[00:00:17] (03CR) 10saper: "> So COUNT(some_field) as FooBar messes up PGSQL? Wow..." [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/98353 (owner: 10saper) [00:00:32] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf6 branch for cherry-picks [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100506 (owner: 10Catrope) [00:06:59] (03CR) 10Mattflaschen: [C: 032] "Bumps to commit fixing the issue." [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99790 (owner: 10Mattflaschen) [00:09:58] (03Merged) 10jenkins-bot: Bump Thanks for bugfix [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99790 (owner: 10Mattflaschen) [00:10:04] (03CR) 10Chad: [C: 032] Tracking category for modules saved with errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99796 (owner: 10Anomie) [00:12:36] (03Merged) 10jenkins-bot: Tracking category for modules saved with errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99796 (owner: 10Anomie) [00:17:16] (03CR) 10Chad: [C: 031] Respect X-Forwarded-For header when present [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/100440 (owner: 10BryanDavis) [00:18:54] (03PS4) 10Krinkle: mediawiki.js: add `mw.track`, imported from VisualEditor [core] - 10https://gerrit.wikimedia.org/r/99547 (owner: 10Ori.livneh) [00:24:20] legoktm, deployed the Thanks fix. [00:24:26] thanks! ;) [00:24:29] Tested on MW.org successfully. [00:25:15] superm401: Yay. [00:30:00] (03CR) 10Krinkle: Make SpecialWatchlist extend SpecialRecentChanges: step 1 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [00:32:49] (03PS1) 10CSteipp: Don't redirects anons to /createSession [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/100508 [00:41:44] (03PS2) 10EBernhardson: [WIP] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [01:09:44] (03CR) 10Parent5446: "Not really necessary, but consider this:" [core] - 10https://gerrit.wikimedia.org/r/100478 (owner: 10Aaron Schulz) [01:14:46] (03CR) 10Parent5446: "Do we have a usage report on this? This is actually one of the few user preferences I've enabled myself. If it seems like I'm the only one" [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas) [01:16:22] (03CR) 10Parent5446: "I'm not entirely sure, since the code is all over the place. I'll remove my -1 for now since, as you said, it's not like this is making Sa" [core] - 10https://gerrit.wikimedia.org/r/100165 (owner: 10Umherirrender) [01:18:21] (03CR) 10Parent5446: [C: 032] Status::getHTML should actually return HTML [core] - 10https://gerrit.wikimedia.org/r/99798 (owner: 10Anomie) [01:21:29] (03Merged) 10jenkins-bot: Status::getHTML should actually return HTML [core] - 10https://gerrit.wikimedia.org/r/99798 (owner: 10Anomie) [01:25:43] if ( $user->isLoggedIn() && $user->getOption( 'betafeatures-popup-disable' ) ) { [01:25:43] $out->addModules( 'ext.betaFeatures.popup' ); [01:25:43] } [01:25:52] marktraceur: ^ should that be a !$user->getOption? [01:25:57] ...hm [01:25:58] or is that preference poorly named? [01:25:58] Yeah [01:26:04] legoktm: That...explains so much [01:26:24] time to git blame! [01:26:32] It's almost certainly my fault [01:26:38] (03PS1) 10BryanDavis: Allow applicants to specify 3 wikis [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/100517 [01:27:33] Yup [01:27:44] I'm gonna go and hit my head against a wall a few times [01:27:52] https://github.com/wikimedia/mediawiki-extensions-BetaFeatures/commit/4dad4ba9fdd4e54d6f6c226b503c265c7466f6d6 [01:27:53] erk [01:28:02] *nod* [01:28:24] legoktm: Please fix it, swear loudly at me in the commit message, and I'll merge it while swearing loudly at me in real life and my CR message [01:28:27] commit incoming [01:29:24] Something like "Fix stupid mistake by Mark\n\nGod FUCKING damn it, Mark, you fucked it up, god damn everything, shit." should teach me a lesson [01:29:39] Then again maybe we could be sane. [01:29:58] (03PS1) 10Krinkle: mediawiki.js: Minor clean up of comments and code [core] - 10https://gerrit.wikimedia.org/r/100518 [01:32:12] (03PS1) 10Legoktm: Load popup script in same place as personal url [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100519 [01:32:15] marktraceur: ^ [01:32:49] marktraceur: the weird thing is that when this gets deployed its going to show up for everyone [01:33:49] legoktm: Yeah, that was the idea initially [01:33:55] That everyone gets poked once [01:33:58] But only once [01:34:00] right [01:34:07] (03CR) 10Parent5446: [C: 031] Move code to load User data from cache out of loadFromId [core] - 10https://gerrit.wikimedia.org/r/100371 (owner: 10Matthias Mullie) [01:34:14] legoktm: We'll see an uptake in enrollment, maybe :P [01:34:20] I should probably tell Fabrice. [01:34:23] but now most people have already seen it, so its going to be weird that 2 weeks later people are getting annoyed [01:36:05] Yeah [01:36:46] and when I say most people, I mean most people who will complain about things :P [01:39:53] legoktm: I'm going to poke the product team collectively before doing anything. [01:40:01] sure [01:40:38] Sent [01:44:31] (03CR) 10Bsitu: Remove markread action from the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84870 (owner: 10Bsitu) [01:45:28] (03CR) 10Bsitu: "-2 has been removed! :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [01:48:54] anomie|away, RoanKattouw: either of you around? trying to figure out why bsitu's email didn't make it to the mediawiki-api list [01:49:10] legoktm: Did he send to -api or -api-announce ? [01:49:12] -api [01:49:17] http://lists.wikimedia.org/pipermail/wikitech-l/2013-November/073178.html was sent to wikitech fine [01:49:27] it probably should get forwarded on to -announce anyways [01:49:33] I can't find it on http://lists.wikimedia.org/pipermail/mediawiki-api/2013-November/thread.html [01:49:50] Interesting [01:49:56] Maybe he's not subscribed? [01:50:07] Let me log into the moderation interface [01:50:12] thanks [01:50:37] Here we go [01:50:43] Lots of interesting stuff in the moderation queue [01:50:45] Mostly spam [01:51:23] ...from 2012. Oops [01:52:25] haha [01:52:34] There's a bug in mailman, I thought. [01:52:43] That if you CC a list you're not subscribed to, it gets silently bounced or something? [01:52:46] Maybe. [01:52:53] it's a setting [01:53:12] Feature, not a bug, then. ;-) [01:53:48] I'm trying to figure out if we should keep the "justify paragraphs" MediaWiki user preference. [01:53:50] wait, i think i got that wrong anyways, i thought you mean if you're getting mail delivered that you sent to the list yourself [01:53:52] If anyone has thoughts. [01:54:09] legoktm: Went through the mod queue but his message isn't in there either [01:54:10] mailman has stupid behavior, was my point. [01:54:17] Don't know why it didn't come through, CC to mediawiki-api tends to work [01:54:33] Gloria: Similarly, Bcc to the list is forbidden, I found one that was held for that reason [01:54:34] huh [01:54:39] it seems the problem here was more that nobody logged in since 2012 to moderate it [01:54:47] Right. mailman has arcane and stupid features and bugs. [01:54:58] mutante: Yes that too [01:55:04] RoanKattouw: well, could you forward the one he sent to wikitech to -announce? I'm going to merge the change now [01:55:05] that is also a per-list setting [01:55:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=52810 [01:55:21] legoktm: Will do. -announce actively rejects messages that aren't from me or Sam [01:55:34] Did the API change? [01:55:56] Gloria: Echo's? yes [01:56:00] RoanKattouw: thanks! [01:56:10] Ah. [01:56:15] legoktm: He's linking to merged code. What are you merging now? [01:56:34] errr, it wasn't merged [01:56:44] oh [01:56:47] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEcho.git/40ea204cdc64e4e6f4d3589e261baa5476e420e0/api%2FApiEchoMarkRead.php wasn't merged? [01:57:01] right [01:57:02] The name of the HEAD commit there is "Localisation updates", that's almost certainly merged [01:57:09] so we split the API module into 2 [01:57:27] that moved out the code into the new module, I'm merging the code that removes the deprecated code from the old module [01:57:31] Aha [01:57:32] which is the actual breaking change [01:57:34] I can haz link? [01:57:42] It's conventional to link to the breaking change [01:57:42] http://lists.wikimedia.org/pipermail/mediawiki-api/2013-November/thread.html [01:57:44] er [01:57:45] https://gerrit.wikimedia.org/r/#/c/84870/ [01:57:49] ^ that one [01:57:52] stupid clipboard [01:59:48] Sent [02:00:00] thanks :D [02:00:28] (03CR) 10Legoktm: [C: 032] "Email sent to mediawiki-api-announce courtesy of Roan: http://lists.wikimedia.org/pipermail/mediawiki-api-announce/2013-December/000046.ht" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84870 (owner: 10Bsitu) [02:00:38] (03Merged) 10jenkins-bot: Remove markread action from the read API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84870 (owner: 10Bsitu) [02:03:34] (03PS1) 10Werdna: Add function for checking options arrays for SQL injection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100521 [02:11:23] (03CR) 10MZMcBride: "Discussion is ongoing on bug 52810. Divining how many people have this user preference enabled, and from that, how many people would care " [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas) [02:19:37] (03PS1) 10Bsitu: Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 [02:19:51] ori-l: I'm replying to your bait on wikitech-l. [02:20:24] (03CR) 10Bsitu: [C: 04-2] Add flow specific exceptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [02:35:37] Gloria: minification harms the open web? :D [02:35:41] give me a break [02:35:52] it's standard practice [02:36:31] Surely it has some costs. [02:36:37] We know that it does. [02:37:03] That particular bullet point is probably too vague to be meaningful. [02:37:09] the bandwidth saved is worth the lose that may come from not being able to read the JS well [02:37:16] *loss [02:37:28] Is it worth the extra developer time debugging race conditions? :-) [02:37:31] yes [02:37:34] Okay. [02:37:48] Then I guess it's a pretty quick conversation. ;-) [02:38:00] Though I think others might still disagree. [02:38:09] Or perhaps there's a compromise to be had. [02:38:20] Though I feel like any compromise would just make debugging even worse. [02:38:22] page size is pretty important for regions with poor connectivity [02:38:45] developers can deal with it [02:39:06] You don't be happen to be in ops by chance? :D [02:39:09] Gloria: I think you may want to follow-up your e-mail with "verbose HTML etc. harm the Open Web more by limiting participation to those that are bandwidth-blind". [02:39:22] James_F: exactly [02:39:36] Gloria: I happen to want to serve more people in the world [02:39:59] if that's at the expense of a bit of dev time, so be it [02:40:15] Ryan_Lane: We have Zero and MobileFrontend, of course. [02:40:26] And I'm not sure serving more people is directly relevant here. [02:40:53] except that performance directly impacts a person's willingness to stay on a site [02:41:07] James_F: We could probably eliminate a few Wikimedia Foundation pet extensions and make up for the minification loss. [02:41:19] I'm in agreement there [02:41:26] for the love of fuck let's kill article feedback [02:41:37] A slimmer site that's easier to debug... [02:41:40] Gloria: I agree. First to go is Monobook. [02:41:45] Haha [02:41:45] Gloria: Next, AFT. [02:41:50] and yes, please kill of all those fucking skins [02:41:55] Jared is trying. [02:41:59] He got wontfixed twice today. [02:42:00] Gloria: Next, red links rendered as "Foo ?". [02:42:05] Gloria: Next, … [02:42:06] hands Ryan a Cologne_Blue [02:42:15] and let's kill off the bullshit preferences that ruin people's caching [02:42:18] mutante: Unsupported skin. :-) [02:42:30] Ryan_Lane: mwalker and I are writing an RfC for January about that. [02:42:31] James_F: heh,ok:) [02:42:44] James_F: I was like halfway through redoing preferences when that storm came through today. [02:42:56] mutante: The only supported skins right now are vanilla Vector and Monobook. [02:43:00] Gloria: So? [02:43:03] you know the nice thing about not being an employee anymore is that I can speak my mind relatively freely :) [02:43:05] I swear to God I got like 12 different e-mails about bug 58223 changing dependencies or blockers or whatever. [02:43:15] I memorized the number I had so many. [02:43:25] James_F: So Jared's going to derail my efforts. [02:43:28] If he keeps up. [02:43:34] Slow, incremental change. [02:43:38] That's how you play the game. [02:43:43] Ryan_Lane: You know the nice thing about speaking my mind freely? I get to still be an employee. ;-) [02:43:48] Gloria: It's not a game. [02:43:49] Not clueless tracking tickets, Jesus. [02:44:02] James_F: That's what the losers say, yes. [02:44:12] James_F: good luck there [02:44:38] Ryan_Lane: It's worked so far. [02:44:54] I'll rest easy this evening knowing that the analytics team is on the case re: user prefs. [02:44:55] Gloria: You think I'm losing your games? :-) [02:44:57] Hehhh. [02:44:57] people don't like hearing certain truths [02:45:12] James_F: I think you, of all people, should recognize the importance of incremental change. [02:45:17] Hello, VisualEditor. [02:45:29] The prefs changes are no different in that regard. [02:45:42] Gloria: You think VisualEditor isn't undergoing incremental change? [02:45:45] * James_F is confused. [02:46:00] I think pushing changes to users is hard work. [02:46:02] And requires patience. [02:46:18] the user prefs thing is a joke [02:46:32] Not arbitrary deadlines. Not trying to move the mountain overnight. [02:46:33] the prefs that break caching should either be done client side, or they should simply be removed [02:46:43] and we can just take the hit from the .000001% of broken users [02:46:44] I don't think too many breaking caching. [02:46:52] Gloria: like 4-5 do [02:46:59] Working on it. :-) [02:47:04] I have a list. [02:47:55] https://bugzilla.wikimedia.org/showdependencytree.cgi?id=52807&hide_resolved=0 [02:48:14] Ryan_Lane: We're planning to do a mix of the former and the latter. [02:48:42] Public planning? [02:48:42] Ryan_Lane: Cached Parsoid HTML served straight to the user, with CSS for implementation of styling changes. [02:49:05] Gloria: Yes. [02:49:11] Sounds fun. [02:50:11] Ryan_Lane: https://gerrit.wikimedia.org/r/#/c/98276/ and the like are awaiting code review and merging. ;-) [02:54:03] Gloria: https://www.mediawiki.org/wiki/Parsoid/Roadmap#Use_Parsoid_HTML_for_all_page_views_.5Bhard.2C_stretch_goal.2C_Q4.5D refers, etc. [02:54:03] Gloria: Expect an RfC some time soon. [02:54:04] James_F: You mean like https://www.mediawiki.org/wiki/Requests_for_comment/Core_user_preferences [02:54:04] ? [02:54:04] Oh, you mean about Parsoid? [02:54:04] Yeah, I think that'll be controversial. [02:54:04] It's about the death of wikitext, isn't it? [02:54:14] sounds more like the death of the PHP parser [02:54:31] There are competing ideas and schools of thought, I think. [02:55:28] In some ways, it makes sense to eliminate wikitext. Converting to HTML and back is a bit insane. [02:55:33] OTOH, wikitext built Wikipedia. [02:55:39] Gloria: Nothing to do with the death of wikitext. [02:55:54] Gloria: You're confused between "use output of Parsoid" and "don't have Parsoid". [02:56:06] Gloria: That's a separate (and much later) discussion to have. [02:56:16] And frankly I'm not sure we'll ever want to get rid of wikitext. [02:56:17] I like your speed. :-) [02:56:42] Switching read mode to Parsoid means re-building our entire read mode pipeline. [02:56:46] Different ways for skins to work. [02:56:50] wants really easy table creation [02:56:52] Different ways for preferences to be applied. [02:57:01] then i can actually tell people to not use google docs [02:57:01] mutante: You can sort-of do it now with rich paste. [02:57:09] mutante: But yeah. :-( [02:57:21] mutante: (Also, that's VisualEditor, not Parsoid; Parsoid supports tables just fine.) [02:57:49] James_F: yea, to be honest it seems easier to write them in HTML than in wikitext [02:57:52] Looking forward to the RFC. [02:58:00] and what i do is paste HTML into parsoid :) [02:58:02] I've been thinking about an RFC reporter. [02:58:04] and then use the result [02:58:15] Where it would post new RFCs and RFCs that have changed status every week. [02:58:27] I wonder if I can get a GCI student to write that. [02:58:31] Specifically, we're talking about doing ESI compositing of every page; the HTML of the page /contents/ is stored, but the skinning is done on-request. No anons getting served cached pages. [02:59:07] s/stored/cached to hell and back in Varnish/g :-) [02:59:52] heh, i like that. This page has been cached to hell and back via cp1123. [03:00:16] mutante: Bingo. :-) [03:03:40] (03CR) 10Aaron Schulz: [C: 032] Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [03:05:08] Oh my. [03:05:59] Another one bites the dust. [03:06:41] (03Merged) 10jenkins-bot: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [03:07:37] Gloria: Congrats. :-) [03:08:13] Nice :) [03:10:00] * Gloria did very little. [03:10:10] It's shocking how long that preference lasted. [03:10:36] Thank you, though. I'm excited to have a modern preferences section. [03:10:46] Slowly killing the clutter will definitely help. [03:17:06] (03CR) 10Tim Starling: "> Yes, VitaliyFilippov is correct, the javascript disabling is just an option. In some cases the small extra ui complexity of the ajax stu" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/57041 (owner: 10Njw) [03:31:54] (03CR) 10Catrope: [C: 032] API: Add image sizes and default user prefs to meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/100409 (owner: 10Anomie) [03:34:54] (03Merged) 10jenkins-bot: API: Add image sizes and default user prefs to meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/100409 (owner: 10Anomie) [04:07:34] Is anyone else having problems with the +10 links in the Gerrit diff (for showing additional context lines)? [04:07:44] I'm using Firefox. [04:07:50] I cleared Cache and Offline Website Data, but it didn't help. [04:08:46] Same problem in Chromium [04:09:11] yeah, those haven't worked for a while I think [04:12:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=58252 [04:12:27] It's a pain [04:13:25] Besides just not being able to see context, you also can't add a comment to a line they haven't changed. [04:19:09] (03CR) 10Tim Starling: [C: 031] "Looks good to me. My only quibble would be that any call of PPFrame::setVolatile(false) is most likely an error — it's hard to imagine a v" [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [04:19:35] superm401: We're fixing the "very large i18n files" issue with https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format if you want a gander. :-) [04:19:59] James_F, is this in reference to the +10 thing/ [04:20:03] ? [04:20:23] superm401: Yes. [04:20:23] My example is actually from wmf-config, but it's a bug in Gerrit regardless. [04:20:32] superm401: Yeah. :-( [04:20:52] superm401: The most frequent instance of it in practice is generally i18n files being humonguous. [04:21:28] (03CR) 10Tim Starling: [C: 031] Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 (owner: 10Anomie) [04:21:54] "split by language (en.json, qqq.json, fr.json, etc.)" [04:21:57] Interesting. [04:23:02] (03CR) 10Tim Starling: [C: 031] Mark parser hook output as volatile [extensions/Cite] - 10https://gerrit.wikimedia.org/r/99793 (owner: 10Anomie) [04:26:04] (03PS2) 10Tim Starling: Expose PPFrame::getTitle to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99797 (owner: 10Anomie) [04:26:13] (03CR) 10Tim Starling: [C: 032] Expose PPFrame::getTitle to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99797 (owner: 10Anomie) [04:29:36] (03Merged) 10jenkins-bot: Expose PPFrame::getTitle to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99797 (owner: 10Anomie) [04:30:11] (03PS1) 10Springle: identify LogPager queries for load balancing [core] - 10https://gerrit.wikimedia.org/r/100531 [04:30:33] (03CR) 10Tim Starling: [C: 04-1] Be slightly more user friendly in generate.php. (031 comment) [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/99709 (owner: 10Dr0ptp4kt) [04:53:11] Krinkle: have you seen the new MDN? [05:04:33] (03PS1) 10Springle: Remove problem forced index. Bug 57175. [core] - 10https://gerrit.wikimedia.org/r/100532 [05:10:14] (03CR) 10Aaron Schulz: [C: 032] Remove problem forced index. Bug 57175. [core] - 10https://gerrit.wikimedia.org/r/100532 (owner: 10Springle) [05:10:27] (03PS1) 10Mattflaschen: The core versions include loginstart and loginend. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 [05:10:55] (03CR) 10Werdna: "A couple of issues and some refactoring to do." (0317 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [05:13:11] (03Merged) 10jenkins-bot: Remove problem forced index. Bug 57175. [core] - 10https://gerrit.wikimedia.org/r/100532 (owner: 10Springle) [05:14:43] ori-l: the grey/blue design? That's been in opt-in beta for a few months, got in as soon as I saw the banner for logged-in users. [05:14:45] Quite nice [05:14:51] (03CR) 10Mattflaschen: "With this change, if we save a blank version on all WMF wikis, it won't actually register an edit unless there was previously a non-blank " [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:14:53] few weeks, not months. [05:15:05] is it the default not? [05:15:06] now* [05:15:39] yes [05:15:47] * ori-l sheepishly confesses he never signed up for an account [05:16:04] https://developer.mozilla.org/en-US/profiles/Krinkle [05:16:10] I don't make many edits, but made a few [05:16:36] ori-l: Have you seen the new stackoverflow layout (the top bar) [05:16:45] that one I saw just now [05:17:27] They've improved the notifications interface and added the ability to mark-as-read individual changes to reputation [05:17:33] (e.g. upvote etc.) [05:17:55] They've also made various hidpi improvements [05:18:18] though main logo is still 1:1 [05:18:18] i dig the SO change, too [05:18:34] the stackexchange logo is @2x png :) [05:18:52] It looks weird if you don't have enough contrast. [05:19:07] At normal contrast, I'm okay with it. [05:19:20] * Krinkle is catching up Bruce Willis movies [05:19:21] http://www.imdb.com/title/tt0102266/quotes?item=qt0468279 [05:19:26] Just heard that scene [05:20:11] (03CR) 10Legoktm: "If that's your goal, can't you just check that the page does exist before making the edit to blank it?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:20:51] AaronSchulz: hey, do you have some time to help me debug https://bugzilla.wikimedia.org/show_bug.cgi?id=57464#c12 ? I'm not really sure what could be causing that [05:21:07] Bruce Willis and Damon Wayans make a good comedy duo, too bad they haven't done more together (or did they?) [05:21:26] cya 2morrow [05:21:34] dunno, haven't seen it [05:21:35] cya [05:22:13] legoktm: You're not able to reproduce the issue locally? [05:22:28] No, I just tried and I couldn't [05:22:33] Lame. [05:23:03] er wait [05:23:06] I did reproduce it [05:23:21] Well, I think I did. [05:23:39] I think interwiki prefixes are cached somewhere. [05:23:48] (03CR) 10PleaseStand: [C: 04-1] Be slightly more user friendly in generate.php. (031 comment) [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/99709 (owner: 10Dr0ptp4kt) [05:23:54] Yeah, interwiki cahe [05:24:05] I don't think he means interwiki cache. [05:24:16] That's prefix mapping only, isn't it? [05:24:16] well, my wiki is just using the interwiki table [05:24:21] not .cdb [05:24:59] And even though I deleted the 'wikipedia' row, Title::newFromText( "wikipedia:metawikimedia:Page" )->getInterwiki() returns 'wikipedia' [05:25:28] (03PS8) 10Tholam: Site logo loaded using ResourceLoaderSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [05:25:33] Fun. [05:26:04] (03CR) 10jenkins-bot: [V: 04-1] Site logo loaded using ResourceLoaderSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [05:26:34] (03CR) 10Tholam: "Sorry I've taken so long for an update. I haven't had much free time recently." [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [05:27:58] hmm [05:28:10] Interwiki::fetch uses memcached, but that should be per wiki [05:28:13] (03CR) 10Swalling: [C: 031] "This implementation will make sure we reduce the number of non-null edits when blanking, while keeping the script simple. Plus, this also " [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:28:58] (03CR) 10Mattflaschen: "MaxSem recommended using foreachwiki (https://git.wikimedia.org/blob/operations%2Fpuppet/8159245588a03bc9a037053df6dbc48752a8758f/files%2F" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:29:04] (03CR) 10Legoktm: "Adding the &nocreate= parameter to the API is not simple?" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:29:18] (03CR) 10Legoktm: "to an API request*" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:30:46] oh [05:31:10] that is probably less work than making a trivial change to edit.php [05:33:35] (03CR) 10Mattflaschen: "I wasn't aware of 'nocreate'. Thanks for letting me know." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:33:53] (03CR) 10MZMcBride: The core versions include loginstart and loginend. (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:36:42] (03PS2) 10Mattflaschen: The core versions include loginstart and loginend. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 [05:37:45] (03CR) 10Mattflaschen: "It was unintentional." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [05:39:22] ok, its stored in memcache [05:39:31] but thats for me locally, it should never hit there on a wmf wiki [05:40:37] (03PS3) 10Mattflaschen: Blank signupstart and signupend [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 [05:42:49] (03PS4) 10Mattflaschen: Blank signupstart and signupend [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 [06:21:16] (03PS1) 10Springle: Remove problem forced index. Bug 58256. [core] - 10https://gerrit.wikimedia.org/r/100537 [06:38:37] (03PS2) 10Aaron Schulz: Remove problem forced index. Bug 58256. [core] - 10https://gerrit.wikimedia.org/r/100537 (owner: 10Springle) [06:44:57] (03PS1) 10Ori.livneh: Module storage: randomly choose between Function and $.globalEval [core] - 10https://gerrit.wikimedia.org/r/100542 [06:46:25] (03CR) 10Ori.livneh: "We should be able to revert this patch after it spends a few hours in production." [core] - 10https://gerrit.wikimedia.org/r/100542 (owner: 10Ori.livneh) [06:48:18] (03CR) 10jenkins-bot: [V: 04-1] Module storage: randomly choose between Function and $.globalEval [core] - 10https://gerrit.wikimedia.org/r/100542 (owner: 10Ori.livneh) [06:48:55] heh [06:48:59] jenkins dislikes both: [06:49:01] 06:46:04 resources/mediawiki/mediawiki.js: line 1273, col 29, Missing 'new' prefix when invoking a constructor. [06:49:01] 06:46:04 resources/mediawiki/mediawiki.js: line 1273, col 29, eval can be harmful. [06:49:23] jenkins considered fussy [06:53:51] (03CR) 10IAlex: "This is more a back end change, so I don't think there is anything in this change that should be mentioned in the release notes." [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [06:54:09] (03PS4) 10IAlex: Enhance the destination control parameter of wfDebug() and wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/95356 [06:54:28] (03CR) 10IAlex: "Fixes merge conflict" [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [07:00:09] (03PS2) 10Ori.livneh: Module storage: randomly choose between Function and $.globalEval [core] - 10https://gerrit.wikimedia.org/r/100542 [07:15:01] legoktm: Any luck with the MassMessage bug? [07:21:11] (03CR) 10Siebrand: [C: 04-2] "Overriding strings from core in an extension is not supported in the localisation process." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [07:21:33] (03CR) 10IAlex: "I don't know what the intented nesting was. By looking at the code I supposed it was
." [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [07:21:57] (03PS2) 10IAlex: Fix HTML output arround HTMLForm's submit buttons when in vform [core] - 10https://gerrit.wikimedia.org/r/96704 [07:22:12] (03CR) 10Siebrand: "Have a look at https://gerrit.wikimedia.org/r/#/c/98078/ for a possible solution." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [07:22:39] (03CR) 10IAlex: "Fixes merge conflict" [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [07:33:45] (03PS3) 10EBernhardson: [WIP] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [07:34:20] (03PS4) 10EBernhardson: Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [07:45:05] (03PS6) 10IAlex: Add support for "tabindex" in HTMLFormField subclasses [core] - 10https://gerrit.wikimedia.org/r/62014 [07:45:54] (03CR) 10IAlex: "Fixes merge conflict" [core] - 10https://gerrit.wikimedia.org/r/62014 (owner: 10IAlex) [07:55:23] (03CR) 10Siebrand: [C: 04-1] Add flow specific exceptions (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100524 (owner: 10Bsitu) [08:06:32] (03CR) 10Helder.wiki: Implement keyboard navigation for BookManagerv2 (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [08:29:55] (03CR) 10Netbrain: "It is probably possible to do this, however due to the asynchronous nature of java-script and ajax, this is not a straightforward thing." [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 (owner: 10Netbrain) [09:33:28] (03CR) 10Zfilipin: [C: 04-1] "Do not merge until this is green:" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100382 (owner: 10Zfilipin) [09:33:44] (03CR) 10Zfilipin: [C: 04-1] "Do not merge until this is green:" [selenium] - 10https://gerrit.wikimedia.org/r/100381 (owner: 10Zfilipin) [09:44:02] (03PS1) 10Dan-nl: whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 [09:45:48] (03PS3) 10Netbrain: Added support for execution to be done on client side. This to prevent max execution time error in php. [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 [09:47:32] (03PS2) 10Dan-nl: whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 [09:48:52] (03CR) 10Dan-nl: "added ->escaped() to the wfMessages in MetadataDetectForm::getCopyUploadsDomainsAsList()" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [09:49:03] (03CR) 10Netbrain: "I18N is completed. please verify." [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 (owner: 10Netbrain) [09:51:57] (03PS3) 10Dan-nl: whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 [09:53:10] (03CR) 10Dan-nl: "changed ->escaped() to ->parse()" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [10:12:34] (03CR) 10Siebrand: [C: 04-1] whitelist-instructions (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [10:16:50] (03CR) 10Daniel Kinzler: [C: 031] "Looks like a nice hack to me :)" (031 comment) [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [10:30:08] Hey ! I would like to contribute to your organisation. How should I get started? [10:31:19] !hacker | anubhav908 [10:31:19] anubhav908: http://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [10:35:59] (03PS4) 10Dan-nl: whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 [10:36:39] (03CR) 10Dan-nl: "- addressed siebrand’s inline comment in ps3" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [10:47:37] (03CR) 10Siebrand: [C: 031] whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [10:50:02] Hello everyone, I'm intern of OPW and I'll work with MediaWiki Homepage Redesign. [11:02:51] (03CR) 10Daniel Kinzler: [C: 031] "seems sensible, but havn't tested" [core] - 10https://gerrit.wikimedia.org/r/100154 (owner: 10saper) [11:04:39] (03CR) 10Zfilipin: [C: 04-1] "There is still one deprecation warning left." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [11:13:53] (03CR) 10Zfilipin: Added a test for downloading pdf from a random page (035 comments) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [11:25:20] (03PS1) 10Raimond Spekking: Some more consistency tweaks in preparation for adding extension to translatewiki.net [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100552 [11:33:33] (03CR) 10Siebrand: "@matmarex: Which would you feel comfortable replacing?" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [11:37:54] (03CR) 10Siebrand: "Thanks, Raimond." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100552 (owner: 10Raimond Spekking) [11:37:58] (03CR) 10Siebrand: [C: 032] Some more consistency tweaks in preparation for adding extension to translatewiki.net [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100552 (owner: 10Raimond Spekking) [11:38:04] (03Merged) 10jenkins-bot: Some more consistency tweaks in preparation for adding extension to translatewiki.net [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100552 (owner: 10Raimond Spekking) [11:44:13] Just to confirm. Can anyone tell me if the repository mediawiki/core has the MediaWiki Homepage? [11:45:57] (03CR) 10Helder.wiki: "ZzzzZzz..." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100000 (owner: 10L10n-bot) [12:04:11] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [12:06:48] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [12:09:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/28799 (owner: 10leucosticte) [12:17:06] (03CR) 10Siebrand: "Katie, you write:" [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:17:35] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:20:51] (03PS5) 10Siebrand: Canonicalize text and update docs of messages using 'loginreqlink' [core] - 10https://gerrit.wikimedia.org/r/94414 (owner: 10Bartosz Dziewoński) [12:21:16] (03CR) 10Siebrand: [C: 032] "Fixed YAMC. Now +2 quickly :)." [core] - 10https://gerrit.wikimedia.org/r/94414 (owner: 10Bartosz Dziewoński) [12:25:57] (03Merged) 10jenkins-bot: Canonicalize text and update docs of messages using 'loginreqlink' [core] - 10https://gerrit.wikimedia.org/r/94414 (owner: 10Bartosz Dziewoński) [12:29:07] (03CR) 10Aude: "siebrand: looks like they have been fixed already" [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:29:26] (03CR) 10Aude: Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:29:52] (03CR) 10Siebrand: [C: 031] "@katie: Indeed. Wonderful :)." [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:33:18] (03PS1) 10MarkAHershberger: Restore compatibility with curl < 7.16.2 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/100556 [12:33:48] (03CR) 10MarkAHershberger: [C: 032] Restore compatibility with curl < 7.16.2 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/100556 (owner: 10MarkAHershberger) [12:35:40] (03CR) 10Siebrand: Add test to validate special page aliases (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:38:21] (03Merged) 10jenkins-bot: Restore compatibility with curl < 7.16.2 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/100556 (owner: 10MarkAHershberger) [12:40:42] (03CR) 10Aude: [C: 04-1] "errr i looks like hebrew still fails (e.g. כניסה_/_הרשמה_לחשבון for Userlogin) but don't see that on translatewiki" [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:41:01] siebrand: sorry, cofused [12:41:03] confused* [12:41:20] aude: Hmm? [12:41:26] כניסה_/_הרשמה_לחשבון [12:41:34] still exists in core apparently [12:41:39] not on translatewiki [12:42:09] aude: What's the canonical name for that? [12:42:18] Userlogin [12:42:43] aude: This is what MessagesHe.php has: 'Userlogin' => array( 'כניסה_לחשבון', 'כניסה' ), [12:43:02] oh [12:43:09] aude: https://he.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces|namespacealiases should show what the live wiki has. [12:43:12] i need to rebase [12:43:28] Oops. Let me correct that URL. [12:43:54] yep passes now [12:43:57] aude: Live still has כניסה_/_הרשמה_לחשבון [12:44:14] (03CR) 10Aude: "i needed to rebase" [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [12:44:15] aude: They're lucky it's not the primary, otherwise that would have broken their signup. [12:44:19] (03PS4) 10Aude: Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 [12:44:29] right [12:45:04] aude: They're running 1.23wmf5, and I assume it's resolved in 1.23wmf6 (Thursday?) [12:45:30] aude: So this runs the check over all special page aliases for all languages, right? [12:45:42] it does [12:45:49] aude: That's a very nice validation. Thanks. [12:46:15] it would be nicer if translatewiki would check when the user translates [12:46:23] aude: You informed for a better localisation; I don't have any, other than the i18n linter that doesn't exist yet. [12:46:25] but i am not familiar enough with translatewiki code to do that [12:47:36] aude: SpecialPageAliasesCM class in Translate (ffs/MediaWIkiComplexMessages.php) [12:47:45] k [12:49:57] aude: localisation a few sentences back was supposed to be "location", but I think I can't type anything else any more when it starts with "local". [12:51:45] ok [12:52:25] it's more of a 'system' test but we don't really make such distinction [12:52:31] vs. unit test [12:57:53] Hello everyone. :) [12:58:25] (03CR) 10Phe: "It fix also a failure on safari, at least safari 4.1/5.0" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100407 (owner: 10Tpt) [13:01:13] (03PS1) 10MarkAHershberger: Attempt to fix problems noted in phpcs: https://integration.wikimedia.org/ci/job/mediawiki-core-regression-phpcs-HEAD/3256/console [core] - 10https://gerrit.wikimedia.org/r/100559 [13:01:29] (03CR) 10Nikerabbit: "Should this mention somewhere that this only checks special page aliases for core?" [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [13:02:25] (03PS2) 10MarkAHershberger: Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100559 [13:18:54] (03PS3) 10MarkAHershberger: Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100559 [13:34:42] (03PS1) 10MarkAHershberger: Attempt to fix problems noted in phpcs. [core] - 10https://gerrit.wikimedia.org/r/100561 [13:34:59] (03PS1) 10Tpt: Add tabindex to wpTextbox1 in Page: pages editor [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100562 [13:38:27] (03PS9) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [13:39:21] (03PS1) 10Daniel Kinzler: (bug 47070) check content model namespace on import. [core] - 10https://gerrit.wikimedia.org/r/100563 [13:42:54] (03PS1) 10Shirayuki: i18n: consistency tweaks [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100564 [13:45:48] (03PS2) 10Tpt: Add tabindex to wpTextbox1 in Page: pages editor [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100562 [13:48:15] (03CR) 10Phe: [C: 031] "Ergonomy is really weird w/o this patch" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100562 (owner: 10Tpt) [13:48:54] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100562 (owner: 10Tpt) [13:49:01] (03Merged) 10jenkins-bot: Add tabindex to wpTextbox1 in Page: pages editor [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100562 (owner: 10Tpt) [13:51:05] (03CR) 10Hashar: [C: 032] Update ProofreadPage to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100408 (owner: 10Tpt) [13:54:22] (03Merged) 10jenkins-bot: Update ProofreadPage to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100408 (owner: 10Tpt) [13:59:22] Reedy: around ? [14:00:17] (03CR) 10Phe: [C: 031] Add custom DifferenceEngine for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97210 (owner: 10Tpt) [14:00:55] (03CR) 10Rtdwivedi: [C: 031] Explode ProofreadPageRenderer into smaller not static classes [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 (owner: 10Tpt) [14:03:07] anybody here can say how to kill user without any edits? removeUnsedAccounts.php does not delete a lot of accounts [14:11:40] andre__: how to I mark this task as finished? [14:11:44] https://www.google-melange.com/gci/task/view/google/gci2013/5243150582939648 [14:12:16] zeljkof, by asking the student to mark it as "I'm done with my work, please review it" first [14:12:36] andre__: thanks [14:12:47] (03PS1) 10MaxSem: Fix parameter description to match the actual behavior [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/100567 [14:13:45] (03CR) 10Yuvipanda: [C: 032] "Is more accurate." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/100567 (owner: 10MaxSem) [14:13:47] (03Merged) 10jenkins-bot: Fix parameter description to match the actual behavior [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/100567 (owner: 10MaxSem) [14:30:29] Hello. I want to autoload a JS file in the ULS extension. I see a function addModules in the ULShooks.php file but adding my file to the array doesn autoload it. [14:31:15] !gerrit I748463882c815ad42ff55bd938fcfc895f2205fc [14:31:15] https://gerrit.wikimedia.org/r/#q,I748463882c815ad42ff55bd938fcfc895f2205fc,n,z [14:52:48] Reedy: are you around ? Got some wiki routing issue for beta cluster. Should be covered by https://gerrit.wikimedia.org/r/#/c/100573/ [14:57:36] (03PS1) 10VitaliyFilippov: Use jQuery instead of deprecated addHandler [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/100574 [14:57:55] (03CR) 10VitaliyFilippov: [C: 032 V: 032] Use jQuery instead of deprecated addHandler [extensions/SlimboxThumbs] - 10https://gerrit.wikimedia.org/r/100574 (owner: 10VitaliyFilippov) [15:12:22] (03Abandoned) 10Zfilipin: Released gem version 0.1.14 [selenium] - 10https://gerrit.wikimedia.org/r/100381 (owner: 10Zfilipin) [15:12:42] (03Abandoned) 10Zfilipin: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100382 (owner: 10Zfilipin) [15:13:55] (03PS2) 10Zfilipin: Make it possible to run tests on Cloudbees using PhantomJS [selenium] - 10https://gerrit.wikimedia.org/r/100375 [15:42:55] (03CR) 10Anomie: [C: 031] "Code looks ok. Haven't tested." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/100508 (owner: 10CSteipp) [15:50:28] (03CR) 10Anomie: "> My only quibble would be that any call of PPFrame::setVolatile(false) is most likely an error" [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [15:51:37] (03PS4) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [15:51:39] (03PS3) 10Matthias Mullie: Use addError() to add errors, instead of adding to array ourselves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100387 [15:51:41] (03PS4) 10Matthias Mullie: Introduce tipsy [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98820 [15:54:37] I have problem to remove my bot's watchlists there are more than 190,000 how can I remove them? [15:55:39] (03PS5) 10Matthias Mullie: Introduce tipsy [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98820 [15:58:31] I have problem to remove my bot's watchlists there are more than 190,000 how can I remove them? [16:00:26] wow [16:01:06] there's a JS out there... Nemo_bis probably knows [16:01:26] it is mediawiki's bug [16:01:26] (03PS1) 10Cmcmahon: interim update until login method is shared among repos [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100579 [16:01:36] because bot shouldn't have watch list and [16:01:40] reza1615_: Sure, but there are workaround [16:01:46] s [16:02:40] (03CR) 10Cmcmahon: "I made this change to the Mobile repo some time ago and it did improve the situation with false failures due to login failing" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100579 (owner: 10Cmcmahon) [16:02:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=58277 [16:03:00] reza1615__: Are you logged into the account with a browser? [16:03:06] yes [16:03:16] by chrome [16:03:21] and firefox [16:03:24] it is the same [16:03:30] both of them will carsh [16:03:38] one second [16:04:54] $.post('/wiki/%D9%88%DB%8C%DA%98%D9%87:%D9%88%DB%8C%D8%B1%D8%A7%DB%8C%D8%B4_%D9%81%D9%87%D8%B1%D8%B3%D8%AA_%D9%BE%DB%8C%E2%80%8C%DA%AF%DB%8C%D8%B1%DB%8C%E2%80%8C%D9%87%D8%A7/raw', { wpTitles: '', wpEditToken: mw.user.tokens.get('editToken'), title: 'ویژه:ویرایش فهرست پی‌گیری‌ها/raw' }); [16:04:54] also I tested [16:05:06] in consul but it can not post [16:05:28] mh? [16:05:36] in fa.wiki [16:05:53] (03PS5) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [16:06:47] (03PS3) 10Hashar: Adds some beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [16:06:54] $.post('/wiki/Special:EditWatchlist/raw', { wpTitles: '', wpEditToken: mw.user.tokens.get('editToken'), title: 'Special:EditWatchlist/raw' }); [16:06:59] reza1615_: What erro do you receive? [16:07:19] "Our servers are currently experiencing a technical problem. This is probably temporary and should be fixed soon. Please try again in a few minutes." [16:07:35] is the watchlist downsizing? [16:07:56] it has 194,000 pages [16:08:09] so it shows time out in consul [16:08:43] reza1615_: Has the size decreased after you ran the post= [16:08:46] * ? [16:08:55] no [16:09:06] it coudn't post [16:09:57] even through it times out something in the backend will happen [16:10:10] I'm just not sure how far, as I'm not into that code much [16:10:47] $.post('/wiki/Special:EditWatchlist/raw', { wpTitles: '', wpEditToken: mw.user.tokens.get('editToken'), title: 'Special:EditWatchlist/raw' }); Object {readyState: 1, setRequestHeader: function, getAllResponseHeaders: function, getResponseHeader: function, overrideMimeType: function…} POST https://fa.wikipedia.org/wiki/Special:EditWatchlist/raw 500 (Internal Server Error) load.php?debug=false&lang=fa&modules=jquery%2Cm [16:10:57] that's obvious [16:11:27] but the question is whether it alters the DB in some way [16:12:50] when I run the bot [16:12:58] (03CR) 10BryanDavis: [C: 031] Enhance the destination control parameter of wfDebug() and wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [16:13:01] every month it [16:13:14] do Retrieving watchlist for wikipedia:fa via API and it takes many time! [16:13:58] mh, first of all you should disable automatic watching in the bot's user preferences and/ or your bot software [16:14:52] (03CR) 10BryanDavis: [C: 031] whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [16:15:00] how? [16:15:11] Which of these? [16:15:34] disable automatic watching in pywikipedia [16:15:42] ewk, dunno... not my area [16:16:32] reza1615_: Is there a bug filed about this? [16:16:43] A shell user can clear out the watchlist, presumably. [16:16:44] yes [16:16:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=58277 [16:17:01] https://bugzilla.wikimedia.org/show_bug.cgi?id=58257 [16:17:27] how can i find shell user? [16:18:15] I commented on 58277. [16:18:39] reza1615_: Why did you file two bugs? [16:18:48] Never mind. [16:18:51] closing both now [16:18:53] they are diffrent isue [16:19:18] the first one is request for clearing [16:19:24] hoo: I don't think 58277 is a duplicate. Though perhaps invalid. [16:19:42] the second is request to have number limitation [16:20:01] by sure most of bot owners should have this problem [16:20:14] They don't. [16:20:20] Why are you checking your watchlist? [16:20:24] spicailly wikidata bots becuase they makes pages [16:20:42] i don't check :) bot check it every month [16:20:45] :( [16:20:46] Why? [16:20:53] Retrieving watchlist for wikipedia:fa via API [16:20:58] Why? [16:21:01] it's pywikipedia [16:21:11] Okay, but why is retrieving the bot's watchlist? [16:21:16] is it * [16:21:19] What's the point? [16:21:40] may be api force the bot [16:21:54] hoo: You trampled my bug summary. :-( [16:22:01] Gloria: uh? [16:22:13] Sorry :P [16:22:19] (03CR) 10Jhall: [C: 031] interim update until login method is shared among repos [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100579 (owner: 10Cmcmahon) [16:22:28] :P [16:22:55] hoo why close it? [16:23:05] reza1615_: We already have bugs for these topics [16:23:06] It can be other user's bug [16:23:15] Why is pywikipedia retrieving the bot's watchlist? [16:23:29] Not that the bot should have a huge watchlist, but that's a separate issue... [16:23:47] why bot should have watch list? [16:23:56] All users have a watchlist. [16:23:57] reza1615_: Sorry? [16:23:57] it mediawiki's bug [16:24:06] We don't need one bug per user, but one per problem [16:24:23] hoo: If he wants his bot's watchlist cleared by a shell user, he'll need a separate bug. [16:24:30] Gloria: Ah, yes [16:24:41] Anyway, it's sort of a MediaWiki bug. [16:24:41] Pity so few people have shell access [16:24:53] Pity so much still requires shell access. ;-) [16:24:56] We should have a hard limit on watched pages IMO [16:25:05] I suggested that. [16:25:07] In the bug. [16:25:15] (03CR) 10Anomie: Changed TIME_ONLY to NAME_AND_TIME_ONLY in FileRepo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100478 (owner: 10Aaron Schulz) [16:25:19] Even without a limit, why is a huge watchlist a problem? [16:25:24] Just don't open it. :-) [16:25:47] Or have a script try to retrieve it. [16:25:59] huge watch list [16:26:14] is difficult to manage but if we have limitation [16:26:24] we can manage it easyly [16:26:34] You mean pagination, I think. [16:26:43] Like (50 | 100 | 500). [16:26:46] or we can say if the list is more than 20,000 it shows the limitaion [16:26:54] Or truncation. [16:26:54] yes [16:26:58] That's not really useful if you have close to 200k entries [16:26:59] Which means just stopping the list at a certain point. [16:27:06] unless you want to spend the rest of your life sorting [16:27:14] hoo: It's certainly better than trying to load 200,000 on a single request. [16:27:23] But I agree that pagination is probably not the answer. [16:27:34] Gloria: I still don't see why one would need to see 200k patches one watched [16:27:47] s/patches/pages/ [16:27:51] I thought we had a limit to watchlist size? [16:27:53] They wouldn't. That's obviously excessive. [16:27:58] But some people have 10,000 pages watched. [16:27:59] (03CR) 10Anomie: [C: 031] "Code looks ok. Haven't tested." [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/99527 (owner: 10Aaron Schulz) [16:28:03] MaxSem: Clearly not. ;-) [16:28:10] bah [16:28:19] I think Domas used to complain. [16:28:26] Because you could have related long-running queries. [16:28:51] ask springle if it's still the case? [16:28:52] It's rather easy to watch a huge amount of pages... [16:29:16] (03PS1) 10Hashar: mwconf: $wg settings for djvu [integration/jenkins] - 10https://gerrit.wikimedia.org/r/100582 [16:29:20] The long-running queries are orthogonal, I think. The root issue is huge watch lists. [16:29:24] watchlists [16:29:26] (03CR) 10Hashar: [C: 032] mwconf: $wg settings for djvu [integration/jenkins] - 10https://gerrit.wikimedia.org/r/100582 (owner: 10Hashar) [16:29:29] (03Merged) 10jenkins-bot: mwconf: $wg settings for djvu [integration/jenkins] - 10https://gerrit.wikimedia.org/r/100582 (owner: 10Hashar) [16:29:33] or we can have a key for drainage [16:29:35] reza1615_, bot name and wiki? [16:29:45] rezabot [16:29:48] A reset key? [16:29:49] fa.wiki [16:29:51] Meh. [16:29:54] (03CR) 10Hashar: "$wgDjvu* configuration being added with https://gerrit.wikimedia.org/r/100582" [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [16:30:02] yes [16:30:04] I think we had one of those previously. [16:30:09] Special:EditWatchlist/clear or something. [16:30:21] but now it dosen't work [16:30:38] "EditWatchlist" has the word "twat" in it. [16:31:55] (03PS4) 10Hashar: tests: beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [16:32:04] I tested Special:EditWatchlist/clear [16:32:11] and it shows the same error [16:32:37] Gloria, can you imagine what deletion of 200k rows can do with replicatuion? that would require hjobs or some similar PITA [16:33:09] MaxSem: Delete them in 5k packs :P [16:33:28] even 5k is too much, 500 is recommended [16:33:38] Apparently SQL doesn't like DELETE with LIMIT. [16:33:47] it does [16:33:48] I've never understood why deletion fucked up replication so badly. [16:34:06] This came up in the context of user_properties or something. [16:34:44] I have 9 trillion bugspam e-mails. [16:34:53] also we should set all bot groups unchecked all watchlist properties by default [16:34:56] https://bugzilla.wikimedia.org/show_bug.cgi?id=52777#c2 [16:35:14] reza1615_: That requires modifying the user preference when the bot is promoted. [16:35:22] And retroactively changing current bots. [16:35:26] It's possible, just tedious. [16:35:42] yes but it should be by system [16:36:24] we could write a simple extension for that :P [16:36:37] sure [16:37:06] reza1615_, done [16:37:15] yes [16:37:23] do you remove them ? [16:37:57] thanks:))))))))))))) [16:38:25] please add a possiblity for other bot runers [16:39:06] most of them they don't know why their bot stop more than 20 min for login ! [16:39:18] thats the case [16:39:50] (03PS1) 10Hashar: mwconf: wgDjvuToXml -> wgDjvuToXML [integration/jenkins] - 10https://gerrit.wikimedia.org/r/100583 [16:39:58] (03CR) 10Hashar: [C: 032] mwconf: wgDjvuToXml -> wgDjvuToXML [integration/jenkins] - 10https://gerrit.wikimedia.org/r/100583 (owner: 10Hashar) [16:40:01] (03Merged) 10jenkins-bot: mwconf: wgDjvuToXml -> wgDjvuToXML [integration/jenkins] - 10https://gerrit.wikimedia.org/r/100583 (owner: 10Hashar) [16:41:50] (03PS5) 10Hashar: tests: beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [16:41:53] (03CR) 10MZMcBride: "Eloquence: I'm not sure (gently) exposing new users to diffs and wikitext is a bad thing. We can always show a diff _and_ jump down to the" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 (owner: 10Aude) [16:42:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [16:43:20] (03CR) 10jenkins-bot: [V: 04-1] tests: beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [16:43:55] (03PS1) 10Cmcmahon: preference no longer exists per Bug 52809 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100584 [16:49:37] (03PS6) 10Tpt: tests: beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 [16:50:15] (03CR) 10Tpt: "Fix test after a change in normalization of the text layer" [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [16:50:53] FYI the Engineering Community team is starting its monthly IRC meeting at #wikimedia-meetbot in 10 minutes. More info at https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2013-12-10 [16:53:20] (03PS6) 10Matthias Mullie: Introduce tipsy [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98820 [17:00:17] andre__, ping, #wikimedia-meetbot [17:01:24] (03CR) 10Jhall: [C: 032] preference no longer exists per Bug 52809 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100584 (owner: 10Cmcmahon) [17:02:21] mutante: Hey. I copied you on https://bugzilla.wikimedia.org/show_bug.cgi?id=52329 [17:02:54] (03Merged) 10jenkins-bot: preference no longer exists per Bug 52809 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100584 (owner: 10Cmcmahon) [17:06:15] (03CR) 10Jhall: [C: 032] interim update until login method is shared among repos [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100579 (owner: 10Cmcmahon) [17:06:19] (03PS2) 10Cmcmahon: interim update until login method is shared among repos [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100579 [17:08:34] (03CR) 10Jhall: [C: 032] interim update until login method is shared among repos [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100579 (owner: 10Cmcmahon) [17:09:55] (03Merged) 10jenkins-bot: interim update until login method is shared among repos [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100579 (owner: 10Cmcmahon) [17:11:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/100563 (owner: 10Daniel Kinzler) [17:12:52] Gloria: try again and reload bug:) [17:13:37] mediawiki-vagrant q: I need to use this with a rh client. Any hints? [17:13:46] users are different [17:13:57] some package names are [17:14:09] any hints? [17:14:11] (03CR) 1001tonythomas: "Should I add something more to the patch here ?" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas) [17:14:41] !log running gerrit reviewer-counts cron command manually for bug 52329 [17:14:41] Wrong channel, try again. [17:14:56] hate [17:15:07] love [17:16:42] hexmode: you're right:) [17:16:54] mutante: \o/ [17:18:00] (03PS1) 10Cicalese: Updated to use Html class and eliminated usage of unnecessary wiki globals. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100587 [17:18:03] mutante: now, if only I could find a puppet/vagrant guru I'd have a real reason to love. [17:18:49] hexmode: in theory puppet should save us from exactly that.. the OS difference .. i don't know about vagrant though [17:18:57] hexmode: you want ori or yuvipanda i think [17:19:47] (03CR) 10Cicalese: [C: 032 V: 032] Updated to use Html class and eliminated usage of unnecessary wiki globals. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100587 (owner: 10Cicalese) [17:19:54] hexmode: you rang? [17:20:49] A wild ori-l appears. [17:21:19] ori-l: ! [17:21:20] ori-l: mutante just fixed https://gerrit.wikimedia.org/reviewer-counts.json [17:21:34] we love mutante [17:21:38] ori-l: If you still want to relocate it, now's the time. Otherwise, it'll be considered a stable API endpoint. [17:21:46] (03CR) 10Gergő Tisza: [C: 031] whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [17:21:51] ori-l: yes, I'm looking for help with vagrant-mediawiki and rh [17:21:56] any clues? [17:22:10] i never cared about the location, just the way the query was run [17:22:18] hexmode: rh? [17:22:21] RedHat [17:22:34] redhat [17:22:36] yeah [17:22:53] ori-l: Fair. I cared about the location. [17:23:07] oh, um, puppet supports rpm as a package provider [17:23:16] this means that package { 'foo': } will use RPM rather than apt [17:23:19] why does my patch https://gerrit.wikimedia.org/r/#/c/99171/ shows Can merge: No , even though it got a +2 from jenkins-bot ? [17:23:21] but the package names are different in many cases [17:23:24] (03PS1) 10Anomie: Add access to Language::fetchLanguageNames [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100589 [17:23:28] tonythomas01: needs to be rebased [17:23:52] ok. I need to upload a new patchset with git pull --rebase and all ? [17:24:02] ori-l: right, but there appear to be some checks for apt-specific stuff. Any pointers on how to change that? [17:24:03] There's usually a "rebase" button you can press. [17:24:05] tonythomas01: ^ [17:24:21] Gloria: rebase button ? [17:24:23] Tobi_WMDE: are you here ? [17:24:45] Gloria: I found that. Thanks :) [17:25:38] hexmode: you'd start by replacing the box in the Vagrantfile with one from http://www.vagrantbox.es/ [17:25:45] hexmode: then vagrant up, things will fail, then [17:25:52] Gloria: It shows ' The change could not be rebased due to a path conflict during merge [17:25:55] ' [17:25:58] Lame. [17:26:04] You need to manually rebase, then. [17:26:07] It involves git voodoo. [17:26:07] (03CR) 10Hoo man: [C: 031] "Looks good at first glance :)" [core] - 10https://gerrit.wikimedia.org/r/97742 (owner: 10Aude) [17:26:24] zeljkof: I would like to ask you if I am on the right track, I have made the delete_item.feature [17:26:24] Gloria: ok [17:26:40] vandrew_: hi [17:27:00] vandrew_: could you please remind me what are you working on? [17:27:04] hexmode: you'll have to edit the puppet source to do things like this: https://github.com/puppetlabs/puppetlabs-apache/blob/master/manifests/params.pp [17:27:32] zeljkof: https://bugzilla.wikimedia.org/show_bug.cgi?id=57844 [17:27:35] vandrew_: I remember, wikibase tests :) [17:27:40] greg-g: Can I get a lightning deploy window today for a LocalisationUpdate fix that I'm about to write? [17:27:52] if $::osfamily == 'redhat' { $package = 'foo' } etc [17:28:00] hexmode: it won't be fun, sadly [17:28:09] heh [17:28:13] dang [17:28:37] zeljkof: what do you think about this one http://pastebin.com/0X7W46az is about deleting an item [17:28:38] good thing I got a sucker paying for this [17:29:30] vandrew_: do you know how to push code to gerrit? [17:29:30] hexmode: i'll be checking my mailbox for the royalties check [17:29:30] ori-l: yeah, I've got a box already, even started making my own for people who will be using this [17:29:42] vandrew_: that is how we do code review [17:29:46] * ori-l is kidding [17:29:56] yes [17:30:03] git review should do it [17:30:07] vandrew_: great, yes [17:30:10] but I still have to work on the rest of them [17:30:13] ori-l: when you start putting your mailing addy out there, I'll *start* to think about it [17:30:16] vandrew_: please push code to gerrit [17:30:23] ok [17:30:23] probably wont last long [17:30:39] vandrew_: you can amend the commit and push again, when you have more code [17:30:53] vandrew_: this is short documentation https://www.mediawiki.org/wiki/Gerrit/Getting_started [17:31:16] vandrew_: could you please ping me in #wikimedia-qa? it has less traffic [17:31:46] (03PS1) 10UltrasonicNXT: Add convenience function User::isInGroup( $group ) [core] - 10https://gerrit.wikimedia.org/r/100590 [17:32:21] hexmode: as a maintainer i'm not supposed to tell you this but you may find it easier to just fork and create a redhat-specific branch [17:32:27] (03PS5) 10BryanDavis: whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [17:32:41] (03CR) 10BryanDavis: [C: 032] whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [17:32:55] (03Merged) 10jenkins-bot: whitelist-instructions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100548 (owner: 10Dan-nl) [17:33:28] puppet is a limited language, and making things cross-distro-compatible usually means cluttering manifests with bazillion ifs [17:33:33] making them virtually unreadable [17:33:43] (see what i did there?) [17:34:20] but if you want to give it a shot i'm open to reviewing / merging if it works well on rh [17:34:27] (03PS2) 10UltrasonicNXT: Add convenience function User::isInGroup( $group ) [core] - 10https://gerrit.wikimedia.org/r/100590 [17:34:54] ori-l: yeah, was kind of looking like it needed to be forked. :( [17:35:09] but it is good to have a 2nd opinion [17:35:28] (03CR) 10UltrasonicNXT: "(sorry for patchset 1, I accidentally commited something I didn't mean to)" [core] - 10https://gerrit.wikimedia.org/r/100590 (owner: 10UltrasonicNXT) [17:36:05] hexmode: it won't be so bad; you'll probably find generic analogs for the stuff that is rh-specific (setting up apache, php, etc.) on https://forge.puppetlabs.com/ (but beware, the quality of things there is very uneven) [17:36:20] and the mediawiki-specific puppet configs should be mostly portable, since they don't use apt anyway [17:38:07] you could also just have vagrant provision an ubuntu/debian virtual machine on the redhat target host and hope nobody notices :P [17:39:21] (03PS3) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 [17:39:50] heh, crafty [17:39:57] (03CR) 10jenkins-bot: [V: 04-1] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [17:41:39] (03PS4) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 [17:42:16] (03CR) 10jenkins-bot: [V: 04-1] Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [17:49:26] (03PS1) 10Catrope: Update the README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/100594 [17:51:39] (03PS1) 10Cicalese: Elminated unnecessary statics. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100598 [17:53:39] (03CR) 10Cicalese: [C: 032 V: 032] Elminated unnecessary statics. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100598 (owner: 10Cicalese) [17:55:19] (03Abandoned) 10EBernhardson: Merge branch 'gerrit/98995/3' into 2013/flow/db-storage-abstraction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99036 (owner: 10Werdna) [17:56:46] (03PS2) 10EBernhardson: Allow ObjectManager to fall back to querying backend storage when no index is available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 (owner: 10Werdna) [17:57:00] (03CR) 10EBernhardson: "PS2: rebased onto master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 (owner: 10Werdna) [17:59:36] (03PS3) 10EBernhardson: Allow ObjectManager to fall back to querying backend storage when no index is available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 (owner: 10Werdna) [18:00:51] (03CR) 10EBernhardson: "PS3: create/catch exception specific to no index existing" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 (owner: 10Werdna) [18:01:10] (03CR) 10Siebrand: [C: 032] Update the README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/100594 (owner: 10Catrope) [18:01:12] (03Merged) 10jenkins-bot: Update the README [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/100594 (owner: 10Catrope) [18:01:20] (03PS5) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 [18:05:13] (03PS6) 1001tonythomas: Removed "Enable section editing via [edit] links" from preferences [core] - 10https://gerrit.wikimedia.org/r/99171 [18:08:05] dan-nl: hey, looking good on the test beta upload from David! :) [18:08:09] also, just clicking around, this image: http://commons.wikimedia.beta.wmflabs.org/wiki/File:Betula_utilis_D.Don_var._jacquemontii_-Spach-_Winkl.-E_-_Royal_Botanic_Garden_Living_Collection_-_19851857.jpeg has a link to the record at http://www.europeana.eu/portal/record/11616/5B5309342B4693D9A838A53F4FA7F113E30946B8.html which is a 404 :/ [18:08:15] dan-nl: is that a known thing? [18:08:53] hey greg-g, yes, the only issue we've run into thus far is the job throttle we set-up [18:09:27] on that 404, i'll let david know [18:09:37] awesome [18:09:48] (03PS1) 10Anomie: Use jquery.spinner when console is pending [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100599 [18:10:18] greg-g: do you know anything about the job delay and why it's turned off? [18:10:40] (03CR) 10Bartosz Dziewoński: "Siebrand, I would *love* to investigate this some time, but unfortunately the time is not now. As I said, I won't block if you find someon" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [18:10:57] no, first I've heard of it [18:11:16] k, i'll look more closely and chat with Aaron|home about it [18:11:37] I hear bd808 knows about it, but not if he knows what to do about it :) [18:11:42] we'll need to sort out the right combination. that botanical upload stopped because > 1000 media file batch jobs were in the queue [18:12:14] ah, okay, i'll chat with bd808 about it once i find the method i'm looking for … thanks [18:13:21] (03PS3) 10Zfilipin: WIP Make it possible to run tests on Cloudbees using PhantomJS [selenium] - 10https://gerrit.wikimedia.org/r/100375 [18:14:14] * bd808 wonders what he's supposed to know about job delay [18:14:33] (03PS1) 10Cicalese: Put class in separate file. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100600 [18:14:34] (03PS4) 10Zfilipin: WIP Make it possible to run tests on Cloudbees using PhantomJS [selenium] - 10https://gerrit.wikimedia.org/r/100375 [18:19:25] (03CR) 10Cicalese: [C: 032 V: 032] Put class in separate file. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100600 (owner: 10Cicalese) [18:19:26] bd808: jobReleaseTimestamp [18:20:04] is that available for use? i looked earlier and it wasn't … but that was about a mont hago [18:20:09] *month ago [18:20:28] (03PS1) 10EBernhardson: Dony allow empty titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100601 [18:20:36] (03PS2) 10EBernhardson: Dont allow empty titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100601 [18:22:52] (03CR) 10Bartosz Dziewoński: "What would you need this for? I think you should almost never have to care about groups at all, but about permissions instead ($user->isAl" [core] - 10https://gerrit.wikimedia.org/r/100590 (owner: 10UltrasonicNXT) [18:23:20] bd808: think i found what i found a month ago … in JobQueue.php line 173 supportsDelayedJobs() not implemented [18:23:29] any idea why it hasn't been implemented? [18:24:29] dan-nl: I think it's a feature flag based on the backend. JobQueueRedis supports it [18:24:59] so in theory it should work on beta? [18:25:24] and on production? [18:25:47] (03PS9) 10Hoo man: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [18:26:09] dan-nl: It looks like yes. The default queues in production and labas are redis based [18:26:18] thedj_: thedj[work]: Around? [18:26:27] k, i'll write a patch and we can test on beta ... [18:28:13] (03PS10) 10Hoo man: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [18:30:44] (03CR) 10Hoo man: "Changed the hint message to 'Tip: You can use the left and right arrow keys to navigate between the tabs in the tabs list.' per the sugges" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [18:31:50] (03CR) 10Hoo man: [C: 031] "Graham: "Sounds good to me! On IE, JAWS says the name of the tab twice, but that's alright."" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [18:32:11] (03PS1) 10EBernhardson: Dont throw javascript errors with invalid anchor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100603 [18:32:22] (03CR) 10Bartosz Dziewoński: " is an inline element and
is a block one, so nesting them in that order rarely if ever makes sense." [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [18:40:29] addshore, hi, am I supposed to publish this GCI task? http://www.google-melange.com/gci/task/view/google/gci2013/5824806058459136 [18:40:35] (03CR) 10Spage: [C: 031] "looks right to me" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100603 (owner: 10EBernhardson) [18:41:46] (03PS1) 10EBernhardson: Filter the display of content via a hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100604 [18:45:23] (03PS2) 10Dr0ptp4kt: Be slightly more user friendly in generate.php. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/99709 [18:45:38] (03CR) 10Dr0ptp4kt: Be slightly more user friendly in generate.php. (032 comments) [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/99709 (owner: 10Dr0ptp4kt) [18:46:10] (03PS2) 10Hoo man: Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 [18:47:11] (03PS1) 10Aude: Update Wikibase and related extensions [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100606 [18:47:14] (03CR) 10Hoo man: "Add the CSS conditionally, per Daniel" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [18:54:47] (03CR) 10Bartosz Dziewoński: Preferences: Improve accessibility of the JS tabs of Preferences (035 comments) [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [19:01:02] (03PS8) 10Manybubbles: Implement per-namespace cross wiki searching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [19:01:19] (03PS9) 10Manybubbles: WIP:Implement per-namespace cross wiki searching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [19:02:55] yuvipanda: What's your magical git-review-free way of pushing to gerrit? I'm having some trouble getting a commit on the right branch. [19:04:05] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase and related extensions [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100606 (owner: 10Aude) [19:05:32] marktraceur: git push gerrit HEAD:refs/for/ [19:05:35] where is usually 'master' [19:05:49] and will likely be something else in your case [19:06:17] (you might also need to substitute 'origin' for 'gerrit', depending on your configuration) [19:06:45] marktraceur: there should be a file .gitreview with a line like defaultbranch=production (in my case) ,that you can change [19:06:53] MatmaRex: https://gerrit.wikimedia.org/r/#/c/78640/10/resources/mediawiki.special/mediawiki.special.preferences.js [19:06:57] and git review should be ok then [19:07:05] What do you mean by "mis-indentation", it looks good in gerrit [19:07:19] hoo: there are spaces instead of tabs [19:07:28] ah :D [19:07:29] Ok [19:07:35] Going to follow up [19:07:36] hoo: you can toggle "Show Tabs" in the "Preferences" [19:07:47] hoo: and change tab width to something non-default [19:07:58] that makes such mistakes painfully obvious :) [19:08:58] that would annoy me to much, I guess [19:11:21] MatmaRex: I was trying to get it on wmf/1.23wmf6, so yeah [19:11:27] mutante: The default branch is fine [19:11:35] Argh, no new changes. [19:13:00] MatmaRex, mutante: http://paste.marktraceur.info/1009/raw/phork0.txt [19:14:35] MatmaRex: The style you asked about, it's the same as mw-jump [19:14:41] * MatmaRex wants a Thinkpad T420s [19:14:46] marktraceur: dunno, sorry. :( [19:14:47] marktraceur: is it in master? [19:14:49] hoo: okay [19:14:50] Bah. [19:14:50] should we annote that or directly use mw-jump over there [19:14:51] aude: Yeah [19:14:58] cherry pick button! [19:15:00] in gerrit [19:15:06] aude: It's not a clean cherry-pick [19:15:07] can you use it? [19:15:08] oh [19:15:12] darn! [19:15:30] marktraceur: on an related note, the order of footer lines looks messed up [19:15:41] MatmaRex: That's because I did it manually [19:15:51] okay [19:15:56] MatmaRex: Should we annotate that or directly use mw-jump over there? [19:16:05] annotate what? [19:16:06] ...oh [19:16:14] MatmaRex: OK, doing that apparently worked [19:16:26] MatmaRex: that it's a copy of mw-jump from the shared skin CSS [19:16:30] doing what now :o [19:16:47] hoo: what i meant was to slap a comment on it saying somehting along the lines of /* Hide, but keep accessible for screen-readers */ [19:16:54] (this i copied from vector's screen.less) [19:17:08] It's not from vector, it's from shared.css [19:17:12] hey marktraceur [19:17:16] still want to do that? [19:17:23] so in theory we could also use mw-jump and I wonder whether that would be smart [19:17:52] (03CR) 10UltrasonicNXT: "Well I've found I've had to use the code in it, so I wondered why there wasn't a function..." [core] - 10https://gerrit.wikimedia.org/r/100590 (owner: 10UltrasonicNXT) [19:17:53] yuvipanda: Do what? [19:18:06] marktraceur: push without git-review [19:18:08] Oh [19:18:11] oh, I see MatmaRex has told you [19:18:13] Yeah, but I figured it out [19:18:32] hoo: sounds scary, let's not [19:18:39] heh, ok :) [19:24:03] yuvipanda: is grrrit not gate & submit? [19:24:20] aude: nope. nobody bothered to set it up... yet :) [19:24:23] ok [19:24:31] Hrm [19:24:31] and I'm unfamiliar with our jenkins setup [19:24:38] aude: have any patches for it? [19:24:54] i can probably fix jenkins [19:24:55] aude: I can grant you access to the tools on toollabs if you want :) [19:24:56] yuvipanda: I can hear you staring at me. You can just stop it right now. [19:25:01] i have access :) [19:25:08] going to deploy it [19:25:11] aude: ah, okay :D sorry, must've forgot :) [19:25:11] Oh, that could work too. [19:25:32] marktraceur: that thought had not crossed my mind until right this moment... :P [19:26:15] * marktraceur returns to sitting quietly in the corner [19:26:22] i don't have to restart? [19:26:31] just update git? [19:26:45] qgil: ill take a lok at it now [19:26:47] *look [19:27:09] (03CR) 10Anomie: [C: 032] Don't redirects anons to /createSession [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/100508 (owner: 10CSteipp) [19:27:12] aude: you do have to restart [19:27:13] (03Merged) 10jenkins-bot: Don't redirects anons to /createSession [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/100508 (owner: 10CSteipp) [19:27:18] aude: check out Grrrit-wm page in wikitech [19:27:25] i am [19:27:34] it doesn't say anything about restart for deploy [19:27:41] so i assume not needed [19:27:52] oh [19:28:02] (03PS3) 10Aude: Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 (owner: 10Hoo man) [19:28:12] ok, needs restart [19:28:21] aude: yeah, it does. let me edit the page [19:28:38] aude: dammit, I can't edit it (2factor auth, phone is dead). Can you? [19:28:43] qgil: I am not sure who wrote the task but it seems reasonable :) [19:28:58] (03CR) 10Aaron Schulz: "That can easily be bolted on later by making NAME_AND_TIME_ONLY have the value 3 and NAME/TIME 1 and 2 respectively." [core] - 10https://gerrit.wikimedia.org/r/100478 (owner: 10Aaron Schulz) [19:29:15] addshore, sure, just undocumented. Think of a student landing in Wikimedia for the first time. [19:29:35] Heh, Indeed, I will try and add a bit more blub to it in the morning :) [19:29:48] thanks addshore [19:29:55] (I thought it was you) [19:30:06] (03CR) 10Chad: WIP:Implement per-namespace cross wiki searching (034 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [19:30:08] (03PS11) 10Hoo man: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [19:30:11] (03CR) 10Hoo man: Preferences: Improve accessibility of the JS tabs of Preferences (035 comments) [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [19:30:31] (03PS2) 10Aaron Schulz: Changed TIME_ONLY to NAME_AND_TIME_ONLY in FileRepo [core] - 10https://gerrit.wikimedia.org/r/100478 [19:30:33] ok it worked [19:30:42] (03CR) 10Hoo man: "Fixed various style things (per MatmaRex)." [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [19:30:51] (03CR) 10Aaron Schulz: Changed TIME_ONLY to NAME_AND_TIME_ONLY in FileRepo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100478 (owner: 10Aaron Schulz) [19:30:57] aude: sweet! :D thanks for the patch! [19:31:24] despite uncertainty about restart, the instructions are easy [19:31:33] (03CR) 10Hoo man: [C: 031] "Restoring +1 from PS10" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [19:31:45] * aude can update  [19:31:46] anomie: I can always rebase https://gerrit.wikimedia.org/r/#/c/99738/ later to change the redirect key behavior, but I don't want to mix that in with this [19:31:50] aude: thanks! :) [19:32:14] aude: I think the 'restart' section used to === and hence under 'deployment' and somehow that got lost [19:32:44] Aaron|home: I still think it's odd to have it use different keys in the result depending on the flag. I'd just merge the two patches. [19:33:06] sometimes it has to be restarted unrelated to deploy [19:33:14] own section is fine, but i made it clear [19:33:47] (03CR) 10EBernhardson: [C: 032] Add function for checking options arrays for SQL injection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100521 (owner: 10Werdna) [19:33:53] anomie: I don't want to deal with the https://gerrit.wikimedia.org/r/#/c/99738/ stuff now [19:34:03] * Aaron|home already spent way too much time on this [19:34:05] aude: ok [19:34:06] (03CR) 10EBernhardson: [C: 032] Dont throw javascript errors with invalid anchor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100603 (owner: 10EBernhardson) [19:34:34] I can do it differently with the flag since it doesn't break any callers [19:35:13] (03CR) 10EBernhardson: [C: 032] Small collapser CSS tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100420 (owner: 10Matthias Mullie) [19:35:49] (03CR) 10EBernhardson: [C: 032] Get rid of unused file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100389 (owner: 10Matthias Mullie) [19:35:54] (03Merged) 10jenkins-bot: Add function for checking options arrays for SQL injection [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100521 (owner: 10Werdna) [19:36:10] (03Merged) 10jenkins-bot: Dont throw javascript errors with invalid anchor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100603 (owner: 10EBernhardson) [19:36:29] (03Merged) 10jenkins-bot: Small collapser CSS tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100420 (owner: 10Matthias Mullie) [19:37:46] ^d: https://www.mediawiki.org/wiki/Gerrit/Project_ownership#aarcos_.2B2_for_MultimediaViewer would be nice to get done soon [19:37:56] (03Merged) 10jenkins-bot: Get rid of unused file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100389 (owner: 10Matthias Mullie) [19:39:35] (03CR) 10Aaron Schulz: [C: 032] Add access to Language::fetchLanguageNames [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100589 (owner: 10Anomie) [19:40:47] (03PS1) 10Dan-nl: job-queue-delay [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100617 [19:41:02] greg-g: can I futz with collection again quickly? I want to get Jeff to extract a temp file for me generated by a good revision of the code (to compare it against a bad revision) [19:41:34] (03Merged) 10jenkins-bot: Add access to Language::fetchLanguageNames [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100589 (owner: 10Anomie) [19:43:25] mwalker: should be ok, reedy looks pretty much done [19:43:30] No I'm not [19:43:32] Shits broken [19:43:37] oh well then [19:43:41] mwalker: nope, not now [19:43:54] gotcha [19:44:40] greg-g: if Reedy finishes before 1300; can I do it? [19:44:51] mwalker: yeah [19:44:56] *thumbs up* [19:45:04] bd [19:45:24] Reedy: please ping me when things are unbroken [19:46:27] (03PS10) 10Manybubbles: WIP:Implement per-namespace cross wiki searching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [19:47:04] (03CR) 10Krinkle: [C: 04-1] Link "You have new messages" to user talk diff (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 (owner: 10Aude) [19:47:52] all the feedback! [19:48:02] thanks krinkle :) [19:51:36] (03CR) 10BryanDavis: [C: 032] job-queue-delay [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100617 (owner: 10Dan-nl) [19:51:41] (03Merged) 10jenkins-bot: job-queue-delay [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100617 (owner: 10Dan-nl) [19:53:51] (03CR) 10Anomie: Changed TIME_ONLY to NAME_AND_TIME_ONLY in FileRepo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100478 (owner: 10Aaron Schulz) [19:54:56] (03CR) 10EBernhardson: Make header use *ActionPermissions (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 (owner: 10Matthias Mullie) [19:54:56] Krinkle: hey :) Siebrand was wondering whether we lint json files. He filled a bug for it https://bugzilla.wikimedia.org/show_bug.cgi?id=58279 [19:55:01] Krinkle: not sure whether jshint does it [19:55:14] (03PS1) 10Reedy: Pass $title parameter to getCredits() call [core] - 10https://gerrit.wikimedia.org/r/100619 [19:56:30] (03PS2) 10Reedy: Pass $title parameter to getCredits() call [core] - 10https://gerrit.wikimedia.org/r/100619 [19:56:40] (03PS1) 10Reedy: Pass $title parameter to getCredits() call [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100620 [20:06:15] (03CR) 10Reedy: [C: 032] Pass $title parameter to getCredits() call [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100620 (owner: 10Reedy) [20:07:14] (03PS11) 10Manybubbles: Implement per-namespace cross wiki searching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [20:09:43] (03Merged) 10jenkins-bot: Pass $title parameter to getCredits() call [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100620 (owner: 10Reedy) [20:09:46] (03CR) 10Umherirrender: "Caused I8edbdfe615f848963e3bea47dac99d1abd64c7f7" [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/97086 (owner: 10Chad) [20:10:32] (03CR) 10Umherirrender: "See I102e9dcdc1b26a02082fa7e52bfd2ed42a15afa0" [core] - 10https://gerrit.wikimedia.org/r/100619 (owner: 10Reedy) [20:10:49] (03CR) 10Manybubbles: [C: 04-1] "Can't update submodule:" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/100483 (owner: 10Chad) [20:10:52] (03CR) 10Aaron Schulz: [C: 032] identify LogPager queries for load balancing [core] - 10https://gerrit.wikimedia.org/r/100531 (owner: 10Springle) [20:14:06] (03Merged) 10jenkins-bot: identify LogPager queries for load balancing [core] - 10https://gerrit.wikimedia.org/r/100531 (owner: 10Springle) [20:14:22] (03PS3) 10UltrasonicNXT: Allow the removal of various features [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 [20:16:25] (03CR) 10Umherirrender: "Only looked at the code, no meaning about the need." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/100590 (owner: 10UltrasonicNXT) [20:16:53] (03PS1) 10Manybubbles: Stop 'store'ing fields [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100625 [20:19:03] (03CR) 10UltrasonicNXT: "Well it's not very pretty, but that's what I have to end up with... :/" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [20:26:25] (03CR) 10Aaron Schulz: [C: 032] Remove problem forced index [core] - 10https://gerrit.wikimedia.org/r/100537 (owner: 10Springle) [20:26:42] (03CR) 10Reedy: "I'm not 100% sure about this as the fix...." [core] - 10https://gerrit.wikimedia.org/r/100619 (owner: 10Reedy) [20:27:30] (03PS1) 10Aude: Update Wikibase, revert patch to enable use of parser cache for wikidata [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100628 [20:27:53] Reedy: ^ [20:28:15] (03CR) 10Umherirrender: "Another solution is to add to the result, like &redirects= does and give the canonical name as normal title in the " [core] - 10https://gerrit.wikimedia.org/r/100388 (owner: 10Anomie) [20:30:17] (03Merged) 10jenkins-bot: Remove problem forced index [core] - 10https://gerrit.wikimedia.org/r/100537 (owner: 10Springle) [20:35:11] Reedy: greg-g https://gerrit.wikimedia.org/r/#/c/100628/ [20:36:56] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, revert patch to enable use of parser cache for wikidata [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100628 (owner: 10Aude) [20:37:05] thanks [20:39:21] (03CR) 10Hashar: [C: 031] "Seems good as a beginning." [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [20:42:08] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100636 (owner: 10L10n-bot) [20:44:58] (03CR) 10Aaron Schulz: [C: 032] Deleting a page and then immediately create-protecting it caused a PHP Fatal error [core] - 10https://gerrit.wikimedia.org/r/48435 (owner: 10Owyn) [20:48:56] (03PS1) 10Bsitu: Add Flow [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100671 [20:50:39] (03Merged) 10jenkins-bot: Deleting a page and then immediately create-protecting it caused a PHP Fatal error [core] - 10https://gerrit.wikimedia.org/r/48435 (owner: 10Owyn) [20:53:01] (03PS1) 10Bsitu: Add Flow [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100672 [20:53:27] (03CR) 10Aaron Schulz: [C: 032] API: Add iiprop=canonicaltitle [core] - 10https://gerrit.wikimedia.org/r/100388 (owner: 10Anomie) [20:54:08] Reedy: when you get time, the multiversion router is broken for non-pedia wiki on beta cluster :D [20:54:41] Reedy: the project in en.wiktionary.beta.wmflabs.org is not taken in account and is always 'wikipedia' so the earlier domain ends up mapping to 'enwiki' database :D [20:54:44] patch at https://gerrit.wikimedia.org/r/#/c/100573/ :-] [20:54:59] might want to do that tomorrow though [20:58:03] anomie: is https://gerrit.wikimedia.org/r/#/c/99738/ ok to merge then? [20:58:28] (03CR) 10Bsitu: [C: 032] Add Flow [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100671 (owner: 10Bsitu) [20:58:40] (03CR) 10Bsitu: [C: 032] Add Flow [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100672 (owner: 10Bsitu) [20:58:50] Aaron|home: I don't see any problem with it. I don't know what bawolff was getting at though. [20:59:29] ^d: ping [21:00:18] * gwicke wonders whether it is possible to rename one of our git repos [21:00:54] (03PS3) 10UltrasonicNXT: Add convenience function User::isInGroup( $group ) [core] - 10https://gerrit.wikimedia.org/r/100590 [21:01:27] <^d> gwicke: Renaming? /me shudders [21:01:50] (03CR) 10Bsitu: [C: 04-2] Add Flow [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100671 (owner: 10Bsitu) [21:01:51] <^d> If it has review history we want to retain, it's a huge manual pain in the rear. [21:02:03] (03CR) 10Bsitu: [C: 04-2] Add Flow [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100672 (owner: 10Bsitu) [21:02:06] ^d: it is not used yet [21:02:13] alternative is delete & create new [21:02:28] mediawiki/services/parsoid/node_modules -> mediawiki/services/parsoid/deploy [21:03:02] <^d> Ah, yeah that'll be easy then. [21:03:12] <^d> In that case it's easier just to nuke & recreate. [21:03:44] ^d: could you do that for this repo? [21:04:25] <^d> Yeah, second. [21:04:37] ^d: awesome, thanks! [21:06:17] (03CR) 10Isarra: [C: 032 V: 032] "Merging this so it actually will get tested when next it has to be used? Yes I am horrible this is horrible but I really have no better id" [tools/grabbers] - 10https://gerrit.wikimedia.org/r/89146 (owner: 10Isarra) [21:08:31] (03Merged) 10jenkins-bot: API: Add iiprop=canonicaltitle [core] - 10https://gerrit.wikimedia.org/r/100388 (owner: 10Anomie) [21:09:56] <^d> gwicke: Done. New repo created & inherits ACLs from mediawiki/services/parsoid [21:11:26] ^d: perfect, thanks! [21:11:30] <^d> yw [21:11:43] the old one can be nuked [21:12:02] (03PS1) 10Cscott: Add font support for Malayalam script; also add a test case. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100675 [21:12:03] (03PS1) 10Cscott: Add Taamey Frank CLM font for Hebrew. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100676 [21:12:04] (03PS1) 10Cscott: Replace Taamey Frank with Linux Libertine for Hebrew. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100677 [21:15:07] <^d> gwicke: One step ahead of you :p [21:15:32] ^d, sweet ;) [21:15:57] is https://git.wikimedia.org/summary/?r=mediawiki/services/parsoid/node_modules cached? [21:16:27] (03CR) 10Chad: [C: 031] "I'm wondering if we could just turn it on by default. If people find it annoying we can always turn it back off :)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100392 (owner: 10Manybubbles) [21:16:46] <^d> gwicke: Yeah. [21:16:50] <^d> Can't remember for how long. [21:17:18] k, does not really matter [21:17:54] (03CR) 10Bsitu: [C: 032] Add Flow [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100671 (owner: 10Bsitu) [21:18:11] (03CR) 10Bsitu: [C: 032] Add Flow [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100672 (owner: 10Bsitu) [21:19:10] who [21:19:24] <^d> me! [21:21:04] isnt bsitu on IRC ? [21:21:25] got some exception on beta cluster with Flow @ master [21:21:33] (03CR) 10Mattflaschen: "> Overriding strings from core in an extension is not supported in the localisation process." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/100534 (owner: 10Mattflaschen) [21:21:45] (03Merged) 10jenkins-bot: Add Flow [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100671 (owner: 10Bsitu) [21:21:46] <^d> hashar: -tech and -operations. [21:21:50] ahh [21:21:51] <^d> /whois says [21:21:52] <^d> :) [21:21:53] thx [21:21:56] <^d> yw [21:22:10] should have filled a bug against git/gerrit component *giggles* [21:22:23] <^d> Heh [21:23:19] (03Merged) 10jenkins-bot: Add Flow [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100672 (owner: 10Bsitu) [21:23:22] RoanKattouw: I added your advice to bsitu to deploy new extensions on all branches in use to https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Case_1d:_new_extension [21:23:33] spagewmf: Thanks, will review in a minute [21:25:03] (03PS1) 10EBernhardson: Revert "Get rid of unused file" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100681 [21:25:23] (03CR) 10EBernhardson: [C: 032] Revert "Get rid of unused file" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100681 (owner: 10EBernhardson) [21:25:36] (03Merged) 10jenkins-bot: Revert "Get rid of unused file" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100681 (owner: 10EBernhardson) [21:27:46] (03CR) 10Manybubbles: "Clean clone fixed it." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/100483 (owner: 10Chad) [21:28:43] Reedy: Are files like http://download.wikimedia.org/mediawiki/1.22/mediawiki-1.22.0.tar.gz.sig in version control somewhere or otherwise backed up? [21:28:51] Or only through dumps.wm.o mirroring? [21:28:55] They're not in version control [21:29:04] I've no idea if wmf back it up as misc stuff [21:29:06] apergos: ^^ [21:29:06] not just the .sig file, I mean the distrubutions in general. [21:30:37] (03PS1) 10Bsitu: Update Flow to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100682 [21:33:16] (03PS1) 10Bsitu: Update Flow to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100683 [21:33:48] (03CR) 10Bsitu: [C: 032] Update Flow to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100682 (owner: 10Bsitu) [21:37:21] (03PS1) 10Dan-nl: add-url-error-info [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100684 [21:37:31] (03CR) 10Bsitu: [C: 032] Update Flow to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100683 (owner: 10Bsitu) [21:37:38] Reedy: I was asking because I need a place to publish oojs releases (currently at github-pages, http://krinkle.github.io/oojs/releases/ ) [21:37:57] and download.wikimedia.org seems like the right place, but not sure. [21:38:21] (03Merged) 10jenkins-bot: Update Flow to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100682 (owner: 10Bsitu) [21:38:34] (03CR) 10Aaron Schulz: [C: 04-1] Create block log entries on HideUser blocks too (031 comment) [core] - 10https://gerrit.wikimedia.org/r/49234 (owner: 10Liangent) [21:38:42] oojs requires compilation/building, right now we publish them to the npmjs repository, but that one can only be easily accessed through the npm protocol, not over plain http. [21:39:21] of course there's a small risk that people might misuse these as a cdn, so there's a concern as well as to whether or not we want to host it at download.wikimedia.org [21:39:46] perhaps we could do that gihub does with their action=raw (force content-type text/plain, so that it can't be used as a cdn, download or plain-view only0 [21:40:29] (e.g. https://raw.github.com/jquery/qunit/master/addons/phantomjs/runner.js in a script tag doesn't work in most browsers) [21:41:00] (03Merged) 10jenkins-bot: Update Flow to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100683 (owner: 10Bsitu) [21:41:36] Krinkle, can you re-review https://gerrit.wikimedia.org/r/#/c/83217/ when you have a chance? [21:41:55] (03PS2) 10BryanDavis: add-url-error-info [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100684 (owner: 10Dan-nl) [21:42:03] (03CR) 10BryanDavis: [C: 032] add-url-error-info [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100684 (owner: 10Dan-nl) [21:42:11] (03Merged) 10jenkins-bot: add-url-error-info [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100684 (owner: 10Dan-nl) [21:42:34] spagewmf: Sweet, looks good [21:42:50] thx [21:43:58] (03CR) 10Chad: [C: 032] Stop 'store'ing fields [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100625 (owner: 10Manybubbles) [21:44:04] (03Merged) 10jenkins-bot: Stop 'store'ing fields [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100625 (owner: 10Manybubbles) [21:44:34] (03PS1) 10Matthias Mullie: Get rid of unused file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100686 [21:47:17] (03PS1) 10Aaron Schulz: Set root job information for purge jobs to avoid excess work [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/100687 [21:50:50] (03CR) 10Chad: "Looking good now, just seeking clarification on part of the commit summary." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [21:53:45] (03CR) 10Owyn: "This was a minor fix, but thanks for following up on it!" [core] - 10https://gerrit.wikimedia.org/r/48435 (owner: 10Owyn) [21:59:07] (03CR) 10Manybubbles: Implement per-namespace cross wiki searching (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:01:43] ^d: any chance to look at https://gerrit.wikimedia.org/r/#/c/98959/ ? [22:02:06] (03CR) 10Manybubbles: "Comments I forgot to publish earlier, now published for posterity." (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:02:35] Reedy: Hm.. no https on download.wikimedia.org (or dumps.wikimedia.org) [22:02:46] I'll file a bug [22:02:46] (03PS2) 10Manybubbles: Update Elastica to 0.90.7 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/100483 (owner: 10Chad) [22:03:03] (03CR) 10Manybubbles: [C: 032 V: 032] "Verified locally with Cirrus' regression suite." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/100483 (owner: 10Chad) [22:03:51] <^d> Aaron|home: The only real difference from before is the fallback if you don't specify wikiId, right? [22:04:28] yeah, so certain callers have time to be updated [22:06:03] <^d> *nod* Sounds reasonable. [22:06:16] (03CR) 10Chad: [C: 032] filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/98959 (owner: 10Aaron Schulz) [22:09:22] (03Merged) 10jenkins-bot: filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/98959 (owner: 10Aaron Schulz) [22:11:42] (03CR) 10Chad: "I don't have any objections to this anymore, +1 lgtm" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:11:48] (03CR) 10Chad: [C: 031] Implement per-namespace cross wiki searching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:12:33] <^d> manybubbles: If you're set, pull the trigger and let's get this on beta. [22:13:04] ^d: well I'm about 20 minutes from stopping to go make dinner. [22:13:12] I can merge it and it'll end up on beta but won't be configured [22:13:26] <^d> I'll play with the config for beta. [22:13:34] sweet, I'll merge [22:14:06] <^d> Actually, config's already live. [22:14:07] (03CR) 10Manybubbles: [C: 032] Implement per-namespace cross wiki searching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:14:10] <^d> I pre-configured it the other day. [22:14:12] (03Merged) 10jenkins-bot: Implement per-namespace cross wiki searching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:14:23] <^d> When I split commonswiki_file off. [22:14:26] (03PS1) 10Legoktm: Add "nocreate" and "createonly" options to edit.php [core] - 10https://gerrit.wikimedia.org/r/100691 [22:14:33] superm401: ^ [22:14:41] cool. Well, it'll show up then when that merges [22:14:49] double of everything in both wikis unless we reindex [22:15:03] (03CR) 10jenkins-bot: [V: 04-1] Add "nocreate" and "createonly" options to edit.php [core] - 10https://gerrit.wikimedia.org/r/100691 (owner: 10Legoktm) [22:15:28] erg [22:15:57] (03PS2) 10Shirayuki: i18n: consistency tweaks [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100564 [22:16:06] <^d> manybubbles: Having a mode to just update the external index is kind of nice. [22:16:11] legoktm, cool, let me test. [22:16:14] <^d> It'd be nice to not have to fully reindex for that. [22:16:22] probably, yeah [22:16:33] ^d: you could build one pretty quick, I think [22:16:39] <^d> Yeah, I'll poke it this evening. [22:16:39] (03PS7) 10Aaron Schulz: tests: beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [22:16:40] (03CR) 10Shirayuki: "rebased" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100564 (owner: 10Shirayuki) [22:16:41] <^d> Shouldn't be hard. [22:18:09] (03PS2) 10Legoktm: Add "nocreate" and "createonly" options to edit.php [core] - 10https://gerrit.wikimedia.org/r/100691 [22:19:48] (03PS1) 10Dan-nl: add-tmp-path-info [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100692 [22:22:03] (03CR) 10BryanDavis: [C: 032] add-tmp-path-info [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100692 (owner: 10Dan-nl) [22:22:14] (03Merged) 10jenkins-bot: add-tmp-path-info [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100692 (owner: 10Dan-nl) [22:23:51] (03CR) 10Aaron Schulz: [C: 032] tests: beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [22:25:40] (03PS3) 10Shirayuki: i18n: consistency tweaks [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100564 [22:26:50] (03Merged) 10jenkins-bot: tests: beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [22:28:40] (03PS1) 10Cmcmahon: login still failing occasionally in IEs [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100694 [22:29:26] (03PS4) 10Shirayuki: i18n: consistency tweaks [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100564 [22:30:53] (03CR) 10Cmcmahon: "for example: https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_10/340/testReport/juni" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100694 (owner: 10Cmcmahon) [22:31:25] (03PS1) 10Aaron Schulz: Update FSRepo to avoid the deprecated FileBackend construction style [core] - 10https://gerrit.wikimedia.org/r/100695 [22:34:30] (03CR) 10Aaron Schulz: [C: 032] Use jquery.spinner when console is pending [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100599 (owner: 10Anomie) [22:36:19] (03Merged) 10jenkins-bot: Use jquery.spinner when console is pending [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100599 (owner: 10Anomie) [22:36:42] (03CR) 10Aaron Schulz: "The line:" [core] - 10https://gerrit.wikimedia.org/r/99676 (owner: 10saper) [22:40:56] (03PS4) 10Krinkle: [WIP] resourceloader: Refactor module links output [core] - 10https://gerrit.wikimedia.org/r/95463 [22:42:01] (03PS1) 10CSteipp: Update CentralAuth to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100698 [22:43:34] (03Abandoned) 10BryanDavis: Respect X-Forwarded-For header when present [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/100440 (owner: 10BryanDavis) [22:44:27] legoktm, your patch looks good. :) [22:44:34] woot [22:44:34] I tested all the scenarios. Is there anyone else you want to review? [22:44:38] If not, I can merge. [22:44:43] not really, go for it :) [22:47:19] (03PS1) 10Aude: Update Wikibase, update memcached key [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100701 [22:48:03] Reedy: greg-g sorry one more thing whenever there is open time (e.g. after flow stuff) [22:48:06] ^ [22:48:18] forgot to put that in our branch [22:51:38] (03CR) 10Mattflaschen: [C: 032] "Looks good. I tested the following scenarios, and they all behave as they should:" [core] - 10https://gerrit.wikimedia.org/r/100691 (owner: 10Legoktm) [22:52:47] legoktm, looks like I'm still going to have to use a script, though. [22:52:57] why? [22:53:21] Since we also want to blank signup(start|end) if the corresponding login(start|end) exists, even if signup(start|end) doesn't. [22:53:32] Since it's a tranclusion (or intclusion or whatever it's called). [22:54:11] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/22cf03ac9ac393a5cec476dc710a3d8e77747d35/languages%2Fmessages%2FMessagesEn.php#L1221 [22:54:23] So basically if either signupstart or loginstart exists, blank signupstart. [22:54:29] I'm working on adapting your script, now. [22:55:15] (03Merged) 10jenkins-bot: Add "nocreate" and "createonly" options to edit.php [core] - 10https://gerrit.wikimedia.org/r/100691 (owner: 10Legoktm) [22:55:33] ok then [22:58:41] bd808: Include the product name in your bug summary, please. :-) [22:58:51] Err, or component name. [22:59:14] Rather than "Don't use mail() function", you want "Don't use mail() function in Wikimania Scholarships application" or similar. [22:59:17] Gloria: I'll do that in the future. I was just about to ask you about the style convention [22:59:50] bd808: Bugspam and IRC and other places only use the bug summary. So when I get an e-mail that's like "Don't use mail()", it's super-confusing. [23:00:09] I ass-u-me-d that setting the product and component were sufficient, but I can see how not all tools are nicely compliant [23:01:01] (03PS1) 10Dan-nl: additional-exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100705 [23:01:02] (03CR) 10jenkins-bot: [V: 04-1] additional-exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100705 (owner: 10Dan-nl) [23:05:09] (03PS5) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [23:06:06] (03PS1) 10Aaron Schulz: Added --wikidb param to sql.php [core] - 10https://gerrit.wikimedia.org/r/100707 [23:06:31] spagewmf: that should work [23:07:02] * Aaron|home likes how msysgit takes a year to push anything [23:07:03] (03Abandoned) 10Dan-nl: additional-exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100705 (owner: 10Dan-nl) [23:07:04] (03PS1) 10Krinkle: Add .jshintrc file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100708 [23:07:10] (03PS1) 10Krinkle: Clean up existing code and pass jshint [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100709 [23:09:58] (03PS1) 10Dan-nl: additional-exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100711 [23:10:44] (03PS1) 10Krinkle: Make mwext-Scribunto-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/100712 [23:11:28] (03CR) 10Krinkle: [C: 032] "Adding file (default settings for now, feel free to adapt as needed) for Jenkins." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100708 (owner: 10Krinkle) [23:11:39] (03CR) 10Krinkle: [C: 031] Make mwext-Scribunto-jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/100712 (owner: 10Krinkle) [23:12:41] (03CR) 10BryanDavis: [C: 032] additional-exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100711 (owner: 10Dan-nl) [23:12:46] (03Merged) 10jenkins-bot: additional-exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/100711 (owner: 10Dan-nl) [23:12:51] (03CR) 10Krinkle: "After this is reviewed/merge, please notify I01d349bf21b20ce941 so that we can make the jenkins job voting to ensure we keep it passing fr" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100709 (owner: 10Krinkle) [23:13:43] (03Merged) 10jenkins-bot: Add .jshintrc file [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100708 (owner: 10Krinkle) [23:14:03] (03CR) 10Krinkle: [C: 04-1] "Don't merge before I283fda1409b1e76db." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/100712 (owner: 10Krinkle) [23:17:07] (03CR) 10Chad: [C: 04-1] "Not a fan, seems rather hacky and single-use; but won't block it if someone absolutely needs this for some deployment." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100707 (owner: 10Aaron Schulz) [23:19:49] (03CR) 10Aaron Schulz: "It's no less hacky that our use of the $wiki field in LoadBalancer methods uses by everything with it's own database (CentralAuth/GlobalBl" [core] - 10https://gerrit.wikimedia.org/r/100707 (owner: 10Aaron Schulz) [23:21:54] (03CR) 10Aaron Schulz: "*No more hacky" [core] - 10https://gerrit.wikimedia.org/r/100707 (owner: 10Aaron Schulz) [23:23:25] (03CR) 10Chad: [C: 031] "Two wrongs don't make a right ;-) But this is fine if we need it." [core] - 10https://gerrit.wikimedia.org/r/100707 (owner: 10Aaron Schulz) [23:27:02] DarTar: If I wanted to muck around with dashboard creation, might there be docs to let me do that? [23:27:20] (03PS1) 10CSteipp: Update CentralAuth to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100714 [23:27:33] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100698 (owner: 10CSteipp) [23:27:47] marktraceur: that's a gentle reminder, but in fact yes: [23:27:52] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100714 (owner: 10CSteipp) [23:27:58] (03CR) 10Aaron Schulz: "I mean they are literally implemented using the same wfGetDB() and getConnection() calling pattern." [core] - 10https://gerrit.wikimedia.org/r/100707 (owner: 10Aaron Schulz) [23:28:08] Krinkle: ping re https://gerrit.wikimedia.org/r/#/c/99547/ [23:28:19] marktraceur: https://wikitech.wikimedia.org/wiki/EE_Dashboard [23:29:57] marktraceur: let me know if I can help with that, you can also submit a pull request to the limn-editor-engagement-data repo if you wish and I'll take care of merging them [23:30:09] 'kay [23:32:12] ori-l: Hm.. [now(), +new Date(), now() - +new Date()], seems to always return between 2.0 and 3.9. I was expecting the off to vary up and down, not always behind? [23:32:31] Is there a logical explanation for that? [23:33:01] (03Merged) 10jenkins-bot: Update CentralAuth to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100698 (owner: 10CSteipp) [23:35:01] (03Merged) 10jenkins-bot: Update CentralAuth to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100714 (owner: 10CSteipp) [23:40:58] (03CR) 10Bsitu: [C: 032] Get rid of unused file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100686 (owner: 10Matthias Mullie) [23:41:13] (03Merged) 10jenkins-bot: Get rid of unused file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100686 (owner: 10Matthias Mullie) [23:42:04] (03PS1) 10Aaron Schulz: Avoid "Error: 1193 Unknown system variable table_type" error [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/100715 [23:42:45] DarTar: I think I'm seeing that the dashboard display and the generation of data are totally separate, is there a page documenting the latter? [23:43:11] hmm not really, that's the bit that's still missing [23:43:12] Like, from the start-point of "data in a database table" or "data in EventLogging" or similar. [23:43:16] Ah, bollocks. [23:43:17] 'kay [23:43:22] but I can give you a 30 sec demo [23:43:35] do you have time in say 10 mins? [23:43:49] Uhhh, I think no [23:43:59] I have the LD at 16:00, are you free at 16:30? [23:45:24] (03PS2) 10EBernhardson: Remove duplicated mention notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99563 (owner: 10Bsitu) [23:45:31] (03CR) 10EBernhardson: "extra whitespace" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99563 (owner: 10Bsitu) [23:45:42] (03CR) 10EBernhardson: [C: 032] "PS2: removed extra whitespace" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99563 (owner: 10Bsitu) [23:45:51] (03Merged) 10jenkins-bot: Remove duplicated mention notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99563 (owner: 10Bsitu) [23:46:24] (03CR) 10EBernhardson: [C: 032] Allow ObjectManager to fall back to querying backend storage when no index is available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 (owner: 10Werdna) [23:46:34] (03Merged) 10jenkins-bot: Allow ObjectManager to fall back to querying backend storage when no index is available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 (owner: 10Werdna) [23:53:39] (03PS3) 10EBernhardson: Make header use *ActionPermissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 (owner: 10Matthias Mullie) [23:53:44] (03CR) 10jenkins-bot: [V: 04-1] Make header use *ActionPermissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 (owner: 10Matthias Mullie) [23:55:05] (03CR) 10EBernhardson: [C: 032] "PS3:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 (owner: 10Matthias Mullie) [23:55:09] (03CR) 10jenkins-bot: [V: 04-1] Make header use *ActionPermissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 (owner: 10Matthias Mullie) [23:57:37] springle: Flow needs 'CREATE DATABASE flowdb' on the extension1 cluster, should I file a bug for that or do you have a system like https://wikitech.wikimedia.org/wiki/New_Project_Request/Database ? [23:58:18] (03PS1) 10MarkTraceur: Update MultimediaViewer to work in conjunction with VisualEditor [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100718 [23:58:45] marktraceur: Yay. [23:58:49] Yarp! [23:58:56] Will go as soon as the LD starts I guess [23:59:00] marktraceur: Are you after RoanKattouw in the LD? [23:59:08] I think so! [23:59:22] spagewmf: bug, i think, linked to the schema change tracking bug [23:59:27] marktraceur: Let RoanKattouw go first, then. :-P Or he could merge the two pulls? [23:59:40] Doesn't matter to me [23:59:45] I'm not touching VE, only MMV [23:59:56] (03PS4) 10EBernhardson: Make header use *ActionPermissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99416 (owner: 10Matthias Mullie)