[00:00:12] hoo, legoktm: security@wikimedia.org is the checked email account for security issues right? [00:00:20] Krenair: yes [00:00:20] Yes. [00:00:34] It forwards to Chris S., Tim, Roan, and others. [00:00:37] Gloria: the database storage is nearly identical to how normal user prefs are stored [00:00:39] Krenair: Yep [00:00:46] You can also open a security bug, though [00:01:01] legoktm: Right, it's normalized and we only store non-default. [00:01:07] I was wondering about the global part. [00:01:11] I'm pointing someone else in that direction, we don't know the details [00:01:16] ok [00:01:21] Setting "use this preference on all wikis" doesn't update all the wikis. [00:01:30] It just adds an additional row that takes precedence. [00:01:32] It sounds like. [00:01:35] yes [00:01:44] It sounds terribly confusing. [00:01:54] If you don't track checkbox state. [00:01:59] it is tracked [00:02:10] Oh. [00:02:10] ill show you another screenshot when my vm boots [00:02:21] If you uncheck it, does it show the local value? [00:02:46] there are two different pages [00:02:54] Special:GlobalPreferences and Special:Preferences [00:02:59] Hmmm. [00:03:04] I see that now. [00:03:06] Interesting. [00:04:26] http://cl.ly/image/323P3Q2j3C2M <-- look at language [00:04:35] How does Special:Preferences work? [00:04:43] Oh. [00:04:51] Hmmmmmmmm. [00:06:05] legoktm: hmm [00:06:12] so there are no local overrides? [00:06:22] no [00:06:24] global > local [00:06:25] :( [00:06:41] why? [00:06:51] simpler UI, i guess [00:06:59] because it would be horribly confusing [00:07:01] Duplicating preferences... hmmm. [00:07:07] hmm. [00:07:21] I suppose you could add a pref like "use global preferences on this wiki" but that would be all or nothing [00:08:00] Tangentially, preferences are also horribly ugly. [00:08:01] i've never thought about it, to be honest, but there's gotta be a solution that would allow for that and not suck [00:08:11] Continuing to tack on links to "basic information" is fine. [00:08:13] But it's ugly. [00:08:16] Aesthetically. [00:08:24] MatmaRex: It's a hard problem. [00:08:29] it is [00:08:31] legoktm: yeah, i think such a pref would be a must-have for usefulness [00:08:35] I'm not sure having two separate special pages is... [00:08:37] I'm not sure. [00:09:01] (e.g. my use case is that i was to receive email on changed to pages i watch on all wikis except for my home pl.wiki, where i watch a few thousand pages and check watchlist all the time anyway) [00:09:12] For me personally, I want to have global defaults for nearly all wikis. [00:09:20] And then have specific settings for a few wikis. [00:09:43] yeah, that makes sense [00:11:20] so....what preferences tab would this go under? [00:11:29] Preferences --> Preferences [00:11:44] Where you have it now is probably fine. [00:11:51] I was just saying that preferences generally are ugly. [00:11:55] And could use a redesign. [00:12:30] yup [00:17:03] (03PS3) 10TTO: Add language override options for rebuildInterwiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 [00:18:58] (03PS8) 10TTO: Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 [00:35:42] (03CR) 10PleaseStand: Abstract out mysql_field_type() call from DatabaseBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100172 (owner: 10PleaseStand) [00:40:07] (03PS1) 10Hoo man: Fix a PHP Notice in Scribunto_LuaEngine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100336 [00:40:51] (03CR) 10Reedy: "100,000!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100000 (owner: 10L10n-bot) [00:41:09] damn L10n-bot :D [00:42:22] siebrand: Stop spoiling all the funt! [00:42:26] siebrand: Stop spoiling all the fun! [00:43:42] hiii Reedy, bored now? [00:43:48] i've still got patches pending [00:43:54] hoo: maybe you? :> [00:44:02] Nah, hacking on parser functions [00:44:04] and it sucks [00:44:07] really :P [00:44:14] it does [00:45:42] hmm, hoo [00:45:57] about https://gerrit.wikimedia.org/r/#/c/89379/ "Make SpecialWatchlist extend SpecialRecentChanges: step 1" [00:46:12] Yeah, I knew that one would throw back [00:46:13] (03CR) 10Anomie: [C: 032] "Sensible enough." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100336 (owner: 10Hoo man) [00:46:15] …actually, i'm not sure what i wanted to ask you about [00:46:32] i should refactor these patches again some time i guess [00:46:57] You could say that the watchlist just is a specialized RecentChanges (only show pages I watch), but I think our code by far is to complex to represent that in reality [00:46:59] but first i'd have to strip specialrecentchanges [00:47:12] So yes, you should take the clean path [00:47:57] (03Merged) 10jenkins-bot: Fix a PHP Notice in Scribunto_LuaEngine [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/100336 (owner: 10Hoo man) [00:48:01] let's try implementing that on top first, maybe [00:49:04] (03PS8) 10Legoktm: Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [00:49:07] there. [00:53:36] massive rebase incoming. [00:54:01] (03PS4) 10Bartosz Dziewoński: SpecialWatchlist: Don't overwrite context now that we don't have to [core] - 10https://gerrit.wikimedia.org/r/94289 [00:54:02] (03PS6) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 [00:54:03] (03PS4) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 [00:54:04] (03PS8) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 [00:54:05] (03PS3) 10Bartosz Dziewoński: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 [00:54:06] (03PS3) 10Bartosz Dziewoński: SpecialWatchlist: Reorder some stuff in #execute [core] - 10https://gerrit.wikimedia.org/r/94627 [00:54:07] (03PS3) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 [00:54:08] (03PS2) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 [00:54:09] (03PS8) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges: step 1 [core] - 10https://gerrit.wikimedia.org/r/89379 [00:54:18] rebase is singular [00:54:29] * YuviPanda rebases Reedy [00:59:09] hmm crap, creating an abstract base page means i will have to actually think for a little bit instead of just coding :( [01:00:08] :D :P [01:00:59] hoo: would you be okay with doing that on top of the current stack? [01:02:11] not sure... merging the change that makes SpecialWatchlist a child of SpecialRecentChanges will physically hurt, still :P [01:04:11] it won't if you merge a change that makes that no longer the case at the same time ;) [01:04:34] Ok, in that case it's fine [01:05:10] aw, there are 11 methods defined on both of these classes [01:05:20] 12, actually [01:05:24] and a few more reused ones [01:05:45] this is going to be a lot of cut-and-pasting [01:06:09] Yeah... but it's fun committing after (seeing the pure amount of deleted row) [01:12:28] why do we have so many classes defined in SpecialPage.php :/ [01:13:02] Because it's more fun that way :P [01:13:32] i should habe more displays than 1, so i could see all three files at once [01:13:34] have* [01:13:49] Yeah, 3 monitors are fun [01:13:56] (not so much because Xorg sucks, but still) [01:18:40] i'd even accept just two [01:18:45] (if one is widescreen :>) [01:19:54] heh, I got one widescreen for my browser, the "tiny" notebook on in the middle for IRC, terminal, ... and a pivot one on the left (full hd, also)... that one is for code and emails mostly [01:22:06] * the pivot one actually is on the right [01:22:07] …i hate a Thinkpad T60 [01:22:11] * hoo should go to bed [01:22:23] it's a shame they stopped making laptops with 4:3 screens, i like this one [01:25:07] mh, for coding that sucks, yeah... that's why I have external screens :P [01:29:19] anyway... good night ;) [02:22:28] (03CR) 10Parent5446: "If this function is only used in earlier version of MediaWiki, it should probably be deprecated properly rather than just being removed." [core] - 10https://gerrit.wikimedia.org/r/100172 (owner: 10PleaseStand) [02:26:56] (03PS1) 10Legoktm: Load ext.wikiLove.local from PHP [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 [02:27:16] Gloria: ^ [02:31:51] (03PS2) 10Legoktm: Load ext.wikiLove.local from PHP [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/100338 [03:59:34] (03CR) 10MZMcBride: "Lego: did you hear back from Fabrice?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [03:59:35] Huh. Apparently someone is offering to make donations in bitcoins, if WMF sets up a method of accepting them. [03:59:54] https://wikimediafoundation.org/wiki/Bitcoin [04:00:16] [04:00:25] I doubt you'll like what you find. ;-) [04:00:31] But that link may be handy. [04:03:01] Oh, I like it lots! I'll tell them to give *me* the bitcoins... [04:11:15] Can Helder +2? [04:19:01] (03PS1) 10Gnosygnu: v0.12.1.0 [xowa] - 10https://gerrit.wikimedia.org/r/100344 [04:20:26] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/100344 (owner: 10Gnosygnu) [04:23:54] (03CR) 10Springle: "Sorry about the delay getting back to this." [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [04:39:05] (03CR) 10Jackmcbarn: "Here's one that would use log_user_text_type_time:" [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [04:39:30] springle: ^ [04:42:51] legoktm: Got a second? [04:42:58] possibly [04:43:06] I'm not totally sure why you abandoned: https://gerrit.wikimedia.org/r/#/c/97380/1 [04:43:08] and, that second is gone :( [04:43:10] :-( [04:43:25] Gloria: Oh, that accidentally got fixed in my other commit [04:43:58] You mean in https://gerrit.wikimedia.org/r/#/c/97370/ ? [04:44:14] https://gerrit.wikimedia.org/r/#/c/97370/2/SpecialNotifyTranslators.php <-- the setOption call is now unconditional, so saveSettings is only called when its updated (for everyone) [04:44:15] yeah [04:45:07] I'm not a fan of storing this info in a user's options, since the current way requires a database write for each user who gets a notificaiton [04:45:16] which can easily add up to 1000 writes in one request [04:54:53] Also, user options are considered private, whereas notifications may well be useful to be made available to tools. [04:55:19] Most user options are considered private. [04:55:32] Gender, e-mail-ability, and a few others are considered public. [04:56:17] Coren: You may be interested in https://bugzilla.wikimedia.org/show_bug.cgi?id=54441 [04:58:44] (03CR) 10Andrew Bogott: Add 'puppet status' to Special::Resources (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/100327 (owner: 10Andrew Bogott) [04:59:02] Gloria: From a database replication perspective, we don't (and cannot) make the difference. [04:59:30] Coren: The Toolserver has custom views. [04:59:30] toolserver does [04:59:32] And anything is possible. [04:59:37] (03PS2) 10Andrew Bogott: Add 'puppet status' to Special::Resources [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/100327 [05:00:51] I know; but Labs works under the principle of "unless a normal registered user can see it, then it's private". We can ask legal to clear the use-case, though. [05:01:09] Coren: So did the Toolserver. [05:01:14] Let me show you around MediaWiki sometime. ;-) [05:01:17] Gender is public. [05:01:20] So is e-mail-ability. [05:02:25] In Special:Preferences, gender clearly says "this information will be made public" [05:02:40] and it can be easily retrieved via the API, same with email-a-bility [05:04:05] It is; and therefore a case can be made for it that'll require little but a rubberstamp from Legal. Remember that we work at the /table/ level in replication. :-) [05:05:14] Any table that has /any/ private information needs to have a specific use case, and an okay from legal specifiying the exact data that can be presented. [05:05:35] I'm not saying "can't do it"; I'm saying "need clearance". [05:05:39] Where is that documented? [05:06:32] Gloria: I don't think it's documented in any one place; it's kinda spread over numerous mailing lists and bugzillas. [05:07:04] Coren: Citation needed. :-) [05:07:10] The legal requirement sounds made-up. [05:07:29] o_O [05:07:56] I have no desire to engage in being insulted. Feel free to contact legal to check up on me if you feel like it. [05:08:09] Nobody is insulting you. [05:08:18] The legal requirement sounds made-up. [05:08:25] You brought up user options. [05:08:31] And then you brought up a legal requirement. [05:08:39] I asked for citations for what you're saying. [05:08:57] I read many mailing lists and bugzillas. ;-) [05:09:28] Yes, and if you feel the need to doubt what I'm saying, feel free to take it up with legal yourself. I feel no need to stay here and be called a liar to my face. [05:10:00] Heh. [05:10:01] I thought I filed a bug for that? [05:10:07] I wonder if that's just misdirected anger. [05:10:29] no, that was watchlist table [05:10:30] * legoktm files [05:10:51] "We have a policy." "Okay, link?" "WHY ARE YOU QUESTIONING ME?????" [05:10:53] What a child. [05:11:30] For those keeping score at home, "what a child" _is_ an insult. [05:18:07] https://bugzilla.wikimedia.org/show_bug.cgi?id=58196 [05:18:29] Thanks. [05:40:14] (03PS1) 10Legoktm: Link to translated page [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100349 [05:48:06] (03PS5) 10leucosticte: Adding ViewFiles extension, v1.0.3. [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/28799 [05:48:43] (03CR) 10leucosticte: "Done, thanks for the review." (033 comments) [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/28799 (owner: 10leucosticte) [05:55:53] (03PS1) 10Legoktm: Use localized link to Special:Preferences [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100351 [05:56:39] Can anyone please tell me how to add a local only message to a i18n.php file? [05:58:06] (03CR) 10Legoktm: SkinTemplate: Add $this as a parameter to PersonalUrls hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95776 (owner: 10Bartosz Dziewoński) [05:58:16] durga: what do you mean? [06:00:00] (03PS1) 10Legoktm: PersonalUrls hook provides a SkinTemplate, not a Skin [core] - 10https://gerrit.wikimedia.org/r/100352 [06:00:32] (03CR) 10Legoktm: SkinTemplate: Add $this as a parameter to PersonalUrls hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95776 (owner: 10Bartosz Dziewoński) [06:01:37] I have to add a local message to the i18n.php file, which exposes that message to the client side, to check if the repository is local, how do I do that? [06:02:49] sorry, what exactly are you trying to do? [06:04:33] Iam working on the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 [06:06:59] I think you just need to add another message key [06:07:37] In this bug I have to add an if condition to check if the repository is local, and if it is local then it should say Learn more [06:08:18] you can create two messages [06:08:25] one for local usage, and one for not-local [06:08:38] then where the message gets used, check if the repo is local and decide which message to use [06:08:49] Yeah, but adding that if condition to the php file is not enough, some changes are to be made in the i18n.php file [06:09:10] yeah, you just need to add the message [06:09:20] lemme find the documentation [06:09:29] ok, thank you [06:09:47] https://www.mediawiki.org/wiki/Localisation#Adding_new_messages [06:15:59] Thank you, I will read it and try if it is working [06:17:17] And will you be able to mentor me? I am working on open source contribution, so will you be able to help me? [06:17:23] (03PS1) 10Legoktm: Use RequestContext::getMain()->getSkin() instead of User::getSkin() [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100353 [06:17:50] I think Mark will be able to help out, but you can add me as a reviewer [06:18:11] Thank you :) [06:23:06] (03CR) 10Parent5446: [C: 032] PersonalUrls hook provides a SkinTemplate, not a Skin [core] - 10https://gerrit.wikimedia.org/r/100352 (owner: 10Legoktm) [06:23:28] (03PS1) 10Legoktm: Use 'skinname-$name' message for displaying skin name [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100354 [06:25:58] (03Merged) 10jenkins-bot: PersonalUrls hook provides a SkinTemplate, not a Skin [core] - 10https://gerrit.wikimedia.org/r/100352 (owner: 10Legoktm) [07:02:13] (03CR) 10Siebrand: [C: 031] Use localized link to Special:Preferences [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100351 (owner: 10Legoktm) [07:07:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. No opinion on the change itself." [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [07:21:51] (03PS3) 10Legoktm: Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [07:21:52] (03CR) 10jenkins-bot: [V: 04-1] Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [07:22:14] grrr [07:24:03] (03PS4) 10Legoktm: Add script to send notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [07:29:10] (03CR) 10Legoktm: "Example screenshot for VectorBeta: http://i.imgur.com/CeBnHTO.png" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [07:35:07] (03PS5) 10Siebrand: Formatting fixes in includes/htmlform/* [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [07:35:57] (03CR) 10Siebrand: "PS5 has all CodeSniffer issues resolved, and PHPStorm formatter applied. Also moved public class properties to top of lists." [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [08:35:07] (03CR) 10Wikinaut: "@Bartosz" [core] - 10https://gerrit.wikimedia.org/r/96651 (owner: 10Wikinaut) [09:10:30] (03CR) 10Calak: [C: 031] Allow two-tier setup of transwiki import sources [core] - 10https://gerrit.wikimedia.org/r/84194 (owner: 10TTO) [09:29:06] (03CR) 10Daniel Kinzler: [C: 031] "Seems sensible, but needs manual testing, on PostGres and others DBs." [core] - 10https://gerrit.wikimedia.org/r/100183 (owner: 10saper) [10:19:49] (03CR) 10Parent5446: [C: 04-1] Teach ORMTable to use sequences (034 comments) [core] - 10https://gerrit.wikimedia.org/r/100183 (owner: 10saper) [10:37:35] (03CR) 10Springle: [C: 031] "Thanks for the second example." [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [10:55:36] (03CR) 10Bartosz Dziewoński: [C: 032] Link to translated page [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100349 (owner: 10Legoktm) [10:55:45] (03Merged) 10jenkins-bot: Link to translated page [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100349 (owner: 10Legoktm) [10:57:20] (03CR) 10Bartosz Dziewoński: [C: 032] Use 'skinname-$name' message for displaying skin name [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100354 (owner: 10Legoktm) [10:57:29] (03Merged) 10jenkins-bot: Use 'skinname-$name' message for displaying skin name [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100354 (owner: 10Legoktm) [11:03:26] (03CR) 10Bartosz Dziewoński: "You definitely should not use the $wgUser global, but instead pass the user from somewhere else. What is $this->getUser() here and why is " [core] - 10https://gerrit.wikimedia.org/r/96651 (owner: 10Wikinaut) [11:04:22] (03CR) 10Bartosz Dziewoński: "(I have read the bug but I didn't learn anything I didn't already know, apart from the fact that this apparently makes some extension work" [core] - 10https://gerrit.wikimedia.org/r/96651 (owner: 10Wikinaut) [11:24:31] (03CR) 10Tobias Gritschacher: [C: 031] Moved Wikibase Selenium tests to /tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/98829 (owner: 10Zfilipin) [11:25:12] (03CR) 10Zfilipin: [C: 032] Moved Wikibase Selenium tests to /tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/98829 (owner: 10Zfilipin) [11:25:20] (03Merged) 10jenkins-bot: Moved Wikibase Selenium tests to /tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/98829 (owner: 10Zfilipin) [11:27:14] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Two minor complaints." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [11:50:12] Hi Nemo_bis or any other translation admin who's online, can I get a couple of pages approved for translation? Namely items number 41 and 42 under 'Help pages', at this link: https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list [12:01:08] (03CR) 10MarkAHershberger: [C: 032] Don't lie about what function makes a query [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/97668 (owner: 10Chad) [12:02:37] (03CR) 10MarkAHershberger: [C: 032] Remove $wgTitle usage in CustomUserSignup [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/97627 (owner: 10Chad) [12:02:40] (03Merged) 10jenkins-bot: Remove $wgTitle usage in CustomUserSignup [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/97627 (owner: 10Chad) [12:05:57] (03CR) 10MarkAHershberger: [C: 032] Use wfMkdirParents() and wfRecursiveRemoveDir() rather than DIY [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/97555 (owner: 10Chad) [12:07:34] (03CR) 10MarkAHershberger: [C: 032] Don't use $wgTitle when OutputPage can provide [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/97546 (owner: 10Chad) [12:11:08] (03CR) 10MarkAHershberger: [C: 032] Remove ugly $wgTitle usage from edit.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/95840 (owner: 10Chad) [12:14:29] (03Merged) 10jenkins-bot: Remove ugly $wgTitle usage from edit.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/95840 (owner: 10Chad) [12:25:48] (03CR) 10MarkAHershberger: [C: 032] "looking forward to this." [core] - 10https://gerrit.wikimedia.org/r/92004 (owner: 10Chad) [12:28:53] (03Merged) 10jenkins-bot: Begin exposing SiteConfiguration via site contexts [core] - 10https://gerrit.wikimedia.org/r/92004 (owner: 10Chad) [13:05:24] Hi Nemo_bis, I've now enabled email notifs for edits of watchlisted pages so you don't have to leave messages on my user page anymore :) [13:07:15] :) [13:18:06] (03CR) 10Siebrand: Formatting fixes in includes/htmlform/* (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [13:23:23] (03PS6) 10Siebrand: Formatting fixes in includes/htmlform/* [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [13:23:49] (03CR) 10Siebrand: "Latest PS resolve Matma Rex's comments, as well as inconsistent commenting in HTMLFormField.php." [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [13:25:19] Hello. [13:25:33] hi Niharika [13:38:36] Reedy: morning, awake already ? :-] [13:48:40] (03PS1) 10Siebrand: Prevent fatal when Fiel::transform() returns false [core] - 10https://gerrit.wikimedia.org/r/100369 [13:49:48] (03PS2) 10Siebrand: Prevent fatal when Fiel::transform() returns false [core] - 10https://gerrit.wikimedia.org/r/100369 [13:53:33] (03CR) 10Parent5446: [C: 032] Prevent fatal when File::transform() returns false [core] - 10https://gerrit.wikimedia.org/r/100369 (owner: 10Siebrand) [13:54:09] (03CR) 10Bartosz Dziewoński: [C: 032] "Smoke test passed, three people looked at this. LGTM." [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [13:55:03] (03PS5) 10Dan-nl: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [13:56:45] (03Merged) 10jenkins-bot: Prevent fatal when File::transform() returns false [core] - 10https://gerrit.wikimedia.org/r/100369 (owner: 10Siebrand) [13:58:16] (03Merged) 10jenkins-bot: Formatting fixes in includes/htmlform/* [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [14:01:03] (03CR) 10Dan-nl: "- addressed almost all of the @todo’s siebrand added." (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [14:21:46] (03PS1) 10Matthias Mullie: Move code to load User data from cache out of loadFromId [core] - 10https://gerrit.wikimedia.org/r/100371 [14:25:00] (03CR) 10Njw: [C: 032 V: 032] Simplify and rename the HTML & CSS [skins/erudite] - 10https://gerrit.wikimedia.org/r/99436 (owner: 10Njw) [14:26:30] (03PS1) 10Matthias Mullie: User User cache when loading usernames [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100373 [14:28:05] (03PS1) 10Yaron Koren: Improved handling for chars with umlauts, and encodings like UTF-8 & UTF-16 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/100374 [14:30:40] (03CR) 10Yaron Koren: [C: 032 V: 031] Improved handling for chars with umlauts, and encodings like UTF-8 & UTF-16 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/100374 (owner: 10Yaron Koren) [14:31:05] (03CR) 10Yaron Koren: [V: 032] Improved handling for chars with umlauts, and encodings like UTF-8 & UTF-16 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/100374 (owner: 10Yaron Koren) [14:31:19] (03CR) 10Matthias Mullie: "I like this solution" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [14:32:42] (03Abandoned) 10Matthias Mullie: User renaming needs to be handleable by the RenameUser extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99668 (owner: 10Matthias Mullie) [14:36:07] (03CR) 10Siebrand: i18n review: Updates for messages, code and documentation (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [14:38:50] is Tobias Gritschacher here ? [14:40:29] anyone here who can answer a few question regarding this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=57844 ? [14:41:12] vandrew: tgr ? [14:41:23] vandrew: maybe. try asking the question. :) [14:41:24] !ask [14:41:24] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [14:41:34] vandrew: Hmm, no that's Tisza Gergő :) [14:41:53] zeljkof might know too, since he does browser tests [14:42:13] i've never seen tobias on IRC, i thnk [14:42:23] vandrew: are you a code-in student? [14:42:26] yes [14:42:34] vandrew: welcome! :) [14:42:54] I am the mentor for the task [14:43:00] zeljkof: I have a few questions before I begin working [14:43:17] Tobi_WMDE in #wikidata is another mentor [14:43:22] vandrew: ask [14:43:53] zeljkof: first of all I have to clone the new cucumber test, here https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikibase/129f22419945ad414fda6701e91b25af9b6eb973/selenium_cuc yes ? [14:44:19] and add the old ones via a gerrit commit yes ? [14:44:45] vandrew: did you create bugzilla account? https://bugzilla.wikimedia.org/ [14:45:09] zeljkof: yes, I have one [14:45:29] can you then assign the bug to yourself? [14:45:48] if you do not have the privileges, just leave a comment at the bug, I will assign it to you [14:46:35] zeljkof: I have the following privileges bz_canusewhines User can configure whine reports for self [14:46:51] vandrew: can you assign the bug to yourself? [14:47:02] (Assigned To setting) [14:47:25] zeljkof: no [14:47:35] zeljkof: I'll post a comment yes ? [14:47:39] vandrew: can you please then leave a comment then [14:47:44] yes, please [14:47:48] so I can see your account [14:47:54] and I will assign the bug to you [14:48:38] zeljkof: should I specify something in the comment or can I type anything ? [14:48:57] just say something like "please assign the bug to me" :) [14:49:52] zeljkof: done [14:50:37] vandrew: ok, assigned the bug to you [14:50:41] next step [14:51:09] do you have gerrit account? https://gerrit.wikimedia.org [14:51:20] yes [14:51:28] vandrew: excellent [14:51:49] did you clone wikibase repo? [14:52:33] vandrew: ^ [14:52:42] zeljkof: haven't cloned anything yet [14:52:49] but I'll clone it right away [14:52:59] vandrew: ok, the next step is to get the code, that is called cloning [14:53:09] are you familiar with version control and/or git? [14:53:29] yes [14:53:42] Tobi_WMDE: vandrew is asking how to complete the task https://bugzilla.wikimedia.org/show_bug.cgi?id=57844 [14:53:54] vandrew: excellent, then just clone the repo [14:54:02] https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikibase/129f22419945ad414fda6701e91b25af9b6eb973/selenium_cuc this one yes ? [14:54:30] well, that points to a folder inside the repo [14:54:47] I will add link to the repo to the ticket [14:54:49] yes, here is the repo I'l lactually clone [14:54:50] https://git.wikimedia.org/git/mediawiki/extensions/Wikibase.git [14:55:25] vandrew: go here https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Wikibase [14:55:47] and use ssh or http url to clone (depending on how you prefer to clone) [14:55:58] (03PS2) 10Manybubbles: Remove pool counter from updating pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99747 [14:56:17] vandrew: make sure you are logged in, that will give you a specific url for you [14:57:28] vandrew: hey, the path to the selenium tests just changed today.. :-( [14:57:47] now it is /tests/browser/ (instead of /selenium_cuc/ [14:57:56] (03CR) 10Manybubbles: Remove pool counter from updating pages (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99747 (owner: 10Manybubbles) [14:58:29] Tobi_WMDE: could you please update the bug? [15:00:07] zeljkof: I have finished the cloning [15:00:35] vandrew: excellent, Tobi_WMDE could you please help him with the task, I will have to go soon [15:00:59] vandrew: Tobi_WMDE will know more what needs to be done, ping him :) [15:01:19] ok [15:01:36] zeljkof: thanks for the help [15:02:03] vandrew: no problem, I will be around for a while too, if Tobi_WMDE can not help you [15:02:06] * zeljkof is out to lunch [15:02:38] zeljkof: vandrew I've updated the bug description [15:02:58] see https://bugzilla.wikimedia.org/show_bug.cgi?id=57844#c2 [15:04:11] hmm, have we worked out a way to rename classes in PHP while keeping back-compat? [15:04:23] siebrand: did we? i think you were doing something about that with tyler or someone ^ [15:04:41] plop [15:05:08] (i can just make a pseudo-subclass that calls wfDeprecated() in constructor, but not sure if that's how we do it) [15:05:16] MatmaRex: AFAIK Platform isn't too enthusiastic about Tyler's proposal. [15:05:32] MatmaRex: The class renames for LB that I've proposed can do without it. [15:05:53] (what was the proposal? / were the proposals?) [15:05:58] actually, just tell me how to do it [15:06:05] i want to rename SpecialRedirectToSpecial to something else [15:06:19] since the "Special" prefix is for actual special pages, and this is an abstract superclass [15:06:33] abstract class SpecialRedirectToSpecial extends RedirectSpecialPage [15:07:46] (i'd also prefer to do it about now, since i want to split SpecialPage.php into a few saner files :) ) [15:09:27] (03CR) 10PleaseStand: "bug 58213" [core] - 10https://gerrit.wikimedia.org/r/66304 (owner: 10Aaron Schulz) [15:10:36] hey Niharika [15:10:38] how's it going? [15:11:15] yuvipanda: Hi. :) [15:11:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/100327 (owner: 10Andrew Bogott) [15:11:58] yuvipanda: Would you be able to tell me how to make a JS file run on page load? [15:12:20] Niharika: https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader [15:12:25] has all the info :) [15:12:52] yuvipanda: Ah. Is there a search bar for looking through the documentation? :P [15:13:03] I have real trouble finding helpful links. [15:13:13] Niharika: :D I usually search on google with 'mediawiki ' and that helps [15:13:23] Niharika: there's a searchbar on mw.org on top right but it's... kinda meH :P [15:13:40] yuvipanda: Great. Yeah, I checked that out already. :P [15:13:42] :) [15:14:07] Niharika: although most of those links are from memory - if you hang around on IRC enough and listen to passing discussions between other people, you pick up a few intersting tidbits :) [15:15:00] Tobi_WMDE: so first I have to copy the tests from here to the new place, yes /https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FWikibase/129f22419945ad414fda6701e91b25af9b6eb973/repo%2Ftests%2Fselenium [15:15:05] yuvipanda: IRC is way more fun than I expected. Except that it needs a well designed client. :) [15:15:20] Niharika: yup! Windows doesn't have too many, sadly. [15:15:25] most people I know reccomend Hexchat [15:15:29] for Windows [15:16:06] vandrew: copying the tests would not make much sense, as they are in rspec. [15:16:10] yuvipanda: Iḿ surviving with Pidgin for now. [15:16:15] Not too bad. [15:16:31] hmm, I remember it being the most terrible of the IRC clients I had tried when I was on Windows :P [15:16:34] Niharika: do try out hexchat :) [15:16:39] vandrew: would probably be the best to look how the other tests were done. [15:16:54] yuvipanda: Definitely. :) [15:17:14] Niharika: doesn't the OPW period start today? [15:17:27] e.g. have a look at the label.feature and respective label_steps.rb files [15:17:36] yuvipanda: Tomorrow. 10th. [15:17:58] Tobi_WMDE: ok [15:18:05] yuvipanda: Started for me fortnight ago only though. :P [15:18:06] they pretty much replace the old label_spec.rb tests [15:18:20] Niharika: hehe :D [15:18:29] Niharika: yup, that's pretty awesome of you! :) [15:19:10] yuvipanda: Haha. It´s partially my fear of not being able to complete the project on time. Hence the early start. ;) [15:19:34] (03CR) 10Andrew Bogott: [C: 032 V: 032] Add 'puppet status' to Special::Resources [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/100327 (owner: 10Andrew Bogott) [15:19:37] vandrew: so, my way to do it, is (1) create a new feature file and implement scenarios which pretty much reflect what the old tests (from the *_spec.rb file) did [15:20:04] aw crap [15:20:33] and (2) implement the definition steps (the *_steps.rb file) to do the work for the scenarios [15:21:00] Niharika: I did that in my first GSoC too. [15:21:57] yuvipanda: You participated more than once? :O [15:22:00] Cool. :D [15:22:07] vandrew: you basically do not need to get wikibase working locally for you (that can be some hard work) - you can use the betalabs instance on http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page to test and tryout the behavior [15:22:07] Niharika: yeah, first with GNOME and then with WMF. [15:22:22] yuvipanda: Nice. :) [15:22:28] Niharika: GSoC/OPW are great ways to try to integrate with a community - it didn't work out with GNOME, but I stuck on at WM :) [15:23:22] Tobi_WMDE: I'll try that way [15:24:00] yuvipanda: :) I can see how the real-world code is WAY different from what we get to learn in college. =/ [15:25:05] Niharika: yes, I tell people to completely forget the type of code they learn in college :) [15:25:13] the style is often a hinderance [15:26:19] (03PS1) 10Gerrit Patch Uploader: Remove unused variable and deprecated parameters [core] - 10https://gerrit.wikimedia.org/r/100378 [15:26:20] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/100378 (owner: 10Gerrit Patch Uploader) [15:26:57] yuvipanda: Indeed. [15:28:41] (03PS1) 10Gerrit Patch Uploader: Remove unused variable and deprecated parameters [core] - 10https://gerrit.wikimedia.org/r/100379 [15:28:42] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/100379 (owner: 10Gerrit Patch Uploader) [15:29:31] Niharika: I'm off to have dinner. Do go through the RL docs, and also look at other example code in other extensions. [15:29:46] Niharika: or even core mediawiki itself - it uses RL to load JS and CSS [15:29:58] yuvipanda: Thanks. Bon appetite! Iĺl do that. [15:30:06] :) [15:31:49] vandrew: do you have all the information that you need? [15:32:01] (03CR) 10Njw: "Can somebody else weigh in, perhaps? Is there some way something like this could be accepted into the extension? As I said, it's completel" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/57041 (owner: 10Njw) [15:40:38] (03PS6) 10Hoo man: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [15:41:02] (03CR) 10Hoo man: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [15:42:01] I'm using the API on enwiki but for some reaosn it's saying I'm an IP rather than displaying the userinfo for my account. What am I doing wrong? [15:42:07] I checked, I'm definitely logged in. [15:42:10] And this is the query: http://en.wikipedia.org/w/api.php?format=json&action=query&meta=userinfo [15:42:46] (03CR) 10Hashar: "Some bits could be improved. Overall I like the idea of using tidy to test out HTML validity, can definitely be reused in other tests as " (034 comments) [core] - 10https://gerrit.wikimedia.org/r/98853 (owner: 10Daniel Kinzler) [15:44:00] (03CR) 10jenkins-bot: [V: 04-1] Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [15:44:03] DGarry: are you sending the cookies? [15:44:36] MatmaRex: Turns out it was because I wasn't using HTTPS. Thanks. :) [15:44:45] ah. :) [15:45:00] (03PS1) 10Zfilipin: Released gem version 0.1.14 [selenium] - 10https://gerrit.wikimedia.org/r/100381 [15:47:01] (03PS1) 10Zfilipin: Updated Ruby gems [qa/browsertests] - 10https://gerrit.wikimedia.org/r/100382 [15:48:00] Tobi_WMDE: so for example for Edit-tab test I have to make a *_spec.rb, modify the old spec so it will work and the files should be in test/browser yes ? [15:49:26] vandrew: I have to go in a few minutes, if Tobi_WMDE does not reply, ask the question at the bug report, I will reply as soon as possible [15:50:02] zeljkof: sure [15:51:38] vandrew: good luck! :) [15:52:19] besides Tobi_WMDE and me, chrismcmahon and JeffHall can also help [15:52:31] they are mostly in #wikimedia-qa [15:52:42] zeljkof:I'll ask them then [15:58:30] vandrew: for edit-tab test there should be a /tests/browser/features/edittab.feature file which contains scenarios (like e.g. in label.feature) describing the desired behavior of the edt-tab. [15:59:12] (03PS1) 10Njw: Make underlining of links clearer, and make declarations more sensible [skins/erudite] - 10https://gerrit.wikimedia.org/r/100386 [15:59:36] and there should be a /tests/browser/features/step_definitions/edittab_steps.rb file (like e.g. label_steps.rb) which implements the specific steps [16:00:04] (03CR) 10Njw: [C: 032 V: 032] Make underlining of links clearer, and make declarations more sensible [skins/erudite] - 10https://gerrit.wikimedia.org/r/100386 (owner: 10Njw) [16:00:46] (03PS1) 10Matthias Mullie: Use addError() to add errors, instead of adding to array ourselves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100387 [16:02:07] Tobi_WMDE: so I have to create these files for all the tests yes ? [16:02:29] vandrew: yes [16:03:47] vandrew: what was a single edittab_spec.rb file before will then be a edittab.feature and a edittab_steps.rb file [16:04:30] yes [16:04:47] vandrew: just like I did iit already with the other tests, like e.g. label_spec.rb (it became labels.feature and label_steps.rb) [16:04:57] Tobi_WMDE: yes, there are a few [16:05:50] Tobi_WMDE: and here http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page and here I can test the behavior [16:12:50] (03CR) 10Anomie: [C: 031] "> The api output is still a little odd." [core] - 10https://gerrit.wikimedia.org/r/99738 (owner: 10Aaron Schulz) [16:20:51] (03PS2) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [16:23:25] (03PS3) 10Manybubbles: Remove pool counter from updating pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99747 [16:26:32] (03CR) 10Hoo man: "Style/ jshint fixes" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [16:26:36] (03PS1) 10Anomie: API: Add iiprop=canonicaltitle [core] - 10https://gerrit.wikimedia.org/r/100388 [16:30:17] (03PS2) 10Anomie: Added a TIME_ONLY option to FileRepo::findFiles to use less RAM [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [16:30:23] (03CR) 10Anomie: [C: 032] Added a TIME_ONLY option to FileRepo::findFiles to use less RAM [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [16:30:28] * greg-g waves to andre__ :) [16:31:34] (03PS1) 10Matthias Mullie: Get rid of unused file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100389 [16:32:09] (03PS1) 10PleaseStand: Restore compatibility with curl < 7.16.2 [core] - 10https://gerrit.wikimedia.org/r/100390 [16:32:20] !g I3043f827c57c72799eb5c5a5abf291c825e1addf | Krinkle|detached [16:32:20] Krinkle|detached: https://gerrit.wikimedia.org/r/#q,I3043f827c57c72799eb5c5a5abf291c825e1addf,n,z [16:33:30] (03CR) 10Anomie: "I wonder, should this check for TIME_ONLY to be available and fallback to the existing code if not? Or do we not care about the latest ver" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/99527 (owner: 10Aaron Schulz) [16:33:56] (03PS2) 10PleaseStand: Restore compatibility with curl < 7.16.2 [core] - 10https://gerrit.wikimedia.org/r/100390 [16:35:46] (03Merged) 10jenkins-bot: Added a TIME_ONLY option to FileRepo::findFiles to use less RAM [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [16:36:35] (03CR) 10PleaseStand: "bug 58178" [core] - 10https://gerrit.wikimedia.org/r/58247 (owner: 10Chad) [16:37:42] (03CR) 10PleaseStand: "Please backport to MediaWiki 1.22." [core] - 10https://gerrit.wikimedia.org/r/100390 (owner: 10PleaseStand) [16:39:21] (03CR) 10Krinkle: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [16:42:56] (03CR) 1001tonythomas: "Adding more reviewers. I think this patch looks good." [core] - 10https://gerrit.wikimedia.org/r/94117 (owner: 10Gerrit Patch Uploader) [16:47:41] vandrew: exactly [16:47:46] (03CR) 10Anomie: [C: 04-1] "We require PHP 5.3.2, which was released 4 March 2010. Curl 7.16.2 was released 11 April *2007*, almost three years earlier. Do we really " [core] - 10https://gerrit.wikimedia.org/r/100390 (owner: 10PleaseStand) [16:51:16] (03PS1) 10Manybubbles: Let Cirrus return the score [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/100392 [16:59:36] (03CR) 10Bartosz Dziewoński: [C: 031] "If it costs us about nothing, why not? We require a somewhat recent PHP because it has features we use in our code, that can't be just not" [core] - 10https://gerrit.wikimedia.org/r/100390 (owner: 10PleaseStand) [17:00:33] (03CR) 10Umherirrender: "The function in Sanitizier contains some other suppress and restore of warnings, so that is not very readable, that is right. Should I lea" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100165 (owner: 10Umherirrender) [17:00:56] (03CR) 10Anomie: Tracking category for modules saved with errors (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99796 (owner: 10Anomie) [17:01:07] (03PS2) 10Anomie: Tracking category for modules saved with errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99796 [17:02:22] (03PS1) 10Bartosz Dziewoński: Split includes/SpecialPage.php [core] - 10https://gerrit.wikimedia.org/r/100394 [17:02:33] (03PS8) 10Hoo man: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [17:03:09] siebrand: There? I want to autoload a JS file when ULS is enabled, how do I do that? [17:03:30] (03CR) 10Hoo man: "Added the Qqq message" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [17:03:30] hoo: https://gerrit.wikimedia.org/r/100394 is for you <3 [17:04:14] :) \o/ [17:05:08] is this the first time MatmaRex uses <3 <3 [17:05:36] MatmaRex: Trailing spaces... clear -2 :D [17:05:55] hoo: yeah, just noticed :P [17:06:10] (03CR) 10Hoo man: [C: 04-1] "No way!!! :D" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/100394 (owner: 10Bartosz Dziewoński) [17:06:45] (03CR) 1001tonythomas: "The patch needs review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94500 (owner: 10Tinaj1234) [17:06:51] Looks good in general... I'm pretty confident that I have the time to merge it later today ;) [17:07:01] (03PS2) 10Bartosz Dziewoński: Split includes/SpecialPage.php [core] - 10https://gerrit.wikimedia.org/r/100394 [17:07:02] Nikerabbit: i don't think [17:07:05] hoo: THERE. [17:07:47] Let's wait for jenkins :P [17:08:01] i wonder if i messed up any autoloader entry [17:08:08] MatmaRex: ever? [17:08:13] oh look, i didn't [17:08:26] Nikerabbit: ever what? [17:08:32] $ grep -Er "MatmaRex>.+<3" irclogs/FreeNode/ | wc -l [17:08:33] 17 [17:08:39] MatmaRex: bunnies? [17:08:55] Nemo_bis is the new NSA [17:09:16] what bunnies? D: [17:09:18] i am lost [17:09:28] no bunnies? :O [17:09:38] carrots? :E [17:09:40] ';..;' [17:09:57] I just ate all carrots available here, sorry [17:10:35] there's some elery left though [17:10:37] (03PS1) 10Njw: Don't respect showjumplinks, remove unneeded sitename check, improve rtl [skins/erudite] - 10https://gerrit.wikimedia.org/r/100396 [17:11:21] *celery [17:11:48] (03CR) 10Hoo man: [C: 032] "Rather trivial change, looks good (no functional changes... hopefully)" [core] - 10https://gerrit.wikimedia.org/r/100394 (owner: 10Bartosz Dziewoński) [17:11:57] MatmaRex: ^ [17:12:31] (03CR) 10Bartosz Dziewoński: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [17:12:38] I went through all files and everything looked ok ;) [17:12:45] woot, that's quick [17:12:52] hoo: wanna review some more changes? :P [17:13:10] MatmaRex: I'm actually so fast, because I'm supposed to work on Capiunto :D [17:13:35] But really, that one is trivial... moving classes around should be a safe thing to do... even in MediaWiki/core [17:14:26] (03PS3) 10Anomie: Status::getHTML should actually return HTML [core] - 10https://gerrit.wikimedia.org/r/99798 [17:14:45] Ok, I realize that this sentence is asking for bad luck over here :P [17:14:59] (03CR) 10Njw: [C: 032 V: 032] Don't respect showjumplinks, remove unneeded sitename check, improve rtl [skins/erudite] - 10https://gerrit.wikimedia.org/r/100396 (owner: 10Njw) [17:15:05] (03Merged) 10jenkins-bot: Split includes/SpecialPage.php [core] - 10https://gerrit.wikimedia.org/r/100394 (owner: 10Bartosz Dziewoński) [17:15:41] capiunto or capiuntote? [17:16:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I don't think this is the right way to do this per https://bugzilla.wikimedia.org/show_bug.cgi?id=56611#c10" [core] - 10https://gerrit.wikimedia.org/r/94117 (owner: 10Gerrit Patch Uploader) [17:16:24] Nemo_bis: https://www.mediawiki.org/wiki/Extension:Capiunto :D [17:16:41] hoo: i sure hope i didn't miss any. :P [17:17:04] (just kidding, mostly, jenkins would scream) [17:17:06] (03PS1) 10Njw: Ensure all related padding is reduced together when screen is too small [skins/erudite] - 10https://gerrit.wikimedia.org/r/100398 [17:17:10] hmm forget that [17:19:09] (03CR) 10Njw: [C: 032 V: 032] Ensure all related padding is reduced together when screen is too small [skins/erudite] - 10https://gerrit.wikimedia.org/r/100398 (owner: 10Njw) [17:24:38] (03PS3) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [17:25:10] (03PS2) 10Matthias Mullie: Use addError() to add errors, instead of adding to array ourselves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100387 [17:26:16] (03PS1) 10Matthias Mullie: Add missing message to resources [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100400 [17:27:53] (03PS1) 10Manybubbles: Update BetaFeatures and Cirrus [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100401 [17:28:26] Oh. Wait. [17:28:34] (03CR) 10Matthias Mullie: [C: 032] Disable VisualEditor by default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99721 (owner: 10Spage) [17:28:35] manybubbles: Did you talk to Howie about the BetaFeatures thing? [17:28:45] (03Merged) 10jenkins-bot: Disable VisualEditor by default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99721 (owner: 10Spage) [17:28:48] * marktraceur was going to ask at 08:30 this morning but predictably forgot [17:28:56] marktraceur: sorry, ask about what? [17:29:12] manybubbles: There's a product manager assigned to BetaFeatures, to sort of guide the process [17:29:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [17:29:40] I mentioned it last week, I think [17:29:43] marktraceur: cool. I can poke him. what is his irc name? [17:29:52] hfung, he may not be on...I'll go see if he's in [17:30:38] (03PS1) 10Njw: Back out of RTL part of previous commit; turns out it isn't needed [skins/erudite] - 10https://gerrit.wikimedia.org/r/100402 [17:30:43] csteipp: in regards to username suppression in flow, we are instead pulling all the usernames out of the flow db and querying the usernames from the wiki itself in batches. When querying from the wiki's user table do we still need to join ipblocks and filter on ipb_deleted = 1? [17:30:49] (03CR) 10Njw: [C: 032 V: 032] Back out of RTL part of previous commit; turns out it isn't needed [skins/erudite] - 10https://gerrit.wikimedia.org/r/100402 (owner: 10Njw) [17:31:07] (03CR) 10Matthias Mullie: [C: 032] Repair subpage links going through redlink handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99801 (owner: 10EBernhardson) [17:31:17] (03Merged) 10jenkins-bot: Repair subpage links going through redlink handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99801 (owner: 10EBernhardson) [17:32:22] (03PS1) 10Manybubbles: Update BetaFeatures and Cirrus [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100403 [17:33:03] ebernhardson: Yes. Either a join, or you need to check the block table in a followup [17:34:49] csteipp: ok will do [17:35:29] manybubbles: He's not in, let's go but cautiously. :) [17:35:40] cool. [17:36:00] marktraceur: ^d and I usually keep track of this on -ops if you want to join us [17:36:10] Oh, sure [17:37:07] (03CR) 10EBernhardson: [WIP] Load usernames directly from wiki's in batches (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 (owner: 10EBernhardson) [17:37:35] (03CR) 10Chad: [C: 032] Update BetaFeatures and Cirrus [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100401 (owner: 10Manybubbles) [17:37:39] (03CR) 10Chad: [C: 032] Update BetaFeatures and Cirrus [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100403 (owner: 10Manybubbles) [17:38:15] (03CR) 10Siebrand: [C: 032] Add missing message to resources [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100400 (owner: 10Matthias Mullie) [17:39:52] (03CR) 10Chad: [C: 032] Remove pool counter from updating pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99747 (owner: 10Manybubbles) [17:40:02] (03Merged) 10jenkins-bot: Add missing message to resources [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100400 (owner: 10Matthias Mullie) [17:41:08] (03Merged) 10jenkins-bot: Update BetaFeatures and Cirrus [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100401 (owner: 10Manybubbles) [17:42:59] (03Merged) 10jenkins-bot: Update BetaFeatures and Cirrus [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100403 (owner: 10Manybubbles) [17:43:33] (03Merged) 10jenkins-bot: Remove pool counter from updating pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99747 (owner: 10Manybubbles) [17:44:17] (03PS1) 10EBernhardson: Test case for redlink handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100405 [17:45:18] (03CR) 10Chad: [C: 032] "People should just update their software, but I'm not going to get into yet another freaking holy war about how we handle broken installat" [core] - 10https://gerrit.wikimedia.org/r/100390 (owner: 10PleaseStand) [17:46:40] (03CR) 10Chad: [V: 032] Don't lie about what function makes a query [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/97668 (owner: 10Chad) [17:47:05] (03CR) 10Chad: [V: 032] Use wfMkdirParents() and wfRecursiveRemoveDir() rather than DIY [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/97555 (owner: 10Chad) [17:47:16] (03CR) 10Chad: [V: 032] Don't use $wgTitle when OutputPage can provide [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/97546 (owner: 10Chad) [17:47:57] (03PS1) 10Njw: Ensure :visited is taken into account in footer, and remove unneeded !important [skins/erudite] - 10https://gerrit.wikimedia.org/r/100406 [17:48:01] (03CR) 1001tonythomas: "Should I submit a new patch without removing the 'rememberpassword' keyword related items ?" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [17:49:19] (03CR) 10Njw: [C: 032 V: 032] Ensure :visited is taken into account in footer, and remove unneeded !important [skins/erudite] - 10https://gerrit.wikimedia.org/r/100406 (owner: 10Njw) [17:49:26] (03Merged) 10jenkins-bot: Restore compatibility with curl < 7.16.2 [core] - 10https://gerrit.wikimedia.org/r/100390 (owner: 10PleaseStand) [17:51:42] (03CR) 1001tonythomas: "Should I add something more to the patch ?" [core] - 10https://gerrit.wikimedia.org/r/99322 (owner: 1001tonythomas) [17:52:21] (03PS1) 10Tpt: Fix failure in IE 8 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100407 [17:52:50] (03CR) 10Tpt: [C: 032] "Trivial change" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100407 (owner: 10Tpt) [17:52:59] (03Merged) 10jenkins-bot: Fix failure in IE 8 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100407 (owner: 10Tpt) [18:01:03] (03PS1) 10Tpt: Update ProofreadPage to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100408 [18:10:48] (03PS1) 10Anomie: API: Add image sizes and default user prefs to meta=siteinfo [core] - 10https://gerrit.wikimedia.org/r/100409 [18:11:56] anomie: heh, I read ^ as 'default user profile image sizes' and was confused [18:23:56] Tobi_WMDE: how do I create a new wikidata item on this page ?http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page ? [18:24:35] vandrew: http://wikidata.beta.wmflabs.org/wiki/Special:NewItem [18:27:02] hoo: thx [18:29:36] (03PS1) 10Hoo man: Implement {{#infobox:...}} as a simple wrapper [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/100411 [18:32:16] hoo: and how do I delete an item ? [18:32:36] vandrew: Are you administrator there? [18:32:50] using the usual mediawiki-way [18:33:11] vandrew: Exactly, yes [18:33:12] yes, I have just created an item and I have to delete it now [18:33:30] hoo: what is the usual mediawiki-way [18:33:57] Do you see the arrow down somwhere on the upper right side? [18:34:09] Hover it, and select delete [18:34:14] the rest should be self explaining [18:36:00] hoo: I see no arrow, here is the page http://wikidata.beta.wmflabs.org/wiki/Q8542 [18:36:24] vandrew: Are you logged in? [18:36:40] yes [18:37:30] I don't have a user there (and can't recall the default credentials now) [18:37:52] ok, I'll figure it out, thanks for the help [18:38:19] vandrew: In a nuthsell: It will point you to http://wikidata.beta.wmflabs.org/wiki/Q8542?action=delete [18:39:11] (03CR) 10Bartosz Dziewoński: [C: 032] Use localized link to Special:Preferences [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100351 (owner: 10Legoktm) [18:39:12] (03CR) 10jenkins-bot: [V: 04-1] Use localized link to Special:Preferences [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100351 (owner: 10Legoktm) [18:39:35] hoo: I am not in the [18:39:40] whut [18:39:45] administrators group.. [18:39:52] Muahaha, trying to break my master MatmaRex? NOT TODAY!!! [18:39:55] vandrew: That's why you didn't see the arrow [18:39:56] Jenkins will stop you [18:40:01] You'll never get away with it [18:40:07] hoo: could you tell me if the delete button works ? [18:40:11] sorry I can't fix that... I'm not into our labs stuff at all [18:40:11] (03CR) 10MaxSem: [C: 04-2] "That'd be a DB query per link rendered which will be too slow for even medium pages. And even disabling it for most users will not help to" (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 (owner: 10Kaldari) [18:40:25] and I don't have *any* rights over there (why? :P) [18:40:26] Oh, wait, it's legoktm's patch. My bad. [18:40:42] (03CR) 10Bartosz Dziewoński: "The V-1 was caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=57483" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100351 (owner: 10Legoktm) [18:40:50] Anyone here who has administrator rights here http://wikidata.beta.wmflabs.org/wiki/Q8542http://wikidata.beta.wmflabs.org/wiki/Q8542 ? [18:40:59] marktraceur: ^demon's fault :P [18:41:00] MatmaRex: Did I give you +2 on BF? I don't remember doing that. [18:41:05] Oh, reasonable [18:41:27] (03CR) 10Bartosz Dziewoński: [C: 032] "Once more with feeling." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100351 (owner: 10Legoktm) [18:41:36] anomie: hmm, so in core imagelinks has the links directly pointed to where as GlobalUsage resolves the redirects...if TIMES_ONLY is used that behavior will change [18:41:51] (03Merged) 10jenkins-bot: Use localized link to Special:Preferences [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100351 (owner: 10Legoktm) [18:41:55] marktraceur: i have +2 in core and all extensions and probably something else (like most people with +2 i think) [18:42:12] the invalidation jobs check the redirect tables, so purges would work fine, but the "usages" list would change [18:42:22] i've gotten emails asking me to review, so i'm reviewing. :P [18:42:34] Review all the changes :D [18:43:08] vandrew: do you want that deleted or what? [18:43:53] AaronSchulz: Hmm. If I recall correctly, people will get upset if global usage for File:Foo.png doesn't report uses via File:Redirect_to_Foo.png. [18:43:54] MatmaRex: That's magical and awesome [18:44:22] thedj_: Around? :P [18:44:43] AaronSchulz: OTOH, I suspect they'd be happy if they can look at File:Redirect_to_Foo.png and see just those usages there. [18:44:55] vandrew: well, done; let me know if I misunderstood [18:44:57] (just like templatelinks, in other words) [18:45:00] MatmaRex: Do you have any a11y changes left open? I kind of lost the overview :P [18:45:27] a11y sounds war-ish [18:45:58] :P accessibility is such a long word [18:46:01] anomie: it looks like templates links register both [18:46:09] in statelessFetchTemplate() [18:46:09] I have no idea who invented that shortage (and why) [18:46:13] AaronSchulz: Exactly [18:46:29] (03Abandoned) 10Kaldari: Conditionally add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 (owner: 10Kaldari) [18:46:29] we should really be more consistent with these ;) [18:47:16] hoo: you mean my changes? i don't think i have anything specifically a11y-related [18:47:24] Ok :P [18:47:33] i have a bunch of interface stuffs [18:47:43] Going to do some volunteer stuffs now :D [18:50:46] anomie: if there was a NAMES_ONLY flag it could return a (search name => final name) map [18:52:43] AaronSchulz: Could work, but then you might also want NAME_AND_TIME_ONLY. Maybe instead of TIME_ONLY. [18:53:02] (the idea being that name and time are what you need to fetch the particular File object) [18:53:18] (03PS1) 10Kaldari: Adding convenience function isDisambiguationPage [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100413 [18:54:38] anomie: I could replace TIME_ONLY, yes [18:58:10] (03PS2) 10Kaldari: Adding convenience function isDisambiguationPage [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100413 [19:03:33] (03PS3) 10Kaldari: Adding convenience function isDisambiguationPage [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100413 [19:08:12] Nemo_bis: I have to delete the page and make a test [19:08:20] (03PS1) 10Yaron Koren: New version: 0.4.1 [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/100417 [19:08:54] I've spoken with chirsmcmalaunch and he said that will grant me administrator priviliges [19:09:21] I'm wokind making tests and I need to see how to processes woked, thanks for the help [19:11:29] (03CR) 10Yaron Koren: [C: 032 V: 032] New version: 0.4.1 [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/100417 (owner: 10Yaron Koren) [19:17:03] (03PS1) 10Ebrahim: i18n: Adding Persian namespaces [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 [19:17:44] vandrew: I've already deleted the page [19:19:17] (03CR) 10saper: [C: 031] "Next patch addresses minor nitpicks." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/100183 (owner: 10saper) [19:21:40] (03PS2) 10saper: Teach ORMTable to use sequences [core] - 10https://gerrit.wikimedia.org/r/100183 [19:24:43] (03PS1) 10Matthias Mullie: Small collapser CSS tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/100420 [19:25:34] (03CR) 10Calak: [C: 031] i18n: Adding Persian namespaces [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:28:23] (03CR) 10Siebrand: [C: 032] i18n: Adding Persian namespaces [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:28:37] (03CR) 10jenkins-bot: [V: 04-1] i18n: Adding Persian namespaces [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:29:42] Nemo_bis: I know, and it worked, I already wrote that in delete_item.feature [19:31:48] (03CR) 10Ebrahim: ""19:28:36 PHP Fatal error: Class EducationProgram\OrgPage contains 1 abstract method and must therefore be declared abstract or implement" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:42:15] (03CR) 10EBernhardson: "Is this still being persued? Should either be updated or abandonded." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [19:42:19] (03CR) 10Siebrand: "This issue should be resolved. I have no idea how that code could have been merged. Will look and see where it happened." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:45:37] (03CR) 10Siebrand: [C: 032] i18n: Adding Persian namespaces [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:45:42] (03CR) 10jenkins-bot: [V: 04-1] i18n: Adding Persian namespaces [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:45:57] Nemo_bis, is this task completed? http://www.google-melange.com/gci/task/view/google/gci2013/5299345800822784 [19:45:58] Make MediaWiki documentation translatable [19:45:58] Status: NeedsReview (2 days, 9 hours left) [19:45:58] Mentor(s): Guillaume Paumier, Quim Gil [19:47:01] qgil: checking [19:47:27] huh, we have a gcibot. [19:47:42] same reaction, MatmaRex [19:47:55] it first was on #wikimedia... [19:49:05] qgil: it's exactly 90.0 % complete according to the requirements we set, maybe accept it and note that for the next iteration we'd need slightly more "volume"? [19:49:53] Nemo_bis, meh, considering that it is not his first task of this type, and con sidering that these tasks are not complex, I will still ask for 100%. Thanks! [19:49:54] Can I work on a bug which has an assignee or I should ask the assignee and wait for a response? :) [19:49:56] or he can do another (small) page if we want to follow the numbers [19:50:09] yep [19:50:21] MegaAlex, hi! Bug number? [19:50:52] 18515 [19:51:18] (03CR) 10Siebrand: "I don't see where this was introduced. Previous submits didn't fail. I'll ask @hashar if something changed in CI." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:52:46] Hm.. What is User [Nobody] ? [19:52:52] (03CR) 10Siebrand: [V: 032] "Force merging this. The test fail is not caused by this patch set." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:52:52] Related to ECho [19:53:11] Krinkle: it happens when a revision was deleted or oversighted [19:53:23] MegaAlex, it was assigned to JeroenDeDauw just few days ago. If you are interested in that report ping him here (I just did) :) or comment in the bug report [19:53:26] > [[User:[Nobody]|[Nobody]]] thanked you for your edit on MediaWiki talk:Gadget-UTCLiveClock.js. [19:53:34] (03CR) 10Ebrahim: "Thank you so much" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [19:53:42] hm. well, in this case it's a bug. :P [19:53:47] Doesn't parse well in wikitext, causes the syntax to be shown to the user. [19:54:40] qgil: mmkay, thanks for the info :) [19:55:56] (03PS3) 10saper: Add missing uploadstash.us_props for PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/99676 [19:56:19] Krinkle: file a bug, then, i've never seen this before [19:56:26] (apart from for deleted revisions) [20:02:25] spagewmf: Unfortunately we can't: Copyright ©2013 Scrum Alliance, Inc. – All rights reserved on http://www.scrumalliance.org/community/articles/2007/march/glossary-of-scrum-terms [20:02:39] MatmaRex: When the edit is hidden, or the thanks-log entry? [20:04:05] Krinkle: the edit, i think [20:07:56] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=58234 [20:10:26] marktraceur: Do you need someone to review https://gerrit.wikimedia.org/r/#/c/99722/ ? [20:16:15] James_F: Sort of but not really - could be aarcos as much as anyone [20:17:10] marktraceur: Kk. Would be nice to get it out soon, though. :-) [20:17:27] Yarp [20:17:35] James_F: If someone !== aarcos has time, then go nuts [20:17:46] (03CR) 10Ebrahim: "Hmm. Seems not merged https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FEducationProgram" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [20:18:16] (03PS1) 10Cicalese: Updated extension credits and added acknowledgements. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100426 [20:20:48] marktraceur: I don't want to steal his fun. :-) [20:20:54] (03CR) 10Cicalese: [V: 032] Updated extension credits and added acknowledgements. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100426 (owner: 10Cicalese) [20:21:12] (03CR) 10Cicalese: [C: 032] Updated extension credits and added acknowledgements. [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/100426 (owner: 10Cicalese) [20:23:21] (03CR) 10Edokter: [C: 031] mediawiki.hlist: Remove skin-specific styles [core] - 10https://gerrit.wikimedia.org/r/99805 (owner: 10Bartosz Dziewoński) [20:30:20] greg-g: is there room in the schedule today for me to play around with the Collection extension -- it looks like an update broke it; but I can't reproduce it on my test install and we don't have a beta instance of it set up [20:30:43] basically; I'm going to roll back to the beginning of november before we started futzing with it [20:30:49] and see if that helps [20:31:34] baha [20:31:58] mwalker: yeah, one sec [20:37:15] (03CR) 10Hashar: "THANK YOU!!! Now we need unit tests :-]" [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [20:46:31] (03PS4) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [20:51:27] (03CR) 10Siebrand: "Wrong button. I don't merge manually any more, so I forgot how it works :)." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [20:56:16] (03CR) 10Calak: "Thanks!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/100418 (owner: 10Ebrahim) [21:03:11] (03CR) 10Hashar: "There is at least one other occurrence of setId( 1 ) in includes/LanguageConverterTest.php :" [core] - 10https://gerrit.wikimedia.org/r/99640 (owner: 10saper) [21:06:43] Yay, we have hdpi thumbs on the file page now! [21:10:32] Krinkle: yay GCI :) [21:10:49] (03CR) 10saper: "I think LanguageConverterTest is okay because it does not touch database at all, those are in-memory User objects and I believe they do no" [core] - 10https://gerrit.wikimedia.org/r/99640 (owner: 10saper) [21:10:55] (you should totally mentor more tasks :P) [21:11:20] (03PS3) 10Jackmcbarn: Add index on logging.log_user_text [core] - 10https://gerrit.wikimedia.org/r/85508 [21:11:59] (03CR) 10Legoktm: "Bsitu needs to remove his -2 on I863cf068754723701c26ba575c94a9852cac240e so that can be merged, and then this one can be merged." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/80710 (owner: 10Legoktm) [21:12:22] MatmaRex: I haven't mentorred any tasks and have no time available to do so. [21:12:36] other than through regular code review, which is still backlogged 2-3 weeks right now. [21:13:27] (03CR) 10Jackmcbarn: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/85508 (owner: 10Jackmcbarn) [21:13:50] Krinkle: yeah. (well, you mentored one indirectly since i dragged you into it ;) ) [21:14:27] We're an open source project that takes pull requests, if they provide a good patch and don't require basic setup help from my end, it rolls in normally. That's great. [21:17:34] (03PS1) 10Cscott: Update README. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100438 [21:17:35] (03PS1) 10Cscott: Remove unused dependency on `request` package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100439 [21:19:16] (03PS1) 10BryanDavis: Respect X-Forwarded-For header when present [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/100440 [21:25:20] (03PS1) 10Sharihareswara: fixing merge conflict [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/100456 [21:25:38] (03PS2) 10Cscott: Update README. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100438 [21:25:39] (03PS2) 10Cscott: Remove unused dependency on `request` package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100439 [21:30:21] (03PS1) 10Cscott: Update README with information on NPM package name and links. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/100473 [21:36:21] (03CR) 10Cscott: [C: 032] Remove unused dependency on `request` package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100439 (owner: 10Cscott) [21:36:29] (03CR) 10Cscott: [C: 032] Update README. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100438 (owner: 10Cscott) [21:36:48] (03CR) 10Cscott: [C: 032] Update README with information on NPM package name and links. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/100473 (owner: 10Cscott) [21:43:05] (03Merged) 10jenkins-bot: Remove unused dependency on `request` package. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100439 (owner: 10Cscott) [21:43:44] (03Merged) 10jenkins-bot: Update README. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100438 (owner: 10Cscott) [21:47:05] (03Merged) 10jenkins-bot: Update README with information on NPM package name and links. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/100473 (owner: 10Cscott) [21:47:44] (03CR) 10Hashar: [C: 032] "Thanks Saper, works for me!" [core] - 10https://gerrit.wikimedia.org/r/99640 (owner: 10saper) [21:50:52] (03Merged) 10jenkins-bot: Don't assume test user has ID 1 in SpecialPageTest [core] - 10https://gerrit.wikimedia.org/r/99640 (owner: 10saper) [21:51:34] (03PS1) 10Aaron Schulz: Changed TIME_ONLY to NAME_AND_TIME_ONLY in FileRepo [core] - 10https://gerrit.wikimedia.org/r/100478 [21:52:06] hey greg-g, regarding the whitelist for gwtoolset, wgCopyUploadsDomains. i've just added some instructions to the extension, but david and i are wondering if it would be okay to actually display the currently whitelisted domains ... [21:55:20] (03CR) 10saper: "\o/ Thanks!" [core] - 10https://gerrit.wikimedia.org/r/99640 (owner: 10saper) [21:57:03] dan-nl: I'm not the ultimate authority, but it seems to me like showing the whitelist should be ok because the config is already public via the git repository. [21:57:37] bd808: :) [21:58:25] (03PS2) 10MaxSem: WIP: add new one-column diff mode [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/99541 [21:59:47] (03PS1) 10Cscott: Fix missing font package in Travis configuration. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100479 [22:13:21] (03PS6) 10Dan-nl: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:14:57] (03PS1) 10Legoktm: Use Message::text instead of relying on Message::_toString [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100482 [22:15:20] (03CR) 10Siebrand: [C: 04-1] i18n review: Updates for messages, code and documentation (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:16:16] (03CR) 10Dan-nl: "- addressed the last of the @todo’s" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:17:27] (03CR) 10MarkTraceur: "Booo, l10n-bot, you ruin everyone's fun." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100000 (owner: 10L10n-bot) [22:17:43] James_F, ori-l, et al., could use a reviewer on https://gerrit.wikimedia.org/r/#/c/100481/1 (VE on Draft namespace on Beta Labs), if you can spare a few minutes. [22:17:58] Let me know if I can review something as well. [22:18:04] (03CR) 10Dan-nl: [C: 031] i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:18:07] legoktm, MatmaRex mwalker do you think that this patch is good enough to close http://www.google-melange.com/gci/task/view/google/gci2013/5836804318035968 ? [22:18:07] siebrand: let me know if you need anything else on https://gerrit.wikimedia.org/r/#/c/99631/ otherwise it's fine to merge by me. [22:18:08] BookManager v2: Implement keyboard navigation [22:18:08] Status: NeedsReview (19 hours, 19 minutes left) [22:18:08] Mentor(s): Andre Klapper, Quim Gil, Raylton P. Sousa, Kunal Mehta [22:18:28] superm401: +2'd [22:18:45] Thanks, ori-l [22:18:52] dan-nl: Already reviewed. 1 thing missing (numParams() instead of params()) [22:19:42] qgil: uh, not today :) it looked okay last time i looked [22:19:47] wants to find an IRC channel with people from w3.org [22:19:50] (not today = don't ask me today :) ) [22:20:08] siebrand: k, i'll add that [22:20:37] MatmaRex, I might close it asking Jared to still listen to feedback. After 7 patches (and previous GCI tasks closed) I think we can trust him [22:21:23] qgil: it doesn't totally meet our coding standard; but the logic itself seems ok [22:21:26] has it been tested? [22:21:59] (actually I'm not sure what I would nitpick is in our standard; it's just convention that seems to be followed elsewhere -- so I'm ok pushing it) [22:22:15] (03PS7) 10Dan-nl: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:22:52] (03CR) 10Dan-nl: [C: 031] "- added the numParams siebrand mentioned is ps6." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:23:01] (03CR) 10Siebrand: [C: 031] "Should be good to go." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:23:17] mwalker, thank you. We have time pressure to review the GCI task but then we can still aim for A Good Patch in Gerrit. If you can leave feedback in the Gerrit change, perfect. [22:23:17] (03CR) 10Siebrand: [C: 032] i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:23:47] (03Merged) 10jenkins-bot: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [22:24:29] dan-nl: Can Raymond_ now add localisation for GWToolset in translatewiki.net? [22:25:32] siebrand: let's wait one more day. david is still testing and there may be a few changes he'll still want to make [22:26:01] dan-nl: Do you identify the possibility that 25% or more of the L10n will be changed? [22:26:10] no [22:26:20] * Raymond_ listens [22:26:52] siebrand: i estimate a potential for 7% change [22:27:19] in phase 2 … there may be more [22:27:31] dan-nl: Then we can just go ahead <--- Raymond_ ;) [22:27:33] dan-nl. siebrand I will do an i18n review tomorrow [22:27:47] dan-nl. siebrand and add the extension [22:27:51] Didn't work. Debugging now. [22:28:02] Raymond_: Just done, and merged, I think. I spent about 2 hours on Friday. [22:28:12] siebrand: ah great1 [22:28:14] ! [22:28:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=56740 Typing "!" into a channel shouldn't cause the bot to print the list of all bangcodes it knows [22:28:20] Wait, never mind, looks right now. [22:28:31] (03PS1) 10Chad: Update Elastica to 0.90.7 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/100483 [22:28:33] lolol [22:28:59] ! | wm-bot [22:28:59] wm-bot: https://bugzilla.wikimedia.org/show_bug.cgi?id=56740 Typing "!" into a channel shouldn't cause the bot to print the list of all bangcodes it knows [22:30:25] cool, thanks Raymond_ and siebrand [22:31:12] (03CR) 10Chad: [C: 031] Use Message::text instead of relying on Message::_toString [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100482 (owner: 10Legoktm) [22:32:46] "bangcodes" [22:40:13] RoanKattouw: do you know where in the code I can find where we declare keyboard shortcuts? [22:40:34] mwalker: In MW core? [22:40:38] *nods* [22:40:44] or [22:40:45] in VE [22:40:48] <^d> manybubbles: Ask and you shall receive: https://gerrit.wikimedia.org/r/#/c/100483/ [22:41:12] I want a million swiss francs. [22:41:16] thank you! I'll run the regressions against it tomorrow I think then merge it [22:41:32] RoanKattouw: I'm attempting to see an example of how it internationalizes to different keyboards [22:41:41] (03PS1) 10Legoktm: Support BasicFormatter::getLinkParams returning raw urls [extensions/Echo] - 10https://gerrit.wikimedia.org/r/100491 [22:41:58] mwalker: See the accesskey-* i18n messages for keyboard shortcuts in MW [22:42:10] For VE, I don't think we have internationalized keyboard shortcuts at this time [22:42:19] <^d> Amgine: Terms and conditions may apply. Not all requests can be honored. Void where prohibited. Must be 18 years or older to play. [22:42:53] Void where prohibited is a hilarious disclaimer [22:43:05] the hell is elastica? [22:43:45] dan-nl: bd808 yeah, I'm leaning towards probably ok. How is access handed out to use GWToolset anyways? [22:43:48] (I should know this) [22:43:51] Amgine: I got a nigerian friend that can help you proceed with your 1 Million swiss francs. He is quite cheap (roughly 2000$) [22:44:34] Amgine: https://en.wikipedia.org/wiki/419_scams :D [22:44:36] greg-g: an admin will have to add them to the gwtoolset group … i'm not sure yet how those requests will come in though [22:44:38] (03PS2) 10Legoktm: Support BasicFormatter::getLinkParams returning raw urls [extensions/Echo] - 10https://gerrit.wikimedia.org/r/100491 [22:44:52] dan-nl: yeah, gotcha. Then I'm ok with it. [22:44:56] (displaying the list) [22:44:59] (03CR) 10Legoktm: "Ie18698e3ef755ca5a2cecc1f1cfb4254184bb576 is the echo change" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [22:44:59] greg-g: AaronSchulz: arch I forgot to talk about Swift volumes during our meeting :( [22:45:05] cool, i'll create a patch for it [22:45:10] hashar: what about 'em? [22:45:15] hashar: btw, the existing npm-test macro is very different [22:45:19] hashar: it doesn't fetch anything from a remote server [22:45:21] (03CR) 10MarkTraceur: [C: 032] Use Message::text instead of relying on Message::_toString [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100482 (owner: 10Legoktm) [22:45:27] (03Merged) 10jenkins-bot: Use Message::text instead of relying on Message::_toString [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/100482 (owner: 10Legoktm) [22:45:31] legoktm: There ya go [22:45:37] hashar: it merely uses the npm shell script to read package.json and execute the 'test' command. [22:45:42] marktraceur: thanks :) [22:45:43] legoktm: I'd *like* tests for that. [22:45:50] tests for? [22:45:52] greg-g: gwtoolset would need a swift volume but I have no idea how to set one up on the cluster nor what kind of information is needed :D I mailed you + dan-nl + some others [22:45:55] For the issue you mentioned in -staff. [22:46:02] ah [22:46:07] not sure how to write tests for that... [22:46:09] hashar: oh right, that... dangit [22:46:21] yes dangit ;) [22:46:41] legoktm: tests/HTMLTextBlockFieldTest.php should exist in some form [22:46:44] greg-g: I am sure AaronSchulz can help on getting us a Swift volume. He must know who to poke. [22:46:45] You can test it there [22:47:00] hashar: where? production? [22:47:08] marktraceur: I don't think that would have caught this bug though [22:47:16] Krinkle: the npm test macro is being used by some sub repositories of the Collection extension (for the pdf sprint) [22:47:17] btw, david is okay with us moving the extension to production this thursday if that's what you meant in the email greg-g [22:47:27] Krinkle: might want to double check it is still working for those jobs. [22:47:38] hashar: yeah, but they commit node_modules to a git repository elsewhere. [22:47:39] AaronSchulz: yeah in production, we don't have swift on beta [22:47:48] dan-nl: yeah, if we're ready. I hope we can be [22:48:22] greg-g: i think we only need to sort out the swift config hashar just mentioned [22:48:26] legoktm: No, which is why you should write a test that would have failed, and then we can have it in the future. [22:48:30] hashar: I wasn't sure if people were saying it was needed there for some weird reason [22:48:57] (03PS1) 10CSteipp: Update CentralAuth to master for wmf5 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100492 [22:48:59] hashar: there wouldn't be any new "volumes" since it's not mounted or anything, and the container could be made by MediaWiki [22:49:11] I don't there is really anything to do there afaik [22:49:11] ah volume/container so :-] [22:49:38] so if $wgFileBackend swiftSomethingClass has a new container name, mediawiki will magically create the container in Swift for us ? [22:49:45] (03CR) 10CSteipp: [C: 032] Update CentralAuth to master for wmf5 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100492 (owner: 10CSteipp) [22:49:53] marktraceur: but the bug wasn't in the HTMLTextBlockField class, so a test there *should not* catch this bug. [22:50:06] AaronSchulz: i just need help figuring out the config then ... [22:50:08] AaronSchulz: I am going to need one to host the MediaWiki tarballs as well :D [22:50:31] or will Reedy take care of the config? [22:51:21] (03PS2) 10Aaron Schulz: Use FileRepo::findFiles() to avoid a bunch of queries [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/99527 [22:51:33] (03CR) 10Aaron Schulz: "Now depends on https://gerrit.wikimedia.org/r/#/c/100478/1" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/99527 (owner: 10Aaron Schulz) [22:52:04] legoktm: Oh, OK then. [22:52:13] legoktm: There might be a test that would work somewhere, but whatever [22:54:37] (03CR) 10Esanders: "This may be the most boring commit in the whole repository." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100000 (owner: 10L10n-bot) [22:54:51] (03Merged) 10jenkins-bot: Update CentralAuth to master for wmf5 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/100492 (owner: 10CSteipp) [22:55:21] i am off to bed, see you tomorrow [22:58:28] AaronSchulz: help with that swift/gwtoolset thing is appreciated [22:58:36] AaronSchulz: just saying, no rush right this minute [22:59:00] thanks greg-g [22:59:06] (03CR) 10Mwalker: "I have some styling feedback, a query on i18n support; and..." (034 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [22:59:59] (03PS1) 10Cscott: Add texlive-generic-extra package to dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100495 [23:00:02] AaronSchulz: we can pick it up tomorrow if that fits better with your schedule [23:00:15] (03CR) 10Cscott: [C: 032] Fix missing font package in Travis configuration. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100479 (owner: 10Cscott) [23:00:23] (03CR) 10Cscott: [C: 032] Add texlive-generic-extra package to dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100495 (owner: 10Cscott) [23:01:15] (03Merged) 10jenkins-bot: Fix missing font package in Travis configuration. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100479 (owner: 10Cscott) [23:01:50] (03Merged) 10jenkins-bot: Add texlive-generic-extra package to dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/100495 (owner: 10Cscott) [23:08:14] sounds like $wgGWTFileBackend = 'local-multiwrite'; [23:08:42] I don't see a need to touch filebackend.php, so there isn't really anything special to do in this case [23:11:45] AaronSchulz: cool, so we just use the 'local-multiwrite' and that's it? [23:12:21] can anyone point to an edit by an anonymous ipv6 user on any wiki? I'm just curious how it ends up getting displayed [23:12:38] do we have to worry about the server keeping the store private? or will the prepare() method be enough? [23:12:59] that's enough [23:13:12] ebernhardson: https://en.wikipedia.org/w/index.php?title=Slovaks&diff=prev&oldid=497417268 [23:13:23] AaronSchulz: thanks! [23:21:03] (03Abandoned) 10Krinkle: Create new "qunitfile" macro and use in oojs-core [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99304 (owner: 10Krinkle) [23:50:05] (03PS1) 10Chad: Adding .gitreview [uxprototypes] - 10https://gerrit.wikimedia.org/r/100505 [23:50:38] (03CR) 10Chad: [C: 032 V: 032] Adding .gitreview [uxprototypes] - 10https://gerrit.wikimedia.org/r/100505 (owner: 10Chad) [23:55:51] (03PS1) 10Catrope: Update VisualEditor to wmf6 branch for cherry-picks [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/100506