[00:03:01] (03CR) 10Bartosz Dziewoński: "But… this still fires a query for each link? :(" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 (owner: 10Kaldari) [01:46:18] (03CR) 10Legoktm: "Code works fine, just a few coding convention issues, see https://www.mediawiki.org/wiki/CC/JS#Whitespace and the inline comments." (034 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [01:47:14] MatmaRex: if you have some time, can you look at ^ and make sure that's the best/proper way to implement that? [01:47:49] i don't even know what BookManagerv2 is D: [01:48:01] neither do I! [01:48:57] basically it has a nav bar at the top, and this just makes the arrow keys work [01:49:36] MatmaRex: http://cl.ly/image/2e3i0S1l1b0N is what it looks like [01:51:32] the code looks reasonable enough for such a stupid feature [01:51:43] :D [01:53:42] (03CR) 10Bartosz Dziewoński: Implement keyboard navigation for BookManagerv2 (033 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [01:53:53] i mean, i have absolutely no idea why would anyone want this [01:54:21] its for wikisource I think [02:18:25] (03PS1) 10Bartosz Dziewoński: Release notes for I0ef9674e [core] - 10https://gerrit.wikimedia.org/r/100196 [02:20:43] (03CR) 10Legoktm: [C: 032] Release notes for I0ef9674e [core] - 10https://gerrit.wikimedia.org/r/100196 (owner: 10Bartosz Dziewoński) [02:21:22] (03CR) 10Bartosz Dziewoński: "Probably. https://gerrit.wikimedia.org/r/100196" [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [02:23:31] (03Merged) 10jenkins-bot: Release notes for I0ef9674e [core] - 10https://gerrit.wikimedia.org/r/100196 (owner: 10Bartosz Dziewoński) [02:30:32] (03PS2) 10Jcf2000: Implement keyboard navigation for BookManagerv2 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 [02:31:55] "!document.activeElement === 'body'" :/ [02:33:31] (03CR) 10Jcf2000: "Thanks for your input (:" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [02:35:33] legoktm: aw, heh [02:35:35] hey legoktm, do you happen to have admin access to http://commons.wikimedia.beta.wmflabs.org/ [02:35:39] i guess i should have been more explicit [02:35:54] dan-nl: I have no clue, let me find out [02:36:44] dan-nl: I see a delete button so looks like it [02:36:52] * YuviPanda deletes legoktm [02:36:57] ha! [02:37:29] do you want me to do something? [02:37:44] i'm wondering if it's possible to make sure the cron job that's running the maintenance/runJobs.php script is running as www [02:37:54] ohohoh, I don't have shell access [02:38:17] the gwtoolset extension is using the filebackend to store metadata files in a fb store [02:38:38] oh, okay, np then … guess i need to ask for that next time ;) [02:38:52] I think aude does? [02:39:34] (03CR) 10Jcf2000: "On line 24, would it be function(e) or function( e )?" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [02:39:49] hmm … aude mentioned something about being added to deployment-prep, can you add me to that? [02:40:07] dan-nl: I do have access [02:40:13] oh cool [02:40:13] dan-nl: https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep <-- look at the admins list [02:40:50] YuviPanda: would you be able to add me to that group so i could do it on my own? [02:40:56] dan-nl: actually I got removed in the cleanup :P [02:41:02] I didn't realize that. sorry [02:41:04] thanks legoktm [02:41:11] YuviPanda: np [02:41:23] dan-nl: your best bet for today is probably Reedy or ori-l, our resident workaholics [02:41:42] thanks! [02:41:52] or to be exact, amongst some of our resident workaholics :) [02:42:42] Reedy, ori-l, would you be able to allow me to have shell access to http://commons.wikimedia.beta.wmflabs.org/? or help me check the fb for that server? [02:43:29] basically i need to sort out if it's okay for the cronjob that runs maintenance/runJobs.php to run as www [02:43:59] how you doing YuviPanda? [02:44:21] dan-nl: not bad at all :) [02:44:31] Been reducing the amount of PHP in my life for sanity reasons, though :D [02:44:39] lol [02:44:53] dan-nl: :D [02:45:09] grunting and angling more to you're liking? [02:45:13] used to be very active in doing labs work, but have taken a break for now :P [02:45:29] dan-nl: no, right now it is Java (Android app!), and am learning... x86 ASM on the side :) [02:46:09] ah, so you decided to go native [02:46:18] dan-nl: yup!! [02:46:37] x86 ASM, now there's an interesting language! [02:46:48] soon you'll only be speaking in hex [02:47:16] dan-nl: hehe :D Not going to be able to actually build something there, but am learning it so I can eventually read / hack on kernel code [02:47:42] wow, interesting direction, haven't thought about doing that yet ... [02:48:42] dan-nl: well, my direction was BASIC -> C -> VB -> VB.NET -> C# -> Python -> C/GTK -> Vala -> JS -> PHP/JS -> Java [02:48:53] (over about 12 years :P) [02:49:02] my gosh! [02:49:04] dan-nl: so it's more like going back a few steps to 'roots'. [02:49:05] that's nice! [02:49:08] yeah! [02:49:41] dan-nl: I'm right now hacking on https://github.com/yuvipanda/AndroLua as well - a way to write code on tablets directly in lua [02:49:48] exploring how much we can do on a tablet form factor... [02:50:38] interesting indeed! [02:51:46] so you believe it would be easier to program in lua than in Java or, is it C++ ? [02:53:00] dan-nl: well, I don't know :) [02:53:06] dan-nl: definitely easier than Java or C++ [02:53:17] i see [02:53:20] neat idea [02:53:24] dan-nl: I personally 'got' programming with BASIC, LOGO and C, so maybe I'm biased :) [02:53:46] ah logo, now that was fun! [02:53:52] I remember how I got to draw one petal, and then suddenly realized I could 'loop' them 8 times with different start points to get a full flower [02:53:58] move that turtle, fast! [02:54:07] as long as the offset * number of loops are equal to 360 [02:54:33] nice :) [02:54:42] dan-nl: yup! :) good times [02:54:52] dan-nl: working on the revamped Wikipedia app in the rest of my time [02:55:22] are you working for the foundation as a contractor? [02:56:45] dan-nl: yeah [02:57:02] dan-nl: well, it's a bit of a murky line since everyone outside the US is a contractor, and I am [02:57:04] outside the US [02:57:13] :) [03:01:34] (03CR) 10Bartosz Dziewoński: [C: 04-1] "It would, in fact, be "function ( e )" (that's even more spaces! ;) ) – we add a space after keywords, and 'function' is a keyword like 'i" (032 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [03:07:28] (03PS8) 10Legoktm: Load scripts and styles via ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [03:08:30] (03PS3) 10Jcf2000: Implement keyboard navigation for BookManagerv2 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 [03:31:54] (03CR) 10Theopolisme: Implement keyboard navigation for BookManagerv2 (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [04:30:10] (03PS4) 1001tonythomas: Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 [04:41:00] (03PS4) 10BryanDavis: Include error code in error message when convert fails [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [04:44:35] (03CR) 10BryanDavis: "Rebased manually. Apparently git wasn't able to handle that fact that an empty line had been added just before the return statement." [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [04:45:36] (03CR) 10Kaldari: "Yes, but the only people who should notice any difference are the people who opt into the feature. Rendering time should remain the same f" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 (owner: 10Kaldari) [04:51:10] (03CR) 10BryanDavis: [C: 032] Include error code in error message when convert fails [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [04:54:08] (03Merged) 10jenkins-bot: Include error code in error message when convert fails [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [06:07:51] (03PS3) 10BryanDavis: Made redis lock manager get EX/SH locks in one go [core] - 10https://gerrit.wikimedia.org/r/91325 (owner: 10Aaron Schulz) [06:09:15] (03CR) 10BryanDavis: "Manual rebase." [core] - 10https://gerrit.wikimedia.org/r/91325 (owner: 10Aaron Schulz) [06:09:51] (03CR) 10BryanDavis: [C: 032] "Tested using eval.php on vagrant image as suggested by Aaron." [core] - 10https://gerrit.wikimedia.org/r/91325 (owner: 10Aaron Schulz) [06:12:53] (03Merged) 10jenkins-bot: Made redis lock manager get EX/SH locks in one go [core] - 10https://gerrit.wikimedia.org/r/91325 (owner: 10Aaron Schulz) [06:13:09] (03PS4) 10Jcf2000: Implement keyboard navigation for BookManagerv2 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 [06:14:06] (03CR) 10Jcf2000: "Theopolisme: Thanks for the suggestion (:" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [06:21:57] (03CR) 10Theopolisme: Implement keyboard navigation for BookManagerv2 (032 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [06:24:09] (03PS3) 10BryanDavis: filebackend: exception handling cleanups [core] - 10https://gerrit.wikimedia.org/r/97336 (owner: 10Aaron Schulz) [06:24:38] (03CR) 10BryanDavis: "Manual rebase." [core] - 10https://gerrit.wikimedia.org/r/97336 (owner: 10Aaron Schulz) [06:25:02] (03CR) 10BryanDavis: [C: 032] filebackend: exception handling cleanups [core] - 10https://gerrit.wikimedia.org/r/97336 (owner: 10Aaron Schulz) [06:25:26] (03CR) 10Legoktm: "Can release notes be added for this please?" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [06:28:11] (03PS5) 10Jcf2000: Implement keyboard navigation for BookManagerv2 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 [06:28:56] (03Merged) 10jenkins-bot: filebackend: exception handling cleanups [core] - 10https://gerrit.wikimedia.org/r/97336 (owner: 10Aaron Schulz) [06:42:04] (03CR) 10BryanDavis: [C: 031] "Should this change be mentioned in the release notes?" [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [09:29:36] Hello [09:31:57] uga [09:33:12] (03PS1) 10Umherirrender: Break long lines and remove some spaces in QueryPage.php [core] - 10https://gerrit.wikimedia.org/r/100197 [09:37:22] (03PS4) 10Siebrand: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 [09:37:36] (03CR) 10Siebrand: "Rebased to remove merge conflict." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [09:39:36] where can I find documentation about the User management/permission system? [09:40:05] (03CR) 10Siebrand: "PS2 is a manual rebase to remove merge conflict." [core] - 10https://gerrit.wikimedia.org/r/99468 (owner: 10Siebrand) [09:42:42] (03CR) 10Siebrand: [C: 04-1] Break long lines and remove some spaces in QueryPage.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100197 (owner: 10Umherirrender) [09:46:33] (03PS2) 10Siebrand: Some more formatting fixes for media classes [core] - 10https://gerrit.wikimedia.org/r/99468 [09:49:13] (03PS2) 10Umherirrender: Break long lines and remove some spaces in QueryPage.php [core] - 10https://gerrit.wikimedia.org/r/100197 [09:49:38] (03CR) 10Umherirrender: Break long lines and remove some spaces in QueryPage.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100197 (owner: 10Umherirrender) [09:50:44] (03CR) 10Siebrand: "PS6 fixes merge conflicts." [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [09:50:47] (03PS6) 10Siebrand: Replace and by and in i18n [core] - 10https://gerrit.wikimedia.org/r/99195 [09:52:00] (03CR) 10Siebrand: [C: 032] Break long lines and remove some spaces in QueryPage.php [core] - 10https://gerrit.wikimedia.org/r/100197 (owner: 10Umherirrender) [09:55:09] (03CR) 10Calak: [C: 031] i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [09:56:49] (03Merged) 10jenkins-bot: Break long lines and remove some spaces in QueryPage.php [core] - 10https://gerrit.wikimedia.org/r/100197 (owner: 10Umherirrender) [10:00:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n changes LGTM." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas) [10:04:40] (03PS1) 10Umherirrender: Raw option of parser functions should match complete word [core] - 10https://gerrit.wikimedia.org/r/100198 [10:19:51] (03PS1) 10Umherirrender: Silencing errors is discouraged [core] - 10https://gerrit.wikimedia.org/r/100199 [10:23:26] (03PS2) 10Umherirrender: Silencing errors is discouraged [core] - 10https://gerrit.wikimedia.org/r/100199 [10:41:38] (03PS1) 10leucosticte: Move PerPageLicense class to its own file [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/100202 [10:55:50] cscott_away: am playing with sharejs for a side project of mine. seems rather cool :) [11:03:24] (03CR) 10TTO: Replace and by and in i18n (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [11:05:08] (03CR) 10Siebrand: [C: 04-1] "Looks like you forgot to "git add PerPageLicense.classes.php" before committing." [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/100202 (owner: 10leucosticte) [11:07:50] (03CR) 10Siebrand: Replace and by and in i18n (033 comments) [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [11:17:56] (03PS2) 10leucosticte: Move PerPageLicense class to its own file [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/100202 [11:20:43] (03CR) 10Siebrand: [C: 031] Move PerPageLicense class to its own file [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/100202 (owner: 10leucosticte) [14:03:09] Hi Nemo_bis, are you around? [14:04:26] sort of [14:04:39] I just have one quick question... [14:04:50] go ahead [14:05:27] When adding the tag at the top of the page, is that supposed to be for the 'Other languages' bit? [14:06:21] Because I added it at the top (and deleted {{languages}}), but the language selection feature isn't showing. [14:07:51] Btw, the page in question is here: https://www.mediawiki.org/wiki/Help:Protected_pages [14:45:31] (03CR) 10Bartosz Dziewoński: "I am still very uneasy about search&replacing these tags en masse." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [15:00:45] YuGin: it shows up after the page is marked [15:02:37] YuGin: you had forgotten some pieces again https://www.mediawiki.org/w/index.php?title=Help%3AProtected_pages&diff=838534&oldid=838518 [15:04:09] (03PS4) 10TheDJ: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 [15:04:46] (03CR) 10jenkins-bot: [V: 04-1] Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [15:05:57] Nemo_bis, is there a tutorial/ manual that details this? I cannot seem to find it anywhere... [15:10:13] (03PS5) 10TheDJ: Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 [15:12:40] YuGin: the page translation administration help page tells you need templates to call other templates and categories [15:13:06] it doesn't link mediawiki.org's versions because others may want slightly different ones, but those templates are documented [15:13:35] (03CR) 10jenkins-bot: [V: 04-1] Preferences: Improve accessibility of the JS tabs of Preferences [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [15:14:16] (03CR) 10Hoo man: [C: 04-1] "Qqq message missing" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [15:14:55] (03PS1) 10Bartosz Dziewoński: SpecialWantedcategories: Show more current information when in cached mode [core] - 10https://gerrit.wikimedia.org/r/100210 [15:15:54] (03CR) 10Bartosz Dziewoński: "Screenshot: http://i.imgur.com/JwpAyGr.png" [core] - 10https://gerrit.wikimedia.org/r/100210 (owner: 10Bartosz Dziewoński) [15:17:47] Nemo_bis- ok, thanks- so if I understand the admin help page correctly, that means that when the template detects the string 'TNT', it checks for a language code in the page name, then displays the appropriate language for 'PD Help Page'? [15:19:18] (03PS1) 10Anomie: Detect already-undone edits for undo [core] - 10https://gerrit.wikimedia.org/r/100211 [15:22:17] Nemo_bis, and what about {{langcat}}? What is its exact function? [15:22:18] YuGin: yes [15:22:25] same for category [15:22:43] /it subpages go into /it "subcategories" and so on [15:23:09] Hmm, but why didn't the original version of the page require it? [15:23:40] Or is the addition of {{langcat}} supposed to add a translation of the category? [15:27:15] YuGin: it just ensures that the category is not filled with all the translation pages in all languages [15:27:57] Nemo_bis, I see, thanks. [15:35:35] Nemo_bis, how do I handle {{Special page}}? {{TNT|Special page}} doesn't work. [15:36:00] This is the page: https://www.mediawiki.org/wiki/Help:Random_page [15:36:08] YuGin: I'll be offline for a few hours now, so please ping another translation admin if you need more pages approved (check the list in special:listusers; if you don't find them on #mediawiki they may be on #wikimedia-stewards, #wikimedia or #wikimedia-translation) [15:36:37] Oh, ok then. [15:36:45] that's not a translatable template; you need to check if the template is marked for translation or has /en etc. subpages [16:18:09] (03PS1) 10Bartosz Dziewoński: Release notes for Iabf4873f [core] - 10https://gerrit.wikimedia.org/r/100213 [16:18:22] (03CR) 10Bartosz Dziewoński: "Yeah, there should have been notes. But you know, I don't have a monopoly on adding them ;) https://gerrit.wikimedia.org/r/100213" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [16:22:23] (03CR) 10Scimonster: [C: 031] Release notes for Iabf4873f [core] - 10https://gerrit.wikimedia.org/r/100213 (owner: 10Bartosz Dziewoński) [16:26:05] (03CR) 10Bartosz Dziewoński: [C: 032] Release notes for Iabf4873f [core] - 10https://gerrit.wikimedia.org/r/100213 (owner: 10Bartosz Dziewoński) [16:28:56] (03Merged) 10jenkins-bot: Release notes for Iabf4873f [core] - 10https://gerrit.wikimedia.org/r/100213 (owner: 10Bartosz Dziewoński) [16:29:06] (03CR) 10Jack Phoenix: "See https://www.mediawiki.org/wiki/Register_globals , especially the sections "Sanitize custom global variables before use" and "Configure" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [16:31:29] (03CR) 10Bartosz Dziewoński: "I'd still like this to be solved "properly" (see bug 53945), but I guess this should be okay. Not sure what impact a couple thousand queri" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 (owner: 10Kaldari) [16:46:22] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks okay to me, I tested and it works as advertised. Could somebody i18n-inclined double-check?" [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [16:46:27] Nemo_bis: around? ^ [16:47:56] (03CR) 10Bartosz Dziewoński: "Do you think this should this have release notes?" [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [17:12:16] (03CR) 10UltrasonicNXT: "Docs added: https://www.mediawiki.org/w/index.php?title=Extension:Comments&stable=0&shownotice=1&fromsection=Parameters" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 (owner: 10UltrasonicNXT) [17:33:57] ori-l, hi, any new thoughts on json config? [18:02:18] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [18:05:44] (03PS5) 10Theopolisme: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [18:06:49] (03CR) 10jenkins-bot: [V: 04-1] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [18:09:00] (03PS6) 10Theopolisme: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [18:19:38] (03CR) 10Theopolisme: Implement keyboard navigation for BookManagerv2 (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [18:23:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Here are before and after screenshots from Opera 18 (using Chrome's Blink engine) on Windows XP:" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx) [18:25:00] (03CR) 10Bartosz Dziewoński: "(Also, this is a perfect opportunity to stuff something silly into the file icon, per bug 20281. Let's not miss it. :P)" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx) [18:31:25] (03CR) 10Bartosz Dziewoński: [C: 032] "OK, let's do this then. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [18:33:57] (03PS6) 10Bartosz Dziewoński: Hygiene: Cleanup IE6 specific rules by using * hack [core] - 10https://gerrit.wikimedia.org/r/94163 (owner: 10Jdlrobson) [18:34:35] (03Merged) 10jenkins-bot: Add search results found as parameter to showCreateLink [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [18:35:12] (03CR) 10Bartosz Dziewoński: "Wikitext I used for testing, for reference:" [core] - 10https://gerrit.wikimedia.org/r/98291 (owner: 10M4tx) [18:36:42] (03CR) 10TheDJ: "What's your opinion on the approach ?" [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [18:38:48] (03CR) 10Jcf2000: "Theopolisme: I agree with you on the up and down arrows. I was really using them as placeholders. I will also go ahead and fix the bracket" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [18:41:50] (03CR) 10Jcf2000: "Ah, I see what you mean with .click(). Hmmm, learn something new each day, right? Thanks, Theo. Good luck in GCI (:" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [18:47:46] (03PS6) 10Jcf2000: Implement keyboard navigation for BookManagerv2 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 [19:00:36] (03PS1) 10Bartosz Dziewoński: SpecialUndelete: Use DifferenceEngine#addHeader instead of rolling our own [core] - 10https://gerrit.wikimedia.org/r/100218 [19:01:43] (03CR) 10Aaron Schulz: [C: 032] Some more formatting fixes for media classes [core] - 10https://gerrit.wikimedia.org/r/99468 (owner: 10Siebrand) [19:05:45] (03Merged) 10jenkins-bot: Some more formatting fixes for media classes [core] - 10https://gerrit.wikimedia.org/r/99468 (owner: 10Siebrand) [19:06:04] (03CR) 10Theopolisme: "Yep, with no arguments .click() is the same as .trigger('click'). You could do the same thing with the location.href stuff (replace it wit" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 (owner: 10Jcf2000) [19:16:03] (03PS7) 10Jcf2000: Implement keyboard navigation for BookManagerv2 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195 [19:21:42] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Breaks display. :(" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [19:32:36] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/100220 [19:34:50] (03CR) 10Bartosz Dziewoński: "Does this also fix the example given in https://bugzilla.wikimedia.org/show_bug.cgi?id=38911#c7 ?" [core] - 10https://gerrit.wikimedia.org/r/98250 (owner: 10TheDJ) [19:47:43] (03CR) 10Bartosz Dziewoński: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/100220 (owner: 10Umherirrender) [19:50:41] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/100220 (owner: 10Umherirrender) [20:05:47] (03CR) 10Bartosz Dziewoński: Site logo loaded using ResourceLoaderSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [20:07:30] Hi, does anyone know if/where i can get the source code of the rc-pmtpa bot? [20:09:05] Yeah.. It should be around somewhere [20:10:24] . Note that the config variables mentioned are deprecated in MW 1.22 in favor of $wgRCFeeds. [20:11:38] Cool, thank you both^^ [20:13:48] hi Reedy, bored? [20:14:14] I'm going out in a few minutes [20:14:15] :P [20:14:51] the number of my pending patches has been skyrocketing recently [20:15:55] https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner [20:17:05] (03Abandoned) 10Legoktm: [WIP] Notify a user via Echo once their job is done [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87001 (owner: 10Legoktm) [20:19:55] (03CR) 10Legoktm: Check the spamlist's content format earlier (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97365 (owner: 10Legoktm) [20:20:20] (03PS2) 10Legoktm: Check the spamlist's content format earlier [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97365 [20:21:02] counting only core, i have twice as many patches as the next person :( [20:22:53] oO [20:22:57] MatmaRex: open ones? [20:23:09] yep [20:23:13] 42 [20:23:18] probably more now, i submitted a few today [20:23:35] admittedly some are -1'd, but most aren't [20:23:43] oO [20:23:50] I got 3 (one draft), all -1ed [20:24:02] MatmaRex: Isn't this where you decide no on cares and abandon them all? [20:24:07] (03PS6) 10Legoktm: Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [20:24:14] (03CR) 10jenkins-bot: [V: 04-1] Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [20:24:24] wut [20:24:26] Reedy: i'll just wait for someone to get annoyed and merge them all instead [20:24:34] how does it not merge??? [20:24:35] legoktm: DENIED. [20:24:38] Reedy: like i merged platonides's 20 patches to mediawiki/tools/something [20:24:44] legoktm: there's a bug in gerrit [20:24:53] Just one? [20:24:53] "a bug" [20:25:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=57483 [20:25:35] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [20:25:37] (03PS7) 10Legoktm: Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [20:25:41] MatmaRex: oh when will you learn [20:25:46] gerrit doesn't *have* bugs [20:25:48] it *is* a bug [20:25:50] :) [20:25:53] you really mean gerrit bug, or do you mean jenkins bug [20:25:54] (03CR) 10Bartosz Dziewoński: "https://bugzilla.wikimedia.org/show_bug.cgi?id=57483" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [20:26:02] i do mean a gerrit bug [20:26:05] or so says hashar [20:26:13] who investigated this from the jenkins's side [20:26:43] happen around once a day in my experience [20:26:49] and gets more and more annoying [20:26:57] happens* [20:27:09] (03CR) 10jenkins-bot: [V: 04-1] Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [20:27:17] grrr [20:27:22] lol [20:27:22] let me make sure it actually does merge. [20:27:25] maybe it actually doesn't merge [20:27:36] (but the bug is real) [20:27:49] MatmaRex: this is more than just having to rebase ? [20:28:02] cant you hit the Rebase button [20:28:25] on [20:28:28] oh* [20:28:30] it doesnt merge [20:28:31] hrmmmmm [20:29:47] sees bug now..uhm... [20:29:56] blegh [20:30:13] MatmaRex: wanna merge https://gerrit.wikimedia.org/r/#/c/97365/ ? [20:31:40] mutante: it's especially annoying when it happens right after you rebase [20:31:50] so you can't rebase again until some other patch is merged [20:32:12] you can say "recheck" on the patch, but that will make jenkins only vote V+-1, never V+2 [20:33:31] legoktm: looks non-trivial [20:33:32] yea, i noticed that too, it's the order of things, if you +2 before jenkins got to the confirmation you also have to give your +2 one more time after it [20:33:49] so the order matters not just the sum of scores sometimes [20:34:18] but that's all independent from https://bugzilla.wikimedia.org/show_bug.cgi?id=57483 [20:39:15] (03CR) 10Bartosz Dziewoński: "Ugh, the data flow is complicated here… unrelated comment inline." (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97365 (owner: 10Legoktm) [20:39:48] MatmaRex: like return Title|Status? [20:40:37] like return Status, regardless of success/failure [20:40:55] scout's honor that these changes work? i can +2 :P [20:43:00] be prepared then [20:43:07] yup the change works :D [20:44:41] MatmaRex: I don't want to touch how the function works right now since it gets moved in the next change, i'll do that after the refactoring is merged [20:44:47] (03CR) 10Bartosz Dziewoński: [C: 032] "Code looks good, and Legoktm promised on scout's honor that it works." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97365 (owner: 10Legoktm) [20:44:57] sure, as i said, that was unrelated [20:45:04] lol [20:45:31] > Queue lengths: 135 events, 0 results. [20:45:45] heh, l10n time? [20:45:46] wtf? [20:45:50] oh [20:45:50] l10n-bot [20:46:04] legoktm: so, wanna review some of my 40 core patches? ;) [20:46:09] sure [20:46:22] (03Merged) 10jenkins-bot: Check the spamlist's content format earlier [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97365 (owner: 10Legoktm) [20:46:32] legoktm: Do you have +2 on core? [20:46:36] hoo: yes :) [20:46:44] \o/ :) [20:47:09] legoktm: the most recent ones are usually the most pleasant ;) [20:47:18] or th eones which are already +1'd [20:47:20] i'm looking at https://gerrit.wikimedia.org/r/#/c/97853 right now [20:48:05] legoktm: https://gerrit.wikimedia.org/r/100217 (Wikibase)... I really want that one in... it's just to bad to not have it :P [20:49:31] * MatmaRex wonders who the hell decided db keys should have underscores [20:49:59] ... [20:50:10] hoo: looks sane, but I don't really know the rest of the code that well [20:50:16] (03PS1) 10Andrew Bogott: Add 'puppet status' to Special::Resources [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/100327 [20:50:19] ok ;) [20:53:20] hey everybody [20:53:37] hi [20:54:08] (03CR) 10Siebrand: Add 'puppet status' to Special::Resources (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/100327 (owner: 10Andrew Bogott) [20:54:45] quick question, the icons are on commons.wikimedia.org for sure? Talking about this icon for this task in specific: http://www.google-melange.com/gci/task/view/google/gci2013/5843157379973120 [20:55:03] I can't seem to find it :/ [20:55:15] Went through the whole directory [20:57:24] (03CR) 10Legoktm: [C: 032] "Tested, works as expected." [core] - 10https://gerrit.wikimedia.org/r/97853 (owner: 10Bartosz Dziewoński) [20:57:43] czołem ircowicze [21:00:00] (03PS1) 10Jack Phoenix: SVG versions of block & voted images by Isarra. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100328 [21:00:27] (03Merged) 10jenkins-bot: Wrap changes lists in
[core] - 10https://gerrit.wikimedia.org/r/97853 (owner: 10Bartosz Dziewoński) [21:01:06] MatmaRex: why do you use Class#function instead of Class::function? [21:01:37] hm [21:01:38] Ahmad96: Hi. [21:01:45] hi [21:01:52] legoktm: Ruby habit, i guess [21:02:02] legoktm: i like to have a distinction between static and non-static methods, too [21:02:10] (03CR) 10Jack Phoenix: [C: 032 V: 032] SVG versions of block & voted images by Isarra. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/100328 (owner: 10Jack Phoenix) [21:02:14] Class::function is static, Class#function is normal [21:02:48] ok [21:04:39] No, no chance. The icon is not in the directory haha. [21:05:07] Ahmad96: There are two problems that I can see with regards to the Sinhala Wiktionary logo. [21:05:17] (1) I have no idea where the tile image comes from. [21:05:29] (2) I have no idea what's the font used for that single letter. [21:06:27] Hmm [21:06:46] I suspect that it might be the letter වි - which seems to be the Sinhala sign for the Latin letter 'W' [21:06:54] s/logo/favicon, of course. [21:07:06] https://bugzilla.wikimedia.org/show_bug.cgi?id=38036#c9 suggests that. [21:07:19] Ahmad96: I suggest you drop that and take on another favicon. [21:07:23] Sorry about that! [21:07:29] Oh okay [21:07:56] Should I take a new task or should I come up a new favicon? [21:08:55] Ahmad96: unless you want to start World War Three, god no. [21:09:07] It'll be much easier to take a new task :) [21:09:11] haha ok :) [21:09:36] We should mark it somehow, and try to contact the Sinhala folks some time, though. [21:10:04] (03CR) 10Legoktm: [C: 031] SpecialUndelete: Use DifferenceEngine#addHeader instead of rolling our own [core] - 10https://gerrit.wikimedia.org/r/100218 (owner: 10Bartosz Dziewoński) [21:10:09] but that's for another day, and definitely too time-consuming for you guys [21:11:14] lol whut [21:11:16] i broke bugzilla [21:11:29] how dare you, [21:11:40] from bugmail for https://bugzilla.wikimedia.org/show_bug.cgi?id=8844 : http://i.imgur.com/b2tf5xv.png [21:11:50] that's my changes to the bug with gerrit-bot's comment [21:12:04] and i got that mail (and i don't get sent my own bug changes) [21:12:05] lol [21:12:19] turns out bugzilla's edit conflict detection is no better than ours [21:12:21] that's a relief [21:13:39] ha [21:14:07] lol wut HTML mails are so ugly [21:14:54] MatmaRex: https://gerrit.wikimedia.org/r/#/c/86282 "uncool"? [21:17:09] um, i don't remember. it probably doesn't actually work [21:17:14] heh [21:17:16] like, not saving preferences, or something [21:17:24] or throwing exceptions on invalid ones [21:17:30] or something else silly like that [21:17:52] i have a bunch of free-floating patches to htmlform and preferences stuff i need to rework one day [21:22:16] yeah, some of the preferences stuff could really use clean up [21:22:57] no [21:22:59] all of it could use it [21:23:14] :D [21:26:13] (03CR) 10Bartosz Dziewoński: "This was refactored and became a part of the BetaFeatures extension, right? Should this patch be abandoned?" [core] - 10https://gerrit.wikimedia.org/r/74662 (owner: 10MarkTraceur) [21:26:18] (03CR) 10Bartosz Dziewoński: "This was refactored and became a part of the BetaFeatures extension, right? Should this patch be abandoned?" [core] - 10https://gerrit.wikimedia.org/r/75143 (owner: 10MarkTraceur) [21:27:36] (03Abandoned) 10Bartosz Dziewoński: HTMLForm: Deprecate lack of $context in constructor and #setTitle [core] - 10https://gerrit.wikimedia.org/r/86304 (owner: 10Bartosz Dziewoński) [21:27:49] (03CR) 10Bartosz Dziewoński: "Oh well, this is staying soft-deprecated forever then." [core] - 10https://gerrit.wikimedia.org/r/86304 (owner: 10Bartosz Dziewoński) [21:28:06] (03Abandoned) 10Bartosz Dziewoński: HTMLForm: Disallow lack of $context in constructor, remove #setTitle [core] - 10https://gerrit.wikimedia.org/r/86305 (owner: 10Bartosz Dziewoński) [21:28:28] wait what [21:28:51] i'm not going to fix infinite extensions just to remove some old stuff no one cares about anyway [21:29:13] and i'm just going through outstanding htmlform-related patches [21:29:26] since i want to merge a different large patch that splits it into files for each class [21:29:28] like 20 of them [21:32:57] phpstorm's find usages is still running [21:33:13] legoktm: you need a faster machine [21:33:15] :) [21:33:21] * YuviPanda has long given up on 'cleanup' work on mw [21:33:28] its found 80+ usages so far [21:35:19] (03CR) 10Bartosz Dziewoński: "This changes the effective nesting now, doesn't it? I don't think you intended on that." [core] - 10https://gerrit.wikimedia.org/r/96704 (owner: 10IAlex) [21:36:19] ugh [21:38:00] (03PS1) 10Legoktm: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/100330 [21:38:06] (03CR) 10TheDJ: "@Matmarex yup it does." [core] - 10https://gerrit.wikimedia.org/r/98250 (owner: 10TheDJ) [21:38:09] MatmaRex: ^ [21:39:21] legoktm: meh [21:39:45] i'm having second thoughts on removing that, actually, it seems to have somewhat legitimate uses sometimes [21:39:47] also, boring [21:40:03] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Let's rebase this baby." [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [21:40:07] (03PS1) 10Legoktm: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/100331 [21:40:10] now, that ^ is exciting. [21:40:20] I'm glad you find my change exciting :D [21:40:39] (03CR) 10Parent5446: [C: 04-1] "This change is pointless. It just replaces one error suppression operator with another slower and less readable error suppression operator" [core] - 10https://gerrit.wikimedia.org/r/100165 (owner: 10Umherirrender) [21:42:03] (03CR) 10Bartosz Dziewoński: "You should have https://www.mediawiki.org/wiki/CC/PHP#Error_handling updated, then – it says not to use @ "for any reason ever"." [core] - 10https://gerrit.wikimedia.org/r/100165 (owner: 10Umherirrender) [21:42:37] (03PS1) 10Legoktm: Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/100332 [21:47:08] (03CR) 10Parent5446: ":/ Well unfortunately what it says there is correct. What I mean to say is that rather than replacing one operator with another, why not j" [core] - 10https://gerrit.wikimedia.org/r/100165 (owner: 10Umherirrender) [22:06:53] (03CR) 10Parent5446: Abstract out mysql_field_type() call from DatabaseBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/100172 (owner: 10PleaseStand) [22:12:53] (03PS4) 10Bartosz Dziewoński: Split includes/HTMLForm [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [22:14:47] (03PS5) 10Bartosz Dziewoński: Split includes/HTMLForm [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [22:15:00] (03PS12) 10Wikinaut: make SpecialChangePassword form text depending on login status of $wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [22:15:29] (03CR) 10Bartosz Dziewoński: "PS4, PS5: Rebased. The conflicts were whitespace-only changes (f153998317bba5803fdf16749b79cfefaae59620, 5dbfd5bf80a4469fef2da1b56d57129a4" [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [22:17:00] (03CR) 10Bartosz Dziewoński: [C: 04-1] "$wgUser? You have a $this->getUser() right there. If you did mean not to use it, then I expect a long and precise explanation. :P" [core] - 10https://gerrit.wikimedia.org/r/96651 (owner: 10Wikinaut) [22:20:40] (03PS1) 10saper: Let BlockTest.php respect database constraints [core] - 10https://gerrit.wikimedia.org/r/100334 [22:24:50] (03CR) 10Bartosz Dziewoński: [C: 032] "It parses, ship it!" [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [22:25:04] (03CR) 10Bartosz Dziewoński: "Conflicts badly with https://gerrit.wikimedia.org/r/#/c/95774/ :(" [core] - 10https://gerrit.wikimedia.org/r/62014 (owner: 10IAlex) [22:25:45] (03PS3) 10Bartosz Dziewoński: Formatting Fixes in inc/htmlform/* [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [22:25:50] (03PS4) 10Bartosz Dziewoński: Formatting fixes in includes/htmlform/* [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [22:26:30] (03CR) 10jenkins-bot: [V: 04-1] Formatting fixes in includes/htmlform/* [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [22:27:05] (03CR) 10Bartosz Dziewoński: "Siebrand's comments still apply." [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [22:28:22] (03Merged) 10jenkins-bot: Split includes/HTMLForm [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [23:38:58] (03CR) 10Hoo man: [C: 04-1] "needs a rebase" [core] - 10https://gerrit.wikimedia.org/r/62014 (owner: 10IAlex) [23:42:15] (03CR) 10Hoo man: "The approach looks ok, but I need to test it (and have Graham test it), before I can say whether this fits our needs." [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [23:51:58] (03PS1) 10Legoktm: Link to Special:GlobalPreferences on Special:Preferences [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/100335 [23:52:26] Oh my. [23:52:27] (03CR) 10Physikerwelt: [C: 032 V: 032] Pass context to HTMLForm, don't use HTMLForm::setTitle [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/100332 (owner: 10Legoktm) [23:52:32] legoktm: Global prefrences? :o [23:52:41] yes, hello :) [23:52:44] preferences [23:52:51] legoktm: Is that for shared user tables? [23:52:56] Or is that a generic extension? [23:53:03] generic extension [23:53:06] it works for CentralAuth too [23:53:19] (03CR) 10Legoktm: [C: 032 V: 032] Link to Special:GlobalPreferences on Special:Preferences [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/100335 (owner: 10Legoktm) [23:53:26] the UI is weird [23:53:38] Yeah... [23:54:00] Nobody is quite sure how global user prefs should work. [23:54:15] Gloria: http://cl.ly/image/0F2F452U2o0B [23:54:35] Oh Lord. [23:55:03] How does that work with more than one wiki? [23:55:08] Do the checkboxes conflict? [23:55:24] Or does it always read from the central DB for those checkboxes? [23:55:42] if you set a global preference, it overrides anything set locally [23:55:48] An all or (n)one approach may be better. [23:55:59] legoktm: Right, but let's say I check "use this preference" on en.wiki. [23:56:10] And then do the same on commons.wiki with a different value. [23:56:33] err [23:56:49] then whatever you set on commonswiki will be used globally [23:57:09] whatever you set last [23:57:15] So the checkboxes never retain state? [23:57:17] Interesting. [23:57:20] no, they do [23:57:28] so if you set it on enwiki, its stored [23:57:28] Hmm. [23:57:42] then when you open up commonswiki, you see what you set on enwiki, and change it [23:57:47] so now what you set last is stored [23:58:10] Got it. [23:58:14] What happens if I check the box? [23:58:19] Does it update every other wiki? [23:58:31] it updates the central database which each wiki reads from [23:59:00] And then only reads that value from other wikis if it's set? [23:59:27] Otherwise it would potentially have to do many updates, right? [23:59:35] For each wiki where it's set... [23:59:41] only preferences that are active are stored