[00:00:02] bd808: atm it's only evaluating the final url for redirects and a proper media file extension. it could be altered to check the file size in the header as well [00:00:20] aude: appears not :( :( [00:00:31] superm401: I'm guessing that will need backporting.. :/ [00:00:33] anybody else wanna help out aude real quick? [00:00:40] a quick update of wikibase (shhhh) [00:00:42] (03CR) 10Aaron Schulz: "I'd abandon these unless the "else"s are breaking something useful somehow." [core] - 10https://gerrit.wikimedia.org/r/99451 (owner: 10Siebrand) [00:00:47] legoktm, yeah, I'll check. [00:00:53] dan-nl: Are you using UploadFromUrl or your own version of it? I forget. [00:00:56] :) [00:00:59] <^d> greg-g, aude: link? [00:01:31] https://gerrit.wikimedia.org/r/#/c/99762/ (https://gerrit.wikimedia.org/r/#/c/99742/) [00:01:31] bd808: i'm using it, but before i pass it a url i need to evaluate it … evaluateMediafileUrl in includes/Handlers/UploadHandler.php [00:01:32] (03Abandoned) 10Siebrand: Remove unneeded uses of else {} in media classes [core] - 10https://gerrit.wikimedia.org/r/99451 (owner: 10Siebrand) [00:01:34] it's an update to help them debug some annoying situation, it's only going to the test wikis (right aude)? [00:01:50] (03Abandoned) 10Siebrand: Remove unneeded use of else{} in file repo classes [core] - 10https://gerrit.wikimedia.org/r/99145 (owner: 10Siebrand) [00:02:01] ensures each content language uses it's own memcached key for lookup of property labels [00:02:05] affects wikipedias [00:02:16] when theyuse our parser function [00:02:33] aude: ? [00:02:36] greg-g: no, test2 is fine [00:02:41] it's reedy :) [00:02:47] ^d: Not sure what you are referring to [00:02:50] dan-nl: Ah. I see. You do a HEAD request first. [00:02:51] test2 is not sharing memcached [00:03:02] orly? [00:03:06] aude: ahhhh [00:03:09] how does that work.. [00:03:09] <^d> bawolff: Nevermind. [00:03:10] not for this particular thing [00:03:28] (03CR) 10Chad: [C: 032] Update Wikibase, ensure correct memcached for property label lookup [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99762 (owner: 10Aude) [00:03:29] because we'll hook it up to test.wikidata at some tpoint [00:03:29] bd808: yes, some institutions redirect, some more than once, to their media files [00:03:46] <^d> aude, greg-g: On it. [00:03:47] and then it would be icky to mix stuff in cache [00:03:49] and UploadFromUrl wasn't following them for some reason [00:03:50] ^d [00:03:51] dan-nl: It would be cool to add a check in your code, but spectacular to fix UploadFromUrl itself. :) [00:03:53] thanks [00:03:57] Reedy: ^d's on it [00:04:07] :) [00:05:05] * ^d whistles jeopardy tune while jenkins churns [00:05:30] :) [00:06:05] dan-nl: Lego made a good suggestion for a tiny change to your patch. Fix it and I'll merge [00:06:26] (03Merged) 10jenkins-bot: Update Wikibase, ensure correct memcached for property label lookup [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99762 (owner: 10Aude) [00:06:32] \o/ [00:06:48] bd808: k, where's the suggestion? [00:06:58] its an inline comment [00:07:11] what the author said :) [00:07:22] bd808, found it [00:09:37] bd808: it's up there [00:10:04] dan-nl: "Change has been successfully merged into the git repository." [00:10:21] cool, i'll test it out in a few minutes and let you know [00:11:29] yay [00:13:54] <^d> aude, greg-g: Done sync'ing. [00:15:19] thanks [00:16:12] bd808: the integration failed to deploy … jenkins had a problem with fetching the change https://integration.wikimedia.org/ci/job/beta-mediawiki-config-update/1603/console [00:17:03] dan-nl: Grrr. Now I have to figure out how to actually fix the beta cluster [00:17:07] permission denied? [00:17:09] ^d: ?? [00:17:30] hmm … is that because i created the patch? [00:17:38] (03CR) 10Aaron Schulz: [C: 032] Normalize newlines in DjVu text-layer metadata. [core] - 10https://gerrit.wikimedia.org/r/99710 (owner: 10Brian Wolff) [00:17:54] No. Somebody messed with something on the host I'm guessing [00:17:57] <^d> greg-g: Huh? [00:18:13] <^d> Oh, crap. [00:18:14] probably pulled an manual update with the wrong umask [00:18:17] <^d> I think I might've done that. [00:18:20] (03CR) 10GWicke: [C: 04-2] "I06ad1f570d652ef06e0efa2382b5dde9047b5855 is definitely the better approach." [vagrant] - 10https://gerrit.wikimedia.org/r/90702 (owner: 10Physikerwelt) [00:18:23] <^d> Will fix, sec. [00:18:29] (03CR) 10Shirayuki: Better GENDER support in moderation.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [00:18:48] there goes chad, breaking beta cluster again [00:19:23] dan-nl: getting there.... sooo close :) [00:19:26] <^d> Don't I get some points for at least using beta? :) [00:19:36] greg-g: yes, :) [00:19:43] -rw-r--r-- 1 mwdeploy mwdeploy 98435 Dec 6 21:54 .git/logs/refs/remotes/origin/master [00:19:48] Looks ok to me [00:19:57] <^d> bd808: I'm fixing ownership on everything. [00:20:01] ah [00:20:01] ^d: yeah, +5, and -4 almost breaking it for the weekend, so slightly ahead ;) [00:20:06] <^d> Some of .git was accidentally owned by root. [00:20:45] (03Merged) 10jenkins-bot: Normalize newlines in DjVu text-layer metadata. [core] - 10https://gerrit.wikimedia.org/r/99710 (owner: 10Brian Wolff) [00:22:53] ^d: all better now? [00:24:53] <^d> I think so, testing. [00:25:33] <^d> "Auto packing the repository for optimum performance." [00:25:45] <^d> git should add "(except when on nfs, where it's slow as balls)" [00:26:16] <^d> bd808: But yes, fixed. [00:28:21] So how do I get zuul/jenkins to try to deploy again? [00:28:32] I can't amend the patch because it's already merged [00:29:25] bd808 do you see a try again button or link on this page? https://integration.wikimedia.org/ci/job/beta-mediawiki-config-update/1603/ [00:29:29] * bd808 found the "rebuild last" button [00:29:36] deploy to beta? [00:29:55] aude: Yeah. I think I figured it out [00:30:32] yep, that looks like it worked … thanks [00:30:41] k [00:30:46] will check the tool in a few moments [00:32:58] dan-nl: I see your config on the server, so I think you should be ready to try again [00:33:11] cool, i'll try it … how did you check it? [00:33:22] greg-g: Can I grab a LD slot on Monday, please? VE breakage in wmf6. :-( [00:33:37] I have super powers :) (shell access to the beta cluster) [00:34:18] :) [00:35:27] James_F: fun, yeah [00:35:46] greg-g: Thanks. [00:36:05] <^d> bd808: I pulled everything to deployment-bastion. [00:36:10] <^d> As part of fixing it. [00:36:43] ^d: Oh thanks. I figured out how to resubmit the job on the jenkins interface too [00:36:52] <^d> That'll do it too :) [00:37:15] and I just fixed another permissions bug that wasn't your fault. common-local was owned by timidity [00:37:32] causing "PHP Warning: dba_open(/a/common/wikiversions.cdb.tmp.tmp.659247121): failed to open stream: Permission denied in /data/project/apache/common-local/multiversion/CdbDBA.php on line 53" [00:39:12] textual [00:39:20] Whoops. :) [00:39:25] (03PS2) 10JGonera: [WIP] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [00:43:51] James_F: added to cal, let me know a little more the day of [00:44:01] greg-g: Thanks. [00:44:56] legoktm, yeah, it's in wmf6 [00:46:16] bd808: still having some issues … does this mean anything to you … Error fetching URL: Received HTTP code 403 from proxy after CONNECT [00:46:58] legoktm, do you have deployment access? [00:46:59] 403 is Forbidden. [00:47:04] superm401: nope :( [00:47:16] (03Abandoned) 10Chad: Installer reports undefined noFollow [core] - 10https://gerrit.wikimedia.org/r/99731 (owner: 10saper) [00:47:20] (03CR) 10Aaron Schulz: [C: 04-1] Removed 'Disable browser page caching" user preference (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [00:47:51] works locally without issue [00:48:19] dan-nl: What's the URL? I can try from inside beta network manually [00:48:42] (03CR) 10Chad: "One nit, otherwise ok." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99747 (owner: 10Manybubbles) [00:49:00] * dan-nl : looking up the url [00:49:26] <^d> greg-g: Can I sync two no-op config changes for poolcounter? [00:49:42] legoktm, alright, I'll do the bump, can you bug greg-g to find a time to deploy? [00:49:57] bd808: it's hard to say which url, but here's one http://www.rijksmuseum.nl/media/assets/RP-P-1992-80 [00:50:28] ^d: ? [00:50:29] greg-g: hey. superm401 and I need a deployment window to fix Thanks in wmf6. patch is https://gerrit.wikimedia.org/r/#/c/99764/ [00:50:38] you're welcome [00:50:40] wait, what? [00:50:42] oh ;) [00:50:49] <^d> greg-g: https://gerrit.wikimedia.org/r/#/c/99752/ - we've already removed the functionality. [00:50:52] :P [00:51:09] ^d: ah, uh, sure I guess [00:52:02] legoktm: it's only on wmf6? [00:52:05] broken on, that is [00:52:16] greg-g: yeah, according to superm401 [00:52:33] dan-nl: It takes a few redirects but it gets there. [00:52:40] yes :) [00:52:55] i sent you the xml file i'm testing with [00:53:02] Yeah, I looked at https://git.wikimedia.org/tree/mediawiki%2Fcore.git/refs%2Fheads%2Fwmf%2F1.23wmf5/extensions/ and https://git.wikimedia.org/tree/mediawiki%2Fcore.git/refs%2Fheads%2Fwmf%2F1.23wmf6/extensions/ [00:53:13] dan-nl: I wonder if there is a proxy configured for the php client that I don't know about. [00:53:21] k, yeah [00:53:22] * bd808 goes to grep config files [00:53:46] legoktm: superm401 https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=91485&oldid=91483 [00:53:58] have no idea … on http://gwtoolset.wmflabs.org/wiki/GWToolset this xml file worked without issue … i'll test it again just to make sure ... [00:54:17] Okay [00:54:49] <^d> greg-g: Done, thanks. I was able to check off all but two things on today's todo list :) [00:55:31] (03PS1) 10EBernhardson: [WIP] Load usernames directly from wiki's in batches [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99789 [00:55:37] (03PS1) 10Mattflaschen: Bump Thanks for bugfix [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99790 [00:55:39] dan-nl: Maybe to narrow things down while debugging you should make a test file that only has one image in it [00:55:50] :) [00:55:54] Thanks, greg-g [00:55:59] greg-g: thanks! [00:56:04] ja, on our test instance it's no issue [00:56:18] i'll create a single record xml file ... [00:56:30] superm401: I probably won't be online at that time fyi, I have a 7am final the next day :/ [00:56:38] Ok. So there is something different about the beta cluster (which is not surprising) [00:56:41] No problem [00:57:16] (03CR) 10EBernhardson: User renaming needs to be handleable by the RenameUser extension (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99668 (owner: 10Matthias Mullie) [00:58:11] bd808: oh boy, for some reason it looks like the code couldn't follow the url redirects to its destination … wonder if there's a config for how many redirects it will follow [00:58:31] There's an outbound proxy too: url-downloader.wikimedia.org:8080 [00:58:34] (03PS1) 10Anomie: Add PPFrame::isVolatile and PPFrame::setVolatile [core] - 10https://gerrit.wikimedia.org/r/99792 [00:59:00] (03PS1) 10Anomie: Mark parser hook output as volatile [extensions/Cite] - 10https://gerrit.wikimedia.org/r/99793 [00:59:20] (03PS1) 10Anomie: Don't cache volatile wikitext [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99794 [00:59:24] (03PS1) 10Anomie: Enable volatile caching test for frame:expandTemplate [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99795 [01:00:07] (03CR) 10Krinkle: "(removing from my review list)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61289 (owner: 10Rasel160) [01:00:11] greg-g, can I do it Monday instead? [01:00:12] (03CR) 10Anomie: "Since this is somewhat odd to test, I put together some test cases at https://www.mediawiki.org/wiki/User:Anomie/Bug46815." [core] - 10https://gerrit.wikimedia.org/r/99792 (owner: 10Anomie) [01:00:50] dan-nl: I can recreate with curl [01:00:58] curl -x url-downloader.wikimedia.org:8080 -LI -XHEAD http://www.rijksmuseum.nl/media/assets/RP-P-1992-80 [01:01:02] Never mind, that is Monday. [01:01:07] HTTP/1.0 403 Forbidden [01:01:55] superm401: it is on monday (stupid UTC) [01:02:04] more stupid daylight savings/timezones in general [01:02:46] bd808: so something is going on with that proxy because i can do it localy and on labs without issue … how can we get around that? [01:03:28] curl -LI -XHEAD http://www.rijksmuseum.nl/media/assets/RP-P-1992-80 [01:03:47] HTTP/1.1 200 OK [01:03:58] (03PS1) 10Anomie: Tracking category for modules saved with errors [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99796 [01:04:46] (03PS1) 10Anomie: Expose PPFrame::getTitle to Lua [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99797 [01:05:19] dan-nl: I'm looking at the proxy config now to see if I can guess what's up [01:05:30] thanks [01:05:48] (03PS1) 10Anomie: Status::getHTML should actually return HTML [core] - 10https://gerrit.wikimedia.org/r/99798 [01:06:18] maybe another whitelist? [01:06:52] dan-nl: I think the proxy is only setup for production and automatically denied anything from the beta cluster based on the origin IP [01:07:12] I can run the same curl command from the prod bastion just fine [01:07:41] (03CR) 10jenkins-bot: [V: 04-1] Status::getHTML should actually return HTML [core] - 10https://gerrit.wikimedia.org/r/99798 (owner: 10Anomie) [01:07:49] (03Abandoned) 10Anomie: Test (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96530 (owner: 10Anomie) [01:08:13] bd808 is it possible to fix it so that the beta cluster can use it to fetch remote files? [01:08:43] Maybe. Or maybe we can just configure beta not to use a proxy at all [01:09:05] Prod needs one because the servers don't have direct access to the outside [01:09:37] k … who would you need to ask about that? [01:09:51] or can you just do it? [01:11:40] dan-nl: The problem is definitely that the squid at url-downloader.wikimedia.org isn't configured to allow the labs subnet to request files through it [01:12:02] oh, it's going through that? ugh [01:12:20] greg-g: yeah, but I don't think it's necessary in beta [01:12:32] well, beta shouldn't go through it, is my guess [01:12:43] * bd808 nods [01:13:44] cool, is it an easy config change? is csteipp okay with it? [01:13:53] (03PS2) 10Anomie: Status::getHTML should actually return HTML [core] - 10https://gerrit.wikimedia.org/r/99798 [01:14:29] (03PS1) 10EBernhardson: Repair subpage links going through redlink handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99801 [01:14:33] god I hope so, and probably [01:14:34] ;) [01:14:43] :) [01:20:37] (03PS6) 10Bartosz Dziewoński: Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 [01:21:59] dan-nl: https://gerrit.wikimedia.org/r/#/c/99803/ [01:22:17] greg-g, csteipp: ^ [01:22:45] (03CR) 10Bartosz Dziewoński: [C: 032] "What's up with this change, come on." [core] - 10https://gerrit.wikimedia.org/r/99713 (owner: 10Bartosz Dziewoński) [01:23:06] (03CR) 10Bartosz Dziewoński: [V: 032] "Stupid jenkins." [core] - 10https://gerrit.wikimedia.org/r/99713 (owner: 10Bartosz Dziewoński) [01:25:21] dan-nl: Chris approved. Waiting for jenkins to do it's thing [01:26:18] cool [01:27:20] btw bd808, scholarship is much better than I expected. Thank you. Should be able to finish up on Monday. [01:27:58] csteipp: Better than you expected? It's F'ing awesome :) [01:28:13] (03PS1) 10Bartosz Dziewoński: mediawiki.hlist: Remove skin-specific styles [core] - 10https://gerrit.wikimedia.org/r/99805 [01:28:54] dan-nl: "Change has been deployed on the beta cluster". Try again [01:29:06] (03CR) 10Siebrand: Tracking category for modules saved with errors (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99796 (owner: 10Anomie) [01:29:39] * dan-nl : trying it now [01:32:24] bd808 \o/ http://commons.wikimedia.beta.wmflabs.org/wiki/File:Een_vrouw_brengt_een_offer_aan_Priapus_---Sc%C3%A8nes_uit_Vergilius_dichtbundel_Bucolica_-serietitel--RP-P-1992-80-RM0001.COLLECT.70.jpeg [01:32:46] dan-nl: AWESOME!!!!! [01:33:16] definitely! now that's a great way to start a weekend! [01:33:43] I'm going to open a big Belgian beer to celebrate [01:33:50] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99843 (owner: 10L10n-bot) [01:33:52] http://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Category:GWToolset_Batch_Upload&action=edit&redlink=1 [01:34:13] i'll go to sleep now ;) [01:34:31] greg-g: ^^ successful test of GWToolset in beta [01:34:36] i'm curious how the server will handle the other 7 images. will check in on it tomorrow [01:34:45] thanks everyone for your help!! [01:37:25] bd808: enjoy that belgian beer! [01:37:37] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/99885 (owner: 10L10n-bot) [01:38:07] dan-nl: You should have a little party too. Thanks for sticking in here to see it run [01:40:49] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99843 (owner: 10L10n-bot) [01:45:36] (03PS1) 10Legoktm: Initial commit [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/99979 [01:45:50] (03CR) 10Legoktm: [C: 032 V: 032] Initial commit [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/99979 (owner: 10Legoktm) [01:52:33] heh [01:52:36] commit 100,000: https://gerrit.wikimedia.org/r/#/c/100000/ [01:52:56] wow [01:54:43] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/99885 (owner: 10L10n-bot) [01:55:49] Hmm, yes, sorry. Those latest 300 or so patch sets have been caused by me. [01:56:58] siebrand: you win this round.... but i'll be seeing you in 900,000 commits! [01:57:05] (03CR) 10Bsitu: [C: 032] Missing use statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99703 (owner: 10EBernhardson) [01:57:13] ori-l: That'll be in 5 years or so... [01:57:14] nice trick :) [01:57:18] ori-l: let's do that. [02:01:16] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/99885 (owner: 10L10n-bot) [02:01:52] siebrand: Not if i18n-bot commits each en.json, fr.json file as a distinct commit. :-D [02:02:14] James_F: I'm assuming I'll try trying to avoid that... [02:02:21] siebrand: Please do. :-) [02:02:30] James_F: I just might. [02:02:52] siebrand: Well, seriously, it would let people watch for just one language's changes. [02:02:56] * James_F hmms. [02:03:10] I mean, I'd go mental because I watch all changes, but that's my problem. :-) [02:03:23] "go" [02:03:49] James_F: May I recommend https://translatewiki.net/w/i.php?title=Special:RecentChanges&feed=atom&limit=50&translations=only&trailer=%2Fen-gb ? [02:03:54] commit #10000 was by l10n-bot as well [02:04:39] siebrand: Sure, but I want the inheritance tree. :-) [02:04:43] James_F: Or https://translatewiki.net/w/i.php?title=Special:RecentChanges&feed=atom&limit=50&namespace=8&translations=only&trailer=%2Fen-gb even. [02:05:07] James_F: I;m sure bugzilla is willing to record your feature requests. [02:05:14] * James_F grins. [02:06:08] Anyway... I'm done for the day. All Translate supported extension's i18n files have been completely rebuild. Nice and clean for Christmas. [02:06:23] Now let's convert the bunch to JSON. [02:06:24] (03CR) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:06:30] siebrand: Yay. [02:07:05] (03PS2) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 [02:07:45] (03Merged) 10jenkins-bot: Missing use statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99703 (owner: 10EBernhardson) [02:14:16] (03CR) 10jenkins-bot: [V: 04-1] JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:20:57] (03CR) 10Bartosz Dziewoński: "I didn't change any code, did I?…" [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:21:57] (03PS3) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 [02:25:04] (03CR) 10jenkins-bot: [V: 04-1] JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:27:32] (03CR) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [02:38:00] (03PS1) 10Legoktm: Add PreferencesFormPreSave hook [core] - 10https://gerrit.wikimedia.org/r/100113 [02:53:53] (03CR) 10Bartosz Dziewoński: "Sounds scary. Why?" [core] - 10https://gerrit.wikimedia.org/r/100113 (owner: 10Legoktm) [03:05:43] (03PS1) 10Danny B.: code-quality: Special:PrefixIndex is transcludable [core] - 10https://gerrit.wikimedia.org/r/100114 [03:16:11] (03PS1) 10Kaldari: Conditionally add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 [03:17:30] (03PS2) 10Kaldari: Conditionally add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 [03:18:26] (03CR) 10Kaldari: "See change Id511fd84 for an alternative implementation" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [03:19:44] (03PS3) 10Kaldari: Conditionally add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 [03:21:09] (03PS4) 10Kaldari: Conditionally add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 [04:17:18] (03CR) 10Legoktm: "See how it's kinda used in https://gerrit.wikimedia.org/r/#/c/99979/" [core] - 10https://gerrit.wikimedia.org/r/100113 (owner: 10Legoktm) [04:40:19] (03PS1) 10Legoktm: Clear a user's preferences before saving new ones [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/100116 [04:40:40] (03CR) 10Legoktm: [C: 032 V: 032] Clear a user's preferences before saving new ones [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/100116 (owner: 10Legoktm) [05:01:46] (03PS1) 10Theopolisme: Add spamlist title inline validation [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 [05:15:39] (03CR) 10Legoktm: "Can you use mw.Title for this? (I have no clue) https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [05:22:33] (03CR) 10Theopolisme: "The way I understand it, not really, unless someone were to set mw.Title.exist to all the pages in the wiki, which would be pretty impract" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [05:25:34] (03CR) 10Theopolisme: "Waiting for some comments/"okay" on the upstream and then will set up semantic versioning and whatnot and upload a new patch set here." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [05:31:25] (03CR) 10Legoktm: [C: 04-1] "Meh. That's fine :)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [06:15:22] (03CR) 10Theopolisme: "Hmm, is that really necessary?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [06:26:55] (03CR) 10Legoktm: "Well, it's supposed to check that the given title is valid, which means that it exists and that we can extract targets from it, and for th" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [06:55:35] (03PS2) 10Theopolisme: Add spamlist title inline validation [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 [06:56:41] (03PS1) 10Legoktm: Remove class constant variable reference from Echo.php [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/100120 [06:56:56] (03CR) 10Legoktm: [C: 032] Remove class constant variable reference from Echo.php [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/100120 (owner: 10Legoktm) [06:57:03] (03Merged) 10jenkins-bot: Remove class constant variable reference from Echo.php [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/100120 (owner: 10Legoktm) [07:09:16] (03PS3) 10Theopolisme: Add spamlist title inline validation [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 [07:13:42] (03CR) 10Parent5446: "Is there a reason this needs to be used rather than the existing hooks in the User class?" [core] - 10https://gerrit.wikimedia.org/r/100113 (owner: 10Legoktm) [07:14:22] (03CR) 10Parent5446: "Nevermind. Just saw other commit." [core] - 10https://gerrit.wikimedia.org/r/100113 (owner: 10Legoktm) [07:15:58] (03CR) 10Parent5446: [C: 04-1] Status::getHTML should actually return HTML (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99798 (owner: 10Anomie) [07:17:13] (03CR) 10Legoktm: [C: 032] "Works wonderfully, thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [07:17:23] (03Merged) 10jenkins-bot: Add spamlist title inline validation [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [07:53:20] Hi Nemo_bis, are you around? [07:54:11] (03PS1) 10Physikerwelt: Add length constraint to XQueryGenerator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/100121 [08:07:35] (03CR) 10Kambiz Darabi: "@Daniel Friesen:" [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [08:27:57] (03CR) 10MZMcBride: "It might be worth adding a release notes entry. Maybe." [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [08:33:46] (03PS6) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 [08:37:03] (03CR) 1001tonythomas: "Corrected the Release Notes." [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [09:01:50] (03PS1) 10Tpt: Prevent the browser to scroll while zooming with mouse [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100122 [09:24:50] (03CR) 10Physikerwelt: [C: 032 V: 032] Add length constraint to XQueryGenerator [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/100121 (owner: 10Physikerwelt) [09:52:59] how do I rebase [09:53:22] I used git rebase but it said that my current branch is up to date [09:53:55] Does the gerrit interface show "Can Merge Yes"? [09:54:41] yes [09:54:58] (03CR) 10Nemo bis: "(I didn't test.)" [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [09:55:19] Then I don't think you need to (but i'm probably wrong on that) [09:55:31] what is making you think you need to do a rebase? [09:55:35] p858snake|l: This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. [09:58:14] I believe from memory, but from memory there is a button that can do it from the gerrit interface [09:58:15] p858snake|l: I'm uploading an icon [09:58:29] (or just make a new patchset by editing the commit message) [09:59:16] Elsie will know better [10:00:48] Sleeeeep. [10:01:04] Elsie: can you help me with this ? [10:01:17] Which changeset are you working on? [10:01:26] here https://gerrit.wikimedia.org/r/#/c/99756 [10:01:47] What command are you running and what happens? [10:02:02] You should be able to do "git review --no-rebase". [10:02:05] If you have a commit made. [10:02:16] It's 5 a.m. Time for bed. :-) [10:02:21] good night [10:21:31] (03PS1) 10PleaseStand: Remove 5 unused block messages [core] - 10https://gerrit.wikimedia.org/r/100126 [10:21:38] (03PS1) 10PleaseStand: Remove unused message 'rcnote' [core] - 10https://gerrit.wikimedia.org/r/100127 [10:22:31] (03PS1) 10PleaseStand: Remove unused message 'confirmemail_error' [core] - 10https://gerrit.wikimedia.org/r/100128 [10:22:37] (03PS1) 10PleaseStand: Remove unused message 'compare-selector' [core] - 10https://gerrit.wikimedia.org/r/100129 [10:22:44] (03PS1) 10PleaseStand: Remove unused message 'limitall' [core] - 10https://gerrit.wikimedia.org/r/100130 [10:22:51] (03PS1) 10PleaseStand: Remove unused message 'undeletereset' [core] - 10https://gerrit.wikimedia.org/r/100131 [10:30:18] (03CR) 10Helder.wiki: [C: 031] mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [10:41:47] (03CR) 10Jack Phoenix: [C: 031] code-quality: Special:PrefixIndex is transcludable [core] - 10https://gerrit.wikimedia.org/r/100114 (owner: 10Danny B.) [10:49:58] (03CR) 10Jack Phoenix: "So COUNT(some_field) as FooBar messes up PGSQL? Wow..." [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/98353 (owner: 10saper) [10:52:00] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/100135 (owner: 10L10n-bot) [11:07:09] (03CR) 10Siebrand: [C: 032] Remove unused message 'compare-selector' [core] - 10https://gerrit.wikimedia.org/r/100129 (owner: 10PleaseStand) [11:08:18] (03CR) 10Siebrand: [C: 032] Remove unused message 'undeletereset' [core] - 10https://gerrit.wikimedia.org/r/100131 (owner: 10PleaseStand) [11:09:05] (03CR) 10Siebrand: [C: 032] Remove unused message 'limitall' [core] - 10https://gerrit.wikimedia.org/r/100130 (owner: 10PleaseStand) [11:10:41] (03CR) 10Siebrand: [C: 04-1] "Could you please submit a patch that removes the message reference in ConfirmAccount?" [core] - 10https://gerrit.wikimedia.org/r/100128 (owner: 10PleaseStand) [11:10:56] (03Merged) 10jenkins-bot: Remove unused message 'compare-selector' [core] - 10https://gerrit.wikimedia.org/r/100129 (owner: 10PleaseStand) [11:12:37] (03CR) 10Siebrand: [C: 032] Remove unused message 'rcnote' [core] - 10https://gerrit.wikimedia.org/r/100127 (owner: 10PleaseStand) [11:12:38] (03Merged) 10jenkins-bot: Remove unused message 'undeletereset' [core] - 10https://gerrit.wikimedia.org/r/100131 (owner: 10PleaseStand) [11:14:03] (03Merged) 10jenkins-bot: Remove unused message 'limitall' [core] - 10https://gerrit.wikimedia.org/r/100130 (owner: 10PleaseStand) [11:15:21] (03PS1) 10Tpt: Make pages without index use text layer extraction and default header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100138 [11:16:54] (03Merged) 10jenkins-bot: Remove unused message 'rcnote' [core] - 10https://gerrit.wikimedia.org/r/100127 (owner: 10PleaseStand) [11:35:39] (03PS1) 10Umherirrender: Remove extra comma to avoid fatal in IE7 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/100140 [11:40:40] (03CR) 10Calak: [C: 031] "We removed 2 additional formats, now it has only 4 formats (like all wikis)." [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [11:42:02] (03PS1) 10saper: Crude way to recreate PgSQL references in tables [core] - 10https://gerrit.wikimedia.org/r/100141 [12:08:02] (03CR) 10saper: "The problem is that wfWarn with trigger_error STOPS the execution of the code, so we never get the real error out there, only the rollback" [core] - 10https://gerrit.wikimedia.org/r/99648 (owner: 10saper) [12:15:42] (03CR) 10Jack Phoenix: [C: 04-1] "Apologies for the delayed reply!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [12:16:54] Hello Nemo_bis, are you around? [12:20:13] YuGin: yep [12:20:27] I was looking for you earlier when I saw your ping [12:20:33] Ah, I had to go out :( [12:21:46] Anyway, the only part of the page I translated yesterday that hasn't been marked for translation is the table at the very end [12:22:02] (Link to page: https://www.mediawiki.org/wiki/Help:Extension:FlaggedRevs ) [12:23:36] Yesterday you gave me a link to a page that 'translated' words into magic words, e.g. 'Accurate' --> 'revreview-accuracy-2' [12:24:25] However that page doesn't work for the table at the very bottom, i.e. I can't put that table in the {{int:message name}} format [12:24:36] So how do I handle that table? [12:33:29] YuGin: it's ok if you just enclose in translate tags the part that can be translated (i.e. colour names and description); or, if it's not worth it, you could make it a single section [12:38:38] (03PS1) 10Siebrand: Add explicit GENDER support in log entry [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/100143 [12:39:11] (03CR) 10jenkins-bot: [V: 04-1] Add explicit GENDER support in log entry [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/100143 (owner: 10Siebrand) [12:42:58] YuGin: when you're done with the import of old translations, past the link for this page on melange [12:44:18] *paste [12:46:14] (03CR) 10Siebrand: [C: 032] Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [12:48:02] Nemo_bis, I've added the appropriate tags for the last table and posted the link on the melange page. [12:48:13] good [12:48:15] (03CR) 10jenkins-bot: [V: 04-1] Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [12:56:38] hey, any idea why do I get build failed here https://gerrit.wikimedia.org/r/#/c/100144/ ? [13:05:20] vandrew: jenkins is restarting sorry :( [13:08:18] hashar: should I do a commit again or something else ? [13:08:49] vandrew: na just wait :-] [13:08:58] whenever jenkins is back up I will retrigger the failed builds [13:09:53] hashar: cool [13:10:59] ha it is backup [13:11:34] (03PS2) 10Hashar: Add explicit GENDER support in log entry [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/100143 (owner: 10Siebrand) [13:11:54] (03PS7) 10Hashar: Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [13:12:23] siebrand: vandrew: jobs re running, sorry [13:13:05] hashar: Sure. [13:13:10] hashar: Hadn't noticed. [13:15:12] hashar: no problem, it worked good this time [13:31:50] I am out [14:21:45] (03Abandoned) 10Raimond Spekking: Add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [14:29:49] (03CR) 10Raimond Spekking: Conditionally add a CSS class to disambiguation pages (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 (owner: 10Kaldari) [14:40:00] (03CR) 10Daniel Friesen: [C: 04-1] "Being in charge of capturing stuff printed from other parts of MW for external code sounds out of scope for OutputPage." [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [14:51:11] The "book export" function currently returns *always* PDF, even if one chooses EPUB/ZIM/OpenDocument [14:51:54] (confirmed on wikipedia-{de,en} from various locations with firefox and chrome) [15:01:25] (replied on #wikimedia-tech) [15:05:33] (03CR) 10Nikerabbit: [C: 032] Add explicit GENDER support in log entry [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/100143 (owner: 10Siebrand) [15:05:35] (03Merged) 10jenkins-bot: Add explicit GENDER support in log entry [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/100143 (owner: 10Siebrand) [15:16:08] (03PS2) 10Tpt: Make pages without index use text layer extraction and default header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100138 [15:20:49] (03Abandoned) 10Tpt: Add the level change summary tag even if there is an edit summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99634 (owner: 10Tpt) [15:23:52] (03CR) 10Rtdwivedi: [C: 031] Makes pages without index use text layer extraction and default header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100138 (owner: 10Tpt) [15:27:43] (03CR) 10Rtdwivedi: [C: 031] Prevent the browser to scroll while zooming with mouse [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100122 (owner: 10Tpt) [15:33:37] (03PS1) 10Siebrand: Make button text more concise [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/100151 [15:34:55] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100138 (owner: 10Tpt) [15:35:01] (03Merged) 10jenkins-bot: Makes pages without index use text layer extraction and default header and footer [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100138 (owner: 10Tpt) [15:35:23] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100122 (owner: 10Tpt) [15:35:33] (03Merged) 10jenkins-bot: Prevent the browser to scroll while zooming with mouse [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100122 (owner: 10Tpt) [15:40:09] (03PS1) 10Tpt: Use JavaScript to add the level change tag in order to keep the existing process [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100152 [16:14:53] (03CR) 10Rtdwivedi: [C: 031] Use JavaScript to add the level change tag in order to keep the existing process [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100152 (owner: 10Tpt) [16:39:48] (03CR) 10UltrasonicNXT: "Sorry for that, ridiculous number of silly mistakes there!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [16:42:30] (03CR) 10UltrasonicNXT: "Also, if I do $wgSomeGlobal = 'default value', won't I override the value given in LocalSettings? I need to have these variables at the ri" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [17:01:20] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100152 (owner: 10Tpt) [17:01:29] (03Merged) 10jenkins-bot: Use JavaScript to add the level change tag in order to keep the existing process [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/100152 (owner: 10Tpt) [17:26:36] (03CR) 10MZMcBride: "Thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/100117 (owner: 10Theopolisme) [17:40:20] (03CR) 10Ebrahim: [C: 031] Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [17:40:59] (03CR) 10MZMcBride: Tracking category for modules saved with errors (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/99796 (owner: 10Anomie) [18:02:48] hmmm, special version says "MediaWiki 1.23wmf5 (d7c6f6c)" while the latest thing in that branch is cb0ccd1b [18:03:12] * aude wonders [18:07:13] anyone online happen to know how i can see if runJobs.php is run as a cron job on http://commons.wikimedia.beta.wmflabs.org/ ? [18:07:40] i can try to find out [18:08:09] i know where cron jobs are for production but not sure for beta [18:08:21] ah, cool, i'm wondering if the job queue has any pending GWToolset Batch Upload Jobs in it [18:08:37] k, any help would be great [18:08:59] although actually it should be run with redis [18:10:17] k, basically i'm testing the gwtoolset extension … i uploaded a small set of records, 10 [18:10:54] 3 got downloaded to the wiki, the remaining 7 should be taken care of by a batch job, but i can't tell if the batch job is in the queue, failed to run or ? [18:11:21] here are the 3 that got put into the wiki http://commons.wikimedia.beta.wmflabs.org/wiki/Category:GWToolset_Batch_Upload [18:11:41] is there a way i can actually see what's in the queue if anything? [18:12:15] * aude investigating [18:13:08] (03CR) 10Qgil: "Is the last patch correct? This is the third patch of a Google Code-in task, and the other two have been already +1/merged." [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [18:13:17] i'm not sure if details are available other than to shell users [18:13:25] or if so how [18:14:13] hmm [18:15:24] found this http://commons.wikimedia.beta.wmflabs.org/w/api.php?action=query&meta=siteinfo&siprop=statistics [18:15:37] don't know if it's accurate or not. it shows 4 jobs [18:16:06] just wonder how i might get them to run … or see what types of jobs they are ... [18:17:18] it has 4 videos queued [18:17:31] timed media handler? [18:18:11] is Quim Gil here ? [18:18:15] transcoding jobs [18:18:38] ah, that's not the ones i was hoping would be in there [18:19:38] dan-nl: http://dpaste.com/1496233/ [18:20:00] looks like they are getting processed [18:20:27] vandrew_: apparently not, his nick is 'qgil' [18:20:29] @seen qgil [18:20:30] MatmaRex: Last time I saw qgil they were quitting the network with reason: Ping timeout: 246 seconds N/A at 12/6/2013 11:42:19 PM (18h38m10s ago) [18:20:32] yes, see the gwtoolsetUploadMetadaJob … that's the one that should have run [18:20:33] i don't know what "abandoned" means here [18:20:53] is there a way to view the exception log to see why it was abandoned? [18:20:59] maybe it had an error [18:21:08] probably can look [18:21:09] yep that's what i'm thinking [18:21:29] i think that if i can see the exception log i may be able to figure out why [18:21:51] is there a way i could see the exception or erro log? [18:22:24] http://dpaste.com/1496234/ [18:22:37] if you can get added to deployment-prep, you'd be able to do this yourself [18:22:45] or poke someone [18:22:48] perfect that's what i needed [18:23:05] k [18:23:10] thanks, who could add me hasher? [18:23:24] yes hashar [18:23:56] thanks aude [18:24:26] (03CR) 10saper: "See https://bugzilla.wikimedia.org/show_bug.cgi?id=37702#c16 for more details why this is needed." [core] - 10https://gerrit.wikimedia.org/r/100154 (owner: 10saper) [18:25:02] sure :) [18:25:30] oh wow, over 100000 changesets [18:26:14] awww, localisation bot got that one :/ [18:29:46] nice, sure the translation team will be happy about that :) [18:31:09] :) [18:42:40] (03CR) 10Kambiz Darabi: "Nothing at all! I was just so concentrating on _how_ to change things that I didn't consider _not_ changing things." [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [18:45:18] aude: do you know anything about the permissions on the nfs on that beta server? [18:45:52] (03PS3) 10Kambiz Darabi: Allow MediaWiki class to be instantiated inside another PHP application [core] - 10https://gerrit.wikimedia.org/r/99162 [18:47:48] not really [18:48:17] * aude probably would break more stuff if i tried to fix :) [18:48:23] k, i think i'll pickup the work on monday with hashar then [18:48:31] ok [18:48:53] (03PS4) 10Kambiz Darabi: Allow MediaWiki class to be instantiated inside another PHP application [core] - 10https://gerrit.wikimedia.org/r/99162 [19:01:13] (03PS5) 10Kaldari: Conditionally add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 [19:03:43] (03PS6) 10Kaldari: Conditionally add a CSS class to disambiguation pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/100115 [19:12:54] (03CR) 10MarkAHershberger: "Except it takes some manual interaction. The cherry pick button didn't work. *SIGH*" [core] - 10https://gerrit.wikimedia.org/r/99731 (owner: 10saper) [19:15:04] (03CR) 10Umherirrender: "You should split your patch set, for example the part with "Abstract out mysql_field_type() call from DatabaseBase so this works when usin" [core] - 10https://gerrit.wikimedia.org/r/92502 (owner: 10PleaseStand) [19:20:27] (03CR) 10saper: "cherry-picking to REL1_22 fails because noFollow feature is not yet present in its LocalSettingsGenerator, see" [core] - 10https://gerrit.wikimedia.org/r/99731 (owner: 10saper) [19:21:08] (03CR) 10Umherirrender: "ResourceLoaderUserCSSPrefsModule.php contains a fragment, which can be removed when the option is removed." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas) [19:40:40] (03CR) 10Nikerabbit: Add search results found as parameter to showCreateLink (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [19:55:58] (03CR) 10Kipcool: [C: 032 V: 032] Console [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/98748 (owner: 10Hiong3-eng5) [19:56:42] .iso639 Russenorsk [20:09:20] (03PS1) 10Umherirrender: Silencing errors is discouraged [core] - 10https://gerrit.wikimedia.org/r/100165 [20:10:26] (03CR) 10jenkins-bot: [V: 04-1] Silencing errors is discouraged [core] - 10https://gerrit.wikimedia.org/r/100165 (owner: 10Umherirrender) [20:16:25] (03PS1) 10PleaseStand: Abstract out mysql_field_type() call from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/100172 [20:17:34] (03CR) 10jenkins-bot: [V: 04-1] Abstract out mysql_field_type() call from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/100172 (owner: 10PleaseStand) [20:18:47] (03PS2) 10Umherirrender: Silencing errors is discouraged [core] - 10https://gerrit.wikimedia.org/r/100165 [20:19:51] (03PS2) 10PleaseStand: Abstract out mysql_field_type() call from DatabaseBase [core] - 10https://gerrit.wikimedia.org/r/100172 [20:25:37] (03PS1) 10PleaseStand: Remove $dbw->close() call from convertLinks.php [core] - 10https://gerrit.wikimedia.org/r/100173 [20:30:38] (03PS1) 10Umherirrender: Remove @ and break long lines in profileinfo.php [core] - 10https://gerrit.wikimedia.org/r/100174 [20:33:55] (03PS2) 10Umherirrender: Move functions to better place in Special:Search [core] - 10https://gerrit.wikimedia.org/r/97310 [20:34:14] (03PS1) 10PleaseStand: Add new_name_timestamp index when upgrading from 1.1 [core] - 10https://gerrit.wikimedia.org/r/100176 [20:36:07] (03Abandoned) 10PleaseStand: Fix problems when upgrading from MediaWiki 1.1 schema [core] - 10https://gerrit.wikimedia.org/r/92502 (owner: 10PleaseStand) [20:49:36] (03PS1) 10Umherirrender: Break long lines and remove some spaces in Defines.php [core] - 10https://gerrit.wikimedia.org/r/100177 [21:00:08] (03PS1) 10Umherirrender: Break long lines and remove some spaces in Revision.php [core] - 10https://gerrit.wikimedia.org/r/100179 [21:01:20] (03PS1) 10saper: Database independent test for bug 37601 [core] - 10https://gerrit.wikimedia.org/r/100180 [21:02:55] (03CR) 10Siebrand: [C: 032] Break long lines and remove some spaces in Defines.php [core] - 10https://gerrit.wikimedia.org/r/100177 (owner: 10Umherirrender) [21:02:57] (03CR) 10jenkins-bot: [V: 04-1] Database independent test for bug 37601 [core] - 10https://gerrit.wikimedia.org/r/100180 (owner: 10saper) [21:03:07] (03CR) 10Siebrand: [C: 032] Break long lines and remove some spaces in Revision.php [core] - 10https://gerrit.wikimedia.org/r/100179 (owner: 10Umherirrender) [21:06:06] (03Merged) 10jenkins-bot: Break long lines and remove some spaces in Defines.php [core] - 10https://gerrit.wikimedia.org/r/100177 (owner: 10Umherirrender) [21:07:43] (03Merged) 10jenkins-bot: Break long lines and remove some spaces in Revision.php [core] - 10https://gerrit.wikimedia.org/r/100179 (owner: 10Umherirrender) [21:09:34] (03CR) 10Siebrand: [C: 032] Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [21:12:50] (03Merged) 10jenkins-bot: Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [21:13:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [21:13:50] (03CR) 10saper: [C: 031] "Thank you, Jenkins. This commit introduces a test for bug 37601, which should fail unless this bug is fixed." [core] - 10https://gerrit.wikimedia.org/r/100180 (owner: 10saper) [21:14:43] (03CR) 10Siebrand: [C: 04-1] "Per Umherirrender." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas) [21:17:44] (03CR) 10Aaron Schulz: [C: 032] Remove 5 unused block messages [core] - 10https://gerrit.wikimedia.org/r/100126 (owner: 10PleaseStand) [21:18:35] (03CR) 10Aaron Schulz: [C: 032] Remove $dbw->close() call from convertLinks.php [core] - 10https://gerrit.wikimedia.org/r/100173 (owner: 10PleaseStand) [21:18:51] (03PS2) 10Siebrand: Removed "Show table of contents (for pages with more than 3 headings)" from MW user preference [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas) [21:18:59] (03PS3) 10Siebrand: 1234567890123456789012345678901234567890123456789012345678901234567890 Remove preference "Show table of contents (for pages with more ...)" [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas) [21:19:14] siebrand: Err? [21:20:00] (03CR) 10Siebrand: "Per Umherirrender's comments on PS1." [core] - 10https://gerrit.wikimedia.org/r/99430 (owner: 1001tonythomas) [21:20:53] (03CR) 10Umherirrender: Add UI to discover translated SVG files. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [21:20:55] (03Merged) 10jenkins-bot: Remove 5 unused block messages [core] - 10https://gerrit.wikimedia.org/r/100126 (owner: 10PleaseStand) [21:22:45] (03Merged) 10jenkins-bot: Remove $dbw->close() call from convertLinks.php [core] - 10https://gerrit.wikimedia.org/r/100173 (owner: 10PleaseStand) [21:58:59] (03PS1) 10saper: Teach ORMTable to use sequences [core] - 10https://gerrit.wikimedia.org/r/100183 [22:18:47] (03PS1) 10Siebrand: Use 'brackets' message instead of hard coded brackets [core] - 10https://gerrit.wikimedia.org/r/100184 [22:25:46] (03CR) 10Siebrand: "This caused bug 57818." [core] - 10https://gerrit.wikimedia.org/r/64365 (owner: 10Bartosz Dziewoński) [22:51:45] (03PS1) 10PleaseStand: Fix RequestAccountPage::confirmEmailToken() [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/100193 [22:52:58] (03CR) 10PleaseStand: "Untested." [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/100193 (owner: 10PleaseStand) [22:55:51] (03CR) 10Bartosz Dziewoński: [C: 032] Add PLURAL support to youhavenewmessages* [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [22:56:59] (03CR) 10PleaseStand: "Patch for ConfirmAccount is I22c3e29b." [core] - 10https://gerrit.wikimedia.org/r/100128 (owner: 10PleaseStand) [22:57:19] (03PS2) 10PleaseStand: Remove unused message 'confirmemail_error' [core] - 10https://gerrit.wikimedia.org/r/100128 [22:59:02] (03Merged) 10jenkins-bot: Add PLURAL support to youhavenewmessages* [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [23:02:23] (03PS7) 10Ori.livneh: Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [23:02:45] (03CR) 10Ori.livneh: [C: 032] Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [23:07:38] (03Merged) 10jenkins-bot: Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [23:12:41] (03CR) 10Raimond Spekking: [C: 032 V: 032] Make button text more concise [extensions/RevisionCommentSupplement] - 10https://gerrit.wikimedia.org/r/100151 (owner: 10Siebrand) [23:25:52] (03CR) 10Siebrand: [C: 032] Remove unused message 'confirmemail_error' [core] - 10https://gerrit.wikimedia.org/r/100128 (owner: 10PleaseStand) [23:28:51] (03Merged) 10jenkins-bot: Remove unused message 'confirmemail_error' [core] - 10https://gerrit.wikimedia.org/r/100128 (owner: 10PleaseStand) [23:46:47] (03PS5) 10MegaAlex: Add search results found as parameter to showCreateLink [core] - 10https://gerrit.wikimedia.org/r/99265 [23:55:05] (03PS1) 10Jcf2000: Implement keyboard navigation for BookManagerv2 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/100195