[00:00:46] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf6 tip [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99560 (owner: 10MaxSem) [00:03:03] (03CR) 10Bartosz Dziewoński: "(Aw, Aaron's comment was not there when I +2'd, sorry. Needs edit conflict detection!)" [core] - 10https://gerrit.wikimedia.org/r/99336 (owner: 10Siebrand) [00:04:46] (03PS1) 10Bsitu: Remove duplicated mention notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99563 [00:05:34] (03PS1) 10EBernhardson: Properly escape post moderation state in template output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99564 [00:06:28] (03CR) 10Aude: [C: 031] "looks good!" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99546 (owner: 10BryanDavis) [00:08:06] aude: I'll try to put bugs in for things that I know still need fixed tomorrow. The list is getting shorter but of course I keep find new problems. [00:08:24] ok [00:08:37] i am tryign to install it again and then try it out [00:09:08] It should be pretty easy to get running (I hope). [00:09:11] seems to work, except that i need to setup user(s) [00:09:20] i can make a script for it [00:09:30] unless there is some other recommended way [00:09:39] Ah i have a script for that on the scholarship-alpha box [00:09:46] ok [00:09:56] pretty simple [00:10:02] INSERT INTO users (username, password, email, reviewer, isvalid, isadmin) [00:10:02] VALUES ('admin', '$2y$08$QeeLottZC5JIZnq/yzafNebEhyB4UPNIVtAWkxdKOpg58uawGfrri', 'bd808+scholarship@wikimedia.org', 1, 1, 1); [00:10:13] :) [00:10:16] that makes an admin/password login [00:10:40] ok [00:10:54] (03CR) 10GWicke: "Ping ping!" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93526 (owner: 10Ori.livneh) [00:11:28] (03CR) 10Ori.livneh: "Gabriel, sure, we can normalize it; I just don't have the time to implement that myself at the moment." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93526 (owner: 10Ori.livneh) [00:11:41] werdna: Do you have any idea what's causing the significant number of duplicate LQT threads on mw.org? It's not a new thing, I've been seeing it for as long as I can remember, but I suspect a JS issue perhaps (maybe it doesnt' disable the button after clicking submit by ajax and keeps listening?) [00:12:15] https://www.mediawiki.org/wiki/Special:Log/delete?user=Krinkle [00:12:19] Krinkle: Not sure. May also be a double-loading of JS [00:12:59] https://www.mediawiki.org/wiki/Special:Log/delete/Krinkle [00:13:11] Elsie: mind blown [00:13:19] :-) [00:13:21] (03CR) 10Bsitu: [C: 032] Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [00:13:33] Elsie: Nice, is that new-ish? [00:13:34] (03Merged) 10jenkins-bot: Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [00:13:37] (03PS1) 10Cscott: Update test cases (use latest bundler; add multi-wiki test). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99567 [00:13:38] (03PS1) 10Cscott: Ensure that errors inside promises result in non-zero exit status. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99568 [00:13:39] (03PS1) 10Cscott: Improve Arabic, Devanagari, and Urdu fonts. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99569 [00:13:40] (03PS1) 10Cscott: Improve font/language handling in multiwiki collections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99570 [00:13:41] (03PS1) 10Cscott: Handle missing keys more gracefully in Db module. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99571 [00:13:59] Krinkle: Probably from this year, not sure. [00:14:05] cool [00:14:15] (03CR) 10Cscott: [C: 032] Update test cases (use latest bundler; add multi-wiki test). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99567 (owner: 10Cscott) [00:14:22] (03CR) 10Cscott: [C: 032] Ensure that errors inside promises result in non-zero exit status. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99568 (owner: 10Cscott) [00:14:29] (03CR) 10Cscott: [C: 032] Improve Arabic, Devanagari, and Urdu fonts. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99569 (owner: 10Cscott) [00:14:36] (03CR) 10Cscott: [C: 032] Improve font/language handling in multiwiki collections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99570 (owner: 10Cscott) [00:14:43] zooooommmgggggg [00:14:44] (03CR) 10Cscott: [C: 032] Handle missing keys more gracefully in Db module. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99571 (owner: 10Cscott) [00:17:30] (03Merged) 10jenkins-bot: Update test cases (use latest bundler; add multi-wiki test). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99567 (owner: 10Cscott) [00:17:35] (03CR) 10CSteipp: "We never want to pass user-controlled data to unserialize, so this would only be possible if we know $image can't be tampered with." [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [00:17:44] (03PS1) 10EBernhardson: Double quote all html attributs (htmlspecialchars does not escape ') [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99573 [00:18:08] (03Merged) 10jenkins-bot: Ensure that errors inside promises result in non-zero exit status. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99568 (owner: 10Cscott) [00:18:15] csteipp: We already assume $image cannot be tampered with. We unserialize the img_metadata field of the db all over the place [00:18:53] (03Merged) 10jenkins-bot: Improve Arabic, Devanagari, and Urdu fonts. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99569 (owner: 10Cscott) [00:19:00] (03CR) 10Chad: [C: 032] Add missing Apply::updateNotes() function [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99546 (owner: 10BryanDavis) [00:19:05] csteipp: DjVu is (currently) the exception, all other images that support metadata use unserialize for dealing with the metadata [00:19:07] (03Merged) 10jenkins-bot: Add missing Apply::updateNotes() function [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99546 (owner: 10BryanDavis) [00:19:24] (03Merged) 10jenkins-bot: Improve font/language handling in multiwiki collections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99570 (owner: 10Cscott) [00:20:03] (03Merged) 10jenkins-bot: Handle missing keys more gracefully in Db module. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99571 (owner: 10Cscott) [00:22:58] (03CR) 10Chad: [C: 032] Change line breaks in LocalFile::recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/99147 (owner: 10Siebrand) [00:23:44] (03CR) 10Chad: [C: 032] Update documentation for log related classes [core] - 10https://gerrit.wikimedia.org/r/98859 (owner: 10Siebrand) [00:24:21] (03CR) 10Aaron Schulz: "The XML is the result of calling a metadata process on the file, so a user should not be able to cause arbitrary output." [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [00:26:12] (03PS1) 10Mwalker: DI to master [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/99581 [00:26:27] (03CR) 10Mwalker: [C: 032 V: 032] DI to master [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/99581 (owner: 10Mwalker) [00:26:29] (03CR) 10Brian Wolff: "Additionally, after this change, it would be impossible to have new raw xml entries in the img_metadata field." [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [00:26:36] (03Merged) 10jenkins-bot: Change line breaks in LocalFile::recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/99147 (owner: 10Siebrand) [00:27:31] (03CR) 10Bsitu: [C: 032] Double quote all html attributs (htmlspecialchars does not escape ') [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99573 (owner: 10EBernhardson) [00:28:31] (03Merged) 10jenkins-bot: Update documentation for log related classes [core] - 10https://gerrit.wikimedia.org/r/98859 (owner: 10Siebrand) [00:29:45] (03CR) 10MZMcBride: Double quote all html attributs (htmlspecialchars does not escape ') (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99573 (owner: 10EBernhardson) [00:33:59] (03Merged) 10jenkins-bot: Double quote all html attributs (htmlspecialchars does not escape ') [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99573 (owner: 10EBernhardson) [00:34:27] (03PS2) 10EBernhardson: Properly escape moderation state in template output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99564 [00:35:26] (03PS1) 10Spage: Add class errorbox to showError() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99583 [00:35:45] (03CR) 10jenkins-bot: [V: 04-1] Properly escape moderation state in template output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99564 (owner: 10EBernhardson) [00:37:56] (03PS1) 10Tholam: Use an IContextSource instead of globals in addDate method [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 [00:38:30] (03PS1) 10EBernhardson: Properly escape the output of flow-topic-comments i18n message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99585 [00:39:00] (03PS2) 10Tholam: Use an IContextSource instead of globals in addDate method [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 [00:39:54] (03PS4) 10Chad: Fix fetching ParserOutput [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 [00:39:58] (03CR) 10Chad: Fix fetching ParserOutput (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [00:42:45] (03CR) 10Tim Starling: "What is it for?" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [00:43:22] (03CR) 10Legoktm: [C: 04-1] "You also need to update the functions that call this method, which is BookManagerv2Hooks::formatMetadata, however that also needs context," [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [00:43:50] (03PS3) 10EBernhardson: Properly escape moderation state in template output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99564 [00:46:01] (03PS1) 10JGonera: [WIP] Add Compact personal bar beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 [00:46:10] (03CR) 10EBernhardson: [C: 032] Add class errorbox to showError() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99583 (owner: 10Spage) [00:46:18] (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [00:46:25] (03Merged) 10jenkins-bot: Add class errorbox to showError() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99583 (owner: 10Spage) [00:47:27] (03CR) 10Brian Wolff: "I should also mention, I tested this with proofread page, and everything seemed to be fine." [core] - 10https://gerrit.wikimedia.org/r/99544 (owner: 10Brian Wolff) [00:52:34] (03PS3) 10Tholam: Use an IContextSource instead of globals in addDate method [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 [00:54:28] (03CR) 10Tholam: "I tried to find out how onBeforePageDisplay was called but couldn't find where." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [00:55:40] (03PS1) 10Bsitu: use substr instead of preg_match to check for '_id' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99588 [00:56:46] (03PS4) 10Tholam: Use an IContextSource instead of globals in addDate method [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 [00:58:04] (03CR) 10Legoktm: Use an IContextSource instead of globals in addDate method (032 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [01:01:46] (03PS5) 10Tholam: Use an IContextSource instead of globals in addDate method [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 [01:02:40] superm401: is there any reason to keep the 'editor engagement' project in mingle? [01:02:47] (https://mingle.corp.wikimedia.org/projects/ee) [01:03:10] I've never used it. Core Features using the Flow board, right? [01:03:20] correct superm401 [01:03:23] You should double-check with StevenW, but I don't think we're lanning to use it. [01:03:28] kk thanks [01:03:35] StevenW: ^^? [01:04:06] Yeah we're not using [01:04:11] KILL IT [01:04:14] WITH FIRE [01:04:18] with pleasure, StevenW [01:04:20] thanks! [01:04:23] np [01:06:02] (03CR) 10EBernhardson: [C: 032] use substr instead of preg_match to check for '_id' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99588 (owner: 10Bsitu) [01:06:11] (03Merged) 10jenkins-bot: use substr instead of preg_match to check for '_id' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99588 (owner: 10Bsitu) [01:06:34] (03CR) 10Bsitu: [C: 032] Page title does not display corectly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99531 (owner: 10EBernhardson) [01:06:43] (03CR) 10Legoktm: [C: 04-1] Use an IContextSource instead of globals in addDate method (033 comments) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [01:06:44] (03Merged) 10jenkins-bot: Page title does not display corectly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99531 (owner: 10EBernhardson) [01:08:37] (03CR) 10Tholam: Use an IContextSource instead of globals in addDate method (031 comment) [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [01:11:02] (03PS6) 10Tholam: Use an IContextSource instead of globals in addDate method [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 [01:18:21] (03CR) 10Spage: "gerrit shows angry red whitespace indicators (I use https://gist.github.com/holysugar/1318698 as my pre-commit hook)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [01:27:46] (03CR) 10Legoktm: [C: 031] "LGTM, going to try to set this extension up so I can confirm it works." [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [01:28:43] spagewmf, are you there? [01:34:14] (03CR) 10Mattflaschen: [C: 04-1] "-1 since this breaks the places in core that use buttons (I think just login/signup, Special:Search, and HTMLForm). You can grep on media" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [01:38:39] (03CR) 10Bsitu: [C: 032] Properly escape moderation state in template output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99564 (owner: 10EBernhardson) [01:38:49] (03Merged) 10jenkins-bot: Properly escape moderation state in template output [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99564 (owner: 10EBernhardson) [01:39:05] (03CR) 10Bsitu: [C: 032] Properly escape the output of flow-topic-comments i18n message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99585 (owner: 10EBernhardson) [01:39:14] (03Merged) 10jenkins-bot: Properly escape the output of flow-topic-comments i18n message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99585 (owner: 10EBernhardson) [01:40:05] (03CR) 10Bsitu: [C: 032] Document return value of HistoryRenderer::getTimespans [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99562 (owner: 10EBernhardson) [01:40:22] (03Merged) 10jenkins-bot: Document return value of HistoryRenderer::getTimespans [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99562 (owner: 10EBernhardson) [01:41:05] (03CR) 10Bsitu: [C: 032] Properly escape button content and document that safe html must be passed in [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99561 (owner: 10EBernhardson) [01:41:18] (03Merged) 10jenkins-bot: Properly escape button content and document that safe html must be passed in [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99561 (owner: 10EBernhardson) [02:01:44] (03CR) 10Krinkle: Update Releasenotes and version number for 1.21.3 (031 comment) [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95547 (owner: 10CSteipp) [02:07:18] (03CR) 10Bsitu: Ensure non-binary cache keys (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 (owner: 10EBernhardson) [02:10:48] (03CR) 10Bsitu: [C: 032] Group revision by the type(header or post id) in RevisionStorage::findMostRecent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99559 (owner: 10EBernhardson) [02:10:58] (03Merged) 10jenkins-bot: Group revision by the type(header or post id) in RevisionStorage::findMostRecent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99559 (owner: 10EBernhardson) [02:12:13] (03PS5) 10Ragesoss: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 [02:16:53] (03PS1) 10Legoktm: WebRequest::getCheck is never null [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99593 [02:17:26] (03CR) 10GWicke: "Did you test this?" [core] - 10https://gerrit.wikimedia.org/r/98067 (owner: 10Aaron Schulz) [02:21:39] (03CR) 10Brian Wolff: [C: 04-1] Converted html cache updates to use BacklinkJobUtils (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98067 (owner: 10Aaron Schulz) [02:24:09] (03CR) 10Aaron Schulz: Converted html cache updates to use BacklinkJobUtils (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98067 (owner: 10Aaron Schulz) [02:28:34] (03CR) 10Mollywhite: [C: 032 V: 032] WebRequest::getCheck is never null [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99593 (owner: 10Legoktm) [02:29:09] (03CR) 10Brian Wolff: Converted html cache updates to use BacklinkJobUtils (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98067 (owner: 10Aaron Schulz) [02:32:23] (03CR) 10Tim Starling: [C: 04-1] "The application Betacommand suggests on the bug needs a batch lookup feature, deploying and using this patch for it would be very ineffici" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [02:38:31] (03PS3) 10Aaron Schulz: Converted html cache updates to use BacklinkJobUtils [core] - 10https://gerrit.wikimedia.org/r/98067 [02:41:25] (03PS1) 10Ori.livneh: Don't load mw.PopUpMediaTransform unconditionally [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 [02:41:56] (03PS1) 10Aaron Schulz: Removed excess title validity check [core] - 10https://gerrit.wikimedia.org/r/99598 [02:43:31] (03CR) 10Krinkle: [C: 04-1] mediawiki.js: add `mw.track`, imported from VisualEditor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99547 (owner: 10Ori.livneh) [02:45:23] (03CR) 10Brian Wolff: [C: 032] "This looks good to me" [core] - 10https://gerrit.wikimedia.org/r/98067 (owner: 10Aaron Schulz) [02:45:38] ori-l: Woo, people giving TMH love and attention [02:48:26] (03Merged) 10jenkins-bot: Converted html cache updates to use BacklinkJobUtils [core] - 10https://gerrit.wikimedia.org/r/98067 (owner: 10Aaron Schulz) [02:52:34] bawolff: i liked how it uses every possible means of adding javascript to pages [02:52:42] *like [02:52:46] Don't even get me started [02:52:59] I'd change it, but it scares me [02:54:03] then there's MwEmbedSupport [02:54:09] completely unrelated, as you know [02:54:10] yeah [02:54:16] it's a generic framework [02:54:35] Extension:TotallyNotTimedMediaHandler [02:55:21] Extension:MakesWeirdAssuptionsAboutMyInstallPathAndWasAPainToGetWorkingLocally (although in fairness, I think someone fixed that issue) [02:56:44] ori-l, can you review https://gerrit.wikimedia.org/r/#/c/99600/ ? [02:56:49] It's the draft namespace for Labs. [02:56:56] I think I got the override syntax right. [02:57:17] It didn't look like you can just add individual subentries (e.g. just the new namespaces for enwiki), so for existing keys I put the whole enwiki. [03:00:47] superm401: hm, looks a bit tricky. i'll eat dinner and get back to this in a bit [03:01:13] Alright, thanks. [03:01:24] (03PS2) 10Aaron Schulz: Removed excess title validity check [core] - 10https://gerrit.wikimedia.org/r/99598 [03:09:02] superm401: btw, for what its worth, I tested that hook locally, and it appears to work [03:09:14] Thank you. [03:09:34] I tested some stuff too locally (basic creations, protection and blocking). [03:10:12] One thing I would note, is it might override how oAuth overrides permissions, I'm not sure. That wouldn't actually hurt anything, since in oAuth if page creation is restricted so is editing [03:17:06] bawolff, I'll check. [03:18:02] superm401: you would need to set up your own custom grants to actually notice it, the default grants the user would fail other checks [03:20:01] superm401: I'm 99% sure it would override oAuth [03:20:35] should someone set up oAuth to grant edit rights without page creation rights [03:27:28] (03CR) 10Catrope: [C: 04-2] "I'm redoing the way OOJS UI does i18n, see https://gerrit.wikimedia.org/r/#/c/99603/" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [03:29:54] oh wait, I guess that is possible, I just misread the oauth page. I think the hook would allow apps with "Edit existing pages" rights, to also create pages in draft namespace [03:34:07] bawolff, OAuth doesn't use TitleQuickPermissions so tentatively, it may not interfere. [03:34:34] It uses a hook that's called later on [03:34:38] Oh, but it may since TitleQuickPermissions relies on user rights, and it does work through UserGetRights [03:35:04] yeah [03:35:55] superm401: i don't think it works [03:36:19] ori-l, thanks, can you explain? [03:36:24] We could work around it, by changing the hook for drafts to just do a user->isAllowed( 'createtalk' ); and redirect the permission check to be as if it was for a talk page (If this is even a concern at all) [03:36:46] bawolff, not sure that's really more clear. [03:37:32] It wouldn't be particularly clear, but it might have more expected behaviour [03:41:05] bawolff, OAuth doesn't support anons, does it? [03:41:23] superm401: no it does not [03:41:55] I kind of feel like nobody is going to care about this issue [03:42:14] It's not a big deal to fix. [03:42:21] We can just only suppress the check if they're logged out. [03:42:37] Which is an ID check so it shouldn't be a significant performance cost. [03:42:50] superm401: why don't you simply add if ( $wgDBname === 'enwiki' ) $wgExtraNamespaces[110] 'Draft'; ? [03:42:57] to CommonSettings-labs.php, I mean [03:44:20] What makes you think it doesn't work? [03:44:41] it works, it's just weird to duplicate the settings [03:45:00] i live-hacked InitialiseSettings-labs.php on labs to check it [03:45:12] Alright, I can do it that way. [03:45:33] I put it in Init since it seemed to be the normal way. But it doesn't matter either way, since if it works, we'll take it right out. [03:46:18] OK, so just do it this way [03:46:26] I'll merge, ok? [03:46:42] ori-l, wait for me to add the isAnon, please. [03:47:00] MERGE MERGE MERGE MERGE [03:47:03] ok, I'll wait. [03:50:54] (03PS1) 10EBernhardson: Remove duplicated condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99607 [03:56:37] ori-l, updated. [04:21:01] (03PS5) 10Chad: Fix fetching ParserOutput [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 [04:23:03] Hi Nemo_bis, are you there? [04:24:05] Or also to any of the other mentors- I'm working on a 'Make MediaWiki documentation translatable' task, and I was wondering if should also be put within the tags. [04:31:09] ori-l, are you around by any chance? [04:32:12] can anyone help with MW Vagrant issues? [04:32:48] anyone know how to use --conf with a maintenance script? I just want to override $wgDBname when creating a table , but --conf==/path/to/mySpecialConf.db doesn't work [04:33:02] mooeypoo: what's the problem, I know a little about MW Vagrant [04:33:21] I've installed git, installed Vagrant, and instlled Virtual Box [04:33:27] all latest versions (I'm on windows) [04:33:53] i pulled the mw vagrant repo and went 'vagrant up' and everything went good *until* the point of "Booting VM" [04:34:00] it tried for a while and then failed. [04:34:31] "Timed out while waiting for the machine to boot. This means that [04:34:31] Vagrant was unable to communicate with the guest machine within [04:34:31] the configured ("config.vm.boot_timeout" value) time period. This can [04:34:31] mean a number of things." [04:34:36] ... etc etc. [04:35:12] mooeypoo: umm, you could try running the VirtualBox program, start the VM from that, it might be more informative. [04:35:30] let me see [04:35:51] do a vagrant halt first just to be sure vagrant isn't involved [04:36:08] okay [04:36:28] I did 'vagrant halt' but in Virtual Box the machine says "Running" [04:37:21] where are the config params for mw vagrant? I want to increase 'config.vm.boot_timeout' but i'm not sure where it is [04:38:53] Hello everyone! [04:39:03] Hi Niharika [04:39:05] mooeypoo: interesting, my VirtualBox shows it's stopped. I would try stopping it in VirtualBox, then start from VirtualBox. When I do that I see a console. [04:39:16] * mooeypoo tries [04:39:52] gave me GRUB and ran ubuntu [04:40:27] mooeypoo: in your vagrant folder, there's a Vagrantfile with some vb.customize() lines [04:40:50] right [04:41:25] ok the vagrant vm asks me to login [04:41:29] O.O [04:41:40] there's a user/pass? [04:41:55] mooeypoo: Try admin/vagrant [04:42:08] As username and password. [04:42:12] mooeypoo: right, but vagrant is designed to use `vagrant ssh` , I don't know what the vagrant password is. [04:42:17] Login incorrect. [04:42:27] Try vagrant/vagrant then. [04:42:31] That worked for me. [04:42:43] success! [04:42:46] mooeypoo: so the good news is, you have a working VirtualBox VM, the problem is vagrant doesn't know how to connect to its spawn [04:43:00] I'm in. [04:43:04] okay.. how do I fix that? [04:44:48] mooeypoo: I'm not sure. It's good that you can access the instance console, but vagrant commands like `vagrant provision` "want" to run on the host, contacting the VM over ssh. [04:44:49] so, if I go and do 'vagrant up' while the console is running in the vm -- will I see the resulting operation, or will vagrant get all confused it couldn't open the vm on its own? [04:45:10] oh, if its ssh i won't see it, but i can debug maybe, log files, whatever... perhaps [04:45:38] now I know for sure it's running at least.. meh. should I retry 'vagrant up' or will that fail because I already started it? [04:46:25] mooeypoo: ´vagrant halt´ stops the VM, you should give that command first. [04:46:37] Before retrying vagrant up. [04:46:42] mooeypoo: I don't know, try it. While it's up, does `vagrant ssh` in your host work? [04:47:04] Niharika, I did that before shutting down and restrting the vm myself [04:47:22] How did you restart the VM? Direct from VB? [04:47:27] and 'vagrant ssh' asks for a passphrase [04:47:32] Niharika, aye [04:47:40] anyone knows what the passphrase is? [04:47:54] for the 'insecure private key' [04:48:05] vagrant probably [04:48:10] the password is always 'vagrant' [04:48:10] I just tried that :D [04:48:12] it's not [04:48:14] oh :( [04:48:16] 'root' [04:48:18] 'password' [04:48:19] :P [04:48:21] 'abc123' [04:48:28] 1234 [04:48:31] spaceballs ftw. [04:48:40] mooeypoo: As a thumb rule, never start Vagrant directly from VB. Always use vagrant up and vagrant halt. Thatś what I´ve learnt so far. [04:48:56] Niharika, aye, but the entire problem was that 'vagrant up' failed on booting the VM [04:49:11] mooeypoo: Oh, okay. [04:49:15] so spagewmf and I wanted to see if it boots on its own -- which it does [04:49:27] so. Now what? should I shut down the vm and retry 'vagrant up' from the host? [04:49:42] mooeypoo: I see no harm in trying that. [04:49:50] mooeypoo: I think the problem you'll have is vagrant sets up its password-free connection at first. Now we know you have a working VM you need to get vagrant to retry that part. [04:50:23] hahaha [04:50:28] ok, the insecure private key password? [04:50:32] ... it's nothing. [04:50:33] :D [04:51:11] mooeypoo: so you're in with vagrant ssh? That's good. so exit out, and try `vagrant provision` ont he host [04:51:16] as for ssh == yes, it works [04:51:31] ok sorry to be an idiot, but how do you quit ssh? [04:51:33] (03PS1) 10Mwalker: FR #1113 Treat a subpage like it's a language [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/99613 [04:51:56] mooeypoo: `exit` the shell should do it [04:52:02] ctrl+D [04:52:07] ok i'm out. [04:52:18] the VM is still up. Should I force-close it/ [04:52:20] ? [04:52:42] if the other end freezes, you can usually do ~. [04:52:46] to exit ssh [04:53:06] ooh [04:53:08] neat [04:53:30] mooeypoo: umm, I would leave the VM up according to VirtualBox and run `vagrant provision` on the host, and hope it does everything that might not have happened in your failed `vagrant up` [04:53:41] mooeypoo: but I'm just pretending to be knowledgeable :) [04:53:46] you don't think I should retry vagrant up? [04:54:03] does 'vagrant provision' does the same thing? [04:54:14] mooeypoo: sure, but for me it just says [04:54:14] Bringing machine 'default' up with 'virtualbox' provider... [04:54:15] [default] VirtualBox VM is already running. [04:54:44] aye, for me as well. [04:55:21] okay, so leave the machine up,and do 'vagrant provision' ..lots of stuff happened and i'm back to git shell [04:55:59] "Could not parse PKey: no start line [04:56:26] mooeypoo: you mean multi-colored lines of purple and blue and such? I think that's all puppet config joy. [04:56:29] and then a bunch of lines starting with "from ....in 'map'" ... "from .... in 'load_identities'" ... [04:56:41] nope, they're all white lines. [04:56:47] look like errors [04:57:41] mooeypoo: Yes, I think if you start from VirtualBox vagrant doesn't do some of its setup, like mounting folders and setting up puppet. [04:58:04] ok so, shut down the virtual box vm, and retry 'vagrant up' ? [04:58:17] mooeypoo: yup, I think so. [04:58:22] * mooeypoo attempts [04:59:23] ok it's going, and 'booting vm...' and i saw the vm box status turn to 'running' [04:59:35] so it seems to be working, but vagrant's still waiting "Waiting for machine to boot." [05:00:32] it might well be letting the machine have more time, I am just not sure where to set that configuration option up [05:01:17] yeah again timed out. It's recommending I increase the timeout, but I don't know where I set that line and to what value. is it seconds? [05:02:11] (03CR) 10Legoktm: [C: 032] "Didn't break anything :)" [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [05:02:14] (03Merged) 10jenkins-bot: Use an IContextSource instead of globals in addDate method [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99584 (owner: 10Tholam) [05:02:36] mooeypoo: me neither, you could try vb.customize additions in Vagrantfile as I said. You could also do `vagrant destroy` as https://www.mediawiki.org/wiki/MediaWiki-Vagrant says [05:02:52] found it http://docs.vagrantup.com/v2/vagrantfile/machine_settings.html [05:03:12] it's a bit odd, though [05:03:19] good luck, I gotta go [05:03:22] thanks! [05:04:10] sure. If you see "aniuska" s/he was also getting MW-Vagrant to work in Windows, had different problems :) [05:04:55] thanks :) we'll commiserate [05:07:15] mooeypoo: ´vagrant destroy´ should be a good option. [05:10:18] ok [05:10:28] that would start me from scratch? [05:12:02] Thatĺl destroy the vagrant files and youĺl need to do ´vagrant up´ once to reinstantiate the machine. I´m no expert, but thatś what I understand from the docs. [05:12:09] * mooeypoo nods [05:12:13] retrying. [05:14:46] 'waiting for machine to boot' [05:14:51] crossing fingers. [05:15:31] (03PS1) 10Legoktm: Notice: Undefined variable: jsonPageTitle in /vagrant/mediawiki/extensions/BookManagerv2/BookManagerv2.hooks.php on line 527 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99615 [05:16:01] (03PS2) 10Legoktm: Notice: Undefined variable: jsonPageTitle in /vagrant/mediawiki/extensions/BookManagerv2/BookManagerv2.hooks.php on line 527 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99615 [05:16:39] boot, damn you, boot [05:22:46] (03CR) 10AndyRussG: [C: 04-1] "Nice, just a few details. Seems to work well, though I didn't try all messages with all permutations." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [05:23:20] mooeypoo: Any luck? [05:24:14] Niharika, it doesn't look good. It's still waiting. So, it got my increased timeout request, but it seems to not help :\ [05:24:33] You did a vagrant destroy? [05:24:38] indeed [05:24:53] so weird. The vm seems to be loading properly when i boot it manually -- and even when I don't, it went from "stopped" to "running" during the 'vagrant up' process [05:25:48] Hmm... [05:27:52] (03PS1) 10Legoktm: Set a default value for $wgBookManagerv2JsonEditor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99616 [05:28:09] (03PS2) 10Legoktm: Set a default value for $wgBookManagerv2JsonEditor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99616 [05:32:56] (03CR) 10Mollywhite: [C: 032 V: 032] Notice: Undefined variable: jsonPageTitle in BookManagerv2.hooks.php on line 527 [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99615 (owner: 10Legoktm) [05:33:36] (03CR) 10Mollywhite: [C: 032 V: 032] Set a default value for $wgBookManagerv2JsonEditor [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99616 (owner: 10Legoktm) [05:36:17] (03PS1) 10Aaron Schulz: Small doc comment fix [core] - 10https://gerrit.wikimedia.org/r/99617 [05:42:32] (03CR) 10Aaron Schulz: [C: 032] Small doc comment fix [core] - 10https://gerrit.wikimedia.org/r/99617 (owner: 10Aaron Schulz) [05:45:27] (03Merged) 10jenkins-bot: Small doc comment fix [core] - 10https://gerrit.wikimedia.org/r/99617 (owner: 10Aaron Schulz) [06:05:57] (03PS3) 10Legoktm: Check for missing timestamp using JavaScript [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97480 [06:05:59] (03CR) 10jenkins-bot: [V: 04-1] Check for missing timestamp using JavaScript [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97480 (owner: 10Legoktm) [06:06:07] (03Abandoned) 10Jforrester: Add rc.unpatrolled to the recentchanges API [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95088 (owner: 10Krinkle) [06:09:59] (03Abandoned) 10Legoktm: [WIP] Add Redis backend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92248 (owner: 10Legoktm) [06:13:48] (03Abandoned) 10Legoktm: Create a new Flow topic if the page is occupied [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90474 (owner: 10Legoktm) [06:47:32] (03PS2) 10Ori.livneh: mediawiki.js: add `mw.track`, imported from VisualEditor [core] - 10https://gerrit.wikimedia.org/r/99547 [06:50:37] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.js: add `mw.track`, imported from VisualEditor [core] - 10https://gerrit.wikimedia.org/r/99547 (owner: 10Ori.livneh) [06:53:52] YuGin: no, no need to translate comments [06:53:55] (03PS1) 10EBernhardson: Each wiki needs its own definitions; [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99618 [06:54:25] (03CR) 10EBernhardson: [C: 032] Each wiki needs its own definitions; [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99618 (owner: 10EBernhardson) [06:54:34] (03CR) 10EBernhardson: [V: 032] Each wiki needs its own definitions; [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99618 (owner: 10EBernhardson) [06:54:57] YuGin: if they are useful to traslate an unit, you can and should move them to the corresponding qqq [06:55:04] (message documentation) [06:57:06] Nemo_bis- the comment in question is actually , so probably not. [07:02:55] :) [07:13:06] (03PS1) 10Legoktm: Send Thanks log entries to UDP [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99619 [07:23:43] (03PS10) 10Legoktm: Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 [07:23:48] (03CR) 10Legoktm: Add Special:Thanks as a non-JS fallback (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [07:32:56] (03PS2) 10Siebrand: Make visibleMetadataField protected [core] - 10https://gerrit.wikimedia.org/r/99455 [07:33:27] (03PS2) 10Siebrand: Remove function call from for loop test part in GIFMetadataExtractor::readGCT() [core] - 10https://gerrit.wikimedia.org/r/99454 [07:33:49] (03CR) 10Siebrand: [C: 032] "Per Bartosz's earlier +2, now after rebase." [core] - 10https://gerrit.wikimedia.org/r/99454 (owner: 10Siebrand) [07:34:35] (03PS2) 10Siebrand: Simplify ternary construction [core] - 10https://gerrit.wikimedia.org/r/99452 [07:34:47] (03CR) 10Siebrand: [C: 032] "Per Bartosz's earlier +2, now after rebase." [core] - 10https://gerrit.wikimedia.org/r/99452 (owner: 10Siebrand) [07:40:05] (03Merged) 10jenkins-bot: Remove function call from for loop test part in GIFMetadataExtractor::readGCT() [core] - 10https://gerrit.wikimedia.org/r/99454 (owner: 10Siebrand) [07:42:50] (03Merged) 10jenkins-bot: Simplify ternary construction [core] - 10https://gerrit.wikimedia.org/r/99452 (owner: 10Siebrand) [07:46:53] (03PS1) 10PleaseStand: Remove 3 unused movepage messages [core] - 10https://gerrit.wikimedia.org/r/99620 [07:47:58] (03PS1) 10PleaseStand: Remove unused message 'resetpass' [core] - 10https://gerrit.wikimedia.org/r/99621 [07:48:04] (03PS1) 10PleaseStand: Remove 3 unused allpages messages [core] - 10https://gerrit.wikimedia.org/r/99622 [08:00:47] (03CR) 10Mattflaschen: [C: 032] Thanks is not using namespaces [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97195 (owner: 10Legoktm) [08:00:56] (03Merged) 10jenkins-bot: Thanks is not using namespaces [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97195 (owner: 10Legoktm) [08:01:41] (03PS2) 10Ori.livneh: Don't load mw.PopUpMediaTransform unconditionally [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/99597 [08:12:41] (03PS3) 10Scimonster: Unblacklist group-user-css/js [core] - 10https://gerrit.wikimedia.org/r/99434 [08:29:49] (03PS1) 10Whym: Add local names in Japanese [extensions/cldr] - 10https://gerrit.wikimedia.org/r/99623 [08:30:57] (03PS2) 10Whym: Add local names in Japanese [extensions/cldr] - 10https://gerrit.wikimedia.org/r/99623 [08:35:04] Nemo_bis, can you approve the page I chose for translation? ( https://www.mediawiki.org/wiki/Help:Extension:FlaggedRevs ) [08:35:29] I've already struck it out on the migration list [08:35:30] YuGin: are you done already with the other page I marked? [08:35:47] That page actually only had a bit of translations which were already copied over [08:35:51] yes I know, didn't get to it yet in my morning mail processing, it's next item :) [08:35:57] ok [08:36:18] Ah, ok, take your time. [08:37:11] YuGin: "Sighted" is no longer correct, the term was replaced [08:40:15] YuGin: when quoting interface messages, the ideal is to actually call them, like this: https://www.mediawiki.org/w/index.php?title=Help%3AExtension%3AFlaggedRevs&diff=836890&oldid=836844 [08:41:14] I suggest to either remove that table from translation for now, or ensure its consistency with actual software translations [08:41:50] What does ;{{int:revreview-accuracy-1}} actually indicate? [08:43:02] YuGin: it's called a magic word http://mediawiki.org/wiki/Help:Magic_words [08:45:17] Hmm, so 'sighted' is replaced by 'rereview-accuracy-1'? [09:05:46] Urgh, my IRC died for a few minutes there. [09:06:20] Nemo_bis- Also, should all interface messages be replaced by the {{int:messagename}} format? [09:07:37] (03PS4) 10Parent5446: Unblacklist group-user-css/js [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [09:08:02] (03CR) 10Parent5446: [C: 031] Unblacklist group-specific JS/CSS for the user group [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [09:17:54] YuGin: yes, if possible [09:18:20] especially if they say click "text": it's nasty if the text doesn't correspond [09:19:33] Nemo_bis, ok, and just to clarify, the content of the messages are still the same, right? i.e. for e.g. 'acceptable' should become {{int:acceptable}}? [09:20:01] With the exception of 'sighted' which becomes rereview-accuracy-1? [09:20:13] YuGin: after int: comes the message name, I doubt [[MediaWiki:acceptable]] exists [09:20:33] I think they just go on -2 -3 -4 etc., but you can use https://translatewiki.net/w/i.php?title=Special:SearchTranslations [09:23:19] Nemo_bis- I see, thanks- I'll make the changes now. [09:34:14] YuGin: I've marked it for now, excluding the parts which need work, so that you can migrate most translations today; i'll be afk all day [09:34:36] Nemo_bis, I'm almost done! :/ [09:36:56] and I'm almost out [09:37:12] Ok, never mind, the bits at the end are a little trickier [09:37:20] I'll just copy over what I have firsst. [10:06:04] hashar, have you had a chance to look at this gerrit commit? https://gerrit.wikimedia.org/r/#/c/98684/ i think i need your +1 in order for it to move forward. i believe bd808|BUFFER or marktraceur will merge it once csteipp officially closes this https://bugzilla.wikimedia.org/show_bug.cgi?id=56178 [10:10:07] (03CR) 10Hashar: [C: 032] Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99522 (owner: 10Tpt) [10:12:59] (03Merged) 10jenkins-bot: Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99522 (owner: 10Tpt) [10:15:53] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99428 (owner: 10Tpt) [10:16:05] (03Merged) 10jenkins-bot: Adds the capacity to zoom by mouse wheel [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99428 (owner: 10Tpt) [10:20:55] (03PS1) 10Tpt: Update ProofreadPage to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99627 [10:23:26] (03CR) 10Hashar: [C: 032] Update ProofreadPage to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99627 (owner: 10Tpt) [10:26:21] (03Merged) 10jenkins-bot: Update ProofreadPage to master [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99627 (owner: 10Tpt) [11:08:42] (03CR) 10Daniel Kinzler: [C: 04-1] Add validation of the content model edited by EditPage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [11:09:33] (03CR) 10Daniel Kinzler: [C: 04-1] "see my comments on the patch against master" [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99519 (owner: 10Tpt) [11:10:03] (03CR) 10Daniel Kinzler: [C: 04-1] "see my comments on the patch against master" [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99518 (owner: 10Tpt) [11:10:28] (03CR) 10Calak: [C: 031] Add PLURAL and GENDER support for some messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [11:12:15] (03CR) 10Siebrand: Add PLURAL and GENDER support for some messages (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [11:12:36] (03PS1) 10Siebrand: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 [11:12:39] (03CR) 10jenkins-bot: [V: 04-1] i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [11:14:41] (03PS2) 10Siebrand: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 [11:16:24] (03PS1) 10Jack Phoenix: Version 3.0: AJAX pager, better anti-spam measures, etc. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/99632 [11:26:39] (03PS1) 10Tpt: Add the level change summary tag even if there is an edit summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99634 [11:26:45] (03CR) 10jenkins-bot: [V: 04-1] Add the level change summary tag even if there is an edit summary [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99634 (owner: 10Tpt) [11:32:40] (03CR) 10Jack Phoenix: [C: 032 V: 032] Version 3.0: AJAX pager, better anti-spam measures, etc. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/99632 (owner: 10Jack Phoenix) [11:44:43] (03PS7) 10Tpt: Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 [11:45:59] (03CR) 10Tpt: "Addition of a nice error message." [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [12:14:36] (03CR) 10Siebrand: [C: 032] Add local names in Japanese [extensions/cldr] - 10https://gerrit.wikimedia.org/r/99623 (owner: 10Whym) [12:14:47] (03Merged) 10jenkins-bot: Add local names in Japanese [extensions/cldr] - 10https://gerrit.wikimedia.org/r/99623 (owner: 10Whym) [12:16:42] (03CR) 10Siebrand: [C: 032] Remove 3 unused allpages messages [core] - 10https://gerrit.wikimedia.org/r/99622 (owner: 10PleaseStand) [12:18:35] (03CR) 10Siebrand: [C: 032] Remove unused message 'resetpass' [core] - 10https://gerrit.wikimedia.org/r/99621 (owner: 10PleaseStand) [12:19:47] (03Merged) 10jenkins-bot: Remove 3 unused allpages messages [core] - 10https://gerrit.wikimedia.org/r/99622 (owner: 10PleaseStand) [12:20:28] (03CR) 10Siebrand: [C: 032] Remove 3 unused movepage messages [core] - 10https://gerrit.wikimedia.org/r/99620 (owner: 10PleaseStand) [12:21:44] (03Merged) 10jenkins-bot: Remove unused message 'resetpass' [core] - 10https://gerrit.wikimedia.org/r/99621 (owner: 10PleaseStand) [12:22:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [12:25:45] (03Merged) 10jenkins-bot: Remove 3 unused movepage messages [core] - 10https://gerrit.wikimedia.org/r/99620 (owner: 10PleaseStand) [12:26:36] (03PS1) 10Aude: Update DataValues, fix js error on test.wikidata [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99638 [12:27:11] Reedy or anyone who'd like to deploy small thing: https://gerrit.wikimedia.org/r/#/c/99638/ [12:27:19] for test.wikidata [12:29:40] (03CR) 10Daniel Kinzler: [C: 04-1] "The qqq messages should read something like:" [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [12:31:50] Reedy: Do you have any idea what might cause namespaces to not work [anymore?] on some ml sites? https://bugzilla.wikimedia.org/show_bug.cgi?id=58074 confuses me [12:36:35] (03CR) 10Siebrand: [C: 031] "LGTM" (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 (owner: 10Ragesoss) [12:37:56] (03CR) 10Aude: "i wonder if the actual page should be kept as the title? not sure how it's handled for other error cases in edit page." [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [12:40:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/99586 (owner: 10JGonera) [12:45:32] edsanders: Love your "I'm in denial" comment :) [12:47:20] don't take it personally ;) [12:48:30] (03CR) 10Siebrand: [C: 04-1] "See inline comment. New message keys must be added to maintenance/language/messages.inc." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [12:49:08] edsanders: I don't. Just thought it was funny. Abstractions contain a lot of denial :) [12:49:50] edsanders: btw, you might have stumbled on a use case that justifies decoupling LangDB from ULS. [12:50:07] edsanders: It's been theorised before.... [12:51:04] So the example I gave is correct? [12:51:26] edsanders: You mean Roan's suggestion? [12:51:44] I mean the en-pirate edge case [12:51:50] * YuviPanda puts License Headers on all files everywhere [12:52:07] edsanders: ehr. How did we get to pirate from LangDB? [12:52:42] ok, I don't understand the LangDB ULS thing... [12:53:06] edsanders: Okay. Miscommunication, obviously. [12:53:10] (03PS1) 10saper: Don't assume test user has ID 1 in SpecialPageTest [core] - 10https://gerrit.wikimedia.org/r/99640 [12:53:25] edsanders: Let me look up some sources :) [12:54:11] edsanders: I read your comment on https://gerrit.wikimedia.org/r/#/c/98284/, but hadn't seen "Roan: also are those lists built from the same data source? E.g. if I configured my wiki to have en-pirate, the API would have that data but would the ULS library?" [12:54:21] My latest comment on that commit was that if you added a custom interwiki language then you couldn't get the autonym from ULS [12:54:27] right [12:54:45] do you know the answer to that? [12:54:54] edsanders: The answer to those questions are "probably no" and "no" [12:55:04] edsanders: Have to look into the former. [12:55:25] edsanders: Which is the former data source? [12:55:42] (03CR) 10saper: "Needless to say, this caused SpecialPageTest to fail badly on PostgreSQL :)" [core] - 10https://gerrit.wikimedia.org/r/99640 (owner: 10saper) [12:55:52] edsanders: LangDB is a very specific dataset, that does not have translations. [12:56:15] edsanders: https://github.com/wikimedia/jquery.uls/blob/master/data/langdb.yaml [12:57:22] I don't know what any of the language sources I, I was just guessing that if we got the autonyms from the backend instead of the frontend there might be cases where that is better [12:57:25] * siebrand greets anomie. [12:57:30] *sources are [12:57:55] edsanders: Okay. If backend is MediaWiki, the data source is CLDR. [12:58:07] edsanders: If it's something else (Parsoid?), I don't know. [12:58:48] hi siebrand [12:59:12] anomie|away: What timezone are you in? Insomnia if it's PDT, I guess... [12:59:30] siebrand: US eastern [12:59:46] anomie|away: UTC-5? [12:59:54] Yeah, that sounds right [12:59:58] anomie|away: Good morning, then :) [13:04:41] * siebrand greets AndyRussG  [13:05:45] (03PS1) 10Odder: Add a LanguageAng.php file for Old English projects [core] - 10https://gerrit.wikimedia.org/r/99641 [13:08:19] (03CR) 10Siebrand: [C: 04-1] "This also needs an implementation in JavaScript, and tests." [core] - 10https://gerrit.wikimedia.org/r/99641 (owner: 10Odder) [13:12:46] Hello everyone. [13:19:08] (03PS2) 10MegaAlex: Add search results found as parameter to showCreateLink [core] - 10https://gerrit.wikimedia.org/r/99265 [13:19:45] (03CR) 10jenkins-bot: [V: 04-1] Add search results found as parameter to showCreateLink [core] - 10https://gerrit.wikimedia.org/r/99265 (owner: 10MegaAlex) [13:29:40] hey hashar, have you had a chance to look at this gerrit commit? https://gerrit.wikimedia.org/r/#/c/98684/ i think i need your +1 in order for it to move forward [13:31:40] ahh [13:31:41] filebackend [13:31:42] :( [13:32:03] dan-nl: I guess we could just merge it in [13:32:43] i think the idea is for you to only +1 it for now [13:32:52] and then reedy would do the +2? [13:32:56] i don't know [13:33:06] if that is ready , we can just deploy it [13:33:10] Reedy: three ? [13:33:13] there ? [13:33:37] chris is almost done with his security review … he hasn't close the ticket just yet [13:34:18] i was thinking we just needed to get that config commit prepped with a +1, maybe not … i'll chat this eve with bd808|BUFFER about it [13:35:20] the filebackend..I have no clue honestly [13:36:09] (03PS3) 10MegaAlex: Add search results found as parameter to showCreateLink [core] - 10https://gerrit.wikimedia.org/r/99265 [13:38:13] hashar: right, was hoping that AaronSchulz or Reedy might know more about it. for now it's just a guess based on an earlier chat i had with AaronSchulz [13:39:52] yeah AaronSchulz is definitely the expert there [13:39:55] he wrote it :] [13:46:23] (03PS3) 10Siebrand: i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 [13:49:45] YuviPanda: There? [13:49:50] Niharika: yo [13:50:20] YuviPanda: I needed a bit of help getting gerrit to work. [13:50:28] sure, tell me [13:50:57] YuviPanda: Git-review in installed in vagrant already. And I generated the keys just fine. [13:51:11] okay [13:51:30] YuviPanda: It troubles me when making commits. [13:51:36] Niharika: what does it do? [13:52:13] Gives errors. Let me replicate the error and show you the screenshot. Gimme a moment. [13:53:01] Niharika: ok [13:56:22] YuviPanda: http://imgur.com/AP6oYmt [13:56:47] Niharika: can you show me the output of git show? [13:57:16] Niharika: also, use an actual pastebin. use http://www.howtogeek.com/howto/windows-vista/copy-to-the-clipboard-from-the-windows-command-prompt/ to copy someone [13:57:45] http://imgur.com/qP8lymR [13:57:55] YuviPanda: Okay, Iĺl do that next time. [13:58:00] Niharika: :) [13:59:57] YuviPanda: Could you tell me how this works? The branching and merging, that is. And what does rebase mean? [14:00:21] And did you see the git show output above? [14:01:21] Niharika: ah, it's a bit too large for an IRC conversation, I'm afraid. [14:01:31] Niharika: I learnt it from reading http://git-scm.com/book, and I think you will enjoy that too. [14:01:42] YuviPanda: Okay, I´ll refer that. [14:02:07] Niharika: it's a book of sorts, so start from the top and go on. It'll help you immensely. A great amount of learning. Did for me when I first read it [14:03:16] Niharika: take your time :) Make test commits and try out all the things on that book. Is an useful life skill for a programmer, git magic [14:04:00] YuviPanda: Okay. :) But how do I solve my current problem? [14:04:20] Niharika: I suggest you don't. You do have the time to read up on it, no? [14:04:52] YuviPanda: I guess so. Alright then. I´ll come back to this later. [14:04:56] Thanks. [14:04:57] Niharika: I think that'll be of better help in the long term than me solving it. [14:05:08] Niharika: yw! And do poke me if there's sections on that book you don't understand :) [14:05:25] YuviPanda: :) [14:06:25] Niharika: although do note that there are some chapters of that book you can skip if you want. 4, 8 and 9 are completely skippable (or just read the intros!). [14:06:41] Niharika: don't think of it like a college exam book :) [14:06:53] YuviPanda: Okay. [14:07:00] Niharika: sweet :) [14:12:25] (03PS4) 10MegaAlex: Add search results found as parameter to showCreateLink [core] - 10https://gerrit.wikimedia.org/r/99265 [14:13:58] (03PS1) 10Gergő Tisza: Add vagrant roles for MultimediaViewer and CommonsMetadata [vagrant] - 10https://gerrit.wikimedia.org/r/99646 [14:17:51] (03CR) 10Calak: [C: 031] i18n review: Updates for messages, code and documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99631 (owner: 10Siebrand) [14:27:40] (03PS1) 10saper: wfWarn() should NOT cause unit tests to fail [core] - 10https://gerrit.wikimedia.org/r/99648 [14:28:42] (03PS6) 10Ragesoss: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 [14:30:34] siebrand: I changed this commit to *only* change the message key for English and qqq. Is that correct? [14:31:52] (03PS1) 10Gerrit Patch Uploader: Use hooks instead of $wgOut when $wgCategoryTreeForceHeaders is set [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/99649 [14:31:53] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/99649 (owner: 10Gerrit Patch Uploader) [14:32:18] (the message key needs to be changed because it gets created by combining strings based on whether the user tried to create a new page or edit an existing one, so it wasn't feasible to leave the incorrectly named key the same) [14:33:59] (03CR) 10Anomie: [C: 032] Remove mergeExpected and assertResultRecursive [core] - 10https://gerrit.wikimedia.org/r/99340 (owner: 10saper) [14:35:52] ragesoss: Excellent. Raymond_ will take care of the rest once it's merged. [14:36:13] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 (owner: 10Ragesoss) [14:36:18] cool, thanks. [14:37:00] (03Merged) 10jenkins-bot: Remove mergeExpected and assertResultRecursive [core] - 10https://gerrit.wikimedia.org/r/99340 (owner: 10saper) [14:37:46] (03CR) 10Siebrand: [C: 04-1] "The .orig file does not belong in this patch set." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/99649 (owner: 10Gerrit Patch Uploader) [14:38:47] (03CR) 10Anomie: "Personally I'm not particularly concerned about static analysis if it makes the code work better. But what's the use case for this, i.e. w" [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [14:39:52] (03CR) 10Siebrand: [C: 04-1] "This is actually pretty useful. Please only disable it in your particular use case. No need to throw out the baby with the bath water." [core] - 10https://gerrit.wikimedia.org/r/99648 (owner: 10saper) [14:43:40] (03CR) 10Anomie: [C: 031] "Code seems sane. Haven't tested, and can't merge anyway until the core change is merged." (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/99527 (owner: 10Aaron Schulz) [14:47:37] (03CR) 10saper: "Can you refer to the actual example as posted in the bug?" [core] - 10https://gerrit.wikimedia.org/r/99648 (owner: 10saper) [14:52:38] (03PS1) 10leucosticte: Move init of $noFollow outside of if [core] - 10https://gerrit.wikimedia.org/r/99654 [15:01:30] (03CR) 10Nikerabbit: "You don't need to add a class to use $wgGrammarForms. The default implementation in Language.php should already handle it." [core] - 10https://gerrit.wikimedia.org/r/99641 (owner: 10Odder) [15:03:14] (03PS4) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 [15:04:04] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [15:04:50] (03CR) 10Chad: [C: 032] Move init of $noFollow outside of if [core] - 10https://gerrit.wikimedia.org/r/99654 (owner: 10leucosticte) [15:07:54] (03Merged) 10jenkins-bot: Move init of $noFollow outside of if [core] - 10https://gerrit.wikimedia.org/r/99654 (owner: 10leucosticte) [15:09:23] (03PS5) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 [15:18:01] (03CR) 10Rillke: "IE 8 killed again. Other IE users also report issues." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [15:23:18] (03PS1) 10Aude: Update Wikibase, for issue with parser function [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99658 [15:23:39] Reedy: around? [15:23:47] or maybe ^d? [15:24:06] or anyone with deploy super powers [15:25:03] ^d: around? [15:25:24] <^d> Breakfasting and reading e-mails. Sup? [15:25:34] we have an issue with our parser funciton on wikipedia [15:25:44] likely but not certain to due with memcached [15:26:05] https://gerrit.wikimedia.org/r/#/c/99658/ will result in refreshing the cache and we want to try that [15:26:21] reedy seems not around yet [15:26:53] we also have somethign for wmf6 (js on test.wikidata is broken) [15:27:03] not as urgent [15:28:36] <^d> Hmmm [15:29:05] i don't know who else can deploy stuff that is availble [15:29:12] greg-g: around yet? [15:30:09] (03PS6) 10Manybubbles: Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [15:30:15] (03CR) 10jenkins-bot: [V: 04-1] Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [15:32:18] (03PS7) 10Manybubbles: Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [15:32:22] (03CR) 10jenkins-bot: [V: 04-1] Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [15:35:37] (03CR) 10Manybubbles: "Tested and amended with the following changes:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [15:36:03] (03PS2) 10Aude: Update DataValues and Wikibase [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99638 [15:36:20] (03PS8) 10Manybubbles: Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [15:37:30] (03CR) 10Manybubbles: [C: 031] "Fixed method name I broke.... I'm +1ing because it works now. If Chad likes change I vote he +2. Or he can +1 and I'll +2. Whatever. " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [15:40:35] (03PS1) 10Rillke: Fix script error in IE [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/99661 [15:41:54] (03PS1) 10Hashar: operations-puppet-pep8 no more uses submodules [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99663 [15:42:15] (03CR) 10Hashar: [C: 032] operations-puppet-pep8 no more uses submodules [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99663 (owner: 10Hashar) [15:43:12] (03Merged) 10jenkins-bot: operations-puppet-pep8 no more uses submodules [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99663 (owner: 10Hashar) [15:44:13] (03CR) 10Rillke: "Reported as https://bugzilla.wikimedia.org/show_bug.cgi?id=58100 - patch at I30bb876a5afee629e60f11cdee58adb6ed5be214" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [15:52:23] (03PS1) 10Manybubbles: Make delete test less flaky [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99667 [15:53:04] aude: I am now [15:53:14] we have some backports to depoy [15:53:16] deploy* [15:53:32] * aude has one more thing to put in [15:57:09] (03PS3) 10Aude: Update DataValues and Wikibase [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99638 [15:58:47] (03PS1) 10Matthias Mullie: User renaming needs to be handleable by the RenameUser extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99668 [15:59:15] (03CR) 10jenkins-bot: [V: 04-1] User renaming needs to be handleable by the RenameUser extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99668 (owner: 10Matthias Mullie) [16:00:44] (03CR) 10Matthias Mullie: "TODO: updates to flow_revision & flow_tree_revision users do not yet check wfWikiID() to ensure we're updating the correct user." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99668 (owner: 10Matthias Mullie) [16:01:18] (03PS2) 10Aude: Update Wikibase, for issue with parser function [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99658 [16:01:20] greg-g: Reedy ^ [16:01:34] and the one for wmf6, less urgent yet important soonish [16:04:19] (03Abandoned) 10coren: Make FOR UPDATE specify table in fetchFromConds() [core] - 10https://gerrit.wikimedia.org/r/89516 (owner: 10coren) [16:13:10] (03PS22) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [16:17:05] (03CR) 10BryanDavis: [C: 032] Add vagrant roles for MultimediaViewer and CommonsMetadata [vagrant] - 10https://gerrit.wikimedia.org/r/99646 (owner: 10Gergő Tisza) [16:17:10] (03Merged) 10jenkins-bot: Add vagrant roles for MultimediaViewer and CommonsMetadata [vagrant] - 10https://gerrit.wikimedia.org/r/99646 (owner: 10Gergő Tisza) [16:20:15] (03CR) 10Manybubbles: [C: 032 V: 031] Fix fetching ParserOutput [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [16:20:20] (03Merged) 10jenkins-bot: Fix fetching ParserOutput [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 (owner: 10Chad) [16:23:44] (03CR) 10Gergő Tisza: [C: 032] Fix script error in IE [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/99661 (owner: 10Rillke) [16:23:55] (03Merged) 10jenkins-bot: Fix script error in IE [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/99661 (owner: 10Rillke) [16:24:05] aude: hey, sorry, was on a call with markus g [16:24:29] * greg-g is looking [16:25:55] aude: is it just this new patch? https://gerrit.wikimedia.org/r/#/c/98101/ [16:39:24] back [16:48:38] (03CR) 10Gergő Tisza: [C: 031] generalize BitmapHandler::logErrorForExternalProcess [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [16:50:01] (03CR) 10Gergő Tisza: [C: 031] media: limit size of stderr being logged [core] - 10https://gerrit.wikimedia.org/r/99157 (owner: 10Hashar) [16:50:27] greg-g: https://gerrit.wikimedia.org/r/#/c/99658/ is the patch [16:50:38] if we wait a minute, i'm putting one more small thing in [16:50:43] :) [16:50:59] so we have more ability to debug, if this doesn't fix [16:51:07] * aude hopes a new cache key fixes [16:51:15] likely [16:51:47] i can't see the issue on test2 (which has wmf6), so odd [16:58:53] (03CR) 10Brian Wolff: "This looks good, and seems like something we should do. However would it really fix the OOM error? Doesn't php still have to store the out" [core] - 10https://gerrit.wikimedia.org/r/99157 (owner: 10Hashar) [17:02:19] qgil:regarding the GCI task, I should clone this https://git.wikimedia.org/tree/operations%2Fmediawiki-config.git/HEAD/docroot%2Fbits%2Ffavicon first yes ? [17:05:21] vandrew, yes [17:05:40] vandrew, you can look at https://bugzilla.wikimedia.org/show_bug.cgi?id=58075 [17:07:38] (03CR) 10Brian Wolff: [C: 032] "Looks good. I would almost go one step further and put the method in MediaHandler" [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:08:09] (03CR) 10jenkins-bot: [V: 04-1] generalize BitmapHandler::logErrorForExternalProcess [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:08:42] bawolff: [17:08:52] bawolff: Indeed probably need to be in MediaHandler [17:09:22] (03CR) 10Hashar: [C: 04-2] "Will move the method to MediaHandler." [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:09:55] The distinction between MediaHandler and ImageHandler is rather sketchy [17:10:36] ahh [17:10:44] bawolff: just found out nothing extends MediaHandler but ImageHandler [17:10:54] at least in core [17:10:58] Lots of extensions do though [17:12:05] TimedMediaHandler_body.php:class TimedMediaHandler extends MediaHandler { [17:12:06] :D [17:13:16] (03PS1) 10Umherirrender: Make a single colon a invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/99674 [17:13:21] Hmm, I guess not that many extensions actually do that. I had it in my head that more of them did [17:15:50] hashar: Oh, on the actual fix for that bug, you meant that trim makes a copy, and that having two copies of the string exhausts all memory, not that the initial substr would magically get rid of the entire string before it goes in php memory [17:15:57] That makes more sense to me now [17:16:30] YuviPanda: you wrote the github/gerrit integration thing, right? have you seen https://gerrit.googlesource.com/plugins/github/+/refs/heads/master/README.md ? [17:16:55] cscott: yes, and when me and Chad last checked it was nowhere [17:16:56] (03PS2) 10Hashar: generalize BitmapHandler::logErrorForExternalProcess [core] - 10https://gerrit.wikimedia.org/r/99142 [17:17:14] bawolff: well the huge string will still be around [17:17:23] bawolff: but substr will let us copy only a small part of it [17:17:41] cscott: but will be happy to get this used instead of that bot. I haven't touched the bot in a while either [17:17:52] hashar: Want to remove your -2 from 99142? I'll +2 it [17:18:02] cscott: I'd actually get involved with that plugin, but I already write enough Java as is (Android) [17:18:15] (03CR) 10jenkins-bot: [V: 04-1] generalize BitmapHandler::logErrorForExternalProcess [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:18:18] bawolff: need to resolve some stupid conflict [17:18:28] (03PS3) 10Aude: Update Wikibase, for issue with parser function [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99658 [17:18:30] greg-g: ^ [17:18:49] probably all siebrand's documentation fixes to that class [17:18:52] I'm here now... [17:18:57] yay [17:19:07] Reedy: https://gerrit.wikimedia.org/r/#/c/99658/ [17:19:43] weird, probably caching issue [17:19:55] JS gurus, https://gerrit.wikimedia.org/r/99661 you should probably be aware of [17:21:56] (03PS4) 10Aude: Update DataValues and Wikibase [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99638 [17:22:23] that one is less urgent, but still important so wmf6 has same fixes and so people can test on test.wikidata [17:22:54] (03CR) 10Hashar: "Moved the method up to MediaHandler. Rebasing." [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:23:08] (03PS3) 10Hashar: generalize BitmapHandler::logErrorForExternalProcess [core] - 10https://gerrit.wikimedia.org/r/99142 [17:23:34] (03CR) 10Hashar: "PS3 is a rebase" [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:24:51] (03CR) 10Brian Wolff: [C: 032] "Looks good" [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:25:53] (03PS1) 10saper: Add missng uploadstash.us_props for PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/99676 [17:25:54] (03CR) 10Brian Wolff: [C: 032] "Looks good. My last comment was confused, although this doesn't get rid of the original string, it does prevent it from being duplicated i" [core] - 10https://gerrit.wikimedia.org/r/99157 (owner: 10Hashar) [17:26:06] oh that needs rebase too doesn't it [17:27:18] well, it will be easier once the other one is merged [17:27:28] dependant patches suck [17:28:28] (03PS2) 10Hashar: media: limit size of stderr being logged [core] - 10https://gerrit.wikimedia.org/r/99157 [17:29:29] (03CR) 10Hashar: "Yup that is the idea Brian. That is not ideal but should be good enough for most use cases." [core] - 10https://gerrit.wikimedia.org/r/99157 (owner: 10Hashar) [17:29:35] (03CR) 10Brian Wolff: [C: 032] media: limit size of stderr being logged [core] - 10https://gerrit.wikimedia.org/r/99157 (owner: 10Hashar) [17:29:46] (03PS2) 10saper: Add missing uploadstash.us_props for PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/99676 [17:29:47] bawolff: thank you very much for your review :-D [17:29:53] no problem [17:30:14] bawolff: we will then be able to spot some file transformations failures that are not logged anywhere :-] [17:30:19] one file emitted 125MB of errors :( [17:30:36] That's quite the error [17:32:05] aude: One for wmf5 and one for wmf6? [17:32:10] yes [17:32:13] do wmf5 first [17:32:23] (03CR) 10AndyRussG: Add PLURAL and GENDER support for some messages (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [17:32:32] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, for issue with parser function [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99658 (owner: 10Aude) [17:32:44] thanks [17:34:23] hashar: Well we're discussing image errors - any chance you would want to review https://gerrit.wikimedia.org/r/#/c/86390/ - the idea is, include the process error code in the user facing output, so that when people report in bugzilla, things that are OOM errors can be easily separated from those that aren't [17:34:50] ahh [17:35:07] have you noticed we now usually do: [17:35:15] (03CR) 10Reedy: [C: 032 V: 032] Update DataValues and Wikibase [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99638 (owner: 10Aude) [17:35:16] logErrorForExternalProcess() then getMediaTransformError() ? :D [17:35:51] should probably have made the logErrorForExternalProcess() a method of the MediaTransformError() :( [17:35:52] yes [17:36:36] oh. Hmm. That would put the error handling code together [17:37:14] basically the way we handle errors is a bit messy :( [17:37:27] (03Merged) 10jenkins-bot: media: limit size of stderr being logged [core] - 10https://gerrit.wikimedia.org/r/99157 (owner: 10Hashar) [17:38:58] (03CR) 10Qgil: "For what is worth, M4tx also created https://gerrit.wikimedia.org/r/#/c/99258/" [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [17:39:14] (03CR) 10Hashar: [C: 032] "Sounds good." [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [17:39:17] As it stands, MediaTransformError basically just takes a string which it plops in front of the user's face, so it would have to be modified to have more structured error information [17:39:43] there is an RFC regarding logging [17:39:57] that would help [17:40:27] and the way we do error handling through MediaWiki core need to be improved/ made consistent [17:40:37] yeah [17:42:07] (03CR) 10Chad: [C: 032] "Diff from my changes to Nik's looks good, going to go ahead and +2 this." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [17:42:14] <^d> manybubbles: Wheee ^ :) [17:42:44] (03CR) 10jenkins-bot: [V: 04-1] Include error code in error message when convert fails [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [17:42:58] (03CR) 10Chad: [C: 032] Make delete test less flaky [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99667 (owner: 10Manybubbles) [17:43:00] (03Merged) 10jenkins-bot: Allow splitting of single namespaces into their own indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [17:43:06] (03CR) 10jenkins-bot: [V: 04-1] Make delete test less flaky [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99667 (owner: 10Manybubbles) [17:43:28] (03PS2) 10Chad: Make delete test less flaky [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99667 (owner: 10Manybubbles) [17:43:32] ^D: yay! [17:43:33] (03CR) 10Chad: [C: 032] Make delete test less flaky [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99667 (owner: 10Manybubbles) [17:43:39] ^d: yay! [17:43:40] (03Merged) 10jenkins-bot: Make delete test less flaky [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99667 (owner: 10Manybubbles) [17:43:47] <^d> :) [17:44:17] <^d> If we can land https://gerrit.wikimedia.org/r/#/c/98986/ today, we'll have finished the stuff I want for commons support :) [17:44:42] <^d> I've got some unpushed fixes to that, just haven't finished it yet. [17:44:44] (03PS2) 10Krinkle: Make a single colon a invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/99674 (owner: 10Umherirrender) [17:44:50] (03CR) 10Krinkle: [C: 031] Make a single colon an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/99674 (owner: 10Umherirrender) [17:46:21] ^d / manybubbles : I was just wondering, in cirrussearch, could we make the text layer of pdf and djvu files indexed? [17:46:40] <^d> That would be awesome :) [17:46:46] <^d> I don't see why we couldn't. [17:46:50] ^d: we sure could [17:46:55] I am off, thanks again bawolff [17:47:19] <^d> bawolff: File a bug :D [17:47:20] filing a bug for it, bawolff [17:47:28] oh, better you do it, actually [17:47:43] I wonder if it'd be better to make another plugin that hooks cirrus actually do it [17:47:51] I imagine there probably is one already [17:48:14] hmmm - more food for thought about what kind of hooks cirrus is going to need to expose [17:48:15] <^d> Want to lump svg in there too? [17:48:20] <^d> :) [17:48:40] ^d: people will totally complain when the text made up of shapes doesn't get indexes [17:48:43] *indexed* [17:48:51] <^d> lol. [17:49:04] On the MediaHandler side, we have the getPageText method to get the text of a specific page, which we could use [17:49:21] <^d> In that case, it should be pretty easy on our side. [17:49:36] yeah! [17:49:44] <^d> When we're indexing something in NS_FILE, check if we've got any page text, if so index that. [17:49:47] ^d: my rabbit hole yesterday: https://github.com/elasticsearch/elasticsearch/pull/4352 [17:50:12] ^d: also, we should talk about https://gerrit.wikimedia.org/r/#/c/98046/ [17:50:19] We might want to make a new MediaHandler method for getEntirePageText, as I think the current method splits it up by pages, and then one would need to unsplit it up. For a 400 page document that would probably be inefficient [17:50:28] I'd love to be able to deploy cirrus as a beta feature soon [17:50:56] bawolff: probably! especially if it has to dig into the pdf each time via some external process [17:51:21] (03CR) 10Bsitu: [C: 032] Remove duplicated condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99607 (owner: 10EBernhardson) [17:51:29] (03CR) 10jenkins-bot: [V: 04-1] Remove duplicated condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99607 (owner: 10EBernhardson) [17:51:32] <^d> manybubbles: Yeah I agree. Sooooo, how can we compromise here? I really think having a second global to control it is going to be a maintenance burden. [17:51:43] found an old bug for it: https://bugzilla.wikimedia.org/show_bug.cgi?id=6421 [17:51:50] bawolff: sweet! [17:51:53] manybubbles: No, its cached in img_metadata [17:51:59] so no external process each time [17:52:04] bawolff: better [17:52:10] <^d> bawolff knows his metadata :) [17:52:30] ^d: hmm - I just don't want to punnish folks who set their beta features to "give me all the beta features!" [17:52:40] because that is what we'd do if we did that. [17:53:02] ^d: I get that having a second global would be a pain because we'd have to turn it on after we're done indexing [17:53:06] with _another_ release window [17:53:19] maybe that one could normally be an lightning deploy, at least [17:53:37] <^d> Well yeah, but still. Having to do it later could be annoying. [17:53:47] <^d> And I fear "where is the beta feature" bugs. [17:54:01] (03CR) 10Ori.livneh: [C: 032] Allow 'noprotocol' option in captcha-addurl-whitelist [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97317 (owner: 10Anomie) [17:54:04] (03Merged) 10jenkins-bot: Allow 'noprotocol' option in captcha-addurl-whitelist [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97317 (owner: 10Anomie) [17:57:00] ^d: I don't announce that cirrus is ready until we've finished indexing. We could not announce until it we've deployed the beta feature [17:57:19] (03PS1) 10Bsitu: Missing table prefix in query condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99687 [17:57:26] And I think the way to do it is to have a list of indexing wikis that _don't_ get the beta feature, rather than a list that do [17:57:28] because most will get it [17:57:32] <^d> Fair enough. It only matters for secondary indexed wikis anyway :) [17:57:44] yeah [17:57:55] right [17:58:02] <^d> So yeah, doing the inverse (list wikis to not have it) sounds like an acceptable plan of record. [17:58:13] sweet [17:58:17] I can implement that after lunch [17:58:18] <^d> So then we'll just add it when we index, remove when they're done & we announce, then no more burden. [17:58:47] yay! [17:58:53] sounds great. [17:59:12] I'm going to go eat vietnamese food. [18:00:26] (03CR) 10Bsitu: "Related fix to the build failure: https://gerrit.wikimedia.org/r/#/c/99687/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99607 (owner: 10EBernhardson) [18:03:57] (03PS8) 10Tpt: Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 [18:05:20] qgil: is inkscape good for this job ? or should I use something else ? [18:06:10] (03CR) 10Tpt: "Improve i18n messages as requested" [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [18:06:24] ^d: quick question, what's the correct syntax again to link internally from one gerrit change set to another in a cover message.. did we define those or gerrit itself? [18:06:37] hey csteipp, did you get a chance to look at this yesterday? https://gerrit.wikimedia.org/r/#/c/99387/ [18:06:48] <^d> mutante: We did, there's regexes in the gerrit config in puppet. [18:06:49] trying to avoid that pasting of full URLs to gerrit [18:07:02] ^d: thanks,looking [18:07:15] <^d> But generally, it's /I[a-f][0-9]{8,40}/ [18:07:20] dan-nl: Yeah, I think it was fine, but I wanted to check with aaron about it [18:07:49] k [18:07:54] <^d> mutante: Or something like that :) templates/gerrit/gerrit.config.erb is where we define all of them. [18:08:36] ^d: ty! found it. [commentlink "changeid"]:) [18:09:01] <^d> Yep yep [18:09:05] <^d> You're welcome [18:09:21] AaronSchulz: would you be able to look at https://gerrit.wikimedia.org/r/#/c/99387/ today? i'm hoping to get your +1 and csteipp's +1 so that bd808 can merge it before we move the extension to the beta cluster [18:10:00] greg-g: Reedy could you try this http://dpaste.com/1495209/ with eval.php [18:10:07] for enwiki? [18:10:22] that might help [18:12:25] Hmm, whoever did the new legend on RC, it looks really pretty :) [18:12:35] \o/ agree [18:13:29] scimonster [18:14:32] aude: Empty array [18:14:44] huh [18:14:47] thanks [18:15:12] then it's not specific to the parser function [18:17:04] (03PS1) 10CryoKey: Support new centralized CryoKey Lite API [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/99692 [18:18:56] bawolff: scimonster, but we stole the idea from ru.wp [18:20:23] (03CR) 10CryoKey: [C: 032 V: 032] Support new centralized CryoKey Lite API [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/99692 (owner: 10CryoKey) [18:20:35] (03PS2) 10Chad: Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 [18:20:59] (03CR) 10Chad: "Still missing the actual tracking component, but has most of the rest of it in place now." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [18:21:45] (03PS3) 10Chad: Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 [18:23:31] vandrew, sorry. An .ico file contins bitmap / png image layer(s) and therefore Inkscape is not an appropriate tool. GIMP should do. [18:23:44] vandrew, https://en.wikipedia.org/wiki/ICO_%28file_format%29 :) [18:23:51] (03CR) 10Dzahn: [C: 031] "per "5-10% of all wikis using it"" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [18:24:07] If you're making it from scratch you can use inkscape, and export to png [18:25:32] qgil: no problem [18:26:38] argh, bawolff is right. vandrew , listen to the voice of the experience [18:26:47] Reedy: how about http://dpaste.com/1495219/ ? [18:26:57] key difference is "$id = $labelResolver->getPropertyIdsForLabels( array( 'signature' ), true );" has true [18:27:14] Empty array again [18:27:19] huh [18:27:20] ok [18:27:22] hmm, my experiance level with graphic design is pretty low ;) [18:28:14] Ok, wtf. DjVu is stupid [18:28:43] Reedy: what about on test2? [18:28:51] apparently works for me [18:29:25] this class has not changed since october [18:29:30] vandrew: If you do use inkscape, for making from scratch. Ensure to upload the svg file somewhere (commons maybe. We used to have an artwork repo in svn for source files...) too, in case somebody has to edit it later, they can edit in the original format [18:30:16] (03CR) 10Aaron Schulz: "https://gerrit.wikimedia.org/r/#/c/99527/ (though Brad already saw it)" [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [18:30:33] 'serialization' => 'P109', [18:30:37] (for the second one) [18:30:41] oooh, as expected [18:30:43] bawolff: I'll use gimp as qgil said, thx for the tip [18:31:10] Same tip applies to gimp, but with xcf as the source file, instead of svg [18:31:44] if you're making from scratch that is, if you already have a file you're just editing, then you don't need to worry about that [18:32:42] (03PS1) 10MarkTraceur: Fix script error in IE [extensions/UploadWizard] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99694 [18:34:53] So text layer extraction has been subtly broken on djvu files since 2009... [18:35:30] (03CR) 10Bartosz Dziewoński: [C: 031] Make a single colon an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/99674 (owner: 10Umherirrender) [18:36:48] (03CR) 10MarkTraceur: [C: 032] "Yay cherry-picks." [extensions/UploadWizard] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99694 (owner: 10MarkTraceur) [18:36:52] (03Merged) 10jenkins-bot: Fix script error in IE [extensions/UploadWizard] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99694 (owner: 10MarkTraceur) [18:37:45] (03PS1) 10MarkTraceur: Fix script error in IE [extensions/UploadWizard] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99695 [18:38:12] (03CR) 10MarkTraceur: [C: 032] Fix script error in IE [extensions/UploadWizard] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99695 (owner: 10MarkTraceur) [18:38:47] (03Merged) 10jenkins-bot: Fix script error in IE [extensions/UploadWizard] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99695 (owner: 10MarkTraceur) [18:39:37] (03PS1) 10Brian Wolff: Fix text extraction on DjVu so that it works beyond first call. [core] - 10https://gerrit.wikimedia.org/r/99696 [18:43:12] (03PS1) 10MarkTraceur: Update UploadWizard to fix IE8 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99697 [18:47:03] (03PS1) 10MarkTraceur: Update UploadWizard to fix IE8 [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99698 [18:49:25] (03CR) 10MarkTraceur: [C: 032 V: 032] Update UploadWizard to fix IE8 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99697 (owner: 10MarkTraceur) [18:49:37] (03CR) 10MarkTraceur: [C: 032 V: 032] Update UploadWizard to fix IE8 [core] (wmf/1.23wmf6) - 10https://gerrit.wikimedia.org/r/99698 (owner: 10MarkTraceur) [18:51:51] (03CR) 10EBernhardson: [C: 032] Missing table prefix in query condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99687 (owner: 10Bsitu) [18:54:16] (03Merged) 10jenkins-bot: Missing table prefix in query condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99687 (owner: 10Bsitu) [18:54:29] (03CR) 10Aaron Schulz: [C: 04-1] filebackend-user-access (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [18:56:25] Reedy: does http://dpaste.com/1495252/ work? [18:56:46] on what wiki? [18:56:50] enwiki [18:57:39] I got this when using git review [remote rejected] HEAD -> refs/publish/master/office/bug (change 99611 closed) [18:58:31] (03PS23) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [18:59:35] Yup [18:59:39] ok [18:59:46] has to be caching [19:00:12] vandrew: Usually means you tried to update a change that's marked as abandoned [19:00:43] (03PS1) 10Ebrahim: i18n: Remove ckb from link underline removal [core] - 10https://gerrit.wikimedia.org/r/99701 [19:00:50] bawolff: I want to make a new change, what should I use ? [19:00:59] I mean a new commit [19:01:15] I used git commit -a --amend [19:01:23] http://dpaste.com/1495254/ ? [19:01:35] * aude had the recache param wrong before [19:01:43] vandrew: Generally you should do something like git checkout master; git checkout -b newBranch; ; git add; git commit; git review [19:02:09] (03PS3) 10AndyRussG: Add PLURAL and GENDER support for some messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [19:02:10] bawolff: thanks again [19:02:40] Yup, still works [19:03:40] huh, that seemed to clear / fix [19:04:13] so we are doing something wrong about clearing the cache for each deployment, perhaps [19:04:48] (03CR) 10Bsitu: [C: 032] Remove duplicated condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99607 (owner: 10EBernhardson) [19:04:58] (03Merged) 10jenkins-bot: Remove duplicated condition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99607 (owner: 10EBernhardson) [19:06:34] Reedy: so, it seems the cache is shared for all the clients [19:08:18] (03PS4) 10Chad: Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 [19:08:36] aude: Which cache? [19:08:43] memcached [19:08:48] same cache key [19:09:08] (03CR) 10Chad: "Other than the very glaring todo in CirrusSearchOtherIndexes::update(), this should be just about done." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [19:09:11] (03CR) 10Calak: [C: 031] i18n: Remove ckb from link underline removal [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [19:10:28] (03PS4) 10Siebrand: Add PLURAL and GENDER support for some messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 [19:10:34] (03PS1) 10EBernhardson: Missing use statement [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99703 [19:10:48] (03CR) 10Siebrand: "Thanks, removed some duplication in PS." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [19:11:47] (03PS3) 10Dan-nl: filebackend-user-access [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 [19:11:54] (03CR) 10AndyRussG: "I think we're all set... Maybe I'll wait just a bit to merge in case there are any final comments. Thanks everyone!!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [19:12:23] (03CR) 10Siebrand: "I don't think there will be. Pretty clear and done :)." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [19:12:45] Reedy: ok, i think i see where the problem might be [19:13:31] (03CR) 10Dan-nl: "- addressed aaron’s comments in ps2" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [19:13:38] it's not getting the cache key based on our setting, which changes for each deployment [19:17:25] no, it is [19:19:29] and the issue still appears on other wikis [19:19:42] (03CR) 10Manybubbles: "The TODO isn't tooooo bad. I think I can figure out the right Elasticsearch incantations if you'd like." (034 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [19:23:43] (03CR) 10Bsitu: User renaming needs to be handleable by the RenameUser extension (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99668 (owner: 10Matthias Mullie) [19:27:40] (03PS1) 10Dr0ptp4kt: Be slightly more user friendly in generate.php. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/99709 [19:28:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [19:29:34] (03CR) 10MarkTraceur: "In the future, if I'm going to abandon something, I will absolutely go ahead and do it :)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [19:29:41] (03CR) 10MarkTraceur: "when possible*" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [19:29:53] (03PS7) 10Ragesoss: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 [19:30:23] (03PS1) 10Brian Wolff: Normalize newlines in DjVu text-layer metadata. [core] - 10https://gerrit.wikimedia.org/r/99710 [19:31:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 (owner: 10Ragesoss) [19:33:12] Anyone know where can I find the wikimedia office logo ? It doesn't seem to be here https://commons.wikimedia.org/wiki/Category:Logos_of_Wikimedia [19:33:19] (03CR) 10Brian Wolff: "I'd like to add, I tested this with proofread page, and it works fine with it." [core] - 10https://gerrit.wikimedia.org/r/99710 (owner: 10Brian Wolff) [19:33:58] vandrew: Define "office logo"? [19:34:22] office.ico favicon [19:34:29] I need to find the high resolution one [19:35:18] Can you link to the bug you're working on? I don't understand what you're saying. [19:37:00] here is the GCI task, https://www.google-melange.com/gci/task/view/google/gci2013/5824285293674496, I have to complete a bug report and I need the original high resolution of the logo, also the logo is the same as the logo from left top of this page https://office.wikimedia.org/wiki/Main_Page [19:37:07] Oh! [19:39:14] vandrew: From looking at the HTML source of the officewiki front page, I've discerned that it's https://meta.wikimedia.org/wiki/File:WikimediaOFFICE-logo135px.png [19:39:35] I blame qgil for incomplete task summary. :P [19:39:47] marktraceur: thanks again ! [19:40:05] vandrew: i've been wondering what you were fixing:) gotcha. mind linking the Bugzilla ticket to gerrit? [19:40:11] (03PS3) 10Ori.livneh: mediawiki.js: add `mw.track`, imported from VisualEditor [core] - 10https://gerrit.wikimedia.org/r/99547 [19:40:27] (03CR) 10AndyRussG: [C: 032] Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 (owner: 10Ragesoss) [19:40:28] mutante: just a second, I am working on that [19:40:54] vandrew: sure, no rush, thanks for the fix, as i said, i was just a random reviewer because i saw it pop up on IRC:) [19:41:14] (03Merged) 10jenkins-bot: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 (owner: 10Ragesoss) [19:42:07] (03CR) 10AndyRussG: [C: 032] Add PLURAL and GENDER support for some messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [19:42:32] * siebrand thanks AndyRussG  [19:42:52] (03Merged) 10jenkins-bot: Add PLURAL and GENDER support for some messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [19:43:06] siebrand: my pleasure, thank you too! [19:43:45] siebrand: sorry for the delay in getting to it. Hopefully I'll get to your other patch soon [19:44:04] AndyRussG: Don't worry about it. I have 30 other patches, too... [19:44:16] Ah OK [19:44:33] (03PS1) 10Hashar: drop labels hasPhpUnit & hasPhpcs (unneeded now) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99712 [19:44:59] (03CR) 10Hashar: [C: 032] drop labels hasPhpUnit & hasPhpcs (unneeded now) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99712 (owner: 10Hashar) [19:45:21] (03Merged) 10jenkins-bot: drop labels hasPhpUnit & hasPhpcs (unneeded now) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99712 (owner: 10Hashar) [19:45:30] (03PS1) 10Bartosz Dziewoński: mediawiki.page.ready: Fix whitespace in IIFE [core] - 10https://gerrit.wikimedia.org/r/99713 [19:45:31] (03PS1) 10Bartosz Dziewoński: Update collapsible lists below edit form on live preview via mw.hook [core] - 10https://gerrit.wikimedia.org/r/99714 [19:46:11] (03PS1) 10Brian Wolff: Add method to get entire text layer. This could be useful for search [core] - 10https://gerrit.wikimedia.org/r/99715 [19:46:49] (03CR) 10Bartosz Dziewoński: Update collapsible lists below edit form on live preview via mw.hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99714 (owner: 10Bartosz Dziewoński) [19:47:59] siebrand: BTW, I think we're leaning towards a major rewrite of much of the EP extension, including much of the UX. (Maybe I mentioned this already?) Hopefully we'll get an RFC out about it soon... [19:48:40] AndyRussG: didnt know [19:49:21] mutante: I've added the bug report [19:49:26] (03CR) 10Gergő Tisza: [C: 032] Fix text extraction on DjVu so that it works beyond first call. [core] - 10https://gerrit.wikimedia.org/r/99696 (owner: 10Brian Wolff) [19:49:59] vandrew: thanks [19:50:32] (03CR) 10Manybubbles: [C: 031] "cool." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99715 (owner: 10Brian Wolff) [19:51:09] siebrand: Yeah... it'll surely be a little while before a new version is in production, so at this point it's really a question of balancing resources between upkeep and working towards something new [19:52:40] (03PS2) 10Brian Wolff: Add method to get entire text layer. This could be useful for search [core] - 10https://gerrit.wikimedia.org/r/99715 [19:53:38] hi vandrew , marktraceur the summary is not incomplete. We really want GCI students to find the logo they should work on (using whatever tactics). Thank you! [19:53:47] Ah [19:53:52] (03CR) 10Bartosz Dziewoński: i18n: Remove ckb from link underline removal (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [19:54:05] So you used me like a pawn in your massive engineering community chess game [19:54:10] (03Merged) 10jenkins-bot: Fix text extraction on DjVu so that it works beyond first call. [core] - 10https://gerrit.wikimedia.org/r/99696 (owner: 10Brian Wolff) [19:54:31] thanks tgr :) [19:54:36] (03CR) 10Chad: Implement multi-index support on a per-namespace basis (034 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [19:55:07] vandrew, marktraceur then again, I had no idea that the Wikimedia Office logo was available only in meta and as a png, instead of svg in Commons as usual... [19:55:20] (03CR) 10Bartosz Dziewoński: "Both languages use the same script, right?" [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [19:56:06] Yeah [19:57:02] (03CR) 10Ebrahim: "all of listed languages are using arab script. So you want I change the previous line (from scripts to script)?" [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [19:58:53] (03CR) 10Manybubbles: Implement multi-index support on a per-namespace basis (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [20:00:00] (03CR) 10Bartosz Dziewoński: "Ah, no, I was just wondering. Just check my comments on the commit message and I'll merge." [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [20:00:10] (03PS2) 10Ebrahim: i18n: Remove ckb from link underline removal [core] - 10https://gerrit.wikimedia.org/r/99701 [20:00:35] (03CR) 10Bartosz Dziewoński: "(I suppose it would make sense to explicitly mention which script is this about in the comment :) )" [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [20:01:08] (03CR) 10Calak: [C: 031] i18n: Remove ckb from link underline removal [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [20:02:15] (03CR) 10Bartosz Dziewoński: [C: 032] "Maybe we should consider killing the feature entirely if so many people think it's not okay." [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [20:03:38] (03CR) 10Hashar: "Some bits can be enhanced (see inline diff)." (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98275 (owner: 10Merlijn van Deen) [20:04:55] (03PS1) 10Spage: Disable VisualEditor by default [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99721 [20:05:14] (03CR) 10Bartosz Dziewoński: "Where do the '\n's come from, actually? Do we need to unescape \t too or something else?" [core] - 10https://gerrit.wikimedia.org/r/99710 (owner: 10Brian Wolff) [20:05:50] (03PS5) 10Chad: Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 [20:06:24] MatmaRex: Good question. I have no idea. ProofreadPage only replaces \n's [20:06:45] MatmaRex: The value comes from the command line djvutxt [20:07:09] (03Merged) 10jenkins-bot: i18n: Remove ckb from link underline removal [core] - 10https://gerrit.wikimedia.org/r/99701 (owner: 10Ebrahim) [20:07:19] (03CR) 10Chad: Implement multi-index support on a per-namespace basis (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [20:07:50] (03CR) 10jenkins-bot: [V: 04-1] Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [20:08:11] bawolff: well, why does that command produce such silly output? [20:08:23] because its stupid :P [20:08:41] MatmaRex: Behave [20:08:50] And that's without the --escape option specified [20:08:59] which appearently enables even more escapes [20:09:22] <^d> Jenkins, y u lie? [20:09:25] <^d> Can't merge my ass. [20:09:36] MatmaRex: The docs claim "Without options -detail and -escape, this program simply outputs the UTF-8 text" [20:09:40] which seems to be a lie [20:10:32] bawolff: maybe the files themselves have bad data? [20:10:35] or actually, it does that with the detail page [20:10:49] ^d: there's a bug for that [20:11:05] ^d: it's actually gerrit's fault. so, your fault. :P [20:11:10] <^d> There's a bug for lots of things :) [20:11:11] https://bugzilla.wikimedia.org/show_bug.cgi?id=57483 [20:11:30] MatmaRex: So without the --detail option, the output is more sane [20:11:45] <^d> How is that not a dupe of the other one? [20:11:49] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [20:12:07] what other one? [20:12:23] <^d> There was another bug about hash_mismatch after we migrated servers. [20:12:32] <^d> I've never been able to reproduce. [20:12:34] !bug ALL hash mismatch [20:12:34] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=ALL+hash+mismatch [20:12:48] <^d> Nor been able to explain it, since we copied the server signature for that reason. [20:12:51] ^d: well, now you approximately one occurence a day [20:13:06] you have* [20:13:11] <^d> Meh, or I can just ignore jenkins :p [20:13:28] MatmaRex: So it tries to output it as lisp style expressions for some reason... [20:13:36] bawolff: lol [20:13:53] I go back to my previous answer of its stupid [20:15:25] bawolff: well anyway, that doesn't look like a good solution. maybe we should slap some parser on top of that or something [20:16:49] MatmaRex: We have some sort of scary regex doing parsing of it... [20:17:38] oh hmmmm. [20:18:11] hm [20:18:24] -ph [20:18:25] it looks like we could unwrap the parentheses and put it into json_decode [20:18:38] would be a little less scary, i think [20:18:56] (03CR) 10Brian Wolff: "Its from the command djvutxt --detail=page. This outputs the page text as a series of lisp-type expressions, with newlines escaped as \n. " [core] - 10https://gerrit.wikimedia.org/r/99710 (owner: 10Brian Wolff) [20:19:03] does php not have a sexpression parser built-in? :P [20:19:35] * bawolff would rather not re-write are entire djvu support [20:20:28] This is just changing at what level the \n converting happens. Previously it happened in ProofreadPage [20:20:57] i'm trying to make sense of that regex [20:21:29] so in pageTextCallback, $matches[1] contains the insides of a ""-quoted-string, right? [20:21:59] wrapping it in "" again and passing to json_decode to handle the escaped for us seems sane to me [20:22:06] or, well, as sane as it gets with this kind of code [20:22:07] (03CR) 10Anomie: "There is a behavioral inconsistency introduced in this patch." [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [20:22:48] (03CR) 10Anomie: [C: 031] "Code looks good and appears to work in testing." [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [20:23:27] bawolff: ^^^ [20:23:54] I agree that the word sanity is relative here [20:24:48] I don't think other types of (printable) characters are escaped, so I'm not sure if doing that is needed [20:26:14] hmm, actually what you're saying makes sense [20:26:41] quotes are definitely escaped [20:26:43] backslashes [20:27:19] the super lame question for tonight is: is it faster to use define( 'MW', 42 ); or to use: const MW = 42; [20:27:42] MatmaRex: Maybe using stripslashes instead of json_decode [20:28:17] hashar: I would imagine the second, but I have no idea [20:28:25] either way, its probably a micro-optimization [20:28:56] bawolff: oh, i had no idea php had this [20:29:05] bawolff: hm, but does it handle \\n? it's not documented to [20:29:14] (which doesn't yet mean anything of course) [20:29:16] bawolff: yeah that is true [20:29:50] (03PS24) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [20:30:27] MatmaRex: echo stripslashes( '\\\\n' ); gives \n as I would expect [20:30:47] bawolff: that looks like too many slashes [20:30:55] what about "\\n"? [20:32:08] it comes out as just n [20:35:59] (03CR) 10Bartosz Dziewoński: [C: 032] "Code looks nice and works. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [20:37:31] * bawolff finds a file with quotes in it to test [20:38:56] Found one. [20:39:08] Hmm, \" is being converted somewhere along the line [20:39:50] (03CR) 10MarkAHershberger: [C: 032] Sync RELEASE-NOTES-1.22 between master and REL1_22 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97101 (owner: 10IAlex) [20:40:30] appearently in proofread page, because they aren't in getPageText() [20:41:55] qgil: I've got a few of +1 and marked the task as complete, when you have time please take a look over it [20:42:04] bawolff: /me weeps [20:42:25] yeah... [20:42:35] (03PS6) 10Chad: Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 [20:43:22] ok, its getting killed by $body = preg_replace( "/(\\\\\d*)/", '', $text ); [20:43:38] which I feel like is not the intention of the code... [20:43:50] (03CR) 10Chad: Implement multi-index support on a per-namespace basis (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [20:44:14] so many slashes [20:44:24] ugh, wait, five? wat [20:44:28] ok, that evaluates to /(\\\d*)/ [20:44:38] that makes exactly zero sense [20:44:44] Which I guess matches a \ followed by 0 or more numbers [20:45:10] are you sure? [20:45:13] (did you run it?) [20:45:19] Have I ever talked about my fee feelings about proofread page... [20:45:29] (03Merged) 10jenkins-bot: Unblacklist group-specific JS/CSS for the user group [core] - 10https://gerrit.wikimedia.org/r/99434 (owner: 10Scimonster) [20:45:53] "\\\\\d" should become \\d, shouldn't it? [20:46:13] (03PS1) 10saper: Installer reports undefined noFollow [core] - 10https://gerrit.wikimedia.org/r/99731 [20:46:42] yes, and PCRE takes that as an escape sequence to mean a literal \ followed by a d [20:46:56] mwalker: thoughts re: https://bugzilla.wikimedia.org/show_bug.cgi?id=57939 ? [20:47:01] vandrew, closed. Thank you! [20:47:11] qgil: thanks [20:47:30] wait [20:47:33] that doesn't make sense [20:48:05] php should pass /(\\\d*)/ to pcre, and pcre see's that as \\ = literal \, followed by \d for digit [20:48:21] why should it? [20:48:25] there are five slashes [20:48:28] oh [20:48:31] I don't know [20:48:38] okay [20:48:38] I tried it and that's what happened [20:48:40] (03Merged) 10jenkins-bot: Sync RELEASE-NOTES-1.22 between master and REL1_22 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97101 (owner: 10IAlex) [20:48:40] let's just run this [20:49:07] (03PS2) 10UltrasonicNXT: Allow the removal of various features [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 [20:49:27] MatmaRex: Oh appearently "\d" to php means the string \d [20:49:46] and not 'd' like you would expect [20:49:50] ugh [20:49:56] (03CR) 10UltrasonicNXT: "I've had those changes lying around for a little while, so I realise this is not yet complete, but I thought I'd just submit what I've don" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [20:50:18] stupid shitty-ass fucking backslashes [20:50:24] there. [20:51:09] :) [20:51:21] hahaha [20:51:31] MatmaRex: If that was intended to be a reference you did it very well [20:51:40] Except I think you forgot 'useless' [20:52:16] I'd still prefer stripslashes [20:52:26] whoops, paste accidentally [20:54:31] (03CR) 10Aaron Schulz: [C: 031] filebackend-user-access [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [20:58:28] MatmaRex: oh stripslashes is useless, it converts \037 -> 37 [20:59:00] heh [20:59:18] thanks AaronSchulz [20:59:35] hmm, there is stripcslashes [20:59:42] bd808: https://gerrit.wikimedia.org/r/#/c/99387/ is ready to be merged when you get a chance [21:00:01] (03CR) 10leucosticte: "We fixed it in Change-Id: I5655a0dc64055f3ec5d0a287aa8e0c85c11d3a1f" [core] - 10https://gerrit.wikimedia.org/r/99731 (owner: 10saper) [21:00:32] dan-nl: Looking now. It doesn't need Chris to sign off too? [21:00:55] he mentioned in chat that he was okay with it and wanted aaron to check [21:01:11] csteipp: can you also +1 https://gerrit.wikimedia.org/r/#/c/99387/? [21:03:31] (03CR) 10MarkAHershberger: "but it would be nice to have this on REL1_22 for a point release later." [core] - 10https://gerrit.wikimedia.org/r/99731 (owner: 10saper) [21:05:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [21:07:49] vandrew: your favicon change has been deployed, pinged Reedy and he merged, so i think your google task can be marked completed now in time before the weekend (since it said 2 days left). well done [21:11:22] (03PS7) 10Chad: Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 [21:11:25] spagewmf: would this be useful for you too? https://github.com/awjrichards/bingle/issues/16 [21:11:32] (03PS2) 10Brian Wolff: Normalize newlines in DjVu text-layer metadata. [core] - 10https://gerrit.wikimedia.org/r/99710 [21:14:09] bd808, who needs to sign off on https://gerrit.wikimedia.org/r/#/c/98684/? [21:21:34] dan-nl: If you think it's ready I can +2 it. Let's wait for 99387 first and then I'll push the button [21:21:53] bd808: sounds good. [21:22:56] csteipp: once you +1 https://gerrit.wikimedia.org/r/#/c/99387/ we can move forward with moving the extension to the beta cluster. i'll stay online for a bit longer if you have any further questions about it [21:25:51] Reedy: so we still have some memcached issues [21:26:34] can we try just to clear the key wikidatawiki/WBL-1.23wmf5:TermPropertyLabelResolver [21:26:37] (03CR) 10BryanDavis: [C: 032] "Got approval from Chris via irc." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [21:26:44] (03Merged) 10jenkins-bot: filebackend-user-access [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/99387 (owner: 10Dan-nl) [21:28:00] and we're sure each client / wiki has its own memcached? [21:28:19] dan-nl: I'mm about to do the config push for beta if you're ready. [21:28:24] bd808, csteipp, thanks! [21:28:33] bd808: yes, it's ready [21:28:45] greg-g: ^ [21:29:24] dan-nl: "Change has been successfully merged into the git repository." [21:30:07] bd808: cool, thanks, so in about 10 minutes the extension will be on the beta cluster? [21:30:20] (03PS1) 10Mglaser: Merge "Unblacklist group-specific JS/CSS for the user group" [core] - 10https://gerrit.wikimedia.org/r/99737 [21:30:20] aude: "own memcached"? [21:30:24] yep :) [21:30:27] They all go into one big pool [21:30:38] (to dan, man, lag from the office wifi) [21:30:42] dan-nl: That's the theory. [21:30:54] Reedy: ok [21:30:59] (03CR) 10JGonera: Add no-dimensions option to MediaTransformOutput::toHtml (031 comment) [core] - 10https://gerrit.wikimedia.org/r/90679 (owner: 10JGonera) [21:30:59] bd808: you just have to believe, it's like Santa [21:31:19] that might explain stuff [21:31:24] greg-g: I'm a "trust but verify" sort of guy [21:31:25] aude: So should things should be prefixed if they're wiki specific [21:31:26] (03Abandoned) 10Mglaser: Merge "Unblacklist group-specific JS/CSS for the user group" [core] - 10https://gerrit.wikimedia.org/r/99737 (owner: 10Mglaser) [21:31:29] (03PS2) 10JGonera: Add no-dimensions option to MediaTransformOutput::toHtml [core] - 10https://gerrit.wikimedia.org/r/90679 [21:31:31] Reedy: ook [21:31:33] wfMemcKey does something like that IIRC [21:31:49] bd808: "Show me" /me grew up partly in Missouri [21:31:51] (03PS1) 10Aaron Schulz: Tweaked FileRepo::findFiles() behavoir to match LocalRepo [core] - 10https://gerrit.wikimedia.org/r/99738 [21:31:52] right now lookup by english label works on spanish wiki, for example [21:33:48] (03PS1) 10Mglaser: Raised version number to 1.22.0 [core] - 10https://gerrit.wikimedia.org/r/99740 [21:35:03] then i don't know why it worked before and now is a problem [21:35:52] Reedy: do you want to review https://gerrit.wikimedia.org/r/#/c/99742/ ? :) [21:36:08] ^d: https://gerrit.wikimedia.org/r/#/c/99598/ [21:36:10] i highly doubt any other wikidata developer is available, so other choice is self merge [21:36:26] aude: could you point somebody knowledgeable about Wikidata's JS stuff at https://bugzilla.wikimedia.org/show_bug.cgi?id=58106#c3 ? [21:36:49] <^d> AaronSchulz: Heh, redundant check is redundant. [21:37:08] (03CR) 10Aaron Schulz: [C: 032] Add no-dimensions option to MediaTransformOutput::toHtml [core] - 10https://gerrit.wikimedia.org/r/90679 (owner: 10JGonera) [21:37:29] (03CR) 10jenkins-bot: [V: 04-1] Raised version number to 1.22.0 [core] - 10https://gerrit.wikimedia.org/r/99740 (owner: 10Mglaser) [21:38:05] (03Abandoned) 10Mglaser: Raised version number to 1.22.0 [core] - 10https://gerrit.wikimedia.org/r/99740 (owner: 10Mglaser) [21:38:10] (03PS1) 10Umherirrender: No 'Show extended details' for file metadata without extra details [core] - 10https://gerrit.wikimedia.org/r/99744 [21:38:23] (03PS1) 10Merlijn van Deen: Add Python 3.3 syntax checker [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99745 [21:40:21] MatmaRex: it's obviously a high priority, although not sure how easy to fix and what all is needed [21:40:30] and our js developer is aware [21:41:14] probably answer is to initiate most js on editing mode and for only parts needed, if we can make it more fine grained [21:41:17] aude: well, i just commented and said what is needed :) [21:41:18] (03PS2) 10Merlijn van Deen: Add Python 3.3 syntax checker [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98275 [21:41:35] so it doesn't take four minutes [21:41:41] (03PS1) 10Mglaser: Raised version number to 1.22.0 (stable) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99746 [21:41:44] buy, say, twenty-thirty seconds [21:41:45] (03PS1) 10Manybubbles: Remove pool counter from updating pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99747 [21:41:52] still mind-bogglingly long, but usable at least [21:43:19] (03CR) 10MarkAHershberger: [C: 032] Raised version number to 1.22.0 (stable) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99746 (owner: 10Mglaser) [21:43:32] (03CR) 10Aaron Schulz: [C: 04-1] "The warning makes sense, why would something ever rollback when there is no real trx? That sounds like a problem elsewhere." [core] - 10https://gerrit.wikimedia.org/r/99648 (owner: 10saper) [21:44:46] (03Merged) 10jenkins-bot: Add no-dimensions option to MediaTransformOutput::toHtml [core] - 10https://gerrit.wikimedia.org/r/90679 (owner: 10JGonera) [21:44:48] DanielK_WMDE: Are you working on bug 45844 at all, or should I submit a patch for it? [21:45:06] (03CR) 10Hashar: "maybe we can just install the package from Quantal http://packages.ubuntu.com/quantal/amd64/python3.3-minimal/download :D" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99745 (owner: 10Merlijn van Deen) [21:46:25] (03CR) 10jenkins-bot: [V: 04-1] Add Python 3.3 syntax checker [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98275 (owner: 10Merlijn van Deen) [21:51:21] (03Merged) 10jenkins-bot: Raised version number to 1.22.0 (stable) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99746 (owner: 10Mglaser) [21:51:37] qgil: https://gerrit.wikimedia.org/r/#/c/99756/ is it good ?" [21:52:08] (03CR) 10Aaron Schulz: [C: 032] Declare visibility on class properties of Exif [core] - 10https://gerrit.wikimedia.org/r/99398 (owner: 10Siebrand) [21:52:16] I think I got the wrong image [21:52:52] (03PS1) 10Legoktm: Don't set hooks to an empty array [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/99759 [21:52:56] manybubbles: ^ [21:53:27] legoktm: checking [21:53:52] hey hashar, are you able to add me and DivadH to the gwtoolset group on http://commons.wikimedia.beta.wmflabs.org? [21:54:11] (03CR) 10Aaron Schulz: [C: 032] Update documentation for media related classes [core] - 10https://gerrit.wikimedia.org/r/99450 (owner: 10Siebrand) [21:54:29] AaronSchulz: W00t! That was the big-un :) [21:54:32] (03CR) 10Swalling: "Removing my -2 per the update at https://bugzilla.wikimedia.org/show_bug.cgi?id=56455#c44" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [21:55:00] superm401: ^ [21:55:32] Yep, noted. [21:55:33] vandrew, -1 Please pay more attention to these obvious details before asking other community members to review your patches. [21:55:49] legoktm: works for me. [21:56:11] wanna +2? :) [21:56:23] (03CR) 10Aaron Schulz: "Doesn't UploadStash.php also need to use encodeBlob()?" [core] - 10https://gerrit.wikimedia.org/r/99676 (owner: 10saper) [21:56:27] qgil: I'll resolve them right away, sorry for the incovenience [21:56:59] legoktm: one moment. [21:57:22] (03CR) 10Nikerabbit: [C: 032] mediawiki.page.ready: Fix whitespace in IIFE [core] - 10https://gerrit.wikimedia.org/r/99713 (owner: 10Bartosz Dziewoński) [21:57:57] (03CR) 10Siebrand: "This patch won't merge as is because of a merge conflict in release notes. That should be easy to resolve when the time comes to merge, th" [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [21:58:39] legoktm: I know I'm ignorant, but how does that field get initialized to an array in the first place? [21:58:47] it doesnt [21:58:48] (03CR) 10jenkins-bot: [V: 04-1] Update documentation for media related classes [core] - 10https://gerrit.wikimedia.org/r/99450 (owner: 10Siebrand) [21:58:50] (03Merged) 10jenkins-bot: Declare visibility on class properties of Exif [core] - 10https://gerrit.wikimedia.org/r/99398 (owner: 10Siebrand) [21:58:52] I'm missing something.... probably because I'm not good at php. [21:59:13] legoktm: so when I push something onto it php makes it an array? [21:59:38] See, this is my confusion too [21:59:41] manybubbles: yeah. https://dpaste.de/AVxj/raw [22:00:28] Hooks::run will check if any hooks are set or not [22:00:30] (03CR) 10Manybubbles: [C: 032] Don't set hooks to an empty array [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/99759 (owner: 10Legoktm) [22:01:07] qgil: I corrected the description and added the right ico, I think [22:01:21] legoktm: huh, I thought jenkins would submit it [22:01:28] it should? [22:01:35] > Queue lengths: 11 events, 0 results. [22:01:50] backlogged [22:02:05] (03CR) 10Brian Wolff: "The api output is still a little odd. I would suggest that the API sets ignoreRedirect parameter when querying for files, unless the &redi" [core] - 10https://gerrit.wikimedia.org/r/99738 (owner: 10Aaron Schulz) [22:02:35] legoktm: cool. if that is all that is being deployed then I can deploy that during my window too. [22:02:45] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.page.ready: Fix whitespace in IIFE [core] - 10https://gerrit.wikimedia.org/r/99713 (owner: 10Bartosz Dziewoński) [22:02:50] awesome [22:02:59] Krinkle: would you be able to add DivadH and i to the gwtoolset group on http://commons.wikimedia.beta.wmflabs.org? [22:03:25] (03PS2) 10Siebrand: Update documentation for media related classes [core] - 10https://gerrit.wikimedia.org/r/99450 [22:03:55] qgil: I have no idea about the parent. I have used the default way to make a comit. [22:04:16] vandrew, sorry, my fault [22:04:21] (03Merged) 10jenkins-bot: Don't set hooks to an empty array [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/99759 (owner: 10Legoktm) [22:04:31] AaronSchulz: Any chance you would be able to review https://gerrit.wikimedia.org/r/#/c/95746/ and its dependency, if you're not busy? [22:05:00] (03CR) 10Siebrand: [C: 032] "Merge conflict resolved in latest PS. +2 per Aaron's earlier +2." [core] - 10https://gerrit.wikimedia.org/r/99450 (owner: 10Siebrand) [22:05:02] dan-nl: Maybe, I don't know. I don't particularly administer that project in any way. [22:05:08] (03PS1) 10Aude: Update Wikibase, ensure correct memcached for property label lookup [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99762 [22:05:15] (03PS2) 10Siebrand: Remove unneeded uses of else {} in media classes [core] - 10https://gerrit.wikimedia.org/r/99451 [22:05:41] Reedy: greg-g ^ [22:05:49] Krinkle: okay, sorry, it has you listed as an admin … [22:06:34] vandrew: In your commit summary, can you include what the difference is between the icons (So that people like me who aren't familar with the context can figure out why the icon needs to be replaced)? [22:06:51] bawolff: can you make a follow up for https://gerrit.wikimedia.org/r/#/c/99738/ ? [22:07:07] (03CR) 10Nikerabbit: "21:59:59 Running JSDuck with /srv/ssd/jenkins-slave/workspace/mediawiki-core-jsduck/maintenance/jsduck/config.json..." [core] - 10https://gerrit.wikimedia.org/r/99713 (owner: 10Bartosz Dziewoński) [22:07:08] AaronSchulz: Yep, I can do that [22:07:27] * AaronSchulz is getting too distracted by this off tangent [22:08:35] bawolff: I'll add it, thanks [22:08:48] dan-nl: I'm an admin there on the shell side to work on continuous intergration and automatic deployment. [22:08:58] The wiki end, I don't even know if I have a wiki account there. [22:09:15] I could create one etc., but probably best to ask anotehr admin who knows this . [22:09:39] lol, i broke jsduck. [22:09:43] * aude wonder if i can login [22:10:00] thanks Krinkle, working on it in #wikimedia-labs now with hashar [22:10:19] nope [22:10:37] (03Merged) 10jenkins-bot: Update documentation for media related classes [core] - 10https://gerrit.wikimedia.org/r/99450 (owner: 10Siebrand) [22:11:06] legoktm: there is a bunch of undeployed stuff [22:11:18] manybubbles: for? [22:11:35] legoktm: betafeatures. it isn't just your change and internationalization [22:11:40] oh [22:11:50] well we could cherry-pick it to another branch I guess [22:12:11] or just enable the config for Cirrus and then wait for the BetaFeatures changes to get deployed [22:12:23] but that would be 2 weeks from now :| [22:12:25] (03CR) 10Bartosz Dziewoński: "Maybe caused bug 58128? Please look into that :)" [core] - 10https://gerrit.wikimedia.org/r/99377 (owner: 10Siebrand) [22:12:43] /gg/gg [22:12:45] yeah, let me send an email [22:12:45] Bahhhh [22:12:59] * marktraceur is going to have to implement a filter soon [22:13:21] (03PS1) 10Mattflaschen: Fix broken notifications caused by invalid create parameters [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99764 [22:13:35] manybubbles: Is cirrussearch becoming a betafeature? [22:13:41] marktraceur: yeah [22:13:48] Is the product team aware? [22:13:49] I can have this converation with you now then [22:14:01] I don't really care, but Howie might [22:14:01] (03CR) 10Aaron Schulz: [C: 032] Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 (owner: 10Brian Wolff) [22:14:04] I was looking at the list of folks with undeployed changes for BetaFeatures and it is pretty much you [22:14:06] (03PS2) 10Mattflaschen: Fix broken notifications caused by invalid create parameters [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99764 [22:14:23] manybubbles: That makes sense since I wrote the extension. :) [22:14:39] would you mind if I deployed it on Monday 9am SF time? [22:14:44] Not at all [22:14:47] I need a little fix for cirrus to be happy [22:14:56] will you be around in case something horrible happens? [22:15:02] unlikely, I know [22:15:03] Yup! [22:15:06] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/99713 (owner: 10Bartosz Dziewoński) [22:15:14] sweet. I'll add it to my list of stuff getting deployed during that window [22:16:33] (03CR) 10Aaron Schulz: "What is the use of this change?" [core] - 10https://gerrit.wikimedia.org/r/99451 (owner: 10Siebrand) [22:16:34] (03CR) 10jenkins-bot: [V: 04-1] Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 (owner: 10Brian Wolff) [22:16:50] <^d> manybubbles and marktracuer have the same number of characters. It's surprisingly hard to follow who's talking when it's just you two guys. [22:17:05] ^d: We live to confuse you [22:17:11] (03CR) 10Siebrand: "Removing unneeded uses of else{}." [core] - 10https://gerrit.wikimedia.org/r/99451 (owner: 10Siebrand) [22:17:19] ^d: they are the same color for me too. [22:17:24] anyway, going to log off. see you on monday morning [22:17:29] got to hang with kids [22:17:41] (03CR) 10Siebrand: "See https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+branch:master+topic:unneeded-else,n,z" [core] - 10https://gerrit.wikimedia.org/r/99451 (owner: 10Siebrand) [22:17:53] * bawolff goes to rebase that [22:23:01] (03CR) 10Mattflaschen: "Can you explain the purpose of this?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99619 (owner: 10Legoktm) [22:23:02] (03PS6) 10Brian Wolff: Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 [22:23:11] <^d> Whoops, I think I killed beta. [22:23:36] (03CR) 10Aude: "feel free to ask me on irc (again), but PHPUnit can test for warnings and notices." [core] - 10https://gerrit.wikimedia.org/r/99648 (owner: 10saper) [22:23:40] (03CR) 10Aaron Schulz: "Getting:" [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [22:23:49] (03CR) 10Aaron Schulz: "*with" [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [22:23:54] <^d> Well fuck. [22:23:55] <^d> :\ [22:25:05] (03CR) 10Legoktm: "I was writing an IRC bot that would ping me whenever I have an unread echo notification, however that requires polling the API right now. " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99619 (owner: 10Legoktm) [22:26:58] (03CR) 10Bartosz Dziewoński: "Why? I am also not sure if this is an improvement." [core] - 10https://gerrit.wikimedia.org/r/99451 (owner: 10Siebrand) [22:27:49] mutante: how do I attach more than one file to an RT ticket? [22:27:52] (03CR) 10Bartosz Dziewoński: "Aren't thanks private or something? /me has no idea what this change actually does" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99619 (owner: 10Legoktm) [22:28:50] (03CR) 10Legoktm: "Supposedly." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99619 (owner: 10Legoktm) [22:29:58] (03CR) 10Siebrand: "I once had a patch set scored -1 for it, so I decided to take it up as one of the items to correct while doing checks." [core] - 10https://gerrit.wikimedia.org/r/99451 (owner: 10Siebrand) [22:30:03] (03PS5) 10Brian Wolff: Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 [22:30:07] mutante: RT#''6456 [22:30:19] * hexmode is having trouble typing today [22:30:30] (03CR) 10Brian Wolff: "PS5, is just a rebase. What are you doing when you get the warning?" [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [22:30:39] hexmode: reply - attach file - select one and then button "Add more files" [22:31:18] AaronSchulz: What triggered the warning for you? [22:31:35] (03CR) 10Aaron Schulz: [C: 032] Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 (owner: 10Brian Wolff) [22:31:58] mutante: ty, some snafus but they're there now. [22:32:16] (03PS6) 10Ebrahim: Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [22:33:26] hexmode: aha, i see, so it's being built on integration now ? aaah [22:33:53] no more everybody? [22:33:56] mutante: it could be before, I was just lazy. mglaser did it [22:34:09] cool [22:34:27] trying to make sure more than one M of Mark y Markus can do this [22:34:50] but it's signed with your key? [22:35:00] need gpg trust plz [22:35:11] yes, so we didn't have to update keys [22:35:19] my key is already there [22:35:23] k [22:35:26] markus isn't [22:35:33] (03Merged) 10jenkins-bot: Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 (owner: 10Brian Wolff) [22:35:34] can you fix keys.html? [22:36:08] i guess. i remember vaguely we have touched it.. but have to look where it is (now) [22:36:10] qgil: the quality is still not as good as the original [22:37:05] mutante: https://www.mediawiki.org/keys/keys.html [22:37:22] vandrew, I don't know much about creating ico files, but can't you just borrow the same 16x16 image used in the current favicon? [22:37:32] oh i expected noc for some reason, but ok [22:37:57] twkozlowski, please check my reply to vandrew [22:38:10] AaronSchulz: Actually I figured out what was triggering that. Its not my patch, I'll submit a fix as a separate patch [22:38:40] hexmode: cant wget securely from integration because of the cert not matching.. but ..yea i know how long that discussion has been [22:38:44] qgil: that is what I'll do now [22:38:49] for labs certs [22:38:55] vandrew, what is the original image you are using, an SVG or some lower resolution PNG? [22:39:25] mutante: see, that is why it is good we attached the sigs ;) [22:39:39] vandrew: also, the image you just submitted has four layers, and we only need three. The 256x256 pixel isn't really required for our purposes. [22:39:58] vandrew, are you using GIMP? Maybe bawolff was right that using Inkscape and exporting from svg to png would be better [22:40:52] qgil: I used the default 16x16 version and added the 48x48 only [22:41:25] (03CR) 10Aude: [C: 031] Don't assume test user has ID 1 in SpecialPageTest [core] - 10https://gerrit.wikimedia.org/r/99640 (owner: 10saper) [22:41:27] vandrew, talk to twkozlowski , he is the one that knows this stuff [22:41:27] I mean now I'll do that [22:42:14] twkozlowski: I'll make a new commit now without the 256x256 and with the defaul 16x16 [22:42:30] and 32x32 too [22:42:38] that'd be lovely, thanks [22:44:15] twkozlowski: done [22:44:31] hexmode: released [22:44:45] (03PS1) 10Brian Wolff: Fix SvgHandler::getScriptParams to not give warnings. [core] - 10https://gerrit.wikimedia.org/r/99769 [22:44:49] !log mediawiki 1.22 has been released - http://dumps.wikimedia.org/mediawiki/1.22/ [22:44:49] Wrong channel, try again. [22:44:55] mutante: \o/ tyvm! [22:45:06] Woo! [22:45:12] hexmode: yw [22:46:05] (03CR) 10Brian Wolff: "Warning was caused by an earlier commit, and not noticed as not too many people use scripted transform. I submitted a fix at https://gerri" [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [22:46:16] mglaser, hey:) [22:46:34] :D [22:47:27] mutante: mglaser is in #mediawiki, not here [22:48:27] hmmm https://twitter.com/wikimediatech is not updating :/ [22:48:35] i think it's a known issue [22:49:00] vandrew: I know it's nitpicking, but did you notice the difference between the 32 and the 48 px versions of the sunflower? [22:49:56] (03CR) 10Aaron Schulz: [C: 032] Fix SvgHandler::getScriptParams to not give warnings. [core] - 10https://gerrit.wikimedia.org/r/99769 (owner: 10Brian Wolff) [22:49:59] aude: yea, it is known and unfortunate [22:50:11] how about identi.ca [22:50:18] twkozlowski: the colors ? [22:50:27] AaronSchulz: Thanks for the review [22:50:47] :/ [22:53:27] (03CR) 10Parent5446: [C: 032] Restore Signupstart and Signupend messages for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [22:53:30] (03Merged) 10jenkins-bot: Fix SvgHandler::getScriptParams to not give warnings. [core] - 10https://gerrit.wikimedia.org/r/99769 (owner: 10Brian Wolff) [22:53:45] vandrew: yes, the inside of the sunflower [22:54:19] vandrew: for easy comparison, see http://tools.wikimedia.pl/~odder/tpp/mediawiki32px.ico and http://tools.wikimedia.pl/~odder/tpp/mediawiki48px.ico [22:57:10] (03Merged) 10jenkins-bot: Restore Signupstart and Signupend messages for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [23:00:44] twkozlowski: but the official is more like the 48x version [23:01:29] twkozlowski: I think I have found the right one [23:01:51] vandrew: yes, I think they might be using different sunflower pictures [23:02:08] https://commons.wikimedia.org/wiki/File:MediaWiki_logo_1.svg vs https://commons.wikimedia.org/wiki/File:Tournesol.png perhaps, from what I see [23:10:09] twkozlowski: I added the other type of flower [23:10:18] I think they look similar now [23:10:45] oh, I added the wrong file... [23:15:02] marktraceur: btw, did you know that manybubbles|away and ^d are going to update betafeatures on monday (for a fix that enable their stuff)? [23:15:23] Yes, they told me [23:17:11] twkozlowski: ok, this time I thing everything is alright [23:19:15] marktraceur: cool, thought you'd like to know ;) [23:19:36] greg-g: https://gerrit.wikimedia.org/r/#/c/99762/ [23:19:48] if there is a chance to have that deployed.... [23:20:21] vandrew: so you suggest we use the sunflower from the logo at mediawiki.org right? [23:20:22] Reedy: still around? [23:20:34] it ensures per content language memcached for lookup of property labels [23:20:49] e.g. find for german wikivoyage and german wikipedia to share this, but not english [23:20:55] fine* [23:21:22] (03PS2) 10Kambiz Darabi: Allow MediaWiki class to be instantiated inside another PHP application [core] - 10https://gerrit.wikimedia.org/r/99162 [23:23:14] (03CR) 10Kambiz Darabi: "Thanks, and sorry for wasting your time with such obvious mistakes." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [23:24:05] vandrew: from what I see, the 32px version uses a different sunflower than the 15 and 48px ones [23:24:47] (03CR) 10Aaron Schulz: "Works fine with Speech bubbles.svg" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [23:25:09] twkozlowski: wait, aren't the 16 and 32 the same ? [23:25:10] marktraceur: hey, unless you shot a nerf ball at me in the next 5 minutes, I'mma gonna put you as the default cc for GWToolset, cool? ;) [23:25:21] shoot [23:25:32] * marktraceur looks at self WFHing [23:25:34] CURSES [23:25:38] I guess I'll have no choice. [23:26:20] marktraceur: but seriously, multimedia team makes sense (at least as first line of defense)... open to other suggetsions [23:26:56] * aude agree :) [23:27:13] Yeah [23:27:15] I'm game [23:27:16] k [23:27:18] thanks [23:28:18] twkozlowski: the 16x should be the same with the 32 since I used the default one for them [23:28:59] vandrew: let me recheck it again, then... [23:29:34] (03PS6) 10Brian Wolff: Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 [23:31:16] (03CR) 10Aaron Schulz: [C: 032] Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [23:32:32] (03CR) 10Brian Wolff: "The api issue turned out to be more complicated then I thought, and I have to run. I'll look into it further tomorrow." [core] - 10https://gerrit.wikimedia.org/r/99738 (owner: 10Aaron Schulz) [23:33:03] vandrew: I think they do differ. [23:33:24] vandrew: try opening the ico file in GIMP, and exporting the three layers into three different files [23:33:33] and then opening them in a browser next to each other [23:33:55] there is visible difference between the 32px layer and the other ones [23:34:22] twkozlowski: ok, then I'll change the 32x one to be the same with the rest [23:34:34] vandrew: thanks much [23:34:43] I'll have a look in the morning, have to get some sleep now [23:34:50] (03Merged) 10jenkins-bot: Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [23:34:51] thanks for your work, it is greatly appreciated [23:35:00] vandrew: and for your patience as well! [23:41:20] bawolff: re the opening up "upload-by-url" old bug you referenced, that's really interesting, I wonder what kinds of considerations need to be taken for it (I'm not suggesting anything crazy like legal) [23:41:33] hey csteipp and AaronSchulz, the extension is on the beta cluster, but unfortunately we have a config issue to deal with. i'm hoping that we can allow the config change on the beta cluster today and then discuss what would need to happen for production next week. https://gerrit.wikimedia.org/r/#/c/99775/ if you're okay with it, please +1 and then bd808 will merge it [23:41:39] but... ugh, I uttered the word, maybe they'll hear it and make a recommendation [23:42:01] (03PS1) 10JGonera: Remove -o and -moz vendor prefixes from transition LESS mixin [core] - 10https://gerrit.wikimedia.org/r/99779 [23:42:03] heya dan-nl :) [23:42:11] hey greg-g :) [23:42:25] greg-g: I really just don't understand why it was restricted in the first place. I have no idea what's the concern [23:42:35] yeah [23:42:36] * bd808 channels Reedy: "DOWNLOAD ALL THE THINGS" [23:42:55] there's plenty of unsavory stuff on flickr, it isn't like its "better" than the rest of the internet [23:43:05] Any jerk can upload anything too [23:43:12] (03CR) 10Parent5446: [C: 032] Make a single colon an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/99674 (owner: 10Umherirrender) [23:43:18] bawolff: if used to skip the limit checker (size wise) didn't it? [23:43:30] * bd808 uploads pictures of Steve Martin as The Jerk [23:43:31] greg-g: There's lots of unsavoury stuff on commons :P [23:43:44] probably worse than flickr [23:43:58] p858snake|l: Ah yup. I'm pretty sure it does. [23:44:13] p858snake|l: If it did at one point, that certainly hasn't been the case for a very long time [23:44:25] bawolff: Really? [23:44:27] bawolff: flickr has (or had) some of the more "hardcore" fetish porn back in the day, pretty sure commons doesn't [23:44:39] Maybe I'm just not familar with flickr [23:44:43] (03CR) 10Parent5446: Added a TIME_ONLY option to FileRepo::findFiles to use less RAM [core] - 10https://gerrit.wikimedia.org/r/99526 (owner: 10Aaron Schulz) [23:44:43] <^d> Long as we respect size limits, there's no more harm in upload-by-url than normal uploading. [23:44:52] <^d> We can't stop people from downloading and uploading by hand ;-) [23:45:17] ^d: slapping people with gloves, does not count as stopping [23:45:27] upload-by-url can turn our server into an attack proxy. So that's (one of) the reason for the whitelist. [23:45:42] bawolff: yeah, flickr and tumblr are both pretty seedy when you get to the more adult depths [23:45:59] csteipp: so, it's more of a trusting what about flickr, then? [23:46:17] I guess trusting they can take our ddos? [23:46:20] <^d> csteipp: That's an argument for throttling and whitelisting, not for locking down the permission imho. [23:46:24] vs small random site on the internet [23:46:31] More that our server is limited to attacking flickr if someone finds a GET based exploit [23:46:38] * greg-g nods [23:47:07] so, dan-nl would a reasonable solution be to whitelist a small set for testing, and then have a requirement to use the tool be "file a bug to add your upload domain to the whitelist"? [23:47:26] it'd be a nice way of making sure we know about upcoming uploads, too [23:47:34] "here comes 10 TB of stuff!" [23:47:40] :) [23:47:42] (03Merged) 10jenkins-bot: Make a single colon an invalid title in php and js [core] - 10https://gerrit.wikimedia.org/r/99674 (owner: 10Umherirrender) [23:47:51] <^d> greg-g: Again, an argument for proper throttling :) [23:47:57] ^d: that too ;) [23:48:04] so if you want your domain added to the whitelist you add a bug report? [23:48:18] Also isn't upload by url already limited to admins on top of that (who hopefully aren't too evil) [23:48:23] I don't *like* us being a bottle neck like that, but I don't foresee the uptake of this to be 10s per week, more 10s per year [23:48:27] dan-nl: yeah [23:48:39] bawolff: yeah, I believe so [23:49:05] i think that's a reasonable work around for now … i'll make a change to the patch i just created [23:49:11] ^d: The other issue is curl-client exploits (like the parsing one last spring) [23:49:38] <^d> :( [23:50:12] my only concern would be making sure someone is available to handle any of those requests, but for now this at least lets us move forward [23:50:29] we're pretty good about site-requests [23:50:37] s/we're/Reedy's/ [23:51:54] UploadFromUrl does honor $wgMaxUploadSize, but only after the temp file has been fully downloaded [23:52:05] oh... [23:52:13] Well I guess that could be a problem [23:52:23] <^d> I remember why I stopped messing with the upload code now, bleh. [23:52:31] ^d: There's dragons [23:52:35] So it doesn't a) peek at the download size header or b) abort as soon as it has too much data [23:53:20] ^d: I think the Upload related classes are my least favourite classes in all of mediawiki (The way it was stretched for chunked upload in particular, is just :s ) [23:53:49] bawolff: Come back this summer and you can fix all that :) [23:54:32] bd808: i just updated the patch with a limited list for now. are you okay with pushing that to the beta cluster? https://gerrit.wikimedia.org/r/#/c/99775/2/wmf-config/InitialiseSettings-labs.php [23:54:32] rewrite all the multimedia related code! [23:55:18] <^d> Upload doesn't use $wgTitle, it can live. [23:55:21] <^d> It can live. [23:55:36] bd808: i did write some code that does peek at the header [23:55:48] but i don't remember if i check the upload size … will look [23:57:15] ^d: On the other hand, it does store data in the user session, which it then messes about with in the job queue from the command line by starting a session for that user even though php is being executed from cli [23:57:29] * ^d snickers [23:57:35] More importantly, it sort of just doesn't really work most of the time [23:57:35] <^d> Remember who wrote most of that now ;-) [23:57:53] (03CR) 10Bartosz Dziewoński: "Probably no one will actually notice anyway, but I'm not sure if there's value in removing these." [core] - 10https://gerrit.wikimedia.org/r/99779 (owner: 10JGonera) [23:59:33] csteipp: Can you give a quick +1 to https://gerrit.wikimedia.org/r/#/c/99775/ ? [23:59:40] * bd808 does a CYA [23:59:43] <^d> bawolff: Didn't you say something about using a different title in WebRequest to get rid of that last $wgTitle there? [23:59:45] greg-g: no reedy? [23:59:49] (03CR) 10Legoktm: [C: 032] "Erp :/" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99764 (owner: 10Mattflaschen) [23:59:54] <^d> Or was it HttpFunctions? [23:59:58] (03Merged) 10jenkins-bot: Fix broken notifications caused by invalid create parameters [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/99764 (owner: 10Mattflaschen)