[00:00:37] csteipp, Aaron|home, thanks for your help. i'll see what i can come up with later today after talking with hashar about the beta cluster config [00:00:57] werdna: I'm not sure I understand, are you saying Trevor is opposing jquery.scroll? [00:01:19] Krinkle: I'm saying that Trevor is opposed to factoring it out of OOJS. [00:01:24] He wants to keep the existing implementation. [00:01:51] (03CR) 10Cscott: [C: 032] Add non-enwiki test case. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99001 (owner: 10Cscott) [00:02:10] I'm not fighting that, it's not my problem what you guys use in OOJS [00:02:10] (03CR) 10Cscott: [C: 032] Fetch PDFs when used as images, and thumbnails for embedded video. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99002 (owner: 10Cscott) [00:02:43] (03Merged) 10jenkins-bot: Add non-enwiki test case. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99001 (owner: 10Cscott) [00:03:24] (03Merged) 10jenkins-bot: Fetch PDFs when used as images, and thumbnails for embedded video. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99002 (owner: 10Cscott) [00:05:03] (03PS1) 10Matthias Mullie: [Experimental] div contenteditable editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99004 [00:11:10] (03Abandoned) 10Aaron Schulz: Hash long memcached keys and warn about it in the logs [core] - 10https://gerrit.wikimedia.org/r/94989 (owner: 10Aaron Schulz) [00:13:26] (03PS1) 10Cscott: Update packages to match deps of latest mw-ocg-bundler and mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/99006 [00:14:13] (03CR) 10Cscott: [C: 032 V: 032] Update packages to match deps of latest mw-ocg-bundler and mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/99006 (owner: 10Cscott) [00:16:22] (03PS1) 10Cscott: Update to latest bundler, latexer, and node_modules. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99008 [00:16:23] (03CR) 10jenkins-bot: [V: 04-1] Update to latest bundler, latexer, and node_modules. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99008 (owner: 10Cscott) [00:16:24] (03CR) 10EBernhardson: [C: 032] Fix to post history link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98987 (owner: 10Bsitu) [00:16:28] (03PS3) 10Jdlrobson: Add ability to generate KSS files for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/98990 [00:16:33] (03Merged) 10jenkins-bot: Fix to post history link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98987 (owner: 10Bsitu) [00:16:47] (03PS1) 10Matthias Mullie: Improve edit-post form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99009 [00:19:07] (03PS2) 10Cscott: Update to latest bundler and latexer; rename their binaries. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/99008 [00:20:32] * Aaron|home gives https://gerrit.wikimedia.org/r/#/c/97993/ to bawolff [00:20:59] * bawolff will look at it [00:22:24] * Aaron|home will want to do a follow up too [00:25:14] (03CR) 10Bsitu: Always use UUID objects when querying storage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98994 (owner: 10EBernhardson) [00:26:19] (03PS1) 10Krinkle: resourceloader: Make sure hashmtime cache key is different by language [core] - 10https://gerrit.wikimedia.org/r/99010 [00:26:50] (03PS1) 10Catrope: Update VisualEditor to 1.23wmf5 branch for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99012 [00:27:57] (03PS1) 10Catrope: Update VisualEditor to wmf4 branch for cherry-pick [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99013 [00:28:08] (03CR) 10Catrope: [C: 032] Update VisualEditor to 1.23wmf5 branch for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99012 (owner: 10Catrope) [00:28:19] (03CR) 10Catrope: [C: 032] Update VisualEditor to wmf4 branch for cherry-pick [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99013 (owner: 10Catrope) [00:28:25] (03CR) 10Catrope: [V: 032] Update VisualEditor to wmf4 branch for cherry-pick [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99013 (owner: 10Catrope) [00:28:32] (03CR) 10Catrope: [V: 032] Update VisualEditor to 1.23wmf5 branch for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99012 (owner: 10Catrope) [00:30:08] ^d: Sorry to ask, but QChris isn't around… I'm suddenly getting logged out of gerrit on every page load. Is something meant to have changed? [00:30:25] <^d> Nothing on our end, hmm [00:39:30] (03CR) 10Mattflaschen: "Yes, my understanding is that adding it by default is intended to accommodate buttons in regular wikitext/templates." [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [00:41:19] RoanKattouw: https://github.com/gruntjs/grunt-contrib-csslint/issues/26 [00:41:29] TimStarling: is https://gerrit.wikimedia.org/r/#/c/95304/ ok now? [00:56:05] (03PS4) 10Tim Starling: Added support to img_auth.php for non-repo containers [core] - 10https://gerrit.wikimedia.org/r/95304 (owner: 10Aaron Schulz) [00:56:11] (03CR) 10Tim Starling: [C: 032] Added support to img_auth.php for non-repo containers [core] - 10https://gerrit.wikimedia.org/r/95304 (owner: 10Aaron Schulz) [00:56:14] (03PS2) 10Catrope: resourceloader: Make sure hashmtime cache key is different by language [core] - 10https://gerrit.wikimedia.org/r/99010 (owner: 10Krinkle) [00:56:23] yes [00:57:15] (03CR) 10Catrope: [C: 032] resourceloader: Make sure hashmtime cache key is different by language [core] - 10https://gerrit.wikimedia.org/r/99010 (owner: 10Krinkle) [00:59:51] (03PS1) 10Ori.livneh: resourceloader: Make sure hashmtime cache key is different by language [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99014 [01:00:12] (03PS1) 10Ori.livneh: resourceloader: Make sure hashmtime cache key is different by language [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99015 [01:00:32] greg-g: mind if i sync those? [01:01:24] * greg-g looks [01:01:40] (03Merged) 10jenkins-bot: Added support to img_auth.php for non-repo containers [core] - 10https://gerrit.wikimedia.org/r/95304 (owner: 10Aaron Schulz) [01:01:42] some context in #wikimedia-operations too [01:02:18] spagewmf: does the flow board-history view not work on ee-flow? Or is there a place I can look at that? [01:02:28] (03PS2) 10EBernhardson: Global variable to disable flow's memcache usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 [01:02:33] I was starting to try to reason about if that's a good way to do it or not, but whatever, Roan +2'd it ;) [01:02:38] ori-l: yeah, go forth [01:03:14] (03CR) 10Ori.livneh: [C: 032] resourceloader: Make sure hashmtime cache key is different by language [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99015 (owner: 10Ori.livneh) [01:03:19] greg-g: Summary: Ori deployed the localStorage thing, we saw bits traffic be cut in half, were puzzled as to why the impact was so large (positive, but still), and found a bug that inflated bits traffic that localStorage is now dampening the impact of [01:03:26] (03CR) 10Ori.livneh: [C: 032] resourceloader: Make sure hashmtime cache key is different by language [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99014 (owner: 10Ori.livneh) [01:03:36] So this is the fix for that bug [01:03:36] RoanKattouw: interesting! [01:05:01] where's jenkins? [01:05:08] out back smoking [01:05:18] damn slacker [01:05:22] (03Merged) 10jenkins-bot: resourceloader: Make sure hashmtime cache key is different by language [core] - 10https://gerrit.wikimedia.org/r/99010 (owner: 10Krinkle) [01:05:23] || whanking [01:06:27] 'wh'? [01:12:19] (03CR) 10Bsitu: [C: 031] (bug 57388) first click in [Start a new topic] jumps to textarea below [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98497 (owner: 10Matthias Mullie) [01:13:10] greg-g: done, thanks [01:21:33] manybubbles: i saw your note on https://bugzilla.wikimedia.org/show_bug.cgi?id=57934 [01:21:58] awjr: sure [01:22:26] manybubbles: do you know what kind of caching is in front of search? i was wondering if it would be something like that or possibly search requests being sent to different nodes that aren't in sync [01:23:13] awjr: That prefix search has varnish in front of it with a pretty long ttl [01:23:39] do you have any idea what varies that cache manybubbles? [01:24:00] awjr: no, though being logged in turns it off, I believe [01:24:19] like the text caches [01:24:57] that might explain https://bugzilla.wikimedia.org/show_bug.cgi?id=57934#c2 [01:25:21] not the logged in part [01:25:31] but something caching related [01:26:02] it could be an error the was cached [01:26:20] but I'm not sure [01:26:29] i could see that [01:26:43] do you know who might know more about search varnishes? [01:27:06] I think it is just the regular varnish [01:27:18] might be worth looking at the vcl in the puppet repository [01:27:21] kk [01:27:26] thanks [01:27:30] I *think* it is in puppet [01:27:36] fingers crossed :) [01:28:02] gwicke: is it worth adding b/c for ParsoidCacheUpdateJob jobs if new ones use BacklinkJobUtils? The dependency ones could just no-op . [01:32:04] (03PS6) 10Spage: Demonstrate use of oo-ui [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 [01:32:42] (03Abandoned) 10Legoktm: Display stats on preview of how many pages we are posting to [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81894 (owner: 10Legoktm) [01:36:23] RoanKattouw: James_F: Finally found a bug report for it: https://code.google.com/p/chromium/issues/detail?id=236298 [01:41:23] (03CR) 10Spage: [C: 04-1] "Matthew Flaschen is right, but I don't have a better place for this yet. Oojs-ui is independent of MediaWiki so a demo program showing ho" [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 (owner: 10Spage) [01:50:27] Aaron|home: IMO it makes more sense to add some URL job for the parsoid stuff [01:51:06] we will also move away from Varnish soon, so I'm not too keen to spend too much time on the current jobs [01:56:36] (03PS4) 10Ragesoss: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 [02:05:38] (03PS1) 10Bsitu: Escape $action in hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99019 [02:07:06] YuviPanda: did you ever have the chance to set up a gerrit-to-redis key for me? [02:09:03] RoanKattouw: http://cl.ly/image/19242i20473B https://gist.github.com/Krinkle/8d42cbb13d51b3473c67 [02:15:20] (03CR) 10Mattflaschen: "The bug ID disappeared." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [02:18:01] (03CR) 10CSteipp: [C: 031] sanitizer-escape-id [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98742 (owner: 10Dan-nl) [02:18:40] (03CR) 10Mattflaschen: [C: 04-1] "Thanks for cleaning up the code duplication remnants from https://gerrit.wikimedia.org/r/#/c/98357/ ." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [02:20:47] (03PS2) 10Bsitu: Fix a fatal error on topic history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98750 [02:21:16] (03PS3) 10Bsitu: Fix a fatal error on board history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98750 [02:23:23] (03PS1) 10Theopolisme: [WIP] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [03:03:59] (03PS2) 10Theopolisme: [WIP] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [03:05:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [03:07:40] (03PS3) 10Theopolisme: [WIP] Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [03:09:52] (03CR) 10Kaldari: "Yes, loading it by default is to facilitate wiki content, but it will also be used by non-wiki content. The main reason we want to provide" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [03:13:00] (03PS4) 10Werdna: [WIP] Shorten uuids to 88 bits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [03:13:02] (03PS3) 10Werdna: Always use UUID objects when querying storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98994 (owner: 10EBernhardson) [03:13:04] (03PS3) 10Werdna: Ensure non-binary cache keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 (owner: 10EBernhardson) [03:15:26] (03CR) 10Brian Wolff: Optimized LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [03:15:38] (03CR) 10Brian Wolff: [C: 04-1] Optimized LocalRepo::findFiles() (034 comments) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [03:20:01] (03PS1) 10Yaron Koren: Fixed handling of uppercase chars in var names for #display_external_table [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/99023 [03:20:03] (03CR) 10Brian Wolff: "Additionally it would really be nice if this added some unit tests. (Ideally, there should at least be enough of a unit test so that jenki" [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [03:20:23] (03PS6) 10Jforrester: Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [03:20:54] (03CR) 10Yaron Koren: [C: 032 V: 032] Fixed handling of uppercase chars in var names for #display_external_table [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/99023 (owner: 10Yaron Koren) [03:21:16] (03CR) 10Daniel Friesen: "OutputPage already loads a number of modules that I'd say would be relatively similar. The stuff currently loaded by SkinTemplate is exclu" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [03:21:55] (03CR) 10jenkins-bot: [V: 04-1] Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [03:25:20] (03PS7) 10Jforrester: Add OOjs and OOjs UI to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [03:35:50] (03CR) 10Brian Wolff: Optimized LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [03:46:42] (03CR) 10Legoktm: [C: 031] "https://gist.github.com/legoktm/7781996 will blank the messages on all public WMF wikis. If someone with the appropriate rights wants to r" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:00:53] (03PS5) 10Werdna: [WIP] Shorten uuids to 88 bits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [04:06:26] (03PS6) 10Werdna: [WIP] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [04:40:39] Hmmmmmm. [04:40:51] I'm trying "git rebase gerrit/master" instead of "git rebase origin/master". [04:41:43] Elsie: Is it better? [04:41:54] I'm not sure. [04:42:02] I'm just trying to update an old patchset. [04:42:02] They should really be the same thing [04:42:16] Unless you haven't updated one or the other [04:45:05] hey, anybody good with git? I want to create a changeset that depends on two unmerged changesets, and I don't really want those changesets to depend on each other. [04:46:18] werdna: Basically the answer is "merge the commits and base the change on the merge commit" [04:46:23] werdna: you can't [04:46:31] well, we don't use merge commits though [04:46:32] hmph [04:46:45] lazyktm: He can rebase it after one of them gets merged [04:46:54] oh [04:46:56] that would work [04:47:02] I did that once for MMV [04:47:26] Just -2 the merge commit [04:47:56] * werdna shrugs [04:48:04] git checkout 2013/flow/db-storage-abstraction [04:48:13] git merge gerrit/98995/3 [04:48:30] git checkout 2013/flow/contributions; git rebase --onto 2013/flow/db-storage-abstraction HEAD~1 [04:48:33] that'll do the trick for now [04:48:45] I can always rewrite the history now [04:48:49] s/now/later [04:48:53] force pushing! [04:49:11] lazyktm: No jedi git tricks [04:49:49] haw haw [04:49:53] I have to say [04:49:58] the more I use git, the more I love it [04:50:09] *nod* [04:50:11] I just noticed I'd done a bunch of refactoring in the patch I was writing [04:50:47] so git commit -a; git reset files/that/I/refactored; git commit --amend --no-edit; git commit -am 'The changes that were not part of my original change'; git rebase --onto HEAD~2 HEAD~1 [04:50:53] and then label the branch and return [04:51:15] though I guess I could have done git checkout -b my/refactoring/branch between the commits and then just git checkout my/old/branch at the end [04:51:29] ....yeah, thats out of my git skill range. [04:52:26] hey Ryan_Lane, haven't we scared you away yet? [04:52:47] yurik: ok [04:52:52] :) [05:00:09] (03PS1) 10Santhosh: Make explicit plural forms work for Russian [core] - 10https://gerrit.wikimedia.org/r/99029 [05:00:15] ori-l, ok, so my questions so far: the config object - should it be my object or should I just use an array that gets passed around? The advantages of the array is that users of the config (say, enwiki) doesn't need to even load JsonConfig extension... unless of course they want to validate it in which case it is no longer as trivial [05:00:28] or a derived object [05:01:45] (03PS3) 10Tim Starling: Add a bit of output to makeSimpleList.php [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/96374 (owner: 10Reedy) [05:01:47] array is nicer if you can pull it off [05:01:51] (03CR) 10Tim Starling: [C: 032] Add a bit of output to makeSimpleList.php [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/96374 (owner: 10Reedy) [05:02:22] (03Merged) 10jenkins-bot: Add a bit of output to makeSimpleList.php [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/96374 (owner: 10Reedy) [05:02:54] ori-l, yes, but array means no validation [05:03:17] hmm, actually doubt it - because then you need to implement your own access to cache [05:03:40] so i guess the question is -- my object vs my base object + derrived [05:03:54] another question - the mechanism of plugin integration -- hooks are not very good [05:07:43] ori-l, thoughts? [05:09:21] sorry, back in a bit [05:17:30] what is not very good about hooks? [05:21:51] yurik: ^ [05:22:27] ori-l, the hooks are per string, and allow multiple hook ups [05:22:43] here i would rather have "per subnamespace", and only once [05:23:09] there should be only one extension controlling a specific config page [05:23:29] (03CR) 10Parent5446: Optimized LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [05:24:17] hence -- $wgJsonConfigPlugin['Proxy']['Validate'] = onValidate [05:24:18] (03CR) 10Tim Starling: "Filed bug 57961 for this." [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/91659 (owner: 10Reedy) [05:24:53] right; so a JSON configuration content that is extended by particular implementations gets you that, sort of [05:25:15] ori-l, not sure what you mean [05:26:29] subclassing a JsonConfigContent and overriding a validation method has the characteristics you desire [05:27:02] it's up to the method whether to call the parent class's method which it shadows [05:28:23] (03CR) 10Aaron Schulz: Clean up global state when job finishes (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94685 (owner: 10Legoktm) [05:28:35] ori-l, but what about specifiying which JsonConfigContent to instantiate? [05:28:46] via the config example above? [05:29:26] $wgJsonConfigPlugin['Proxy'] = 'MyJsonConfigContent' ? [05:30:04] $wgContentNamespaces [05:30:32] won't work - it only supports regular namespaces, not the sub-namespaces I would like to have [05:30:47] page title: "Config:Proxy:Opera" [05:31:07] otherwise meta community would eat us alive [05:31:20] heh [05:31:21] as everytime you need to create a new type of config, there will be pain [05:31:32] esp if you need just one of those pages [05:31:48] you could provision a dedicated config wiki [05:32:02] Config:MyExtension:Production [05:32:07] (vs Test :)) [05:32:17] (03CR) 10Parent5446: Optimized LocalRepo::findFiles() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [05:33:52] talk namespaces accompany a primary namespace, maybe that could be extended in core to support some notion of nested namespaces [05:34:02] or maybe you could use categories? [05:34:44] ori-l, there is no need for that - the page Title would be "MyExtension:Production" for the Config:MyExtensionProduction - and the talk page would work just as well [05:35:02] ah, i see [05:35:07] the only difference is that the different Content object would be instantiated [05:35:26] either that or a different Config object for the same Content object [05:37:43] do you have a use case other than Zero? [05:38:35] I'm not skeptical; I see the need for something like this. But maybe if you have another case specifically in mind other than Zero you'd be able to resolve these issues better; it's a bit abstract for me [05:38:51] events :) [05:39:04] list of proxy IPs [05:39:41] possibly - IP blocker (if that list is public) [05:39:47] the politics of meta shouldn't influence the technical design of this extension, right? [05:39:55] exactly [05:40:27] i mean, if the metawiki community finds the proliferation of namespaces obnoxious, i don't think they're going to be fooled by us nesting namespaces inside other namespaces like matrioshki [05:40:29] that's why - limiting to just one namespace with the stringent editing requirements and flagged revisions implementation [05:41:11] ori-l, the only reason (IMHO) they are annoed with namespaces is because namespace lists show up all over interface - like in searching, filtering, etc [05:41:28] if all these configs are limited to just one "Config" NS, it won't affect anyone [05:41:40] i don't call it namespace, i call it prefix :) [05:42:40] right, but there's no special benefit to housing this namespace on meta; why not provision a dedicated wiki? [05:43:13] we do one for every wikimania, it doesn't seem like a huge deal [05:44:42] there is no common monitoring across multiple wikis / spam/vandal fighting, it already sits on the main cluster - stability for production-related activity, etc [05:44:57] i don't think we should have split off all other wikis from the meta [05:45:07] like mediawiki.org should have been together with meta [05:45:24] meta - means anything "about the project" [05:45:38] there is no point to splinter it off like that [05:46:05] common templates, etc [05:46:08] tons of issues [05:46:44] templates are a major hassle for example - they work on some wikis, they work differently on other, very hard to migrate them, ... you are a programmer, you know that you shouldn't have copies of stuff :) [05:48:59] oh, cross linking is painful too :) [05:52:53] do you need multiple levels of nesting? [05:53:00] nope [05:53:07] one per extension [05:53:16] or multiple per ext [05:54:05] (03CR) 10Santhosh: [C: 04-1] Add new jquery.scroll.js plugin. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [05:54:11] Config:Zero:NNN or Config:EventType:NNN (or however you want to use them), or Config:Proxy:Name [05:54:14] things like that [05:54:50] and JsonConfig can also support custom namespaces (like in the case of Zero - until we migrate it - Zero:NNN) [05:55:37] so just one sublevel really. And besides, this makes it very convinient for the API: you can list all pages with a specific prefix [05:55:45] in the namespace Config [05:55:47] santhosh: I'm not sure I understand the difference? [05:56:06] you don't like the fact that the function is enclosed in parentheses? [05:56:18] werdna: we are invoking a function with jquery as argument [05:56:29] so am I? [05:56:44] what's wrong with what I wrote? I have an IIFE as well. [05:57:35] it is just convention to have arguments to function close to function, instead of function in paranthesis and arguments outside [05:58:07] okay, so you don't like the fact that I put the function in parentheses? [05:58:55] if you change the last line to }( jQuery ) ); it will be perfect [05:59:26] yurik: sounds mostly sane :) [05:59:37] https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Closure should make it more clear to you :) [05:59:57] ori-l, of course it does :) Can you give me an example of an event definition? [06:00:13] santhosh: I'm not sure I understand the significance of putting the parentheses around the entire statement rather than around the function expression [06:00:19] it's not explained at the link you gave me [06:00:41] yurik: https://meta.wikimedia.org/w/index.php?title=Special%3APrefixIndex&prefix=&namespace=470 ? [06:00:59] ori-l, any specific one that you think is the most representative? [06:01:01] good for a doc? [06:01:49] https://meta.wikimedia.org/wiki/Schema:Echo, perhaps? [06:02:20] thx. And I really don't think "schema" was a good namespace name :) [06:03:14] santhosh: you might say I'm a bit iffy about it [06:03:15] haw haw haw [06:03:22] yurik: yeah, probably too generic [06:04:10] werdna: http://benalman.com/news/2010/11/immediately-invoked-function-expression/ has some discussion on both formats. both works very well. [06:04:40] werdna: it seems (function(){ /* code */ }()); is Crockford recommendation :) [06:05:06] (03CR) 10Brian Wolff: "Tested locally, seems to work well. One minor issue with inserting jobs on the central wiki, which I don't think should happen, but once t" (032 comments) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [06:05:07] werdna: I care about consistancy alone here. [06:05:20] consistency of where the parentheses are in IIFEs? [06:05:41] yes, compared to other similar js code in MW [06:06:54] I'll be honest, I think that's a total waste of time. But I'll change it – I just want to get this damn thing in. [06:07:07] werdna: :) [06:07:41] ori-l, are there any other systems that store json in wiki? [06:07:46] that you may know? [06:08:29] (03PS6) 10Werdna: Add new jquery.scroll.js plugin. [core] - 10https://gerrit.wikimedia.org/r/96949 [06:08:34] don't think so, no [06:08:42] there ya go santhosh :p [06:09:05] ori-l, thx. I'm writing https://www.mediawiki.org/wiki/Requests_for_comment/Json_Config_pages_in_wiki [06:10:14] guys, random question .. I'm going over the mw styles for images (thumb / thumbinner / figurecaption) for VE styling stuff, but thumbinner seems to be defined as div.thumbinner .. is there a reason why not to remove the div and leave it as just .thumbinner? [06:10:54] Probably not. [06:10:56] no; in fact, omitting the div makes the selector faster [06:11:08] am I missing something? the class isn't used anywhere else as far as I can see, but we're switching from the div/div/div/div/div/div structure to the more convenient (Parsoid-friendly)
[06:11:13] since the browser has one test to execute against each element rather than two [06:11:18] I imagine that selector dates back to way way back [06:11:34] (03CR) 10Legoktm: "Given that there's basically nothing left in this extension anymore, bug 55678 might be worth looking into." [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 (owner: 10Ori.livneh) [06:12:04] so probably someone just wrote div.thumbinner in the early days, and noone has changed it [06:12:07] well, I made a mirror class that's ve-specific [06:12:09] mooeypoo: https://github.com/stubbornella/csslint/wiki/Disallow-overqualified-elements [06:12:34] oh, and ori-l, pls +2 git-update :) [06:12:40] hmm [06:12:44] i'm forced to stay on branch in vagrant [06:12:48] I'm wondering if I should submit a fix for that [06:13:29] (03CR) 10Ori.livneh: [C: 032] Added "git-update" command [vagrant] - 10https://gerrit.wikimedia.org/r/98033 (owner: 10Yurik) [06:13:30] I mean, I made a mirror css for the ve-class so the image will look the same when it's edited even though it's in
-- but then it will be annoying for theme people to adjust it [06:13:33] (03Merged) 10jenkins-bot: Added "git-update" command [vagrant] - 10https://gerrit.wikimedia.org/r/98033 (owner: 10Yurik) [06:13:38] lol, that was fast [06:13:40] (03CR) 10Legoktm: [C: 04-1] Unconditionally insert shop link via PHP (033 comments) [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 (owner: 10Ori.livneh) [06:14:05] ori, want to review the other one about renaming? [06:14:09] lazyktm: 'return true' isn't necessary anymore [06:14:14] although i couldn't figure out how to do aliasing [06:14:36] ori-l: sure, but why break back-compatibility over something so trivial? [06:14:38] yurik: i think it's fair to make aliases a requirement; it's muscle-memory for me at this point and probably for a few others [06:14:53] ori-l, i'm not against it - just not sure how to do it :) [06:15:12] lazyktm: you mean, for all the non-Wikimedia users of WikimediaShopLink? [06:15:12] Hello, are there any mentors online who can help with the 'Make MediaWiki documentation translatable' task? [06:15:25] your code simply registers "command" -> handler code [06:15:43] which means that I would have to duplicate that code [06:15:48] ori-l: heheheh. you never know! [06:15:50] * bawolff resists urge to make snide comment about mediawiki not having documentation... [06:15:58] which means that it would show up twice in the list of commands [06:16:00] lazyktm: the suggestion to merge it into wikimediamessages is good, i think [06:16:21] bawolff, I thought there was an accepted GSoC that was going to magically fix that problem? [06:16:33] * mooeypoo heard that during the summer application time [06:16:38] and the internet never lies. [06:16:48] bawolff, that is the exact name of the task I just claimed. [06:16:55] ori-l: I think so too [06:17:13] Well if every gsoc magically fixed all the things they claimed they were going to fix... :P [06:17:23] YuGin: I know, I was making a joke [06:17:24] yurik: a lot of vagrant is implemented using its own plugin architecture [06:17:34] so you may be able to hook into the command-line processing component somehow [06:17:37] the code is pretty readable [06:17:57] YuGin: To be honest, I don't know much about translate extension, but I could link you to the documentation [06:18:03] ori-l, to a trained programmer -- but it takes time to get the gist of stuff just from reading code when you're new [06:18:03] bawolff- eh, ok... I'm new here so I guess I'm not supposed to get it... [06:18:13] * yurik debates if its worth the time... [06:18:23] YuGin: Basically people complain a lot that our documentation isn't very good [06:18:28] i did learn some ruby while hacking it [06:18:31] bawolff, I actually need help deciphering the task instructions. [06:18:47] and even got rubymine to explain it to me... btw, a good IDE [06:19:02] YuGin, task? is that for google code-in ? [06:19:09] mooeypoo- yes. [06:19:13] awesomesauce :) [06:19:20] YuGin: Do you have a link handy to the task [06:19:25] seems that just like other people get religious about apple, i'm slowly turning into a JetBrains fanatic... :( [06:19:33] bawolff: http://www.google-melange.com/gci/task/view/google/gci2013/5792145784963072 [06:20:03] yurik, why is that a sadly-face? as long as you don't camp out in front of the JetBrains website overnight to get the latest version, I think you can do a smiley when you state that. [06:20:08] YuGin: This page will probably help somewhat: https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_example [06:20:21] thx mooeypoo, you have a point [06:20:41] * mooeypoo sometimes does [06:20:45] Nemo_bis: ping (?) [06:21:22] ooh the translate extension. I've never actually did that, though I did translate stuff. [06:21:37] bawolff- yes, that's one of the overwhelmingly many pages the task links to :/ More precisely, the first thing the task asks me to do regarding the pages meant for translation is to follow the steps for migration: https://commons.wikimedia.org/wiki/Commons:Preparing_a_page_for_translation [06:22:09] mooeypoo: Honestly, I still have no idea how it works [06:22:22] But I'm not exactly sure how to go about carrying out those instructions. [06:22:27] which is probably not very reassuring to YuGin [06:22:29] It's magic! [06:22:43] hang on, there's a way, there's a way. I think I found a tutorial actually [06:22:51] bawolff: yes? [06:22:59] mooeypoo: And I even volunteered to fix the make TimedText work with translate extension bug, so I should really figure it out [06:23:05] hah "The effects will be permanent, so if you don't want to learn how to use it, please stop reading now." [06:23:08] love it. [06:23:17] Nemo_bis: YuGin is looking for help with translate, and we're all useless :) [06:23:19] Hmm, I have that page open too [06:23:37] hm that seems to explain how to translate, not so much how to add new pages to the translation tool [06:24:00] oo! [06:24:01] https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_example [06:24:08] #mediawiki-i18n [06:24:11] err [06:24:16] Nemo_bis: s/he claimed the gci task that you're listed as mentor on [06:24:25] yeah, read scrollback now [06:24:36] I meant to say, "Also, you should go there #mediawiki-i18n [06:25:09] YuGin: have you seen the list of pages to choose among? is that unclear? [06:25:32] Nemo_bis: Yes, I have to choose the pages for translation from there, right? [06:25:33] (First of all, thanks for being here and for claiming this task!) [06:25:44] Yep [06:26:08] If something doesn't work in the instructions we can improve them [06:26:20] Ok, then the next step is to 'follow the steps for migration' which are given in the link https://commons.wikimedia.org/wiki/Commons:Preparing_a_page_for_translation [06:26:30] (You're welcome :P) [06:27:10] Yes, I linked that one because it's shorter than something else I wrote, even though it's not in the actual docs [06:27:41] And that's where I'm a little confused- one of the instructions is to 'Prepare the page for translation' which would be things like the 'Page Translation Example' link posted by mooeypoo above? [06:28:06] The two tutorials should not take more than 10 minutes each, the reference manual for page translation is highly advisable but you can also read is while you encounter things... [06:28:46] But before that, there are things such as 'assess whether you are capable of migrating existing translations to the new sytem' and 'Move all existing translations to the corresponding subpages', but I can't seem to find the corresponding tutorials for those [06:28:55] Prepare the page for translation = Following steps at https://commons.wikimedia.org/wiki/Commons:Preparing_a_page_for_translation [06:29:50] Move all existing translations to the corresponding subpages = Follow the translator tutorial to perform the last step of https://commons.wikimedia.org/wiki/Commons:Preparing_a_page_for_translation [06:30:10] assess whether you are capable of migrating existing translations to the new sytem = don't choose too big a page to start with [06:30:29] (03CR) 10Nikerabbit: resourceloader: Make sure hashmtime cache key is different by language (033 comments) [core] - 10https://gerrit.wikimedia.org/r/99010 (owner: 10Krinkle) [06:31:03] Ah, and by translator tutorial you mean the Translation Examples? [06:32:29] yes [06:33:00] that's to familiarise yourself with the translation interface where you'll be inputting text [06:33:24] (there are also harder ways to do it, but no need to use those now :P) [06:34:00] So to recap: [06:34:12] 1) Select pages [06:35:14] 2) Carry out preparation for translation following the tutorial https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_example [06:35:46] 3) Mark for translation [06:36:17] Yep, (3) requires a translation admin (e.g. me) until you become one :) [06:36:59] Hmm, but the next step on the Melange page is 'copy the old translations to corresponding units with Special:Translate' [06:37:13] Don't forget to also follow the melange directions (I think I remember seeing something about linking to the pages you completed ?) [06:37:54] yeah but that one can worry later [06:38:04] Ah. Ok :) [06:38:13] I was replying to mooeypoo [06:38:24] * mooeypoo nods [06:38:28] Oops [06:38:35] YuGin: yes, the old translations are in the /fr /it etc. subpages [06:38:42] sorry, I'll shut up and let you do the guiding :) [06:39:02] mooeypoo: your reactions to the help pages were useful too :) [06:39:31] And where do I find those subpages? [06:39:38] :D [06:40:00] YuGin: they'll linked from the source page [06:40:49] e.g. https://www.mediawiki.org/wiki/Help:Bots#footer [06:41:15] Hmm, ok [06:41:25] like, https://www.mediawiki.org/wiki/Help:Bots/pt [06:41:58] there are some differences between the two pages, but usually proper names and markup are enough to identify what's what [06:42:21] so you just take what was there and insert it in Special:Translate as translation [06:43:12] Right, I think I get it (for now) [06:43:38] https://www.mediawiki.org/wiki/Help:Bots/de is too different and there's not much content so the wisest thing to do may be dropping it [06:44:36] YuGin: great; surely the second time you take this task will be easier :) [06:44:55] Another thing- the tutorial says 'This tutorial assumes that the Translate extension is already installed and configured' [06:45:09] mediawiki.org has it :) [06:45:57] sometimes we have some eager translators trying to start using Translate as in the tutorial before the extension is there and they don't have great success :P [06:46:58] (03PS2) 10Nikerabbit: Make explicit plural forms work for Russian [core] - 10https://gerrit.wikimedia.org/r/99029 (owner: 10Santhosh) [06:47:35] (03CR) 10Brian Wolff: Optimized LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [06:48:11] (03CR) 10Nikerabbit: [C: 032] Make explicit plural forms work for Russian [core] - 10https://gerrit.wikimedia.org/r/99029 (owner: 10Santhosh) [06:52:09] (03Merged) 10jenkins-bot: Make explicit plural forms work for Russian [core] - 10https://gerrit.wikimedia.org/r/99029 (owner: 10Santhosh) [06:52:56] YuGin: let me know when you've chosen the first page/you've prepared it, so that I mark (approve) it [06:53:26] Nemo_bis- yup, I will. [06:57:40] (03PS1) 10Werdna: Refine paranoid SQL handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99034 [06:57:42] (03PS1) 10Werdna: Abstract out DbStorage superclass from BasicDbStorage and RevisionStorage. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99035 [06:57:44] (03PS1) 10Werdna: Merge branch 'gerrit/98995/3' into 2013/flow/db-storage-abstraction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99036 [06:57:46] (03PS1) 10Werdna: Allow ObjectManager to fall back to querying backend storage when no index is available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 [06:57:48] (03PS1) 10Werdna: [WIP] Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 [06:57:57] YuGin, good luck, and welcome! [06:58:18] (03CR) 10Werdna: [C: 04-2] "Merge commit placeholder" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99036 (owner: 10Werdna) [06:59:00] (03CR) 10Legoktm: Clean up global state when job finishes (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94685 (owner: 10Legoktm) [07:01:28] (03PS2) 10Aaron Schulz: Converted html cache updates to use BacklinkJobUtils [core] - 10https://gerrit.wikimedia.org/r/98067 [07:07:25] (03PS2) 10Werdna: [WIP] Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 [07:24:19] Nemo_bis, to carry out my task, do I have to install Wikimedia (or use a hosting service), install the translation extension on that, and then carry out the work in that particular wiki? [07:24:39] nooo [07:24:44] all happens on mediawiki.org [07:24:49] Ah... [07:24:58] Been barking up the wrong tree for the past half an hour :/ [07:25:08] :< [07:25:48] In that case, could you enable my mediawiki account? I registered a while ago but haven't received email confirmation that my account has been created yet. [07:26:35] YuGin: there's no need to enable it... what's the username? [07:26:48] 'yugin' [07:27:17] unless you registered before 2008, nope [07:28:21] (03CR) 10Siebrand: "How should we proceed with these patches?" [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [07:28:34] such a username exists only on ru, sr, uk, zh Wikipedias [07:28:36] Ok, I sorted it out- turns out the one I registered for earlier was at translatewiki.net [07:28:42] hah :) [07:29:57] approved your request there [07:31:04] and welcome on mediawiki.org too [07:31:41] after your first edit, you can go to special:mergeaccount and your account will work on all Wikimedia wikis (except the four above) [07:33:35] Great, thanks. [07:39:53] Nemo_bis, should I not be using pages that already have 'This page contains changes which are not marked for translation' at the top of the page? [07:40:05] Are those already pages that other people are doing the same task on? [07:42:18] YuGin: in theory not, if they're following instructions... link? [07:42:42] For example, https://www.mediawiki.org/wiki/Help:Bots [07:44:05] (03PS6) 10Aaron Schulz: Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 [07:47:03] siebrand, why ignored? [07:47:53] yurik: "ignored" means that even if people add a translation for a message, Translate will not export it. That's what we do with empty messages like those. [07:48:12] but i do want people to add it there? [07:48:21] yurik: Hmm? [07:48:37] yurik: where is "there"? [07:48:37] i mean - this way we can have different "hello world" in different languages [07:48:44] (03PS1) 10PleaseStand: Remove unused messages 'edit-externally' and 'edit-externally-help' [core] - 10https://gerrit.wikimedia.org/r/99039 [07:48:50] (03PS1) 10PleaseStand: Remove unused message 'wrong_wfQuery_params' [core] - 10https://gerrit.wikimedia.org/r/99040 [07:48:55] (03PS1) 10PleaseStand: Remove unused message 'qbspecialpages' [core] - 10https://gerrit.wikimedia.org/r/99041 [07:49:00] * Aaron|home wonders what DBAccessBase is for [07:49:05] people at translate wiki would enter "hello to Wiki Tajik, here is some famous quote" [07:49:27] Aaron|home, all your DB base accessible to us? [07:49:51] siebrand, ^^ [07:49:52] yurik: why? That is a local wiki customisation, isn't it? Not a string that's not present in English, but present in some other languages (?) [07:50:09] siebrand, it could be [07:50:25] yurik: It [07:50:32] like we choose not to have it in english, but we will configure it for tajik - each community would decide for itslef [07:50:33] yurik: It's a very unusual use case. [07:51:11] siebrand, this is what various wiki communities do - for example they decide how their front page would look like [07:51:21] here we just have one line of customizations, not a full page :) [07:51:42] yurik: their front page is created on their local wiki, not in the localisation of a generic product. [07:52:08] siebrand, this generic product is only useful to wikipedia and sister projects [07:52:14] simply by nature of zero [07:52:33] zero means - mobile carrier decides to give access to wikipedia for free [07:52:47] yurik: I know what the product does. [07:52:54] so who else other than us (and facebook / twitter) would ever want that ? [07:53:09] but facebook for some reason doesn't want to use mediawiki :( [07:53:28] yes, that's too bad. [07:53:39] Their discussion system is slightly better than ours, though. [07:53:50] Same goes for notifications, I guess. [07:54:56] YuGin: on that page it was added by an unregistered user, ignore [07:55:15] hence - my thought is to have one custom message for french -- Bonjure {{SITENAME}},
Tu deviens responsable pour toujours de ce que tu as apprivoisé
[07:55:33] Nemo_bis- oh, ok. [07:55:39] and no, siebrand, i think our product goes much further :) [07:55:56] YuGin: we had another user who tried something and disappeared, might be him :) [07:56:54] siebrand, that's why I want the QQQ to be very descriptive for that one - its very unusual [07:57:35] it will frame the requirement, but leave the community to decide how to do it [07:58:07] Nemo_bis, that must explain it then... [07:58:41] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [07:58:58] YuGin: just check the history, if there are no edits in the last few hours do what you want [07:59:20] Ok, thanks. [07:59:41] (03CR) 10Siebrand: [C: 04-1] "Entries in maintenance/language/messages.inc are missing for new keys. See http://www.mediawiki.org/wiki/I18n#Adding_new_messages for deta" [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [08:01:40] (03CR) 10Siebrand: [C: 032] Remove unused message 'qbspecialpages' [core] - 10https://gerrit.wikimedia.org/r/99041 (owner: 10PleaseStand) [08:02:21] (03PS2) 10Tpt: Use as image name the root title of the page [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98968 [08:02:54] (03CR) 10Tpt: [C: 032] "Minor change that fix a big issue" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98968 (owner: 10Tpt) [08:02:55] (03CR) 10Siebrand: [C: 032] Remove unused message 'wrong_wfQuery_params' [core] - 10https://gerrit.wikimedia.org/r/99040 (owner: 10PleaseStand) [08:03:38] (03Merged) 10jenkins-bot: Use as image name the root title of the page [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98968 (owner: 10Tpt) [08:04:41] (03Merged) 10jenkins-bot: Remove unused message 'qbspecialpages' [core] - 10https://gerrit.wikimedia.org/r/99041 (owner: 10PleaseStand) [08:05:09] (03CR) 10Siebrand: [C: 032] "Nice finds. Thanks." [core] - 10https://gerrit.wikimedia.org/r/99039 (owner: 10PleaseStand) [08:05:52] (03PS5) 10Aaron Schulz: Added support for purging backlinks in the wiki farm [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 [08:07:00] (03Merged) 10jenkins-bot: Remove unused message 'wrong_wfQuery_params' [core] - 10https://gerrit.wikimedia.org/r/99040 (owner: 10PleaseStand) [08:07:10] (03PS1) 10Tpt: Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99042 [08:07:54] QUIT [08:10:07] (03Merged) 10jenkins-bot: Remove unused messages 'edit-externally' and 'edit-externally-help' [core] - 10https://gerrit.wikimedia.org/r/99039 (owner: 10PleaseStand) [08:12:41] (03CR) 10Siebrand: "Is this supposed to be a library, or an integrated part of MediaWiki? If it's supposed to be a JavaScript library, "also used by MediaWiki" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [08:15:43] YuGin: was the page on Commons useful to you, or should I just link the two tutorials next time? [08:16:51] Nemo_bis, the page on Commons was a little confusing. I think the two tutorials should be enough. [08:17:57] YuGin: ok thanks; that was my initial opinion too, but I suspected that I was overestimating the quality of the help pages created by us/me [08:18:22] test failed, sorry [08:18:51] Nemo_bis, I'm having a little trouble accessing the page showing the translation units of the article [08:19:34] Clicking 'This page contains changes which are not marked for translation' brings me to 'Differences between revisions' page [08:20:00] When according to the tutorial I should be getting the translation units... [08:22:56] YuGin: that's because you're not a translation admin... "prepare the page for translation" meand adding tags etc.; "marking" is something only translation admins can to [08:23:10] if the page is ready, I can mark it [08:24:01] Oh, I see- so all I can do before I need an admin to mark it is to choose a suitable page and add the tags? [08:24:54] In any case, the page I picked was https://www.mediawiki.org/wiki/Accessibility [08:29:38] (03PS1) 10Aaron Schulz: Made Title cache use MapCacheLRU [core] - 10https://gerrit.wikimedia.org/r/99043 [08:30:57] (03CR) 10Santhosh: [C: 032] mw.language.convertPlural: Check if matching form exists [core] - 10https://gerrit.wikimedia.org/r/91563 (owner: 10PleaseStand) [08:31:42] YuGin: well, on most pages it's a bit harder than that, but yes, most of the work is after the page is marked [08:32:20] By 'harder', what sort of extra steps are you talking about? [08:32:53] YuGin: for instance, here the marking you did is not good enough :) that would put almost the whole page in a single unit [08:33:26] Oh- so the tags are what decide the units? [08:33:37] I didn't know that... [08:33:40] tags and newlines [08:33:59] yeah, it's why you are supposed to read the page translation manual :P but you can do so in the process [08:34:05] YuGin: like this https://www.mediawiki.org/w/index.php?title=Accessibility&diff=835705&oldid=835703 [08:34:45] (03Merged) 10jenkins-bot: mw.language.convertPlural: Check if matching form exists [core] - 10https://gerrit.wikimedia.org/r/91563 (owner: 10PleaseStand) [08:35:02] (03CR) 10Aaron Schulz: [C: 032] Set visibility on class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [08:36:17] YuGin: and this https://www.mediawiki.org/w/index.php?title=Accessibility&diff=835707&oldid=835705 [08:36:57] (03CR) 10Aaron Schulz: Clean up global state when job finishes (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94685 (owner: 10Legoktm) [08:38:47] Nemo_bis- ok. What's the difference between newlines and tags? [08:38:57] (03Merged) 10jenkins-bot: Set visibility on class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [08:41:22] (03PS1) 10Tpt: Fix an error in Page content unserialization [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99044 [08:41:23] (03CR) 10jenkins-bot: [V: 04-1] Fix an error in Page content unserialization [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99044 (owner: 10Tpt) [08:41:29] YuGin: newline is one character, many :) the tag is more precise, but newlines are often good enough because if a page has proper spacing Translate guesses well [08:42:31] if a page is not too complex, using will be enough; if a page has a lot of mixed translatable and untranslatable text, you need to be like a surgeon [08:42:40] I see. And as a general rule of thumb, should each bullet be a single unit? [08:42:58] Or is that only if each bullet is a sufficiently complex sentence? [08:43:37] bullets are just formatting elements, I suggest you to follow linguistic concepts like sentences [08:43:49] (03PS1) 10Tpt: no message [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99045 [08:43:59] I can put a long sentence in a bullet or spread it across a dozen bullets, but I always must translate it as a whole [08:44:09] Oh, ok. Thanks, I'll get back to tagging that page. [08:44:13] (03Abandoned) 10Tpt: no message [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99045 (owner: 10Tpt) [08:45:12] Oh, and say I were to have a sentence with a name of a person in it [08:45:22] (03PS2) 10Tpt: Fix an error in Page content unserialization [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99044 [08:45:44] Do I place a tag at the start of the person's name and then at the end of it so as to not mark the name for translation? [08:49:17] (03PS1) 10Siebrand: Update ternary notation [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99047 [08:51:26] YuGin: you could do that, but it's not worth it; plus, it's possible some languages must transliterate the name [08:51:38] (03PS2) 10Siebrand: Update ternary notation [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99047 [08:52:19] I think it's worth excluding from translation only 1) things which would really break if changed (e.g. some HTML), or 2) things which really must not be translated [08:53:11] (03PS1) 10Siebrand: Update ternary notation [core] - 10https://gerrit.wikimedia.org/r/99048 [08:53:12] Ok. By the way, I spotted what's probably a typo in that page: '...the DZB arteed to look at Wikipedia's skin' [08:53:27] (arteed --> agreed) [08:53:34] Nikerabbit: are you there? [08:53:50] Nemo_bis- Should I change it? [08:53:52] YuGin: yeah, fix everything you find [08:54:20] you don't need to ask permission to change stuff, on wikis ;) [08:54:28] :P [08:55:05] (03CR) 10Matthias Mullie: [C: 032] Global variable to disable flow's memcache usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 (owner: 10EBernhardson) [08:55:06] For this sentence: 'CSS uses a:hover but is missing a:focus' [08:55:14] Presumably [08:55:31] 'a:hover' and 'a:focus' can't/shouldn't be translated? [08:55:42] AaronSchulz: Quick reviews based on your spotting "? :" instead of "?:": https://gerrit.wikimedia.org/r/#/c/99046/ https://gerrit.wikimedia.org/r/#/c/99047/ https://gerrit.wikimedia.org/r/#/c/99048/ [08:55:48] matanya: maybe [08:55:48] And therefore I should wrap them outside of the tags? [08:55:55] yes, but you can let the translator decide it [08:56:19] the more tags you add, the more manual work there is later :) [08:56:26] Ahh. Ok. [08:56:27] Nikerabbit: i'm refactoring stuff in puppet, i can't understant what you did in modules/solr/manifests/init.pp [08:56:40] Nikerabbit: have a sec to explian? [08:56:45] matanya: this is translatewiki.net puppet or wmf puppet? [08:56:53] Nikerabbit: wmf [08:57:04] I have meeting in 5 mins [08:57:19] Nikerabbit: it can wait [08:57:37] Nikerabbit: will you be avialable latter? [08:57:52] matanya: but basically it install backported solr and jetty and shuffles some configuration files around [08:57:55] matanya: probably [08:58:31] so Nikerabbit please ping me when you have time. i have two or three questions. [08:59:17] (03CR) 10Aaron Schulz: [C: 032] Set visibility on class properties in LocalFile.php [core] - 10https://gerrit.wikimedia.org/r/97350 (owner: 10Siebrand) [09:00:18] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on class properties in LocalFile.php [core] - 10https://gerrit.wikimedia.org/r/97350 (owner: 10Siebrand) [09:00:45] (03CR) 10Aaron Schulz: [C: 032] Update ternary notation [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99047 (owner: 10Siebrand) [09:00:47] (03Merged) 10jenkins-bot: Update ternary notation [extensions/BookManagerv2] - 10https://gerrit.wikimedia.org/r/99047 (owner: 10Siebrand) [09:01:17] (03CR) 10Aaron Schulz: [C: 032] Update ternary notation [core] - 10https://gerrit.wikimedia.org/r/99048 (owner: 10Siebrand) [09:01:50] hashar: It looks like https://gerrit.wikimedia.org/r/97350 may be blocked on something CI related. [09:02:24] hashar: Ignore that. [09:02:42] AaronSchulz: Have to fix https://gerrit.wikimedia.org/r/97350. PHP Fatal error: Access level to LocalFile::$repo must be public [09:03:32] huh, I guess netbeans didn't detect that [09:03:43] whatever that is can use getRepo() [09:04:02] Nemo_bis, I have finished preparing the page: https://www.mediawiki.org/wiki/Accessibility [09:09:43] YuGin: ok, now strike its title on https://www.mediawiki.org/wiki/Project:Language_policy/Migration_list please; that sends me an email notification [09:12:36] What do you mean by strike? [09:13:16] enclose the text in [09:14:26] AaronSchulz: Weirdly enough, PHPStorm didn't get that either. [09:14:38] Done. Interesting how a text strikeout can trigger an email notification... [09:14:57] YuGin: every edit does, because I watched the page and set the appropriate preferences [09:15:25] I tricked some other translation admins in watching the page to help me help students like you :P [09:16:28] YuGin: now are you able to find the link you have to add on melange? [09:17:25] Isn't that supposed to only come at the very end? [09:18:14] YuGin: yes, but this page actually has no translations to import (my mistake), so you jump to the end [09:18:33] the list is a bit rough [09:19:59] In that case, no, I'm not sure of where to find the link [09:20:29] YuGin: have you clicked the example link? [09:20:40] So what you're saying is that I would usually have to transfer over existing translations at this point, but in this case there are none? [09:20:40] i.e. https://www.mediawiki.org/w/index.php?title=Special%3AMessageGroupStats&x=D&group=page-Help%3AScreenshots&suppressempty=1 [09:21:14] Hmm, yes, I saw that link but I thought there was supposed to be one for each page and couldn't find it [09:21:14] YuGin: yes, but it was a big page and you helped me a lot with the instructions, so we'll consider the task done for this time [09:21:49] :D [09:21:50] there is a dropdown at the top if you wish; or other methods [09:21:54] Oh, I found the page I needed [09:21:58] (03Merged) 10jenkins-bot: Native digits on 'notification-page-linked-bundle' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97507 (owner: 10Ebrahim) [09:22:15] It says 'Nothing to show for requested statistics' [09:22:23] That's because there are no translations currently? [09:23:37] yes, uncheck the last checkbox [09:23:53] so at least it says the number of units [09:24:03] (03CR) 10Siebrand: [C: 04-1] i18n: Localized user right labels (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 (owner: 10Ebrahim) [09:24:30] Ok. Wow, that's an extensive list [09:24:50] yep, MediaWiki supports a few hundreds languages [09:25:59] Well, I've submitted the link to the melange task and mark it as complete [09:26:02] *marked [09:26:02] (03CR) 10TTO: [C: 031] "Review progress is glacial in this repository..." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/83414 (owner: 10Rillke) [09:27:36] YuGin: thanks, I'll get it accepted; if you want you could tell me if the instructions are clearer this way: https://www.mediawiki.org/w/index.php?title=Talk:Google_Code-in&diff=835788&oldid=834363 [09:27:52] or you can proceed to repeat the task for the second time, it should be much easier :) [09:28:30] Yes, I'll claim another one :) [09:29:31] (03PS1) 10Nikerabbit: Add Translate-meta.wikimedia.org-linux-firefox [selenium] - 10https://gerrit.wikimedia.org/r/99054 [09:29:51] I think the new instructions are a lot clearer :) [09:30:07] hey hashar, when you have a moment i need some help with https://gerrit.wikimedia.org/r/#/c/98684/. i need to sort out the config for the BetaCluster, and later for production, for GWToolset. marktraceur started the commit, but i'm not sure how to set-up the backend config. i have this idea for the moment http://pastebin.com/WwHtA6tb. the fb should be protected and not viewable by the public. i'm relying on FileBackend->prepare() to take care of it by pas [09:30:07] in noAccess and noListing. would the config in the paste bin work or is there something else i need to set? [09:30:51] YuGin: great! :) [09:33:44] (03PS1) 10Hashar: rm old MediaWiki-GIT-Fetching job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99055 [09:33:59] (03CR) 10Hashar: [C: 032] rm old MediaWiki-GIT-Fetching job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99055 (owner: 10Hashar) [09:34:16] (03PS2) 10Hashar: rm old MediaWiki-GIT-Fetching job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99055 [09:34:20] (03PS2) 10Nikerabbit: Add Translate-meta.wikimedia.org-linux-firefox [selenium] - 10https://gerrit.wikimedia.org/r/99054 [09:34:22] (03CR) 10Hashar: [C: 032] rm old MediaWiki-GIT-Fetching job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99055 (owner: 10Hashar) [09:34:26] (03Merged) 10jenkins-bot: rm old MediaWiki-GIT-Fetching job [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99055 (owner: 10Hashar) [09:39:11] dan-nl: hey [09:39:34] hey [09:39:40] dan-nl: so we use feature flags to enable extensions / features [09:39:47] that is wmgUseGWToolset defined in InitialiseSettings-labs.php [09:40:32] in CommonSettings-labs.php the if( wmgUseGWToolset ) { /** some code **/ } would thus only be executed for which the flag has been set [09:40:48] that is where you should put your configuration [09:41:25] I am not sure the feature flag is available in filebackend-labs.php though [09:41:34] (03PS1) 10Siebrand: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/99056 [09:41:37] YuGin: btw, what languages do you speak? you wrote that you're from UK and also speak Chinese, isn't it perhaps the opposite? [09:42:07] dan-nl: that is more or less what Bryan Davis replied on the gerrit change. [09:43:29] hashar, so in InitialiseSettings-labs.php i need to add a array entry 'wmgUseGWToolset' => array( 'default' => true ) ? [09:43:50] dan-nl: that is what Mark did : https://gerrit.wikimedia.org/r/#/c/98684/1/wmf-config/InitialiseSettings-labs.php,unified [09:44:13] ah, now it's getting clearer [09:45:07] hashar, and then in https://gerrit.wikimedia.org/r/#/c/98684/1/wmf-config/CommonSettings-labs.php,unified i need to add what i have in the paste binhttp://pastebin.com/WwHtA6tb ? [09:45:14] another interesting feature is something like: require( getRealmSpecificFilename( "$wmfConfigDir/jobqueue.php" ) ); [09:45:22] but that would be for later [09:45:32] dan-nl: yup exactly [09:46:06] hashar, then my question has to do with filebackend-labs.php and how to “properly” add the FileBackend resource the extension needs [09:46:20] i'm still not that familiar with the fb set-up [09:47:02] i guess i can get rid of the if statement and just declare the backend set-up [09:47:17] but i need help figuring out what that config should be for the beta cluster [09:47:36] ahh [09:47:40] filebackend well... [09:47:44] I am not very familiar with it [09:47:58] oh no … AaronSchulz said you'd know why to do ;) [09:48:05] at least on beta we don't have swift, so the files are saved on a shared NFS export [09:48:22] yeah Aaron is overestimating my competencies :-D [09:48:46] Nemo_bis- I believe I wrote 'English-UK' as my primary language? That's because I'm from Singapore and we speak British English here. Chinese is my secondary language. [09:49:14] i see that in the current filebackend-labs.php file the local fb has an entry for /mnt/upload7/private/archive/$site/$lang [09:49:24] YuGin: ah, ok :) timezone didn't match, didn't think of singapore :) [09:49:52] do you know if i could use that for a "secure" fb container path? [09:50:29] who would know which directories in the nfs have been protected or how would i protect a new fs directory via apache config? [09:51:00] I have Zero idea how the protection is handled [09:51:08] oh boy [09:51:10] on beta, that might not even be protected properly [09:51:15] but we can find out :D [09:51:15] any idea of who might? [09:51:48] cool, how do we find out :) [09:52:52] (03PS1) 10Hashar: some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/99059 [09:53:03] (03CR) 10Hashar: [C: 032 V: 032] some more extensions [extensions] - 10https://gerrit.wikimedia.org/r/99059 (owner: 10Hashar) [09:54:15] dan-nl: I guess the content in private is not exposed directly [09:54:29] but served via MediaWiki which would handle the authentication [09:54:56] k, i can try just using that basis for the container path and see what happens [09:55:10] indeed :] [09:55:15] is there a way we could test it out today? [09:55:31] y [09:55:32] yup [09:55:39] just have to get the change reviewed / merged in [09:55:44] it will deploy on the beta cluster automatically [09:56:03] i'm still working with csteipp_afk on the security review, is it still possible to move the extension to the beta cluster? [09:56:03] and then you can look at http://en.wikipedia.beta.wmflabs.org/ to play with it [09:56:31] you probably want to have the security review to pass first indeed [09:56:31] ah i see … guess i'd need marktraceur and a few others to approve that gerrit commit first [09:56:37] ok [09:57:17] i'll try setting up the config and then see where csteipp_afk is at with the review. there are still a few outstanding gerrit commits we need to finish off first [09:57:52] do you happen to have any ideas on what the proper $wgFileBackends config should be? [09:58:40] hashar: or someone else who might? [09:59:42] i'm curious if class FSFileBackend would work or if i need to use a different type of fb [10:01:01] dan-nl: I am not sure, I always ends up being terribly confused by its configuration [10:01:17] I think you want to tweak $wgLocalFileRepo and add a new zone there [10:02:00] yes, that's pretty much where i'm at atm .. cool, at least we have the same thought on that. who else would know more definitively how to set it up? [10:02:08] Aaron definitely [10:02:23] you can have a look at the $wgLocalFileRepo defined in wmf-config/filebackend.php (that is the one f rom production) [10:02:28] off … he told me to ask you ... [10:02:33] and add some bits in filebackend-labs.php [10:02:47] k, i'll see what i can sort out … thanks! [10:02:49] yeah as I said, Aarond is overestimating my knowledge of filebackend setup :] [10:02:54] :) [10:03:02] in prod we have "thumbs" zone [10:03:08] maybe we need a gwtoolset zone configured [10:03:25] coffeeeee [10:26:16] (03CR) 10Siebrand: [C: 032] Make the deletion-related messages for courses and institutions clear [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98874 (owner: 10Ragesoss) [10:26:28] (03Merged) 10jenkins-bot: Make the deletion-related messages for courses and institutions clear [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98874 (owner: 10Ragesoss) [10:30:45] (03CR) 10Siebrand: On Special:Contributions, mention EP roles (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98183 (owner: 10AndyRussG) [10:39:10] (03PS1) 10Hashar: phantomjs tests put logs in /log/ now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99064 [10:39:31] (03CR) 10Siebrand: Ported some initial files from Zero extension (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [10:39:53] (03CR) 10Hashar: [C: 032] phantomjs tests put logs in /log/ now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99064 (owner: 10Hashar) [10:40:12] (03Merged) 10jenkins-bot: phantomjs tests put logs in /log/ now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/99064 (owner: 10Hashar) [10:42:42] (03CR) 10Yurik: Ported some initial files from Zero extension (031 comment) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [10:44:23] (03CR) 10Nikerabbit: [C: 031] "I assume that the overheard of using a class for this is insignificant." [core] - 10https://gerrit.wikimedia.org/r/99043 (owner: 10Aaron Schulz) [10:48:31] (03PS3) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [10:50:54] (03PS1) 10Physikerwelt: Generate Content-MML XQueries [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/99066 [10:58:52] (03CR) 10saper: "This breaks PostgreSQL :(" [core] - 10https://gerrit.wikimedia.org/r/42278 (owner: 10Umherirrender) [11:06:40] (03PS1) 10saper: Restore recentchanges.rc_cur_time (breaks psql) [core] - 10https://gerrit.wikimedia.org/r/99068 [11:13:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [11:17:51] hashar, for the GWToolset deploy to the BetaCluster, do you know if i also need to add $IP/extensions/GWToolset/GWToolset.php to wmf-config/extension-list-labs.php file? [11:21:06] dan-nl: yeah most probably [11:21:18] that is used by the l10n script that generate the message file [11:21:22] maintenance/mergeMessageFiles.php or somethin [11:21:23] g [11:21:32] thanks [11:21:36] failing to do so and the messages from your extension will not be generated in the .cdb [11:21:37] good catch! [11:21:44] I am off for lunch bb in ~ 1 hour [11:29:56] (03CR) 10Matthias Mullie: [C: 032] Escape $action in hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99019 (owner: 10Bsitu) [11:30:05] (03Merged) 10jenkins-bot: Escape $action in hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99019 (owner: 10Bsitu) [11:34:38] (03CR) 10Siebrand: Do language formatting on numbers in [[Special:TimedMediaHandler]] (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97999 (owner: 10Brian Wolff) [11:38:29] (03CR) 10Parent5446: [C: 04-1] "The real issue here is that in maintenance/postgres/tables.sql the rc_cur_time column does not have a DEFAULT like it does in the main MyS" [core] - 10https://gerrit.wikimedia.org/r/99068 (owner: 10saper) [11:39:06] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Nice. I think you're probably (one of) the first to add a parameter for a dropdown." [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [11:40:19] (03CR) 10saper: "I agree that we should remove the field; the problem is that the current way forward does not work as expected." [core] - 10https://gerrit.wikimedia.org/r/99068 (owner: 10saper) [11:49:50] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. See inline comment and Benny's comment about missing qqq." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [11:58:21] YuviPanda: There? [12:09:37] * siebrand tickles YuviPanda  [12:09:53] (03CR) 10Zfilipin: "Fixed path in main readme file to selenium readme file" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [12:11:14] (03CR) 10Zfilipin: [C: 031] Clean up test documentation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [12:11:43] (03CR) 10Theopolisme: "(comment #7 by Tisza Gergő on the linked bug)" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [12:12:57] (03CR) 10Siebrand: [C: 04-1] "Trailing whitespace in all added files. Please remove." [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 (owner: 10leucosticte) [12:13:28] * Niharika raises a hand to ask a question. I am using git-review from vagrant(hosted on Windows). When I clone a repo, it gets cloned into vagrant and doesnt appear on the host machine. Any workaround? [12:15:06] (03CR) 10Siebrand: [C: 04-1] "Quick L10n review." (031 comment) [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/28799 (owner: 10leucosticte) [12:16:30] (03CR) 10Zfilipin: [C: 032] Prefer double-quoted strings in Ruby code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [12:17:21] (03CR) 10Zfilipin: [C: 032] Prefer double-quoted strings in Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [12:17:23] (03Merged) 10jenkins-bot: Prefer double-quoted strings in Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [12:18:08] (03CR) 10Siebrand: [C: 04-1] "Quick L10n review." (033 comments) [extensions/IssueTracker] - 10https://gerrit.wikimedia.org/r/91565 (owner: 10leucosticte) [12:21:27] (03PS1) 10Hashar: qa/browsertests now has gate-and-submit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99071 [12:21:43] (03PS2) 10Hashar: qa/browsertests now has gate-and-submit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99071 [12:22:14] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n looks fine. There are some indentation issues that should be resolved." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [12:22:21] (03CR) 10Hashar: [C: 032] qa/browsertests now has gate-and-submit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99071 (owner: 10Hashar) [12:23:23] (03Merged) 10jenkins-bot: qa/browsertests now has gate-and-submit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/99071 (owner: 10Hashar) [12:24:05] (03PS1) 10Tpt: Normalize level title [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99072 [12:38:04] (03CR) 10Phe: [C: 031] "I've not searched why addCategory() require normalized title now, it was working a few days ago w/o this piece of code, but actually a val" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99072 (owner: 10Tpt) [12:45:43] (03CR) 10Physikerwelt: [C: 032 V: 032] Generate Content-MML XQueries [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/99066 (owner: 10Physikerwelt) [12:49:43] (03CR) 10Siebrand: "I'd very much prefer adding the external dependency, because it means other people will fix our code. Duplicating functionality, and keepi" [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [12:51:02] (03PS1) 10Hashar: mw-install-sqlite: always create sqlite datadir [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99080 [12:51:11] (03CR) 10Hashar: [C: 032] mw-install-sqlite: always create sqlite datadir [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99080 (owner: 10Hashar) [12:51:15] (03Merged) 10jenkins-bot: mw-install-sqlite: always create sqlite datadir [integration/jenkins] - 10https://gerrit.wikimedia.org/r/99080 (owner: 10Hashar) [12:51:43] hashar: Do configuration changes like https://gerrit.wikimedia.org/r/#/c/99070/ require a deployment window, or can they be deployed at any time? [12:53:06] siebrand: depends on what the change does :D [12:53:32] if we are 101% sure it is not going to have any impact, we can merge them whenever we want I guess [12:55:27] i have no clue what are the consequences of enabling .po export myself [12:58:47] (03PS5) 10Netbrain: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 [13:11:24] hashar: Feature has been enabled on translatewiki.net since forever. It provides users with a download for offline translation, that can later be imported. [13:15:06] (03CR) 10Ebrahim: "Just MediaWiki default rights or also some common created right on Wikimedia?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 (owner: 10Ebrahim) [13:20:01] (03CR) 10Theopolisme: "That's kind of along the lines of what I initially thought as well." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [13:26:51] Hey, I am working on the bug 56121 https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 and I have cloned the extension, the changes are to be made in the MultimediaViewer.i18n.php file, it is to check whether the repository is local and then to add a local message, can someone please help me with it? [13:28:14] (03CR) 10Manybubbles: [C: 04-2] "I think this is more a problem on Cirrus's side then core. Tim's filed Bug 57961 which explains it pretty well. I'll do a bit more diggi" [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/91659 (owner: 10Reedy) [13:31:35] (03PS2) 10Ebrahim: i18n: Localized user right labels [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 [13:39:20] (03PS3) 10Ebrahim: i18n: Localized user right labels [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 [13:46:06] (03CR) 10Siebrand: [C: 031] i18n: Localized user right labels [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 (owner: 10Ebrahim) [13:47:44] (03CR) 10Siebrand: [C: 04-1] Added "search and replace within selection" functionality (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [13:52:42] YuviPanda: Knock knock! [13:53:15] (03CR) 10Bartosz Dziewoński: "I am not able to review this meaningfully, but I think I really like where this is going." [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [13:54:53] My location: Москва, Россия [14:00:31] (03PS1) 10shinjiman: Adding python 3 support for the Makefile.py file for the zhtable [core] - 10https://gerrit.wikimedia.org/r/99086 [14:24:53] Niharika: hey [14:25:10] YuviPanda: Hi. :) [14:25:32] YuviPanda: I had some questions about using gerrit from vagrant, if youŕe free for a moment. [14:26:36] YuviPanda: When I clone a repo using gerrit, it gets cloned into vagrant. How do I move it to the host machine? [14:31:55] Niharika: it is already in your host machine [14:32:12] Niharika: anything under /vagrant is also in the host machine in the folder where you cloned it [14:32:19] it = 'mediawiki-vagrant' [14:32:23] they are shared in both the machines [14:32:40] so when you are doing the cloning, clone it under /vagrant in the vagrant machine [14:33:24] YuviPanda: Okay. I´ll keep that in mind. [14:33:25] Niharika: does that make sense? [14:33:27] :) [14:33:28] Yep. [14:33:31] (03PS1) 10Siebrand: Handle explicit plural forms in custom convertPlural in language classes [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99088 [14:34:30] (03PS1) 10Siebrand: Make explicit plural forms work for Russian [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99090 [14:34:33] hello. Please check http://sourceforge.net/p/kiwix/feature-requests/775/ [14:35:44] (03CR) 10Nikerabbit: [C: 032] Remove unneeded else{} in LogEventsList::userCanBitfield() [core] - 10https://gerrit.wikimedia.org/r/98972 (owner: 10Siebrand) [14:36:29] (03CR) 10jenkins-bot: [V: 04-1] Make explicit plural forms work for Russian [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99090 (owner: 10Siebrand) [14:36:36] (03CR) 10Nikerabbit: [C: 032] Add deprecation warnings for log related methods [core] - 10https://gerrit.wikimedia.org/r/98970 (owner: 10Siebrand) [14:36:42] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Comments inline. Also, please add release notes (just add an entry to the RELEASE-NOTES-1.23 file) and mention other changes in the commit" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [14:37:45] Krinkle|detached: does what i just said on https://gerrit.wikimedia.org/r/98356 (loading site logo via RL patch) make sense? [14:40:12] (03Merged) 10jenkins-bot: Remove unneeded else{} in LogEventsList::userCanBitfield() [core] - 10https://gerrit.wikimedia.org/r/98972 (owner: 10Siebrand) [14:41:30] (03PS4) 10Manybubbles: Clean up test documentation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [14:41:58] (03CR) 10Manybubbles: [C: 032 V: 032] "Rebased and submitting." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [14:42:09] (03Merged) 10jenkins-bot: Add deprecation warnings for log related methods [core] - 10https://gerrit.wikimedia.org/r/98970 (owner: 10Siebrand) [14:43:43] (03CR) 10Siebrand: "This depends on Change-Id: I2a9f93567087babb896999f1214d3c56afc67c96" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/99090 (owner: 10Siebrand) [14:45:49] (03CR) 10Nikerabbit: [C: 032] Update documentation for IndexPager::formatRow() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98973 (owner: 10Siebrand) [14:48:21] (03CR) 10Siebrand: Update documentation for IndexPager::formatRow() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98973 (owner: 10Siebrand) [14:48:47] (03Merged) 10jenkins-bot: Update documentation for IndexPager::formatRow() [core] - 10https://gerrit.wikimedia.org/r/98973 (owner: 10Siebrand) [14:55:24] (03CR) 10Siebrand: "Nice to see you back, Shinjiman. It's been a while. Please let us know if you're up for more involvement. Liangent has a fairly long patch" [core] - 10https://gerrit.wikimedia.org/r/99086 (owner: 10shinjiman) [14:56:10] (03CR) 10Siebrand: [C: 031] Adding python 3 support for the Makefile.py file for the zhtable [core] - 10https://gerrit.wikimedia.org/r/99086 (owner: 10shinjiman) [14:56:35] siebrand: fyi he was locked out from signing up because of how labs works; luckily I emailed him and I found out [14:57:02] Nemo_bis: cool. [14:57:17] Nemo_bis: Chinese firewall? [14:57:55] siebrand: no, nobody can register with usernames which were used in SVN or wikitech gives completely untruthful errors [14:58:26] but now abogott learnt how to create users in those cases, so we've just doubled our capacity to serve such former SVN users :) [14:58:31] (03CR) 10Siebrand: "@Theopolisme Absolutely." [core] - 10https://gerrit.wikimedia.org/r/99021 (owner: 10Theopolisme) [14:59:07] Nemo_bis: right :) [15:04:59] (03PS1) 10Cscott: Release 0.2.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99092 [15:05:29] (03CR) 10Cscott: [C: 032] Release 0.2.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99092 (owner: 10Cscott) [15:06:09] (03CR) 10jenkins-bot: [V: 04-1] Release 0.2.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99092 (owner: 10Cscott) [15:07:55] (03PS1) 10Cscott: Release 0.2.0. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99093 [15:08:53] (03CR) 10Cscott: [C: 032] Release 0.2.0. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99093 (owner: 10Cscott) [15:09:28] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99072 (owner: 10Tpt) [15:10:44] (03Merged) 10jenkins-bot: Normalize level title [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99072 (owner: 10Tpt) [15:11:14] (03Merged) 10jenkins-bot: Release 0.2.0. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/99093 (owner: 10Cscott) [15:14:04] (03CR) 10Addshore: [C: 04-1] Check the spamlist's content format earlier (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97365 (owner: 10Legoktm) [15:15:02] (03CR) 10Addshore: [C: 04-1] Move non-SpecialPage specific functions into MassMessage class (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 (owner: 10Legoktm) [15:16:16] (03CR) 10Phe: [C: 031] Fix an error in Page content unserialization [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99044 (owner: 10Tpt) [15:17:13] (03CR) 10Rtdwivedi: [C: 031] Fix an error in Page content unserialization [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99044 (owner: 10Tpt) [15:21:23] (03CR) 10Tpt: [C: 032] "Reviewed by Phe and Aarti" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99044 (owner: 10Tpt) [15:21:25] (03Merged) 10jenkins-bot: Fix an error in Page content unserialization [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99044 (owner: 10Tpt) [15:29:00] (03CR) 10Bartosz Dziewoński: "Thanks for reviews!" (039 comments) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [15:39:59] (03PS1) 10Tpt: Check that the proofreader is not null in API validation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99098 [15:41:18] (03PS3) 10Bartosz Dziewoński: Refactor RL modules related to Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/98589 [15:43:15] Nikerabbit: There? Iḿ getting this error on running localhost:8080. [15:43:16] ¨Parse error: syntax error, unexpected T_IS_IDENTICAL in /vagrant/mediawiki/extensions/UniversalLanguageSelector/UniversalLanguageSelector.php on line 233 Call Stack: 0.0005 632984 1. {main}() /vagrant/mediawiki/index.php:0 0.0024 633536 2. require('/vagrant/mediawiki/includes/WebStart.php') /vagrant/mediawiki/index.php:46 0.0487 1558904 3. require_once('/vagrant/mediawiki/LocalSettings.php') /vagrant/mediawiki/includes/WebStart.php:136 0.0502 1 [15:43:54] (03CR) 10Bartosz Dziewoński: "Verified: compared login and signup form, on Vector and Monobook, logged in and logged out. Everything looks just like it did before." [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [15:49:11] (03CR) 10Phe: [C: 031] Check that the proofreader is not null in API validation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99098 (owner: 10Tpt) [15:50:09] (03CR) 10Rtdwivedi: [C: 031] Check that the proofreader is not null in API validation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99098 (owner: 10Tpt) [15:50:41] (03CR) 10Tpt: [C: 032] "Thanks both for review" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99098 (owner: 10Tpt) [15:53:08] (03Merged) 10jenkins-bot: Check that the proofreader is not null in API validation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99098 (owner: 10Tpt) [16:01:54] (03PS3) 10Matthias Mullie: [WIP] Add Flow events to Special:Contributions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [16:07:55] when I try to amend an earlier change, by giving git review -d and later adding the change, giving git commit ammends, and doing git review -R , I get almost 10-30 commits, that I hadn't done as outstanding ommits and tells that I am going to submit multiple commits. The first among the list is my own commit. How to fix this ?? [16:09:20] andre__: can you set Andrew Green (AndyRussG) as a default to the cc list for 'MediaWiki extensions > EducationProgram'? [16:09:21] (03CR) 10Matthias Mullie: [C: 04-1] "I have no idea where UUID::getComparisonUUID comes from. Other than that, this patch is ready for review." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99038 (owner: 10Werdna) [16:10:02] ragesoss, done [16:10:15] andre__: thanks! [16:10:19] np [16:11:07] Thanks andre__! [16:12:24] (03CR) 10Jhall: [C: 031] Merging the readme files of other repositories with this one. [selenium] - 10https://gerrit.wikimedia.org/r/98577 (owner: 10Mayankmadan) [16:12:43] (03PS1) 10Siebrand: Update documentation for DatabaseBase::selectRow() [core] - 10https://gerrit.wikimedia.org/r/99131 [16:14:16] (03PS2) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 [16:14:26] (03PS1) 10Siebrand: Update documentation for MediaHandler::getPageDimensions() [core] - 10https://gerrit.wikimedia.org/r/99132 [16:14:55] (03PS1) 10Bartosz Dziewoński: Stop prepending newlines to templates starting with *#;: [core] - 10https://gerrit.wikimedia.org/r/99133 [16:18:44] (03PS1) 10Siebrand: Update documentation for file repo related classes [core] - 10https://gerrit.wikimedia.org/r/99136 [16:20:45] (03PS1) 10Siebrand: Group public and private properties [core] - 10https://gerrit.wikimedia.org/r/99137 [16:22:33] (03CR) 10jenkins-bot: [V: 04-1] Stop prepending newlines to templates starting with *#;: [core] - 10https://gerrit.wikimedia.org/r/99133 (owner: 10Bartosz Dziewoński) [16:22:36] (03PS1) 10Siebrand: Satisfy code analyzer by ensuring $urls is defined [core] - 10https://gerrit.wikimedia.org/r/99139 [16:28:11] (03CR) 10Krinkle: Site logo loaded using UserSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [16:28:26] (03PS1) 10Tpt: No indentation to the first paragraph of a Page: page [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99141 [16:31:57] (03CR) 10Krinkle: Site logo loaded using UserSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [16:32:09] (03PS1) 10Hashar: generalize BitmapHandler::logErrorForExternalProcess [core] - 10https://gerrit.wikimedia.org/r/99142 [16:39:24] (03CR) 10Phe: [C: 031] No indentation to the first paragraph of a Page: page [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99141 (owner: 10Tpt) [16:39:52] (03PS1) 10Manybubbles: Switch search methods to always return status [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99144 [16:39:57] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99141 (owner: 10Tpt) [16:40:08] (03Merged) 10jenkins-bot: No indentation to the first paragraph of a Page: page [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/99141 (owner: 10Tpt) [16:42:26] (03PS1) 10Siebrand: Remove unneeded use of else{} in file repo classes [core] - 10https://gerrit.wikimedia.org/r/99145 [16:43:22] (03PS1) 10Tpt: Update ProofreadPage to master [core] - 10https://gerrit.wikimedia.org/r/99146 [16:43:44] (03CR) 10Chad: "-intitle: wouldn't work? That would be my first assumption on syntax." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 (owner: 10Manybubbles) [16:43:56] (03PS1) 10Siebrand: Change line breaks in LocalFile::recordUpload2() [core] - 10https://gerrit.wikimedia.org/r/99147 [16:44:01] (03Abandoned) 10Tpt: Update ProofreadPage to master [core] - 10https://gerrit.wikimedia.org/r/99146 (owner: 10Tpt) [16:44:05] (03CR) 10Chad: [C: 032] Fix error in prefer-recent: test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98977 (owner: 10Manybubbles) [16:45:06] (03CR) 10Manybubbles: "I can certainly change it to that. !intitle: is actually more like the syntax that we have now. ! intitle: as well." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 (owner: 10Manybubbles) [16:46:03] (03PS2) 10Tpt: Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99042 [16:46:45] (03CR) 10Siebrand: [C: 04-1] Removed 'Disable browser page caching" user preference (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [16:46:47] (03Merged) 10jenkins-bot: Fix error in prefer-recent: test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98977 (owner: 10Manybubbles) [16:48:58] (03PS1) 10Yaron Koren: Removing support for YUI JS library, and thus for MW 1.16 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/99150 [16:50:26] (03CR) 10Yaron Koren: [C: 032 V: 032] Removing support for YUI JS library, and thus for MW 1.16 [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/99150 (owner: 10Yaron Koren) [16:50:59] (03CR) 10Calak: [C: 031] Group public and private properties [core] - 10https://gerrit.wikimedia.org/r/99137 (owner: 10Siebrand) [16:51:25] (03CR) 10Calak: [C: 031] Update documentation for MediaHandler::getPageDimensions() [core] - 10https://gerrit.wikimedia.org/r/99132 (owner: 10Siebrand) [16:51:28] (03PS1) 10Cmcmahon: Revert "Prefer double-quoted strings in Ruby code" [selenium] - 10https://gerrit.wikimedia.org/r/99151 [16:52:03] (03PS1) 10Matthias Mullie: recentchanges updates should be against core db, not flow (which may be on other cluster) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99152 [16:52:16] (03CR) 10Hashar: "I am a bit short on time to be able to deploy that right now. I have added a few people that interacted with ProofRead previously." [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99042 (owner: 10Tpt) [16:52:42] (03CR) 10Cmcmahon: [C: 032] "This change seems to have broken all the Jenkins builds, Sauce reports "Unable to pick a platform" for every build in every repo." [selenium] - 10https://gerrit.wikimedia.org/r/99151 (owner: 10Cmcmahon) [16:57:37] Hi, can someone please help reviewing this patch from a Google Code-in student? Add an SVG version of watch icon https://gerrit.wikimedia.org/r/#/c/98856/ [16:59:30] (03CR) 10Bartosz Dziewoński: "Is there any browser which supports CSS transforms but not SVG images? If yes, what happens then?" [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [16:59:37] when i'm less overloaded :( [17:01:05] (03PS3) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/98276 [17:01:27] (03PS2) 10Matthias Mullie: [Experimental] div contenteditable editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99004 [17:02:20] (03PS1) 10Anomie: Improve ApiQueryTestBase::assertResult [core] - 10https://gerrit.wikimedia.org/r/99156 [17:02:43] (03PS1) 10Hashar: media: limit size of stderr being logged [core] - 10https://gerrit.wikimedia.org/r/99157 [17:03:34] (03CR) 10Hashar: "The actual bug fix is in https://gerrit.wikimedia.org/r/#/c/99157/" [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:03:48] Hello [17:05:13] MatmaRex: I asked a question about embedding MW in another PHP application 2 weeks ago. You gave me some hints how to tackle that. [17:06:08] Thanks a lot: I have MW running as an 'application' inside phabricator. [17:06:26] ohh [17:06:31] well done kami [17:06:48] make sure to share your knowledge somewhere on a blog / phabricator mailing list or whatever [17:06:51] hashar: it is not yet finished, just a proof of concept [17:07:19] But it looks promising. [17:07:23] (03CR) 10Chad: "I'm fine with ! if it matches what we have now (and - just kind of made sense to me since it's what I expect from Google)." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 (owner: 10Manybubbles) [17:08:04] (03CR) 10Krinkle: "* I agree having mediawiki.ui available is better than having uncertainly regarding jquery.ui vs. mediawiki.ui vs. something else." [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [17:08:19] hashar: is it enough to push the change to Gerrit for review? [17:09:12] (03PS1) 10Yurik: Changed ZeroRatedMobileAccess to Zero [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/99158 [17:09:55] kami: more or less [17:10:09] kami: asking other devs to look at the code will help getting it attention [17:10:18] in last resort, you can expose your code on wikitech-l [17:11:12] (03CR) 10Manybubbles: "Let me check the - prefix to. I think we actually support too many syntaxes but we get them for free from lucene." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 (owner: 10Manybubbles) [17:11:45] (03CR) 10EBernhardson: [C: 032] "One issue, but its not a blocker. Filed bug 57987 to take care of it at a later date." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98750 (owner: 10Bsitu) [17:11:54] (03Merged) 10jenkins-bot: Fix a fatal error on board history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98750 (owner: 10Bsitu) [17:12:01] (03CR) 10Tpt: [C: 031] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:12:21] Tpt_: thx :] [17:13:05] (03PS1) 10Manybubbles: Turn off pool counter for bulk index build job [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 [17:13:45] hashar: thank you [17:14:08] (03PS4) 10Siebrand: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [17:14:10] (03PS1) 10Siebrand: Change use of bold and italic to strong and emphasis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99161 [17:14:19] (03PS1) 10Kambiz Darabi: Allow MediaWiki class to be instantiated inside another PHP application [core] - 10https://gerrit.wikimedia.org/r/99162 [17:16:40] (03CR) 10Manybubbles: "I checked: we do support the - prefix for negation. I'll use that." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 (owner: 10Manybubbles) [17:20:09] (03CR) 10Chad: [C: 04-2] "Not sure if I agree with this at all, but a couple of major things that need fixing first before we'll even consider it." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [17:23:59] (03CR) 10Hashar: "Nice Thomas! Thank you for writing tests, we badly need them. I left a few remarks in the diff, namely about how the djvu commands might " (034 comments) [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [17:24:44] kami: and here you get review :-] [17:24:50] hashar: that was quick. [17:24:59] hashar: my patch contains junk. [17:25:16] kami: don't be blocked by the Code-Review -2 vote, that is merely to make sure the patch is not going to be deployed on Wikimedia servers [17:25:19] I was so buried in all the globals that I didn't properly clean up [17:25:24] it is ok [17:25:24] just amend :-] [17:25:28] will do [17:25:41] get the patch, do your change, git add then: git commit --amend [17:25:48] making sure the Change-Id: remains the same [17:25:59] I know. We use gerrit internally, here. [17:26:05] awesome [17:26:05] (03CR) 10M4tx: "I don't believe there is any. The main problem is that there's no way to fallback the CSS animations without using JavaScript (it raises f" [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [17:26:22] (03PS1) 1001tonythomas: Removed "Disable search suggestions" from Mediawiki Preference [core] - 10https://gerrit.wikimedia.org/r/99163 [17:26:32] kami: we have Jenkins executing some tests, two of them are PHP_CodeSniffer which check style [17:26:43] kami: you can ignore the result of those jobs [17:26:52] hashar: was just going to ask where I can find the config [17:26:53] (03CR) 10jenkins-bot: [V: 04-1] Removed "Disable search suggestions" from Mediawiki Preference [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [17:26:55] (03PS3) 10Manybubbles: Make incategory: and intitle: negatable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 [17:27:13] kami: our code base does not pass our PHP CodeSniffer standard :( [17:27:27] (03PS1) 10EBernhardson: Disable potential external loading in ParsoidUtils::createDOM [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99164 [17:27:45] kami: anyway the standard is in the git repo ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer.git [17:27:49] we have some old doc on https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer [17:27:58] but don't waste your time on it right now :-] [17:28:13] (03PS1) 10Anomie: Remove change_tag_tag_id index forcing from API too [core] - 10https://gerrit.wikimedia.org/r/99165 [17:28:37] hashar: I will try to minimise complaints [17:29:28] (03CR) 10Anomie: "I asked about this on change I6b8f35bd, but no one bothered to answer me then." [core] - 10https://gerrit.wikimedia.org/r/99165 (owner: 10Anomie) [17:29:42] (03PS4) 10Manybubbles: Make incategory: and intitle: negatable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 [17:30:17] (03PS2) 1001tonythomas: Removed "Disable search suggestions" from Mediawiki Preference [core] - 10https://gerrit.wikimedia.org/r/99163 [17:31:29] (03CR) 10Anomie: [C: 04-1] "Looks good, except for one thing." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98996 (owner: 10Jackmcbarn) [17:31:31] (03CR) 10Chad: "I'm in favor of this in theory, lemme dig up some numbers on actual usage :)" [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [17:31:49] (03CR) 10Hashar: Allow MediaWiki class to be instantiated inside another PHP application (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [17:31:56] enough for today [17:32:00] rushing out home *wave* [17:35:08] (03CR) 10Brian Wolff: [C: 031] "Kill useless prefs with fire!" [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [17:36:05] (03PS1) 10EBernhardson: Properly protect moderated content in Templating::getContent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99166 [17:39:05] (03CR) 10Chad: [C: 031] "2009 users on enwiki, 207 on dewiki, 107 on commonswiki. I did no tests to see how active these users are." [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [17:39:09] Niharika: was your problem solved? [17:39:24] Nikerabbit: Yeah. [17:39:30] oki [17:39:36] and matanya not here [17:39:46] hi Nikerabbit [17:40:00] OrenBochman: hi uga [17:40:05] OrenBochman: where have you been hiding [17:40:13] I have interesting news for you [17:41:05] (suspense pause...) [17:41:19] (03PS1) 10Yaron Koren: More changes to remove YUI/MW 1.16 support [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/99169 [17:42:58] (03CR) 10Yaron Koren: [C: 032 V: 032] More changes to remove YUI/MW 1.16 support [extensions/HeaderTabs] - 10https://gerrit.wikimedia.org/r/99169 (owner: 10Yaron Koren) [17:43:03] (03CR) 10Chad: [C: 032] Switch search methods to always return status (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99144 (owner: 10Manybubbles) [17:43:07] (03Merged) 10jenkins-bot: Switch search methods to always return status [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99144 (owner: 10Manybubbles) [17:43:54] (03CR) 10Chad: [C: 032] Make incategory: and intitle: negatable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 (owner: 10Manybubbles) [17:43:58] (03Merged) 10jenkins-bot: Make incategory: and intitle: negatable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 (owner: 10Manybubbles) [17:47:21] (03CR) 10Aaron Schulz: [C: 032] Remove change_tag_tag_id index forcing from API too [core] - 10https://gerrit.wikimedia.org/r/99165 (owner: 10Anomie) [17:49:24] (03CR) 10Umherirrender: [C: 031] generalize BitmapHandler::logErrorForExternalProcess [core] - 10https://gerrit.wikimedia.org/r/99142 (owner: 10Hashar) [17:49:25] (03PS1) 10EBernhardson: Properly escape messages used in anchors in RC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99170 [17:50:20] (03Merged) 10jenkins-bot: Remove change_tag_tag_id index forcing from API too [core] - 10https://gerrit.wikimedia.org/r/99165 (owner: 10Anomie) [17:50:40] (03CR) 10Umherirrender: "Why not fix both cases by removing the extra margin with css on '.successbox p'?" [core] - 10https://gerrit.wikimedia.org/r/97914 (owner: 10Kaldari) [17:51:17] (03PS1) 1001tonythomas: Removed "Enable section editing via [edit] links" from Mediawiki Preference. [core] - 10https://gerrit.wikimedia.org/r/99171 [17:51:49] (03CR) 10Brian Wolff: [C: 032] "We should really write in the coding conventions if the type comes before or after the variable in an @param, since half of mediawiki seem" [core] - 10https://gerrit.wikimedia.org/r/99132 (owner: 10Siebrand) [17:52:28] (03PS2) 10Tpt: Adds some beginning of tests for DjVu files [core] - 10https://gerrit.wikimedia.org/r/98258 [17:52:39] (03PS2) 10Brian Wolff: Removed "Enable section editing via [edit] links" from Mediawiki Preference. [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [17:52:55] (03CR) 10Tpt: "Improve things pointed in PS 1" [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [17:53:03] (03CR) 10Brian Wolff: "This one I'd like to see some stats for, to see how much people actually use it" [core] - 10https://gerrit.wikimedia.org/r/99171 (owner: 1001tonythomas) [17:53:14] (03CR) 10Siebrand: "*nod* Making this small change because I come across it as being an issue elsewhere as pointed out by PHPStorm. I'm working my way down in" [core] - 10https://gerrit.wikimedia.org/r/99132 (owner: 10Siebrand) [17:56:31] (03Merged) 10jenkins-bot: Update documentation for MediaHandler::getPageDimensions() [core] - 10https://gerrit.wikimedia.org/r/99132 (owner: 10Siebrand) [17:57:10] tonythomas01: Another pref I always thought should die, is "disable browser caching" (Since its actually useless, as it doesn't even disable most types of caching) [17:57:21] (03CR) 10Umherirrender: "Should it removed from mediawiki or only from the Preferences page (which is done here)? You should remove the default value for that from" [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [17:58:13] (03CR) 10Kaldari: "Daniel Friesen: What modules does OutputPage load that are similar? I only see mediawiki.page.startup, mediawiki.util, mediawiki.api, medi" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [17:58:16] bawolff, I think you should see this https://gerrit.wikimedia.org/r/#/c/98276/ [17:58:32] oh, woo! [17:58:54] * bawolff has always hated that pref [18:02:56] bawolff, feel free to go through that [18:03:37] I'm about to start participating in a round table thingy, but I'll try to look at that commit today or tommorow [18:06:15] tonythomas01: (specificly http://youtu.be/vMTvVYHiUoA if you're curious, although I'm not sure how interesting it would be to you) [18:07:27] (03PS4) 10leucosticte: Adding ViewFiles extension, v1.0.3. [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/28799 [18:07:56] bawolff, looks great, but super slow internet connection here today :( [18:08:31] (03CR) 10Umherirrender: "But how you want handle this, when not getting the default?" [core] - 10https://gerrit.wikimedia.org/r/99068 (owner: 10saper) [18:09:33] (03PS1) 10Yurik: Updated zero [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99174 [18:09:56] (03CR) 10Yurik: [C: 032 V: 032] Updated zero [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99174 (owner: 10Yurik) [18:14:37] (03PS1) 10Yurik: Updated Zero ext [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99175 [18:14:39] bawolff, when removing the keyword 'disablesuggest' completely , I should remove it from the maintenance/dictionary/mediawiki.dic too right ? [18:15:03] Umm. Good question, I guess so [18:15:41] bawolff, ok. uploading patch set 3. Removed from Defaultsettings.php and Skin.php [18:16:00] Yeah, I think others doing similar things have removed it from that file [18:19:03] (03CR) 10Daniel Friesen: [C: 04-1] "I've pointed out some specific issues that can be fixed." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [18:19:07] Krinkle, I wonder whether you could have a look at https://gerrit.wikimedia.org/r/#/c/98856/ -- I'm trying to find reviewers for this Google Code-in patch. Thank you! [18:20:24] (03CR) 10Yurik: [C: 032 V: 032] Updated Zero ext [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99175 (owner: 10Yurik) [18:21:09] (03CR) 10Siebrand: [C: 04-1] "L10n looks good." (033 comments) [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/28799 (owner: 10leucosticte) [18:21:21] (03PS3) 1001tonythomas: Removed "Disable search suggestions" from Mediawiki Preference [core] - 10https://gerrit.wikimedia.org/r/99163 [18:25:19] (03PS3) 10leucosticte: Add PerPageLicense extension. [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 [18:27:04] (03PS6) 10Netbrain: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 [18:29:44] (03PS5) 10Kaldari: Add 'mediawiki.ui.button' CSS module [core] - 10https://gerrit.wikimedia.org/r/98869 [18:30:16] (03CR) 10Jorm: [C: 031] Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [18:31:01] RoanKattouw, could you please have a look at https://gerrit.wikimedia.org/r/#/c/98856/ ? I'm quite desperate trying to find a reviewer for this Google Code-in patch [18:31:39] (03PS4) 10leucosticte: Add PerPageLicense extension. [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 [18:32:11] qgil: I always find brion to be an entusiastic reviewer for all things SVG [18:35:27] YuviPanda, good to know! Especially considering that https://gerrit.wikimedia.org/r/#/c/98856/ is a patch for a bug filed by... brion :) [18:35:49] jorm +1'd it. Thank you! [18:36:07] timo pulled trevor onto it, though. [18:36:16] so he may want to look at it. [18:36:52] I harassed roan at the kitchenette... [18:39:04] (03CR) 10Krinkle: "I haven't looked at the SVG visually yet, but here's a rough sketch of what I'd recommend." [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [18:40:39] (03PS1) 10MarkTraceur: Fix a conditional that causes errors sometimes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/99178 [18:43:11] (03CR) 10EBernhardson: [C: 032] recentchanges updates should be against core db, not flow (which may be on other cluster) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99152 (owner: 10Matthias Mullie) [18:43:22] (03Merged) 10jenkins-bot: recentchanges updates should be against core db, not flow (which may be on other cluster) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99152 (owner: 10Matthias Mullie) [18:43:55] greg-g, Reedy: csteipp found bugs, so no Flow deploy today [18:44:20] csteipp++ , good stuff [18:44:21] (03PS2) 10MarkTraceur: Fix a conditional that causes errors sometimes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/99178 [18:44:28] (03CR) 10MarkTraceur: "What a silly typo." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/99178 (owner: 10MarkTraceur) [18:45:19] (03CR) 10EBernhardson: [C: 032] Change use of bold and italic to strong and emphasis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99161 (owner: 10Siebrand) [18:45:35] ebernhardson: ty [18:46:30] spagewmf: wow, alright then, glad he did :) [18:46:34] I mean, you know [18:47:03] Whoa, we're less than 1000 patches away from 100k [18:47:07] Super exciting [18:47:09] qgil: :) [18:47:18] Everyone have their important patches queued up ready to claim it? :) [18:47:43] I'm reserving mine for the 1M [18:48:24] (03CR) 10Bsitu: Fix a fatal error on board history (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98750 (owner: 10Bsitu) [18:49:26] greg-g: for sure. Can we reschedule to Tuesday Dec 10 after the the MW deploy window? [18:49:32] qgil: Maybe gerrit.wikimedia.org/r/1000000 can be something like "Fix all bugs", leaving no files in the repo. [18:50:48] lol [18:51:02] marktraceur: Also fix bug: 1 [18:51:14] It will finally be documented properly [18:51:21] gerrit has a housecleaning/easter egg where at N % 100000 all patches in the system are +2d [18:51:42] (03CR) 10Jorm: [C: 031] "Other than the idea that we may want to eliminate the use of a sprite, this looks good to me. Timo or Trevor may have stronger opinions a" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/97454 (owner: 10M4tx) [18:51:46] (03CR) 10Chad: "Considering we don't do in-process search updates anymore and it's been offloaded to the jobqueue, I'm wondering if we should be suppressi" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [18:51:56] (03PS1) 10BryanDavis: Add udp2log compatible log handler [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99181 [18:53:35] (03PS3) 10UltrasonicNXT: {{NUMBEROFCOMMENTSPAGE}} magic word/parser funct [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 [18:53:43] (03CR) 10Manybubbles: "Confused: do you mean we should not be suppressing the update counter? Just let the jobs wait behind these bulk indexes?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [18:54:34] spagewmf: yeah... lemme add it real quick [18:55:00] (03PS5) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [18:55:23] (03PS2) 10Siebrand: Change use of bold and italic to strong and emphasis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99161 [18:55:48] (03CR) 10Siebrand: [C: 032] "Per Erik's earlier +2 after rebasing it on master." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99161 (owner: 10Siebrand) [18:55:57] (03Merged) 10jenkins-bot: Change use of bold and italic to strong and emphasis [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99161 (owner: 10Siebrand) [19:03:54] (03CR) 10Siebrand: "A few comments." (033 comments) [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 (owner: 10leucosticte) [19:04:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [19:04:48] (03PS1) 10Aude: Add .gitreview file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99183 [19:04:56] (03PS2) 10Bsitu: Properly escape messages used in anchors in RC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99170 (owner: 10EBernhardson) [19:05:07] (03CR) 10Siebrand: [C: 032] Add .gitreview file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99183 (owner: 10Aude) [19:05:28] wow, fast! [19:05:33] (03CR) 10Bsitu: [C: 032] Properly escape messages used in anchors in RC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99170 (owner: 10EBernhardson) [19:06:21] (03Merged) 10jenkins-bot: Add .gitreview file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/99183 (owner: 10Aude) [19:06:25] (03CR) 10Aaron Schulz: "It would be nice for jobs to avoid using pool counter (we can control job process count in puppet). Having jobs wait around on a counter w" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [19:06:34] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/99163 (owner: 1001tonythomas) [19:06:34] (03Merged) 10jenkins-bot: Properly escape messages used in anchors in RC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99170 (owner: 10EBernhardson) [19:08:31] (03PS2) 10BryanDavis: sanitizer-escape-id [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98742 (owner: 10Dan-nl) [19:08:40] (03CR) 10BryanDavis: [C: 032] sanitizer-escape-id [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98742 (owner: 10Dan-nl) [19:08:46] (03Merged) 10jenkins-bot: sanitizer-escape-id [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98742 (owner: 10Dan-nl) [19:13:32] (03PS1) 10Manybubbles: Update Cirrus to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99185 [19:13:57] aude: yeah, I saw an easy opportunity to up my score :) [19:14:35] csteipp: do you think you'll be able to get to the remaining gerrit commits today for gwtoolset? [19:15:05] (03PS1) 10Manybubbles: Update Cirrus to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99186 [19:15:45] marktraceur: what do you think about my last commit, should i mark the task as complete ? [19:15:50] * siebrand greets ^d  [19:16:01] * siebrand greets ^d  [19:16:01] <^d> howdy siebrand [19:16:10] vandrew: Uh, I dunno, haven't looked yet [19:16:13] h, I thought you might have missed that :) [19:16:27] dan-nl: Yeah, I hope so [19:16:38] ^d: I'm good. How are you? Been trying to keep your review queue filled... [19:17:05] <^d> I've been good, busy keeping up with your changes so I can try and keep my queue less than a page :) [19:18:06] great, thanks [19:19:18] marktraceur: take your time [19:20:55] (03CR) 10Manybubbles: [C: 04-1] "Fair point. I'll add this to all of my jobs. I'll keep the settings restoration bit just in case. I don't want my jobs to be responsibl" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [19:20:59] (03PS2) 10EBernhardson: Introduce tipsy [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98820 (owner: 10Matthias Mullie) [19:21:01] (03Merged) 10jenkins-bot: Update Cirrus to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99185 (owner: 10Manybubbles) [19:21:18] (03CR) 10EBernhardson: "PS2: rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98820 (owner: 10Matthias Mullie) [19:21:20] (03CR) 10Bsitu: [C: 032] Properly protect moderated content in Templating::getContent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99166 (owner: 10EBernhardson) [19:22:48] (03Merged) 10jenkins-bot: Properly protect moderated content in Templating::getContent [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99166 (owner: 10EBernhardson) [19:23:14] gwicke: where you thinking of one BacklinkHttpUpdateJob class to use directly or just as a base class? It would be hard to do the former with all the X-Parsoid custom headers based on the title [19:29:40] AaronSchulz, we could just have a generic HTTPJob class [19:29:45] without any backlink logic [19:30:21] taking action (GET/POST etc), URL, headers, PUT/POST data [19:30:30] that would cover our use case [19:30:37] and pretty much everything else [19:30:59] oh, and a priority / nice level I guess [19:31:33] then some other job would have to have that logic I guess [19:32:07] do you mean the generation of the URLs? [19:32:27] so you'd still have a ParsoidCacheUpdateJob job [19:32:38] that would make the http ones [19:32:50] we could do that directly in our handler, without a job [19:33:01] but I guess that could be too slow [19:33:09] must be in a job somewhere [19:33:37] AaronSchulz, for performance reasons? [19:34:32] pulling a list of a million titles out of the DB and generating URLs for them might not be instantaneous [19:35:14] maybe that list could have a URL too ;) [19:59:00] (03CR) 10Krinkle: Site logo loaded using UserSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [20:13:56] (03PS1) 10Siebrand: Replace and by and in i18n. [core] - 10https://gerrit.wikimedia.org/r/99195 [20:19:40] (03PS7) 10Tholam: Site logo loaded using ResourceLoaderSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [20:20:16] (03CR) 10jenkins-bot: [V: 04-1] Site logo loaded using ResourceLoaderSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [20:22:58] (03CR) 10Hashar: "Requested to install djvulibre-bin Ubuntu packages on Jenkins server so the test have a chance to pass: https://gerrit.wikimedia.org/r/991" [core] - 10https://gerrit.wikimedia.org/r/98258 (owner: 10Tpt) [20:24:36] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/99203 (owner: 10L10n-bot) [20:25:53] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/99217 (owner: 10L10n-bot) [20:33:38] (03PS2) 10Siebrand: Replace and by and in i18n. [core] - 10https://gerrit.wikimedia.org/r/99195 [20:37:58] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'd be very wary of blindly replacing these tags, and it seems like you're replacing them blindly here – e.g. the in GlobalFunctions " [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [20:38:20] (03PS1) 10Manybubbles: Use a more efficient query for batch indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99243 [20:38:22] (03CR) 10Bartosz Dziewoński: "the in mediawiki.hlist.js*" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [20:38:42] (03CR) 10Siebrand: "There's not too much blindness. Gerrit allows for comments on line level. Please point out where you need more information." [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [20:38:56] (03PS2) 10Manybubbles: Use a more efficient query for batch indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99243 [20:40:06] (03CR) 10Chad: [C: 032] Use a more efficient query for batch indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99243 (owner: 10Manybubbles) [20:42:29] (03CR) 10Bartosz Dziewoński: "I pointed out two examples noted in a very cursory glance. I don't have time to thoroughly review each line, sorry; if you truly feel you'" [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [20:42:33] (03CR) 10jenkins-bot: [V: 04-1] Replace and by and in i18n. [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [20:42:49] (03Merged) 10jenkins-bot: Use a more efficient query for batch indexing [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99243 (owner: 10Manybubbles) [20:45:15] hexmode: hi! As quick reminder, don't you want to merge https://gerrit.wikimedia.org/r/#/c/97101/ before 1.22 release? [20:46:24] hi ialex ! [20:46:34] hey [20:57:47] (03PS1) 10Anomie: RELEASE-NOTES entry for Ia0bd2531 [core] - 10https://gerrit.wikimedia.org/r/99245 [20:58:17] (03CR) 10Anomie: [C: 032] "Trivial RELEASE-NOTES change forgotten in an earlier commit." [core] - 10https://gerrit.wikimedia.org/r/99245 (owner: 10Anomie) [21:03:02] (03Merged) 10jenkins-bot: RELEASE-NOTES entry for Ia0bd2531 [core] - 10https://gerrit.wikimedia.org/r/99245 (owner: 10Anomie) [21:08:47] (03CR) 10Chad: "I'm saying remove the update counter entirely. The job queue is controlled via puppet (like Aaron points out), and I'd rather all updates " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:15:14] (03CR) 10Parent5446: "Do we know if the previous patch was included in the 1.22 release?" [core] - 10https://gerrit.wikimedia.org/r/99068 (owner: 10saper) [21:15:31] (03CR) 10Manybubbles: "Let me see what I can do...." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:21:08] (03CR) 10Parent5446: [C: 031] "My other comments weren't fixed, but I'm probably being ignored at this point and it isn't that big a deal." [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [21:22:20] (03PS5) 10EBernhardson: Improve error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 (owner: 10Matthias Mullie) [21:22:22] (03PS3) 10EBernhardson: Improve non-JS display of edit-(header|title|post) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98547 (owner: 10Matthias Mullie) [21:23:38] (03CR) 10EBernhardson: [C: 032] "PS5: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 (owner: 10Matthias Mullie) [21:23:47] (03Merged) 10jenkins-bot: Improve error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 (owner: 10Matthias Mullie) [21:23:58] (03CR) 10EBernhardson: [C: 032] "PS3: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98547 (owner: 10Matthias Mullie) [21:24:03] (03PS1) 10Mattflaschen: Fix method name so descriptions actually show up in help [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/99250 [21:24:08] (03Merged) 10jenkins-bot: Improve non-JS display of edit-(header|title|post) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98547 (owner: 10Matthias Mullie) [21:24:47] (03CR) 10Mattflaschen: "Can be tested at /w/api.php?action=help&modules=gettingstartedgetpages ." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/99250 (owner: 10Mattflaschen) [21:28:46] (03CR) 10Bartosz Dziewoński: "(It's probably not merging because of release notes. Don't panic :) )" [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [21:30:48] (03CR) 10Parent5446: Allow MediaWiki class to be instantiated inside another PHP application (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99162 (owner: 10Kambiz Darabi) [21:31:25] (03CR) 10Tholam: "OK that's good to know :-)" [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [21:34:48] (03CR) 10EBernhardson: [C: 04-1] Timestamp in history page gets into show/hide loop on hoverOver (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98860 (owner: 10Bsitu) [21:37:11] (03PS3) 10EBernhardson: Global variable to disable flow's memcache usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 [21:37:36] (03CR) 10EBernhardson: [C: 032] "PS3: rebased, +2 based on previous +2 from Matthias" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 (owner: 10EBernhardson) [21:37:45] (03Merged) 10jenkins-bot: Global variable to disable flow's memcache usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 (owner: 10EBernhardson) [21:39:09] (03PS2) 10Chad: Turn off pool counter for all jobs and commandline scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:39:13] (03CR) 10jenkins-bot: [V: 04-1] Turn off pool counter for all jobs and commandline scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:40:31] (03PS3) 10Chad: Turn off pool counter for all jobs and commandline scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:41:07] (03CR) 10Parent5446: [C: 04-1] Update documentation for file repo related classes (037 comments) [core] - 10https://gerrit.wikimedia.org/r/99136 (owner: 10Siebrand) [21:41:41] (03CR) 10Parent5446: [C: 031] "Will merge once underlying patch is approved." [core] - 10https://gerrit.wikimedia.org/r/99137 (owner: 10Siebrand) [21:42:03] (03CR) 10Parent5446: [C: 031] "Will merge once underlying patch is approved." [core] - 10https://gerrit.wikimedia.org/r/99139 (owner: 10Siebrand) [21:46:01] (03CR) 10Chad: Turn off pool counter for all jobs and commandline scripts (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:46:46] (03CR) 10Parent5446: [C: 031] Remove unneeded use of else{} in file repo classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99145 (owner: 10Siebrand) [21:47:17] (03CR) 10Manybubbles: [C: 032] Turn off pool counter for all jobs and commandline scripts (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:47:27] (03CR) 10Manybubbles: [V: 032] Turn off pool counter for all jobs and commandline scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:47:28] (03Merged) 10jenkins-bot: Turn off pool counter for all jobs and commandline scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99159 (owner: 10Manybubbles) [21:48:25] ahk, looked like I merged too early [21:50:06] ^d: I've have trashed the that other one you linked as well [21:50:23] but I merged before you got to thinkabout that. sorry! [21:51:03] <^d> Hm? I'm fine. [21:51:06] <^d> :p [21:53:54] ahk, it crashes. one moment [21:54:34] (03PS3) 10EBernhardson: Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 [21:54:36] (03CR) 10jenkins-bot: [V: 04-1] Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [21:55:19] <^d> manybubbles: I hadn't really tested that change at all yet ;-) [21:55:35] <^d> Other than "does it parse" [21:56:26] Could someone review this backport? https://gerrit.wikimedia.org/r/#/c/99042 it fix some annoying bugs in Wikisource. [21:57:02] (03PS4) 10EBernhardson: Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 [21:57:07] (03CR) 10EBernhardson: Set a global cache time within Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [21:57:46] eep [21:57:53] (03CR) 10EBernhardson: [C: 032] Revision will be null if user does not have viewing permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98867 (owner: 10Bsitu) [21:58:03] (03Merged) 10jenkins-bot: Revision will be null if user does not have viewing permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98867 (owner: 10Bsitu) [21:59:11] (03PS1) 10Manybubbles: Remove some accidental debug logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99254 [22:02:43] (03CR) 10Chad: [C: 032] Remove some accidental debug logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99254 (owner: 10Manybubbles) [22:03:25] (03Merged) 10jenkins-bot: Remove some accidental debug logs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99254 (owner: 10Manybubbles) [22:05:14] RFC review meeting in #wikimedia-meetbot [22:06:05] (03PS1) 10Manybubbles: Update Cirrus again [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99255 [22:07:50] (03PS1) 10Manybubbles: Update Cirrus again [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99256 [22:09:54] (03CR) 10Chad: [C: 032] Update Cirrus again [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99256 (owner: 10Manybubbles) [22:10:03] (03CR) 10Chad: [C: 032] Update Cirrus again [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99255 (owner: 10Manybubbles) [22:13:06] (03CR) 10Siebrand: "Thanks for the review. Replies inline and updated PS coming up." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/99136 (owner: 10Siebrand) [22:13:44] (03Merged) 10jenkins-bot: Update Cirrus again [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/99256 (owner: 10Manybubbles) [22:13:55] (03PS2) 10Siebrand: Update documentation for file repo related classes [core] - 10https://gerrit.wikimedia.org/r/99136 [22:15:21] (03Merged) 10jenkins-bot: Update Cirrus again [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/99255 (owner: 10Manybubbles) [22:15:51] (03PS1) 10M4tx: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/99258 [22:19:14] (03CR) 10M4tx: "@Krinkle: I implemented it as a separate commit." [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [22:19:51] (03CR) 10M4tx: "Argh. Not a permalink." [core] - 10https://gerrit.wikimedia.org/r/98856 (owner: 10M4tx) [22:27:56] (03PS1) 10Cmcmahon: added test for block/hide/delete/suppress controls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99260 [22:28:10] (03PS2) 10Cmcmahon: added test for block/hide/delete/suppress controls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99260 [22:28:56] (03CR) 10Parent5446: Update documentation for file repo related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99136 (owner: 10Siebrand) [22:29:31] (03CR) 10Parent5446: [C: 032] Update documentation for file repo related classes [core] - 10https://gerrit.wikimedia.org/r/99136 (owner: 10Siebrand) [22:29:32] (03CR) 10Krinkle: mediawiki.api: Fix token with postWithToken, add test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [22:29:35] (03PS2) 10Parent5446: Group public and private properties [core] - 10https://gerrit.wikimedia.org/r/99137 (owner: 10Siebrand) [22:29:57] (03CR) 10Parent5446: [C: 032] Group public and private properties [core] - 10https://gerrit.wikimedia.org/r/99137 (owner: 10Siebrand) [22:30:02] (03PS2) 10Parent5446: Satisfy code analyzer by ensuring $urls is defined [core] - 10https://gerrit.wikimedia.org/r/99139 (owner: 10Siebrand) [22:30:17] (03CR) 10Krinkle: [C: 032] Group public and private properties [core] - 10https://gerrit.wikimedia.org/r/99137 (owner: 10Siebrand) [22:30:18] (03PS3) 10Cmcmahon: added test for block/hide/delete/suppress controls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99260 [22:30:20] (03CR) 10Parent5446: [C: 032] Satisfy code analyzer by ensuring $urls is defined [core] - 10https://gerrit.wikimedia.org/r/99139 (owner: 10Siebrand) [22:30:24] (03CR) 10Krinkle: "+4 :)" [core] - 10https://gerrit.wikimedia.org/r/99137 (owner: 10Siebrand) [22:30:25] (03PS2) 10Parent5446: Remove unneeded use of else{} in file repo classes [core] - 10https://gerrit.wikimedia.org/r/99145 (owner: 10Siebrand) [22:30:37] (03PS4) 10Cmcmahon: added test for block/hide/delete/suppress controls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99260 [22:33:07] (03Merged) 10jenkins-bot: Update documentation for file repo related classes [core] - 10https://gerrit.wikimedia.org/r/99136 (owner: 10Siebrand) [22:34:41] (03CR) 10Siebrand: Remove unneeded use of else{} in file repo classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99145 (owner: 10Siebrand) [22:36:32] (03Merged) 10jenkins-bot: Group public and private properties [core] - 10https://gerrit.wikimedia.org/r/99137 (owner: 10Siebrand) [22:37:10] (03PS2) 10Jackmcbarn: Show tags on deleted edits through the API [core] - 10https://gerrit.wikimedia.org/r/98996 [22:38:36] (03PS3) 10Jackmcbarn: Show tags on deleted edits through the API [core] - 10https://gerrit.wikimedia.org/r/98996 [22:39:55] (03Merged) 10jenkins-bot: Satisfy code analyzer by ensuring $urls is defined [core] - 10https://gerrit.wikimedia.org/r/99139 (owner: 10Siebrand) [22:46:58] (03PS1) 10Foxtrott: introduce XML structure description; add NavHead [skins/chameleon] - 10https://gerrit.wikimedia.org/r/99261 [22:52:16] bawolff: is https://gerrit.wikimedia.org/r/#/c/97993/ ok? [22:52:30] hrm, wrong commit [22:52:51] I mean https://gerrit.wikimedia.org/r/#/c/97659/ [22:53:55] (03PS1) 10EBernhardson: 'view' action is implicit in urls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99262 [22:54:46] (03CR) 10EBernhardson: [C: 032] Improve edit-post form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99009 (owner: 10Matthias Mullie) [22:55:11] (03CR) 10EBernhardson: [C: 032] Adding readme file in /tests/browser/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98773 (owner: 10Mayankmadan) [22:55:12] AaronSchulz: I'm not really at my laptop right now, but I think so [22:55:15] (03Merged) 10jenkins-bot: Improve edit-post form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99009 (owner: 10Matthias Mullie) [22:55:30] (03Merged) 10jenkins-bot: Adding readme file in /tests/browser/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98773 (owner: 10Mayankmadan) [22:55:58] * bawolff just has my irc client going on my cell phone to listen to the rfc meeting [23:06:54] (03PS1) 10MegaAlex: Add search results found as $2 parameter to message searchmenu-new [core] - 10https://gerrit.wikimedia.org/r/99265 [23:11:26] (03CR) 10EBernhardson: [C: 032] (bug 57388) first click in [Start a new topic] jumps to textarea below [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98497 (owner: 10Matthias Mullie) [23:11:46] ^d: maybe scap can use hhvm to rebuild the message caches ;) [23:11:50] (03Merged) 10jenkins-bot: (bug 57388) first click in [Start a new topic] jumps to textarea below [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98497 (owner: 10Matthias Mullie) [23:12:01] <^d> AaronSchulz: Sssh, you'll give away my evil plans ;) [23:14:30] (03CR) 10Aaron Schulz: [C: 032] Update documentation for DatabaseBase::selectRow() [core] - 10https://gerrit.wikimedia.org/r/99131 (owner: 10Siebrand) [23:15:26] ^d: it does have some serious cpu usage [23:15:37] might well be worth it [23:16:01] <^d> I wasn't joking, actually. [23:16:20] <^d> I've considered using hhvm in there. [23:16:21] though I bet that hits mc somewhere since everything depends on everything [23:16:28] <^d> Yup ;-) [23:16:51] <^d> I want to work on the igbinary thing, but I can't compile hhvm at the moment :) [23:18:02] (03Merged) 10jenkins-bot: Update documentation for DatabaseBase::selectRow() [core] - 10https://gerrit.wikimedia.org/r/99131 (owner: 10Siebrand) [23:22:24] (03CR) 10EBernhardson: Always use UUID objects when querying storage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98994 (owner: 10EBernhardson) [23:23:02] (03Abandoned) 10EBernhardson: Always use UUID objects when querying storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98994 (owner: 10EBernhardson) [23:25:17] (03PS7) 10EBernhardson: [WIP] Shorten uuids to 88 bits. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [23:28:32] (03PS4) 10Theopolisme: Create jquery.fullscreen [core] - 10https://gerrit.wikimedia.org/r/99021 [23:34:26] (03CR) 10Siebrand: "> This was just recently proposed and rejected on the design list with" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [23:35:05] (03PS3) 10Siebrand: Replace and by and in i18n. [core] - 10https://gerrit.wikimedia.org/r/99195 [23:36:47] (03PS1) 10EBernhardson: Escape wikitext from the topic title in post history Bug: 58013 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 [23:37:54] (03PS2) 10Legoktm: Escape wikitext from the topic title in post history Bug: 58013 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 (owner: 10EBernhardson) [23:38:28] (03CR) 10jenkins-bot: [V: 04-1] Replace and by and in i18n. [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [23:38:37] (03CR) 10EBernhardson: [C: 04-1] Allow ObjectManager to fall back to querying backend storage when no index is available (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99037 (owner: 10Werdna) [23:38:52] (03PS4) 10Siebrand: Replace and by and in i18n. [core] - 10https://gerrit.wikimedia.org/r/99195 [23:38:57] (03CR) 10Legoktm: [C: 04-1] Escape wikitext from the topic title in post history (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 (owner: 10EBernhardson) [23:41:47] (03CR) 10Krinkle: "Untested, but cod looks good. I agree (per our IRC chat) that the computed style thing is weird and we can probably try using straight .cs" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [23:42:27] (03CR) 10Krinkle: Replace and by and in i18n. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [23:42:54] (03PS5) 10Siebrand: Replace and by and in i18n. [core] - 10https://gerrit.wikimedia.org/r/99195 [23:43:05] (03PS1) 10Ori.livneh: Capitalization: 'jQuery', not 'jquery', and 'MediaWiki', not 'mediawiki' [core] - 10https://gerrit.wikimedia.org/r/99273 [23:43:11] (03CR) 10Siebrand: Replace and by and in i18n (031 comment) [core] - 10https://gerrit.wikimedia.org/r/99195 (owner: 10Siebrand) [23:43:26] (03CR) 10Ori.livneh: [C: 032] Capitalization: 'jQuery', not 'jquery', and 'MediaWiki', not 'mediawiki' [core] - 10https://gerrit.wikimedia.org/r/99273 (owner: 10Ori.livneh) [23:43:47] (03CR) 10Krinkle: "(actually, the module names are lowercase for both of them, not sure if that's the identifier being referred to though)." [core] - 10https://gerrit.wikimedia.org/r/99273 (owner: 10Ori.livneh) [23:44:09] (03CR) 10Ori.livneh: Capitalization: 'jQuery', not 'jquery', and 'MediaWiki', not 'mediawiki' [core] - 10https://gerrit.wikimedia.org/r/99273 (owner: 10Ori.livneh) [23:44:15] heh. [23:44:20] (03PS1) 10Chad: Fix fetching ParserOutput [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/99274 [23:44:26] Krinkle: call it! [23:45:15] ori-l: I'd say "when loading {title} and {title}" or "when loading the {module} and {module} modules". [23:45:36] (03CR) 10CSteipp: [C: 031] PreviewFrom [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98825 (owner: 10Dan-nl) [23:45:39] something like 'loading jQuery and the MediaWiki library" [23:45:45] or libraries? [23:45:47] I dunno. [23:46:26] <^d> AaronSchulz: I finally tried your idea of using ParserOptions of the editor ;-) [23:47:27] (03PS1) 10Bsitu: Remove redundant TitleIsAlwaysKnown() hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99275 [23:48:07] (03CR) 10CSteipp: [C: 031] derivative-request [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98807 (owner: 10Dan-nl) [23:48:28] (03CR) 10CSteipp: [C: 031] table-create [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98735 (owner: 10Dan-nl) [23:50:38] (03CR) 10CSteipp: [C: 031] js-error-output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [23:51:07] (03CR) 10Bsitu: Timestamp in history page gets into show/hide loop on hoverOver (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98860 (owner: 10Bsitu) [23:56:40] (03PS2) 10BryanDavis: PreviewFrom [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98825 (owner: 10Dan-nl) [23:56:46] (03CR) 10BryanDavis: [C: 032] PreviewFrom [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98825 (owner: 10Dan-nl) [23:57:03] (03Merged) 10jenkins-bot: PreviewFrom [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98825 (owner: 10Dan-nl) [23:57:35] (03PS3) 10EBernhardson: Escape wikitext from the topic title in post history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/99271 [23:58:37] (03PS2) 10BryanDavis: derivative-request [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98807 (owner: 10Dan-nl) [23:58:44] (03CR) 10BryanDavis: [C: 032] derivative-request [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98807 (owner: 10Dan-nl) [23:58:50] (03Merged) 10jenkins-bot: derivative-request [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98807 (owner: 10Dan-nl) [23:59:13] (03PS2) 10BryanDavis: table-create [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98735 (owner: 10Dan-nl) [23:59:19] (03CR) 10BryanDavis: [C: 032] table-create [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98735 (owner: 10Dan-nl) [23:59:26] (03Merged) 10jenkins-bot: table-create [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98735 (owner: 10Dan-nl) [23:59:41] (03PS3) 10BryanDavis: js-error-output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [23:59:54] (03CR) 10BryanDavis: [C: 032] js-error-output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl)