[00:01:03] (03CR) 10Huji: [C: 031] "Makes perfect sense to me." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [00:01:21] (03CR) 10MarkTraceur: [C: 032] "Deployed!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98731 (owner: 10MarkTraceur) [00:01:41] (03Merged) 10jenkins-bot: Add MultimediaViewer to qunitable extension list [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98731 (owner: 10MarkTraceur) [00:03:00] (03CR) 10Dan-nl: "- used mw.html.escape() before passing." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [00:03:19] (03PS5) 10Jdlrobson: Changing "أ" to "و" as it is more common between all arab script derivatives [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [00:03:38] (03CR) 10Jdlrobson: [C: 031] "Not sure about the context so will leave to Amir to +2 but updated the commit message to be more descriptive." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [00:10:26] ^d: I've found something to replace Gerrit [00:10:29] Team Foundation Server 2013 Express [00:10:46] <^d> Hellyes. [00:10:55] http://www.visualstudio.com/downloads/download-visual-studio-vs#d-team-foundation-server-express [00:10:56] clearly you mean VSS [00:11:08] haha, i was about to say the name alone sounds like MS [00:11:22] YuviPanda: Don't be silly [00:11:26] It's not supported anymore [00:11:38] Besides [00:11:46] Team Foundation sort of sounds like a less violent Team Fortress [00:11:46] That allows small teams to be more agile [00:11:50] What more could we want? [00:12:00] Reedy: is it agile or Agile?: [00:12:03] "which help individuals and small teams be more agile, collaborate more effectively, and deliver quality software more consistently." [00:12:04] we clearly want the latter [00:12:06] (03CR) 10TheDJ: "I'm not ok with that. We shouldn't bother users with messages unless they are needed." [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [00:12:08] (03CR) 10Swalling: [C: 032] "Text-only changes, precisely what we agreed on in the bug." [core] - 10https://gerrit.wikimedia.org/r/98733 (owner: 10MegaAlex) [00:12:13] Reedy: it's only 'agile', so... [00:12:19] REJECTED! [00:12:20] gives Reedy a iis-graceful-all [00:12:39] (03PS1) 10Dan-nl: table-create [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98735 [00:13:42] Reedy: what do i get if i leave out the Express part? a slower or the pro version ?:P [00:14:00] Maybe the Ultimate version [00:14:02] express as in outlook express? [00:14:56] Reedy: make Brion do windows phone work only and they'll give us a license [00:15:24] mutante: I think more like "14 express", i.e. you don't realize what you're getting into but once you do it's way too late and you're stuck with it [00:15:31] We could just get YuviPanda to get a student version from https://www.dreamspark.com/Product/Product.aspx?productid=72&cmpid=W_VS_DSV_DS_728x90_ENG and share that [00:15:42] by student version, I mean Professional version [00:15:48] well, I used to be a Microsoft Student Partner for two years [00:15:51] (the 14 express is a bus line that runs near the WMF offices and will happily take you to Daly City even if you don't want it to) [00:15:52] (in high school) [00:16:03] they gave you free MSDN subscriptions, but I didn't have a good enough internet connection [00:16:20] * YuviPanda went around colleges doing workshops about MS tech [00:16:50] (03Merged) 10jenkins-bot: Change the reset button text in Special: PasswordReset to 'Reset Password' [core] - 10https://gerrit.wikimedia.org/r/98733 (owner: 10MegaAlex) [00:18:43] (03PS2) 10Aaron Schulz: [WIP] Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 [00:19:31] So, hey all: chrismcmahon and I were just talking in -multimedia and were wondering if it might be useful/awesome to monitor API endpoints in production [00:19:47] (03PS3) 10Aaron Schulz: [WIP] Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 [00:20:43] I think we may flesh it out in a wiki page or list thread [00:20:55] Just FYI. [00:21:09] I'm super excited about the idea, especially if we can do it automatically without more configuration [00:21:45] marktraceur: what do you mean by 'monitor'? [00:21:51] marktraceur: we already keep full logs for API requests [00:22:21] YuviPanda: Like, poke the API with some test data and make sure we get sane requests. Then we can pinpoint pretty specifically what requests are going wrong and how, even if nobody complains about it [00:22:37] responses* [00:22:41] YuviPanda: marktraceur more like "get sane responses" [00:22:42] oh, like tests [00:22:44] I ran out of caffeine [00:22:45] Heh [00:22:54] not 'like' tests, but.. tests? :D [00:22:59] No [00:23:06] YuviPanda: Steadfastly only _similar_ to tests [00:23:16] how are they different from tests? [00:23:17] If anything looks too much like an actual test we'll stop it running [00:23:30] God forbid we actually test something around here [00:23:45] * YuviPanda notes the android app has... tests! [00:23:48] Sufficiently Advanced Monitoring is Indistinguishable from Testing http://www.youtube.com/watch?v=uSo8i1N18oc [00:25:08] chrismcmahon: I'm kind of excited to toy with this idea, but alas have no time to do so [00:25:30] (03PS1) 10EBernhardson: Limit topic titles to 260 bytes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 [00:26:21] I envision there being a script that loads the proper version of mediawiki/core, fetches all the extensions configured for the wiki it's pointing at, and runs through the registered API modules making requests that *should* be valid based on the specs set forth in the module declarations [00:26:49] I think that would all require very small additions to the API module schema, but it would be totally worth it [00:27:09] we have specs in the module declarations? [00:27:16] or do you mean in the future? [00:27:18] marktraceur: and we run it from https://integration.wikimedia.org/ci/ so it can talk to the monitoring services [00:28:04] YuviPanda: I guess you'd need to tweak the schema, see also the other message [00:28:11] Not sure how much you'd need to do though [00:28:18] chrismcmahon: Also yes [00:28:20] hmm [00:28:35] YuviPanda: Types are already included, they just need to be more specific [00:28:46] right. [00:29:00] Maybe we should "just" add more automatic-y example queries, ones that actually provide some test coverage [00:29:00] marktraceur: wikibase's code is oftentimes more specific in the types-of-API department [00:30:09] csteipp: question re: Should use a derivative request object instead of curling the api. do you mean use FauxRequest() or something else? [00:30:18] (03PS1) 10Cscott: Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 [00:30:36] (03CR) 10jenkins-bot: [V: 04-1] Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 (owner: 10Cscott) [00:37:55] (03PS6) 10Legoktm: Load scripts and styles via ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [00:40:36] huh there is no "pages with the most files" special page [00:41:23] I guess there's some storage of what files are linked to what pages in the db, so it would be possible [00:41:51] * AaronSchulz was looking for a test case [00:42:34] AaronSchulz: How many images are we talking, hundreds? Maybe a category would work? [00:49:25] TimStarling: I wonder if the main problem with https://bugzilla.wikimedia.org/show_bug.cgi?id=32598 was mostly large metadata (which is handled better now)...though 7000 file objects (each with a Title) is still pretty heavy [00:49:46] heh, and onLinksUpdateComplete only needs the names... [00:50:20] (03CR) 10Werdna: "I'm working on adding the limit to the frontend as well." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [00:51:53] maybe findFiles() could have NAMES_ONLY or AS_ITERATOR $flags option [00:57:49] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [00:58:24] dan-nl: I think DerivativeRequest is most appropriate there [00:59:03] (03PS1) 10Dan-nl: sanitizer-escape-id [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98742 [00:59:52] (03CR) 10Aaron Schulz: [C: 04-1] "Doesn't match return format yet" [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [01:00:13] csteipp: thanks! [01:00:39] will try it out [01:00:47] (03CR) 10Siebrand: Change the reset button text in Special: PasswordReset to 'Reset Password' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98733 (owner: 10MegaAlex) [01:01:21] (03PS2) 10EBernhardson: Limit topic titles to 260 bytes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 [01:01:35] (03CR) 10EBernhardson: Limit topic titles to 260 bytes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [01:04:05] marktraceur: let's pick up this API test^H^H^H^H monitoring discussion tomorrow, I think it's useful [01:04:54] 'kay [01:06:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98725 (owner: 10Dan-nl) [01:10:18] (03PS4) 10Aaron Schulz: Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 [01:12:12] (03PS1) 10EBernhardson: Gracefully handle invalid links when handling redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98744 [01:26:40] (03CR) 10EBernhardson: [C: 04-1] "reply action also needs a fragment, otherwise looks good" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 (owner: 10Bsitu) [01:28:21] (03PS4) 10EBernhardson: Clicking 'comment' in history should take user to the comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 (owner: 10Bsitu) [01:28:35] (03CR) 10EBernhardson: "PS4: added fragment for 'reply' action" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 (owner: 10Bsitu) [01:28:43] (03CR) 10EBernhardson: [C: 032] Clicking 'comment' in history should take user to the comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 (owner: 10Bsitu) [01:28:53] (03Merged) 10jenkins-bot: Clicking 'comment' in history should take user to the comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 (owner: 10Bsitu) [01:37:05] Anything in particular i should look at to figure out why Title::getFullURL is returning /w/index.php?title=Foo instead of /wiki/Foo ? [01:38:02] anyone know why creating an ApiMain using DerivativeRequest would not return json when format is set to json? [01:38:07] (03CR) 10Cscott: [C: 032] Improve status reporting for article/chapter processing. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98553 (owner: 10Cscott) [01:38:07] ebernhardson: are your pretty urls set up correctly? [01:38:16] dan-nl: are you calling the API internally? [01:38:21] legoktm: very possibly not, i was thinking it might just be a configuration issue [01:38:22] yes [01:38:24] (03CR) 10Cscott: [C: 032] Keep LaTeX happy even if section has no items. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98554 (owner: 10Cscott) [01:38:31] legoktm: i'm using default vagrant setup [01:38:38] legoktm: well, almost default ;) [01:38:40] (03Merged) 10jenkins-bot: Improve status reporting for article/chapter processing. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98553 (owner: 10Cscott) [01:38:41] (03CR) 10Cscott: [C: 032] Use \graphicspath to avoid overly-long graphics filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98555 (owner: 10Cscott) [01:39:04] dan-nl: you can use $api->getResult() to get the raw ApiResult object, which should work for most usecases... [01:39:05] (03Merged) 10jenkins-bot: Keep LaTeX happy even if section has no items. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98554 (owner: 10Cscott) [01:39:15] hmm [01:39:16] php> =Title::newMainPage()->getFullURL() [01:39:16] "http://127.0.0.1:8080/wiki/Main_Page" [01:39:19] legoktm: thanks! [01:39:22] ebernhardson: that's on my vagrant setup ^ [01:39:25] (03Merged) 10jenkins-bot: Use \graphicspath to avoid overly-long graphics filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98555 (owner: 10Cscott) [01:40:09] legoktm: hmm, i get that for the simpel case of Main_Page, but not for the more complex cases within flow [01:40:25] ebernhardson: like...? [01:40:37] legoktm: trying to figure out a shorter test case than just the file in flow :) sec [01:40:39] legoktm: hmm … still giving me an array with stdClass Objects … well i can use those instead ... [01:41:01] i think if you add any query string to it, it automatically switches to index.php [01:41:34] legoktm: hmm, we do add query strings to just about everything. Is that just a mediawiki restriction it sounds like? [01:41:34] (03PS2) 10Cscott: Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 [01:41:35] (03PS3) 10Cscott: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 [01:41:36] (03PS3) 10Cscott: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 [01:41:37] (03PS2) 10Cscott: Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 [01:41:38] (03PS2) 10Cscott: Make filenames "safe" before passing to image converters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98559 [01:41:39] (03PS2) 10Cscott: Only allow a single '.' in image filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98558 [01:41:40] (03PS2) 10Cscott: Fix tilde/caret when followed by numeric characters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98557 [01:41:41] (03PS2) 10Cscott: Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 [01:41:42] (03PS2) 10Cscott: Use exiftool to strip resolution information from JPEGs to avoid a LaTeX error. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 [01:41:43] (03PS4) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [01:41:47] in the request i'm putting in an array for the query params and pass in format => 'json' [01:41:53] (03CR) 10jenkins-bot: [V: 04-1] Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 (owner: 10Cscott) [01:42:07] ebernhardson: I think so. [01:42:10] (03CR) 10jenkins-bot: [V: 04-1] Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [01:42:15] dan-nl: is there a specifc reason you want JSON back? [01:42:20] there's probably a way to do it... [01:42:22] (03CR) 10jenkins-bot: [V: 04-1] Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [01:42:34] (03CR) 10jenkins-bot: [V: 04-1] Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 (owner: 10Cscott) [01:42:48] (03CR) 10jenkins-bot: [V: 04-1] Make filenames "safe" before passing to image converters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98559 (owner: 10Cscott) [01:43:14] legoktm, the code i originally wrote uses it and was curling the api, chris wants me to use DerivativeRequest instead. i'll just make the switch …. [01:43:24] ah [01:43:33] legoktm: can verify its adding the query params that turns it into the ugly urls, thanks for the tip [01:43:45] (03CR) 10jenkins-bot: [V: 04-1] Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 (owner: 10Cscott) [01:43:59] (03CR) 10jenkins-bot: [V: 04-1] Use exiftool to strip resolution information from JPEGs to avoid a LaTeX error. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 (owner: 10Cscott) [01:44:05] (03CR) 10Cscott: [C: 032] Fix tilde/caret when followed by numeric characters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98557 (owner: 10Cscott) [01:44:13] (03CR) 10jenkins-bot: [V: 04-1] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [01:44:21] (03CR) 10Cscott: [C: 032] Only allow a single '.' in image filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98558 (owner: 10Cscott) [01:44:22] ebernhardson: maybe you can turn them into pretty urls with a special page redirect like [[Special:FlowDiscussion/$id]] so people can use wikilinks instead of external ones? [01:44:32] (03Merged) 10jenkins-bot: Fix tilde/caret when followed by numeric characters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98557 (owner: 10Cscott) [01:44:52] (03Merged) 10jenkins-bot: Only allow a single '.' in image filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98558 (owner: 10Cscott) [01:45:18] legoktm: we actually had a Special:Flow before, but deprecated it since people didn't understand why there were two locations. Redirects might work though, i will mention it on the ticket [01:45:35] hmm [01:45:45] i think allowing people to link via [[wikilinks]] is important [01:45:52] really, imo /w/index.php should die :P [01:45:56] trying to find and fix outdated external links is PITA [01:46:01] wikilinks are simple [01:47:04] Krinkle: yt? [01:48:59] ori-l: yep [01:49:34] legoktm: i suppose, but unfortunatly thats a different ticket :P Right now i'm working on a ticket about how flow generates /w/index.php urls instead of /wiki/, redirecting through a special page wouldn't help because we still need query params for a variety of things like what action to take (would only work for the standard 'view' links) [01:50:00] hmm [01:50:03] i guess [01:50:06] Krinkle: with the latest patch of the resourceloader cache invalidation patch, is it not once again the case that code reverts could result in the latest definition being served with the timestamp of its previous incarnation? [01:50:51] ori-l: I'm not entirely sure, but if I understand correctly, isn't that what we wanted it to do (and didn't do at first, but with the latest patch set does) [01:51:51] well, there are two problems to solve: [01:51:54] though in case of a true revert, I think both handlings are acceptable. I was more worried about the scenario you brought up afterwards regarding data center synchronisation. [01:52:10] which it could be alternating due to cache being 1 key per module, that is now no longer the case. [01:52:16] well, but if you roll back two iterations, you might be serving the intervening one, no? [01:54:01] right now it caches with the hash itself inside the key, so it will never serve the 'wrong' timestamp or incorrectly alternate or swing back and forth or getting stuck in a short incremennt loop [01:54:09] (03PS3) 10Werdna: Limit topic titles to 260 bytes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [01:54:24] * werdna waves Krinkle, pounces [01:54:26] so as long as the memcached hasn't expired you can revert as long as back you want [01:54:31] ori-l: [01:54:41] (03CR) 10Werdna: "PS3: Add byte limit to topic title fields." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [01:54:45] -2nd as [01:55:31] werdna: no photobombing in front of my desk after midnight :P [01:55:47] my eyes might get confused :P [01:55:51] :) [01:55:56] careful, don't give me ideas. [01:56:17] Krinkle: so judging by all the rewriting you guys have done to the scroll plugin, you had to deal with scrollable areas that were not positioned? [01:56:20] werdna: I did reply to your quest for a timeslot, yes? Haven't seen an invite though [01:56:37] yeah, I haven't arranged anything yet. [01:56:40] Krinkle: OK, and taking the max of the file mtimes and the def mtimes is helpful too [01:56:55] Did you especially want a scheduled meeting? I was just going to hassle you when I saw you online and wanted an idea of when you'd be around? [01:57:19] ori-l: yeah, the definition is purely additional measurements for cases where file mtimes did not increment. It is not the sole measure. [01:57:33] e.g. when adding new files, removing old files, or re-ordering things, primarily. [01:57:53] Krinkle: I'm ready to merge it but for the omission of wfProfileIn/Out [01:58:05] I'd like to be able to keep a handle on it in prod for a while, at least [01:58:37] performance wise, or statistics wise? I did add a wgDebugLog at some point through the revision of the patch. [01:58:59] I can add wfProfileIn, not sure where though. What do you meant to measure? [01:59:30] werdna: I'm not sure, depends on your definition of positioned. The two primary cases in VE are the dialog contents and toolbar menu's. [01:59:39] Krinkle: I'll point out inline [01:59:57] werdna: Try the "Insert Media" dialog, and the "More" menu in the toolbar on mediawiki.org [02:00:12] (the menu that starts with the item for ) [02:00:30] and be sure to resize the window if needed so that the menu becomes scrollable [02:02:10] oh man, after India, London and the brief holiday break, my gerrit dashboad is booming. [02:02:16] Krinkle: positioned = "position: relative, fixed, absolute" [02:02:28] werdna: k [02:02:42] Krinkle: the thing is, that if the scrollable container is positioned [02:03:06] werdna: Exactly, it might be nested or contained to some level. But afaik the scrollable container is always positioned. [02:03:06] then the jQuery .position() property returns the position of that element relative to its scrollable container's ( scrollLeft(), scrollTop() ) [02:03:25] meaning that the dimension calculation you do in OOJS' scroll handling isn't necessary [02:04:01] Unless there is a way to simplify the logic, I'm pretty sure it is neccecary. [02:04:25] Except for very few lines, every single line has been picked up, changed and turned around to address a bug or another. [02:04:39] Especially Firefox turned out to be complicating. [02:05:01] IF the scrollable container is always positioned, then you can just use .position() and check if position().top is less than the scrollable container's height(), and position().left is less than the scrollable container's width() [02:05:05] and we're not even supporting "older" browsers. [02:05:10] but only if the scrollable container is always positioned. [02:05:13] That's the way position() works. [02:05:50] Though I don't recall the context at the moment (this is mostly other people's work in VE), we also had a need to specify the dimension direction (x or y or both) [02:06:04] Krinkle: yeah, I had the same in my version of the function [02:06:19] but yeah, if you don't want to support non-positioned scrollable elements, then I can write something that works with only positioned scrollable containers, and then I can test it on a few browsers [02:06:39] just so long as you let me know where to test (dialog contents and toolbar menus you said?), then I'll make sure it works [02:06:51] and if it doesn't then I'll have to extract out the getDimensions() function that you wrote [02:07:21] werdna: btw, is this for scroll into view or also for clippable element? [02:07:34] scroll into view, I have no clue what you're referring to with "clippable element" [02:08:30] basically, there's two things at play. Elements that become visible by scrolling the window (e.g. up or down the page), and elements that have an invisible clipping area (e.g. a parent element deeper than the window that has overflow scroll) [02:08:40] e.g. the toolbar menu in VisualEditor [02:08:42] OO.ui.ClippableElement.js [02:09:14] RoanKattouw: Do you know why we calculate border and rect in ui.Element? werdna says if the container is positioned (which afaik it always is in our case), it can be done in an easier way. [02:09:26] What he says makes sense [02:09:26] Hm.. hold on, no, those aren't connected. [02:09:31] overflow, not position. [02:09:37] If the container is positioned then .offset() will be relative to that container [02:09:43] Or more precisely, to the nearest ancestor that is positioned [02:09:51] RoanKattouw: you mean position(), right, not offset()? [02:09:58] Sorry I suppose I do [02:10:02] No, wait [02:10:08] One is one and the other is the ohter [02:10:17] Why would it need to be positioned? The scollable element nor the scrollable container don't have to be positioned. But some parent element will be, because otherwise it would've been in the natural page flow. [02:10:17] Yes [02:10:21] .position() is relative to the offset parent [02:10:26] e.g. in toolbar, the menu, nor the container ispositioned, but the toolbar itself is. [02:10:27] .offset() is relative to the document [02:10:48] right. [02:11:03] but the interesting thing is that for a scrollable element, position() is the actual position on the screen [02:11:03] actually, that isn't true either. it doesn't even need to have a positioned parent. you an have a plain div with overflow scroll. nothing fancy. [02:11:07] not the position within the scrollable area. [02:11:09] we have that in the dialog I think. [02:11:24] Krinkle: yeah, but that scrollable div will not be the offset parent unless it is positioned. [02:11:31] I figured that out the hard way on my consulting job recently. [02:11:40] werdna: It shouldn't be. .position() is relative to the offset parent, which is the nearest ancestor that's explicitly positioned [02:11:41] (03CR) 10Theopolisme: "I'm in favor of removing it completely." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [02:11:54] it needs to have a dimension (e.g. width/height), but position seems fairly unrelated. [02:12:15] I suppose Krinkle is right that you can have clippable things that aren't positioned [02:12:35] I think toolbar menus are positioned, actually [02:12:39] RoanKattouw: correct. So basically [02:12:43] if you want to scroll something into view [02:12:45] The More menu is at least [02:12:52] It's an absolutely positioned child of the "More" button [02:12:53] then the nearest scrollable container must also be the offset parent if you want to use .position() [02:12:54] and even if they're all positioned, you can't use that information directly because that data is somewhat poisoined I think due to scroll offset and overflow buffer. [02:12:59] Don't know about the format dropdown, that might not be positioned [02:13:02] otherwise you DO need to do all the calculations. [02:13:07] RoanKattouw: well, it's an easy fix though. [02:13:10] just set position: relative [02:13:11] and done. [02:13:12] Yeah [02:13:38] I suppose doing the calculations makes it more flexible though [02:13:38] (03CR) 10MarkTraceur: "Hm, that could work." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [02:13:55] You don't have to use the position:relative hack, and you can have intermediate wrappers that are positioned [02:14:08] The scrollable container need not be the direct parent [02:14:22] You would have to come up with something fairly insane I suppose [02:14:58] mmm [02:15:10] (03CR) 10Krinkle: [C: 04-1] Always send headers with a 304 response in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/74400 (owner: 10Catrope) [02:15:20] right, there isn't necessarily a downside to the calculations except complexity (and therefore susceptibility to bugs) [02:15:44] performance is key though, dimensions trigger a reflow. [02:15:55] oh? why? [02:16:04] you have to modify the DOM? [02:16:16] I know I had to do that to find the size of a scrollable area [02:16:22] no, DOM is slow in read just as it is slow in write. [02:16:30] Well, not the DOM, the paint [02:16:54] it has to repaint and reevaluate recursively for any sort of dimension related reading [02:17:02] rect calcs are among the most expensive [02:17:35] it doesn't cache, if you ask for style.anything it will force a redraw right and then so that it returns the truth. [02:17:43] remember scroll position, temporarily set overflow to whatever the normal version is, get width and height, reset overflow and scroll pos [02:17:46] lol, that was fun [02:18:00] Krinkle: so basically, you mean that dimension calcs suck for performance (could be cached?) [02:18:07] so avoid at all costs and only re-query the DOM if needed. [02:18:17] if we don't need it on each event, that'd be better. [02:18:19] (03PS4) 10Theopolisme: Update and remove unnecessary messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 [02:18:33] This isn't triggered on-scroll though, right? [02:18:36] so its' cool. [02:18:52] this is more a concern for clippable element in general (due to margins and touching of page edge), not for scroll into view. [02:19:07] scroll into view is a 'call once when you need it to happen' and done. [02:19:09] well, I don't especially need to touch clippable element [02:19:25] not for what I'm doing [02:24:46] it does seem like ui.Element.scrollIntoView is calculating a lot more than it needs. [02:25:07] well, I mean, here's the other option [02:25:16] just set the elements to position: relative in scrollIntoView [02:25:22] would it hurt anything? [02:25:24] Hm.. forget what I said about every line fixing a bug, though that may be so, I'd love to see a fresh approach. We'll test it thoroughly, but I'd say go bonkers. [02:25:39] It shouldn't need to change the 'position' of anything. [02:25:40] if so, couldn't we just change it back at the end? [02:26:00] it's supposed to be generic, changing css seems like asking for trouble. [02:26:10] I couldn't say whether it will break something, I kind of hope it does. [02:27:34] once you have the scrollable container, using offset() to determine the location and setting scrollTop should work I guess. [02:28:14] mmm [02:28:23] then you do need to factor in borders though, by the looks [02:28:36] offset() includes the border and padding but not the margin, right? [02:28:38] scrollLeft, scrollTop are also readable, assuming those are given within context, you might not even need the absolute document offset. [02:29:03] not for the inner scroll anyway. [02:29:08] well, then you get back to the position() thing – and that is relative to the offset parent [02:29:23] so if you're going to compare position()s, then you need to have the same offset parent [02:29:25] otherwise you get nonsense [02:30:37] right [02:31:13] so basically you have two options [02:31:23] I'm going in circles. Right. offset container and scrollable container are not 'related' in that either can be without the other, and should not be mixed or assumed for either. [02:31:44] the OOJS approach, which is to take the offset() of the element to scroll into view and then the offset() of the scrollable container plus its border [02:31:52] and then you compare with the height and bring it into view that way [02:31:53] OR [02:32:12] you have the scrollable container BE the offset parent (with some guarantee), and then you just scroll relative to position() [02:32:15] (03CR) 10MarkTraceur: [C: 032] "All right, I like it, let's move forward :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [02:32:23] (03Merged) 10jenkins-bot: Update and remove unnecessary messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [02:32:45] I don't much mind which way [02:32:51] 1) is more flexible; 2) is simpler. [02:32:55] what do you reckon RoanKattouw? [02:33:07] Reading scrollback [02:33:21] Krinkle: are those the options as you understand them? [02:34:16] or do you know of a third way that I'm missing? [02:34:21] In a library like oojs-ui I would prefer more flexible over simpler [02:34:47] (03PS1) 10Hiong3-eng5: Console [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/98748 [02:34:57] Consider this case [02:35:10] Let's say I have a scrollable list of things [02:35:14] And those things contain sub-things [02:35:31] It should be reasonable to invoke scrollIntoView on a sub-thing and have it work, right? [02:35:56] Now suppose the sub-things are positioned within the things [02:36:16] It's now impossible for the sub-things' offset parent to be the scrollable container while also measuring everything correctly [02:36:19] for example a horizontal list of blocks, and each block contains children relatively positioned within the block. [02:36:26] mmmmm, yeah, okay [02:36:32] that's fair. [02:36:33] e.g. a row of columns [02:36:38] I'm not saying this is especially reasonable or sane [02:36:51] But if we're writing generic code .. [02:37:07] yeah, but I get your point — I'm abusing a DOM feature to save myself calculations. [02:37:11] and that has consequences [02:37:15] which I can't necessarily predict. [02:37:40] I also hadn't thought about the idea that you might want an offset parent IN BETWEEN the scrollable container and the item to scroll into view. [02:38:43] Yeah, in that case what you want to do is actually impossible without completely screwing up the rendering (and therefore all the measurements) [02:38:45] also note that offset() and position() are also abstractions, they also involve similar calculations through getBoundingClientRect() and scroll positions and pageX/Y etc. [02:39:18] so we're basically taking the parts of those methods we need and implementing those inline where we need them in oojs-ui [02:39:49] nod [02:39:50] okay then [02:39:53] The relative-to-offset-parent stuff is native though [02:39:53] werdna: the first thing you described sounds good, though we're not doing that exactly in oojs-ui right now. It's doing a lot of other things that it probably doesn't need to. [02:39:55] You've convinced me [02:39:59] But yeah [02:40:01] Krinkle: right [02:40:05] so I can simplify the calculations [02:40:06] it uses methods that provide way too much data. [02:40:12] yeah [02:40:40] I'll also probably use an interface closer to yours, I like that better. [02:41:06] but I may keep my method for determining where to scroll to, I think it's easier to read and covers the cases better. [02:41:09] but I'll check on it [02:41:22] hopefully I'll have something to look at tomorrow / soon [02:42:15] are you two going to be at fosdem? [02:42:28] I don't think I will be [02:42:50] I'm already spending the first week of term in Australia [02:43:00] (03PS1) 10Bsitu: Fix a fatal error on topic history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98750 [02:43:23] FOSDEM is a bit less appealing now that it's 15 hours away as opposed to 5 [02:43:30] heh [02:43:59] I'm going to be in SF in feb [02:44:10] so thought I was thinking of going, not going to. [02:44:20] (03PS1) 10Legoktm: Add hook handler for GlobalCssJs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 [02:44:41] Oh, right, you'll be in SF for the arch summit so you'll be here Feb 1-2 [02:46:26] Are the links in the externallinks table supposed to be useful? Because right now, if you put http://example.com/index.php?foo=bar%26baz%3Dquux%2Bquux in an article, externallinks winds up with the very different URL http://example.com/index.php?foo=bar&baz=quux+quux. And http://example.com/index.php?foo=%25bogus goes into externallinks as http://example.com/index.php?foo=%bogus, which has a bogus percent-encoded character. [02:47:55] RoanKattouw: haha, I'm coming BEFORE the arch summit [02:48:26] Yeah I think Timo is staying after instead [02:50:06] https://meta.wikimedia.org/wiki/Research:VisualEditor%27s_effect_on_newly_registered_editors/Results [02:50:10] just been reading this [02:50:30] I'm impressed that people came up with conclusions from it, that would be a very annoying study to try to analyse [02:55:21] Krinkle / RoanKattouw: Oh, one more corner case [02:55:33] from getClosestScrollableContainer [02:56:01] you have a var props which you use to store which properties to look for 'auto' or 'scroll' [02:56:15] you set props to ['overflow'] and if a particular direction 'x' or 'y' is specified then you also add 'overflow-x' or 'overflow-y' [02:56:17] I think that's wrong [02:56:27] I think you should set props to 'overflow' and if a direction is specified then you add that direction [02:56:28] BUT [02:56:40] you should also add BOTH 'overflow-x' AND 'overflow-y' if no direction is specified./ [02:57:01] Maybe this is an oversight because we always specified a direction or something? [02:57:09] yeah, it's a corner case [02:57:18] but I just wanted to check that my logic was sound before I went around changing it :p [02:57:32] On face value it sounds like you're right [02:57:39] But I defer to Krinkle / Trevor (who went home already) [02:58:53] >> ‘Overflow’ is a shorthand. If it has one keyword, it sets both ‘overflow-x’ and ‘overflow-y’ to that keyword; if it has two, it sets ‘overflow-x’ to the first and ‘overflow-y’ to the second. [02:58:54] Krinkle: SyntaxError: Unexpected token ILLEGAL [02:58:57] "" ‘Overflow’ is a shorthand. If it has one keyword, it sets both ‘overflow-x’ and ‘overflow-y’ to that keyword; if it has two, it sets ‘overflow-x’ to the first and ‘overflow-y’ to the second. [02:59:01] http://dev.w3.org/csswg/css-box/#overflow-x [02:59:04] Tricky one [02:59:12] Browsers have been bad on that one [02:59:22] hence why we check 'overflow' separately as well [02:59:48] Checking -x and -y when using both is interesting. We might want to remove 'overflow' entirely even. [02:59:49] huh, interesting [02:59:54] Depending on how up to date browsers are [02:59:57] > alert( "MUAHAHAHA" ) [03:00:08] >> 'foo'.slice(0) [03:00:08] Krinkle: (string) 'foo' [03:00:10] >> 'foo'.slice(1) [03:00:11] Krinkle: (string) 'oo' [03:00:22] * Krinkle runs that bot on labs [03:00:35] > > 'Krinkle'.substr( 2, 3 ) [03:00:47] uses a v8 vm. no nodejs file system, no browser. [03:00:59] ecmabot-wm: source [03:00:59] Krinkle: Pop the hood, check out https://github.com/Krinkle/oftn-bot/tree/ecmabot-wm [03:01:05] > > 'Krinkle'.slice( 2, 3 ) [03:01:16] no space between > and > [03:01:20] ecmabot-wm: commands [03:01:20] Krinkle: Valid commands are: ecmabot-wm:caniuse, ecmabot-wm:ciu, ecmabot-wm:commands, ecmabot-wm:ecma, ecmabot-wm:help, ecmabot-wm:mdc, ecmabot-wm:mdn, ecmabot-wm:ping, ecmabot-wm:source [03:01:26] >> 'Krinkle'.substr( 2, 3 ) [03:01:26] werdna: (string) 'ink' [03:01:32] ecmabot-wm: help caniuse [03:01:32] Krinkle: Search the caniuse.com database. Usage: caniuse border-radius [03:01:36] ecmabot-wm: caniuse border-radius [03:01:37] Krinkle: Can I Use CSS3 Border-radius (rounded corners)? [IE3 9+ | FF3 4+ | Chrome3 5+ | Opera3 10.5+ | Safari3 5+ | iOS3 4.0-4.1+ | Android3 2.2+] Overall: 80.9% 2 [03:02:17] >> 'Krinkle'.split('') [03:02:17] werdna: (object) ['K', 'r', 'i', 'n', 'k', 'l', 'e'] [03:02:45] >> 'Krinkle'.split('').splice( 0, 2, 'S', 't' ).join() [03:02:46] werdna: (string) 'K,r' [03:02:55] ahh damn [03:02:58] ecmabot-wm: ecma strict mode [03:02:58] Krinkle: Found: 10.1.1 Strict Mode Code [03:03:09] ecmabot-wm: ecma isNaN [03:03:09] Krinkle: Found: 15.1.2.4 isNaN (number) [03:03:12] >> 'Krinkle'.split('').push( 'St' ).join() [03:03:12] werdna: TypeError: Object 8 has no method 'join' [03:03:36] ecmabot-wm: ecma Array.prototype.push [03:03:36] Krinkle: Found: 15.4.4.7 Array.prototype.push ( [ item1 [ , item2 [ , … ] ] ] ) [03:03:45] push returns the length, right? [03:03:53] Yes [03:04:01] need a variarble [03:04:10] >> ( function(arr) { arr.splice( 0, 2, 'St' ); return arr; } )( 'Krinkle'.split('') ).join('') [03:04:11] werdna: (string) 'Stinkle' [03:04:15] finally! [03:04:20] or a function :P [03:04:43] ahh closures [03:04:55] it's what tempts unwary programmers into hell [03:04:57] x = 0.1 + 0.2; x = String(x).split(); x.unshift('x'); x.toString(); [03:05:03] >> x = 0.1 + 0.2; x = String(x).split(); x.unshift('x'); x.toString(); [03:05:03] Krinkle: (string) 'x,0.30000000000000004' [03:05:20] >> x = 0.1 + 0.2; x = String(x).split(); x.splice(4, 0, 'x'); x.join(); [03:05:20] Krinkle: (string) '0.30000000000000004,x' [03:06:01] >> x = 0.1 + 0.2; x = String(x).split(''); x.splice(4, 0, 'x'); x.join('') [03:06:01] Krinkle: (string) '0.30x000000000000004' [03:06:04] >> 'RoanKattouw'.replace( 'touw', 'tuin' ) [03:06:04] werdna: (string) 'RoanKattuin' [03:06:06] much better. [03:06:24] RoanKattouw can be a cat garden. [03:06:30] >> 999999999999999 [03:06:30] Krinkle: (number) 999999999999999 [03:06:32] >> 9999999999999999 [03:06:32] Krinkle: (number) 10000000000000000 [03:06:36] magically increasing numbers :) [03:07:01] such a broken toy [03:07:13] but we luv it anyway, don't we [03:08:02] (the number shift is required by standard, IEEE double floating point precision etc. etc.) [03:09:01] floating point numbers are the spawn of the devil [03:09:03] at least, so I hear. [03:09:50] btw, if you haven't seen it already, more of these exposed quirks at https://twitter.com/TimoTijhof/status/376982052236570624 [03:10:23] oh btw [03:10:34] what's the "right" place for CSS reference [03:10:50] I always end up on w3schools [03:10:53] but, like [03:10:54] ew [03:10:56] w3schools [03:11:08] mdn whenever possible, also css-tricks.com almanac is good. [03:11:21] and, once it is more complete, WebPlatform.org [03:11:33] mdn has lots of css docs, not just js [03:11:50] yeah, I do use mdn a lot [03:21:18] top = parseFloat( style ? style.borderTopWidth : $el.css( 'borderTopWidth' ) ) || 0 [03:21:19] hmph [03:21:32] why doesn't $el.css( 'borderTopWidth' ) do the trick? [03:22:36] There was some reason for that [03:22:41] I think Krinkle wrote that? [03:22:53] I assume this is a browser compatibility thing [03:24:15] That may have been inherited from that scrollIntoView plugin [03:24:23] Trevor kept tearing out more and more of the original code to fix bugs [03:24:34] heh, wheeee [03:25:07] I realise why you guys wrote so much of your own stuff. It's a bit NIHy, but by god some of the stuff invented elsewhere is bad :P [03:25:21] every time I take a library I have to apply at least one or two bugfixes [03:25:39] Yeah so we tried to not be NIHy with this one [03:25:49] But came to regret it more every day as we found out more of it was crap [03:26:03] Like, the ClippableElement thing? [03:26:10] That whole feature doesn't even exist in Google Docs, for instance [03:26:44] If you open the heading dropdown in a height-constrained gdocs instance, it goes beyond the window and you *cannot reach* the lower dropdown items because scrolling scrolls the document rather than the viewport [03:27:07] wooo [03:27:27] So we wrote a mixin to address that problem and slapped it on a bunch of things [03:27:37] And after sorting out some of the initial math wonkiness, it worked great [03:28:02] RoanKattouw: I changed it to use style. instead of el., didn't introduce that logic though [03:28:05] I'm not saying every case is like that, but in some cases it just seems like no one on the internet has even thought of the conecpt [03:28:09] NIH is not invented here. [03:28:20] RoanKattouw: which is really weird. [03:28:24] I suppose other people have before [03:28:25] werdna: might be an optimisation [03:28:27] it's just that the code is closed [03:28:29] Krinkle: Yeah I blamed it and found it was introduced in Trevor's initial import [03:28:31] since we already have the style object [03:28:32] Right [03:28:36] No one on the open source internet [03:28:47] And even most of the closed source internet as far as we're concerned (gdocs) [03:28:50] Krinkle: shrug, I just took the function and $.fn-ified it [03:29:00] not messing with something I don't understand [03:29:09] the borders are necessary anyway [03:29:23] If you're $.fn-ifying it maybe we should drop it from OO.ui and use only that version? [03:29:31] hey, random question, when you call offset() on an element that is above the scrollTop() of its container… does the offset() pretend that it's above the container? [03:29:45] RoanKattouw: yeah, well, I imagine there'll be some OOUI refactoring to do once I'm finished with this [03:30:04] I can help out with that but you guys know what you want OOUI to look like so I don't want to mess toooo much with it [03:30:15] I guess this will end up being a few modules [03:30:18] RoanKattouw: Yes, i proposed earlier (last week) that werdna's result of merging these 2 or 3 implementations should be a standalone jquery plugin [03:30:35] which we'd maintain separately and ship in a bunch of places [03:30:37] the jquery.scroll handler plus some other utils that will end up in some file or other [03:32:48] werdna: Are you available tomorrow (Tuesday) between 11am and 6pm PST? [03:32:56] definitely not 11am [03:33:05] but I will be online around, what, 3 or 4 PST [03:33:11] that's 10 to 11 Sydney time [03:33:17] We have an OOUI sprint then [03:33:21] o rly [03:33:40] I guess Flow is likely to want to use OOUI [03:33:47] so it might be worth me popping along [03:34:44] (03CR) 10Krinkle: Add hook handler for GlobalCssJs (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 (owner: 10Legoktm) [03:34:51] Well it's a UI standardization thing more generally [03:34:58] Where Flow and Mobile people have been showing up [03:35:19] For us VE folk it's OOUI work but technically it's the 3rd "MediaWiki UI hack day" [03:35:52] might be worth participating [03:36:41] Yeah if you're messing with UI stuff I recommend you at least pop in for a bit [03:37:05] It's just people hacking and eating pizza and talking to each other, with remote people (Matt F, Krinkle, possibly you) on the hangou [03:39:45] (03PS2) 10Legoktm: Add hook handler for GlobalCssJs [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 [03:39:49] (03CR) 10Legoktm: Add hook handler for GlobalCssJs (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98751 (owner: 10Legoktm) [03:42:21] (03CR) 10MarkAHershberger: [C: 032] "Sanity" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97192 (owner: 10MarkAHershberger) [03:46:24] (03CR) 10Chad: "Next time, please +2 and wait for jenkins to merge, rather than +2 & submit." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97192 (owner: 10MarkAHershberger) [03:48:02] (03CR) 10MarkAHershberger: "I didn't realize that merging happened on submit. Thought that kicked off jenkins. thanks!" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97192 (owner: 10MarkAHershberger) [03:49:11] hexmode: You gonna do master as well? :-) [03:54:11] (03PS7) 10Legoktm: Load scripts and styles via ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [03:56:43] (03PS1) 10Tim Starling: ExternalStoreDB: update for PHP 5 [core] - 10https://gerrit.wikimedia.org/r/98754 [03:57:49] (03PS1) 10Yaron Koren: Added handling for simple arrays (holding just a group of values) in JSON [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98755 [03:58:50] (03CR) 10Yaron Koren: [C: 032 V: 032] Added handling for simple arrays (holding just a group of values) in JSON [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98755 (owner: 10Yaron Koren) [04:04:09] (03CR) 10MZMcBride: "Steven: your action here isn't consistent with consensus and isn't reasonable." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:05:44] StevenW: I'm a bit confused why you're able to -2 core. [04:05:51] I can't find any code contributions from you. [04:06:56] Elsie: Anyone in the wmf ldap group has +2/-2 on basically all repos not including operations/* [04:08:09] Who's in the WMF LDAP group? [04:08:24] Anyone who works at WMF? [04:09:11] Basically [04:09:55] Brilliant. [04:10:29] It's how I got +2 :D [04:17:37] (03CR) 10Dzahn: "re: "unnecessary instruction cruft such warnings not to share your password, to beware of phishing, or reminders to pick a strong password" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:19:41] (03CR) 10MZMcBride: "I added Tim and Brion to this changeset in the hope that one of them can wield a clue-by-four and settle this." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:21:22] (03PS5) 10MZMcBride: Adding HiDPI 'Heart' SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 (owner: 10Sniok) [04:28:10] Elsie: sorry you disagree, and am happy to have Brion or Tim weigh in. [04:28:38] But restoring a message nobody asked to be restored, and which we removed purposefully before, is grounds for -2 in my book. [04:28:50] StevenW: I added a follow-up comment. [04:29:00] It's not clear why you can -2 on core. [04:29:05] It seems to be accidental. [04:29:08] Or incidental, maybe. [04:29:12] legoktm: explained it clearly [04:29:18] it's not an accident at all [04:29:48] StevenW: So you're a developer and you're doing code review? [04:29:54] I actually have merged a couple patches in Core so far without anybody peeing their pants, so it seems so. [04:30:28] StevenW: Seriously? -2? I'm sorry, but "There are only two possibilities with signupend" excludes the very important "Some non-WMF sites may well require it". If you fear the human problem of "someone might put something in there on one of our projects and we don't want to" fix the human problem, don't impose the limitation on every third party. [04:30:29] When you say "you disagree," it feels like you're discounting the half-dozen other people who disagree. [04:31:07] * Elsie shrugs. [04:31:14] I can't keep having this same argument, it isn't healthy. :-) [04:33:35] Coren: I think it's possible resolve that part of the issue and remove my -2. The disabling is one possibility, though I don't like seeing the UX fork on WMF/non-WMF installations. [04:34:07] Like I said in my comment, the -2 was for reinstating a message no one asked to be reinstated, and which we removed intentionally months ago. [04:34:30] https://wikitech.wikimedia.org/wiki/MediaWiki:Signupstart [04:34:40] i'm not sure we can have that requirement that people need to ask for stuff to be kept [04:34:44] (03PS1) 10EBernhardson: Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 [04:34:55] Is there a formal application to submit on behalf of Labs? [04:34:58] It uses Signupstart. [04:34:59] (03CR) 10jenkins-bot: [V: 04-1] Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [04:35:17] Elsie: I'm talking about signupend. I already agreed we need to support Labs' use case. [04:35:30] Hehhhhhhh. You kill me. [04:35:44] StevenW: The problem is that you're seeing it as a strictly UX issue -- it isn't. Removing in on our projects is, indeed, a UX decision (and one, I might add, I probably agree with). Imposing that decision on every non-WMF mediawiki install out there is pointless at best. [04:35:46] I laughing a little. [04:35:52] I'm [04:35:58] Coren: this is a form users use. It is a UX issue. [04:36:14] Anyone who puts something before the user experience is full of shit and should be shot. [04:36:29] Anyway, it's 8:30 on a Monday. I'll see y'all tomorrow. [04:36:35] Bye. [04:36:41] * Coren groans. [04:37:16] I can't remember which was added second. [04:37:31] I think Signupstart or end previously existed and they were added because it made for a logical pair. [04:37:38] FFS, I have about a dozen various mediawiki installs I administer. The idea that "oh, that message is bad UX we'll just disable it" generally bugs me when I wear that hat. [04:37:46] a non-wmf admin using mediawiki has some experience as well [04:38:47] (03PS5) 10Tholam: Site logo loaded using UserSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [04:39:33] Elsie: https://github.com/wikimedia/mediawiki-core/commit/463f2535817ff2b576038963775a44050274ee0d [04:39:37] > Add signupstart to Userlogin.php per request of MZMcBride [04:40:09] Right. [04:40:12] I think I just found end. [04:40:36] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/11896 [04:40:38] Sort of. [04:42:27] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/2359 [04:45:58] (03CR) 10coren: [C: 031] ""There are only two possibilities with signupend" is an excluded middle fallacy, at best. There is at least one third possibility: non-WM" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:48:56] legoktm: I did the full history on the bug. [04:48:59] the fuck is superfish [04:49:02] and why is it loading on my wiki [04:49:07] https://bugzilla.wikimedia.org/show_bug.cgi?id=56455#c41 [04:49:19] Isn't superfish a name for fancy JS tabs? [04:49:35] http://users.tpg.com.au/j_birch/plugins/superfish/ [04:49:41] could be a chrome extension I have [04:49:43] http://users.tpg.com.au/j_birch/plugins/superfish/examples/ [04:49:45] Maybe. [04:50:40] yay [04:50:55] (sarcastic yay) [04:51:21] andrew-macbook:core andrew$ ack -i superfish [04:51:23] gives nothing [04:51:25] must be a chrome extension [04:51:42] Elsie kindly asked me to review a divisive issue with 30 bug comments and about 40 gerrit comments [04:52:00] was very nice of him [04:52:02] thanks Elsie! [04:52:14] what is this? the signup form message thing? [04:52:20] (03PS6) 10Tholam: Site logo loaded using UserSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [04:52:24] yes [04:53:02] hexmode says he found 5-10% of wikis are using those messages .. a considerable number that is [04:53:18] TimStarling: No problem. :-) [04:53:28] I'm not sure I understand the need to remove a message that's being used, but that's just my first blush impression [04:53:34] I don't think it's more than a few minutes' worth of work. [04:54:32] TimStarling: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/2359 is from the youthful days of timstarling, BTW. [04:54:58] hehe [04:55:13] I'm the relevant developer then? [04:55:15] note "has now been merged into REL1_22" [04:56:01] There were/are four distinct messages. (signup|login)(start|end). Not sure what the status of all four is these days. [04:57:13] I proposed removing page counters from MediaWiki core. [04:57:21] But there's resistance. [04:59:03] (03CR) 10Parent5446: Optimized LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [05:02:47] (03CR) 10Chad: "Well somebody decided to overrule my -2 on here without even the courtesy of saying so. I'm out...I've wasted enough time on this already." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [05:06:57] (03PS2) 10EBernhardson: Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 [05:15:25] (03CR) 10Parent5446: "Swalling's -2 disappeared as well, even though the Gerrit review history doesn't say so." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [05:16:41] DRAMA [05:16:43] woooooo [05:18:19] i believe anyone with +2 can just hit the X and remove any other reviewer (and their vote) [05:18:26] no? [05:22:02] nooo idea. [05:22:29] (03PS4) 10Werdna: Add new jquery.scroll.js plugin. [core] - 10https://gerrit.wikimedia.org/r/96949 [05:22:29] <^d> yes. but it's mainly meant for technical reasons, like when jenkins is being stupid. [05:22:35] well, when i hover over names in the reviewer list, i could do that [05:22:38] but i wouldnt [05:22:43] ack [05:23:12] * werdna shrugs [05:23:18] I have no idea why this changeset is such a big deal. [05:23:39] RoanKattouw_away / Krinkle|detached: grrrit-wm: (PS4) Werdna: Add new jquery.scroll.js plugin. [core] - https://gerrit.wikimedia.org/r/96949 [05:32:11] (03PS12) 10Ori.livneh: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [05:36:43] (03CR) 10Tim Starling: [C: 031] "My recommendation is to merge this, and also to run a bot across all WMF wikis to blank the signupstart and signupend MediaWiki namespace " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [05:45:31] (03PS1) 10Werdna: Add relatively paranoid input sanitisation to BasicDbStorage. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98759 [05:45:52] (03PS13) 10Ori.livneh: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [05:47:32] (03PS2) 10Werdna: Add relatively paranoid input sanitisation to BasicDbStorage. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98759 [05:49:38] (03CR) 10Tim Starling: [C: 04-1] "Just a minor issue. Also, it needs another manual rebase." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [05:50:02] that's the opposite of interpose? [05:50:14] to put something on both ends of something [05:50:56] wrap [05:51:24] that works [05:52:12] (03CR) 10Ori.livneh: [C: 032] "I added release notes and wrapped ResourceLoaderModule::getDefinitionMtime with wfProfile* calls." [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [05:54:53] (03CR) 10Amire80: [C: 032] i18n: Update SVG [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [05:55:08] (03Merged) 10jenkins-bot: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [05:56:38] Hello. I´ve mediawiki installed using vagrant. For installing git-review when I logged into the VM and ran ´pip install git-review´, it said Requirement already satisfied. But when I run ´git-review -s´ , it says it cannot connect to gerrit. http://imgur.com/7Je610a [05:56:59] What could be the problem? [06:00:38] (03CR) 10Legoktm: resourceloader: Add definition hashing to improve cache invalidation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [06:04:18] (03CR) 10Parent5446: "I'm not sure what happened to Swalling's -2, but if there are no further objections by tomorrow afternoon, I'll merge this." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [06:09:30] legoktm: ah, good catch, thanks [06:10:05] (03CR) 10Parent5446: [C: 031] API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [06:11:40] :) [06:14:07] (03PS1) 10Ori.livneh: Added wfProfileOut for early returns in ResourceLoaderModule::getDefinitionMtime [core] - 10https://gerrit.wikimedia.org/r/98760 [06:16:28] (03CR) 10Legoktm: [C: 032] Added wfProfileOut for early returns in ResourceLoaderModule::getDefinitionMtime [core] - 10https://gerrit.wikimedia.org/r/98760 (owner: 10Ori.livneh) [06:19:22] (03Merged) 10jenkins-bot: Added wfProfileOut for early returns in ResourceLoaderModule::getDefinitionMtime [core] - 10https://gerrit.wikimedia.org/r/98760 (owner: 10Ori.livneh) [06:59:20] (03CR) 10Swalling: "The -2 from Chad and myself was clearly removed somehow. The latest update I saw was MZMcBride updating the patchset to re-request review," [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [07:03:32] (03CR) 10Legoktm: "http://code.google.com/p/gerrit/issues/detail?id=1300" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [07:30:18] (03CR) 10Siebrand: Collapse topic (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [07:36:24] (03CR) 10Calak: [C: 031] ""أ" is not common, for example it is not available on Kurdish alphabet; I prefer "و"." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [07:40:18] (03CR) 10Siebrand: "Awesome work. Yay for the war on feature creep :)." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [07:42:13] (03CR) 10Siebrand: "@amir: This extension does not appear to have Jenkins test and merge jobs configured. If you intended to merge, you should also +2 Verifie" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [07:48:41] (03CR) 10Gergő Tisza: [C: 031] js-error-output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [07:50:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [07:51:24] (03CR) 10Amire80: [V: 032] "@siebrand: Yes, that's what I thought. Thanks to everybody for the updates and the reviews." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [07:57:13] (03CR) 10Eloquence: "So, this has been merged into the release branch, and is no longer a blocker for the tarball release. There doesn't appear to be legitimat" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [08:04:04] (03PS1) 10Nikerabbit: [1.23wmf5] Translate to wmf/1.23wmf5 branch [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98765 [08:07:13] (03PS1) 10Nikerabbit: [1.23wmf4] Translate to wmf/wmf1.23wmf4 branch [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98766 [08:07:57] (03PS1) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [08:08:34] (03CR) 10Nikerabbit: [C: 032] [1.23wmf5] Translate to wmf/1.23wmf5 branch [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98765 (owner: 10Nikerabbit) [08:08:46] (03CR) 10Nikerabbit: [C: 032] [1.23wmf4] Translate to wmf/wmf1.23wmf4 branch [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98766 (owner: 10Nikerabbit) [08:12:46] (03Merged) 10jenkins-bot: [1.23wmf5] Translate to wmf/1.23wmf5 branch [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98765 (owner: 10Nikerabbit) [08:14:21] (03Merged) 10jenkins-bot: [1.23wmf4] Translate to wmf/wmf1.23wmf4 branch [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98766 (owner: 10Nikerabbit) [08:15:03] (03CR) 10Gergő Tisza: [C: 031] mime-type [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98725 (owner: 10Dan-nl) [08:41:30] (03CR) 10Gergő Tisza: [C: 031] table-create [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98735 (owner: 10Dan-nl) [08:42:19] (03PS1) 10Santhosh: Handle explicit plural forms in custom convertPlural in language classes [core] - 10https://gerrit.wikimedia.org/r/98768 [08:46:16] (03CR) 10Malvineous: [C: 04-1] "I haven't had a chance to test this yet, but I will, although there are a couple of minor issues that will need to be fixed before the cod" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 (owner: 10Netbrain) [08:46:29] (03CR) 10Santhosh: "I submitted a fresh version of this patch at I2a9f93567087babb896999f1214d3c56afc67c96 by keeping Wizardist as author." [core] - 10https://gerrit.wikimedia.org/r/62149 (owner: 10Wizardist) [08:52:26] (03PS1) 10Amire80: Add GENDER support to flow-topic-comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 [08:56:39] (03CR) 10Netbrain: "If wifi drops out, the user would be presented with a generic error message. And the server would no longer recieve api calls for new page" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 (owner: 10Netbrain) [08:57:35] (03CR) 10Netbrain: [C: 031] "I guess you can merge this, by clicking "publish and submit"" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [08:58:44] (03PS2) 10Amire80: Add GENDER support to flow-topic-comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 [09:08:29] (03PS2) 10Santhosh: Handle explicit plural forms in custom convertPlural in language classes [core] - 10https://gerrit.wikimedia.org/r/98768 [09:15:37] (03CR) 10Siebrand: Add GENDER support to flow-topic-comments (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 (owner: 10Amire80) [09:17:38] (03PS1) 10Mayankmadan: Changing readme so it points to mediawiki-selenium [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98770 [09:18:18] (03PS1) 10Hashar: jobs for mw/ext/VectorBeta [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98771 [09:18:36] (03CR) 10Hashar: [C: 032] jobs for mw/ext/VectorBeta [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98771 (owner: 10Hashar) [09:19:01] (03Merged) 10jenkins-bot: jobs for mw/ext/VectorBeta [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98771 (owner: 10Hashar) [09:20:00] (03PS1) 10Hashar: triggers for VectorBeta [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98772 [09:20:21] (03CR) 10Hashar: [C: 032] triggers for VectorBeta [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98772 (owner: 10Hashar) [09:20:27] (03Merged) 10jenkins-bot: triggers for VectorBeta [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98772 (owner: 10Hashar) [09:21:23] (03PS1) 10Mayankmadan: Adding readme file in /tests/browser/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98773 [09:21:52] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98774 [09:24:09] (03PS1) 10Hashar: mwext-VectorBeta-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98775 [09:24:27] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [09:24:55] (03CR) 10Hashar: [C: 032] mwext-VectorBeta-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98775 (owner: 10Hashar) [09:25:04] (03Merged) 10jenkins-bot: mwext-VectorBeta-jslint is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98775 (owner: 10Hashar) [09:25:22] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98774 (owner: 10Hashar) [09:25:25] (03PS1) 10Mayankmadan: Changing README in tests/browser/ to make it point to mediawiki-selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 [09:28:10] yurik: there? [09:28:17] ... [09:28:49] yurik: on https://gerrit.wikimedia.org/r/#/c/98481/. What should be done? [09:50:22] (03CR) 10Siebrand: [C: 04-1] Don't localize Special:CentralAutoLogin (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [09:54:59] (03PS2) 10Siebrand: Fix sitename use in section description [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 (owner: 10MarkTraceur) [09:55:04] (03CR) 10Siebrand: [C: 032] Fix sitename use in section description [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 (owner: 10MarkTraceur) [09:55:13] (03Merged) 10jenkins-bot: Fix sitename use in section description [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 (owner: 10MarkTraceur) [09:58:25] (03PS1) 10Siebrand: Use numParams for correct i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/98788 [09:58:48] (03CR) 10Siebrand: Fix sitename use in section description (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 (owner: 10MarkTraceur) [10:05:56] (03CR) 10Nikerabbit: [C: 032] Use numParams for correct i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/98788 (owner: 10Siebrand) [10:06:00] (03Merged) 10jenkins-bot: Use numParams for correct i18n [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/98788 (owner: 10Siebrand) [10:31:25] hi andre__ [10:36:58] any idea how in PHP I can find whether a variable is defined ? [10:37:05] aka: $myVar = null ; [10:37:14] isset() check whether it is not NULL so that doesn't work :D [10:38:13] well could look at $GLOBALS [10:39:11] hashar: why do you want to do that? :/ [10:39:22] hi liangent [10:40:04] array_key_exists( compact( $varName ) ) seems like it might work [10:40:05] let me try [10:40:29] yep [10:40:29] that works [10:40:34] hashar: > $myvar = null [10:40:35] > print_r( compact( 'myvar', 'myvar2' ) ) [10:40:37] Array [10:40:38] ( [10:40:40] [myvar] => [10:40:41] ) [10:41:13] andre__: MatmaRex told me that newly created tasks by me in GCI remain in unpublished state, so I can draft up stuff there. just want to confirm that whether this is true [10:41:28] liangent, yes, that's correct :) [10:41:51] or even array_key_exists( 'myvar', get_defined_vars() ) [10:42:06] andre__: so how can I notify you when it's ready? [10:42:18] liangent, ping qgil and me? :) [10:42:33] liangent, however I recommend not to draft for too long [10:42:54] I sometimes just flushed the unpublished ones by publishing them, hence good to know that you are "working" on tasks first. [10:43:09] werdna: never heard of compact() before :-D [10:43:22] werdna: seems handy for some corner cases. thx! [10:44:37] andre__: ok and another question, can I add project specific tasks, eg Lua module porting / coding for zhwiki requiring a bit Chinese knowledge [10:44:47] this may makes things a little unfair [10:45:15] (btw is it fair to require English everywhere :p not just in GCI) [10:45:35] liangent: if you make it crystal-clear in the task descriptions what requirements are needed (e.g. Chinese language skills that are close to being a native speaker) I don't see any problem [10:46:06] liangent: it's more about clearly defining the requirements, to avoid misunderstanding or misexpectation on both sides (mentor and student) [10:48:55] andre__: fine. do we have stats about origin country or native language of students? [10:49:08] liangent, no we don't have [10:49:21] but we can let students fail if they obviously ignored task requirements. [10:52:11] (03CR) 10Hashar: "Might have caused bug 57916 "Fatal error getSecondaryDataUpdates() on a non-object". Spotted on beta." [core] - 10https://gerrit.wikimedia.org/r/98071 (owner: 10Aaron Schulz) [10:52:16] (03CR) 10Hashar: "Might have caused bug 57916 "Fatal error getSecondaryDataUpdates() on a non-object". Spotted on beta." [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [10:55:59] (03CR) 10Malvineous: "I will definitely do so, I just want to confirm it works as expected (by actually testing it) before I put my stamp of approval on it!" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [10:58:18] (03CR) 10Malvineous: "Would it be possible to change the generic error message to end with "retry?" to give the user time to reconnect wi-fi and resume the oper" [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 (owner: 10Netbrain) [11:02:28] (03PS2) 10Aude: Update Wikibase [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97784 [11:04:33] (03CR) 10Tim Starling: "> The -2 from Chad and myself was clearly removed somehow. The latest update I saw was MZMcBride updating the patchset to re-request revie" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [11:11:36] (03CR) 10Matthias Mullie: [C: 032] Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [11:11:49] (03Merged) 10jenkins-bot: Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [11:20:31] (03CR) 10Matthias Mullie: [C: 032] Gracefully handle invalid links when handling redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98744 (owner: 10EBernhardson) [11:20:41] (03Merged) 10jenkins-bot: Gracefully handle invalid links when handling redlinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98744 (owner: 10EBernhardson) [11:28:59] (03CR) 10Siebrand: [C: 04-1] "Partial i18n/L10n review done." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [11:34:58] (03CR) 10Zfilipin: [C: 04-1] Check that anons do not see Actions or Block User links (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 (owner: 10Cmcmahon) [11:36:51] (03CR) 10Nikerabbit: [C: 04-1] "Essentially +2 except for minor nitpicks from me." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/98768 (owner: 10Santhosh) [11:38:25] (03CR) 10Zfilipin: [C: 04-1] experimental fix for Bug 57702 (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98732 (owner: 10Cmcmahon) [11:44:21] (03CR) 10Nikerabbit: [C: 032] jquery.spinner: Improve documentation formatting [core] - 10https://gerrit.wikimedia.org/r/98378 (owner: 10Bartosz Dziewoński) [11:47:26] (03Merged) 10jenkins-bot: jquery.spinner: Improve documentation formatting [core] - 10https://gerrit.wikimedia.org/r/98378 (owner: 10Bartosz Dziewoński) [11:56:39] (03PS3) 10Daniel Kinzler: Document parser cache key control. [core] - 10https://gerrit.wikimedia.org/r/98512 [12:14:08] (03CR) 10Amire80: Add GENDER support to flow-topic-comments (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 (owner: 10Amire80) [12:15:12] (03PS3) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [12:17:55] (03CR) 10Amire80: Better GENDER support in moderation.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [12:19:16] (03CR) 10Helder.wiki: jquery.spinner: Improve documentation formatting (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98378 (owner: 10Bartosz Dziewoński) [12:19:31] (03PS3) 10Santhosh: Handle explicit plural forms in custom convertPlural in language classes [core] - 10https://gerrit.wikimedia.org/r/98768 [12:25:00] (03CR) 10Siebrand: [C: 04-1] "Per PS2." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [12:34:43] (03CR) 10Zfilipin: [C: 031] Adding readme file in /tests/browser/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98773 (owner: 10Mayankmadan) [12:39:04] (03CR) 10Zfilipin: [C: 031] Changing README in tests/browser/ to make it point to mediawiki-selenium [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [12:40:35] (03CR) 10Zfilipin: [C: 031] Changing readme so it points to mediawiki-selenium [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98770 (owner: 10Mayankmadan) [12:45:28] (03CR) 10Zfilipin: [C: 031] Merging the readme files of other repositories with this one. [selenium] - 10https://gerrit.wikimedia.org/r/98577 (owner: 10Mayankmadan) [12:50:04] (03PS4) 10Nikerabbit: Handle explicit plural forms in custom convertPlural in language classes [core] - 10https://gerrit.wikimedia.org/r/98768 (owner: 10Santhosh) [13:00:14] (03CR) 10Aude: [C: 031] Document parser cache key control. [core] - 10https://gerrit.wikimedia.org/r/98512 (owner: 10Daniel Kinzler) [13:01:17] hashar: easy review --^ [13:20:46] (03CR) 10Nikerabbit: [C: 032] Handle explicit plural forms in custom convertPlural in language classes [core] - 10https://gerrit.wikimedia.org/r/98768 (owner: 10Santhosh) [13:21:42] (03CR) 10Zfilipin: [C: 04-1] "The code looks good and works fine on my machine, but it causes a lot of deprecation warnings." (037 comments) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [13:23:43] (03Merged) 10jenkins-bot: Handle explicit plural forms in custom convertPlural in language classes [core] - 10https://gerrit.wikimedia.org/r/98768 (owner: 10Santhosh) [13:25:59] (03Abandoned) 10Nikerabbit: (Bug 46422) convertPlural makes using 0= and 1= rules impossible [core] - 10https://gerrit.wikimedia.org/r/62149 (owner: 10Wizardist) [13:31:41] (03PS1) 10Siebrand: Break long lines and suppress false posive [core] - 10https://gerrit.wikimedia.org/r/98805 [13:36:13] (03PS1) 10Dan-nl: derivative-request [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98807 [13:39:04] (03PS1) 10Siebrand: Fix comment [core] - 10https://gerrit.wikimedia.org/r/98808 [13:40:04] (03PS2) 10Siebrand: Fix comment [core] - 10https://gerrit.wikimedia.org/r/98808 [13:40:10] (03PS1) 10Bartosz Dziewoński: jquery.spinner: Wrestling with JSDuck [core] - 10https://gerrit.wikimedia.org/r/98809 [13:40:31] (03CR) 10Bartosz Dziewoński: jquery.spinner: Improve documentation formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98378 (owner: 10Bartosz Dziewoński) [13:40:49] (03CR) 10Bartosz Dziewoński: [C: 032] "Trivial whitespace doc change, let's see if this fixes the display." [core] - 10https://gerrit.wikimedia.org/r/98809 (owner: 10Bartosz Dziewoński) [13:44:20] (03CR) 10coren: "In re "provides the best user experience for both Wikimedia and non-Wikimedia users", I don't think that's a given." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [13:46:46] (03Merged) 10jenkins-bot: jquery.spinner: Wrestling with JSDuck [core] - 10https://gerrit.wikimedia.org/r/98809 (owner: 10Bartosz Dziewoński) [13:51:40] andre__: could you please approve this task? (thanks) https://www.google-melange.com/gci/task/view/google/gci2013/5799508969521152 [13:52:23] zeljkof, sure, done [13:52:31] andre__: thanks! [13:54:30] (03CR) 10Bartosz Dziewoński: jquery.spinner: Improve documentation formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98378 (owner: 10Bartosz Dziewoński) [14:00:05] (03PS1) 10Siebrand: Update some documentation [core] - 10https://gerrit.wikimedia.org/r/98810 [14:01:32] (03CR) 10Anomie: Don't localize Special:CentralAutoLogin (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [14:03:40] siebrand: https://translatewiki.net/w/i.php?title=MediaWiki:Action-oversight/zh-hans&action=edit is missing? [14:03:42] see https://zh.wikipedia.org/wiki/Special:Oversight?uselang=qqx [14:04:40] (03CR) 10Siebrand: Don't localize Special:CentralAutoLogin (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [14:04:54] anomie: Sorry, don't have a better answer than the above. [14:05:38] liangent: I assume that's the Oversight extensions. That's been deprecated for the past 4 years or so, and hasn't been supported on translatewiki.net since. [14:05:51] s/extensions/exgension/ [14:06:43] liangent: Take your pick from https://translatewiki.net/w/i.php?title=Special%3ASearch&profile=advanced&search=oversight&fulltext=Search&ns90=1&redirs=1&profile=advanced [14:08:27] siebrand: well it seems it's still not deprecated as a viewer [14:08:45] liangent: yes, very much unfortunately. [14:10:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n changes trivial. Removal of qqq is not really necessary. It's discouraged, because it increases chances of merge conflicts. See " [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98807 (owner: 10Dan-nl) [14:12:40] (03PS1) 10Siebrand: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/98811 [14:13:37] (03PS1) 10Dan-nl: augmentAllowedExtensions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98812 [14:15:14] siebrand: So how do you add an aliases file that isn't included in translatewiki? Is there an example of this anywhere? [14:16:03] anomie: Just register a second file with aliases, and add a comment in the file that those aliases should not be translated. [14:16:46] anomie: They're not automatically discovered, but manually added to a configuration, so that will work. [14:25:27] (03CR) 10Siebrand: "Pointed out passing a non-existing class property." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [14:31:16] (03PS6) 10Anomie: Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 [14:35:56] (03PS7) 10Anomie: Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 [14:36:27] (03CR) 10Anomie: "PS6: Rebase for RELEASE-NOTES-1.23" [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [14:36:47] (03PS1) 10Siebrand: Update formatting for log related classes [core] - 10https://gerrit.wikimedia.org/r/98815 [14:38:14] (03CR) 10Siebrand: [C: 031] "i18n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [14:47:00] (03CR) 10Anomie: [C: 032] "Please don't forget to do the API bit." [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [14:50:19] (03Merged) 10jenkins-bot: Show minor edits and tags in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [14:58:26] (03PS1) 10Matthias Mullie: Introduce tipsy [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98820 [14:59:12] (03PS1) 10Siebrand: Localise brackets in log entry [core] - 10https://gerrit.wikimedia.org/r/98821 [14:59:13] (03PS1) 10Siebrand: Break long lines in logging related classes [core] - 10https://gerrit.wikimedia.org/r/98822 [15:07:24] (03PS1) 10Dan-nl: PreviewFrom [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98825 [15:07:25] (03PS1) 10Cscott: Update commander/when/mocha dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98826 [15:07:26] (03PS1) 10Cscott: Switch all github URLs to point to official wikimedia mirror. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98827 [15:07:27] (03PS1) 10Cscott: Release version 0.1.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98828 [15:08:51] (03PS1) 10Zfilipin: Moved Wikibase Selenium tests to /tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/98829 [15:09:27] (03CR) 10Zfilipin: "Do not merge into master until this is also merged:" [selenium] - 10https://gerrit.wikimedia.org/r/98829 (owner: 10Zfilipin) [15:20:04] (03Abandoned) 10Zfilipin: WIP Test central-domain login, cross-domain login and central login for anons [qa/browsertests] - 10https://gerrit.wikimedia.org/r/74128 (owner: 10Zfilipin) [15:20:44] (03Abandoned) 10Zfilipin: WIP Feature: Cache [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78234 (owner: 10Zfilipin) [15:21:04] (03CR) 10Zfilipin: "please reopen if I am wrong" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/74128 (owner: 10Zfilipin) [15:22:27] (03PS2) 10Zfilipin: WIP moving login code to the gem [selenium] - 10https://gerrit.wikimedia.org/r/97036 [15:23:40] (03PS4) 10Cmcmahon: Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 [15:23:53] (03PS5) 10Cmcmahon: Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 [15:24:02] (03PS1) 10Cscott: Update commander/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 [15:24:03] (03PS1) 10Cscott: Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 [15:24:27] (03CR) 10jenkins-bot: [V: 04-1] Update commander/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 (owner: 10Cscott) [15:24:45] (03CR) 10jenkins-bot: [V: 04-1] Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 (owner: 10Cscott) [15:28:16] (03CR) 10Cscott: [C: 032] Update commander/when/mocha dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98826 (owner: 10Cscott) [15:28:28] (03CR) 10Cscott: [C: 032] Switch all github URLs to point to official wikimedia mirror. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98827 (owner: 10Cscott) [15:28:36] (03CR) 10Cscott: [C: 032] Release version 0.1.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98828 (owner: 10Cscott) [15:29:15] (03PS1) 10Hashar: limit beta jobs history to 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98832 [15:29:23] (03Merged) 10jenkins-bot: Update commander/when/mocha dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98826 (owner: 10Cscott) [15:29:51] (03CR) 10Hashar: [C: 032] limit beta jobs history to 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98832 (owner: 10Hashar) [15:30:11] (03Merged) 10jenkins-bot: limit beta jobs history to 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98832 (owner: 10Hashar) [15:30:30] (03Merged) 10jenkins-bot: Switch all github URLs to point to official wikimedia mirror. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98827 (owner: 10Cscott) [15:31:35] (03Merged) 10jenkins-bot: Release version 0.1.0. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98828 (owner: 10Cscott) [15:37:08] (03PS1) 10Dan-nl: FOR_PUBLIC [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98835 [15:43:02] (03PS4) 10Matthias Mullie: Improve error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 [15:43:04] (03PS2) 10Matthias Mullie: Improve non-JS display of edit-(header|title|post) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98547 [15:43:06] (03PS1) 10Matthias Mullie: [WIP] Edit conflicts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 [15:43:08] (03PS1) 10Cscott: Rename npm package to mw-ocg-bundler. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98837 [15:43:23] (03CR) 10Cscott: [C: 032] Rename npm package to mw-ocg-bundler. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98837 (owner: 10Cscott) [15:44:04] (03Abandoned) 10Cmcmahon: experimental fix for Bug 57702 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98732 (owner: 10Cmcmahon) [15:46:42] (03Merged) 10jenkins-bot: Rename npm package to mw-ocg-bundler. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98837 (owner: 10Cscott) [15:54:04] (03PS1) 10Cscott: Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 [15:54:21] (03CR) 10jenkins-bot: [V: 04-1] Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 (owner: 10Cscott) [15:56:09] (03PS1) 10Cscott: Bump version in package.json. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98843 [15:56:10] (03PS1) 10Cscott: Use mw-ocg-bundler as binary name, and consistently in documentation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98844 [15:59:40] marktraceur: mark, when you have time can you check if my last commit is alright ? [16:02:03] (03CR) 10Manybubbles: [C: 04-1] "I think this is the wrong file to change. The one in tests/browser makes more sense. Also I think we'll need to keep a bunch of the inst" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [16:04:28] !logs [16:04:29] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [16:05:34] (03CR) 10Siebrand: Improve error messages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 (owner: 10Matthias Mullie) [16:06:24] (03CR) 10Gergő Tisza: [C: 031] FOR_PUBLIC [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98835 (owner: 10Dan-nl) [16:06:26] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 (owner: 10Matthias Mullie) [16:07:35] (03Restored) 10Greg Grossmeier: WIP Feature: Cache [qa/browsertests] - 10https://gerrit.wikimedia.org/r/78234 (owner: 10Zfilipin) [16:08:08] vandrew: Sure! It should be "when I get into the office", so keep your hat on :) [16:08:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98836 (owner: 10Matthias Mullie) [16:09:19] marktraceur: Thanks [16:09:31] (03PS1) 10Manybubbles: Don't spawn to update links if there aren't any [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98845 [16:11:32] (03CR) 10Daniel Kinzler: [C: 032] Break long lines and suppress false posive [core] - 10https://gerrit.wikimedia.org/r/98805 (owner: 10Siebrand) [16:16:30] (03Merged) 10jenkins-bot: Break long lines and suppress false posive [core] - 10https://gerrit.wikimedia.org/r/98805 (owner: 10Siebrand) [16:18:00] (03CR) 10Legoktm: "I'm not really a fan of hooks with :'s in them, but I can't really think of a better name either." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [16:18:36] (03CR) 10Chad: [C: 032] Don't spawn to update links if there aren't any [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98845 (owner: 10Manybubbles) [16:18:40] (03Merged) 10jenkins-bot: Don't spawn to update links if there aren't any [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98845 (owner: 10Manybubbles) [16:19:35] (03PS1) 10Dan-nl: original-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98846 [16:23:09] (03CR) 10Chad: [C: 032] Fix comment [core] - 10https://gerrit.wikimedia.org/r/98808 (owner: 10Siebrand) [16:26:25] (03Merged) 10jenkins-bot: Fix comment [core] - 10https://gerrit.wikimedia.org/r/98808 (owner: 10Siebrand) [16:26:42] (03CR) 10Siebrand: [C: 04-1] "Per comments from Lego and Tyler." [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [16:27:54] (03CR) 10Siebrand: [C: 04-1] "Adding -1 so I won't be coming back here each time I scan my list of incoming reviews." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 (owner: 10Amire80) [16:33:41] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 (owner: 10Legoktm) [16:44:51] (03CR) 10Anomie: [C: 031] "Code looks ok. Haven't tested." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [16:50:46] (03CR) 10Aaron Schulz: [C: 032] ExternalStoreDB: update for PHP 5 [core] - 10https://gerrit.wikimedia.org/r/98754 (owner: 10Tim Starling) [16:51:14] (03CR) 10Jhall: [C: 031] Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 (owner: 10Cmcmahon) [16:54:09] (03Merged) 10jenkins-bot: ExternalStoreDB: update for PHP 5 [core] - 10https://gerrit.wikimedia.org/r/98754 (owner: 10Tim Starling) [16:56:03] (03CR) 10Matthias Mullie: [C: 032] Limit topic titles to 260 bytes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [16:56:22] (03Merged) 10jenkins-bot: Limit topic titles to 260 bytes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [16:58:08] (03CR) 10Jhall: [C: 031] Changing readme so it points to mediawiki-selenium [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98770 (owner: 10Mayankmadan) [16:59:17] (03PS1) 10Aaron Schulz: Fixed field name [core] - 10https://gerrit.wikimedia.org/r/98850 [16:59:34] (03CR) 10Cscott: [V: 032] Bump version in package.json. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98843 (owner: 10Cscott) [17:01:03] (03CR) 10Aaron Schulz: [C: 032] Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/98811 (owner: 10Siebrand) [17:02:19] (03CR) 10Cscott: [C: 032] Bump version in package.json. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98843 (owner: 10Cscott) [17:02:30] (03PS2) 10Cscott: Use mw-ocg-bundler as binary name, and consistently in documentation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98844 [17:02:34] (03CR) 10Aaron Schulz: [C: 032] Fixed field name [core] - 10https://gerrit.wikimedia.org/r/98850 (owner: 10Aaron Schulz) [17:03:17] (03PS2) 10Cscott: Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 [17:04:00] (03Merged) 10jenkins-bot: Bump version in package.json. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98843 (owner: 10Cscott) [17:04:25] (03Merged) 10jenkins-bot: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/98811 (owner: 10Siebrand) [17:04:40] (03CR) 10Swalling: "> If MZMcBride removed you as a reviewer by clicking the "x" next to your name, then re-added you, that would have reset your review level" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [17:04:46] (03CR) 10Aaron Schulz: [C: 032] Update some documentation [core] - 10https://gerrit.wikimedia.org/r/98810 (owner: 10Siebrand) [17:04:48] (03CR) 10jenkins-bot: [V: 04-1] Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 (owner: 10Cscott) [17:05:32] ori-l: So, the profile calls, what are those for? I'd expect that method to be somewhat trivial in execution (composing an array using only values already stored in properties, hashing it, and interacting once with the object cache). Not a completely trivial return, but doesn't seem like a typical thing we wrap in profile calls either. [17:07:10] (03Merged) 10jenkins-bot: Fixed field name [core] - 10https://gerrit.wikimedia.org/r/98850 (owner: 10Aaron Schulz) [17:07:57] vandrew: It's super close, and I'm sorry we're stuck in such a long code review pipeline :( [17:08:51] (03CR) 10Matthias Mullie: Add GENDER support to flow-topic-comments (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98769 (owner: 10Amire80) [17:10:22] (03Merged) 10jenkins-bot: Update some documentation [core] - 10https://gerrit.wikimedia.org/r/98810 (owner: 10Siebrand) [17:10:55] (03PS3) 10Nikerabbit: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 [17:11:57] (03CR) 10Siebrand: "Static code analysis for the win! :)" [core] - 10https://gerrit.wikimedia.org/r/98850 (owner: 10Aaron Schulz) [17:12:35] (03CR) 10Krinkle: "For the record: An older version of this patch (still pending review) was backported and self-merged to REL1_22. Please keep that in mind " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [17:13:35] (03CR) 10Nikerabbit: New hook MessageCache::get (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [17:15:16] (03CR) 10CSteipp: [C: 031] FOR_PUBLIC [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98835 (owner: 10Dan-nl) [17:17:02] (03CR) 10Siebrand: "Hmm, too late. I was just about to suggest that we should try to say goodbye to byte length and go for character length. Maybe we still ca" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [17:19:01] (03CR) 10CSteipp: "I do care! I'm just not sure what needs to happen / change for this to be added." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/74128 (owner: 10Zfilipin) [17:19:16] marktraceur: how should I name the variable ? [17:19:31] vandrew: I gave you several options [17:20:40] (03CR) 10Jforrester: resourceloader: Add definition hashing to improve cache invalidation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [17:21:49] (03CR) 10Siebrand: "Bug 57933 -- Implement limitations based on characters instead of bytes" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [17:22:15] marktraceur: yes, I saw the comments now [17:24:00] (03CR) 10Matthias Mullie: "Sure, makes sense. In this case, we're not limited to a certain amount of bytes in DB, so that change shouldn't be too hard." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98737 (owner: 10EBernhardson) [17:24:31] (03PS1) 10Aaron Schulz: Make sure $content is always defined [core] - 10https://gerrit.wikimedia.org/r/98851 [17:25:37] (03CR) 10Siebrand: [C: 04-1] New hook MessageCache::get (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [17:25:49] (03CR) 10Umherirrender: "There is a normal software update plan for wmf sites, so you can merge this and when it is deployed to all wikis, you can merge the corres" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [17:28:01] (03CR) 10Legoktm: New hook MessageCache::get (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [17:28:06] ^d: https://gerrit.wikimedia.org/r/#/c/98851/1 [17:28:16] (03CR) 10BryanDavis: [C: 032] FOR_PUBLIC [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98835 (owner: 10Dan-nl) [17:28:32] (03PS2) 10UltrasonicNXT: {{NUMBEROFCOMMENTSPAGE}} magic word/parser funct [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 [17:28:52] (03Merged) 10jenkins-bot: FOR_PUBLIC [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98835 (owner: 10Dan-nl) [17:29:13] (03CR) 10UltrasonicNXT: "Sure. Forgetting about docs is certainly something I am guilty of..." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 (owner: 10UltrasonicNXT) [17:29:45] (03CR) 10Chad: [C: 032] Make sure $content is always defined [core] - 10https://gerrit.wikimedia.org/r/98851 (owner: 10Aaron Schulz) [17:30:26] (03CR) 10Siebrand: [C: 031] New hook MessageCache::get (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [17:32:50] (03Merged) 10jenkins-bot: Make sure $content is always defined [core] - 10https://gerrit.wikimedia.org/r/98851 (owner: 10Aaron Schulz) [17:33:10] marktraceur: I should use git review -d 98180 since it was rebased yes ? [17:33:57] (03CR) 10Krinkle: [C: 04-1] Add new jquery.scroll.js plugin. (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [17:34:20] (03CR) 10CSteipp: [C: 032] "That's ugly. But if that's what it takes let's do it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [17:34:58] (03Merged) 10jenkins-bot: Don't localize Special:CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [17:35:27] (03CR) 10CSteipp: [C: 031] augmentAllowedExtensions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98812 (owner: 10Dan-nl) [17:37:37] (03PS3) 10Aaron Schulz: Added support to img_auth.php for non-repo containers [core] - 10https://gerrit.wikimedia.org/r/95304 [17:38:22] (03CR) 10Matthias Mullie: "I noticed the patch is still WIP (missing i18n msgs, one-line & -collapsed look the same), so didn't review too thoroughly yet." (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [17:38:47] vandrew: Yeah, good idea [17:38:57] marktraceur: one more thing [17:39:02] about the too many var [17:39:51] Yeah? [17:40:20] what should I do to resolve this problem ? [17:40:50] vandrew: You should only declare variables in one statement in the function. You can initialise them anywhere, but there should only be one "var" keyword in each scope. [17:40:58] oh I see [17:41:11] I will initialisade the in down [17:41:21] So probably move your lines after the existing statement and put your new variable there. [17:43:04] (03CR) 10Matthias Mullie: [C: 032] Fix menu icon position for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98552 (owner: 10Amire80) [17:43:06] marktraceur: so I can move my lines and add , after the else } [17:43:10] yep ? [17:43:24] (03PS1) 10Daniel Kinzler: assertValidHtml for checking html in test cases. [core] - 10https://gerrit.wikimedia.org/r/98853 [17:44:11] (03Merged) 10jenkins-bot: Fix menu icon position for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98552 (owner: 10Amire80) [17:44:13] (03CR) 10Zfilipin: "The first step is to apply for Pair programming Friday for fun and profit! :)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/74128 (owner: 10Zfilipin) [17:45:46] Uh [17:45:47] * marktraceur looks [17:46:10] wait, I'll give you a pastebin link [17:46:22] vandrew: No, you should move your if/else blocks after the var statement [17:46:32] And you should declare your variable in the existing var statement. [17:46:57] (03CR) 10Zfilipin: "All repos that have selenium tests should have a link to mediawiki-selenium gem, that is all we wanted to do with this change. I still vot" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [17:47:54] marktraceur: but the link is assigned in the var the existing var statement [17:48:22] (03CR) 10Matthias Mullie: [C: 032] Add RTL images for the flag icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98572 (owner: 10Amire80) [17:48:32] (03Merged) 10jenkins-bot: Add RTL images for the flag icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98572 (owner: 10Amire80) [17:49:10] marktraceur: right under $owField = $( '' ) which is in the existing var statement [17:49:13] vandrew: Then move the assignment out of the existing var statement [17:49:25] marktraceur: ok [17:49:36] Or write a ternary statement to set the variable so you can do it all in one [17:49:47] (03CR) 10Matthias Mullie: [C: 032] Sysops should not have the flow-suppress permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98580 (owner: 10EBernhardson) [17:49:57] (03Merged) 10jenkins-bot: Sysops should not have the flow-suppress permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98580 (owner: 10EBernhardson) [17:53:52] (03PS2) 10Manybubbles: Clean up test documentation [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [17:54:29] marktraceur: linkPrefix = this.$useFile.data( 'repoInfo' ) ? mw.config.get( 'wgServer' ) : new String(), [17:55:09] vandrew: : '', would be fine [17:55:16] No need to bring *constructors* into the fray [17:55:21] ok [17:57:11] (03CR) 10CSteipp: [C: 031] mime-type [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98725 (owner: 10Dan-nl) [17:57:17] (03PS1) 10Siebrand: Use protocol relative URL [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/98854 [17:57:52] (03CR) 10Manybubbles: "I've uploaded a version that moves the reference into the README under test/browser that I like better. It also conforms to the stuff men" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98776 (owner: 10Mayankmadan) [17:58:31] (03PS2) 10BryanDavis: augmentAllowedExtensions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98812 (owner: 10Dan-nl) [17:58:40] (03CR) 10BryanDavis: [C: 032] augmentAllowedExtensions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98812 (owner: 10Dan-nl) [17:58:46] (03Merged) 10jenkins-bot: augmentAllowedExtensions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98812 (owner: 10Dan-nl) [17:58:53] marktraceur: one more thing , after using git review -d 98180 what should I use in order to add as a new build to /r/#/c/98180/ [17:59:18] git review -R is telling me that I am going to submig multiple commits [18:00:28] vandrew: Do git fetch --all && git review -R [18:01:24] vandrew: Your indentation is still bad. You need to use tabs, not spaces. [18:01:53] yes [18:01:54] (03PS2) 10BryanDavis: mime-type [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98725 (owner: 10Dan-nl) [18:01:58] I forgot to do that in the other file [18:02:05] (03CR) 10BryanDavis: [C: 032] mime-type [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98725 (owner: 10Dan-nl) [18:02:11] (03Merged) 10jenkins-bot: mime-type [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98725 (owner: 10Dan-nl) [18:02:28] And you "should" use $.data( 'isLocal', repoInfo.local ) instead, for clarity [18:02:57] ok [18:03:06] Or some day, I'll be looking at some data attribute somewhere and thinking "ooh, I know! I have the repoinfo here, I can just use that!", and it will break horribly [18:03:47] (03CR) 10Matthias Mullie: Set a global cache time within Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [18:03:49] that wouldn't be too good [18:04:19] Indeed [18:05:28] (03PS1) 10Amire80: Corrected the spelling of language name 'cu' [core] - 10https://gerrit.wikimedia.org/r/98855 [18:06:08] (03CR) 10Matthias Mullie: [C: 031] Wire up the buffered cache to db transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [18:06:52] (03CR) 10EBernhardson: Set a global cache time within Flow (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [18:08:14] (03CR) 10Ebrahim: "What is blocking this really?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97507 (owner: 10Ebrahim) [18:11:04] (03CR) 10Matthias Mullie: [C: 031] Native digits on 'notification-page-linked-bundle' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97507 (owner: 10Ebrahim) [18:12:27] (03PS1) 10M4tx: Add an SVG version of watch icon [core] - 10https://gerrit.wikimedia.org/r/98856 [18:13:32] (03CR) 10Qgil: [C: 031] "This seems to be a simple patch, but I haven't tested it." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 (owner: 10Legoktm) [18:18:58] (03CR) 10Yurik: Ported some initial files from Zero extension (032 comments) [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 (owner: 10Yurik) [18:20:08] (03PS2) 10Yurik: Ported some initial files from Zero extension [extensions/JsonConfig] - 10https://gerrit.wikimedia.org/r/98767 [18:23:31] <^d> MatmaRex: You didn't review my code :( [18:25:53] ;_; [18:26:48] (03CR) 10Nikerabbit: [C: 032] Use protocol relative URL [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/98854 (owner: 10Siebrand) [18:26:51] (03Merged) 10jenkins-bot: Use protocol relative URL [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/98854 (owner: 10Siebrand) [18:26:52] ^d: don't expect anything from me on mondays and tuesday, my schedule on these days rather sucks [18:26:59] (03CR) 10Chad: "One minor nit, otherwise lgtm." (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98463 (owner: 10BryanDavis) [18:27:04] just came back home (it's 7:30 pm) [18:27:07] <^d> MatmaRex: Gotcha :) [18:27:26] (03PS1) 10Siebrand: Maitenance for logging related classes [core] - 10https://gerrit.wikimedia.org/r/98859 [18:27:57] gwicke: any change to look at https://gerrit.wikimedia.org/r/#/c/98067/1 today? [18:29:39] (03PS2) 10BryanDavis: Use PHPMailer to send mail [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98463 [18:30:15] (03CR) 10BryanDavis: Use PHPMailer to send mail (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98463 (owner: 10BryanDavis) [18:30:45] (03CR) 10Chad: [C: 032] Use PHPMailer to send mail [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98463 (owner: 10BryanDavis) [18:30:49] (03Merged) 10jenkins-bot: Use PHPMailer to send mail [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98463 (owner: 10BryanDavis) [18:32:33] (03CR) 10MarkAHershberger: "Krinkle, that doesn't match what I see in my freshly-checked-out REL1_22. It has the updated patch without the config var." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [18:32:37] marktraceur: I think I've resolved all the problems [18:32:43] Iiiinteresting [18:32:48] vandrew: I'm excited to see it [18:33:44] (03PS3) 10EBernhardson: Collapse topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 [18:35:41] (03CR) 10Krinkle: "This patch is still open, so it is outdated in that sense. It is still variable and pending review. I don't know if this was an emergency " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [18:42:22] (03CR) 10MarkAHershberger: "I'm doing the final RC today. Agreed that this isn't the normal workflow and that things should land in master first." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [18:43:13] (03CR) 10EBernhardson: "Shoudl be ready for full review now" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [18:43:35] (03CR) 10EBernhardson: Collapse topic (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [18:44:46] Aaron|home: will try to slot it in [18:47:43] (03PS1) 10Bsitu: Timestamp in history page gets into show/hide loop on hoverOver [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98860 [18:50:25] (03CR) 10Chad: [C: 032] Cleanup DAO layer [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98024 (owner: 10BryanDavis) [18:50:29] (03Merged) 10jenkins-bot: Cleanup DAO layer [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98024 (owner: 10BryanDavis) [18:50:58] (03CR) 10Chad: [C: 032] Allow configuration of log destination [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98305 (owner: 10BryanDavis) [18:51:09] (03Merged) 10jenkins-bot: Allow configuration of log destination [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98305 (owner: 10BryanDavis) [18:51:59] (03CR) 10Chad: [C: 032] Cleanup and fix javascript [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97752 (owner: 10BryanDavis) [18:52:06] (03Merged) 10jenkins-bot: Cleanup and fix javascript [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97752 (owner: 10BryanDavis) [18:52:24] ^d: \o/ for merges [18:52:32] (03PS2) 10EBernhardson: Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 [18:56:40] (03CR) 10CSteipp: [C: 031] "Thanks!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98759 (owner: 10Werdna) [18:57:48] (03CR) 10Chad: [C: 04-1] Allow config loading from file (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 (owner: 10BryanDavis) [19:00:16] <^d> bd808: I thought about suggesting json ^, but I figured it'd make https://gerrit.wikimedia.org/r/#/c/98740/7/modules/wikimania_scholarships/templates/env.erb way more annoying :p [19:01:45] (03PS1) 10EBernhardson: Better UUID error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98861 [19:02:20] ^d: I get your point about the complexity that I introduced there. I'll put my 12factors hat back on the shelf and do something more simple. [19:03:19] <^d> :) [19:03:40] merged all the stuffs! [19:03:48] <^d> All but 1 [19:03:50] (03PS1) 10Ebrahim: i18n: Localized user right labels [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98863 [19:03:55] :/ [19:05:42] greg-g: Can I get an LD window for today? Need to fix an oversight in a config change that went out yesterday (VE on svwiktionary) [19:06:53] aude: He picked the right one to reject. I'll get it fixed [19:10:02] (03PS1) 10Bsitu: Revision will be null if user does not have viewing permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98867 [19:10:44] (03CR) 10Aude: "agree with Chad. too much evil regex and think config handling could be more simple." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 (owner: 10BryanDavis) [19:11:56] RoanKattouw: yeah, plz add to calendar [19:12:06] <^d> aude: Not worrying about MW coding style toooooo much right now. [19:12:28] <^d> Long as it's sane and readable I'm fine with letting Bryan format how he sees fit and not waste time on spacing & so forth. [19:12:43] (03PS1) 10Krinkle: Create macro for csslint and use in oojs-ui and VisualEditor [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98868 [19:12:46] heh [19:13:15] consistency is nice though, but i can turn a blind eye sometimes [19:13:22] (03PS2) 10Krinkle: Create macro for csslint and use in oojs-ui and VisualEditor [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98868 [19:13:48] (03PS1) 10Kaldari: Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 [19:14:18] I've tried to be MW style I think, but my eye doesn't always see the missing spaces yet [19:14:58] (03PS3) 10BryanDavis: Allow config loading from file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 [19:15:01] (03CR) 10jenkins-bot: [V: 04-1] Allow config loading from file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 (owner: 10BryanDavis) [19:15:07] greg-g: [[wikitech:Deployments]]? [19:15:39] RoanKattouw: yessir [19:15:43] k [19:15:48] Also adding a cherry-pick for blacklisting IE11 [19:16:06] <^d> bd808: Long as we can read it I'm not going to be a stickler. [19:16:12] Reedy: as you may know, Core features team is going to deploy Flow tomorrow on a handful of pages on mediawiki.org. I added yo as a reviewer to 94106, I think the steps are https://www.mediawiki.org/wiki/Flow_Portal/2013-12_Devployment#Deploy_steps . Anything else we should do in advance? [19:16:22] <^d> :) [19:16:25] PHP Warning: Invalid argument supplied for foreach() in /usr/local/apache/common-local/php-1.23wmf5/includes/cache/CacheDependency.php on line 56 [19:16:25] PHP Fatal error: Call to undefined method WikitextContent::getLevel() in /usr/local/apache/common-local/php-1.23wmf5/extensions/ProofreadPage/includes/page/EditProofreadPagePage.php on line 250 [19:17:07] 1st one has a bug [19:17:52] <^d> 2nd one is ProofreadPage ;-) [19:17:54] PP needs updating [19:18:03] dejavu [19:18:16] (03Draft6) 10AndyRussG: On Special:Contributions, mention EP roles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98183 [19:19:17] YuviPanda: ping [19:19:31] CONFLICT (submodule): Merge conflict in extensions/MobileFrontend [19:19:33] gwicke: moment, in a meeting [19:19:40] k [19:19:47] will send a mail [19:20:01] (03PS4) 10BryanDavis: Allow config loading from file [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 [19:22:02] (03PS1) 10Ragesoss: Make the deletion-related messages for courses and institutions clear [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98874 [19:22:37] (03CR) 10BryanDavis: Allow config loading from file (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 (owner: 10BryanDavis) [19:23:14] (03PS3) 10Aude: Update Wikibase [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97784 [19:23:21] (03PS2) 10Ragesoss: Make the deletion-related messages for courses and institutions clear [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98874 [19:23:32] Reedy: https://gerrit.wikimedia.org/r/#/c/97784/ [19:23:55] (03PS1) 10Reedy: Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98875 [19:24:18] (03CR) 10Reedy: [C: 032 V: 032] Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98875 (owner: 10Reedy) [19:26:12] (03PS4) 10Reedy: Update Wikibase [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97784 (owner: 10Aude) [19:26:13] ^d: looks like proofread page is going nuts! [19:26:21] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97784 (owner: 10Aude) [19:26:40] <^d> Hm? For search? [19:26:49] I don't think it is us [19:26:59] going nuts? [19:27:03] but I think it is us [19:27:10] lots more logs in fatals [19:27:21] <^d> Reporting what Sam's in the process of fixing? [19:27:22] Those are now fixed [19:27:23] fatal.log [19:27:29] hmm let me see [19:27:34] 419 PHP Fatal error: Call to a member function inNamespace() on a non-object in /usr/local/apache/common-local/php-1.23wmf5/extensions/ProofreadPage/ProofreadPage. [19:27:34] body.php on line 232 [19:27:35] Oh shit [19:27:37] (03CR) 10Aude: [C: 031] "not verified or tried this, but looks good" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98354 (owner: 10BryanDavis) [19:27:51] yeah, I think you deployed it and it broke [19:27:53] roll back? [19:27:55] huh [19:27:57] (03CR) 10Krinkle: [C: 032] "Deployed mwext-VisualEditor-csslint and oojs-ui-csslint." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98868 (owner: 10Krinkle) [19:28:02] superm401: https://gerrit.wikimedia.org/r/98878 [19:28:04] proofread page is one extension i've never tried [19:28:13] oh [19:28:26] manybubbles: It was already broke [19:28:27] partially [19:28:29] <^d> manybubbles: zhwikisource, hewikisource? Totally not Cirrus. [19:28:34] <^d> Reedy: I f'ing hate that extension. [19:28:45] ^d: yeah. not us. I was just watching fatals in case [19:28:49] Reedy: coudl it be that proofread page needs the $wgContentHandlerUseDB = true? [19:28:55] 'cause I'm still running jobs [19:29:01] it should be fine with it false, though [19:29:16] * aude thinks $wgContentHandlerUseDB should be true everywhere now :) [19:29:19] it wasn't blowing up at nearly this rate until just a few minutes ago [19:29:41] <^d> $wgTitle? Mother of god. [19:29:52] <^d> Figures. [19:30:18] $in_index_namespace = $wgParser->getTitle()->inNamespace( self::getIndexNamespaceId() ); [19:30:41] less blowing up now [19:30:48] I think it stopped [19:30:53] aude: wgContentHandlerUseDB requires a lot of schema changes [19:31:04] I reverted most of the wikis that are using proofreadpage back to 1.23wmf4 [19:31:04] (03PS2) 10Kaldari: Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 [19:31:12] Tpt__: ProofreadPage is even more broken! [19:31:24] (03CR) 10Aaron Schulz: (bug 35607) Fix OXML type detection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/70830 (owner: 10VitaliyFilippov) [19:31:31] * Reedy finds a stack trace to go with it [19:31:36] Reedy: Sorry :-( What is the issue? [19:31:43] it is still sputtering but mostly done [19:31:55] aude: PHP Fatal error: Class 'Wikibase\Repo\Specials\UserBlockedError' [19:31:58] You fixed that one, right? [19:32:08] Tpt__: maybe not more broken, just more frequently broken [19:32:41] (03CR) 10Bsitu: [C: 032] Better UUID error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98861 (owner: 10EBernhardson) [19:33:14] Reedy: deploy the backports [19:33:26] Right [19:33:29] Shit got broken ;) [19:33:33] https://gerrit.wikimedia.org/r/#/c/97784/ [19:33:37] (03Merged) 10jenkins-bot: Better UUID error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98861 (owner: 10EBernhardson) [19:33:48] blocked users shouldn't use our special pages, but anyway.... [19:34:06] Tpt__: https://bugzilla.wikimedia.org/show_bug.cgi?id=57942 [19:35:11] (03PS1) 10Tpt: Revert "Should fix an issue where qualityX classes are not add to links" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98884 [19:35:20] (03PS1) 10Ori.livneh: Unconditionally insert shop link via PHP [extensions/WikimediaShopLink] - 10https://gerrit.wikimedia.org/r/98885 [19:35:22] Reedy: https://gerrit.wikimedia.org/r/#/c/98884/ [19:36:16] if ( !isset( $wgTitle ) ) { [19:36:20] scary code is scary [19:36:23] (03CR) 10Aaron Schulz: [C: 032] Break long lines in logging related classes [core] - 10https://gerrit.wikimedia.org/r/98822 (owner: 10Siebrand) [19:36:41] dont' use $wgTitle :) [19:36:44] don't* [19:36:54] gwicke: I didn't remember to mention this yesterday but presumably you saw the 'onlyinclude' parsoid bug filed on friday or saturday? [19:36:57] * aude is not familiar with the extension, though [19:37:08] <^d> aude: I don't know what other title to use there. [19:37:15] I just want to make sure someone's aware of it, because due to that logging is turned off in puppet for the parsoids [19:37:36] it lacks context [19:37:38] it seems [19:37:44] <^d> GetLinkColours doesn't pass a title. [19:37:46] aude: yes, it's the issue [19:37:51] hook is called from LinkHolderArray [19:37:55] which is parser stuff [19:37:59] <^d> Which doesn't really want or need a context :) [19:38:08] yeah [19:38:14] (03CR) 10Aaron Schulz: [C: 032] Localise brackets in log entry [core] - 10https://gerrit.wikimedia.org/r/98821 (owner: 10Siebrand) [19:38:19] <^d> Well, LinkHolderArray doesn't need a singular title. [19:38:22] i would need to understand that part of the code better [19:38:23] (03CR) 10Mattflaschen: "See https://gerrit.wikimedia.org/r/#/c/98869 , a similar follow-up that proposes a new module." [core] - 10https://gerrit.wikimedia.org/r/87296 (owner: 10Mattflaschen) [19:38:27] <^d> Hence the "Array" part of the name ;-) [19:38:27] right [19:39:37] <^d> Might need to use the main request context here :\ [19:39:40] gwicke: back [19:39:47] :/ [19:40:11] gwicke: want me to respond to the email or respond here? [19:40:20] <^d> aude: It'd shut up the fatals. [19:40:28] <^d> But I wouldn't be able to sleep well tonight :p [19:40:54] It's a recent change that cause the problem [19:41:00] So at least reverting that... [19:41:00] (03CR) 10Aaron Schulz: [C: 032] Update formatting for log related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98815 (owner: 10Siebrand) [19:41:17] I've created the reverting change: https://gerrit.wikimedia.org/r/#/c/98884/1 [19:42:23] (03CR) 10Parent5446: "I'm pretty sure we have reached a consensus on this, and Swalling has not re-added his -2, so I'm tempted to believe there is nothing else" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:42:36] Reedy: Could you review it? [19:43:12] That is what is happening in here ;) [19:43:21] Thanks :-) [19:43:21] (03PS5) 10Jdlrobson: POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 [19:43:55] (03PS2) 10Reedy: Revert "Should fix an issue where qualityX classes are not add to links" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98884 (owner: 10Tpt) [19:44:15] (03Merged) 10jenkins-bot: Break long lines in logging related classes [core] - 10https://gerrit.wikimedia.org/r/98822 (owner: 10Siebrand) [19:44:16] (03Merged) 10jenkins-bot: Localise brackets in log entry [core] - 10https://gerrit.wikimedia.org/r/98821 (owner: 10Siebrand) [19:44:17] (03Merged) 10jenkins-bot: Update formatting for log related classes [core] - 10https://gerrit.wikimedia.org/r/98815 (owner: 10Siebrand) [19:44:57] bd808: is https://gerrit.wikimedia.org/r/#/c/87650/2 fine? There is lots of code I could cleanup using that. [19:45:30] (03PS3) 10Reedy: Revert "Should fix an issue where qualityX classes are not add to links" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98884 (owner: 10Tpt) [19:45:36] (03CR) 10Reedy: [C: 032] Revert "Should fix an issue where qualityX classes are not add to links" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98884 (owner: 10Tpt) [19:46:30] Aaron|home: Sure. I think it needs tests but that's not a deal breaker [19:47:03] (03PS3) 10BryanDavis: Added MapCacheLRU class, a simpler cousin to ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/87650 (owner: 10Aaron Schulz) [19:47:18] (03CR) 10BryanDavis: [C: 032] Added MapCacheLRU class, a simpler cousin to ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/87650 (owner: 10Aaron Schulz) [19:47:20] (03CR) 10jenkins-bot: [V: 04-1] POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [19:48:20] (03CR) 10Aaron Schulz: "RepoGroup and such classes basically duplicate this logic" [core] - 10https://gerrit.wikimedia.org/r/87650 (owner: 10Aaron Schulz) [19:48:35] gaaah [19:48:41] what's this? [19:48:41] F:\mediawiki\core>scp gerrit.wikimedia.org:hooks/commit-msg commit-msg [19:48:41] @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ [19:48:41] @ WARNING: POSSIBLE DNS SPOOFING DETECTED! @ [19:48:41] @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ [19:48:47] NSA! NSA! [19:49:04] (03Merged) 10jenkins-bot: Revert "Should fix an issue where qualityX classes are not add to links" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98884 (owner: 10Tpt) [19:49:14] MatmaRex: usually, try again it'll go away [19:49:30] <^d> Gotta give NSA time to hide their tracks :p [19:50:01] YuviPanda: i just did and it didn't. [19:50:02] (03PS1) 10Reedy: Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98886 [19:50:14] MatmaRex: well, try again? :) [19:50:21] but everytime I had seen that it has happened... [19:50:23] (03CR) 10Reedy: [C: 032] Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98886 (owner: 10Reedy) [19:50:28] or maybe this time it's NSA for realz [19:50:42] (03PS1) 10Catrope: Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 [19:50:47] Do they have the NSA in Poland? [19:50:58] (03CR) 10Reedy: [V: 032] Update ProofreadPage to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98886 (owner: 10Reedy) [19:51:11] NSA is here, there, everywhere... [19:53:24] Reedy: Thanks [19:53:39] Just confirm that kills of the remaining fatals then I'll update wikisource again [19:53:54] (03CR) 10Aaron Schulz: Fixes to RedisBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [19:54:07] (03Merged) 10jenkins-bot: Added MapCacheLRU class, a simpler cousin to ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/87650 (owner: 10Aaron Schulz) [19:54:57] (03CR) 10Mattflaschen: [C: 04-1] "This will cause a double-loading issue. I'm fine with the idea here (if I understand right) of breaking mediawiki.ui.button into a small " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [19:55:42] (03PS2) 10Catrope: Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 [19:55:43] (03CR) 10jenkins-bot: [V: 04-1] Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [19:55:52] (03PS6) 10Jdlrobson: POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 [19:56:20] <^d> MatmaRex: Easy workaround: copy the hook from another repo. It barely changes ever. [19:56:48] (03CR) 10Bartosz Dziewoński: "> We should figure out how to dynamically switch between PNG and SVG based on detected browser support though." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [19:57:17] ^d: i actually wanted to chekc if the ssh way works [19:57:19] (03PS3) 10Ragesoss: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 [19:57:23] turns out not really [19:57:34] <^d> Does for me, I just tried. [19:57:41] <^d> (And I'm home today, not on wmf network) [19:57:47] (03CR) 10Jforrester: [C: 04-1] Add oojs and oojs-ui to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [19:57:54] well yeah, i'd have to kill that known host or something [19:58:01] (can't be arsed) [19:58:16] MatmaRex: rm rf ~/.ssh/known_hosts :P [19:58:28] and then say yes to the next thousand ssh connections you try [19:58:29] YuviPanda: joke's on you, i'm on windows! [19:58:36] hehe, 'on me' :P [19:58:38] (03PS4) 10Aaron Schulz: Fixes to RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/96801 [19:58:43] <^d> MatmaRex: Joke's on you, you're on windows. [19:59:09] (03CR) 10Swalling: [C: 04-2] "If you're just waiting for me to re-assert the objections voiced in my original -2 (again, no one asked for signupend to be re-added), I'v" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:59:51] (03CR) 10Catrope: "What I'm doing with the i18n here is a bit funky: the ooui-* messages exist in the VisualEditor repo, and I'm moving them to core." [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:00:04] ugh, wtf. i have two different known keys for 208.80.154.81 [20:00:13] (03PS3) 10Catrope: Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 [20:00:35] MatmaRex: What LESS mixin? [20:00:45] (And yeah they're all background-images) [20:01:12] !master resources/mediawiki.less/mediawiki.mixins.less | RoanKattouw [20:01:12] RoanKattouw: https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/resources%2fmediawiki.less%2fmediawiki.mixins.less [20:01:17] .background-image-svg(@svg, @fallback) [20:01:22] Tpt__: [20:01:22] Dec 3 19:59:19 10.64.0.206 apache2[17509]: PHP Fatal error: Call to a member function getLevel() on a non-object in /usr/local/apache/common-local/php-1.23wmf5/extensions/ProofreadPage/ProofreadPage.body.php on line 704 [20:01:29] (03PS7) 10Jdlrobson: poc: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 [20:01:32] siebrand: Could you take a look at https://gerrit.wikimedia.org/r/98887 and its companion https://gerrit.wikimedia.org/r/98889 ? What I'm doing there is a bit crazy, moving i18n messages from one repo to another [20:01:38] (03CR) 10jenkins-bot: [V: 04-1] Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:01:40] Nice [20:01:50] RoanKattouw: or pau's magic technique if you want to stick to plain CSS (which this mixin just uses) [20:02:06] http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique [20:02:14] Hah! [20:02:16] Nice [20:02:19] Maybe we'll just do that in oojs-ui [20:02:32] And have that be the default build [20:02:35] yep, it's sexy [20:02:39] Right now we have a default build with PNGs and an SVG build [20:02:51] the only drawback is that (if you embed images) you embed both versions [20:02:53] (03CR) 10Chad: [C: 032] Document future removal of action=parse&prop=languageshtml [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [20:02:58] But instead I suppose we could have a PNG build, an SVG build, and a hybrid build that's the default [20:03:00] Yeah [20:03:00] Reedy: It's a bug that happens only when a user begin to edit with the old edit code and submit (or preview) with the new one. [20:03:01] but that's easy to work around by just not embedding the PNG ones :P [20:03:04] So VE won't want that, for example [20:03:13] In VE standalone we'll use the SVG build [20:03:20] because it doesn't support any browsers that don't support SVG anyway [20:03:24] Reedy: I've submitted a change in order to fix it in core https://gerrit.wikimedia.org/r/#/c/97835/ [20:03:47] RoanKattouw: https://integration.wikimedia.org/ci/job/mediawiki-core-jslint/10609/console [20:04:14] (03PS1) 10Odder: Test. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/98890 [20:04:40] (03PS4) 10Catrope: Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 [20:04:52] (03PS3) 10Kaldari: Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 [20:05:00] (03Abandoned) 10Odder: Test. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/98890 (owner: 10Odder) [20:05:45] YuviPanda: your choice [20:06:13] apergos: have not completed my bugzilla catch-up yet, should get to it later today [20:06:14] (03CR) 10Chad: Fixed stream wrapper in PhpHttpRequest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [20:06:36] ok. I just want to make sure you guys know about it [20:06:46] gwicke: okay will respond in email in abit [20:06:49] thanks [20:07:18] (03CR) 10Chad: [C: 032] Set $wgNoFollowLinks to false iff "Authorized editors only" selected [core] - 10https://gerrit.wikimedia.org/r/95755 (owner: 10leucosticte) [20:08:20] (03CR) 10jenkins-bot: [V: 04-1] Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:08:51] (03CR) 10Mattflaschen: [C: 031] "Looks good, and I confirmed it's not double-loaded." [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [20:09:11] (03CR) 10Chad: [C: 032 V: 032] Update documentation [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/97309 (owner: 10Siebrand) [20:09:18] (03CR) 10jenkins-bot: [V: 04-1] poc: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [20:10:32] (03CR) 10Catrope: [C: 031] Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [20:10:59] (03PS4) 10Kaldari: Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 [20:11:31] (03CR) 10jenkins-bot: [V: 04-1] Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:11:41] (03CR) 10Mattflaschen: [C: 031] Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [20:11:43] (03CR) 10Chad: [C: 032] filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 (owner: 10Aaron Schulz) [20:11:51] (03CR) 10Catrope: [C: 031] Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [20:12:38] (03CR) 10Chad: [C: 032] Use Html::hidden instead of Html::input [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97929 (owner: 10Jackmcbarn) [20:13:04] (03Merged) 10jenkins-bot: Document future removal of action=parse&prop=languageshtml [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [20:16:15] (03CR) 10Bsitu: "Some nitpicks, looks fine to me other than that. The other issue is that When I am in a small view, 'load more' is still loading the data " (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98757 (owner: 10EBernhardson) [20:17:37] (03Merged) 10jenkins-bot: Set $wgNoFollowLinks to false iff "Authorized editors only" selected [core] - 10https://gerrit.wikimedia.org/r/95755 (owner: 10leucosticte) [20:18:30] manybubbles: could this be a CirrusSearch problem? https://bugzilla.wikimedia.org/show_bug.cgi?id=57934 Mobile search is behaving really oddly on test2wiki and mw.o [20:18:45] let me look! [20:19:01] cirrus isn't live on mw.o right now due to the issue two weeks ago [20:19:08] would be live in a few day probably [20:19:12] but still, let me look [20:19:20] (03CR) 10Anomie: [C: 031] "Everything seems to work, except for the issue with 'add' noted in PS3. Did you want to fix that or leave it?" [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:20:00] (03Merged) 10jenkins-bot: Use Html::hidden instead of Html::input [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97929 (owner: 10Jackmcbarn) [20:20:01] manybubbles: seen first on test2wiki [20:20:26] (03PS8) 10Spage: poc: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [20:21:27] (03CR) 10JGonera: [C: 031] Add 'mediawiki.ui.button' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [20:21:52] (03CR) 10Aaron Schulz: "getMulti() is documented as not doing that AFAIK so that should change back" [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:22:12] (03Merged) 10jenkins-bot: filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 (owner: 10Aaron Schulz) [20:25:56] (03CR) 10Mattflaschen: "See inline. in addition, we might not want to put trailing whitespace into the HTML/templates." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [20:26:09] (03CR) 10jenkins-bot: [V: 04-1] poc: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [20:26:13] manybubbles: ^demon|lunch i didn't follow the conclusion for re-enabling cirrus.... is it enabled as secondary for wikidata now? [20:26:20] (03CR) 10Mattflaschen: [C: 04-1] "Rename doesn't make sense and should be fixed. See also previous review." [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [20:26:53] aude: no - it is only enabled on the wikis that it was enabled on before we disabled it across the board. We should, though, reenable it for wikidata. I think. [20:27:13] ok, good (well not good) [20:27:21] not to blame for lousy results [20:27:22] https://www.wikidata.org/w/index.php?search=athens&button=&title=Special%3ASearch&srbackend=CirrusSearch [20:28:24] (03CR) 10Eloquence: "This is my last comment as enough energy has been expended on this already. That said, the signup experience is important." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [20:30:59] (03PS1) 10Sharihareswara: pep8 style fixes [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98895 [20:31:00] (03PS1) 10Sharihareswara: README updates [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98896 [20:31:01] (03PS1) 10Sharihareswara: Add .gitreview [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98897 [20:32:39] (03PS1) 10Tpt: Fix a failure in API when the page does not exists [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98898 [20:32:48] (03CR) 10Sharihareswara: [C: 032 V: 032] pep8 style fixes [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98895 (owner: 10Sharihareswara) [20:32:54] (03PS1) 10Aaron Schulz: Made RepoGroup use ProcessCacheLRU [core] - 10https://gerrit.wikimedia.org/r/98899 [20:33:16] (03CR) 10Sharihareswara: [C: 032 V: 032] README updates [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98896 (owner: 10Sharihareswara) [20:33:45] (03CR) 10Sharihareswara: [C: 032 V: 032] "Thanks to everyone in #wikimedia-tech who looked at my git-review issues!" [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98897 (owner: 10Sharihareswara) [20:35:04] (03CR) 10Aaron Schulz: "Actually I misread that, this is better than before." [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:36:48] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=54360 . The Flow LESS files are in https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FFlow.git/HEAD/modules%2Fmediawiki.ui%2Fstyles [20:37:06] Reedy: I've made a change to fix the last error trace of bug https://bugzilla.wikimedia.org/show_bug.cgi?id=57615 https://gerrit.wikimedia.org/r/#/c/98898 It's caused by a very silly ommision. I'm sorry for that. [20:40:24] (03PS1) 10Aaron Schulz: Revert "filebackend: cleaned up the FileBackend constructor" [core] - 10https://gerrit.wikimedia.org/r/98902 [20:40:31] (03CR) 10Aaron Schulz: [C: 032] Revert "filebackend: cleaned up the FileBackend constructor" [core] - 10https://gerrit.wikimedia.org/r/98902 (owner: 10Aaron Schulz) [20:41:03] (03CR) 10Anomie: [C: 032] "ok then" [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:44:30] (03PS5) 10Catrope: Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 [20:44:42] <^demon|lunch> aude, manybubbles: Yeah. We can probably handle it now. [20:45:00] (03PS1) 10Mwalker: Updating DonationInterface [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/98904 [20:45:15] (03CR) 10Mwalker: [C: 032 V: 032] Updating DonationInterface [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/98904 (owner: 10Mwalker) [20:46:06] (03Merged) 10jenkins-bot: Revert "filebackend: cleaned up the FileBackend constructor" [core] - 10https://gerrit.wikimedia.org/r/98902 (owner: 10Aaron Schulz) [20:47:33] (03CR) 10Siebrand: [V: 032] Don't use $wgTitle, QuickTemplate has had getSkin() for well over 2 years [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/97564 (owner: 10Chad) [20:48:02] (03CR) 10Parent5446: "In response to the bug matter itself, I would support either solution for the messages. However, if we were to proceed with replacing thes" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [20:48:22] (03Merged) 10jenkins-bot: Fixes to RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:49:43] (03CR) 10Parent5446: [C: 04-1] Fixed stream wrapper in PhpHttpRequest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [20:49:47] (03CR) 10Bartosz Dziewoński: "Not really, I'd still be moving 300 lines of code around." [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [20:49:48] (03CR) 10jenkins-bot: [V: 04-1] Add oojs and oojs-ui to core [core] - 10https://gerrit.wikimedia.org/r/98887 (owner: 10Catrope) [20:50:00] (03CR) 10Siebrand: Change CdbException to subclass Exception (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96910 (owner: 10Chad) [20:51:26] (03CR) 10Jack Phoenix: [C: 04-1] "One copy-paste issue (see the inline comment); once that's fixed, this should be good to go!" (031 comment) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 (owner: 10UltrasonicNXT) [20:53:01] (03CR) 10Phe: [C: 031] "bot can't create page in namsepace Page: w/o this patch." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98898 (owner: 10Tpt) [20:53:48] (03CR) 10Bartosz Dziewoński: "Krinkle: done." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [20:54:00] (03PS2) 10Bartosz Dziewoński: Refactor RL modules related to Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/98589 [20:54:49] (03CR) 10Tpt: [C: 032] "Reviewed by Phe" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98898 (owner: 10Tpt) [20:55:18] (03CR) 10Peachey88: "> I don't think it's fair to claim "consensus". I actually really appreciate that Steven is participating in the conversation, which I'd l" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [20:55:45] (03PS1) 10Aaron Schulz: [WIP] filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/98959 [21:00:10] (03PS1) 10BryanDavis: Add configuration setting for SMTP host [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98960 [21:01:39] (03CR) 10Aaron Schulz: Optimized LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [21:07:20] (03CR) 10Siebrand: Update formatting for log related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98815 (owner: 10Siebrand) [21:07:27] <^demon|lunch> Aaron|home: Think you could review the last of the cdb changes today? pretty minor what's left, and I'd like to put that behind me and off my queue. [21:09:13] (03Merged) 10jenkins-bot: Fix a failure in API when the page does not exists [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98898 (owner: 10Tpt) [21:09:17] spagewmf, jdlrobson, what's the status of the living style guide? [21:09:20] What can I do? [21:11:38] Excuse me I have a minor question [21:11:50] Where in the flying hell are the phpunit jenkins jobs declared [21:12:32] the cloud [21:12:59] I think he meant 'cloud' by 'flying hell' [21:13:08] I believe it's to the right of the death-by-gerrit pits [21:14:21] Sigh [21:14:31] * marktraceur does detective work on int.wm.o [21:16:54] http://git.wikimedia.org/tree/integration%2Fjenkins-job-builder-config.git [21:16:57] marktraceur: ^ [21:17:00] and ... [21:17:12] I know the *repo*, I'm one of the people who can deploy it [21:17:17] I just don't see it in any of the files [21:17:47] which job? [21:17:51] or which extension? [21:18:13] Well, I'm looking to enable phpunit for CommonsMetadata, but I don't see any other extensions that have it enabled for some reason [21:18:21] I guess it's testextensions [21:19:24] But that job exists for CMD and has never run [21:19:27] marktraceur: eh, didnt read all but you are looking where phpunit comes from? [21:19:30] manifests/role/deployment.pp: 'upstream' => 'https://gerrit.wikimedia.org/r/integration/phpunit', [21:19:41] There's a "hasPhpUnit" variable that isn't *set* anywhere in the config directory [21:19:51] mutante: I'm looking for how to enable it for an extension [21:20:00] Maybe CMD just isn't registering its unit tests properly [21:20:19] Or maybe it doesn't have any [21:20:30] I could have sworn it did [21:20:40] (03PS1) 10Sharihareswara: MySQL db access for Wikimedia Labs [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98962 [21:20:43] jzerebecki: ^^ [21:20:57] marktraceur: maybe he can help, i know he looked at unit tests and coverage [21:21:25] 'kay [21:21:47] Aha, it's not registering them [21:21:54] I'll do that and then maybe it will run [21:22:17] i think phpunit is default for all extensions [21:22:25] i dont' know why they don't run [21:22:34] (03PS1) 10Spage: Some comments for replacing core mediawiki.ui [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98963 [21:23:19] aude: Because they're not registered like they should be [21:23:26] oh [21:23:34] Or....ah, they are, DAMN it [21:26:20] ^demon|lunch: looking [21:27:33] (03PS1) 10Krinkle: Enable oojs-ui-csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98964 [21:27:40] (03CR) 10Aaron Schulz: [C: 032] Change CdbException to subclass Exception [core] - 10https://gerrit.wikimedia.org/r/96910 (owner: 10Chad) [21:28:31] (03CR) 10Krinkle: [C: 032] Enable oojs-ui-csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98964 (owner: 10Krinkle) [21:28:38] (03Merged) 10jenkins-bot: Enable oojs-ui-csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98964 (owner: 10Krinkle) [21:30:25] (03CR) 10BryanDavis: Add configuration setting for SMTP host (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98960 (owner: 10BryanDavis) [21:30:26] (03PS1) 10MarkTraceur: Turn on CMD unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98965 [21:30:41] Turns out they weren't running because zuul. Sigh. [21:30:49] (03Merged) 10jenkins-bot: Change CdbException to subclass Exception [core] - 10https://gerrit.wikimedia.org/r/96910 (owner: 10Chad) [21:31:11] (03PS1) 10Manybubbles: Make incategory: and intitle: negatable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 [21:31:12] (03CR) 10MarkTraceur: [C: 032] Turn on CMD unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98965 (owner: 10MarkTraceur) [21:32:01] marktraceur: easy enough to fix :) [21:32:15] Well yeah [21:32:16] (03PS2) 10Manybubbles: Make incategory: and intitle: negatable [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98966 [21:32:22] * aude knows for next time [21:32:23] (03Merged) 10jenkins-bot: Turn on CMD unit tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98965 (owner: 10MarkTraceur) [21:32:39] When you have zuul deploy rights it is [21:32:45] yeah .... [21:33:18] JENKINS, DO MY BIDDING [21:33:19] (03CR) 10Mattflaschen: "There should be a README specifying how to install kss-node." [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [21:33:32] (03CR) 10Aaron Schulz: [C: 032] Proper CdbException handling [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/97846 (owner: 10Chad) [21:34:30] ^demon|lunch: so you tested all the multiversion scripts like MWVersion and activeMWVersions? [21:35:20] (03CR) 10VitaliyFilippov: (bug 35607) Fix OXML type detection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/70830 (owner: 10VitaliyFilippov) [21:35:27] <^demon|lunch> I tested activeMWVersions. [21:35:39] (03Merged) 10jenkins-bot: Proper CdbException handling [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/97846 (owner: 10Chad) [21:35:44] <^demon|lunch> And tested MWMultiVersion by way of trial and error. [21:37:35] ^demon|lunch: can the CDB stuff in core be moved to /libs? [21:37:51] that makes it less likely someone would make it depend on MW by mistake [21:37:55] <^demon|lunch> Possibly, yeah :) [21:40:35] (03PS1) 10Krinkle: Enable mwext-VisualEditor-csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98967 [21:41:07] (03CR) 10Krinkle: [C: 032] "Deployed the push to jenkins an hour ago, tested locally, enabling now to run from Zuul." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98967 (owner: 10Krinkle) [21:41:17] (03Merged) 10jenkins-bot: Enable mwext-VisualEditor-csslint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98967 (owner: 10Krinkle) [21:41:32] (03CR) 10Mattflaschen: "With the Jenkins/static idea, I think we also wouldn't have to commit the KSS-generated HTML." [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [21:42:25] superm401: yes so we could simply add the comments to core and generate the kss separately via a jenkins job [21:43:42] Yeah, it would avoid the issue anytime source and compiled are both committed, that they inevitably get out of sync and make code review and rebasing messier than needed. [21:44:59] (03PS1) 10Tpt: Use as image name the root title of the page [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/98968 [21:47:59] (03CR) 10Anomie: Optimized LocalRepo::findFiles() (034 comments) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [21:49:10] (03CR) 10Swalling: Change the reset button text in Special: PasswordReset to 'Reset Password' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98733 (owner: 10MegaAlex) [21:53:12] (03PS2) 10Siebrand: Update documentation for log related classes [core] - 10https://gerrit.wikimedia.org/r/98859 [21:53:13] (03PS1) 10Siebrand: Declare visibility on log class related properties [core] - 10https://gerrit.wikimedia.org/r/98969 [21:53:14] (03PS1) 10Siebrand: Add deprecation warnings for log related methods [core] - 10https://gerrit.wikimedia.org/r/98970 [21:53:15] (03PS1) 10Siebrand: Replace deprecated notifyRC2UDP() with notifyRCFeeds(). [core] - 10https://gerrit.wikimedia.org/r/98971 [21:53:16] (03PS1) 10Siebrand: Remove unneeded else{} in LogEventsList::userCanBitfield() [core] - 10https://gerrit.wikimedia.org/r/98972 [21:53:17] (03PS1) 10Siebrand: Update documentation for IndexPager::formatRow() [core] - 10https://gerrit.wikimedia.org/r/98973 [21:53:18] (03PS1) 10Siebrand: Set saner default for parameters of LogEventsList::showOptions() [core] - 10https://gerrit.wikimedia.org/r/98974 [21:54:10] (03PS2) 10Siebrand: Set saner default for parameters of LogEventsList::showOptions() [core] - 10https://gerrit.wikimedia.org/r/98974 [21:54:20] (03CR) 10Bsitu: Set a global cache time within Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 (owner: 10EBernhardson) [21:54:29] (03PS2) 10Siebrand: Update documentation for IndexPager::formatRow() [core] - 10https://gerrit.wikimedia.org/r/98973 [21:54:48] (03PS2) 10Siebrand: Remove unneeded else{} in LogEventsList::userCanBitfield() [core] - 10https://gerrit.wikimedia.org/r/98972 [21:54:54] (03PS1) 10Yaron Koren: Switched around author names - I'm the main author now [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98975 [21:56:15] (03PS1) 10Cmcmahon: add when_present for hygiene and consistency [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98976 [21:56:19] (03CR) 10Yaron Koren: [C: 032 V: 032] Replaced wfMessage()->text() with ->parse(), per Siebrand's recommendation [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98697 (owner: 10Yaron Koren) [21:56:47] (03CR) 10Yaron Koren: [C: 032 V: 032] Switched around author names - I'm the main author now [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98975 (owner: 10Yaron Koren) [21:57:00] (03PS2) 10Siebrand: Replace deprecated notifyRC2UDP() with notifyRCFeeds(). [core] - 10https://gerrit.wikimedia.org/r/98971 [21:57:09] (03PS2) 10Siebrand: Add deprecation warnings for log related methods [core] - 10https://gerrit.wikimedia.org/r/98970 [21:59:28] (03PS2) 10Aaron Schulz: filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/98959 [22:00:05] (03CR) 10JGonera: [C: 04-1] "The links on Special:StyleGuide are configuration-specific, e.g. they're generated as /w/index.php/Special:StyleGuide/section-1, while on " [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [22:00:15] ^demon|lunch: https://gerrit.wikimedia.org/r/#/c/98959/1..2/includes/filebackend/FileBackend.php I had to tweak that for b/c [22:00:31] * Aaron|home will update some exts later [22:01:16] (03CR) 10JGonera: "I like Mattflaschen's idea." [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [22:05:01] bawolff: anything to do on https://gerrit.wikimedia.org/r/#/c/97659/ ? [22:05:41] (03PS1) 10Manybubbles: Fix error in prefer-recent: test [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98977 [22:05:46] Aaron|home: Looking over it, it looks good. I've been meaning to set up GlobalUsage locally in order to test it [22:06:25] That's probably something I'll do today [22:08:01] bawolff: not sure what to do with https://gerrit.wikimedia.org/r/#/c/67880/2 [22:09:52] anomie|away: huh, FileRepo has 'if ( $redir && $title->getNamespace() == NS_FILE ) {' [22:12:01] (03CR) 10Cmcmahon: [C: 032] "hygiene, no functional change" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98976 (owner: 10Cmcmahon) [22:15:26] Aaron|home: I'm not sure I understand what the problem that https://gerrit.wikimedia.org/r/#/c/67880/2 is trying to solve is? [22:15:58] anomie|away: huh, daa41d3 [22:17:08] (03PS2) 10Cscott: Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 [22:17:09] (03PS3) 10Cscott: Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 [22:17:10] (03PS2) 10Cscott: Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 [22:17:11] (03PS4) 10Cscott: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 [22:17:12] (03PS3) 10Cscott: Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 [22:17:13] (03PS4) 10Cscott: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 [22:17:14] (03PS3) 10Cscott: Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 [22:17:15] (03PS3) 10Cscott: Make filenames "safe" before passing to image converters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98559 [22:17:16] (03PS3) 10Cscott: Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 [22:17:16] bawolff: when an mc server goes down the keys redistribute and do so again when it comes up (or another one comes up/down). If stuff happens in the meantime, the key value could revert to a stale value [22:17:17] (03PS3) 10Cscott: Use exiftool to strip resolution information from JPEGs to avoid a LaTeX error. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 [22:17:18] (03PS5) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [22:17:19] (03PS1) 10Cscott: Use imagemagick 'mogrify' to strip EXIF resolution information. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98983 [22:17:20] (03PS1) 10Cscott: Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 [22:17:21] (03PS1) 10Cscott: Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 [22:17:31] bawolff: it could easily be stuck that way for a week [22:18:07] I guess we haven't had these kind of problems for a while (last time was during the DC switch) [22:18:13] Wouldn't that screw up a lot more then just images [22:18:27] thumb.php gave 404s for existing files, heh [22:19:15] the adaptive ttl thing is used by cache proxies and FTP since it's really simple to do, not perfect of course [22:21:00] can someone with permissions mark https://bugzilla.wikimedia.org/show_bug.cgi?id=57510 as fixed? [22:21:30] jackmcbarn: done [22:21:32] (03PS1) 10Chad: Implement multi-index support on a per-namespace basis [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 [22:21:34] thanks [22:21:44] jackmcbarn: You can ask andre for permissions if you want them [22:22:12] (03CR) 10Chad: "we can haz commons searches" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:22:21] he's User:AKlapper? [22:22:39] jackmcbarn: yeah, the name of the permissions you want is "editbugs" [22:23:03] Aaron|home: Hmm, this still wouldn't fix the situation where 404's were given though, as the missing ttl is still 1 day, so this is more for if someone uploaded a new version with different dimensions or something, right? [22:24:16] right, I'm not sure how low the missing TTL could be [22:24:38] we definitely have lots of bogus requests [22:25:04] (03PS6) 10Cmcmahon: Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 [22:25:16] (03CR) 10Manybubbles: Implement multi-index support on a per-namespace basis (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:25:32] (03CR) 10Cmcmahon: [C: 032] "thanks for the +1, I want to use the page.rb changes in another new test" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 (owner: 10Cmcmahon) [22:25:44] (03CR) 10Manybubbles: "Does this cover indexes as well?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:26:10] (03CR) 10jenkins-bot: [V: 04-1] Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 (owner: 10Cscott) [22:26:40] (03CR) 10jenkins-bot: [V: 04-1] Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 (owner: 10Cscott) [22:27:00] (03CR) 10jenkins-bot: [V: 04-1] Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 (owner: 10Cscott) [22:27:28] (03CR) 10jenkins-bot: [V: 04-1] Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [22:27:30] (03PS8) 10Tim Starling: Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [22:27:37] (03CR) 10Tim Starling: [C: 032] Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [22:27:45] (03CR) 10Chad: "If we plan to build & deploy this using the same thing, that's a non-starter. We have to use gerrit, not github." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 (owner: 10Cscott) [22:28:00] (03CR) 10jenkins-bot: [V: 04-1] Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 (owner: 10Cscott) [22:28:14] (03Merged) 10jenkins-bot: Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 (owner: 10Cmcmahon) [22:28:26] (03CR) 10jenkins-bot: [V: 04-1] Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [22:29:01] (03PS1) 10Bsitu: Fix to post history link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98987 [22:29:15] (03CR) 10jenkins-bot: [V: 04-1] Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 (owner: 10Cscott) [22:29:48] hey csteipp, just wanted to let you know that i'm online in case you have any questions for me [22:30:05] (03CR) 10jenkins-bot: [V: 04-1] Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 (owner: 10Cscott) [22:30:06] (03CR) 10jenkins-bot: [V: 04-1] Use exiftool to strip resolution information from JPEGs to avoid a LaTeX error. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 (owner: 10Cscott) [22:30:36] (03CR) 10jenkins-bot: [V: 04-1] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [22:31:26] (03CR) 10jenkins-bot: [V: 04-1] Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 (owner: 10Cscott) [22:31:43] Aaron|home: Hmm, the 5 minute perhaps seems a bit low of a starting value to me (although I have no idea what access patterns actually are, or what the performance implications would actually be), maybe something like 20 minutes as the minimum would be safer [22:32:05] (03CR) 10jenkins-bot: [V: 04-1] Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 (owner: 10Cscott) [22:32:49] (03CR) 10Cscott: "I think our current build and deploy mechanism (using git submodules) uses gerrit. It's just the npm package metadata which is pointing a" [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 (owner: 10Cscott) [22:33:37] (03Merged) 10jenkins-bot: Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [22:34:44] (03CR) 10Cscott: [C: 032 V: 032] "Overriding jenkins test failure, since the failure is fixed by the next commit (https://gerrit.wikimedia.org/r/98983)." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 (owner: 10Cscott) [22:35:14] (03CR) 10Cscott: [C: 032] Use imagemagick 'mogrify' to strip EXIF resolution information. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98983 (owner: 10Cscott) [22:36:08] bawolff: for brand new files they usually have few uses/requests...though this would be an issue with re-names or re-uploads of popular files [22:36:24] * Aaron|home looks at http://www.hpl.hp.com/techreports/1999/HPL-1999-108.pdf [22:36:58] (03PS2) 10Bsitu: Fix to post history link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98987 [22:37:03] (03CR) 10jenkins-bot: [V: 04-1] Use exiftool to strip resolution information from JPEGs to avoid a LaTeX error. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 (owner: 10Cscott) [22:39:32] (03CR) 10Cscott: [C: 032] Use mw-ocg-bundler as binary name, and consistently in documentation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98844 (owner: 10Cscott) [22:40:42] Hmm, there are certainly exceptions even with new files - e.g. Someone doing a local upload to put a file on wikipedia's main page [22:41:02] (03CR) 10Bsitu: [C: 032] Some comments for replacing core mediawiki.ui [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98963 (owner: 10Spage) [22:41:08] (03Merged) 10jenkins-bot: Use mw-ocg-bundler as binary name, and consistently in documentation. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98844 (owner: 10Cscott) [22:41:09] (03Merged) 10jenkins-bot: Some comments for replacing core mediawiki.ui [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98963 (owner: 10Spage) [22:42:13] (03CR) 10Tim Starling: "Erik wrote:" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [22:42:53] bawolff: too bad mc doesn't give you a hit counter on GET [22:43:16] one could then factor that into to whether to cache misses or not [22:43:57] I guess using mt_rand() on set() would simulate that a bit [22:45:52] qgil: yes, i saw the page, thanks [22:46:34] matanya, hi, not perfect but better than nothing. I hope new wisdom is added as questions from new contributors find responses. :) [22:46:42] /br/br [22:46:44] Bah. [22:46:56] p [22:47:03] * marktraceur needs to stop trying to type things [22:47:07] I'm terrible at it [22:47:24] (03CR) 10Cscott: [C: 032] Make filenames "safe" before passing to image converters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98559 (owner: 10Cscott) [22:47:30] qgil: yes, the wiki way :) [22:48:10] jdlrobson, are you around? [22:48:22] (03CR) 10MZMcBride: "> If MZMcBride removed you as a reviewer by clicking the "x" next to your name, then re-added you, that would have reset your review level" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [22:50:02] Aaron|home: The change sounds like it would be fine (Although it would be good to include a detailed code comment on the reasoning), however I don't really feel like I'm familiar enough with how a lower cache time would potentially affect performance on wikimedia to give it a +2 [22:50:42] I think I'll probably abandon it for the moment actually [22:51:24] (03Abandoned) 10Aaron Schulz: Use adaptive TTL in LocalFile to deal with memcached flapping better. [core] - 10https://gerrit.wikimedia.org/r/67880 (owner: 10Aaron Schulz) [22:51:44] bawolff: did daa41d3 add a bug? [22:51:46] (03CR) 10Bsitu: [C: 032] Wire up the buffered cache to db transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [22:51:55] (03Merged) 10jenkins-bot: Wire up the buffered cache to db transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [22:51:56] !gerrit daa41d3 [22:51:56] https://gerrit.wikimedia.org/r/#q,daa41d3,n,z [22:52:28] heh, my bios boot write lock seems to work [22:52:35] *boot sector [22:52:41] (03CR) 10Cscott: "Tickle jenkins." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98559 (owner: 10Cscott) [22:53:03] hmm, line 140 looks suspicious [22:53:05] (03CR) 10Chad: "Cover indexes? Do you mean I79e134d1? I'm working on cleaning that up still. One doesn't necessarily depend on the other." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:53:16] jdlrobson: when you see this, please see https://www.mediawiki.org/wiki/Talk:Typography_Update#Sizing_looks_really_bad_in_Wikidata [22:53:18] Aaron|home, the BIOS anyone can edit? [22:53:29] (03CR) 10Swalling: ">The difference between Steven's two options is not visible to end users, so A/B testing is not relevant." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [22:53:38] well if you have a skrewdriver, yes [22:53:48] Aaron|home: Are you sure you have the right commit id, that's a commit from 2011 [22:54:12] (03CR) 10Chad: [C: 04-2] "Naive approach gives you naive results ;-) Right now if you've got a page on your commonswiki, and you've created it locally (happens a lo" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98986 (owner: 10Chad) [22:54:52] bawolff: this was due to a comment brad made on https://gerrit.wikimedia.org/r/#/c/97993/ for similar code [22:55:42] qgil: all I need is some magic tamper tape ;) [22:56:27] It certainly looks unintentional, that was supposed to be a commit with no code changes [22:58:16] (03PS1) 10Jdlrobson: Add ability to generate KSS files for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/98990 [23:00:00] Aaron|home: I don't think it would be of any consequence though, as the newFile function would return false if the intended check fails anyways [23:01:54] (03CR) 10Brian Wolff: Optimized LocalRepo::findFiles() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [23:01:57] (03PS3) 10Cscott: Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 [23:01:58] (03PS4) 10Cscott: Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 [23:01:59] (03PS3) 10Cscott: Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 [23:02:00] (03PS5) 10Cscott: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 [23:02:01] (03PS4) 10Cscott: Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 [23:02:02] (03PS5) 10Cscott: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 [23:02:03] (03PS4) 10Cscott: Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 [23:02:04] (03PS4) 10Cscott: Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 [23:02:05] (03PS6) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [23:02:06] (03PS2) 10Cscott: Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 [23:02:07] (03PS2) 10Cscott: Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 [23:02:36] (03CR) 10jenkins-bot: [V: 04-1] Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 (owner: 10Cscott) [23:03:05] (03CR) 10jenkins-bot: [V: 04-1] Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 (owner: 10Cscott) [23:03:30] (03CR) 10jenkins-bot: [V: 04-1] Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 (owner: 10Cscott) [23:03:56] (03CR) 10jenkins-bot: [V: 04-1] Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [23:04:20] (03CR) 10jenkins-bot: [V: 04-1] Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 (owner: 10Cscott) [23:04:24] hey Aaron|home, bd808 has asked me to amend this change set, https://gerrit.wikimedia.org/r/#/c/98684/1. but i'm not sure how to add the filebackend config. this is what i have for the moment, http://pastebin.com/N0LUTM2z - this works fine locally, but earlier you mentioned that the file backend config would go in filebackend.php, i imagine, filebackend-labs.php for this change set. but what would i add to it? [23:04:25] superm401: https://gerrit.wikimedia.org/r/98990 [23:04:28] (03PS2) 10Sharihareswara: MySQL db access for Wikimedia Labs [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98962 [23:04:45] (03CR) 10jenkins-bot: [V: 04-1] Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [23:05:08] (03CR) 10jenkins-bot: [V: 04-1] Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 (owner: 10Cscott) [23:05:41] $wgGWTFileBackend is an unfortunate acronym... :P [23:05:57] bawolff: why}s that? [23:05:58] (03CR) 10jenkins-bot: [V: 04-1] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [23:05:59] (03CR) 10Cscott: [C: 032] Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 (owner: 10Cscott) [23:06:15] (03PS4) 10Cscott: Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 [23:06:16] (03PS5) 10Cscott: Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 [23:06:17] (03PS4) 10Cscott: Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 [23:06:18] (03PS6) 10Cscott: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 [23:06:19] (03PS5) 10Cscott: Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 [23:06:20] (03PS6) 10Cscott: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 [23:06:21] (03PS5) 10Cscott: Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 [23:06:22] (03PS7) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [23:06:23] (03PS3) 10Cscott: Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 [23:06:24] (03PS3) 10Cscott: Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 [23:06:25] (03CR) 10jenkins-bot: [V: 04-1] Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 (owner: 10Cscott) [23:06:36] dan-nl: $wgG...WTF...ileBackend [23:06:49] (03CR) 10jenkins-bot: [V: 04-1] Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 (owner: 10Cscott) [23:07:09] (03Merged) 10jenkins-bot: Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 (owner: 10Cscott) [23:07:18] bawolff: nice ;) [23:07:36] <^demon|lunch> bawolff: Well I've been saying since the beginning that GWToolset is GWT ;-) [23:07:58] dan-nl: that seems mostly OK, though I'd use 'basePath' instead of 'containerPaths' and I still don't see why $wgGWTFBMetadataContainer has to exist [23:08:03] (03PS1) 105xbe: change README [extensions/examples] - 10https://gerrit.wikimedia.org/r/98992 [23:08:35] ^demon|lunch: And from my understanding, the distance you have to travel to get from GWT to WTF is not very far :P [23:08:52] 'containerPaths' is really only there for legacy reasons [23:09:13] ah, okay [23:09:15] <^demon|lunch> bawolff: Indeed! :) [23:09:24] (03CR) 10Cscott: [C: 032] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [23:09:40] (03CR) 10Cscott: [C: 032] Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [23:09:51] (03CR) 10Cscott: [C: 032] Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [23:10:02] (03CR) 10Cscott: [C: 032] Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 (owner: 10Cscott) [23:10:16] (03CR) 10Cscott: [C: 032] Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 (owner: 10Cscott) [23:10:18] Aaron|home: i don't think i understand the set-up that clearly. what's the diff between containerPaths and basePaths [23:10:21] (03CR) 10jenkins-bot: [V: 04-1] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [23:10:58] (03CR) 10Cscott: [C: 032] Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 (owner: 10Cscott) [23:11:11] (03CR) 10Cscott: [C: 032] Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 (owner: 10Cscott) [23:12:39] i thought that when you create a backend you had to include a containerPath [23:13:03] wgGWTFBMetadataContainer is just a reference to that container, which i thought i had to refer to [23:13:21] (03CR) 10Mattflaschen: "Jon posted a simpler follow-up without templates or the generated HTML: https://gerrit.wikimedia.org/r/#/c/98990/" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [23:13:22] dan-nl: basePath is the path that all container directories go under [23:13:41] (03CR) 10Bartosz Dziewoński: "I assume this is currently done per the talk on the bug. I'll check tomorrow, sorry for the delay :(" [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [23:13:54] when you define that, then any random container can be created using prepare() for that backend [23:14:07] it will just be a directory under basePath [23:14:53] containerPaths is for overriding container directories to be located at arbitrary locations, which is needed for legacy cases like the /images directory stuff [23:16:08] (03CR) 10Cscott: [C: 032] Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 (owner: 10Cscott) [23:16:09] (03PS3) 10Sharihareswara: MySQL db access for Wikimedia Labs [tools/missing-from-wikipedia] - 10https://gerrit.wikimedia.org/r/98962 [23:17:41] (03CR) 10Mattflaschen: "See earlier commit: https://gerrit.wikimedia.org/r/#/c/95279/" [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [23:18:15] Aaron|home: but don't i need to specify the container within the base path where i want the files to go? [23:18:43] right [23:18:47] (03PS5) 10Aaron Schulz: Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 [23:19:03] Krinkle: https://gerrit.wikimedia.org/r/#/c/98869/ is essentially awaiting your +2. [23:20:14] (03PS1) 10EBernhardson: Ensure non-binary cache keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 [23:20:16] (03PS1) 10EBernhardson: Always use UUID objects when querying storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98994 [23:20:18] (03PS1) 10EBernhardson: [WIP] Shorten uuids to 88 bits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [23:20:25] Aaron|home: in regards to that paste bin i can just add that to CommonSettings-labs.php? i don't have to add anything to filebackend-labs.php? [23:20:40] (03CR) 10jenkins-bot: [V: 04-1] Ensure non-binary cache keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 (owner: 10EBernhardson) [23:20:43] (03PS5) 10Cscott: Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 [23:20:44] (03PS6) 10Cscott: Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 [23:20:45] (03PS5) 10Cscott: Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 [23:20:46] (03PS7) 10Cscott: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 [23:20:47] (03PS6) 10Cscott: Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 [23:20:48] (03PS7) 10Cscott: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 [23:20:49] (03PS6) 10Cscott: Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 [23:20:50] (03PS8) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [23:20:51] (03PS4) 10Cscott: Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 [23:20:52] (03PS4) 10Cscott: Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 [23:20:53] (03CR) 10jenkins-bot: [V: 04-1] Always use UUID objects when querying storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98994 (owner: 10EBernhardson) [23:20:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Shorten uuids to 88 bits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [23:21:00] git flooood! [23:21:31] Halo 5: Code Review [23:21:32] (03CR) 10Cscott: [C: 032] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [23:21:40] (03CR) 10Cscott: [C: 032] Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [23:21:54] (03CR) 10Cscott: [C: 032] Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [23:22:01] dan-nl: the wgFileBackends stuff belongs in -labs.php to keep it more organized [23:22:02] (03CR) 10Cscott: [C: 032] Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 (owner: 10Cscott) [23:22:10] (03CR) 10Cscott: [C: 032] Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 (owner: 10Cscott) [23:22:19] the rest can be in commonsettings [23:22:22] (03CR) 10Cscott: [C: 032] Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 (owner: 10Cscott) [23:22:29] (03CR) 10Cscott: [C: 032] Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 (owner: 10Cscott) [23:22:35] woooooooo cscott [23:22:37] (03PS2) 10EBernhardson: Ensure non-binary cache keys [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98993 [23:23:00] Aaron|home: k, and that backend config is fine for now? we can change it later to work with basePath? [23:23:13] werdna: jenkins didn't like the linting of one of the first patches in a big pile. sorry about the spam. [23:23:46] (03PS1) 10Jackmcbarn: Show tags on deleted edits through the API [core] - 10https://gerrit.wikimedia.org/r/98996 [23:23:56] (03PS2) 10EBernhardson: Always use UUID objects when querying storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98994 [23:24:14] (03CR) 10Cscott: [C: 032] Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 (owner: 10Cscott) [23:24:51] cscott: well at least you're making things more interesting [23:25:16] dan-nl: actually, is '/images/gwtoolset/metadata' private? [23:25:24] Aaron|home: yes [23:25:34] (03Merged) 10jenkins-bot: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [23:25:36] Aaron|home: here's the updated paste bin http://pastebin.com/WwHtA6tb [23:25:42] greg-g: Regarding upcoming deploys, I assume we'll do wmf7 on 12 Dec/19 Dec, wmf8 on 19 Dec/2 Jan, wmf9 on 2 Jan/9 Jan? [23:25:48] werdna: and jenkins did good by catching my unused variable, i guess. [23:25:50] not sure if that's how i should do it or not [23:26:01] dan-nl: how so? ..htaccess file or apache conf? [23:26:09] (03Merged) 10jenkins-bot: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [23:26:16] (03Merged) 10jenkins-bot: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [23:26:46] (03Merged) 10jenkins-bot: Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 (owner: 10Cscott) [23:26:47] Aaron|home: locally i've been relying on the prepare() method, which is placing an .htaccess file and index.html file in the directories [23:27:11] I see 'deletedDir' => "/mnt/upload7/private/archive/$site/$lang" above for the deleted directory conf [23:27:12] Aaron|home: as far as on production i have no idea, although apache config would be more efficient as far as i know [23:27:21] (03Merged) 10jenkins-bot: Use proper line-breaking algorithm for URLs (or things which look like them). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98739 (owner: 10Cscott) [23:27:30] maybe a similar path could be used, e.g. "/mnt/upload7/private/gwtoolset/$site/$lang" [23:27:34] (03Merged) 10jenkins-bot: Avoid deferred floats caused by float size/quantity restrictions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98984 (owner: 10Cscott) [23:27:47] (03PS2) 10EBernhardson: [WIP] Shorten uuids to 88 bits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [23:27:56] (03Merged) 10jenkins-bot: Don't render icons smaller than 16x16 as floating figures. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98985 (owner: 10Cscott) [23:28:15] James_F: right [23:28:21] (03Merged) 10jenkins-bot: Update commander/gammalatex/mocha/when deps. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98830 (owner: 10Cscott) [23:28:27] * greg-g has some schedules to update [23:28:38] we don't want to rely on those .htaccess files in prod [23:28:39] Aaron|home: k, who would know for sure what the best config would be? [23:28:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Shorten uuids to 88 bits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 (owner: 10EBernhardson) [23:28:53] dan-nl: at least hashar [23:29:16] greg-g: Kk. [23:29:25] Aaron|home: k, i'll check with him tomorrow … thanks for you help thus far. [23:29:35] or rather, later today ... [23:30:12] (03PS3) 10EBernhardson: [WIP] Shorten uuids to 88 bits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98995 [23:31:54] Aaron|home: sorry, one other thing i just remembered. csteipp mentioned in one of his security review comments, no access control on who can access files in the backend? is there a way to control which user has access to a filebackned file? [23:32:03] (03CR) 10Cscott: [C: 032] "We can always revert this later if npm using github URLs turns out to be a problem." [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 (owner: 10Cscott) [23:32:16] (03CR) 10Cscott: [C: 032] Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 (owner: 10Cscott) [23:32:27] (03Merged) 10jenkins-bot: Point all github urls to official wikimedia mirrors. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98831 (owner: 10Cscott) [23:32:50] (03Merged) 10jenkins-bot: Rename package from mw-latexer to mw-ocg-latexer. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98841 (owner: 10Cscott) [23:32:51] dan-nl: how can users currently access files right now? [23:34:07] they don't access them directly. the “wizard” guides them through the process and the mwstore value is passed along as a hidden field. i think csteipp is concerned about someone maliciously using that mwstore value inapproriately [23:35:07] the code uses that value to retrieve the file and use it in the rest of the “wizard” process [23:35:30] i'm talking about the xml metadata file that’s uploaded [23:35:50] where is the comment? [23:36:01] https://bugzilla.wikimedia.org/show_bug.cgi?id=56178 [23:36:12] find includes/Handlers/Forms/MetadataMappingHandler.php [23:37:29] superm401: jgonera https://github.com/kneath/kss/issues/37 [23:38:18] jdlrobson, thanks. [23:39:57] (03CR) 10JGonera: [C: 04-1] Add ability to generate KSS files for mediawiki.ui (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [23:42:27] dan-nl: so right now retrieveFile() takes a full mwstore:// path, it should either take a path relative to the gwtoolset-container or check that the path is under that. It could furthermore be relative to a subdirectory that uses the user ID. [23:43:59] (03PS1) 10EBernhardson: Always escape moderation reason when included in history messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98999 [23:45:33] Aaron|home doesn't this make sure the file is under the container? [23:46:18] (03CR) 10Bsitu: [C: 032] Add relatively paranoid input sanitisation to BasicDbStorage. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98759 (owner: 10Werdna) [23:46:27] (03Merged) 10jenkins-bot: Add relatively paranoid input sanitisation to BasicDbStorage. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98759 (owner: 10Werdna) [23:46:34] (03PS2) 10Jdlrobson: Add ability to generate KSS files for mediawiki.ui [core] - 10https://gerrit.wikimedia.org/r/98990 [23:46:41] dan-nl: right now it only checks that it's the right backend [23:46:45] in regards to the user id … i could add that sub-directory under the hash … that would probably take care of csteipp's concern? [23:47:24] why not have //, which is what I was suggesting (it seems a bit more natural)? [23:47:36] i agree [23:47:42] just wanted to clarify [23:49:43] any user supplied paths should always be a relative as possible in general, are there any other paths used like that? [23:49:54] (03CR) 10Tim Starling: "> So when we say it's better for users to have a form lacking that kind of extra instructional content, the tests we previously run back t" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [23:50:12] (03PS1) 10MegaAlex: Add {{PLURAL: support for youhavenewmessagesfromusers and youhavenewmessages [core] - 10https://gerrit.wikimedia.org/r/99000 [23:50:31] dan-nl: Yeah, my concern is that an attacker should never be able to send a victim to a link that would show the xml. Iirc, there isn't functionality to display it, so that is fine. Secondary to that, having the xml's public seemed odd to me. [23:51:17] (03CR) 10jenkins-bot: [V: 04-1] Add {{PLURAL: support for youhavenewmessagesfromusers and youhavenewmessages [core] - 10https://gerrit.wikimedia.org/r/99000 (owner: 10MegaAlex) [23:51:26] 1000 changes left... [23:51:53] Aaron|home: there is also a path to the metadata mapping, but i believe that one is relative [23:52:07] i can see that i still need to understand the filebackend better [23:52:32] (03CR) 10Bsitu: [C: 032] Always escape moderation reason when included in history messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98999 (owner: 10EBernhardson) [23:52:42] (03Merged) 10jenkins-bot: Always escape moderation reason when included in history messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98999 (owner: 10EBernhardson) [23:52:59] csteipp: so using the relative path as Aaron|home suggested, //.xml would work? [23:54:14] (03CR) 10Jdlrobson: [C: 04-1] Refactor RL modules related to Special:Userlogin (034 comments) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [23:54:33] also the xmls are "protected" as far as i understand it by the FileBackend->prepare() method so while they're on the public side of the server they aren't visible because of server config [23:55:31] (03CR) 10JGonera: [C: 04-1] Add ability to generate KSS files for mediawiki.ui (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98990 (owner: 10Jdlrobson) [23:55:48] csteipp: the mwstore value is only used by the “wizard” to retrieve the file. i don't think a user could actually use it to view it or downloaded it unless they got some php code onto the server that could access it [23:56:09] or break through the server config that protects the files from public view [23:56:14] (03PS2) 10MegaAlex: Add {{PLURAL: support for youhavenewmessagesfromusers and youhavenewmessages [core] - 10https://gerrit.wikimedia.org/r/99000 [23:56:25] (03PS5) 10Werdna: Add new jquery.scroll.js plugin. [core] - 10https://gerrit.wikimedia.org/r/96949 [23:56:56] Krinkle: alright, so I chatted with trevor: apparently adding this plugin as a dependency is no-go. So I'm just going to push ahead with putting it in core so it can actually be used. [23:57:03] dan-nl: Then it's probably fine as is [23:57:11] I've addressed your concerns, so far as I know. [23:57:19] (03CR) 10Krinkle: [C: 04-1] "As previously mentioned on https://gerrit.wikimedia.org/r/#/c/87296/ and https://gerrit.wikimedia.org/r/#/c/70740/:" [core] - 10https://gerrit.wikimedia.org/r/98869 (owner: 10Kaldari) [23:57:59] csteipp: cool, i still ike Aaron|home's idea about /user-id/hash it could help find those who may be trying to upload malicisou xml if ever necessary [23:58:13] (03PS1) 10Cscott: Add non-enwiki test case. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99001 [23:58:59] (03PS1) 10Cscott: Fetch PDFs when used as images, and thumbnails for embedded video. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/99002 [23:59:18] although the user name would probably be bogus anyway … still, i imagine it might be useful for non-malicious purposes later down the line as well