[00:18:02] heyhey [00:24:57] (03CR) 10Shirayuki: [C: 04-1] "$2 should not be null for backward compatibility." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [00:30:35] (03Abandoned) 10Werdna: Echo: Implement real-time notification using XMPP over BOSH. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/16580 (owner: 10Werdna) [00:30:57] (03Abandoned) 10Werdna: LiquidThreads rewrite JS improvements: [extensions/LiquidThreads] (lqt-updates) - 10https://gerrit.wikimedia.org/r/41022 (owner: 10Werdna) [00:40:09] (03CR) 10Addshore: [C: 04-1] Remove now incomplete dependency lists for some projects (032 comments) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 (owner: 10Jeroen De Dauw) [00:41:35] (03CR) 10Addshore: [C: 031] Improve organization of TestsAutoLoader [core] - 10https://gerrit.wikimedia.org/r/96039 (owner: 10Aude) [00:43:14] (03CR) 10Addshore: [C: 031] Replace usage of deprecated Linker::makeKnownLinkObj function [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97214 (owner: 10Aude) [00:52:56] Hello. Is this the right place to ask for a pull request to be merged on the WikipediaMobile GitHub repo? [00:53:33] You'd probably want to ask in #wikimedia-mobile [00:53:42] But it's the wrong time of day to get a response [00:53:44] @Reedy Thanks! [00:53:49] @Reedy Ok [00:53:50] did you open a pull request? [00:54:10] Yes [00:56:32] @Reedy Do you think anyone's going to look at it soon? [00:56:42] When did you open it? [00:56:53] 9 minutes ago [00:57:23] heh [00:57:30] I'd certainly at least give it 24 hours [00:58:01] Alright; thanks [00:58:15] There's a similarly trivial pull request that's been out for 6 months [00:59:15] What do you think it would take to be added as a contributor just to work on the WikipediaMetro app? [01:01:47] Not sure. But having a couple of commits/pull requests in place first wouldn't hurt [01:04:01] Well, I can't make commits until I'm a contributor, and I can't make pull requests if nobody answers [01:04:14] Sure [01:04:36] But your request has been open for literally minutes [01:04:39] On a holiday weekend [01:05:18] /whois APerson241 [01:05:25] * Reedy claps bd808 [01:05:57] * APerson241 looks worried [01:06:10] I seem to recall mobile might be working more on a newer version of the apps [01:06:19] The commit log suggests only really localisation updates recently [01:09:39] Krinkle|detached: poke? [01:10:17] Krinkle|detached: just wanted to talk about scroll behaviour at some point soon. I've learned a bit about scroll handling since I wrote what I wrote, and I wanted to check on your requirements etc. [01:34:20] (03PS1) 10BryanDavis: Use PHPMailer to send mail [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98463 [02:44:28] (03CR) 10Tim Starling: [C: 04-1] "This is not compatible with wikis where thumbScriptUrl is set, e.g. on WMF private wikis. On wikis using thumbScriptUrl, the thumbnail dir" [core] - 10https://gerrit.wikimedia.org/r/96920 (owner: 10Gergő Tisza) [03:01:59] (03CR) 10Tim Starling: [C: 032] Made Lua code in JobQueueRedis more readable with unpack() [core] - 10https://gerrit.wikimedia.org/r/94397 (owner: 10Aaron Schulz) [03:07:02] (03Merged) 10jenkins-bot: Made Lua code in JobQueueRedis more readable with unpack() [core] - 10https://gerrit.wikimedia.org/r/94397 (owner: 10Aaron Schulz) [03:07:36] (03CR) 10Theopolisme: "Fabulous. Just let me know. :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98245 (owner: 10Theopolisme) [03:08:39] (03CR) 10Tim Starling: "Do you have an application for this? Just thinking of I51404ce3." [core] - 10https://gerrit.wikimedia.org/r/87650 (owner: 10Aaron Schulz) [03:17:08] (03CR) 10Tim Starling: [C: 04-1] "I think it would be more user-friendly to require that the prefix be a directory, and to automatically add the trailing slash if it is mis" [core] - 10https://gerrit.wikimedia.org/r/95304 (owner: 10Aaron Schulz) [03:19:14] (03CR) 10Tim Starling: Fixed fatal error when getLocalCopy() fails (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96640 (owner: 10Aaron Schulz) [03:19:18] (03PS2) 10Tim Starling: Fixed fatal error when getLocalCopy() fails [core] - 10https://gerrit.wikimedia.org/r/96640 (owner: 10Aaron Schulz) [03:19:23] (03CR) 10Tim Starling: [C: 032] Fixed fatal error when getLocalCopy() fails [core] - 10https://gerrit.wikimedia.org/r/96640 (owner: 10Aaron Schulz) [03:24:25] (03Merged) 10jenkins-bot: Fixed fatal error when getLocalCopy() fails [core] - 10https://gerrit.wikimedia.org/r/96640 (owner: 10Aaron Schulz) [03:35:44] (03PS2) 10Tim Starling: Call object_properties_init in create_object handlers for PHP 5.4 [php/luasandbox] - 10https://gerrit.wikimedia.org/r/96687 (owner: 10Anomie) [03:35:56] (03CR) 10Tim Starling: [C: 032] Call object_properties_init in create_object handlers for PHP 5.4 [php/luasandbox] - 10https://gerrit.wikimedia.org/r/96687 (owner: 10Anomie) [03:36:33] (03Merged) 10jenkins-bot: Call object_properties_init in create_object handlers for PHP 5.4 [php/luasandbox] - 10https://gerrit.wikimedia.org/r/96687 (owner: 10Anomie) [04:21:41] (03PS1) 10Gnosygnu: v0.12.0.0 [xowa] - 10https://gerrit.wikimedia.org/r/98468 [04:21:57] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/98468 (owner: 10Gnosygnu) [04:28:29] (03PS1) 10Legoktm: [WIP] Add the ability to send messages using the user's account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 [04:28:44] Elsie: ^ [04:31:12] (03PS2) 10Legoktm: [WIP] Add the ability to send messages using the user's account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 [04:33:44] legoktm: Oh my. [04:34:00] it works for the most part [04:34:07] (03PS3) 10Legoktm: [WIP] Add the ability to send messages using the user's account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 [04:34:48] just doesnt support flagging the edit as bot [04:52:34] (03PS4) 10Legoktm: Add the ability to send messages using the user's account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98469 [05:14:32] (03Abandoned) 10Legoktm: Add protection settings info to $wgRestrictionTypes and $wgRestrictionLevels [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96933 (owner: 10Legoktm) [05:28:18] Can anyone help me with enabling search suggestion in my mediawiki? [05:34:16] What's your question? [05:34:22] Hi stausifr. ^ [05:35:14] Hi Elsie: I want to enable search suggestions in my mediawiki. I have version 1.19 [05:35:21] You probably want #mediawiki. [05:35:57] stausifr: If you join #mediawiki, I may be able to help a bit. [06:11:52] (03CR) 10Parent5446: [C: 032] update.php: Add a full stop [core] - 10https://gerrit.wikimedia.org/r/98459 (owner: 10Bartosz Dziewoński) [06:14:54] (03Merged) 10jenkins-bot: update.php: Add a full stop [core] - 10https://gerrit.wikimedia.org/r/98459 (owner: 10Bartosz Dziewoński) [06:28:51] (03CR) 10Parent5446: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/98120 (owner: 10Umherirrender) [06:28:57] (03CR) 10Parent5446: [C: 032] Move closing parenthesis from multi line if and function to own line [core] - 10https://gerrit.wikimedia.org/r/98454 (owner: 10Umherirrender) [06:32:03] (03PS3) 10Jeroen De Dauw: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 [06:32:09] (03CR) 10Jeroen De Dauw: Remove now incomplete dependency lists for some projects (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 (owner: 10Jeroen De Dauw) [06:32:11] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/98120 (owner: 10Umherirrender) [06:33:49] (03Merged) 10jenkins-bot: Move closing parenthesis from multi line if and function to own line [core] - 10https://gerrit.wikimedia.org/r/98454 (owner: 10Umherirrender) [06:39:45] (03PS1) 10AndyRussG: Fix undelete courses and institutions [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98475 [06:40:54] done! w00t! [06:41:32] (03PS5) 10Parent5446: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/97544 (owner: 10Umherirrender) [06:41:48] (03CR) 10Parent5446: [C: 032] Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/97544 (owner: 10Umherirrender) [06:43:51] (03CR) 10Faidon Liambotis: "Thanks for the quick patch!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [06:46:40] (03Merged) 10jenkins-bot: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/97544 (owner: 10Umherirrender) [06:56:59] (03CR) 10Jack Phoenix: "This isn't an in-depth review, just a quick glance. With that in mind, so far so good!" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 (owner: 10UltrasonicNXT) [07:01:37] (03CR) 10Aaron Schulz: [C: 032] Replace usage of deprecated Linker::makeKnownLinkObj function [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97214 (owner: 10Aude) [07:02:06] (03Merged) 10jenkins-bot: Replace usage of deprecated Linker::makeKnownLinkObj function [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97214 (owner: 10Aude) [07:09:25] (03PS1) 10Aaron Schulz: Fixed key name typo [core] - 10https://gerrit.wikimedia.org/r/98478 [07:10:17] (03CR) 10Jack Phoenix: [C: 04-1] "I asked in #mediawiki a few days ago and we prefer $wgEnableSomeFunctionality over $wgDisableSomeFunctionality, so the globals should be r" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [07:10:33] (03CR) 10Aaron Schulz: [C: 032] Fixed key name typo [core] - 10https://gerrit.wikimedia.org/r/98478 (owner: 10Aaron Schulz) [07:14:33] (03Merged) 10jenkins-bot: Fixed key name typo [core] - 10https://gerrit.wikimedia.org/r/98478 (owner: 10Aaron Schulz) [07:58:27] (03CR) 10Amire80: Better GENDER support in moderation.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [08:05:28] (03CR) 10Shirayuki: Better GENDER support in moderation.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [08:33:31] liangent: I just noticed that "cdo" does not have a fallback language. Would zh-hans maybe be more appropriate than the current default en? [08:39:00] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98484 [08:39:21] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98484 (owner: 10Siebrand) [08:44:17] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98484 (owner: 10Siebrand) [08:51:53] (03PS1) 10Nikerabbit: Fix typo [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/98485 [09:18:20] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98486 [09:18:35] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98486 (owner: 10Siebrand) [09:22:40] (03CR) 10Siebrand: [C: 032] Fix typo [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/98485 (owner: 10Nikerabbit) [09:22:47] (03Merged) 10jenkins-bot: Fix typo [php/FastStringSearch] - 10https://gerrit.wikimedia.org/r/98485 (owner: 10Nikerabbit) [09:23:41] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98486 (owner: 10Siebrand) [09:54:10] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98490 [09:54:43] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98490 (owner: 10Siebrand) [09:55:55] (03PS4) 10Hashar: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 (owner: 10Jeroen De Dauw) [09:57:15] (03CR) 10Hashar: [C: 032] "amended commit summary to list out jobs being updated." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 (owner: 10Jeroen De Dauw) [09:57:57] (03Merged) 10jenkins-bot: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 (owner: 10Jeroen De Dauw) [09:58:57] (03Abandoned) 10Hashar: doc: converts hooks.txt to doxygen format [core] - 10https://gerrit.wikimedia.org/r/66128 (owner: 10Hashar) [09:59:02] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/98490 (owner: 10Siebrand) [10:04:15] (03PS7) 10Hashar: make-release: initial tarball test script [tools/release] - 10https://gerrit.wikimedia.org/r/89158 [10:08:16] (03PS8) 10Hashar: make-release: initial tarball test script [tools/release] - 10https://gerrit.wikimedia.org/r/89158 [10:09:26] (03CR) 10Hashar: [C: 032] "I have updated the tarball default path to point to ./build/ since that is where make-release.py generate the tarball by default." [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [10:09:28] (03Merged) 10jenkins-bot: make-release: initial tarball test script [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [10:18:57] (03PS4) 10Matthias Mullie: Insert new revision when Flow is taking over [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 [10:19:21] (03PS2) 10Hashar: make-release: update local repositories [tools/release] - 10https://gerrit.wikimedia.org/r/95825 [10:19:28] (03CR) 10Hashar: [C: 032] make-release: update local repositories [tools/release] - 10https://gerrit.wikimedia.org/r/95825 (owner: 10Hashar) [10:20:50] (03Merged) 10jenkins-bot: make-release: update local repositories [tools/release] - 10https://gerrit.wikimedia.org/r/95825 (owner: 10Hashar) [10:20:54] (03PS1) 10Hashar: mediawik-core-release: run phpunit tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98492 [10:23:00] (03CR) 10Matthias Mullie: [C: 031] "LGTM, once the comment has been updated" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 (owner: 10EBernhardson) [10:23:39] (03CR) 10Matthias Mullie: [C: 032] Don't attempt to fix redlinks in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98027 (owner: 10EBernhardson) [10:23:48] (03Merged) 10jenkins-bot: Don't attempt to fix redlinks in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98027 (owner: 10EBernhardson) [10:26:54] (03CR) 10Matthias Mullie: [C: 032] Outdent overindented code and rename a variable for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98359 (owner: 10Amire80) [10:27:06] (03Merged) 10jenkins-bot: Outdent overindented code and rename a variable for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98359 (owner: 10Amire80) [10:28:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [10:39:19] (03PS2) 10Hashar: mediawik-core-release: run phpunit tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98492 [10:42:44] (03CR) 10PleaseStand: [C: 04-1] Create ResourceLoaderLogoModule to load logo (033 comments) [core] - 10https://gerrit.wikimedia.org/r/98460 (owner: 10Tholam) [10:46:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 (owner: 10Brian Wolff) [10:49:18] (03PS1) 10Hashar: make-release: raise default phpunit timeouts [tools/release] - 10https://gerrit.wikimedia.org/r/98494 [10:49:30] (03CR) 10Hashar: [C: 032] make-release: raise default phpunit timeouts [tools/release] - 10https://gerrit.wikimedia.org/r/98494 (owner: 10Hashar) [10:49:32] (03Merged) 10jenkins-bot: make-release: raise default phpunit timeouts [tools/release] - 10https://gerrit.wikimedia.org/r/98494 (owner: 10Hashar) [10:55:38] (03CR) 10Siebrand: Update type hints in TraditionalImageGallery (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97477 (owner: 10Siebrand) [10:55:44] (03PS2) 10Siebrand: Update type hints in TraditionalImageGallery [core] - 10https://gerrit.wikimedia.org/r/97477 [10:58:16] (03PS3) 10Hashar: make-release: unit tests for MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96016 [10:58:36] siebrand: falling back to zh makes sense, but I'm not sure whether it's better to use nan [10:59:06] or, have nan and cdo fallback to each other first, then zh [10:59:08] liangent: Can you give it some thought, or make inquiries, and submit a patch? I'll approve,... [10:59:09] see https://en.wikipedia.org/wiki/Min_Chinese [11:00:24] (03PS2) 10Siebrand: Updates for Interwiki.php [core] - 10https://gerrit.wikimedia.org/r/97508 [11:00:26] (03CR) 10Siebrand: "PS2 resolves merge conflicts." [core] - 10https://gerrit.wikimedia.org/r/97508 (owner: 10Siebrand) [11:03:19] (03CR) 10Siebrand: "PS6 resolves merge conflict." [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [11:03:20] (03PS6) 10Siebrand: Document future removal of action=parse&prop=languageshtml [core] - 10https://gerrit.wikimedia.org/r/96364 [11:06:27] siebrand: I'm not very confident with my understanding of fallback: assume 'de' vanished and there're only 'de-at' and 'de-ch' existing. should they be falling back to each other first, then 'en'? [11:06:37] (03CR) 10Calak: [C: 031] Updates for Interwiki.php [core] - 10https://gerrit.wikimedia.org/r/97508 (owner: 10Siebrand) [11:06:53] in cdo/nan case, cdo = de-at, nan = de-ch, zh = en [11:07:07] (03PS3) 10Siebrand: Various fixes for EnhancedChangesList [core] - 10https://gerrit.wikimedia.org/r/96244 [11:07:22] (03CR) 10Siebrand: "PS3 resolves merge conflict." [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [11:07:32] (03CR) 10Hashar: [C: 032] make-release: unit tests for MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96016 (owner: 10Hashar) [11:09:16] liangent: fallbacks can be as you want them. For example, this would be valid fallbacks: pt -> pt-br-> fr -> it -> en, as $fallback = 'pt, pt-br, fr, it' [11:09:23] (03Merged) 10jenkins-bot: make-release: unit tests for MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96016 (owner: 10Hashar) [11:09:42] (03PS3) 10Hashar: make-release: enhance MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96038 [11:09:46] liangent: languages are allowed to fall back to each other. [11:10:00] See for example: [11:10:00] MessagesPt_br.php:$fallback = 'pt'; [11:10:01] MessagesPt.php:$fallback = 'pt-br'; [11:10:06] (03CR) 10Hashar: [C: 032] "Covered by tests so it should be fine. Will amend if something goes wrong." [tools/release] - 10https://gerrit.wikimedia.org/r/96038 (owner: 10Hashar) [11:11:06] (03Merged) 10jenkins-bot: make-release: enhance MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96038 (owner: 10Hashar) [11:20:38] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/38904 (owner: 10Amire80) [11:21:30] (03CR) 10Siebrand: [C: 032] Cleaning up English messages for clarity and correctness [core] - 10https://gerrit.wikimedia.org/r/98358 (owner: 10Amire80) [11:23:03] (03CR) 10Siebrand: [C: 04-1] Removed 'Disable browser page caching" user preference (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [11:25:36] (03CR) 10Siebrand: [C: 032 V: 032] Consistency tweak in preparation for adding extension to translatewiki.net [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/98306 (owner: 10Raimond Spekking) [11:25:38] (03Merged) 10jenkins-bot: Cleaning up English messages for clarity and correctness [core] - 10https://gerrit.wikimedia.org/r/98358 (owner: 10Amire80) [11:26:11] (03CR) 10Siebrand: [C: 032] Add some Meta specific user groups [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/98301 (owner: 10Raimond Spekking) [11:28:05] andre__: could you please approve https://www.google-melange.com/gci/task/view/google/gci2013/5884931574071296 ? [11:28:33] zeljkof, sure, done [11:28:48] andre__: thanks! :) [11:29:14] (03Merged) 10jenkins-bot: pages -> page. Only 1 link from Wikibase to Wikimedia Commons possible. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/98393 (owner: 10Raimond Spekking) [11:29:15] (03Merged) 10jenkins-bot: Add some Meta specific user groups [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/98301 (owner: 10Raimond Spekking) [11:36:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [11:37:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [11:41:12] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 (owner: 10Legoktm) [11:42:48] (03PS1) 10Liangent: Add fallback languages for cdo, hak and nan [core] - 10https://gerrit.wikimedia.org/r/98496 [11:43:35] siebrand: https://gerrit.wikimedia.org/r/98496 . using zh-hant instead of zh-hans, because existing messages in those languages are written in traditional han script [11:43:47] liangent: great [11:45:04] siebrand: however wuu messages are written in hant script, but wuu is falling back to zh-hans currently [11:45:08] I don't know why [11:45:19] anyway there're an existing bug asking for a converter for wuu [11:45:32] hm wuu and yue [11:46:49] (03PS1) 10Matthias Mullie: Alternative method to focus textarea [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98497 [11:48:56] (03CR) 10Siebrand: [C: 032] Add fallback languages for cdo, hak and nan [core] - 10https://gerrit.wikimedia.org/r/98496 (owner: 10Liangent) [11:50:51] (03CR) 10Hashar: [C: 032] "updated mediawiki-core-release" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98492 (owner: 10Hashar) [11:51:08] (03Abandoned) 10Hashar: tarball experiment [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86160 (owner: 10Hashar) [11:51:45] (03Merged) 10jenkins-bot: mediawik-core-release: run phpunit tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98492 (owner: 10Hashar) [11:51:54] (03Merged) 10jenkins-bot: Add fallback languages for cdo, hak and nan [core] - 10https://gerrit.wikimedia.org/r/98496 (owner: 10Liangent) [11:52:15] (03Abandoned) 10Hashar: tie to ruby 1.9.3 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/85813 (owner: 10Hashar) [11:53:15] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [12:01:33] (03CR) 10Siebrand: "This currently has no reviewers. You should probably assign a few. I'd review if I had subject matter expertise..." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [12:03:21] (03PS3) 10Amire80: Show a warning on page deletion if a page is linked to [core] - 10https://gerrit.wikimedia.org/r/65162 [12:04:56] (03CR) 10Siebrand: [C: 04-1] Update and remove unnecessary messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [12:14:32] (03Abandoned) 10Hashar: (WIP) jenkins-build-parse.py (WIP) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/75906 (owner: 10Hashar) [12:21:07] (03CR) 10Siebrand: "Is PS3 a rebase, a change, or both?" [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [12:22:50] (03CR) 10Siebrand: [C: 032] Add missing version comment to SqliteUpdater [core] - 10https://gerrit.wikimedia.org/r/98170 (owner: 10Umherirrender) [12:22:53] (03CR) 10Amire80: "Both, fixed punctuation." [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [12:23:21] (03CR) 10Siebrand: [C: 032] Correct version section for rc_source in the updaters [core] - 10https://gerrit.wikimedia.org/r/96874 (owner: 10Umherirrender) [12:27:45] (03Merged) 10jenkins-bot: Add missing version comment to SqliteUpdater [core] - 10https://gerrit.wikimedia.org/r/98170 (owner: 10Umherirrender) [12:27:46] (03Merged) 10jenkins-bot: Correct version section for rc_source in the updaters [core] - 10https://gerrit.wikimedia.org/r/96874 (owner: 10Umherirrender) [12:32:05] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97728 (owner: 10Hashar) [12:32:10] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97728 [12:33:40] (03PS1) 10Hashar: wikimedia-wikimania-scholarships-jslint now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98501 [12:33:48] (03CR) 10Hashar: [C: 032] wikimedia-wikimania-scholarships-jslint now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98501 (owner: 10Hashar) [12:34:05] (03Merged) 10jenkins-bot: wikimedia-wikimania-scholarships-jslint now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98501 (owner: 10Hashar) [12:36:39] (03CR) 10Amire80: "Technically it is OK. I am a bit doubtful about this because the letter is extremely simple, but if other Arabic speakers think that it is" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [12:40:16] (03CR) 10Siebrand: "Please do not mix rebases and code changes if it can be avoided. These changes require a full review, instead of a review of the diff betw" [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [12:48:37] (03CR) 10Siebrand: "Was merged with L10n issues." (031 comment) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [12:53:52] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 (owner: 10Legoktm) [12:53:55] YuviPanda: There? [12:59:14] (03PS1) 10Matthias Mullie: (bug 57698) recentchanges displaying raw topic title(?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98507 [13:07:25] (03PS2) 10Ebrahim: 'آ' for Persian [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 [13:08:06] Hi. Iḿ trying to register the ULS as a beta feature. I followed the steps as given here: https://www.mediawiki.org/wiki/Extension:BetaFeatures but I ran into this error: Warning: require(/vagrant/mediawiki/../extensions/UniversalLanguageSelector/UniversalLanguageSelector.hooks.php): failed to open stream: No such file or directory in /vagrant/mediawiki/includes/AutoLoader.php [13:11:02] (03CR) 10Theopolisme: "@Siebrand, care to expand on that?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [13:11:18] (03PS1) 10Hashar: phase out /srv/slave-scripts [integration/jenkins] - 10https://gerrit.wikimedia.org/r/98509 [13:11:37] (03CR) 10Hashar: [C: 032] phase out /srv/slave-scripts [integration/jenkins] - 10https://gerrit.wikimedia.org/r/98509 (owner: 10Hashar) [13:11:41] (03Merged) 10jenkins-bot: phase out /srv/slave-scripts [integration/jenkins] - 10https://gerrit.wikimedia.org/r/98509 (owner: 10Hashar) [13:21:30] (03PS8) 10Bartosz Dziewoński: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:22:08] (03PS1) 10Daniel Kinzler: Document parser cache key control. [core] - 10https://gerrit.wikimedia.org/r/98512 [13:22:50] (03CR) 10Bartosz Dziewoński: "Sorry, I was just leaving for the night yesterday when I left my comment. Glad you figured it out anyway :)" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:22:57] easy review --^^ [13:23:41] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks good to me now. Thank you!" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:26:09] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Uh, SpecialUserlogin too." [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:28:22] (03CR) 10Siebrand: [C: 031] "@Theopolisme: I think I made amistake ticking boxes here. I meant to:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [13:30:34] (03PS9) 10Bartosz Dziewoński: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:30:58] (03CR) 10Bartosz Dziewoński: [C: 032] "File permissions are actually correct *now*. :)" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:33:39] (03PS1) 10Hashar: phase out /srv/slave-scripts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98513 [13:35:23] (03CR) 10Hashar: [C: 032] phase out /srv/slave-scripts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98513 (owner: 10Hashar) [13:35:29] (03CR) 10Aude: [C: 04-1] "minor nitpick" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98512 (owner: 10Daniel Kinzler) [13:35:42] (03Merged) 10jenkins-bot: phase out /srv/slave-scripts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98513 (owner: 10Hashar) [13:35:58] (03Merged) 10jenkins-bot: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:37:58] (03CR) 10Amire80: "Gonna test in a minute, in the meantime just a comment." (031 comment) [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [13:39:17] (03PS3) 10Ebrahim: 'آ' for Persian [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 [13:43:20] (03CR) 10Amire80: [C: 031] "I tested the new addition for Persian (fa) and it works properly." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [13:48:45] (03PS16) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [13:51:57] (03PS1) 10Njw: Add any extra menus added to sidebar to middle column [skins/erudite] - 10https://gerrit.wikimedia.org/r/98514 [13:54:02] 1 [14:40:37] (03PS17) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [14:51:37] hashar: ping [14:51:43] Krinkle: lo [14:52:03] Can't make the checkin today, can we do it earlier? [14:52:16] sure [14:52:19] since you are awake [14:52:23] can do right now if you want [14:52:26] k [14:52:29] I hopefully got my headphones [14:53:45] Any bugzilla admin here that can see what's up with bugzilla's (email) config? I can't login and password reminders are not being delivered [14:54:05] (03PS2) 10Anomie: Don't localize Special:CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 [14:54:09] andre__: ^ [14:55:01] (03CR) 10Anomie: "Good catch. PS2 should prevent the redirect from "Special:CentralAutoLogin" to the localized name. I still need to check whether generated" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [14:55:01] Krinkle: is such stuff really configured via interface? [14:55:09] Yes [14:58:18] Krinkle, second time I hear this. Last time it took a while until the person received the address change email. [14:58:30] (I don't have access to mail server logs) [14:58:40] though last time I heard was one month ago [14:59:46] (03PS1) 10Siebrand: Use page instead of article. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/98525 [15:01:21] well, mchenry does look unusually busy https://ganglia.wikimedia.org/latest/?c=Miscellaneous%20pmtpa&h=mchenry.wikimedia.org&m=cpu_report&r=hour&s=descending&hc=4&mc=2 [15:01:28] (03CR) 10Raimond Spekking: [C: 032] Use page instead of article. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/98525 (owner: 10Siebrand) [15:02:34] (03Merged) 10jenkins-bot: Use page instead of article. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/98525 (owner: 10Siebrand) [15:03:19] (03PS1) 10Manybubbles: Restore log10 boost for link counts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98526 [15:03:55] (03PS3) 10Anomie: Don't localize Special:CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 [15:49:15] (03PS1) 10Matthias Mullie: Improve error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 [15:53:16] (03CR) 10MaxSem: "This one is superceded by recent PDF work - can be abandoned?:)" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/44848 (owner: 10Adamw) [15:54:56] (03PS4) 10Ebrahim: Changing "أ" to "و" as it is more common between all arab script derivatives [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 [15:57:27] (03CR) 10Amire80: [C: 031] Changing "أ" to "و" as it is more common between all arab script derivatives [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [15:58:47] (03CR) 10Chad: [C: 032] Restore log10 boost for link counts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98526 (owner: 10Manybubbles) [16:00:09] (03Merged) 10jenkins-bot: Restore log10 boost for link counts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98526 (owner: 10Manybubbles) [16:09:14] (03PS1) 10Chad: Updating CirrusSearch to master (ffef180) [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98534 [16:09:58] (03PS2) 10Matthias Mullie: Improve error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 [16:12:09] (03PS1) 10Chad: Updating Cirrus to master (ffef180) [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98535 [16:15:11] (03PS2) 10Chad: Updating Cirrus to master (ffef180) [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98535 [16:19:17] (03CR) 10Addshore: [C: 031] Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [16:27:51] (03PS1) 10Ragesoss: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 [16:31:01] (03PS18) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [16:31:17] (03CR) 10jenkins-bot: [V: 04-1] Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [16:33:52] (03CR) 10Amire80: [C: 032] Changing "أ" to "و" as it is more common between all arab script derivatives [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 (owner: 10Ebrahim) [16:36:27] (03CR) 10Legoktm: [C: 031] "Haven't tested." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98362 (owner: 10Whym) [16:42:00] (03PS1) 10Anomie: Protect tabs from HTML Tidy [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/98540 [16:43:13] (03PS1) 10Yaron Koren: Replaced wfMsg() calls with wfMessage(), improved comments [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 [16:43:37] (03PS2) 10Anomie: Protect tabs from HTML Tidy [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/98540 [16:44:56] (03CR) 10Brian Wolff: [C: 032] "Ok. If they serve a purpose that's fine - At first glance they just seemed a little odd." [core] - 10https://gerrit.wikimedia.org/r/97477 (owner: 10Siebrand) [16:46:21] (03CR) 10Zfilipin: "Chris, Jeff, please merge this into master if you do not have any complains." [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [16:46:23] (03CR) 10MaxSem: "Hmm, why not just link to the special page? My objection against special page transcluding is that once ResourceLoader 2.0 (zomg vaporware" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 (owner: 10Jackmcbarn) [16:46:42] (03CR) 10Zfilipin: "Chris, Jeff, please merge this into master if you do not have any complains." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [16:47:49] (03CR) 10Yaron Koren: [C: 032 V: 032] Replaced wfMsg() calls with wfMessage(), improved comments [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 (owner: 10Yaron Koren) [16:50:29] (03CR) 10Siebrand: "Pointed out some security issues." (031 comment) [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 (owner: 10Yaron Koren) [16:54:01] (03PS2) 10Njw: Add any extra menus added to sidebar to middle column [skins/erudite] - 10https://gerrit.wikimedia.org/r/98514 [16:55:27] (03PS3) 10Njw: Add any extra menus added to sidebar to middle column [skins/erudite] - 10https://gerrit.wikimedia.org/r/98514 [16:56:04] (03CR) 10Njw: [C: 032 V: 032] Add any extra menus added to sidebar to middle column [skins/erudite] - 10https://gerrit.wikimedia.org/r/98514 (owner: 10Njw) [16:57:17] (03CR) 10Siebrand: Improve error messages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 (owner: 10Matthias Mullie) [16:58:45] (03CR) 10Chad: [C: 032] Updating CirrusSearch to master (ffef180) [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98535 (owner: 10Chad) [16:58:50] (03CR) 10Chad: [C: 032] Updating CirrusSearch to master (ffef180) [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98534 (owner: 10Chad) [16:59:56] (03CR) 10Cscott: [C: 031] "anomie: ping" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [17:00:17] (03CR) 10Cscott: [C: 032] Improve status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97921 (owner: 10Cscott) [17:01:04] (03CR) 10Yaron Koren: "Thanks for the comments. So which is preferred, escaped() or parse()? (I feel like I've asked about this before, but I don't remember.)" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 (owner: 10Yaron Koren) [17:01:08] (03PS1) 10Cscott: Specify default collection language in the metabook file. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98542 [17:01:34] (03CR) 10Siebrand: "I couldn't say. Please have a look at the API documentation, and take your pick." [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 (owner: 10Yaron Koren) [17:01:55] (03Merged) 10jenkins-bot: Improve status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97921 (owner: 10Cscott) [17:02:13] (03Merged) 10jenkins-bot: Updating CirrusSearch to master (ffef180) [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98535 (owner: 10Chad) [17:05:26] (03Merged) 10jenkins-bot: Updating CirrusSearch to master (ffef180) [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98534 (owner: 10Chad) [17:06:28] (03CR) 10Brian Wolff: [C: 031] "There's a part of me that feels a little odd about exempting ourselves from anti-spam measures (seems kind of self-centred), but the logic" [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [17:06:39] (03PS2) 10Ragesoss: Display correct interface message when adding duplicate institution [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98537 [17:08:17] (03CR) 10Yaron Koren: "Alright - looks like parse() it is!" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 (owner: 10Yaron Koren) [17:10:33] (03PS2) 10Brian Wolff: Use canonical class name for SvgHandler and rename the test for consistency. [core] - 10https://gerrit.wikimedia.org/r/97316 (owner: 10Platonides) [17:11:44] (03CR) 10CSteipp: [C: 031] "That functionality looks like it should work. I'll let Siebrand comment if the translation should be handled another way. Otherwise I'll m" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 (owner: 10Anomie) [17:12:00] (03PS3) 10Matthias Mullie: Improve error messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 [17:12:12] (03CR) 10Matthias Mullie: Improve error messages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98533 (owner: 10Matthias Mullie) [17:12:25] (03CR) 10Hoo man: [C: 032] "I should have done this with I2ff35f8 back in December last year. Thanks :)" [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [17:14:30] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.org to default $wgNoFollowDomainExceptions [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [17:16:54] ugh, what's up now [17:18:09] Time: 30.38 seconds, Memory: 553.25Mb [17:18:37] sigh, why are those tests using mediawiki.org [17:19:02] 1) SideBarTest::testExternalUrlsRequireADescription [17:19:15] what's this?? 'active' => false [17:19:26] Nemo_bis: Our unit tests don't so much test if you break something, as much as testing if you changed anything at all [17:19:48] bawolff: yeah, or if you're using non-default config and sets of extensions in your checkout [17:20:18] Whenever I run unit tests, the process basically goes start commenting out stuff in LocalSettings.php until I stop getting fatal errors [17:20:38] jenkins should say SUCCESSFULLY CHANGED SOMETHING instead of FAILURE [17:21:20] I've never heard of someone running tests locally without errors :O we need to learn your commenting abilities [17:21:32] (03CR) 10Brian Wolff: [C: 032] Use canonical class name for SvgHandler and rename the test for consistency. [core] - 10https://gerrit.wikimedia.org/r/97316 (owner: 10Platonides) [17:23:05] oh I still get phpunit errors, I just manage to stop the script from dying with a fatal error before the test completes [17:23:38] bawolff: on https://www.mediawiki.org/w/index.php?title=User:Bawolff&diff=0&oldid=710345 , do you know https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_newbie_owner ? [17:23:53] csteipp: I'm running late for the Flow security meeting, don't wait for me [17:24:31] No i didn't. That's probably a more effective list [17:33:14] (03CR) 10Kipcool: [C: 032 V: 032] Tags [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/97692 (owner: 10Hiong3-eng5) [17:33:35] spagewmf: no problem. Is ebernhardson in SF? [17:34:07] (03CR) 10Kipcool: [C: 032 V: 032] Duplicate Expression [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/98145 (owner: 10Hiong3-eng5) [17:35:37] (03CR) 10Kaldari: [C: 032] Suppress on sender's deeper user subpages [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98362 (owner: 10Whym) [17:35:39] (03Merged) 10jenkins-bot: Suppress on sender's deeper user subpages [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98362 (owner: 10Whym) [17:36:59] (03CR) 10Cscott: [C: 032] Specify default collection language in the metabook file. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98542 (owner: 10Cscott) [17:38:02] (03Merged) 10jenkins-bot: Specify default collection language in the metabook file. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/98542 (owner: 10Cscott) [17:42:41] (03CR) 10Yaron Koren: "Calling $this->msg() in that file doesn't work - how should it be called?" [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 (owner: 10Yaron Koren) [17:45:30] (03CR) 10Siebrand: "Oops, my bad. Only works for non-static methods, obviously... Otherwise $this is now known." [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98541 (owner: 10Yaron Koren) [17:47:12] (03PS19) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [17:47:16] (03CR) 10jenkins-bot: [V: 04-1] Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [17:48:42] (03PS1) 10Matthias Mullie: Improve non-JS display of edit-(header|title|post) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98547 [17:50:44] (03PS1) 10Matthias Mullie: Don't assume $data['topic-title'] exists for every event [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98548 [17:50:52] Nemo_bis: https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/16799/console [17:52:18] (03PS20) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [18:10:39] hoo: yes, we were commenting it above [18:13:41] (03PS21) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [18:15:05] (03PS2) 10Brian Wolff: (minor) Make ApiFeedContributions respect $wgFeedLimit [core] - 10https://gerrit.wikimedia.org/r/39840 (owner: 10MrBlueSky) [18:15:12] (03PS1) 10saper: Remove background-color statements from CSS [extensions/Collection] - 10https://gerrit.wikimedia.org/r/98549 [18:15:40] (03PS1) 10Siebrand: Add PLURAL and GENDER support for some messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 [18:15:59] (03PS2) 10saper: Remove background-color statements from CSS [extensions/Collection] - 10https://gerrit.wikimedia.org/r/98549 [18:16:06] (03PS1) 10Yaron Koren: Added more error messages for when parser function params are not specified [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98551 [18:16:33] (03PS1) 10Amire80: Fix menu icon position for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98552 [18:18:31] (03CR) 10Yaron Koren: [C: 032 V: 032] Added more error messages for when parser function params are not specified [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98551 (owner: 10Yaron Koren) [18:20:11] (03PS1) 10Cscott: Improve status reporting for article/chapter processing. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98553 [18:20:12] (03PS1) 10Cscott: Keep LaTeX happy even if section has no items. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98554 [18:20:13] (03PS1) 10Cscott: Use \graphicspath to avoid overly-long graphics filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98555 [18:20:14] (03PS1) 10Cscott: Use exiftool to strip resolution information from JPEGs to avoid a LaTeX error. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 [18:20:15] (03PS1) 10Cscott: Fix tilde/caret when followed by numeric characters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98557 [18:20:16] (03PS1) 10Cscott: Only allow a single '.' in image filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98558 [18:20:17] (03PS1) 10Cscott: Make filenames "safe" before passing to image converters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98559 [18:20:18] (03PS1) 10Cscott: Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 [18:21:35] (03CR) 10jenkins-bot: [V: 04-1] Use exiftool to strip resolution information from JPEGs to avoid a LaTeX error. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98556 (owner: 10Cscott) [18:21:49] (03CR) 10jenkins-bot: [V: 04-1] Fix tilde/caret when followed by numeric characters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98557 (owner: 10Cscott) [18:22:02] (03CR) 10jenkins-bot: [V: 04-1] Only allow a single '.' in image filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98558 (owner: 10Cscott) [18:22:29] (03CR) 10jenkins-bot: [V: 04-1] Make filenames "safe" before passing to image converters. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98559 (owner: 10Cscott) [18:22:40] (03CR) 10jenkins-bot: [V: 04-1] Non-English language support via polyglossia. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98560 (owner: 10Cscott) [18:23:23] (03CR) 10UltrasonicNXT: "Thanks for your reply Jack." [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 (owner: 10UltrasonicNXT) [18:23:51] hoo: hopefully this is enough to fix it [18:23:54] (03CR) 10Kaldari: [C: 032] Fix OpenSearchXml integration [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/94178 (owner: 10MaxSem) [18:23:57] (03Merged) 10jenkins-bot: Fix OpenSearchXml integration [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/94178 (owner: 10MaxSem) [18:24:14] (03PS4) 10Nemo bis: Add mediawiki.org to default $wgNoFollowDomainExceptions [core] - 10https://gerrit.wikimedia.org/r/98089 [18:24:21] (03CR) 10Amire80: [C: 04-1] Add PLURAL and GENDER support for some messages (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [18:25:01] (03CR) 10Siebrand: Add PLURAL and GENDER support for some messages (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [18:25:26] (03CR) 10Hoo man: [C: 032] "Amended version looks ok also." [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [18:25:32] Nemo_bis: Let's see :D [18:26:31] (03PS2) 10Siebrand: Add PLURAL and GENDER support for some messages [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 [18:28:36] (03Merged) 10jenkins-bot: Add mediawiki.org to default $wgNoFollowDomainExceptions [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [18:28:45] Nemo_bis: \o/ ;) [18:28:48] :) [18:29:10] I didn't even consider those side effects back then :P [18:31:50] (03PS1) 10Brian Wolff: Add missing subjectspace pages to watchlist on update. [core] - 10https://gerrit.wikimedia.org/r/98563 [18:33:35] hoo: heh, tests make us notice the side effects :) [18:34:06] At least they should :D [18:34:29] (03PS2) 10Netbrain: Added support for execution to be done on client side. This to prevent max execution time error in php. [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 [18:35:42] (03PS3) 10Nemo bis: Quote the alleged "edit" message directly in livetranslate-dictionary-* [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/87562 [18:38:57] (03PS3) 10Bartosz Dziewoński: Remove background-color statements from CSS [extensions/Collection] - 10https://gerrit.wikimedia.org/r/98549 (owner: 10saper) [18:39:19] (03CR) 10Amire80: [C: 031] "A bit unusual, but probably will work. Didn't try to run." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98550 (owner: 10Siebrand) [18:40:02] (03CR) 10Bartosz Dziewoński: [C: 032] Remove background-color statements from CSS (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/98549 (owner: 10saper) [18:40:10] (03Merged) 10jenkins-bot: Remove background-color statements from CSS [extensions/Collection] - 10https://gerrit.wikimedia.org/r/98549 (owner: 10saper) [18:41:23] greg-g, hi. try mediawikiwiki now [18:41:42] taha! [18:41:44] thanks Krenair [18:41:54] I disabled that global block locally. [18:42:09] And poked the stewards about getting the global block removed [18:42:16] K4-713: still blocked other places... gotcha [18:42:22] er, sorry K4-713 [18:42:50] * K4-713 looks slightly relieved [18:42:59] Usually when I get pinged over here, somebody is after my blood. [18:42:59] (03CR) 10Bartosz Dziewoński: "Please update the documentation! https://www.mediawiki.org/wiki/Manual:$wgNoFollowDomainExceptions" [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [18:43:28] (03PS1) 10Siebrand: Add GENDER support for 'ep-articletable-remarticle-text' [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98567 [18:43:53] (03PS1) 10Anomie: Correct failure message when account is locked [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 [18:45:53] (03CR) 10Amire80: [C: 031] Add GENDER support for 'ep-articletable-remarticle-text' [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/98567 (owner: 10Siebrand) [18:47:31] (03PS2) 10Aaron Schulz: Avoid calling oldFileFromRowFactory field directly [core] - 10https://gerrit.wikimedia.org/r/98176 [18:48:19] ^d: ^ [18:48:28] (03CR) 10Nemo bis: "Jeroen, should I abandon this one?" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/87562 (owner: 10Nemo bis) [18:48:34] (03CR) 10Siebrand: [C: 032] Avoid calling oldFileFromRowFactory field directly [core] - 10https://gerrit.wikimedia.org/r/98176 (owner: 10Aaron Schulz) [18:48:36] Krenair: oh, where did you ping, somewhere public I could link to from https://meta.wikimedia.org/wiki/User_talk:J.delanoy#WMF_Office_IP_blocked ? [18:48:49] #wikimedia-stewards [18:49:04] <^d> AaronSchulz: siebrand beat me to it :) [18:49:27] * siebrand smiles. [18:49:33] lol, has someone been vandalizing at the WMF offices :P [18:51:14] * siebrand coughs... https://en.wikipedia.org/wiki/User_talk:216.38.130.164 [18:52:12] (03PS1) 10Aaron Schulz: Fixed api.php fatals due to protected field usage [core] - 10https://gerrit.wikimedia.org/r/98570 [18:52:21] siebrand: ^ [18:52:54] (03CR) 10Siebrand: [C: 032] "Grr... Tx." [core] - 10https://gerrit.wikimedia.org/r/98570 (owner: 10Aaron Schulz) [18:52:55] (03Merged) 10jenkins-bot: Avoid calling oldFileFromRowFactory field directly [core] - 10https://gerrit.wikimedia.org/r/98176 (owner: 10Aaron Schulz) [18:53:00] (03CR) 10Bsitu: [C: 032] Don't assume $data['topic-title'] exists for every event [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98548 (owner: 10Matthias Mullie) [18:53:27] siebrand: this is actually why I love "protected", if you don't use it people will abuse stuff horribly [18:53:30] AaronSchulz: Can't use head of master on twn anymore because of the composer maffia. [18:53:54] AaronSchulz: Yes, but getting rid of the legacy is a fucking nightmare. [18:54:20] (03PS1) 10Amire80: Add RTL images for the flag icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98572 [18:54:28] (03PS1) 10Umherirrender: Use TablePager on Special:ProtectedPages [core] - 10https://gerrit.wikimedia.org/r/98573 [18:54:31] chrismcmahon: do we have a no parameter api.php test? (e.g. the page that has the description of all the modules)? [18:54:41] bawolff: it's not uncommon for WMF IPs to be blocked, usually it's some network weirdness but sometimes just edits' weirdness :) [18:55:06] AaronSchulz: not that I know of, but I really wish that we did [18:55:08] the only assertion would be like "does this 503 or not" [18:55:19] or 5xx for that matter [18:55:31] look at the bright side too, like five new global blocking/locking bugs were just filed, and some already have patches :P [18:55:35] I've heard of various varnish/squid IPs being blocked, but I'm surprised about a WMF office IP being blocked [18:55:48] we should do this more often [18:56:02] AaronSchulz: greg-g and I have been discussing doing this sort of thing [18:56:27] (03CR) 10Umherirrender: "A possible use case for the new columns can be found under Iade82653999ca770586762b3c1383f73dfe3a5ee" [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [18:57:15] (03Merged) 10jenkins-bot: Don't assume $data['topic-title'] exists for every event [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98548 (owner: 10Matthias Mullie) [18:57:27] (03CR) 10Brian Wolff: [C: 032] "There's a slight problem in that this does 1 more than the limit, but that's also a problem with the limit url parameter, so not a problem" [core] - 10https://gerrit.wikimedia.org/r/39840 (owner: 10MrBlueSky) [18:58:21] (03Merged) 10jenkins-bot: Fixed api.php fatals due to protected field usage [core] - 10https://gerrit.wikimedia.org/r/98570 (owner: 10Aaron Schulz) [18:59:19] greg-g: may I push a configuration change for CentralNotice in todays LD? it'll be to change the hide cookie duration from 1 year to 10 months [18:59:22] (03PS1) 10Chad: Elastica to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98574 [18:59:33] (03CR) 10Chad: [C: 032 V: 032] Elastica to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98574 (owner: 10Chad) [19:00:31] mwalker: sounds controversial ;) [19:00:51] heh; everything's controversial :) [19:01:00] mwalker: :) cool, yeah, please add [19:01:08] kk [19:01:24] I may ping you again about re-enabling cross wiki hiding; I'm negotiating with paravoid currently [19:06:08] (03PS3) 10Umherirrender: Use TablePager on Special:ProtectedTitles [core] - 10https://gerrit.wikimedia.org/r/98252 [19:07:07] (03CR) 10Umherirrender: "Patch Set 3: Removed unneeded return, add comment and fixed spacing" [core] - 10https://gerrit.wikimedia.org/r/98252 (owner: 10Umherirrender) [19:09:05] (03CR) 10Kaldari: [C: 04-1] New API for selecting a task; related refactoring and minor fm (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [19:10:19] (03PS1) 10Mayankmadan: Merging the readme files of other repositories with this one. [selenium] - 10https://gerrit.wikimedia.org/r/98577 [19:15:41] marktraceur, cscott_away, anyone else interested: there's a small patch for the Education Program that's a bit urgent, perhaps someone would like to review it? https://gerrit.wikimedia.org/r/#/c/98475/ It's for a bug that a user came across yesterday (supposedly had been fixed, but reappeared) and the EP folks are hoping to get it through quickly, perhaps even out-of-cycle. Thanks a ton in advance! [19:15:41] (03PS1) 10EBernhardson: Sysops should not have the flow-suppress permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98580 [19:16:39] (03CR) 10Anomie: [C: 032] "Mainly just made sure all these code paths were hit, except for the "can't happen" one in the default case in luasandbox_lua_to_zval()." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:17:12] (03Merged) 10jenkins-bot: Plug leaks on error paths. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:17:51] (03CR) 10Aaron Schulz: [C: 032] Protect tabs from HTML Tidy [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/98540 (owner: 10Anomie) [19:18:00] (03Merged) 10jenkins-bot: Protect tabs from HTML Tidy [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/98540 (owner: 10Anomie) [19:26:22] (03PS5) 10Brian Wolff: Add $robotPolicy parameter to SpecialPage::setHeaders() [core] - 10https://gerrit.wikimedia.org/r/98255 (owner: 10leucosticte) [19:26:44] (03CR) 10PiRSquared17: [C: 04-1] "Infinitely better than what we currently have, but can a link to the globalauth log (e.g. //meta.wikimedia.org/wiki/Special:Log/globalauth" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [19:27:08] (03CR) 10PiRSquared17: "s/block/lock;" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [19:27:13] (03CR) 10Brian Wolff: [C: 032] "Looks fine." [core] - 10https://gerrit.wikimedia.org/r/98255 (owner: 10leucosticte) [19:27:59] (03CR) 10Alex Monk: "PiRSquared17:" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [19:29:03] bawolff: 216.38.130.165 has been blocked on mediawiki.org for months [19:29:58] (03PS1) 10Aude: Whitelist aarcos [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98583 [19:31:11] Nemo_bis, yes, only for anonymous users... it becomes an issue when logged in users can't edit either [19:31:14] (03PS2) 10Brian Wolff: Add missing subjectspace pages to watchlist on update. [core] - 10https://gerrit.wikimedia.org/r/98563 [19:31:15] (03PS1) 10Yurik: Updated zero ext [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98584 [19:31:48] (03CR) 10PiRSquared17: "Krenair:" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [19:32:44] (03Merged) 10jenkins-bot: Add $robotPolicy parameter to SpecialPage::setHeaders() [core] - 10https://gerrit.wikimedia.org/r/98255 (owner: 10leucosticte) [19:32:50] Krenair: I'm not saying it's an issue, just that it's common for WMF office's IPs to be blocked [19:32:51] (03PS1) 10Yurik: Updated zero ext [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98586 [19:33:04] (03CR) 10Bartosz Dziewoński: "Lol, Tidy sucks so bad. https://bugzilla.wikimedia.org/show_bug.cgi?id=54617" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/98540 (owner: 10Anomie) [19:33:56] (03CR) 10Aarcos: [C: 031] Whitelist aarcos [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98583 (owner: 10Aude) [19:37:02] (03CR) 10Alex Monk: "I don't think so, I tried that in Ifab83095" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [19:39:30] (03CR) 10PiRSquared17: [C: 031] "Okay." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98568 (owner: 10Anomie) [19:39:59] (03CR) 10MarkTraceur: [C: 032] "He's got shifty eyes, but we'll let him through for now." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98583 (owner: 10Aude) [19:40:21] (03Draft1) 10Wikinaut: L10n patch follow-up Ieff71386de02d0c9e428df5131467cc7af75faff [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/98588 [19:40:38] (03Merged) 10jenkins-bot: Whitelist aarcos [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98583 (owner: 10Aude) [19:41:36] (03PS1) 10Bartosz Dziewoński: Refactor RL modules related to Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/98589 [19:42:09] (03CR) 10Wikinaut: [C: 032 V: 032] "trivial L10n patch (thanks, Siebrand, for pointing me to this single forgotten qqq message of https://gerrit.wikimedia.org/r/#/c/94977/26/" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/98588 (owner: 10Wikinaut) [19:42:18] (03CR) 10Bartosz Dziewoński: "The cleanup I promised: https://gerrit.wikimedia.org/r/98589" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [19:43:15] (03CR) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account (031 comment) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [19:44:07] (03CR) 10Bartosz Dziewoński: "There is now new code in this patch, just moving stuff around." [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [19:44:14] (03CR) 10Bartosz Dziewoński: "no new code*" [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [19:46:39] (03CR) 10Yurik: [C: 032 V: 032] Updated zero ext [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98584 (owner: 10Yurik) [19:47:10] simple boring review --^^ [19:47:13] (03PS1) 10Siebrand: Consistency updates for localisation [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98592 [19:48:08] <^d> MatmaRex: Want some reviews? [19:48:09] <^d> :) [19:48:22] depends. giving or receiving? [19:48:35] (03CR) 10Yaron Koren: [C: 032 V: 032] "Thank you!" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98592 (owner: 10Siebrand) [19:48:39] <^d> giving, I've got a couple of misc. extension fixes. [19:48:42] <^d> globals, etc. [19:48:47] i think i still have some GCI reviewing to do [19:48:54] but i think i'll need krinkle for that [19:48:57] <^d> https://gerrit.wikimedia.org/r/#/q/is:open+owner:self+mediawiki/extensions+-Cirrus+-Wikimedia,n,z [19:48:59] @notify Krinkle [19:48:59] I'll let you know when I see Krinkle around here [19:49:07] ^d: "owner:self" [19:49:13] <^d> lol. [19:49:14] (03CR) 10Dzahn: [C: 032] Better instructions on top of enter_bug.cgi, link to guided form [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98041 (owner: 10Tholam) [19:49:23] (03CR) 10Dzahn: [V: 032] Better instructions on top of enter_bug.cgi, link to guided form [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98041 (owner: 10Tholam) [19:49:27] heh, i have three patches there. [19:49:39] <^d> https://gerrit.wikimedia.org/r/#/q/is:open+mediawiki/extensions+-Cirrus+-Wikimedia+owner:%22Chad+%253Cchadh%2540wikimedia.org%253E%22,n,z [19:49:40] <^d> :) [19:51:04] boooring [19:51:20] i haven't even heard of most of these, huh [19:51:54] hi Krinkle. [19:52:03] ^d: i'll review some later, maybe, but not now :( [19:52:13] <^d> k. [19:53:18] (03CR) 10Bartosz Dziewoński: [C: 032] Don't use $wgTitle, QuickTemplate has had getSkin() for well over 2 years [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/97564 (owner: 10Chad) [19:53:26] ok, that one was too simple to pass up [19:54:07] <^d> AaronSchulz: Did you see my comment on https://gerrit.wikimedia.org/r/#/c/94989/? [19:54:27] (03PS1) 10MarkTraceur: Un-templateify the MMV tests, make jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 [19:54:58] Krinkle, hashar, can has review of ^^ [19:54:59] ? [19:54:59] (03CR) 10Krinkle: [C: 04-1] "Needs logic for cache invalidation." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [19:55:10] <^d> I'm inclined to either come up with a nicer key (hard) or fail more badly (could be fun :p) [19:55:22] Just a +1 probably, I'll merge and deploy once our jslint patch is merged [19:55:43] (03CR) 10Bartosz Dziewoński: "$wgArticle is actually a global here. Are you sure nothing these scripts run doesn't depend on that global being set?" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/97551 (owner: 10Chad) [19:56:18] "nothing doesn't depend", ehh. [19:56:33] (that's enough for real for now.) [19:56:34] (03CR) 10Krinkle: "So no longer testextensions-master (phpunit) ?" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 (owner: 10MarkTraceur) [19:56:53] MatmaRex: What about the sitelogo thing? Why is extending the wikmodule a problem? [19:56:53] Krinkle: hah, you know, i was just going to ask you about those patches of tholam. :) [19:57:07] you linked me earlier, I have a buffer. [19:57:15] k [19:57:23] (03PS1) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [19:57:35] well, we need to override isKnownEmpty(), which looks hacky to me, and might not be the most efficient thing ever in general [19:57:45] (03CR) 10jenkins-bot: [V: 04-1] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [19:57:47] (03PS2) 10Matthias Mullie: (bug 57388) first click in [Start a new topic] jumps to textarea below [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98497 [19:57:55] and we need to combine logic for cache invalidation with the existing one [19:58:34] both of these mean that we need to much internal knowledge of RLWikiModule than i'm comfortable with when subclassing it like this [19:58:37] Krinkle: ^ [19:58:50] (03CR) 10Yurik: [C: 032 V: 032] Updated zero ext [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98586 (owner: 10Yurik) [19:59:10] (unless i'm missing something obvious to you) [19:59:38] MatmaRex: overriding isKnownEmpty is fine, because it unconditionally adds the css rule. Unless you make that css rule optional, there is no need to implement any known-empty logic. [20:00:03] As for the cache invalidation, that's just parent::() and then return max( $parentMTime, wglogomtime ) [20:00:08] (03CR) 10MarkTraceur: "We don't really have any useful PHP code in this extension, so that's probably fine - we just need JS unit testing, linting, and jslint." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 (owner: 10MarkTraceur) [20:00:26] which you calculate using the value-hash-cache-timestamp logic [20:00:28] we have no wglogomtime i'm aware of, unless we store the time we last noticed it changing [20:00:39] yes [20:00:48] ugh. [20:00:50] that's what we do for all values we cache that don't have timestamps. [20:00:57] we do the same for the language globals in langdata module [20:01:02] sounds unpleasant, but alright [20:01:36] so we stick to adding the logo to ResourceLoaderSiteModule? [20:01:48] (03CR) 10Dzahn: [C: 032 V: 032] Add warning that patches should go to Gerrit instead of Bugzilla [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 (owner: 10Tholam) [20:01:57] and definition timestamp, and git version hash, etc. there is no other way to calculate it without lots of spurious invalidations (e.g. you'd need an array of all files that can possibly affect this global, and then some, and hte max() of their files, which is terrible and doesn't even always work with git and wmf-config) [20:02:00] MatmaRex: Yep [20:02:03] Krinkle: while we're at it, let's change "#p-logo a" to ".mw-logo", hm? [20:02:14] .mw-wiki-logo, rather [20:02:34] Krinkle: WTF is going on with phpcs in VE [20:02:43] MatmaRex: Be sure to document that this means we will now always add a request for modules=site&only=styles on every page, where previously this only happened on wikis that enabled sitejs/css and actually created 1 or more wiki pages [20:02:51] MatmaRex: Sounds good [20:02:56] document where? [20:03:04] MatmaRex: Commit message [20:03:11] Krinkle: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/2103/console looks very broken [20:03:13] MatmaRex: Also, given the above, this will now depend on https://gerrit.wikimedia.org/r/#/c/95463/ [20:03:14] ah, duh. sure [20:03:24] hmm? [20:03:31] MatmaRex: If not, you need to change OutputPage to take these new factors into account, but probably easier to make it dependent on https://gerrit.wikimedia.org/r/#/c/95463/ [20:03:36] why would it? it seemed to work when i tested very biriefly [20:03:37] because we need to load site module unconditionally [20:03:47] MatmaRex: Delete your local site js/css pages [20:03:50] and try again :) [20:04:03] i have none. it loaded the site module when i changed isKnownEmpty to return false, i think [20:04:04] (03CR) 10Dzahn: "note: this is not adding 110 lines of new codes, it's just that when we make modifications files are copied from "./template/en/default/' " [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 (owner: 10Tholam) [20:04:20] MatmaRex: OK, in addition, disable the wg variarbles that enable it. [20:04:23] They are false on a new wiki by default. [20:04:39] i'mmm pretty sure they're true by default [20:04:46] wgUseSiteJs / Css? [20:04:48] or something [20:05:09] hashar: ping [20:05:09] hashar: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/2103/console [20:05:12] phpcs brokne [20:05:49] ok anyway, will have to check this [20:05:51] MatmaRex: okay, they weren' always true by default. Whatever, the point is, OutputPage has some harccoded logic beyond isKnownEmpty that will break your change if you don't fix it. [20:06:00] (03PS1) 10Bsitu: Add plural support to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98599 [20:06:01] got it, thanks [20:06:09] (03Abandoned) 10Brian Wolff: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97363 (owner: 10RAZVOR) [20:06:17] Krinkle: bah [20:06:21] Which is ugly, and why I remove it with https://gerrit.wikimedia.org/r/#/c/95463/ [20:06:57] understood, thanks [20:07:04] (03Abandoned) 10Brian Wolff: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97364 (owner: 10RAZVOR) [20:07:23] Krinkle: i really don't have time for this today/tomorrow, so i'll just paste this log on the bug, 'kay? [20:07:43] MatmaRex: OK (do simplify if you like, but OK either way) [20:07:44] why the hell did I thought I could use git-deploy [20:08:22] hashar: are you using the right fork ?:) [20:08:26] na [20:08:34] I am pissed of [20:08:43] what happened [20:08:52] that is a piece of fucking crap [20:09:26] Krinkle: fixed [20:10:28] for some reason git-deploy does not update submodules [20:10:32] how convenient is that ? [20:12:09] hashar: I suppose git-deploy only sync's the (staged) working copy, it doesn't git-pull, submodule-update, submodule-init or untracked files. [20:12:23] I am filling a bug for it [20:12:28] I don't even want to attempt to debug it [20:12:46] kind of nice, but not always intuitive. I could be wrong, but I think making it update submodule will be wontfix upstream. [20:12:48] I would, anyway. [20:13:22] I'm surprised it let' you sync without updating submodule [20:13:33] (03PS1) 10Njw: Check that navigation section exists before using it for top menu [skins/erudite] - 10https://gerrit.wikimedia.org/r/98603 [20:13:33] hashar: Thanks! [20:13:49] doesn't it forbid syncing a dirty copy? pulling down changes that include submodule leaves the working tree in dirty state (the subnmodule head) [20:13:53] hashar: oh, you mean on the minions? [20:14:00] oh crap, that's a dirty dirty bug [20:14:41] (03CR) 10Njw: [C: 032 V: 032] Check that navigation section exists before using it for top menu [skins/erudite] - 10https://gerrit.wikimedia.org/r/98603 (owner: 10Njw) [20:15:42] if anyone feels like teaching git-deploy the submodules … the bug is https://bugzilla.wikimedia.org/57880 [20:16:21] James_F: while you are around, I am finally able to connect between labs instance so I will soon make parsoid on beta to self update :-] [20:17:48] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=56257#c10 thanks [20:17:53] ^d: maybe you can look at https://gerrit.wikimedia.org/r/#/c/98071/ ? [20:19:52] (03CR) 10Krinkle: "A new module shouldn't be needed, this patch is obsolete with I89e32fcd27c9f0." [core] - 10https://gerrit.wikimedia.org/r/98460 (owner: 10Tholam) [20:20:54] (03CR) 10Krinkle: [C: 031] "LGTM. Should be merged by the person deploying it." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 (owner: 10MarkTraceur) [20:21:34] <^d> AaronSchulz: Do you want a merge? lgtm, but if you're wanting the other people on that list to review too I can just +1 [20:21:56] ^d: +2 is fine [20:21:58] (03CR) 10Anomie: [C: 04-1] "Found some bugs while testing." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:22:05] (03CR) 10Krinkle: Un-templateify the MMV tests, make jslint voting (031 comment) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 (owner: 10MarkTraceur) [20:22:17] (03CR) 10Chad: [C: 032] "less parsing :D" [core] - 10https://gerrit.wikimedia.org/r/98071 (owner: 10Aaron Schulz) [20:23:40] (03PS1) 10Manybubbles: fix formatting typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98607 [20:23:51] (03PS2) 10Manybubbles: fix formatting typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98607 [20:25:08] (03CR) 10Aaron Schulz: Fixes to RedisBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:25:40] (03Merged) 10jenkins-bot: Avoid parsing more in refreshLinksJobs [core] - 10https://gerrit.wikimedia.org/r/98071 (owner: 10Aaron Schulz) [20:28:28] Reedy: Can you check bugzilla config and see if you can figure out why emails are not being sent? (at least not for password reminders) [20:28:35] Alternatively, help me reset my password by other means maybe? [20:28:48] I have almost no access to bugzilla [20:29:10] hashar: Woo. [20:29:18] * yuvipanda gives Reedy editbugs [20:29:23] Reedy: Do you have read acceess to the main admin conf / Email ? [20:29:37] Nope [20:29:46] hexmode: andre__: Can you check bugzilla config and see if you can figure out why emails are not being sent? (at least not for password reminders). Alternatively, help me reset my password by other means maybe? [20:29:50] Reedy: k [20:30:14] Krinkle, Bugzilla config has not changed [20:30:20] mutante might be a better person to ask if he's not busy [20:30:46] andre__: Can you verify General configration / Email has Mail set to SMTP etc. ? [20:31:07] or edit my user (there is a way for admins with edituser to change/reset password, right?) [20:31:08] Krinkle, yes, because I receive bugmail all of the time. [20:31:12] OK [20:31:17] hey,i was wondering earlier myself [20:31:22] why wikibugs was slow to reply [20:31:26] well, I've reset my password 3 times over the day. Still nothing and I can't login. [20:31:29] but then it did all at once [20:31:34] (03CR) 10Siebrand: [C: 032] fix formatting typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98607 (owner: 10Manybubbles) [20:31:36] like there was some delay but eventually worked [20:31:36] hmm [20:31:37] (03Merged) 10jenkins-bot: fix formatting typo [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/98607 (owner: 10Manybubbles) [20:31:56] thought it was just the bot [20:32:00] maybe we should enable use_mailer_queue in the preferences [20:32:14] (not right now, but in the middle run) [20:32:52] (03PS2) 10MarkTraceur: Un-templateify the MMV tests, make jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 [20:32:57] (03PS1) 10MaxSem: Update MobileFrontend to wmf4 tip [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98609 [20:33:26] i checked kaulen, looks normal, sends out mail to mchenry as usual [20:33:36] not like a huge mail queue there [20:34:10] (03PS1) 10MaxSem: Update MobileFrontend to wmf5 tip [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98611 [20:34:54] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf4 tip [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98609 (owner: 10MaxSem) [20:34:57] (03CR) 10Krinkle: [C: 04-1] Refactor RL modules related to Special:Userlogin (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [20:35:11] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf5 tip [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98611 (owner: 10MaxSem) [20:35:20] andre__: I still haven't gotten any of the password reset e-mails. Tried a 4th time now. [20:35:28] Been about 15 hours since the first try. [20:35:45] The number of tabs open with draft comments is getting unmanagable :-/ [20:36:18] Krinkle, well, I could manually reset your password to something, but then I'd still have to send you your password in a somehow secure way. [20:36:36] can't do anything about mail being slow [20:36:39] andre__: I'm fine with IRC PM, or @wikimedia.org e-mail [20:37:09] My mail (both gmail.com and wikimedia.org) are working fine, checked spam/junk as well. [20:37:32] Krinkle: but i also see mchenry sending stuff to you at gmail [20:37:44] dunno what it is [20:37:45] notifications or password reminder [20:38:23] notifications, it's the same message to multiple bug cc's [20:38:45] do you get notifications? [20:39:23] Yes [20:39:30] (03CR) 10Bartosz Dziewoński: Refactor RL modules related to Special:Userlogin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [20:39:54] ok, in that case, no need to keep looking at exim logs then [20:40:03] then it should really be in bugzilla [20:40:45] Krinkle, check your mailbox [20:40:47] (03PS2) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [20:40:48] (03PS1) 10Cscott: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 [20:40:49] (03PS1) 10Cscott: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 [20:41:00] (03CR) 10Krinkle: Avoid parsing more in refreshLinksJobs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98071 (owner: 10Aaron Schulz) [20:41:29] andre__: Thx, got it. [20:41:56] andre__: oh, silly me. It was buried in the filter I have for bugzilla notifications. Set it up too wide, it matched the e-mail. Found it now, though already used yours. Thanks :) [20:42:12] :) [20:42:32] see, people? reading bugmail pays off! [20:42:48] I do read it, it is a filter to apply a label and move from Inbox to All Mail [20:42:49] bugmail about bugmail is the best bugmail [20:42:54] (03PS2) 10Daniel Kinzler: Document parser cache key control. [core] - 10https://gerrit.wikimedia.org/r/98512 [20:42:57] so I don't get buzzed 24/7 about cc changes [20:43:06] (03CR) 10PleaseStand: [C: 04-1] Site logo loaded using UserSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [20:43:17] but I'm like 7 days behind [20:45:45] (03PS1) 10Dan-nl: js-error-output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 [20:45:49] (03CR) 10jenkins-bot: [V: 04-1] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [20:46:07] (03CR) 10jenkins-bot: [V: 04-1] Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [20:46:29] (03CR) 10jenkins-bot: [V: 04-1] Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [20:47:02] cscott_away: :( [20:47:56] cscott_away: seems https://gerrit.wikimedia.org/r/#/c/98556/ introduce some npm test regression [20:52:20] greg-g: FYI, we're scrubbing the Parsoid deployment scheduled for 8 minutes' time, as it's not needed. Sorry for the short notice. VE deployment at 14:00 still going ahead. [20:52:45] James_F: thanks for the heads up. [20:52:59] greg-g: Always. :-) [20:53:20] wikitech, why are you always logging me out?! [20:53:29] (03CR) 10Bartosz Dziewoński: Site logo loaded using UserSiteModule instead of inline (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [20:53:47] I like typing my password 80 times a day as much as the next guy... [20:54:08] James_F: oh, you already got it, thanks [20:55:03] (03PS2) 10Cscott: Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 [20:55:04] (03PS2) 10Cscott: Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 [20:55:05] (03PS3) 10Cscott: Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 [20:55:22] (03CR) 10jenkins-bot: [V: 04-1] Improve BR/DIV linebreak handling. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98665 (owner: 10Cscott) [20:55:40] (03CR) 10jenkins-bot: [V: 04-1] Suppress 'toplink' on hewiki. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98666 (owner: 10Cscott) [20:55:54] (03CR) 10jenkins-bot: [V: 04-1] Support explicit DIR attributes on HTML elements. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98597 (owner: 10Cscott) [20:56:33] (03PS1) 10Yaron Koren: Removed #get_external_data parser function - it was time. [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98687 [21:01:14] (03CR) 10Siebrand: [C: 032] Add plural support to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98599 (owner: 10Bsitu) [21:03:05] (03Abandoned) 10Yaron Koren: Removed #get_external_data parser function - it was time. [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98687 (owner: 10Yaron Koren) [21:04:33] (03CR) 10Siebrand: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account (031 comment) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [21:06:09] (03Merged) 10jenkins-bot: Add plural support to comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98599 (owner: 10Bsitu) [21:08:59] (03CR) 10Parent5446: [C: 032] "Four people +1'ing including Brad....I think we're good to go." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [21:09:36] (03CR) 10Legoktm: [C: 04-2] "This isn't supposed to be merged until there is a deployment plan for WMF sites." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [21:09:52] errrrr [21:10:03] (03CR) 10Anomie: "@Parent5446: Did we ever get figured out about the undeploying of AssertEdit when this is being deployed?" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [21:10:10] (03CR) 10jenkins-bot: [V: 04-1] Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [21:13:23] (03CR) 10Parent5446: ":/ somebody should have put a procedural -2 then. Sorry about that." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [21:15:04] (03CR) 10Siebrand: Add $robotPolicy parameter to SpecialPage::setHeaders() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98255 (owner: 10leucosticte) [21:15:34] AaronSchulz, Reedy: https://gerrit.wikimedia.org/r/#/c/98255/ causes issues. [21:15:57] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/65162 (owner: 10Amire80) [21:16:51] (03PS1) 10Legoktm: Don't use $wgUser in WikiLoveHooks::getUserTalkPage [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98691 [21:20:11] (03PS1) 10Parent5446: Revert "Add $robotPolicy parameter to SpecialPage::setHeaders()" [core] - 10https://gerrit.wikimedia.org/r/98692 [21:21:18] (03CR) 10Siebrand: [C: 032] Revert "Add $robotPolicy parameter to SpecialPage::setHeaders()" [core] - 10https://gerrit.wikimedia.org/r/98692 (owner: 10Parent5446) [21:21:41] Krinkle: Did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=13953#c24 ? [21:24:28] (03PS1) 10Yaron Koren: Removed deprecated #get_external_data - it was time. [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98693 [21:24:42] (03CR) 10Krinkle: [C: 04-1] "A little too much code change imho (a bit beyond obvious review / cleanup), but already reviewed now, so just for next time." (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [21:25:55] (03CR) 10Yaron Koren: [C: 032 V: 032] Removed deprecated #get_external_data - it was time. [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/98693 (owner: 10Yaron Koren) [21:25:56] (03CR) 10Anomie: Added support for purging backlinks in the wiki farm (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [21:27:17] (03Merged) 10jenkins-bot: Revert "Add $robotPolicy parameter to SpecialPage::setHeaders()" [core] - 10https://gerrit.wikimedia.org/r/98692 (owner: 10Parent5446) [21:27:31] (03CR) 10EBernhardson: [C: 04-1] "One possible worry, this would insert a revision even if the user is just viewing an empty page?" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [21:33:22] (03PS1) 10Cmcmahon: Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 [21:33:31] (03PS2) 10Cmcmahon: Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 [21:34:21] (03PS1) 10Yaron Koren: Replaced wfMessage()->text() with ->parse(), per Siebrand's recommendation [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/98697 [21:34:37] (03PS3) 10Cmcmahon: Check that anons do not see Actions or Block User links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98696 [21:35:20] (03CR) 10Bartosz Dziewoński: "Some quick replies, thanks." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [21:36:31] (03CR) 10Aaron Schulz: Added support for purging backlinks in the wiki farm (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [21:36:51] (03CR) 10EBernhardson: "Also this only catches pages requested via wiki page url, we additionally need to do this for the api requests." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [21:37:08] ^demon|lunch: https://bits.wikimedia.org/static-1.23wmf4/common/images/poweredby_mediawiki_88x31.png [21:37:44] (03CR) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [21:37:46] <^demon|lunch> ori-l: Yes? [21:38:51] legoktm: https://bugzilla.wikimedia.org/show_bug.cgi?id=13953#c25 [21:39:40] <^demon|lunch> ori-l: https://bits.wikimedia.org/static-1.23wmf4/skins/common/images/poweredby_mediawiki_88x31.png works, your url is missing the /skins/ bit [21:40:06] Krinkle: thanks. [21:42:27] Krinkle: for reviewing the extension, would it be easier if was https://gerrit.wikimedia.org/r/#/c/94837/ just merged and the extension reviewed on what's in the repo, or just do the review on that patch since it's basically the entire extension? [21:42:37] (03CR) 10Krinkle: Added support for purging backlinks in the wiki farm (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [21:43:20] legoktm: Both. [21:43:44] legoktm: only good code should be merged, but it'll also be reviewed architectually separately [21:44:38] alright [21:45:03] (03CR) 10Brian Wolff: "Ideally this would send RefreshLinks jobs for the case where a file is fully deleted, or the file is uploaded and there wasn't previously " [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [21:45:19] <^demon|lunch> ori-l: Was there a question buried in here somewhere? Or were you just wanting to share urls? :) [21:45:34] legoktm: there won;t be much to review separately, but just making sure that it being merged does not mean it is OK for deployment. [21:45:37] ^demon|lunch: sorry, bug was on my end [21:45:40] your reply was right [21:45:46] <^demon|lunch> k :) [21:46:10] Krinkle: right [21:48:29] (03PS2) 10Legoktm: Display a notice on top of the edit window when editing global.css/js [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 [21:48:30] (03CR) 10jenkins-bot: [V: 04-1] Display a notice on top of the edit window when editing global.css/js [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 (owner: 10Legoktm) [21:50:30] (03PS4) 10Aaron Schulz: Added support for purging backlinks in the wiki farm [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 [21:51:37] (03PS5) 10EBernhardson: Insert new revision when Flow is taking over [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [21:52:16] (03CR) 10Anomie: Added support for purging backlinks in the wiki farm (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 (owner: 10Aaron Schulz) [21:52:51] (03CR) 10EBernhardson: [C: 032] "PS4: Updated to only create the article if the workflow exists(including if the workflow is created this request) and to apply the same lo" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [21:53:03] (03Merged) 10jenkins-bot: Insert new revision when Flow is taking over [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [21:54:16] (03CR) 10Kaldari: [C: 032] Don't use $wgUser in WikiLoveHooks::getUserTalkPage [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98691 (owner: 10Legoktm) [21:54:18] (03Merged) 10jenkins-bot: Don't use $wgUser in WikiLoveHooks::getUserTalkPage [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98691 (owner: 10Legoktm) [21:55:12] (03CR) 10EBernhardson: [C: 032] (bug 57698) recentchanges displaying raw topic title(?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98507 (owner: 10Matthias Mullie) [21:55:22] (03Merged) 10jenkins-bot: (bug 57698) recentchanges displaying raw topic title(?) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98507 (owner: 10Matthias Mullie) [22:00:03] (03PS6) 10EBernhardson: Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [22:00:19] (03CR) 10EBernhardson: "PS6: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [22:01:48] (03CR) 10Gergő Tisza: "Is this a good idea? Users should be able to make useful error reports without having to learn how to inspect HTTP requests. Isn't it enou" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [22:03:53] (03CR) 10MarkTraceur: [C: 032] "'kay, here we go" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 (owner: 10MarkTraceur) [22:04:15] (03Merged) 10jenkins-bot: Un-templateify the MMV tests, make jslint voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98595 (owner: 10MarkTraceur) [22:06:03] (03CR) 10Krinkle: "Seems to work locally, though the unconditional calling of setPagetitle() seems suspicious. It doesn't cause a problem in my local testing" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 (owner: 10Jackmcbarn) [22:06:23] hashar: Dumb question, but does service zuul restart not work on gallium? [22:06:26] (03CR) 10Brian Wolff: "I would assume Chris meant that he just wanted you to escape the error message before putting it into html (?)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [22:06:40] Er, reload. [22:06:51] marktraceur: sudo -su jenkins; /etc/init.d/zuul reload [22:06:53] marktraceur: it waits for all jobs currently running to have completed [22:07:10] I mean [22:07:13] marktraceur: I usually do sudo su - jenkins ; cd /etc/zuul/wikimedia && git pull [22:07:17] I know it's /etc/init.d/zuul reload [22:07:23] It's a graceful restart that only affects internal proces (not the main process) [22:07:27] then /etc/init.d/zuul reload and then tail -f /var/log/zuul/zuul.log [22:07:31] But usually when I see that my instinct is to replace /etc/init.d/ with service [22:07:43] or watch https://integration.wikimedia.org/zuul/ [22:08:11] the soft restart gets added to the queue internally, so it can take a while before it actually does [22:08:24] restart I can't remember, I think it wait for current jobs to finish then save the queued events somewhere [22:08:34] yep [22:08:48] restart will also miss events while restarting, though it'll save the current queue. [22:08:57] reload should be fine now, queue is empty. [22:09:32] You seem to be misunderstanding my question [22:10:28] The instructions for deployment say "/etc/init.d/zuul reload" but every modern instruction list I've seen recently tends to say "service $WHATEVER reload" instead - e.g. "service apache2 restart" or "service zuul reload" [22:10:46] I'm just curious if that's conscious [22:11:22] csteipp, what would you like re: https://gerrit.wikimedia.org/r/98686 [22:11:29] I never use "service", so I wouldn't recommend using it. You'd have to verify with that package to see if that supports it in all cases. [22:11:34] marktraceur: ohhh [22:11:40] marktraceur: I never use "service" either [22:11:44] Zuul installs it in init.d and using that works. [22:11:47] * yuvipanda always uses 'service' [22:11:48] Hm. [22:11:51] 'kay [22:11:55] * yuvipanda wonders if it is an init vs upstart thing [22:11:59] Oh, yuvipanda uses it, it *must* be wrong. :P [22:12:04] :P [22:12:32] I think 'service' got introduced on redhat [22:12:51] the idea was to provide the same command regardless of the backend init / systemv whatever system being used [22:13:05] but don't quote me on that hehe [22:13:10] heh [22:13:50] marktraceur: the service shell script seems to simply pass the command to the service. Might be faster to type service parsoid reload [22:14:00] might even come with some tab completion if you have bash-completion [22:14:17] heh, we don't put the "man" command on labs instances? [22:14:20] hashar: Exactly, I didn't think there would be anything complex about it [22:14:25] dzahn@muzilla:~$ man man [22:14:25] -bash: man: command not found [22:14:30] mutante: 'twould be sexist [22:14:33] mutante: :-] [22:14:37] marktraceur: :) [22:14:40] * yuvipanda gives marktraceur a pull request [22:14:51] mutante: I think that is the same on labs, man is not in the default image :( [22:14:56] yuvipanda: Fer what? [22:15:08] marktraceur: feel free to update the Zuul doc to use 'service' :] [22:15:16] s/use/refers to/ [22:15:18] hashar: With pleasure [22:15:34] !g Iaefc77236 [22:15:34] https://gerrit.wikimedia.org/r/#q,Iaefc77236,n,z [22:15:44] marktraceur: random OT joke, will PM link. [22:16:09] !g I170437fc [22:16:09] https://gerrit.wikimedia.org/r/#q,I170437fc,n,z [22:17:56] hashar: creating bug ..:) [22:18:43] mutante: while at it, ask for a refresh of the basic image. It is fairly outdated. [22:19:25] (03PS1) 10Legoktm: Create a fresh Title object in the job [extensions/MassMessage] (1.23wmf5) - 10https://gerrit.wikimedia.org/r/98709 [22:19:34] (03PS1) 10Catrope: Update VisualEditor to wmf4 branch for cherry-pick [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98710 [22:19:58] (03CR) 10Legoktm: [C: 032] Create a fresh Title object in the job [extensions/MassMessage] (1.23wmf5) - 10https://gerrit.wikimedia.org/r/98709 (owner: 10Legoktm) [22:20:39] (03Merged) 10jenkins-bot: Create a fresh Title object in the job [extensions/MassMessage] (1.23wmf5) - 10https://gerrit.wikimedia.org/r/98709 (owner: 10Legoktm) [22:21:02] hashar: found existing " Custom image needs ubuntu-standard package " . that's it [22:21:39] (03PS1) 10Catrope: Update VisualEditor to wmf5 branch for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98712 [22:21:59] Seems puppet doesn't install man, and it's not in the default ubuntu image [22:22:03] we're using. [22:22:12] nice [22:22:13] Seems puppet doesn't install man, and it's not in the default ubuntu image [22:22:24] argg, that https://bugzilla.wikimedia.org/show_bug.cgi?id=54080 [22:24:42] mutante: that could be part of the basic image that we use in openstack [22:24:59] but yeah, seems simple enough to add it in [22:25:47] upvoted [22:27:30] (03PS3) 10Bsitu: Clicking 'comment' in history should take user to the comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 [22:30:37] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf5 branch for cherry-pick [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/98712 (owner: 10Catrope) [22:30:42] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf4 branch for cherry-pick [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/98710 (owner: 10Catrope) [22:37:51] (03CR) 10Hoo man: [C: 04-1] "We could put that along the lines of the preferences-summary message. If you're ok with that I'll do that sometime soon." [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [22:38:07] ^d: queeestion. U cloned the drush repo for me, but I do not see any of the upstream branches. [22:38:47] <^d> In the middle of a few things. Can you send me an e-mail? Preferably with urls :) [22:38:53] sure [22:40:06] marktraceur, hi, do you think this GCI task is completed: https://gerrit.wikimedia.org/r/#/c/98148/ [22:40:42] Hm [22:40:56] Sorry, I didn't see it recently [22:42:25] qgil: Seems not [22:42:27] It's not i18nable [22:42:32] Which won't work for Commons [22:42:36] Which is UW's main client [22:43:08] qgil: I'd either send Theopolisme back to the drawing board or withdraw this one from the pool, it may be more complicated than you want if it involves messing with i18n? [22:44:50] marktraceur, one option is to close this one , since i18n was not mentioned in the task description / bug report. Then, open a new task to internationalize it. [22:44:55] Yeah [22:44:57] Well [22:45:02] eh, adding some messages is not very hard [22:45:06] qgil: Can patches span multiple tasks? [22:45:18] and siebrand said "l10n reviewed"? [22:45:20] (03PS1) 10Cscott: Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 [22:45:23] MatmaRex: Maybe not for us, but they'll probably also need to work on documenting...wait wat [22:45:29] * MatmaRex has no idea what the task is about [22:45:32] (03CR) 10GWicke: "Ping!" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93526 (owner: 10Ori.livneh) [22:45:38] (03CR) 10jenkins-bot: [V: 04-1] Suppress hyperlinks in indexed section titles. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/98715 (owner: 10Cscott) [22:45:50] MatmaRex: hmm? [22:45:59] usable message documentation is not very hard either [22:46:03] siebrand: see marktraceur above [22:46:15] siebrand, this is about https://gerrit.wikimedia.org/r/#/c/98148/ [22:46:59] anyway, i had a GCI student or two add/use messages in some tasks already and none of them complained it was hard :) [22:47:12] (that was core, so we had to explain what messages.inc and messagesTypes.inc is too) [22:47:17] MatmaRex, I haveno better criteria than yours [22:47:37] MatmaRex: Ah. Yes, I reviewed that. I'm technically okay with the L10n/i18n changes. I think there may be something to be said about the implementation, but I try to keep a little focused these days. [22:48:05] (one of the patches was https://gerrit.wikimedia.org/r/#/c/96584/ , i don't have others at hand – this one turned out to be a little bigger than i expected, but rather okay) [22:48:45] (03CR) 10MarkTraceur: "Wait wat?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [22:49:19] (03PS3) 10Mattflaschen: New API for selecting a task; related refactoring and minor fm [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 [22:49:41] (03CR) 10Mattflaschen: "Comments addressed in patch set 3, plus a minor fix to the error text." (035 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [22:50:27] Thank you marktraceur for the comment in Gerrit I will follow the discussion. It is ok to ask the student to implement i18n, as MatmaRex has done with other students [22:50:45] (03PS1) 10Siebrand: Rephrase 'openstackmanager-securitygrouprule-ranges-help' [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/98716 [22:50:59] 'kay [22:52:17] (03CR) 10Theopolisme: "Well, the idea here is that for Commons, there is *no* message displayed -- it was useful back when UpWiz was first introduced, but now se" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [22:52:50] (03CR) 10Jdlrobson: [C: 032] Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [22:53:05] matanya, have you seen https://wikitech.wikimedia.org/wiki/Get_involved [22:53:21] (03Merged) 10jenkins-bot: Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [22:54:43] (03CR) 10Andrew Bogott: [C: 032 V: 032] Rephrase 'openstackmanager-securitygrouprule-ranges-help' [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/98716 (owner: 10Siebrand) [22:55:02] (03CR) 10MarkTraceur: "Hrm." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [22:56:17] (03CR) 10Theopolisme: "But then the question is, what should the message say? Right now, there's not really much for it *to* say, short of "Welcome to the Upload" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [22:56:28] (03CR) 10EBernhardson: [C: 04-1] "additionally, the preview action in modules/base/ui-functions.js needs to be updated to pass a page title" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [22:56:33] (03PS7) 10EBernhardson: Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [22:56:57] (03CR) 10Siebrand: "If anything, I'd just remove the cruft altogether, and not leave the headerMessage configuration setting behind." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [22:57:17] (03CR) 10EBernhardson: [C: 031] "PS7: Addressed comments against PS6, would prefer someone else check over my updates." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [22:57:36] (03CR) 10MarkTraceur: "Honestly it would be fine for it to say nothing (i.e. '') and be untranslated - see https://www.mediawiki.org/wiki/Localisation#Messages_t" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [23:05:03] (03CR) 10Kaldari: [C: 04-1] New API for selecting a task; related refactoring and minor fm (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [23:11:13] (03PS1) 10Kaldari: Removing constructor that doesn't do anything. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98717 [23:14:06] (03PS2) 10EBernhardson: use explicit transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 [23:14:27] (03PS3) 10EBernhardson: Wire up the buffered cache to db transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 [23:15:21] (03Abandoned) 10Tholam: Create ResourceLoaderLogoModule to load logo [core] - 10https://gerrit.wikimedia.org/r/98460 (owner: 10Tholam) [23:17:00] (03CR) 10Mwalker: [C: 031] API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [23:21:43] (03PS4) 10Mattflaschen: New API for selecting a task; related refactoring and minor fm [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 [23:22:15] (03CR) 10Mattflaschen: "Wording fixes made in patch set 4." (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [23:22:23] (03PS1) 10Krinkle: Install Grunt plugin for csslint [integration/jenkins] - 10https://gerrit.wikimedia.org/r/98722 [23:24:15] (03CR) 10CSteipp: "An extra layer of escaping would be fine too. The error message should have html escaped, but could contain "<script>", which .html(" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 (owner: 10Dan-nl) [23:27:23] (03CR) 10Legoktm: [C: 032] Removing constructor that doesn't do anything. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98717 (owner: 10Kaldari) [23:27:32] (03Merged) 10jenkins-bot: Removing constructor that doesn't do anything. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/98717 (owner: 10Kaldari) [23:35:14] (03PS2) 10Krinkle: Install Grunt plugin for csslint [integration/jenkins] - 10https://gerrit.wikimedia.org/r/98722 [23:35:24] (03CR) 10Kaldari: [C: 032] New API for selecting a task; related refactoring and minor fm [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [23:35:26] (03Merged) 10jenkins-bot: New API for selecting a task; related refactoring and minor fm [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [23:36:38] Krinkle: Sorry, I forget, what's the difference between "test" and "gate-and-submit"? [23:36:44] (03PS1) 10Dan-nl: mime-type [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98725 [23:37:31] I *think* "test" happens after a trusted user +1s. [23:37:33] But I dunno. [23:38:49] Oh, I see, it's documented in layout.yaml, never mind [23:42:05] (03PS1) 10MarkTraceur: Enable qunit tests on MultimediaViewer patches [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98726 [23:42:46] (03CR) 10MarkTraceur: [C: 032] Enable qunit tests on MultimediaViewer patches [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98726 (owner: 10MarkTraceur) [23:43:16] (03Merged) 10jenkins-bot: Enable qunit tests on MultimediaViewer patches [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/98726 (owner: 10MarkTraceur) [23:47:06] (03PS1) 10EBernhardson: Set a global cache time within Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98728 [23:47:50] (03CR) 10Krinkle: JSDuck-ify /resources/mediawiki.language/* (033 comments) [core] - 10https://gerrit.wikimedia.org/r/98380 (owner: 10Bartosz Dziewoński) [23:48:16] marktraceur: test runs on patch set submission by trusted person (or after V+2 otherwise) [23:48:30] marktraceur: gate-and-submit runs after the V+2 for projects where jenkins does the merge [23:48:39] so there can be many hours between the two [23:48:45] (03PS1) 10MarkTraceur: Add MultimediaViewer to qunitable extension list [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98731 [23:48:49] *nod* [23:48:53] plus, the latter will run in a special queue that is bound to merging [23:48:55] Krinkle: I sorted it out [23:49:20] And you mean C+2 [23:49:26] Indeed [23:50:28] (03CR) 10Krinkle: [C: 032] Install Grunt plugin for csslint [integration/jenkins] - 10https://gerrit.wikimedia.org/r/98722 (owner: 10Krinkle) [23:50:42] (03Merged) 10jenkins-bot: Install Grunt plugin for csslint [integration/jenkins] - 10https://gerrit.wikimedia.org/r/98722 (owner: 10Krinkle) [23:52:04] (03PS2) 10MarkTraceur: Add MultimediaViewer to qunitable extension list [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/98731 [23:56:39] (03PS1) 10Cmcmahon: experimental fix for Bug 57702 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98732 [23:57:05] (03PS2) 10Dan-nl: js-error-output [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/98686 [23:57:32] (03CR) 10Jdlrobson: "Porting to LESS first would really make this css and thus the diff more readable :)" [core] - 10https://gerrit.wikimedia.org/r/98589 (owner: 10Bartosz Dziewoński) [23:59:04] (03PS1) 10MegaAlex: Change the reset button text in Special: PasswordReset to 'Reset Password' [core] - 10https://gerrit.wikimedia.org/r/98733