[00:28:57] jackmcbarn: For AnomieBOT? Unless you have something to say about it, just remove the section [00:29:10] kk [00:33:23] (03PS1) 10BryanDavis: Add PHPMailer via Composer [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98355 [00:36:45] (03CR) 10BryanDavis: [C: 032] "This should be uncontroversial." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98355 (owner: 10BryanDavis) [00:36:51] (03Merged) 10jenkins-bot: Add PHPMailer via Composer [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98355 (owner: 10BryanDavis) [00:38:57] * YuviPanda|away creates some controversies for bd808 [00:39:35] YuviPanda|away: Like >80 char lines in python? :P [00:39:46] bd808: hah! :D perceptive [00:39:56] I need to convince someone to override jenkins on that one [00:40:02] STUPID RULE!!1 [00:41:36] YuviPanda|away: I disagree, but I edit with vim in an 80 column terminal [00:41:49] bd808: indeed! [00:45:51] Hello... does anyone know where MW designers hang out on a Saturday evening? [00:46:32] AndyRussG: usually... nowhere on IRC. [00:46:38] AndyRussG: I'd suggest emailing design list [00:46:49] Ah great idea [00:47:07] AndyRussG: :D [00:47:17] YuviPanda|away: Thanks :) [00:47:23] yw [00:57:09] (03PS1) 10Tholam: Site logo loaded using UserCSSPrefsModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [00:57:39] (03CR) 10Parent5446: [C: 031] "@Swalling - Could you please elaborate as to why re-adding signupend is such a bad idea? In the end it is just an extra div that does not " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [01:01:21] (03CR) 10Parent5446: [C: 031] "Looks good. Will give some time to let others see." [core] - 10https://gerrit.wikimedia.org/r/98255 (owner: 10leucosticte) [01:01:51] (03CR) 10Parent5446: [C: 031] Add mediawiki.org to default $wgNoFollowDomainExceptions [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [01:03:10] (03CR) 10Parent5446: Removed 'Disable browser page caching" user preference (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98276 (owner: 1001tonythomas) [01:10:22] (03CR) 10Parent5446: [C: 04-1] "Minor quip" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [01:10:46] (03PS2) 10Parent5446: Changed FOR UPDATE handling in Postgresql [core] - 10https://gerrit.wikimedia.org/r/69767 [01:20:26] (03PS1) 10Jcf2000: Reformat signin captcha in case of incorrect login [core] - 10https://gerrit.wikimedia.org/r/98357 [01:34:50] (03CR) 10Swalling: "No one asked that we add signupend back. The bug cited says nothing about it." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [01:37:38] (03CR) 10Jcf2000: "When I patched this through, it added the "\r" character at the end of each line. Is there an quick/easy way to remove all of those?" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [02:29:19] (03PS2) 10Jeroen De Dauw: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 [03:10:01] (03PS2) 10Jcf2000: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 [03:12:54] (03CR) 10Jcf2000: "PS2" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [05:54:11] (03CR) 10Parent5446: "> It contains content. In the case of examples from Wikimedia" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [05:56:12] (03CR) 10Parent5446: [C: 04-1] "This sounds like it belongs in an extension. MediaWiki core itself does not include CAPTCHA support." [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [06:40:34] (03CR) 10Theopolisme: [C: 04-1] "Hey, thanks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98245 (owner: 10Theopolisme) [07:26:30] (03PS1) 10Amire80: Cleaning up English messages for clarity and correctness [core] - 10https://gerrit.wikimedia.org/r/98358 [08:36:10] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix bug with require by explicily using $dir [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98282 (owner: 10UltrasonicNXT) [08:52:21] (03PS1) 10Amire80: Outdent overindented code and rename a variable for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98359 [08:57:47] (03PS5) 10Amire80: Grammar and consistency in English messages [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/38904 [09:02:19] (03CR) 10Jcf2000: "Valid point, however it seems that the restyling of the CAPTCHA was already implemented directly into the core" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [09:47:06] (03PS5) 10Nemo bis: Add direct links to translation interface on Special:AllMessages [core] - 10https://gerrit.wikimedia.org/r/94064 [10:29:05] Ahmad96_________: fix your connection [10:34:46] Jasper_Deng: He just has a *very* dynamic ip ;-) [10:35:01] maybe he should get a bouncer xD [10:46:29] (03PS4) 10Umherirrender: Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 [10:47:25] (03CR) 10Umherirrender: "Patch Set 4: Use false to disable" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [10:50:58] Jasper_Deng: Just send him to #wikimedia-get-a-bouncer [10:51:48] multichill: lol I'm not an op in here [10:56:48] (03PS1) 10Umherirrender: Simplify switch in BacklinkCache::getConditions [core] - 10https://gerrit.wikimedia.org/r/98361 [11:22:31] (03PS1) 10Whym: * find root title instead of base title for subpages [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98362 [11:26:36] (03PS2) 10Whym: * prevent being shown on own user subpages by finding root title instead of base title [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98362 [11:41:17] (03PS15) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [11:41:31] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [11:53:11] (03PS1) 10Umherirrender: Avoid repeat of class name when appending in Linker [core] - 10https://gerrit.wikimedia.org/r/98364 [11:54:06] (03CR) 10Bartosz Dziewoński: [C: 031] Restore Signupstart and Signupend messages for account creation [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97192 (owner: 10MarkAHershberger) [11:54:12] (03CR) 10Bartosz Dziewoński: [C: 031] Restore Signupstart and Signupend messages for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [12:00:50] physikerwelt: math 2.0 is looking quite nice [12:02:25] physikerwelt: in the interest of moving forward, perhaps we should ask an external ocaml coder for a review ? [12:08:20] (03CR) 10Bartosz Dziewoński: TableSorter: Fix column order when collecting headers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98250 (owner: 10TheDJ) [12:09:17] (03CR) 10Bartosz Dziewoński: [C: 031] "Waiting for another set of eyes :)" [core] - 10https://gerrit.wikimedia.org/r/98250 (owner: 10TheDJ) [12:10:27] thedj: Yes that would be an option. However, I think it's quite easy to review since I just deleted unneccery stuff. [12:10:48] Do you know an external ocaml reviewer? [12:13:28] physikerwelt: nope, but there are a few ocaml related sites, we could go ask around :D [12:14:06] ok if you could give me a pointer I could ask them [12:20:53] physikerwelt: i'm sure we could get a bit of attention on https://groups.google.com/forum/#!forum/fa.caml [12:28:57] thedj: ok I'll try that [12:39:08] physikerwelt: has the math wmflabe instance been running math 2.0 ? [12:41:17] This one: http://math-test2.instance-proxy.wmflabs.org/wiki/Main_Page ? [12:41:42] This is math 2.0 [12:42:08] I have merged everything to the dev branch [12:42:33] k [12:44:58] how is ocaml with utf-8 btw ? [12:47:03] if you use something like \text{öälö} everything works since ocaml passes the bytes without understanding that those are multibyte chars [12:47:04] (03PS1) 10Amire80: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 [12:47:40] ah cool [12:47:53] I don't think that we should use ocaml in the future... I'm just not a fan of changing everything at the same time [12:49:05] physikerwelt: yeah, i agree with that [12:49:15] I have already reimplemented all important features of the ocaml code in php but there are some minor differences [12:49:49] not all {} are placed in the same way in my php implmentation and some nasty rewriting is not done as well [12:50:31] I think it's unreasonable to spend effort on reproducing the exact behaiviour of the ocaml code [12:51:11] well that discussion is exactly why i think it's better left out :D [12:51:12] i.e. I don't understand why all this addition brakets should be added or why a_b^c should be better than a^c_b [12:52:47] physikerwelt: why is the lbrack/rbrack commented in the texvccheck ? [12:53:34] texutil.ml [12:54:32] I think this is a bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=54624 [12:55:37] (03CR) 10TheDJ: [C: 04-1] "Hmm, as far as I understand ocaml, it's looking OK" (0313 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [12:56:15] physikerwelt: ah, so you moved it ? [12:56:26] to properly close [12:56:32] Hi, What can be the reason for {{PAGESINCATEGORY}} suddenly start return zero? [12:57:50] thedj: at least that was inteded [12:58:48] k [13:00:14] well i think we should follow trough on this, see if we can get an outside review on the correctness of ocaml. might want to confer with csteip on that. [13:03:34] gtg. will be back later today [13:03:35] I'm not worried about the correctness, since it produces exactly the same output as the old output for all equations occuring in the english wikipedia, but I would like to get some feedback on the style [13:04:08] security/resource usage correctness i meant. [13:14:37] evgen2: you mean other than the category being empty? [13:14:44] evgen2: on what page? on what wiki? [13:16:25] (03PS16) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [13:16:37] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [13:17:01] MatmaRex yes, on any non-empty category [13:17:47] MatmaRex wiki.laser.ru [13:18:39] evgen2: on what page? (i don't speak russian) [13:19:46] MatmaRex - zeros on main page [13:21:18] (03CR) 10Physikerwelt: [V: 032] "@TheDJ:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [13:22:11] evgen2: huh. weird. [13:22:58] (03PS51) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [13:24:09] evgen2: the data about the number of entries in each category is stroed in the 'category' table [13:24:12] !table category [13:24:12] For help on creating tables in wikitext, see and [13:24:16] !db category [13:24:16] See http://www.mediawiki.org/wiki/Manual:category_table [13:24:33] evgen2: can you verify it's not full of zeroes? :) [13:26:58] MatmaRex strange thing http://wiki.laser.ru/index.php/TestPage [13:27:41] MatmaRex It works for just created category [13:28:28] evgen2: it sounds like something weird happened to the actual data, then, but it should be possible to somewhat easily recompute this [13:29:52] evgen2: try running `php maintenance/populateCategory.php --force` [13:29:55] !maintenance [13:29:56] https://www.mediawiki.org/wiki/Manual:Maintenance_scripts [13:30:25] i have no idea what could have caused that data to disappear, though. [13:30:35] (or maybe it's some other issue entirely.) [13:38:41] (03CR) 10Bartosz Dziewoński: [C: 04-1] "You probably need `global $wgLogo;` somewhere for this to work." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [13:42:24] (03PS2) 10Shirayuki: Better GENDER support in moderation.js [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [13:43:38] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Copy-pasting code is bad, please don't do it. It's okay to modify existing modules or split them." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:43:55] (03CR) 10Bartosz Dziewoński: "And yeah, this should not be in core, but it currently is, so let's just fix the issue here now and worry about that later." [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [13:44:09] (03CR) 10Shirayuki: "added description for unused parameter $2" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [13:46:08] (03CR) 10Shirayuki: [C: 031] Outdent overindented code and rename a variable for clarity [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98359 (owner: 10Amire80) [13:52:29] (03CR) 10Bartosz Dziewoński: [C: 032] "Why not. We really should come up with a better way to do this than sticking more and more stuff into that array, though." [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [13:55:27] (03Merged) 10jenkins-bot: Add JavaScript variable wgContentNamespaces [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [13:56:03] who is maintaining http://simple.wikipedia.beta.wmflabs.org/wiki/Schr%C3%B6dinger_equation ? [13:56:31] or more generally wikipedia.beta.wmflabs.org [14:04:28] (03CR) 10Umherirrender: "todo was added with Ibb86b51073b980eda9ecce2cf0b8dd33f058adbf" [core] - 10https://gerrit.wikimedia.org/r/98364 (owner: 10Umherirrender) [14:07:27] physikerwelt: https://integration.wikimedia.org/ [14:08:09] or https://www.mediawiki.org/wiki/Beta_cluster [14:09:44] Nemo_bis: Thanks [14:10:17] (03CR) 10Bartosz Dziewoński: [C: 032] Avoid repeat of class name when appending in Linker [core] - 10https://gerrit.wikimedia.org/r/98364 (owner: 10Umherirrender) [14:10:22] I added my request to the open tasks list [14:13:13] (03Merged) 10jenkins-bot: Avoid repeat of class name when appending in Linker [core] - 10https://gerrit.wikimedia.org/r/98364 (owner: 10Umherirrender) [14:18:29] (03PS1) 10UltrasonicNXT: {{NUMBEROFCOMMENTSPAGE}} magic word/parser funct [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 [14:25:01] (03CR) 10Amire80: [C: 032] Prefer double-quoted strings in Ruby code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 (owner: 10Mayankmadan) [14:25:03] (03CR) 10jenkins-bot: [V: 04-1] Prefer double-quoted strings in Ruby code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 (owner: 10Mayankmadan) [14:26:08] YuviPanda: Hi. There? [14:26:15] (03CR) 10Shirayuki: "This is out of my domain." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/98375 (owner: 10UltrasonicNXT) [14:32:57] MatmaRex popolateCategory doesn't help [14:34:09] evgen2: i have no idea, then :( [14:34:53] MatmaRex now I have 2 just created pages in Category Test wiki.laser.ru/index.php/Category:Test and PAGESINCATEGORY returns 1 [14:36:11] (03PS2) 10Amire80: Prefer double-quoted strings in Ruby code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 (owner: 10Mayankmadan) [14:36:26] (03CR) 10Amire80: [C: 032] Prefer double-quoted strings in Ruby code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 (owner: 10Mayankmadan) [14:36:43] (03Merged) 10jenkins-bot: Prefer double-quoted strings in Ruby code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 (owner: 10Mayankmadan) [14:43:03] How do I manipulate the design(CSS) of elements in the sidebar? [14:44:43] MatmaRex looks like some MySQL InnoDB: error clustered record for sec rec not found InnoDB: index `cat_title` of table `wiki`.`category` [14:45:43] Niharika: I suggest reading https://www.mediawiki.org/wiki/Manual:Interface/Sidebar#Sidebar_width_in_Vector_skin_.28CSS.29 [14:46:06] and other parts of the page [14:46:15] whym: Thanks. [14:48:01] MatmaRex I confuse may be with numbers that is shown in categories for the number of articles [15:09:34] (03CR) 10Siebrand: "Ping." [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [15:22:22] (03PS1) 10Bartosz Dziewoński: jquery.spinner: Improve documentation formatting [core] - 10https://gerrit.wikimedia.org/r/98378 [15:53:49] YuviPanda: There? [15:56:26] plop [16:00:06] Nikerabbit: Is there a way to add elements to the sidebar using javascript only? [16:00:27] Nikerabbit: I could do it using the hook. [16:03:59] Niharika: you can do anything you want with javascript [16:06:05] (03PS1) 10Bartosz Dziewoński: JSDuck-ify /resources/mediawiki.language/* [core] - 10https://gerrit.wikimedia.org/r/98380 [16:06:14] Nikerabbit: Okay. Where do I find these JavaScript files? Which directory? [16:06:16] Niharika: mw.util.addPortletLink [16:06:29] Niharika: file://localhost/F:/mediawiki/core/docs/js/index.html#!/api/mw.util-method-addPortletLink [16:06:35] agh, wrong link D: [16:06:55] Niharika: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.util-method-addPortletLink [16:07:38] Okay. Thanks MatmaRex! :) [16:44:51] (03CR) 10Tholam: "Oops I had put global $wgLogo on the one I was testing but forgot to put it in the file I uploaded. About the location I was looking at th" [core] - 10https://gerrit.wikimedia.org/r/98356 (owner: 10Tholam) [16:47:49] (03PS3) 10Whym: Suppress on sender's deeper user subpages [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/98362 [16:51:47] (03CR) 10Brian Wolff: [C: 04-1] "These types of type hints seem different from normal. Do we usually do this? See also inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97477 (owner: 10Siebrand) [18:14:57] (03PS3) 10Jcf2000: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 [18:16:01] (03CR) 10jenkins-bot: [V: 04-1] Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [18:22:20] (03PS4) 10Jcf2000: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 [18:23:01] (03CR) 10Jcf2000: "PS4 removes trailing whitespace" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [18:23:24] (03CR) 10jenkins-bot: [V: 04-1] Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [18:28:27] (03PS5) 10Jcf2000: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 [18:42:52] (03PS18) 10Brian Wolff: (bug 40588) LinkSearch cannot search with a port in the url [core] - 10https://gerrit.wikimedia.org/r/28908 (owner: 10MrBlueSky) [18:44:44] (03PS1) 10Raimond Spekking: pages -> page. Only 1 link from Wikibase to Wikimedia Commons possible. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/98393 [18:49:34] (03CR) 10Brian Wolff: [C: 032] "PS18 rebased." [core] - 10https://gerrit.wikimedia.org/r/28908 (owner: 10MrBlueSky) [18:57:02] (03CR) 10Lydia Pintscher: [C: 031] pages -> page. Only 1 link from Wikibase to Wikimedia Commons possible. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/98393 (owner: 10Raimond Spekking) [19:01:58] (03CR) 10Parent5446: [C: 04-1] "Minor issue" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [19:03:32] (03CR) 10Parent5446: [C: 031] Add $wgHideUserContribLimit config setting [core] - 10https://gerrit.wikimedia.org/r/98267 (owner: 10Umherirrender) [19:09:00] (03CR) 10Raimond Spekking: [C: 032 V: 032] "+2 per Lydias +1 and comment on translatewiki.net" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/98393 (owner: 10Raimond Spekking) [19:31:27] marktraceur: I have a little problem [19:32:59] marktraceur: The function from ext.multimediaViewer.js is a littile vague... [19:33:20] the repoInfo variable gets its data from another function and so on [19:33:58] everything is chaned together, I would have to almost everything from the file to get that info [19:34:06] is there any other way ? [19:34:08] chained* [19:34:34] to take almost* [19:40:38] vandrew_: You can save it somewhere in the interface as a data attribute [19:47:31] marktraceur: so I'll do this in the first file this.$useFile.data( 'repoInfo', null ); [19:48:13] then after the repoInfo initialisation this.$useFile.data('repoInfo, repoInfo); [19:48:22] and then call it in the other file as [19:48:38] repoInfo= this.$useFile.data('repoInfo'); ? [19:48:51] Something like that, yeah [19:49:07] cool [19:49:08] thx [19:49:10] vandrew_: You may not need the whole thing though [19:49:20] wait ? [19:49:28] wait ? [19:49:35] what do you mean by the whole thing ? [19:50:03] if I do the initialisation in ext.multimediaViewer.js [19:50:19] and call that in the interface file [19:50:41] marktraceur: shouldn't that work ? [19:55:52] Yeah it should [19:56:05] I'll push a commit right away [19:56:05] But you only need repoInfo.local, not the whole thing, so it may be OK to limit what you save [19:56:08] Either way works :) [19:56:09] yea [19:56:10] of course [19:56:14] marktraceur: Looks like there's interest in beta features, there was someone at Project:Support_desk asking how to install it [19:59:45] bawolff: how to install BetaFeatures or beta features? [20:00:08] bawolff: That's cool! [20:00:17] lol, the former [20:00:42] The made specific reference to the link in the personal actions bar [20:00:42] (we really suck at naming, don't we. :P) [20:00:49] *they [20:00:53] Yes, yes we do [20:01:03] Could be worse, imagine if they renamed it [20:01:13] Looking at you, flaggedRevs/PendingChanges [20:01:42] * MatmaRex whistles innocently… [20:02:41] If I remember correctly, at one point someone from the design team wanted to rename LiquidThreads to something else, which got an interesting response [20:02:43] * MatmaRex https://bugzilla.wikimedia.org/show_bug.cgi?id=56537 [20:02:54] GreyBlocks! [20:03:14] * marktraceur will never be able to think of it as anything else now. :P [20:04:04] We could just make all the features shitty, and call it alpha features! [20:08:07] (03CR) 10Aaron Schulz: [C: 032] Simplify switch in BacklinkCache::getConditions [core] - 10https://gerrit.wikimedia.org/r/98361 (owner: 10Umherirrender) [20:09:04] marktraceur: I've made the commit there are a few little indentation problem and other things but tell me if this method work [20:09:45] works * [20:10:04] and take yout time don't hurry to review my commit [20:10:29] Words that I don't think have ever been spoken before about the MediaWiki commit review process... [20:10:44] 'kay [20:11:01] It works out because I have sooo many things to do today [20:12:14] (03CR) 10Bene: [C: 031] "Email sent to mailing list." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98174 (owner: 10Bene) [20:13:54] (03PS3) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/98120 [20:14:19] (03CR) 10Umherirrender: "Patch Set 3: Rebased" [core] - 10https://gerrit.wikimedia.org/r/98120 (owner: 10Umherirrender) [20:16:40] (03Merged) 10jenkins-bot: Simplify switch in BacklinkCache::getConditions [core] - 10https://gerrit.wikimedia.org/r/98361 (owner: 10Umherirrender) [20:27:27] vandrew_: I change the commit message on your commit, to make the first line shorter, and to have the bug number at the bottom (Generally the first line of the commit message should be roughly 65 letters, followed by a newline, followed by a more detailed description) [20:31:25] basile: thanks! [20:32:15] I mean bawolf [20:32:24] bawolff [20:39:08] hmm [20:39:31] what will php do when i do: $arr = array(); $arr['whatevs'][] = 'asdf';? [20:40:39] $arr['whatevs'][] shouldn't that whatevs be a int ? [20:40:42] (most importantly, do i get a warning?) [20:41:01] (03PS1) 10Umherirrender: Move closing parenthesis from multi line if and function to own line [core] - 10https://gerrit.wikimedia.org/r/98454 [20:41:10] vandrew_: heh, no, PHP arrays are magical things which can be indexed by both numbers and strings [20:41:34] unlike in any other language (which always have two types for two kinds of such things) [20:41:39] yeah, but that string shouldn't be a number ? [20:41:51] nope, it can be a string [20:42:07] a string like "apple" ? [20:43:03] no need to answer, got it [20:48:15] MatmaRex: no warning. $arr will be array( 'whatevs' => array( 'asdf') ); [20:49:10] no notices either? good [20:49:13] nope [20:49:14] well, for some definition of good [20:49:18] that's totally valid php [20:49:32] thats how $wgHooks works :) [20:49:42] hmmm [20:49:43] okay. [20:57:53] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This looks nice :) Comments inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [21:21:05] hello! I am new here, cause I found a bug on excerpt API of mediawiki and I see if can contribute in solving it! first time ever, not used in PHP, a python iniated, maybe somebody could help in achiving this task? [21:32:36] (03PS6) 10Jcf2000: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 [21:37:58] (03CR) 10Jcf2000: "PS4 adds more line spacing in mediawiki.special.createAccount.js" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [21:38:26] (03CR) 10Jcf2000: "Sorry, I meant PS6" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [21:38:55] hi gg4u [21:38:57] #wikimedia-lab [21:39:07] hi MatmaRex! [21:39:23] gg4u: i'd like to help, but i'm just leaving – have you seen https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker already? [21:39:44] I am reading it and set up the account, but I am a bit lost [21:40:06] (03CR) 10Hoo man: "What about https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce ?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98174 (owner: 10Bene) [21:40:35] for example, is it possibile to branch or test a bug on wikimedia lab ? or do I have to use git? [21:42:32] (03CR) 10MaxSem: [C: 032] "From looking at logs, this API is rarely, if ever, used." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98174 (owner: 10Bene) [21:42:38] (03Merged) 10jenkins-bot: Changing ApiQueryAllCampaigns api module prefix [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98174 (owner: 10Bene) [21:43:42] gg4u: i'm afraid i don't really understand the question, i have barely used labs [21:45:38] (03CR) 10Bartosz Dziewoński: "Well, that's entirely not what I meant :(" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [21:48:00] ok. so I am cloning mediawiki now, we'll see if I'll be able in getting my hands dirty. I simply would like to contribute in solving bug 57668 - https://bugzilla.wikimedia.org/show_bug.cgi?id=57668 [21:49:23] gg4u: note that the bug is mentioned as being in the MobileFrontend extension, not mediawiki core [21:49:24] !e MobileFrontend [21:49:24] https://www.mediawiki.org/wiki/Extension:MobileFrontend [21:49:34] ouch [21:50:56] so could you please shed light on the steps to do and the git to clone? do i have to clone mediawiki AND mobileFrontend extension or how else could I test? [21:57:53] yes, both of them [21:58:15] good night everyone. [22:07:10] (03PS2) 10Tholam: Site logo loaded using UserSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [22:10:07] (03CR) 10Jcf2000: "Bartosz Dziewoński: Could you please direct me on what needs to be changed? I'm ready to upload a new patch with some minor spacing change" [core] - 10https://gerrit.wikimedia.org/r/98357 (owner: 10Jcf2000) [22:10:49] (03PS3) 10Tholam: Site logo loaded using UserSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [22:12:59] (03PS4) 10Tholam: Site logo loaded using UserSiteModule instead of inline [core] - 10https://gerrit.wikimedia.org/r/98356 [22:24:42] (03PS1) 10Bartosz Dziewoński: update.php: Add a full stop [core] - 10https://gerrit.wikimedia.org/r/98459 [22:25:42] ok, so installed Mediawiki and mobileFrontend, running on my localmachine [22:26:52] guys, what should i do now to reproduce a bug? [22:27:12] Follow the instructions? [22:27:40] I do not want to install the full wikipedia database: I am trying to reproduce this https://bugzilla.wikimedia.org/show_bug.cgi?id=57668 [22:28:06] Just import that page and any dependants then? [22:28:09] @Reedy, I have many pages open and I am confused, this is the first time for me [22:28:27] (03PS7) 10Jcf2000: Additional styling for CAPTCHA on Special:UserLogin [core] - 10https://gerrit.wikimedia.org/r/98357 [22:29:02] how to import a page with all dependants ? [22:29:18] Special:Export [22:29:56] and Special:Import [22:30:15] which is the endpoint of the API on a localmachine? I tried http://localhost/mediawiki/api.php but got an error: Fatal error: Cannot access protected property RepoGroup::$reposInitialised in s/mediawiki/includes/api/ApiQueryFileRepoInfo.php on line 39 [22:30:32] I am gonna check this now, tks [22:42:48] guys, maybe I am missing something... there is no Special:Import on my local mediawiki software. Could anybody please help? [22:45:45] (03PS1) 10Tholam: Create ResourceLoaderLogoModule to load logo [core] - 10https://gerrit.wikimedia.org/r/98460 [22:55:12] (03PS1) 10Anomie: Don't localize Special:CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/98461 [23:11:40] (03CR) 10Kaldari: "@Umherirrender: Your comment does not make sense to me. You seem to be suggesting that we purposely render it incorrectly (with a

) in " [core] - 10https://gerrit.wikimedia.org/r/97914 (owner: 10Kaldari) [23:37:47] (03CR) 10TTO: "No obvious reason why Jenkins marked this as a failure?" [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [23:40:19] (03CR) 10Bartosz Dziewoński: "Meh, the post-merge check just randomly fails 50% of the time. I learned to ignore it." [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [23:50:54] (03CR) 10Werdna: [C: 031] "Looks okay, but I haven't tested it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98359 (owner: 10Amire80) [23:54:26] (03CR) 10Werdna: [C: 04-1] Better GENDER support in moderation.js (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98368 (owner: 10Amire80) [23:55:19] (03CR) 10Werdna: "This is resolved in a more robust way in my scroll-bug-fixing patch. I'm going to clear that up today so maybe we can just hold tight unti" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98245 (owner: 10Theopolisme) [23:56:40] (03CR) 10Werdna: [C: 032] "Cheers!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98293 (owner: 10Amire80) [23:57:15] (03CR) 10Werdna: [C: 032] Add English messages authors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98283 (owner: 10Amire80) [23:57:16] (03Merged) 10jenkins-bot: Creating images for RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98293 (owner: 10Amire80) [23:57:30] (03Merged) 10jenkins-bot: Add English messages authors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98283 (owner: 10Amire80) [23:59:56] (03CR) 10Werdna: [C: 04-1] Clicking 'comment' in history should take user to the comment (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 (owner: 10Bsitu)