[00:04:30] (03PS6) 10Bartosz Dziewoński: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 [00:05:34] ori-l: updated the patch ^. i'd love if you could recheck that, but i think it should be good enough [00:05:52] checking [00:05:54] (03CR) 10jenkins-bot: [V: 04-1] Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [00:05:57] heh [00:06:33] aw woot. [00:07:00] Undefined variable: ruleWithEmbedded [00:07:08] CSSMinTest::testRemap with data set #0 ('Simple case', array('foo { prop: url(bar.png); }', false, 'http://example.org', false), 'foo { prop: url(http://example.org/bar.png); }') Undefined variable: ruleWithEmbedded [00:07:38] aw, duh [00:08:54] praise gods for unit tests [00:08:59] brb [00:09:17] (03PS7) 10Bartosz Dziewoński: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 [00:09:49] for reals this time. [00:14:47] (03PS4) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 [00:28:21] MatmaRex: looks good so far [00:31:29] OK, I'm gonna take advantage of thanksgiving to potentially screw up the grrrit-wm config [00:31:36] Testing in production is awesome [00:32:42] that rush of adrenaline. [00:32:50] i'm off, good night [00:34:26] marktraceur: did I mention I hate US Holidays? [00:36:15] Not recently, no [00:36:20] YuviPanda: Why's that? [00:37:36] 'hate' is probably too strong a word [00:38:24] marktraceur: IRC is a ghost town except for a few people [00:41:00] Aw. [00:41:07] YuviPanda: Luckily I'm being a hermit [00:41:19] heh yeah :D [00:41:28] * YuviPanda perfects his little operations/puppet.git patch [00:41:35] Let's see if it works [00:42:03] Hrm [00:42:25] The defaults thing didn't work, I guess [00:42:44] Wonder if it still picks things up properly [00:42:49] I... just realized that -wm meant wikimedia [00:42:51] * YuviPanda facepalms [00:42:56] Hah. [00:43:03] Oh, good, crashes [00:44:41] (03CR) 10Ori.livneh: [C: 032] Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [00:47:06] Weird. [00:50:49] I'll screw with it more later, for now, I'm basically thinking it's not gonna work [00:56:59] YuviPanda: What did you think it meant before? [00:57:06] I never thought of it, really [01:15:18] (03PS1) 10TTO: Add page JavaScript variable wgIsContentPage [core] - 10https://gerrit.wikimedia.org/r/98143 [02:07:33] (03PS1) 10Hiong3-eng5: Duplicate Expression [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/98145 [03:25:12] would it be useful to create a tag that automatically kills any categories inside of it? if so, could it go in core or would it have to be an extension? [03:28:23] jackmcbarn: It would be an extension, but why do you need it? [03:28:49] so templates don't have to deal with 3 different ways that another template might need categorization disabled [03:29:30] jackmcbarn: Oh, so, transcluding a template without transcluding the categories in the template? Yeah, sure, almost certainly possible [03:30:05] if i did make that extension, what hoops would i need to jump through to get it added to wikimedia wikis? [03:31:33] jackmcbarn: It needs to go through multiple reviews, and you'd probably need to seek consensus from the community for enabling it [03:33:09] i remember seeing a page explaining all that, but i cant find it now [03:33:12] can you link to it? [03:34:11] Hm [03:34:13] * marktraceur finds it [03:34:56] https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment [03:35:13] thanks [03:42:42] why are and ok for core, but this would have to be an extension? [03:44:49] jackmcbarn: I think this is a nice idea, but not really necessary for most wikis [03:45:08] is probably similar. I wonder if it would be "sane" to split that into an extension. [03:45:29] I don't think is splittable, you need to be able to tell the parser to ignore things in one context or another. [03:47:17] I guess you *could* split it out, but it would be really annoying to write templates :P [03:47:53] And I don't think our style is to split more things out into extensions, but to try and keep things in core as much as possible, when they're useful. [03:48:02] Maybe a sane dependency management system will change that, I dunno. [04:13:17] (03CR) 10Parent5446: [C: 04-1] Fixed spacing (036 comments) [core] - 10https://gerrit.wikimedia.org/r/98120 (owner: 10Umherirrender) [04:24:20] !logs [04:24:20] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [04:34:46] (03PS1) 10Pastakhov: add variable CURRENTLOGGEDUSER [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/98146 [04:40:30] (03PS2) 10Pastakhov: add variable CURRENTLOGGEDUSER [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/98146 [04:55:26] (03CR) 10Pastakhov: [C: 032] add variable CURRENTLOGGEDUSER [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/98146 (owner: 10Pastakhov) [04:55:56] (03CR) 10Pastakhov: [V: 032] add variable CURRENTLOGGEDUSER [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/98146 (owner: 10Pastakhov) [05:12:18] (03PS1) 10Pastakhov: add variable CURRENTLOGGEDUSER [extensions/MyVariables] (REL1_22) - 10https://gerrit.wikimedia.org/r/98147 [05:12:52] (03CR) 10Pastakhov: [C: 032 V: 032] add variable CURRENTLOGGEDUSER [extensions/MyVariables] (REL1_22) - 10https://gerrit.wikimedia.org/r/98147 (owner: 10Pastakhov) [05:13:39] (03PS1) 10Theopolisme: Update and remove unnecessary messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 [05:15:44] (03PS1) 10Pastakhov: add variable CURRENTLOGGEDUSER [extensions/MyVariables] (REL1_20) - 10https://gerrit.wikimedia.org/r/98149 [05:16:11] (03CR) 10Pastakhov: [C: 032 V: 032] add variable CURRENTLOGGEDUSER [extensions/MyVariables] (REL1_20) - 10https://gerrit.wikimedia.org/r/98149 (owner: 10Pastakhov) [06:49:34] (03PS2) 10Hiong3-eng5: Duplicate Expression [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/98145 [07:34:50] (03CR) 10PleaseStand: [C: 04-1] "We don't need yet another page-specific config variable for this." [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [07:40:30] (03CR) 10TTO: "My concern was, though, that wgContentNamespaces is necessarily going to be larger than wgIsContentPage, thereby increasing the per-page p" [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [07:59:08] (03PS7) 10Wikinaut: make SpecialChangePassword form text depending on login status of wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [08:06:53] (03PS8) 10Wikinaut: make SpecialChangePassword form text depending on login status of wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [08:10:26] (03PS9) 10Wikinaut: make SpecialChangePassword form text depending on login status of wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [08:11:14] (03PS10) 10Wikinaut: make SpecialChangePassword form text depending on login status of $wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [08:35:24] (03PS1) 10Ebrahim: "أ" to "ا" as it is more usual on Arabic script variants [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/98153 [09:28:22] (03CR) 10TTO: "So, caching softens the impact. That's OK. I'll do it." [core] - 10https://gerrit.wikimedia.org/r/98143 (owner: 10TTO) [09:50:34] $minor = (int) $skin->msg( 'sitenotice_id' )->inContentLanguage()->text(); [09:50:34] lol [09:56:31] (03PS1) 10Reedy: Parameter type hints on SiteNoticeAfter hook subscriber [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/98154 [09:58:08] (03PS2) 10Reedy: Add a bit of output to makeSimpleList.php [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/96374 [10:00:52] (03PS3) 10Reedy: Minor updates to populateRevisionSha1.php to use newer available features [core] - 10https://gerrit.wikimedia.org/r/90431 [10:20:55] (03PS2) 10TTO: Add JavaScript variable wgContentNamespaces [core] - 10https://gerrit.wikimedia.org/r/98143 [10:27:38] (03PS1) 10Hashar: basic layout for labs [integration/zuul-config] (labs) - 10https://gerrit.wikimedia.org/r/98157 [10:27:46] (03CR) 10jenkins-bot: [V: 04-1] basic layout for labs [integration/zuul-config] (labs) - 10https://gerrit.wikimedia.org/r/98157 (owner: 10Hashar) [10:28:49] (03CR) 10Hashar: [C: 032 V: 032] basic layout for labs [integration/zuul-config] (labs) - 10https://gerrit.wikimedia.org/r/98157 (owner: 10Hashar) [10:41:11] :q [10:46:18] (03CR) 10Addshore: "It can still be CRed though :)" [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95655 (owner: 10Addshore) [11:08:39] Anyone know how to mark code in tasks as completed? *goes to read some stuff...* [11:09:00] addshore: {{done}} [11:09:37] really? O_o [11:13:55] (03CR) 10Rillke: "+1 for the idea behind this patch; did not test anything, yet" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [11:36:52] (03PS3) 10Zsaigol: Changed Special:GlobalUsers to inherit from AlphabeticPager [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 [11:41:18] (03CR) 10Zsaigol: "I think the context is the same, so the messages can be re-used from core." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [11:42:23] (03CR) 10Zsaigol: "I've now created a bug" [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [11:50:47] (03PS1) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [12:06:26] (03CR) 10Zfilipin: [C: 04-1] "Please fix whitespace." (033 comments) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [12:20:16] (03PS2) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [12:45:27] Anybody here can help me a little about how to run specific Mediawiki pages in the browser after I edit them? Iḿ mightily confused. [12:49:26] hi Niharika [12:49:31] which page? [12:51:29] YuviPanda: Hey! Glad to see you, seriously. [12:51:46] :D [12:51:59] Mediawiki works fine. And I got 2 extensions too. [12:52:07] Niharika: which extensions? [12:52:23] ULS and BetaFeatures. [12:52:37] Now, I want to create a new Wiki page and get the interlanguage links in it. [12:52:44] aah! [12:53:06] there should be docs on that somewhere [12:53:08] let me look [12:53:24] Okay! [12:53:29] * YuviPanda is now on a 256kbps connection, so gimme a bit [12:53:41] No problem. [12:56:21] Niharika: so [12:56:24] set https://www.mediawiki.org/wiki/Manual:$wgInterwikiMagic to true [12:56:29] and https://www.mediawiki.org/wiki/Manual:$wgHideInterlanguageLinks to false [12:56:38] in your vagrant/LocalSettings.php [12:57:04] (03PS3) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [12:57:08] Okay! [12:57:12] Niharika: and then on the bottom of your test page, put something like [[:en:India]] or something [12:57:16] and see if that works [12:57:58] YuviPanda: I have to create an account and then create the Wiki page, right? [12:58:17] Niharika: vagrant has a default account with name 'admin' and password 'vagrant' [12:58:19] so just use that [12:58:52] YuviPanda: I did that. But it says incorrect. It did allow me to login with name and password both ´vagrant´ though. [12:59:05] Niharika: in mediawiki? [12:59:44] Yep. I did vagrant ssh. Then it asked me for the password and username. [13:00:17] Niharika: no I mean, in localhost:8080 click 'login' [13:00:26] and try admin / vagrant? [13:00:46] you can create a new wiki page by going to something like localhost:8080/wiki/New_page and clicking create [13:01:29] I did that after creating an account. [13:01:36] That worked fine. [13:02:16] But the thing is, the backend html/js page isnt created anywhere. Itś not in the whole directory. [13:02:59] Niharika: what do you mean by 'backend html/js page'? [13:03:31] Niharika: are you looking for a New_page.html when you create localhost:8080/wiki/New_page? [13:03:40] Yes! [13:03:46] I shouldnt? [13:04:23] Niharika: ah, no ;) [13:04:28] Niharika: so when you create New_page [13:04:29] Forgive me if I sound dumb. I have little experience with servers. [13:04:37] it gets saved in the database [13:04:48] Okay. [13:04:59] and then when you go to localhost:8080/wiki/New_page, PHP queries the database for page contents of New_page and returns it to you [13:05:17] Okay. Makes sense, huge number of pages. [13:05:28] Niharika: pfft, the only dumb thing to do is to not ask questions when you don't know :) [13:05:40] Niharika: so the php code inside mediawiki/ is what is actually called [13:06:00] Niharika: let me find a link that'll help you understand the process of how you see the page when you go to localhost:8080/wiki/New_page [13:06:04] I think it'll be useful [13:06:49] Niharika: yeah, not just huge number of pages - but each edit to a page is also saved (try clicking 'view history' on any wikipedia page). So if each of those created a new file... [13:07:44] YuviPanda: Yeah, Iǘe seen that. Seems an obvious thing to store pages that way. Lots of redundant components in these pages. [13:08:12] Niharika: https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture [13:08:25] I highly suggest you read as much of it as possible, will clarify a lot of things [13:08:41] start at the top, and read at least till end of the section named 'Requests, caching and delivery' [13:08:54] Niharika: I'll be here for now, so poke me if you don't understand something. [13:09:21] Niharika: and don't worry about asking questions that see, 'silly' to you :) [13:09:41] Mediawiki is a large and complex piece of code, and takes a while to get used to [13:10:22] YuviPanda: Thanks! Iĺl get back to you after reading it. [13:10:33] Niharika: :) [13:14:04] (03CR) 10Netbrain: [C: 032 V: 032] Fix SideBarMenu unit tests [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95655 (owner: 10Addshore) [13:38:00] (03CR) 10Zfilipin: [C: 04-1] Added a test for downloading pdf from a random page (033 comments) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [13:52:37] YuviPanda: I am still not able to make the interlanguage links appear. I changed a couple of other variables and those changes show up, but interlanguage links doesnt. [13:52:45] YuviPanda: Ideas? [13:53:03] Niharika: did you add a [[:en:India]] to the page you just created? [13:53:23] No. [13:53:43] Niharika: try [[wikipedia:en:India]]? [13:54:08] Okay. [13:55:14] YuviPanda: That just adds the link? [13:55:20] hmm, weird [13:55:30] Niharika: let me investigate on my instance. gimme a moment [13:55:35] Sure. [14:06:35] Nikerabbit: around? [14:07:16] Niharika: still investigating, sorry! [14:07:50] YuviPanda: No problem at all. [14:17:00] Niharika: i think i got it to work! [14:17:08] Niharika: let me write up [14:19:21] Niharika: https://dpaste.de/tB1m [14:19:57] Niharika: this is assuming you already set $wgInterwikiMagic = true; and $wgHideInterLanguageLinks = false; in your LocalSettings.php [14:20:16] YuviPanda: Yep, those are there. [14:20:29] Niharika: I'm stepping out for food for a few minutes right now. You can email me (yuvipanda@gmail.com) and I'll respond immediately even when I'm out (for the next 30 mins or so) [14:20:31] brb [14:20:45] Niharika: do poke me if the instructions aren't clear or don't work! [14:20:46] brb [14:34:10] YuviPanda|away: Thanks a lot! They worked. :D [14:49:04] (03PS2) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/98120 [14:50:20] (03CR) 10Umherirrender: "Patch Set 2: Adressed comments" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/98120 (owner: 10Umherirrender) [14:55:31] (03PS4) 10Umherirrender: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/97544 [14:56:19] (03CR) 10Umherirrender: "Patch Set 4: Rebased on the top of I40ccda72c418c4a33fcd675773cb08d971510cdb" [core] - 10https://gerrit.wikimedia.org/r/97544 (owner: 10Umherirrender) [15:02:36] (03PS1) 10Umherirrender: Add missing version comment to SqliteUpdater [core] - 10https://gerrit.wikimedia.org/r/98170 [15:42:29] (03PS4) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [15:43:37] (03PS2) 10Theopolisme: Update and remove unnecessary messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 [15:43:55] (03CR) 10Theopolisme: Update and remove unnecessary messages (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98148 (owner: 10Theopolisme) [15:49:04] (03CR) 10Zfilipin: [C: 031] Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [15:50:59] Niharika|away: woohoo, sweet :) [16:00:15] YuviPanda: yes but internet sucks [16:00:29] Nikerabbit: 'tis fine, had a question about langlinks but resolved now [16:02:46] YuviPanda: Hey. Could you tell me what we did in those steps? I want to understand that. [16:02:57] Niharika: sure! moment [16:03:05] Okay. [16:04:29] Niharika: okay, so step 1 is adding 'en' as an 'interwiki prefix' [16:04:59] Niharika: so we are telling mediawiki that 'when a link starts with 'en:', it refers to a link that can be found at the URL http://en.wikipedia.org/wiki/$1 [16:05:05] Niharika: wehre $1 is the title after en: [16:05:14] YuviPanda: That means English is the default language? [16:05:32] Niharika: so mediawiki knows that when you link to [[en:India]], it refers to http://en.wikipedia.org/wiki/$1 [16:05:40] Niharika: means we only added for english. [16:05:55] Niharika: if you try [[hi:]] you will note that that doesn't work [16:06:02] since we only added for 'en' and not for 'hi' [16:06:18] Niharika: if you want more support for interwiki links, you can just repeat step 1 again and again with different values [16:06:24] YuviPanda: Okay! So if I want to add more languages, I keep adding them? [16:06:26] Okay! [16:06:29] instead of 'en' just use a 'language code' - hi for hindi, ta for tamil, etc [16:06:30] Niharika: yeah! [16:06:38] And clicking on those links will lead to...? [16:06:45] Niharika: the appropriate wikipedia [16:06:56] Niharika: or rather, the link you specify in the second parameter to the SQL insert [16:07:09] Niharika: if you click the 'English' link you have now, it will go to en.wikipedia.org/wiki/$1 [16:07:16] Niharika: since we specified that [16:07:19] does that make sense? [16:07:24] YuviPanda: Okay. Perfectly. [16:07:31] Thanks! [16:07:35] Niharika: so step 2! [16:07:46] Niharika: so the problem with having these in mysql is that we will need to query it every time [16:07:54] Niharika: so mediawiki uses a 'cache', in this case 'redis. [16:08:10] Niharika: Redis is a software that can store 'key value' pairs, and get them to you really fast [16:08:17] Niharika: think of it like a massive and fast hashtable [16:08:28] Niharika: so the interwiki data is cached in redis [16:08:32] by mediawiki [16:08:41] YuviPanda: Okay. I get that. I read about the Caching in that article. [16:08:44] Cool. [16:08:46] ah sweet ;) [16:08:51] Niharika: so when we modified the interwiki table by hand [16:08:54] Niharika: we had to clear the cache [16:09:04] Niharika: the 'flushdb' command deleted all the items from the redis cache [16:09:16] And it regenerates on its own? [16:09:33] Niharika: so every time mediawiki tries to access that table, it checks cache first [16:09:42] Niharika: if it isn't there, it takes it from the db, puts it in the cache and then uses it [16:09:51] Niharika: so the second time it tries toa ccess it, it's there in the cache and so no need to hit the db [16:10:09] Okay. Got it. [16:10:22] Mediawiki is HUGE. :O [16:10:36] :D [16:10:38] indeed [16:10:43] Curiously, clicking on English doesnt open http://en.wikipedia.org/wiki/$1 but opens the Main_Page. [16:11:06] Niharika: did you put it in the main page? [16:11:19] Nope. [16:11:32] It leads to this page: http://en.wikipedia.org/wiki/Main_Page [16:11:43] I put it on the test wiki page I made. [16:12:01] Niharika: can you pastebin the contents of the test page? [16:12:13] Sure. [16:13:18] YuviPanda: https://dpaste.de/azCK [16:13:42] Niharika: aah! [16:13:52] Niharika: so it should be [[en:India]] [16:13:55] Niharika: or some other page like that [16:14:06] Niharika: so mediawiki will redirect you to that particular page when you click the interlanguage link [16:14:19] Niharika: mediawiki doesn't know the equivalent page in every language, right? [16:14:31] Test page in english is probably going to be something completely different in another language [16:14:37] YuviPanda: Nope. But the $1 page? [16:14:44] Niharika: $1 is what is called a 'placeholder' [16:14:53] Niharika: it is replaced by the actual string you put there [16:15:08] Niharika: so if you put there [[en:India]], $1 will be replaced with the string 'India' [16:15:24] YuviPanda: But if nothing is specified, shouldn the $1 page be opened? [16:15:52] Niharika: if nothing is specified, $1 refers to the 'empty string' [16:16:02] Niharika: so $1 is '', so you get en.wikipedia.org/wiki/ [16:16:08] Niharika: which takes you to the main page [16:16:13] think of $1 as a variable [16:16:29] YuviPanda: Okay. Understood. [16:16:33] Thank you! [16:16:35] :D [16:16:48] Niharika: so you should probably insert entries for a bunch more languages there so you can play around [16:17:08] Yeah. On it. [16:17:15] Niharika: I also suggest you document the entire process (in a blog post? Or in a page in mediawiki.org) so other people can easily do this [16:18:10] Okay. I blog everyday, normally. Iĺl add everything, for sure. [16:18:44] Niharika: sure! do link to me when you post it too :) [16:19:02] YuviPanda: Definitely. [16:32:02] (03PS5) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [16:35:08] (03CR) 10Zfilipin: [C: 04-1] Added a test for downloading pdf from a random page (031 comment) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [16:36:33] (03CR) 10Zfilipin: Added a test for downloading pdf from a random page (031 comment) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [16:41:26] (03PS1) 10Bene: (bug 57128) Changing ApiQueryAllCampaigns api module prefix [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/98174 [16:44:11] (03PS1) 10Umherirrender: Store timestamp, user and reason for page protections in the db [core] - 10https://gerrit.wikimedia.org/r/98175 [16:47:15] (03CR) 10jenkins-bot: [V: 04-1] Store timestamp, user and reason for page protections in the db [core] - 10https://gerrit.wikimedia.org/r/98175 (owner: 10Umherirrender) [16:47:34] hi yuri [16:48:04] (03PS1) 10Aaron Schulz: Avoid calling oldFileFromRowFactory field directly [core] - 10https://gerrit.wikimedia.org/r/98176 [16:49:52] (03PS6) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [16:52:34] (03CR) 10Zfilipin: [C: 04-1] Added a test for downloading pdf from a random page (031 comment) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [16:54:42] marktraceur: regarding the task link = this.$useFile.data( 'link' ) || src, [16:55:07] should be link = this.$useFile.data( 'src' )|| src [17:16:51] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/98177 [17:16:56] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/98178 [17:17:05] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/98179 [17:17:52] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/98177 (owner: 10Pigpen) [17:18:08] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/98178 (owner: 10Pigpen) [17:18:22] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/98179 (owner: 10Pigpen) [17:27:50] vandrew_: I don't think so, no [17:28:08] vandrew_: "link" is the link to the file page, e.g. https://commons.wikimedia.org/wiki/File:Foobar.jpg [17:28:29] vandrew_: "src" is the URL for the image itself, e.g. https://upload.wikimedia.org/wikipedia/commons/3/3a/Foobar.jpg [17:28:40] marktraceur: this.$imageLinks [17:29:04] What about it? [17:29:08] this should contain the image link [17:29:20] not the source [17:29:41] I've initialed another variable with it and displayed it in place of link [17:31:41] (03PS7) 10Mayankmadan: Added a test for downloading pdf from a random page [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 [17:32:58] I think $imageLinks is something else [17:33:22] I think it's a mis-named variable for the list of image data that's on the right side of the lightbox view [17:34:36] marktraceur: one more thing, I see that windows.location.her is asigned to a variable [17:34:53] that will redirect the page to the page source [17:35:10] href* yes [17:35:26] then $link.prop( 'href' ) should return the link [17:35:26] What [17:36:02] I've lost you [17:36:10] window.location.her if a property [17:36:24] ...no [17:36:34] hmm [17:36:35] window.location.href [17:37:17] yes, herf, my mistake [17:37:53] (03CR) 10Zfilipin: [C: 04-1] Added a test for downloading pdf from a random page (035 comments) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/98160 (owner: 10Mayankmadan) [17:38:15] href, even. [17:38:18] Anyway [17:39:08] (03CR) 10Nikerabbit: Avoid calling oldFileFromRowFactory field directly (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98176 (owner: 10Aaron Schulz) [17:40:30] what does $link.prop( 'href' ) return ? and shouldn't also (this).attr("href") the link ? [17:40:50] return the link* [17:41:01] vandrew_: $link.prop( 'href' ) is basically the same as $link.attr( 'href' ) in this case [17:41:21] isn't that the page link then ? [17:42:37] It should be, yes [17:44:44] I'll push a amend comit soon then [17:44:45] thx [17:46:23] an amend* [17:58:43] marktraceur: This change was unable to be automatically merged with the current state of the repository. [17:58:56] marktraceur: what should I do ? [18:00:07] vandrew_: You need to rebase the change [18:00:17] vandrew_: git fetch --all && git rebase origin/master [18:00:32] thx [18:15:42] marktraceur: CONFLICT (content): Merge conflict in resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js [18:15:50] how do I reset everything [18:16:18] You need to resolve the conflict [18:16:27] Go into that file and look for <<<< [18:17:08] there are a few of weird <<<<< and ==== [18:17:12] why are they there ? [18:17:42] vandrew_: They're to tell you what the conflicts are [18:18:35] vandrew_: Between <<<<< and ===== are your changes, between ==== and >>>>> are the changes from origin/master [18:18:39] You need to consolidate them [18:19:25] (03PS5) 10Ori.livneh: More tests for CSSMin::remap [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [18:20:06] marktraceur: I'm working on the old changes it may be from that ? [18:20:28] marktraceur: the ones with where i have changed $this to &useFile [18:20:41] shouldn't [18:20:57] I reset to the default or something ? [18:21:12] Yeah [18:21:41] I'll delete the local folder and clone the git again [18:21:47] vandrew_: git rebase --abort && git checkout master && git reset --hard origin/master [18:21:54] ah, ok [18:23:26] (03CR) 10Ori.livneh: [C: 032] More tests for CSSMin::remap [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [18:23:35] (03PS8) 10Ori.livneh: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [18:26:34] (03Merged) 10jenkins-bot: More tests for CSSMin::remap [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [18:28:36] marktraceur: why does it say (change 98127 closed) [18:28:41] when I use review ? [18:28:56] is trying to post on another change [18:28:57] vandrew_: Because you're probably amending to an existing commit [18:29:06] What's in your git log? [18:29:22] Like, the summary of the first commit [18:29:41] Id44fea9008adb391817250c2897693f45bead717 pushed a bunch of stuff into the [18:29:44] subclass of LightboxInterface, but forgot to change the calls to "this" in [18:29:47] the dialog function to be sane. [18:30:02] Yeah, so, that's the fix you submitted, right? [18:30:06] yes [18:30:41] the fist one, now I'm trying to submit the other one [18:31:27] Did you commit your next change already? [18:31:44] yes, here https://gerrit.wikimedia.org/r/#/c/98180/ [18:31:55] but the bot reports that error [18:32:07] It looks like it's based on the wrong commit [18:32:11] Which is why I had you rebase [18:32:16] But then you backed out of the rebase [18:32:42] Or you could make the change again based on current master [18:33:40] so i should use git fetch --all && git rebase origin/master [18:33:51] first time I got that conflict errors [18:33:55] when using rebase [18:34:14] Yeah [18:34:18] That's the purpose of rebase [18:34:36] I'll use it again [18:35:00] (03CR) 10Bartosz Dziewoński: [C: 04-1] "So, I assume your code is a fork of Mathias's jquery.placeholder as of this commit: https://github.com/mathiasbynens/jquery-placeholder/bl" [core] - 10https://gerrit.wikimedia.org/r/98137 (owner: 10MegaAlex) [18:36:00] marktraceur: no error this time, what command should I use to add it to this https://gerrit.wikimedia.org/r/#/c/98180/ [18:36:13] as a new patch set [18:36:13] ... [18:36:20] vandrew_: You're still not doing it right I think [18:36:28] I think you rebased origin/master onto origin/master [18:36:29] the git review -R [18:36:31] So of course no errors [18:36:48] git review -d 98180 && git rebase origin/master [18:37:59] (03CR) 10Ori.livneh: [C: 032] Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [18:40:55] (03Merged) 10jenkins-bot: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [18:51:06] (03CR) 10Bartosz Dziewoński: "Several minor comments." (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/98137 (owner: 10MegaAlex) [18:57:58] marktraceur: done [18:58:50] vandrew_: Reviewed [18:59:11] marktraceur: where did it failed ? [19:00:10] marktraceur: no need to repert, saw the coments [19:01:23] vandrew_: There were a few mistakes, look at the inline comments [19:01:25]