[00:02:13] just me being confused by the configuration I had checked out on my laptop in mediawiki-config, I forgot that it was a year old since I was looking through the repo history a minute ago [00:08:02] (03PS2) 10Yurik: Added "git-update" command [vagrant] - 10https://gerrit.wikimedia.org/r/98033 [00:08:14] ori-l, what do you think ^ [00:09:32] yurik: looking [00:16:41] (03PS1) 10Aklapper: [4.4] Sync MoreBugUrl extension, add our custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 [00:22:56] yurik: I like that running it with '-h' informs you that you can run it with '-h' to see the help screen that you're already looking at :P [00:34:51] ori-l, i copied your other module :-P [00:34:59] i guess it should be fixed :) [00:35:09] well, actually if that's the only option, than it should be there [00:35:18] all utulities do that [00:36:50] yurik: it's fine, just slightly amusing. i like the patch, going to test it out a bit [00:36:53] thanks for submitting it! [01:13:04] (03PS1) 10Dr0ptp4kt: Add Opera Mini IPv6 addresses. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/98039 [01:19:38] (03PS10) 10JGonera: Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [01:21:46] (03CR) 10JGonera: [C: 031] Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [01:27:03] (03PS2) 10Dr0ptp4kt: Add Opera Mini IPv6 addresses. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/98039 [01:30:03] Have a great weekend (and Thanksgiving, if you celebrate it). [01:36:09] (03PS1) 10Tholam: Better instructions on top of enter_bug.cgi, link to guided form [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98041 [03:23:12] (03PS1) 10Spage: Set $server_url to something other than undef [vagrant] - 10https://gerrit.wikimedia.org/r/98060 [03:26:43] (03CR) 10Ori.livneh: "Thanks, S & Erik." (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/98060 (owner: 10Spage) [03:33:41] (03PS2) 10Ori.livneh: Set $server_url to something other than undef [vagrant] - 10https://gerrit.wikimedia.org/r/98060 (owner: 10Spage) [03:33:54] (03CR) 10Ori.livneh: [C: 032] Set $server_url to something other than undef [vagrant] - 10https://gerrit.wikimedia.org/r/98060 (owner: 10Spage) [03:47:46] Hello. I am running Mediawiki using Vagrant. Facing a Not Found 404 error when I navigate to localhost:8080. The VM is running. Any idea what could be causing the issue? [04:12:08] can i get help here with editing the vector skin? [04:20:07] (03CR) 10Tim Starling: [C: 032] Add Opera Mini IPv6 addresses. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/98039 (owner: 10Dr0ptp4kt) [04:20:09] (03Merged) 10jenkins-bot: Add Opera Mini IPv6 addresses. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/98039 (owner: 10Dr0ptp4kt) [04:23:06] (03CR) 10Chad: [C: 032] Declare visibility on class properties of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97373 (owner: 10Siebrand) [04:24:10] (03CR) 10Chad: [C: 032] Update documentation for gallery related files [core] - 10https://gerrit.wikimedia.org/r/97475 (owner: 10Siebrand) [04:24:45] (03CR) 10Chad: [C: 032] Declare visibility on class properties of ImageGalleryBase [core] - 10https://gerrit.wikimedia.org/r/97476 (owner: 10Siebrand) [04:26:56] (03Merged) 10jenkins-bot: Remove commented out code [core] - 10https://gerrit.wikimedia.org/r/97473 (owner: 10Siebrand) [04:26:57] (03Merged) 10jenkins-bot: Break long lines in gallery classes [core] - 10https://gerrit.wikimedia.org/r/97472 (owner: 10Siebrand) [04:26:58] (03Merged) 10jenkins-bot: Update formatting for gallery related files [core] - 10https://gerrit.wikimedia.org/r/97471 (owner: 10Siebrand) [04:26:59] (03Merged) 10jenkins-bot: Replace Linker::link() by linkKnown() [core] - 10https://gerrit.wikimedia.org/r/97474 (owner: 10Siebrand) [04:27:00] (03Merged) 10jenkins-bot: Declare visibility on class properties of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97373 (owner: 10Siebrand) [04:28:24] (03PS2) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 [04:28:41] (03Merged) 10jenkins-bot: Update documentation for gallery related files [core] - 10https://gerrit.wikimedia.org/r/97475 (owner: 10Siebrand) [04:29:51] (03CR) 10Chad: "I wouldn't be opposed to restoring this to the REL1_22 branch, with a very clear release-notes entry in master saying it's been removed wi" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:29:56] (03Merged) 10jenkins-bot: Declare visibility on class properties of ImageGalleryBase [core] - 10https://gerrit.wikimedia.org/r/97476 (owner: 10Siebrand) [04:30:44] (03CR) 10Chad: [C: 032] Hash long memcached keys and warn about it in the logs [core] - 10https://gerrit.wikimedia.org/r/94989 (owner: 10Aaron Schulz) [04:32:31] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 (owner: 1001tonythomas) [04:33:18] (03CR) 10Chad: [C: 04-1] "Actually, I not sure I like this now that I think about it again." [core] - 10https://gerrit.wikimedia.org/r/94989 (owner: 10Aaron Schulz) [04:47:30] (03PS1) 10Pastakhov: fix operator T_ELSEIF inside other operator T_IF [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/98063 [04:48:18] (03CR) 10Pastakhov: [C: 032] fix operator T_ELSEIF inside other operator T_IF [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/98063 (owner: 10Pastakhov) [04:48:27] (03Merged) 10jenkins-bot: fix operator T_ELSEIF inside other operator T_IF [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/98063 (owner: 10Pastakhov) [04:57:32] (03PS1) 10tosfos: initial code - allows anchor tags and parses them [extensions/AnchorHandler] - 10https://gerrit.wikimedia.org/r/98064 [04:58:49] (03CR) 10tosfos: [C: 032 V: 032] initial code - allows anchor tags and parses them [extensions/AnchorHandler] - 10https://gerrit.wikimedia.org/r/98064 (owner: 10tosfos) [05:44:54] (03PS1) 10Aaron Schulz: Converted html cache updates to use BacklinkJobUtils [core] - 10https://gerrit.wikimedia.org/r/98067 [05:47:46] (03PS3) 10Aaron Schulz: Fixes to RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/96801 [06:15:36] (03CR) 10Parent5446: [C: 032 V: 032] Fix ordering of scripts for Persona [extensions/Persona] - 10https://gerrit.wikimedia.org/r/97478 (owner: 10Parent5446) [06:22:29] (03PS1) 10Pastakhov: fix operator T_ELSEIF [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/98069 [06:23:43] (03CR) 10Pastakhov: [C: 032] fix operator T_ELSEIF [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/98069 (owner: 10Pastakhov) [06:23:49] (03Merged) 10jenkins-bot: fix operator T_ELSEIF [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/98069 (owner: 10Pastakhov) [06:45:05] (03PS1) 10Aaron Schulz: Avoid parsing more in refreshLinksJobs [core] - 10https://gerrit.wikimedia.org/r/98071 [09:04:48] (03CR) 10Nikerabbit: "FYI: PHP Fatal error: Cannot access protected property LocalRepo::$oldFileFromRowFactory in /www/translatewiki.net/w/includes/filerepo/fi" [core] - 10https://gerrit.wikimedia.org/r/97373 (owner: 10Siebrand) [09:41:11] (03CR) 10TTO: Make edit toolbar Signature button optional in content namespaces (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [09:49:46] anyone around who knows the parsoid stuff? [09:53:06] apergos: One does not simply know parsoid *runs* [09:53:23] well someone better because we have an issue [09:57:17] (03PS1) 10Nikerabbit: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 [10:02:32] (03CR) 10Siebrand: [C: 031] New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [10:03:29] (03PS1) 10Ori.livneh: Log event when new editors reach edit milestone [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/98079 [10:09:12] (12:08:11 μμ) apergos: need someone to look at this basically now [10:09:12] (12:08:41 μμ) apergos: Util.tokensToString, invalid token: undefined tokens: [ '', [10:09:12] (12:08:46 μμ) apergos: plus piles and piles of crud [10:09:24] ori-l: who do we know that knows parsoid? [10:09:26] like right now [10:10:32] hey siebrand, have you been able to take a look at the change i made to https://gerrit.wikimedia.org/r/#/c/97369/ that addresses your comments in ps4? [10:13:12] *sigh* [10:13:15] (03PS2) 10Nikerabbit: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 [10:14:29] (03PS1) 10Siebrand: Make $oldFileFromRowFactory public [core] - 10https://gerrit.wikimedia.org/r/98080 [10:18:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [10:18:26] dan-nl: Done [10:18:34] thanks [10:19:27] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [10:19:52] (03CR) 10Nikerabbit: [C: 032] "Merging this to unbreak master." [core] - 10https://gerrit.wikimedia.org/r/98080 (owner: 10Siebrand) [10:23:10] (03Merged) 10jenkins-bot: Make $oldFileFromRowFactory public [core] - 10https://gerrit.wikimedia.org/r/98080 (owner: 10Siebrand) [10:23:45] apergos: sorry, wasn't online [10:23:50] i know a little bit [10:24:20] so what i'd really like is to turn off logging to nohup.out [10:24:33] just turn it off and let folks deal with the exceptions later [10:24:45] what we have now is this log file fills up on a host, fills / [10:25:32] OK, looking [10:27:49] if there's a problem with , that's going hit a lot of templates and a lot of pages... [10:34:37] ./files/misc/parsoid: sudo -E -u parsoid nohup node /var/lib/parsoid/Parsoid/js/api/server.js > /var/lib/parsoid/nohup.out 2>&1 & [10:34:50] I guess it would be a manual change to that meh [11:03:09] (03PS9) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [11:38:07] (03PS3) 10TTO: Hide edit toolbar Signature button in content namespaces by default [core] - 10https://gerrit.wikimedia.org/r/87649 [11:39:11] (03CR) 10TTO: "I've never written a release note before; is that text appropriate?" [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [11:46:45] (03CR) 10Peachey88: Hide edit toolbar Signature button in content namespaces by default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [11:49:42] (03PS1) 10Nemo bis: Add mediawiki.org to default $wgNoFollowDomainExceptions [core] - 10https://gerrit.wikimedia.org/r/98089 [12:01:05] (03PS1) 10Jack Phoenix: Fix JS issue on Special:ViewRelationshipRequests. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/98090 [12:01:28] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix JS issue on Special:ViewRelationshipRequests. [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/98090 (owner: 10Jack Phoenix) [12:08:47] * Niharika waves to YuviPanda! [12:10:23] YuviPanda: I had a silly doubt, if you have a moment. [12:13:39] (03PS1) 10Netbrain: Added support for execution to be done on client side. This to prevent max execution time error in php. [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/98094 [12:37:14] marktraceur: how was the commit ? [12:40:17] cd [12:49:16] YuviPanda: You there? [12:53:11] (03CR) 10Nikerabbit: [C: 031] "Well duh I just recommended it out of habit. Usually those don't have ids so Html::hidden( 'key', $value ) reads nicely." [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97929 (owner: 10Jackmcbarn) [13:10:35] lazy bunny, not even +2 after demanding it [13:20:45] Niharika: hrey [13:20:49] Niharika: sorry was watching a movie. [13:20:51] 'sup? [13:24:56] heyheyhey [13:35:57] YuviPanda: Be back in a while! Sorry! [13:36:04] Niharika: sure 'tis ok [13:40:07] (03PS1) 10Netbrain: Custom version without the need for ParamProcessor [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/98096 [13:43:13] (03CR) 10Netbrain: [C: 032 V: 032] "Needs rebase though." [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95655 (owner: 10Addshore) [13:47:27] (03Abandoned) 10Netbrain: Custom version without the need for ParamProcessor [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/98096 (owner: 10Netbrain) [13:51:52] YuviPanda: Which movie? :P [13:52:22] I was stuck on how do I run specific files in the mediawiki folder. [13:52:52] Whatever path I enter, it turns up the This Page Does Not Exist thing. [14:35:42] (03PS3) 10Addshore: General Cleanup [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95650 [14:35:59] (03PS2) 10Addshore: Fix SideBarMenu unit tests [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95655 [14:36:14] netbrain: ^^ ;p [15:24:29] (03PS2) 10Aklapper: [4.4] Sync MoreBugUrl extension, add our custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 [15:48:18] (03PS3) 10Aklapper: [4.4] Sync MoreBugUrl extension, add our custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98035 [16:20:13] anyone here who can help me with multimedia viewer ? [16:31:40] (03PS2) 10Aklapper: [4.4] Sync index frontpage with upstream changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98013 [16:33:08] (03CR) 10Aklapper: [C: 04-1] "CSS loading changes now enable Dusk CSS by default. This is different from 4.2 and needs to be fixed." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98005 (owner: 10Aklapper) [16:39:26] (03CR) 10Aklapper: "Dusk is loaded as alternative CSS in 4.2 code: (03CR) 10Aaron Schulz: "Can the caller use newFileFromRow?" [core] - 10https://gerrit.wikimedia.org/r/98080 (owner: 10Siebrand) [16:47:20] (03PS2) 10Aklapper: [4.4] Upgrade two template files and reapply our custom changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98005 [17:20:49] (03CR) 10Parent5446: [C: 031] Add mediawiki.org to default $wgNoFollowDomainExceptions [core] - 10https://gerrit.wikimedia.org/r/98089 (owner: 10Nemo bis) [17:24:22] (03CR) 10Parent5446: [C: 04-1] "We should also do some sort of performance testing to see what the impact of this hook (with no subscribers) is." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [17:24:56] (03CR) 10Parent5446: New hook MessageCache::get [core] - 10https://gerrit.wikimedia.org/r/98078 (owner: 10Nikerabbit) [17:44:32] Hey, is there some standard process on how to get people look at bugs and/or patches? [17:45:47] You just ask them on IRC or something, poke` [17:47:38] Well I don't really know who to address; it's just that I reported a bug (#57201) which then got prioritized as "high", and also supplied a patch for it... [17:49:34] You can add people you want to review your patch [17:49:42] Are you part of GCI [17:50:34] GCI? No idea what that is, and as I said, I don't really know who to address or who would be reponsible for certain parts and as such responsible.. [17:52:32] Okay, well I guess just ask MatmaRex [17:52:42] Or wait for someone to get around to it normally [17:53:20] It's been over a week by now, hence me asking ^^ [17:53:51] !b 57201 [17:53:51] https://bugzilla.wikimedia.org/57201 [17:55:06] It looks like there are already three reviewers on your patch [17:56:16] All you really need is someone with merge privileges to look at it [17:56:20] I can take a quick look at it in between cooking things [17:56:35] Not sure I'll be able to merge, but maybe. :) [17:56:57] Yeah, Parent5446 commented on it shortly after I pushed it but hasn't replied on my follow-up question since. And the other two didn't say anything yet ^^ [17:57:38] marktraceur: Thanks! And I don't think it's ready for merging right now (given Parent's clarification request), but I certainly would like some input so I can push an improved patch [17:58:33] poke`: It's common for people to run through a commit multiple times, but I'll do what I can [17:59:36] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/97350 (owner: 10Siebrand) [18:00:27] Personally I know nothing about PHP [18:00:31] Yeah, I don't mind working on improving it at all, I'd just like to see some momentum, before I forget what it was actually about ;) [18:00:37] So I can't really comment [18:03:43] marktraceur: should I make another review with the new changes ? [18:03:50] marktraceur: I see that you've added some comments [18:06:13] vandrew: Not sure what you mean - have you fixed comments in the patch, and want to submit a new version? Or have you fixed a different bug, and want to submit an entirely new change? [18:06:44] marktraceur: yes I've fixed the comments in the patch [18:08:44] marktraceur: actually the problems you reported in the patch comments [18:09:12] vandrew: OK, then you should do "git commit -a --amend", which will modify the initial commit, and then do "git review -R", which will push the new version of the change up [18:15:08] (03PS3) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 [18:15:44] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 (owner: 1001tonythomas) [18:23:56] missing Change-Id in commit message footer) [18:24:05] again .. [18:25:26] done [18:27:45] vandrew: The commit summary suggests to me that you've done something funky [18:28:19] It might have been an accidental merge commit [18:28:22] Or something [18:28:46] (03PS4) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 [18:31:40] marktraceur: I've used the commands you said and worked on the bug/57678 branch [18:31:48] marktraceur: how bad is it ? [18:32:57] (03Abandoned) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 (owner: 1001tonythomas) [18:48:08] Hm [18:48:19] vandrew: Not so bad, you submitted a commit with other changes [18:48:49] vandrew: Check out the old version with the command in the "Patch Set 1" section and check out a new branch, we'll try again :) [18:49:05] Once you have it, run "git log" to make sure your commit is on top [18:49:10] THen make your changes [18:49:28] Then you run git commit -a --amend && git review -R [18:49:44] The extraneous changes tell me that you had something else in your git history [18:50:03] yes, I'm working on another bug [18:50:06] but on another branch [18:50:55] oh my, i just looked at Parser#replaceInternalLinks2 [18:51:13] that's a lot of profanity in comments. [18:51:35] and a staggering number of references to bugs [18:52:06] Oh wait [18:52:11] vandrew: This is a totally new commit? [18:52:23] MatmaRex: Welcome to parser hacking! [18:52:28] marktraceur: git checkout HEAD^ bug/57678 should [18:52:36] marktraceur: no [18:52:39] No [18:52:52] marktraceur: this is the commit for the things you've reported in the comments [18:52:58] Oh wait [18:53:04] vandrew: I see what's happening now [18:53:19] vandrew: We don't do multiple commits to address issues, we amend existing commits [18:53:37] aw crap, Title is stupid [18:53:39] I've used git commit -a -ammend [18:53:48] i was trying to hunt down why [[#|stuff]] links to main page [18:53:52] vandrew: But what branch were you on? [18:54:00] And what was the parent commit? [18:54:05] turns out empty 'fragment' and no 'fragment' is considered the same things [18:54:11] the same thing* [18:55:15] marktraceur: I'm on the branch bug/57678 and the parrent is Merge "Previous and next functionality!" [18:55:18] I think [18:55:22] this is the commit before this one [18:55:43] Hm [18:56:33] vandrew: So git review -d 98020 [18:56:39] Then make your changes [18:56:42] Then git commit -a --amend [18:56:47] Then git review -R [18:56:57] marktraceur: right away [18:57:02] (sorry I got confused about where you were in the repo, but now it should work!) [18:57:41] you don't have to excuse, I haven't use gerrit before, you are a huge help for me [19:01:48] marktraceur: one question [19:01:54] marktraceur: https://gerrit.wikimedia.org/r/#/c/98020/2/resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js here [19:02:28] marktraceur: shouldn't be there a ; after the return false; } ? [19:04:03] (03PS1) 10Bartosz Dziewoński: Add parser test for empty self-link with empty fragment [[#|...]] [core] - 10https://gerrit.wikimedia.org/r/98119 [19:04:35] there's some much code that does the parsing, i don't even know who to blame for that. ^ [19:04:48] vandrew: Yes absolutely [19:05:02] MatmaRex: Probably RoanKattouw_away [19:05:16] Mostly just because he's fun to blame for things [19:05:27] (03PS2) 10Bartosz Dziewoński: Add parser test for empty self-link with empty fragment [[#|...]] [core] - 10https://gerrit.wikimedia.org/r/98119 [19:08:22] MatmaRex: some of the "default" tests from github.com/mathiasbynens/jquery-placeholder fail.What should I do about that? :) [19:08:38] marktraceur: I've made the amend commit [19:09:13] MegaAlex: hmm. some people add failing tests first, meaning to add features / fix bugs to make the work later [19:09:38] MegaAlex: you can probably ignore them, or add them to our version commented-out [19:09:50] thanks for working on this :) [19:10:13] ok, I will do that, thanks :) [19:11:43] (03CR) 10jenkins-bot: [V: 04-1] Add parser test for empty self-link with empty fragment [[#|...]] [core] - 10https://gerrit.wikimedia.org/r/98119 (owner: 10Bartosz Dziewoński) [19:11:54] woot. [19:12:26] graaah. [19:14:57] (03PS3) 10Bartosz Dziewoński: Add parser test for empty self-link with empty fragment [[#|...]] [core] - 10https://gerrit.wikimedia.org/r/98119 [19:19:55] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/98120 [19:28:36] robla: around? [19:32:45] vandrew: I see it, I'll review it in due time :) you can work on the next one if you like [19:33:01] Base it on that commit, just make sure to commit a new change, don't amend this time [19:35:01] marktraceur: take your time [19:36:04] (03PS1) 10Umherirrender: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/98123 [19:52:48] (03CR) 10Umherirrender: "Amend of Ibbd693719d03569a4d9c5cf0b61079edd4bc40ff failed. Will retry." [core] - 10https://gerrit.wikimedia.org/r/98123 (owner: 10Umherirrender) [19:52:54] (03Abandoned) 10Umherirrender: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/98123 (owner: 10Umherirrender) [19:57:44] (03PS3) 10Umherirrender: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/97544 [20:28:57] marktraceur: I would like to know what do you think about my idea regarding the task I have [20:29:00] The problem should come from the src or link variable because it may be [20:29:02] assigned to something like this "images/logo.png". This means the image wil be [20:29:21] loaded via http or https depending on the URL used in the browser. [20:30:33] so, this is why the link is protocol relative [20:30:37] vandrew: Sort of [20:30:52] vandrew: The issue is, we set it to "https://example.com/wiki/File:Blah" now [20:31:05] vandrew: We should be setting it to "//example.com/wiki/File:Blah" [20:31:12] That's what protocol-relative means [20:31:30] images/logo.png is a relative URL too, but not protocol-relative, path-relative [20:31:52] yes, but in my task they want both https [20:32:30] shouldn't that be the reverse [20:32:31] ? [20:32:47] here is my task https://www.google-melange.com/gci/task/view/google/gci2013/5868509229744128 [20:32:51] vandrew: No, we don't want to force HTTPS I think [20:33:26] marktraceur: it says: " [20:33:26] Given that we want to encourage safe browsing of Wikimedia sites, I would go [20:33:29] with https for both. [20:33:30] " [20:33:41] Oh, hm [20:34:31] we should probably use the canonical protocol [20:34:37] no idea what is it on en.wp [20:34:39] probably http [20:34:43] I dunno [20:34:46] I thought relative was good [20:34:48] (actually, i said that in https://bugzilla.wikimedia.org/show_bug.cgi?id=56787#c6 ) [20:34:55] Because then on third party sites we wouldn't cause issues [20:34:57] marktraceur: i think we're discussing copyable links, no? [20:35:03] Yeah, MatmaRex, we are [20:35:15] I don't know what siteinfo offers by way of "You can use HTTPS here" [20:35:31] well, proto-relative links are not autolinked by anything, so they're not very useful in this case [20:35:39] anything i'm aware of* [20:36:03] MatmaRex: We put it into an element and an element [20:36:08] So it's set up fine [20:36:18] okay, wait [20:36:25] i am now patently confused [20:36:41] so am I, hah [20:37:08] Wait [20:37:12] Damn it I think we all are [20:37:14] OK [20:37:30] NOW I'm thinking we should use $wgServer [20:37:48] we should never use wgServer, unless you mean indirectly via wfExpandUrl. :) [20:37:55] Well [20:38:04] On the client side we don't have wfExpandUrl, I think [20:38:14] also, wgServer on WMF wikis was proto-relative last time i checked [20:38:19] what are we talking about, again [20:38:20] wait [20:38:24] * MatmaRex screenshots [20:38:50] marktraceur: I believe I saw that function in the code, let me check [20:39:13] are we talking about the parts circled in red here? http://i.imgur.com/36COcsd.png [20:39:49] MatmaRex: Yea [20:39:51] yes [20:39:52] the last one [20:39:58] (the href is actually just relative here, heh. lol) [20:40:41] marktraceur: aww, why do these texts select themselves on click, and not on focus? :( [20:40:57] and on keypress, too, apparnetly [20:41:09] i can't look at the end without copying somewhere else [20:41:12] * MatmaRex submits a patch [20:41:13] MatmaRex: I fucked around with different solutions for about an hour but couldn't find anything [20:41:31] .on('focus', function(){this.select()}) [20:41:33] or something [20:42:22] how's that repo called? [20:42:34] marktraceur: there is no wfExpandUrl [20:42:47] on the client side [20:45:00] MatmaRex: mediawiki/extensions/MultimediaViewer [20:47:32] marktraceur: thanks, got it [20:47:44] oh look, it appears like i get to remove some code. :D [20:49:14] marktraceur: hmmm [20:49:30] marktraceur: in selectAllOnEvent(), you check if ( $this.is( 'label' ) ), but that function is only bound to inputs [20:49:34] s * [20:49:49] is that intentional / still needed / was enountered in the wild, or can i remove that? [20:52:34] (03CR) 10Netbrain: "It still depends on https://gerrit.wikimedia.org/r/#/c/95650/3" [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95655 (owner: 10Addshore) [20:54:04] Random question: It's okay to randomly review random code reviews and +1/comment on them right? (lots of randoms here) [20:57:37] poke`: perfectly okay, there's no such thing as too many reviews [20:57:51] (it's in fact very much okay to -1 them as well) [20:58:19] the problem is patches that sit for weeks or months with nobody so much as leaving a single word of comment on them :) [20:58:27] Good, just want to make sure that it won't be weird to comment on a lot stuff :D [20:59:11] marktraceur: https://gerrit.wikimedia.org/r/98127 and https://gerrit.wikimedia.org/r/98128 (the second one will likely merge-conflict with vandrew's work) [20:59:21] (also, untested) [21:02:47] MatmaRex: so I shoould do that change to my work yep ? [21:03:22] vandrew: no, don't be bothered about that right now :) [21:03:49] (and definitely do not apply that patch on your work, as that's bound to cause problems :) ) [21:05:13] MatmaRex: I went through several iterations, some that listened to both label and inputs [21:05:44] marktraceur: okay. i killed that anyway, see links above. just bind 'focus' on inputs :) [21:10:17] Yay MatmaRex patches in things I actually maintain [21:10:28] It's like Christmas in basically December [21:10:52] heh [21:11:01] oh also, marktraceur, i've been meaning to ask you [21:11:07] why is the close button on the wrong side ;_; [21:11:32] MatmaRex: 1. It's not if you use it on mw.org 2. I blame designers for everything [21:12:01] My rough answer is "violetto uses a Mac and doesn't know better" [21:12:22] heh, okay [21:12:39] But she's not here for me to troll her [21:12:40] Sadly [21:13:02] oh huh, i like the mw.org one. [21:13:15] didn't know it was redone (already :>) [21:13:26] Yarp! [21:13:37] Where do I need to look at? [21:13:41] We've had to explain this multiple times to people complaining about various things [21:14:08] poke`: sorry? [21:14:32] With all your talking, you made me interested; so what is this about, and where is it on mw.org? ^^ [21:14:52] every thumbail I believe [21:15:29] poke`: MultimediaViewer, a beta feature [21:15:36] !e MultimediaViewer [21:15:37] https://www.mediawiki.org/wiki/Extension:MultimediaViewer [21:15:38] poke`: You'll need to enable it in your preferences [21:15:39] !e BetaFeatures [21:15:39] https://www.mediawiki.org/wiki/Extension:BetaFeatures [21:15:53] !e [21:15:53] https://www.mediawiki.org/wiki/Extension:$wiki_encoded_* [21:15:53] huh, i can spawn mutiple "use this file" dialogs. lols [21:20:23] Interesting, although I'm not a fan of full screen light boxes, but interesting :) [21:20:37] There's a bug with the close button not appearing, are you aware of that? [21:21:05] MatmaRex: That's another GCI task, someone's claimed it [21:21:50] MatmaRex: Have you tested the select patches you wrote? I remember being vaguely unsatisfied about basically every solution I tried [21:22:21] marktraceur: lol no [21:22:38] but i am 100% positive that this works on all browsers since Netscape 3 [21:22:41] or 4 [21:22:47] whichever first has javascript :P [21:22:51] had* [21:23:24] netscape [21:23:31] Well, we'll see [21:23:49] MatmaRex: Did you just totally trample all over the poor GCI student working on that bug [21:23:52] How terrible [21:23:55] aw [21:24:26] didn't mean to :P [21:24:28] Heh, thanks [21:24:57] I'll test your select patch now [21:25:16] Oh, right, it should be rebased on top of the other patch that I should merge [21:25:54] "We strive for excellence around here" heh. [21:25:56] :D [21:26:15] we are pupils actually [21:26:27] vandrew: Hm? [21:26:39] Oh, so you're all here because of Google? :o [21:26:48] Uh [21:26:55] poke`: Some people are [21:26:56] marktraceur: here in my country, a student is someone who is at university [21:27:16] Ahhh [21:27:24] MatmaRex, what have you done?! [21:27:33] what did i do this time? D: [21:27:39] HectorAE: Been a bastard LIKE USUAL [21:27:40] What mark said [21:27:53] ;_; [21:27:56] Ah this is the best way to spend Thanksgiving [21:28:00] indeed, MatmaRex spoils everything! [21:28:04] You totally swept a task out from under a GCI student [21:28:11] * marktraceur kids, is super happy that MatmaRex is being productive :) [21:28:13] marktraceur: replacing perl scripts with python scripts is the better way :D [21:28:15] * YuviPanda does that [21:28:21] HectorAE: i was too late, there already was a patch, so i abandoned mine :P [21:28:51] i should probably create a bunch of GCI tasks of my own [21:28:57] Wait wait wait [21:29:54] YuviPanda: wikibugs? [21:30:05] marktraceur: nope, toollabs [21:30:23] AWww. [21:30:27] YuviPanda: awwwwwwww. [21:30:35] (03PS3) 10Aklapper: [4.4] Upgrade two template files and reapply our custom changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98005 [21:30:40] marktraceur: not touching wikibugs anytime soon :D [21:30:47] * YuviPanda actually has wikibugs hidden on #mediawiki [21:31:01] Damn it [21:31:29] YuviPanda: I guess I'll do that soon and have my bug/patch mail sorter replace it [21:31:37] You know, whenever I finish that [21:31:40] heh yeah [21:32:18] * marktraceur chuckles at bugs in his code [21:32:43] MatmaRex: Opening the use-file dialog closes the lightbox UI, but then trying to use left/right arrow keys in the input loads the next image in the lightbox again [21:32:59] So we should probably file muuuultiple bugs for what's happening there [21:33:05] Because the use-fil dialog got very broken [21:38:59] (03PS1) 10Yurik: Renamed all -roles to roles- [vagrant] - 10https://gerrit.wikimedia.org/r/98131 [21:39:38] what does || when we have something like this: a= b||c [21:39:48]