[00:00:21] (03PS4) 10BryanDavis: sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [00:00:23] legoktm: Remind me to invite you to brunch at some point, I have an evil vegetarian plot that would be good to have multiple supporters for. Plus I owe you for traversing the Echo nastiness. [00:00:25] oh oops. that's what I meant to say yeah [00:00:43] heh, alright :) [00:01:55] (03CR) 10CSteipp: [C: 031] external-entity [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97521 (owner: 10Dan-nl) [00:02:36] Basically https://en.wikibooks.org/wiki/Cookbook:Wakeup_Sausage_Casserole with vegetarian imitation sausage [00:02:51] ProfileSection is cool. I guess I didn't realize RAII worked in PHP. [00:04:19] (03CR) 10BryanDavis: [C: 032] external-entity [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97521 (owner: 10Dan-nl) [00:06:04] that sounds exciting [00:06:30] (03CR) 10BryanDavis: [C: 032] max-file-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97465 (owner: 10Dan-nl) [00:06:39] Totally [00:06:46] I have to get the bloody mix right, too [00:07:08] (03PS8) 10Aaron Schulz: Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 [00:07:22] I keep revising it, but I think I've finally figured out that there aren't enough eggs in the wikibooks recipe [00:11:00] (03CR) 10GWicke: [C: 032] Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [00:14:12] (03Merged) 10jenkins-bot: Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [00:14:38] (03CR) 10CSteipp: [C: 031] sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [00:17:13] (03PS2) 10Mattflaschen: New API for selecting a task; related refactoring and minor fm [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 [00:19:28] gwicke: ok, time to convert HTMLCacheUpdateJob [00:22:10] Aaron|home: I'm still not 100% convinced that we need lazy expansion [00:22:35] IIRC the memory used by the jobs is fairly low right now [00:23:28] if early expansion would give us better dedup then that might be worth it (and save some memory too if done early) [00:23:31] gwicke: well we have isJobQueueDeprioritized throttling refreshLinks job expansion a lot right now [00:24:04] otherwise there would be millions of jobs like before [00:24:16] ah, I see [00:24:27] thought that refreshLinks was so much more efficient these days ;) [00:24:28] so we are not even doing eager expansion there right now [00:25:01] (03CR) 10CSteipp: [C: 031] "I haven't tested it, but this looks sane and useful" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 (owner: 10Legoktm) [00:25:12] I think I'll mess around with using some tricks to avoid parsing though [00:25:17] * Aaron|home hasn't looked at that in a while [00:26:31] Aaron|home: what would the memory use be like with full expansion? [00:27:02] gwicke: the reason I only change isJobQueueDeprioritized in that patch instead of removing it is that I was afraid what full eager expansion would do when there are tens of thousands of refreshLinks2 jobs [00:27:06] *changed [00:28:23] it's hard to say how big that would expand too, one could need to guess the backlinks for all the base jobs in there (though that wouldn't count range jobs) [00:29:50] anyway, HTMLCacheUpdateJob doesn't really de-duplicate now since the jobs are batched anyway [00:29:54] Aaron|home: from looking at the Job class I remember each job probably serializing to a few strings [00:30:14] so it might not be that bad really [00:30:23] not much longer than a URL [00:33:03] (03PS2) 10Werdna: Using his and her instead of their [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97829 (owner: 10Amire80) [00:35:16] (03CR) 10Werdna: [C: 031] "I added neuter support as well." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97829 (owner: 10Amire80) [00:37:21] (03CR) 10Werdna: [C: 032] Logical order of "from" and "to" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97786 (owner: 10Amire80) [00:37:30] (03Merged) 10jenkins-bot: Logical order of "from" and "to" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97786 (owner: 10Amire80) [00:40:27] (03PS1) 10Bsitu: Flow should be configurable to use a cluster database [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97868 [00:42:29] (03CR) 10BryanDavis: [C: 032] sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [00:43:32] (03CR) 10MarkTraceur: [C: 04-1] "Unrecognized parameter: 'count'" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 (owner: 10Legoktm) [00:43:46] marktraceur: you have to use 'bfcount' [00:43:51] oh [00:43:53] need to fix that [00:43:58] legoktm: I can't be blamed for this [00:44:36] (03PS3) 10Legoktm: API module: list=betafeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 [00:44:36] :P [00:44:38] fixed [00:46:04] (03PS2) 10Werdna: Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [00:46:06] (03CR) 10jenkins-bot: [V: 04-1] Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [00:46:28] No it's not [00:46:43] legoktm: bfcounts [00:46:46] Plural [00:46:53] ugh [00:46:59] boyfriend count? [00:47:01] * Aaron|home runs [00:47:04] ug[tab] [00:47:31] (03PS4) 10Legoktm: API module: list=betafeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 [00:47:44] Aaron|home: Just a convenience thing, help ward off stalkers, you know [00:47:58] We're also adding "It's complicated" [00:48:43] marktraceur: Aaron|home IS ON TO US [00:48:44] err [00:48:45] I mean [00:48:51] * yuvipanda phamplets self, goes away [00:48:52] (03CR) 10MarkTraceur: [C: 032] "Thanks, Lego!" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 (owner: 10Legoktm) [00:48:57] (03Merged) 10jenkins-bot: API module: list=betafeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 (owner: 10Legoktm) [00:48:58] woo :D [00:49:36] yuvipanda: Come on man [00:50:34] (03PS3) 10Werdna: Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [00:50:40] heh [00:51:39] (03CR) 10Werdna: [C: 031] "* PS2: Added back-compatibility for existing flow_revision rows." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [00:52:13] Aaron|home: If the MW API were more RESTful we could just return 404 from User:Whoever/bfcounts for "it's complicated" [00:57:51] (03CR) 10Werdna: [C: 032] "Still seems like a good idea sober." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 (owner: 10Matthias Mullie) [00:58:20] (03PS7) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [00:59:11] (03PS2) 10CSteipp: Add OAuth identify method [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 [00:59:34] (03CR) 10CSteipp: "PS2: Manual rebase" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 (owner: 10CSteipp) [01:00:10] (03Merged) 10jenkins-bot: Add setChildren() & setDepth() in loadTopicTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 (owner: 10Matthias Mullie) [01:02:04] (03PS3) 10CSteipp: Add OAuth identify method [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 [01:03:15] (03CR) 10CSteipp: "PS3: Remove the trailing whitespace from the JWT library, and remove the debugging statements I left in." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 (owner: 10CSteipp) [01:06:50] (03PS8) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [01:13:10] (03PS7) 10Werdna: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 [01:15:42] (03CR) 10Aude: [C: 031] "tested this in the default and enhanced formats and don't see any problems." [core] - 10https://gerrit.wikimedia.org/r/97853 (owner: 10Bartosz Dziewoński) [01:19:29] (03CR) 10Werdna: "PS7 is a rebase. Matthias has given it a +1 with some of his own changes. I'm going to do a thorough review and get this moved ahead." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [01:28:24] (03PS1) 10Bsitu: Weird timestamp display in both topic and board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97873 [01:36:12] (03PS1) 10Dr0ptp4kt: Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 [01:42:17] (03PS2) 10Dr0ptp4kt: Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 [01:43:13] (03PS3) 10Legoktm: Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 (owner: 10Dr0ptp4kt) [01:57:33] (03PS8) 10Werdna: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 [02:02:59] (03CR) 10Werdna: "PS7 addresses a lot of timestamp-related stuff. It's a rewrite of timestamp.html.php in pure PHP, because the HTML/PHP was just confusing." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [02:03:32] (03CR) 10Werdna: "And by PS7 I mean PS8. That's a lot of playstations." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [02:18:39] (03CR) 10Tim Starling: [C: 04-1] Updates for Opera Mini. (032 comments) [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 (owner: 10Dr0ptp4kt) [02:42:10] (03CR) 10Mattflaschen: "That was just a fix to avoid blowing up on a bad ID returned from Redis." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [03:10:19] hey bd808, thanks for those gerrit merges earlier today. [03:20:51] dan-nl: You're welcome [03:22:05] I was mostly just +2'ing after Chris and Gergo had done the hard part and given you good feedback and +1s [03:22:12] bd808, i'm looking at csteipp’s comment on https://gerrit.wikimedia.org/r/#/c/97369/, but don’t quite understand it yet. do you happen to know what he’s looking for? if not, no worries, i’ll ask him tomorrow. [03:25:35] dan-nl: I *think* he's talking about removing the indirection of FormHandler::getFormClass [03:26:14] k, i'll ask for more specifics tomorrow [03:27:05] That sounds like a good plan. Is that the last patch? [03:31:04] bd808: yes, in that series it is, it's the one holding up the others [03:32:35] csteipp mentioned that he has a few other issues to address, but that will probably come after this form-handler patch has been resolved. [03:33:05] fabrice mentioned that you had a few other concerns, but he wasn't specific. [03:34:11] I think my concerns are mostly timeline based. I'm not holding back any architecture problems from you. [03:34:28] ah, ok [03:35:09] once we resolve any other issues chris has, as far as i understand it, we should then be able to deploy to beta. correct? [03:35:32] dan-nl: Yes. That should be the case [03:35:46] what haste happen on beta before deploy to production? [03:35:59] *has to [03:36:31] dan-nl: Some amount of testing; I don't know if there is specific criteria. [03:37:09] Part of the beta step is just "being there" for a week [03:37:56] That give a chance for testers and others to notice problems that come from being integrated with the rest of the extensions [03:37:58] if we can get the extension onto commons by dec 6, that would leave a week for testing … that seems like it could work for deploy on the 17th, no? [03:38:12] i mean get it on beta by the 6th [03:38:33] That seems possible. [03:39:28] k, then it seems it will depend on csteipp’s schedule and my ability to turn around updates based on his reviews [03:39:40] do you know if there were any other concerns? [03:40:48] Not that I've heard of. Aaron closed his review ticket as I recall and I haven't heard Gergo say anything outside of review feedback. [03:41:34] I voiced concern with Fabrice about timeline because of what I've seen of Chris' schedule [03:42:21] He's got to move on to reviewing a couple of other projects soon that are both trying to launch by the end of the year as well. [03:42:51] But it looks like you are moving pretty fast now in his queue [03:43:48] okay, that's clear then. fabrice mentioned more issues with code, but i found that confusing because aaron had closed the architecture ticket, chris’ list of issues was very clear and i didn’t see anything else [03:45:14] hopefully i can sort out anything else chris sees and we can deploy onto beta then by dec 6 [03:45:38] dan-nl: I'm excited to see it happen. [03:45:47] :) [03:46:03] thanks for your time [03:58:27] legoktm: https://dpaste.de/HpL2/raw [03:58:43] What'd I do? :-( [03:58:44] You broke it. [03:58:58] try... [03:59:05] git fetch https://gerrit.wikimedia.org/r/operations/mediawiki-config refs/changes/75/97675/1 && git checkout FETCH_HEAD [03:59:19] though I expect you'll run into an issue when you try amending and resubmitting [03:59:26] Detached head. [03:59:40] git checkout -b review/mzmcbride/drafts [05:13:44] (03CR) 10EBernhardson: Global variable to disable flow's memcache usage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 (owner: 10EBernhardson) [05:14:25] ori-l: I assume you've seen http://motherfuckingwebsite.com/ ? [05:17:45] (03CR) 10EBernhardson: [C: 031] Link "You have new messages" to user talk diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 (owner: 10Aude) [05:36:53] (03CR) 10Aaron Schulz: Fixes to RedisBagOStuff (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [05:37:46] (03CR) 10Eloquence: "Always linking to the diff seems awful from a usability standpoint - a new user will have no idea how to interpret a diff (it requires par" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 (owner: 10Aude) [05:44:58] (03CR) 10Spage: [C: 032] "Excellent! passes on ee-flow" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 (owner: 10Cmcmahon) [05:45:08] (03Merged) 10jenkins-bot: new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 (owner: 10Cmcmahon) [05:57:02] (03PS1) 10Pastakhov: fix parent level, save incomplete operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97886 [06:05:12] (03CR) 10Werdna: Add access to historical revisions. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [06:35:33] (03PS8) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [06:36:35] (03PS9) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [06:43:04] (03CR) 10AndyRussG: "@Cscott: Test added!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [07:44:35] (03CR) 10Jack Phoenix: [C: 031] Simplify interlanguage links creation by early return [core] - 10https://gerrit.wikimedia.org/r/97737 (owner: 10Amire80) [09:07:06] (03PS3) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 [09:09:38] (03PS2) 10Pastakhov: fix parent level, save incomplete operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97886 [09:25:01] (03CR) 10Aude: "echo notifications already link to the diff (e.g. https://commons.wikimedia.org/w/index.php?title=User_talk:Aude&oldid=prev&diff=110552111" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 (owner: 10Aude) [09:32:42] (03PS9) 10Matthias Mullie: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [09:33:28] (03CR) 10Matthias Mullie: Add access to historical revisions. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [09:53:36] (03CR) 10Matthias Mullie: [C: 031] "Looks good to me, merge at will" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [09:54:13] (03CR) 10Nikerabbit: [C: 031] Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [09:57:30] (03CR) 10Dan-nl: [C: 031] Fix outdated comment in DefaultSettings [core] - 10https://gerrit.wikimedia.org/r/85420 (owner: 10TTO) [10:02:55] (03PS3) 10Pastakhov: fix parent level, save incomplete operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97886 [10:06:19] (03CR) 10Zfilipin: [C: 04-1] "Just a couple of small changes left to do! :)" (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [10:07:18] (03PS49) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [10:07:19] (03PS14) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [10:07:33] (03CR) 10jenkins-bot: [V: 04-1] Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [10:08:00] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [10:10:26] (03CR) 10Hashar: "I have missed earlier the back compatibility code. Seems you missed LBFactory_Simple in the process." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [10:11:35] (03PS4) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 [10:12:21] (03CR) 10Siebrand: "Uploading updated patch." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [10:13:30] (03CR) 10Zfilipin: [C: 031] Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [10:17:27] (03CR) 10Siebrand: "PS6 removes merge conflict." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [10:17:38] (03PS6) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [10:22:11] (03PS50) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [10:23:40] (03PS7) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [10:23:50] (03CR) 10Siebrand: "PS7: Comments in PS5 by @hashar addressed." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [10:25:40] (03CR) 10jenkins-bot: [V: 04-1] Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [10:27:55] (03CR) 10Pastakhov: [C: 032] fix parent level, save incomplete operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97886 (owner: 10Pastakhov) [10:28:03] (03Merged) 10jenkins-bot: fix parent level, save incomplete operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97886 (owner: 10Pastakhov) [10:28:31] (03CR) 10Zfilipin: [C: 04-1] "Great job! Just a couple of small changes and this will be ready for merging into master branch! :)" (033 comments) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [10:32:12] (03PS8) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [10:35:49] (03PS3) 10Mayankmadan: Prefer double-quoted strings in Ruby code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 [10:43:22] (03CR) 10Zfilipin: [C: 031] Prefer double-quoted strings in Ruby code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 (owner: 10Mayankmadan) [10:47:43] (03CR) 10Zfilipin: [C: 04-1] "Just a few changes in one file and this is ready!" (033 comments) [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [11:02:46] (03PS1) 10Pastakhov: add frame parameters in renderFunction [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97898 [11:06:11] (03CR) 10Siebrand: [C: 04-1] "Pointed out some L10n related concerns." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [11:21:28] (03PS1) 10Physikerwelt: Improvments in Update script and size calculations for different output formats [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/97899 [11:22:03] (03CR) 10Physikerwelt: [C: 032 V: 032] Improvments in Update script and size calculations for different output formats [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/97899 (owner: 10Physikerwelt) [11:22:34] (03PS2) 10Mayankmadan: Prefer double-quoted strings in Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/97756 [11:22:57] (03CR) 10Siebrand: [C: 04-1] "Typo in L10n." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [11:29:24] (03PS1) 10Physikerwelt: Add maitenance hints for missing variable statistics [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/97901 [11:30:56] (03CR) 10Physikerwelt: [C: 032 V: 032] Add maitenance hints for missing variable statistics [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/97901 (owner: 10Physikerwelt) [11:33:38] (03PS1) 10Netbrain: Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 [11:45:37] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [11:47:12] (03PS2) 10Ori.livneh: Fix CirrusSearch dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/97626 (owner: 10Gergő Tisza) [11:47:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [11:48:04] (03CR) 10Ori.livneh: [C: 032] Fix CirrusSearch dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/97626 (owner: 10Gergő Tisza) [11:48:26] (03CR) 10Siebrand: "Removed myself from reviewers. I'm not familiar with the codebase." [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [11:49:56] ori-l: still awake? [11:59:14] (03CR) 10Siebrand: [C: 04-1] Show minor edits and tags in Special:Undelete (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [12:07:38] (03CR) 10Siebrand: [C: 04-1] "L10n/i18n reviewed." (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 (owner: 10Legoktm) [12:09:38] (03PS1) 10Physikerwelt: adjusting gitreview to the development branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/97906 [12:10:14] (03CR) 10Physikerwelt: [C: 032 V: 032] adjusting gitreview to the development branch [extensions/Math] (dev) - 10https://gerrit.wikimedia.org/r/97906 (owner: 10Physikerwelt) [12:16:42] (03CR) 10Pastakhov: [C: 032] add frame parameters in renderFunction [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97898 (owner: 10Pastakhov) [12:16:59] (03Merged) 10jenkins-bot: add frame parameters in renderFunction [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97898 (owner: 10Pastakhov) [12:42:32] * YuviPanda waves at Niharika [12:50:49] (03CR) 10Siebrand: [C: 032] Using his and her instead of their [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97829 (owner: 10Amire80) [12:50:58] (03Merged) 10jenkins-bot: Using his and her instead of their [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97829 (owner: 10Amire80) [12:55:10] (03CR) 10Siebrand: "@Robla: setWarning is added in the reponse. wfDeprecated() is server side, and consumers will never see it. As consumers may well not be a" [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [12:57:31] (03CR) 10Zfilipin: [C: 031] Prefer double-quoted strings in Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [12:59:27] (03CR) 10Siebrand: [C: 032] Added or improved file documentation [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/97775 (owner: 10Kghbln) [12:59:30] (03Merged) 10jenkins-bot: Added or improved file documentation [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/97775 (owner: 10Kghbln) [13:03:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97757 (owner: 10Gerrit Patch Uploader) [13:07:59] (03CR) 10Siebrand: "Duplicate if there is a fair chance the strings will be customised or have a different context. I the context is exactly the same, you can" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [13:09:07] (03CR) 10Siebrand: [C: 04-1] Changed Special:GlobalUsers to inherit from AlphabeticPager, and not use the Special:ListUsers pager as a base class. (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [13:11:10] (03CR) 10Zfilipin: [C: 031] Prefer double-quoted strings in Ruby code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [13:11:26] (03CR) 10Siebrand: [C: 031] "+1 on the change and the reasoning. Haven't reviewed in detail. The L10n changes look fine. Added Raymond as reviewer, because he'll have " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [13:15:47] (03CR) 10Siebrand: [C: 032] Simplify interlanguage links creation by early return [core] - 10https://gerrit.wikimedia.org/r/97737 (owner: 10Amire80) [13:16:58] (03CR) 10Siebrand: [C: 032] Document the block duration tooltip [core] - 10https://gerrit.wikimedia.org/r/74950 (owner: 10Amire80) [13:19:28] (03Merged) 10jenkins-bot: Simplify interlanguage links creation by early return [core] - 10https://gerrit.wikimedia.org/r/97737 (owner: 10Amire80) [13:20:01] (03CR) 10Siebrand: [C: 04-2] "Per matmarex. Should probably be abandoned." [core] - 10https://gerrit.wikimedia.org/r/75678 (owner: 10Amire80) [13:20:57] (03PS1) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97908 [13:21:39] (03Merged) 10jenkins-bot: Document the block duration tooltip [core] - 10https://gerrit.wikimedia.org/r/74950 (owner: 10Amire80) [13:29:31] (03PS1) 10Shirayuki: i18n: fix "flow-rev-message-reply-bundle" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97909 [13:30:28] (03CR) 10Siebrand: "You're removing the possibility of setting the preference, but where is the preference being used, and shouldn't code in that path not als" [core] - 10https://gerrit.wikimedia.org/r/97908 (owner: 1001tonythomas) [13:30:48] (03PS1) 10Bartosz Dziewoński: jquery.makeCollapsible: Remove useless debug logging [core] - 10https://gerrit.wikimedia.org/r/97911 [13:36:00] (03CR) 10Siebrand: [C: 032] i18n: fix "flow-rev-message-reply-bundle" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97909 (owner: 10Shirayuki) [13:36:09] (03Merged) 10jenkins-bot: i18n: fix "flow-rev-message-reply-bundle" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97909 (owner: 10Shirayuki) [13:41:39] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [13:43:09] (03Abandoned) 10Amire80: Add a request to write the browser to feedback-bugornote [core] - 10https://gerrit.wikimedia.org/r/75678 (owner: 10Amire80) [13:46:20] (03CR) 10Shirayuki: "Spotted by Shirayuki and Amire80" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97909 (owner: 10Shirayuki) [13:50:13] (03PS1) 10Bartosz Dziewoński: jquery.spinner: Fix documentation formatting [core] - 10https://gerrit.wikimedia.org/r/97912 [13:51:42] (03CR) 10Siebrand: [C: 032] jquery.spinner: Fix documentation formatting [core] - 10https://gerrit.wikimedia.org/r/97912 (owner: 10Bartosz Dziewoński) [13:55:26] (03Merged) 10jenkins-bot: jquery.spinner: Fix documentation formatting [core] - 10https://gerrit.wikimedia.org/r/97912 (owner: 10Bartosz Dziewoński) [14:04:25] (03PS1) 10Kaldari: Fixing successbox message formatting in special pages [core] - 10https://gerrit.wikimedia.org/r/97914 [14:05:47] (03PS1) 10Amire80: Cleanup variable use in getLanguages [core] - 10https://gerrit.wikimedia.org/r/97915 [14:13:35] (03PS1) 10Hashar: comment out parsoid-server-sanity-check [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97916 [14:13:42] (03CR) 10Hashar: [C: 032] comment out parsoid-server-sanity-check [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97916 (owner: 10Hashar) [14:13:57] (03CR) 10MarkAHershberger: "Chad, if you don't like the hacky config option, could you provide another way to do the same thing?" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [14:14:27] (03Merged) 10jenkins-bot: comment out parsoid-server-sanity-check [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97916 (owner: 10Hashar) [14:29:13] (03PS1) 10Matthias Mullie: Allow Flow to connect to separate DB cluster [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97917 [14:32:07] (03CR) 10Hashar: "Do you guys know of any ruby linter/stylechecker that would be able to catch that kind of issue?" [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [14:40:26] (03CR) 10Manybubbles: [C: 04-1] "One fix requested in comments." (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [14:41:48] (03PS5) 10Manybubbles: Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [14:42:48] (03PS6) 10Manybubbles: Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [14:43:39] (03CR) 10Manybubbles: [C: 04-1] "Added explanation to the commit message. Please fix the comment and I'll merge it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [14:44:08] Rtdwivedi: please contact me when you have time [14:45:10] Hi MatmaRex [14:49:52] MatmaRex: so I've become a part time mentor now. Again :P [14:53:45] (03CR) 10MaxSem: "What's the use case for this? I see the point in including e.g. Special:PrefixIndex, but Gadgets?" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 (owner: 10Jackmcbarn) [15:01:02] hi mayankmadan [15:01:06] YuviPanda: yay [15:03:32] hi Niharika [15:03:48] Hi. :) [15:03:51] Niharika: this is the general dev channel :) [15:04:09] Niharika: you can autocomplete someone's name by typing the first few characters of their name and then typing tab [15:04:11] Hello to everyone. [15:04:19] so yu should expand to my name [15:04:43] YuviPanda: [15:05:00] Yuv [15:05:07] Niharika: :) and when someone's name is mentioned, they get an alert, so they know someone is talking to them [15:05:35] YuviPanda: Alright. Neat. [15:05:38] :) [15:06:23] Niharika: also, for IRC, you can try out http://hexchat.github.io/ too [15:06:33] a lot of people like that better than Pidgin [15:07:02] YuviPanda: Okay. Iĺl try that! [15:07:08] Niharika: sweet! [15:07:17] Hopefully thatĺl have better emoticons. These are pathetic. [15:07:26] Niharika: hahaha :D [15:07:32] # settings [15:25:45] siebrand, I was trying to remove all occurence of 'nocache' in the core wrt to your comment in https://gerrit.wikimedia.org/r/#/c/97908/ .While grepping I found the occurence in includes/AjaxResponse.php, the statement if ( $wgUser->getOption( 'nocache' ) ) { should I remove that too inorder to remove the button function completely ? [15:26:48] tonythomas01: If you want to remove that user option, you should remove all related code. As the code you reference above is about that preference, I'd say it should be removed in that patch set. [15:28:01] siebrand, one more thing, in resources/jquery/jquery.js , I get this result rnocache = /<(?:script|object|embed|option|style)/i, [15:28:11] is that too to be removed ? [15:28:18] tonythomas01: Sorry, don't know... [15:28:33] tonythomas01: I'd suggest leaving that alone, it's unrelated [15:28:36] tonythomas01: I'd say no. [15:28:53] Thanks, so I will leave that [15:28:58] * YuviPanda waves at siebrand [15:30:01] is there anyother action other than that checkbox in preferences that is triggering a nocache ? [15:30:01] * siebrand happily greets YuviPanda [15:30:37] as, I find this comment in includes/OutputPage.php - > Use enableClientCache(false) to force it to send nocache headers [15:39:29] YuviPanda: I ran the vagrant up command. But it seems stuck somewhere. Itś showing me the same statement for over ten minutes now. [15:39:44] Niharika: what statement? [15:40:10] Niharika: don't kill it yet, that sometimes happens if the network is a bit slow. [15:40:28] No. It says failed dependencies. [15:40:34] Niharika: oh [15:40:40] :( [15:40:40] Niharika: can you pastebin it? [15:40:54] The error log? [15:40:54] Niharika: dpaste.de, then copy paste the entire error message into that/ [15:40:57] and give me the link? [15:40:58] yeah [15:41:00] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [15:41:44] (03PS2) 10Cscott: Refactor the metabook-repair code. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97759 [15:41:45] (03PS1) 10Cscott: Improve status reporting. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97921 [15:42:50] YuviPanda: Doesnt let me copy-paste it. Should I mail you a screenshot of the prompt? [15:43:26] Niharika: hmm ok! [15:43:49] Niharika: you can use imgur.com to do the same for scsreenshots [15:44:18] (03CR) 10Cscott: [C: 032] Refactor the metabook-repair code. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97759 (owner: 10Cscott) [15:45:08] YuviPanda: Iĺl start using imgur. Mailed it for now. [15:45:18] Niharika: ok! [15:45:19] looking [15:45:20] (03Merged) 10jenkins-bot: Refactor the metabook-repair code. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97759 (owner: 10Cscott) [15:46:04] Niharika: ah, that's just a slow network issue. [15:46:07] Niharika: run vagrant up again? [15:46:16] Okay! [15:46:16] Niharika: this is the first time setup, so can be a bit slow. [15:46:22] No problem. [15:46:43] Iĺl have to kill this though. [15:46:50] Is that okay to do? [15:46:56] Niharika: yeah that's ol [15:46:57] ok [15:47:16] YuviPanda: Okay. [15:48:20] Niharika: btw here is how to copy paste from a windows console: http://superuser.com/a/170197 [15:57:05] (03CR) 10John F. Lewis: [C: 031] General Cleanup [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95650 (owner: 10Addshore) [16:01:59] (03PS9) 10Hashar: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [16:02:33] Niharika: works now? [16:02:40] (03CR) 10Hashar: "Patchset 9 adds tests to ensure we keep back compatibility for the various LBFactory classes." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [16:03:42] (03PS10) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [16:04:41] (03PS10) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [16:09:30] YuviPanda: Sorry! I went away for dinner. Ran the command. No errors yet. [16:09:36] (03PS11) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [16:09:37] sweet [16:11:46] (03CR) 10AndyRussG: Fix errors if course/org forms are re-submitted (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [16:11:49] (03CR) 10Jackmcbarn: "My plan is to replace the list at https://en.wikipedia.org/wiki/Wikipedia:Gadgets#Currently_installed_gadgets with a transclusion of Speci" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 (owner: 10Jackmcbarn) [16:13:21] (03CR) 10Nikerabbit: "...but if you don't add newlines anything starting with * or # will not display correctly." [core] - 10https://gerrit.wikimedia.org/r/97914 (owner: 10Kaldari) [16:13:32] (03CR) 10Anomie: [C: 032] Add OAuth identify method [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 (owner: 10CSteipp) [16:15:25] YuviPanda: It says VM already running. And it does show a VM running in the VB panel. [16:15:34] But I am not able to open it. [16:16:04] (03Merged) 10jenkins-bot: Add OAuth identify method [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 (owner: 10CSteipp) [16:16:06] (03CR) 10Kaldari: "Nikerabbit: I'm not sure I understand your comment. Could you elaborate?" [core] - 10https://gerrit.wikimedia.org/r/97914 (owner: 10Kaldari) [16:16:21] (03CR) 10Anomie: [C: 031] "Looks good. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [16:18:47] (03CR) 10Anomie: [C: 032] Remove module storage logging; replace with small clean-up script [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/97485 (owner: 10Ori.livneh) [16:18:53] (03Merged) 10jenkins-bot: Remove module storage logging; replace with small clean-up script [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/97485 (owner: 10Ori.livneh) [16:18:57] (03CR) 10Nikerabbit: "In the case that any of these messages start or have been customized to start with a list, the list doesn't render properly. That's the mo" [core] - 10https://gerrit.wikimedia.org/r/97914 (owner: 10Kaldari) [16:22:33] YuviPanda: Are you there? [16:27:09] (03CR) 10Chad: "I'm not opposing because I don't care about these users, I'm opposing because I do care about them :D" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [16:29:19] Niharika: here now [16:29:34] Niharika: what do you mean by 'open it'? [16:29:53] Niharika: try going to localhost:8000 on a browser in windows, it should show up [16:29:59] Niharika: did vagrant up finish without errors? [16:31:01] Okay! No, it didn run at all. Just said the machine is running. [16:31:38] Niharika: ah [16:31:43] Niharika: try running 'vagrant provison' [16:31:45] (03CR) 10Jhall: [C: 031] Prefer double-quoted strings in Ruby code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [16:32:06] YuviPanda: Okay. [16:32:08] Niharika: the idea with vagrant is that you write your code, etc on the host OS itself - in Windows, and it just *runs* inside the VM [16:32:35] Okay. I was assuming it be like the other VM I have. [16:32:52] Niharika: ah, no. it's mostly invisible. [16:33:04] (03CR) 10Jhall: [C: 031] Prefer double-quoted strings in Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [16:33:36] YuviPanda: I ran vagrant provision. Itś doing some stuff now. [16:33:44] Niharika: yup! wait for it [16:33:54] Niharika: only slow the first time, I promise! [16:34:22] I don have any problem with slow as long as it runs. I get errors in installing almost everything. [16:34:29] I am yet to make grunt work. [16:35:00] (03CR) 10MarkAHershberger: "I realize I started the discussion here about "caring for users", but this isn't the appropriate venue. We should move that elsewhere. w" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [16:35:09] Niharika: yeah, most of those issues will go away when you have vagrant, since you can just run it inside of them. And that's the exact same environment as the production servers, so it should work fine :) [16:36:23] YuviPanda: Done! localhost:8080 takes me to the Main Page. :D [16:36:27] FInally. [16:36:30] Niharika: :D [16:36:41] (03PS1) 10Tpt: Load page module when the navigation is displayed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97924 [16:36:45] How do I proceed now? [16:36:54] Niharika: so in the vagrant folder, you will find mediawiki folder, and in there there will be all the code [16:37:04] YuviPanda: Okay! [16:37:13] Niharika: you can edit it in windows itself, using any editor you want, and just refresh localhost:8080 and it'll show up :D [16:37:42] Niharika: have you submitted a patch via Gerrit before? [16:37:50] YuviPanda: Nope. Never. [16:38:04] Niharika: hmm, if so I think that'll be a good first start. [16:38:18] Niharika: do you know of any small bug that you can fix and submit a patch for? I can guide you through it. [16:38:36] Okay. Iĺl read through the tutorials and come back to bother you if I get stuck. :) [16:38:45] Niharika: :) feel free to bother me :) [16:39:00] YuviPanda: Thank you for all the help! [16:39:03] Niharika: :) [16:39:10] Niharika: when does OPW 'official' coding period start? [16:39:18] YuviPanda: December 10. [16:39:36] Niharika: nice! You've a good head start [16:39:39] * YuviPanda likey! [16:39:50] YuviPanda: :) [16:40:27] (03PS1) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 [16:40:34] Niharika: so by submitting a patch, you'll get experience finding / fixing bugs, and also about how our git/gerrit setup works :) [16:42:05] YuviPanda: I wanted to learn that. :) [16:42:12] (03PS6) 10Jackmcbarn: Show minor edits and tags in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/97855 [16:42:16] Niharika: :) Once you get used to it it is quite easy :) [16:42:22] Niharika: oh, and one more thing [16:42:26] Niharika: type 'vagrant ssh' [16:42:34] Okay. [16:42:51] Niharika: that'll log you into the VM in a commandline, and you can then do things you can do normally in an Unbutu machine [16:43:13] (03Abandoned) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97908 (owner: 1001tonythomas) [16:43:22] Okay. What do I need that for? [16:43:36] Niharika: nothing in particular now, but in case you want to play around [16:43:44] since you mentioned you can't open the VM normally [16:43:44] Not like Rebutu machines [16:44:01] YuviPanda: Okay. :) [16:44:29] (03PS1) 10Anomie: API: Add $wgAPIFormatModules [core] - 10https://gerrit.wikimedia.org/r/97926 [16:44:42] Niharika: :) [16:57:28] (03CR) 10Anomie: Output hidden fields on pages other than templates (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [17:05:18] (03CR) 10Yurik: [C: 032] "As long as people use it to disable existing formats, not add new ones :)" [core] - 10https://gerrit.wikimedia.org/r/97926 (owner: 10Anomie) [17:05:47] (03CR) 10Jackmcbarn: Output hidden fields on pages other than templates (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [17:06:03] (03CR) 10Legoktm: General Cleanup (034 comments) [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95650 (owner: 10Addshore) [17:08:21] (03Merged) 10jenkins-bot: API: Add $wgAPIFormatModules [core] - 10https://gerrit.wikimedia.org/r/97926 (owner: 10Anomie) [17:11:40] legoktm: apparently I have gone from too few spaces to too many :P [17:18:38] (03CR) 10Anomie: [C: 031] "A few trivial style nitpicks, and wondering why you don't add this to ApiQueryDeletedrevs too." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [17:20:50] (03CR) 10Anomie: Output hidden fields on pages other than templates (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [17:22:48] (03Abandoned) 10Bsitu: Flow should be configurable to use a cluster database [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97868 (owner: 10Bsitu) [17:24:16] Rtdwivedi: Hey, I'll change them right away [17:24:22] Rtdwivedi: Thx for the feedback [17:25:39] (03CR) 10Anomie: [C: 032] "Meh, may as well. It's not so different from how wpSummary gets used in two different ways depending on §ion=new." [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [17:25:43] (03Merged) 10jenkins-bot: Output hidden fields on pages other than templates [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [17:27:34] (03CR) 10Jackmcbarn: [C: 04-1] "Doing..." [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [17:32:25] is there a way to diff deleted (not revdel'd) revisions through the api? [17:40:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [17:42:20] (03PS7) 10Jackmcbarn: Show minor edits and tags in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/97855 [17:42:42] (03CR) 10Nikerabbit: "Did I miss something. I see no way to use this to disable existing formats." [core] - 10https://gerrit.wikimedia.org/r/97926 (owner: 10Anomie) [17:43:18] (03CR) 10Jackmcbarn: "I'll save the API fix for a different commit. It has a small issue that will make it more complicated than I want to do in this commit." [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [17:44:02] (03CR) 10Nikerabbit: Output hidden fields on pages other than templates (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [17:44:31] Nikerabbit: a little late, that's already merged [17:47:22] Rtdwivedi: are you here ? [17:47:34] vandrew_: Hi! [17:47:55] Rtdwivedi: Hey, I've done what you said [17:48:17] Rtdwivedi: Deleted the To Do and added the missing thing [17:48:27] vandrew_: Great! [17:49:00] vandrew_: task closed. :-) [17:49:02] Rtdwivedi: Thanks ! [17:51:58] (03PS1) 10Cscott: LUASANDBOX_G requires the tsrm_ls to be present. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97928 [17:52:50] (03CR) 10Siebrand: [C: 031] Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97925 (owner: 1001tonythomas) [17:53:05] (03CR) 10Siebrand: [C: 04-1] "This needs release notes." [core] - 10https://gerrit.wikimedia.org/r/97925 (owner: 1001tonythomas) [17:53:58] hey csteipp, don't know if you had a chance to read my email. it's re: https://gerrit.wikimedia.org/r/#/c/97369/. i just need a bit more clarity on what you'd like me to change [17:55:48] (03CR) 10Yurik: "In theory we can make something similar to $wgAPIModules['modulename'] = 'ApiDisabled' to disable formats ... not sure it will work at the" [core] - 10https://gerrit.wikimedia.org/r/97926 (owner: 10Anomie) [17:56:40] (03PS4) 10Dr0ptp4kt: Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 [17:58:01] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [core] - 10https://gerrit.wikimedia.org/r/97855 (owner: 10Jackmcbarn) [17:58:32] jackmcbarn: what do you mean late? One can always make a new commit [17:58:42] (03CR) 10Bsitu: [C: 032] Allow Flow to connect to separate DB cluster [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97917 (owner: 10Matthias Mullie) [17:58:51] (03Merged) 10jenkins-bot: Allow Flow to connect to separate DB cluster [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97917 (owner: 10Matthias Mullie) [17:59:01] Nikerabbit: yes, but for a minor style thing, is it really worth it? [17:59:35] jackmcbarn: yes? [18:02:43] (03PS1) 10Jackmcbarn: Use Html::hidden instead of Html::input [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97929 [18:02:51] (03PS1) 10Chad: Fix notices on undefined $fileHandle and $res [core] - 10https://gerrit.wikimedia.org/r/97930 [18:02:55] <^d> AaronSchulz: ^ [18:04:28] (03CR) 10Anomie: [C: 032] LUASANDBOX_G requires the tsrm_ls to be present. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97928 (owner: 10Cscott) [18:05:09] (03Merged) 10jenkins-bot: LUASANDBOX_G requires the tsrm_ls to be present. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97928 (owner: 10Cscott) [18:06:26] (03CR) 10Aaron Schulz: [C: 032] Fix notices on undefined $fileHandle and $res [core] - 10https://gerrit.wikimedia.org/r/97930 (owner: 10Chad) [18:06:27] (03PS1) 10Cscott: Plug leaks on error paths. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 [18:07:07] anomie: ^ [18:09:24] (03Merged) 10jenkins-bot: Fix notices on undefined $fileHandle and $res [core] - 10https://gerrit.wikimedia.org/r/97930 (owner: 10Chad) [18:10:37] (03CR) 10Zfilipin: "@Hashar: if you are talking about comments I made in env.rb[1], Ruby did not complain because it is valid Ruby code. :) But, I find it con" [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [18:12:30] (03CR) 10Dan-nl: "hey chris," [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [18:18:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [18:18:34] (03CR) 10Jeremyb: "bug 36142" [core] - 10https://gerrit.wikimedia.org/r/8622 (owner: 10Aaron Schulz) [18:20:02] (03CR) 10Siebrand: "Please add message documentation when adding new message keys. See https://www.mediawiki.org/wiki/I18n#Message_documentation for details." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [18:20:59] qgil: I would like to speak with you regarding a task [18:24:16] (03CR) 10Daniel Kinzler: [C: 04-1] "Some nitpicks. Would definitely be an improvement for the architecture." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/97742 (owner: 10Aude) [18:25:45] (03CR) 10Daniel Kinzler: [C: 032] Make setUp and tearDown protected in tests [core] - 10https://gerrit.wikimedia.org/r/97355 (owner: 10Aude) [18:28:40] (03CR) 10Siebrand: [C: 032] Cleanup variable use in getLanguages [core] - 10https://gerrit.wikimedia.org/r/97915 (owner: 10Amire80) [18:29:09] (03Merged) 10jenkins-bot: Make setUp and tearDown protected in tests [core] - 10https://gerrit.wikimedia.org/r/97355 (owner: 10Aude) [18:30:43] (03CR) 10Siebrand: [C: 031] Add some phpdocs for IDEs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 (owner: 10Addshore) [18:30:58] (03PS1) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97934 [18:31:00] (03CR) 10Anomie: "I'm not sure this is correct." (032 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [18:31:51] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97934 (owner: 1001tonythomas) [18:32:09] (03Merged) 10jenkins-bot: Cleanup variable use in getLanguages [core] - 10https://gerrit.wikimedia.org/r/97915 (owner: 10Amire80) [18:32:28] (03CR) 10Manybubbles: "The message documentation was added in I29a3ad409f04906a08d3cae92cde7e761ccc0ba3 so we did find and correct the mistake." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [18:33:04] (03Abandoned) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97934 (owner: 1001tonythomas) [18:33:22] (03CR) 10Bsitu: [C: 031] Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [18:34:54] andre__: hello ? [18:37:01] (03CR) 10Cscott: "Yeah, it would be nice to more thoroughly audit the code, but I wanted to fix the obvious (ie, tested) bugs first. I'm nervous about addi" (032 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [18:38:51] (03CR) 10Zfilipin: Prefer double-quoted strings in Ruby code (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [18:39:36] (03PS1) 10Anomie: RETURN_FALSE instead of return in some methods [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97936 [18:40:35] vandrew_, hi [18:41:19] andre__: hey [18:41:40] andre__: I would like to speak about a task, is it the right time ? [18:41:56] vandrew_, I have time, I just don't know if I'm the person to speak to :P [18:42:45] andre__: umm, it's about this task https://www.google-melange.com/gci/task/view/google/gci2013/5868509229744128 [18:43:31] (03CR) 10Zfilipin: [C: 04-1] "Please fix this and as far as I am concerned this is good to go:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [18:43:44] vandrew_: #wikimedia-multimedia might be a good place to ask [18:43:48] (03PS1) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97937 [18:43:49] vandrew_, because there are also the developers [18:44:16] (03CR) 10Siebrand: "Ah, great, thanks. I'm catching up on my review back." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [18:44:23] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97937 (owner: 1001tonythomas) [18:44:26] andre__: yeah, but before I start coding I have a few questions about gerrit [18:44:28] anomie: csteipp is there any support in our OAuth implementation for apps that are not web based, but not desktop / mobile either (So I can keep tokens secret)? [18:44:32] andre__: should I ask there ? [18:44:45] vandrew_, ah, sure, in that case, that's generic development stuff, so this here is the perfect channel [18:44:47] anomie: csteipp specifically, I've a non http network service that I want to have users verify as [18:44:49] *to [18:44:55] vandrew_, but in general: Don't ask to ask, just ask here [18:44:59] (03Abandoned) 1001tonythomas: Removed 'Disable browser page caching" user preference [core] - 10https://gerrit.wikimedia.org/r/97937 (owner: 1001tonythomas) [18:45:12] andre__: sure thing [18:45:13] vandrew_, somebody will point you to better places if it's not the best place. [18:45:56] andre__: so, I've cloned the repository to my computer [18:46:37] andre__: how to I submit as an amendament to the initial patch ? [18:46:41] (03CR) 10Siebrand: [C: 04-1] Insert new revision when Flow is taking over (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [18:46:51] vandrew_, https://www.mediawiki.org/wiki/Git/Tutorial#Amending_a_change [18:47:12] YuviPanda: You might set up your consumer's callback as Special:OAuth/verified, then have your program prompt the user to enter the verification code displayed on that page. [18:47:13] vandrew_: recommend you use "git review", then it's simpler and you can do "git review -d 12345" where 12345 is th gerrit change number you see in the URL [18:47:27] anomie: woo, I didn't know of /verified [18:47:48] YuviPanda: You can see how it works at https://www.mediawiki.org/w/index.php?title=Special:OAuth/verified&oauth_verifier=1234&oauth_token=5678 [18:48:18] vandrew_: so basically, git clone .. change stuff.. git commit -a .. git review if it's a new change, and git review -d 12345, change stuff, git commit --amend -a , git review to add to existing change [18:48:23] I've just used "git review" got a mail [18:48:40] YuviPanda: Although, for the thing I think you're planning, shouldn't you be having both a web and non-web interface? [18:49:07] anomie: mysql thingy? Well, I am first trying to get a non-web thingy working [18:49:16] anomie: since... I already have it working :D just doesn't auth anyone [18:49:27] mutante: so basically I have to use "git review -d and a change number " ? [18:49:41] YuviPanda: I was just thinking if they hit the mysql interface and aren't authed, you'd tell them to go to the web interface to auth first and then try again. [18:50:08] anomie: 'web interface' being a specially constructed OAuth URL, rather than my own web interface [18:50:17] anomie: since the web interface is going to take a lot longer to build [18:50:22] anomie: and I don't want to couple those two together [18:50:31] anomie: with /verify I guess I don't even need a web interface [18:50:39] to begin with at least [18:50:41] vandrew_, yeah, and 12345 is the change number in e.g. https://gerrit.wikimedia.org/r/#/c/12345/ [18:50:45] (03CR) 10Siebrand: [C: 04-1] "Needs qqq." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [18:51:08] vandrew_: yep [18:51:13] anomie, Just now I had a problem with amending the new change set. It just gets out s a new change after git review -R [18:51:27] vandrew_: then after you made new changes, commit with --amend and "git review" again [18:51:46] then you should see a new patchset (via IRC bot and on gerrit web ui) [18:51:58] I see [18:52:10] YuviPanda: Well, 'web interface' being a page that does the call to /initiate, then redirects the browser to /authorize, then calls /token and saves the info once the browser comes back. [18:52:24] mutante: MarkTraceur told me the following on a comment: "We don't use merge commits " ? [18:52:35] It's true, we don't [18:52:54] vandrew_: depends on the repo [18:53:01] YuviPanda: You're complaining that people might not be able to figure out how to ssh into tool labs, but you expect them to have a mysql client installed locally? ;) [18:53:04] but yea, it should be the bot verifying it and causing the merge [18:53:11] while humans do code review [18:53:28] marktraceur: so should I use another command ? [18:54:04] vandrew_: What did you use, git-review? That should be fine, just make sure your git tree is in a sane state [18:54:20] eh, wait, i may have gotten you wrong there first, what marktracur says [18:54:31] vandrew_: https://www.mediawiki.org/wiki/Git/Getting_started has some tips about our workflow [18:54:32] i got that as "we dont merge commits" (as humans) [18:54:43] marktraceur: yes I've used git review [18:55:56] anomie: halfak tells me that's a common occurance :D [18:56:41] hello guillom? [18:56:56] sorry to bother you, but have you taken a look at my essay yet? [18:57:49] <^d> Who wants an easy 2-liner to review? :) [18:57:51] andre__: so I have to use git review and then post the commit https://gerrit.wikimedia.org/r/#/c/97938/ like this on the site ? [18:58:05] (03CR) 10Manybubbles: Prefer double-quoted strings in Ruby code (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [18:58:36] (03PS9) 10Jdlrobson: Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [18:59:38] (03CR) 10Siebrand: Show notification on search page if configured (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [18:59:51] anomie: I'll go read up on the OAuth protocol I guess [19:00:04] (03PS1) 10Tpt: Improve ProofreadIndexPage parser management [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97941 [19:00:08] anomie: I was under the assumption that you only needed the token from /verify + the API key [19:00:19] (03CR) 10Anomie: "The pattern of "MAKE_STD_ZVAL() for a local variable / call something / never use that local again" seems ripe for cleaning up." (032 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:00:30] (03CR) 10Jdlrobson: [C: 031] "I made a slight tweak so that the hack lives in MobileFrontend (see I4c92422428de60d2e11ba891fe44dbf43ad99c43) which will keep it more mai" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [19:01:32] (03CR) 10Chad: [C: 032] Allow enabling as default with a BetaFeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 (owner: 10Legoktm) [19:01:54] (03Merged) 10jenkins-bot: Allow enabling as default with a BetaFeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 (owner: 10Legoktm) [19:01:57] YuviPanda: https://tools.wmflabs.org/oauth-hello-world/enduser.php?action=download, particularly the functions doAuthorizationRedirect() and fetchAccessToken(). What /verify does is tell you the "oauth_verifier" that you need for the call to /token if you don't have a webpage at which to receive it yourself. [19:02:04] (03CR) 10Manybubbles: Show notification on search page if configured (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [19:02:15] vandrew_, I don't know what exactly you want to do, and at which stage of development you are, so it's hard to generalize for me [19:02:28] ^d: woo, thanks :D [19:02:37] vandrew_, but normally you follow the steps in https://www.mediawiki.org/wiki/Git/Tutorial#How_to_submit_a_patch for your first patch for an issue, [19:02:51] vandrew_, and if that patch needs more changes you follow https://www.mediawiki.org/wiki/Git/Tutorial#Amending_a_change [19:02:51] andre__: ok, thx again [19:03:14] vandrew_, if you have problems at a specific step, please let me/us know [19:03:15] anomie: wah that's very well commented. Thank you [19:04:40] YuviPanda: Note that if you want OAuth-compliant responses instead of our funny json, omit "format=json" from those requests. [19:05:09] * anomie saw valhallasw was complaining to YuviPanda about that in #wikimedia-labs [19:05:42] (03CR) 10Zfilipin: Prefer double-quoted strings in Ruby code (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [19:07:52] vandrew_, back, hi! [19:08:23] vandrew_, oh, I see you already talked with andre__ [19:08:27] qgil: yes [19:08:33] good [19:12:55] (03PS7) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 [19:15:41] (03CR) 10Cscott: Plug leaks on error paths. (031 comment) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:15:48] (03PS2) 10Cscott: Plug leaks on error paths. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 [19:16:05] (03PS3) 10Cscott: Plug leaks on error paths. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 [19:18:31] (03CR) 10Zfilipin: [C: 031] Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [19:18:43] (03CR) 10Cscott: "Updated w/ anomie's feedback. Fixing luasandbox_lua_to_zval as anomie suggested exposed another leak in luasandbox_call_helper, which I f" [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:18:57] (03PS1) 10EBernhardson: Increase default topic list load to 10 topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97942 [19:28:50] (03CR) 10Anomie: Plug leaks on error paths. (035 comments) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:28:52] (03CR) 10CSteipp: "Move the $this->_Handler instanceof FormHandler either above the if..else, so both sides are covered, or do the check at the bottom of set" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [19:30:04] (03CR) 10Anomie: [C: 031] "I'm not sure I see the point, since Html::hidden just calls Html::input with the parameter 'hidden'. Nikerabbit?" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97929 (owner: 10Jackmcbarn) [19:33:38] (03CR) 10Chad: "No net change, but harmless :)" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97929 (owner: 10Jackmcbarn) [19:37:50] (03PS4) 10Cscott: Plug leaks on error paths. [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 [19:40:00] (03CR) 10Manybubbles: [C: 032 V: 032] Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [19:40:08] (03CR) 10Anomie: "What about the few wasted cycles processing the extra function call? ;)" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97929 (owner: 10Jackmcbarn) [19:40:15] (03CR) 10Chad: [C: 032] Remove unused local variables, update formatting and documentation [core] - 10https://gerrit.wikimedia.org/r/97505 (owner: 10Siebrand) [19:40:48] (03CR) 10Cscott: "Bow to anomie's eye for details. (I looked at the ztrace instances and somehow overlooked the fact that they had an error case too, even " [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:41:02] (03CR) 10Chad: [C: 032] Update formatting and comments in FormatJson [core] - 10https://gerrit.wikimedia.org/r/97533 (owner: 10Siebrand) [19:41:42] (03PS1) 10Aaron Schulz: [WIP] Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 [19:42:36] (03CR) 10Chad: [C: 032] Use 'pagetitle' in content language [core] - 10https://gerrit.wikimedia.org/r/94862 (owner: 10Siebrand) [19:42:48] (03CR) 10Anomie: [C: 031] "Looks good now. Haven't tested, yet. Remind me next week if I don't get to it this afternoon." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [19:45:03] (03Merged) 10jenkins-bot: Remove unused local variables, update formatting and documentation [core] - 10https://gerrit.wikimedia.org/r/97505 (owner: 10Siebrand) [19:45:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Optimized LocalRepo::findFiles() [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [19:46:09] (03CR) 10EBernhardson: [C: 031] "We can merge whenever raymond is prepared to make the change." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [19:46:46] (03Merged) 10jenkins-bot: Update formatting and comments in FormatJson [core] - 10https://gerrit.wikimedia.org/r/97533 (owner: 10Siebrand) [19:49:01] (03Merged) 10jenkins-bot: Use 'pagetitle' in content language [core] - 10https://gerrit.wikimedia.org/r/94862 (owner: 10Siebrand) [19:52:27] YuviPanda , hi. I had some problems with labs-vagrant a few weeks ago, https://wikitech.wikimedia.org/wiki/Talk:Labs-vagrant [19:52:43] spagewmf: ow, looking [19:52:49] spagewmf: didn't have talk page email on there :( [19:52:52] err [19:52:55] watchlist email [19:53:53] YuviPanda: no worries. It was a few weeks ago, I just returned to it. I'll figure out the Parsoid problem [19:54:50] spagewmf: I thought I fixed the home 755 issue. grr. [19:55:02] spagewmf: also, try switching your user to user vagrant before running? [19:55:35] (03PS1) 10Aklapper: [4.4] Upgrade InlineHistory extension [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97994 [19:56:15] maybe you did, that was Nov. 8. I 've been running `sudo labs-vagrant provision` but for git fetch in \vagrant I did sudo su vagrant first. [19:56:48] spagewmf: i definitely haven't touched it since november, now :) [19:57:05] spagewmf: I'll take a look again. parsoid seems to be looking at the wrong place, or maybe there's a firewall rule [19:57:52] YuviPanda: what is the problem? [19:58:15] gwicke: https://wikitech.wikimedia.org/wiki/Talk:Labs-vagrant#Parsoid_errors_using_VisualEditor_role [19:58:26] gwicke: see log messages and such from parsoid there that spagewmf encountered [20:00:45] could be a broken api url [20:15:02] (03Abandoned) 10Merlijn van Deen: Another test commit, now in an integrated setting. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89410 (owner: 10Merlijn van Deen) [20:15:07] (03PS1) 10Brian Wolff: Add audio stats to [[Special:TimedMediaHandler]]. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 [20:17:25] (03CR) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [20:18:26] (03CR) 10Siebrand: [C: 032] "Yay Raimond :)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [20:19:04] (03CR) 10jenkins-bot: [V: 04-1] Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [20:19:48] (03CR) 10Siebrand: Show notification on search page if configured (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [20:24:39] marktraceur, am I supposed to create a task for https://bugzilla.wikimedia.org/show_bug.cgi?id=57678 or not? [20:24:57] marktraceur, I can be your proxy, but don't make me think :) [20:24:59] qgil: I think vandrew_ is already on it, but I'm not sure what you want to do [20:25:16] If he gets something for having a task about it, it may be worthwhile to add a task [20:25:28] Else it doesn't matter [20:25:31] vandrew_, can claim only one task at a time. I can create a task, but then he must unclaim the current one. [20:26:14] marktraceur, I think it is better not to mess things up, because while vandrew_ works in the first task another student can claim the other one... [20:26:30] Might be [20:26:44] 'kay, we'll just work through the two bugs as part of the one task [20:27:30] marktraceur, you can always find other little tasks, and if vandrew_ likes MultimediaViewer he can jump on them and close them faster as he gains experience [20:27:47] Yup [20:27:52] ok, thanks! [20:28:20] (03PS3) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [20:28:22] (03CR) 10jenkins-bot: [V: 04-1] form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [20:28:27] marktraceur, btw, all your MultimediaViewer and UploadWizard tasks are published since an hour ago or so [20:28:39] Saweet [20:28:41] Thanks :) [20:28:43] (03CR) 10Siebrand: [C: 04-1] "Omissions in L10n." (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 (owner: 10Brian Wolff) [20:28:58] (03PS4) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [20:30:53] (03CR) 10Dan-nl: "- attempting to address chris’ comments in ps2" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [20:31:35] (03PS1) 10Brian Wolff: Do language formatting on numbers in [[Special:TimedMediaHandler]] [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97999 [20:34:39] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [20:39:22] (03PS1) 10Cmcmahon: update locator and use hover not onmouseover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98000 [20:39:44] (03PS2) 10Brian Wolff: Add audio stats to [[Special:TimedMediaHandler]]. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 [20:39:56] (03PS2) 10Cmcmahon: update locator and use hover not onmouseover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98000 [20:41:43] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97999 (owner: 10Brian Wolff) [20:43:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 (owner: 10Brian Wolff) [20:44:33] (03CR) 10Nemo bis: Show notification on search page if configured (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [20:44:54] (03PS1) 10Bsitu: Clicking 'comment' in history should take user to the comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 [20:45:50] siebrand: But If I started fixing everything slightly sketchy about TMH, I'd be here all day :P [20:46:14] bawolff: At least do it in the code parts you touch. I know there's a lot more... [20:46:45] Ok, I'll change the
[20:46:50] bawolff: Oh, that one. [20:46:57] bawolff: Yeah, that's optional, I guess. [20:47:12] bawolff: I thought you protested the lego. [20:47:33] Yeah, your comment about the lego was 100% fair, I probably should have changed that when I first saw it [20:47:44] <^d> bawolff: s/all day/all week/ [20:47:53] s/all week/all time/ [20:48:04] but that's if you start fixing everything sketchy about mediawiki [20:48:11] * YuviPanda mumbles something about PHP [20:48:47] (03PS4) 10Matthias Mullie: Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 [20:49:04] (03CR) 10Matthias Mullie: [C: 032] Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [20:49:10] <^d> YuviPanda: PHP is awesome. It let's you do things like "$a$b$c" > 1 [20:49:13] (03CR) 10Siebrand: [C: 032] Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [20:49:22] (03Merged) 10jenkins-bot: Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 (owner: 10Matthias Mullie) [20:49:25] ^d: I need to steal your paste and do a blog post at some point [20:49:37] <^d> http://p.defau.lt/?hhbKUN75uXUWEXoijtGofQ - here, it's yours :p [20:49:48] ty ty :) [20:52:40] <^d> I really should use the 4th option. [20:52:53] <^d> I think it's devilishly clever :p [20:53:14] ^d: you should use 3. [20:53:19] ^d: it is functional and hence webscale [20:53:30] IT CAN SCALE TO THOUSANDS OF BOOLEANS! [20:53:47] <^d> WASTES TIME ON FUNCTION CALLS. [20:56:22] (03PS3) 10Brian Wolff: Add audio stats to [[Special:TimedMediaHandler]]. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97998 [20:58:14] (03PS5) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [20:58:16] (03CR) 10jenkins-bot: [V: 04-1] form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [20:58:30] (03PS6) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [20:59:00] (03PS10) 10EBernhardson: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [20:59:08] (03PS3) 10Cmcmahon: update locator and use hover not onmouseover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98000 [20:59:31] (03CR) 10Cmcmahon: [C: 032] "merge to turn the Flow test build green" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98000 (owner: 10Cmcmahon) [20:59:41] (03CR) 10Dan-nl: "- addressed siebrand’s comments in ps4" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [21:00:01] (03CR) 10EBernhardson: [C: 032] "PS10: address l10n issues. Documentation is in the pipeline." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [21:00:13] (03Merged) 10jenkins-bot: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [21:01:36] (03PS2) 10Bsitu: Clicking 'comment' in history should take user to the comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98001 [21:02:09] (03CR) 10Bartosz Dziewoński: "Hmm, that sounds reasonable too." [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [21:03:46] (03CR) 10Parent5446: [WIP] Optimized LocalRepo::findFiles() (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97993 (owner: 10Aaron Schulz) [21:08:32] hey csteipp, i adjusted the code so that the test is in the setModuleHandler. i'm no longer using instance of since that method makes sure the module is registered. the main thing to test after that was that a module was set and registered if the form was posted. does this take care of your concern here or did i miss something? [21:10:16] dan-nl: I was actually looking for the opposite-- another check of instanceof beyond the config check, so that someone can't take over the server with a config change [21:14:42] csteipp: so the check against the protected $_registered_modules could be overridden? that's good to know. i thought protected class members couldn't be overridden if there was no setter. would putting an instanceof check in the setModuleHandler if $this->_Handler has been set take care of it? [21:16:39] Not that the method can be overriden, but that someone can put in "just a config change" that gets rubber stamped and deployed, which would allow a hostile class to be loaded. So yes, check in setModuleHandler is fine [21:22:24] (03CR) 10Chad: [C: 032] Use ISO 3166-1 alpha-2 country codes [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97654 (owner: 10BryanDavis) [21:22:29] (03Merged) 10jenkins-bot: Use ISO 3166-1 alpha-2 country codes [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97654 (owner: 10BryanDavis) [21:28:04] (03PS7) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [21:28:05] (03CR) 10jenkins-bot: [V: 04-1] form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [21:28:21] (03PS8) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [21:31:32] (03PS9) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [21:31:33] (03CR) 10jenkins-bot: [V: 04-1] form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [21:31:45] (03PS10) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [21:32:28] csteipp: k, ps10 has the instance of test in it .. let me know if that's okay now or not. [21:36:32] (03CR) 10Dan-nl: "added instanceof test to setModuleAndHandler." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [21:37:51] (03CR) 10Brian Wolff: Do language formatting on numbers in [[Special:TimedMediaHandler]] (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97999 (owner: 10Brian Wolff) [21:39:00] (03CR) 10Kaldari: "Ah, thanks for the explanation. In all 4 of these cases, the messages are just short simple success messages, for example, "Tokens reset."" [core] - 10https://gerrit.wikimedia.org/r/97914 (owner: 10Kaldari) [21:51:41] (03PS3) 10Brian Wolff: Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 [21:52:16] (03CR) 10jenkins-bot: [V: 04-1] Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [21:55:18] (03PS4) 10Brian Wolff: Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 [21:55:19] (03PS5) 10Brian Wolff: Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 [21:57:32] (03CR) 10EBernhardson: (bug 57162) red links don't work (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [21:58:38] (03CR) 10Brian Wolff: [C: 032] Remove commented out code [core] - 10https://gerrit.wikimedia.org/r/97473 (owner: 10Siebrand) [21:59:43] (03CR) 10Brian Wolff: [C: 032] Break long lines in gallery classes [core] - 10https://gerrit.wikimedia.org/r/97472 (owner: 10Siebrand) [22:00:30] (03CR) 10Malvineous: [C: 032 V: 031] Fixed bug where variables referenced where not reachable (out of scope) [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/97902 (owner: 10Netbrain) [22:01:11] (03PS1) 10Aklapper: [4.4] Upgrade two template files and reapply our custom changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98005 [22:02:40] (03CR) 10CSteipp: [C: 031] form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [22:02:52] (03PS6) 10EBernhardson: (bug 57162) red links don't work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [22:03:13] (03CR) 10EBernhardson: [C: 032] "PS6: address PS5 comments" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [22:03:37] (03CR) 10Brian Wolff: [C: 032] "Looks fine to me, although to be honest some of the changes seem kind of random - for example, doing things like class foo extends bar {} " [core] - 10https://gerrit.wikimedia.org/r/97471 (owner: 10Siebrand) [22:05:34] (03Merged) 10jenkins-bot: (bug 57162) red links don't work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [22:07:51] (03CR) 10Brian Wolff: [C: 032] Replace Linker::link() by linkKnown() [core] - 10https://gerrit.wikimedia.org/r/97474 (owner: 10Siebrand) [22:08:16] oh, hmm. they all depend on that one FileRepo change... [22:09:08] (03PS1) 10Aklapper: [4.4] Upgrade "Login"/"Email address" string to use upstream code [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98008 [22:12:41] <^demon|meeting> bawolff: Yeah I know...I keep wanting to review some others but I can't :) [22:14:50] (03PS1) 10EBernhardson: Expose more information about BasicDbStorage queries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98010 [22:16:54] (03CR) 10BryanDavis: [C: 031] "I'll +2 if Siebrand agrees that his concerns from Patch Set 4 have been addressed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [22:17:26] (03PS1) 10EBernhardson: Repair for redlinks patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98012 [22:19:57] i am trying to set up my git review, and am following https://www.mediawiki.org/wiki/Gerrit/Tutorial#Installing_git-review [22:20:09] but i get [22:20:11] The following command failed with exit code 1 [22:20:11] "scp gerrit.wikimedia.org:hooks/commit-msg .git/hooks/commit-msg" [22:20:11] ----------------------- [22:20:11] .git/hooks/commit-msg: No such file or directory [22:20:11] ----------------------- [22:20:16] on git review -s [22:20:26] anyone an idea? [22:21:12] <^demon|meeting> Are you on a submodule? [22:22:52] might be... I am working on pywikipedia core... [22:23:07] (03PS1) 10Aklapper: [4.4] Sync index frontpage with upstream changes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98013 [22:23:58] <^demon|meeting> dennyvrandecic: So, .git/hooks doesn't exist on a submodule (usually). [22:24:11] <^demon|meeting> It's usually going to be in the parent repo's .git/modules/* somewhere. [22:24:23] <^demon|meeting> (git-review doesn't know about submodules, and explodes as you saw) [22:24:33] i do have a .git/hooks directory though [22:24:59] i am wondering if i tried to clone from github and now trying to push to gerrit... [22:25:56] (03CR) 10Tim Starling: [C: 032] "I assumed it wasn't necessary, but bundled PHP extensions do generally use RETURN_FALSE after throwing an exception." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97936 (owner: 10Anomie) [22:26:02] (03PS2) 10EBernhardson: Repair for redlinks patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98012 [22:26:24] (03Merged) 10jenkins-bot: RETURN_FALSE instead of return in some methods [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97936 (owner: 10Anomie) [22:27:27] yeah, that looks like it. thanks for the help ^demon|meeting [22:27:36] <^demon|meeting> you're welcome [22:30:06] (03PS1) 10EBernhardson: topic-history action, used in topic.html.php, did not exist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98015 [22:31:47] (03CR) 10EBernhardson: [C: 032] Weird timestamp display in both topic and board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97873 (owner: 10Bsitu) [22:31:49] (03CR) 10jenkins-bot: [V: 04-1] Weird timestamp display in both topic and board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97873 (owner: 10Bsitu) [22:33:36] (03PS2) 10EBernhardson: Weird timestamp display in both topic and board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97873 (owner: 10Bsitu) [22:33:50] (03CR) 10EBernhardson: "PS2: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97873 (owner: 10Bsitu) [22:33:56] (03CR) 10EBernhardson: [C: 032] Weird timestamp display in both topic and board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97873 (owner: 10Bsitu) [22:34:06] (03Merged) 10jenkins-bot: Weird timestamp display in both topic and board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97873 (owner: 10Bsitu) [22:36:10] (03CR) 10Jdlrobson: New API for selecting a task; related refactoring and minor fm (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [22:39:07] (03CR) 10Mattflaschen: [C: 032] Add some phpdocs for IDEs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 (owner: 10Addshore) [22:39:38] (03Merged) 10jenkins-bot: Add some phpdocs for IDEs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 (owner: 10Addshore) [22:39:46] marktraceur: oh [22:39:55] marktraceur: I forgot to do the commit [22:40:01] Heh, it's OK [22:40:39] marktraceur: so I'll go into the directory and use git review [22:40:58] (03CR) 10Bsitu: [C: 032] Repair for redlinks patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98012 (owner: 10EBernhardson) [22:41:08] (03Merged) 10jenkins-bot: Repair for redlinks patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98012 (owner: 10EBernhardson) [22:42:06] (03CR) 10Tim Starling: [C: 031] "I've reviewed it, and I'm fine with it being merged as it is. make test is a test. But suit yourself." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/97931 (owner: 10Cscott) [22:42:44] vandrew: Correct [22:42:50] (03CR) 10Mattflaschen: "Replied inline." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 (owner: 10Mattflaschen) [22:44:31] (03CR) 10Bsitu: [C: 032] topic-history action, used in topic.html.php, did not exist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98015 (owner: 10EBernhardson) [22:44:47] (03Merged) 10jenkins-bot: topic-history action, used in topic.html.php, did not exist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98015 (owner: 10EBernhardson) [22:45:13] hey siebrand, did you happen to see the update to https://gerrit.wikimedia.org/r/#/c/97369/? you had placed some comments in ps4, ps10 reflects changes i made to address your comments [22:46:57] (03CR) 10Tim Starling: [C: 04-1] "80.232.117.120/29 lacks source comment." [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 (owner: 10Dr0ptp4kt) [22:47:57] (03CR) 10Bsitu: [C: 032] Expose more information about BasicDbStorage queries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98010 (owner: 10EBernhardson) [22:48:12] (03Merged) 10jenkins-bot: Expose more information about BasicDbStorage queries [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98010 (owner: 10EBernhardson) [22:48:32] why do I get this error ..?error: failed to push some refs to 'ssh://vldandrew@gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer.git' [22:49:22] vandrew: Did you remember to do git commit ? [22:49:35] Usually that error has more than one line, and the other lines have more details [22:49:51] vandrew: Did you try to use git push? [22:50:06] not yet [22:50:09] You can't, you have to go through gerrit by either using git review or [22:50:28] He's trying git review [22:50:35] vandrew: Did you set up an SSH key on Gerrit? [22:50:44] yes [22:50:47] the first time worked [22:51:20] ah... probably there's someting starting with remote rejected below the error you posted... we need more details ;) [22:54:26] <^demon|meeting> bawolff: I wonder if we can merge the filerepo visibility ones without breaking anything :) [22:54:31] ! [remote rejected] HEAD -> refs/publish/master (no new changes) [22:54:31] derp [22:54:52] ... ? I'm working on another branch [22:54:53] vandrew: That generally means you forgot to do git add, or forgot to do git commit [22:55:26] * bawolff wonders who added the derp wm-bot comment. /me eyes elsie [22:55:41] ^demon|meeting: I don't think it would break anything, but visibility changes are scary [22:55:54] <^demon|meeting> I know right? [22:55:55] <^demon|meeting> :) [22:56:22] <^demon|meeting> Especially when you're making it private/protected when it's currently public. [22:56:48] Like if anything actually depends on that being public, its probably pretty broken, but still... [22:57:43] things that are pretty broken should be fully broken [22:57:44] no? [22:57:54] <^demon|meeting> Can't argue with that logic. [22:58:29] things that are pretty broken should be fully broken but I still don't want them to blame me ;) [22:58:47] <^demon|meeting> I break things for people all the time! [23:00:17] They call him Chad, breaker of things [23:00:31] You break *one thing* [23:00:41] (03PS1) 10Yamelnychuk: Check local duplicates due to $wgNamespacesToConvert Bug 55383 Change-Id: I951f9982de44e02edab4f2409cb9a99542938c0b [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 [23:00:46] heh :D [23:01:29] marktraceur: here https://gerrit.wikimedia.org/r/#/c/98020/ [23:01:51] I saw, I'll review and prod at it [23:01:52] YuviPanda: for some reason grrrit-wm was spitting out lines with a literal \n where the commit message had a newline [23:01:59] when? [23:03:06] marktraceur: that was a nice continuation of yesterday's reference [23:03:06] marktraceur: then I'll go, goodnight [23:03:12] does that count as a running gag now? [23:03:38] apergos: Two incidents does not a running gag make [23:03:42] (03CR) 10Legoktm: [C: 04-1] "Looks good, just a minor code style issue. See the inline comment." (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 (owner: 10Yamelnychuk) [23:03:45] We'll keep it going though [23:03:50] good man [23:03:56] YuviPanda: just now in #pywikipediabot [23:03:57] [02:52:33 PM] (PS3) Denny Vrandecic: allow URLs for sources\n\nChange-Id: I5f65e8ce51fe7f34b66bc8dfaa920209c087055a [pywikibot/core] - https://gerrit.wikimedia.org/r/98018 [23:03:59] You know how I do [23:04:04] hmm [23:04:14] legoktm: can you file a bug? gerrit component. I'm going to sleep in about 5 mins [23:04:17] theoretically [23:05:34] YuviPanda: NO SLEEP, SLEEP IS FOR THE WEAK AND THE DEAD [23:05:44] Or rather [23:05:45] NO [23:05:48] SLEEP [23:05:49] <^demon|meeting> File a gerrit bug? [23:05:51] marktraceur: THE MIND IS WILLING, THE WRISTS ARE WEAK [23:05:51] TIL BROOKLYN! [23:05:57] * ^demon|meeting HIDES, NOW [23:06:05] Is it international caps lock day yet [23:06:10] ^demon|meeting: ugh, I meant grrrit component, but that doesn't exist... [23:06:17] YuviPanda: sure [23:06:20] ^demon|meeting: you can come out now [23:06:22] :P [23:06:23] Argh, October 22nd, I remember being disappointed now [23:06:55] (03CR) 10Bsitu: [C: 032] Increase default topic list load to 10 topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97942 (owner: 10EBernhardson) [23:07:04] (03Merged) 10jenkins-bot: Increase default topic list load to 10 topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97942 (owner: 10EBernhardson) [23:07:49] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=57688 [23:07:57] ty [23:10:11] (03PS2) 10Yamelnychuk: Check local duplicates due to $wgNamespacesToConvert Bug 55383 Change-Id: I951f9982de44e02edab4f2409cb9a99542938c0b [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 [23:10:36] legoktm please review it again [23:11:32] (03PS1) 10BryanDavis: Cleanup DAO layer [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98024 [23:11:39] yamelnychuk: great, I think you missed the second part of my comment though, the global line should go above the $targets = array() line [23:12:28] ah [23:12:56] also in your commit message, it should be 'Bug: ###' <-- with the colon. it makes it automatically searchable then [23:13:14] (03PS1) 10Aklapper: [4.4] Upgrade files to 4.4 and reapply one-liner custom patches [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98025 [23:13:43] (03PS5) 10Dan-nl: sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 [23:13:44] (03CR) 10jenkins-bot: [V: 04-1] sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [23:13:53] (03PS6) 10Dan-nl: sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 [23:15:37] (03CR) 10Dan-nl: "merged changes in https://gerrit.wikimedia.org/r/#/c/97369/10 includes/Specials/SpecialGWToolset.php in order to avoid merge conflict." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [23:15:40] (03PS3) 10Yamelnychuk: Check local duplicates due to $wgNamespacesToConvert Bug:55383 Change-Id: I951f9982de44e02edab4f2409cb9a99542938c0b [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 [23:16:09] (03PS4) 10Legoktm: Check local duplicates due to $wgNamespacesToConvert Bug:55383 Change-Id: I951f9982de44e02edab4f2409cb9a99542938c0b [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 (owner: 10Yamelnychuk) [23:16:10] (03PS5) 10Brian Wolff: Check local duplicates due to $wgNamespacesToConvert [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 (owner: 10Yamelnychuk) [23:16:17] bawolff: heh. [23:16:21] lol [23:16:33] hey siebrand trying finish up a chain of commits. just need your approval on https://gerrit.wikimedia.org/r/#/c/97369/ [23:16:35] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 (owner: 10Yamelnychuk) [23:16:42] (03Merged) 10jenkins-bot: Check local duplicates due to $wgNamespacesToConvert [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/98021 (owner: 10Yamelnychuk) [23:16:56] yamelnychuk: thanks! [23:17:17] can you claim task as closed? [23:17:25] (03PS1) 10EBernhardson: Don't attempt to fix redlinks in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/98027 [23:17:44] yamelnychuk: i think you have to add a link to the gerrit patch before I can do that. [23:18:01] done [23:18:44] closed :D [23:21:20] (03PS2) 10BryanDavis: Cleanup DAO layer [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98024 [23:23:03] (03PS5) 10Dr0ptp4kt: Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 [23:26:18] (03PS1) 10Aklapper: [4.4] Sync with upstream 4.4 [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98028 [23:34:47] (03CR) 10BryanDavis: Cleanup DAO layer (036 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/98024 (owner: 10BryanDavis) [23:42:36] dr0ptp4kt: are you not reading my comments or something? [23:44:02] TimStarling, . hang on [23:44:50] (03PS1) 10Aklapper: [4.4] Sync MoreBugUrl extension with upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98031 [23:45:00] the comment at the start of the section says that the range comes from net-changes-mini, which is obviously not true [23:47:55] that was previously in the section that had it labeled as such. however, your comment on ps4 was referring to a completely different subnet, the testing one. i'll update the comment there. [23:48:13] (see email) [23:48:28] TimStarling, does that make sense? [23:49:04] (03PS1) 10Aklapper: [4.4] Sync custom file with upstream 4.4 and reapply custom patch [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/98032 [23:49:17] (03PS1) 10Yurik: Added "git-update" command [vagrant] - 10https://gerrit.wikimedia.org/r/98033 [23:50:42] on PS3 I wrote "Where did this range come from? It was not in the last net-changes-mini post." on line 559 in the new file [23:50:53] that line was [23:50:54] +80.232.117.120/29 [23:51:11] on PS4 I wrote "80.232.117.120/29 lacks source comment." [23:51:23] which is the same range [23:51:55] that was me trying to tell you that my comment on PS3 was unresolved [23:52:15] TimeStarling, yeah, i get it, sorry about that. one minute. [23:53:06] (03PS6) 10Dr0ptp4kt: Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 [23:53:23] ^TimStarling, i /believe/ that does it. [23:54:13] yep, that's what I was looking for [23:54:24] (03CR) 10Tim Starling: [C: 032] Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 (owner: 10Dr0ptp4kt) [23:54:25] (03Merged) 10jenkins-bot: Updates for OM. [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/97874 (owner: 10Dr0ptp4kt) [23:54:36] TimStarling, thx, and apologies again! [23:55:19] do you need this backported and deployed immediately? [23:56:19] i'll leave the timing to you on the backport. [23:56:26] no rush on deployment for current branch [23:57:05] argh [23:57:30] is that a problem? [23:57:54] no, unrelated argh [23:58:28] alright, i'm gonna walk some stuff back to my apartment and hop online there. ttyl