[00:03:55] (03PS1) 10BryanDavis: Use ISO 3166-1 alpha-2 country codes [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97654 [00:08:48] (03CR) 10BryanDavis: Use ISO 3166-1 alpha-2 country codes (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97654 (owner: 10BryanDavis) [00:13:09] (03CR) 10BryanDavis: [C: 032] "Self-merge!" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97650 (owner: 10BryanDavis) [00:16:23] (03CR) 10BryanDavis: [V: 032] "Self-verify! No Zuul integration here yet apparently." [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97650 (owner: 10BryanDavis) [00:27:12] (03CR) 10Mattflaschen: [C: 04-1] "There are a few small things. See inline." (034 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [00:36:37] (03CR) 10Bsitu: [C: 032] Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [00:36:56] (03Merged) 10jenkins-bot: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [00:43:53] TimStarling: is it worth adding a new global for the shared repo wiki or is just assume it is $wgGlobalUsageDatabase good enough? [00:44:09] I suppose in theory it could be some other DB nothing else uses [00:44:32] what shared repo? [00:44:37] commons [00:46:40] just reading GlobalUsage again... [00:48:55] * AaronSchulz was thinking $wgGlobalUsageSharedRepoWiki [00:50:19] right, so globalimagelinks doesn't record which repo the image is actually in [00:53:18] ok, and the implementation of GlobalUsageHooks::onLinksUpdateComplete() is potentially inefficient, it relies on the RepoGroup cache [00:53:55] hmm, no it doesn't [00:54:47] it calls LocalRepo::findFile(), which doesn't have an in-process cache [00:55:10] (03CR) 10Werdna: "I'm going to do the merge myself, and tidy up both of them." [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [00:55:31] rel = { 'top': eld.rect.top - ( scd.rect.top + scd.borders.top ), [00:55:33] hmph [00:55:45] so it really is inefficient [00:56:05] can we write relativePosition = { top : elementDimensions.top - scrollableDimensions etc etc instead? [00:56:11] really, those extra keystrokes aren't saving much time. [00:56:55] especially when I have to read it. [00:57:00] right [00:57:11] anyway, what you're saying is that it currently lacks the assumption that global images are in a particular wiki, and you want to add that assumption in order to fix bug 22390 [00:57:13] I resisted the urge to play around with that now [00:57:48] if LocalRepo actually override findFiles() it could return a FileArray thing and that could be used [00:57:54] that would spam far less queries [00:58:24] or just MappedIterator, whatever [00:59:34] how will your fix for bug 22390 work, exactly? [01:00:22] the imagelink tables still have the links in addition to the global one, so pushing htmlcacheupdate jobs to wikis with 1+ backlinks to a file (using the global table for that query) should work [01:00:57] so why do you need the global wiki name for that? [01:01:23] just for if ($wgGlobalUsageSharedRepoWiki == wfWikiId()) ... [01:01:25] Hi. Can someone recommend a way to get all aliases and possible translations for a given namespace, for instance NS_FILE? [01:01:27] when a file changes you don't want to trigger jobs on non-commons [01:01:35] I would like to get, "File", "Plik", etc. [01:01:36] yeah, checks like that [01:02:38] and presumably $wgGlobalUsageSharedRepoWiki = false; would disable the feature [01:03:02] well, I also have $wgGlobalUsagePurgeBacklinks [01:03:10] right [01:03:35] ok, I guess it is good enough [01:04:55] ideally I would like to have the repo name in the ParserOutput, so that it would be available to GlobalUsageHooks::onLinksUpdateComplete() without any overhead [01:05:18] and then a new field could be added to globalimagelinks, storing the repo name [01:06:00] and then you could have some sort of map from repo name to wiki name [01:06:12] then it would theoretically work with multiple shared repos [01:06:43] e.g. a multi-wiki site might have both InstantCommons and a shared repository [01:08:52] you know, just using wfFindFile()->getRepo() would be more efficient than what is there, and probably more accurate [01:09:01] because it would use the RepoGroup in-process cache [01:11:05] (03PS1) 10Aaron Schulz: Added support for purging backlinks in the wiki farm [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 [01:12:04] (03PS1) 10Aaron Schulz: Removed check for global that was removed from core [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97660 [01:13:35] gah, since findFiles() is defined as returning an array, I guess that's tricky to make reasonable without breaking the interface [02:51:46] (03PS1) 10Chad: Don't lie about what function makes a query [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/97668 [02:53:46] (03PS1) 10Chad: Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 [02:53:54] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 (owner: 10Chad) [02:54:37] <^d> What do you mean it won't merge? [02:54:42] <^d> Jenkins you lie. [02:55:00] <^d> Fine, I'll rebase :p [02:55:01] (03PS2) 10Chad: Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 [02:56:41] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 (owner: 10Chad) [03:00:04] (03PS3) 10Chad: Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 [03:01:12] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 (owner: 10Chad) [03:02:56] (03PS4) 10Chad: Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 [03:05:22] (03PS1) 10MarkAHershberger: Move reference to $row where it is in-scope and doesn't produce E_STRICT notices. [core] - 10https://gerrit.wikimedia.org/r/97670 [03:08:27] (03CR) 10Chad: [C: 04-1] "Should rebase so this doesn't depend on the current parent." [core] - 10https://gerrit.wikimedia.org/r/97670 (owner: 10MarkAHershberger) [03:08:46] (03PS2) 10MarkAHershberger: Move reference to $row where it is in-scope and doesn't produce E_STRICT notices. [core] - 10https://gerrit.wikimedia.org/r/97670 [03:11:34] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialPage::execute() abstract, deprecate $function and $file params [core] - 10https://gerrit.wikimedia.org/r/97669 (owner: 10Chad) [03:11:48] ^d: thanks for the quick review. Caught the problem at the same time and think I got it fixed. Let me know if not. [03:12:37] <^d> Yeah it looks fine now. [03:12:48] :) [03:16:04] <^d> Ok, so only one minor nit but otherwise ok. [03:16:07] <^d> Since we're now calling getBatchCondition() potentially 10k times instead of once, let's pass $dbw to it rather than calling getDB() a bajillion times. [03:17:01] <^d> Make sense? [03:17:03] that's the sort of thing I wasn't sure about. Glad you pointed that out [03:19:21] (03PS3) 10MarkAHershberger: Move reference to $row where it is in-scope and doesn't produce E_STRICT notices. [core] - 10https://gerrit.wikimedia.org/r/97670 [03:20:59] (03CR) 10Chad: [C: 032] Move reference to $row where it is in-scope and doesn't produce E_STRICT notices. [core] - 10https://gerrit.wikimedia.org/r/97670 (owner: 10MarkAHershberger) [03:32:46] could wm-bot have a wikidata backend?:p [04:17:25] (03PS2) 10Aaron Schulz: Added support for purging backlinks in the wiki farm [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 [04:49:59] (03PS1) 10Dan-nl: sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 [04:50:35] (03PS2) 10Dan-nl: sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 [05:06:31] (03PS2) 10Werdna: CSS transitions for timestamp hovers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97535 (owner: 10EBernhardson) [05:08:44] (03CR) 10Werdna: [C: 032] "PS2: Killed trailing whitespace." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97535 (owner: 10EBernhardson) [05:08:57] (03Merged) 10jenkins-bot: CSS transitions for timestamp hovers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97535 (owner: 10EBernhardson) [05:15:49] (03CR) 10Werdna: [C: 032] CSS transitions for post creator/tool links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97534 (owner: 10EBernhardson) [05:15:58] (03CR) 10jenkins-bot: [V: 04-1] CSS transitions for post creator/tool links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97534 (owner: 10EBernhardson) [05:19:00] (03PS2) 10Werdna: CSS transitions for post creator/tool links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97534 (owner: 10EBernhardson) [05:20:09] (03CR) 10Werdna: [C: 032] "PS2 is a rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97534 (owner: 10EBernhardson) [05:20:20] (03Merged) 10jenkins-bot: CSS transitions for post creator/tool links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97534 (owner: 10EBernhardson) [05:23:06] (03CR) 10Werdna: "Let me take a proper look at it and I'll let you know." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91348 (owner: 10Werdna) [06:09:02] (03CR) 10JGonera: [C: 032] mediawiki.ui: Ensure that buttons and inputs are vertically aligned [core] - 10https://gerrit.wikimedia.org/r/95361 (owner: 10Bartosz Dziewoński) [06:12:18] (03Merged) 10jenkins-bot: mediawiki.ui: Ensure that buttons and inputs are vertically aligned [core] - 10https://gerrit.wikimedia.org/r/95361 (owner: 10Bartosz Dziewoński) [06:45:11] (03PS4) 10Werdna: [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 [06:47:20] (03CR) 10Werdna: "PS4: Address Matthias' comments." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [06:49:20] (03CR) 10Werdna: [C: 032] Add topic moderation log i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97529 (owner: 10Matthias Mullie) [06:49:30] (03Merged) 10jenkins-bot: Add topic moderation log i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97529 (owner: 10Matthias Mullie) [06:50:39] (03CR) 10Werdna: [C: 032] Get rid of unused $wgFlowTokenSalt [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97520 (owner: 10Matthias Mullie) [06:50:49] (03Merged) 10jenkins-bot: Get rid of unused $wgFlowTokenSalt [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97520 (owner: 10Matthias Mullie) [06:53:32] (03CR) 10Werdna: "Be[rn]nie, have you guys settled on this? Should I review it?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [06:56:57] (03CR) 10Werdna: "If I could +2 your last comment, I would." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 (owner: 10Matthias Mullie) [06:57:35] (03CR) 10EBernhardson: [C: 04-1] "I think going to go with bennys latest suggestion, onTransactionIdle, i havn't had time for the refactor yet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [07:08:39] (03PS2) 10Aaron Schulz: Update documentation for job related classes [core] - 10https://gerrit.wikimedia.org/r/97532 (owner: 10Siebrand) [07:13:00] (03CR) 10Aaron Schulz: Update documentation for job related classes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97532 (owner: 10Siebrand) [07:14:13] (03PS3) 10Aaron Schulz: Added support for purging backlinks in the wiki farm [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97659 [07:39:17] (03CR) 10Siebrand: Update documentation for job related classes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97532 (owner: 10Siebrand) [07:41:29] (03PS3) 10Siebrand: Update documentation for job related classes [core] - 10https://gerrit.wikimedia.org/r/97532 [08:31:58] (03PS1) 10Mattflaschen: New API for selecting a task; related refactoring and minor fm [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97691 [08:50:23] (03PS1) 10Hiong3-eng5: Tags [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/97692 [09:04:27] \j mediawiki-parsoid [09:04:34] \join mediawiki-parsoid [09:08:03] (03CR) 10Hashar: [C: 04-1] "I don't mind stripping the underscore from class names, but I would like the upgrade to be as transparent as possible to the user." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [09:19:09] (03PS1) 10Pastakhov: fix some architectural issues [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97696 [09:20:23] (03CR) 10Hashar: "> @Antoine: Can you please have a look at this and see if it's something that can be fixed in CodeSniffer?" [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [09:22:03] (03CR) 10Pastakhov: [C: 032] fix some architectural issues [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97696 (owner: 10Pastakhov) [09:22:23] (03Merged) 10jenkins-bot: fix some architectural issues [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97696 (owner: 10Pastakhov) [09:38:34] (03CR) 10Tpt: ""Perhaps, for Wikibase, getPageContentLanguage and getPageViewContentLanguage should both be based on the *user's* language, one with and " [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [10:06:36] (03PS1) 10MaxSem: Fix fatal in ParserCache::getKey() [core] - 10https://gerrit.wikimedia.org/r/97704 [10:13:08] (03CR) 10Hashar: "That would still leave the invalid key in the cache. Would it make sense to look at the serialized data, log a wgDebugLogGroup entry abou" [core] - 10https://gerrit.wikimedia.org/r/97704 (owner: 10MaxSem) [10:17:25] (03CR) 10Amire80: [C: 032] Added links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/96023 (owner: 10Zfilipin) [10:17:29] (03Merged) 10jenkins-bot: Added links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/96023 (owner: 10Zfilipin) [10:21:34] !logs [10:21:34] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [10:26:53] MaxSem: if you are around, beta still has a "deployment-solr" instance, not sure whether it is still used. [10:27:05] MaxSem: noticed you deleted the deployment-solr2 instance already [10:27:25] hashar, it is:) [10:27:37] solr2 was to investigate an issue [10:27:41] okkk [10:50:46] (03PS1) 10Aude: Get date in EnhancedChangesList::recentChangesLine from baseRC [core] - 10https://gerrit.wikimedia.org/r/97707 [10:52:09] (03CR) 10Aude: "passes tests when rebased against Ia6a371d" [core] - 10https://gerrit.wikimedia.org/r/97707 (owner: 10Aude) [10:59:08] (03PS1) 10Pastakhov: fix for double arrays in encapsed string [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97709 [11:00:03] (03CR) 10Pastakhov: [C: 032] fix for double arrays in encapsed string [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97709 (owner: 10Pastakhov) [11:00:10] (03Merged) 10jenkins-bot: fix for double arrays in encapsed string [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/97709 (owner: 10Pastakhov) [11:08:32] (03PS13) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [11:09:06] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [11:38:08] (03PS1) 10Aude: Create cachedEntry after processing change block [core] - 10https://gerrit.wikimedia.org/r/97723 [11:39:03] (03CR) 10Aude: "this also passes tests when rebased against Ia6a371d" [core] - 10https://gerrit.wikimedia.org/r/97723 (owner: 10Aude) [11:47:11] (03PS1) 10Hashar: tweak phpunit-junit macros [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97725 [11:47:13] (03PS1) 10Hashar: phpunit job + wikimedia/wikimania-scholarships [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97726 [11:47:22] (03CR) 10Hashar: [C: 032] tweak phpunit-junit macros [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97725 (owner: 10Hashar) [11:47:29] (03CR) 10Hashar: [C: 032] phpunit job + wikimedia/wikimania-scholarships [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97726 (owner: 10Hashar) [11:48:05] (03Merged) 10jenkins-bot: tweak phpunit-junit macros [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97725 (owner: 10Hashar) [11:48:21] (03Merged) 10jenkins-bot: phpunit job + wikimedia/wikimania-scholarships [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97726 (owner: 10Hashar) [11:52:18] (03PS1) 10Hashar: triggers for wikimedia/wikimania-scholarships [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97727 [11:52:33] (03CR) 10Thaiphan: "I would be interested in updating this functionality back to a functioning state. I host my MediaWiki installation on Windows Azure (it's " [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [11:53:04] (03CR) 10Hashar: [C: 032] triggers for wikimedia/wikimania-scholarships [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97727 (owner: 10Hashar) [11:53:12] (03Merged) 10jenkins-bot: triggers for wikimedia/wikimania-scholarships [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97727 (owner: 10Hashar) [11:54:30] yay scholarships! [11:54:33] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97728 [11:54:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97728 (owner: 10Hashar) [11:57:43] greg-g: Umm… why have you scheduled Roan's deployment of VisualEditor config on Monday to be done by Gabriel later in the day, at the same time as his Parsoid deployment? I was expecting it earlier (normally we go at ~ 10:00). Did gwicke_away say it needed to go out together? [11:58:44] (03PS2) 10Matthias Mullie: Add setChildren() & setDepth() in loadTopicTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 [11:58:56] (03CR) 10Matthias Mullie: Add setChildren() & setDepth() in loadTopicTitle (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 (owner: 10Matthias Mullie) [11:59:53] (03PS1) 10Hashar: phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97729 [12:00:40] (03PS2) 10Hashar: phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97729 [12:00:49] (03CR) 10Hashar: [C: 032] phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97729 (owner: 10Hashar) [12:01:14] (03Merged) 10jenkins-bot: phpunit-junit builder missed full path to phpunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97729 (owner: 10Hashar) [12:03:06] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97728 (owner: 10Hashar) [12:03:27] (03CR) 10Darkdadaah: [C: 032 V: 032] No format for lists [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/97146 (owner: 10Darkdadaah) [12:07:51] (03CR) 10Krinkle: Display nested exception backtrace's (031 comment) [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [12:08:27] (03CR) 10Matthias Mullie: [C: 032] [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [12:08:29] (03CR) 10jenkins-bot: [V: 04-1] [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [12:10:02] (03PS5) 10Matthias Mullie: [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [12:10:28] (03CR) 10Matthias Mullie: [C: 032] [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [12:10:39] (03Merged) 10jenkins-bot: [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [12:11:54] (03PS1) 10Hashar: jshint configuration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97730 [12:11:55] (03PS1) 10Hashar: schol.js: pass jshint [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97731 [12:12:50] (03CR) 10Siebrand: "I reported https://bugzilla.wikimedia.org/57585" [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [12:15:38] (03CR) 10Hashar: "jshint job is passing :-]" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97731 (owner: 10Hashar) [12:17:50] lunch break [12:28:30] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 (owner: 10Jackmcbarn) [12:28:59] (03CR) 10Siebrand: [C: 032] i18n: capitalize URL [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97649 (owner: 10Shirayuki) [12:29:03] (03Merged) 10jenkins-bot: i18n: capitalize URL [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97649 (owner: 10Shirayuki) [12:31:30] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [12:34:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (owner: 10Legoktm) [12:37:47] (03PS2) 10Siebrand: Consistency tweak: Url -> URL [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97549 (owner: 10Raimond Spekking) [12:38:00] (03Abandoned) 10Siebrand: Consistency tweak: Url -> URL [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97549 (owner: 10Raimond Spekking) [12:40:34] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97521 (owner: 10Dan-nl) [12:43:12] (03CR) 10Werdna: [C: 031] "Looks okay, but then again I've had a few glasses of wine so I'll leave it till tomorrow to +2." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 (owner: 10Matthias Mullie) [12:45:08] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. One small L10n issue remaining." (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [12:48:16] (03CR) 10Siebrand: Update formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97098 (owner: 10Siebrand) [12:48:42] (03PS2) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/97098 [12:51:05] (03PS3) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/97098 [13:16:03] (03PS4) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/97098 [13:16:56] (03CR) 10Hashar: [C: 032] Update formatting of externalstore classes [core] - 10https://gerrit.wikimedia.org/r/97098 (owner: 10Siebrand) [13:17:55] (03CR) 10jenkins-bot: [V: 04-1] Update formatting of externalstore classes [core] - 10https://gerrit.wikimedia.org/r/97098 (owner: 10Siebrand) [13:21:14] (03Merged) 10jenkins-bot: Update formatting of externalstore classes [core] - 10https://gerrit.wikimedia.org/r/97098 (owner: 10Siebrand) [13:26:05] (03PS1) 10Amire80: Simplify interlanguage links creation by early return [core] - 10https://gerrit.wikimedia.org/r/97737 [13:27:08] (03PS2) 10Amire80: Simplify interlanguage links creation by early return [core] - 10https://gerrit.wikimedia.org/r/97737 [13:33:43] (03PS2) 10Addshore: Add some phpdocs for IDEs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 [13:34:11] (03PS3) 10Addshore: Add some phpdocs for IDEs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 [13:35:07] (03Abandoned) 10Hashar: pipelines.test: Change from Verified+2 to Verified+1 [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/61720 (owner: 10Krinkle) [13:37:44] (03Abandoned) 10Hashar: experimental breadcrumb display [integration/docroot] - 10https://gerrit.wikimedia.org/r/68343 (owner: 10Hashar) [13:38:03] (03Abandoned) 10Hashar: experimental HTML console publishing [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/74424 (owner: 10Hashar) [13:38:10] (03Abandoned) 10Hashar: publish-console.py script [integration/jenkins] - 10https://gerrit.wikimedia.org/r/75637 (owner: 10Hashar) [13:38:50] (03PS2) 10Addshore: Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 [13:38:58] (03CR) 10Addshore: "PS2 is rebase" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore) [13:40:36] (03PS2) 10Hashar: Actually trigger mwext-MobileFrontend-phpcs-HEAD . [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94239 (owner: 10JanZerebecki) [13:40:52] (03CR) 10Hashar: [C: 032] "sorry , I have been long to visit this change." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94239 (owner: 10JanZerebecki) [13:40:58] (03Merged) 10jenkins-bot: Actually trigger mwext-MobileFrontend-phpcs-HEAD . [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94239 (owner: 10JanZerebecki) [13:42:29] (03CR) 10Bartosz Dziewoński: [C: 032] "Shouldn't break anything." [core] - 10https://gerrit.wikimedia.org/r/97723 (owner: 10Aude) [13:42:44] (03CR) 10Bartosz Dziewoński: [C: 032] "Shouldn't break." [core] - 10https://gerrit.wikimedia.org/r/97707 (owner: 10Aude) [13:43:16] (03PS3) 10Addshore: Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 [13:44:27] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94239 (owner: 10JanZerebecki) [13:45:45] (03CR) 10Gergő Tisza: [C: 04-1] "This seems very brittle. What if one of the parameters has a , or ; in it?" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [13:46:02] (03PS4) 10Hashar: Only run linting and not tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [13:47:07] (03CR) 10Hashar: [C: 032] "That is a pity, makes the WMF Jenkins useless so you might as well disable all jobs." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [13:47:36] (03CR) 10Aude: [C: 04-1] "I would like to split up some of the formatting code first, and then we can have tests for that specifically and tests here that cover mor" [core] - 10https://gerrit.wikimedia.org/r/93611 (owner: 10Aude) [13:48:54] (03Merged) 10jenkins-bot: Create cachedEntry after processing change block [core] - 10https://gerrit.wikimedia.org/r/97723 (owner: 10Aude) [13:48:55] (03Merged) 10jenkins-bot: Get date in EnhancedChangesList::recentChangesLine from baseRC [core] - 10https://gerrit.wikimedia.org/r/97707 (owner: 10Aude) [13:48:59] (03Merged) 10jenkins-bot: Only run linting and not tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [14:01:47] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [14:23:52] (03CR) 10MarkAHershberger: "Thaiphan, I'll contact you via email. We weren't able to find any public MSSQL wikis." [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [14:34:59] (03PS1) 10Cscott: Improve status reporting. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97740 [14:36:06] (03CR) 10Anomie: Display nested exception backtrace's (031 comment) [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [14:46:43] (03PS12) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [14:46:55] (03CR) 10Hashar: "rebased" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 (owner: 10Hashar) [14:48:53] (03PS13) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [14:49:18] (03CR) 10Hashar: "+ MobileFrontend" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 (owner: 10Hashar) [14:49:41] (03PS14) 10Hashar: browsertests for some extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [14:50:00] (03CR) 10Hashar: [C: 032] "lets unleash them. deployed!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 (owner: 10Hashar) [14:50:22] (03Merged) 10jenkins-bot: browsertests for some extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 (owner: 10Hashar) [14:54:40] (03PS1) 10Hashar: ULS browsertests on check pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97741 [14:55:33] (03CR) 10Hashar: [C: 032] "deploying" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97741 (owner: 10Hashar) [14:55:42] (03PS1) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [14:55:43] (03Merged) 10jenkins-bot: ULS browsertests on check pipeline [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97741 (owner: 10Hashar) [14:56:58] (03CR) 10Aude: [C: 04-1] "tests pass when rebased against Ia6a371dd" [core] - 10https://gerrit.wikimedia.org/r/97742 (owner: 10Aude) [15:10:27] !g Ib055f5470886e1b818d4c53cb4c61a751d81e154 [15:10:27] https://gerrit.wikimedia.org/r/#q,Ib055f5470886e1b818d4c53cb4c61a751d81e154,n,z [15:11:25] Rtdwivedi: I would like to ask some questions regarding my current task. [15:18:18] (03PS2) 10Umherirrender: Fix StatusTest for wikis with $wgContentLanguage != 'en' [core] - 10https://gerrit.wikimedia.org/r/97554 [15:20:24] (03CR) 10Poke: [C: 031] "This cleanup looks good to me." [core] - 10https://gerrit.wikimedia.org/r/97373 (owner: 10Siebrand) [15:23:40] Rtdwivedi: Please send me a message when you have time. [15:26:46] (03CR) 10Aude: [C: 031] "verified, this fixes the issue" [core] - 10https://gerrit.wikimedia.org/r/97554 (owner: 10Umherirrender) [15:36:09] James_F: a mistake [15:36:15] greg-g: Ah, right. [15:36:32] greg-g: And what about timing? [15:38:58] fixed [15:39:03] 14:00 pacific [15:39:11] James_F: ^ [15:39:15] * greg-g goes [15:39:34] greg-g: Ah. Boo. :-( [15:39:37] greg-g: See you. [15:41:10] vandrew: I am here now. [15:43:01] (03CR) 10BryanDavis: [C: 031] schol.js: pass jshint (031 comment) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97731 (owner: 10Hashar) [15:43:12] bd808|BUFFER: \O/ [15:43:22] (03CR) 10BryanDavis: [C: 031] jshint configuration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97730 (owner: 10Hashar) [15:43:48] bd808|BUFFER: whenever they get merged we can make the jslint job to be voting in integration/zuul-config.git [15:43:55] Rtdwivedi: Hey, I have a few question regarding the Unify ProofreadPage extension documentation task [15:44:13] Hi. :-) [15:44:27] vandrew: Ask away. [15:44:51] Rtdwivedi: First of all, there are 4 pages to merge yes? [15:45:06] hashar: I apparently had never even looked at the js files in that project. :( [15:45:43] I just moved them into a new directory and marched on [15:46:04] 4 pages, yes. [15:46:41] Rtdwivedi: Where should be these pages merged to ? Should I make a new wikipage ? [15:47:51] vandrew: Yes, on a new wikipage. Preferably like mediawiki.org/wiki/something . [15:49:12] Rtdwivedi: Oh, sorry pressed some buttons and left the channel. [15:49:22] vandrew_: Yes, on a new wikipage. Preferably like mediawiki.org/wiki/something . [15:49:28] no problem. :-) [15:50:03] Rtdwivedi:And I'll have to take the most important informations only yes ? [15:50:51] vandrew_: Yes. But it should be sufficient enough to cover everything. I mean, if somebody reads just your page, they should be good to proceed further. [15:51:28] Rtdwivedi: I see. [15:51:37] Rtdwivedi: Thank you for the help [15:52:26] vandrew_: I signed up for this. :P :) [15:52:38] yep [15:54:21] bd808: it is fine. there is only a few lines of js anyway. [15:54:29] bd808: but better have jshint whine while it is easy to fix :-] [15:54:51] hashar: For sure. Same with the php code style [15:55:26] bd808: that one is a huge tech debt :D siebrand is fixing a bunch of php style issues in core [15:55:41] bd808: for extensions, I got to update them all to use some new jobs (a strict one and a more laxist one) [15:55:42] Rtdwivedi:this said, I'll use this page https://wikisource.org/wiki/Proofreadhelp [15:56:07] vandrew_: Sure. Thanks! [16:03:35] (03PS1) 10Cscott: Switch from Gentium to Charis for Latin/Cyrillic text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97747 [16:19:48] TimStarling: ping [16:20:25] * bd808 hopes Tim is sleeping [16:20:26] TimStarling: Hi, David Chan (WMF) is trying to get Scribunto + lua to work locally on an Ubuntu machine. I did a plain install on my Mac and it works straight away, he's getting an error though. [16:20:34] Hm.. indeed [16:20:37] no Tim-away though [16:20:48] True enough [16:21:41] what kind of error ? [16:24:43] and how did he install it? [16:27:45] divec: ^ [16:27:55] thedj[work]: All he got is "Script error" and "Module not found" [16:28:00] (03CR) 10Aaron Schulz: [C: 032] Set visibility on class properties of ArchivedFile [core] - 10https://gerrit.wikimedia.org/r/97368 (owner: 10Siebrand) [16:29:06] $wgScribuntoEngineConf['luastandalone']['errorFile'] = [16:29:06] '/var/log/luaerror.log'; [16:29:19] (03CR) 10Aaron Schulz: [C: 032] Update documentation for job related classes [core] - 10https://gerrit.wikimedia.org/r/97532 (owner: 10Siebrand) [16:29:24] adding that will probably tell you more [16:33:05] (03Merged) 10jenkins-bot: Update documentation for job related classes [core] - 10https://gerrit.wikimedia.org/r/97532 (owner: 10Siebrand) [16:34:19] yuvipanda: Thought: If there are inline comments on a CR message, and no normal-message, maybe it would be better to print the first bit of a comment and link to the first file diff from grrrit-wm [16:34:46] marktraceur: problem with that is that it requires a HTTP request to get the inline comment data [16:34:51] not exposed through the stream [16:35:10] I simply built a PHP lua module [16:35:37] marktraceur: it's not that hard to do, just the network request had me balking, because it'll delay the post [16:35:41] not by a lot, though [16:35:48] was relatively easy - except for ph5-debug which had to be uninstalled afterwards because it kept crashing PHP [16:35:52] so go for it if you want to. would be highly useful [16:36:24] yuvipanda: Wait, I thought the inline comments got sent with the initial event...hrm [16:36:29] (03PS1) 10Matthias Mullie: Change suppression terminology in code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97751 [16:36:30] marktraceur: they don't [16:36:32] (03CR) 10Siebrand: "@hashar As far as I can tell, both issues are addressed in this patch set as those concerns were shared. What exactly would you like to se" [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [16:36:34] that's the problem [16:36:51] But we should make the request anyway, to get the message (in the case of a rebase) and to get an accurate commit message [16:36:55] marktraceur: I raised it with gerrit folks and qchris, am not too optimistic [16:37:04] hmm, yeah tyat's a bug [16:37:07] Maybe the queuer should make that request [16:37:20] And put the message in limbo until it has all the information [16:38:03] that could happen too, yeah [16:38:10] though I'd want the queuer to be as simple as possible [16:38:20] It wouldn't be too complicated [16:38:26] It just adds another leg to the journey [16:38:41] true [16:38:47] I'd happily merge if there was a patch :D [16:39:00] recieve event -> make HTTP request -> stick message in limbo; recieve HTTP response -> retrieve message from limbo -> put message in real queue [16:39:03] Sigh [16:39:09] (03PS3) 10Dan-nl: sanitized-exceptions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 [16:39:09] yuvipanda: I might have time on...ah who are we kidding [16:39:13] :P [16:39:20] no need to put it in limbo, just block [16:39:23] not gonna take a long time [16:39:28] it's a in-network call [16:39:31] * marktraceur cringes [16:39:34] Even so [16:39:41] Blocking? In JavaScript? [16:39:48] Didn't your mother teach you better [16:39:55] marktraceur: the queuer is in python :P [16:39:57] (03CR) 10Dan-nl: "- attempting to address Gergő Tisza’s comments is ps2." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [16:40:01] Besides, it's COOLER [16:40:46] marktraceur: it's in labs/gerrit-to-redis [16:41:03] Fun times [16:41:08] I'll check it out [16:41:31] yuvipanda: Wait, is it an HTTP request or an SSH gerrit API request? [16:41:40] marktraceur: http. [16:41:48] the ssh api is deprecated [16:41:52] * marktraceur is puzzled [16:41:53] Oh, huh [16:41:57] Funky [16:42:32] (03PS2) 10Zsaigol: Changed Special:GlobalUsers to inherit from AlphabeticPager, and not use the Special:ListUsers pager as a base class. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 [16:43:15] marktraceur: indeed [16:43:23] git notes doesn't have that info, and you don't want to do that anyway [16:44:27] yuvipanda: Which info? [16:44:36] marktraceur: inline comments, rebase, etc [16:44:42] Ah, yeah [16:44:57] I wasn't talking about using git internals [16:45:18] But stuff like ssh gerrit.wikimedia.org gerrit stream-events [16:45:28] Except more like gerrit query [16:45:31] (03CR) 10Anomie: "https://www.mediawiki.org/wiki/Manual:Hooks/TitleQuickPermissions still needs creating." [core] - 10https://gerrit.wikimedia.org/r/52910 (owner: 10Parent5446) [16:46:22] Our monthly Engineering Community Team Showcase will start in 15 minutes, featuring guillom , andre__ and myself: http://www.youtube.com/watch?v=3YBpFGXX_kI :) [16:47:16] * guillom waves [16:47:29] * addshore goes to watch [16:47:40] guillom, can you please share the URL of the hangout when we start, so I have one thing less to think about? :) [16:47:40] cool, i'm tuning in [16:48:26] oh, sharing https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2013-11-26 will be useful as well [16:48:40] (03CR) 10Zsaigol: "I haven't changed the messages - they could be moved into CentralAuth.i18n.php, but I can see an argument for re-using the core messages t" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [16:48:44] let me edit the schedule to push guillom 's topics forward [16:48:59] (03PS1) 10BryanDavis: Cleanup and fix javascript [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97752 [16:49:02] thanks [16:51:37] (03CR) 10BryanDavis: [C: 032] jshint configuration [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97730 (owner: 10Hashar) [16:53:29] (03CR) 10Aude: [C: 031] Cleanup and fix javascript [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97752 (owner: 10BryanDavis) [16:55:45] marktraceur: How do I tell if zuul is slow vs not setup correctly for a project? [16:56:09] andre__, guillom you should have received an invitation to join the hangout [16:56:16] marktraceur: https://gerrit.wikimedia.org/r/#/c/97730/ looks like it should have merged but ??? [16:57:45] I'll join in a second [16:58:31] andre__, guillom I just shuffled the agenda, please reload https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2013-11-26 [16:58:48] bd808: https://integration.wikimedia.org/ci/job/wikimedia-wikimania-scholarships-jslint/ [16:58:50] thanks! [16:59:05] stuff in build history? [16:59:32] all the jobs: https://integration.wikimedia.org/ci/ [16:59:56] aude: Config for the jslint job says it's non-voting at the moment [17:00:07] * bd808 just merged manually [17:00:07] k [17:00:29] qgil: I don't see an invite [17:00:53] (03CR) 10BryanDavis: [C: 032] schol.js: pass jshint [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97731 (owner: 10Hashar) [17:01:14] oh, sorry, I see it now [17:02:26] hangout starting soon? [17:03:15] ^d: Any idea why zuul wouldn't be merging https://gerrit.wikimedia.org/r/#/c/97731/ ? [17:03:41] <^d> Hmm, let's find out. [17:03:48] * bd808 knows nothing about zuul yet [17:05:33] watching the hangout now... [17:05:42] <^d> bd808: Weird. It did gate-and-submit, just without the submit part. [17:05:56] :) gate and ignore [17:08:27] <^d> Krinkle: You around? [17:18:16] ^d: Yes? [17:20:05] ^d: Zuul/jenkins-bot probably tried but failed because of insufficient permissions [17:20:12] new repo? [17:21:00] Krinkle: Yes. It's new and zuul has never succeeded on it yet [17:21:31] https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia/wikimania-scholarships [17:23:25] bd808: ^d: https://gist.github.com/Krinkle/7662369 [17:23:39] Example: https://gerrit.wikimedia.org/r/#/c/94279/1 [17:24:06] It's hard to do through command-line git / git-review, so if you do it via cli, don't bother trying, ask first :) [17:24:36] If you have permissions to change it yourself, do it via the GUI :) [17:25:14] <^d> Krinkle: Ah, easily fixed :) [17:25:18] otherwise, check these aliases: https://github.com/Krinkle/dotfiles/blob/master/gitconfig#L14-L16, then use "git gerrit-config-co" to check out htat branch, and "git gerrit-config-review" to push to gerrit. [17:25:47] <^d> Granted submit to JenkinsBot. [17:25:59] (yes, the gerrit GUI has a "Push for review" button if you're only allowed to read, but though that works, the interface itself doesn't let you enter username "JenkinsBot" if you're not an admin with write access) [17:26:24] hence, the cli method is required to do it for real [17:26:34] as review that is. [17:26:36] great :) [17:32:11] who would i ping about problems with labs instances? for some reason our instance is reporting /data/project as 'No such file or directory' while its shown on less. Not entirely sure whats up though because /data isn't reported via mount as anything special [17:32:17] s/less/ls [17:32:35] typically that would be some sort of problem with a network drive, but /data isn't reported as a network drive via mount [17:33:13] (03CR) 10Chad: [C: 032] Removed check for global that was removed from core [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97660 (owner: 10Aaron Schulz) [17:33:20] (03Merged) 10jenkins-bot: Removed check for global that was removed from core [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/97660 (owner: 10Aaron Schulz) [17:34:42] ebernhardson: ask in #wikimedia-labs [17:34:49] aude: thanks [17:35:27] (03PS1) 10Mayankmadan: Prefer double-quoted strings in Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/97756 [17:40:50] (03CR) 10Zfilipin: "$ find . -name "*.rb" -exec ruby -wc {} \;" [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [17:41:27] (03PS1) 10Gerrit Patch Uploader: Add local user group membership to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97757 [17:41:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97757 (owner: 10Gerrit Patch Uploader) [17:42:41] (03PS3) 10IAlex: Fix StatusTest for wikis with $wgLanguageCode != 'en' [core] - 10https://gerrit.wikimedia.org/r/97554 (owner: 10Umherirrender) [17:42:47] (03CR) 10IAlex: [C: 032] Fix StatusTest for wikis with $wgLanguageCode != 'en' [core] - 10https://gerrit.wikimedia.org/r/97554 (owner: 10Umherirrender) [17:43:19] :d [17:43:22] :D [17:46:21] (03CR) 10Mwalker: [C: 032] Improve status reporting. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97740 (owner: 10Cscott) [17:46:57] addshore: shall we make jenkins run tests in german? :) [17:47:21] like travis does :D [17:47:26] Natürlich :) [17:47:30] (Of course) [17:47:33] :D [17:47:44] xD [17:47:53] * addshore thinks we should run the tests in all possible languages ;p [17:48:20] I only recently fixed the Qunit's from MobileFrontend to work on non-en wikis... these kind of things are important [17:48:28] indeed [17:49:15] (03CR) 10Mwalker: [C: 032] Switch from Gentium to Charis for Latin/Cyrillic text. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97747 (owner: 10Cscott) [17:50:03] (03Merged) 10jenkins-bot: Fix StatusTest for wikis with $wgLanguageCode != 'en' [core] - 10https://gerrit.wikimedia.org/r/97554 (owner: 10Umherirrender) [17:53:50] (03PS1) 10Cscott: Refactor the metabook-repair code. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97759 [18:04:33] (03PS1) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 [18:08:33] (03CR) 10Jhall: [C: 031] "Looks good!" [selenium] - 10https://gerrit.wikimedia.org/r/97756 (owner: 10Mayankmadan) [18:16:47] (03PS1) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 [18:26:01] (03PS14) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [18:27:58] (03CR) 10AndyRussG: Let instructors and other roles add students (031 comment) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [18:30:26] (03CR) 10Legoktm: Let instructors and other roles add students (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [18:37:29] does wikipedia zero have a channel? [18:37:53] zeljkof: they hang out in -mobile [18:38:01] yuvipanda: thanks [18:38:05] yw [18:42:46] AndyRussG: I filed the bug about non-existent articles in the students table, and even found a way to make it throw a database error in the process. :) [18:43:07] Cool [18:44:22] I was going to say, "Yum, bug report!" but I got sidetracked by Legoktm's review [18:44:30] Thanks [18:45:51] Rtdwivedi: Hey, when you have time I would like to ask you something. [18:46:33] vandrew_: Just give me 15 mins. [18:46:48] Rtdwivedi: take your time ;) [18:49:45] AndyRussG: heh, drive by reviews are the best :P [18:50:38] (03PS1) 10Jackmcbarn: Output hidden fields on pages other than templates [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 [18:51:43] ugh: Apparently no bystanders were harmed... so far [18:52:19] (03PS1) 10Kghbln: Amendend a system message [extensions/SubPageList] - 10https://gerrit.wikimedia.org/r/97766 [18:54:24] (03CR) 10Jhall: [C: 04-1] "This change is a bit too aggressive. This specific change in page_steps.rb:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [18:56:41] qgil: Did you get my message a while back about MMV and UW having easy-keyword bugs that would work for GCI? [18:57:33] qgil: could you please approve this task? https://www.google-melange.com/gci/task/view/google/gci2013/5259991820795904 [18:57:57] (03PS1) 10Chad: Split NS_FILE into its own index type [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 [19:01:25] (03PS2) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 [19:03:28] (03PS6) 10Cmcmahon: new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 [19:04:33] (03PS2) 10Chad: Split NS_FILE into its own index type [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 [19:06:24] vandrew_: I am here. [19:08:12] Rtdwivedi: I've already started to work on the task and I would like to ask you if I am on the right track [19:08:46] ugh: I think your drive-by aim was a bit off ;) Setting needsToken to true makes API test for the existence of a token, not its validity [19:08:51] Rtdwivedi: here is the wiki https://www.mediawiki.org/wiki/Proofreadhelp I'v merged 3 pages and I still have to merge with the advanced users wiki page [19:09:06] * Rtdwivedi is reading vandrew_'s task [19:09:12] (03CR) 10Dan-nl: "- or would you prefer to see the logic outside of the exception class and in the Utils class similar to what you wrote above?" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [19:09:16] Rtdwivedi: Thanks. [19:09:38] If I remove the test for $user->matchEditToken( $params['token']), it dies when there's no token, but not when there's an invalid token [19:09:39] zeljkof, published [19:10:10] hey csteipp, just want to check-in. do you think you'll be able to get to the outstanding gerrit commits today or do you have another day scheduled? [19:10:15] qgil: thanks, we have a really active student, I want to have a few tasks available for him [19:10:56] ugh: https://doc.wikimedia.org/mediawiki-core/master/php/html/ApiBase_8php_source.html, line 2103 [19:11:01] marktraceur, mmm nope, sorry. :? Why don't you become a mentor. I can help convincing your team mates as well. The more, the merrier. [19:11:21] zeljkof, this is great! [19:11:42] qgil: yes, it started slowly, but this kid wants to be the winner of the contest :) [19:12:01] AndyRussG: it's in ApiMain: https://github.com/wikimedia/mediawiki-core/blob/master/includes/api/ApiMain.php#L740 [19:12:07] qgil: I'm good [19:12:15] he has finished one task, already working on another one and asked for a few more in the queue [19:12:31] marktraceur, I know you are, but do you need to insist ;) [19:12:38] I'll answer questions about things I maintain, but I'm hesitant to declare myself a mentor for the program [19:13:42] marktraceur, andre and me are hesitant about publishing tasks being the mentors ourselves, when we don't have remotely the skills to support/assess the students... [19:13:55] marktraceur: being a mentor is cool, y'know. ;) [19:14:05] ugh: Hmm... I wonder why it's not dying when I send a bad token then, maybe I'm doing something else wrong? [19:14:35] marktraceur, also, in only one week it is noticeable the difference in mentoring: less noise, more students getting to the point [19:14:54] AndyRussG: is it throwing sessionfailure errors? :/ [19:14:59] marktraceur: and not that much of a commitment, unless you have five students at the same time or something [19:15:10] MatmaRex: I know, I'd call myself a mentor [19:15:17] I just don't particularly want to be a mentor for Google [19:15:22] heh [19:15:27] AndyRussG: oh, did you implement getTokenSalt() { return ''; } ? [19:15:40] Open Source is also evil [19:15:43] FREE SOFTWARE FTW! [19:16:11] vandrew_: It is mostly on the right track. Though, I would like a few things to be improved. [19:16:20] marktraceur, mmm okay... Publish your tasks somewhere, links included, and I will publish them for you. They need to be tied to bug reports you follow, and you will assess the Gerrit patches as usual. Deal? [19:16:27] Rtdwivedi: I'm all ears [19:16:47] qgil: Do I need to open a bz for the cron thing too? [19:17:03] (03PS1) 10Kghbln: Name and description change [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97771 [19:17:07] vandrew_: The structure should be of the kind "what is proofreading, how to do it on WIkisource", "about the extension and how to use it"... [19:17:20] Rtdwivedi, did anybody tell you that you happen to be a great mentor? Congratulations! Not that I didn't expect it, but you are doing great. [19:18:02] Coren, the candidate for Open Academy? Yes, please. CC me pls. [19:18:13] qgil: Will do my best - any bug marked "easy" in MultimediaViewer is a candidate, I'll make sure the ones in UW are OK too [19:18:18] vandrew_: also, it would be great if you could use headings etc. that are different from the rest of the text. That's all for now. [19:18:41] ugh: I change the JS to send a bad token and it still performs the changes. No, I didn't implementing getTokenSalt... Nor do the other API classes in the extension (there are just a few) [19:19:00] qgil: only one of my 3 tasks is complete. Thanks a lot! :D [19:19:08] Rtdwivedi: Thanks for feedback. [19:19:59] vandrew_: Also, looks like you intended to put links at a few places but forgot to put the link. :) [19:20:00] marktraceur, do you mind CCing me and adding gci2013 to the Whiteboard field of those you want to promote? I will post them as they come. [19:20:17] AndyRussG: if you want ApiMain to do the check, you need to implement getTokenSalt. Then it should work. [19:20:40] ugh: OK, thanks, trying that [19:20:46] Rtdwivedi, it's not the # of tasks closed that makes a good mentor, but the timing and usefulness of the replies. [19:21:30] :D [19:25:31] * Coren tries to find an apropriate project for this and fails. [19:25:46] qgil: I just punt and stuff it in the expected first use case (labs)? [19:25:47] Rtdwivedi: when you refer to structure, you mean that in place of the title Proofreading should be what is proofreading ? [19:26:10] Rtdwivedi: or should I add an sub heading for that ? [19:26:21] vandrew_: I refer to the organization of text. [19:26:22] ugh: OK, now API is checking correctly, thanks! [19:26:43] vandrew_: Add sub-headings where you deem them to be necessary. :-) [19:26:47] could someone help me with this one part of the mobilefrontend? [19:26:55] <^d> manybubbles: There you are! I have a patch for youuuuu [19:26:59] AndyRussG: woot :D [19:27:05] Rtdwivedi: oh,yeah ,of course, I'll change them right away [19:27:30] tholam: try poking jdlrobson for MobileFrontend stuff :) [19:27:47] <^d> manybubbles: To get your mind off of crashing and metrics. Here's some prepwork for foreign file searches. https://gerrit.wikimedia.org/r/#/c/97767/ [19:27:51] (03CR) 10Aaron Schulz: [C: 032] Handle redirecting the template in EditPage form [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/93494 (owner: 10Anomie) [19:27:54] (03Merged) 10jenkins-bot: Handle redirecting the template in EditPage form [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/93494 (owner: 10Anomie) [19:30:25] (03CR) 10Aaron Schulz: [C: 04-1] "Grammar" (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97771 (owner: 10Kghbln) [19:31:50] Coren, up to you. I'm only trying to keep a common process for all possible projects for outreach programs. The details are up to the mentors. [19:33:29] ^d: was actually hacking on some elasticsearch things. what about crashing? [19:33:41] qgil: 57613 [19:33:53] (03PS1) 10Reedy: Throw exception properly [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97774 [19:34:15] took a long lunch trying to convince someone smart to come work with us [19:35:24] Coren, thanks! Please add it to https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Distributed_cron_replacement using {{tracked}}, like the other projects. [19:35:36] qgil way ahead of you. :-) [19:35:43] :D [19:35:57] (03CR) 10Aaron Schulz: [C: 032 V: 032] Throw exception properly [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97774 (owner: 10Reedy) [19:37:51] Coren: is this supposd to be for GCI? [19:38:36] (03CR) 10Anomie: Output hidden fields on pages other than templates (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [19:39:40] (03PS2) 10Umherirrender: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/97544 [19:39:40] yuvipanda: Any even where organized coding may take place in a mentorship scenario; the impetus was the Facebook Open Academy mail from Quim, but the usefulness is there regardless of what even picks it up. :-) [19:40:15] <^d> manybubbles: Heh, I figured I'd give you a change of pace :p [19:40:22] yuvipanda: It's something that I'd use; that I don't have the time to do myself; that is well-defined and of reasonably limited scope. That sounded like an ideal project. [19:40:31] (03PS1) 10Kghbln: Added or improved file documentation [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/97775 [19:40:34] Coren: true! [19:40:37] (03CR) 10Jackmcbarn: Output hidden fields on pages other than templates (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/97763 (owner: 10Jackmcbarn) [19:40:48] Coren: and makes sense for the FN thing [19:41:20] <^d> manybubbles: I'm hacking around with how to do commons files. It's not really interwiki search, since the results should be inline. [19:41:30] <^d> I'm kinda scratching my head though. [19:41:46] <^d> (Since afaict, Elastica only really supports querying a single index?) [19:42:47] (03CR) 10Manybubbles: "Three points:" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [19:42:48] (03PS1) 10Daniel Kinzler: (bug #56685) make sure commafy can deal with strings. [core] - 10https://gerrit.wikimedia.org/r/97776 [19:43:15] <^d> The dumb (and wrong) way would be to query twice, but then you'd have the "merge 2 result sets" problem. [19:45:22] ^d: care to merge that one? very easy review. [19:45:58] <^d> I'll +2 if jenkins says a-ok. [19:46:11] thanks [19:46:15] <^d> yw [19:47:04] (03PS2) 10Kghbln: Name and description change [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97771 [19:48:07] (03CR) 10Chad: "1. Yeah, let's can make this configurable." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97767 (owner: 10Chad) [19:49:11] (03CR) 10Kghbln: "Thank you for having a look and suggesting the improvement." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97771 (owner: 10Kghbln) [19:49:50] (03CR) 10Aaron Schulz: [C: 032] Name and description change [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97771 (owner: 10Kghbln) [19:50:56] (03Merged) 10jenkins-bot: Name and description change [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97771 (owner: 10Kghbln) [19:53:19] (03CR) 10Chad: [C: 032] (bug #56685) make sure commafy can deal with strings. [core] - 10https://gerrit.wikimedia.org/r/97776 (owner: 10Daniel Kinzler) [19:55:13] (03PS2) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [19:57:48] (03Merged) 10jenkins-bot: (bug #56685) make sure commafy can deal with strings. [core] - 10https://gerrit.wikimedia.org/r/97776 (owner: 10Daniel Kinzler) [19:58:18] ^d: https://gerrit.wikimedia.org/r/#/c/97164/ [19:59:30] (03CR) 10jenkins-bot: [V: 04-1] Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 (owner: 10Aude) [19:59:55] (03CR) 10BryanDavis: [C: 031] Clean up MimeMagic singleton handling [core] - 10https://gerrit.wikimedia.org/r/97164 (owner: 10Aaron Schulz) [20:04:23] (03PS1) 10Aude: Update Wikibase, fix fatal error in special page [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97784 [20:04:53] (03CR) 10Aaron Schulz: [C: 032] Set visibility on class properties of File (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97367 (owner: 10Siebrand) [20:05:00] (03PS1) 10Tpt: Remove an unneeded property [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97785 [20:06:18] ugh: just added: https://www.mediawiki.org/wiki/API:Extensions#Edit_token [20:06:22] (03PS2) 10BryanDavis: Use ISO 3166-1 alpha-2 country codes [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97654 [20:07:06] AndyRussG: sweet :D [20:07:26] ugh: :) [20:09:28] (03PS1) 10Amire80: Logical order of "from" and "to" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97786 [20:10:55] (03CR) 10Chad: [C: 032] Clean up MimeMagic singleton handling [core] - 10https://gerrit.wikimedia.org/r/97164 (owner: 10Aaron Schulz) [20:11:12] (03Merged) 10jenkins-bot: Set visibility on class properties of ArchivedFile [core] - 10https://gerrit.wikimedia.org/r/97368 (owner: 10Siebrand) [20:11:13] (03Merged) 10jenkins-bot: Set visibility on class properties of File [core] - 10https://gerrit.wikimedia.org/r/97367 (owner: 10Siebrand) [20:11:20] <^d> Aaron|home: On that note...do we still need & on wfGetDB() & friends these days? [20:11:29] no [20:11:33] <^d> Didn't think so. [20:12:31] (03PS1) 10Jackmcbarn: Allow transcluding Special:Gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/97787 [20:13:20] hmm, no jenkins-bot? [20:15:14] (03Merged) 10jenkins-bot: Clean up MimeMagic singleton handling [core] - 10https://gerrit.wikimedia.org/r/97164 (owner: 10Aaron Schulz) [20:16:40] jackmcbarn: not all repos have it [20:17:00] ugh: it was just a lot slower than normal. it did eventually catch it [20:17:08] ah [20:21:50] (03PS3) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [20:25:27] (03CR) 10RobLa: "If this function is spewing warnings now, won't this just double the amount of warnings that get spewed? It would seem marking this as de" [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [20:26:34] (03PS4) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [20:28:29] (03CR) 10Anomie: [C: 032] Remove experiment code for moduleStorage [core] - 10https://gerrit.wikimedia.org/r/97482 (owner: 10Ori.livneh) [20:29:31] (03PS5) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [20:34:26] (03PS6) 10Aude: Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up [core] - 10https://gerrit.wikimedia.org/r/97742 [20:34:28] alright, done if anyone wants to review ^ :) [20:34:50] (03PS1) 10Amire80: Using his and her instead of their [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97829 [20:34:50] makes it more possible for wikibase (and flow) to support enhanced changes format [20:35:10] * hoo wishes he had the time for that atm [20:35:19] no immediate hurry [20:35:39] almost 100% test coverage there :) [20:35:57] (03PS2) 10Amire80: Logical order of "from" and "to" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97786 [20:35:57] Uncommon for core :) [20:36:13] yeah [20:36:36] * aude shall try to make it 100% but not today [20:37:12] (03CR) 10Parent5446: "@Anomie Done" [core] - 10https://gerrit.wikimedia.org/r/52910 (owner: 10Parent5446) [20:42:11] (03CR) 10Jhall: [C: 031] "Looks good!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97761 (owner: 10Mayankmadan) [20:42:43] gwicke: http://www.heise.de/newsticker/meldung/OLG-Stuttgart-Wikimedia-haftet-fuer-Verdachtsberichterstattung-2053118.html [20:44:39] mutante: I'm glad that I'm not a lawyer [20:44:50] heh [20:45:08] heh, yea, just afraid that means more "delete in swift/ceph/foo" tickets [20:45:28] unless it doesnt matter at all, because we dont operate servers in .de [20:45:41] so even if it was the OLG... shrug [20:45:56] just wondering if it was really "the WMF" or actually WMDE lawyers [20:46:02] when they say foundation [20:46:05] hey aude, i wonder how does that actually make it easier for flow/wikidata? i see no hooks/subclassing/whatever there [20:46:18] (just wondering, the change looks sane enough) [20:46:19] there will be hooks [20:46:37] ah. okay [20:46:38] :) [20:46:40] then we can customize handling of an entry [20:47:02] and i can more easily provide tests for the enhanced changes class (e.g. how it groups) [20:49:33] (03Merged) 10jenkins-bot: Remove experiment code for moduleStorage [core] - 10https://gerrit.wikimedia.org/r/97482 (owner: 10Ori.livneh) [20:50:05] (03CR) 10Jhall: [C: 031] "Looks good!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97762 (owner: 10Mayankmadan) [20:51:34] marktraceur, thank you for the tasks! Question: will you be more or less traceable between Thursday-Sunday? [20:51:46] More or less, yeah [20:51:52] My family isn't that interesting [20:52:02] :) [20:52:27] qgil: You have my phone number if not, and I will be basically an hour from a computer at any time [20:52:41] I might want to black Friday night out, but otherwise AOK [20:53:02] no worries! checking twice a day or so is pretty good already [20:53:13] Heh. [20:53:21] I eat twice a day for breakfast [20:53:28] Almost literally [20:56:47] (03PS1) 10Tpt: (bug 57615) Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 [21:05:23] (03CR) 10Jhall: [C: 031] new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 (owner: 10Cmcmahon) [21:06:47] (03PS1) 10Tpt: Use new validation system of the content model in EditPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97837 [21:11:30] (03PS2) 10Tpt: (bug 57615) Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 [21:13:50] (03CR) 10jenkins-bot: [V: 04-1] (bug 57615) Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:14:35] (03PS1) 10Hoo man: Fix README grammar [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/97840 [21:14:57] (03CR) 10Hoo man: [C: 032] Fix README grammar [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/97840 (owner: 10Hoo man) [21:17:02] (03Merged) 10jenkins-bot: Fix README grammar [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/97840 (owner: 10Hoo man) [21:17:18] (03CR) 10Tpt: ""ContentHandler::getForModelID( $modelId ) instanceof TextContentHandler;" isn't nice but is needed because there is no way to get if a co" [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:19:59] (03CR) 10jenkins-bot: [V: 04-1] (bug 57615) Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:20:05] (03PS3) 10Parent5446: (bug 57615) Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:21:02] (03PS3) 10Umherirrender: Correct version section for rc_source in the updaters [core] - 10https://gerrit.wikimedia.org/r/96874 [21:23:07] (03CR) 10Anomie: [C: 04-1] Error handling tweaks in JobQueueFederated (033 comments) [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [21:27:27] (03CR) 10jenkins-bot: [V: 04-1] Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:28:05] (03Draft3) 10Wikinaut: OpenID: Fix the README file; chg $wgOpenIDLoginOnly default false [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97843 [21:29:03] (03CR) 10Wikinaut: [C: 032 V: 032] OpenID: Fix the README file; chg $wgOpenIDLoginOnly default false [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97843 (owner: 10Wikinaut) [21:30:11] (03PS4) 10Tpt: (bug 57615) Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 [21:30:30] (03CR) 10Aaron Schulz: [C: 032] Error handling tweaks in JobQueueFederated (032 comments) [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [21:31:08] (03PS5) 10Tpt: (bug 57615) Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 [21:31:27] (03CR) 10jenkins-bot: [V: 04-1] Error handling tweaks in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [21:32:54] (03CR) 10Tpt: "PS4:" [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:36:24] (03CR) 10jenkins-bot: [V: 04-1] Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:37:56] (03PS1) 10Chad: Proper CdbException handling [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/97846 [21:39:27] (03PS2) 10Aaron Schulz: Error handling tweaks in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/94436 [21:40:03] (03CR) 10jenkins-bot: [V: 04-1] Error handling tweaks in JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/94436 (owner: 10Aaron Schulz) [21:41:59] (03PS6) 10Tpt: Add validation of the content model edited by EditPage [core] - 10https://gerrit.wikimedia.org/r/97835 [21:42:29] (03CR) 10Tpt: "PS6: Drop validation on construct too" [core] - 10https://gerrit.wikimedia.org/r/97835 (owner: 10Tpt) [21:44:41] (03PS2) 10Tpt: Use new validation system of the content model in EditPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97837 [21:46:26] (03PS2) 10Chad: Change CdbException to subclass Exception [core] - 10https://gerrit.wikimedia.org/r/96910 [21:46:27] (03PS2) 10Chad: Improved CdbException handling in LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/96909 [21:46:28] (03PS1) 10Chad: Improved CdbException handling in Interwiki [core] - 10https://gerrit.wikimedia.org/r/97847 [21:46:52] <^demon|away> Aaron|home: ^ :) [21:47:08] <^demon|away> The full list of changes is https://gerrit.wikimedia.org/r/#/q/status:open+topic:cdbstuff,n,z (ignore multiversion until all the core ones go in) [21:50:53] spagewmf, do you know if the css_preso directory and ulimit4 script are still needed on toro? [21:51:01] I can copy them somewhere if you want. [21:51:09] ^demon|away: won't that give warnings? [21:51:17] you should set $this->readers[$code] = false on exception or something [21:51:29] most of these commits have similar warnings [21:51:41] (at least some of the merged ones did too) [21:53:47] <^demon|away> - if ( !file_exists( $fileName ) ) { [21:53:47] <^demon|away> - $this->readers[$code] = false; [21:53:47] <^demon|away> - } else { [21:53:49] <^demon|away> + $this->readers[$code] = false; [21:53:51] <^demon|away> + if ( file_exists( $fileName ) ) { [21:54:08] <^demon|away> Like that ^ [22:05:25] RIP grrrit-wm [22:05:32] legoktm: labs is dead [22:05:34] legoktm: NFS restart, will be back [22:05:38] oh [22:05:47] somehow my IRC bots running from labs are still connected [22:06:20] marktraceur: hohohoh no. NFS is fucked again :P [22:06:34] legoktm: are you hitting NFS? [22:06:40] legoktm: I'm logging to NFS, so... :P [22:07:07] it should, but it should also catch those errors [22:07:40] legoktm: i know, i know... [22:07:45] :) [22:07:45] i don't :P [22:11:00] ... [22:18:07] legoktm, anyone else interested: here's another token-related question: does it make sense to try to send a salted token to JS? Right now I'm just using mw.user.tokens.get( 'editToken' ). I'm just wondering whether it has any real security advantages, since anyone can just take the unsalted token, which is always sent, and salt it using the same procedure for salting used on the server... no? [22:18:49] ummmm. mw.user.tokens.get should be fine I think....that's what nearly everything else uses. I'm not really sure what the security implications are. [22:21:00] !logs [22:21:00] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [22:21:41] legoktm: OK, got it. Thanks! [22:26:27] legoktm can you give me more details about what i need to do at this task https://www.google-melange.com/gci/task/view/google/gci2013/5794960062283776 ? [22:26:39] hi [22:26:39] sure [22:27:12] how familiar are you with mediawiki? do you know how Titles and page namespaces work? [22:28:17] vaguely [22:28:32] ok, so basically every page has a namespace, and a title part [22:28:51] so the page 'User:Legoktm', "User" is the namespace, and "Legoktm" is the rest [22:29:13] MassMessage has a feature which lets users enter one namespace, and it gets converted to a different namespace [22:29:22] that code is at https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/MassMessageJob.php#L46 [22:29:40] marktraceur, I'm trying to find a page about Media Viewer for developers, like a regular extension page, with a link to a repo, installation instructions... [22:29:44] however, we can also do this check earlier [22:29:50] I only find the info for betatesters and end users [22:30:07] qgil: https://www.mediawiki.org/wiki/Extension:MultimediaViewer ? [22:30:54] thanks legoktm , now I only need to learn why MultimediaViewer is Media Viewer etc. :) [22:30:56] That's the one [22:31:04] yamelnychuk: basically that code needs to get replicated in the normalizeTargets function [22:31:07] qgil: It's like Echo/Notifications [22:31:11] in MassMessage.body.php [22:31:19] ok [22:31:33] I named the extension because I was creating repos and bugzilla components, and three weeks later fabriceflorin came up with a slightly different name [22:31:58] naming vs branding :) [22:32:29] yamelnychuk: does that make sense? [22:33:45] marktraceur, let me guess who wrote "without extraneous page loads or confusing interstitial pages." I love it [22:33:57] * marktraceur did [22:34:14] of corrs [22:34:39] I already find it and try understand how it works, also https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/MassMessageJob.php#L46 code different then code that i get from https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MassMessage [22:34:40] We used the term "interstitial page" throughout the product planning meetings, though [22:35:15] wait, really? [22:35:18] hmm [22:36:01] yamelnychuk: no, it is up to date for me. both repos are at 9c54083 [22:40:31] marktraceur, http://www.google-melange.com/gci/task/view/google/gci2013/5868509229744128 [22:40:40] one more question, how to write irc msg like yournick: somebodynick: msg ? =) [22:40:46] let me know whether you want any changes, marktraceur [22:41:06] over email since I must run to catch the train [22:41:15] qgil: Currently 100% deployed to every WMF wiki [22:41:26] Under the BetaFeatures flag, but still [22:41:27] I will post the rest while commuting (ok) [22:41:36] *nod* I'll keep poking you [22:41:38] bye! [22:44:20] yuvipanda: uhhh ^ [22:44:34] legoktm: yeah looking [22:45:13] ori-l, spagewmf, are either of you still working on piramido or toro? [22:45:19] local-lolrrit-wm@tools-login:~/lolrrit-wm$ ./src/kick.bash [22:45:20] No job 'lolrrit-wm' is currently queued or running [22:45:20] Your job 1678402 ("lolrrit-wm") has been submitted [22:45:21] i'm not using either [22:45:28] Thanks, ori-l. I'm doing some cleaning. [22:45:34] thanks [22:45:43] why is jenkins-bot failing my commit for stuff i didn't touch? [22:45:44] https://gerrit.wikimedia.org/r/#/c/97855/ [22:46:04] (03PS2) 10Mayankmadan: Prefer double-quoted strings in Ruby code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 [22:46:08] (03CR) 10EBernhardson: [C: 032] "PS3 & 4: fix rebase of i18n messages and add qqq for the new parameter" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96417 (owner: 10Werdna) [22:46:13] (03CR) 10EBernhardson: [C: 04-2] "oops don't merge yet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96417 (owner: 10Werdna) [22:46:15] (03PS4) 10EBernhardson: Display reason for moderation in history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96417 (owner: 10Werdna) [22:46:17] (03CR) 10EBernhardson: [C: 032] Display reason for moderation in history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96417 (owner: 10Werdna) [22:46:19] jackmcbarn: it's the last failure that is causing it to veto [22:46:22] (03CR) 10Anomie: [C: 04-1] "-1 for line 256. The other comments don't really matter." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [22:46:23] (03Merged) 10jenkins-bot: Display reason for moderation in history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96417 (owner: 10Werdna) [22:46:24] and that does seem to come from your change [22:46:27] (03PS1) 10Legoktm: Add global groups to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 [22:46:32] * jackmcbarn looks [22:46:34] (03PS1) 10Tholam: Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 [22:46:35] jackmcbarn: 22:43:37 PHP Parse error: syntax error, unexpected '[' in includes/specials/SpecialUndelete.php on line 1130 [22:46:41] » » » ChangeTags::formatSummaryRow( $tags, 'deleteddiff' )[0] . '
' . [22:46:52] that's not valid in all supported versions of PHP I think [22:47:01] legoktm: should be fine now [22:47:19] woot [22:47:43] * werdna waves at people [22:49:07] yuvipanda: Oululaisen paikallisradion omistaja selvisi käräjäoikeudessa vakavasta tekijänoikeuspinteestä. Tapauksessa ihmetyttää poliisin toiminta. [22:49:28] (03PS3) 10Jackmcbarn: Show tags in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/97855 [22:49:32] grumble, old versions of php [22:50:06] Nikerabbit: என்ன சொல்றீங்க புரிலே [22:50:39] yuvipanda: why don't you understand? [22:50:51] Nikerabbit: because [22:51:05] yuvipanda: because! [22:51:23] Nikerabbit: :D [22:54:40] jackmcbarn: https://bugzilla.wikimedia.org/show_bug.cgi?id=57627 [22:55:15] I hope you don't feel singled out; I was really confused by it too [22:55:17] cool, thanks [22:58:35] (03PS15) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [22:59:27] (03CR) 10AndyRussG: Let instructors and other roles add students (032 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [23:00:07] marktraceur: I'm playing with BetaFeatures right now and cant get BetaFeaturesHooks::getUserCounts to return anything. [23:00:29] legoktm: Uhhh, that's weird [23:00:29] The betafeatures_user_counts table is empty (no rows), even though I have a user who has a betafeature enabled [23:00:37] Oh [23:00:38] well, it's returning an empty array. [23:00:53] legoktm: It updates very infrequently [23:00:56] (03PS4) 10Jackmcbarn: Show minor edits and tags in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/97855 [23:01:01] Disable memcached [23:01:24] ill just flush the keys [23:02:04] (03PS5) 10Jackmcbarn: Show minor edits and tags in Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/97855 [23:05:08] marktraceur: ah got it. I didn't realize I had to run the job queue. [23:05:20] *nod* sorry 'bout that [23:05:26] Bloody job queue [23:05:41] I should maybe document better how that table works [23:08:45] <3 job queue [23:09:06] (03PS1) 10Legoktm: API module: list=betafeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 [23:09:13] marktraceur: ^ [23:09:16] (03CR) 10CSteipp: [C: 031] "This addresses my concerns with Filter::evaluate. Let's merge this, and I'll make comments on a couple of the places where it's used, and " [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 (owner: 10Dan-nl) [23:10:14] (03CR) 10Aaron Schulz: [C: 032] Improved CdbException handling in LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/96909 (owner: 10Chad) [23:10:48] (03PS1) 10Luis Felipe Schenone: Initial commit [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/97861 [23:10:54] (03CR) 10Jdlrobson: [C: 04-1] "A few minor whitespace changes - Brion can you think of a better approach to the mw.api hack?" (033 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [23:11:04] * brion looks [23:11:24] (03CR) 10CSteipp: [C: 031] functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 (owner: 10Dan-nl) [23:14:02] (03PS7) 10Tholam: Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 [23:14:51] (03CR) 10Brion VIBBER: "Well, I'd recommend removing the code duplication between core's 'api' interface and MF's 'api' interface, but that seems outside the scop" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 (owner: 10Tholam) [23:14:58] (03PS8) 10Tholam: Add refresh functionality on fancycaptcha for mobile [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97852 [23:14:59] (03CR) 10Gergő Tisza: [C: 031] "Definitely not, exception initialization logic belongs to the exception class. I would have extracted it from the constructor into a separ" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97676 (owner: 10Dan-nl) [23:17:01] (03Merged) 10jenkins-bot: Improved CdbException handling in LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/96909 (owner: 10Chad) [23:19:54] (03PS1) 10EBernhardson: By default Flow should not be deployed to any pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97862 [23:20:53] (03CR) 10Werdna: [C: 032] By default Flow should not be deployed to any pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97862 (owner: 10EBernhardson) [23:20:58] (03PS1) 10EBernhardson: Global variable to disable flow's recent changes formatting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97863 [23:21:12] (03Merged) 10jenkins-bot: By default Flow should not be deployed to any pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97862 (owner: 10EBernhardson) [23:21:34] marktraceur, http://www.google-melange.com/gci/task/view/google/gci2013/5868509229744128 edited [23:22:13] (03PS1) 10EBernhardson: Global variable to disable flow's memcache usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 [23:22:15] marktraceur, Caltrain is not the best place to keep a data connection alive [23:22:18] (03CR) 10Aaron Schulz: [C: 032] Improved CdbException handling in Interwiki (032 comments) [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:23:04] Go figure [23:23:07] Thanks qgil [23:23:23] caltrain is horrible for that :P [23:23:37] (03CR) 10Jhall: [C: 031] "Looks good!" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/97849 (owner: 10Mayankmadan) [23:23:50] marktraceur, can I clone the other MultimediaViewer tasks with this template? [23:24:31] * marktraceur reads [23:24:32] qgil: you know that other tasks eagerly waiting to be cloned are those for i18n and mw.o's Translate, don't you? ;) [23:24:54] (03PS2) 10Legoktm: Add global groups to Special:CentralAuth/Username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97851 [23:24:56] ebernhardson, I ���like��� the fact that the connection always drops between two little villages totally unrelated with the Internet called... Palo Alto and Mountain View [23:25:06] qgil: Sounds fine to me [23:25:10] thanks! [23:25:15] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Initial commit [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/97861 (owner: 10Luis Felipe Schenone) [23:25:54] (03CR) 10Chad: Improved CdbException handling in Interwiki (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:25:59] (03CR) 10Chad: [C: 04-2] Improved CdbException handling in Interwiki [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:26:03] qgil: i like that buying a monthly pass for caltrain in the san jose(or should i say, silicon valley?) train station involves listening to a dial-up modem connect [23:26:13] really feels next-gen :) [23:26:19] :DDDD [23:27:14] ebernhardson, bact-to-the-future feeling [23:28:03] (03CR) 10Chad: Improved CdbException handling in Interwiki (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:29:09] (03CR) 10Aaron Schulz: Improved CdbException handling in Interwiki (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:29:13] (03PS4) 10Chad: Change CdbException to subclass Exception [core] - 10https://gerrit.wikimedia.org/r/96910 [23:29:14] (03PS3) 10Chad: Improved CdbException handling in Interwiki [core] - 10https://gerrit.wikimedia.org/r/97847 [23:29:25] (03CR) 10Chad: Improved CdbException handling in Interwiki [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:30:06] (03CR) 10Bartosz Dziewoński: "I'm not sure how useful this will actually be. Consider me neutral. (If it is actually useful to you, then make that a weak +1.)" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97856 (owner: 10Ori.livneh) [23:32:01] (03CR) 10Spage: "Only comment comments." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97864 (owner: 10EBernhardson) [23:34:51] (03CR) 10Aaron Schulz: [C: 032] Improved CdbException handling in Interwiki [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:37:25] lol [23:37:26] branch: master (might-as-well-use-gender) [23:37:54] (03Merged) 10jenkins-bot: Improved CdbException handling in Interwiki [core] - 10https://gerrit.wikimedia.org/r/97847 (owner: 10Chad) [23:44:16] (03CR) 10Aude: [C: 04-1] "hopefully this option is not needed :)" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97863 (owner: 10EBernhardson) [23:46:27] (03CR) 10GWicke: "Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [23:47:56] (03CR) 10CSteipp: "Getting better, although the form displays just have to be present in the config now. It would be nice if those also inherited and were ch" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 (owner: 10Dan-nl) [23:49:11] (03CR) 10CSteipp: [C: 031] max-file-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97465 (owner: 10Dan-nl) [23:49:30] gwicke: did you forget to score? [23:50:37] Aaron|home: you can pick your score ;) [23:50:42] (03CR) 10MarkTraceur: [C: 04-1] "I want to say something like "put the API module in includes/" but if you don't want to it's cool." (034 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 (owner: 10Legoktm) [23:50:43] +2? [23:50:48] sure [23:51:09] I did not test it, I guess you did [23:51:16] btw, any HTTP API would need to handle posting multiple jobs (which could just use a generic multi-job job) [23:51:30] why? [23:51:41] those notes should go on some mw.org page instead of that commit though, since that's all orthogonal [23:51:51] (03CR) 10GWicke: [C: 032] Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [23:52:11] gwicke: to avoids RTTs...it could even use pipelining, as long as there is something [23:52:14] Aaron|home: yeah, is there a brainstorming page for the job queue? [23:52:18] (03CR) 10jenkins-bot: [V: 04-1] Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [23:52:26] Aaron|home: ah, parallelism should do that [23:52:45] well, preferably not spamming tcp connections [23:53:09] you can just set the number of concurrent requests per host to a middle ground like 50 [23:53:30] node for example does that for you [23:53:34] heh, same thing filebackend does [23:53:41] but ideally that's not the best way [23:53:47] the only page I know of is https://www.mediawiki.org/wiki/Job_queue_redesign [23:53:59] ugh, merge conflict [23:54:27] in the glorious future spdy / HTTP 2.0 will make small requests even more efficient [23:54:32] (03CR) 10BryanDavis: [C: 032] "Approving per Chris' recommendation" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 (owner: 10Dan-nl) [23:54:40] (03Merged) 10jenkins-bot: filter [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 (owner: 10Dan-nl) [23:55:12] ori-l: speaking of which, how did the spdy deploy go? [23:55:40] I lost track [23:55:40] (03CR) 10BryanDavis: [C: 032] functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 (owner: 10Dan-nl) [23:55:47] (03Merged) 10jenkins-bot: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 (owner: 10Dan-nl) [23:56:05] legoktm: Thanks for the patch, look forward to merging 'er [23:56:10] :) [23:56:22] I hope to have the Echo stuff done by the weekend [23:57:16] o.o [23:57:27] legoktm: Will you have time to eat yer turkey? :) [23:58:03] (03PS2) 10Legoktm: API module: list=betafeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 [23:58:21] (03PS2) 10Tim Starling: Remove https redirect from CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96317 (owner: 10CSteipp) [23:58:28] (03CR) 10Tim Starling: [C: 032] Remove https redirect from CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96317 (owner: 10CSteipp) [23:58:29] (03CR) 10Legoktm: "I moved it into includes/ since I don't really care :)" (034 comments) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97859 (owner: 10Legoktm) [23:58:31] (03Merged) 10jenkins-bot: Remove https redirect from CentralAutoLogin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96317 (owner: 10CSteipp) [23:58:39] Muahaha [23:59:12] marktraceur: I'm vegetarian, so we're having lasagna among other things. Also that's just Thursday, the weekend is 3 more days :P [23:59:26] Aaron|home: added a section in https://www.mediawiki.org/wiki/Talk:Job_queue_redesign [23:59:31] Oh, by the end of the weekend?