[00:00:15] But you already have six [00:00:22] 5 [00:00:25] That's like one per day [00:00:28] Well still. [00:02:11] legoktm: it's called on both [00:02:35] ok [00:02:40] i'll just move it into the constructor then [00:02:53] hm... [00:03:12] I have two more tasks to finish before I can get a T-shirt. [00:03:32] yeah [00:03:47] And even that might be a stretch the way my mentors are being... Which is to say not being around. [00:03:54] Weekends. [00:04:28] legoktm: I just don't like it when fields like that mutate after construction [00:05:28] Aaron|home: so the main problem is that if a namespace is not existent on meta, but is on the target site, Title->mNamespace is 0, so when we check $title->getNamespace(), we get NS_MAIN instead of NS_PROJECT (or w/e) [00:06:07] easiest way I could think of doing that is just recreating the title object [00:06:32] right, I don't have a problem with that :) [00:06:45] ideally you'd know the foreign NS ID, but that's always a pain [00:07:30] yeah, that's nearly impossible to do since namespaces can be added by extensions, which you can't get from $wgConf [00:10:05] legoktm: right, all the "config resolving" stuff mentioned in the rfc review [00:14:39] so yeah :/ [00:22:40] (03PS3) 10Legoktm: Create a fresh Title object in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 [00:24:00] Aaron|home: ^ moved it into the constructor. I'm not a fan of doing it this way, but I'm not sure there's anything better... [00:30:24] (03CR) 10Hoo man: [C: 04-1] "Extending classes solely for code reuse is bad. I would like to have at least a abstract base class (maybe ChangesSpecialPage or something" [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [00:36:46] (03PS6) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [01:00:50] (03PS13) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [01:01:31] (03PS7) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [01:06:00] (03PS1) 10Aude: Fix typos in documentation [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97460 [01:11:14] (03PS8) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [01:11:27] (03PS3) 10Theopolisme: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 [01:14:37] (03PS3) 10Aude: Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 [01:16:02] (03CR) 10Aude: [C: 04-1] "This fails until we get Hebrew special page aliases re-exported, and then it will pass." [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [01:16:03] (03CR) 10jenkins-bot: [V: 04-1] Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [01:27:57] !pastebin [01:27:57] To avoid overflowing the channel with inane amounts of text, use https://dpaste.org/ or other awesome pastebin sites to share code, errors, and other large texts. [01:32:25] (03CR) 10AndyRussG: Let instructors and other roles add students (039 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [01:44:15] (03CR) 10AndyRussG: Let instructors and other roles add students (0312 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [01:45:35] (03CR) 10Aaron Schulz: [C: 032] Create a fresh Title object in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:45:42] (03Merged) 10jenkins-bot: Create a fresh Title object in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:45:48] thanks [02:07:07] (03CR) 10Theopolisme: Improve PDF/DJVU navigation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [02:10:29] hi tholam, theopolisme [02:10:35] hi [02:10:52] tholam: see pm [02:16:42] (03CR) 10Theopolisme: Improve PDF/DJVU navigation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [02:17:49] (03PS4) 10Tholam: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [02:18:58] (03CR) 10jenkins-bot: [V: 04-1] Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [02:24:53] * HectorAE sighs again [02:26:09] Louder. [02:26:54] * HectorAE sighs heavily [02:32:34] (03PS5) 10Tholam: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [02:33:43] (03CR) 10jenkins-bot: [V: 04-1] Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [02:42:17] (03PS6) 10Theopolisme: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 [02:43:26] (03CR) 10jenkins-bot: [V: 04-1] Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [02:48:37] Sooo saaad [03:00:11] (03PS7) 10Tholam: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [03:02:29] (03CR) 10Tholam: "How do I fix the author? I tried changing it in the commit when i amended it but it didn't do anything." [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [03:10:53] * HectorAE starts listening to a playlist of cool Homestuck music videos [03:36:25] (03PS9) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [03:40:21] (03PS10) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [04:11:29] (03PS1) 10Dan-nl: max-file-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97465 [04:11:52] (03PS2) 10Dan-nl: max-file-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97465 [04:24:57] (03PS1) 10Gnosygnu: v0.11.3.0 [xowa] - 10https://gerrit.wikimedia.org/r/97466 [04:34:26] (03PS1) 10Samwilson: New hook: OutputPageHtmlAttributes [core] - 10https://gerrit.wikimedia.org/r/97467 [04:36:22] (03PS1) 10Legoktm: Cleanup inconsistent code style [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 [04:40:41] (03CR) 10MZMcBride: Remove message 'expandtemplates-desc' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97389 (owner: 10Raimond Spekking) [04:42:50] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/97466 (owner: 10Gnosygnu) [04:58:21] (03PS11) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [05:19:49] (03CR) 10Chad: [C: 032] Update documentation of Status [core] - 10https://gerrit.wikimedia.org/r/97324 (owner: 10Siebrand) [05:20:19] (03CR) 10Parent5446: [C: 04-1] "Needs documentation in doc/hooks.txt." [core] - 10https://gerrit.wikimedia.org/r/97467 (owner: 10Samwilson) [05:22:53] (03Merged) 10jenkins-bot: Update documentation of Status [core] - 10https://gerrit.wikimedia.org/r/97324 (owner: 10Siebrand) [05:45:31] (03PS2) 10Siebrand: Declare visibility on class properties of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97373 [05:45:32] (03PS1) 10Siebrand: Update formatting for gallery related files [core] - 10https://gerrit.wikimedia.org/r/97471 [05:45:33] (03PS1) 10Siebrand: Break long lines in gallery classes [core] - 10https://gerrit.wikimedia.org/r/97472 [05:45:34] (03PS1) 10Siebrand: Remove commented out code [core] - 10https://gerrit.wikimedia.org/r/97473 [05:45:35] (03PS1) 10Siebrand: Replace Linker::link() by linkKnown() [core] - 10https://gerrit.wikimedia.org/r/97474 [05:45:36] (03PS1) 10Siebrand: Update documentation for gallery related files [core] - 10https://gerrit.wikimedia.org/r/97475 [05:45:37] (03PS1) 10Siebrand: Declare visibility on class properties of ImageGalleryBase [core] - 10https://gerrit.wikimedia.org/r/97476 [05:45:38] (03PS1) 10Siebrand: Update type hints in TraditionalImageGallery [core] - 10https://gerrit.wikimedia.org/r/97477 [05:45:43] (03PS2) 10Samwilson: New hook: OutputPageHtmlAttributes [core] - 10https://gerrit.wikimedia.org/r/97467 [05:48:48] (03CR) 10Siebrand: Remove unused local variable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97322 (owner: 10Siebrand) [05:48:54] (03PS2) 10Siebrand: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/97322 [05:51:20] (03PS1) 10Parent5446: Fix ordering of scripts for Persona [extensions/Persona] - 10https://gerrit.wikimedia.org/r/97478 [05:55:39] legoktm: https://gerrit.wikimedia.org/r/97366 has no reviewers assigned. [05:55:55] Yeah [05:56:04] there are intermediate patches that need to be reviewed first [05:56:23] Go Siebrand go. [05:58:00] (03CR) 10Werdna: "Timo, would you mind providing concrete feedback or withdrawing your -1?" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [05:59:49] legoktm: I also replied to a few posts here: https://www.mediawiki.org/wiki/Help_talk:Extension:MassMessage [05:59:58] I'm not sure I knew that page existed. [06:00:25] I'd have preferred it be soft-redirected to Meta-Wiki's talk page, but w/e. [06:01:17] Help talk redirects to Extension talk:MassMessage right now [06:03:13] Oh, look at that, yes it does. [06:03:20] I guess that's not so bad, then. [06:10:37] (03PS12) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [06:12:19] (03PS2) 10Legoktm: Cleanup inconsistent code style [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 [06:12:20] (03PS7) 10Legoktm: Check for a message with no timestamp [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 [06:12:21] (03PS1) 10Legoktm: Generalize the badhtml module for any warning [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97479 [06:12:22] (03PS1) 10Legoktm: Check for missing timestamp using JavaScript [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97480 [06:12:46] (03CR) 10Legoktm: "PS7 was just a rebase." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [06:14:28] (03CR) 10Legoktm: "If a user uses a template to generate the signature, this will generate false positives. I don't know how common that is..." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97480 (owner: 10Legoktm) [06:15:24] (03PS13) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [06:18:00] (03PS2) 10Legoktm: Check for missing timestamp using JavaScript [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97480 [06:32:59] (03CR) 10Krinkle: [C: 031] Move file to adhere to module declaration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/97163 (owner: 10MarkTraceur) [06:33:54] * marktraceur resolves to teach Krinkle|detached about UploadWizard so he can actually bloody merge things :P [06:36:41] marktraceur: module declration says [06:36:42] 'styles' => 'ext.uploadWizard.uploadCampaign.list.css', [06:36:52] oh [06:36:53] nevermind [06:37:02] Hurrdurr [06:37:03] (03CR) 10Yuvipanda: [C: 032] Move file to adhere to module declaration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/97163 (owner: 10MarkTraceur) [06:37:07] (03Merged) 10jenkins-bot: Move file to adhere to module declaration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/97163 (owner: 10MarkTraceur) [06:37:21] * marktraceur thwaps YuviPanda with multiple cluenewspapers [06:37:21] marktraceur: hurdurr indeed [06:37:40] YuviPanda: ori-l pointed it out and we're deploying it this week because it's lowe-impact [06:37:45] low-impact* [06:38:08] hey YuviPanda [06:38:21] hi ori-l! [06:38:44] how were you able to enable SPDY on nginx on labs, when the nginx in apt.wm.o wasn't built with it? [06:38:54] and how has it been working, in general? [06:38:59] ori-l: because it isn't running nginx from apt.wm.o :D [06:39:12] ah [06:39:16] ori-l: there's a deb that is installed just for that project [06:39:36] ori-l: nobody's really used it, and that proxy system is going to be rolled out only today anyway. [06:39:45] ori-l: so I expect a better idea when there's more load on it [06:39:58] ok, definitely let me know how it works out! [06:40:02] ori-l: will do! [06:45:58] (03CR) 10Krinkle: "I did, 3 days ago on Nov 22. I don't recall specific bugs at this time, but given the bad experience the VisualEditor team has had with th" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [06:46:17] ori-l: it has actually been surfaced last friday! https://wikitech.wikimedia.org/wiki/Special:NovaProxy [06:46:40] ori-l: I guess andrewbogott_afk will start moving more people to it over time [06:46:46] (03CR) 10Krinkle: Add jquery.scroll.js plugin, factored out from Flow. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [06:46:56] apparently will make the eqiad migration easier [06:57:13] (03PS1) 10Legoktm: If there are no matches, null is returned [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97481 [07:00:11] Hey, I made a new install of MW, and installed UploadWizard and ProofreadPage as well. I have a DjVu file, but when I try to create it's index file, the function doDBUpdates in maintenance/populateImageSha1.php throws the error "No such file". [07:00:39] Does anyone know a workaround? [07:01:08] Rtdwivedi: What file does it say doesn't exist? [07:01:10] Rtdwivedi: Did you upload the DjVu file via Special:Upload? [07:01:13] (03CR) 10AndyRussG: "Hi, all, here are some general points." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [07:01:27] That is, did you upload the file to the server using the wiki user interface? [07:01:44] Elsie: I uploaded using Special:UploadWizard. [07:01:57] Heh. [07:02:02] marktraceur: It doesn't name a file. [07:02:18] Is your wiki public? Can you provide a link? [07:02:30] Elsie: No, it's my local install. [07:03:42] (03CR) 10Krinkle: Add jquery.scroll.js plugin, factored out from Flow. (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [07:04:30] (03PS1) 10Ori.livneh: Remove experiment code for moduleStorage [core] - 10https://gerrit.wikimedia.org/r/97482 [07:09:46] (03CR) 10Aaron Schulz: [C: 032] Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/97322 (owner: 10Siebrand) [07:10:00] (03CR) 10Krinkle: [C: 031] If there are no matches, null is returned [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97481 (owner: 10Legoktm) [07:10:39] marktraceur: although, I don't get an error when I don't provide pagelist tag to the Index page. [07:11:41] (03CR) 10Krinkle: Swap Title::newFromUrl for Title::newFromText (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97455 (owner: 10Reedy) [07:11:44] Rtdwivedi: I'm not very versed in the ProofreadPage extension - you may want to ask its maintainers, maybe they have a better shot at debugging [07:12:24] marktraceur: I work with ProofreadPage, but most probably, it's not a bug in ProofreadPage. [07:12:46] (03Merged) 10jenkins-bot: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/97322 (owner: 10Siebrand) [07:13:07] Right, but I don't even know how to deal with debugging [07:13:16] And it's late out here on the left coast [07:13:23] (03PS2) 10Ori.livneh: Remove experiment code for moduleStorage [core] - 10https://gerrit.wikimedia.org/r/97482 [07:13:43] oh, have a good night! Thanks! :-) [07:14:43] (03CR) 10Ori.livneh: "Note that this leaves the key 'moduleStorageExperiment' set in localStorage, but I'll be clearing that from Extension:WikimediaEvents (pat" [core] - 10https://gerrit.wikimedia.org/r/97482 (owner: 10Ori.livneh) [07:33:11] resuming here [07:33:22] I think the Configuration database RFC is poorly titled. [07:33:36] And I'm unclear whether there's genuine disagreement about the overall goal(s). [07:33:56] there's no genuine disagreement, just a paralyzing lack of clarity about what the goals actually are [07:34:15] which is why it's good to wed developments to specific use-cases, like zero [07:34:29] I don't think there's a lack of clarity for some. [07:34:39] hehe, zero has figured out our use cases from the start :) [07:34:57] I think putting all configuration variables possible into a graphical user interface is a common goal. [07:34:57] yurik: right [07:35:05] maybe that's why we developed it and now trying to see if we can generalize it [07:35:07] not really [07:35:30] nah, i would rather not have a cute button for each minor setting there is [07:35:33] i'll take /etc over Control Panel [07:35:34] too limiting [07:35:52] text is pretty damn nice for a lot of use cases [07:36:04] Such as? [07:36:17] there is usually a good middle ground - common stuff - GUI, complex unusual stuff for devs only - text [07:36:19] integration with existing configuration management [07:36:22] tools [07:36:29] scriptable from pretty much anywhere / anything [07:36:42] Scriptability depends on an API no matter what. [07:36:48] I'm not sure what you mean by integration. [07:36:57] Elsie, have you seen zero configs? [07:37:11] It'd be nice to have an evaluation of core config variables. Lots are booleans. [07:37:14] yurik: Probably some version of it. [07:37:18] Elsie, http://meta.wikimedia.org/wiki/Zero:250-99 [07:37:22] view source [07:37:30] and the page [07:37:41] Right. [07:37:46] Elsie: they're evaluated every second :) [07:38:02] Hurr. [07:38:06] I mean an audit. [07:38:09] the point about it - the config is in plain text, and it gets pulled by all mobile clients [07:38:24] as a json blob, and gets parsed on the client [07:38:27] Some are arrays, others are booleans, still others are... strings or integers, I guess. [07:38:41] And then of course there's Wikimedia's config v. typical config. [07:38:44] someone needs to do an evaluation and compile the results... [07:39:42] * YuviPanda slinks away [07:39:59] how do you express things like this in a graphical interface: [07:40:03] // Confirmed can do anything autoconfirmed can. [07:40:04] $wgGroupPermissions['confirmed'] = $wgGroupPermissions['autoconfirmed']; [07:40:12] or [07:40:22] $wgExtensionEntryPointListFiles[] = "$wmfConfigDir/extension-list-$wmfExtendedVersionNumber"; [07:40:35] You allow groups to inherit permissions of other groups? [07:40:45] I think Microsoft has supported this logic in a GUI for a decade or two. [07:41:00] * ori-l goes back to doing other things [07:41:09] Not sure what the hell the second example is doing. [07:41:31] Probably can be stored in a similar text input, though. [07:41:34] Or re-implemented [07:41:35] . [07:41:55] Extension lists in particular would need some work with any configuration interface, I imagine. [07:42:05] i look forward to the gesture interface [07:42:31] * ori-l gestures at Elsie. [07:42:37] Yes. [07:42:39] Good night. [07:42:48] good night [07:45:30] yurik: CommonSettings.php: http://i.imgur.com/gRGS9ss.jpg [07:45:52] yeah, i figured :) [07:46:05] my only concern - how much it would cost to hire him [07:46:09] and would we want to ? [07:46:13] "Siri, replace memcached with redis as the primary session cache" [07:46:39] ori-l, that requires a gesture [07:46:52] that subtle movement of the middle finger [07:47:04] if you do it wrong, the system might not get it [07:47:23] there are a lot of middle-finger commits to mediawiki-config [07:48:46] (03PS6) 10Wikinaut: make SpecialChangePassword form text depending on login status of wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [08:29:31] (03PS3) 10Ori.livneh: Remove experiment code for moduleStorage [core] - 10https://gerrit.wikimedia.org/r/97482 [08:32:17] ör [08:36:49] hey Nikerabbit [08:37:01] what's ör? [08:37:22] arrow? [08:38:18] that's what the orcs say? [08:39:25] oh [08:41:45] (03PS1) 10Ori.livneh: Remove module storage logging; replace with small clean-up script [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/97485 [08:51:58] (03CR) 10Jforrester: Make edit toolbar Signature button optional in content namespaces (031 comment) [core] - 10https://gerrit.wikimedia.org/r/87649 (owner: 10TTO) [08:54:45] ori-l: curious though did you get useful data out from the experiment [08:56:41] yes, but aaron halfaker is writing up a proper report [08:56:56] so i'm not publicizing anything yet [08:58:15] oki [08:58:52] (03CR) 10Nemo bis: "This change depends on a commit which can't be merged. Perhaps you instead want to submit this as a new independent change: remember https" [core] - 10https://gerrit.wikimedia.org/r/97364 (owner: 10RAZVOR) [08:59:51] (03PS2) 10Nemo bis: Add a message to the edit form when external text is loaded. Also, an i18n file for the messages. [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/66231 (owner: 10Samwilson) [09:01:01] is it normal for this to given an internal server error? https://gerrit.wikimedia.org/r/#/c/66223/ [09:01:11] no [09:01:19] that's a serious bug [09:01:21] whatever it is [09:01:31] ori-l: is there some page to watchlist, to avoid missing said report? [09:02:17] Nemo_bis: https://meta.wikimedia.org/wiki/Research:Module_storage_performance [09:02:28] if you want to cheat you can peek at the talk page [09:02:58] (03CR) 10Nemo bis: "This depends on a commit which gives me Code Review - Error" [extensions/ExternalArticles] - 10https://gerrit.wikimedia.org/r/66230 (owner: 10Samwilson) [09:04:14] i hope to get approval from the legal dept to release the dataset along with the results [09:04:42] i think it'll be straightforward, the data is really sterile, nothing private/personal [09:05:09] nice to hear [09:15:38] (03CR) 10Werdna: "As I've clarified previously, this is not a fork of any plugin, and I've never claimed it to be." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [09:55:38] (03CR) 10Krinkle: Add jquery.scroll.js plugin, factored out from Flow. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [09:57:14] (03PS8) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [09:57:16] (03PS3) 10Hashar: get-mw-core now fallback on git.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/87059 [09:58:33] (03CR) 10Krinkle: "Yeah (see later inline comment) so it isn't a fork. In that case we should ensure that your implementation passes our use cases and then w" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [09:59:17] (03CR) 10Hashar: "made cucumber to use the 'ciwmf' cucumber profile" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 (owner: 10Hashar) [10:03:26] (03CR) 10Daniel Kinzler: "would definitely be good to have such a test, but this seems a bit brittle." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/93611 (owner: 10Aude) [10:05:22] (03Abandoned) 10Ori.livneh: Revert "Kranitor: Make JSHint pass" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96482 (owner: 10devunt) [10:13:05] (03CR) 10Daniel Kinzler: [C: 04-1] "There has to be a better way to do this. Content objects can control their own content language, based on the content itself, the current " [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [10:15:35] (03CR) 10Ori.livneh: "> For comparison, here is the implementation we ended up with in" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [10:15:52] (03CR) 10Daniel Kinzler: "Sorry. Forget my previous comment. I'm quite confused about what which language thingy really means, and how it is used where. The transli" [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [10:21:46] I've got a question regarding the GCI tasks [10:21:58] what happens if all tasks are compleated?; [10:22:06] Will there be new ones? [10:22:41] Because more than half of them are already compleated [10:32:50] (03PS9) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [10:37:43] (03PS10) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [10:40:48] (03CR) 10KartikMistry: [C: 031] "LGTM." [core] - 10https://gerrit.wikimedia.org/r/97473 (owner: 10Siebrand) [10:41:30] ahmad96: yes, there will be plenty [10:42:44] if you want to be sure to be able to gain a lot of points, https://www.google-melange.com/gci/task/view/google/gci2013/5863957638152192 is something that will get faster after the first time you complete it, and there's room to complete it up to 400 times or so [10:43:33] ahmad96, I also believe andre__ is about to post some more i18n tasks [10:44:02] yes, that is the plan, I just need to get there on my to-do list for today :-/ [10:44:25] and everybody is welcome to discuss with developers potential new GCI tasks. [10:49:53] I would love to see new kiwix related tasks [10:54:18] Maybe porting the build system over to gradle [10:54:59] Or a tablet layout [10:55:44] ahmad96: you should ask Kelson on #kiwix then [11:06:53] (03PS8) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 [11:12:20] (03CR) 10Addshore: [C: 031] Thanks is not using namespaces [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97195 (owner: 10Legoktm) [11:22:07] (03CR) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation (037 comments) [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [11:23:06] * [new tag] 1.22.0rc-FINAL [11:23:11] o_O ? [11:44:10] (03CR) 10Ori.livneh: [C: 031] "I'm leaning towards merging, but I'd like to think about this just a tiny bit longer. Some minor quibbles inline." (039 comments) [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [11:47:47] (03PS1) 10Matthias Mullie: No strict comparison against id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97494 [11:50:52] Krinkle: code path for getting int UTC timestamp via time(): time() [11:50:59] via wgTimestamp(): (wait for it...) [11:51:02] wfTimestamp -> new MWTimestamp -> MWTimestamp::setTimestamp -> new DateTime / new DateTimeZone -> MWTimestamp::getTimestamp [11:51:29] *three* objects! [11:51:53] oh, I left out time(), which wfTimestamp also calls [11:52:26] so really: wfTimestamp -> new MWTimestamp -> MWTimestamp::setTimestamp -> time -> new DateTime / new DateTimeZone -> MWTimestamp::getTimestamp [11:52:48] i guess there are no ObjectFactories, we should be grateful [11:53:55] ori-l: Yeah, isn't it lovely [11:54:01] ori-l: even worse, it will return a string [11:54:01] we should probably just add: [11:54:08] *not* an int [11:54:18] to the top of wfTimestamp: [11:54:22] / fast path [11:54:40] if ($outputtype == TS_UNIX && !$ts ) return time(); [11:58:53] (03PS8) 10Theopolisme: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 [11:59:29] (03CR) 10Theopolisme: "You can use `git commit --amend --reset-author`." [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [12:01:22] (03PS9) 10Theopolisme: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 [12:07:58] (03PS2) 10Brian Wolff: Don't use API to fetch alternate poster sizes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/96932 [12:08:28] (03CR) 10Brian Wolff: "Ps2: Rather bad typo on my part that Aaron caught." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/96932 (owner: 10Brian Wolff) [12:25:27] (03PS9) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 [12:37:10] (03PS10) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 [12:37:49] (03CR) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation (038 comments) [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [12:41:56] (03CR) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [12:42:14] (03PS11) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 [12:46:18] hi Nemo_bis [12:51:41] (03CR) 10Aklapper: [C: 031] "+1: Not 102% sure about the graphs links as I cannot easily test on wmflabs (missing datasets), but it cannot break anything badly. Plus t" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97005 (owner: 10Aklapper) [12:52:00] hi andre__ [12:52:06] hi mayankmadan [12:52:35] i dont get this task http://www.google-melange.com/gci/task/view/google/gci2013/6385280768540672 [12:52:43] i dont get what it wants [12:58:58] (03PS10) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [13:02:40] andre__: ^^ [13:03:01] mayankmadan, what is unclear? [13:06:16] (03PS1) 10Njw: Ensure no borders causing horizontal scrollbars with narrow screens [skins/erudite] - 10https://gerrit.wikimedia.org/r/97502 [13:06:21] (03CR) 10Bartosz Dziewoński: "This does not actually depends on its "dependency" here, does it?" (038 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 (owner: 10Legoktm) [13:08:30] hi mayankmadan [13:09:20] mayankmadan: have you read https://commons.wikimedia.org/wiki/Commons:Preparing_a_page_for_translation ? [13:09:28] i dont understand a thing on the task page [13:09:35] tell me [13:11:50] mayankmadan, if you can explain and share what the exact problems are, somebody can improve the description for you and others :) [13:12:28] (03CR) 10Bartosz Dziewoński: "(I see this is part of a larger stack, so don't consider my comments blocking. I can merge this later today.)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 (owner: 10Legoktm) [13:15:48] (03PS4) 10Matthias Mullie: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [13:19:20] (03CR) 10Hashar: "Causes bug 57535 on beta: ForeignAPIRepo::$fetchDescription being accessed in File.php." [core] - 10https://gerrit.wikimedia.org/r/97371 (owner: 10Siebrand) [13:23:38] (03CR) 10Kaldari: "File.php expects several of these member variables to be public (see lines 1724 and 1732 for example). This change breaks loading files pa" [core] - 10https://gerrit.wikimedia.org/r/97371 (owner: 10Siebrand) [13:24:48] (03PS1) 10Siebrand: Set visibility of 2 properties to public [core] - 10https://gerrit.wikimedia.org/r/97504 [13:25:28] (03CR) 10Siebrand: "I've submitted https://gerrit.wikimedia.org/r/97504" [core] - 10https://gerrit.wikimedia.org/r/97371 (owner: 10Siebrand) [13:26:52] yeah mayankmadan, I tried to be verbose to avoid giving any step for granted but I may surely have missed the point, so please ask :) [13:29:06] (03CR) 10Kaldari: [C: 032] Set visibility of 2 properties to public [core] - 10https://gerrit.wikimedia.org/r/97504 (owner: 10Siebrand) [13:32:08] (03Merged) 10jenkins-bot: Set visibility of 2 properties to public [core] - 10https://gerrit.wikimedia.org/r/97504 (owner: 10Siebrand) [13:34:12] siebrand: as you can tell, I haven't recovered from my jetlag yet :P [13:34:21] as it's 5am here [13:35:05] kaldari: Ah, yes, I did wonder about the peculiar time. [13:35:27] kaldari: I landed 07:00 local time. Fell asleep several times already. [13:35:38] (03PS8) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 [13:35:41] (03PS7) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 [13:40:33] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 (owner: 10Hashar) [13:40:41] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 (owner: 10Hashar) [13:41:25] (03PS3) 10Hashar: make-release: basic logging support [tools/release] - 10https://gerrit.wikimedia.org/r/95782 [13:41:39] (03CR) 10Hashar: [C: 032] make-release: basic logging support [tools/release] - 10https://gerrit.wikimedia.org/r/95782 (owner: 10Hashar) [13:42:44] (03Merged) 10jenkins-bot: make-release: basic logging support [tools/release] - 10https://gerrit.wikimedia.org/r/95782 (owner: 10Hashar) [13:42:53] (03PS1) 10Siebrand: Remove unused local variables, update formatting and documentation [core] - 10https://gerrit.wikimedia.org/r/97505 [13:46:30] (03PS1) 10Siebrand: Update documentation [core] - 10https://gerrit.wikimedia.org/r/97506 [13:54:52] (03Abandoned) 10Hashar: Don't upload if output looks erroneous [tools/release] - 10https://gerrit.wikimedia.org/r/70648 (owner: 10Reedy) [13:57:21] (03CR) 10Hashar: "So --destDir is not honored in the make-release script :-/ The code always creates the tar ball in the build root (aka --build)." [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [14:00:20] (03CR) 10Hashar: [C: 032] Update documentation [core] - 10https://gerrit.wikimedia.org/r/97506 (owner: 10Siebrand) [14:03:21] (03Merged) 10jenkins-bot: Update documentation [core] - 10https://gerrit.wikimedia.org/r/97506 (owner: 10Siebrand) [14:11:47] (03PS1) 10Ebrahim: Native digits on 'notification-page-linked-bundle' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97507 [14:16:31] (03CR) 10Hashar: "removing myself from reviewers, feel free to add me back whenever the tests have been fixed in the extension." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [14:17:37] (03PS2) 10Hashar: General Cleanup of some Tests [core] - 10https://gerrit.wikimedia.org/r/95606 (owner: 10Addshore) [14:19:23] (03CR) 10Hashar: [C: 032] General Cleanup of some Tests [core] - 10https://gerrit.wikimedia.org/r/95606 (owner: 10Addshore) [14:23:00] (03Merged) 10jenkins-bot: General Cleanup of some Tests [core] - 10https://gerrit.wikimedia.org/r/95606 (owner: 10Addshore) [14:27:52] (03PS1) 10Siebrand: Updates for Interwiki.php [core] - 10https://gerrit.wikimedia.org/r/97508 [14:28:15] (03PS4) 10Hashar: get-mw-core now fallback on git.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/87059 [14:32:14] (03PS11) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [14:37:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I did not test yet (will do later today), but I like really like how this looks :D Left some minor comments inline." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [14:37:39] (03Abandoned) 10Hashar: doc: alias PHPUnit commands [core] - 10https://gerrit.wikimedia.org/r/92782 (owner: 10Hashar) [14:41:32] (03PS5) 10Matthias Mullie: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [14:41:34] (03CR) 10Matthias Mullie: Add access to historical revisions. (038 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [14:43:46] (03CR) 10Matthias Mullie: [C: 031] "All that's left now is:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [14:44:23] (03CR) 10Gergő Tisza: [C: 04-2] "Unfortunately, the parameter array passed to wfStreamThumb() will contain raw values when using a 404 handler - it will look something lik" [core] - 10https://gerrit.wikimedia.org/r/96920 (owner: 10Gergő Tisza) [14:44:50] (03PS1) 10Siebrand: Update formatting of job related files [core] - 10https://gerrit.wikimedia.org/r/97509 [14:47:00] (03PS6) 10Matthias Mullie: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [14:54:48] (03PS1) 10Matthias Mullie: Add setChildren() & setDepth() in loadTopicTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 [14:54:50] (03CR) 10jenkins-bot: [V: 04-1] Add setChildren() & setDepth() in loadTopicTitle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 (owner: 10Matthias Mullie) [14:59:10] (03CR) 10Calak: [C: 031] Updates for Interwiki.php [core] - 10https://gerrit.wikimedia.org/r/97508 (owner: 10Siebrand) [14:59:14] (03PS1) 10Siebrand: Break long lines in job related files [core] - 10https://gerrit.wikimedia.org/r/97512 [14:59:33] (03CR) 10Calak: [C: 031] Native digits on 'notification-page-linked-bundle' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97507 (owner: 10Ebrahim) [15:07:02] (03PS1) 10Hashar: mw-core-get.sh: snapshot a mediawiki/core treeish [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97513 [15:07:14] (03CR) 10Hashar: [C: 032] mw-core-get.sh: snapshot a mediawiki/core treeish [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97513 (owner: 10Hashar) [15:07:17] (03Merged) 10jenkins-bot: mw-core-get.sh: snapshot a mediawiki/core treeish [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97513 (owner: 10Hashar) [15:13:34] (03PS1) 10Siebrand: Set visibility on class properties of DoubleRedirectJob [core] - 10https://gerrit.wikimedia.org/r/97514 [15:14:24] (03PS1) 10Hashar: make mw-core-get.sh strict (set -e) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97515 [15:14:39] (03CR) 10Hashar: [C: 032] make mw-core-get.sh strict (set -e) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97515 (owner: 10Hashar) [15:14:46] (03Merged) 10jenkins-bot: make mw-core-get.sh strict (set -e) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97515 (owner: 10Hashar) [15:23:43] (03PS1) 10Hashar: mw-core-get.sh: bug fixing [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97517 [15:23:52] (03CR) 10Hashar: [C: 032] mw-core-get.sh: bug fixing [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97517 (owner: 10Hashar) [15:23:55] (03Merged) 10jenkins-bot: mw-core-get.sh: bug fixing [integration/jenkins] - 10https://gerrit.wikimedia.org/r/97517 (owner: 10Hashar) [15:24:17] (03CR) 10Qgil: [C: 031] "The graphics look good to me, but I'm not a person to assess the code of the patch." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/97454 (owner: 10M4tx) [15:24:29] (03PS2) 10Gergő Tisza: WIP Make thumb.php redirects point to thumb.php [core] - 10https://gerrit.wikimedia.org/r/96920 [15:33:02] (03PS1) 10Siebrand: Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 [15:35:07] (03PS1) 10Matthias Mullie: Get rid of unused $wgFlowTokenSalt [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97520 [15:36:15] (03CR) 10Matthias Mullie: "Go home Jenkins, you're drunk" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97511 (owner: 10Matthias Mullie) [15:36:57] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 (owner: 10Siebrand) [15:36:59] (03CR) 10Matthias Mullie: [C: 031] Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [15:41:41] (03CR) 10Anomie: [C: 04-1] Add an API action to test blacklisted URLs (033 comments) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [15:43:44] (03CR) 10Nikerabbit: [C: 032] Add a class to interlanguage links [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80) [15:45:24] (03PS1) 10Dan-nl: external-entity [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97521 [15:46:19] (03PS1) 10Reedy: Fix class usages from global namespace [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97522 [15:47:10] (03PS2) 10Reedy: Fix class usages from global namespace [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97522 [15:47:30] (03PS2) 10Dan-nl: external-entity [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97521 [15:47:55] (03Merged) 10jenkins-bot: Add a class to interlanguage links [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80) [15:49:15] Does class_exist check the global namespace? Or just the current? [15:52:24] (03PS1) 10Reedy: Fix onConfirmEmailComplete class_exists check [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97524 [15:54:06] (03PS2) 10Siebrand: Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 [15:55:07] (03CR) 10Gergő Tisza: "Fixed params issue. Tested with both 404 and normal handling, seems to work." [core] - 10https://gerrit.wikimedia.org/r/96920 (owner: 10Gergő Tisza) [15:55:47] (03PS3) 10Jeroen De Dauw: Only run linting and not tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 [15:58:18] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 (owner: 10Siebrand) [16:02:06] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/87059 (owner: 10Hashar) [16:03:04] (03Merged) 10jenkins-bot: get-mw-core now fallback on git.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/87059 (owner: 10Hashar) [16:03:50] (03CR) 10MaxSem: [C: 032] Fix class usages from global namespace [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97522 (owner: 10Reedy) [16:03:56] (03Merged) 10jenkins-bot: Fix class usages from global namespace [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97522 (owner: 10Reedy) [16:08:39] (03CR) 10Siebrand: "The -2 because of QUnit failure is probably incorrect." [core] - 10https://gerrit.wikimedia.org/r/97519 (owner: 10Siebrand) [16:29:20] (03CR) 10Anomie: [C: 04-1] "Also, I see in PS4 you were having ApiMain use this function. Why did you drop that? The uses of getTraceAsString in includes/db/DatabaseE" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [16:29:33] (03PS10) 10Tholam: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [16:30:33] (03PS1) 10Hashar: get-mw-core now fallback on git.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97527 [16:30:36] (03PS1) 10Hashar: bind mediawiki-core-qunit to gallium [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97528 [16:30:43] (03PS10) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [16:30:52] (03CR) 10Hashar: "The version deployed is really https://gerrit.wikimedia.org/r/97527 forgot to send it in Gerrit." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/87059 (owner: 10Hashar) [16:31:03] (03CR) 10Hashar: [C: 032] "already deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97527 (owner: 10Hashar) [16:31:20] (03CR) 10Hashar: [C: 032] "being deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97528 (owner: 10Hashar) [16:34:29] (03Merged) 10jenkins-bot: get-mw-core now fallback on git.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97527 (owner: 10Hashar) [16:35:13] (03Merged) 10jenkins-bot: bind mediawiki-core-qunit to gallium [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97528 (owner: 10Hashar) [16:39:30] (03CR) 10Anomie: "Seems to work. One suggestion for result naming improvement." (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [16:41:08] hashar: Hi [16:44:56] (03PS11) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [16:46:05] (03CR) 10Jackmcbarn: "Can https://www.mediawiki.org/w/index.php?title=Extension:SpamBlacklist/API&diff=829427&oldid=788403 be approved to reflect those changes?" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [16:48:23] (03PS1) 10Matthias Mullie: Add topic moderation log i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97529 [16:49:47] (03CR) 10Matthias Mullie: [C: 04-1] [SCHEMA CHANGE] Refactor of moderation logging. (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [16:50:17] (03CR) 10Matthias Mullie: [C: 031] "Looks good, but parent patch needs to get merged first" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96417 (owner: 10Werdna) [18:19:18] (03CR) 10Chad: [C: 031] Use 'pagetitle' in content language [core] - 10https://gerrit.wikimedia.org/r/94862 (owner: 10Siebrand) [18:20:54] (03PS1) 10EBernhardson: CSS transitions for timestamp hovers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97535 [18:22:39] (03CR) 10Bartosz Dziewoński: [C: 031] "Eh, and it has a dependency too. So I won't now (and probably not this week), sorry." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 (owner: 10Legoktm) [18:22:54] heh [18:23:03] i was just cleaning it up right now >.> [18:24:12] how do i get the name of a special page in a language-independent way? [18:25:36] its in special page factory i think. one sec [18:25:52] (03PS3) 10Legoktm: Cleanup inconsistent code style [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 [18:26:12] jackmcbarn: SpecialPage::getTitleFor('Watchlist')->getPrefixedText() will work [18:28:57] !logs [18:28:57] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [18:29:28] (03CR) 10Legoktm: "Yeah, so this commit doesn't have a dependency, but I wanted to clean up the JS before adding more stuff to it." (038 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 (owner: 10Legoktm) [18:30:04] (03PS4) 10Legoktm: Cleanup inconsistent code style [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 [18:31:31] hi MatmaRex [18:31:43] Hola MatmaRex, mayankmadan. [18:31:56] hi [18:31:58] Not sticking around for long, only about ten more minutes. [18:32:31] MatmaRex, kinda wanted to do this task http://www.google-melange.com/gci/task/view/google/gci2013/5734051386228736 [18:32:34] (03CR) 10Bartosz Dziewoński: [C: 032] If there are no matches, null is returned [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97481 (owner: 10Legoktm) [18:32:44] (03Merged) 10jenkins-bot: If there are no matches, null is returned [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97481 (owner: 10Legoktm) [18:32:52] thanks [18:33:21] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs rebase." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 (owner: 10Legoktm) [18:33:28] legoktm: sure, but that's it for today. :P [18:33:30] :| [18:33:56] mayankmadan: sorry, i don't have time for GCI today, either :( i have two patches to review and then it's university work [18:34:25] (03PS1) 10MarkTraceur: Move file to adhere to module declaration [extensions/UploadWizard] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97536 [18:34:39] MatmaRex, No problem(as long as other students dont get tasks too :)) [18:34:39] (03CR) 10MarkTraceur: [C: 032] Move file to adhere to module declaration [extensions/UploadWizard] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97536 (owner: 10MarkTraceur) [18:34:44] (03Merged) 10jenkins-bot: Move file to adhere to module declaration [extensions/UploadWizard] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97536 (owner: 10MarkTraceur) [18:34:45] (03PS5) 10Legoktm: Cleanup inconsistent code style [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97468 [18:35:08] (03PS1) 10MarkTraceur: Move file to adhere to module declaration [extensions/UploadWizard] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97537 [18:35:15] (03CR) 10MarkTraceur: [C: 032] Move file to adhere to module declaration [extensions/UploadWizard] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97537 (owner: 10MarkTraceur) [18:35:19] (03Merged) 10jenkins-bot: Move file to adhere to module declaration [extensions/UploadWizard] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97537 (owner: 10MarkTraceur) [18:36:29] hexmode, can you please have a look to https://www.mediawiki.org/wiki/MediaWiki_1.22 and see whether you are happy with HectorAE 's improvements? [18:37:02] (03PS1) 10MarkTraceur: Update UploadWizard [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97538 [18:38:32] (03PS1) 10MarkTraceur: Update UploadWizard [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97539 [18:38:34] (03CR) 10Chad: Update formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97098 (owner: 10Siebrand) [18:38:41] (please be happy please be happy) [18:39:35] (03CR) 10Chad: [C: 032] Set visibility on class properties of OldLocalFile [core] - 10https://gerrit.wikimedia.org/r/97344 (owner: 10Siebrand) [18:41:24] (03CR) 10MarkTraceur: [C: 032 V: 032] "Going out now" [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97539 (owner: 10MarkTraceur) [18:43:14] (03PS11) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [18:43:24] hi qgil [18:43:58] how do i send a mail to qa mailing list? [18:45:25] legoktm: still around? [18:45:26] (03Merged) 10jenkins-bot: Set visibility on class properties of OldLocalFile [core] - 10https://gerrit.wikimedia.org/r/97344 (owner: 10Siebrand) [18:45:28] yup [18:47:27] (03CR) 10MarkTraceur: [C: 032] Update UploadWizard [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97538 (owner: 10MarkTraceur) [18:51:24] (03PS1) 10MaxSem: Fix fatal due to access to protected field [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97541 [18:53:04] hi mayankmadan , subscribing to https://lists.wikimedia.org/mailman/listinfo/qa [18:53:27] Hi MathaRex [18:53:45] please check it https://gerrit.wikimedia.org/r/#/c/96918/ [18:53:57] MatmaRex* [18:54:21] (03CR) 10Legoktm: [C: 031] "Untested." [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [18:54:45] hi yamelnychuk, yes, i'm on it [18:54:49] !tabcompletion [18:54:49] Instead of manually typing another person's nickname in IRC, you can type the beginning of their name and hit TAB on your keyboard to get it autocompleted, like on the command line. This avoids misspellings. Just make sure it's the right person! [18:54:52] yamelnychuk: ^ [18:57:26] qgil: yeah, looks good. He even added a shot of the login after thingles noted it had been updated. [18:58:08] (03PS2) 10Matthias Mullie: (bug 57532) Topics started by an IP show as "Topic started by [current user's IP]" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97494 [18:58:11] hexmode, can we consider the task completed? [18:58:34] qgil: I think so, yeah [18:58:52] hexmode, good! Thank you for acting as mentor-via-proxy :) [18:59:01] np [18:59:01] hexmode, if you have more tasks, they are welcome [18:59:07] (03CR) 10Aaron Schulz: [C: 032] Fix fatal due to access to protected field [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97541 (owner: 10MaxSem) [18:59:09] (03Merged) 10jenkins-bot: Fix fatal due to access to protected field [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/97541 (owner: 10MaxSem) [19:01:25] (03CR) 10Hoo man: [C: 04-1] "I'm also not sure it's a good idea to use messages from core, these probably should be defined in the extension i18n (Siebrand probably kn" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/97531 (owner: 10Zsaigol) [19:02:02] (03CR) 10Bartosz Dziewoński: [C: 04-1] Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [19:02:47] (03CR) 10Swalling: "Mark: I don't think wgCleanLoginUX is the right solution. Creating an on/off switch for one message on one form seems excessive. Adding op" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:04:16] (03CR) 10Legoktm: Improve PDF/DJVU navigation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:04:17] (03CR) 10Aaron Schulz: [C: 04-1] Set visibility on class properties of Job (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97519 (owner: 10Siebrand) [19:05:09] (03CR) 10CSteipp: "The overall concept I think is fine. It does open some brute-forcing opportunities to figure out hidden lists, but those are pretty minor " [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [19:07:24] why doesn't onMediaWikiPerformAction run on special pages? [19:07:49] (03CR) 10Ragesoss: [C: 031 V: 031] "I've tested this in combination with the 'assign articles' patch, and everything seems to be in working order." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [19:07:50] (03CR) 10Bsitu: [C: 032] (bug 57532) Topics started by an IP show as "Topic started by [current user's IP]" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97494 (owner: 10Matthias Mullie) [19:08:13] (03Merged) 10jenkins-bot: (bug 57532) Topics started by an IP show as "Topic started by [current user's IP]" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97494 (owner: 10Matthias Mullie) [19:09:23] !hook MediaWikiPerformAction [19:09:24] https://www.mediawiki.org/wiki/Manual:Hooks/MediaWikiPerformAction [19:09:41] (03CR) 10Ragesoss: [C: 031 V: 031] "Tested locally along with the 'add students' patch, and it works." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [19:10:01] MatmaRex: does viewing special pages not count as an action? [19:10:12] I don't think special pages support actions [19:10:37] hmm [19:10:41] Heh, Watchlist + action=edit goes to Special:EditWatchlist. [19:10:44] Seems they might [19:10:54] how can i run a hook before a special page loads? [19:11:00] jackmcbarn: looking at the code, apparently. [19:11:18] wfRunHooks( 'SpecialPageBeforeExecute', array( $this, $subPage ) ); [19:11:32] https://www.mediawiki.org/wiki/Manual:Hooks/SpecialPageBeforeExecute [19:11:35] thanks [19:14:12] New FOSS OPW participants announced! https://wiki.gnome.org/OutreachProgramForWomen/2013/DecemberMarch [19:14:51] We're trying to make sense of webstatscollector data and are running into many hits to Special:CentralAutoLogin. [19:15:19] (03PS1) 10Umherirrender: Fixed spacing of exception message in Revision::checkContentModel [core] - 10https://gerrit.wikimedia.org/r/97544 [19:15:22] When do we expect requests to for example Special:CentralAutoLogin/createSession? [19:15:32] Or Special:CentralAutoLogin/start? [19:16:17] (03CR) 10RobLa: [C: 04-1] "Naming-wise, I'm not thrilled with the "$wgCleanLoginUX" name, because it's the logical equivalent of "$wgDontShowExtraMessages". "true" " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:18:44] (03CR) 10Tholam: Improve PDF/DJVU navigation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:18:46] qchris: csteipp and anomie would know [19:18:53] MatmaRex: Thanks! [19:19:12] (03CR) 10MarkAHershberger: "I don't see this as a dispute over whether we *should* phase it out or not -- though there is disagreement over that issue that will need " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:19:34] qchris: /start should be going away [19:19:51] csteipp: That's good to know :-) [19:20:16] csteipp: and createSession? Do we expect a request to it for each request? [19:20:25] csteipp: or just if a user has not yet been logged in? [19:20:48] The /createSession call only happens when a user is centrally logged in, but not on the current wiki, and we were able to log them in with javascript [19:21:15] csteipp: Understood. Thanks! [19:21:31] qchris: On the first pageview for most anon users, you should see a hit to /checkLoggedIn. Some of those will redirect to /createSession then /validateSession then /setCookies, then maybe one other in the future. For anons who don't have JS enabled, you'd see a hit to /start then the rest as described before. Post-login, you'll also see a hit to /start on various other wikis, and also /refreshCookies on loginwiki. And on logout, you'll see hits to [19:21:31] /deleteCookies. [19:21:34] qchris: After the current version of centralauth is deployed, all anonymous visitors will hit /checkLoggedIn once per day [19:21:54] s/the first pageview/the first pageview per site per day/ [19:23:13] Oh ... ok. [19:23:58] csteipp: /start isn't completely going away, just most of the hits to it. [19:24:01] (03CR) 10Bartosz Dziewoński: "Looks nice and works when I tested it :D" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:24:34] anomie, Yes that's right [19:24:59] (03CR) 10Chad: [C: 04-2] "I hate new config for such a hacky single use case. Mention it in the release notes if it's not already and move on." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:27:34] (03PS11) 10Tholam: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:28:11] (03CR) 10Tholam: "fixed the indentation" [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:31:21] (03CR) 10Umherirrender: "These tests already fails under the old class name when running isolated on my local machine" [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [19:31:33] (03PS5) 10Umherirrender: Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 [19:33:39] qgil: How easy should a task be for GCI? I have a few MassMessage bugs that could probably be done [19:34:12] hi ugh rough estimate: a couple of hours for an experienced contributor [19:34:40] what's the cleanest way to write out a redirect and then stop all processing? [19:34:43] (03CR) 10jenkins-bot: [V: 04-1] Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [19:34:45] ugh, in practice, what is important is to have things documented and an outcome clearly defined [19:34:48] (http redirect) [19:35:11] jackmcbarn: its somewhere in OutputPage [19:35:12] ugh, MassMessage bugfixes sound like great GCI tasks! [19:36:02] ugh: how do i stop further code after i do that? [19:36:05] did someone say a gci task :) [19:36:06] qgil: https://bugzilla.wikimedia.org/show_bug.cgi?id=55383 will take a few hours, https://bugzilla.wikimedia.org/show_bug.cgi?id=57406 will take like 10 minutes [19:36:11] i remember seeing somewhere don't use die() [19:36:12] jackmcbarn: return; :) [19:36:24] ugh: then i just give control back to somewhere else that will do more stuff [19:36:25] (03CR) 10Gergő Tisza: [C: 031] external-entity [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97521 (owner: 10Dan-nl) [19:37:06] (03PS12) 10Bartosz Dziewoński: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:37:12] ugh, well, both are good tasks. :) In short: the system works and it's fair. when you consider that there are 1000s of tasks in the whole program and all students have access to all tasks [19:37:14] jackmcbarn: what are you trying to do specifically? [19:37:32] qgil: ok, do I need to do anythign to get them added to the list? [19:37:47] (03CR) 10Bartosz Dziewoński: [C: 032] "I added the "Co-authored-by:" lines for both of you. Thank you!" [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:37:58] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FInputBox/51ea834c37140ab547656d30c640bc8ddcdab552/InputBox.hooks.php [19:38:00] ugh, become a mentor first [19:38:00] that, but for special pages [19:38:06] (03CR) 10Legoktm: [C: 032] Remove m prefixes from private variables [core] - 10https://gerrit.wikimedia.org/r/96797 (owner: 10Chad) [19:38:27] ugh, https://www.mediawiki.org/wiki/Google_Code-In#Become_a_Wikimedia_GCI_mentor [19:38:40] ugh, then you can ask tasks at will [19:39:01] ugh, we just ask you to follow some simple, common-sense requirements described in tat wiki page [19:39:06] (03CR) 10Mattflaschen: [C: 032] "I was just using EchoNotifier as a marker that Echo is installed." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97524 (owner: 10Reedy) [19:39:38] qgil: ok, signing up right now [19:39:47] ugh, great! Thank you [19:40:00] jackmcbarn: can this be done in the special page itself and not via a hook? [19:40:23] ugh: it's an extension operating on Special:Movepage, so i don't think so [19:40:32] new tasks coming up!!! great :) [19:42:06] qgil: my username is "legoktm_" [19:42:17] (03Merged) 10jenkins-bot: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [19:42:26] (03Merged) 10jenkins-bot: Fix onConfirmEmailComplete class_exists check [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/97524 (owner: 10Reedy) [19:44:05] (03Merged) 10jenkins-bot: Remove m prefixes from private variables [core] - 10https://gerrit.wikimedia.org/r/96797 (owner: 10Chad) [19:44:07] ugh, have you received a notification? This Melange beats me when it comes to add new connections [19:44:47] uhh [19:44:48] no clue [19:44:55] but i found the create task page [19:44:58] (03PS6) 10MarkAHershberger: Restore MediaWiki:Signupstart for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 [19:45:02] (03PS12) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [19:45:25] ugh, ok, do you see "My Dasjboard"in the left column? [19:45:35] yeah [19:45:44] i think i figured out what to do [19:46:08] ugh , click My dashboard and then "Connect with organizations " [19:46:21] I think I'm already connected. [19:47:38] (03CR) 10MarkAHershberger: "I agree, this is a hacky config option." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:49:13] (03PS1) 10Chad: Don't use $wgTitle when OutputPage can provide [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/97546 [19:49:28] qgil: How long should I make it? 1 day? [19:49:33] (03CR) 10Anomie: [C: 04-1] "Needs rebase. Once that's done, it seems to work." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 (owner: 10CSteipp) [19:49:50] what is the thing you're supposed to use when you want to use die()? [19:50:03] jackmcbarn: throw a MWException [19:50:07] ugh: you mean time for the task? [19:50:11] MatmaRex: yes. [19:50:17] And do I just stick a bug link in the description? [19:50:21] MatmaRex: even if it's "supposed" to happen? [19:50:49] ugh: all of my tasks used 5 days, which was overkill in some cases, but i needed to extend the time for two tasks [19:50:59] ok [19:50:59] (after a lengthy code review process) [19:51:07] (03CR) 10Chad: "Having a better configuration system is neither here nor there. A better config system would mean we're adding a junky new config setting " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [19:51:12] 2-5 days is probably okay, depending on the task [19:51:20] how do I link to the bug report? [19:51:28] since that is supposed to include figuring out where to get the code, how to submit patches etc. [19:51:47] "See this bug report for more information. Students are required to read Wikimedia's general instructions first." [19:52:21] See this bug report for more information. Students are required to read Wikimedia's general instructions first. [19:53:16] https://www.google-melange.com/gci/task/view/google/gci2013/5877560873320448 [19:53:43] qgil: ^ [19:54:00] Not sure I got the formatting right... :| [19:56:06] ugh: aw, no, melange uses a "WYSIWYG" editor [19:56:08] and i mean "WYSIWYG" [19:56:18] since it notoriously breaks my formatting in bizarre ways [19:56:32] and its styles are completely different than real page styles [19:56:45] i just edit the source HTML by hand (there's a little button to do that) [19:56:57] ah [19:56:59] found that [19:57:19] much easier [19:57:54] ugh: also, i'd link [[E:MassMessage]] on mw.org in the task description [19:58:16] or some other page about what MM is, if you have one [19:58:33] jackmcbarn: I'm guessing the 'SpecialMovepageAfterMove' hook? Chances are you can and should just let the rest of the special page do its thing, OutputPage will remember you called ->redirect() and do your redirect when the page is output. [19:58:52] (03Abandoned) 10Rudolf.grossmann: Added an i18n message used by the applet generated by the extension (3rd try with Linux line endings) [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/79349 (owner: 10Rudolf.grossmann) [19:59:01] anomie: not quite, it needs to happen even if you load the page without doing the move [19:59:45] (03PS1) 10Chad: Remove unused globals [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/97548 [19:59:47] am i allowed to modify $request? if i am, i don't have to do the redirect [20:00:57] (03PS13) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [20:00:57] MatmaRex: ok, added the links. Does someone need to approve the tasks? they're listed as "unapproved" right now [20:01:24] ugh: yes, org admin (== qgil or andre) [20:01:29] (03CR) 10Legoktm: [C: 032] Remove unused globals [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/97548 (owner: 10Chad) [20:01:30] (03PS1) 10Raimond Spekking: Consistency tweak: Url -> URL [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97549 [20:01:40] (03CR) 10Legoktm: [V: 032] Remove unused globals [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/97548 (owner: 10Chad) [20:02:10] jackmcbarn: you probably are allowed to modify it, but what are you expecting that to do? [20:02:58] jackmcbarn: depending on implementation details, that will most likely cause the rest of whatever special page was ran to think it was ran with different requests parameters than the real ones [20:03:08] (also, aren't WebRequests immutable?) [20:03:58] $request->setVal('rar', 'zomg'); [20:04:02] <^d> ashley: I think you left a fatal in UserProfilePage.php. [20:04:11] <^d> There's still one leftover $wgTitle that I think you missed. [20:04:13] ugh: yes, i want to do that. is it okay to do that or will it break things somewhere i don't expect? [20:04:32] You probably shouldn't. [20:04:45] (03PS3) 10Siebrand: Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 [20:05:02] so it's a lesser of two evils. abort processing uncleanly to fire off the redirect, or modify $request [20:06:22] (03PS4) 10Siebrand: Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 [20:06:30] What is your extension trying to do? [20:06:53] I'm pretty sure there is a cleaner way to take over a page. [20:07:22] i don't want to take it over. i want to change the wpNewTitle parameter based on the existence of a prefix parameter, just like InputBox does to creates now [20:08:26] hmm [20:08:39] That should be fine to do then [20:08:45] editing $request? [20:09:11] (03CR) 10Bartosz Dziewoński: [C: 032] "This appears to make sense :) Thanks!" [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [20:09:14] yeah [20:09:33] you might want to do it as an ExtensionFunction so nothing gets confused [20:10:00] ugh, please edit the task specifying that changes are expected to be submitted in Gerrit and linked to their related bug reports in their commit message [20:10:25] ugh, this is a point where we are getting stuck every time, and specifying it in the task should help [20:10:36] ugh, the links to learn how to are already provided in the wiki oage [20:10:36] ok [20:12:05] ugh: what are those? the only thing i can find is https://www.mediawiki.org/wiki/Extension:ExtensionFunctions.php which is deprecated/removed [20:12:19] !wg ExtensionFunctions [20:12:20] https://www.mediawiki.org/wiki/Manual:%24wgExtensionFunctions [20:12:41] (03PS1) 10Chad: Don't use $wgArticle when we're not a global [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/97551 [20:12:42] (03Merged) 10jenkins-bot: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [20:13:30] qgil: I added: Patches should be submitted to Gerrit and reference the bug report in the commit message. [20:13:31] (03CR) 10Siebrand: "See PS4." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97519 (owner: 10Siebrand) [20:14:35] hey csteipp, just wanted to check-in with you when you have a moment. have a question regarding exception handling. i have an idea about demonstrating that the exception message has been properly sanitised, but want to make sure you're okay with it. the idea is to pass the wfmessage key to the gwtexception class and use it to sanitise the message. would be central enough to take care of your concern? [20:14:52] ugh, published. Welcome to GCI! :) [20:14:59] (03PS1) 10Jack Phoenix: Fix fatal (thanks Chad!) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97552 [20:15:06] woot [20:15:41] ^d: ahh, good catch, thanks :) luckily it was a rather obscure code path not normally used (it's only active when FanBoxes ext. is enabled & the appropriate globals are toggled on) [20:15:56] (03CR) 10Jack Phoenix: [C: 032 V: 032] Fix fatal (thanks Chad!) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97552 (owner: 10Jack Phoenix) [20:16:09] (03PS6) 10Manybubbles: Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 [20:16:14] (03PS1) 10Chad: Remove commented $wgArticle usages [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/97553 [20:16:49] <^d> ashley: Grepping for $wgTitle and $wgArticle turns up all kinds of fun stuff :D [20:16:56] <^d> We still have one extension using $wgArticle :( [20:17:08] you should totally grep for wfMsg ;) [20:17:39] <^d> I miss wfMsg() and wfMsgExt() [20:17:42] dan-nl: Yeah, that sounds ok [20:17:42] csteipp, i'll try and stay online in case you have any questions you'd like to address now regarding my gerrit commits. otherwise i'll look for your comments on them as they come in. [20:17:53] csteipp: cool, i'll try that out then [20:18:09] I think we managed to get rid of most of the wfMsg stuff [20:18:20] aye, the introduction of wfMessage was kinda...not so cool; the internals are cool and all, but it shoulda replaced wfMsg IMO [20:18:53] <^d> Too many characters :) [20:20:02] we should have One I18n Function To Rule Them All, and like some other PHP projects, we should call it _ [20:20:30] (03PS1) 10Umherirrender: Fix StatusTest for wikis with $wgContentLanguage != 'en' [core] - 10https://gerrit.wikimedia.org/r/97554 [20:20:49] (03CR) 10Aaron Schulz: [C: 032] Remove commented $wgArticle usages [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/97553 (owner: 10Chad) [20:21:25] <^d> ashley: Brevity is key! [20:21:46] (-; [20:25:42] ugh, heh, a student has already claimed one of your tasks. You can assign your own tasks. [20:26:12] no [20:26:18] i was going to claim that task [20:26:19] damn [20:27:56] mayankmadan, life goes on, and today we just started the second week of GCI :) [20:27:56] (03PS1) 10Chad: Use wfMkdirParents() and wfRecursiveRemoveDir() rather than DIY [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/97555 [20:28:07] <^d> I've really got to stop looking at DPL or I'm going to get sucked in. [20:28:22] <^d> You could spend days on that and not fix half the crap :\ [20:29:33] ^d: and SimpleForms ? [20:29:43] <^d> And a dozen other things. [20:29:45] <^d> *sigh* [20:32:06] ^d: fix our EditEntity test yet? :) [20:36:09] (03CR) 10Nikerabbit: "Bit hard to follow... Is the $message param modified by reference, as it is not returned anywhere?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97507 (owner: 10Ebrahim) [20:41:46] (03PS1) 10Jackmcbarn: Allow InputBoxes to be used to move pages [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/97559 [20:43:01] (03Abandoned) 10Umherirrender: Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [20:48:04] (03CR) 10Ebrahim: "AFAIK https://github.com/wikimedia/mediawiki-extensions-Echo/blob/e0b379d1741c7ffb98d02d644f42dda3b1d94f3f/formatters/BasicFormatter.php#L" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97507 (owner: 10Ebrahim) [20:57:37] (03CR) 10Aaron Schulz: [C: 032] Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 (owner: 10Siebrand) [20:59:12] <^d> aude: Some $wgTitles are easy to remove. Others aren't. [21:00:40] (03Merged) 10jenkins-bot: Set visibility on class properties of Job [core] - 10https://gerrit.wikimedia.org/r/97519 (owner: 10Siebrand) [21:02:21] (03CR) 10Chad: [C: 032] Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 (owner: 10Manybubbles) [21:03:22] (03Merged) 10jenkins-bot: Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 (owner: 10Manybubbles) [21:13:44] (03PS1) 10Chad: Don't use $wgTitle, QuickTemplate has had getSkin() for well over 2 years [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/97564 [21:26:59] (03PS1) 10Gergő Tisza: Fix CirrusSearch dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/97626 [21:27:18] (03PS1) 10Chad: Remove $wgTitle usage in CustomUserSignup [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/97627 [21:28:12] (03CR) 10Jdlrobson: [C: 032] Add mobile as a target on VisualEditor dependencies. [core] - 10https://gerrit.wikimedia.org/r/93915 (owner: 10Robmoen) [21:29:39] (03CR) 10Chad: "For anyone who doesn't believe me that the new data is just as accurate as what we have now: http://p.defau.lt/?KdwrZBgw_iF3LB5eWZCqdw" [extensions/CustomUserSignup] - 10https://gerrit.wikimedia.org/r/97627 (owner: 10Chad) [21:30:33] lols. [21:30:45] <^d> ;-) [21:31:16] that probably only runs on special:userlogin [21:31:23] <^d> Indeed :p [21:31:42] i'd git blame, but can't be arsed. [21:37:05] (03CR) 10BryanDavis: [C: 031] "The only bit I wonder about is way that the jre is included. Prod puppet uses "package { 'openjdk-7-jdk': }" directly in the class though " [vagrant] - 10https://gerrit.wikimedia.org/r/97626 (owner: 10Gergő Tisza) [21:48:21] (03CR) 10jenkins-bot: [V: 04-1] Fix CirrusSearch dependencies [vagrant] - 10https://gerrit.wikimedia.org/r/97626 (owner: 10Gergő Tisza) [21:51:45] (03Merged) 10jenkins-bot: Add mobile as a target on VisualEditor dependencies. [core] - 10https://gerrit.wikimedia.org/r/93915 (owner: 10Robmoen) [21:51:48] (03PS1) 10Legoktm: Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 [21:53:21] (03CR) 10jenkins-bot: [V: 04-1] Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 (owner: 10Legoktm) [21:56:06] (03PS3) 10Legoktm: Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 [21:56:19] (03CR) 10Legoktm: "PS3: Rebase" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [21:56:48] hey csteipp, i've almost got a solution in place for the exception handling, but want to review it tomorrow after a bit of sleep. how are you doing with the other gerrit commits? do you think you'll be able to merge them this week? [21:58:14] (03CR) 10Legoktm: Show an error to the user if the spamlist has no targets on it (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [22:03:00] (03PS4) 10Legoktm: Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 [22:03:22] (03PS2) 10Legoktm: Output the number of recipients on preview [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97628 [22:13:03] (03PS1) 10Theopolisme: Add oldid for target list in hidden comment [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97630 [22:13:45] legoktm: ^ [22:13:51] :D [22:13:55] (Heh, easiest bug fix ever...) [22:19:45] (03PS1) 10Cmcmahon: new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 [22:21:11] (03PS2) 10Cmcmahon: new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 [22:21:24] (03PS3) 10Cmcmahon: new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 [22:21:44] (03CR) 10Legoktm: [C: 04-1] "While it doesn't cause the test to fail, you should update MassMessagetest::testMessageSending." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97630 (owner: 10Theopolisme) [22:24:40] (03PS4) 10Cmcmahon: new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 [22:24:58] (03PS5) 10Cmcmahon: new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 [22:27:41] (03PS2) 10Theopolisme: Add oldid for target list in hidden comment [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97630 [22:29:23] (03PS1) 10Ori.livneh: Avoid extra parsing in prepareContentForEdit() [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97634 [22:32:15] (03CR) 10Parent5446: [C: 031] New hook: OutputPageHtmlAttributes [core] - 10https://gerrit.wikimedia.org/r/97467 (owner: 10Samwilson) [22:36:45] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97630 (owner: 10Theopolisme) [22:36:56] (03Merged) 10jenkins-bot: Add oldid for target list in hidden comment [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97630 (owner: 10Theopolisme) [22:38:24] (03CR) 10Jhall: [C: 031] new test to edit existing title/post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97632 (owner: 10Cmcmahon) [22:52:27] (03CR) 10Ori.livneh: [C: 032] Avoid extra parsing in prepareContentForEdit() [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97634 (owner: 10Ori.livneh) [22:55:39] (03Merged) 10jenkins-bot: Avoid extra parsing in prepareContentForEdit() [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97634 (owner: 10Ori.livneh) [23:02:10] (03PS1) 10Ori.livneh: Update TemplateData to master for I0782ea669 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97645 [23:04:08] (03CR) 10Ori.livneh: [C: 032] Update TemplateData to master for I0782ea669 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97645 (owner: 10Ori.livneh) [23:19:39] (03PS1) 10Mwalker: Updating CN to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97646 [23:21:20] (03PS12) 10Parent5446: Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418 [23:21:27] (03PS2) 10Parent5446: Changed logged out tokens to use session if already there [core] - 10https://gerrit.wikimedia.org/r/76458 [23:22:07] (03CR) 10Mwalker: [C: 032] Updating CN to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97646 (owner: 10Mwalker) [23:22:25] (03CR) 10jenkins-bot: [V: 04-1] Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418 (owner: 10Parent5446) [23:23:19] (03CR) 10jenkins-bot: [V: 04-1] Changed logged out tokens to use session if already there [core] - 10https://gerrit.wikimedia.org/r/76458 (owner: 10Parent5446) [23:24:16] chrismcmahon: ping [23:24:27] hi gwicke [23:24:31] hi! [23:24:50] what is the procedure for testing something on the beta cluster in labs? [23:25:10] I need to check a varnish config change and am wondering if I can use beta for that [23:26:31] (03Merged) 10jenkins-bot: Updating CN to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97646 (owner: 10Mwalker) [23:26:59] gwicke: we have varnish on beta labs, but I think it might be mostly used by the MobileFrontend people. I believe that our Varnish config is through puppet [23:27:24] I thought you have a parsoid setup on beta [23:27:31] I'm referring to the parsoid varnishes [23:27:43] ah, the parsoid. yes, that is a different host [23:28:55] gwicke: I'm not sure where the parsoid host configuration on beta stands right now. could you create a bugzilla ticket for hashar and put me and greg-g on the Cc for it? [23:30:04] chrismcmahon: ah, if it takes longer I'll be quicker to test it elsewhere [23:30:25] is "wikimania scholarship" a mediawiki extension or a standalone application? [23:32:26] (03CR) 10Dzahn: [C: 032 V: 032] Sync to upstream; fix wrong query parameters not used in WM Bugzilla [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97005 (owner: 10Aklapper) [23:32:28] gwicke: yeah, sorry I don't know right off. we *should* be able to test environment tweaks for parsoid on beta easily, and the fact that we can't right now is something of a bug, that's why I would like a bugzilla issue for it. [23:33:31] chrismcmahon: what is your policy on shell access in betalabs? [23:33:47] if I know the host and have a shell on it I'd be happy [23:33:50] quite liberal, I think [23:34:00] you need NDA to get full root, IIRC [23:34:01] root shell, that is [23:34:06] (03PS1) 10Shirayuki: i18n: capitalize URL [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97649 [23:34:09] but i guess gwicke already has it [23:34:12] he asked for shell, not root [23:34:13] gwicke: you should have it I think [23:34:34] since I need to restart varnish I'll need root [23:35:37] chrismcmahon: can you add me to betalabs? [23:38:49] Platonides: "wikimania scholarship" is a stand-alone application [23:40:18] I see [23:40:36] btw, hello Bryan :) [23:41:20] * bd808 waves [23:41:24] gwicke: what is your user name on wikitech? so I can add you to https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep [23:46:01] chrismcmahon: gwicke [23:47:18] (03PS1) 10BryanDavis: Fix gitignore of vim swap files [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/97650 [23:50:08] gwicke: you're now added to that project. I *think* that if you ssh from bastion to deployment-parsoid2 you should have what you need. [23:51:25] chrismcmahon: thanks! I have a shell as user gwicke, but don't seem to have sudo rights [23:58:25] gwicke: you should have sudo now [23:59:01] chrismcmahon: awesome, thanks!