[00:07:20] (03CR) 10Legoktm: Allow posting in all talk namespaces by default (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 (owner: 10Legoktm) [00:15:20] (03PS2) 10Legoktm: Allow posting in all talk namespaces by default [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 [00:15:38] (03CR) 10Legoktm: "PS2: Rebase" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 (owner: 10Legoktm) [00:28:35] (03PS1) 10Aude: Call parent::setUp() in DiffHistoryBlobTest before marking skipped tests [core] - 10https://gerrit.wikimedia.org/r/97352 [00:29:58] (03PS2) 10Aude: Call parent::setUp() in DiffHistoryBlobTest before marking skipped tests [core] - 10https://gerrit.wikimedia.org/r/97352 [00:48:36] (03PS1) 10Aude: Make setUp and tearDown protected in tests [core] - 10https://gerrit.wikimedia.org/r/97355 [01:11:10] Hi , I'm trying to build kiwix for android and I'm getting this error. can anyone help me with this? [01:11:17] BUILD FAILED /home/akhil/kiwix-kiwix/src/dependencies/android-sdk/sdk/tools/ant/build.xml:647: The following error occurred while executing this line: /home/akhil/kiwix-kiwix/src/dependencies/android-sdk/sdk/tools/ant/build.xml:688: Execute failed: java.io.IOException: Cannot run program "/home/akhil/kiwix-kiwix/src/dependencies/android-sdk/sdk/platform-tools/aapt": error=2, No such file or directory at java.lang.ProcessBuilder. [01:11:32] The file exist. [01:14:35] Anyone? [01:15:37] I don't think people in here are familiar with kiwix [01:15:50] Maybe #kiwix? Dunno if that exists... [01:17:28] This is a general question. does anyone have any experience builiding apps from source [01:21:20] (03CR) 10Bartosz Dziewoński: Add legend to Special:RecentChanges and Special:Watchlist (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [01:35:45] Fixed it. [03:11:58] (03PS4) 10Aaron Schulz: Remove leading underscore from methods _getResponseCreate* [core] - 10https://gerrit.wikimedia.org/r/97318 (owner: 10Siebrand) [03:16:43] (03CR) 10Aaron Schulz: [C: 032] Remove leading underscore from methods _getResponse* [core] - 10https://gerrit.wikimedia.org/r/97318 (owner: 10Siebrand) [03:17:50] (03PS2) 10Aaron Schulz: filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 [03:19:15] (03CR) 10jenkins-bot: [V: 04-1] filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 (owner: 10Aaron Schulz) [03:20:24] (03Merged) 10jenkins-bot: Remove leading underscore from methods _getResponse* [core] - 10https://gerrit.wikimedia.org/r/97318 (owner: 10Siebrand) [03:39:44] (03PS3) 10Aaron Schulz: filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 [03:41:50] (03CR) 10jenkins-bot: [V: 04-1] filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 (owner: 10Aaron Schulz) [04:05:15] (03CR) 10Eloquence: "Indeed, I think it's reasonable to phase out MediaWiki:Signupstart in favor of a new, blank by default message, e.g MediaWiki:Signupnotice" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:22:24] (03PS4) 10Aaron Schulz: filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 [04:24:13] (03CR) 10Peachey88: "> Indeed, I think it's reasonable to phase out MediaWiki:Signupstart in favor of a new, blank by default message, e.g MediaWiki:Signupnoti" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [04:28:14] (03PS1) 10Nischayn22: Added checks and updated README [extensions/PageCreationNotif] - 10https://gerrit.wikimedia.org/r/97357 [04:29:49] (03CR) 10Nischayn22: [C: 032 V: 032] Added checks and updated README [extensions/PageCreationNotif] - 10https://gerrit.wikimedia.org/r/97357 (owner: 10Nischayn22) [04:56:15] hello all [04:56:21] I'm a Google Code-In participant [04:56:29] and I'm trying to port nowcommons.py to pywikibot core [04:56:38] how might I test my progress? [05:01:41] microchip_sac, try https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools [05:17:14] (03CR) 10Ori.livneh: [C: 032] jquery.wikiEditor.iframe: Restore function signatures [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96983 (owner: 10Krinkle) [05:17:20] (03Merged) 10jenkins-bot: jquery.wikiEditor.iframe: Restore function signatures [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96983 (owner: 10Krinkle) [05:52:09] (03CR) 10Parent5446: [C: 032 V: 032] Fix extension functionality and backwards compatibility [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 (owner: 10Parent5446) [05:56:59] So if qgil or hexmode come back later, ask them to watch out for me tomorrow [05:57:10] In roughly 9 to 10 hours. [05:57:36] It's about the release notes. Now bye. [06:42:26] (03PS4) 10Siebrand: Set visibility on the class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 [06:42:42] (03PS2) 10Siebrand: Set visibility for class properties in LocalFile.php [core] - 10https://gerrit.wikimedia.org/r/97350 [06:44:04] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [06:44:34] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on class properties in LocalFile.php [core] - 10https://gerrit.wikimedia.org/r/97350 (owner: 10Siebrand) [06:48:08] (03PS1) 10Theopolisme: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 [06:49:02] (03CR) 10Eloquence: "Peachey: The entire account creation form was (successfully) redesigned to increase signup success; see https://meta.wikimedia.org/wiki/R" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [06:50:13] (03PS2) 10Theopolisme: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 [06:56:38] (03PS2) 10Santhosh: LanguageGvTest::testGetPluralRuleType() has never worked [core] - 10https://gerrit.wikimedia.org/r/97337 (owner: 10Platonides) [06:56:58] (03CR) 10Santhosh: "Any problem with $this->markTestSkipped() ?" [core] - 10https://gerrit.wikimedia.org/r/97337 (owner: 10Platonides) [06:57:33] (03CR) 10Parent5446: "@Swalling - Ah, well that would make more sense. This patch, however, *does* remove it entirely. Specifically notice in User::setCookies()" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [06:58:27] (03CR) 10Peachey88: "And if a wiki community wants to display what ever they feel like above the data entry section, It's their prerogative to display what eve" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [07:02:32] (03CR) 10Legoktm: "This works, but it's getting pretty ugly. Can you rebase this onto Addshore's patch at I77abd54a50090229c7f3a3daa239bcb185702e46? I think " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [07:23:26] (03PS1) 10RAZVOR: comi [core] - 10https://gerrit.wikimedia.org/r/97361 [07:28:00] (03CR) 10Liangent: [C: 04-1] "What's this?" [core] - 10https://gerrit.wikimedia.org/r/97361 (owner: 10RAZVOR) [07:31:54] (03PS1) 10RAZVOR: nc [core] - 10https://gerrit.wikimedia.org/r/97363 [07:33:29] (03PS2) 10RAZVOR: nc [core] - 10https://gerrit.wikimedia.org/r/97363 [07:35:05] (03CR) 10jenkins-bot: [V: 04-1] Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97363 (owner: 10RAZVOR) [07:35:07] https://gerrit.wikimedia.org/r/#/c/97363/ [07:41:15] (03PS1) 10RAZVOR: nc [core] - 10https://gerrit.wikimedia.org/r/97364 [07:42:44] (03Abandoned) 10RAZVOR: comi [core] - 10https://gerrit.wikimedia.org/r/97361 (owner: 10RAZVOR) [07:43:36] (03PS2) 10RAZVOR: nc [core] - 10https://gerrit.wikimedia.org/r/97364 [07:45:15] razvor: please don't do test commits in the core section [07:46:38] we have a test repository that you can use https://git.wikimedia.org/project/?p=test [07:48:40] (03PS12) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [07:48:41] (03PS4) 10Legoktm: Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [07:48:42] (03PS1) 10Legoktm: Check the spamlist's content format earlier [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97365 [07:49:00] that seems out of order. [07:52:29] (03PS1) 10Legoktm: Don't parse custom footer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97366 [08:01:41] (03PS10) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [08:01:46] (03CR) 10jenkins-bot: [V: 04-1] Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [08:01:50] :| [08:11:07] (03PS5) 10Legoktm: Move non-SpecialPage specific functions into MassMessage class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [08:11:13] (03CR) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [08:13:12] (03PS1) 10Siebrand: Set visibility on class properties of File [core] - 10https://gerrit.wikimedia.org/r/97367 [08:34:58] (03PS1) 10Siebrand: Set visibility on class properties of ArchivedFile [core] - 10https://gerrit.wikimedia.org/r/97368 [08:40:28] (03PS3) 10RAZVOR: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97364 [09:05:09] (03PS5) 10Siebrand: Set visibility on class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 [09:06:15] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [09:08:59] (03PS1) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [09:13:33] (03PS4) 10Umherirrender: Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 [09:15:10] (03PS2) 10TTO: Fix outdated comment in DefaultSettings [core] - 10https://gerrit.wikimedia.org/r/85420 [09:15:30] (03PS3) 10TTO: Fix outdated comment in DefaultSettings [core] - 10https://gerrit.wikimedia.org/r/85420 [09:15:53] (03PS2) 10TTO: Make edit toolbar Signature button optional in content namespaces [core] - 10https://gerrit.wikimedia.org/r/87649 [09:17:21] (03CR) 10jenkins-bot: [V: 04-1] Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [09:19:03] (03PS2) 10Dan-nl: form-handler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97369 [09:29:11] mm [09:29:41] (03PS1) 10Siebrand: Set visibility on class properties of FileRepo [core] - 10https://gerrit.wikimedia.org/r/97371 [09:30:58] When matmaRex will be here? [09:32:03] (03PS7) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 [09:33:53] 1 [09:35:58] 1 [09:37:01] (03CR) 10Hoo man: [C: 032] Call parent::setUp() in DiffHistoryBlobTest before marking skipped tests [core] - 10https://gerrit.wikimedia.org/r/97352 (owner: 10Aude) [09:40:02] (03Merged) 10jenkins-bot: Call parent::setUp() in DiffHistoryBlobTest before marking skipped tests [core] - 10https://gerrit.wikimedia.org/r/97352 (owner: 10Aude) [09:45:03] (03PS1) 10Siebrand: Declare visibility on class properties of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97373 [09:46:09] (03CR) 10jenkins-bot: [V: 04-1] Declare visibility on class properties of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97373 (owner: 10Siebrand) [09:58:10] (03CR) 10Nikerabbit: "Finally: https://gerrit.wikimedia.org/r/#/c/76705/1/tests/phpunit/includes/DiffHistoryBlobTest.php :)" [core] - 10https://gerrit.wikimedia.org/r/97352 (owner: 10Aude) [10:04:11] (03PS1) 10Nikerabbit: Fix variable name in comments [core] - 10https://gerrit.wikimedia.org/r/97377 [10:06:09] (03CR) 10Legoktm: [C: 032] Fix variable name in comments [core] - 10https://gerrit.wikimedia.org/r/97377 (owner: 10Nikerabbit) [10:09:30] (03Merged) 10jenkins-bot: Fix variable name in comments [core] - 10https://gerrit.wikimedia.org/r/97377 (owner: 10Nikerabbit) [10:10:42] Hello marktraceur [10:11:01] Hello #wikimedia-dev [10:11:11] good morning vietnam [10:12:58] marktraceur: I have hacked OutputPage with ob_get_contents as proposed yesterday. [10:13:04] It works! [10:14:43] I had to add a bunch of global var declarations to Setup.php and WebStart.php and other places. [10:15:08] all $wg.... globals which appear there [10:15:22] 1 [10:17:28] What is the correct way of submitting my 2 or 3 commits? [10:21:36] (03PS1) 10UltrasonicNXT: Allow the disabling of Blog_talk namespace [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/97379 [10:34:47] (03CR) 10Nikerabbit: [C: 04-1] "This is one of the nine languages which have custom convertPlural still left. (Weren't we supposed to get rid of all of those?)" [core] - 10https://gerrit.wikimedia.org/r/97337 (owner: 10Platonides) [10:55:24] (03PS1) 10Nemo bis: Add bottrop variant by L. Diener [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/97381 [10:57:19] (03PS2) 10Nemo bis: Add bottrop variant by L. Diener [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/97381 [10:57:58] (03CR) 10Nemo bis: "Hmm it went to the wrong branch. No time to fix today" [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/97381 (owner: 10Nemo bis) [10:59:37] (03CR) 10Legoktm: Add bottrop variant by L. Diener (032 comments) [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/97381 (owner: 10Nemo bis) [11:00:01] (03PS1) 10Legoktm: Add bottrop variant by L. Diener [extensions/SimpleAntiSpam] (bottrop) - 10https://gerrit.wikimedia.org/r/97382 [11:00:12] Nemo_bis: ^ I just used the "cherry pick to button" [11:00:45] legoktm: so I can abandon mine, right? [11:00:50] yeah [11:01:10] (03Abandoned) 10Nemo bis: Add bottrop variant by L. Diener [extensions/SimpleAntiSpam] - 10https://gerrit.wikimedia.org/r/97381 (owner: 10Nemo bis) [11:01:46] are you going to work on it right now or should I start cleaning it up? [11:02:50] not now for sure [11:15:18] anyone familiar with oauth? [11:28:38] Ahmad96_________, fix your connection please [11:28:54] any ops around? [11:29:30] (03PS2) 10Legoktm: Add bottrop variant by L. Diener [extensions/SimpleAntiSpam] (bottrop) - 10https://gerrit.wikimedia.org/r/97382 [11:30:16] (03PS3) 10Legoktm: Add bottrop variant by L. Diener [extensions/SimpleAntiSpam] (bottrop) - 10https://gerrit.wikimedia.org/r/97382 [11:37:00] (03PS1) 10UltrasonicNXT: Allow the removal of various features [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97383 [11:56:44] (03PS4) 10MarkAHershberger: Restore MediaWiki:Signupstart for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 [11:58:57] (03CR) 10Bartosz Dziewoński: "> It originally seemed like a pretty simple project (i managed to hack in the basic features in under an hour), but all this checking and " [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [11:59:13] (03PS5) 10MarkAHershberger: Restore MediaWiki:Signupstart for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 [12:05:37] (03CR) 10MarkAHershberger: "Added a global ($wgCleanLoginUX) that, if set to true, doesn't display the old messages. This allows WMF wikis to set it true when $wmfRe" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [12:21:44] (03CR) 10Jack Phoenix: [C: 04-1] "No doubt that the whole namespace in question (as well as SocialProfile's User_profile_talk or LinkFilter's Link_talk) is very silly, but " [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/97379 (owner: 10UltrasonicNXT) [12:25:32] (03CR) 10Bartosz Dziewoński: "And I guess I could also say, welcome to the world of large codebases worked on by large groups of people, with their sets of quirks, conv" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [12:32:18] (03Abandoned) 10UltrasonicNXT: Allow the disabling of Blog_talk namespace [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/97379 (owner: 10UltrasonicNXT) [12:34:24] (03CR) 10Jack Phoenix: [C: 04-1] "There's also an associated bug ticket about this on Bugzilla: https://bugzilla.wikimedia.org/show_bug.cgi?id=44607" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97303 (owner: 10UltrasonicNXT) [13:00:08] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I looked closely now and I believe this is the final round of comments, mostly minor ones :) Thank you! Hopefully we can close this up tod" (038 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [13:04:43] (03PS2) 10UltrasonicNXT: Add user_points SQL files into SocialProfile [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97303 [13:26:50] (03CR) 10Platonides: "Santhosh, my problem are the 71 useless lines added to the phpunit output because “convertPlural for gv doesn't seem to actually follow ou" [core] - 10https://gerrit.wikimedia.org/r/97337 (owner: 10Platonides) [13:55:13] Hi! I am a GCI student. [13:55:25] (03CR) 10Jack Phoenix: [C: 032 V: 032] Add user_points SQL files into SocialProfile [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97303 (owner: 10UltrasonicNXT) [13:56:17] I have a very basic knowledge of C++ and HTML. Can I participate in GCI ? [14:00:55] riddimiddi find C++ tasks [14:02:16] hi riddimiddi [14:02:48] I think we may have some css-related tasks [16:10:39] (03CR) 10Nikerabbit: [C: 04-1] Remove unused local variable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97322 (owner: 10Siebrand) [16:13:35] (03CR) 10Nikerabbit: "It looks like the svg files could be optimized more for smaller file size. Unfortunately I don't have documentation how to do that." [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [16:30:09] (03PS3) 10Theopolisme: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 [16:30:16] (03CR) 10Kipcool: [C: 032 V: 032] OmegaWiki TAGS [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/95994 (owner: 10Hiong3-eng5) [16:30:31] (03CR) 10Kipcool: [C: 032 V: 032] Remove Duplicate Expressions [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/96929 (owner: 10Hiong3-eng5) [16:32:24] (03CR) 10Kipcool: [C: 032 V: 032] API batch transaction, conserve transaction [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/96955 (owner: 10Hiong3-eng5) [16:44:26] (03PS8) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 [16:44:35] (03PS3) 10Theopolisme: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 [16:46:31] (03CR) 10jenkins-bot: [V: 04-1] jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 (owner: 10Theopolisme) [16:46:54] whoops... [16:47:56] (03PS4) 10Theopolisme: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 [16:49:29] (03CR) 10Scimonster: "I guess that's everything then. I'm marking it as complete on GCI." [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [17:07:00] (03CR) 10MZMcBride: "Follow-up: bug 56455." [core] - 10https://gerrit.wikimedia.org/r/55847 (owner: 10Spage) [17:08:25] Anyone interested in the 1.22 release notes I can talk with? [17:12:05] (03CR) 10Bartosz Dziewoński: Add legend to Special:RecentChanges and Special:Watchlist (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [17:12:28] HectorAE: hi, about what exactly? [17:12:42] HectorAE: (it's weekend, so most people who usually sit in this channel are not here) [17:12:48] Oh really [17:12:57] I picked a bad time for that task... [17:13:10] (03PS1) 10Cscott: Travis configuration was installing inkscape rather than imagemagick. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97387 [17:13:11] But anyway, I was thinking we should reorganize the page a bit. [17:14:04] (03PS9) 10Bartosz Dziewoński: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [17:14:18] (03CR) 10Cscott: [C: 032] Travis configuration was installing inkscape rather than imagemagick. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97387 (owner: 10Cscott) [17:14:27] hexmode: you mean this page: https://www.mediawiki.org/wiki/MediaWiki_1.22 , right? [17:14:32] I think we should keep the upgrade notices, but move things around a bi [17:14:35] Yes. [17:14:57] I've been pretty much the only one working on it for a few days [17:15:07] And I need some feedback [17:15:14] (03Merged) 10jenkins-bot: Travis configuration was installing inkscape rather than imagemagick. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97387 (owner: 10Cscott) [17:15:27] HectorAE: if you want somebody who is supposed to know all about this ;), then qgil (your GCI task's mentor, i think) or hexmode (release manager) would be the right people [17:15:50] Yes, I know, I've been waiting around for them. [17:15:52] HectorAE: but if you'll accept somebody who is a jack of all trades (master of none), then i'm here. :P [17:16:03] Well you're better than nothing, MatmaRex. [17:16:17] haha :D [17:17:19] Looking at it right now, I think probably we should put all extension-related news under one subsection and all UI news under another [17:17:43] Expand both of those a bit so we don't have two subsections with only one sentence each [17:19:45] (03CR) 10Bartosz Dziewoński: [C: 032] "Alright! Thank you :)" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [17:20:28] HectorAE: sounds sane [17:20:57] Except my edit where I replaced the "User accounts" section with just a screenshot was reverted [17:21:28] Edit summary: style [17:22:03] hmm? [17:22:12] maybe that was accidental [17:22:38] https://www.mediawiki.org/w/index.php?title=MediaWiki_1.22&diff=827229&oldid=827207 looks like the screenshot was moved higher up on the page [17:22:46] (03Merged) 10jenkins-bot: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [17:23:07] Yes but they also kept the single sentence subsection [17:23:35] I don't think there's really a need for that _and_ a screenshot [17:24:24] i don't know. maybe just ask Shirayuki about that? :) [17:24:33] i think the screenshot itself would suffice [17:24:42] Yeah, I'll talk to them [17:34:16] (03PS1) 10Bartosz Dziewoński: SpecialRecentChanges: Use $wgRecentChangesFlags in makeLegend() [core] - 10https://gerrit.wikimedia.org/r/97388 [17:34:28] (03CR) 10Bartosz Dziewoński: "Followup to use $wgRecentChangesFlags: https://gerrit.wikimedia.org/r/97388 . Turned out to be easier than it looked." [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [17:38:06] (03CR) 10MZMcBride: "Follow-up: bug 56455." [core] - 10https://gerrit.wikimedia.org/r/67233 (owner: 10Spage) [17:39:13] (03CR) 10MZMcBride: "Follow-up: bug 56455." [core] - 10https://gerrit.wikimedia.org/r/57823 (owner: 10Mattflaschen) [17:41:09] Okay I left a message on Shirayuki's talk page [17:41:47] Except it looks really weird because it's in a Flow section under the old normal sections... [17:45:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(Just noting this here so we know where we're standing. (And especially, so that I know where we're standing.))" [core] - 10https://gerrit.wikimedia.org/r/97348 (owner: 10Theopolisme) [17:54:28] (03CR) 10Scimonster: [C: 031] SpecialRecentChanges: Use $wgRecentChangesFlags in makeLegend() [core] - 10https://gerrit.wikimedia.org/r/97388 (owner: 10Bartosz Dziewoński) [17:59:25] (03CR) 10Bartosz Dziewoński: "Oh come on people, this is trivial, isn't it?" [core] - 10https://gerrit.wikimedia.org/r/95361 (owner: 10Bartosz Dziewoński) [18:19:50] (03PS5) 10Theopolisme: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 [19:26:18] (03PS6) 10Wikinaut: Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [19:47:10] (03PS1) 10Raimond Spekking: Remove message 'expandtemplates-desc' [core] - 10https://gerrit.wikimedia.org/r/97389 [19:58:08] (03CR) 10Bartosz Dziewoński: [C: 032] "Bah. Thank you. I assume there is no automated tool that checks this in any way, is there?" [core] - 10https://gerrit.wikimedia.org/r/97389 (owner: 10Raimond Spekking) [20:01:07] (03Merged) 10jenkins-bot: Remove message 'expandtemplates-desc' [core] - 10https://gerrit.wikimedia.org/r/97389 (owner: 10Raimond Spekking) [20:17:38] (03CR) 10Hoo man: [C: 032] "Awesome... this makes the Wikidata "D" appear in the legend :)" [core] - 10https://gerrit.wikimedia.org/r/97388 (owner: 10Bartosz Dziewoński) [20:18:24] (03CR) 10Hashar: [C: 032] Update documentation of MediaHandler [core] - 10https://gerrit.wikimedia.org/r/97313 (owner: 10Siebrand) [20:20:23] (03PS7) 10Wikinaut: Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [20:20:53] (03Merged) 10jenkins-bot: SpecialRecentChanges: Use $wgRecentChangesFlags in makeLegend() [core] - 10https://gerrit.wikimedia.org/r/97388 (owner: 10Bartosz Dziewoński) [20:22:27] (03Merged) 10jenkins-bot: Update documentation of MediaHandler [core] - 10https://gerrit.wikimedia.org/r/97313 (owner: 10Siebrand) [20:24:15] (03CR) 10Legoktm: [C: 04-1] Perform checks before thanking via API (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [21:01:16] (03CR) 10Aaron Schulz: [C: 032] Set visibility on class properties of FileRepo [core] - 10https://gerrit.wikimedia.org/r/97371 (owner: 10Siebrand) [21:04:20] (03Merged) 10jenkins-bot: Set visibility on class properties of FileRepo [core] - 10https://gerrit.wikimedia.org/r/97371 (owner: 10Siebrand) [21:06:59] (03PS8) 10Wikinaut: Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [21:07:39] * HectorAE sighs [21:08:15] (03PS9) 10Wikinaut: Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [21:13:14] (03PS10) 10Wikinaut: Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [21:14:13] (03CR) 10Aaron Schulz: [C: 032] Limit job queue rate and wait for completion [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 (owner: 10Manybubbles) [21:14:22] (03Merged) 10jenkins-bot: Limit job queue rate and wait for completion [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 (owner: 10Manybubbles) [21:16:44] (03CR) 10Aaron Schulz: [C: 032] Only link to specific revision in log entry if page still exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97116 (owner: 10Legoktm) [21:16:58] (03Merged) 10jenkins-bot: Only link to specific revision in log entry if page still exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97116 (owner: 10Legoktm) [21:17:52] (03CR) 10Wikinaut: [C: 031 V: 031] "works fine !" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [21:25:00] (03CR) 10Wikinaut: [C: 032 V: 032] "ok" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [21:26:51] gerritspam incoming! [21:27:00] (03PS3) 10Bartosz Dziewoński: SpecialWatchlist: Don't overwrite context now that we don't have to [core] - 10https://gerrit.wikimedia.org/r/94289 [21:27:01] (03PS5) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 [21:27:02] (03PS3) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 [21:27:03] (03PS7) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 [21:27:04] (03PS2) 10Bartosz Dziewoński: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 [21:27:05] (03PS2) 10Bartosz Dziewoński: SpecialWatchlist: Reorder some stuff in #execute [core] - 10https://gerrit.wikimedia.org/r/94627 [21:27:06] (03PS2) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 [21:27:07] (03PS7) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges: step 1 [core] - 10https://gerrit.wikimedia.org/r/89379 [21:27:08] (03PS1) 10Bartosz Dziewoński: Always load 'mediawiki.special.changeslist' on SpecialRecentChanges and subclasses [core] - 10https://gerrit.wikimedia.org/r/97451 [21:27:17] pow. [21:27:20] that was a nice rebase. [21:38:08] (03Draft2) 10Wikinaut: follow-up to I1ec8d99da9e74966425e4505340205413b37718e [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97452 [21:38:16] (03CR) 10Wikinaut: [C: 032 V: 032] follow-up to I1ec8d99da9e74966425e4505340205413b37718e [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97452 (owner: 10Wikinaut) [21:47:18] (03PS1) 10M4tx: Add SVG versions of toolbar icons [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/97454 [22:03:58] (03CR) 10Bartosz Dziewoński: "So I tested it, and…" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [22:14:02] (03PS1) 10Reedy: Swap Title::newFromUrl for Title::newFromText [core] - 10https://gerrit.wikimedia.org/r/97455 [22:14:06] (03PS6) 10Theopolisme: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 [22:16:36] (03CR) 10Aaron Schulz: [C: 032] Swap Title::newFromUrl for Title::newFromText [core] - 10https://gerrit.wikimedia.org/r/97455 (owner: 10Reedy) [22:20:14] (03Merged) 10jenkins-bot: Swap Title::newFromUrl for Title::newFromText [core] - 10https://gerrit.wikimedia.org/r/97455 (owner: 10Reedy) [22:45:51] (03PS4) 10Theopolisme: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 [22:50:53] (03PS7) 10Theopolisme: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 [23:04:13] (03CR) 10Bartosz Dziewoński: [C: 032] "Appears to work perfectly and doesn't break any existing test cases. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/97348 (owner: 10Theopolisme) [23:07:34] (03Merged) 10jenkins-bot: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 (owner: 10Theopolisme) [23:13:29] (03CR) 10Legoktm: [C: 04-1] Perform checks before thanking via API (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [23:16:39] hi theopolishme [23:16:59] hey [23:18:17] (03PS4) 10Legoktm: Split Api Module into lovely small functions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/93316 (owner: 10Addshore) [23:18:34] (03CR) 10Legoktm: [C: 032] Split Api Module into lovely small functions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/93316 (owner: 10Addshore) [23:18:42] (03Merged) 10jenkins-bot: Split Api Module into lovely small functions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/93316 (owner: 10Addshore) [23:21:05] (03CR) 10Legoktm: [C: 04-1] Add basic unit test for dieOnBadUser api method (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 (owner: 10Addshore) [23:23:13] hi Nemo_bis [23:27:32] (03PS5) 10Theopolisme: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 [23:27:34] (03CR) 10jenkins-bot: [V: 04-1] Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [23:27:57] *groans* [23:28:16] (03CR) 10Legoktm: "I don't understand why the revision ids need to be set to 0. They're already disabled with 'enabled' => false. Shouldn't we include the re" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96902 (owner: 10Bsitu) [23:28:31] (03PS6) 10Legoktm: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [23:28:40] (03CR) 10jenkins-bot: [V: 04-1] Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [23:29:02] theopolisme: well, at least this time it's a real failure :) [23:29:06] Haha [23:29:19] theopolisme: looks like you just need to fix the tests [23:29:24] Indeed [23:41:32] (03PS7) 10Theopolisme: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 [23:45:24] (03CR) 10Legoktm: [C: 032] Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [23:45:32] (03Merged) 10jenkins-bot: Perform checks before thanking via API [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97358 (owner: 10Theopolisme) [23:51:27] (03PS1) 10Aaron Schulz: More file backend docs [core] - 10https://gerrit.wikimedia.org/r/97457 [23:53:17] * HectorAE pings hexmode [23:53:25] AaronSchulz: hi, do you have some time to review https://gerrit.wikimedia.org/r/#/c/97162 ? [23:53:54] (and thanks for the merges earlier) [23:54:22] why didn't you put that line in the constructor? [23:56:10] (03PS5) 10Wikinaut: make SpecialChangePassword form text depending on login status of wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [23:56:47] isn't the constructor called on meta and not the target site? I'm not sure how exactly jobs are stored/serialized [23:56:57] Basically that line needs to be executed on the target site [23:58:03] I'm kind of regretting picking such an open-ended task... [23:58:07] Also, hola mayankmadan. [23:58:34] hi HectorAE :) [23:59:19] How [23:59:28] Ahem, how are your tasks going? [23:59:43] HectorAE, Not very good at the moment