[00:07:05] (03PS1) 10Darkdadaah: No format for lists [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/97146 [00:07:10] (03PS1) 10Ori.livneh: Update PagedTiffHandler to master for I52fe2ec25 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97147 [00:08:41] (03PS1) 10Ori.livneh: Update PagedTiffHandler to master for I52fe2ec25 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97148 [00:09:16] greg-g: this is a fix for 57359 ^ [00:09:41] aaron reviewed the patch, we'd feel better about the state of prod with this in place [00:10:07] ah, the stupid /tmp bug? [00:10:15] yeah [00:10:45] i'm cool with that, tested enough? :) [00:11:28] yep [00:12:26] (03CR) 10Ori.livneh: [C: 032] Update PagedTiffHandler to master for I52fe2ec25 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97147 (owner: 10Ori.livneh) [00:12:39] (03CR) 10Ori.livneh: [C: 032] Update PagedTiffHandler to master for I52fe2ec25 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97148 (owner: 10Ori.livneh) [00:15:37] (03Merged) 10jenkins-bot: Update PagedTiffHandler to master for I52fe2ec25 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97147 (owner: 10Ori.livneh) [00:15:56] jenkins-bot merging patches on friday evening pst! [00:17:14] (03Merged) 10jenkins-bot: Update PagedTiffHandler to master for I52fe2ec25 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97148 (owner: 10Ori.livneh) [00:17:54] (03CR) 10Bsitu: Avoid fatal error when mentioning invalid user (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97042 (owner: 10EBernhardson) [00:27:29] AaronSchulz: around? someone found a massmessage bug which I think is due to how the job queue works [00:28:04] or maybe this is in the Title class [00:28:05] hm, [00:38:08] (03PS1) 10Reedy: Update MobileFrontend to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97154 [00:39:01] (03CR) 10Reedy: [C: 032 V: 032] Update MobileFrontend to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97154 (owner: 10Reedy) [00:39:12] (03PS1) 10Reedy: Update MobileFrontend to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97155 [00:39:26] (03CR) 10Reedy: [C: 032 V: 032] Update MobileFrontend to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97155 (owner: 10Reedy) [00:40:33] (03PS1) 10Reedy: Update Wikibase to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97157 [00:40:48] errr, [00:40:52] Reedy: ? [00:40:56] not master [00:41:07] haha [00:41:11] Abandon that one :D [00:41:13] yeah [00:41:15] * aude got it [00:41:21] (03Abandoned) 10Reedy: Update Wikibase to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97157 (owner: 10Reedy) [00:41:23] waiting for my patch to merge [00:41:24] thanks [00:41:26] (03PS1) 10Andrew Bogott: Pull in some updates to OSM. [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97158 [00:42:55] BAH [00:43:00] MF doesn't want to go to master either [00:43:01] FAIL [00:43:17] (03PS1) 10Aude: Update Wikibase, fix for action=info [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97159 [00:43:39] Reedy: https://gerrit.wikimedia.org/r/#/c/97159/ [00:44:12] (03PS1) 10Reedy: Update MF to head of wmf5 branch [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97160 [00:45:14] (03PS1) 10Reedy: Update MF to head of wmf4 branch [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97161 [00:45:16] (03PS2) 10Reedy: Update Wikibase, fix for action=info [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97159 (owner: 10Aude) [00:45:22] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, fix for action=info [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97159 (owner: 10Aude) [00:45:31] (03PS2) 10Reedy: Update MF to head of wmf5 branch [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97160 [00:45:39] (03CR) 10Reedy: [C: 032 V: 032] Update MF to head of wmf5 branch [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97160 (owner: 10Reedy) [00:45:52] (03CR) 10Reedy: [C: 032 V: 032] Update MF to head of wmf4 branch [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97161 (owner: 10Reedy) [00:46:01] would it be possible to use all unstyled 's instead of styling them [00:49:26] like here: https://en.wikipedia.org/w/index.php?title=Special:UserLogin [00:49:34] (03PS1) 10Legoktm: Create a fresh Title object in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 [00:49:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Two quick comments. I'll test this and think some more tomorrow." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [00:49:36] (03PS1) 10MarkTraceur: Move file to adhere to module declaration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/97163 [00:49:37] ori-l: ^^ [00:49:43] (03PS1) 10Aaron Schulz: Clean up MimeMagic singleton handling [core] - 10https://gerrit.wikimedia.org/r/97164 [00:50:33] Reedy: if you're still doing backports...any chance I can get https://gerrit.wikimedia.org/r/#/c/97162 in? global message delivery is somewhat broken due to it [00:51:54] स्वागतम् [00:55:41] legoktm: what is 'somewhat broken'? [00:56:34] ori-l: if the namespace you're sending to is an interwiki prefix on meta, the message fails and an error is logged [00:56:50] this is breaking any messages sent to [[Wikipedia:*]] and other project pages [01:00:48] (03PS1) 10Reedy: Load SpamBlacklist from meta over HTTPS [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/97167 [01:03:02] (03CR) 10Aaron Schulz: [C: 032] Create a fresh Title object in the job (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:03:15] (03CR) 10jenkins-bot: [V: 04-1] Create a fresh Title object in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:03:22] :| [01:03:25] (03CR) 10Aaron Schulz: "Gah, didn't mean to +2" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:06:43] (03CR) 10Aaron Schulz: [C: 032] If a user has a temporary password set, still take over the account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97117 (owner: 10Legoktm) [01:07:07] (03CR) 10Legoktm: Create a fresh Title object in the job (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:07:16] (03CR) 10Jeroen De Dauw: "Hashar: we are well aware that you want these things to happen and that you at the same time do not have the time to get it done. This is " [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [01:07:26] AaronSchulz: I'm not sure if my assumptions on how the job queue work are correct. [01:08:24] (03CR) 10Bsitu: Use explicit transactions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [01:09:07] (03CR) 10TTO: [C: 04-1] "This seems to be a test commit; please do not upload these to Gerrit." [core] - 10https://gerrit.wikimedia.org/r/97057 (owner: 10RAZVOR) [01:09:35] (03CR) 10jenkins-bot: [V: 04-1] Create a fresh Title object in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:09:49] (03Merged) 10jenkins-bot: If a user has a temporary password set, still take over the account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97117 (owner: 10Legoktm) [01:09:54] (03PS2) 10Legoktm: Create a fresh Title object in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 [01:09:58] (03PS1) 10Reedy: Make WebRequest::protocol protected as it's used in subclasses in the same file [core] - 10https://gerrit.wikimedia.org/r/97168 [01:10:03] ^^ easy bug is easy [01:10:23] (03CR) 10Legoktm: Create a fresh Title object in the job (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97162 (owner: 10Legoktm) [01:11:43] (03CR) 10Krinkle: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [01:20:46] Can anyone explain to me how dynamic sidebars and GROUP-SIDEBAR works? [01:21:01] I'm just trying to add something to the wikitech sidebar… turns out to be obscure! [01:27:51] nm, found it! [01:49:51] (03CR) 10Legoktm: [C: 032] Make WebRequest::protocol protected as it's used in subclasses in the same file [core] - 10https://gerrit.wikimedia.org/r/97168 (owner: 10Reedy) [01:50:16] legoktm: I didn't play the blame game... [01:50:25] neither did I [01:52:54] (03Merged) 10jenkins-bot: Make WebRequest::protocol protected as it's used in subclasses in the same file [core] - 10https://gerrit.wikimedia.org/r/97168 (owner: 10Reedy) [01:57:45] (03PS7) 10Legoktm: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [02:01:45] (03PS3) 10Tholam: Add warning that patches should go to Gerrit instead of Bugzilla [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 [02:02:59] (03CR) 10Legoktm: "@Bartosz: done, but I'd feel bad for not giving you credit since some of this patch is yours. Can I add you as a co-author in the commit m" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [02:09:35] (03PS6) 10Theopolisme: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 [02:21:45] (03CR) 10Legoktm: [C: 032] "Tested, works like expected. The i18n messages are a bit awkward, but that wasn't introduced in this patch. Bug 57273 is about making them" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [02:21:55] (03CR) 10jenkins-bot: [V: 04-1] Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [02:22:44] awk [02:23:30] haha [02:24:12] that's an interesting test failure. [02:24:34] theopolisme: you're going to have to fix the test I think. [02:24:41] Ugh [02:26:15] theopolisme: and fyi, to run the tests you can do php core/tests/phpunit/phpunit.php core/extensions/Echo/tests/SomeTest.php [02:26:28] Cool, thanks. I think I see what needs to be done [02:26:42] great :D [02:38:25] (03CR) 10Legoktm: [C: 031] Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [02:39:19] (03CR) 10Legoktm: "Hit publish too early..looks good to me, just needs release notes added to the RELEASE-NOTES-1.23 file." [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [02:42:52] (03CR) 10Huji: "Yes. Apologies for that." [core] - 10https://gerrit.wikimedia.org/r/88670 (owner: 10Huji) [02:47:52] Hi can anyone help me with my Google Code In Task [02:49:37] Its about KIWIX [02:49:49] #kiwix is probably more help.. [02:51:33] All of them are from different time zones so ... And most of my questions are about general development [02:53:46] I think they are european based [02:54:44] class role::download::primary .. include download::kiwix [02:55:03] brandnew roles :P [02:55:21] but yea, not kiwix development itself, that's the server setup [02:55:43] Yes, thats the problem. My task is to add a history button to the kiwix app. Its simple but I don't know which files to edit [02:57:23] For starters, they've multiple different clients [02:57:24] Akhil_: i'd try the lists or maybe even twitter to get around the need for real time answer then http://www.kiwix.org/wiki/Communication [02:57:51] (03CR) 10Legoktm: [C: 04-1] "$mList is mentioned in docs/hooks.txt for the SpecialPage_initList hook" [core] - 10https://gerrit.wikimedia.org/r/96797 (owner: 10Chad) [03:32:04] (03PS7) 10Theopolisme: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 [03:33:10] (03CR) 10Legoktm: [C: 031] "Tests pass, I'll let someone else +2 because this is going into areas I'm not totally familiar with." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [05:29:31] (03PS1) 10RAZVOR: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97182 [05:30:49] (03CR) 10jenkins-bot: [V: 04-1] page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97182 (owner: 10RAZVOR) [05:32:19] (03PS1) 10Legoktm: Don't use @deprecated for parameters [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97184 [05:33:33] (03PS1) 10MarkAHershberger: Restore MediaWiki:Signupstart for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 [05:34:12] (03CR) 10jenkins-bot: [V: 04-1] Restore MediaWiki:Signupstart for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [05:34:24] (03PS2) 10Legoktm: Restore MediaWiki:Signupstart for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [05:34:45] :D [05:40:01] (03PS1) 10RAZVOR: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97186 [05:41:14] (03CR) 10jenkins-bot: [V: 04-1] page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97186 (owner: 10RAZVOR) [05:51:37] (03PS1) 10RAZVOR: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97187 [05:51:38] (03PS1) 10RAZVOR: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97188 [05:51:58] (03CR) 10Eloquence: "As is, won't this reinstate the message also on Wikimedia wikis that have it, e.g. https://de.wikipedia.org/wiki/MediaWiki:Signupstart ? I" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [05:53:46] (03CR) 10jenkins-bot: [V: 04-1] page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97188 (owner: 10RAZVOR) [06:17:31] (03PS3) 10MarkAHershberger: Restore MediaWiki:Signupstart for account creation [core] - 10https://gerrit.wikimedia.org/r/97185 [06:21:34] (03PS1) 10Legoktm: Check supposed revision being reverted is on the same page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97191 [06:24:13] (03CR) 10MarkAHershberger: "Mergeing to REL1_22 so we can make a tarball release with this." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [06:25:03] (03PS1) 10MarkAHershberger: Restore MediaWiki:Signupstart for account creation [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97192 [06:36:58] (03PS2) 10Legoktm: Don't send rollback notification if nothing changed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95797 (owner: 10Alex Monk) [06:37:12] (03CR) 10Legoktm: [C: 032] Don't send rollback notification if nothing changed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95797 (owner: 10Alex Monk) [06:37:20] (03Merged) 10jenkins-bot: Don't send rollback notification if nothing changed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95797 (owner: 10Alex Monk) [07:14:11] (03PS4) 10Legoktm: Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 [07:14:12] (03CR) 10Legoktm: Add Special:Thanks as a non-JS fallback (038 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [07:14:22] (03CR) 10jenkins-bot: [V: 04-1] Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [07:20:53] (03PS5) 10Legoktm: Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 [07:25:51] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, overall. There are some problems with the test file, and some minor issues elsewhere (e.g. comments with missing info)." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [07:26:53] (03PS1) 10Legoktm: Thanks is not using namespaces [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97195 [07:29:52] (03CR) 10Wikinaut: [C: 04-1] "Hashar, Parent5446:" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [07:41:20] (03CR) 10Swalling: [C: 04-1] "The problem of messages like https://de.wikipedia.org/wiki/MediaWiki:Signupstart that Erik pointed is precisely why I requested we make a " [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [07:43:17] (03CR) 10Legoktm: "@Swalling: That's breaking backwards-compatability for no good reason except for "people have misused this message"." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [07:48:23] (03PS1) 10Mattflaschen: Mark ApiThank as requiring write [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97199 [07:48:55] (03CR) 10Peachey88: "> If WMF wikis have abused the message, fix those." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [07:49:15] (03CR) 10Legoktm: [C: 04-1] "Nice catch. You'll have to modify the JS to send a POST request, since it's just sending GET ones right now." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97199 (owner: 10Mattflaschen) [07:53:21] (03CR) 10Legoktm: "Or...maybe not. That's a different variable apparently. Will test." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97199 (owner: 10Mattflaschen) [07:54:09] (03CR) 10Peachey88: "I wouldn't call having information such as this (From the de: message) all that bad anyway..." [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [07:55:28] (03CR) 10TTO: "Sorry - I was tossing and turning in bed last night when I realised this probably hadn't even been deployed yet..." [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [07:55:35] (03CR) 10Mattflaschen: "Yeah, testing welcome, but mustBePosted is separate, and it WFM." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97199 (owner: 10Mattflaschen) [07:57:04] (03CR) 10Legoktm: [C: 032] "Yup, tested, works fine." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97199 (owner: 10Mattflaschen) [07:57:13] (03Merged) 10jenkins-bot: Mark ApiThank as requiring write [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/97199 (owner: 10Mattflaschen) [08:01:45] (03CR) 10Mattflaschen: "Comment inline re write mode. See https://gerrit.wikimedia.org/r/#/c/97199/ , just merged, marking it as requiring write." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [08:10:50] (03CR) 10Mattflaschen: "Specifically regarding your example of German Wikipedia, I don't think such a long message about choosing a username is necessary on the a" [core] - 10https://gerrit.wikimedia.org/r/97185 (owner: 10MarkAHershberger) [08:34:50] (03Draft3) 10Wikinaut: Bug 45304: show correct button texts for login/create account/convert OpenID [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97202 [08:36:22] (03CR) 10Hoo man: "I'm not a big fan of deploying this without at least having a CentralAuth bug for this change (even better would be a CA patch)." [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [08:38:10] (03PS4) 10Wikinaut: Bug 45304: show correct button texts for login/create account/convert OpenID [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97202 [08:38:56] (03CR) 10Hoo man: [C: 032] "No concerns raised in a week... go for it \o/" [core] - 10https://gerrit.wikimedia.org/r/74170 (owner: 10Daniel Kinzler) [08:41:05] (03CR) 10Wikinaut: [C: 032 V: 032] Bug 45304: show correct button texts for login/create account/convert OpenID [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97202 (owner: 10Wikinaut) [08:42:04] (03Merged) 10jenkins-bot: Detect leakage of error_reporting state in tests. [core] - 10https://gerrit.wikimedia.org/r/74170 (owner: 10Daniel Kinzler) [08:43:26] (03CR) 10Hoo man: [C: 032] mediawiki.Title: Add 'params' parameter to #getUrl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95778 (owner: 10Bartosz Dziewoński) [08:46:32] (03Merged) 10jenkins-bot: mediawiki.Title: Add 'params' parameter to #getUrl [core] - 10https://gerrit.wikimedia.org/r/95778 (owner: 10Bartosz Dziewoński) [08:56:38] (03CR) 10Wikinaut: "I still think, that originally $wgUser was meant, perhaps you can ask around." [core] - 10https://gerrit.wikimedia.org/r/96651 (owner: 10Wikinaut) [09:18:55] (03CR) 10Aklapper: [C: 031] "Perfect! +1" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 (owner: 10Tholam) [09:26:50] (03CR) 10Hashar: "That is Tyler Romeo patch. I usually don't code on extensions." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [09:27:35] (03PS3) 10Dan-nl: filter [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 [09:30:50] (03CR) 10Dan-nl: "- addressed chris’ comment in ps2, includes/Utils.php" (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 (owner: 10Dan-nl) [09:44:24] (03PS1) 10Umherirrender: Use lowercase null [core] - 10https://gerrit.wikimedia.org/r/97207 [09:55:51] (03PS1) 10Shirayuki: i18n: fix double-space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/97208 [09:59:07] (03PS1) 10Shirayuki: i18n: double space [extensions/RSS] - 10https://gerrit.wikimedia.org/r/97209 [10:00:33] (03PS6) 10Dan-nl: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 [10:01:00] (03PS7) 10Dan-nl: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 [10:07:34] (03CR) 10Aude: "would be great to get this in or otherwise lego's patch for non-js (then I can rework/rebase this) :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 (owner: 10Aude) [10:14:36] (03PS1) 10Tpt: Add custom DifferenceEngine for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97210 [10:18:22] (03PS11) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [10:18:45] (03PS2) 10Tpt: Add custom DifferenceEngine for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97210 [10:24:15] (03PS1) 10Shirayuki: i18n: add a period after "etc" [core] - 10https://gerrit.wikimedia.org/r/97212 [10:34:59] (03PS3) 10Tpt: Add custom DifferenceEngine for Page: pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97210 [10:42:58] (03PS1) 10Aude: Replace usage of deprecated Linker::makeKnownLinkObj function [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/97214 [10:45:46] (03PS1) 10Tpt: Add @covers annotation [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97234 [10:46:34] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/97231 (owner: 10L10n-bot) [10:49:12] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/97251 (owner: 10L10n-bot) [10:59:08] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/97251 (owner: 10L10n-bot) [11:01:12] (03CR) 10Aklapper: "Confusing - on boogs.wmflabs.org, the "&datasets=UNCONFIRMED" parameters had an additional colon (%3A) in the parameter, but not in the co" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97005 (owner: 10Aklapper) [11:07:24] (03CR) 10Aklapper: "After removing %3A from the parameters, the "Graph" links on boogs.wmflabs.org finally work, and the stats look much saner. Still want to " [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97005 (owner: 10Aklapper) [11:16:21] (03PS1) 10Tpt: Remove unneeded use of global variables [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97294 [11:16:57] (03Abandoned) 10Aklapper: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97182 (owner: 10RAZVOR) [11:27:07] (03PS2) 10Umherirrender: Correct version section for rc_source in the updaters [core] - 10https://gerrit.wikimedia.org/r/96874 [11:47:16] (03PS1) 10Tpt: Explode ProofreadPageRenderer into smaller not static classes [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 [11:49:59] (03PS2) 10Tpt: Explode ProofreadPageRenderer into smaller not static classes [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/97295 [12:24:07] (03CR) 10Bartosz Dziewoński: "> Can I add you as a co-author in the commit message?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [12:25:14] (03CR) 10Bartosz Dziewoński: "You can kill one duplicate by clicking the "Abandon Change" button." [core] - 10https://gerrit.wikimedia.org/r/88670 (owner: 10Huji) [12:29:19] (03PS4) 10Wikinaut: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [12:32:03] (03PS5) 10Wikinaut: Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [12:34:02] (03CR) 10Wikinaut: [C: 04-1 V: 04-1] "I rebased that manually (cherry-picking). It still does not work correctly, but perhaps I made a mistake somewhere." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [12:34:15] (03CR) 10Wikinaut: Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [12:34:25] (03CR) 10Wikinaut: [C: 04-1] Bug 18528: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [12:38:28] (03CR) 10Bartosz Dziewoński: [C: 032] i18n: add a period after "etc" [core] - 10https://gerrit.wikimedia.org/r/97212 (owner: 10Shirayuki) [12:39:18] (03CR) 10Shirayuki: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/97212 (owner: 10Shirayuki) [12:41:30] (03Merged) 10jenkins-bot: i18n: add a period after "etc" [core] - 10https://gerrit.wikimedia.org/r/97212 (owner: 10Shirayuki) [13:08:08] (03CR) 10Bartosz Dziewoński: [C: 031] "Did not test." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [13:10:10] hm what's the situation of this block https://zh-classical.wikipedia.org/wiki/Special:%E5%88%97%E7%A6%81%E7%B0%BF%E3%80%81%E7%A6%81%E5%9D%80?wpTarget=%E5%88%BB%E6%84%8F&limit=50 [13:10:33] see also https://en.wikipedia.org/wiki/Special:CentralAuth/%E5%88%BB%E6%84%8F [13:11:18] this user seems to be blocked in 2006 before account creation in 2009 ? [13:12:23] https://zh-classical.wikipedia.org/wiki/Special:%E8%AA%8C/%E5%88%BB%E6%84%8F also claims the 2009 account creation, which matches CentralAuth log [13:14:03] liangent: was the account renamed, maybe? [13:14:44] MatmaRex: how? [13:15:39] liangent: https://zh-classical.wikipedia.org/w/index.php?title=Special%3A%E8%AA%8C&type=&user=&page=user%3A%E5%88%BB%E6%84%8F&year=&month=-1&tagfilter=&hide_review_log=1&hide_thanks_log=1 [13:15:50] liangent: that account was created in 2006, then renamed [13:15:56] apparently the block was not moved with it [13:16:04] then a new account with that name was created [13:16:18] Hello. [13:18:30] another student attached solution https://gerrit.wikimedia.org/r/#/c/97125/ [13:19:00] hi razvor [13:19:16] another student attached solution https://gerrit.wikimedia.org/r/#/c/97125/ [13:20:24] well, yeah [13:20:37] but he commented about that on the task, didn't he? [13:20:56] MatmaRex: yeah that's right [13:21:17] so there're two bugs to fix: (1) E:Renameuser should update ipblocks table [13:21:22] (03Abandoned) 10Bartosz Dziewoński: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [13:21:40] (2) Special:Blocklist should prefer data from user table when ipb_user is there [13:21:41] liangent: it might as well be updating it now, a lot can happen in 7 years ;) [13:22:16] MatmaRex: anyway bug (2) is valid [13:23:36] I had a look at RenameUser source, and it seems already fixed [13:24:08] Hi [13:24:10] Is it possible to 'embed' mediawiki inside another php application? [13:24:21] Looking at index.php, the class MediaWiki is instantiated and run() [13:24:28] and there is RequestContext which contains an OutputPage [13:24:59] What about my task? [13:26:00] razvor: what about it? you can continue working on it [13:26:26] razvor: but please remove all of the patches you accidentally submitted and just submit one [13:26:41] razvor: you can "remove" a patch by clicking the "Abandon Change" button [13:29:30] That student use my works, and in but please remove all of the patches you accidentally submitted and just submit one tests have good results [13:30:56] razvor: sorry, i don't understand :( [13:32:08] https://gerrit.wikimedia.org/r/#/c/97125/ have not bugs? [13:32:32] test results are good [13:33:53] (03CR) 10Bartosz Dziewoński: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [13:34:08] (03PS3) 10Bartosz Dziewoński: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback [core] - 10https://gerrit.wikimedia.org/r/96239 [13:34:34] razvor: i haven't looked at his patch yet [13:37:42] Please see it. What if it is correct? [13:40:18] ? [13:40:32] MatmaRex: ? [13:41:51] (03Abandoned) 10RAZVOR: https://bugzilla.wikimedia.org/show_bug.cgi?id=55893 bug commited [core] - 10https://gerrit.wikimedia.org/r/97057 (owner: 10RAZVOR) [13:42:04] (03Abandoned) 10RAZVOR: page.image.pagination: Add mw.hook() [core] - 10https://gerrit.wikimedia.org/r/97067 (owner: 10RAZVOR) [13:42:19] (03Abandoned) 10RAZVOR: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97186 (owner: 10RAZVOR) [13:42:30] (03Restored) 10RAZVOR: page.image.pagination: Add mw.hook() [core] - 10https://gerrit.wikimedia.org/r/97067 (owner: 10RAZVOR) [13:42:35] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=57482 https://bugzilla.wikimedia.org/show_bug.cgi?id=57481 [13:42:52] (03Abandoned) 10RAZVOR: resources/mediawiki.page/mediawiki.page.image.pagination.js [core] - 10https://gerrit.wikimedia.org/r/97066 (owner: 10RAZVOR) [13:43:48] (03Abandoned) 10RAZVOR: page.image.pagination: Add mw.hook() [core] - 10https://gerrit.wikimedia.org/r/97067 (owner: 10RAZVOR) [13:43:55] (03Abandoned) 10RAZVOR: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97187 (owner: 10RAZVOR) [13:44:03] (03Abandoned) 10RAZVOR: page.images,pagination: Added history pushState for url changing, mw.hook, commited bug with doublequotes bug:55893 [core] - 10https://gerrit.wikimedia.org/r/97188 (owner: 10RAZVOR) [13:44:13] (03PS1) 10Umherirrender: The static declaration must come after the visibility declartion [core] - 10https://gerrit.wikimedia.org/r/97298 [13:45:05] (03PS1) 10RAZVOR: ff [core] - 10https://gerrit.wikimedia.org/r/97299 [13:47:29] (03PS1) 10Kaldari: Removing CSS for auto-enroll option label [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97300 [13:50:21] MatmaRex: ? [13:58:25] (03PS2) 10Bartosz Dziewoński: Removing CSS for auto-enroll option label [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97300 (owner: 10Kaldari) [13:58:46] (03CR) 10Bartosz Dziewoński: [C: 031] Removing CSS for auto-enroll option label [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97300 (owner: 10Kaldari) [13:59:35] liangent: thanks for filing those, i'm afraid i won't help much in fixing them though :) [14:36:00] (03PS1) 10UltrasonicNXT: Fix SQL errors being caused by $points being empty [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97302 [14:37:08] (03CR) 10Hoo man: [C: 04-1] "Some style comments." (033 comments) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [14:44:27] Hi MatmaRex [14:49:00] hi [14:54:09] Dont you have a list of tasks that are about fixing or implementing a fearure [14:54:21] MatmaRex: ^ [14:56:13] mayankmadan: i don't have any lists, apart from what is available on Melange [14:57:46] MatmaRex: i was talking about implementing a particular feature by dividing it into some tasks. It makes things a lot more easier to work on something particular [14:58:08] (03PS2) 10Umherirrender: Use lowercase key words [core] - 10https://gerrit.wikimedia.org/r/97207 [14:59:44] (03CR) 10Umherirrender: "Patch Set 2: Found some instanceof and array in addition to null." [core] - 10https://gerrit.wikimedia.org/r/97207 (owner: 10Umherirrender) [15:01:16] (03PS1) 10UltrasonicNXT: Add user_points SQL files into SocialProfile [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97303 [15:03:28] hi :) [15:04:25] MatmaRex: I have a question about the GCI task. [15:05:36] hi m4tx [15:05:48] http://www.google-melange.com/gci/task/view/google/gci2013/5345950625169408 [15:05:50] about this GCI task. [15:06:00] I have to create SVG version of search button icon [15:06:12] and there's one problem. [15:06:20] I have to provide a PNG fallback. [15:06:48] i think we have a little "magic" code that makes a SVG with PNG fallback work [15:06:58] no no [15:06:59] Making PNGs from SVG is hard [15:07:01] that's not a problem [15:07:10] The problem is: it's in :) [15:07:25] And Wikimedia uses PNG fallback that requires CSS. [15:07:28] oh. [15:07:29] hm. [15:07:32] So there are two ways. [15:07:45] hmmm. [15:07:48] Remove and replace it with background-image in CSS [15:07:56] or . [15:08:01] without PNG fallback. [15:08:34] gah, i have a pending patch that redoes the search interface in a way that puts the image in CSS [15:08:53] i sort of forgot it was not merged yet :) [15:09:19] m4tx: hm, i'm thinking [15:09:31] (the patch is https://gerrit.wikimedia.org/r/#/c/82100/) [15:10:14] m4tx: i think it would be best if you created your change "on top of" mine [15:10:59] hm [15:11:22] m4tx: and i'll just mark the GCI task as solved when you submit the patch and i verify it works, not when it's merged [15:11:40] ok :) [15:11:47] i don't even know if there's a sane way of shoehorning the SVG with PNG fallback into the current state of things [15:11:47] siema m4tx [15:11:51] meh. [15:12:33] guest000000000: no i cały misterny plan. [15:12:51] cnie :> [15:14:31] btw., MatmaRex [15:14:52] (03CR) 10Bartosz Dziewoński: "The worst issue that can happen will be that the form will point to direct search instead of fulltext one, I think." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [15:14:58] (03CR) 10Kaldari: [C: 04-2] "I'm -2ing this until things are hashed out in the bug." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [15:14:59] m4tx: hm? [15:15:07] is there any reason why we don't have something like .background-image-svg-with-png LESS mixin? [15:15:08] :P [15:15:15] m4tx: i think we do :D [15:15:25] ah. :D [15:15:37] I haven't seen any :D [15:16:01] a few mixins are defined in /resources/mediawiki.less/mediawiki.mixins.less [15:16:07] .background-image-svg(@svg, @fallback) { [15:16:14] hm. [15:16:54] I'll have a look at it :P [15:18:45] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Seems to work okay, but the input text will be HTML-escaped every time you resubmit the form, turning "" into "<b>" into "&lt" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [15:19:10] hm, indeed, there is such a mixin. [15:21:38] btw., MatmaRex: you're polish and you're sometimes going to VLO, right? ;> [15:23:54] (03PS12) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [15:23:59] m4tx: czolem, mateusz ;) [15:24:30] ...;> [15:25:01] (03CR) 10Bartosz Dziewoński: [C: 031] "Tested, works. I'd also rather that somebody more experience with this looked at it, but it looks perfect for me. So, I'll mark the GCI ta" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [15:31:13] (03PS1) 10Kaldari: Adding 2 new equivalencies (partial fix for bug 25619) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/97304 [15:31:48] (03PS1) 10Bartosz Dziewoński: Html: Fix a copy-paste error in docs [core] - 10https://gerrit.wikimedia.org/r/97305 [15:32:09] (03PS13) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [15:49:24] (03PS6) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [15:50:31] (03CR) 10jenkins-bot: [V: 04-1] Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [15:57:33] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Another HTML-escaping issue. :( Hopefully it's the last one." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [15:58:20] (03CR) 10Theopolisme: [C: 04-1] "This looks like yet another test commit. Please see TTO's comment on your previous change, click "Abandon" on this one, and discuss with y" [core] - 10https://gerrit.wikimedia.org/r/97299 (owner: 10RAZVOR) [15:58:52] (03PS7) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [16:02:00] (03CR) 10UltrasonicNXT: "I'll get there one day... :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:02:14] (03PS2) 10Bartosz Dziewoński: Html: Fix a copy-paste error in docs [core] - 10https://gerrit.wikimedia.org/r/97305 [16:02:21] (03CR) 10Bartosz Dziewoński: [C: 032] Html: Fix a copy-paste error in docs [core] - 10https://gerrit.wikimedia.org/r/97305 (owner: 10Bartosz Dziewoński) [16:04:16] (03CR) 10Bartosz Dziewoński: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:06:23] MatmaRex please check it again https://gerrit.wikimedia.org/r/#/c/96918/ [16:07:08] (03Merged) 10jenkins-bot: Html: Fix a copy-paste error in docs [core] - 10https://gerrit.wikimedia.org/r/97305 (owner: 10Bartosz Dziewoński) [16:07:18] yamelnychuk: i'm looking at the patch right now :) [16:08:00] yamelnychuk: can you mention the bug number (it should be linked in GCI task) in the commit summary? see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Example [16:08:12] yamelnychuk: this will cause your patch and the bug to be linked together [16:09:23] (03CR) 10Bartosz Dziewoński: [C: 032] "I'm just going to be bold and merge this, designers can bikeshed about the exact color later. This grey is definitely not okay." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97300 (owner: 10Kaldari) [16:09:31] (03Merged) 10jenkins-bot: Removing CSS for auto-enroll option label [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/97300 (owner: 10Kaldari) [16:11:02] (03PS8) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [16:11:50] MatmaRex done [16:11:57] (03CR) 10UltrasonicNXT: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:12:20] MatmaRex: users.v-lo.krakow.pl SSH server is very useful when cloning Wikimedia repository many times, especially when you have a very slow internet connection at home... :D [16:12:35] anyway... I think I've done my task. I'll commit it in a moment. [16:12:40] ;) [16:12:45] yamelnychuk: thanks [16:13:16] m4tx, you can also clone from another clone... [16:13:34] (be right back, and i'll recheck your patch, yamelnychuk) [16:16:39] (03CR) 10Yamelnychuk: "Actually, $settings != null would check for both null and undefined, but jenkins-bot says that expected '!==' and instead '!='." [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [16:16:46] (03CR) 10Hoo man: [C: 032] "Trivial (style-only) change." [core] - 10https://gerrit.wikimedia.org/r/97207 (owner: 10Umherirrender) [16:19:45] (03Merged) 10jenkins-bot: Use lowercase key words [core] - 10https://gerrit.wikimedia.org/r/97207 (owner: 10Umherirrender) [16:19:50] (03PS9) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [16:24:34] (03CR) 10Hoo man: "The code looks ok now (untested)." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [16:25:32] (03CR) 10Jackmcbarn: "You can also "bypass" the logs by just looking at the spam blacklist and seeing if you're on it. Also, logging is a relatively new feature" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [16:25:41] (03CR) 10Bartosz Dziewoński: "Yes, we almost always use strict comparisons (=== and !==) instead of == and !=. The latter perform type conversions, sometimes resulting " [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [16:27:32] (03CR) 10Hoo man: [C: 031] "That's not fully true, you can also use hidden blacklists (we don't do that now, but some users request that). I doubt that Chris has conc" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [16:27:36] (03CR) 10Bartosz Dziewoński: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [16:29:02] (03CR) 10Bartosz Dziewoński: "See http://stackoverflow.com/a/359509 about why we avoid == and != :)" [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [16:36:54] (03CR) 10Bartosz Dziewoński: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:37:14] (03CR) 10Yamelnychuk: "Ok, I agree with you `!$settings` would be better. I will read article and update solution." [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [16:43:52] (03PS9) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [16:46:26] (03PS14) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [16:46:32] (03CR) 10jenkins-bot: [V: 04-1] Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:48:09] MatmaRex please review https://gerrit.wikimedia.org/r/#/c/96918/ , and also thanks for link it was very useful [16:48:57] (03CR) 10Bartosz Dziewoński: "Huh, V-1? That looks like a bug in jenkins :/" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:49:05] (03CR) 10Bartosz Dziewoński: "recheck" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:51:01] yamelnychuk: :) i'll look in a second [16:53:27] (03CR) 10Bartosz Dziewoński: "I filed a bug in our continuous integration config: https://bugzilla.wikimedia.org/show_bug.cgi?id=57483 , since I've seen this happen bef" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:53:40] (03PS15) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [16:54:34] (03CR) 10Siebrand: [C: 032] The static declaration must come after the visibility declartion [core] - 10https://gerrit.wikimedia.org/r/97298 (owner: 10Umherirrender) [16:55:16] (03CR) 10UltrasonicNXT: "oh, that was just a rebase just in case to try and make Jenkins happy, but there wasn't actually anything to rebase..." [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:57:46] (03Merged) 10jenkins-bot: The static declaration must come after the visibility declartion [core] - 10https://gerrit.wikimedia.org/r/97298 (owner: 10Umherirrender) [16:59:14] (03CR) 10Siebrand: [C: 032] i18n: double space [extensions/RSS] - 10https://gerrit.wikimedia.org/r/97209 (owner: 10Shirayuki) [16:59:19] (03Merged) 10jenkins-bot: i18n: double space [extensions/RSS] - 10https://gerrit.wikimedia.org/r/97209 (owner: 10Shirayuki) [16:59:20] (03CR) 10Bartosz Dziewoński: [C: 032] "Okay, this looks all pretty now :) Thank you!" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [16:59:34] (03CR) 10Siebrand: [C: 032] i18n: fix double-space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/97208 (owner: 10Shirayuki) [17:00:14] (03Merged) 10jenkins-bot: i18n: fix double-space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/97208 (owner: 10Shirayuki) [17:02:05] (03CR) 10Siebrand: "@lego: Yes, and Raymond will take care of that. Go ahead and merge." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/59760 (owner: 10Alex Monk) [17:02:25] (03Merged) 10jenkins-bot: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [17:06:02] (03CR) 10Siebrand: [C: 031] Canonicalize text and update docs of messages using 'loginreqlink' [core] - 10https://gerrit.wikimedia.org/r/94414 (owner: 10Bartosz Dziewoński) [17:12:53] (03CR) 10Bartosz Dziewoński: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [17:15:01] (03PS1) 10Bartosz Dziewoński: Xml::textarea: Custom attributes should override default ones [core] - 10https://gerrit.wikimedia.org/r/97306 [17:18:33] (03CR) 10Bartosz Dziewoński: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [17:23:33] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This appears to make the feature stop working. After applying this patch, the tabs no longer collapse when the window is resized to be too" [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [17:24:47] yamelnychuk: ^ [17:25:26] MathmaRex how i can test my patch? [17:28:56] (03PS3) 10Bartosz Dziewoński: Xml::textarea: Custom attributes should override default ones [core] - 10https://gerrit.wikimedia.org/r/97306 [17:29:04] yamelnychuk: do you have a MediaWIki wiki installed somewhere? [17:30:25] no, can you give me tutorial link maybe? [17:30:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Hmmm, actually, every function in this class uses this pattern… why do they do that?" [core] - 10https://gerrit.wikimedia.org/r/97306 (owner: 10Bartosz Dziewoński) [17:30:42] MatmaRex: how to add a Patch Set/commit on top of your commit with topic bug/46947 that you gave me before? [17:31:25] yamelnychuk: https://www.mediawiki.org/wiki/Manual:Installing_MediaWiki [17:31:32] thanks [17:31:52] yamelnychuk: good luck :) [17:32:03] m4tx: you have git-review installed already, right? [17:32:12] yea, of course [17:32:28] cloned a core repo [17:32:29] and [17:32:36] used git fetch https://gerrit.wikimedia.org/r/mediawiki/core refs/changes/00/82100/11 && git checkout FETCH_HEAD [17:32:55] then I made my changes, executed git commit [17:33:03] ah, you can also use `git review -d 82100` to download patches for review [17:33:09] ah. [17:33:10] well, then that should be okay [17:33:17] just run `git review` to submit your patch [17:33:34] (and say 'yes' when it asks you about submitting two patches) [17:33:38] ah. [17:33:46] That was my main problem. [17:33:58] git-review is yelling about submitting my commit and your commit [17:34:03] I thought it's not ok. [17:34:04] yeah [17:34:10] if you didn't change the previous commit, then it won't modify the other change [17:34:26] ok :P [17:34:27] (03PS1) 10M4tx: Added SVG version of search button icon (bug 35336). [core] - 10https://gerrit.wikimedia.org/r/97307 [17:34:40] hm [17:35:07] (03CR) 10jenkins-bot: [V: 04-1] Added SVG version of search button icon (bug 35336). [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [17:35:07] thank you :D [17:35:29] or... not [17:35:33] "This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset." [17:35:34] lolwut. [17:36:58] run git rebase [17:37:36] (03Restored) 10Umherirrender: Avoid Generic accessor in Category.php [core] - 10https://gerrit.wikimedia.org/r/62986 (owner: 10Umherirrender) [17:37:47] (03PS2) 10Umherirrender: Avoid Generic accessor in Category.php [core] - 10https://gerrit.wikimedia.org/r/62986 [17:41:04] Platonides: I tried it. But merging it with master produces merge error since I'm using MatmaRex's commit as my base. [17:41:27] The other important fact is that I'm a git lame... [17:42:51] (03PS1) 10Platonides: Use the class name with capital letter [core] - 10https://gerrit.wikimedia.org/r/97308 [17:43:19] I'm not aware of the background, why is it a problem? [17:43:48] (using a commit by MatmaRex, not being knowledgeable about git may indeed be an inconvenient) [17:45:50] m4tx: i think might change might not be merging cleanly right now [17:45:54] my change might* [17:46:28] i should fix that, i guess [17:47:46] Platonides: I really don't know... The only thing I know is when I'm using his commit as a base and then trying to merge it with master, it gives me merge error. [17:48:14] m4tx: my own commit is not merging cleanly right now [17:48:19] not your fault :) [17:48:26] ah. [17:48:57] let me fix that [17:53:14] (03PS1) 10Siebrand: Update documentation [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/97309 [17:54:15] (03PS12) 10Bartosz Dziewoński: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [17:55:04] (03PS13) 10Bartosz Dziewoński: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 [17:55:21] (03CR) 10Bartosz Dziewoński: "Rebased, was conflicting with the fix for bug 54069." [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [17:55:46] (03PS5) 10Bartosz Dziewoński: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 [17:55:57] (03PS2) 10Bartosz Dziewoński: Added SVG version of search button icon (bug 35336). [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [17:56:18] m4tx: should be okay now :) [17:56:27] Thank you very much, MatmaRex :> [17:56:46] (03PS1) 10Umherirrender: Move functions to better place in Special:Search [core] - 10https://gerrit.wikimedia.org/r/97310 [17:59:47] (03Abandoned) 10Siebrand: Silence false positive CodeSniffer error [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [18:02:13] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Yay, works nicely. Nitpicks inline." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [18:02:42] (03PS2) 10Siebrand: Use the class name with capital letter [core] - 10https://gerrit.wikimedia.org/r/97308 (owner: 10Platonides) [18:02:50] (03CR) 10Siebrand: [C: 032] Use the class name with capital letter [core] - 10https://gerrit.wikimedia.org/r/97308 (owner: 10Platonides) [18:03:29] ah [18:03:36] tabs. [18:03:55] I knew that, but forgot about it when copying text from vim. [18:04:24] (03CR) 10Bartosz Dziewoński: "We could also avoid any issues with JS blacklisted vs. disabled by checking for that in an inline script ($(document.body).hasClass('clien" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński) [18:07:50] (03Merged) 10jenkins-bot: Use the class name with capital letter [core] - 10https://gerrit.wikimedia.org/r/97308 (owner: 10Platonides) [18:09:30] MatmaRex: how to add patch set to my commit? [18:11:22] m4tx: `git commit --amend`, then `git review` again [18:11:31] kthx. [18:11:53] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change [18:12:11] ok, thanks :) [18:15:33] (03PS1) 10Platonides: Add missing wfProfileOut()s [core] - 10https://gerrit.wikimedia.org/r/97311 [18:17:21] (03PS3) 10M4tx: Added SVG version of search button icon (bug 35336). [core] - 10https://gerrit.wikimedia.org/r/97307 [18:17:37] (03PS2) 10Alex Monk: Don't use @deprecated for parameters [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97184 (owner: 10Legoktm) [18:17:47] (03CR) 10Alex Monk: [C: 032] Don't use @deprecated for parameters [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97184 (owner: 10Legoktm) [18:17:58] (03PS1) 10Siebrand: Update formatting of file backend classes [core] - 10https://gerrit.wikimedia.org/r/97312 [18:17:59] (03PS1) 10Siebrand: Update documentation of MediaHandler [core] - 10https://gerrit.wikimedia.org/r/97313 [18:17:59] wow. I tihnk I haven't fucked anything o.o [18:18:05] unbelievable [18:19:10] (03Merged) 10jenkins-bot: Don't use @deprecated for parameters [extensions/Echo] - 10https://gerrit.wikimedia.org/r/97184 (owner: 10Legoktm) [18:19:19] Vizzini, is it you? [18:19:51] :) [18:20:02] (03PS2) 10Siebrand: Update documentation of MediaHandler [core] - 10https://gerrit.wikimedia.org/r/97313 [18:22:41] (03CR) 10Platonides: "This calls deprecated getRootUrl()" [core] - 10https://gerrit.wikimedia.org/r/85344 (owner: 10MarkTraceur) [18:23:48] (03PS1) 10Umherirrender: Use square brackets instead of curly braces for char of a string [core] - 10https://gerrit.wikimedia.org/r/97314 [18:24:03] (03PS1) 10Siebrand: Update documentation of file backend classes [core] - 10https://gerrit.wikimedia.org/r/97315 [18:24:44] (03CR) 10Bartosz Dziewoński: [C: 04-1] "One last thing: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Example :) You can edit the commit message via gerrit, by " [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [18:24:56] m4tx: i'm just complaining now ;) [18:25:13] yeah, I saw it :) [18:25:16] I'm currently fixing it [18:25:19] (03PS2) 10Siebrand: Update documentation of file backend classes [core] - 10https://gerrit.wikimedia.org/r/97315 [18:29:13] (03PS1) 10Platonides: Use canonical class name for SvgHandler and rename the test for consistency. [core] - 10https://gerrit.wikimedia.org/r/97316 [18:29:32] (03PS1) 10Anomie: Allow 'noprotocol' option in captcha-addurl-whitelist [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97317 [18:31:07] (03CR) 10Hoo man: [C: 032] "Looks fine, has tests... go for it :)" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [18:32:13] (03CR) 10Nemo bis: [C: 04-1] "Indeed. Please don't change message key here." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/96973 (owner: 10Inchikutty) [18:32:14] MatmaRex: Is "Add SVG version of search button icon" in 1st line and "Fixes bug 35336" in body alright or am I omitting something? :P [18:32:44] m4tx: see the example i linked https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Example [18:32:50] I saw it... [18:32:52] (03PS1) 10Siebrand: Remove leading underscore from method name [core] - 10https://gerrit.wikimedia.org/r/97318 [18:32:53] you'd usually just add "Bug: NNN" on the last line [18:33:01] (03Merged) 10jenkins-bot: Optionally integrate with AntiSpoof [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [18:33:03] hm [18:33:05] just before the autmatocially-inserted Change-ID [18:33:35] I've read whole article. [18:33:59] m4tx: no need to state "fixes" [18:34:07] Ok. [18:34:22] (03PS2) 10Siebrand: Remove leading underscore from method name [core] - 10https://gerrit.wikimedia.org/r/97318 [18:34:32] So "Add SVG version of search button icon" and "Bug: 35336"? [18:35:01] (03PS1) 10Platonides: Replace usage of deprecated getRootUrl() method [core] - 10https://gerrit.wikimedia.org/r/97319 [18:35:14] (03CR) 10Anomie: Allow 'noprotocol' option in captcha-addurl-whitelist (034 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/97317 (owner: 10Anomie) [18:35:45] MatmaRex? :) [18:36:21] m4tx: yeah, should be ok [18:36:42] ok then :) [18:36:47] (03PS4) 10M4tx: Added SVG version of search button icon (bug 35336). [core] - 10https://gerrit.wikimedia.org/r/97307 [18:43:05] yay [18:43:49] m4tx: well, i guess i can close the GCI task already, but unfortunately i can't tell you when you will see this change live on Wikipedias :( [18:44:05] oh, i can't close it – you have to mark it as completed first :D https://google-melange.appspot.com/gci/task/view/google/gci2013/5345950625169408 [18:44:24] (03PS1) 10Platonides: Rename $wgServerSetting to $serverSetting [core] - 10https://gerrit.wikimedia.org/r/97320 [18:44:41] too much GCI work, MatmaRex? [18:46:01] Platonides: i'm just barely keeping afloat :) [18:46:47] Platonides: hmm, how about reviewing some code? [18:46:59] i have like 40 open changes to core pending myself [18:47:08] I can review a few changes this weekend :) [18:47:44] https://gerrit.wikimedia.org/r/#/q/owner:%22Bartosz+Dziewo%25C5%2584ski%22+status:open,n,z lots of stuff, including lots of simple stuff too [18:49:46] (03PS1) 10Siebrand: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/97322 [18:49:47] (03PS1) 10Siebrand: Fix various type and reference issues [core] - 10https://gerrit.wikimedia.org/r/97323 [18:49:48] (03PS1) 10Siebrand: Update documentation of Status [core] - 10https://gerrit.wikimedia.org/r/97324 [18:49:53] MatmaRex: sorry, I was afk for a while :P [18:50:08] Platonides: oh btw, not sure if i asked you already – do you have somebody who could do something about your stack of patches to mediawiki/tools/code-utils? i have no idea what that does myself [18:50:28] ok, marked as complete :P [18:50:36] (03PS1) 10Platonides: StatusTest is language dependant [core] - 10https://gerrit.wikimedia.org/r/97325 [18:50:46] MatmaRex, no [18:51:16] those tools weren't reviewed in svn days [18:51:17] (03PS2) 10Siebrand: Update documentation of Status [core] - 10https://gerrit.wikimedia.org/r/97324 [18:51:38] m4tx: and as closed. thanks :) [18:52:01] Thank you too :P [18:52:07] And see you in Kanciapa xD [18:52:09] !bug 56694 was added as a gci suggestion, btw [18:52:09] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=56694+was+added+as+a+gci+suggestion%2c+btw [18:52:36] (03CR) 10Bartosz Dziewoński: [C: 031] "OK. This patch is perfect, but unfortunately it has a dependency :( I will merge it as soon as the dep is merged, but I have no idea when " [core] - 10https://gerrit.wikimedia.org/r/97307 (owner: 10M4tx) [18:53:48] (03PS4) 10M4tx: Fixed low-resolution enhanced recent changes collapse/show arrows (bug 35344) [core] - 10https://gerrit.wikimedia.org/r/96372 [18:54:20] (03CR) 10M4tx: "Sorry for multiple patches. I fixed the commit message already." [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx) [18:56:10] Platonides: commented, sounds like a good idea to me [18:56:23] (03PS1) 10Siebrand: Add missing return value [core] - 10https://gerrit.wikimedia.org/r/97326 [18:56:46] Platonides: wanna mentor that ;) [18:56:48] it's one of those things I wanted to write for some time and I nerver do :) [18:56:50] Platonides: wanna mentor that? ;) [18:57:10] no problem [18:57:23] are you a mentor already? if not, you'll have to ask andre or qgil about that [18:57:25] (03PS2) 10M4tx: Fixed indentation style and PNG fallbacking method. [core] - 10https://gerrit.wikimedia.org/r/97022 [18:57:27] but note that my general availability is quite low these times [18:57:56] no, I'm not signed up as mentor in GCI [18:58:12] although I doubt qgil would oppose to that [18:58:28] (03CR) 10Siebrand: [C: 032] Rename $wgServerSetting to $serverSetting [core] - 10https://gerrit.wikimedia.org/r/97320 (owner: 10Platonides) [18:58:32] i could probably mentor it too, i guess, 10 of the 17 tasks i was mentoring are solved already, huh. [18:58:35] didn't even realize. [19:00:52] you are supposed to continue adding tasks AFAIK [19:01:20] (03PS2) 10Aaron Schulz: Add missing return value [core] - 10https://gerrit.wikimedia.org/r/97326 (owner: 10Siebrand) [19:01:50] yeah, i am [19:01:53] (03CR) 10Siebrand: [C: 04-1] "Per Nemo." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/96973 (owner: 10Inchikutty) [19:01:56] i was planning to do that today, life interfered [19:02:06] maybe i still will [19:04:29] (03PS1) 10Platonides: Make phpunit pick the test @groups [core] - 10https://gerrit.wikimedia.org/r/97328 [19:04:30] (03CR) 10Bartosz Dziewoński: Add legend to Special:RecentChanges and Special:Watchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [19:04:44] (03CR) 10Aaron Schulz: [C: 04-1] Fix various type and reference issues (032 comments) [core] - 10https://gerrit.wikimedia.org/r/97323 (owner: 10Siebrand) [19:05:03] MatmaRex: will there be new tasks during this year's GCI? As far as I remember, organizations were adding tasks during previous GCIs... [19:08:25] (03CR) 10Siebrand: [C: 032] "Found uses in:" [core] - 10https://gerrit.wikimedia.org/r/97006 (owner: 10Bartosz Dziewoński) [19:09:21] m4tx: there will, assuming me and other mentors find some time between reviewing to add them :) [19:09:56] Ah, cool. [19:09:58] (03Merged) 10jenkins-bot: Rename $wgServerSetting to $serverSetting [core] - 10https://gerrit.wikimedia.org/r/97320 (owner: 10Platonides) [19:10:06] siebrand: around? [19:10:14] MatmaRex: yes [19:10:17] Or maybe not, because I'll have smaller chance to become a grand prize winner [19:10:20] but still cool :P [19:10:24] siebrand: is it okay to hardcoded "±" in source code, or should it have a message? [19:10:26] m4tx: :P [19:10:31] to hardcode* [19:10:49] MatmaRex: I'd say optional message. [19:10:52] (03CR) 10Aaron Schulz: [C: 032] Update formatting of file backend classes [core] - 10https://gerrit.wikimedia.org/r/97312 (owner: 10Siebrand) [19:10:54] (20:09:21) MatmaRex: m4tx: there will, assuming me and other mentors find some time between answering noobs like m4tx to add them :) [19:11:00] That would be better answer to my question. [19:11:02] ;> [19:11:37] MatmaRex: If used combined with a number, use with a parameter and make sure to use number formatting to numeral conversion can take place [19:11:43] siebrand: we are hardcoding '+' in some place [19:11:43] s [19:12:08] MatmaRex: We have done a lot of things in the past we should prevent from happening in the future. [19:12:10] $formattedSize = '+' . $formattedSize; , in ChangesList [19:12:27] minus is apparnetly handled by formatNum [19:14:32] (03Merged) 10jenkins-bot: Kill 'newmessageslink' and 'newmessagesdifflink' messages [core] - 10https://gerrit.wikimedia.org/r/97006 (owner: 10Bartosz Dziewoński) [19:15:33] (03CR) 10Siebrand: "Thanks for the screenshot. It may be that I disagree with the fact that this is a good project to work on as a starter project, but let's " [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [19:15:58] (03PS1) 10Platonides: Make checkPHPExtension() load the extension when it's available. [core] - 10https://gerrit.wikimedia.org/r/97329 [19:16:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Minor complaints. I like where this is going! I almost missed that you submitted your changes, sorry for late review." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [19:17:08] (03Merged) 10jenkins-bot: Update formatting of file backend classes [core] - 10https://gerrit.wikimedia.org/r/97312 (owner: 10Siebrand) [19:17:36] siebrand: it's flipped in RTL (by CSSJanus) [19:17:46] k [19:18:17] MatmaRex: I suspected that, but I'd like to make submitter aware these things are relevant :) [19:18:58] yup :) [19:20:22] (03Abandoned) 10RAZVOR: ff [core] - 10https://gerrit.wikimedia.org/r/97299 (owner: 10RAZVOR) [19:20:58] Platonides: still here? [19:21:02] (03PS1) 10Platonides: Replace a bunch of extension_loaded() checks with checkPHPExtension() [core] - 10https://gerrit.wikimedia.org/r/97330 [19:21:05] (03CR) 10Siebrand: Remove deprecated EditPage::spamPage() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95839 (owner: 10Chad) [19:21:09] MatmaRex, yes [19:21:34] Platonides: ok, so you said something about changes to mediawiki/tools/code-utils not being reviewed in general? [19:21:44] why don't you self-merge all of that (assuming it works) [19:21:46] ? [19:22:43] yes, most of https://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Ftools%2Fcode-utils&title=Special%3ACode%2FMediaWiki were marked as 'deferred' [19:22:54] (03CR) 10Aaron Schulz: [C: 032] Update documentation of file backend classes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97315 (owner: 10Siebrand) [19:23:01] hmm..., I'm not sure about doing that [19:23:40] heh [19:23:41] (03CR) 10Aaron Schulz: [C: 032] Add missing return value [core] - 10https://gerrit.wikimedia.org/r/97326 (owner: 10Siebrand) [19:23:49] Platonides: well, i can do that for you if you promisethe code works [19:24:05] that pile of patches with no path forward has been annoying me a lot :) [19:24:25] MatmaRex, I have been using it :) [19:24:45] (03CR) 10Aaron Schulz: [C: 032] Replace usage of deprecated getRootUrl() method [core] - 10https://gerrit.wikimedia.org/r/97319 (owner: 10Platonides) [19:25:04] in fact, many of the low-hanging fixes I do are based on its ouput :P [19:25:26] (03CR) 10Aaron Schulz: [C: 032] "This is why I like ProfileSection" [core] - 10https://gerrit.wikimedia.org/r/97311 (owner: 10Platonides) [19:26:16] (03Merged) 10jenkins-bot: Update documentation of file backend classes [core] - 10https://gerrit.wikimedia.org/r/97315 (owner: 10Siebrand) [19:26:32] Platonides: alright. i'm just going to merge the whole stack one by one [19:27:40] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/60004 (owner: 10Platonides) [19:29:21] let me check it a moment [19:29:40] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/57934 (owner: 10Platonides) [19:29:58] Platonides: okay [19:30:08] i'm going backwards to avoid unnecessary merge commits :P [19:30:09] (03Merged) 10jenkins-bot: Replace usage of deprecated getRootUrl() method [core] - 10https://gerrit.wikimedia.org/r/97319 (owner: 10Platonides) [19:31:17] there should be just a couple of tips [19:31:27] (03PS1) 10Siebrand: Add missing type hint for $autoSync [core] - 10https://gerrit.wikimedia.org/r/97332 [19:31:40] (03CR) 10Siebrand: "Replied to comments. Submitted follow-up https://gerrit.wikimedia.org/r/97332 with an update for the type hint." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97315 (owner: 10Siebrand) [19:31:41] (03Merged) 10jenkins-bot: Add missing wfProfileOut()s [core] - 10https://gerrit.wikimedia.org/r/97311 (owner: 10Platonides) [19:31:55] (03CR) 10Aaron Schulz: [C: 032] Add missing type hint for $autoSync [core] - 10https://gerrit.wikimedia.org/r/97332 (owner: 10Siebrand) [19:33:32] Platonides: ping me when it's okay for me to continue :) [19:34:41] argh, I was going to commit a change in my wc [19:34:49] and removed it :s [19:35:24] (03CR) 10Aaron Schulz: [C: 032] Use square brackets instead of curly braces for char of a string [core] - 10https://gerrit.wikimedia.org/r/97314 (owner: 10Umherirrender) [19:36:26] aw :( [19:36:42] Platonides: was it in your index? you could try to recover it if so [19:37:07] (i managed to do that once, and hopefully that will be my last time :P) [19:37:12] (03CR) 10Siebrand: [C: 04-2] "If the community is not asking for a fallback, it is better to not set it without consulting them." [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [19:38:18] no, it was uncommited [19:38:23] I had git diffed it first [19:38:29] but the line got truncated [19:38:38] I had to reconstruct it [19:39:52] (03Merged) 10jenkins-bot: Add missing type hint for $autoSync [core] - 10https://gerrit.wikimedia.org/r/97332 (owner: 10Siebrand) [19:39:59] (03PS1) 10Platonides: Add code to avoid the wfProfileOut false positives at the Preprocessors [tools/code-utils] - 10https://gerrit.wikimedia.org/r/97333 [19:40:16] ok, go ahead [19:40:36] I think that if you merged 97333, all its children would get automatically merged [19:41:35] (03Merged) 10jenkins-bot: Use square brackets instead of curly braces for char of a string [core] - 10https://gerrit.wikimedia.org/r/97314 (owner: 10Umherirrender) [19:41:40] no, i have to +2 each patch separately [19:41:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/97333 (owner: 10Platonides) [19:41:59] then when i merge the first one in the stack, all of them will be merged [19:42:11] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." (031 comment) [tools/code-utils] - 10https://gerrit.wikimedia.org/r/51033 (owner: 10Platonides) [19:42:16] ^ that is some funny code [19:42:49] hehe :) [19:43:01] that was to fix a problem after we started supporting __DIR__ :) [19:43:16] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48245 (owner: 10Platonides) [19:44:14] it isn't specially pretty [19:44:22] more or less parses php syntax [19:44:28] but works well enough :) [19:45:15] yeah, i didn't even know we had a php parser reimplementation in there [19:45:20] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48242 (owner: 10Platonides) [19:45:25] crazy stuff [19:45:33] it's not a perfect implementation, of course [19:45:56] but needs to keep track of things like number of opening and closing braces [19:46:00] (03CR) 10Bartosz Dziewoński: "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/47800 (owner: 10Platonides) [19:46:05] (03CR) 10Bartosz Dziewoński: [C: 032] Do not complain of the use of User::decodeOptions in User.php:1089 [tools/code-utils] - 10https://gerrit.wikimedia.org/r/47800 (owner: 10Platonides) [19:46:15] ok, this should now cause lots of merges. [19:46:27] (03CR) 10Siebrand: "Replied to comments. Submitting updated patch." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/97323 (owner: 10Siebrand) [19:46:29] (03CR) 10Nemo bis: "Siebrand, I agree, but can you clarify what part of that page you're looking at? It says, among other things, that it's an Italian languag" [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [19:46:50] you are stepping by file, right? [19:47:12] Platonides: i was going by the dependency list [19:47:16] ah, ok [19:47:16] (03PS2) 10Siebrand: Fix various type and reference issues [core] - 10https://gerrit.wikimedia.org/r/97323 [19:47:42] I mean, there are two trees, one of check-vars and another of find-entries [19:47:46] does jenkins merge code in that repo? [19:47:47] yeah, i see [19:48:01] and if you walked them by data, it could get messy [19:48:06] do you want me to rebase? [19:48:38] rebase what? why? [19:49:36] (03CR) 10Siebrand: "The rebase made the diff unreadable, so I added comments for the two changes made so it's easier to find." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/97323 (owner: 10Siebrand) [19:49:39] (03CR) 10Aaron Schulz: Fix various type and reference issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97323 (owner: 10Siebrand) [19:50:10] Platonides: ^ [19:50:21] (03CR) 10Siebrand: Fix various type and reference issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/97323 (owner: 10Siebrand) [19:50:33] (03PS3) 10Siebrand: Fix various type and reference issues [core] - 10https://gerrit.wikimedia.org/r/97323 [19:50:59] the changes [19:51:18] Platonides: why? [19:51:43] ah [19:51:46] Project policy requires all submissions to be a fast-forward. [19:51:53] yes [19:52:36] then yeah, i guess [19:52:41] you can just do that via gerrit [19:52:46] or i can do that, or whoever [19:53:21] are https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/tools/code-utils+branch:master+topic:find-entries,n,z included in the party? [19:53:23] it's easy [19:53:29] I'm ready [19:53:30] this will be a bit noisy [19:53:37] (03PS2) 10Platonides: Treat a { as closing a require line. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/57934 [19:53:38] (03PS4) 10Platonides: PEAR mail appeared twice. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48245 [19:53:39] (03PS4) 10Platonides: Improve handling of extension_loaded() [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48242 [19:53:40] (03PS2) 10Platonides: Add code to avoid the wfProfileOut false positives at the Preprocessors [tools/code-utils] - 10https://gerrit.wikimedia.org/r/97333 [19:53:41] (03PS2) 10Platonides: RedisLockManager class added in ed01e813 checks for RedisException [tools/code-utils] - 10https://gerrit.wikimedia.org/r/60004 [19:53:42] (03PS5) 10Platonides: Do not complain of the use of User::decodeOptions in User.php:1089 [tools/code-utils] - 10https://gerrit.wikimedia.org/r/47800 [19:53:43] (03PS3) 10Platonides: dirname(dirname(__DIR__)) and JobQueueAggregatorRedis.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/51033 [19:54:47] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/47800 (owner: 10Platonides) [19:54:48] (03PS4) 10Platonides: Whitelist getcwd() [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50590 [19:54:48] (03PS4) 10Platonides: Take into account files which include another file that then dies. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50589 [19:54:50] (03PS3) 10Platonides: Whitelist phpversion() [tools/code-utils] - 10https://gerrit.wikimedia.org/r/51027 [19:54:50] (03PS3) 10Platonides: Check the whole history of included files for Maintenance.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50918 [19:54:51] (03PS4) 10Platonides: Add another automaton for «if (PHP_SAPI!='cli')» [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50118 [19:54:53] (03PS4) 10Platonides: Add support for dirname( __DIR__ ) to find-entries. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50117 [19:54:54] (03PS3) 10Platonides: Instead of having multiple $cliSapiAutomaton, make it an array. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50707 [19:54:55] (03PS4) 10Platonides: Use stream_resolve_include_path to detect files loaded from pear [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50055 [19:54:56] (03PS3) 10Platonides: Add a couple of automatons [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50708 [19:54:56] stupid jenkins. [19:54:56] (03PS3) 10Platonides: Allow whitelisting additional functions on the command line. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50813 [19:54:58] (03PS3) 10Platonides: Allow a php shebang [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50812 [19:54:58] (03PS3) 10Platonides: Accept arbitrarily long lists of dirname() calls [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50811 [19:54:59] (03PS3) 10Platonides: Skip the $evaluatedFiles cache for Benchmarker.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50122 [19:55:01] (03Merged) 10jenkins-bot: Do not complain of the use of User::decodeOptions in User.php:1089 [tools/code-utils] - 10https://gerrit.wikimedia.org/r/47800 (owner: 10Platonides) [19:55:16] whaaat is going on. [19:55:18] okay, whatever. [19:55:23] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48242 (owner: 10Platonides) [19:55:36] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48245 (owner: 10Platonides) [19:55:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/51033 (owner: 10Platonides) [19:56:00] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/57934 (owner: 10Platonides) [19:56:12] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/60004 (owner: 10Platonides) [19:56:17] My rebase + your +2 + 3 jenkins messages = 5 lines per change [19:56:52] (03Merged) 10jenkins-bot: Improve handling of extension_loaded() [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48242 (owner: 10Platonides) [19:57:03] for 20 changes = 100 lines :P [19:57:07] (03Merged) 10jenkins-bot: PEAR mail appeared twice. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/48245 (owner: 10Platonides) [19:57:22] (03Merged) 10jenkins-bot: dirname(dirname(__DIR__)) and JobQueueAggregatorRedis.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/51033 (owner: 10Platonides) [19:57:32] (03Merged) 10jenkins-bot: Treat a { as closing a require line. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/57934 (owner: 10Platonides) [19:57:42] (03Merged) 10jenkins-bot: RedisLockManager class added in ed01e813 checks for RedisException [tools/code-utils] - 10https://gerrit.wikimedia.org/r/60004 (owner: 10Platonides) [19:59:17] i'm going to get so much mail [19:59:22] brb [20:00:41] (03PS1) 10Siebrand: Update formatting of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97334 [20:00:45] as much as I :) [20:00:49] *me [20:00:53] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Did not test, some comments. Razvor, can you fix this? :)" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [20:02:12] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/97333 (owner: 10Platonides) [20:02:55] (03Merged) 10jenkins-bot: Add code to avoid the wfProfileOut false positives at the Preprocessors [tools/code-utils] - 10https://gerrit.wikimedia.org/r/97333 (owner: 10Platonides) [20:03:43] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50055 (owner: 10Platonides) [20:03:48] (03Merged) 10jenkins-bot: Use stream_resolve_include_path to detect files loaded from pear [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50055 (owner: 10Platonides) [20:04:41] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50117 (owner: 10Platonides) [20:04:46] (03Merged) 10jenkins-bot: Add support for dirname( __DIR__ ) to find-entries. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50117 (owner: 10Platonides) [20:05:04] $definedAutomaton = token_get_all( " heh, what. [20:05:44] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50118 (owner: 10Platonides) [20:05:49] (03Merged) 10jenkins-bot: Add another automaton for «if (PHP_SAPI!='cli')» [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50118 (owner: 10Platonides) [20:06:09] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50122 (owner: 10Platonides) [20:06:13] (03Merged) 10jenkins-bot: Skip the $evaluatedFiles cache for Benchmarker.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50122 (owner: 10Platonides) [20:06:19] i really hope that code works. :P [20:07:18] (03CR) 10Siebrand: "* http://www.ethnologue.com/language/cos: http://www.ethnologue.com/language/cos" [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [20:08:12] (03CR) 10Platonides: [C: 032] Add .mw-editsection-like class, behavior same as .mw-editsection [core] - 10https://gerrit.wikimedia.org/r/87627 (owner: 10Bartosz Dziewoński) [20:09:06] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50589 (owner: 10Platonides) [20:09:10] (03Merged) 10jenkins-bot: Take into account files which include another file that then dies. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50589 (owner: 10Platonides) [20:09:28] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50590 (owner: 10Platonides) [20:09:32] (03Merged) 10jenkins-bot: Whitelist getcwd() [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50590 (owner: 10Platonides) [20:09:45] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50707 (owner: 10Platonides) [20:09:49] (03Merged) 10jenkins-bot: Instead of having multiple $cliSapiAutomaton, make it an array. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50707 (owner: 10Platonides) [20:10:10] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50708 (owner: 10Platonides) [20:10:14] (03Merged) 10jenkins-bot: Add a couple of automatons [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50708 (owner: 10Platonides) [20:10:29] almost there! [20:10:55] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50811 (owner: 10Platonides) [20:10:59] (03Merged) 10jenkins-bot: Accept arbitrarily long lists of dirname() calls [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50811 (owner: 10Platonides) [20:11:07] yay, that felt good to merge ^ [20:11:25] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50812 (owner: 10Platonides) [20:11:34] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50813 (owner: 10Platonides) [20:11:40] (03Merged) 10jenkins-bot: Allow a php shebang [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50812 (owner: 10Platonides) [20:11:47] (03Merged) 10jenkins-bot: Allow whitelisting additional functions on the command line. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50813 (owner: 10Platonides) [20:11:57] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50918 (owner: 10Platonides) [20:12:00] (03Merged) 10jenkins-bot: Check the whole history of included files for Maintenance.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/50918 (owner: 10Platonides) [20:12:42] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging the whole stack of changes. They work, and the patches have been sitting here for too long." [tools/code-utils] - 10https://gerrit.wikimedia.org/r/51027 (owner: 10Platonides) [20:12:44] (03Merged) 10jenkins-bot: Whitelist phpversion() [tools/code-utils] - 10https://gerrit.wikimedia.org/r/51027 (owner: 10Platonides) [20:12:52] (03CR) 10Platonides: [C: 032] "Perfect" [core] - 10https://gerrit.wikimedia.org/r/90156 (owner: 10Bartosz Dziewoński) [20:12:55] and presto! [20:13:29] (03Merged) 10jenkins-bot: Add .mw-editsection-like class, behavior same as .mw-editsection [core] - 10https://gerrit.wikimedia.org/r/87627 (owner: 10Bartosz Dziewoński) [20:13:48] wow, my "outgoing reviews" is short now :) [20:14:35] mine is still long :( [20:14:55] I merged a couple of your changeset [20:15:12] I started looking "comment: this doesn't work" [20:15:21] "this should wat untl branching..." [20:15:30] heh [20:15:40] i tink only the oldest few are like that [20:16:27] i just marked 90 emails as read. :D [20:17:07] (03CR) 10Platonides: "I agree, a javascript autocomplete dropdown would be more appropiate." [core] - 10https://gerrit.wikimedia.org/r/80781 (owner: 10Bartosz Dziewoński) [20:17:28] well, I went to the oldest... [20:18:43] (03CR) 10Nemo bis: "Siebrand, thanks, now I understand better. It would definitely not be the same. :) Hungarian and Finnish are two finno-ugric languages but" [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [20:19:08] (03CR) 10Siebrand: "This doesn't merge. Just enter them in https://translatewiki.net?" [core] - 10https://gerrit.wikimedia.org/r/44397 (owner: 10VitaliyFilippov) [20:20:01] (03CR) 10Siebrand: [C: 04-1] Add russian messages for bad title errors. [core] - 10https://gerrit.wikimedia.org/r/44397 (owner: 10VitaliyFilippov) [20:20:13] (03CR) 10Bartosz Dziewoński: "The translations being added here are for messages added in the dependency (unmerged)." [core] - 10https://gerrit.wikimedia.org/r/44397 (owner: 10VitaliyFilippov) [20:21:47] (03CR) 10Platonides: [C: 032] "What a function! Approved" [core] - 10https://gerrit.wikimedia.org/r/94615 (owner: 10Bartosz Dziewoński) [20:24:42] siebrand: re https://gerrit.wikimedia.org/r/#/c/97006/ - is somebody from TWN handling migrating translations for these to the new ones? or do you think it's not worth it? [20:24:44] (03PS3) 10Siebrand: Add missing return value [core] - 10https://gerrit.wikimedia.org/r/97326 [20:25:17] MatmaRex: Raimond takes care of those things, and AFIAK He does that meticulously. [20:25:26] (03Merged) 10jenkins-bot: EnhancedChangesList: Add missing [core] - 10https://gerrit.wikimedia.org/r/94615 (owner: 10Bartosz Dziewoński) [20:26:33] siebrand: okay. i could play with ReplaceText myself, but in that case i'll leave this to professionals :) [20:27:18] (03CR) 10Siebrand: [C: 04-1] "Per comment by Niklas. As it's the same line and topic, might as well be added in this patch." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 (owner: 10MarkTraceur) [20:27:45] MatmaRex: You should only do that once the source files are updated, and you'd need a shell account and some training for that. [20:28:21] (03CR) 10Platonides: [C: 032] Remove 'prefsnologin' message, don't use 'watchnologin' where inappropriate [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [20:28:21] MatmaRex: If you're up for that, I'd happily provide you with shell. With more active staff, we can do more and respond quicker to translator raised issues. [20:29:54] (03PS1) 10Aaron Schulz: filebackend: exception handling cleanups [core] - 10https://gerrit.wikimedia.org/r/97336 [20:31:12] siebrand: thanks, but no; i'm afraid i'm already doing too many things to do any of them properly [20:31:21] (03CR) 10Nemo bis: "Just for fun, I've read a few articles from co.wiki like https://co.wikipedia.org/wiki/Napulione_Buonaparte and I can say that the variant" [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [20:31:22] MatmaRex: ditto... [20:31:37] (03Merged) 10jenkins-bot: Remove 'prefsnologin' message, don't use 'watchnologin' where inappropriate [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [20:32:25] i've almost withdrawn from the pl.wp community too, and i can't say i'm too happy aobut that [20:33:19] i'm getting ~400 emails daily (including bugmail, gerritmail, etc.) and still trying to at least skim them all [20:37:15] (03CR) 10Platonides: [C: 04-1] "If you are passing an explicit parameter,why override it in the attribs? That's for other, uncommon, attributes." [core] - 10https://gerrit.wikimedia.org/r/97306 (owner: 10Bartosz Dziewoński) [20:37:41] (03CR) 10Siebrand: [C: 031] filebackend: exception handling cleanups [core] - 10https://gerrit.wikimedia.org/r/97336 (owner: 10Aaron Schulz) [20:38:48] MatmaRex, I at least looked at your pending changes [20:38:55] MatmaRex: I went nl.wp -> commons -> twn -> mediawiki -> wmf, and the first two I only visit occasionally now. It's a matter of choice, i think, and sometimes one has to move on to keep things interesting. [20:39:15] although there were fewer approve than expected [20:39:25] I left notes in a couple of them [20:41:17] * Platonides moves 54 gerrit mails to the archive [20:41:32] (03PS2) 10Aaron Schulz: filebackend: exception handling cleanups [core] - 10https://gerrit.wikimedia.org/r/97336 [20:41:56] Platonides: thanks [20:42:34] (03CR) 10Aaron Schulz: [C: 032] Fix various type and reference issues [core] - 10https://gerrit.wikimedia.org/r/97323 (owner: 10Siebrand) [20:42:43] (03CR) 10Aaron Schulz: [C: 032] Add missing return value [core] - 10https://gerrit.wikimedia.org/r/97326 (owner: 10Siebrand) [20:43:26] you're more than welcome :) [20:44:53] * Platonides moves another 47 gerrit mails [20:46:37] (03Merged) 10jenkins-bot: Fix various type and reference issues [core] - 10https://gerrit.wikimedia.org/r/97323 (owner: 10Siebrand) [20:47:06] (03PS1) 10Platonides: LanguageGvTest::testGetPluralRuleType() has never worked [core] - 10https://gerrit.wikimedia.org/r/97337 [20:52:36] (03Abandoned) 10Huji: (bug 55486) Add .gitignore to the /skins directory to make it easier to work on extensions [core] - 10https://gerrit.wikimedia.org/r/88669 (owner: 10Huji) [20:55:36] (03PS1) 10Siebrand: Break lon glines in file repo files [core] - 10https://gerrit.wikimedia.org/r/97338 [20:56:13] (03PS2) 10Platonides: SpecialPreferencesTest needs a db [core] - 10https://gerrit.wikimedia.org/r/64562 [20:56:38] original commit was from May... [20:58:07] (03PS3) 10Siebrand: Remove leading underscore from method name [core] - 10https://gerrit.wikimedia.org/r/97318 [21:01:54] (03PS1) 10Siebrand: Rename File::_getIsSafeFile() to getIsSafeFileUncached() [core] - 10https://gerrit.wikimedia.org/r/97339 [21:02:10] Platonides: there are patches in the low thousands that are still open :( [21:02:21] https://www.mediawiki.org/wiki/Gerrit/Reports/Oldest_open_changesets [21:06:20] https://www.mediawiki.org/w/index.php?title=Gerrit%2FReports%2FOldest_open_changesets&diff=826930&oldid=821260 :) [21:08:59] meh, still above 800 open unreviewed patches [21:09:10] hah [21:09:12] (03PS2) 10Platonides: Make phpunit pick the test @groups [core] - 10https://gerrit.wikimedia.org/r/97328 [21:09:19] Platonides: i think that's autoupdated from time to time [21:09:30] (probably when the list changes, eh) [21:09:35] yes, it's a bot [21:10:18] Nemo_bis, the changes I created today are very easy to review... [21:10:22] the cron is on github too ;) [21:10:54] on the bright side, now only 72 % of open patches are from outside WMF :) a small step towards non-discrimination [21:11:15] Platonides: are you saying the number will quickly go down? [21:12:33] not really, [21:12:42] I was just pointing out, in case you wanted to help making them go down ;) [21:13:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does not merge :(" [core] - 10https://gerrit.wikimedia.org/r/12782 (owner: 10Platonides) [21:14:13] for some definition of "you" [21:15:19] xD [21:15:21] (03PS2) 10Platonides: Make checkPHPExtension() load the extension when it's available. [core] - 10https://gerrit.wikimedia.org/r/97329 [21:15:22] (03PS2) 10Platonides: Replace a bunch of extension_loaded() checks with checkPHPExtension() [core] - 10https://gerrit.wikimedia.org/r/97330 [21:17:09] (03PS2) 10Siebrand: Break lon glines in file repo files [core] - 10https://gerrit.wikimedia.org/r/97338 [21:17:15] (03PS2) 10Siebrand: Rename File::_getIsSafeFile() to getIsSafeFileUncached() [core] - 10https://gerrit.wikimedia.org/r/97339 [21:17:32] (03PS4) 10Bartosz Dziewoński: Canonicalize text and update docs of messages using 'loginreqlink' [core] - 10https://gerrit.wikimedia.org/r/94414 [21:18:13] (03Abandoned) 10Bartosz Dziewoński: Xml::textarea: Custom attributes should override default ones [core] - 10https://gerrit.wikimedia.org/r/97306 (owner: 10Bartosz Dziewoński) [21:29:22] (03PS1) 10Siebrand: Set visibility on the class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 [21:30:26] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on the class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [21:30:55] (03PS2) 10Siebrand: Set visibility on the class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 [21:31:55] (03CR) 10Umherirrender: Remove deprecated EditPage::spamPage() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95839 (owner: 10Chad) [21:32:01] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on the class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [21:34:27] (03CR) 10Scimonster: "This is as small as i could shrink Chrome: http://imgur.com/3xdQEod" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [21:37:34] (03PS1) 10Siebrand: Set visibility on class properties of OldLocalFile [core] - 10https://gerrit.wikimedia.org/r/97344 [21:38:41] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on class properties of OldLocalFile [core] - 10https://gerrit.wikimedia.org/r/97344 (owner: 10Siebrand) [21:39:21] (03PS2) 10Siebrand: Set visibility on class properties of OldLocalFile [core] - 10https://gerrit.wikimedia.org/r/97344 [21:40:39] (03CR) 10Aaron Schulz: [C: 032] Break long lines in file repo files [core] - 10https://gerrit.wikimedia.org/r/97338 (owner: 10Siebrand) [21:40:45] (03CR) 10Siebrand: Remove deprecated EditPage::spamPage() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95839 (owner: 10Chad) [21:46:56] (03CR) 10Rillke: "Thanks for all the feedback. In case anyone wants this chage, it's easy to restore." [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [21:47:53] (03Abandoned) 10Rillke: Adding "it" as a fallback language to for Corsican [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [21:52:17] (03CR) 10Jack Phoenix: [C: 032 V: 032] "UserStats' incStatField() and decStatField() -- which are called after a user's social points should be increased or decreased, also by ot" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97302 (owner: 10UltrasonicNXT) [21:55:03] (03PS1) 10Umherirrender: Let maintenance class start with a upper case letter [core] - 10https://gerrit.wikimedia.org/r/97345 [21:56:39] (03PS1) 10Aude: Add @group medium to ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/97346 [22:04:31] (03CR) 10Aaron Schulz: [C: 032] Update formatting of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97334 (owner: 10Siebrand) [22:04:56] (03CR) 10Platonides: [C: 032] "It may also be a good idea to rename McTest to MemcacheTest" [core] - 10https://gerrit.wikimedia.org/r/97345 (owner: 10Umherirrender) [22:07:09] (03PS1) 10Umherirrender: Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 [22:07:48] (03Merged) 10jenkins-bot: Break long lines in file repo files [core] - 10https://gerrit.wikimedia.org/r/97338 (owner: 10Siebrand) [22:07:49] (03Merged) 10jenkins-bot: Update formatting of file repo classes [core] - 10https://gerrit.wikimedia.org/r/97334 (owner: 10Siebrand) [22:08:17] (03PS1) 10Theopolisme: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 [22:09:51] (03Merged) 10jenkins-bot: Let maintenance class start with a upper case letter [core] - 10https://gerrit.wikimedia.org/r/97345 (owner: 10Umherirrender) [22:10:01] (03CR) 10jenkins-bot: [V: 04-1] Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [22:10:56] (03PS1) 10Aaron Schulz: filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 [22:12:33] (03CR) 10Legoktm: [C: 032] Add @group medium to ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/97346 (owner: 10Aude) [22:12:45] (03CR) 10Edokter: [C: 031] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [22:13:44] (03PS2) 10Umherirrender: Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 [22:14:37] (03CR) 10jenkins-bot: [V: 04-1] filebackend: cleaned up the FileBackend constructor [core] - 10https://gerrit.wikimedia.org/r/97349 (owner: 10Aaron Schulz) [22:14:38] (03CR) 10Umherirrender: "LanguageClassesTestCase extracts language name from the class name, so LanguageBe_taraskTest.php cannot be renamed at the moment." [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [22:15:05] MatmaRex: 400 emails/day? ouch [22:15:55] (03CR) 10jenkins-bot: [V: 04-1] Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [22:17:39] legoktm: a lot of that is gerrit spam [22:17:53] takes me a few milliseconds to sort that out [22:18:08] (03Merged) 10jenkins-bot: Add @group medium to ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/97346 (owner: 10Aude) [22:18:12] a few dozens actual emails i should read, i guess [22:18:37] (03PS3) 10Umherirrender: Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 [22:19:10] heh [22:19:44] i should probably do some stats on that someday [22:21:56] let's see, I have 28k mails in trash since... argh I shouldn't have used ctrl+a on that dir [22:21:58] (03PS1) 10Siebrand: Set visibility for class properties in LocalFile.php [core] - 10https://gerrit.wikimedia.org/r/97350 [22:22:40] (03CR) 10jenkins-bot: [V: 04-1] Remove underscore from classes in phpunit tests [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [22:23:07] (03CR) 10Siebrand: "recheck" [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [22:23:45] (03CR) 10jenkins-bot: [V: 04-1] Set visibility for class properties in LocalFile.php [core] - 10https://gerrit.wikimedia.org/r/97350 (owner: 10Siebrand) [22:24:46] hm, february [22:25:03] i have about 2.5 GB of email locally. [22:25:16] (03CR) 10Siebrand: "@hashar: Can you see what's wrong here?" [core] - 10https://gerrit.wikimedia.org/r/97350 (owner: 10Siebrand) [22:25:28] i don't think that includes everything i've ever received, my mail client DB might be slightly borked [22:25:30] I have 7GB used in gmail. [22:25:51] (03PS3) 10Siebrand: Set visibility on the class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 [22:26:11] gmail claims i am using 2.39 GB [22:26:21] funny, used to be larger, and i don't remember deleting anything. [22:26:28] i think that number is a lie. [22:26:56] (03CR) 10jenkins-bot: [V: 04-1] Set visibility on the class properties of UnregisteredLocalFile [core] - 10https://gerrit.wikimedia.org/r/97343 (owner: 10Siebrand) [22:28:16] Hello [22:28:25] MatmaRex: where are you checking it? gmail's interface now only gives the combined size across all services, you need to click [22:29:07] (03CR) 10Legoktm: [C: 032] "Awesome." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/59760 (owner: 10Alex Monk) [22:29:08] (03CR) 10Parent5446: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [22:29:10] (03Merged) 10jenkins-bot: Fix hiding of other expiry input row [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/59760 (owner: 10Alex Monk) [22:30:21] (03CR) 10Umherirrender: "Looks like jenkins does not love this patch set." [core] - 10https://gerrit.wikimedia.org/r/97347 (owner: 10Umherirrender) [22:30:23] Nemo_bis: at the bottom of the page. http://i.imgur.com/H5H9wp7.png [22:31:02] 2.38 of that is gmail, according to https://www.google.com/settings/storage [22:31:53] (03CR) 10Legoktm: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [22:32:27] I would like to embed mediawiki in another php application where authentication is performed by that app, and a header div is displayed in addition to the wiki page. [22:33:11] I have looked at the class MediaWiki and at RequestContext and think that it might be doable. [22:35:49] kami: if you just want to change authentication, you should look into https://www.mediawiki.org/wiki/AuthPlugin [22:36:00] kami: You could probably write an extension similar to Extension:OpenID that does the authentication, but why are you doing this? [22:37:08] It's not only the authentication. I would like to integrate MW as a component in another application which has a wiki, but the wiki is weak (pun intended). [22:38:46] You might know the application: it is phabricator.org [22:40:33] ah [22:41:49] If I could prevent MediaWiki->run() from rendering the page, but instead capture the output and put it into a 'PhrictionDocument', I would be almost done. [22:42:05] MatmaRex: I talked with Mateusz M. (not me, another Mateusz M. :P) and... I have poor internet connection at home... But why you developed MediaWiki on users.v-lo.krakow.pl? :D [22:42:43] kami: neat, I like phabrictor from what I can tell :) [22:43:07] greg-g: yes, it contains almost everything a software shop would need [22:43:18] it only lacks a real wiki [22:43:46] heh, watch out for mediawiki then ;) [22:44:00] and MW (I don't dare to say it, but maybe even Semantic MW) would be a good fit [22:44:11] definitely [22:44:50] kami: just use ob_start, ob_get_clean and friends? [22:45:07] !hss [22:45:07] ZOMG!! http://bit.ly/2sYkfl – #semantic-mediawiki [22:45:15] I am completely new to the MW code. Just spent 2 hours this morning to look around a bit. [22:45:50] MatmaRex: thank you. I will look at those. [22:49:15] what about OutputPage in RequestContext? [22:53:00] OutputPage.output uses ob_start + ob_end_flush [22:59:36] (03CR) 10Bartosz Dziewoński: "Add some basic unit tests, pretty please :) See https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing and the /tests/qunit/suites/" [core] - 10https://gerrit.wikimedia.org/r/97348 (owner: 10Theopolisme) [23:00:07] kami: You could probably also consider "just" using MW API calls in the phabricator backend [23:00:31] It might make auth, etc. easier [23:01:24] (03CR) 10Theopolisme: "Cool, that will be fun :)" [core] - 10https://gerrit.wikimedia.org/r/97348 (owner: 10Theopolisme) [23:01:30] marktraceur: what are MW API calls? You mean the methods of the class MediaWiki or all of the API? [23:01:30] [23:01:46] kami: I mean the HTTP API that MediaWiki provides [23:01:53] You can do edits over it, get page text, even rendered pages [23:02:00] marktraceur: I see [23:02:53] (03CR) 10Bartosz Dziewoński: "There is also a "manual" test suite at https://test.wikipedia.org/wiki/User:Krinkle/CollapsingTestpageMw , by the way, I think it contains" [core] - 10https://gerrit.wikimedia.org/r/97348 (owner: 10Theopolisme) [23:02:58] Sounds even easier. The MW instance would still be usable stand-alone. [23:03:44] marktraceur: where do I find some docs about that HTTP API? [23:04:09] kami: You can go to api.php to find the docs [23:04:20] marktraceur: thanks. [23:04:36] e.g. if your wiki's index is http://example.com/w/index.php you would go to http://example.com/w/api.php [23:05:27] also, [23:05:27] !api [23:05:28] The MediaWiki API provides direct, high-level access to the data contained in the MediaWiki databases. Client programs should be able to use the API to login, get data, and post changes. Find out more at < https://www.mediawiki.org/wiki/API >. For client libraries in various languages, see < https://www.mediawiki.org/wiki/API:Client_Code >. [23:05:56] the ones are api.php are guaranteed to be up-to-date, though, and the ones on mw.org not necessarily [23:07:52] Sounds great. [23:08:01] Will have a look at them tomorrow. [23:09:08] But if I would decide to go the other route and really use php in-process calls, where exactly is the output written into the response? [23:11:09] kami: i think you're looking for the OutputPage#output method [23:11:29] kami: or the call to it in Wiki#main [23:11:37] MediaWiki#main * [23:11:40] in OutputPage->output, there is ob_start, followed by $this->getSkin()->outputPage() [23:12:16] or alternatively if ( $this->mArticleBodyOnly) echo $this->mBodytext; [23:12:17] [23:12:26] well [23:12:31] it's complicated [23:12:39] most people avoid those areas. :P [23:13:04] (03CR) 10Swalling: "@Parent5446 I don't think we actually want to remove it from user login? The goal here is to clean up Preferences by removing a redundant " [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [23:13:42] heh, i just looked in SkinTemplate#outputPage [23:13:43] // @todo Add wfDeprecated in 1.20 [23:13:56] guess what, there is no wfDeprecated there. [23:14:15] MatmaRex: Do it do it do it [23:14:21] marktraceur: lolno [23:14:37] marktraceur: last time i wanted to kill something that should have been deprecated four versions ago [23:14:38] well [23:14:43] let's just say the patches are still pending [23:14:46] Heh. [23:14:51] and another verison was released in the meantime [23:14:56] is being released* [23:15:10] because, guess what, everybody and their dog is still calling that code. [23:16:08] MatmaRex: what I would like to do is to prevent that the output of MediaWiki#output goes into the response directly, but to gather it in a buffer, then trick phabricator into thinking that its own machinery has rendered their own wiki markup, and set the content of the buffer which was rendered by MW into the phabricator document's content. [23:17:31] kami: i think you can just wrap the calls to any functions that output stuff in ob_start() and ob_get_clean()? or does that fail when the inner functions call these too? [23:17:51] (where ob_get_clean() will return everything that was "outputted" since the ob_start() call) [23:18:43] MatmaRex: I will try that out. [23:20:11] ob_end_flush will of course write it out, but I could work around that, if ob_end_flush is not called in many different places [23:20:37] is MediaWiki#output the only place where I have to expect the ob_end_flush call? [23:20:59] no idea [23:21:42] grep is my friend :) [23:21:48] Grep grep greeeep [23:23:25] (03PS2) 10Theopolisme: jquery.makeCollapsible: collapse to caption support [core] - 10https://gerrit.wikimedia.org/r/97348 [23:23:28] now the redirects: I saw wfRunHooks( "BeforePageRedirect"... in #output [23:24:59] I guess with that, I can prevent a redirect, right? [23:30:14] MatmaRex, marktraceur: thank you for your help. It's getting late here. I will try out ob_start etc. tomorrow. [23:30:41] Bye. [23:42:40] !pastebin [23:42:41] To avoid overflowing the channel with inane amounts of text, use https://dpaste.org/ or other awesome pastebin sites to share code, errors, and other large texts.