[00:00:04] legoktm: I think we may get rid of it, given that it's hidden except for opt-un users on enwiki. [00:00:14] * bawolff 's browser isn't supported, so doesn't see the VE things [00:00:24] bawolff: What browser do you use? [00:00:31] (03PS2) 10Aaron Schulz: Truncate super long SQL in DB error log lines (useful for blobs) [core] - 10https://gerrit.wikimedia.org/r/96906 [00:00:33] Firefox 3.5.16 (and proud!) [00:00:38] * ^d files a bug about how it doesn't work on w3m [00:00:40] bawolff: Oh… dear…. [00:00:51] * bawolff opens chrome to see how it looks [00:01:16] bawolff: We blacklisted FF < 15 due to them only fixing a major DOM corruption bug then. [00:01:21] ^d: Half expecting Jiddini to.. [00:01:31] Newer versions of firefox make me feel old. [00:01:41] bawolff: At some point we may make a shim to allow FF 13/14 to work, but… not below FF 10. [00:01:51] I don't want my software to have a version number anywhere near my age! [00:02:12] Real reason is that apt-get won't let me upgrade without upgrading gnome, which I don't really want to do [00:02:24] Is that a real dependency? [00:03:16] 22.0a2 (2013-04-19) [00:03:31] James_F: Its something weird going on with them both depending on libcario [00:03:40] bawolff: Ah, fun. [00:03:41] * bawolff not really an expert in linux package managers [00:03:47] (03PS1) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [00:03:53] bawolff: And your OS doesn't do het-deploy for libcairo? [00:04:19] I have no idea, my package management skills involve using the GUI [00:04:23] # experimental for modern Iceweasel [00:04:23] deb http://ftp.us.debian.org/debian experimental main [00:04:23] deb http://mozilla.debian.net/ experimental iceweasel-aurora [00:04:25] there isn't a button for that [00:04:35] i added those repos just for newer iceweasel/firefox [00:04:40] and left the rest on wheezy [00:04:47] worksforme [00:05:24] James_F: Damn igt [00:05:29] I blame the distractions [00:05:35] Reedy: Yeah. :-( [00:05:42] Reedy: Yay for post-midnight deploys. [00:05:50] (03CR) 10jenkins-bot: [V: 04-1] Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [00:06:03] what's the dilly yo? [00:06:15] texcv stuffs? [00:06:25] Fixing it at the speed of scroll [00:06:31] heh [00:06:49] bawolff: GUI would be something like clicking in "Ubuntu Software Center" and adding a repo [00:06:51] I need to finish and fix my fix to get rid of this [00:06:57] if Ubuntu is what you have [00:07:04] synaptic [00:07:07] (03PS2) 10Tholam: Add warning that patches should go to Gerrit instead of Bugzilla [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 [00:07:08] Reedy: csteipp is wanting to do the oauth stuff, should he wait until you're done fixing this? or should he go ahed? [00:07:09] I'm using real debian [00:07:15] greg-g: He can go ahead [00:07:22] csteipp: go forth [00:07:23] Mines nearly done but wouldn't affect him anyway [00:07:29] * greg-g nods [00:07:35] !log Built texvc for 1.23wmf5 [00:07:35] Wrong channel, try again. [00:07:40] greg-g: Cool. [00:07:41] * Reedy kicks wm-bot [00:07:45] * Elsie hugs wm-bot. [00:07:50] greg-g: Rendering of blocks is broken 'cos MW can't find texvc. [00:07:51] bawolff: ok, nice, then that or edit /etc/apt/sources.list or better put a new file in /etc/apt/sources.list.d/ [00:07:57] James_F: awesome [00:08:02] James_F: refresh all the things [00:08:06] apt-get update and apt-get install iceweasel [00:08:07] greg-g: And I found it through checking VE. Yay. [00:08:08] MathJax, ftw. ;-) [00:08:13] James_F: is this only affecting betafeature opt-ins, or everyone? [00:08:25] greg-g: It's affecting all use of on wmf5. [00:08:33] greg-g: So… no and yes. [00:08:34] ah, so, no one ;) [00:08:43] but yeah, good catch :) [00:08:57] thanks James_F [00:08:58] 16:12 < Reedy> !log Built texvc for 1.23wmf5 [00:09:00] Reedy: Confirmed, working. [00:09:02] greg-g: Always. [00:09:10] James_F: sorry for confusion today [00:09:14] Reedy: Specifically: confirmed, working in wmf5, and still working in wmf4. [00:09:18] greg-g: Not your fault at all. [00:10:25] <^d> Does anyone know how to use Yuvi's tool to get a pull request into gerrit? [00:10:54] Ring the YuviPanda hotline [00:11:05] <^d> nick says |zzz. [00:11:27] ^d: To be fair, it is 05:41 there. :-) [00:11:30] there's that tool to get a gerrit patch from filling out a form [00:11:38] Speaking of, my body clock is still mostly on IST, and a bit on UTC. [00:11:43] <^d> mutante: Not what I want :) [00:11:44] So it's either 05:41 or 00:11. [00:11:46] Yay fun. [00:12:03] ^d: it stopped working so he has to run the script manually :/ [00:12:15] it's https://github.com/yuvipanda/SuchABot if you want to fix it :P [00:12:20] <^d> Aw no fun :( [00:13:06] <^d> One of the hhvm guys wrote us a pull request and I wanted to try and get it in gerrit :) https://github.com/wikimedia/mediawiki-core/pull/13 [00:13:27] Copy and paste. [00:13:28] (03PS1) 10CSteipp: Update WikimediaMessages to master for wmf4 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96919 [00:13:51] <^d> Elsie: I can think of a half dozen ways around it, including copy+paste :) [00:13:54] pull and push [00:13:57] <^d> I just thought I'd ask before I did. [00:13:57] ^d oh easy [00:14:01] (03PS1) 10Gergő Tisza: WIP Make thumb.php redirects point to thumb.php [core] - 10https://gerrit.wikimedia.org/r/96920 [00:14:05] ^d: Add it as a GCI task [00:14:11] ^d: take https://github.com/ptarjan/mediawiki-core/commit/f20aae93e54705b2d1724afc75f0dc097cdda6fc.patch and use gerrit-patch-uploader [00:14:14] Mark it with the "easy" keyword in Bugzilla. [00:14:37] <^d> legoktm: I'd probably just fetch the patch and amend it locally. [00:14:42] <^d> :) [00:15:08] well, that works too [00:16:59] (03PS1) 10CSteipp: Update WikimediaMessages for wfm5 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96923 [00:17:49] (03CR) 10CSteipp: [C: 032] Update WikimediaMessages for wfm5 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96923 (owner: 10CSteipp) [00:18:12] (03CR) 10CSteipp: [C: 032] Update WikimediaMessages to master for wmf4 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96919 (owner: 10CSteipp) [00:20:18] (03CR) 10Gergő Tisza: "Haven't tested yet; just want to see if this is not a completely wrong approach." [core] - 10https://gerrit.wikimedia.org/r/96920 (owner: 10Gergő Tisza) [00:21:42] tgr: I just skimmed the code, but it looks like you're doing something different in the code then what the commit message says (?) [00:22:22] bawolff: may be [00:22:42] (03PS3) 10EBernhardson: CSS transitions for hover effects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96690 [00:23:01] i have to set up a foreign repo locally to get that code running, i havent gotten there yet [00:23:27] You don't need a foreign repo for thumbnail handler [00:24:03] Just some apache config changes - see https://www.mediawiki.org/wiki/Manual:Thumb.php [00:24:05] the idea was to generate a new thumb.php link, transform() seemed to do that [00:24:11] i might have misread the code [00:24:25] <^d> bawolff: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTimedMediaHandler.git/6a8129cf23dce3918f633fc63264c4797bdf12b1/TimedMediaTransformOutput.php#L272 makes me cry :p [00:24:47] ^d: TimedMediaHandler makes me cry in so many ways... [00:24:53] <^d> +1 [00:25:17] tgr: That should just generate a new thumbnail and return a direct path to the thumbnail [00:25:26] tgr: which is probably a good approach to take [00:25:30] <^d> bawolff: That FauxRequest to ApiMain keeps us from using Cirrus on private wikis :p [00:26:33] (03CR) 10Chad: [C: 032] Truncate super long SQL in DB error log lines (useful for blobs) [core] - 10https://gerrit.wikimedia.org/r/96906 (owner: 10Aaron Schulz) [00:26:35] ^d: can't you just replace it with a DerivativeReuqest? [00:26:45] (03PS1) 10Aaron Schulz: Made SqlBagOStuff fully avoid transactions when possible [core] - 10https://gerrit.wikimedia.org/r/96924 [00:26:46] <^d> Dunno. [00:26:48] <^d> Mayeb. [00:26:57] ^d: To be fair, the whole api doesn't work at all on private wikis doesn't make sense to me [00:27:40] wait, wtf is that code even doing, is it just getting a thumbnail [00:27:47] ^d: https://gerrit.wikimedia.org/r/#/c/96924/ [00:27:51] <^d> bawolff: Yep. [00:27:54] why would it do the api for that [00:28:13] <^d> Because think of who probably wrote that ;-) [00:28:23] bawolff: transform() doesn't seem to generate anything if you call it without flags [00:28:40] tgr: That should depend on your wiki settings [00:28:48] if you don't have a 404 handler, it should generate stuff [00:28:53] (03Merged) 10jenkins-bot: Update WikimediaMessages for wfm5 [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96923 (owner: 10CSteipp) [00:30:00] (03Merged) 10jenkins-bot: Update WikimediaMessages to master for wmf4 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96919 (owner: 10CSteipp) [00:30:15] (03CR) 10Chad: [C: 032] Made SqlBagOStuff fully avoid transactions when possible [core] - 10https://gerrit.wikimedia.org/r/96924 (owner: 10Aaron Schulz) [00:30:18] (03CR) 10Aaron Schulz: [C: 032] Handle CDB errors more gracefully in cdb.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/96907 (owner: 10Chad) [00:30:59] bawolff: won't $this->getTransformScript(); be truthy then? [00:31:27] anyway, if it generates the thumbnail before redirecting, even better [00:31:52] (03Merged) 10jenkins-bot: Truncate super long SQL in DB error log lines (useful for blobs) [core] - 10https://gerrit.wikimedia.org/r/96906 (owner: 10Aaron Schulz) [00:32:02] (03PS1) 10Ori.livneh: Update MobileFrontend for I3efc1fa64 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96926 [00:32:34] (03CR) 10BryanDavis: "Mark: 1.23wmf4 is on all wikis now and contains this changeset plus it's performance improvement follow ups (Ia81bed7d8b42a2d2b200a3ce45a7" [core] - 10https://gerrit.wikimedia.org/r/94186 (owner: 10BryanDavis) [00:32:45] (03CR) 10Awjrichards: [C: 032 V: 032] Update MobileFrontend for I3efc1fa64 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96926 (owner: 10Ori.livneh) [00:34:10] (03CR) 10Chad: [C: 032] Avoiding implicit transactions when applying [core] - 10https://gerrit.wikimedia.org/r/96912 (owner: 10Aaron Schulz) [00:38:37] (03Merged) 10jenkins-bot: Made SqlBagOStuff fully avoid transactions when possible [core] - 10https://gerrit.wikimedia.org/r/96924 (owner: 10Aaron Schulz) [00:39:41] (03CR) 10Awjrichards: "@hashar I looked briefly at pywikibot (I am not really familiar with it) and it seems totally overkill. I just wanted a really simple, lig" [tools/release] - 10https://gerrit.wikimedia.org/r/95738 (owner: 10Awjrichards) [00:40:35] (03Merged) 10jenkins-bot: Handle CDB errors more gracefully in cdb.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/96907 (owner: 10Chad) [00:40:50] awjr: wikitools, simplemediawiki, etc [00:41:03] * awjr looks [00:41:07] awjr: pywikibot will nicely handle all the edge cases for you, which is why it looks like its overkill [00:41:29] makes sense [00:41:37] that's nicely put, legoktm [00:42:05] :) [00:43:30] blargh, i just want something quick and dirty :) [00:43:46] wikitools is your best bet then [00:43:49] <^d> Quick and dirty? That's what we do best! [00:43:53] https://github.com/alexz-enwp/wikitools [00:44:00] legoktm: yeah im looking at it already [00:44:07] mine's even quicker and dirtier :p [00:44:31] all i need to do is log in and post some wikitext [00:44:34] https://github.com/legoktm/supersimplemediawiki [00:44:37] <^d> Quicker and dirtier would've been a bunch of file_get_contents() calls to the API without any semblance of trying to use a library ;-) [00:44:49] ^d you mean quickest and dirtiest ;) [00:45:23] also https://github.com/yuvipanda/python-mwapi [00:45:28] oo you used requests too legoktm [00:45:32] yeah [00:46:00] no need to reinvent the wheel :P [00:46:09] requests has a concept of sessions that allows you to persist all the good cookies across all requests with no extra work [00:46:15] how i wish that were true ... [00:46:46] legoktm: eg https://gerrit.wikimedia.org/r/#/c/95750/3/git-logs/mwapi.py [00:47:00] awjr: yeah, i didnt know about it until a while back, but i havent used that library since i wrote it [00:47:10] it's a nice feature [00:47:15] (03Merged) 10jenkins-bot: Avoiding implicit transactions when applying [core] - 10https://gerrit.wikimedia.org/r/96912 (owner: 10Aaron Schulz) [00:48:29] (03CR) 10Manybubbles: Perform Elasticsearch updates with queued jobs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 (owner: 10Manybubbles) [00:49:28] (03CR) 10Chad: Perform Elasticsearch updates with queued jobs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 (owner: 10Manybubbles) [00:50:24] (03CR) 10Manybubbles: Perform Elasticsearch updates with queued jobs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 (owner: 10Manybubbles) [00:51:05] (03PS1) 10Aaron Schulz: Removed some FORCE INDEX statements [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96928 [00:52:49] requests is nice. [00:53:01] Apparently virtual environments are also the bee's knees. [00:53:07] Or cat's pajamas, as they say. [00:53:11] (03PS3) 10Manybubbles: Perform Elasticsearch updates with queued jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 [00:53:13] But I haven't gotten into them yet. [00:53:59] virtualenv is awesome [00:57:19] (03PS1) 10Hiong3-eng5: Remove Duplicate Expressions [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/96929 [00:58:57] (03CR) 10MZMcBride: Stop eating posts (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96905 (owner: 10EBernhardson) [01:02:20] (03CR) 10Liangent: Handle CDB errors more gracefully in cdb.php maintenance script (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96907 (owner: 10Chad) [01:02:57] legoktm: I don't really get it. [01:03:03] legoktm: Can you explain it? [01:03:12] You define a requirements.txt file, right? [01:03:19] not necessarily [01:03:20] basically [01:03:39] right now you're installing all your libraries system-wide [01:03:41] By my count, you answered "not necessarily" to the "can you explain it?" question. [01:03:52] No, I usually install them locally. [01:03:56] i was going in reverse order :P [01:03:59] oh well [01:04:00] so [01:04:07] Because I'm usually on some host where I can't install system-wide. [01:04:09] For better or worse. [01:04:11] with virtualenv, you install them to that environment [01:04:21] The environment is basically a directory? [01:04:21] and you enable that environment or disable it [01:04:29] Activate and deactivate. [01:04:31] Right. [01:04:38] not a directory [01:04:40] (03CR) 10Aaron Schulz: [C: 04-1] Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [01:05:04] TimStarling: ;) [01:05:05] I think that's the part I don't understand. [01:05:07] so this way you can have multiple versions of the same package installed [01:05:30] (03CR) 10BryanDavis: "This look reasonable to me, but it wanders into bits that I'm not completely sure of. It looks to me like File::transform() without the RE" [core] - 10https://gerrit.wikimedia.org/r/96920 (owner: 10Gergő Tisza) [01:05:37] So it's just compiling and sandboxing modules, basically? [01:06:16] How portable is it? I still don't really see how this helps my life. [01:06:45] sure [01:06:54] its helpful for developing stuff when you want a clean environment [01:07:06] Hmmm. [01:07:19] All right. [01:07:19] not sure how portable it is. i have a simple list of commands that let me setup pywikibot in each tool-labs tool i create in <1 minute [01:07:37] What's needed? [01:07:44] Isn't it just setup.py? [01:07:52] Do you modify the path too? [01:07:56] PYTHONPATH, I mean. [01:08:07] (Is it on GitHub?) [01:08:27] Aaron|home: When you get a minute could you look at https://gerrit.wikimedia.org/r/#/c/96920/ and see if you agree that Gergő is headed in the right direction? (+16, -10 change) [01:08:43] https://wikitech.wikimedia.org/wiki/User:Legoktm/pywikibot_on_tools_lab [01:09:04] Bless you. [01:09:59] I suppose [01:12:10] marktraceur, \o/ BetaFeatures :-) [01:12:14] congrats. looks nice. [01:13:51] Thanks! [01:14:04] Eloquence: And it only took 5 hours of deployment [01:14:07] * marktraceur takes a nap [01:14:11] :) [01:18:16] (03CR) 10Legoktm: "Ifad0cad215cd0e91746dd08c3f8888c9fbe01c20 will undeploy the extension. 1.23wmf5 went out today, so this will need to go in 1.23wmf6, which" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [01:19:18] (03Draft2) 10Dereckson: Improving CLDR Plural Rule Evaluator documentation. [core] - 10https://gerrit.wikimedia.org/r/96930 [01:22:15] (03CR) 10Dzahn: [C: 032] Reset tops parameter to default value if too long [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96880 (owner: 10Aklapper) [01:22:23] (03CR) 10Dzahn: [V: 032] Reset tops parameter to default value if too long [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96880 (owner: 10Aklapper) [01:30:45] (03PS1) 10Brian Wolff: Don't use API to fetch alternate poster sizes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/96932 [01:37:30] (03PS2) 10Mwalker: Add wikis information to metabook [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96893 [01:38:29] (03PS1) 10Legoktm: Add 'aft' to $wgRestrictionTypes if enabled [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96933 [01:38:46] anomie|away: ^ [01:39:13] (03CR) 10Aaron Schulz: Handle CDB errors more gracefully in cdb.php maintenance script (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96907 (owner: 10Chad) [01:43:49] (03PS1) 10Mwalker: Apparently frozen in NodeLand doesn't mean anything [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96934 [01:44:14] (03CR) 10Mwalker: [C: 032] Apparently frozen in NodeLand doesn't mean anything [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96934 (owner: 10Mwalker) [01:46:19] (03CR) 10Parent5446: "Indeed, although I think it's only available in certain PHP versions, and of course you have to be using FastCGI." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96904 (owner: 10Parent5446) [02:07:39] (03PS2) 10Legoktm: Add protection settings info to $wgRestrictionTypes and $wgRestrictionLevels [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96933 [02:07:45] anomie|away: ^ [02:08:10] I think that should work. [02:45:00] (03PS1) 10Cscott: Work around for XeTeX 3.1415926-2.4-0.9998 (TeX Live 2012/Debian). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96937 [02:46:21] (03CR) 10Mwalker: [C: 032] Work around for XeTeX 3.1415926-2.4-0.9998 (TeX Live 2012/Debian). [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96937 (owner: 10Cscott) [02:58:08] (03CR) 10Werdna: "Concern should be addressed in PS3" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [03:02:44] (03CR) 10Cscott: [C: 032] Add wikis information to metabook (031 comment) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96893 (owner: 10Mwalker) [03:02:55] (03Merged) 10jenkins-bot: Add wikis information to metabook [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96893 (owner: 10Mwalker) [03:06:19] (03PS1) 10Cscott: Explicitly add latex-xcolor to the list of package dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96939 [03:10:00] (03CR) 10Werdna: [C: 04-1] "In general, using $wgTitle at all is discouraged in new MediaWiki development." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [03:19:53] hey is santhosh about? [03:20:08] He appears to be online. [03:20:23] And not idle. [03:20:58] * werdna prods santhosh  [03:21:44] I found out that my JS scrollIntoView function clashes with some similar code in UniversalLanguageSelector, so I'm sort of wondering where the jquery.uls module comes from. [03:21:50] Hoping to merge mine with the one in ULS [03:31:58] marktraceur: idle time: 5 days 12 hours [03:32:02] so I guess probably so [03:34:56] (03CR) 10Santhosh: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/96930 (owner: 10Dereckson) [03:38:15] (03CR) 10Werdna: "I've contacted language engineering about merging the two functions and bringing them into core. However, their function does not cover al" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [03:38:20] (03Merged) 10jenkins-bot: Improving CLDR Plural Rule Evaluator documentation. [core] - 10https://gerrit.wikimedia.org/r/96930 (owner: 10Dereckson) [03:39:39] (03PS2) 10Springle: Removed some FORCE INDEX statements [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96928 (owner: 10Aaron Schulz) [03:47:33] (03CR) 10Werdna: (bug 57162) red links don't work (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [03:47:53] Aaron|home: why might jenkins-bot ignore 96928? [03:48:10] springle: flagged revs doesn't have jenkins set up [03:48:21] ah ok [03:49:55] (03CR) 10Werdna: [C: 031] "*Looks* okay, wouldn't mind a second pair of eyes." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96690 (owner: 10EBernhardson) [03:52:30] (03CR) 10Springle: [C: 031 V: 031] "No jenkins-bot to verify on flagged revs?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96928 (owner: 10Aaron Schulz) [04:01:37] (03Restored) 10Legoktm: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [04:01:46] (03PS5) 10Legoktm: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [04:02:44] (03PS4) 10Werdna: Consolidate and clean up "scroll to this element" code. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 [04:05:48] (03PS6) 10Legoktm: Fire Echo event when revision is approved [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [04:06:13] (03CR) 10Legoktm: "PS5: My changes which don't actually work yet." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [04:07:25] (03CR) 10Siebrand: "I think Aaron's idea may get rid of a lot of issues. Next PS will implement that." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [04:08:50] (03PS4) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [04:12:54] (03PS1) 10Mwalker: Collection download does not work like I thought [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96942 [04:13:07] (03CR) 10Mwalker: [C: 032] Collection download does not work like I thought [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96942 (owner: 10Mwalker) [04:13:14] (03CR) 10jenkins-bot: [V: 04-1] Collection download does not work like I thought [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96942 (owner: 10Mwalker) [04:13:59] (03PS2) 10Mwalker: Collection download does not work like I thought [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96942 [04:14:38] (03PS1) 10Werdna: When destroying the plain editor, be sure to empty the textbox and reset its height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96943 [04:14:41] (03CR) 10Mwalker: [C: 032] Collection download does not work like I thought [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96942 (owner: 10Mwalker) [04:22:45] (03PS1) 10Mwalker: Not throw exception on config get [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96944 [04:22:59] (03CR) 10Mwalker: [C: 032] Not throw exception on config get [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96944 (owner: 10Mwalker) [04:25:59] (03PS1) 10PleaseStand: Mechanism for renaming/aliasing classes [core] - 10https://gerrit.wikimedia.org/r/96945 [04:26:03] (03PS5) 10Siebrand: Remove underscore from class names LBFactory_* [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 [04:30:44] (03CR) 10Siebrand: "Hmm. Looks like this indeed has backward compatibility now. I've updated the patch for SimpleSecurity to use a class_alias, because I didn" [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [04:39:07] (03PS5) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [04:44:00] (03PS1) 10Mwalker: Adding more details collection should know but doesnt [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96946 [04:44:13] (03CR) 10Mwalker: [C: 032] Adding more details collection should know but doesnt [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96946 (owner: 10Mwalker) [04:44:31] (03Merged) 10jenkins-bot: Adding more details collection should know but doesnt [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96946 (owner: 10Mwalker) [04:45:43] (03CR) 10Siebrand: "@Yaron: Indeed, that's what I meant. As for the omissions on other messages: I didn't want to unnecessarily increase the scope of the patc" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/96289 (owner: 10Yaron Koren) [04:48:24] (03CR) 10Siebrand: [C: 032 V: 032] EditFilterMerged is always called [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/95838 (owner: 10Chad) [04:51:08] (03PS3) 10Siebrand: Remove deprecated EditPage::spamPage() [core] - 10https://gerrit.wikimedia.org/r/95839 (owner: 10Chad) [04:52:15] (03CR) 10Siebrand: [C: 032] "Added release notes in PS2." [core] - 10https://gerrit.wikimedia.org/r/95839 (owner: 10Chad) [04:56:18] (03Merged) 10jenkins-bot: Remove deprecated EditPage::spamPage() [core] - 10https://gerrit.wikimedia.org/r/95839 (owner: 10Chad) [04:56:57] (03PS1) 10Mwalker: Status bugfixes and other things [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96948 [04:57:08] (03CR) 10Mwalker: [C: 032] Status bugfixes and other things [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96948 (owner: 10Mwalker) [04:57:59] (03Merged) 10jenkins-bot: Status bugfixes and other things [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96948 (owner: 10Mwalker) [04:58:57] (03PS1) 10Werdna: Add jquery.scroll.js plugin, factored out from Flow. [core] - 10https://gerrit.wikimedia.org/r/96949 [04:59:38] (03PS2) 10Werdna: Add jquery.scroll.js plugin, factored out from Flow. [core] - 10https://gerrit.wikimedia.org/r/96949 [05:02:07] (03PS1) 10Werdna: Make Flow use core version of scrollIntoView. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96950 [05:03:35] (03CR) 10jenkins-bot: [V: 04-1] Add jquery.scroll.js plugin, factored out from Flow. [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [05:09:01] How do I make my local JSHint report the same errors as Jenkins? [05:12:11] (03PS1) 10Legoktm: Return an empty array if there are no page properties [core] - 10https://gerrit.wikimedia.org/r/96951 [05:16:53] werdna: most repositories have a hidden .jshintrc file in their repository root [05:17:06] yeah, looks like I didn't have the "real" JSHint installed [05:19:05] (03CR) 10Siebrand: [C: 04-1] Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [05:22:49] (03CR) 10Siebrand: Add site-wide privacy link (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/96894 (owner: 10CSteipp) [05:32:08] (03CR) 10Qgil: "Hi Sniok, could you please improve your commit message following https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 (owner: 10Sniok) [05:36:09] (03CR) 10Siebrand: [C: 04-1] "Is there a screenshot available of this somewhere? Also can you please indicate which problem you are trying to resolve by making this cha" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [05:37:03] (03PS1) 10Cscott: Render math extension; improve rendering of
and
. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96953 [05:37:04] (03PS1) 10Cscott: CLI option for single-column rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96954 [05:37:17] (03CR) 10jenkins-bot: [V: 04-1] Render math extension; improve rendering of
and
. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96953 (owner: 10Cscott) [05:37:29] (03CR) 10jenkins-bot: [V: 04-1] CLI option for single-column rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96954 (owner: 10Cscott) [05:39:16] (03CR) 10Cscott: [C: 032] Explicitly add latex-xcolor to the list of package dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96939 (owner: 10Cscott) [05:39:29] (03Merged) 10jenkins-bot: Explicitly add latex-xcolor to the list of package dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96939 (owner: 10Cscott) [05:41:26] (03PS1) 10Hiong3-eng5: API batch transaction, conserve transaction [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/96955 [05:46:37] (03CR) 10Siebrand: "Thank you, Dan." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 (owner: 10Dan-nl) [05:48:30] (03PS3) 10Werdna: Add jquery.scroll.js plugin, factored out from Flow. [core] - 10https://gerrit.wikimedia.org/r/96949 [05:49:41] (03CR) 10Werdna: "PS3: Shut up JSHint ;-)" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [05:53:23] (03CR) 10MZMcBride: "It might be reasonable to do a follow-up commit that splits this into multiple messages, documents where the messages are used, and tweaks" (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/96894 (owner: 10CSteipp) [05:56:03] (03PS2) 10Cscott: Don't try to test XeLaTeX compilation if XeLaTeX is not installed. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96913 [05:57:52] (03CR) 10Cscott: [C: 032] Don't try to test XeLaTeX compilation if XeLaTeX is not installed. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96913 (owner: 10Cscott) [05:58:03] (03CR) 10Siebrand: "I recall lengthy discussion about action vs. special page, I think on wikitech-l." [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [05:58:08] (03Merged) 10jenkins-bot: Don't try to test XeLaTeX compilation if XeLaTeX is not installed. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96913 (owner: 10Cscott) [06:00:53] (03PS2) 10Cscott: Render math extension; improve rendering of
and
. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96953 [06:00:54] (03PS2) 10Cscott: CLI option for single-column rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96954 [06:01:16] (03CR) 10Siebrand: [C: 04-1] "This needs special page aliases in MessagesEn.php." [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [06:04:42] (03CR) 10Cscott: [C: 032] Render math extension; improve rendering of
and
. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96953 (owner: 10Cscott) [06:04:56] (03Merged) 10jenkins-bot: Render math extension; improve rendering of
and
. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96953 (owner: 10Cscott) [06:05:03] (03CR) 10Cscott: [C: 032] CLI option for single-column rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96954 (owner: 10Cscott) [06:06:19] (03Merged) 10jenkins-bot: CLI option for single-column rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96954 (owner: 10Cscott) [06:07:16] (03CR) 10Parent5446: Mechanism for renaming/aliasing classes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96945 (owner: 10PleaseStand) [06:16:41] (03CR) 10Siebrand: Add site-wide privacy link (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/96894 (owner: 10CSteipp) [06:22:57] (03PS8) 10Mattflaschen: mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 [06:23:38] (03CR) 10Siebrand: "Special:History is already taken by the extension MobileFrontend." [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [06:26:12] (03CR) 10Mattflaschen: "This is updated for the new structure and ready for review." [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [06:26:19] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [06:38:29] (03CR) 10Nikerabbit: mediawiki.api: Fix token with postWithToken, add test (032 comments) [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [06:41:52] (03PS9) 10Nikerabbit: mediawiki.api: Fix token with postWithToken, add test [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [06:48:36] (03CR) 10PleaseStand: Mechanism for renaming/aliasing classes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96945 (owner: 10PleaseStand) [06:52:09] (03PS1) 10Mattflaschen: Use GettingStarted namespace for all classes [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/96958 [06:57:49] (03CR) 10Mattflaschen: [C: 032] Update README and clarify licensing [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/87312 (owner: 10Mattflaschen) [06:57:59] (03CR) 10Mattflaschen: [V: 032] Update README and clarify licensing [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/87312 (owner: 10Mattflaschen) [07:13:44] (03PS24) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [07:18:54] (03CR) 10Wikinaut: [C: 031 V: 031] "self-reviewed. Looks okay to me being merged, but I wish that someone else also looks to the code, please." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [07:20:27] (03CR) 10Legoktm: [C: 04-1] "I don't think special page vs. action matters much here. This is just a redirect, so users can link to [[Special:Edit/Foo]] using an inter" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [07:21:47] (03CR) 10Wikinaut: "This code is now live on http://openid-wiki.instance-proxy.wmflabs.org/wiki ." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [07:38:23] (03CR) 10Aaron Schulz: Improved CdbException handling in LocalisationCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96909 (owner: 10Chad) [07:40:59] (03PS3) 10Aaron Schulz: Removed some FORCE INDEX statements [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96928 [07:41:39] (03CR) 10Aaron Schulz: [C: 032 V: 032] Removed some FORCE INDEX statements [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96928 (owner: 10Aaron Schulz) [07:52:53] (03CR) 10PleaseStand: "Actually, let's take the simple approach of just not supporting the use of class_alias() in the actual PHP files, as the whole point of th" [core] - 10https://gerrit.wikimedia.org/r/96945 (owner: 10PleaseStand) [07:57:19] (03CR) 10Legoktm: "MF patch at I11b6eb72793d2d885e0ce8f70bf780386b30daed" [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [08:00:01] (03CR) 10Nikerabbit: "Are there any practical ways to measure the impact of this change?" [core] - 10https://gerrit.wikimedia.org/r/96904 (owner: 10Parent5446) [08:00:27] (03CR) 10Nikerabbit: Update WikimediaMessages for wfm5 (031 comment) [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96923 (owner: 10CSteipp) [08:03:04] siebrand: where do aliases go for core special pages? [08:05:59] found it [08:09:05] (03PS4) 10Legoktm: Add Special:Edit and Special:History which redirect to their action equivalents [core] - 10https://gerrit.wikimedia.org/r/96170 [08:19:51] (03PS1) 10Aude: Remove User::getPageRenderingHash, deprecated since 1.17 [core] - 10https://gerrit.wikimedia.org/r/96965 [08:31:39] (03PS1) 10Legoktm: Follow redirects in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/96966 [08:34:30] (03CR) 10IAlex: Remove User::getPageRenderingHash, deprecated since 1.17 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96965 (owner: 10Aude) [08:44:17] (03PS2) 10Legoktm: Follow redirects in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/96966 [08:45:11] (03PS2) 10Aude: Remove User::getPageRenderingHash, deprecated since 1.17 [core] - 10https://gerrit.wikimedia.org/r/96965 [08:45:53] (03CR) 10Aude: Remove User::getPageRenderingHash, deprecated since 1.17 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96965 (owner: 10Aude) [09:09:35] oauth is live? [09:22:31] (03PS1) 10Mwalker: Can now report status of bundler [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96968 [09:22:46] (03CR) 10jenkins-bot: [V: 04-1] Can now report status of bundler [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96968 (owner: 10Mwalker) [09:23:40] (03PS2) 10Mwalker: Can now report status of bundler [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96968 [09:30:23] (03PS1) 10Mwalker: Report status of bundler [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96969 [09:31:26] (03CR) 10Mwalker: [C: 032] Can now report status of bundler [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96968 (owner: 10Mwalker) [09:31:40] (03CR) 10Mwalker: [C: 032] Report status of bundler [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96969 (owner: 10Mwalker) [09:37:35] (03PS1) 10IAlex: Fix login with temporary password with $wgSecureLogin = true [core] - 10https://gerrit.wikimedia.org/r/96970 [09:54:47] (03CR) 10Parent5446: "Yeah I agree with that. Better to just make it uniform." [core] - 10https://gerrit.wikimedia.org/r/96945 (owner: 10PleaseStand) [09:59:57] (03PS1) 10Mwalker: Accept status from renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96971 [10:00:15] (03CR) 10jenkins-bot: [V: 04-1] Accept status from renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96971 (owner: 10Mwalker) [10:00:32] (03PS1) 10Mwalker: Report status [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96972 [10:01:41] (03PS2) 10Mwalker: Accept status from renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96971 [10:02:01] (03CR) 10Mwalker: [C: 032] Report status [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96972 (owner: 10Mwalker) [10:02:11] (03CR) 10Mwalker: [C: 032] Accept status from renderer [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96971 (owner: 10Mwalker) [10:02:39] (03PS1) 10Inchikutty: Replacing 'show on map' button with a link having same functionality [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/96973 [10:04:19] (03PS1) 10Mwalker: Reference correct i18n parameter [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96974 [10:04:48] (03CR) 10Mwalker: [C: 032] Reference correct i18n parameter [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96974 (owner: 10Mwalker) [10:47:44] (03CR) 10Helder.wiki: "Consider documenting this at" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/75506 (owner: 10Catrope) [10:56:19] (03CR) 10Bartosz Dziewoński: "`git commit --amend --reset-author` :)" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/79775 (owner: 10Bartosz Dziewoński) [10:59:44] (03CR) 10Ori.livneh: "Did you mean to delete GettingStarted.hooks.php?" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/96958 (owner: 10Mattflaschen) [11:14:26] (03CR) 10TTO: Move ExpandTemplates special into core (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [11:35:53] Hello [11:38:52] (03CR) 10TTO: "This change may have made it impossible to access Special:Userlogin on Chechen wikis, where the localised name of this special page contai" [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [11:50:38] (03PS1) 10Rillke: Adding "it" as a fallback language to for Corsican [core] - 10https://gerrit.wikimedia.org/r/96981 [11:53:27] hi RAZVOR [11:53:59] (03CR) 10Rillke: "I really need the help of a native speaker here to verify that it is true and a developer checking whether the technical side was done cor" [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [12:02:08] Need help with puppet - got errors [12:06:16] (03CR) 10Rillke: [C: 031] mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [12:08:46] (03PS4) 10Robmoen: WIP: Target mobile on ve dependencies [core] - 10https://gerrit.wikimedia.org/r/93915 [12:08:56] (03CR) 10Aude: "the patch is not yet deployed and don't see how it's related (but can look at the issue)" [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [12:16:58] (03CR) 10Scimonster: "Here's a screenshot: http://i.imgur.com/1nfM6qc.png" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [12:19:11] (03PS6) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 [12:21:02] (03CR) 10Rillke: "User:Zolo from Wikimedia Commons suggested French as a fallback:" [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [12:29:11] (03CR) 10Parent5446: [C: 04-1] "Make sure to backport this change to the 1.22 branch or whatever Mark uses to manage the RCs." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96970 (owner: 10IAlex) [12:30:34] (03CR) 10Parent5446: [C: 031] Remove User::getPageRenderingHash, deprecated since 1.17 [core] - 10https://gerrit.wikimedia.org/r/96965 (owner: 10Aude) [12:39:01] (03PS4) 10Sniok: Adding HiDPI 'Heart' SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 [12:51:18] (03CR) 10Krinkle: [C: 04-1] "Only iframe.js is affected, so no need to revert the whole thing. Iframe got excluded from jshint validation, is not used by default or on" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96482 (owner: 10devunt) [12:55:26] (03PS1) 10Krinkle: jquery.wikiEditor.iframe: Restore function signatures [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96983 [12:58:19] (03CR) 10Krinkle: "See Ia6db450296ac." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96482 (owner: 10devunt) [13:02:34] (03CR) 10Krinkle: [C: 04-1] "We considered using this plugin in VisualEditor (and did for a while), but ended up rewriting it 3 times because each time (including the " [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [13:04:43] (03CR) 10Krinkle: Add jquery.scroll.js plugin, factored out from Flow. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [13:22:03] (03CR) 10Anomie: "This change caused section edit links to start showing up on old revisions, which causes all sorts of bad UI." [core] - 10https://gerrit.wikimedia.org/r/94150 (owner: 10Bartosz Dziewoński) [13:23:11] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/96985 [13:23:38] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/96985 (owner: 10Pigpen) [13:26:39] (03CR) 10Gergő Tisza: "- I'm not sure what's the procedure for changing a message name, but since the text does not change that all, you probably shouldn't throw" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/96973 (owner: 10Inchikutty) [13:34:51] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/96986 [13:37:12] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/96986 (owner: 10Pigpen) [13:44:38] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96987 [13:44:39] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96988 [13:45:35] (03Abandoned) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96987 (owner: 10Pigpen) [13:46:41] (03Abandoned) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96988 (owner: 10Pigpen) [13:49:50] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/96989 [13:51:35] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96990 [13:51:58] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/96989 (owner: 10Pigpen) [13:55:48] (03Restored) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96988 (owner: 10Pigpen) [13:56:08] (03Restored) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96987 (owner: 10Pigpen) [13:56:30] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96987 (owner: 10Pigpen) [13:56:46] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96988 (owner: 10Pigpen) [13:56:59] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96990 (owner: 10Pigpen) [13:57:50] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96991 [13:58:11] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/96991 (owner: 10Pigpen) [14:16:48] (03CR) 10Bartosz Dziewoński: "/me is awaiting browsers implementing .scrollIntoView( true, {behavior: 'smooth'} )" [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [14:18:26] (03CR) 10Werdna: Add jquery.scroll.js plugin, factored out from Flow. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96949 (owner: 10Werdna) [14:20:53] (03CR) 10Anomie: Suppress section edit links with action=render (031 comment) [core] - 10https://gerrit.wikimedia.org/r/94150 (owner: 10Bartosz Dziewoński) [14:34:10] (03CR) 10Aklapper: [C: 04-1] "Only small nitpick is that the line should use spaces instead of a tab for intendeation, but I can fix this. Thanks!" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 (owner: 10Tholam) [14:34:49] (03CR) 10Umherirrender: Remove deprecated EditPage::spamPage() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95839 (owner: 10Chad) [14:37:07] (03PS1) 10MarkAHershberger: Fix login with temporary password with $wgSecureLogin = true [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/96994 [14:39:09] (03CR) 10MarkAHershberger: "Thank you very much for pointing this out to me." [core] - 10https://gerrit.wikimedia.org/r/96970 (owner: 10IAlex) [14:45:52] (03PS1) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data() attempt 2 [core] - 10https://gerrit.wikimedia.org/r/96996 [14:45:53] (03PS1) 10Yamelnychuk: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core [core] - 10https://gerrit.wikimedia.org/r/96997 [14:47:13] (03PS2) 10IAlex: Fix login with temporary password with $wgSecureLogin = true [core] - 10https://gerrit.wikimedia.org/r/96970 [14:47:31] (03CR) 10jenkins-bot: [V: 04-1] Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data() attempt 2 [core] - 10https://gerrit.wikimedia.org/r/96996 (owner: 10Yamelnychuk) [14:50:30] (03CR) 10Bartosz Dziewoński: "I'm currently a little bit swamped in GCI stuff. I'd say we just replace the code in #addParserOutput to not reenable the section edit lin" [core] - 10https://gerrit.wikimedia.org/r/94150 (owner: 10Bartosz Dziewoński) [14:58:45] (03PS1) 10Anomie: Revert "Suppress section edit links with action=render" [core] - 10https://gerrit.wikimedia.org/r/96999 [14:58:56] (03CR) 10Anomie: "Reverted in https://gerrit.wikimedia.org/r/96999" [core] - 10https://gerrit.wikimedia.org/r/94150 (owner: 10Bartosz Dziewoński) [15:01:40] (03CR) 10IAlex: [C: 031] Remove User::getPageRenderingHash, deprecated since 1.17 [core] - 10https://gerrit.wikimedia.org/r/96965 (owner: 10Aude) [15:03:12] (03PS5) 10Matthias Mullie: (bug 57162) red links don't work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 [15:03:16] (03CR) 10Matthias Mullie: (bug 57162) red links don't work (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [15:03:28] hello i work for http://www.google-melange.com/gci/task/view/google/gci2013/5850981870862336 [15:08:57] (03PS1) 10Manybubbles: WIP:Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 [15:14:35] Nikerabbit: around? [15:14:57] (03CR) 10Bartosz Dziewoński: [C: 032] "Okay, let's do this. Thanks :)" [core] - 10https://gerrit.wikimedia.org/r/96652 (owner: 10MegaAlex) [15:15:33] Nikerabbit: i'm trying to use my newfound staff capabilities on twn and i'd like somebody to tell me if i'm doing something extremely stupid [15:15:57] (what i am trying to do is to rename a few hundred pages) [15:16:26] MatmaRex: how can I help? [15:16:49] (03CR) 10Anomie: [C: 04-1] "Considering that this would allow people to edit-protect pages at nonsense levels such as "aft-noone", this is probably not a good idea." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96933 (owner: 10Legoktm) [15:17:41] Nikerabbit: the code messages 'newmessageslink' and 'newmessagesdifflink' appear to be unused, superseded by 'newmessageslinkplural' and 'newmessagesdifflinkplural' – but in many languages only the first pair has translations [15:18:01] (03Merged) 10jenkins-bot: Change the syntax and non-one count fake values for {{PLURAL: in newmessages* [core] - 10https://gerrit.wikimedia.org/r/96652 (owner: 10MegaAlex) [15:18:02] Nikerabbit: what i am trying to do is to move the translations, since the only difference should be lack of PLURAL: handling in the first set [15:18:32] oh [15:18:38] but you would need to fuzzy them as well [15:18:40] looks like i could replace "(Newmessageslink|Newmessagesdifflink)" with "$1plural" in page titles in MW: and MW talk: namespace, right? [15:18:43] yeah, and that too [15:19:04] buy there is no webui for that [15:19:17] you mean fuzzying? [15:19:31] anyway, let me submit the core patch that kills them and we'll see. :) [15:19:50] yeah for fuzzying [15:26:17] (03PS1) 10Aklapper: Sync to upstream; fix wrong query parameters not used in WM Bugzilla [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/97005 [15:27:39] Reedy: would you take a look at https://gerrit.wikimedia.org/r/#/c/96161/ ? We'd like to merge it so Flow is correct on beta labs, it should not affect production at all (until Flow gets released) [15:28:49] (03PS1) 10Bartosz Dziewoński: Kill 'newmessageslink' and 'newmessagesdifflink' messages [core] - 10https://gerrit.wikimedia.org/r/97006 [15:29:08] Nikerabbit: ^ [15:29:53] (03CR) 10Bartosz Dziewoński: "We should probably grep any extensions for these or something. Some translations for older messages could be migrated to the newer ones, I" [core] - 10https://gerrit.wikimedia.org/r/97006 (owner: 10Bartosz Dziewoński) [15:34:24] (03CR) 10Bartosz Dziewoński: [C: 04-2] "You should amend existing changes instead of submitting new ones when you want to change something; this is mentioned in the tutorial link" [core] - 10https://gerrit.wikimedia.org/r/96996 (owner: 10Yamelnychuk) [15:58:44] (03CR) 10MarkAHershberger: "I wasn't familiar with DerivativeRequest before this and when I compare it with FauxRequest, Looking at the code, I'm not seeing the proto" [core] - 10https://gerrit.wikimedia.org/r/96970 (owner: 10IAlex) [15:59:45] Could someone help me understand https://gerrit.wikimedia.org/r/#/c/96970 and how that fixes the bug? I want to get the code merged so I can do a release, but I don't see how it applies. [15:59:58] Reedy: ping? [16:01:53] (03CR) 10Bartosz Dziewoński: [C: 032] "If you think this is so critical… I assume you will get the revert deployed to WMF wikis. Thanks for pinpointing the bug." [core] - 10https://gerrit.wikimedia.org/r/96999 (owner: 10Anomie) [16:05:19] (03Merged) 10jenkins-bot: Revert "Suppress section edit links with action=render" [core] - 10https://gerrit.wikimedia.org/r/96999 (owner: 10Anomie) [16:05:24] hexmode: well, the constructor for FauxRequest is __construct( $data = array(), $wasPosted = false, $session = null, $protocol = 'http' ) ? [16:05:45] MatmaRex: How did I miss that? [16:05:50] and DerivativeRequest has public function getProtocol() { return $this->base->getProtocol(); } [16:05:54] hexmode: :D [16:05:58] MatmaRex: maybe looking at old code :P [16:06:07] * hexmode checks what he has [16:06:50] also, in general i don't think FauxRequest should ever be used apart form in unit tests in practice [16:06:59] DerivativeRequest is usually what one would want [16:07:56] MatmaRex: I was looking at 1.21 code [16:08:22] "http" was added since then, it looks like [16:08:25] ok [16:09:08] (03CR) 10MarkAHershberger: [C: 032] "I was looking at older code where the protocol wasn't set." [core] - 10https://gerrit.wikimedia.org/r/96970 (owner: 10IAlex) [16:11:09] (03PS1) 10Cscott: Use -D consistently across mw-bundler and mw-latexer to turn on stack traces. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97009 [16:11:10] (03PS1) 10Cscott: Truncate image filenames if necessary to fit OS limits. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97010 [16:11:11] (03PS1) 10Cscott: Decode URI encoding in image resource titles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97011 [16:11:12] (03PS1) 10Cscott: Write siteinfo.db to record siteinfo in a multiple wiki collection. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97012 [16:11:13] (03PS1) 10Cscott: Fix key in revisions.db to be unique in a multiple wiki collection. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97013 [16:11:14] (03PS1) 10Cscott: Refactor revision fetch code to occur in (limited) parallel. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97014 [16:11:15] Morning MatmaRex and hexmode, how's it going? Can I ask a question that's probably easier that hexmode's: how do i get a stack trace off production wiki logs? I know what page triggered it, so maybe it's easy to find... (?) [16:11:15] (03PS1) 10Cscott: Add featured article list and a script to build collections from it. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97015 [16:12:00] AndyRussG: can you trigger the problem on request? [16:12:31] No, it's a bug submitted by a user, only happens to that user [16:12:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=57417 [16:12:52] AndyRussG: if you have the hex code of the exception (which should have been displayed to the user), you can look it up / have it looked up somewhere [16:13:31] They didn't post it, I can ask, though [16:13:33] ah, a fatal error. i'm afraid these don't have any stack traces [16:13:40] i was thinking about exceptions [16:14:01] but the bug is obvious here, actually [16:14:20] EducationProgram checks for "_DiffOp" class somewhere, and that has been renamed to "DiffOp" recently i think [16:14:27] so let's just change that and it will work [16:14:36] Ahhhhhhhhh [16:14:44] 8D [16:15:25] (03CR) 10MarkAHershberger: [C: 032] Fix login with temporary password with $wgSecureLogin = true [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/96994 (owner: 10MarkAHershberger) [16:16:04] * AndyRussG in awe at the power of knowledge [16:16:32] I was wondering what that _ was doing in the code there [16:16:44] AndyRussG: i lurk too much :) [16:17:15] That's also the issue in the bug marked as a duplicate, so that's it [16:17:36] Maybe I should lurk more too [16:18:10] MatmaRex: Thanks once again for the help!!!!! ;) [16:19:24] Damn it, you’ve fucked up the buttons. :( [16:19:31] who? [16:19:35] what? [16:19:38] https://www.dropbox.com/s/t8xqtr13bh6dnei/Screenshot%202013-11-22%2017.19.36.png [16:19:49] personally i made some button way prettier recently. [16:19:53] buttons*. [16:20:08] * YuviPanda gives MatmaRex a make up kit [16:20:10] MAKE THEM ALL PRETTY [16:20:12] sjoerddebruin: i have no idea what i'm looking at. [16:20:45] The save button of the preferences MatmaRex [16:21:23] sjoerddebruin: i don't remember it ever looking different than it looks right now [16:22:45] MatmaRex: It was this before: https://www.dropbox.com/s/sor6m4bjzkp9q4x/Screenshot%202013-11-22%2017.22.37.png [16:25:21] (03PS2) 10Cscott: Add featured article list and a script to build collections from it. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97015 [16:25:22] (03PS1) 10Cscott: Add 'forEachPar' and 'forEachSeq' helpers to promise helper module. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97017 [16:26:08] (03PS1) 10Rillke: Honor shortened thumbnail paths in mw.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/97018 [16:29:11] sjoerddebruin: it never looked like that for me. [16:30:59] (03PS1) 10M4tx: Fixed indentation style and PNG fallbacking method. [core] - 10https://gerrit.wikimedia.org/r/97022 [16:31:13] Weird. [16:33:40] (03PS2) 10M4tx: Fixed low-resolution enhanced recent changes collapse/show arrows (GCI 2013 task 5346992154738688, bug 35344) [core] - 10https://gerrit.wikimedia.org/r/96372 [16:35:11] (03CR) 10Hashar: "Yeah it is probably overkill. Just wanted to let you know at least one other python project exist to interact with MediaWiki. There are s" [tools/release] - 10https://gerrit.wikimedia.org/r/95738 (owner: 10Awjrichards) [16:38:14] (03CR) 10Anomie: [C: 04-2] "This doesn't actually do what you claim. If any page in the result set does have a page prop, it will do exactly nothing because $props wo" [core] - 10https://gerrit.wikimedia.org/r/96951 (owner: 10Legoktm) [16:40:37] (03PS1) 10AndyRussG: Update _DiffOp to DiffOp following rename in core [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/97026 [16:43:26] (03CR) 10AndyRussG: "Thanks to MatmaRex and Reedy for their help on this!" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/97026 (owner: 10AndyRussG) [16:45:08] AndyRussG: can i trust you that this works ^ and merge? :) [16:46:19] Maybe give me 15 minutes to test it out some more? If you like, I'll let you know [16:46:40] ok [16:48:04] (03CR) 10EBernhardson: "i looked through ps3, but due to the included rebase i can't quite see any particular changes." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 (owner: 10Werdna) [16:48:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "-1 per comments on patchset 7. Most of all, this does not actually work with any of the new test cases (https://en.wiktionary.org/wiki/Use" [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [16:51:44] (03PS2) 10Darkdadaah: Proper getopt + head/tail options [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/96222 [16:52:03] (03CR) 10Darkdadaah: [C: 032 V: 032] Proper getopt + head/tail options in decoupe.pl [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/96222 (owner: 10Darkdadaah) [16:53:56] (03Abandoned) 10Yamelnychuk: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core [core] - 10https://gerrit.wikimedia.org/r/96997 (owner: 10Yamelnychuk) [16:54:07] (03Abandoned) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data() attempt 2 [core] - 10https://gerrit.wikimedia.org/r/96996 (owner: 10Yamelnychuk) [16:54:38] MatmaRex: everything checks out, good to go! Thanks a ton [16:54:44] (03CR) 10Krinkle: "fixme: https://bugzilla.wikimedia.org/show_bug.cgi?id=40062#c25" [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [16:55:13] (03CR) 10Bartosz Dziewoński: Adding hlist module to mediawiki (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [16:58:44] I just wanted to step through the modified code with a debugger to be sure [16:59:25] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97033 [16:59:42] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97034 [17:01:16] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/97032 (owner: 10L10n-bot) [17:02:17] (03CR) 10Reedy: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97033 (owner: 10Siebrand) [17:02:31] (03CR) 10Reedy: [C: 032 V: 032] Localisation updates from https://translatewiki.net. [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97034 (owner: 10Siebrand) [17:05:09] (03CR) 10Anomie: [C: 04-1] "Just change the behavior of showHiddenUsersAddBlockInfo() to take out the "!$userCanViewHiddenUsers" check. There's no need to add an extr" [core] - 10https://gerrit.wikimedia.org/r/96794 (owner: 10Umherirrender) [17:06:12] (03CR) 10Chad: [C: 032] Perform Elasticsearch updates with queued jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 (owner: 10Manybubbles) [17:06:42] (03CR) 10Reedy: [C: 032] Update _DiffOp to DiffOp following rename in core [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/97026 (owner: 10AndyRussG) [17:07:00] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/97032 (owner: 10L10n-bot) [17:07:38] (03PS1) 10Zfilipin: WIP moving login code to the gem [selenium] - 10https://gerrit.wikimedia.org/r/97036 [17:11:15] (03Merged) 10jenkins-bot: Perform Elasticsearch updates with queued jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 (owner: 10Manybubbles) [17:12:08] (03PS1) 10Reedy: Update EducationProgram to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97038 [17:14:19] (03PS1) 10Reedy: Update EducationProgram to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97039 [17:17:16] (03PS1) 10EBernhardson: Avoid fatal error when mentioning invalid user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97042 [17:17:18] (03CR) 10Reedy: [C: 032 V: 032] Update EducationProgram to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97039 (owner: 10Reedy) [17:17:31] (03CR) 10Reedy: [C: 032 V: 032] Update EducationProgram to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97038 (owner: 10Reedy) [17:20:00] Thanks again, Reedy and MatmaRex [17:20:20] Please let me know if there is anything more I should do on this re: testing, or anything else [17:20:36] (03PS1) 10Manybubbles: Limit job queue rate and wait for completion [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 [17:21:04] AndyRussG: Reedy will probably notice any leftover fatals in the logs :) [17:21:20] Right! [17:22:32] MatmaRex, Reedy: Do Reedy's changes mean this is now going to production? [17:24:08] AndyRussG: they mean it's slated for going to production, you can join #wikimedia-operations to see any deployments happen [17:24:31] ah, it seems he just deployed it :) [17:24:31] Ah fantastic [17:24:32] [18:21] !log reedy synchronized php-1.23wmf5/extensions/EducationProgram/includes/Events/EditEventCreator.php [17:25:04] (03CR) 10Krinkle: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data() attempt 2 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96996 (owner: 10Yamelnychuk) [17:25:30] (03CR) 10Krinkle: "Ah, thanks Bartosz." [core] - 10https://gerrit.wikimedia.org/r/96996 (owner: 10Yamelnychuk) [17:26:30] fantastic :) [17:26:37] (03PS2) 10EBernhardson: Avoid fatal error when mentioning invalid user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97042 [17:26:38] Thx again [17:27:27] (03Abandoned) 10Matthias Mullie: [WIP] Move HTML<->wikitext conversion out of PostRevision [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96256 (owner: 10Matthias Mullie) [17:29:10] @qgil Are you there ? [17:29:46] (03PS1) 10Gergő Tisza: Add vagrant role for TimedMediaHandler [vagrant] - 10https://gerrit.wikimedia.org/r/97049 [17:30:14] (03PS1) 10Manybubbles: Make sure all microtime calls return floats [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97050 [17:30:47] (03PS1) 10Dan-nl: filter [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 [17:31:26] (03PS2) 10Manybubbles: Limit job queue rate and wait for completion [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 [17:32:17] (03PS1) 10Reedy: Revert "Suppress section edit links with action=render" [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97054 [17:32:33] (03PS4) 10Matthias Mullie: Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 [17:32:35] (03PS3) 10Matthias Mullie: Insert new revision when Flow is taking over [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 [17:33:06] @guillom Hi! [17:35:05] (03CR) 10Reedy: [C: 032 V: 032] Revert "Suppress section edit links with action=render" [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/97054 (owner: 10Reedy) [17:37:05] AaronSchulz: Question for you: The URL https://upload.wikimedia.org/wikipedia/de/thumb/8/8b/Altarschrein_ehemals_in_der_St._Bartholom%C3%A4us-Kirche_in_Anhausen%2C_einem_Ortsteil_des_Stadtteils_Sulzdorf_der_Stadt_Schw%C3%A4bisch_Hall%2C_heute_im_Besitz_der_Staatssammlungen_Stuttgart.jpg/220px-thumbnail.jpg was generated for an image thumbnail, do you know under what circumstances I can expect the 220px-thumbnail filename? [17:37:22] Comes from this page: https://de.wikipedia.org/wiki/St._Bartholomäus-Kirche_(Anhausen) [17:37:43] I can probably ignore it and work around, but it's a bit annoying :/ [17:37:55] NVM, bd808 is fast [17:38:26] (03PS5) 10Matthias Mullie: Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 [17:38:29] (03PS1) 10Bartosz Dziewoński: Revert "Suppress section edit links with action=render" [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97056 [17:38:43] marktraceur: when the filename is too long [17:38:53] marktraceur: rillke just submitted a patch for that for mw.Title? [17:39:22] Did he? [17:39:33] MatmaRex: Got a link handy? :) [17:39:42] marktraceur: you're a reviewed on it. :P [17:39:45] reviewer* [17:39:47] https://gerrit.wikimedia.org/r/#/c/97018/ [17:40:16] Eloquence: So it turns out really really really long filenames get URLs that end in /220px-thumbnail.jpg, which we misinterpret as being the title of the file page. rillke caught it and fixed it :) [17:40:50] heh :) [17:42:18] by default "very long" is strlen() > 255 -- see https://git.wikimedia.org/blob/mediawiki%2Fcore.git/1e0bd351b760c2b1d9f5c0e058dc1c3bf9a83d2e/includes%2Ffilerepo%2FFileRepo.php#L117 [17:43:16] (03PS1) 10RAZVOR: https://bugzilla.wikimedia.org/show_bug.cgi?id=55893 bug commited [core] - 10https://gerrit.wikimedia.org/r/97057 [17:43:17] (03CR) 10MarkTraceur: [C: 032] "Thanks, Rillke!" [core] - 10https://gerrit.wikimedia.org/r/97018 (owner: 10Rillke) [17:43:42] anyone who has time to merge https://gerrit.wikimedia.org/r/#/c/90584/ Use PHPUnit filter/whitelist... [mediawiki/core] ? [17:44:34] (03CR) 10jenkins-bot: [V: 04-1] https://bugzilla.wikimedia.org/show_bug.cgi?id=55893 bug commited [core] - 10https://gerrit.wikimedia.org/r/97057 (owner: 10RAZVOR) [17:45:30] rillke: We were just remarking in -multimedia that it's mighty silly to be inconsistent about the URL structure, that we may as well just use one instance of the title instead of two [17:45:44] We set the cutoff to 160 in operations/wmf-config/filebackend.php [17:47:43] (03Merged) 10jenkins-bot: Honor shortened thumbnail paths in mw.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/97018 (owner: 10Rillke) [17:49:39] (03CR) 10Chad: [C: 032] Make sure all microtime calls return floats [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97050 (owner: 10Manybubbles) [17:49:44] (03Merged) 10jenkins-bot: Make sure all microtime calls return floats [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97050 (owner: 10Manybubbles) [18:02:33] (03CR) 10Cscott: [C: 032] Use -D consistently across mw-bundler and mw-latexer to turn on stack traces. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97009 (owner: 10Cscott) [18:02:41] (03CR) 10Cscott: [C: 032] Truncate image filenames if necessary to fit OS limits. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97010 (owner: 10Cscott) [18:02:51] (03CR) 10Cscott: [C: 032] Decode URI encoding in image resource titles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97011 (owner: 10Cscott) [18:03:04] (03CR) 10Cscott: [C: 032] Write siteinfo.db to record siteinfo in a multiple wiki collection. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97012 (owner: 10Cscott) [18:03:50] (03Merged) 10jenkins-bot: Use -D consistently across mw-bundler and mw-latexer to turn on stack traces. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97009 (owner: 10Cscott) [18:04:59] (03Merged) 10jenkins-bot: Truncate image filenames if necessary to fit OS limits. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97010 (owner: 10Cscott) [18:05:00] (03PS2) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [18:06:13] (03Merged) 10jenkins-bot: Decode URI encoding in image resource titles. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97011 (owner: 10Cscott) [18:07:16] MatmaRex: for fuzzying you need a text replacement adding the text !!FUZZY!! to those messages [18:07:25] (03Merged) 10jenkins-bot: Write siteinfo.db to record siteinfo in a multiple wiki collection. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97012 (owner: 10Cscott) [18:08:37] jdlrobson: You should probably join #wikimedia-office, we're talking about betafeatures [18:11:24] MSG MatmaRex can you review please? https://gerrit.wikimedia.org/r/#/c/96918/ [18:11:45] marktraceur: this seems worth bringing up in that meeting https://www.mediawiki.org/w/index.php?title=Talk:Wikimedia_Foundation_Design&diff=0&oldid=589969 [18:11:56] "Will the Ivory Tower ever respond to the grovelling masses? I have been following and trying to provide feedback on this Beta stuff, but it is very frustrating. The documentation provided is confusing and incomplete, and no questions are ever answered" [18:12:07] Nemo_bis: /join #wikimedia-office [18:12:17] nope [18:12:29] well, ok [18:12:33] it's not my question; if someone wants to answer better so, if not too bad [18:12:43] too bad indeed [18:13:08] clearly better for you to tell someone to ask the question that you think is already too indirect to ask yourself :) [18:13:35] Nemo_bis: It doesn't seem germane for the office hour, I think we'll reply to the user afterwards [18:14:17] yamelnychuk: looking [18:15:11] yamelnychuk: um, i don't see how what you did fixes the bug [18:15:25] (i'm looking at https://gerrit.wikimedia.org/r/#/c/96918/2/skins/vector/collapsibleTabs.js , i assume that's the current patch) [18:16:09] Nemo_bis: that question certainly has a poetry about it [18:17:36] (03CR) 10Ori.livneh: [C: 032] "Nice patch! The care for code conventions is much appreciated." [vagrant] - 10https://gerrit.wikimedia.org/r/97049 (owner: 10Gergő Tisza) [18:17:41] (03Merged) 10jenkins-bot: Add vagrant role for TimedMediaHandler [vagrant] - 10https://gerrit.wikimedia.org/r/97049 (owner: 10Gergő Tisza) [18:18:49] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'm sorry, I don't see how what you did here fixes the bug. It doesn't seem to make anything better." [core] - 10https://gerrit.wikimedia.org/r/96918 (owner: 10Yamelnychuk) [18:21:20] (03PS2) 10Cscott: Add 'forEachPar' and 'forEachSeq' helpers to promise helper module. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97017 [18:21:21] (03PS2) 10Cscott: Prefix the revision ID by the wiki index to create a unique key. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97013 [18:21:22] (03PS2) 10Cscott: Refactor revision fetch code to occur in (limited) parallel. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97014 [18:21:23] (03PS3) 10Cscott: Add featured article list and a script to build collections from it. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97015 [18:21:49] (03CR) 10Cscott: [C: 032] Prefix the revision ID by the wiki index to create a unique key. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97013 (owner: 10Cscott) [18:22:55] (03PS1) 10EBernhardson: [WIP] Attach workflows to posts, to get appropriate title into parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97060 [18:26:42] (03Merged) 10jenkins-bot: Prefix the revision ID by the wiki index to create a unique key. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97013 (owner: 10Cscott) [18:26:55] (03CR) 10Cscott: [C: 032] Refactor revision fetch code to occur in (limited) parallel. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97014 (owner: 10Cscott) [18:27:06] (03CR) 10Cscott: [C: 032] Add 'forEachPar' and 'forEachSeq' helpers to promise helper module. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97017 (owner: 10Cscott) [18:27:16] (03CR) 10Cscott: [C: 032] Add featured article list and a script to build collections from it. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97015 (owner: 10Cscott) [18:27:27] (03CR) 10Nemo bis: [C: 031] "Looks logical from a linguistics point of view, i.e. considering that Corsican apparently is in this respect equivalent to any of the Ital" [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [18:27:42] (03Merged) 10jenkins-bot: Refactor revision fetch code to occur in (limited) parallel. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97014 (owner: 10Cscott) [18:28:27] (03Merged) 10jenkins-bot: Add 'forEachPar' and 'forEachSeq' helpers to promise helper module. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97017 (owner: 10Cscott) [18:28:59] (03PS2) 10Manybubbles: WIP:Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 [18:29:13] (03Merged) 10jenkins-bot: Add featured article list and a script to build collections from it. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97015 (owner: 10Cscott) [18:33:39] (03PS1) 10Jeroen De Dauw: Only run linting and not tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 [18:34:06] (03PS1) 10Dan-nl: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 [18:34:41] (03PS7) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [18:34:52] (03PS1) 10Cscott: Use -D consistently across mw-bundler and mw-latexer to turn on stack traces. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97063 [18:34:53] (03PS1) 10Cscott: Unpack bundle in a subdir. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97064 [18:35:20] (03CR) 10jenkins-bot: [V: 04-1] Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [18:36:20] (03PS1) 10Jeroen De Dauw: Remove now incomplete dependency lists for some projects [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/97065 [18:36:56] (03PS2) 10Dan-nl: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 [18:37:03] (03Abandoned) 10Aaron Schulz: Clear out UID files for unit tests [core] - 10https://gerrit.wikimedia.org/r/86218 (owner: 10Aaron Schulz) [18:37:22] (03CR) 10Dan-nl: "- deleted the includes/functions/functions.php file" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 (owner: 10Dan-nl) [18:38:25] (03CR) 10Aaron Schulz: [C: 032] Follow redirects in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/96966 (owner: 10Legoktm) [18:38:34] (03Merged) 10jenkins-bot: Follow redirects in the job [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/96966 (owner: 10Legoktm) [18:38:39] (03PS2) 10Jeroen De Dauw: Only run linting and not tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 [18:39:58] (03PS2) 10Cscott: Use -D consistently across mw-bundler and mw-latexer to turn on stack traces. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97063 [18:39:58] (03PS2) 10Cscott: Unpack bundle in a subdir. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97064 [18:40:00] (03PS2) 10Dan-nl: filter [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 [18:40:20] (03CR) 10Cscott: [C: 032] Use -D consistently across mw-bundler and mw-latexer to turn on stack traces. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97063 (owner: 10Cscott) [18:40:28] (03CR) 10Dan-nl: "- adjusted the commit message." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 (owner: 10Dan-nl) [18:40:34] (03Merged) 10jenkins-bot: Use -D consistently across mw-bundler and mw-latexer to turn on stack traces. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97063 (owner: 10Cscott) [18:40:37] (03PS3) 10Dan-nl: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 [18:40:51] (03CR) 10Cscott: [C: 032] Unpack bundle in a subdir. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97064 (owner: 10Cscott) [18:40:57] (03CR) 10Parent5446: [C: 04-1] Move ExpandTemplates special into core (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [18:41:09] (03Merged) 10jenkins-bot: Unpack bundle in a subdir. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97064 (owner: 10Cscott) [18:41:52] (03CR) 10Nemo bis: "P.s.: The discussion should continue on that translatewiki.net thread if more needs to be discussed, or on a bugzilla bug." [core] - 10https://gerrit.wikimedia.org/r/96981 (owner: 10Rillke) [18:44:49] (03PS1) 10RAZVOR: resources/mediawiki.page/mediawiki.page.image.pagination.js [core] - 10https://gerrit.wikimedia.org/r/97066 [18:44:50] (03PS1) 10RAZVOR: page.image.pagination: Add mw.hook() [core] - 10https://gerrit.wikimedia.org/r/97067 [18:45:48] (03CR) 10Aaron Schulz: Limit job queue rate and wait for completion (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 (owner: 10Manybubbles) [18:47:29] (03PS4) 10Dan-nl: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 [18:47:51] (03CR) 10jenkins-bot: [V: 04-1] resources/mediawiki.page/mediawiki.page.image.pagination.js [core] - 10https://gerrit.wikimedia.org/r/97066 (owner: 10RAZVOR) [18:47:58] (03CR) 10Liangent: [C: 04-1] Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [18:48:00] (03PS5) 10Dan-nl: functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 [18:48:04] (03CR) 10jenkins-bot: [V: 04-1] page.image.pagination: Add mw.hook() [core] - 10https://gerrit.wikimedia.org/r/97067 (owner: 10RAZVOR) [18:48:16] (03CR) 10Aaron Schulz: [C: 032] Remove User::getPageRenderingHash, deprecated since 1.17 [core] - 10https://gerrit.wikimedia.org/r/96965 (owner: 10Aude) [18:49:55] (03CR) 10Mwjames: [C: 031] "Since WMF Jenkins is unable to install packages via Composer we have no choice as to retreat from Jenkins." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [18:51:43] (03Merged) 10jenkins-bot: Remove User::getPageRenderingHash, deprecated since 1.17 [core] - 10https://gerrit.wikimedia.org/r/96965 (owner: 10Aude) [18:53:40] (03CR) 10Manybubbles: [C: 04-1] Limit job queue rate and wait for completion (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 (owner: 10Manybubbles) [18:55:34] (03CR) 10Aaron Schulz: [C: 032] Delete fuzz-tester.php [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [18:58:47] (03CR) 10jenkins-bot: [V: 04-1] Delete fuzz-tester.php [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [18:59:50] ugh [18:59:52] does that mean qunit in core is broken? D: [18:59:53] (03CR) 10Chad: "How on earth did qunit fail? I didn't change any JS..." [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [19:00:04] * ^d sighs [19:00:08] AaronSchulz: rebase, retry? [19:00:23] maybe that was just computer imps [19:02:16] (03CR) 10Aaron Schulz: Limit job queue rate and wait for completion (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 (owner: 10Manybubbles) [19:02:55] (03CR) 10Manybubbles: Limit job queue rate and wait for completion (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 (owner: 10Manybubbles) [19:03:30] (03PS3) 10Manybubbles: Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 [19:04:14] (03PS8) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [19:04:18] (03PS4) 10Manybubbles: Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 [19:04:52] (03CR) 10jenkins-bot: [V: 04-1] Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [19:05:33] (03CR) 10Reedy: [C: 032 V: 032] Revert "Suppress section edit links with action=render" [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/97056 (owner: 10Bartosz Dziewoński) [19:07:29] (03CR) 10Aaron Schulz: Don't use API to fetch alternate poster sizes (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/96932 (owner: 10Brian Wolff) [19:09:26] AaronSchulz : good catch. No i dI'd not want that [19:09:44] Meh. Typing is hard... [19:11:28] (03CR) 10Aaron Schulz: "Is it faster to use BacklinkCache::getNumLinks() with the $max option set and then fallback to cirrus when the result equals the $max (whi" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 (owner: 10Manybubbles) [19:12:27] (03CR) 10Bartosz Dziewoński: "Rebasing to see if the tests are actually failing or is it just computer imps…" [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [19:12:31] (03PS2) 10Bartosz Dziewoński: Delete fuzz-tester.php [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [19:13:47] (03CR) 10Manybubbles: [C: 04-1] "Probably. I'll have a look at it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 (owner: 10Manybubbles) [19:21:19] (03CR) 10Bartosz Dziewoński: "Well, they're clearly not failing. I blame hashar." [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [19:21:51] (03PS3) 10Manybubbles: Limit job queue rate and wait for completion [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97045 [19:22:16] (03CR) 10BryanDavis: [C: 031] functions [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 (owner: 10Dan-nl) [19:22:17] (03PS9) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [19:25:52] (03CR) 10BryanDavis: [C: 031] filter [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 (owner: 10Dan-nl) [19:28:50] (03CR) 10Bartosz Dziewoński: "Ha, glad to see you've managed to rebase this, I just noticed and was about to offer help :)" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [19:31:48] (03CR) 10Bartosz Dziewoński: "Did you accidentally submit two identical patches? https://gerrit.wikimedia.org/r/#/c/88669/ seems to be the same thing as here." [core] - 10https://gerrit.wikimedia.org/r/88670 (owner: 10Huji) [19:31:52] AaronSchulz: anomie: csteipp: beta has an issue with $wgMWOAuthCentralWiki set to mediawikiwiki which does not exist. [19:32:12] AaronSchulz: anomie: csteipp: was wondering if I could get OAuth enabled on the loginwiki [19:32:22] (03PS2) 10Umherirrender: Always select ipb_deleted on list=[all]users [core] - 10https://gerrit.wikimedia.org/r/96794 [19:32:32] (03CR) 10UltrasonicNXT: ":) It was a bit tricky though. I made my first commit to mw-core in master, not a feature branch, and I think it's this that has made it t" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [19:33:24] maybe I should use labswiki .. [19:34:52] (03CR) 10Umherirrender: "Patch Set 2: Only remove the if from the function instead of given a new param. I was not sure, if extension will call this and maybe not " [core] - 10https://gerrit.wikimedia.org/r/96794 (owner: 10Umherirrender) [19:35:37] (03Draft2) 10Wikinaut: Bug 54511: OpenIDServer show error msg in case of untrusted $wgOpenIDTrustRoot [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 [19:35:56] (03PS1) 10MarkAHershberger: sign in the builddir where the files actually are [tools/release] - 10https://gerrit.wikimedia.org/r/97077 [19:35:59] hashar: For $wgMWOAuthCentralWiki in beta, you should be able to set it to the wiki id of whichever wiki you want to use as the central one, then run update.php against the central wiki (or run extensions/OAuth/backend/schema/mysql/OAuth.sql manually on it) [19:36:16] (03CR) 10Wikinaut: [C: 031 V: 031] Bug 54511: OpenIDServer show error msg in case of untrusted $wgOpenIDTrustRoot [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 (owner: 10Wikinaut) [19:36:20] anomie: is that independent from centralauth and the loginwiki ? [19:36:26] Yes [19:36:37] (03PS1) 10IAlex: Only put returnto parameter if needed on the from-http redirect in Special:Userlogin [core] - 10https://gerrit.wikimedia.org/r/97078 [19:36:43] (03CR) 10Parent5446: [C: 04-1] ">.< So close to merging." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [19:37:19] (otherwise it wouldn't work in production, with loginwiki versus mediawikiwiki) [19:37:32] okk [19:37:35] anomie: https://gerrit.wikimedia.org/r/97079 [19:37:35] :D [19:39:06] thank you [19:39:26] greg-g: ALARM friday deploy !!! [19:39:32] (on beta :D ) [19:39:36] (03PS3) 10Wikinaut: Bug 54511: Let OpenIDServer show an error msg for untrusted TrustRoot [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 [19:40:30] (03PS4) 10Wikinaut: Bug 54511: Let OpenIDServer show an error msg for untrusted TrustRoot [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 [19:40:32] anomie: are the Collection jenkins npmtest jobs working ? [19:40:36] Can someone help reviewing a simple patch, please? It's for a Google Code-in task: https://gerrit.wikimedia.org/r/#/c/96356/ [19:40:45] ^^^^Add HiDPI version or SVG of "heart" icon [19:41:15] hashar: Working as in Jenkins seems to be running them correctly, yes. Working as in they actually pass, no. ;) [19:41:56] (03CR) 10Hashar: Bug 54511: Let OpenIDServer show an error msg for untrusted TrustRoot (031 comment) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 (owner: 10Wikinaut) [19:42:04] (03PS10) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [19:42:06] anomie: at least the tests are being run properly aren't they ? [19:42:29] ror: unable to create file mobilelanding.php (Permission denied) [19:42:31] ohh my god [19:42:56] hashar: on beta? [19:43:06] yeah someone screw up some file permissions [19:43:11] grrrrr [19:43:20] qgil: it looks good at a glance, but i don't have time to test right now [19:43:30] aude: fixing them [19:43:32] thank you MatmaRex [19:43:35] k [19:43:37] (03CR) 10Mattflaschen: "No, thanks. I just renamed it to Hooks.php." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/96958 (owner: 10Mattflaschen) [19:43:43] (03PS5) 10Wikinaut: Bug 54511: Let OpenIDServer show an error msg for untrusted TrustRoot [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 [19:43:45] hashar: Yeah. I think in one repo they're failing because they try to shell out to zip, in another they're trying to shell out to inkscape, and in the third they still have node_modules as a subrepo so Jenkins trying to clone node_modules fails. If/when we decide to care, the options are remove the submodule or I'll submit a patch to have Jenkins stop trying to clone node_modules for that project. [19:43:58] (03CR) 10Wikinaut: Bug 54511: Let OpenIDServer show an error msg for untrusted TrustRoot (031 comment) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 (owner: 10Wikinaut) [19:44:19] (03PS2) 10Mattflaschen: Use GettingStarted namespace for all classes [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/96958 [19:45:17] (03CR) 10Wikinaut: [C: 031 V: 031] "can someone pls. code-review, then I'll merge. ty" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 (owner: 10Wikinaut) [19:45:20] anomie: for zip / inkscape we should get them installed via puppet. [19:45:59] anomie: you can find out the proper package name and add them in operations/puppet.git in modules/contint/manifests/packages/labs.pp [19:46:05] (03CR) 10Wikinaut: "result (in case of an error): http://i.imgur.com/DfdSshf.png" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 (owner: 10Wikinaut) [19:47:03] (03CR) 10Siebrand: "Can has merge?" [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [19:52:21] anomie: that fixed it up thank you! [19:55:25] anomie: ahh we can also make the extension to fetch the submodules [19:56:04] anomie: want me to do the puppet change? [19:56:36] hashar: Which puppet change? For the zip and such? I'm asking c-scott which packages he needs, then I'll submit it. [19:57:12] anomie: thinking about it, you probably want to list that in a class that will later on be used in production. [19:57:41] anomie: checkout with ops for the exact name, might want to add then in applicationserver:: or something [19:58:05] then in contint::packages::labs (which is applied on the jenkins slave) we could include that (soon to be) production class. [19:58:13] hashar: in production for unit testing, or in production for the boxes that are actually going to run the thing? [19:58:20] the later [19:58:33] and the packages needed for tests should land in contint::packages::labs [19:58:34] mwalker is handling the latter [19:58:39] this way they are not going to land in production [19:58:48] i suspect there will be some overlap [19:59:32] (03PS8) 10IAlex: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 [20:00:59] (03PS1) 10Chad: Remove a few stray $wgTitle comments [core] - 10https://gerrit.wikimedia.org/r/97081 [20:02:14] hashar: For now anyway, https://gerrit.wikimedia.org/r/97082 [20:03:17] <^d> http://p.defau.lt/?m8FHHrCWtp0CVTicWjmGmA - getting there :\ [20:03:47] anomie: excellent [20:04:39] * anomie should be careful, or he's going to wind up knowing enough about this to have people asking him for help ;) [20:06:24] (03CR) 10IAlex: [C: 032] Remove a few stray $wgTitle comments [core] - 10https://gerrit.wikimedia.org/r/97081 (owner: 10Chad) [20:07:33] (03PS1) 10Anomie: De-submodulize node_modules [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/97083 [20:07:39] Anyone here who knows something about ExternalStoreMedium ? [20:08:35] (03PS2) 10Anomie: De-submodulize node_modules [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/97083 [20:08:44] (03CR) 10Anomie: [C: 032] De-submodulize node_modules [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/97083 (owner: 10Anomie) [20:08:45] ^d: for includes/HttpFunctions.php you can change $wgTitle to $wgRequest->getRequestURL() or something like that ;) [20:08:49] anomie: did I grant you access on the 'integration' labs project ? [20:08:58] Some lines omitted but this looks wrong (analyser states "illegal array key type (i.e. an array): * @param array $urls A list of external store URLs [20:08:59] foreach ( $urls as $url ) { [20:09:00] $retval[$urls] = $data; [20:09:01] anomie: the tests are being run on integration-slave01 , so that might be handy. [20:09:09] (03Merged) 10jenkins-bot: De-submodulize node_modules [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/97083 (owner: 10Anomie) [20:09:12] <^d> ialex: Heh :) [20:09:20] I *think* it should be $url instead. [20:09:25] (03Merged) 10jenkins-bot: Remove a few stray $wgTitle comments [core] - 10https://gerrit.wikimedia.org/r/97081 (owner: 10Chad) [20:09:27] hashar: I don't think so [20:09:31] (03CR) 10Wikinaut: [C: 032 V: 032] Bug 54511: Let OpenIDServer show an error msg for untrusted TrustRoot [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97075 (owner: 10Wikinaut) [20:10:08] AaronSchulz: ^^ [20:11:18] yeah that's a typo [20:11:27] the subclasses override it so no one noticed I guess [20:12:07] (03PS1) 10Siebrand: Fix incorrect array type [core] - 10https://gerrit.wikimedia.org/r/97084 [20:12:17] AaronSchulz: https://gerrit.wikimedia.org/r/97084 [20:12:29] AaronSchulz: static code analysis scores again. [20:14:23] (03CR) 10Aaron Schulz: [C: 032] Fix incorrect array type [core] - 10https://gerrit.wikimedia.org/r/97084 (owner: 10Siebrand) [20:15:01] (03PS1) 10Chad: Don't use $wgTitle when we've got a good one on hand [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/97086 [20:17:34] (03Merged) 10jenkins-bot: Fix incorrect array type [core] - 10https://gerrit.wikimedia.org/r/97084 (owner: 10Siebrand) [20:18:22] (03PS1) 10Chad: Don't use back-compat globals $wgTitle and $wgRequest [extensions/Collection] - 10https://gerrit.wikimedia.org/r/97087 [20:19:40] (03PS1) 10Siebrand: Set default for $wgExternalStores to empty array [core] - 10https://gerrit.wikimedia.org/r/97088 [20:19:42] (03CR) 10Aaron Schulz: [C: 032] Delete fuzz-tester.php [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [20:20:59] (03PS25) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [20:21:53] (03PS3) 10IAlex: Update comment in DefaultSettings for bug 17180 [core] - 10https://gerrit.wikimedia.org/r/96692 (owner: 10Persia) [20:21:59] (03CR) 10IAlex: [C: 032] Update comment in DefaultSettings for bug 17180 [core] - 10https://gerrit.wikimedia.org/r/96692 (owner: 10Persia) [20:22:13] (03PS1) 10MarkAHershberger: bump version [core] - 10https://gerrit.wikimedia.org/r/97090 [20:22:23] (03CR) 10Edokter: [C: 031] mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [20:22:33] (03PS1) 10Chad: Don't use $wgTitle when we've got a good one on hand [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/97091 [20:23:55] (03Abandoned) 10MarkAHershberger: bump version [core] - 10https://gerrit.wikimedia.org/r/97090 (owner: 10MarkAHershberger) [20:24:50] (03Merged) 10jenkins-bot: Delete fuzz-tester.php [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [20:25:31] (03PS1) 10MarkAHershberger: bump version [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97092 [20:26:03] (03CR) 10MarkAHershberger: [C: 032 V: 032] bump version [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97092 (owner: 10MarkAHershberger) [20:26:32] (03PS1) 10Cscott: Update p module with additional forEachSeq/forEachPar helper functions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97093 [20:26:33] (03PS1) 10Cscott: Collection support! [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97094 [20:28:13] (03PS1) 10Siebrand: Do not call FileBackendGroup::get() statically [core] - 10https://gerrit.wikimedia.org/r/97095 [20:28:26] (03PS1) 10Cscott: Prefer rsvg-convert to inkscape for SVG->PDF conversion. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97096 [20:28:35] hexmode: is it normal that RELEASE-NOTES-1.22 are completely different in master and REL1_22 [20:28:39] ? [20:28:47] (03PS1) 10Chad: Don't use $wgTitle when the parser can give us one [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/97097 [20:28:59] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/97098 [20:29:29] ialex: I think it sadly has been done in the past that way.... I noticed that problem last week and was planning to sync them [20:29:31] (03Merged) 10jenkins-bot: Update comment in DefaultSettings for bug 17180 [core] - 10https://gerrit.wikimedia.org/r/96692 (owner: 10Persia) [20:30:27] <^d> ialex: I don't know if we're ever going to succeed! [20:30:31] (03PS5) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 (owner: 10Hashar) [20:30:31] <^d> This task is so daunting [20:30:34] (03PS7) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 (owner: 10Hashar) [20:31:22] ^d, hexmode: give me a moment :) [20:31:26] ^d: ialex: we could write a test to make sure RELEASE-NOTES are in sync :D [20:31:39] aka make sure the update land in master [20:31:43] <^d> Oh, I'm not worried about release notes :p [20:31:48] <^d> Nor was I talking about that :p [20:31:52] or we should just delete the one from master [20:32:00] (03CR) 10Aaron Schulz: [C: 032] Set default for $wgExternalStores to empty array [core] - 10https://gerrit.wikimedia.org/r/97088 (owner: 10Siebrand) [20:32:04] then whenever a chagne is put in REL1_22 make sure it match the version from master. though that might cause a bunch of issue when several patches are pending for REL1_22 :/ [20:32:06] (03CR) 10Aaron Schulz: [C: 032] Do not call FileBackendGroup::get() statically [core] - 10https://gerrit.wikimedia.org/r/97095 (owner: 10Siebrand) [20:32:26] * siebrand thanks AaronSchulz  [20:33:12] ialex: that will make backporting patches meant for current release a major pain in the butt [20:33:21] <^d> I think we shouldn't backport. [20:33:29] <^d> My preferred way to do things is actually to target things at the lowest supported branch we plan to land the change in, then upmerge those branches to higher supported branches and master. [20:33:32] the file in master is usually deleted after that version is release [20:33:33] d [20:34:06] ^d: i mostly mean things which already have patches pending when REL1_22 is branches, but not yet reviewed [20:34:22] is branched*. or known bugs being fixed in release candidates [20:35:29] <^d> Why on earth have we not gotten around to killing $wgAjaxExportBullshit yet? [20:35:30] * ^d sighs [20:35:32] (03CR) 10Manybubbles: "The answer to Aaron's question about the BacklinkCache is "yes, it is faster than Elasticsearch as coded in this commit." The problem is " [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 (owner: 10Manybubbles) [20:36:01] ^d: nice variable name [20:37:15] ^d: you mean sajax? because compatibility, and because boring [20:37:18] !bug sajax [20:37:18] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=sajax [20:37:37] <^d> MatmaRex: Compatibility is boring :p [20:37:54] ^d: according to https://bugzilla.wikimedia.org/show_bug.cgi?id=53122 SecurePoll uses sajax [20:37:58] D: [20:38:06] (03PS2) 10PleaseStand: Mechanism for renaming/aliasing classes [core] - 10https://gerrit.wikimedia.org/r/96945 [20:38:13] and that's deployed [20:38:47] (03CR) 10MaxSem: [C: 04-1] Let instructors and other roles add students (0312 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [20:39:06] <^d> As does FlaggedRevs, SemanticForms, Collection, CategoryTree [20:39:12] <^d> And that's just deployed ones. [20:39:17] what, seriously? D: [20:39:22] (03CR) 10Hashar: [C: 04-2] "I am not sure what you have in mind but all those four extensions have recent jobs that passed successfully." (034 comments) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [20:39:38] <^d> cd /www/mediawiki/extensions; ack '\$wgAjaxExportList' [20:40:29] <^d> http://p.defau.lt/?W_H8oRBiamJiwajyGlZeKg [20:40:45] <^d> Those BlueSpiceThings need a whole lotta lova. [20:40:46] madness [20:40:47] <^d> *love [20:40:52] <^d> They use tons of ugly globals. [20:41:08] i thought flaggedrevs sucks a little less. :( [20:41:43] BlueSpice stuff was pretty scary the last time I checked it out [20:41:52] felt like the devs reimplemented a _lot_ of stuff... [20:41:57] <^d> Yeah [20:42:00] lots of highly deprecated stuff [20:42:07] <^d> It keeps popping up in all my "looking for old crap" searches. [20:42:35] wtf is bluespice? [20:42:42] on the positive side, at least the code is FOSS -- and I'd hope the devs are around & responsive as well [20:42:52] (03Draft4) 10Wikinaut: make SpecialChangePassword form text depending on login status of wgUser [core] - 10https://gerrit.wikimedia.org/r/96651 [20:43:18] MatmaRex: business-oriented MediaWiki extensions, patches and whatnot developed by...some German people, if memory serves me correct (Hallo! Welt, maybe) [20:43:28] IIRC there's a MW.org page or two about the subject, too [20:43:51] <^d> if (method_exists($wgTitle, 'getNamespace' )) { [20:44:05] <^d> We've had getNamespace() on Title for HOW LONG now? [20:44:50] (03PS26) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [20:44:51] (03CR) 10Hashar: [C: 031] "Please fill a bug to upstream PHP Code_Sniffer : http://pear.php.net/package/PHP_CodeSniffer/bugs" [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [20:45:02] whee [20:45:38] (03Merged) 10jenkins-bot: Set default for $wgExternalStores to empty array [core] - 10https://gerrit.wikimedia.org/r/97088 (owner: 10Siebrand) [20:45:50] (03CR) 10Wikinaut: [C: 032 V: 032] "version 4.00" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [20:46:22] (03CR) 10Cscott: [C: 032] Prefer rsvg-convert to inkscape for SVG->PDF conversion. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97096 (owner: 10Cscott) [20:46:25] ^d: I was inclined to say "at least seven years" but then I realized that I've been around & using MW like for seven years or so, so it's most likely been around for even longer than I... [20:46:30] (03PS1) 10Chad: Remove unused $wgTitle [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/97099 [20:46:59] (03PS1) 10IAlex: Sync RELEASE-NOTES-1.22 between master and REL1_22 [core] - 10https://gerrit.wikimedia.org/r/97100 [20:47:07] (03CR) 10Cscott: [C: 032] Update p module with additional forEachSeq/forEachPar helper functions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97093 (owner: 10Cscott) [20:47:16] (03Merged) 10jenkins-bot: Do not call FileBackendGroup::get() statically [core] - 10https://gerrit.wikimedia.org/r/97095 (owner: 10Siebrand) [20:47:33] <^d> ashley: SocialProfile has $wgTitle [20:47:36] (03CR) 10Cscott: [C: 032] Collection support! [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97094 (owner: 10Cscott) [20:47:40] * ^d gets out the shaming stick to beat ashley with [20:47:50] wut? where? [20:47:59] <^d> SocialProfile/UserProfile/UserProfilePage.php [20:48:05] (03PS1) 10IAlex: Sync RELEASE-NOTES-1.22 between master and REL1_22 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/97101 [20:48:08] hmmm right [20:48:14] hexmode: ^ [20:48:31] mutante: still around? [20:48:53] ialex: nice! [20:48:53] (03PS2) 10IAlex: Sync RELEASE-NOTES-1.22 between master and REL1_22 [core] - 10https://gerrit.wikimedia.org/r/97100 [20:49:12] hexmode: yep [20:49:25] hexmode: they are exactly the same now :) [20:49:31] mutante: uploading now, about to make RT [20:49:43] (03PS1) 10Cscott: Improve script to build featured article collections. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97102 [20:50:54] * ^d thwacks grrrit-wm [20:51:06] hashar: Should we undo 96521 (made npmtest non-voting by default), or make it voting for the OCG repos while leaving the default as non-voting? [20:51:51] <^d> ashley: Also, SocialProfile/UserBoard/UserBoardClass.php [20:51:54] <^d> I missed that the first time. [20:52:15] (03CR) 10Cscott: [C: 032] Improve script to build featured article collections. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97102 (owner: 10Cscott) [20:52:52] (03Merged) 10jenkins-bot: Prefer rsvg-convert to inkscape for SVG->PDF conversion. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97096 (owner: 10Cscott) [20:53:06] mutante: RT#6381 [20:53:06] (03PS6) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 (owner: 10Hashar) [20:53:48] (03Merged) 10jenkins-bot: Update p module with additional forEachSeq/forEachPar helper functions. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97093 (owner: 10Cscott) [20:55:24] (03Merged) 10jenkins-bot: Collection support! [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97094 (owner: 10Cscott) [20:55:51] ^d: since UserProfilePage extends Article, blindly swapping $wgTitle to $this->getTitle() should just work, I assume? but I'm afraid I can't say the same about UserBoardClass.php, as it's a stand-alone class that doesn't extend any other class; it contains business logic and some functions that mix business logic & UI-level code and at least UserBoard_AjaxFunctions.php calls UserBoard's displayMessages() method and IIRC AJAX & title handling [20:55:51] is somewhat problematic, to say the least [20:58:19] <^d> ashley: Yeah, you should be able to call $this->getTitle() for UserProfilePage :) [20:59:00] hexmode: mediawiki-1.22.0rc3.tar.gz has an issue with the signature while the other files are fine [20:59:18] (03Merged) 10jenkins-bot: Improve script to build featured article collections. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97102 (owner: 10Cscott) [20:59:37] mutante: thanks for testing. manually fixing [21:00:06] mutante: wanna +2 https://gerrit.wikimedia.org/r/#/c/96018/ ? it's just a simple capitalization change, no functional changes at all [21:00:22] hexmode: kk [21:01:26] ashley: yes i will, and thanks for it, i just also have to build the package and put it on the instance, just merging wouldnt change it automatically [21:02:06] ah, I see; thanks in advance :) [21:04:12] (03PS1) 10Jack Phoenix: Removed a bunch of $wgTitle calls, because $wgTitle is EVIL! [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97104 [21:04:41] bleurgh rebasing :| [21:04:47] mutante: get new sig from http://mah.everybody.org/tmp/ [21:05:07] ashley: if you have more changes like that, keep 'em coming, i'm not used to contributions on that project so far:) [21:05:15] hexmode: kk [21:06:01] mutante: will do! I actually wanted to change a bunch of "Mediawiki"s to "MediaWiki" and overall clean up the code a bit, but alas, time constraints and all...thankfully it'll be Christmas soon enough! [21:08:26] hexmode: that worked http://dumps.wikimedia.org/mediawiki/1.22/ [21:09:02] !log uploaded mediawiki 1.22.0rc3 [21:09:03] Wrong channel, try again. [21:09:09] bah [21:11:00] anomie: make whatever you want voting :-} [21:11:17] anomie: usually I make a unit test job voting whenever the tests start passing in the branch [21:11:23] mutante: tyvm [21:11:30] (03PS2) 10Jack Phoenix: Removed a bunch of $wgTitle calls, because $wgTitle is EVIL! [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97104 [21:12:00] (03PS1) 10Anomie: Make npmtest voting for Collection OCG [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97105 [21:12:16] hashar: I think I'll leave the default non-voting. https://gerrit.wikimedia.org/r/97105 [21:12:39] (03CR) 10Jack Phoenix: [C: 032 V: 032] Removed a bunch of $wgTitle calls, because $wgTitle is EVIL! [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/97104 (owner: 10Jack Phoenix) [21:13:11] hexmode: yw [21:13:19] ^d: damn, I'm good at this git shit ;-) [21:13:25] anomie: zuul-config change trigger a job that diff the configuration before and after https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/635/console [21:13:35] <^d> ashley: I never thought I'd hear the words :D [21:13:58] note that I didn't say that I like it, just that I managed to fix a problem introduced by it [21:14:05] ashley: sweet, so far i did it like "wait for a couple fixes to be merged" then up the package version.. [21:14:22] eh, i mean, merge a couple at a time [21:14:53] (03CR) 10Hashar: [C: 032] "All jobs manages to complete their build successfully. Congratulations!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97105 (owner: 10Anomie) [21:15:02] (03Merged) 10jenkins-bot: Make npmtest voting for Collection OCG [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97105 (owner: 10Anomie) [21:15:09] anomie: welcome in the "I do tests" club :] [21:15:46] hashar: What is https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/635/console telling me? [21:16:11] anomie: it runs the zuul server in non daemon mode passing the configuration [21:16:26] anomie: that make zuul interpret the layout.yaml and output the pipelines/config .. as it understand it [21:16:35] (03CR) 10Mwjames: ">> all those four extensions have recent jobs that passed successfully" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [21:16:43] the job run it once against the parent patch and once against the current patch, then it does thedifference [21:16:50] hashar: So, I see the three tests I made voting show up twice. And then something unrelated at the end? [21:16:58] anomie: in this case, it shows that some jobs are no more nonvoting [21:17:13] anomie: ah yeah, the lines at the end is a bug in zuul :-/ [21:17:23] it is fixed in later versions though [21:17:40] (03PS1) 10Chad: Don't use $wgTitle when the parser can provide one [extensions/Video] - 10https://gerrit.wikimedia.org/r/97106 [21:17:57] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97105 (owner: 10Anomie) [21:19:11] (03PS1) 10Chad: Remove unused $wgTitle/$wgOut [extensions/Offline] - 10https://gerrit.wikimedia.org/r/97108 [21:20:33] <^d> YuviPanda: Can you import a pull request for mediawiki core? [21:20:41] <^d> With your magic tool? [21:20:43] the IP one? [21:20:53] ^d: Defiance! [21:20:57] Delegation! [21:21:01] ^d: i can haz link> [21:21:01] ? [21:21:05] <^d> YuviPanda: pull request 13. [21:21:06] <^d> sec. [21:21:13] (03CR) 10Anomie: [C: 032] Always select ipb_deleted on list=[all]users [core] - 10https://gerrit.wikimedia.org/r/96794 (owner: 10Umherirrender) [21:21:15] <^d> https://github.com/wikimedia/mediawiki-core/pull/13 [21:22:15] ^d: on it [21:22:19] (03PS1) 10Cscott: Further improvements and bugfixes to featured article bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97109 [21:22:21] <^d> ty [21:24:21] sjoerddebruin: hmmm, could what you reported earlier today be related to https://bugzilla.wikimedia.org/show_bug.cgi?id=57443 ? [21:24:21] (03PS1) 10Yuvipanda: Use lower memory limits [core] - 10https://gerrit.wikimedia.org/r/97110 [21:24:30] ^d: ^ [21:24:46] i'm running it manually forn ow, author info still preserved [21:24:46] I think so... [21:25:04] <^d> YuviPanda: Thanks :) [21:25:07] ^d: yw [21:25:18] (03Merged) 10jenkins-bot: Always select ipb_deleted on list=[all]users [core] - 10https://gerrit.wikimedia.org/r/96794 (owner: 10Umherirrender) [21:26:06] ^d: can you comment on the PR with the patch link? Github keeps timing out the comment submit for me [21:26:07] :| [21:26:15] <^d> Yeah will do. [21:26:27] ^d: ty [21:26:35] MatmaRex: Yes, it’s fixed when i disable the nearby-beta. [21:27:14] <^d> Silly github. [21:27:32] seems completely dead now [21:28:24] <^d> "There was an error creating your comment" [21:28:27] <^d> No shit. [21:31:24] (03CR) 10Chad: [C: 032] Use lower memory limits [core] - 10https://gerrit.wikimedia.org/r/97110 (owner: 10Yuvipanda) [21:32:36] <^d> "Request forbidden by administrative rules" [21:32:39] <^d> stfu github. [21:34:26] (03Merged) 10jenkins-bot: Use lower memory limits [core] - 10https://gerrit.wikimedia.org/r/97110 (owner: 10Yuvipanda) [21:35:23] (03CR) 10Hashar: "The workaround to handle dependencies is the shell script that fetch them. I wrote that in a hurry to fit the needs of Jeroen for the Wiki" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/97061 (owner: 10Jeroen De Dauw) [21:35:41] (03PS5) 10Manybubbles: Count links from Elasticsearch instead of db [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 [21:48:17] (03CR) 10CSteipp: filter (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97051 (owner: 10Dan-nl) [21:48:37] (03CR) 10Parent5446: [C: 031] Mechanism for renaming/aliasing classes [core] - 10https://gerrit.wikimedia.org/r/96945 (owner: 10PleaseStand) [21:51:25] (03Abandoned) 10Chad: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 (owner: 10Chad) [21:51:28] (03PS3) 10M4tx: Fixed low-resolution enhanced recent changes collapse/show arrows (bug 35344) [core] - 10https://gerrit.wikimedia.org/r/96372 [21:51:29] (03PS1) 10M4tx: Fixed indentation style and PNG fallback method. [core] - 10https://gerrit.wikimedia.org/r/97114 [21:51:38] (03PS3) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [21:52:48] (03CR) 10M4tx: "Fixed:" [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx) [21:55:04] (03CR) 10CSteipp: [C: 04-1] "This seems like the wrong way to accomplish this, and seems like it relies on another bug that might disappear." [core] - 10https://gerrit.wikimedia.org/r/96651 (owner: 10Wikinaut) [22:01:53] (03PS1) 10Legoktm: Only link to specific revision in log entry if page still exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97116 [22:09:34] (03CR) 10Hashar: [C: 032] "Path handling is definitely messy in this script. Good catch and nice job on writing a nice commit message summary, much helpful." [tools/release] - 10https://gerrit.wikimedia.org/r/97077 (owner: 10MarkAHershberger) [22:09:41] (03Merged) 10jenkins-bot: sign in the builddir where the files actually are [tools/release] - 10https://gerrit.wikimedia.org/r/97077 (owner: 10MarkAHershberger) [22:10:48] (03CR) 10Manybubbles: [C: 04-1] "grrr - something seems not to be working. going to have to investigate....." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 (owner: 10Manybubbles) [22:13:13] (03CR) 10Manybubbles: "False, alarm. Had switch branches and run things that updated state then tried to switch back without rerunning them." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97002 (owner: 10Manybubbles) [22:13:29] (03PS1) 10Legoktm: If a user has a temporary password set, still take over the account [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97117 [22:15:43] (03PS2) 10Legoktm: Only link to specific revision in log entry if page still exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/97116 [22:16:56] (03PS1) 10Manybubbles: Remove workaround for fixed upstream wildcard bug [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97120 [22:17:30] (03PS1) 10Cmcmahon: put G/W/T steps in alphabetical order [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97121 [22:19:00] (03PS4) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [22:20:59] (03CR) 10Chad: [C: 032] Remove workaround for fixed upstream wildcard bug [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97120 (owner: 10Manybubbles) [22:21:03] (03Merged) 10jenkins-bot: Remove workaround for fixed upstream wildcard bug [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97120 (owner: 10Manybubbles) [22:21:18] (03PS5) 10Yamelnychuk: Fix collapsibleTabs code cleanup: null != undefined & undefined variables passed to .data(). [core] - 10https://gerrit.wikimedia.org/r/96918 [22:22:26] (03Draft2) 10Aude: Add test to validate special page aliases [core] - 10https://gerrit.wikimedia.org/r/97118 [22:23:32] (03CR) 10Aude: [C: 04-1] "this fails until we get Hebrew special page aliases re-exported, and then it will pass." [core] - 10https://gerrit.wikimedia.org/r/97118 (owner: 10Aude) [22:25:24] (03CR) 10Cscott: [C: 032] Further improvements and bugfixes to featured article bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97109 (owner: 10Cscott) [22:25:45] (03PS1) 10Cscott: Bug fixes to URL and TeX escaping. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97123 [22:26:10] (03CR) 10Cmcmahon: [C: 032] "no functional changes" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97121 (owner: 10Cmcmahon) [22:26:19] (03Merged) 10jenkins-bot: Further improvements and bugfixes to featured article bundling. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/97109 (owner: 10Cscott) [22:26:58] (03PS1) 10Cscott: The boldface and italic "gentium basic" fonts are incomplete; don't use. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97124 [22:27:14] (03CR) 10Cscott: [C: 032] Bug fixes to URL and TeX escaping. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97123 (owner: 10Cscott) [22:27:23] (03CR) 10Cscott: [C: 032] The boldface and italic "gentium basic" fonts are incomplete; don't use. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97124 (owner: 10Cscott) [22:27:39] (03Merged) 10jenkins-bot: Bug fixes to URL and TeX escaping. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97123 (owner: 10Cscott) [22:28:00] (03Merged) 10jenkins-bot: The boldface and italic "gentium basic" fonts are incomplete; don't use. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97124 (owner: 10Cscott) [22:30:11] (03CR) 10Qgil: "Why having three patches in total for this fix? Isn't it better to ammend the original patch? Or in any case, why having two patches for f" [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx) [22:32:44] (03Abandoned) 10Cmcmahon: new test for editing existing title, also alphabetize and cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96047 (owner: 10Cmcmahon) [22:33:23] (03PS1) 10Theopolisme: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 [22:34:42] (03CR) 10jenkins-bot: [V: 04-1] Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [22:35:50] (03CR) 10Theopolisme: "This code is still a work in progress, so bear with me :)" [core] - 10https://gerrit.wikimedia.org/r/97125 (owner: 10Theopolisme) [22:38:01] (03PS2) 10Theopolisme: Improve PDF/DJVU navigation [core] - 10https://gerrit.wikimedia.org/r/97125 [22:44:08] (03PS1) 10Cscott: Correct name of package containing the rsvg-convert binary. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97127 [22:44:33] (03CR) 10Cscott: [C: 032] Correct name of package containing the rsvg-convert binary. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97127 (owner: 10Cscott) [22:44:53] (03Merged) 10jenkins-bot: Correct name of package containing the rsvg-convert binary. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/97127 (owner: 10Cscott) [22:45:38] (03CR) 10Ori.livneh: [C: 032] Use GettingStarted namespace for all classes [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/96958 (owner: 10Mattflaschen) [22:45:42] (03Merged) 10jenkins-bot: Use GettingStarted namespace for all classes [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/96958 (owner: 10Mattflaschen) [22:53:11] (03Draft2) 10Wikinaut: removed superfluous wfDebug statements [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97129 [22:54:36] (03CR) 10Wikinaut: [C: 032 V: 032] "trivial change (removed wfDebug() )" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/97129 (owner: 10Wikinaut) [22:59:04] (03PS1) 10Gergő Tisza: Fix accidental dependency on PoolCounter extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97132 [23:04:24] (03Abandoned) 10Gergő Tisza: Fix accidental dependency on PoolCounter extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/97132 (owner: 10Gergő Tisza) [23:06:45] blody flaggedrev having non-standard date for protection_expiry in the api [23:07:02] file a bug! [23:09:44] (03CR) 10AzaToth: [C: 031] Format protection_expiry timestamp in ISO format for API results [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [23:09:59] p858snake|l: found a unapplied patchie instead [23:10:06] since july [23:17:38] (03CR) 10Bsitu: Mention: notify correctly if there is no section title (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [23:18:10] (03CR) 10CSteipp: [C: 031] "Approving the concept. This will make review a little easier. Thanks!" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/97062 (owner: 10Dan-nl) [23:22:12] (03CR) 10CSteipp: [C: 031] "I'm not opposed to getting rid of the preference, and it simplifies some of the logic. Probably need to socialize the change before it's m" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [23:27:51] (03CR) 10Parent5446: [C: 04-1] "The Remember Me checkbox still needs to be removed from includes/templates/Userlogin.php." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [23:32:32] (03PS4) 10Theopolisme: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 [23:33:45] (03PS5) 10Theopolisme: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 [23:38:48] (03CR) 10Legoktm: Mention: notify correctly if there is no section title (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [23:40:12] (03PS1) 10Andrew Bogott: Offer up wmflabs.org as default domain for new proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/97140 [23:47:05] (03CR) 10Bsitu: Mention: notify correctly if there is no section title (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [23:47:30] (03CR) 10CSteipp: "Works for me. My only suggestion is that I usually leave the ./build/ directory as the place where my tarballs are generated. Should base " [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [23:49:04] (03PS2) 10EBernhardson: [WIP] Attach workflows to posts, to get appropriate title into parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/97060 [23:55:47] (03CR) 10Bsitu: "I tried it with signature: [[Usuário:, it doesn't seem to work" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87477 (owner: 10Legoktm) [23:57:21] (03CR) 10Andrew Bogott: [C: 032] Offer up wmflabs.org as default domain for new proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/97140 (owner: 10Andrew Bogott) [23:57:23] (03Merged) 10jenkins-bot: Offer up wmflabs.org as default domain for new proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/97140 (owner: 10Andrew Bogott)