[00:02:11] (03CR) 10Mglaser: [C: 031] "Thanks Antoine! The changes you made look good to me. We will see if stopInSkipped is the best choice, maybe we need to get the full pictu" [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [00:06:22] (03PS23) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [00:07:59] (03PS4) 10Dan-nl: job-queue-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 [00:08:36] (03PS5) 10Dan-nl: job-queue-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 [00:09:05] (03PS4) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [00:11:27] (03CR) 10Dan-nl: "- addressed ps2 comment by aaron in UploadMetadataJob.php." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 (owner: 10Dan-nl) [00:22:08] (03PS1) 10Bsitu: Timestamp should always take user to history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96674 [00:22:47] is there a way you can detect that the updater is being run? I don't see any define('MW_UPDATER', true) or something [00:29:13] (03PS1) 10Legoktm: Define 'MW_UPDATER' when running update.php [core] - 10https://gerrit.wikimedia.org/r/96676 [00:31:38] (03PS1) 10Legoktm: Only run onUserSaveSettings hook if not in update.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96677 [00:32:02] (03CR) 10Legoktm: "Used in I4cf977ee4e0dfd5c564334481e9ae2f6bca85b61." [core] - 10https://gerrit.wikimedia.org/r/96676 (owner: 10Legoktm) [00:34:15] (03PS2) 10Legoktm: Only run onUserSaveSettings hook if not in update.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96677 [00:43:08] (03CR) 10Aaron Schulz: [C: 032] config-clean-up (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 (owner: 10Dan-nl) [00:43:16] (03Merged) 10jenkins-bot: config-clean-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 (owner: 10Dan-nl) [00:48:34] (03CR) 10Aaron Schulz: [C: 032] job-queue-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 (owner: 10Dan-nl) [00:48:40] (03Merged) 10jenkins-bot: job-queue-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 (owner: 10Dan-nl) [00:54:40] (03CR) 10Bsitu: [C: 032] Hook expects old RC_* value for watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96578 (owner: 10EBernhardson) [00:54:49] (03Merged) 10jenkins-bot: Hook expects old RC_* value for watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96578 (owner: 10EBernhardson) [00:55:23] (03CR) 10Bsitu: [C: 032] Add missing documentation on performs-write param [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96541 (owner: 10EBernhardson) [00:55:33] (03Merged) 10jenkins-bot: Add missing documentation on performs-write param [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96541 (owner: 10EBernhardson) [01:00:09] can i poke a +2'er to look at https://gerrit.wikimedia.org/r/#/c/85512/ ? it's been 2 months since i submitted this [01:01:13] * Elsie peeks. [01:02:53] I added a few reviewers. [01:03:02] Perhaps you can comment on the patchset? [01:03:04] It needs a bump. [01:08:46] it'd help to document a use-case in the commit message or the bug [01:09:22] (03PS3) 10Jdlrobson: WIP: Target mobile on ve dependencies [core] - 10https://gerrit.wikimedia.org/r/93915 (owner: 10Robmoen) [01:11:44] (03PS2) 10Bsitu: Moderation buttons should have gray icon by default, colored on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96502 (owner: 10Matthias Mullie) [01:13:38] (03PS2) 10Ori.livneh: Factor out some code to a separate function for better profiling [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/94683 (owner: 10MaxSem) [01:13:43] (03CR) 10Bsitu: "patch set 2: rebased" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96502 (owner: 10Matthias Mullie) [01:13:57] (03CR) 10Ori.livneh: [C: 032] "Thanks." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/94683 (owner: 10MaxSem) [01:14:02] (03Merged) 10jenkins-bot: Factor out some code to a separate function for better profiling [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/94683 (owner: 10MaxSem) [01:17:44] (03PS8) 10Jackmcbarn: Add an API action to test blacklisted URLs [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 [01:19:36] (03PS1) 10Tholam: Add warning that patches should go to Gerrit instead of Bugzilla [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 [01:21:37] (03CR) 10Jackmcbarn: "Rebased only; no changes to the new code." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/85512 (owner: 10Jackmcbarn) [01:31:29] Oh. [01:31:32] I can +2 that now. [01:31:50] But I'd rather at least someone else look at it [01:32:52] can you poke someone if you see them? [01:34:53] well Elsie just added a bunch of people to the patch, so they're all going to get emails about it [01:53:28] (03CR) 10EBernhardson: [C: 04-1] Timestamp should always take user to history page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96674 (owner: 10Bsitu) [02:07:02] (03PS2) 10Bsitu: Timestamp should always take user to history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96674 [02:11:20] (03PS1) 10Anomie: Call object_properties_init in create_object handlers for PHP 5.4 [php/luasandbox] - 10https://gerrit.wikimedia.org/r/96687 [02:12:00] (03PS1) 10EBernhardson: Move buttonicon.less to the base module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96688 [02:43:08] (03PS3) 10EBernhardson: Timestamp should always take user to history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96674 (owner: 10Bsitu) [02:44:31] (03CR) 10EBernhardson: [C: 032] "Also removed $children, which became unused when removing $history" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96674 (owner: 10Bsitu) [02:44:41] (03Merged) 10jenkins-bot: Timestamp should always take user to history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96674 (owner: 10Bsitu) [02:47:51] (03CR) 10EBernhardson: Only run onUserSaveSettings hook if not in update.php (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96677 (owner: 10Legoktm) [02:54:02] (03CR) 10Siebrand: Silence false positive CodeSniffer error (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [03:06:06] https://en.wikipedia.org/wiki/Wikipedia:HOTCAT isn't working @en wiki for me.... [03:06:14] It's been 2.5 months. [03:06:30] How can I fix it? [03:07:49] for more help see https://en.wikipedia.org/wiki/File:Screenshots_by_Pratyya_Ghosh_1.png [03:08:00] It's working good in other wikis.. [03:10:49] !help [03:10:49] There are a lot of topics you could be asking about. Besides, this bot is mostly for experienced users to quickly answer common questions. Please just ask your question and wait patiently, as the best person to answer your question may be away for a few minutes or longer. If you're looking for help pages, we moved that to !helpfor. [03:10:57] !helper [03:55:06] anyone here? [03:55:38] Of course. [04:18:47] JS console [04:24:09] sorry for the delay Reedy I was having my breakfast.. [04:24:10] (03CR) 10Siebrand: "@hashar: Can you have a look, please?" [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [04:24:32] What's the problem and how to fix it.. can you please tell me? [04:26:08] Reedy: you there? ping me after your reply... :-) [04:28:49] Pratyya: Look in your javscript console [04:28:57] Chances are there's a conflict [04:29:05] It works for everyone else, and works for you everywhere else [04:30:00] Also try toggling it off, load a page (view and purge your user page or similar), and enable it again and view/purge again [04:30:56] [10:28] Reedy Also try toggling it off, load a page (view and purge your user page or similar), and enable it again and view/purge again I've done it 25+ times in last 2 months... [04:31:07] Right [04:31:09] See step 1 [04:31:27] http://en.wikipedia.org/wiki/User:Pratyya_Ghosh/common.js it's my common.js [04:31:50] Step 1? [04:32:58] Reedy: [04:33:07] [04:28:46] Pratyya: Look in your javscript console [04:33:12] [04:18:44] JS console [04:33:29] You've 40 imports there [04:33:33] Chances are one of them is causing a problem [04:34:12] https://en.wikipedia.org/wiki/User:Reedy/common.js [04:34:15] RESOLVED WORKSFORME [04:34:36] how'll I understand which one is causing problem? [04:35:01] Every script is important for WP work.. [04:35:56] Have you checked your JS console? [04:36:25] you mean http://en.wikipedia.org/wiki/User:Pratyya_Ghosh/common.js? [04:36:33] No [04:36:53] What browser are you using? [04:37:18] Firefox 25 [04:38:46] * Reedy wonders why he's debugging user JS at 04:38 [04:40:44] Pratyya: Press the menu button in the top left, Web Developer -> Web Console [04:40:49] Ctrl + Shift + K [04:40:50] apparently [04:40:59] Console is noisy on enwiki not logged in... [04:41:39] pressed. Something console, Inspector.... Reedy [04:41:50] And in the window at the bottom? [04:42:00] You might need to refresh the page at this point [04:42:31] a new window opened at the bottom.. [04:42:48] What generates static HTML dumps? [04:42:58] We still do those? [04:42:59] I thought it was in mediawiki/core/maintenance/. [04:43:00] Elsie: code? [04:43:02] We did. [04:43:04] Which code? [04:43:09] Computer code [04:43:10] (03PS1) 10EBernhardson: CSS transitions for hover effects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96690 [04:43:23] My second guess was the WikimediaMaintenance extension. [04:43:24] Reedy: refreshed. [04:43:27] But I don't have that checked out. [04:43:30] Cloned. [04:43:31] w/e [04:43:47] https://www.google.co.uk/search?q=github+wikimediamaintenance&oq=github+wikimediamaintenance&aqs=chrome..69i57j69i64.3610j0j7&sourceid=chrome&espv=210&es_sm=93&ie=UTF-8 [04:43:52] https://www.google.co.uk/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&ved=0CDQQFjAA&url=https%3A%2F%2Fgithub.com%2Fwikimedia%2Fmediawiki-extensions-Maintenance&ei=fo-NUt70NYaRhQfSkYGoBg&usg=AFQjCNGhhy1NDbkxk6PmxEAsIAOCpc3TVw&sig2=FfjtW472Nf5DWfTjo3gwFw&bvm=bv.56988011,d.ZG4 [04:43:54] gk Reedy [04:43:57] STFU GOOGLE [04:44:00] we still do those? [04:44:01] https://github.com/wikimedia/mediawiki-extensions-Maintenance [04:44:03] gk Reedy [04:44:04] (Static HTML) [04:44:15] Don't get excited, everyone. [04:44:18] Not the right ones [04:44:22] https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintenance [04:44:23] I wasn't suggesting we'd fix 15017. [04:44:39] I don't see it in there either. [04:44:48] bug 15017 * [04:44:51] (03PS2) 10Siebrand: Remove function calls from for loop test part [core] - 10https://gerrit.wikimedia.org/r/96457 [04:45:07] (03CR) 10Siebrand: [C: 032] "Per earlier +2 by Tyler." [core] - 10https://gerrit.wikimedia.org/r/96457 (owner: 10Siebrand) [04:45:23] Kinda strange that we have that extension, TBH. [04:45:30] Why? [04:45:32] Don't we have an operations repo? [04:45:35] People complain about core being full of shit [04:45:53] Right, but I think we already keep most Wikimedia MediaWiki shit in operations. [04:46:01] It wouldn't be helpful appearing in like /usr/local/bin [04:46:02] I'm not sure what the point of an extension is. [04:46:07] * Elsie shrugs. [04:46:09] operations/dumps exists [04:46:10] Okay. [04:46:12] It's a useful location [04:46:13] Oh. [04:46:17] Maybe that has the script! [04:46:29] mwscript extensions/WikimediMaintenance/runScript.php --wiki=foo --OPTION [04:46:37] Sensible to type [04:46:41] Also [04:46:45] Wikimedia* [04:46:45] Doesn't it predate git too? [04:46:50] Probably. [04:46:55] No tab autocomplete in here [04:47:03] Elsie: You could wait a couple of hours and ask apergos nicely [04:47:12] It's just a weird set of scripts for an extension. [04:47:26] It has no interface exposure, I believe. I'm not sure that's true for many extensions. [04:48:06] Reedy: what'll I do now? [04:48:59] YuviPanda: I think operations/dumps is exclusively XML dumps. [04:49:09] maebe [04:49:12] And some pieces of download.wikimedia.org, I think. [04:49:15] https://git.wikimedia.org/tree/operations%2Fdumps.git/bf268a25cf5556df6cb3dc98db539145cef5677e [04:49:47] (03Merged) 10jenkins-bot: Remove function calls from for loop test part [core] - 10https://gerrit.wikimedia.org/r/96457 (owner: 10Siebrand) [04:50:09] (03PS1) 10Persia: Update comment in DefaultSettings for bug 17180 [core] - 10https://gerrit.wikimedia.org/r/96691 [04:50:20] Pratyya: Read what the box has to say? [04:51:18] Oh, it's an extension. [04:51:21] hey Reedy can you accept snaps through your client? [04:51:34] I'll send you a screenshot. [04:51:40] https://www.mediawiki.org/wiki/Extension:DumpHTML [04:51:46] (03PS4) 10Siebrand: Document future removal of action=parse&prop=languageshtmli [core] - 10https://gerrit.wikimedia.org/r/96364 [04:51:47] or your mail? [04:52:28] Use an image pastbin or similar [04:53:04] Hey can I send it to your mail? Pastebin takes a lot of time. [04:53:40] (03PS2) 10EBernhardson: CSS transitions for hover effects [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96690 [04:53:42] Pastebin shouldn't be any more difficult htan uploading to commons [04:53:59] (03CR) 10Siebrand: Various fixes for EnhancedChangesList (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96244 (owner: 10Siebrand) [04:54:03] Or any more time than emailing it even with paste and go [04:54:08] More people can look at it too [04:54:12] (03Abandoned) 10Persia: Update comment in DefaultSettings for bug 17180 [core] - 10https://gerrit.wikimedia.org/r/96691 (owner: 10Persia) [04:54:17] Rather than you sending the image X times to Y people [04:55:59] * Reedy notes it's nearly 5am here and he's still sat in his car [04:56:21] * Elsie notes svn.wikimedia.org is down. [04:56:29] It's difficult to research dumpHTML.php without it. [04:56:34] There's a bug for that [04:56:37] Insert trademark [04:56:39] ™ [04:56:43] ty [04:56:56] How do I see the historical state of core/maintenance/? [04:57:03] I can do it with viewvc and svn. [04:57:05] git log [04:57:14] Bleh. [04:57:28] https://github.com/wikimedia/mediawiki-core/commits/master/maintenance [04:57:37] is git.wm.o down? [04:57:38] Yay, pagination [04:57:40] oh, just slow. [04:57:47] ori-l: It's too aggressive with caching [04:57:51] Pisses me off [04:58:03] Having to mangle urls to get up to date data from it [04:58:28] do you have an example? [04:58:45] Visit any page on git.wikimedia.org [04:58:50] ?page=100 [04:59:19] Elsie: Extension:CodeReview [04:59:28] (03PS1) 10Persia: Update comment in DefaultSettings for bug 17180 [core] - 10https://gerrit.wikimedia.org/r/96692 [04:59:30] /trunk/phase3/maintenance and author being me [04:59:43] GitHub works. [05:00:03] Extension:CodeReview doesn't work well if SVN is down. [05:00:07] Though surprisingly diffs work. [05:00:15] Because they're all cached [05:00:17] But any of the useful links go to a dead server. [05:00:18] Maybe. [05:00:19] in teh databass [05:00:23] Yeah. [05:00:25] No, I know they are [05:00:36] I know they are too. [05:00:39] I'm just saying it's surprising. [05:00:41] NO MAYBE ABOUT IT [05:00:45] WELL, [05:00:50] I think I found the revision I wanted. [05:00:52] At long last. [05:00:55] gj [05:01:09] How do I see Git notes (metadata) about a commit? [05:01:31] ori-l: IIRC it's been this way since it was put behind the general purpose misc varnish proxy thing [05:01:33] I think [05:01:38] We map SVN revs to commits somewhere. [05:01:49] I thought that wasn't imported? [05:01:55] It's in git.wm.o. [05:02:11] But you can't look up commits by hash there. [05:02:28] is there really no git.wm.o component or product in bugzilla? [05:02:37] Reedy: the problem is I can't copy it or select anything.... [05:02:38] I tried using "git notes" a few days ago, but I gave up [05:02:49] ori-l: Wikimedia --> Gerrit/Git [05:02:57] that is pretty broad [05:02:58] How'll I paste it to pastebin? [05:03:07] ori-l: Well, it's all handled by... well, you know. [05:03:13] I ended up just checking out the whole of refs/notes/commits and finding the relevant commit in there [05:03:23] Ah, the notes are in a branch? [05:03:33] well, branches are refs/heads/* [05:03:40] TimStarling: You should write a book about these sort of things [05:03:41] so technicall, it's a ref but not a branch [05:03:45] Or blog more frequently [05:03:47] +y [05:04:11] "N tool is supposed to let you do X, Y, Z; but it's much easier to just DIY it with..." [05:04:28] Elsie: try git fetch origin refs/notes/commits && git checkout FETCH_HEAD [05:05:17] Looks like it's working. [05:05:48] Detached HEAD state. [05:06:36] This is pretty trippy. [05:06:43] yeah, then it is something like cat 12/3456789abcdef where 123456789abcdef is the commit hash [05:07:34] I don't understand the two-letter directories. [05:07:37] Oh. [05:07:42] Never mind, I get it. [05:07:50] This is cute. [05:09:51] Elsie: Same reason we can do hashed upload directories in MediaWiki ;) [05:10:45] They're all http links. [05:10:50] But I found what I wanted, yay. [05:11:49] that's a volunteer-friendly task, I think [05:12:03] gerrit stream-events -> varnish purge, I mean [05:12:30] Purging what? [05:12:39] stale pages [05:12:42] Oh, git.wm.o? [05:12:43] everything [05:12:49] Purge all the things. [05:13:03] git.wm.o seems to just be slow, not stale. [05:13:04] ori-l: It's not too uncommon a thing that someone might have already done so... [05:13:08] But I don't use it often because of the former. [05:13:11] GitHub is so much faster. [05:14:29] * Elsie tries "git fetch origin" to re-attach. [05:14:45] Google : Google+ :: GitHub : ? [05:15:08] GitHub is the social network. [05:15:15] You have it on the wrong side. of the comparison. ;-) [05:15:17] That's insightful [05:15:28] but they'll invent some other way to be gross [05:15:54] http://dodgeball.github.com/ [05:16:14] ori-l: I find it difficult to take issue with GitHub. [05:16:22] Stealing all the code [05:17:44] git fetch origin looked somewhat promising. [05:17:51] But I think I really want git checkout master, maybe. [05:18:00] I'm behind by 986 commits. [05:18:17] Do we support "git pull" or "git pull --rebase" or git fetch/something? [05:18:38] I learned recently that people have wildly divergent views on this. [05:19:40] I can put the detached commit into a branch. [05:20:21] I went with git pull --rebase. [05:29:05] Reedy: please see http://www.flickr.com/photos/92970897@N06/. 3 Serially 3 [05:31:14] (03PS1) 10Cscott: Generate the nfo.json file from metabook.json. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96694 [05:36:42] (03CR) 10Mattflaschen: [C: 032] "Thank you. :)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/94370 (owner: 10Phuedx) [05:37:03] (03PS1) 10Cscott: Add --debug option to CLI. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96695 [05:37:15] (03Merged) 10jenkins-bot: Remove the gettingstarted tour. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/94370 (owner: 10Phuedx) [05:46:07] Pratyya: https://en.wikipedia.org/wiki/User:Pratyya_Ghosh/vector.js [05:46:12] What the hell is going on there? [05:46:31] It's not valid javascript [05:47:08] Not saying it's the fault, but it's not helping [05:47:32] User:Xenocidic/statusChanger2.js [05:47:54] Somewhere in the chain you're loading a script from Pathoschild on meta explicitly via http [05:48:03] yes. [05:48:54] no not Pathoschild's [05:49:12] I have imported 6 scripts from meta. [05:49:18] Yes Pathoscilds [05:49:20] Bah [05:49:27] It's in one of your screenshots [05:49:40] Maybe not directly, but indirectly you are [05:50:11] Right in the middle of the 2nd image [05:50:23] You should fix your vector.js file first [05:51:10] that's pssible. But what'll I do there? [05:51:52] !logs [05:51:52] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [05:52:04] https://en.wikipedia.org/w/index.php?title=User:Pratyya_Ghosh/vector.js&action=history [05:52:05] 5 months ago [05:52:31] https://en.wikipedia.org/w/index.php?title=User%3APratyya_Ghosh%2Fvector.js&diff=582634100&oldid=558595253 [05:52:33] For starters [05:54:40] okay. thanks for removing them. Now? [05:55:25] Firefox / Safari: Hold Shift while clicking Reload, or press either Ctrl-F5 or Ctrl-R (⌘-R on a Mac) [05:56:33] done... [05:56:37] now? [05:58:04] Not a bad time to check if hotcat works now [05:58:42] That was the only obvious error according to the console [05:58:56] Reedy: Thank you very much. very much. :-) [05:59:01] It's wroking. [05:59:08] I mean working* [06:00:04] No problem [06:02:13] Reedy: you may wanna see https://en.wikipedia.org/wiki/User_talk:Reedy#A_barnstar_for_you.21 [06:02:59] Pratyya: Aha! [06:03:08] We have a notification system for things like this ;) [06:03:11] But thanks :) [06:03:29] I know that :P But I wanted to let you know.. ;-) [06:03:54] Reedy: I thanked™ you. [06:05:37] It's after 6 am [06:05:39] Bedtime! [06:11:15] (03CR) 10Mattflaschen: "See inline; the whole comment is actually out of date (even before this commit)." (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 (owner: 10Phuedx) [06:12:11] (03CR) 10Mattflaschen: [C: 04-1] "Thanks. However, I should have been clearer on the bug. The title of the bug was misleading. Per the description, we don't need the get" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 (owner: 10Phuedx) [06:44:09] (03PS5) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [06:44:45] (03PS6) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [07:22:18] (03PS3) 10IAlex: Enhance the destination control parameter of wfDebug() and wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/95356 [07:37:08] Hi guys, need some help on this question: http://stackoverflow.com/questions/20114343/any-way-to-get-a-hold-of-a-properly-initialized-wiki-parser-in-the-ajax-hook-of [07:40:06] (03PS7) 10IAlex: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 [07:48:18] (03CR) 10Parent5446: Update Special:ChangePassword to use HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [07:49:40] (03PS1) 10Jack Phoenix: New getTemplateHTML() method for OutputPage. [core] - 10https://gerrit.wikimedia.org/r/96703 [07:50:56] (03PS1) 10IAlex: Fix HTML output arround HTMLForm's submit buttons when in vform [core] - 10https://gerrit.wikimedia.org/r/96704 [07:54:01] (03PS6) 10Mwalker: Fix jshint errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [07:54:32] (03CR) 10Mwalker: "I agree with Cscott on leaving in the function arguments; so I wiggled the patch to allow that." [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [07:55:54] (03CR) 10Mwalker: [C: 032] Fix jshint errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [07:56:59] (03CR) 10Ori.livneh: "devunt, what breakage are you seeing, exactly?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96482 (owner: 10devunt) [08:00:42] (03CR) 10devunt: "Please see line 278, 286, 360, 443, 531, 552, 646, 918, 1130, 1267, 1354, 1364 in modules/jquery.wikiEditor.iframe.js" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96482 (owner: 10devunt) [08:04:21] (03PS1) 10Mwalker: Updating dependencies [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96705 [08:04:46] (03CR) 10Mwalker: [C: 032] Updating dependencies [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96705 (owner: 10Mwalker) [08:05:12] (03CR) 10Mwalker: [V: 032] Updating dependencies [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96705 (owner: 10Mwalker) [08:05:51] static html dumps are a wikimedia extension and nothing to do with the regular dumps, Elsie [08:05:54] https://www.mediawiki.org/wiki/Extension:DumpHTML [08:06:04] tah [08:06:16] apergos: Thanks. :-) [08:06:22] yw [08:06:27] I eventually found it. I was trying to find the original author. [08:06:34] The extension came from core, so it took a bit of detective work. [08:06:44] the ones we have available were done from the maintenance script [08:06:51] It used to be maintenance/dumpHTML.php, yeah. [08:06:54] yeah, not me at all [08:06:58] Indeed! [08:07:23] (03CR) 10devunt: "Example:" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96482 (owner: 10devunt) [08:08:38] The lack of a full timestamp in SAL entries is annoying. [08:08:42] The year is missing. :-( [08:10:16] (03CR) 10IAlex: Update Special:ChangePassword to use HTMLForm (032 comments) [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [08:10:44] (03PS1) 10Mwalker: Apparently missed sqlite [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96706 [08:11:12] (03CR) 10Mwalker: [C: 032 V: 032] Apparently missed sqlite [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96706 (owner: 10Mwalker) [08:13:54] (03CR) 10Parent5446: Update Special:ChangePassword to use HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [08:14:13] (03PS1) 10Mwalker: Everything nice and shiny for test deployment [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96707 [08:14:29] (03CR) 10Mwalker: [C: 032 V: 032] Everything nice and shiny for test deployment [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96707 (owner: 10Mwalker) [08:14:46] (03CR) 10Parent5446: [C: 04-1] "This belongs more in the QuickTemplate class itself rather than in OutputPage." [core] - 10https://gerrit.wikimedia.org/r/96703 (owner: 10Jack Phoenix) [08:18:38] I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=57343 about SAL. [08:20:29] Elsie: GO TO BED [08:20:34] (03PS1) 10Cscott: Revert "Check out OCG/node_modules as a git submodule." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96708 [08:20:47] ori-l: go to bed? [08:20:56] YuviPanda: ! [08:20:59] how did your exams go? [08:21:11] (03CR) 10Cscott: [C: 032 V: 032] Revert "Check out OCG/node_modules as a git submodule." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96708 (owner: 10Cscott) [08:21:15] ori-l: should pass, though it took me a couple of days to get my hands usable again :) [08:21:27] ow [08:21:35] wrong smiley there [08:21:42] in usable shape now tho [08:21:44] I think [08:21:57] (03CR) 10Cscott: [C: 032] Generate the nfo.json file from metabook.json. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96694 (owner: 10Cscott) [08:22:09] (03Merged) 10jenkins-bot: Generate the nfo.json file from metabook.json. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96694 (owner: 10Cscott) [08:22:27] ori-l: ikr [08:22:37] https://wikitech.wikimedia.org/wiki/DumpHTML [08:22:42] (03CR) 10Cscott: [C: 032 V: 032] Add --debug option to CLI. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96695 (owner: 10Cscott) [08:23:12] Elsie: krinkle mentioned https://www.mediawiki.org/wiki/Extension:ServerAdminLog [08:23:22] dunno if it's any good or why we're not using it [08:23:30] Mentioned where? [08:23:44] in a PM [08:23:58] i'm a very important person, don't you know [08:24:22] I'm more important. [08:24:26] probably [08:26:24] MaxSem: did you fix something? http://ganglia.wikimedia.org/latest/graph.php?r=month&z=xlarge&hreg[]=client-side&mreg[]=%5Ebrowser.redirecting.%28desktop%7Cmobile%29_median%24>ype=line&title=Redirecting%3A+redirectStart+to+redirectEnd&aggregate=1 [08:26:24] (03PS1) 10Cscott: Add --verbose option to CLI. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96710 [08:26:25] (03PS1) 10Cscott: Node 0.8 compatibility. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96711 [08:26:26] (03PS1) 10Cscott: Add travis test runner; update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96712 [08:27:11] (03PS1) 10Cscott: Add travis test runner; add test case; update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96713 [08:27:22] ori-l, I didn't. however Faidon reduced the load on mobile cluster [08:28:17] (03CR) 10Cscott: [C: 032] Node 0.8 compatibility. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96711 (owner: 10Cscott) [08:28:34] (03CR) 10Cscott: [C: 032] Add --verbose option to CLI. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96710 (owner: 10Cscott) [08:30:35] (03CR) 10Cscott: [C: 032] Add travis test runner; update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96712 (owner: 10Cscott) [08:31:14] (03CR) 10Cscott: [C: 032] Add travis test runner; add test case; update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96713 (owner: 10Cscott) [08:31:16] (03Merged) 10jenkins-bot: Add travis test runner; add test case; update dependencies. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96713 (owner: 10Cscott) [08:36:14] (03CR) 10Mattflaschen: "Yeah, I'm going to have to rebase it (in progress). It's partly fixed by the new postWithToken abstraction (e.g. that doesn't even use err" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [08:36:33] (03CR) 10Spage: [C: 032] "Both tests pass for me with this on ee-flow.wmflabs.org , if I change Selenium_user's Preferences > Editing to not use Visual editor (whic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96151 (owner: 10Cmcmahon) [08:36:40] (03Merged) 10jenkins-bot: Remove references to VE in Flow tests, not supported now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96151 (owner: 10Cmcmahon) [08:38:00] (03CR) 10IAlex: Update Special:ChangePassword to use HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [09:02:42] (03PS1) 10Dan-nl: autoload-classes [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96715 [09:16:33] (03PS2) 10Scimonster: Move legend to static method, move inline styles to CSS sheet. [core] - 10https://gerrit.wikimedia.org/r/96584 [09:18:35] (03CR) 10Scimonster: "Is it alright that i just added the CSS to an existing stylesheet?" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [09:49:41] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/96721 [09:51:42] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/96721 (owner: 10Siebrand) [09:51:56] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/96722 [09:52:00] (03PS1) 10Mwalker: Adding in the render pipeline [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96723 [09:52:28] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/96722 (owner: 10Siebrand) [09:52:30] (03CR) 10Mwalker: [C: 032] Adding in the render pipeline [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96723 (owner: 10Mwalker) [09:54:28] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96724 [09:56:13] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96724 (owner: 10Siebrand) [09:56:31] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96725 [09:56:44] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/96721 (owner: 10Siebrand) [09:57:16] (03Merged) 10jenkins-bot: Adding in the render pipeline [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96723 (owner: 10Mwalker) [10:02:15] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96725 (owner: 10Siebrand) [10:02:19] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/96722 (owner: 10Siebrand) [10:05:34] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96724 (owner: 10Siebrand) [10:07:48] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96725 (owner: 10Siebrand) [10:17:13] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96730 [10:19:16] (03CR) 10Springle: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [10:26:06] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96730 (owner: 10Siebrand) [10:29:11] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96730 (owner: 10Siebrand) [10:37:43] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96735 [10:40:03] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96735 (owner: 10Siebrand) [10:42:32] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96735 (owner: 10Siebrand) [10:51:28] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96739 [10:55:22] (03PS1) 10Shirayuki: Fix grammar of "needs to be at least contain" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96741 [10:56:18] (03CR) 10Siebrand: "Grammar issues in message?" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [11:03:59] (03CR) 10TTO: "> to sensibly and reliably do this" [core] - 10https://gerrit.wikimedia.org/r/92263 (owner: 10TTO) [11:07:27] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96739 (owner: 10Siebrand) [11:08:46] (03CR) 10Siebrand: [C: 032] Fix grammar of "needs to be at least contain" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96741 (owner: 10Shirayuki) [11:09:34] (03Merged) 10jenkins-bot: Fix grammar of "needs to be at least contain" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96741 (owner: 10Shirayuki) [11:09:49] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96739 (owner: 10Siebrand) [11:19:39] (03CR) 10Siebrand: [C: 032] i18n: use "int:" for consistency [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96471 (owner: 10Shirayuki) [11:19:48] (03Merged) 10jenkins-bot: i18n: use "int:" for consistency [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96471 (owner: 10Shirayuki) [11:19:56] (03CR) 10Siebrand: [C: 032 V: 032] i18n: use "int:" for consistency [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/96467 (owner: 10Shirayuki) [11:20:13] (03CR) 10Siebrand: [C: 032] i18n: use "int:" for consistency [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96462 (owner: 10Shirayuki) [11:20:20] (03Merged) 10jenkins-bot: i18n: use "int:" for consistency [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96462 (owner: 10Shirayuki) [11:23:00] (03PS1) 10Siebrand: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96743 [11:26:01] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96743 (owner: 10Siebrand) [11:28:18] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96743 (owner: 10Siebrand) [11:35:14] (03CR) 10Siebrand: [C: 04-1] "Please add message documentation to MessagesQqq.php and register the new keys in maintenance/languages/messages.inc when adding new messag" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [11:40:08] (03PS2) 10Jack Phoenix: New getHTML() method for QuickTemplate to get the HTML of a template. [core] - 10https://gerrit.wikimedia.org/r/96703 [11:41:45] (03CR) 10Siebrand: "Up to how many jobs may be created in one request? In TranslationNotifications we're running into time outs because there are many (1500 o" (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [11:45:44] (03CR) 10Nikerabbit: Move legend to static method, move inline styles to CSS sheet. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [11:52:32] (03CR) 10Theopolisme: Mention: notify correctly if there is no section title (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [11:54:55] hi Nikerabbit, around? [11:55:53] Nikerabbit: wanna take a look at https://gerrit.wikimedia.org/r/#/c/96652/ ? i18n gci patch [11:56:12] (03PS3) 10Theopolisme: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 [11:57:07] MatmaRex: why is the link to gitblit broken? [11:58:10] Nemo_bis: no idea. probably because gerrit sucks [11:58:18] Nemo_bis: there was some talk yesterday about replication, eh [11:59:35] I'll wait for it to appear, such diffs break my browser in gerrit [12:01:01] Nemo_bis: heh [12:01:06] Nemo_bis: the replication looks broken [12:01:13] Nemo_bis: here's a `git diff` for you: http://i.imgur.com/sHS7ohM.png [12:06:09] MatmaRex: looks wrong [12:06:40] there should be special case for 999, not for 1 [12:07:25] Nikerabbit: heh, i think you previously suggested special-casing 1 [12:07:43] anyway, i'd appreciate if you could review that :) [12:08:31] (03CR) 10Dan-nl: "when the user presses the “process batch” button the extension creates one UploadMetadataJob. that job runs in the background and creates " [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [12:08:53] MatmaRex: I would imagine the translation would be just normal plural with 999=lots of messages at the end [12:09:06] some forms are likely to go unused but less confusing that way if things ever change [12:09:29] maybe I did recommend something else [12:10:25] {{1=foo|other}} might work as well but then translators should be told to only have two forms [12:22:21] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Quoting Krinkle above: "Star hack also applies to IE7.". I'm pretty sure you want the underscore hack." [core] - 10https://gerrit.wikimedia.org/r/94163 (owner: 10Jdlrobson) [12:23:00] (03CR) 10Bartosz Dziewoński: "I'll merge this and dependent patch both at once when they're ready." [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [12:23:38] (03CR) 10Bartosz Dziewoński: [C: 031] New getHTML() method for QuickTemplate to get the HTML of a template. [core] - 10https://gerrit.wikimedia.org/r/96703 (owner: 10Jack Phoenix) [12:29:08] (03CR) 10Hoo man: "Works like a charm, one question arose, though (see inline comment)" (031 comment) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/87546 (owner: 10Stwalkerster) [12:31:46] (03CR) 10Bartosz Dziewoński: Move legend to static method, move inline styles to CSS sheet. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [12:32:22] (03CR) 10Hoo man: [C: 04-1] Add a bit of output to makeSimpleList.php (031 comment) [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/96374 (owner: 10Reedy) [12:33:07] (03CR) 10Bartosz Dziewoński: "> Is it alright that i just added the CSS to an existing stylesheet?" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [12:35:30] (03CR) 10Bartosz Dziewoński: "Hmmmmm, actually. mediawiki.special.changeslist is only loaded when the changes list contains any entries; it is possible for it to be emp" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [12:41:26] (03CR) 10Nikerabbit: Localisation updates from https://translatewiki.net. (031 comment) [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96735 (owner: 10Siebrand) [12:44:24] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I like this solution, but I'm afraid it's too simplistic :) EchoCommentFormatter can technically be used to format other notification type" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [12:48:13] Nikerabbit: siebrand: Nemo_bis: so, i'd really like somebody with the know-how to comment on https://gerrit.wikimedia.org/r/#/c/96652/ , i hate these funny PLURAL: syntaxes [12:50:01] (03PS6) 10Tpt: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 [12:51:38] (03CR) 10Tpt: "Don't add the maintenance script if $wgContentHandlerUseDB = false" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [12:52:23] (03Abandoned) 10Tpt: new branch for parsing test [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/95869 (owner: 10Lyumn) [12:54:58] (03CR) 10Nikerabbit: [C: 032] "If I ignore the fact that the function is 200 lines long, this looks good." [core] - 10https://gerrit.wikimedia.org/r/96546 (owner: 10Umherirrender) [12:58:00] (03PS1) 10Zfilipin: IRC notification is enabled only for #wikimedia-qa channel [selenium] - 10https://gerrit.wikimedia.org/r/96752 [12:58:23] (03Merged) 10jenkins-bot: Truncate protect reason for whole multibyte characters [core] - 10https://gerrit.wikimedia.org/r/96546 (owner: 10Umherirrender) [13:01:53] (03CR) 10Siebrand: input-field-size (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [13:03:25] (03CR) 10Siebrand: "All latest versions of MessagesEn.php should be consistent now." [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96735 (owner: 10Siebrand) [13:14:12] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/96753 (owner: 10L10n-bot) [13:14:18] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/96755 (owner: 10L10n-bot) [13:14:21] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96756 (owner: 10L10n-bot) [13:14:24] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96757 (owner: 10L10n-bot) [13:14:40] (03PS7) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [13:15:04] (03PS8) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [13:15:18] (03CR) 10Dan-nl: "addressing siebrand’s inline comments:" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [13:17:05] (03CR) 10Rtdwivedi: [C: 031] Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [13:18:26] (03CR) 10Tpt: [C: 032] "I ignore the performance issue as the script won't run on Wikimedia cluster (that is the only big user of Proofread Page)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [13:18:42] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/96753 (owner: 10L10n-bot) [13:20:55] (03Merged) 10jenkins-bot: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [13:21:45] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/96755 (owner: 10L10n-bot) [13:22:40] (03CR) 10Theopolisme: "Hmm, are you sure? In looking at the source now it's only used for mention notifications." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [13:23:29] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/96756 (owner: 10L10n-bot) [13:24:26] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/96757 (owner: 10L10n-bot) [13:24:45] (03CR) 10Siebrand: [C: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/96760 (owner: 10L10n-bot) [13:26:27] (03CR) 10Rtdwivedi: [C: 031] Include base module in mobile view [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/94921 (owner: 10Tpt) [13:29:35] base module! [13:30:52] (03CR) 10Tpt: [C: 032] "Reviewed by Aaarti" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92158 (owner: 10Tpt) [13:32:22] (03Merged) 10jenkins-bot: Improves EditPage code [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92158 (owner: 10Tpt) [13:32:53] (03CR) 10Tpt: "Reviewed by Aarti" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/94921 (owner: 10Tpt) [13:32:58] (03CR) 10Tpt: [C: 032] Include base module in mobile view [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/94921 (owner: 10Tpt) [13:33:07] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/96760 (owner: 10L10n-bot) [13:33:23] (03Merged) 10jenkins-bot: Include base module in mobile view [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/94921 (owner: 10Tpt) [13:33:56] hm I didn't get it, I thought MatmaRex had already had his answer [13:41:55] hashar: https://integration.wikimedia.org/zuul/ is showing a lot of "queued" npmtest jobs that don't seem to be being processed [13:43:07] :-(( [13:43:21] they are running on a dedicated slave, it might be dead [13:44:50] https://integration.wikimedia.org/ci/computer/integration-slave01/ [13:44:52] it is there [13:44:53] hmm [13:48:02] !jenkins mwext-Collection-OfflineContentGenerator-latex_renderer-npmtest [13:48:02] https://integration.wikimedia.org/ci/job/mwext-Collection-OfflineContentGenerator-latex_renderer-npmtest [13:50:06] anomie: ahh i know why [13:50:27] the job is made to use jslint first then npmtest [13:50:28] BUT [13:50:49] if you submit a change that is not altering javascript files, the jslint job is skipped [13:50:57] Zuul still keep the npmtest one around [13:51:09] but never trigger it because it depends on the jslint job (which has been skipped) [13:51:17] so I was wrong yesterday, got to launch them in parralel [13:51:20] soryr :-( [13:53:39] anomie: vvvv [13:53:41] (03PS1) 10Hashar: always trigger npmtest jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96762 [13:54:25] (03CR) 10Anomie: [C: 031] always trigger npmtest jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96762 (owner: 10Hashar) [13:54:35] sorry :-( [13:54:53] (03CR) 10Hashar: [C: 032] always trigger npmtest jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96762 (owner: 10Hashar) [13:55:02] (03Merged) 10jenkins-bot: always trigger npmtest jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96762 (owner: 10Hashar) [13:56:05] deployed [13:58:36] (03CR) 10Cscott: [V: 032] Add --verbose option to CLI. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96710 (owner: 10Cscott) [13:58:37] (03Merged) 10jenkins-bot: Node 0.8 compatibility. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96711 (owner: 10Cscott) [14:00:06] (03CR) 10Cscott: [V: 032] Add travis test runner; update dependencies. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96712 (owner: 10Cscott) [14:04:10] (03PS1) 10Tpt: Remove buttons to move in the image [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/96764 [14:04:38] (03CR) 10Siebrand: "Have you considered what happens to existing translations when the contents of parameters change?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96418 (owner: 10Werdna) [14:05:00] (03CR) 10Rtdwivedi: [C: 031] Improve page pages CSS and JavaScript [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/93154 (owner: 10Tpt) [14:05:01] (03CR) 10Tpt: [C: 032] Improve page pages CSS and JavaScript [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/93154 (owner: 10Tpt) [14:05:11] (03Merged) 10jenkins-bot: Improve page pages CSS and JavaScript [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/93154 (owner: 10Tpt) [14:10:18] (03CR) 10Cscott: [C: 031] API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [14:10:44] (03CR) 10Tpt: [C: 032] Remove buttons to move in the image [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/96764 (owner: 10Tpt) [14:10:54] (03Merged) 10jenkins-bot: Remove buttons to move in the image [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/96764 (owner: 10Tpt) [14:18:41] (03CR) 10Scimonster: "Perhaps that could be considered a bug that should be fixed by someone else. :)" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [14:20:18] (03PS1) 10Tpt: Merge pagePagesRefactoring branch [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/96765 [14:30:24] (03PS2) 10Tpt: Merge pagePagesRefactoring branch [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/96765 [14:37:42] (03CR) 10Cmcmahon: [C: 032] "notification to useful channel" [selenium] - 10https://gerrit.wikimedia.org/r/96752 (owner: 10Zfilipin) [14:46:10] (03CR) 10Anomie: "Change itself seems good. I happened to mention this to some others, though, and they made a case that if there is minimal cost to keeping" [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [14:55:55] (03CR) 10Nikerabbit: Move legend to static method, move inline styles to CSS sheet. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [14:58:53] (03CR) 10Scimonster: Move legend to static method, move inline styles to CSS sheet. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [15:02:24] (03PS3) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 [15:02:31] Reedy: could you look at https://gerrit.wikimedia.org/r/#/c/96161/ for merging? it's needed for Flow on beta labs, should not affect prod at all until Flow gets released officially. [15:12:31] (03PS2) 10Matthias Mullie: (bug 57162) red links don't work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 [15:28:42] (03CR) 10Chad: Silence false positive CodeSniffer error (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [15:30:25] (03PS5) 10Anomie: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 [15:30:36] (03PS6) 10Anomie: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 [15:38:19] (03CR) 10Anomie: "PS5: Rebase" [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [15:38:26] AaronSchulz: https://en.wikipedia.org/wiki/Spanner_(database) [15:39:40] (03PS1) 10Njw: Have messages line up with the rest of the content [skins/erudite] - 10https://gerrit.wikimedia.org/r/96772 [15:40:39] (03CR) 10Tpt: [C: 032] Merge pagePagesRefactoring branch [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/96765 (owner: 10Tpt) [15:40:47] (03Merged) 10jenkins-bot: Merge pagePagesRefactoring branch [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/96765 (owner: 10Tpt) [15:41:46] (03PS1) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [15:42:59] (03CR) 10jenkins-bot: [V: 04-1] jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [15:43:11] (03PS1) 10Njw: Make menu entries narrower and add line separator [skins/erudite] - 10https://gerrit.wikimedia.org/r/96774 [15:43:42] (03CR) 10Njw: [C: 032 V: 032] Have messages line up with the rest of the content [skins/erudite] - 10https://gerrit.wikimedia.org/r/96772 (owner: 10Njw) [15:46:13] (03CR) 10Njw: [C: 032 V: 032] Make menu entries narrower and add line separator [skins/erudite] - 10https://gerrit.wikimedia.org/r/96774 (owner: 10Njw) [15:46:17] areke: the removal of > breaks nested tables [15:48:08] (03CR) 10Nikerabbit: Fix double-username issue on RecentChanges items. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96418 (owner: 10Werdna) [15:49:29] (03PS1) 10Cscott: Factor out new 'P' module with promise-related helper code. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96775 [15:49:30] (03PS1) 10Cscott: Convert SVGs to PDFs with inkscape, and include them in the output. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96776 [15:49:31] (03PS1) 10Cscott: Add workaround for RGBA SVGs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96777 [15:50:40] (03CR) 10Nikerabbit: Fix sitename use in section description (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 (owner: 10MarkTraceur) [15:51:29] (03PS2) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [15:52:44] (03CR) 10jenkins-bot: [V: 04-1] jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [16:00:19] (03PS3) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [16:01:39] (03CR) 10jenkins-bot: [V: 04-1] jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [16:03:18] (03CR) 10Aklapper: [C: 04-1] "Thanks! Could you replace "Warning:" by "Note:" (sounds less dramatic), a fullstop at the end of the sentence "Patches should go on Gerrit" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96684 (owner: 10Tholam) [16:14:59] (03CR) 10MarkTraceur: "Bah. There are ever i18n bugs." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 (owner: 10MarkTraceur) [16:19:35] (03PS1) 10Reedy: Add VectorBeta [tools/release] - 10https://gerrit.wikimedia.org/r/96778 [16:20:46] (03CR) 10Reedy: [C: 032] Add VectorBeta [tools/release] - 10https://gerrit.wikimedia.org/r/96778 (owner: 10Reedy) [16:20:49] (03Merged) 10jenkins-bot: Add VectorBeta [tools/release] - 10https://gerrit.wikimedia.org/r/96778 (owner: 10Reedy) [16:21:03] (03PS1) 10Reedy: Update Wikibase branch points [tools/release] - 10https://gerrit.wikimedia.org/r/96779 [16:21:33] (03PS2) 10Reedy: Update Wikibase branch points [tools/release] - 10https://gerrit.wikimedia.org/r/96779 [16:22:50] (03CR) 10Reedy: [C: 032] Update Wikibase branch points [tools/release] - 10https://gerrit.wikimedia.org/r/96779 (owner: 10Reedy) [16:22:52] (03Merged) 10jenkins-bot: Update Wikibase branch points [tools/release] - 10https://gerrit.wikimedia.org/r/96779 (owner: 10Reedy) [16:22:53] (03PS3) 10Matthias Mullie: (bug 57162) red links don't work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 [16:23:03] (03CR) 10Siebrand: Silence false positive CodeSniffer error (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [16:26:50] (03PS1) 10Cscott: Improve DL list rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96781 [16:35:50] (03PS2) 10Cscott: Factor out new 'P' module with promise-related helper code. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96775 [16:35:51] (03PS2) 10Cscott: Convert SVGs to PDFs with inkscape, and include them in the output. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96776 [16:35:52] (03PS2) 10Cscott: Add workaround for RGBA SVGs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96777 [16:35:53] (03PS2) 10Cscott: Improve DL list rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96781 [16:35:54] (03PS1) 10Cscott: De-lint mocha test suite. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96784 [16:36:28] (03CR) 10Pginer: [C: 04-1] "Thanks for your commit." [core] - 10https://gerrit.wikimedia.org/r/96372 (owner: 10M4tx) [16:37:10] (03PS1) 10Cscott: De-lint test suite. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96785 [16:38:23] (03CR) 10Siebrand: [C: 04-1] "Please register the new keys in maintenance/languages/messages.inc when adding new messages to core." [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [16:38:55] (03CR) 10Cscott: [C: 032] De-lint mocha test suite. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96784 (owner: 10Cscott) [16:39:12] (03Merged) 10jenkins-bot: De-lint mocha test suite. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96784 (owner: 10Cscott) [16:39:36] (03CR) 10Cscott: [C: 032] De-lint test suite. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96785 (owner: 10Cscott) [16:39:40] (03PS3) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96441 (owner: 10Siebrand) [16:39:45] (03CR) 10Chad: [C: 032] Update formatting on database-related classes [core] - 10https://gerrit.wikimedia.org/r/96441 (owner: 10Siebrand) [16:40:27] (03Merged) 10jenkins-bot: De-lint test suite. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96785 (owner: 10Cscott) [16:43:43] (03PS2) 10Chad: Break long lines and formatting updates for includes/db/ [core] - 10https://gerrit.wikimedia.org/r/96454 (owner: 10Siebrand) [16:43:47] (03CR) 10Chad: [C: 032] Break long lines and formatting updates for includes/db/ [core] - 10https://gerrit.wikimedia.org/r/96454 (owner: 10Siebrand) [16:44:34] (03CR) 10Chad: Suppress false positive CodeSniffer warning (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [16:45:10] (03Merged) 10jenkins-bot: Update formatting on database-related classes [core] - 10https://gerrit.wikimedia.org/r/96441 (owner: 10Siebrand) [16:45:14] (03CR) 10Siebrand: "It spews warnings and has been marked deprecated for a long time. Legacy code is a maintenance nightmare. Keeping deprecated code around m" [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [16:46:17] (03CR) 10Chad: "This is also just a comment change, so can land easily either way as soon as the core change lands." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 (owner: 10Siebrand) [16:46:50] (03CR) 10Siebrand: Suppress false positive CodeSniffer warning (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [16:46:57] (03PS1) 10Cscott: Add 'readable-stream' package for Node 0.8 compatibility. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96786 [16:46:58] (03PS1) 10Cscott: Add sqlite3 binding compiled for node 0.8.26. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96787 [16:47:17] (03CR) 10Cscott: [C: 032 V: 032] Add 'readable-stream' package for Node 0.8 compatibility. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96786 (owner: 10Cscott) [16:47:29] (03CR) 10Cscott: [C: 032 V: 032] Add sqlite3 binding compiled for node 0.8.26. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96787 (owner: 10Cscott) [16:48:07] (03CR) 10Cscott: [C: 032] Factor out new 'P' module with promise-related helper code. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96775 (owner: 10Cscott) [16:48:19] (03CR) 10Cscott: [C: 032] Convert SVGs to PDFs with inkscape, and include them in the output. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96776 (owner: 10Cscott) [16:48:30] (03CR) 10Cscott: [C: 032] Add workaround for RGBA SVGs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96777 (owner: 10Cscott) [16:48:36] (03CR) 10Siebrand: "Sure. Just want to keep things clean and keep all merges in extensions off until you're ready to deploy them all at the same time (because" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 (owner: 10Siebrand) [16:48:39] (03CR) 10Cscott: [C: 032] Improve DL list rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96781 (owner: 10Cscott) [16:48:49] (03Merged) 10jenkins-bot: Break long lines and formatting updates for includes/db/ [core] - 10https://gerrit.wikimedia.org/r/96454 (owner: 10Siebrand) [16:49:31] (03CR) 10Chad: "So I think the easiest way to land this is to break each of the renames into its own change." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [16:49:38] (03Merged) 10jenkins-bot: Factor out new 'P' module with promise-related helper code. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96775 (owner: 10Cscott) [16:49:52] (03Merged) 10jenkins-bot: Convert SVGs to PDFs with inkscape, and include them in the output. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96776 (owner: 10Cscott) [16:50:29] (03Merged) 10jenkins-bot: Add workaround for RGBA SVGs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96777 (owner: 10Cscott) [16:50:31] (03Merged) 10jenkins-bot: Improve DL list rendering. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96781 (owner: 10Cscott) [16:51:01] (03CR) 10Siebrand: "k. Will split and rebase." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [16:51:12] (03PS3) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [16:52:02] (03CR) 10Anomie: ""It spews warnings" meaning that it has a wfDeprecated call? Or are there actual warnings?" [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [16:52:53] (03CR) 10Siebrand: "Yes, it has this line of code:" [core] - 10https://gerrit.wikimedia.org/r/96364 (owner: 10Siebrand) [16:54:34] (03CR) 10Chad: [C: 032] Suppress false positive CodeSniffer warning (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [16:54:35] (03CR) 10Liangent: "I'm curious why it isn't {{PLURAL:$1|one message|999=messages}}. I guess this better signifies the special value 999." [core] - 10https://gerrit.wikimedia.org/r/96652 (owner: 10MegaAlex) [16:54:38] (03PS2) 10Chad: Suppress false positive CodeSniffer warning [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [16:54:43] (03CR) 10Chad: [C: 032] Suppress false positive CodeSniffer warning [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [16:57:22] (03PS1) 10Anomie: Fix another jshint warning [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96788 [16:57:36] (03CR) 10Anomie: [C: 032] Fix another jshint warning [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96788 (owner: 10Anomie) [16:59:58] (03Merged) 10jenkins-bot: Fix another jshint warning [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96788 (owner: 10Anomie) [17:00:29] (03Merged) 10jenkins-bot: Suppress false positive CodeSniffer warning [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [17:01:34] (03PS1) 10Anomie: Make jshint voting for Collection OCG repos [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96789 [17:06:00] (03PS4) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [17:06:19] (03CR) 10Pginer: [C: 031] Adding HiDPI 'Heart' SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 (owner: 10Sniok) [17:06:34] (03CR) 10Umherirrender: Update formatting for includes/diff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96554 (owner: 10Siebrand) [17:07:19] Hello any Kiwix devs here ??? [17:07:40] hi sakysharma, i recommend the #kiwix channel :) [17:07:51] Ok thanks [17:08:15] (03CR) 10jenkins-bot: [V: 04-1] jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [17:09:23] (03CR) 10Chad: [C: 032] Make jshint voting for Collection OCG repos [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96789 (owner: 10Anomie) [17:09:29] (03Merged) 10jenkins-bot: Make jshint voting for Collection OCG repos [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96789 (owner: 10Anomie) [17:10:15] (03CR) 10Scimonster: "Yeah, sorry. I remembered after that, but i find it much harder to use gerrit than GitHub." [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [17:10:41] (03PS5) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [17:12:24] (03CR) 10Aaron Schulz: "Can you just use "/" instead of DIRECTORY_SEPARATOR like AutoLoader.php does?" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96715 (owner: 10Dan-nl) [17:19:22] (03CR) 10Umherirrender: "There are 5 places where 'for\s*\(\s+;' matched in php files, more than 40 when scanning javascript. It is also possible to refactor to a " [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [17:20:42] (03PS2) 10Anomie: Test (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96530 [17:21:34] (03PS2) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96509 [17:21:43] (03PS6) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 (owner: 10Hashar) [17:22:19] (03CR) 10Siebrand: "I had a chat with Chad on IRC. I argued that all these classes are so interconnected that it makes little sense to make the changes in sep" [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [17:23:32] (03PS3) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96509 [17:24:03] (03PS3) 10Anomie: Test (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96530 [17:24:20] (03CR) 10Umherirrender: "Patch Set 2: Rebased and fixed a new place" [core] - 10https://gerrit.wikimedia.org/r/96509 (owner: 10Umherirrender) [17:25:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Niklas mentioned it on IRC when I asked him about that. I have no opinion myself, but if you two agree, then I'd rather go with that solut" [core] - 10https://gerrit.wikimedia.org/r/96652 (owner: 10MegaAlex) [17:26:18] (03PS4) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 [17:27:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Please add a simple unit test to /tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js , similar to the existing ones for ta" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [17:30:25] (03CR) 10Bartosz Dziewoński: "Also, this seems to change existing behavior. Please ensure that it is not changed. See the test cases at https://test.wikipedia.org/wiki/" [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [17:34:51] guillom, I would liketo ask you something. [17:37:43] Is gulliom away ? [17:39:59] guillom: please contact me when you are back, I have some questions regarding a task. [17:41:29] vandrew: you can just ask questions here, you know :) [17:43:09] MatmaRex: regarding the discovery report is there any problem if I write about my experience with Mediawiki software ? [17:43:56] (03CR) 10PleaseStand: [C: 04-1] "If you make a change that breaks compatibility with old config files, you must add a release note." [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [17:45:06] (03CR) 10Siebrand: "Tyler: A lot more class name changes are expected in the next few weeks. I'll be adding release notes in a separate commit, because adding" [core] - 10https://gerrit.wikimedia.org/r/96469 (owner: 10Siebrand) [17:45:22] vandrew: ah, well, okay, that might be actually the kind of question you should ask guillom himself :) sorry, i don't know. [17:46:07] MatmaRex: is he away ? [17:46:57] vandrew: apparently. your irc client might be able to show more information about any other user [17:47:11] guillom has been idle for almost 5 hours now (not talking) [17:47:18] is there a "red/blue" link cache shared between php instances? I know about LinkCache, but thats internal to the process. Basically i'm wondering if i build up a list of titles that i want to check, can they be pulled from an updated cache or is a select on the revisions table the only way? [17:53:18] (03PS2) 10Dan-nl: autoload-classes [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96715 [17:54:06] (03CR) 10Dan-nl: "- used "/" instead of DIRECTORY_SEPARATOR" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96715 (owner: 10Dan-nl) [17:56:39] hi MatmaRex [17:57:14] ebernhardson: no idea, but i need you! [17:57:25] ebernhardson: can you comment on https://gerrit.wikimedia.org/r/#/c/96656/ ? (a GCI patch to Echo) [17:57:27] hi mayankmadan [17:57:47] ebernhardson: see the latest two comments, if you can [17:58:17] MatmaRex: will look [17:59:18] MatmaRex: Im confused about something with organizations like wikimedia [17:59:21] MatmaRex: well, on first look without thinking about it, it does worry me that CommentFormatter is choosing its own messages [17:59:32] MatmaRex: but have to look closer :) [18:00:16] mayankmadan: yeah? [18:00:21] ebernhardson: thanks [18:00:25] People who volunteer themselves have a job of their own right? [18:01:04] (03CR) 10Bartosz Dziewoński: "I'm not very sure myself, I only made some small changes to this extension. I asked some of the original Echo devs to comment :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [18:01:18] mayankmadan: i don't understand? [18:01:36] mayankmadan: some of the people working on MediaWiki are regular paid employees of the Wikimedia Foundation [18:01:47] mayankmadan: some are volunteers [18:02:14] the first kind of people usually does things outlined by their managers (at least during their paid time), the second kind does whatever they wish ;) [18:04:03] MatmaRex: But how does mediawiki pay people? They dont charge for their services [18:04:07] !logs [18:04:08] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [18:05:24] mayankmadan: mediawiki is the software; wikimedia foundation is the thing that pays people [18:05:31] mayankmadan: they mostly get funds from donations [18:05:44] or rather, entirely, i think [18:06:20] we sell lemonade and girl scout cookies too [18:06:40] (just kidding.) [18:07:08] * YuviPanda checks shop.wikimedia.org [18:07:24] ori-l: just out of curiosity, what are girl scout cookies? [18:08:18] https://en.wikipedia.org/wiki/Girl_Scout_Cookies :) [18:09:45] MatmaRex, ori-l: thank you for the info that you guys provided :) i was always confused about how these things work [18:12:06] <^d> mayankmadan_: https://www.mediawiki.org/wiki/Differences_between_Wikipedia,_Wikimedia,_MediaWiki,_and_wiki tries to explain all the differences on one page :) [18:12:49] o hi ^d [18:12:57] * ^d hides [18:13:03] ^d: why is gitblit replication broken? :( [18:13:13] he's hiding [18:13:19] he can't hear you! [18:13:23] for basically any patchset submitted today, e.g. https://gerrit.wikimedia.org/r/#/c/96584/ [18:13:49] <^d> It's broken for mediawiki/core. [18:13:53] YuviPanda: you can't not hear the sound of broken replication! [18:13:55] <^d> Only. [18:13:59] heh. [18:14:06] so only, like, 95% of all patches, then? that's cool [18:14:08] <^d> replication was generally broken. [18:14:12] heh. [18:14:13] <^d> but I fixed it. [18:14:17] nice. [18:14:41] <^d> I guess I should fix core. [18:14:55] that would be nice of you to do. [18:14:56] :D [18:15:31] <^d> Missing unknown 6d9cb7966a085fc2c275694d12820b53f382e631 [18:15:43] <^d> Which is a draft, heh. [18:15:46] <^d> I hate drafts. [18:15:56] (03PS1) 10Umherirrender: Always select ipb_deleted on list=[all]users [core] - 10https://gerrit.wikimedia.org/r/96794 [18:16:29] (03PS1) 10Cscott: Add sqlite3 binding compiled for node 0.8.26 *on x64*. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96795 [18:16:53] heh [18:17:24] heh, it's my draft. [18:17:28] <^d> Yep. [18:17:34] <^d> ALL YOUR FAULT! [18:17:36] it's also probably deleted in gerrit. [18:17:44] <^d> Yep, it's deleted on gerrit. [18:17:49] <^d> But exists on clones. [18:17:53] silly gerrit. [18:17:56] <^d> Yep. [18:18:09] <^d> Hmm, easiest way to fix... [18:18:25] (03PS2) 10PleaseStand: Update comment in DefaultSettings for bug 17180 [core] - 10https://gerrit.wikimedia.org/r/96692 (owner: 10Persia) [18:18:45] <^d> Do you happen to know what patch set 1-7 it was? [18:18:56] of what? [18:19:04] <^d> Of https://gerrit.wikimedia.org/r/#/c/90729/ [18:19:39] well, some patches i guess. i don't have any pointers to them locally, but they probably still exist in my repo [18:19:57] <^d> Lemme see, I might be able to find out. [18:19:59] i could grep the reflog, if you want me to [18:20:13] but i tend to create and delete and rebase lots of branches when doing things [18:20:50] <^d> refs/changes/29/90729/4 [18:20:50] (03CR) 10PleaseStand: [C: 031] "Corrected a couple typos in the commit message ("$wgShipIPinHeader was adjustd")." [core] - 10https://gerrit.wikimedia.org/r/96692 (owner: 10Persia) [18:21:19] (03CR) 10Cscott: [C: 032 V: 032] Add sqlite3 binding compiled for node 0.8.26 *on x64*. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96795 (owner: 10Cscott) [18:21:30] ^d: are you trying to restore those? or what? [18:21:56] ^d: does submitting drafts and deleting them cause issues? because i did that a few times with some other changesets [18:22:10] <^d> Yeah, I think it can make replication go a little funky. [18:22:15] (the changesets themselves ended up axed too) [18:22:17] heh [18:22:26] okay, i won't do that anymore, i promise [18:22:35] Is there an array or other structure that loads the inbuilt special pages anywhere? [18:22:55] UltrasonicNXT: do you mean [[special:specialpages]]? [18:23:18] UltrasonicNXT: or do you mean some "registry" of special pages in core? that definitely exists somewhere [18:23:22] <^d> UltrasonicNXT: SpecialPageFactory::getList() [18:24:19] <^d> Speaking of... [18:24:38] MatmaRex: Should I change the syntax to {{PLURAL:$1|a|999=b}}? Is that what you agreed for? :) [18:24:51] MatmaRex: yes, though I think I've found it [18:24:59] (the registry) [18:25:02] that's4 for newmessages* [18:25:13] in SpecialPageFactory [18:25:43] MegaAlex: i guess. that turned out to be less crystal clear than i though, eh :) [18:26:28] Hello [18:28:07] (03PS4) 10Matthias Mullie: (bug 57162) red links don't work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 [18:28:19] (03PS1) 10Chad: Remove m prefixes from private variables [core] - 10https://gerrit.wikimedia.org/r/96797 [18:28:36] I create a method which takes URL as a parameter and is supposed to return File object if file is found, or somehow return "error" when file is not found (but URL is valid) or another "error" when even the URL is invalid. Within MediaWiki standards, what would be the best way to implement that method when it comes to returning those errors? Throwing an exception seems like an overkill especially that this i [18:28:37] s not an low level Exception (user is allowed to pass incorrect URL). [18:28:56] (03CR) 10Manybubbles: [C: 032 V: 032] "This is the simplest way I can think of to accomplish this. Great!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96665 (owner: 10Chad) [18:31:08] (03PS1) 10Siebrand: Replace inline tab with space [core] - 10https://gerrit.wikimedia.org/r/96798 [18:32:39] (03PS2) 10Bartosz Dziewoński: Replace inline tab with space [core] - 10https://gerrit.wikimedia.org/r/96798 (owner: 10Siebrand) [18:32:44] (03CR) 10Siebrand: Update formatting for includes/diff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96554 (owner: 10Siebrand) [18:32:54] MatmaRex: ty [18:33:08] (03CR) 10Bartosz Dziewoński: [C: 032] "I replaced an inline tab with space in your commit message :D" [core] - 10https://gerrit.wikimedia.org/r/96798 (owner: 10Siebrand) [18:33:23] MatmaRex: Dude, that was intentional! [18:33:25] (03Restored) 10Reedy: Commit of various wmf-branch live hacks [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy) [18:33:30] :P [18:33:34] (03PS3) 10Jdlrobson: Hygiene: Cleanup IE6 specific rules by using * hack [core] - 10https://gerrit.wikimedia.org/r/94163 [18:34:00] siebrand: btw, wanna weigh in on https://gerrit.wikimedia.org/r/96652 ? i'm fuzzy about the PLURAL: stuff [18:34:16] the weird PLURAL: stuff, i mean, not the normal one. :P [18:35:23] vandrew: I'm back, sorry; I was having dinner [18:35:43] MatmaRex: honestly? I think I've had it with the nonsense around that orange thing. I think I've explained my position on that thing somewhere else 6 months or so ago (in either gerrit or bugzilla). [18:35:46] vandrew: I've left a comment in Melange, but I'm around now for a bit if you want more information :) [18:36:46] MatmaRex: The logic is getting more an more complex there with little benefit. Just remove everything that has to do with numbers, replace it with "undefined number" wording and be done with it. [18:39:08] (03Merged) 10jenkins-bot: Replace inline tab with space [core] - 10https://gerrit.wikimedia.org/r/96798 (owner: 10Siebrand) [18:39:29] siebrand: that sounds like what i wanted to do last december, but you opposed [18:39:36] meh, nevermind. [18:40:07] MatmaRex: People can change their mind. Link to discussion? [18:41:01] siebrand: https://gerrit.wikimedia.org/r/#/c/38506/ was my previous patch [18:41:30] ^d: can you have another look at my timeout change (https://gerrit.wikimedia.org/r/#/c/96639/)? I'd like to get to work on moving the updates to the job queue but I don't think those changes would merge well. [18:42:03] <^d> Yeah, I had mostly finished reviewing it. [18:42:03] (MegaAle.x, if you're reading, this, please don't worry :) ) [18:42:03] (03PS12) 10Reedy: Commit of various wmf-branch live hacks [core] - 10https://gerrit.wikimedia.org/r/22466 [18:42:35] I've added to that registry, but no change, anyone know how to add core special pages? I can't find any docs on it. [18:42:49] <^d> manybubbles: You've got two fatals. Need to use $documents and use $ids in your two error() implementations. [18:42:59] MatmaRex: If I do a quick scan, that's mainly about the number of messages. I commented "This doesn't appear to make it better from where I stand. Possibly makes it worse, by making it even more obscure. Fake values are fine." [18:43:24] (03PS1) 10Reedy: Update live hack path commit [tools/release] - 10https://gerrit.wikimedia.org/r/96800 [18:43:34] MatmaRex: If there's a way to just say that the user's talk page was changes by a user other than themselves, I'd merge that :) [18:43:41] (03Abandoned) 10Reedy: Commit of various wmf-branch live hacks [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy) [18:43:51] (03CR) 10Reedy: [C: 032] Update live hack path commit [tools/release] - 10https://gerrit.wikimedia.org/r/96800 (owner: 10Reedy) [18:44:01] (03CR) 10Umherirrender: [C: 031] Add handler for GetLogTypesOnUser hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95097 (owner: 10Legoktm) [18:44:25] (03Merged) 10jenkins-bot: Update live hack path commit [tools/release] - 10https://gerrit.wikimedia.org/r/96800 (owner: 10Reedy) [18:44:28] siebrand: what we need is ParserFunctions in core messages :P [18:44:36] (03PS1) 10Aaron Schulz: Fixes to RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/96801 [18:44:39] siebrand: hmm, i actually don't see the comment you quoted, where was it? [18:44:59] MatmaRex: inline (MessagesEn.php) [18:45:09] ah [18:45:18] siebrand: anyway, i'm tired with that stuff too, let's do the current thing and forget it for a while [18:45:33] ("the current thing" being 2 → 999) [18:45:39] MatmaRex: with current you mean merge the proposed patch, or maintain status quo? [18:45:51] merge alex's GCI patch [18:45:59] https://gerrit.wikimedia.org/r/#/c/96652/ [18:46:17] MatmaRex: It will cause translations to be fuzzied and translator time to be consumed. [18:47:10] MatmaRex: I'm not going to block it (i.e sustain the bike shed). My recommendation would be to maintain the status quo and work towards a Facebook like personal messages notification icon next to the echo notifications icon. [18:47:30] MatmaRex: But i'm not a designer. I'm an ace at copying, though. [18:47:31] ;) [18:47:58] siebrand: i can come up with regex replacements to fix the translations :) i think you have some on-wiki tool for that? [18:48:06] or i could even run a bot if that'd be better [18:48:32] (03CR) 10Jdlrobson: [C: 04-1] "Rob code looks fine but it states WIP - is this still the case?" [core] - 10https://gerrit.wikimedia.org/r/93915 (owner: 10Robmoen) [18:48:48] siebrand: hmm, that sounds like a big rewrite ;) [18:48:55] MatmaRex: If you're staff (or whatever role) on twn, you can use Special:ReplaceText. Let me know what you need. You may want to let Raymond (not online right now) that you can help. [18:48:57] (03CR) 10Jdlrobson: WIP: Target mobile on ve dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/93915 (owner: 10Robmoen) [18:49:02] MatmaRex: Yes, not trivial. [18:49:06] siebrand: i'm just a translator on twn afaik [18:49:46] ([[user:Matma Rex]], and yeah, i get a permissions error when trying to access it) [18:51:17] MatmaRex: Not only a translator anymore. [18:51:36] MatmaRex: [18:51:37] https://translatewiki.net/w/i.php?title=Special:UserRights/Matma_Rex [18:51:38] (03PS4) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96509 [18:52:06] woot. [18:52:21] thanks [18:52:27] (03PS5) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96509 [18:52:42] <^d> manybubbles: See my ping a bit ago? Other than that you look good to go. [18:53:22] ^d: the one here? https://gerrit.wikimedia.org/r/#/c/96639/1/CirrusSearch.php [18:53:41] <^d> No, this: [18:53:57] <^d> 10:42 <^d> manybubbles: You've got two fatals. Need to use $documents and use $ids in your two error() implementations. [18:54:16] no, I didn't but I'll hunt it down [18:54:30] <^d> Should be a 2-line fix :) [18:55:16] (03CR) 10Umherirrender: "Sounds like a bug in phpcs, because making a method public is a valid use case in a object orientated language. The sniff should also use " [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [18:57:33] (03PS3) 10Manybubbles: Add timeouts to updates and better log failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 [18:57:58] ^d: ^^ annoying explicit pseudo closures [18:58:31] (03CR) 10Chad: [C: 032] Add timeouts to updates and better log failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 (owner: 10Manybubbles) [18:58:40] (03Merged) 10jenkins-bot: Add timeouts to updates and better log failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 (owner: 10Manybubbles) [18:58:46] yay! [18:58:54] I'll go work on jobing everything [19:01:00] (03PS5) 10MaxSem: authors.db extraction [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96312 [19:01:15] <^d> manybubbles: What state is test2wiki in right now? [19:01:27] (03CR) 10Siebrand: "@Antoine: Can you please have a look at this and see if it's something that can be fixed in CodeSniffer?" [core] - 10https://gerrit.wikimedia.org/r/96456 (owner: 10Siebrand) [19:01:34] should be working, haven't synced to it lately though [19:02:16] ^d: searches seem fine. the Elasticsearch cluster is green (or icinga would be super pissed) [19:02:28] <^d> *nod* [19:02:40] (03CR) 10jenkins-bot: [V: 04-1] authors.db extraction [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96312 (owner: 10MaxSem) [19:02:43] <^d> So now, we're just in the monitoring/making sure this doesn't happen again phase? [19:02:49] <^d> But everything's at least *restored*? [19:03:38] oh yeah [19:03:45] <^d> Ok, I was staying hands off until I heard that for sure. Didn't want to touch anything and risk making it worse :) [19:03:49] everything was pretty much restored when we switched back to lucene [19:03:53] (03CR) 10Anomie: [C: 031] "Sorry, this got lost in my review queue. Consider this a +2 once someone volunteers to make sure AssertEdit gets undeployed with whichever" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [19:04:00] we're still running without redundancy on some of the wikivoyages [19:04:04] but they aren't running any way [19:04:13] and we'll rebuild everything when we go back to production [19:04:26] <^d> Should we go ahead and drop all those old indexes then? [19:04:30] but I'm still treating the Elasticsearch cluster as though it were serving production traffic (I mean, it is) [19:04:37] I wanna keep em [19:04:47] (03PS6) 10Aaron Schulz: Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 [19:04:55] so if I do things to Elasticsearch I can see if I've broken them [19:05:12] I don't think I will, but it'll be nice to have them to complain if they fail [19:05:28] I mean, no one is using them so if I break them now then it is better then when people are using them [19:05:50] beyond that, there is no reason not to shoot the old indexes [19:08:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'm still not happy with how this breaks with empty list of changes. We could probably just call `$this->getOutput()->addModuleStyles( 'me" [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [19:12:37] <^d> manybubbles: Totally different subject. If I'm wanting to check an individual node's health, where would you suggest? [19:12:53] <^d> Googling's ended me up with http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/cluster-nodes-stats.html, but I'm not sure if it's really what I want. [19:13:03] <^d> (This is re: better check for LVS depooling) [19:13:32] elasticsearch doesn't really have a node health that _it_ calculates [19:13:34] it has a cluster health [19:13:43] <^d> Yeah hmm. [19:13:44] and node stats [19:13:51] <^d> I'm wondering if we could infer something from node stats though. [19:14:01] you could depool the servers that don't agree with the majority on who is the master [19:14:08] greg-g: heads up i'm still seeing that mobile issue on beta labs - what time is the MobileFrontend deployment scheduled today? [19:14:10] those servers are suffering from a split brain [19:16:51] <^d> What do we have minimum_master_nodes set to now that we've got 12 in the cluster? [19:19:25] <^d> Ah, 2. [19:19:47] ^d: we only have 3 nodes that are master_eligible [19:20:11] we shouldn't have a split brain but we should expect the unexpected [19:20:56] jdlrobson: now-ish, do you not want mobilefrontend to be branched? [19:21:12] greg-g: where is Wikibase deployed? [19:21:22] greg-g: it turns out this is the issue i'm seeing https://bugzilla.wikimedia.org/show_bug.cgi?id=57367 [19:21:32] it's similar to the ULS issue [19:21:52] aude: ^^^ [19:22:41] <^d> manybubbles: Eww. https://github.com/elasticsearch/elasticsearch/issues/2488 [19:23:28] jdlrobson: wikibase client? [19:23:44] * aude knows [19:23:59] https://git.wikimedia.org/blob/operations%2Fmediawiki-config.git/d792f1f0dbe8a91f14763e6ea5c8ee8dba85531a/wmf-config%2FInitialiseSettings.php#L12507 [19:24:04] can't look right now.... when does this need to be fixed? [19:24:52] well i only just started seeing this issue on beta labs today [19:25:17] let me investigate the issue [19:25:46] ^d: indeed. I've seen that bug a few times. I just poked it. [19:25:55] hell, maybe I'll have a look at it one day. [19:26:03] but that doesn't sound like "fun" [19:26:12] maybe the dwarf fortress kind of fun [19:26:18] <^d> Shouldn't we set minimum_master_nodes to the suggested N / 2 + 1? [19:26:26] we have [19:26:37] N is the number of nodes that are master_eligible [19:26:49] <^d> Ah, wrong N. [19:26:55] annoying, isn't it? [19:28:42] jdlrobson: https://www.mediawiki.org/wiki/Wikimedia_Release_%26_QA_Team/Wishlist#True_code_pipeline :) [19:30:10] (I just added that, basically, it's confusing now, and we should fix that) [19:30:54] greg-g: agreed - this is not a good state of affairs :) [19:43:19] (03PS6) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [19:44:35] (03CR) 10jenkins-bot: [V: 04-1] jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [19:48:19] greg-g: so https://gerrit.wikimedia.org/r/#/c/96809/ will fix it [19:48:24] (03PS1) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [19:48:30] i'm poking at awjr|lunch to get it merged so it can go on the train [19:48:40] (and that's fix it as in hack around it :)) [19:49:43] (03CR) 10Siebrand: [C: 04-1] "Messages for English definitely should be part of this patch set." [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [19:50:55] (03PS7) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [19:51:11] (03CR) 10Siebrand: "See inline, and please fix the issues pointed out in https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/3801/consol" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [19:55:15] (03PS1) 10MaxSem: Add wikis information to metabook [extensions/Collection] - 10https://gerrit.wikimedia.org/r/96812 [19:58:29] (03CR) 10Siebrand: [C: 04-1] Add "failed" template (031 comment) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96807 (owner: 10Anomie) [20:02:37] (03CR) 10Legoktm: [C: 04-1] "The $this->newParser stuff needs to be removed." [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [20:04:08] (03CR) 10Legoktm: Move ExpandTemplates special into core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [20:04:40] (03PS2) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [20:07:44] (03PS1) 10Bsitu: Incorrect depth is set to post in topic reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96821 [20:08:40] (03PS3) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [20:09:50] (03PS2) 10Hashar: Remove Scribunto from smw-core unit test suite [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96032 (owner: 10Mwjames) [20:10:14] /whois [20:11:38] (03PS2) 10Bsitu: Incorrect depth is set to post in topic reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96821 [20:11:48] (03CR) 10Siebrand: "See inline comments. Also: Why form the libraries? Isn't that a guarantee for complex future updates?" (039 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [20:12:05] (03CR) 10Siebrand: "Oops: s/form/fork/" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [20:13:05] (03CR) 10Siebrand: [C: 04-1] Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [20:13:06] (03CR) 10Bsitu: [C: 032] Moderation buttons should have gray icon by default, colored on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96502 (owner: 10Matthias Mullie) [20:13:21] (03Merged) 10jenkins-bot: Moderation buttons should have gray icon by default, colored on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96502 (owner: 10Matthias Mullie) [20:14:22] (03CR) 10Hashar: [C: 032] "job mwext-SemanticMediaWiki-testextensions-master refreshed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96032 (owner: 10Mwjames) [20:14:42] (03Merged) 10jenkins-bot: Remove Scribunto from smw-core unit test suite [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96032 (owner: 10Mwjames) [20:15:16] (03CR) 10Nikerabbit: Fixes to RedisBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96801 (owner: 10Aaron Schulz) [20:20:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think you also need to add the imported messages' keys to messages.inc. See https://www.mediawiki.org/wiki/Localisation#Adding_new_messa" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [20:23:22] (03CR) 10Siebrand: [C: 032] Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96509 (owner: 10Umherirrender) [20:25:02] (03PS4) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [20:27:00] (03PS1) 10Cscott: Tweak metabook.json to better match spec. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96826 [20:27:01] (03PS1) 10Cscott: Add CLI option to force a toc. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96827 [20:27:02] (03PS1) 10Cscott: Factor out promise utility module 'P', shared with mw-latexer. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96828 [20:27:03] (03PS1) 10Cscott: Ensure spidered filenames are unique. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96829 [20:27:06] (03Merged) 10jenkins-bot: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96509 (owner: 10Umherirrender) [20:28:01] (03PS1) 10Cscott: Use the P helper module in the implementation of Db. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96830 [20:29:35] (03PS2) 10Aaron Schulz: Fixes to RedisBagOStuff [core] - 10https://gerrit.wikimedia.org/r/96801 [20:31:34] (03CR) 10Siebrand: "L10n reviewed. Punctuation missing." (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 (owner: 10Dan-nl) [20:33:52] (03PS5) 10UltrasonicNXT: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 [20:35:00] (03PS12) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [20:35:07] (03CR) 10Siebrand: "L10n reviewed." (031 comment) [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/96289 (owner: 10Yaron Koren) [20:35:18] (03PS5) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [20:36:26] (03CR) 10jenkins-bot: [V: 04-1] Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [20:37:38] (03CR) 10Anomie: Add "failed" template (031 comment) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96807 (owner: 10Anomie) [20:42:48] (03PS7) 10Aaron Schulz: Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 [20:42:54] (03CR) 10Siebrand: Add "failed" template (031 comment) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96807 (owner: 10Anomie) [20:44:07] (03CR) 10Aaron Schulz: "Added tests" [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [20:46:51] (03CR) 10Mwalker: [C: 04-1] "See my comment, but the blocker really is the need to add" (031 comment) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96807 (owner: 10Anomie) [20:50:21] (03PS5) 10Scimonster: Add legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 [20:53:09] (03CR) 10Scimonster: "OK, it works now even with an empty watchlist view (not empty watchlist)." [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [20:55:08] (03PS5) 10MaxSem: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [20:55:53] (03PS1) 10Umherirrender: Correct version section for rc_source in the updaters [core] - 10https://gerrit.wikimedia.org/r/96874 [20:57:34] (03PS2) 10MegaAlex: Change the syntax and non-one count fake values for {{PLURAL: in newmessages* [core] - 10https://gerrit.wikimedia.org/r/96652 [20:58:05] is User:Iamd on mediawiki.org an intern or mentee or something? [20:58:19] (03CR) 10Siebrand: "Reviewed about half. Two structural issues need to be resolved: No space after ! and no introduction of newlines in comment blocks." (039 comments) [core] - 10https://gerrit.wikimedia.org/r/96252 (owner: 10Addshore) [20:58:19] if so someone may want to point out to him to how to organize his/her work [21:00:23] (03CR) 10UltrasonicNXT: "How do I do this?" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [21:01:23] (03PS1) 10Aude: Update Wikibase [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96877 [21:02:03] (03PS6) 10MaxSem: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [21:03:40] (03CR) 10jenkins-bot: [V: 04-1] Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [21:07:14] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96877 (owner: 10Aude) [21:07:56] (03CR) 10Siebrand: [C: 04-1] Add some phpdocs for IDEs (034 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 (owner: 10Addshore) [21:10:48] (03CR) 10Cscott: [C: 032] Use the P helper module in the implementation of Db. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96830 (owner: 10Cscott) [21:12:18] (03CR) 10Cscott: [C: 032] Tweak metabook.json to better match spec. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96826 (owner: 10Cscott) [21:12:33] (03CR) 10Cscott: [C: 032] Add CLI option to force a toc. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96827 (owner: 10Cscott) [21:12:39] (03PS2) 10Anomie: Add "failed" template [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96807 [21:12:48] (03CR) 10Cscott: [C: 032] Factor out promise utility module 'P', shared with mw-latexer. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96828 (owner: 10Cscott) [21:12:59] (03CR) 10Cscott: [C: 032] Ensure spidered filenames are unique. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96829 (owner: 10Cscott) [21:13:46] (03Merged) 10jenkins-bot: Use the P helper module in the implementation of Db. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96830 (owner: 10Cscott) [21:15:08] (03Merged) 10jenkins-bot: Tweak metabook.json to better match spec. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96826 (owner: 10Cscott) [21:16:26] (03Merged) 10jenkins-bot: Add CLI option to force a toc. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96827 (owner: 10Cscott) [21:17:41] (03Merged) 10jenkins-bot: Factor out promise utility module 'P', shared with mw-latexer. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96828 (owner: 10Cscott) [21:19:06] (03Merged) 10jenkins-bot: Ensure spidered filenames are unique. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96829 (owner: 10Cscott) [21:25:26] (03PS1) 10Aklapper: Reset tops parameter to default value if too long [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96880 [21:25:49] marktraceur: can i get a code review from you? [21:26:08] Sure [21:26:24] jdlrobson: Your typography and nearby things are on all sisters beeteedubs [21:26:28] (03CR) 10Aklapper: [C: 031] "Note: This is already deployed on the production server; just need to sync our public repository." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96880 (owner: 10Aklapper) [21:27:06] marktraceur: it's a nearby fix - it's not working on commons due to this https://gerrit.wikimedia.org/r/96882 [21:28:33] marktraceur: is nearby pages on any of the wiki projects? [21:29:03] Yeah, it works on wikivoyage [21:29:08] Though it's not terribly useful [21:30:15] marktraceur: yeh wikivoyage nearby in general needs some work :( [21:30:23] jdlrobson: what were you poking me about? [21:31:32] (03PS9) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [21:34:36] (03CR) 10Aaron Schulz: [C: 032] input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [21:34:43] (03CR) 10Dan-nl: "addressing siebrand’s inline comments:" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [21:34:44] (03Merged) 10jenkins-bot: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [21:38:40] thanks Aaron|home, i think the last outstanding commit is https://gerrit.wikimedia.org/r/#/c/96715/ [21:39:50] (03CR) 10Aaron Schulz: [C: 032] autoload-classes [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96715 (owner: 10Dan-nl) [21:39:59] (03Merged) 10jenkins-bot: autoload-classes [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96715 (owner: 10Dan-nl) [21:40:39] Aaron|home: excellent, thanks. does that complete the architecture review? [21:41:56] (03CR) 10Dan-nl: "addressed siebrand's inline comment in https://gerrit.wikimedia.org/r/#/c/96510/ ps8" (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [21:44:02] (03CR) 10Dan-nl: "addressed siebrand's comment in https://gerrit.wikimedia.org/r/#/c/96510/ ps 9" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 (owner: 10Dan-nl) [21:46:12] (03CR) 10EBernhardson: (bug 57162) red links don't work (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [21:48:00] (03CR) 10Bartosz Dziewoński: "I'll just rebase for you, as this is not supposed to happen normally. For the record, the steps are:" [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [21:48:56] (03CR) 10Mgrover: [C: 032 V: 032] "Reviewed the code and pulled down this patch and it worked" [tools/release] - 10https://gerrit.wikimedia.org/r/95718 (owner: 10Jdlrobson) [21:49:12] (03Merged) 10jenkins-bot: git-logs: Allow use of -c argument [tools/release] - 10https://gerrit.wikimedia.org/r/95718 (owner: 10Jdlrobson) [21:49:51] (03CR) 10Parent5446: [C: 032] New getHTML() method for QuickTemplate to get the HTML of a template. [core] - 10https://gerrit.wikimedia.org/r/96703 (owner: 10Jack Phoenix) [21:50:10] (03CR) 10Mwalker: [C: 032] "We should go back and modify the messages in a later patch -- but for right now we'll leave them with HTML in them because that's how ever" [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96807 (owner: 10Anomie) [21:51:17] csteipp: saw your post in bugzilla, thanks. i'll start work on it tomorrow [21:51:36] (03PS6) 10Bartosz Dziewoński: Move ExpandTemplates special into core [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [21:53:14] (03Merged) 10jenkins-bot: New getHTML() method for QuickTemplate to get the HTML of a template. [core] - 10https://gerrit.wikimedia.org/r/96703 (owner: 10Jack Phoenix) [21:53:29] (03CR) 10Bsitu: [C: 032] Allow custom 'diff' values to be set [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96293 (owner: 10Gerrit Patch Uploader) [21:53:47] can gerrit hotkeys be turned off? [21:54:26] (on a per-user basis obviously :) [21:54:27] <^d> No way I know of. [21:55:09] (03CR) 10Bartosz Dziewoński: "Done. You should now delete your local branch and run `git review -d 96810` to download the most recent version of code from here if you n" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [21:55:09] doh. I guess i have to remember to turn off my mousepad. Generally i'm typing away, bump the touchpad and then my typing turns into a bunch of hotkeys that switch pages on me [21:55:51] (03Merged) 10jenkins-bot: Allow custom 'diff' values to be set [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96293 (owner: 10Gerrit Patch Uploader) [21:58:25] (03CR) 10UltrasonicNXT: "Hmmm, I think I went through those steps, but when I got to git review, it listed 100s of commits, so I assumed I'd done something wrong. " [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [21:59:07] (03CR) 10Mgrover: [C: 032 V: 032] "Pulled down as well as code reviewed and works" [tools/release] - 10https://gerrit.wikimedia.org/r/95721 (owner: 10Jdlrobson) [21:59:09] (03CR) 10Parent5446: [C: 031] Add handler for GetLogTypesOnUser hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95097 (owner: 10Legoktm) [21:59:14] (03Merged) 10jenkins-bot: git-logs: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 (owner: 10Jdlrobson) [21:59:44] (03CR) 10Waldir: "@Nemo, how so? You mean they could forget the username WikiSysop? That's hardly a serious problem since it's easily recoverable with Speci" [core] - 10https://gerrit.wikimedia.org/r/65613 (owner: 10Waldir) [21:59:53] (03CR) 10EBernhardson: Use explicit transactions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [22:00:05] (03CR) 10Bartosz Dziewoński: "Agh, no, that was probably just git-review being stupid. It sometimes goes "out of sync", running `git fetch --all` usually fixes that." [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [22:00:17] gods, why is git-review so shite. [22:00:47] (03PS1) 10Mwalker: Add wikis information to metabook [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96893 [22:01:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] Add legend to Special:RecentChanges and Special:Watchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [22:02:11] MatmaRex: write something better :P [22:02:24] (03CR) 10Nemo bis: "Waldir, believe it or not, how to recover an initial user is a FAQ: ebernhardson: `git push gerrit HEAD:refs/for/master` [22:02:33] lol [22:02:42] all it has to do is not fuck up remotes [22:02:46] yet it managed to do exactly that [22:03:01] <^d> Solution: don't use git-review! [22:03:28] ^d: i'll have you explain `git push gerrit HEAD:refs/for/master` to a GCI student next time this comes up. :D [22:03:28] (03PS1) 10CSteipp: Add site-wide privacy link [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/96894 [22:03:38] ^d: and `git fetch https://gerrit.wikimedia.org/r/mediawiki/core refs/changes/52/96652/2 && git checkout FETCH_HEAD` too [22:04:00] real solution: don't use gerrit! [22:04:03] <^d> "Don't ask why. It just works :)" [22:04:16] these don't sound like solutions to me :P [22:04:22] they sound like 'lets make a bunch of new problems' [22:04:38] (03CR) 10Aaron Schulz: [C: 032] Add site-wide privacy link [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/96894 (owner: 10CSteipp) [22:04:40] (03Merged) 10jenkins-bot: Add site-wide privacy link [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/96894 (owner: 10CSteipp) [22:05:29] Reedy: is it too late to update MobileFrontend to master again for the deployment train? [22:05:40] Nope [22:05:55] (03CR) 10EBernhardson: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96636 (owner: 10Bsitu) [22:06:00] I'm still sat in purgatory [22:06:06] ebernhardson: oh, i still want you to comment on https://gerrit.wikimedia.org/r/#/c/96656/ :) (or get somebody else to do that) [22:06:25] (03Merged) 10jenkins-bot: Textarea should auto-expand to content height during initial load [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96636 (owner: 10Bsitu) [22:06:25] MatmaRex: i couldn't decide, but i'll poke benny [22:06:30] Reedy: okidoke; shall i do it? [22:06:37] MatmaRex: i always thought the whole formatter abstraction was a bit odd :P [22:07:51] heh [22:08:09] well, Echo definitely has more classes than i'm personally comfortable with :P [22:08:56] (03PS2) 10EBernhardson: Move buttonicon.less to the base module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96688 [22:11:13] oh i prefer having a large number of classes, i just think the way it was abstracted is wierd :P [22:13:39] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Okay, looks good, just a documentation improvement request :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96652 (owner: 10MegaAlex) [22:15:39] (03CR) 10Mgrover: [C: 032 V: 032] "Code reviewed and pulled down the commit.. looks good" [tools/release] - 10https://gerrit.wikimedia.org/r/95732 (owner: 10Jdlrobson) [22:15:45] (03Merged) 10jenkins-bot: git-logs: Link to dependencies, bugs and stories [tools/release] - 10https://gerrit.wikimedia.org/r/95732 (owner: 10Jdlrobson) [22:15:50] (03CR) 10Parent5446: [C: 04-1] Move ExpandTemplates special into core (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/96810 (owner: 10UltrasonicNXT) [22:19:53] (03PS1) 10Awjrichards: Update MobileFrontend to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96896 [22:20:08] Reedy: ^ [22:20:44] (03PS1) 10Brian Wolff: Do not repetitively extract metadata of broken tiff files. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/96897 [22:24:48] (03CR) 10Awjrichards: [C: 032 V: 032] Update MobileFrontend to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96896 (owner: 10Awjrichards) [22:27:19] (03CR) 10EBernhardson: [C: 032] Add preview function (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 (owner: 10Bsitu) [22:27:36] (03Merged) 10jenkins-bot: Add preview function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 (owner: 10Bsitu) [22:28:01] (03Merged) 10jenkins-bot: Update MobileFrontend to master [core] (wmf/1.23wmf5) - 10https://gerrit.wikimedia.org/r/96896 (owner: 10Awjrichards) [22:30:33] (03CR) 10Mgrover: [C: 032 V: 032] "reviewed and tested" [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [22:30:40] (03Merged) 10jenkins-bot: git-logs: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [22:32:21] MatmaRex: I don't understand what should I change to that message. [22:32:59] (03PS1) 10Manybubbles: Perform Elasticsearch updates with queued jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 [22:34:03] (03PS2) 10Manybubbles: Perform Elasticsearch updates with queued jobs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 [22:36:39] ^d: four bugs left before reenabling Cirrus [22:36:45] two of which have patches now [22:38:02] (03CR) 10EBernhardson: [C: 032] Incorrect depth is set to post in topic reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96821 (owner: 10Bsitu) [22:38:03] I might have a look at icinga stuff tonight - I got a late start today so I'll be back for a while after dinner. [22:38:08] MegaAlex: well, mostly the same thing that the message above mentions? [22:38:12] (03Merged) 10jenkins-bot: Incorrect depth is set to post in topic reply [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96821 (owner: 10Bsitu) [22:38:23] MegaAlex: the docs for newmessageslinkplural and newmessagesdifflinkplural are inconsistent [22:38:32] not that it's your fault, but let's fix it :) [22:39:07] (03CR) 10Yaron Koren: "Siebrand - do you mean that it needs a '.' at the end? Not all warning/error messages have that..." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/96289 (owner: 10Yaron Koren) [22:41:17] marktraceur: so the grrrit-wm improvements are your doing? yay <3 [22:42:11] <^d> manybubbles|away: Sounds good. I'll be around if you need a hand. [22:42:22] Only one [22:42:45] MatmaRex: I wanted to do one that either scrubbed or differentiated rebases, but it's waiting on an upstream bug [22:43:05] http://code.google.com/p/gerrit/issues/detail?id=2261 not much attention to it either [22:43:29] marktraceur: hmm [22:44:08] (03CR) 10Aaron Schulz: [C: 032] Do not repetitively extract metadata of broken tiff files. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/96897 (owner: 10Brian Wolff) [22:44:09] marktraceur: i suppose you do not have the commits "locally" when grrrit-wm sends its message? if you did, you could use `git patch-id` to detect rebases [22:44:14] (03Merged) 10jenkins-bot: Do not repetitively extract metadata of broken tiff files. [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/96897 (owner: 10Brian Wolff) [22:44:23] "A "patch ID" is nothing but a SHA1 of the diff associated with a patch, with whitespace and line numbers ignored. As such, it’s "reasonably stable", but at the same time also reasonably unique, i.e., two patches that have the same "patch ID" are almost guaranteed to be the same thing." [22:46:16] MatmaRex: No, we don't even see the latest commit message when we get the stream [22:46:29] (03CR) 10Krinkle: [C: 04-1] jQuery.makeCollapsible: Allow support for table captions (035 comments) [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [22:48:24] Krinkle: i hear you VE guys have a few front-end'y questions you like to ask candidates? I'd love to look over what you guys do to get some ideas for an interviewee we have coming in tomorrow [22:48:54] ebernhardson: I don't think we have a written-down list of questions. [22:49:16] James_F: ahh, well i suppose that makes sense [22:49:23] James_F: ebernhardson: Trevor and Roan would have a very satisfying answer to that. [22:49:30] ebernhardson: It's more topics we cover. [22:49:37] They do actually have written down some good material to assess a candidate. [22:50:03] I've helped review and refine it at some point (after being subjected to it myself), however I don't have a copy of it. [22:50:20] Krinkle: No, we decided that wasn't fit for use a while ago. [22:50:24] Krinkle: Do keep up. :-) [22:50:56] Krinkle: That's why we stopped using it directly before this year. [22:51:42] (03CR) 10Bartosz Dziewoński: "The patch currently also doesn't work as advertised, but I guess you know that :)" [core] - 10https://gerrit.wikimedia.org/r/96773 (owner: 10Areke) [22:52:08] Catchable fatal error: Argument 1 passed to EducationProgram\Events\{closure}() must be an instance of _DiffOp, instance of DiffOp_Copy given in /usr/local/apache/common-local/php-1.23wmf4/extensions/EducationProgram/includes/Events/EditEventCreator.php on line 159 [22:52:10] I think it was quite useful, I do hope then that is will be replaced timely with something else that yields a similar result. [22:52:44] sounds interesting to me at least :) but i imagine via trial and error you would have better information on its usefullness [22:54:02] Because aside from other factors (who we attract in the first place, and social assessment during interview) I found tech assessment a bit lacking (and perhaps causing undesirable results) without Trevor's methods. [22:55:05] Reedy: heh, same stuff as yesterday. [22:55:09] * MatmaRex blames people renaming classes all over [22:55:49] .. and that's why all deployed extensions should have PHP unit tests that actually execute code with latest master. [22:57:01] (03CR) 10Mgrover: [C: 032 V: 032] All MobileFrontend Jenkins jobs should send e-mail notification to the same addresses [selenium] - 10https://gerrit.wikimedia.org/r/96058 (owner: 10Zfilipin) [22:57:08] (03Merged) 10jenkins-bot: All MobileFrontend Jenkins jobs should send e-mail notification to the same addresses [selenium] - 10https://gerrit.wikimedia.org/r/96058 (owner: 10Zfilipin) [23:03:00] (03PS1) 10Bsitu: The comment about eventlogging schema definition is quite confusing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96902 [23:05:35] (03PS3) 10MegaAlex: Change the syntax and non-one count fake values for {{PLURAL: in newmessages* [core] - 10https://gerrit.wikimedia.org/r/96652 [23:08:23] (03PS1) 10Parent5446: Add fastcgi_finish_request where appropriate [core] - 10https://gerrit.wikimedia.org/r/96904 [23:10:20] (03PS8) 10Areke: jQuery.makeCollapsible: Allow support for table captions [core] - 10https://gerrit.wikimedia.org/r/96773 [23:12:55] (03CR) 10Rillke: "Edits can be avoided if "mocked" with jQuery mockjax which is also a core module. Using this in VisualFileChange for a long time for testi" [core] - 10https://gerrit.wikimedia.org/r/83217 (owner: 10Mattflaschen) [23:19:27] (03PS1) 10EBernhardson: Stop eating posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96905 [23:21:05] (03PS1) 10Aaron Schulz: Truncate super long SQL in DB error log lines (useful for blobs) [core] - 10https://gerrit.wikimedia.org/r/96906 [23:23:33] (03CR) 10Bsitu: Use explicit transactions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [23:23:47] (03PS1) 10Chad: Handle CDB errors more gracefully in cdb.php maintenance script [core] - 10https://gerrit.wikimedia.org/r/96907 [23:25:00] (03CR) 10Bsitu: [C: 032] Stop eating posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96905 (owner: 10EBernhardson) [23:25:22] (03Merged) 10jenkins-bot: Stop eating posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96905 (owner: 10EBernhardson) [23:28:32] (03CR) 10Bartosz Dziewoński: "Actually, I don't really have the time nor the incentive to finish working on this, sorry. Anyone can feel free to pick it up." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93115 (owner: 10Bartosz Dziewoński) [23:28:36] (03Abandoned) 10Bartosz Dziewoński: ext.echo.overlay: Show a spinner while waiting for data [WIP] [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93115 (owner: 10Bartosz Dziewoński) [23:29:28] (03CR) 10Bsitu: [C: 032] Move buttonicon.less to the base module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96688 (owner: 10EBernhardson) [23:29:39] (03Merged) 10jenkins-bot: Move buttonicon.less to the base module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96688 (owner: 10EBernhardson) [23:34:22] jdlrobson: Another report of weird flashing of different CSS from a friend, FYI [23:34:49] (03CR) 10Bartosz Dziewoński: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [23:35:05] (03PS2) 10Bartosz Dziewoński: mediawiki.hlist: Use mw.hook( 'wikipage.content' ) in JS fallback [core] - 10https://gerrit.wikimedia.org/r/96239 [23:36:49] (03CR) 10PleaseStand: "So is this the "future" feature described in docs/deferred.txt?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96904 (owner: 10Parent5446) [23:38:11] (03PS1) 10Chad: Improved CdbException handling in LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/96909 [23:42:38] (03PS1) 10Chad: Change CdbException to subclass Exception [core] - 10https://gerrit.wikimedia.org/r/96910 [23:43:54] marktraceur: aw crap, the "Beta" link is still visible for everyone? [23:44:08] marktraceur: people are already complaining https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=582744876&oldid=582739959 [23:44:40] Fascinating. [23:45:14] MatmaRex: Person* [23:45:22] (03CR) 10Chad: Perform Elasticsearch updates with queued jobs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96898 (owner: 10Manybubbles) [23:46:25] to be honest, the more I think about the beta link thing, the more I actually tend to agree with it being a bit overkill [23:46:43] given its essentially a link to Special:Preferences, which we already have [23:47:14] * marktraceur doesn't really have a horse in that race [23:47:22] I let the product and design teams make the decision [23:47:40] (the relevant bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=56517 "The "Beta" personal menu item should only be shown for users who opted in to at least one beta feature") [23:47:45] (03CR) 10Spage: [C: 04-1] "This can't be rebased onto master with the VE test removal because you combined moving code, addition, and cleanup. I couldn't figure out " (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96047 (owner: 10Cmcmahon) [23:48:20] marktraceur: Smart decision - keeps you away from the flame wars ;) [23:48:36] Eeeeexactly. [23:48:57] * marktraceur is a hammer [23:49:01] Gonna hammer in the morning [23:49:05] Gonna hammer in the evening [23:49:08] (03CR) 10Cmcmahon: "Too bad about the rebase. I'll fix this up first thing tomorrow." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96047 (owner: 10Cmcmahon) [23:49:08] All across this land [23:49:45] (03PS1) 10Cscott: Update README; describe node packages with binary dependencies. [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96911 [23:50:01] <^d> marktraceur: Rather than letting other people decide, it's more fun to decide yourself. [23:50:08] <^d> Then when people complain, you can tell them they're wrong ;-) [23:51:13] meh. [23:51:17] dumb designers. [23:51:22] good night everyone [23:52:25] ^d: I don't tend to like telling people they're wrong, which is why doing so shouldn't be my job [23:52:30] I'd do a shite job at it [23:54:30] (03PS1) 10Aaron Schulz: Avoiding implicit transactions when applying [core] - 10https://gerrit.wikimedia.org/r/96912 [23:55:18] Reedy: You aware of issues with texvc in prod? [23:55:31] (03PS1) 10Cscott: Don't try to test XeLaTeX compilation if XeLaTeX is not installed. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96913 [23:55:47] (03CR) 10jenkins-bot: [V: 04-1] Don't try to test XeLaTeX compilation if XeLaTeX is not installed. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96913 (owner: 10Cscott) [23:56:17] (03CR) 10Chad: Truncate super long SQL in DB error log lines (useful for blobs) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96906 (owner: 10Aaron Schulz) [23:57:30] Reedy: Seems to be localised to wmf5. [23:58:11] Reedy: https://www.mediawiki.org/wiki/User:Jdforrester_(WMF)/Test_formulae [23:58:50] Actually, I kind of like the beta link better if it was superscript - e.g. #pt-betafeatures{vertical-align: top; font-size: 0.6em; margin-left: 0em;} [23:59:09] greg-g: Ping? [23:59:34] bawolff: ugh, nooo. I still think visualeditorbeta is super ugly [23:59:42] legoktm: Agreed.