[00:02:15] gwicke: if isQueueDeprioritized() was more than a one-case hack, ParsoidCacheUpdateJobOnDependencyChange had one type for jobs that make jobs and another for ones that actually use curl, and jobs in the later type deprioritized the first type, would keep the total number of jobs down a lot [00:03:39] Aaron|home: are you thinking about only partially expanding jobs? [00:04:17] hmm- I see why you are thinking about this [00:04:44] the load on the parsoid cluster was suspiciously low recently [00:06:57] (03PS1) 10Bsitu: Timestamp in boardy history doesn't switch to absolute on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96398 [00:08:17] (03CR) 10EBernhardson: [C: 032] 'Comment' link does not take user to topic reply box on no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96311 (owner: 10Bsitu) [00:08:27] (03Merged) 10jenkins-bot: 'Comment' link does not take user to topic reply box on no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96311 (owner: 10Bsitu) [00:10:26] Aaron|home: can you check if the ParsoidCacheUpdateJobOnDependencyChange runners are healthy? [00:12:52] ori-l: https://gerrit.wikimedia.org/r/#/c/96397/ [00:14:00] they seem normal [00:14:34] Aaron|home: ok, thanks [00:14:52] I guess they are just slightly too throttled [00:17:28] gwicke: I was thinking of adding throttling to the recursion aspect so there wouldn't be 100s of thousands of jobs [00:18:15] Aaron|home: yeah, although the number of jobs in themselves is not really a problem afaik- it is just that they are not processed fast enough right now [00:18:18] that can't really be done easily without jobs-that-make-jobs being a different class [00:18:41] it still wastes space in redis and triggers those ganglia warnings [00:19:03] right now there is one worker for that queue, I'd like to up it to 1.5 or so.. [00:21:27] (03PS1) 10Ori.livneh: Update MobileFrontend to tip of wmf3 branch [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96401 [00:21:37] (03PS1) 10CSteipp: Update OAuth to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96402 [00:21:38] another trick instead of isQueueDeprioritized() would be to have two queues again, but have the starting jobs be FIFO and break down into job-jobs/real-jobs in a LIFO queue [00:21:57] (03CR) 10Jdlrobson: [C: 031] Update MobileFrontend to tip of wmf3 branch [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96401 (owner: 10Ori.livneh) [00:22:08] (03CR) 10Ori.livneh: [C: 032] Update MobileFrontend to tip of wmf3 branch [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96401 (owner: 10Ori.livneh) [00:22:20] I see that OAuth is deployed on MediaWiki (right?). What is the status for the other WMF wikis, I cannot find a timeline or status? [00:23:02] csteipp: ^^ [00:23:18] dennyvrandecic: Thursday! [00:23:29] https://www.mediawiki.org/wiki/OAuth#Timeline [00:23:33] doing the recursive jobs in LIFO would avoid dumping all the titles in at once [00:23:36] Blank section is blank ;) [00:23:48] Reedy: , csteipp - thanks! [00:28:23] (03PS3) 10Andrew Bogott: Add the 'NovaResources' special page. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 [00:32:21] (03CR) 10CSteipp: "trivial stuff." (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [00:32:22] (03PS4) 10Andrew Bogott: Add the 'NovaResources' special page. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96323 [00:36:08] (03CR) 10Legoktm: Implement global user CSS/JS module (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [00:36:19] (03CR) 10CSteipp: [C: 032] Update OAuth to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96402 (owner: 10CSteipp) [00:39:43] (03Merged) 10jenkins-bot: Update OAuth to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96402 (owner: 10CSteipp) [00:56:42] (03CR) 10Legoktm: [C: 04-1] "I haven't tested this with $wgActionPaths yet, -1 for that." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [00:56:56] (03PS2) 10Legoktm: Add Special:Edit and Special:History which redirect to their action equivalents [core] - 10https://gerrit.wikimedia.org/r/96170 [00:57:16] (03PS1) 10Aaron Schulz: Reduced isQueueDeprioritized() process cache time to 1 second [core] - 10https://gerrit.wikimedia.org/r/96405 [00:57:36] (03CR) 10jenkins-bot: [V: 04-1] Add Special:Edit and Special:History which redirect to their action equivalents [core] - 10https://gerrit.wikimedia.org/r/96170 (owner: 10Legoktm) [00:57:42] :< [01:07:17] gwicke: actually I thought of a better way [01:07:22] * Aaron|home will commit later [01:07:28] has it been raining all day in SF? [01:07:49] pretty much [01:11:35] (03PS3) 10Legoktm: Add Special:Edit and Special:History which redirect to their action equivalents [core] - 10https://gerrit.wikimedia.org/r/96170 [01:21:49] Aaron|home: some way to run low-prio jobs at higher rate if there is nothing else to do would be great [01:22:03] (03PS1) 10Ori.livneh: Add mobile targets to module storage modules [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96408 [01:22:16] actual priorities rather than primitive rate limiting [01:22:49] * Aaron|home is only interested in recursive job resolution, not throttling of actual work jobs [01:23:01] I don't think we are thinking about the same thing :) [01:23:18] (03CR) 10Ori.livneh: [C: 032] "Trivial." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96408 (owner: 10Ori.livneh) [01:23:20] (03Merged) 10jenkins-bot: Add mobile targets to module storage modules [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96408 (owner: 10Ori.livneh) [01:23:31] (03PS1) 10Ori.livneh: Add mobile targets to module storage modules [extensions/WikimediaEvents] (moduleStorage) - 10https://gerrit.wikimedia.org/r/96409 [01:24:00] (03CR) 10Ori.livneh: [C: 032] Add mobile targets to module storage modules [extensions/WikimediaEvents] (moduleStorage) - 10https://gerrit.wikimedia.org/r/96409 (owner: 10Ori.livneh) [01:24:02] (03Merged) 10jenkins-bot: Add mobile targets to module storage modules [extensions/WikimediaEvents] (moduleStorage) - 10https://gerrit.wikimedia.org/r/96409 (owner: 10Ori.livneh) [01:25:01] (03PS1) 10Ori.livneh: Update WikimediaEvents to I5b8cfe592 [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96410 [01:25:24] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to I5b8cfe592 [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96410 (owner: 10Ori.livneh) [01:30:17] (03Merged) 10jenkins-bot: Update WikimediaEvents to I5b8cfe592 [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96410 (owner: 10Ori.livneh) [01:30:48] (03PS1) 10Ori.livneh: Update WikimediaEvents to I5b8cfe592 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96412 [01:31:09] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to I5b8cfe592 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96412 (owner: 10Ori.livneh) [01:36:28] (03Merged) 10jenkins-bot: Update WikimediaEvents to I5b8cfe592 [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96412 (owner: 10Ori.livneh) [01:44:04] (03CR) 10Jack Phoenix: [C: 032] "IRCColourfulRCFeedFormatter is a MW 1.22+ thing (as is the related core config variable $wgRCFeeds)." [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/92471 (owner: 10Reedy) [02:07:30] (03CR) 10Theopolisme: Supress native "invalid email" warning on Special:ChangeEmail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96195 (owner: 10Theopolisme) [02:13:09] (03CR) 10Legoktm: "Needs a rebase again? :/" [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [02:13:44] (03Abandoned) 10Legoktm: ReferenceError: wgDraft is not defined [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88151 (owner: 10Legoktm) [02:14:00] (03CR) 10Liangent: [C: 031] "Was referenced by maintenance/language/zhtable/Makefile (includes/zhtable/Makefile)." [core] - 10https://gerrit.wikimedia.org/r/96193 (owner: 10TTO) [02:17:52] (03PS2) 10Legoktm: Add patch for 1.21.2 [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/87918 [02:18:28] (03PS1) 10Tholam: Updated ImagePage to use HiDPI (GCI Student) [core] - 10https://gerrit.wikimedia.org/r/96414 [02:19:08] (03Abandoned) 10Tholam: Updated ImagePage to use HiPI [core] - 10https://gerrit.wikimedia.org/r/96212 (owner: 10Tholam) [02:20:43] (03CR) 10Isarra: [C: 032 V: 032] "Apparently this was deployed and nothing exploded." [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/87918 (owner: 10Legoktm) [02:21:03] Isarra: hit "submit patch set 2" [02:22:27] Whazzat? [02:22:33] Oh. [02:26:30] PRESS ALL THE BUTTONS [02:29:00] (03PS2) 10Tholam: Updated ImagePage to use HiDPI (GCI Student) [core] - 10https://gerrit.wikimedia.org/r/96414 [02:29:37] Is there a button I can press to have my patch immediately reviewed? [02:31:23] Lolno [02:31:34] (03CR) 10Reedy: [C: 04-1] Updated ImagePage to use HiDPI (GCI Student) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96414 (owner: 10Tholam) [02:32:04] (03CR) 10Reedy: "You also need to rebase this onto master rather than onto an abandoned commit" [core] - 10https://gerrit.wikimedia.org/r/96414 (owner: 10Tholam) [02:34:23] donate here to get your patch ranked up in the review queue [02:34:47] (03CR) 10Reedy: "The nature of this commit, and it's dependency on a now abandoned commit would suggest you actually want to squash this commit into the ab" [core] - 10https://gerrit.wikimedia.org/r/96414 (owner: 10Tholam) [02:41:24] (03PS11) 10Legoktm: Implement global user CSS/JS module [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [02:42:10] (03CR) 10Legoktm: Implement global user CSS/JS module (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [02:43:17] (03Abandoned) 10Tholam: Updated ImagePage to use HiDPI (GCI Student) [core] - 10https://gerrit.wikimedia.org/r/96414 (owner: 10Tholam) [02:45:14] * HectorAE donates $200 to mutante [02:49:11] (03CR) 10TTO: "Mmm, maybe. However, when interlanguage links of the form [[fr:]] are used, we don't know the actual title of the page being lined to. For" [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [02:49:18] HectorAE: -1, already abandoned :) [02:50:03] (03PS1) 10Tholam: Updated ImagePage to use HiDPI [core] - 10https://gerrit.wikimedia.org/r/96416 [02:50:49] i didn't mean add _me_, i meant make a bidding system:) [02:51:43] mutante, what are you talking about? [02:53:28] HectorAE: not so seriously about the donation for reviews [02:58:36] (03PS2) 10TTO: Remove needless leading dash on Main Page interlanguage links [core] - 10https://gerrit.wikimedia.org/r/96200 [03:12:37] gwicke: does https://gerrit.wikimedia.org/r/#/c/96396/ look fine? (simple fix) [03:21:14] (03PS2) 10Tholam: Updated ImagePage to use HiDPI [core] - 10https://gerrit.wikimedia.org/r/96416 [03:23:34] Why are none of my reviewers ever around in IRC? Poor me; I've been waiting for a whole 12 hours after the last patchset. [03:27:55] (03CR) 10Dzahn: [C: 031] "the feed icon looks great to me on Iceweasel (Firefox) 22.0a2 (2013-04-19)" [core] - 10https://gerrit.wikimedia.org/r/96197 (owner: 10HectorAE) [03:28:26] HectorAE: there you go, +1ed, feed icon looks great [03:28:28] Speak of the devil. [03:28:43] Thank you. [03:28:54] yw, you want platform people on it too though [03:28:56] bbl [03:29:34] HectorAE: added direct link people can just hit https://gerrit.wikimedia.org/r/cat/96197%2C3%2Cskins/common/images/feed-icon.svg%5E0 [03:30:30] (03PS3) 10Werdna: [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 [03:30:32] (03PS1) 10Werdna: Display reason for moderation in history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96417 [03:30:41] (03PS1) 10Werdna: Fix double-username issue on RecentChanges items. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96418 [03:33:22] (03CR) 10Parent5446: [C: 032] Update ImagePage to use HiDPI [core] - 10https://gerrit.wikimedia.org/r/96416 (owner: 10Tholam) [03:36:25] (03Merged) 10jenkins-bot: Update ImagePage to use HiDPI [core] - 10https://gerrit.wikimedia.org/r/96416 (owner: 10Tholam) [03:39:22] (03PS1) 10Cscott: Suppress backtrace on error unless 'debug' option is given. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96419 [03:39:23] (03PS1) 10Cscott: Remove infozip dependency, use system 'unzip' binary directly. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96420 [03:42:18] (03CR) 10Jdlrobson: ".. but Wikipédia:Accueil principal - francais would be better than just saying francais! :)" [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [03:46:40] (03PS2) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [03:55:35] (03CR) 10TTO: "Doesn't seem trivial to me. If we have an interwiki link [[fr:]] then the page title is "". MediaWiki would need to query other wikis' dat" [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [04:07:31] (03CR) 10Dan-nl: "aded inline response to address bryan’s comment in MetadataMappingHandler.php" (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [04:08:39] (03PS1) 10Cscott: Download SVGs as well as "bitmaps". [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96421 [04:08:40] (03PS1) 10Cscott: Improve error handling if the `zip` binary is not found. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96422 [04:08:41] (03PS1) 10Cscott: Improve/document compatibility with pediapress bundler. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96423 [04:09:35] (03CR) 10Cscott: [C: 032 V: 032] Suppress backtrace on error unless 'debug' option is given. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96419 (owner: 10Cscott) [04:10:01] (03CR) 10Cscott: [C: 032 V: 032] Remove infozip dependency, use system 'unzip' binary directly. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96420 (owner: 10Cscott) [04:10:23] (03CR) 10Cscott: [C: 032 V: 032] Download SVGs as well as "bitmaps". [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96421 (owner: 10Cscott) [04:10:42] (03CR) 10Cscott: [C: 032 V: 032] Improve error handling if the `zip` binary is not found. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96422 (owner: 10Cscott) [04:11:04] (03CR) 10Cscott: [C: 032 V: 032] Improve/document compatibility with pediapress bundler. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96423 (owner: 10Cscott) [04:18:32] hi, i'm working on porting welcome.py to Pywikibot core, how'd i go about testing if my script works? [04:18:52] would i need to host mediawiki? [04:19:47] wei2912: check out https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools [04:20:02] it's a testing environment so you don't have to host it yourself [04:20:21] also see #wikimedia-labs [04:21:14] mutante, ah, thanks! could i specify under "Tools Justification" that i'm developing pywikibot? [04:21:27] mutante: https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools/Help is usually more helpful [04:21:43] wei2912: also, if you just want a mediawiki host to test on - just use test.wikipedia.org [04:22:11] YuviPanda, didn't know that existed, i think that'll suit my needs. thanks! [04:22:16] :D [04:22:17] wei2912: totally, see there are other related projects already first https://wikitech.wikimedia.org/wiki/Shell_Request/Pywikipedia_Conversion_Bot f.e. [04:23:43] YuviPanda: yea, it does, just skimmed over the same intro text [04:23:55] :D [04:23:58] YuviPanda: but i said ToolLabs, and not just Labs :) [04:24:06] :D [04:24:06] wei2912: hey, we're in #pywikipediabot. You can use test.wikipedia.org if you want to test the script [04:24:07] yeah [04:25:27] thanks YuviPanda legoktm mutante :) [04:26:17] (03PS3) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [04:27:35] glad we have answers like this nowadays:) [04:37:49] mutante: :D [04:38:25] mutante: the other option is to point them to mediawiki-vagrant, which is leaps and bounds over 'setup a LAMP server, and then do these' [04:40:26] YuviPanda: except right now its difficult to get pywikibot to work with non-default wikis. I think that's one of the GCI tasks actually [04:40:35] oh [04:40:44] legoktm: i didn't mean for pywikipediabot but in general [04:40:48] but yeah test. is nice [04:40:49] ah [04:41:16] YuviPanda: but then .. they ask me vagrant stuff :) [04:41:22] hehe [04:41:31] (03PS1) 10Cscott: Improve prefix reverse-mapping (used by Parsoid API). [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96425 [04:41:47] heyyy [04:41:52] ohai brion [04:42:03] (03CR) 10Cscott: [C: 032 V: 032] Improve prefix reverse-mapping (used by Parsoid API). [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96425 (owner: 10Cscott) [04:42:25] btw, GCI AND brion , heh [04:42:34] you guys make him happy https://gerrit.wikimedia.org/r/#/c/96197/ [04:42:54] he had to wait 12 hours:) [04:43:01] whee [04:43:34] saw you were bug reporter about that icon some time [04:43:40] heh brion loves svg [04:43:44] he made https://gerrit.wikimedia.org/r/cat/96197%2C3%2Cskins/common/images/feed-icon.svg%5E0 [04:43:50] :D [04:43:51] lgtm [04:44:36] "first commit" wtg [04:45:15] (03CR) 10AndyRussG: "Fixed JSLint failures specific to this patch. Another change is in the pipeline for the remaining JSLint failures (Change-Id: I5d5d4634d74" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 (owner: 10AndyRussG) [04:45:34] Who's brion [04:45:51] * brion waves [04:45:52] Hello brion. You made that SVG? [04:46:11] nope i just filed lots of bugs about things looking bad on high-dpi displays :D [04:46:13] HectorAE: https://www.wikidata.org/wiki/Q14956410 [04:47:08] Oh so my patch addresses one of those with the Atom icon. Cool to see I've come full circle. [04:47:29] Except that it still hasn't been reviewed by a mentor. [04:47:41] Whoa I didn't know Wikidata had stuff like that [04:47:49] lemme review it shortly... [04:48:53] Cool to see all these awesome devs around. Makes me feel like I'm in a top-secret spy facility or something [04:49:06] welcome :D [04:50:57] (03PS2) 10Dan-nl: job-queue-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 [04:51:13] heh, except you can git clone all the docs [04:51:33] (if they exist) [04:52:07] * YuviPanda git clones mutante [04:52:13] ok lemme dig out my test instance [04:52:17] and my glasses :D [04:52:54] (03CR) 10Dan-nl: "ps2 address bryan’s inline comments in MetadataMappingHandler.php and UploadMetadataJob.php" (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 (owner: 10Dan-nl) [04:53:17] brion: google glasses? [04:53:18] :D [04:53:21] YuviPanda: Duplicate definition. Class[mutante] is already defined; cannot redefine at /Users/Yuvipanda/ [04:53:33] 8D [04:53:48] actually.... i'm starting to fiddle with the native android glass dev kit :DD [04:54:00] just released 'preview' today [04:54:00] oh oh, yea i heard you're on "the list" :) [04:54:00] brion: I saw the repo being created :D [04:54:06] wants to see it in action [04:54:40] HectorAE: it works! confirmed i see the much nicer icon on my pretty high-res screen [04:55:42] ah. now i want nice icons on https://en.planet.wikimedia.org/ [04:55:46] and, looks like it does all the standards for current browser versions, don't need the extra prefixes anymore [04:55:52] i think it's good to merge :D [04:55:53] Good deal! Now I just have to find svg versions of everything else [04:56:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Confirmed works in Firefox and Safari on MacBook Pro w/ Retina display -- looks beautiful on high-res screen, and about the same as before" [core] - 10https://gerrit.wikimedia.org/r/96197 (owner: 10HectorAE) [04:57:12] oops did i do +2 verified again? i hope i don't confuse jenkins [04:57:16] i keep pushing buttons.... [04:57:26] HectorAE: thanks for the fix! [04:57:33] you might have to recreate a few of those images yes :) [04:58:45] You're welcome brion. And uh, you didn't mean to actually +2 it? [04:58:48] That's not good [04:59:07] there's separate 'reviewed' and 'verified' ... it's complicated :) [04:59:22] but the automated testing machine is supposed to do the 'verified' one, human's supposed to do the other one [04:59:46] Oh, okay. [04:59:51] HectorAE: https://commons.wikimedia.org/wiki/Category:SVG_MediaWiki_logos [05:00:08] (03PS2) 10AndyRussG: De-lint JavaScript sources. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94926 (owner: 10Cscott) [05:00:45] (03Merged) 10jenkins-bot: shared.css: Start vectorizing common icons [core] - 10https://gerrit.wikimedia.org/r/96197 (owner: 10HectorAE) [05:00:58] do we want one of those to even replace http://upload.wikimedia.org/wikipedia/mediawiki/b/bc/Wiki.png ? [05:01:29] I don't know, do we? [05:01:33] that's the current logo on mw.org [05:01:33] * YuviPanda hands mutante a can of worms [05:01:47] (03CR) 10AndyRussG: [C: 031] "Just rebasing." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94926 (owner: 10Cscott) [05:02:05] eh.. YuviPanda :) [05:02:48] HectorAE: i don't know, maybe don't start with the large logo, just ran across it looking for SVG on commons within the MW related categories [05:03:49] YuviPanda: "help shape the new trademarked logo usage policy" ?:P [05:03:57] hahaha [05:04:47] Well it's been fun but I really have to sleep [05:04:49] Goodnight [05:05:13] goodnight, cya around, glad we found the right reviewr [05:06:13] (03PS1) 10Siebrand: Update documentation and break long lines [core] - 10https://gerrit.wikimedia.org/r/96429 [05:10:32] (03CR) 10Parent5446: [C: 032] Update documentation and break long lines [core] - 10https://gerrit.wikimedia.org/r/96429 (owner: 10Siebrand) [05:13:34] (03Merged) 10jenkins-bot: Update documentation and break long lines [core] - 10https://gerrit.wikimedia.org/r/96429 (owner: 10Siebrand) [05:13:49] (03PS1) 10Siebrand: Declare visibility of class property in ContentHandler [core] - 10https://gerrit.wikimedia.org/r/96432 [05:15:47] (03CR) 10Siebrand: "I was/am not 100% sure here because of the property being static. I could imagine that would almost imply it being public. Couldn't find a" [core] - 10https://gerrit.wikimedia.org/r/96432 (owner: 10Siebrand) [05:22:34] (03PS1) 10Siebrand: Update formatting and documentatin in includes/context/ [core] - 10https://gerrit.wikimedia.org/r/96433 [05:24:23] (03CR) 10Legoktm: [C: 032] Update formatting and documentatin in includes/context/ [core] - 10https://gerrit.wikimedia.org/r/96433 (owner: 10Siebrand) [05:24:57] (03PS1) 10Siebrand: Update formatting in includes/dao/ [core] - 10https://gerrit.wikimedia.org/r/96434 [05:25:23] (03PS2) 10Siebrand: Update formatting and documentatin in includes/context/ [core] - 10https://gerrit.wikimedia.org/r/96433 [05:25:48] (03CR) 10Siebrand: "oops, sorry Lego. Please +2 again. There was a typo in the first line of the commit summary." [core] - 10https://gerrit.wikimedia.org/r/96433 (owner: 10Siebrand) [05:26:13] legoktm: Can you please +2 https://gerrit.wikimedia.org/r/96433 again? I fixed a typo in the 1st line of the commit summary. [05:26:24] (03CR) 10Legoktm: [C: 032] Update formatting and documentation in includes/context/ [core] - 10https://gerrit.wikimedia.org/r/96433 (owner: 10Siebrand) [05:26:29] done :) [05:26:35] legoktm: ty! [05:30:24] (03PS2) 10Legoktm: Update formatting in includes/dao/ [core] - 10https://gerrit.wikimedia.org/r/96434 (owner: 10Siebrand) [05:30:32] (03CR) 10Legoktm: [C: 032] Update formatting in includes/dao/ [core] - 10https://gerrit.wikimedia.org/r/96434 (owner: 10Siebrand) [05:33:58] (03CR) 10Legoktm: [C: 032] Cleanup and expand Status tests [core] - 10https://gerrit.wikimedia.org/r/95620 (owner: 10Addshore) [05:38:54] (03Merged) 10jenkins-bot: Update formatting and documentation in includes/context/ [core] - 10https://gerrit.wikimedia.org/r/96433 (owner: 10Siebrand) [05:43:13] (03Merged) 10jenkins-bot: Update formatting in includes/dao/ [core] - 10https://gerrit.wikimedia.org/r/96434 (owner: 10Siebrand) [05:44:14] (03PS1) 10Cscott: Add resource URL to the imageinfo db. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96436 [05:45:43] (03Merged) 10jenkins-bot: Cleanup and expand Status tests [core] - 10https://gerrit.wikimedia.org/r/95620 (owner: 10Addshore) [05:46:29] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96437 [05:52:09] (03PS3) 10Aaron Schulz: Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 [05:55:28] (03CR) 10jenkins-bot: [V: 04-1] Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [06:06:13] (03CR) 10Parent5446: [C: 032] Declare visibility of class property in ContentHandler [core] - 10https://gerrit.wikimedia.org/r/96432 (owner: 10Siebrand) [06:06:55] (03PS2) 10Mayankmadan: Adding "whie logged in" in Mediawiki email notification [core] - 10https://gerrit.wikimedia.org/r/96365 [06:07:14] siebrand: online? [06:07:42] mayankmadan: He's in a meeting [06:09:15] (03PS3) 10Mayankmadan: Adding "whie logged in" in Mediawiki email notification [core] - 10https://gerrit.wikimedia.org/r/96365 [06:09:58] (03Merged) 10jenkins-bot: Declare visibility of class property in ContentHandler [core] - 10https://gerrit.wikimedia.org/r/96432 (owner: 10Siebrand) [06:10:14] Nikerabbit: online? [06:11:52] mayankmadan: He's about to join the same meeting [06:11:53] :S [06:11:57] (I'm also in it) [06:12:10] :) [06:19:38] (03CR) 10Mayankmadan: Fixed the last section of MediaWiki:SpecialSpecialpages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96358 (owner: 10Mayankmadan) [06:30:20] (03PS2) 10Mayankmadan: Fixed the last section of MediaWiki:SpecialSpecialpages [core] - 10https://gerrit.wikimedia.org/r/96358 [06:30:53] (03CR) 10Aaron Schulz: [C: 032] Delete maintenance/language/zhtable/trad2simp_supp_unset.manual [core] - 10https://gerrit.wikimedia.org/r/96193 (owner: 10TTO) [06:31:50] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/96396/ [06:32:38] (03CR) 10Catrope: [C: 032] Fixed "Undefined property: stdClass::$page_namespace" error [core] - 10https://gerrit.wikimedia.org/r/96396 (owner: 10Aaron Schulz) [06:34:56] (03Merged) 10jenkins-bot: Delete maintenance/language/zhtable/trad2simp_supp_unset.manual [core] - 10https://gerrit.wikimedia.org/r/96193 (owner: 10TTO) [06:36:31] (03Merged) 10jenkins-bot: Fixed "Undefined property: stdClass::$page_namespace" error [core] - 10https://gerrit.wikimedia.org/r/96396 (owner: 10Aaron Schulz) [07:00:31] (03PS1) 10Amire80: Fix the activity-item-autoflag message [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96440 [07:00:59] (03CR) 10Amire80: [C: 031] Remove needless leading dash on Main Page interlanguage links [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [07:03:27] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96441 [07:20:37] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96443 [07:21:42] (03PS1) 10Amire80: Add dummy GENDER to avoid translatewiki warnings [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96444 [07:31:09] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96437 (owner: 10Ori.livneh) [07:31:37] (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96443 (owner: 10Ori.livneh) [07:34:16] (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96437 (owner: 10Ori.livneh) [07:35:56] (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96443 (owner: 10Ori.livneh) [07:45:23] (03PS1) 10Mayankmadan: Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 [07:47:05] siebrand: can you have a look at my task now http://www.google-melange.com/gci/task/view/google/gci2013/5833790190518272 [07:47:28] mayankmadan: No. I'll be in meeting still for the next 4-5 hours. [07:49:48] okay [08:04:19] andre__: online? [08:16:58] (03CR) 10Parent5446: [C: 04-1] Update formatting (035 comments) [core] - 10https://gerrit.wikimedia.org/r/96441 (owner: 10Siebrand) [08:35:36] mayankmadan, kind of [08:36:15] mayankmadan: please be patient waiting for a review [08:36:23] okay [08:36:25] sorry [08:36:27] mayankmadan, it's a bit rude to ping various people on IRC for this. [08:37:18] mayankmadan, plus learning to be a bit patient (not too much, but a bit) in free software projects is also one aspect of GCI. [08:37:48] (03CR) 10Zfilipin: [C: 031] "Chris, did anything change from patch set 1 to patch set 2? Is there a reason you have rebased the commit?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96151 (owner: 10Cmcmahon) [08:37:48] andre__: sorry... [08:37:51] mayankmadan: the rules say that you can expect a review within 36 hours. I don't want any mentors to always wait that long, but there are timezones and reallife and jobs. [08:38:04] will keep that in mind from now on [08:38:08] mayankmadan, no need to say sorry, we all learn. :) I just try to explain how things work to you :) [08:38:51] mayankmadan, I guess MatmaRex will be up soon, so you can expect a review in the next 12 hours or so :) [08:38:58] thanks for all your work! [08:40:21] (03CR) 10Daniel Friesen: "Shouldn't we try to work the other way? This isn't just supposed to make it 'pretty' it's supposed to make it smaller, in one of the spots" [core] - 10https://gerrit.wikimedia.org/r/92263 (owner: 10TTO) [08:44:20] (03CR) 10Wikinaut: "@ialex" [core] - 10https://gerrit.wikimedia.org/r/96253 (owner: 10IAlex) [08:44:26] (03CR) 10Nikerabbit: "The SVG icon is not embedded currently." [core] - 10https://gerrit.wikimedia.org/r/96197 (owner: 10HectorAE) [08:48:28] (03PS2) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96441 [08:48:29] (03CR) 10Siebrand: "Addressed a few comments in the next PS. Not addressing 2. See inline comments for details." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/96441 (owner: 10Siebrand) [08:49:14] (03CR) 10IAlex: "OutputPage::returnToMain() will use the returnto and returntoquery parameters if you don't pass a target to it." [core] - 10https://gerrit.wikimedia.org/r/96253 (owner: 10IAlex) [08:51:05] (03PS12) 10Helder.wiki: Implement global user CSS/JS module [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [08:52:13] (03CR) 10TTO: "Well... if someone can come up with a way to sensibly and reliably do this, it would be great. However, the commenters at the bug thought " [core] - 10https://gerrit.wikimedia.org/r/92263 (owner: 10TTO) [08:53:14] (03PS3) 10Zfilipin: UW sometimes takes time to process. Discussed on QA mail list http://lists.wikimedia.org/pipermail/qa/2013-November/000692.html Change-Id: I9d6c9c2b512957876edf9f7642acbef14ca655bb [qa/browsertests] - 10https://gerrit.wikimedia.org/r/96146 (owner: 10Cmcmahon) [08:53:40] (03CR) 10Zfilipin: [C: 032] UW sometimes takes time to process [qa/browsertests] - 10https://gerrit.wikimedia.org/r/96146 (owner: 10Cmcmahon) [09:11:10] (03PS1) 10Mwalker: First integration with bundler [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96448 [09:11:21] (03CR) 10Mwalker: [C: 032 V: 032] First integration with bundler [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96448 (owner: 10Mwalker) [09:15:27] (03PS1) 10Mwalker: New Renderer Status Types [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96449 [09:16:40] (03PS2) 10Hashar: update layout for next Zuul version [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93590 [09:17:32] (03CR) 10Hashar: [C: 032 V: 032] "Force merge Zuul being upgraded." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93590 (owner: 10Hashar) [09:21:48] (03CR) 10Pginer: [C: 04-1] "Thanks for your commit." [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 (owner: 10Sniok) [09:23:09] (03CR) 10Daniel Friesen: [C: 04-1] "This is a link from one wiki to another. And besides i18n the main page name may be customized individually by each wiki. We DO NOT know t" [core] - 10https://gerrit.wikimedia.org/r/96178 (owner: 10Jdlrobson) [09:26:48] (03CR) 10Daniel Friesen: [C: 031] Remove needless leading dash on Main Page interlanguage links [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [09:27:17] (03PS1) 10Mwalker: Allow setuid on startup [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96451 [09:27:25] (03CR) 10Mwalker: [C: 032 V: 032] Allow setuid on startup [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96451 (owner: 10Mwalker) [09:35:54] mwalker: sorry was upgrading Zuul [09:36:02] your change is going to be the first one tested with the new version [09:36:09] hashar: ooooh [09:36:20] 2013-11-20 09:36:07,552 INFO zuul.Gearman: Build started [09:36:20] I didn't actually know my new PDF repos had zuul jobs or not yet [09:36:21] \O/ [09:36:34] Zuul now uses Gearman to distribute jobs to Jenkins [09:36:57] I'm going to assume this allows us better, faster, and more reliable connections to the intertubes [09:37:37] indeed [09:46:00] whilst, I, being completely crazy... am making the new collection PDF renderer start via upstart [09:46:13] I'm not sure I hate upstart any less through this experience [09:57:25] Krinkle: nice catch thanks, gotta revert the Zuul upgrade apparently. [09:58:08] !log shutting down Zuul and reverting upgrade :-( [09:58:08] Wrong channel, try again. [10:00:12] (03PS1) 10Hashar: Revert "update layout for next Zuul version" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96453 [10:00:21] (03CR) 10Hashar: [C: 032 V: 032] Revert "update layout for next Zuul version" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96453 (owner: 10Hashar) [10:06:56] (03CR) 10Matthias Mullie: [C: 032] Add dummy GENDER to avoid translatewiki warnings [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96444 (owner: 10Amire80) [10:06:57] (03CR) 10jenkins-bot: [V: 04-1] Add dummy GENDER to avoid translatewiki warnings [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96444 (owner: 10Amire80) [10:14:37] hashar: Jenkins back to normal yet? [10:15:03] (03PS1) 10Siebrand: Break long lines and formatting updates for includes/db/ [core] - 10https://gerrit.wikimedia.org/r/96454 [10:15:10] James_F: almost [10:15:16] hashar: Kk. [10:16:21] James_F: yeah should be good now [10:16:26] hashar: Thanks! [10:16:45] Jenkins should be back in action now. Sorry. Had to revert my Zuul upgrade :-( [10:28:03] (03PS4) 10Hashar: Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [10:28:08] (03CR) 10Hashar: "Retriggering because of Jenkins outage" [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [10:28:23] (03PS4) 10Hashar: New hook to instrument page save failures [core] - 10https://gerrit.wikimedia.org/r/94512 (owner: 10Adamw) [10:28:59] (03CR) 10Hashar: "Retriggering because of Jenkins outage, might just work?" [core] - 10https://gerrit.wikimedia.org/r/94512 (owner: 10Adamw) [10:29:33] (03PS2) 10Hashar: Add dummy GENDER to avoid translatewiki warnings [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96444 (owner: 10Amire80) [10:29:50] (03CR) 10jenkins-bot: [V: 04-1] New hook to instrument page save failures [core] - 10https://gerrit.wikimedia.org/r/94512 (owner: 10Adamw) [10:31:18] (03PS1) 10Siebrand: Suppress false positive CodeSniffer warning [core] - 10https://gerrit.wikimedia.org/r/96456 [10:31:19] (03PS1) 10Siebrand: Remove function calls from for loop test part [core] - 10https://gerrit.wikimedia.org/r/96457 [10:35:16] (03PS1) 10Shirayuki: i18n: use "int:" for consistency [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96458 [10:37:36] (03CR) 10Matthias Mullie: [C: 032] Fix the activity-item-autoflag message [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96440 (owner: 10Amire80) [10:37:39] (03Merged) 10jenkins-bot: Fix the activity-item-autoflag message [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96440 (owner: 10Amire80) [10:39:58] (03CR) 10Ori.livneh: [C: 032] Added some sanity close() calls to RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/93866 (owner: 10Aaron Schulz) [10:40:29] (03CR) 10jenkins-bot: [V: 04-1] Added some sanity close() calls to RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/93866 (owner: 10Aaron Schulz) [10:43:01] (03PS1) 10Siebrand: Remove underscore from class names LBFactory_* [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 [10:46:42] (03PS2) 10Siebrand: Remove underscore from class names LBFactory_* [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 [10:47:05] Help!Problem MediaWiki-Vagrant (vagrant up) - err: /Stage[main]/Apt/Apt::Ppa[git-core/ppa]/Exec[add-apt-repository --yes ppa:git-core/ppa]/returns: change from notrun to 0 failed: Could not find command 'add-apt-repository' [10:50:33] (03PS3) 10Siebrand: Remove underscore from class names LBFactory_* [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 [10:52:11] (03PS1) 10Mwalker: Upstart Script [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96461 [10:52:30] aniuskad: I failed to parse your message. Steps to reproduce? [10:53:48] (03PS1) 10Shirayuki: i18n: use "int:" for consistency [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96462 [10:54:12] (03PS1) 10Siebrand: Remove underscore from class name LBFactory_* [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 [10:54:53] Thx andre_. What u mean Steps to reproduce? [10:55:09] aniuskad, you obviously pasted an error message here. [10:55:16] yes [10:55:17] very often, people do something before they get an error. [10:55:26] that would be called "steps to reproduc" [10:58:00] Ok. Trying to install Wikimedia dev env. Follow instructions. Latest version vagrant and VirtualBox. I have file with output of vagrant up. It fails - cannot find 'add-apt-repository' [10:58:50] I've got more errors but that is first one [11:02:03] (03CR) 10Hoo man: [C: 032] "This also could have been done via translatewiki, AFAIK" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96458 (owner: 10Shirayuki) [11:02:12] (03Merged) 10jenkins-bot: i18n: use "int:" for consistency [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96458 (owner: 10Shirayuki) [11:02:40] aniuskad, instructions on which page? URL welcome [11:02:58] and which exact last command did you enter, before you get that error? [11:03:10] Mediawiki-vagrant page [11:03:24] vagrant up [11:04:14] aniuskad: Are you on a Debian-like Linux distro? [11:05:40] RoanKattouw, No, Windows [11:06:51] aniuskad: can you run 'vagrant paste-puppet' and paste the URL here? [11:08:47] (03PS2) 10Siebrand: Remove underscore from class name LBFactory_* [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 [11:08:56] ori-l: http://dpaste.de/X7o4 [11:09:43] huh, that's odd [11:10:14] let me see [11:10:18] ori-l: why? [11:11:03] (03CR) 10Shirayuki: "Thanks for quick response." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96458 (owner: 10Shirayuki) [11:11:29] because the error you're seeing is happening on a fresh VM and should thus be reproducible [11:12:03] but it isn't, at least for me. which usually means either weird upstream bugs or (more likely in this case) race condition in package dependency fulfilment [11:12:27] aniuskad: can you run 'vagrant ssh' ? [11:13:37] ori-l: dont do anything [11:14:35] ori-l: I'm new in wikimedia so It is my first time doing it. [11:15:02] doing great so far, you just happen to be a bit unlucky [11:15:39] ok, try this: [11:15:48] ori-l: I've been tried for day. Now, it is doing better [11:15:55] (03PS1) 10Shirayuki: i18n: use "int:" for consistency [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/96467 [11:16:48] in your vagrant folder, there should be a subfolder called 'manifests', and in that folder there should be another subfolder called 'manifests.d' [11:17:15] can you create a file there called "extra.pp" and in it put: [11:17:21] package { 'python-software-properties': stage => first, } [11:17:24] just that line [11:17:37] and then save the file and re-run 'vagrant provision' [11:18:44] ori-l:No 'manifests' folder [11:19:32] err sorry, puppet / manifests / manifests.d [11:19:39] ok [11:19:43] (03PS3) 10Amire80: Add dummy GENDER to avoid translatewiki warnings [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96444 [11:24:13] (03CR) 10Matthias Mullie: [C: 032] Add dummy GENDER to avoid translatewiki warnings [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96444 (owner: 10Amire80) [11:24:41] (03Merged) 10jenkins-bot: Add dummy GENDER to avoid translatewiki warnings [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/96444 (owner: 10Amire80) [11:26:38] ori-l: Seems that command failed [11:26:50] which command? [11:26:57] 'vagrant provision'? [11:27:04] yes [11:27:06] can you run 'vagrant puppet-paste' again and paste the link again? [11:27:54] (03PS1) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [11:28:54] sorry, i have to go [11:29:10] if no one else can help you can try running 'vagrant destroy' and then 'vagrant up' to try again with a fresh machine [11:29:24] ori-l:http://dpaste.de/JnKe [11:29:55] aniuskad, a space between the colon and the URL would make the link clickable in an IRC client. [11:30:02] ori-l: Ok. thank for your help [11:30:35] ori-l: http://dpaste.de/JnKe [11:37:31] (03PS1) 10Shirayuki: i18n: use "int:" for consistency [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96471 [11:40:06] (03PS2) 10Siebrand: Remove underscore from classes LBFactory_*, LoadBalancer_*, LoadMonitor_* [core] - 10https://gerrit.wikimedia.org/r/96469 [11:42:16] (03PS4) 10Siebrand: Remove underscore from class names LBFactory_* [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 [11:42:21] (03PS3) 10Siebrand: Remove underscore from class names LBFactory_* [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 [11:43:05] (03CR) 10Siebrand: [C: 04-2] "Sticking a -2 on this for now until it's clear when the core patch can be merged." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/96463 (owner: 10Siebrand) [11:43:06] (03CR) 10Siebrand: [C: 04-2] "Sticking a -2 on this for now until it's clear when the core patch can be merged." [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/96460 (owner: 10Siebrand) [11:50:26] Can anyone help me find out the problem setting up new VM for Wikimedia? See link http://dpaste.de/HvAf [11:57:38] !log [11:57:38] Wrong channel, try again. [11:57:46] !wm log [11:57:46] There is no such key, you probably want to try: !botbrain2, !botnoob, !chansearch, !wikimedia, !wmf, !wmf-deployment, !wmo, !wm-bot, !reboot, !tryflow, !dirtydiffs, !parsoid-web, !parsoid-test, !logs, !wm-bot-ping, !htmllogs, [11:58:00] !logs [11:58:00] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [12:09:54] (03CR) 10Rillke: [C: 031] "an improvement" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96239 (owner: 10Bartosz Dziewoński) [12:11:00] (03PS2) 10Shirayuki: i18n: use "int:" for consistency [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96471 [12:14:35] (03PS2) 10Zfilipin: All MobileFrontend Jenkins jobs should send e-mail notification to the same addresses [selenium] - 10https://gerrit.wikimedia.org/r/96058 [12:21:45] (03PS4) 10Bartosz Dziewoński: Adding "whie logged in" in Mediawiki email notification [core] - 10https://gerrit.wikimedia.org/r/96365 (owner: 10Mayankmadan) [12:22:05] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks, looks okay to me now." [core] - 10https://gerrit.wikimedia.org/r/96365 (owner: 10Mayankmadan) [12:23:42] Any body have any idea why gerrit on firefox doesnt work well [12:30:50] has anyone settup Mediawiki dev env from Windows? [12:32:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] Fixed the last section of MediaWiki:SpecialSpecialpages (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96358 (owner: 10Mayankmadan) [12:35:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] Changing the welcome message after signing up (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96445 (owner: 10Mayankmadan) [12:36:57] mayankmadan: i reviewed and replied on https://www.google-melange.com/gci/task/view/google/gci2013/5833790190518272 :) [12:37:16] will fix these in 5- 10 min [12:37:32] aniuskad: it should be possible, but i'm afraid no one will be able to help if you run into any troubles [12:38:05] aniuskad: if you want to keep using windows (nothing wrong with that, i use windows myself), i suggest setting up a mediawiki installation in a virtual machine with linux [12:38:07] !vagrant [12:38:07] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [12:38:29] mediawiki-vagrant is a prepackaged VM image that includes everything you need :) [12:39:00] (03Merged) 10jenkins-bot: Adding "while logged in" in email notification [core] - 10https://gerrit.wikimedia.org/r/96365 (owner: 10Mayankmadan) [12:39:25] MatmaRex: I have problems with installation [12:40:42] for several day, I have been trying to install Mediakiki-vagrant without luck [12:42:00] MatmaRex: Could you check this link, please? http://dpaste.de/HvAf [12:42:56] (03CR) 10Bartosz Dziewoński: Supress native "invalid email" warning on Special:ChangeEmail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96195 (owner: 10Theopolisme) [12:43:09] (03CR) 10Bartosz Dziewoński: [C: 04-1] "See inline comments on previous patch." [core] - 10https://gerrit.wikimedia.org/r/96195 (owner: 10Theopolisme) [12:43:27] aniuskad: i have set up mediawiki-vagrant on windows 7 and 8 maybe a month ago [12:43:33] MatmaRex: I have a question about this task: http://www.google-melange.com/gci/task/view/google/gci2013/5270840237096960 . I am not sure whether I have to implement a dynamic count or I should change the '2' value to something bigger. [12:43:38] worked without problems then [12:44:22] aniuskad: sorry, i really have no experience with that :( ori-l might be able to help if he's online [12:44:43] MatmaRex: something is really wrong happening [12:45:43] MatmaRex: the last part has dissappeared [12:45:44] Ok, thanks MatmaRex [12:46:04] MegaAlex: i think niklas's comment 3 (https://bugzilla.wikimedia.org/show_bug.cgi?id=42497#c3) outlines the solution here [12:46:26] MegaAlex: you could try implementing the count, sure :) but i have no idea how easy/hard that could be [12:46:57] it might be impossible to do efficiently due to the way our database schema is set up [12:47:08] mayankmadan: "last part" of what? [12:48:11] tgr:Can u help? Can u see this link http://dpaste.de/HvAf? [12:48:25] aniuskad: seems like apt-add-repository command is missing from the VM, you could try to install it manually and re-run vagrant provision [12:49:01] or file a bug for mediawiki-vagrant, ultimately it seems to be a configuration problem [12:49:19] MatmaRex: http://imgur.com/Q2KQs7W [12:50:36] How install apt-add-repository from Windows? [12:51:03] you have to ssh into the virtual machine [12:51:22] (03CR) 10Bartosz Dziewoński: [C: 031] "Sane I guess. Thanks." [core] - 10https://gerrit.wikimedia.org/r/96373 (owner: 10Aude) [12:51:36] or open it in VirtualBox [12:52:07] mayankmadan: well, what did you do? [12:52:29] MatmaRex: i did nothing, i just downloaded the patch as it is written in gerrit [12:52:58] can you try to do it and see if its happening with you too? [12:53:17] mayankmadan: when i downloaded the patch, it looked like on the screenshot i linked [12:53:41] mayankmadan: maybe some bad version of the localisation got cached (we cache a lot of things), try running: [12:53:47] `php maintenance/update.php` [12:54:11] this is a script used when upgrading to newer mediawiki version, it's safe to run when you're not upgrading, and it should clear all caches mediawiki might use [12:56:59] tgr:I did it but don't found mediawiki. Where find it? [12:57:56] MatmaRex: I dont get the comment here https://gerrit.wikimedia.org/r/#/c/96358/2/languages/messages/MessagesQqq.php [13:01:07] aniuskad: you have to run vagrant provision to set up mediawiki & dependencies on the VM [13:01:34] and it will probably fail with the same error [13:01:53] so install apt-add-repository then run it [13:03:36] see http://stackoverflow.com/questions/13018626/add-apt-repository-not-found on how to do that (this has to be done inside the VM) [13:08:31] (03CR) 10Hoo man: "Sorry... somehow I thought this was a qqq message change... multitasking..." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/96458 (owner: 10Shirayuki) [13:08:56] trg: Thank u. I will see link and try [13:09:43] MatmaRex: what is the function of {{msg-mw|...} ? [13:11:15] mayankmadan: it links the other message in translatewiki.net translation interface. [13:12:31] mayankmadan: for example: https://translatewiki.net/w/i.php?title=MediaWiki:Loginreqlink/es&action=edit – the qqq message is displayed above the edit form [13:12:31] do i wrap it like this:- {{msg-mw|Heading for specialpages-note}} [13:12:42] do i wrap it like this:- {{msg-mw|Heading for specialpages-note}} [13:12:51] MatmaRex, ^ [13:12:52] no, just wrap the message name. [13:14:26] MatmaRex: this:- {{msg-mw|specialpages-note-top}} [13:15:55] mayankmadan: Heading for {{msg-mw|specialpages-note}} [13:16:00] just think about this for a minute. [13:16:02] hashar: Good morning/afternoon. Do you have time to help me with getting Jenkins doing tests for the PDF sprint? I think I've got it figured out, but I'm not entirely sure I have it right. [13:16:39] anomie: specific extensions? [13:17:03] anomie: are the tests using UnitTestList php hook and running with phpunit.php from core ? [13:17:29] MatmaRex: i still dont get it [13:17:41] what is the function of msg-mw in translating? [13:17:52] hashar, aude: Well, we want to test the OCG branch of the Collection extension (in addition to master). And then we have some nodejs repos that we want to be running tests for, no PHP in them. [13:20:53] hashar: For the OCG branch, it looks like I can just add a block under "Extra jobs for specific extensions" in mediawiki-extensions.yaml specifying name, ext-name, and mwbranch? That at least seems to make jenkins-jobs generate a mwext-Collection-testextensions-OCG job in addition to mwext-Collection-testextensions-master. [13:21:25] anomie: i think you can put it once [13:21:35] it will run tests on all the branches in the extension [13:22:48] (03PS3) 10Mayankmadan: Fixed the last section of MediaWiki:SpecialSpecialpages [core] - 10https://gerrit.wikimedia.org/r/96358 [13:22:59] anomie: the testextensions job setup mediawiki, install the extension and then run the phpunit.php --testsuite extension wrapper [13:23:28] anomie: we need a new job to run the nodejs tests. [13:24:41] oh my [13:24:44] two README files .. [13:25:01] hashar: For the nodejs tests, I'm told that the job should run "npm test". Would it be right to basically copy the builder for jshint in macro.yaml and change the shell bit to run "npm test" instead of the two jshint commands? [13:25:58] (and then add corresponding job-templates, and then reference them from mediawiki-extensions.yaml) [13:26:19] do the nodejs test depends on having mediawiki + Collection installed ? [13:26:27] and doing some API tests locally maybe ? [13:26:46] (03PS2) 10Mayankmadan: Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 [13:26:56] MatmaRex: Now its done [13:27:15] (03CR) 10Manybubbles: [C: 04-1] "Going to have to reexamine. Please hold off on reviewing...." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [13:27:45] The node tests aren't actually written yet, but the nodejs repos are intended to run standalone. But I suppose they might make API calls out, unless we mock that part. [13:28:23] anomie: so as a first step, you could add a placeholder to let us execute 'npm test' [13:28:23] (03PS1) 10Aklapper: Bring WeeklyReport extension code closer to upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96479 [13:28:56] then in jenkins job builder configuration, get a new npm-test builder macro that would shell: "npm test" [13:29:42] (03PS1) 10Anomie: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 [13:29:59] hashar: So, like https://gerrit.wikimedia.org/r/96480 ? [13:30:04] looking [13:31:13] there are several extensions ? [13:31:39] mediawiki/extensions/Collection/OfflineContentGenerator/bundler [13:31:40] mediawiki/extensions/Collection/OfflineContentGenerator/latex_renderer [13:31:40] mediawiki/extensions/Collection/OfflineContentGenerator/node_modules [13:31:41] indeeed :D [13:32:13] Yeah. If I understand the layout correctly, "node_modules" is the manager, "bundler" is the bit that downloads pages from the wiki, and then "latex_renderer" takes that downloaded data and makes a PDF. [13:32:28] Then at some point there might be "epub_renderer" and so on. [13:32:57] change looks fine at a first glance [13:33:09] expanding the XML locally [13:35:55] (03PS1) 10Sniok: Added cross-browser PNG version fallback [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96481 [13:38:18] anomie: ah the mwbranch is confusing. I guess both master and OCG branches are running the phpunit test the same way aren't they? [13:39:30] (03Abandoned) 10Sniok: Added cross-browser PNG version fallback [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96481 (owner: 10Sniok) [13:39:49] anomie: I also need a Jenkins slave with npm. setting one up [13:40:02] Yeah, I'm not entirely sure what changes are intended for the OCG branch instead of being put in master, but right now the only difference is that the OCG branch adds a submodule that isn't referenced anywhere yet. [13:40:35] I am not sure whether submodules are processed in extensions [13:40:44] (I think the general idea is to work in the OCG branch and then eventually merge it back into master once it works and we can do full code review) [13:41:05] make sense [13:45:14] (03PS2) 10Sniok: Adding HiDPI 'Heart' SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 [13:47:01] (03PS1) 10devunt: Revert "Kranitor: Make JSHint pass" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/96482 [13:47:36] (03PS3) 10Sniok: Adding HiDPI 'Heart' SVG icon [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/96356 [13:48:11] (03CR) 10Aklapper: [C: 031] "Tested on boogs.wmflabs.org after symlinking the two .cgi's (see https://bugzilla.wikimedia.org/show_bug.cgi?id=56091#c2 ) on boogs.wmflab" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96479 (owner: 10Aklapper) [13:58:40] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks, looks okay now." [core] - 10https://gerrit.wikimedia.org/r/96358 (owner: 10Mayankmadan) [14:00:25] anomie: I need a Jenkins slave in labs with npm installed. I created the instance integration-slave01 for that [14:00:37] got to get the puppet role class merged in though https://gerrit.wikimedia.org/r/96483 [14:01:51] (03Merged) 10jenkins-bot: Fixed the last section of MediaWiki:SpecialSpecialpages [core] - 10https://gerrit.wikimedia.org/r/96358 (owner: 10Mayankmadan) [14:03:43] (03PS1) 10Siebrand: Break long lines in MWDebug class [core] - 10https://gerrit.wikimedia.org/r/96485 [14:05:17] (03PS2) 10Hashar: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [14:06:38] (03CR) 10Bartosz Dziewoński: [C: 04-1] Changing the welcome message after signing up (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96445 (owner: 10Mayankmadan) [14:06:39] (03CR) 10Hashar: "Made the npmtest job to be tied to the new Jenkins node label 'hasNpm'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [14:07:01] mayankmadan: ^^ [14:07:17] anomie: so yeah entirely doable. gotta get out for a haircut, will be back in 1+ hour [14:07:25] MatmaRex: will do it quickly [14:07:32] hashar: ok, I'll be here [14:07:44] anomie: got to have puppet change https://gerrit.wikimedia.org/r/96483 merged in, ariel told me he will look at it in a few minutes [14:07:55] meanwhile the slaev is building [14:08:11] MatmaRex: what should i use as my link text? [14:08:17] preferences? [14:08:23] mayankmadan: be creative :) [14:08:37] MatmaRex: how about preferences? :) [14:12:23] (03PS3) 10Mayankmadan: Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 [14:13:03] (03CR) 10jenkins-bot: [V: 04-1] Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 (owner: 10Mayankmadan) [14:21:53] (03PS4) 10Mayankmadan: Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 [14:22:33] (03CR) 10jenkins-bot: [V: 04-1] Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 (owner: 10Mayankmadan) [14:26:40] (03PS5) 10Mayankmadan: Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 [14:27:03] MatmaRex: How about now? [14:27:04] (03CR) 10Bartosz Dziewoński: "Done." [core] - 10https://gerrit.wikimedia.org/r/89488 (owner: 10Bartosz Dziewoński) [14:27:13] (03PS3) 10Bartosz Dziewoński: IcuCollation: Add CollationCkb subclass for Sorani Kurdish [core] - 10https://gerrit.wikimedia.org/r/95867 [14:27:13] (03PS5) 10Bartosz Dziewoński: IcuCollation: Sort digits under localised digits' headings [core] - 10https://gerrit.wikimedia.org/r/89488 [14:27:22] (03CR) 10jenkins-bot: [V: 04-1] Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 (owner: 10Mayankmadan) [14:27:23] (03CR) 10Bartosz Dziewoński: "Rebased, replied." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95867 (owner: 10Bartosz Dziewoński) [14:27:38] (03CR) 10Bartosz Dziewoński: "(Tested, btw, works as expected.)" [core] - 10https://gerrit.wikimedia.org/r/95867 (owner: 10Bartosz Dziewoński) [14:28:34] mayankmadan: the tests are failing… you probably have some typo that breaks the syntax [14:28:41] ah, no [14:28:46] "This change was unable to be automatically merged with the current state of the repository" [14:28:57] i dont know what to do with that [14:28:58] well, i told you why, you have accidental unrelated changes in the language file. [14:29:06] undo them [14:29:15] (or submit the patch from scratch) [14:29:51] yeah [14:31:47] (03PS6) 10Mayankmadan: Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 [14:31:57] MatmaRex: Now its done [14:32:52] MatmaRex: i would be away for sometime now, if the patch submitted is correct then please close the task... Thank you :) [14:43:39] (03PS3) 10Anomie: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 [14:44:24] (03CR) 10Anomie: "PS3: Change "hasSlaveScripts" to "hasNpm" in mediawiki-extensions.yaml too" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [14:45:18] MatmaRex: was the patch good? [14:45:39] (03CR) 10Bartosz Dziewoński: [C: 032] "Alright, let's do this." [core] - 10https://gerrit.wikimedia.org/r/96445 (owner: 10Mayankmadan) [14:47:05] (03Abandoned) 10Bartosz Dziewoński: Replacing please hit back and reload with click the submit button [core] - 10https://gerrit.wikimedia.org/r/96370 (owner: 10Mayankmadan) [14:47:07] MatmaRex: is there a problem? [14:48:05] mayankmadan: no, it looks okay to me :) [14:48:26] mayankmadan: i abandoned the other patch, the one siebrand -1'd, since it seems you do not care about it anymore? [14:48:42] (03Merged) 10jenkins-bot: Changing the welcome message after signing up [core] - 10https://gerrit.wikimedia.org/r/96445 (owner: 10Mayankmadan) [14:49:55] !logs [14:49:55] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [14:51:41] (03CR) 10Chad: [C: 032] Switch shard startup monitoring using health api [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96366 (owner: 10Manybubbles) [14:51:49] (03Merged) 10jenkins-bot: Switch shard startup monitoring using health api [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96366 (owner: 10Manybubbles) [14:52:40] !logs [14:52:40] channel logs: http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki/ html version: http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [14:54:35] Thanks MatmaRex [14:55:25] (03CR) 10Addshore: [C: 031] Add tests for SpecialPage::requireLogin [core] - 10https://gerrit.wikimedia.org/r/96373 (owner: 10Aude) [15:06:28] (03PS1) 10Manybubbles: Only retry on connection errors [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/96492 [15:07:45] (03PS2) 10Manybubbles: Only retry on connection errors [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/96492 [15:10:10] (03CR) 10Manybubbles: "On closer examination point #2 is not needed. Yay! Less code! Let me remove it and re-verify." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [15:16:43] (03PS1) 10Matthias Mullie: (bug 57162) red links don't work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 [15:21:42] (03PS2) 10Manybubbles: Tighter error handling in updateSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 [15:22:14] (03CR) 10Manybubbles: "All done reexamining. Ready for review." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [15:22:21] (03PS3) 10Manybubbles: Tighter error handling in updateSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 [15:28:22] is there any mock library included with mediawiki? [15:30:00] tgr: isn't that the job of phpunit? [15:30:20] phpunit mocks suck [15:30:35] there are several libraries which fix that [15:30:49] phake, mockery are the popular ones [15:31:39] (03PS4) 10Manybubbles: Tighter error handling in updateSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 [15:31:42] Interesting factoid: the 1.22.0 release date, November 29, is my birthday. [15:31:50] it would be nice having at least one of them in core [15:32:02] (03CR) 10Manybubbles: "Rebased. Yummy." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [15:33:18] phpunit sucks [15:33:20] mocks suck [15:33:25] ftfy. :D [15:33:54] (03CR) 10Hashar: "Thanks! Deployed the job, working on Zuul config." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [15:34:22] (03PS1) 10Cscott: Re-add image support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96495 [15:34:22] HectorAE: another factoid: there's an open GCI task to prettify the 1.22 release page mediawiki.org, due by that date. :) [15:35:03] (03CR) 10Matthias Mullie: [C: 032] Fix double-username issue on RecentChanges items. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96418 (owner: 10Werdna) [15:35:21] (03Merged) 10jenkins-bot: Fix double-username issue on RecentChanges items. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96418 (owner: 10Werdna) [15:35:55] (03CR) 10Cscott: [C: 032 V: 032] Add resource URL to the imageinfo db. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96436 (owner: 10Cscott) [15:36:00] MatmaRex, that's what I'm working on right now, actually. [15:36:11] That's how I know. [15:36:31] oh, haha [15:36:33] :D [15:36:33] (03CR) 10Matthias Mullie: [C: 032] Timestamp in boardy history doesn't switch to absolute on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96398 (owner: 10Bsitu) [15:36:39] (03CR) 10Cscott: [C: 032 V: 032] Re-add image support. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96495 (owner: 10Cscott) [15:36:46] (03Merged) 10jenkins-bot: Timestamp in boardy history doesn't switch to absolute on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96398 (owner: 10Bsitu) [15:37:11] (03PS1) 10Hashar: trigger mwext-Collection-testextensions-master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96496 [15:38:40] (03PS2) 10Matthias Mullie: Moderated post/topic styling: * Actually apply classes that were supposed to be applied. * Remove coloured icons on hover; they falsely imply that the element is hot. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95986 (owner: 10Werdna) [15:42:15] (03CR) 10Hashar: [C: 032] trigger mwext-Collection-testextensions-master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96496 (owner: 10Hashar) [15:42:21] (03Merged) 10jenkins-bot: trigger mwext-Collection-testextensions-master [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96496 (owner: 10Hashar) [15:44:35] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/96497 [15:47:43] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96498 [15:55:05] (03PS1) 10Hashar: trigger mwext-Collection-testextensions-OCG (OCG branch) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96500 [15:56:18] (03PS1) 10Cscott: Improve documentation comments. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96501 [15:58:30] (03PS2) 10Hashar: trigger mwext-Collection-testextensions-OCG (OCG branch) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96500 [15:59:21] (03CR) 10Hashar: [C: 032] "lets break Zuul" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96500 (owner: 10Hashar) [15:59:30] (03Merged) 10jenkins-bot: trigger mwext-Collection-testextensions-OCG (OCG branch) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96500 (owner: 10Hashar) [15:59:52] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96498 [15:59:58] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96498 (owner: 10Hashar) [16:00:07] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/96497 [16:01:20] (03PS1) 10Matthias Mullie: Moderation buttons should have gray icon by default, colored on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96502 [16:02:20] (03CR) 10Matthias Mullie: [C: 032] "EBernhardson: I've pushed https://gerrit.wikimedia.org/r/#/c/96502/ for these moderation icons you mentioned" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95986 (owner: 10Werdna) [16:02:30] (03Merged) 10jenkins-bot: Moderated post/topic styling: * Actually apply classes that were supposed to be applied. * Remove coloured icons on hover; they falsely imply that the element is hot. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95986 (owner: 10Werdna) [16:02:54] (03CR) 10Matthias Mullie: [C: 032] Workaround for relative links in /w/index.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96189 (owner: 10EBernhardson) [16:03:09] (03CR) 10Matthias Mullie: [C: 032] Load parsoid content as XML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96182 (owner: 10EBernhardson) [16:03:12] (03Merged) 10jenkins-bot: Workaround for relative links in /w/index.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96189 (owner: 10EBernhardson) [16:03:21] (03Merged) 10jenkins-bot: Load parsoid content as XML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96182 (owner: 10EBernhardson) [16:03:58] (03CR) 10Matthias Mullie: [C: 032] "We lose the baseURI (which is in head), but we're not doing anything with it anyway..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96180 (owner: 10EBernhardson) [16:04:52] (03CR) 10jenkins-bot: [V: 04-1] Request just the from parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96180 (owner: 10EBernhardson) [16:05:57] why on earth am I so stupid [16:06:23] (03PS2) 10Matthias Mullie: Request just the from parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96180 (owner: 10EBernhardson) [16:06:32] (03CR) 10Matthias Mullie: [C: 032] Request just the from parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96180 (owner: 10EBernhardson) [16:06:45] (03Merged) 10jenkins-bot: Request just the from parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96180 (owner: 10EBernhardson) [16:09:22] (03PS4) 10Hashar: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [16:09:29] !g Id29ecd03394e8b3bf6b790aa5ce14112ad2c8b8a [16:09:29] https://gerrit.wikimedia.org/r/#q,Id29ecd03394e8b3bf6b790aa5ce14112ad2c8b8a,n,z [16:10:14] (03PS1) 10Hashar: Revert "trigger mwext-Collection-testextensions-OCG (OCG branch)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96506 [16:10:24] (03CR) 10Hashar: [C: 032] Revert "trigger mwext-Collection-testextensions-OCG (OCG branch)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96506 (owner: 10Hashar) [16:10:40] (03Merged) 10jenkins-bot: Revert "trigger mwext-Collection-testextensions-OCG (OCG branch)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96506 (owner: 10Hashar) [16:10:43] (03CR) 10Jhall: [C: 031] All MobileFrontend Jenkins jobs should send e-mail notification to the same addresses [selenium] - 10https://gerrit.wikimedia.org/r/96058 (owner: 10Zfilipin) [16:11:34] (03CR) 10Hashar: "the mwbranch parameter refers to mediawiki/core branch. OGC branch does not exist in mediawiki/core :D" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [16:12:18] (03CR) 10Tpt: "Note: The change won't affect, I think, wgContentLanguage for Translate extension pages. The only affected pages will be, I believe, Wikib" [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [16:12:36] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96498 [16:12:42] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/96497 [16:13:13] anomie: we have Collection phpunit tests jobs running now. [16:13:18] anomie: next step is inserting the npmtest one [16:13:25] hashar: \o/ [16:13:56] (03PS1) 10Anomie: Add testing for Collection OCG nodejs modules [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96507 [16:13:57] they are for the submodules right ? [16:14:11] hashar: https://gerrit.wikimedia.org/r/96507 should work, I think? [16:14:11] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/96497 (owner: 10Hashar) [16:14:14] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96498 (owner: 10Hashar) [16:15:37] anomie: looking [16:15:56] hah, I think I forgot to fix my email address on that... [16:15:58] anomie: yeah that might works [16:16:16] (03PS2) 10Anomie: Add testing for Collection OCG nodejs modules [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96507 [16:17:05] anomie: maybe we should fail the build early on if it doesn't pass jshint ? [16:17:26] and if it pass, then trigger the npmtest job [16:17:36] this way it fails early and report back to Gerrit faster [16:17:40] hashar: Hmm. Could do so, yeah. [16:17:52] add a column at the end of jslint entries [16:17:56] and indent the npmtest below [16:18:13] on core, there is a chain where we will don't bother running test on php -l failure [16:19:00] (03PS3) 10Anomie: Add testing for Collection OCG nodejs modules [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96507 [16:19:20] s/column/colon/ ? [16:20:19] yeah Colon (punctuation) [16:20:55] in french it is "deux-points" == "two dots" [16:21:28] … "trios petits points" aka "three little dots" or maybe "three small dots" [16:21:47] I've heard people who don't know the name "colon" call it "two dots" in English too. What's semicolon in French? [16:22:00] or "point de suspension" which is the french formal equivalent of "ellipsis" [16:22:06] https://en.wikipedia.org/wiki/Three_Little_Pigs [16:22:18] semi colon is "point virgule" aka "dot comma" [16:22:23] (03PS1) 10Siebrand: Replace deprecated with [core] - 10https://gerrit.wikimedia.org/r/96508 [16:22:42] "point-virgule" exactly thanks wikipedia https://fr.wikipedia.org/wiki/; [16:23:17] That's exactly what I've heard people call it in English when they're not sure about the name "semicolon". Neat! [16:23:35] * anomie finds language stuff like this interesting [16:24:01] (03PS4) 10Hashar: Add testing for Collection OCG nodejs modules [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96507 (owner: 10Anomie) [16:25:02] (03PS1) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96509 [16:25:07] anomie: the jobs in jenkins are named OnlineContentGenerator while the one in Zuul are OFFLINEGenerator [16:25:08] :( [16:25:19] hashar: D'oh. That's me being dumb. [16:25:33] Should be "Offline" [16:25:40] !g I3043f827c57c72799eb5c5a5abf291c825e1addf [16:25:40] https://gerrit.wikimedia.org/r/#q,I3043f827c57c72799eb5c5a5abf291c825e1addf,n,z [16:25:48] amend that one , will refresh the jobs :] [16:26:18] (03PS1) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [16:27:55] (03PS5) 10Anomie: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 [16:29:10] hashar: amended [16:29:26] good to see you doing zuul/jjb changes :-] [16:29:46] (03CR) 10Anomie: Add tests for the Collection OCG (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [16:30:24] (03CR) 10Umherirrender: Cleanup and expand Status tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95620 (owner: 10Addshore) [16:30:29] (03CR) 10Hashar: [C: 04-1] Add tests for the Collection OCG (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [16:30:33] anomie: wil amend again [16:31:05] (03PS6) 10Hashar: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [16:31:11] oops [16:31:19] yeah that is cumbersome with Gerrit [16:31:25] you have to remember to fetch the latest patchset [16:32:25] (03CR) 10Hashar: "deploying them." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [16:32:38] (03CR) 10Hashar: [C: 032] Add testing for Collection OCG nodejs modules [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96507 (owner: 10Anomie) [16:32:48] (03Merged) 10jenkins-bot: Add testing for Collection OCG nodejs modules [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96507 (owner: 10Anomie) [16:33:35] Someone with puppet-vagrat experience ???? [16:34:43] (03CR) 10MaxSem: [C: 032] Writer was not passed to the API constructor [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96361 (owner: 10Mwalker) [16:34:49] (03Merged) 10jenkins-bot: Writer was not passed to the API constructor [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96361 (owner: 10Mwalker) [16:35:47] (03CR) 10MaxSem: [C: 032] New Renderer Status Types [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96449 (owner: 10Mwalker) [16:35:56] (03Merged) 10jenkins-bot: New Renderer Status Types [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96449 (owner: 10Mwalker) [16:41:06] (03CR) 10Reedy: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table (031 comment) [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [16:44:00] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 [16:44:21] (03PS1) 10Cscott: Rename image files to have TeX-safe filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96514 [16:44:46] (03CR) 10Cscott: [C: 032 V: 032] Improve documentation comments. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96501 (owner: 10Cscott) [16:44:47] (03CR) 10Addshore: Cleanup and expand Status tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95620 (owner: 10Addshore) [16:44:55] anomie: https://gerrit.wikimedia.org/r/96513 is made against extensions/Collection/OfflineContentGenerator/bundler to try out jenkins [16:45:11] (03CR) 10Cscott: [C: 032 V: 032] Rename image files to have TeX-safe filenames. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96514 (owner: 10Cscott) [16:46:20] anomie: moauaa facing a Zuul bug :-/ [16:46:27] NoSuchPathError: /srv/ssd/zuul/git/mediawiki/extensions/Collection/OfflineContentGenerator/latex_renderer [16:46:46] I had that issue with some fundraising repo already [16:50:28] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 [16:50:29] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 (owner: 10Hashar) [16:51:03] Need someone with experiece vagrant-puppet [16:52:54] (03CR) 10Njw: [C: 032 V: 032] Release v1.6 [skins/erudite] - 10https://gerrit.wikimedia.org/r/96273 (owner: 10Njw) [16:53:33] aniuskad: you can ask on the qa-l mailing list :-] [16:53:46] hashar: Hmm. I just found out we have another repo to test, and that node_modules repo shouldn't be tested. Sigh. Should I amend 96480 or submit a followup? [16:54:08] aniuskad: https://lists.wikimedia.org/mailman/listinfo/qa [16:54:25] !g 96480 [16:54:25] https://gerrit.wikimedia.org/r/#q,96480,n,z [16:54:44] anomie: amend it :-] [16:54:56] anomie: I usually don't merge jjb changes until I validated they are working [16:55:01] merging in is not needed to deploy the jobs [16:56:05] (03PS7) 10Anomie: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 [16:57:53] (03PS1) 10Anomie: Adjust Collection OCG testing [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96516 [16:58:05] hashar: Done. Also https://gerrit.wikimedia.org/r/96516 to adjust zuul. [17:02:19] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 [17:02:34] mwext-Collection-OfflineContentGenerator-bundler-jslint: SUCCESS (non-voting) [17:02:34] !! [17:02:35] [17:03:15] \o/ And since it passed, we can make it voting [17:03:26] npm one at https://integration.wikimedia.org/ci/job/mwext-Collection-OfflineContentGenerator-bundler-npmtest/1/ [17:03:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 (owner: 10Hashar) [17:03:52] mocha not found hehe [17:03:58] on bundler [17:04:04] I guess npm test doesn't install dependencies [17:04:10] * anomie does not much like npm [17:04:52] I can add you to the integration labs project so you will be able to look at the Jenkins slave in labs [17:06:26] I have no clue how npm works, so can't really make it to install the dev dependencies referenced in that package.json [17:07:07] hashar: Is it safe to have the shell script do "npm install" before "npm test"? That downloads npm packages from the network, which is why it might be iffy. [17:07:22] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 [17:07:25] can't npm test depends on npm install ? [17:07:31] that would trigger it automatically [17:07:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 (owner: 10Hashar) [17:08:31] else we can add "npm install" in the npmtest macro [17:08:33] hashar: Or else we can just say that every module with "npm test" has to have a git submodule for its node_modules directory that has mocha and whatever pre-installed. [17:08:35] or get a npm install macro [17:08:49] fetching from the network is fine to me [17:08:51] hashar: "add 'npm install' in the npmtest macro" was what I was asking [17:08:53] since that is on labs [17:08:58] multiple people are already doing it [17:09:07] so yeah update the macro [17:09:08] done :] [17:09:10] (03PS3) 10Tpt: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 [17:09:39] (03CR) 10Tpt: "Use wfWaitForSlaves();" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [17:09:55] coffee, bb in a few [17:11:58] hashar: It sounds like the people using node would rather have the node_modules submodule. So I think I need to amend the npmtest job template to use use-remote-zuul instead of use-remote-zuul-no-submodules? [17:12:54] (03PS4) 10Tpt: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 [17:16:50] anomie: yup that should fetch the submodulees [17:17:03] (03PS8) 10Anomie: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 [17:17:05] anomie: you might have to make the npmtest non voting as well [17:17:12] cause they are currently preventing change to enter in [17:17:17] there is some example in zuul config [17:17:46] will do it [17:17:47] and leav [17:17:48] e [17:19:02] hashar: Hmm. If we tell zuul to run mwext-Collection-OfflineContentGenerator-npmtest for changes to bundler, would that do what it seems like? I.e. check out mediawiki/extensions/Collection/OfflineContentGenerator and its submodules (of which bundler is one) and run npm test on that instead of bundler specifically? [17:19:34] (03PS1) 10Hashar: npmtest jobs are now non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96521 [17:19:41] (03CR) 10Hashar: [C: 032] npmtest jobs are now non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96521 (owner: 10Hashar) [17:19:57] (03Merged) 10jenkins-bot: npmtest jobs are now non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96521 (owner: 10Hashar) [17:20:53] anomie: i have made npmtest jobs non voting, that would not block folks [17:21:26] (03PS1) 10Cscott: Convert gifs to pngs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96522 [17:21:40] hashar: Or, is there a way to get Jenkins to check out some arbitrary node_modules module (in this case mediawiki/extensions/Collection/OfflineContentGenerator/node_modules, but other people might want to use npmtest in the future) before running npm test? [17:21:48] (03CR) 10Cscott: [C: 032 V: 032] Convert gifs to pngs. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96522 (owner: 10Cscott) [17:21:57] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96523 [17:22:01] anomie: might be possible [17:22:13] or add the node_modules as a submodule repository in each of the renderer [17:22:29] all those dependencies are nasty to integrate though [17:22:38] ideally we would all repositories run all the tests probably [17:22:49] the issue is applying the patchset that triggered it to the correct path [17:23:45] anomie: off sorry, got to get my bike form repair store then dad duties [17:24:09] if anything is horribly broke, text me on my phone (it is in my signature on engineering list mail or on office wiki [17:24:17] hashar: ok. Can you point me to anyone else who knows about this that I can bug? ;) [17:24:24] maybe Timo [17:24:26] not sure [17:25:08] you can write down your idea somewhere on the wiki or by email and then we can have expand from there [17:25:22] in a hurry sorry .. [17:26:04] (03PS5) 10Tpt: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 [17:26:06] (03PS1) 10Cscott: Initial contents of node_modules for OCG/bundler. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96524 [17:27:08] (03PS1) 10Cscott: Check out OCG/node_modules as a git submodule. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96525 [17:43:44] (03CR) 10Cscott: [C: 032 V: 032] Initial contents of node_modules for OCG/bundler. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96524 (owner: 10Cscott) [17:45:55] (03CR) 10Tpt: "Revert patch set 3: there is no limit in UPDATE: statement so this implementation doesn't works." [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [17:46:34] Hi cscott, how's it going? Let me know when you have a sec? Thanks...! [17:47:18] (03CR) 10Cscott: [C: 032 V: 032] "Sure, let's try it this way." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96525 (owner: 10Cscott) [17:47:53] (03PS4) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 (owner: 10Hashar) [17:49:46] (03PS5) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96513 (owner: 10Hashar) [17:56:29] (03CR) 10Jdlrobson: [C: 032] "I'd still prefer for it to be consistent with other pages but definitely an improvement on before" [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [17:57:07] (03Abandoned) 10Jdlrobson: Correct language tooltips for main page [core] - 10https://gerrit.wikimedia.org/r/96178 (owner: 10Jdlrobson) [18:00:11] (03Merged) 10jenkins-bot: Remove needless leading dash on Main Page interlanguage links [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [18:02:21] (03CR) 10BryanDavis: [C: 04-1] input-field-size (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [18:03:34] (03PS1) 10Anomie: Check out OCG/node_modules as a git submodule. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96529 [18:03:53] (03CR) 10Anomie: [C: 032 V: 032] Check out OCG/node_modules as a git submodule. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96529 (owner: 10Anomie) [18:04:04] (03PS2) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 (owner: 10Hashar) [18:10:09] (03PS1) 10Anomie: Test (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96530 [18:14:05] (03CR) 10Tpt: [C: 04-1] "Thanks a lot! (and sorry for the late answer) I've highlighted some small issues." (032 comments) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/96185 (owner: 10Lyumn) [18:27:33] (03PS1) 10Anomie: Fix jshint errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 [18:34:25] MatmaRex, Krenair: https://gerrit.wikimedia.org/r/79917 would be great to get in [18:37:24] marktraceur: i need to implement a C program that can solve a set of up to four linear equations by tomorrow :( [18:37:50] (and another one to implement multiplication of two arbitrarily large numbers, in plain C too of course) [18:37:54] incredibly boring stuff [18:38:45] (03CR) 10EBernhardson: "Somewhat concerned over liner round trip requirements" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96494 (owner: 10Matthias Mullie) [18:39:47] MatmaRex: Aw, well, good luck :) [18:40:35] Warning: DOMDocument::load(): I/O warning : failed to load external entity "/var/www/DevWiki/core/languages/data/plurals.xml" in /var/www/DevWiki/core/includes/cache/LocalisationCache.php on line 603 [18:40:36] Warning: DOMDocument::load(): I/O warning : failed to load external entity "/var/www/DevWiki/core/languages/data/plurals-mediawiki.xml" in /var/www/DevWiki/core/includes/cache/LocalisationCache.php on line 603 [18:40:39] * AaronSchulz hmms [18:40:46] entry-level computer science classes are stupid. :P [18:45:30] (03PS1) 10EBernhardson: Add missing documentation on performs-write param [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96541 [18:46:04] (03PS1) 10Siebrand: Update documentation and formatting for includes/deferred/ [core] - 10https://gerrit.wikimedia.org/r/96542 [18:46:05] (03PS1) 10Siebrand: Update documentation in HTMLCacheUpdateJob [core] - 10https://gerrit.wikimedia.org/r/96543 [18:46:36] (03PS2) 10Siebrand: Update documentation in HTMLCacheUpdateJob [core] - 10https://gerrit.wikimedia.org/r/96543 [18:50:10] MatmaRex: Hi, me again :) [18:51:42] (03CR) 10Siebrand: "'interlanguage-link-title-langonly' should be added to the optionals array in maintenance/languages/messageTypes.inc." [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [18:53:16] MatmaRex: aww; well, it could be worse, I had to do such stuff in Pascal at some point :P [18:53:50] hi ojorgensen, what's up? [18:53:51] (03PS7) 10BryanDavis: [HEAVY WIP] Add varnish role [vagrant] - 10https://gerrit.wikimedia.org/r/87623 (owner: 10Yuvipanda) [18:55:32] (03CR) 10Aaron Schulz: [C: 032] Update documentation in HTMLCacheUpdateJob [core] - 10https://gerrit.wikimedia.org/r/96543 (owner: 10Siebrand) [18:58:30] (03PS1) 10Umherirrender: Truncate protect reason for whole multibyte characters [core] - 10https://gerrit.wikimedia.org/r/96546 [18:59:00] (03CR) 10Parent5446: "What IAlex said. I tested this before merging and the parameters worked." [core] - 10https://gerrit.wikimedia.org/r/96253 (owner: 10IAlex) [18:59:10] (03Merged) 10jenkins-bot: Update documentation in HTMLCacheUpdateJob [core] - 10https://gerrit.wikimedia.org/r/96543 (owner: 10Siebrand) [19:00:04] csteipp, am I missing something or did you forget to hit the attach button? [19:00:38] (03CR) 10Parent5446: [C: 032] Add tests for SpecialPage::requireLogin [core] - 10https://gerrit.wikimedia.org/r/96373 (owner: 10Aude) [19:00:57] Hmm... it's attached in my outbox... so it fell off somewhere upstream from me [19:01:16] mediawiki-l may not allow attachements [19:02:37] MatmaRex: when trying to install mediawiki, the only choosable database is mysql. I'm experiencing lots of problems with mysql, so I want to use sqlite. I have installed sqlite, so why wont it show up? [19:02:57] do i need a particular extension to enable embedded videos in a wiki? [19:03:10] Hi, does anyone have a sec to +2 a couple patches? Submitted by Cscott for the EP extension, I reviewed both, and Raimond Spekking also reviewed one of them. However I don't have +2 ability (yet). They're relatively minor, and it would be nice to get them merged. https://gerrit.wikimedia.org/r/#/c/94932/ https://gerrit.wikimedia.org/r/#/c/94926/ Thanks in advance! [19:03:28] (03PS1) 10Cscott: Properly support foreign file repos (particular commons). [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96547 [19:03:29] (03PS1) 10Cscott: Whitespace fixes. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96548 [19:03:30] (03PS1) 10Cscott: Sync to version of db.js in mw-latexer. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96549 [19:04:16] Krenair: http://pastebin.com/cifbq6w1 in case you see anyone else looking for it [19:04:28] ok [19:04:35] (03Merged) 10jenkins-bot: Add tests for SpecialPage::requireLogin [core] - 10https://gerrit.wikimedia.org/r/96373 (owner: 10Aude) [19:05:54] (03CR) 10Cscott: [C: 032 V: 032] Properly support foreign file repos (particular commons). [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96547 (owner: 10Cscott) [19:06:26] ojorgensen: have you installed php bindings to sqlite? (no idea what the package might be called, but one should exist) [19:06:36] (03PS1) 10Umherirrender: Avoid Database::encodeExpiry, when simple timestamp is given [core] - 10https://gerrit.wikimedia.org/r/96551 [19:06:46] (03CR) 10Cscott: [C: 032 V: 032] Whitespace fixes. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96548 (owner: 10Cscott) [19:07:09] (03CR) 10Cscott: [C: 032 V: 032] Sync to version of db.js in mw-latexer. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96549 (owner: 10Cscott) [19:08:12] :( [19:09:12] MatmaRex: I'll try that! cheers [19:10:16] MatmaRex: It says that The PDO_SQLITE PDO driver is enabled by default [19:10:22] (03PS9) 10Anomie: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 [19:11:06] ojorgensen: sorry, i don't think i've ever had the opportunity to use mediawiki with anything else than mysql, so i don't really know what to do [19:12:07] MatmaRex: that's fine, could you try and help me with my mysql errors then? sorry to be a pain [19:12:41] i can try :) [19:12:53] but i'm not sure if i will be able to [19:13:09] (03PS1) 10Siebrand: Update formatting for includes/diff [core] - 10https://gerrit.wikimedia.org/r/96554 [19:13:29] (03CR) 10Anomie: "So, PS9 is an attempt to add a parameter to "npmtest" to specify which repo should be checked out as the node_modules subdir. If something" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [19:16:39] ojorgensen: ^ [19:19:24] marktraceur: what extensions does a wiki need to have the video player dialogs? [19:19:45] Ahhhh, ebernhardson, I think just TMH? [19:19:51] !e TimedMediaHandler [19:19:51] https://www.mediawiki.org/wiki/Extension:TimedMediaHandler [19:20:01] MatmaRex: cheers, when I run mysql, it tells me ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) [19:20:29] marktraceur: hmm, i installed that and the require MwEmbedSupport that goes with it, but just get thumbnails, probably a config thing then i'll read more : [19:20:32] :) [19:21:03] Hm. [19:21:18] I'd look at the config for the cluster, that's where I was testing laste [19:21:20] last* [19:21:22] ojorgensen: :o [19:21:29] ojorgensen: is the mysql daemon running? [19:21:48] how do I check that? [19:22:01] it's called mysqld i think [19:22:03] (03PS1) 10Raimond Spekking: Ignore new message for translation [core] - 10https://gerrit.wikimedia.org/r/96556 [19:22:11] `ps a | grep mysqld`, possibly [19:22:22] or just restard it, let me find out how [19:22:29] (re(start* [19:22:33] (re)start* [19:22:41] cheers [19:23:09] `service mysqld restart`, probably [19:23:26] (03CR) 10Raimond Spekking: "I changed it to ignore the key for translation: I91defae609e65142ff2d5026c9d7076865536307" [core] - 10https://gerrit.wikimedia.org/r/96200 (owner: 10TTO) [19:23:30] (03PS1) 10Siebrand: Avoid function calls in a for loop test part [core] - 10https://gerrit.wikimedia.org/r/96558 [19:23:31] (03PS1) 10Siebrand: Break long lines in includes/diff/ [core] - 10https://gerrit.wikimedia.org/r/96559 [19:25:05] MatmaRex: When running service mysqld restart, I get mysqld: unrecognized service [19:25:16] ojorgensen: :o [19:25:20] do you have mysql installed? :P [19:25:33] oO Not yet using systemd? :P [19:25:45] ojorgensen: what does `which mysqld` output? or `which mysql`? [19:26:15] (if they output nothing, then you definitely *don't* have mysql installed, or your installation is somehow hopelessly broken) [19:26:17] MatmaRex: /usr/bin/mysql [19:27:03] and the mysqld one? nothing? [19:27:09] (03PS1) 10Cscott: Add modules needed for latex_renderer. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96560 [19:27:29] hoo: you probably know how this stuff works better than i do, help? :D [19:27:38] MatmaRex: /usr/sbin/mysqld [19:27:55] (03CR) 10Cscott: [C: 032 V: 032] Add modules needed for latex_renderer. [extensions/Collection/OfflineContentGenerator/node_modules] - 10https://gerrit.wikimedia.org/r/96560 (owner: 10Cscott) [19:28:30] ojorgensen: hm. wild guess, try `mysqld start`? [19:29:18] MatmaRex: Long error message, pastebin time? What website should I use? [19:29:25] (03PS1) 10Cscott: Update node_modules to include the packages needed for this code. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96561 [19:29:36] ojorgensen: whichever one is your favorite :P [19:29:47] ojorgensen: are you a root? if not, try `sudo mysql start` [19:29:52] !pastebin [19:29:52] To avoid overflowing the channel with inane amounts of text, use https://dpaste.org/ or other awesome pastebin sites to share code, errors, and other large texts. [19:29:53] (03PS1) 10Siebrand: Rename class HWLDF_WordAccumulator to HWLDFWordAccumulator [core] - 10https://gerrit.wikimedia.org/r/96562 [19:29:54] (03PS1) 10Siebrand: Rename classes DiffOp_* to DiffOp* [core] - 10https://gerrit.wikimedia.org/r/96563 [19:29:55] (03CR) 10Cscott: [C: 032 V: 032] Update node_modules to include the packages needed for this code. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96561 (owner: 10Cscott) [19:30:01] ojorgensen: this one is fine i guess ^^^ [19:31:48] MatmaRex: Made the snippet, can I get a link or something so you can view it? [19:32:10] MatmaRex: What's the issue? He has the MySQL/ mariadb server installed but can't run it? Which distro? [19:32:22] (03CR) 10Aaron Schulz: [C: 032] mediafile-job-array (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [19:32:41] hoo: dunno [19:32:49] ojorgensen: what hoo said :) [19:32:53] * MatmaRex fades away [19:32:55] anomie: still around ? [19:33:03] hoo: linux mint 15 xfce 32 bit [19:33:04] ojorgensen: i think the URL should be the one in your browser's address bar [19:33:14] anomie: rush hour completed, will not last long though I am very tired :/ [19:33:24] hashar: Yes, I am. No need to come back this evening on my account though, we can pick it up tomorrow. [19:33:34] MatmaRex: https://dpaste.org/oTWs#L [19:33:45] (03PS2) 10Hashar: Adjust Collection OCG testing [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96516 (owner: 10Anomie) [19:33:53] (03PS1) 10Siebrand: Abstract declaration must precede visibility declaration [core] - 10https://gerrit.wikimedia.org/r/96564 [19:34:10] anomie: I am super busy tomorrow, so better spend half an hour right now to merge a few changes :D [19:34:11] ojorgensen: Ewk, that uses upstart... I'm not really familiar with that... you can get a gui for it using services-admin [19:34:39] hashar: I took a shot at adding a "node-modules" parameter to the npmtest job in https://gerrit.wikimedia.org/r/#/c/96480/ PS9 [19:34:58] * MatmaRex goes back to solving sets of linear equations in C [19:35:12] why do i have to implement such stupid things for uni ;_; [19:35:48] hoo: mysql doesn't show up in services settings, yet postgresql does, even though I removed from synaptic [19:36:24] hashar: (of course, if that looks good we'll need to revert adding node_modules as a submodule to bundler and the rest) [19:36:54] (03Merged) 10jenkins-bot: mediafile-job-array [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [19:37:32] ojorgensen: Weird... is it maybe named mariadb? Dunno how Ubuntu/ Mint handled that, but some distros exchanged MySQL with MariaDB recently [19:37:37] like Fedora [19:37:51] usually the service and binary names were kept, though [19:38:22] (let me just note that if you lose all hope, you can always try vagrant, or setting up a wiki on wmf labs) [19:38:23] !vagrant [19:38:23] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [19:38:34] hoo: no mention of mariaDB, I'm afraid [19:38:52] (03PS1) 10Siebrand: Silence false positive CodeSniffer error [core] - 10https://gerrit.wikimedia.org/r/96566 [19:39:03] Did we try looking for a process in ps already? [19:40:06] ojorgensen: apt-get install --reinstall mysql-server ... that's the last thing I can think of right now (without really having an inside view) [19:41:14] hoo: Will try that, cheers for the help [19:41:17] (03PS1) 10Anomie: Add additional information to FileRepo::getInfo [core] - 10https://gerrit.wikimedia.org/r/96568 [19:41:45] ojorgensen: Wait, doh [19:41:53] maybe the service is only named mysql [19:42:09] (03PS1) 10Cscott: Update field name to match the current filerepoinfo patch. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96569 [19:42:38] without the daemon d [19:43:15] hoo: that still doesn't show up, sorry [19:43:32] ojorgensen: Ok, reinstall it then, I'd say [19:44:09] hoo: reinstalled it as root [19:44:40] (03PS1) 10Siebrand: Remove unused private method check() [core] - 10https://gerrit.wikimedia.org/r/96570 [19:45:12] ojorgensen: So? Do you now have the service in /etc/init.d/ ? [19:46:27] (03CR) 10Hashar: [C: 032] Adjust Collection OCG testing [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96516 (owner: 10Anomie) [19:46:46] hoo: it is in init.d now, I'll check if mysql works [19:47:08] (03CR) 10Hashar: "deploying (zuul busy reloading)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96516 (owner: 10Anomie) [19:47:19] it should :) [19:47:42] hoo: same error [19:47:54] anomie: merged in Zuul change to trigger mediawiki/extensions/Collection/OfflineContentGenerator jobs [19:48:05] ojorgensen: service mysql start gives you what exactly? [19:48:30] (03PS2) 10Anomie: Fix jshint errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 [19:48:41] hoo:it outputs Usage: /etc/init.d/mysql COMMAND [19:49:05] MaxSem: ping? [19:49:11] pong [19:49:21] ojorgensen: actually service should call /etc/init.d/mysql start [19:49:34] service mysql start should do that, to be accurate [19:49:45] MaxSem: I've got 2 undefined variables in DiffFormatter. Looks like you recently created that file. [19:49:58] go on [19:50:12] Using '/etc/init.d/mysql start' would probably work for now, but that's a bad workaround... [19:50:15] MaxSem: $x0 and $y0 are not set. [19:50:38] that part was copied verbatim from another file [19:50:43] hoo: service mysql start outputs https://dpaste.org/5sKD [19:50:56] are you seeing it in prod or PhpStorm? [19:50:57] hashar: I poked at a gerrit change (96534) to try to get Jenkins to run, but it hasn't yet. I don't know if it's just being slow or if something is broken. [19:51:06] MaxSem: Then it seems you may have copied broken code. [19:51:12] MaxSem: Static code analysis. [19:51:15] !g 96534 [19:51:15] https://gerrit.wikimedia.org/r/#q,96534,n,z [19:51:20] ojorgensen: You should call that as root [19:51:29] siebrand, cause even though the IDE goes bonkers, they are getting set first [19:51:39] anomie: I think the change got lost by Zuul :-( [19:51:51] (03PS3) 10Hashar: Fix jshint errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [19:51:58] I know cause I scratched my head about it myself;) [19:52:26] MaxSem: Is it worth initialising them to prevent this? [19:52:56] siebrand, feel free to - I decided to not fix wat's not broken. even though it's confusing:) [19:53:01] anomie: 2013-11-20 19:51:52,335 WARNING zuul.Scheduler: Project mediawiki/extensions/Collection/OfflineContentGenerator not found [19:53:03] hoo: start: Job is already running: mysql [19:53:10] oO [19:53:18] Can you connect then? Run 'mysql* [19:53:23] * 'mysql' [19:53:39] MaxSem: Init as false? [19:53:51] hoo: same old error [19:53:57] (03CR) 10Hashar: "recheck" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [19:54:05] hoo: ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) [19:54:12] MaxSem: 0 is probably better, I guess. [19:54:13] ojorgensen: mh [19:54:23] yup [19:54:34] ojorgensen: run 'lsof -ni | grep mysql' as root [19:54:51] hashar: Odd. It shows up in Gerrit [19:54:55] it should show mysqld if it really is running (and on which port) [19:56:06] hoo: ran it both as root and as my user, outputs nothing [19:56:21] ojorgensen: Then it's not really running [19:56:37] or it couldn't bind the port and died immediately [19:57:09] (03CR) 10Hashar: "recheck" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [19:57:58] hoo: what should I do? [19:58:38] (03PS1) 10Siebrand: Initialise variables and update documentation [core] - 10https://gerrit.wikimedia.org/r/96573 [19:59:02] ojorgensen: tail /var/log/mysqld.log ... maybe you'll find something useful over there [19:59:27] you could also do lsof -ni -P | grep ':3306' to look whether the port is blocked by something, but I doubt that [19:59:31] (03CR) 10Hashar: "recheck" [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [19:59:45] hoo: tail: cannot open ‘/var/log/mysqld.log’ for reading: No such file or directory [20:01:04] ojorgensen: Probably it's just /var/log/mysql.log if the service is only named mysql [20:01:06] my fault [20:01:21] andre__: Around? [20:03:22] (03CR) 10Bsitu: Use explicit transactions (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 (owner: 10EBernhardson) [20:06:09] (03CR) 10Hashar: [C: 04-1] Add tests for the Collection OCG (031 comment) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [20:06:18] anomie: that is messy sorry :( [20:07:21] anomie: all strings are passed to python string formatting with the macro parameters passed as arguments. Aka something like "{my}-{string}" % params , where params must have all the keys "my" and "string", i.e.: { 'my': 'value for my', 'string': 'value for string' } [20:07:32] anomie: will amend to use a dedicated macro, will find out a better solution later on [20:07:48] (03CR) 10Siebrand: [C: 032] Ignore new message for translation [core] - 10https://gerrit.wikimedia.org/r/96556 (owner: 10Raimond Spekking) [20:08:55] hashar: I didn't think it would be a problem if missing a required parameter made the job builder give an error? [20:09:10] anomie: it does :-((((( [20:09:18] (03PS5) 10Aaron Schulz: Improved partitioning scheme for refreshLinks jobs [core] - 10https://gerrit.wikimedia.org/r/96199 [20:09:47] anomie: well lets just merge it in that is going to work in this specific case [20:10:12] hashar: Sometime (not now) I'll have to get you to explain to me what the problem is. [20:10:27] did above [20:10:44] the parameters is a dict which is then passed to each strings [20:10:48] (03Merged) 10jenkins-bot: Ignore new message for translation [core] - 10https://gerrit.wikimedia.org/r/96556 (owner: 10Raimond Spekking) [20:10:59] (03CR) 10AndyRussG: [C: 032] De-lint JavaScript sources. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94926 (owner: 10Cscott) [20:11:10] so if a string contain a variable which does not exist in the passed dict, python complains because it is missing the key in the dict to format the variable [20:11:16] hoo: any ideas? [20:11:30] (03CR) 10AndyRussG: [C: 032] Fix spelling of 'addition' in code and messages. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94932 (owner: 10Cscott) [20:11:55] ojorgensen: 'tail /var/log/mysql.log' gives you what? [20:12:01] hashar: Which means whoever is trying to use npmtest gets an error and needs to go back and specify the parameter [20:12:17] anomie: exactly [20:12:29] we can live with it right now [20:12:29] * anomie isn't seeing why that's bad [20:12:40] refreshing jobs [20:12:41] hoo: nothing [20:12:53] ojorgensen: mh [20:13:26] (03CR) 10Hashar: "jobs refreshed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [20:13:31] maybe 'tail /var/log/mysql.err' as root, ofc [20:14:22] (03PS1) 10Anomie: Revert "Check out OCG/node_modules as a git submodule. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96577 [20:14:37] (03CR) 10Anomie: [C: 032 V: 032] Revert "Check out OCG/node_modules as a git submodule. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96577 (owner: 10Anomie) [20:14:57] hoo: nothing [20:15:42] ojorgensen: Is it empty, or does it not exist? [20:15:49] (03PS4) 10Hashar: Fix jshint errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [20:16:08] (03PS3) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 (owner: 10Hashar) [20:16:56] (03PS1) 10EBernhardson: Hook expects old RC_* value for watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96578 [20:17:09] (03PS4) 10Anomie: Jenkins job validation (DO NOT SUBMIT) [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96519 (owner: 10Hashar) [20:17:16] anomie: I fixed your jshint tweak. We have a bug filled which is that jslint job fallback to use the jshintrc from integration/jenkins.git :-(((( https://bugzilla.wikimedia.org/52456 [20:17:26] anomie: so I had to add a .jshintrc containing {} [20:17:27] (03PS11) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [20:18:01] hashar: I was going to copy the .jshintrc from the bundler repo, and then fix the additional errors [20:18:07] hoo: it just gives me another prompt on a new line [20:18:32] anomie: yeah that would work. Feel free to override https://gerrit.wikimedia.org/r/#/c/96534/ :-] [20:18:47] ojorgensen: that means, that it is empty... if both are empty the service isn't really running and has never been running [20:18:51] hashar: Thanks for helping me get this all working! [20:19:20] anomie: should we get the jjb config change merged in so ? ( Add tests for the Collection OCG https://gerrit.wikimedia.org/r/#/c/96480/ ) [20:19:38] hoo: how can I fix that? [20:19:40] hashar: I see no reason why not [20:20:36] (03PS4) 10AndyRussG: Let instructors and other roles add students [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/96382 [20:20:42] ojorgensen: '/etc/init.d/mysqld start' says the service is already running? [20:20:56] (03CR) 10Hashar: [C: 032] "gives a badge to anomie. Thank you !!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [20:21:15] anomie: so as you might have figured out, the whole system is not very flexible :-( [20:21:26] (03Merged) 10jenkins-bot: Add tests for the Collection OCG [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96480 (owner: 10Anomie) [20:21:36] ideally I would want to reuse Travis test runner to let people easily define whatever test they want to run for their repo. [20:22:40] hoo: no such file or directory [20:22:48] Is "Travis test runner" actual software, or is that like "Ryan deployment system"? [20:22:49] (03CR) 10Aaron Schulz: Add additional information to FileRepo::getInfo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:23:06] it's travisci [20:23:21] ojorgensen: Damn... I keep forgetting that [20:23:22] and nothing to do with trebuchet (aka ryan deployment system) [20:23:32] '/etc/init.d/mysql start' [20:23:43] gwicke: I added you to https://gerrit.wikimedia.org/r/#/c/96199 [20:23:52] (03CR) 10MaxSem: [C: 031] Add additional information to FileRepo::getInfo [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:24:48] * AaronSchulz would like htmlcacheupdate and parsoidcacheupdate to work like that [20:27:04] hoo: https://dpaste.org/QxQn [20:27:33] ojorgensen: run it as root [20:27:39] (03CR) 10Anomie: Add additional information to FileRepo::getInfo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:28:24] hoo: Rather than invoking init scripts through /etc/init.d, use the service(8) utility, e.g. service mysql start Since the script you are attempting to invoke has been converted to an Upstart job, you may also use the start(8) utility, e.g. start mysql [20:29:06] ojorgensen: Yeah [20:29:10] but that should both work [20:29:41] hoo: start: Job is already running: mysql [20:29:48] impossible [20:29:49] :P [20:30:28] service --status-all | grep ^mysql [20:30:39] See what that gives you... [20:30:45] going to grab some food for now [20:30:59] (03CR) 10Aaron Schulz: Add additional information to FileRepo::getInfo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:31:07] be back in 30 min. maybe [20:33:58] (03PS1) 10Cscott: Add sample bundles and a basic sanity-test test suite. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96583 [20:34:10] (03PS1) 10Scimonster: Added legend to Special:RecentChanges and Special:Watchlist [core] - 10https://gerrit.wikimedia.org/r/96584 [20:34:45] (03PS1) 10Cscott: Fix the hacky work around for collections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96585 [20:35:39] (03PS2) 10Mwalker: Upstart Script and User Configuration [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96461 [20:35:53] (03CR) 10Mwalker: [C: 032 V: 032] Upstart Script and User Configuration [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96461 (owner: 10Mwalker) [20:36:09] (03CR) 10Aaron Schulz: [C: 032] Avoid Database::encodeExpiry, when simple timestamp is given [core] - 10https://gerrit.wikimedia.org/r/96551 (owner: 10Umherirrender) [20:39:10] (03Merged) 10jenkins-bot: Avoid Database::encodeExpiry, when simple timestamp is given [core] - 10https://gerrit.wikimedia.org/r/96551 (owner: 10Umherirrender) [20:42:09] (03CR) 10Cscott: [C: 031] Add additional information to FileRepo::getInfo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:43:37] (03PS2) 10Cscott: Update field name to match the proposed filerepoinfo API. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96569 [20:43:41] (03CR) 10Aaron Schulz: config-clean-up (033 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 (owner: 10Dan-nl) [20:44:32] (03CR) 10BryanDavis: [C: 031] job-queue-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 (owner: 10Dan-nl) [20:44:35] bd808, kind of (on and off) [20:45:40] andre__: No worries. I was BOLD and opened bug 57321 where you can answer my questtions [20:45:44] (03PS5) 10Anomie: Fix jshint errors [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 [20:47:24] bd808, heh, done :) [20:47:47] (03PS3) 10Adamw: SmashPig payments listener and role [vagrant] - 10https://gerrit.wikimedia.org/r/96227 [20:48:15] (03CR) 10Aaron Schulz: [C: 04-1] Add $wgShowDuplicatesOnForeignFiles to control dupe section of img [core] - 10https://gerrit.wikimedia.org/r/62934 (owner: 10Brian Wolff) [20:48:52] (03Abandoned) 10Cscott: Update node_modules to include the packages needed for this code. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96561 (owner: 10Cscott) [20:50:03] (03CR) 10Cscott: [C: 032] Add sample bundles and a basic sanity-test test suite. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96583 (owner: 10Cscott) [20:50:27] (03CR) 10Cscott: [C: 032] Fix the hacky work around for collections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96585 (owner: 10Cscott) [20:50:54] (03CR) 10Cscott: [C: 032] Update field name to match the proposed filerepoinfo API. [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96569 (owner: 10Cscott) [20:52:39] (03CR) 10Aaron Schulz: [C: 032] "meh" [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:54:02] (03CR) 10jenkins-bot: [V: 04-1] SmashPig payments listener and role [vagrant] - 10https://gerrit.wikimedia.org/r/96227 (owner: 10Adamw) [20:54:05] (03CR) 10Anomie: Add additional information to FileRepo::getInfo (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:54:17] (03Merged) 10jenkins-bot: Add sample bundles and a basic sanity-test test suite. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96583 (owner: 10Cscott) [20:54:22] (03Merged) 10jenkins-bot: Fix the hacky work around for collections. [extensions/Collection/OfflineContentGenerator/latex_renderer] - 10https://gerrit.wikimedia.org/r/96585 (owner: 10Cscott) [20:57:36] (03Merged) 10jenkins-bot: Add additional information to FileRepo::getInfo [core] - 10https://gerrit.wikimedia.org/r/96568 (owner: 10Anomie) [20:58:20] (03CR) 10Cscott: [C: 04-1] Fix jshint errors (031 comment) [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96534 (owner: 10Anomie) [21:09:20] (03CR) 10Wikinaut: "Well done: I confirm(!), that the problem is indeed solved!" [core] - 10https://gerrit.wikimedia.org/r/96253 (owner: 10IAlex) [21:12:02] (03PS1) 10Bsitu: Textarea should auto-expand to content height during initial load [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96636 [21:12:08] qgil, hexmode, do you want to talk with me about the 1.22 release page? I requested to claim it. [21:12:47] (03PS1) 10Manybubbles: Let client code set the client side timeout [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/96637 [21:16:32] (03Abandoned) 10Aaron Schulz: Reduced isQueueDeprioritized() process cache time to 1 second [core] - 10https://gerrit.wikimedia.org/r/96405 (owner: 10Aaron Schulz) [21:16:44] Hi HectorAE , in a meeting. [21:17:27] Okay. I'm just idling in here for now. [21:27:03] (03CR) 10Dzahn: [C: 032] Bring WeeklyReport extension code closer to upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96479 (owner: 10Aklapper) [21:27:30] (03CR) 10Dzahn: [V: 032] "having error pages instead of crashing is good" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96479 (owner: 10Aklapper) [21:28:11] (03PS2) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [21:28:37] (03PS1) 10Manybubbles: Add timeouts to updates and better log failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 [21:29:04] (03CR) 10Dan-nl: "- addressed bryan’s comment in functions.php in ps1" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [21:29:18] (03CR) 10Manybubbles: [C: 04-1] "Requires Ic4a1013e2acca1ba9f7008c3bfaed4d96a8b9d5f. Do not merge until that is merged." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 (owner: 10Manybubbles) [21:30:58] (03CR) 10Chad: [C: 032] Remove unneeded uses of else{} in api/ [core] - 10https://gerrit.wikimedia.org/r/95887 (owner: 10Siebrand) [21:32:26] (03CR) 10Chad: [C: 032] Break long lines in MWDebug class [core] - 10https://gerrit.wikimedia.org/r/96485 (owner: 10Siebrand) [21:32:36] (03CR) 10Chad: [C: 032] Replace deprecated with [core] - 10https://gerrit.wikimedia.org/r/96508 (owner: 10Siebrand) [21:34:22] (03Merged) 10jenkins-bot: Remove unneeded uses of else{} in api/ [core] - 10https://gerrit.wikimedia.org/r/95887 (owner: 10Siebrand) [21:34:39] (03CR) 10Chad: [C: 032] Update formatting for includes/diff [core] - 10https://gerrit.wikimedia.org/r/96554 (owner: 10Siebrand) [21:34:59] (03CR) 10Chad: [C: 032] Avoid function calls in a for loop test part [core] - 10https://gerrit.wikimedia.org/r/96558 (owner: 10Siebrand) [21:35:13] (03CR) 10Chad: [C: 032] Break long lines in includes/diff/ [core] - 10https://gerrit.wikimedia.org/r/96559 (owner: 10Siebrand) [21:36:02] (03CR) 10Chad: [C: 032] Rename class HWLDF_WordAccumulator to HWLDFWordAccumulator [core] - 10https://gerrit.wikimedia.org/r/96562 (owner: 10Siebrand) [21:36:20] (03Merged) 10jenkins-bot: Break long lines in MWDebug class [core] - 10https://gerrit.wikimedia.org/r/96485 (owner: 10Siebrand) [21:36:46] (03CR) 10Chad: [C: 032] Rename classes DiffOp_* to DiffOp* [core] - 10https://gerrit.wikimedia.org/r/96563 (owner: 10Siebrand) [21:37:27] (03CR) 10Chad: [C: 032] Abstract declaration must precede visibility declaration [core] - 10https://gerrit.wikimedia.org/r/96564 (owner: 10Siebrand) [21:38:01] (03Merged) 10jenkins-bot: Replace deprecated with [core] - 10https://gerrit.wikimedia.org/r/96508 (owner: 10Siebrand) [21:38:18] (03CR) 10Chad: [C: 04-1] Silence false positive CodeSniffer error (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96566 (owner: 10Siebrand) [21:38:38] (03PS1) 10Aaron Schulz: Fixed fatal error when getLocalCopy() fails [core] - 10https://gerrit.wikimedia.org/r/96640 [21:39:47] (03CR) 10Chad: [C: 032] "I know nothing can actually call this since it's private, but did you grep to make sure some ancient broken code isn't still trying to? If" [core] - 10https://gerrit.wikimedia.org/r/96570 (owner: 10Siebrand) [21:40:46] (03CR) 10BryanDavis: [C: 031] input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 (owner: 10Dan-nl) [21:40:57] (03CR) 10Chad: [C: 032] Initialise variables and update documentation [core] - 10https://gerrit.wikimedia.org/r/96573 (owner: 10Siebrand) [21:41:32] (03Merged) 10jenkins-bot: Update formatting for includes/diff [core] - 10https://gerrit.wikimedia.org/r/96554 (owner: 10Siebrand) [21:43:19] (03Merged) 10jenkins-bot: Avoid function calls in a for loop test part [core] - 10https://gerrit.wikimedia.org/r/96558 (owner: 10Siebrand) [21:44:50] (03CR) 10Dzahn: "this hasn't made anything worse, but it also doesn't look like labs yet" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96479 (owner: 10Aklapper) [21:45:16] (03Merged) 10jenkins-bot: Break long lines in includes/diff/ [core] - 10https://gerrit.wikimedia.org/r/96559 (owner: 10Siebrand) [21:45:24] (03PS3) 10Theopolisme: Supress native "invalid email" warning on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/96195 [21:46:27] (03CR) 10Theopolisme: Supress native "invalid email" warning on Special:ChangeEmail (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96195 (owner: 10Theopolisme) [21:47:11] (03Merged) 10jenkins-bot: Rename class HWLDF_WordAccumulator to HWLDFWordAccumulator [core] - 10https://gerrit.wikimedia.org/r/96562 (owner: 10Siebrand) [21:48:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Three notes: (one inline)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96584 (owner: 10Scimonster) [21:48:49] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96523 (owner: 10Siebrand) [21:48:55] (03CR) 10Chad: [C: 032] Update formatting on includes/deferred/ [core] - 10https://gerrit.wikimedia.org/r/96523 (owner: 10Siebrand) [21:49:19] (03PS2) 10Aaron Schulz: Added some sanity close() calls to RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/93866 [21:50:04] (03PS2) 10Chad: Update documentation and formatting for includes/deferred/ [core] - 10https://gerrit.wikimedia.org/r/96542 (owner: 10Siebrand) [21:50:05] (03CR) 10Aaron Schulz: [C: 032] Added some sanity close() calls to RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/93866 (owner: 10Aaron Schulz) [21:50:08] (03CR) 10Chad: [C: 032] Update documentation and formatting for includes/deferred/ [core] - 10https://gerrit.wikimedia.org/r/96542 (owner: 10Siebrand) [21:50:16] (03Merged) 10jenkins-bot: Rename classes DiffOp_* to DiffOp* [core] - 10https://gerrit.wikimedia.org/r/96563 (owner: 10Siebrand) [21:52:11] (03Merged) 10jenkins-bot: Abstract declaration must precede visibility declaration [core] - 10https://gerrit.wikimedia.org/r/96564 (owner: 10Siebrand) [21:53:13] (03CR) 10Chad: [C: 032] Only retry on connection errors [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/96492 (owner: 10Manybubbles) [21:53:31] (03CR) 10Chad: [V: 032] Only retry on connection errors [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/96492 (owner: 10Manybubbles) [21:56:58] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looks like it should work, one last code quality complaint :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96195 (owner: 10Theopolisme) [21:56:59] (03Merged) 10jenkins-bot: Remove unused private method check() [core] - 10https://gerrit.wikimedia.org/r/96570 (owner: 10Siebrand) [21:58:59] Hi, the RFC architecture review meeting s about to start at #wikimedia-meetbot -- details at https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2013-11-20 [21:59:06] (03CR) 10Chad: [C: 04-1] "Logic is good, just some nits about error/return conditions." (037 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [21:59:28] (03Merged) 10jenkins-bot: Initialise variables and update documentation [core] - 10https://gerrit.wikimedia.org/r/96573 (owner: 10Siebrand) [21:59:38] HectorAE, I haven't forgotten you. :) [21:59:56] (03CR) 10Chad: [C: 032 V: 032] Let client code set the client side timeout [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/96637 (owner: 10Manybubbles) [22:01:03] Good thing qgil. [22:02:14] (03CR) 10Manybubbles: [C: 04-1] "Changes coming." (037 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [22:02:56] (03CR) 10Chad: Add timeouts to updates and better log failures (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 (owner: 10Manybubbles) [22:03:44] (03PS5) 10Manybubbles: Tighter error handling in updateSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 [22:07:24] HectorAE, so you are confident that you can take http://www.google-melange.com/gci/task/view/google/gci2013/5860120755961856 [22:07:54] HectorAE, thank you for providing the URLs. I hope you understand we want to be a bit more certain about the GCI student taking this task [22:08:33] You're welcome. I'm kind of embarassed not to have better wiki articles to show you. [22:08:37] (03CR) 10Manybubbles: "Updating comment and rebasing." (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 (owner: 10Manybubbles) [22:08:57] HectorAE, ok, all this is good enough. I'll assign the task to you right now [22:09:06] I'll do my best. [22:09:19] HectorAE, yours. Thank you! [22:09:33] (03PS2) 10Manybubbles: Add timeouts to updates and better log failures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96639 [22:09:34] HectorAE, as explained, go edit by edit in small steps. [22:10:05] HectorAE, it will be a pleasure to see your improvements among the rest of changes coming to that page [22:10:06] Small steps, yes. I'll start working on it in a minute. Thanks for this opportunity, qgil. [22:10:09] (03Merged) 10jenkins-bot: Update formatting on includes/deferred/ [core] - 10https://gerrit.wikimedia.org/r/96523 (owner: 10Siebrand) [22:10:40] HectorAE, in case of doubt hexmode is the release manager, and others here will be robably able to help you aswering questions as well [22:11:31] Good to know. If I have any questions I will definitely ask. [22:11:40] thank you! good luck :) [22:11:48] And welcome! [22:13:06] (03PS1) 10MegaAlex: Change the syntax and non-one count fake values for {{PLURAL: in newmessages* [core] - 10https://gerrit.wikimedia.org/r/96652 [22:14:08] HectorAE, one small tip: mention in your mediawiki.org user page that you are a GCI student and link to the task. This way people curious about the edits of this newcomer to the 1.22 release page will know what are you up to. [22:16:02] (03CR) 10Aklapper: "Works as expected now for both dzahn and me (discussed on IRC)." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/96479 (owner: 10Aklapper) [22:16:23] Sounds like a good idea. I forgot I hadn't created a user page on MediaWiki yet. [22:21:04] (03Merged) 10jenkins-bot: Added some sanity close() calls to RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/93866 (owner: 10Aaron Schulz) [22:21:19] (03PS4) 10Theopolisme: Supress native "invalid email" warning on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/96195 [22:22:47] (03Merged) 10jenkins-bot: Update documentation and formatting for includes/deferred/ [core] - 10https://gerrit.wikimedia.org/r/96542 (owner: 10Siebrand) [22:23:11] (03PS21) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [22:23:58] (03PS5) 10Theopolisme: Supress native "invalid email" warning on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/96195 [22:31:45] (03PS22) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [22:31:51] (03PS1) 10Theopolisme: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 [22:38:57] (03CR) 10Parent5446: Fixed fatal error when getLocalCopy() fails (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96640 (owner: 10Aaron Schulz) [22:40:17] (03CR) 10Parent5446: [C: 032] Remove function calls from for loop test part [core] - 10https://gerrit.wikimedia.org/r/96457 (owner: 10Siebrand) [22:47:50] andrewbogott: https://wikitech.wikimedia.org/wiki/Help:Git_rebase is very eloquent and convincing :D [22:54:53] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks awesome :) Thanks!" [core] - 10https://gerrit.wikimedia.org/r/96195 (owner: 10Theopolisme) [22:55:18] (03CR) 10Legoktm: [C: 04-1] "The messages you added will need documentation, see https://www.mediawiki.org/wiki/Localisation#Adding_new_messages" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [22:55:52] (03CR) 10Cscott: "Tired of waiting for jenkins." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96569 (owner: 10Cscott) [22:56:09] (03CR) 10Cscott: [V: 032] "(Still) tired of waiting for jenkins." [extensions/Collection/OfflineContentGenerator/bundler] - 10https://gerrit.wikimedia.org/r/96569 (owner: 10Cscott) [22:58:03] (03Merged) 10jenkins-bot: Supress native "invalid email" warning on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/96195 (owner: 10Theopolisme) [22:58:39] (03CR) 10Legoktm: Mention: notify correctly if there is no section title (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 (owner: 10Theopolisme) [23:00:07] hmm legoktm got an issue with mass message :/ [23:00:32] addshore: what's up? [23:01:16] Error: invalid magic word 'target' >.< called from Special:CentralAutoLogin/start?type=script Exception from line 316 of /usr/share/nginx/.orain.org/w/includes/MagicWord.php [23:01:36] wonder if its my lcoalisation cache job not being triggereed [23:01:44] (03CR) 10Aaron Schulz: [C: 04-1] job-queue-size (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 (owner: 10Dan-nl) [23:01:53] wut [23:02:11] yeah, that sounds like a cache issue [23:02:30] because that magic word is localized properly [23:02:38] though, its not a magic word. [23:02:49] it's a parserfunction [23:02:50] hmm, our localisation stuff should all be working fine though >.< [23:02:54] ill dig some more [23:04:17] addshore: hmmmm. its not a magic word though. Have you created a target list already? Or is this just after install? [23:04:35] just after install, with default config settings [23:05:30] weird. [23:05:36] indeed ;p [23:07:52] magic words.... [23:08:04] (03CR) 10Chad: [C: 032] Tighter error handling in updateSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [23:08:09] (03Merged) 10jenkins-bot: Tighter error handling in updateSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96383 (owner: 10Manybubbles) [23:08:17] aude: yay :d [23:08:19] those are evil and require localisation cache [23:08:23] (03PS7) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [23:09:38] Nemo_bis: glad to hear it :) [23:09:58] hmm legoktm yep just seems to be a problem with our localisation script updating... [23:10:14] :D [23:10:31] which is odd.. as all I did was copy the command from cron :P [23:11:14] just dump the cache and start over :P [23:11:43] its just odd, as when it was loaded I ran the maint script but it said nothing had changed so I would need to use --force [23:11:51] almost like it didnt detect something, or missed something :D [23:15:48] (03CR) 10Mattflaschen: "Normally, this is not done for local (temporary for a particular method) variables, only fields." (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 (owner: 10Addshore) [23:17:50] (03PS1) 10Yurik: Updating Zero [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96661 [23:21:39] (03CR) 10Yurik: [C: 032 V: 032] Updating Zero [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/96661 (owner: 10Yurik) [23:23:41] (03CR) 10Mattflaschen: "Is this because the fundraising role will eventually use more than one HTTP server (with different host names), all running inside the sam" [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [23:28:12] heh Did not find alias for special page 'Random'. Perhaps no aliases are defined for it? [Called from SpecialPageFactory::getLocalNameFor in /usr/share/nginx/.orain.org/w/includes/SpecialPageFactory.php at line 568] [23:28:23] it just seems to be exception after exception for me :D [23:28:35] you broke it! [23:28:43] (03PS1) 10Yurik: Updated Zero [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96664 [23:28:47] mhhm, this is trying to deploy CentralNotice this time... [23:29:09] (03PS1) 10Chad: Don't use pool counter when running maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96665 [23:33:08] (03CR) 10Yurik: [C: 032 V: 032] Updated Zero [core] (wmf/1.23wmf4) - 10https://gerrit.wikimedia.org/r/96664 (owner: 10Yurik) [23:34:05] (03PS2) 10Theopolisme: Mention: notify correctly if there is no section title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/96656 [23:40:25] ori-l: I can't get my vagrant box to start... https://dpaste.de/8F5s/raw/ [23:42:21] (03PS5) 10Dan-nl: config-clean-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 [23:42:57] (03PS4) 10Jdlrobson: Rewrite CSS for vectorTabs and #p-personal with nesting [core] - 10https://gerrit.wikimedia.org/r/90171 [23:43:12] (03CR) 10Dan-nl: "addressed aaron's comments in ps5" (033 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 (owner: 10Dan-nl) [23:43:31] (03CR) 10Jdlrobson: "Please can someone +2 this. I just had a messy rebase I had to clean up :(" [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [23:43:33] legoktm: there isn't much I can do about low-level errors from VirtualBox [23:43:40] hmm [23:43:46] i'll try debugging [23:44:07] just do the usual things: quit VirtualBox, make sure it's not running in the background, try again [23:44:11] sorry :/ [23:44:59] (03PS3) 10Dan-nl: job-queue-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96353 [23:47:09] (03PS2) 10Jdlrobson: Hygiene: Cleanup IE6 specific rules by using * hack [core] - 10https://gerrit.wikimedia.org/r/94163 [23:47:09] that didn't work [23:47:16] i then tried destorying and recreating [23:47:18] hit the same error [23:47:33] there's a virtualbox upgrade out [23:47:36] let me try that [23:47:54] legoktm: https://github.com/mitchellh/vagrant/issues/1671 [23:48:44] hmm [23:48:45] * legoktm tries [23:48:57] ori-l: that worked! [23:48:59] thanks :D [23:49:11] (03PS3) 10Dan-nl: input-field-size [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96510 [23:49:34] ok [23:49:38] need to upgrade VB and vagrant