[00:00:19] (03PS4) 10EBernhardson: Design tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96065 (owner: 10Matthias Mullie) [00:04:45] (03PS1) 10EBernhardson: Simplify LESS .buttonIcon method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96173 [00:05:18] (03CR) 10EBernhardson: [C: 032] Design tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96065 (owner: 10Matthias Mullie) [00:05:37] (03Merged) 10jenkins-bot: Design tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96065 (owner: 10Matthias Mullie) [00:06:13] Nemo_bis: not my preferred answer, but i suppose that will work :) thanks. [00:07:00] chrismcmahon: Are we not using nfs on the beta cluster? Special:Version takes a long ass-time... [00:08:42] marktraceur: Special:Version used to time out completely. it still has performance problems, but it should complete iirc [00:10:04] (03CR) 10Werdna: [C: 032] Remove the thank link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96063 (owner: 10EBernhardson) [00:10:14] (03Merged) 10jenkins-bot: Remove the thank link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96063 (owner: 10EBernhardson) [00:11:50] (03PS1) 10Hashar: operations-puppet-doc shell is now verbose [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96174 [00:11:50] It does, but it's slow [00:12:12] chrismcmahon: Does it do the same thing as prod does? Compiling the version numbers into a static file somewhere, I think, is the jist... [00:13:41] marktraceur: pretty sure not [00:14:26] (03PS2) 10Legoktm: Allow enabling as default with a BetaFeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 [00:14:39] (03CR) 10Legoktm: Allow enabling as default with a BetaFeature (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 (owner: 10Legoktm) [00:15:22] Aw. [00:15:31] (03CR) 10jenkins-bot: [V: 04-1] Allow enabling as default with a BetaFeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 (owner: 10Legoktm) [00:16:49] (03PS3) 10Legoktm: Allow enabling as default with a BetaFeature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 [00:17:49] (03CR) 10Hashar: [C: 032] operations-puppet-doc shell is now verbose [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96174 (owner: 10Hashar) [00:18:08] (03Merged) 10jenkins-bot: operations-puppet-doc shell is now verbose [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96174 (owner: 10Hashar) [00:23:02] chrismcmahon: Unrelatedly, it looks like en.wp.beta has Commons set up as an API-based foreign repo, which may be interfering with some testing we're doing - is there a good reason it's different from prod? [00:23:14] (03CR) 10GWicke: [C: 04-2] "I think this is the wrong approach. If you mix content then you should rewrite the links to reflect the global base href or location." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 (owner: 10EBernhardson) [00:24:04] At this point I'm happy to say "meh" and go with it, and let tgr deal with it when he gets back [00:24:20] marktraceur: at some point the setup was: enwiki beta looking up in commons beta and commons beta using ApiForeign to fetch from production commons. [00:24:30] Hm [00:24:41] might not apply anymore though [00:24:42] That should work fine because I'm looking up a file on betacommons [00:25:04] But I'm seeing metadata fails and I'm also seeing prod commons configured as a repo in meta=filerepoinfo [00:25:07] http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=filerepoinfo [00:25:40] tgr: Any thoughts as to what the situation is at http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&prop=imageinfo&titles=File:Title_0.6229354626122394.png&iiprop=extmetadata ? [00:26:07] Oh, never mind, response in -multimedia [00:29:30] hey? [00:29:33] is anyone here? [00:30:05] !ask [00:30:06] Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [00:32:10] Google Code-In is happening right now, and I found a suitable task, that I want to get to work on, but I haven't gotten my "Student ID Verification" uploaded yet, so I'm not verified, and I'm afraid that If I do the work and commit now, it may not count for GCIN, or if I wait, someone else will take up the task. [00:32:40] (and it may take a few days before I get the verification) [00:34:09] I don't know, I suspect that if you do the work and commit now it will be fine [00:34:15] but maybe speak to Quim Gil to verify? [00:34:18] qgil@wikimedia.org [00:34:52] rambomedic: he is qgil on IRC also, but he does not seem to be here right now [00:35:32] If I'm replacing a png with a scalable svg image, where should I put the svg image? [00:35:51] I'm assuming in skins/common/images/foo.svg [00:36:42] but then the weird thing is you will have two near-identical files (foo.png and foo.svg | I'm keeping the png for compatibility with older browsers) [00:38:03] seems reasonable to me [00:38:20] but then the weird thing is, there's apparently an "svg" skin [00:38:31] or an svg folder in the skins folder [00:38:45] is that a skin, or used for storage of svg images for other skins? [00:41:52] Um rambomedic I think there's a problem here. [00:41:59] I already claimed that task. [00:42:20] Okay, got it! [00:42:27] I'll work on something else. [00:42:41] Alright. Just wanted to let you know. [00:43:28] (03PS1) 10Jdlrobson: Correct language tooltips for main page [core] - 10https://gerrit.wikimedia.org/r/96178 [00:48:17] (03PS6) 10Mwalker: WIP Node.JS Renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 [00:50:37] (03CR) 10Jdlrobson: "Not sure if I did this right as not so familiar with this code.." [core] - 10https://gerrit.wikimedia.org/r/96178 (owner: 10Jdlrobson) [00:55:54] (03PS4) 10EBernhardson: Hackish method of respecting parsoid base href [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 [01:00:40] (03PS1) 10Mwalker: Adding the OfflineContentGenerator submodule [extensions/Collection] - 10https://gerrit.wikimedia.org/r/96179 [01:01:56] (03PS1) 10EBernhardson: Request just the from parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96180 [01:02:16] (03CR) 10Manybubbles: "Just wanted to let you know that I think this is a great idea. I won't have time to do any real testing of it for the next few days but I" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 (owner: 10Legoktm) [01:02:28] manybubbles: :D [01:03:19] (03Abandoned) 10Mwalker: Adding the OfflineContentGenerator submodule [extensions/Collection] - 10https://gerrit.wikimedia.org/r/96179 (owner: 10Mwalker) [01:03:32] (03PS1) 10Mwalker: Adding the OfflineContentGenerator submodule [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96181 [01:03:35] (03CR) 10GWicke: [C: 04-1] Hackish method of respecting parsoid base href (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 (owner: 10EBernhardson) [01:05:51] (03PS1) 10EBernhardson: Load parsoid content as XML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96182 [01:12:53] (03PS1) 10Mwalker: Intial setup with known intial submodules [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96183 [01:13:34] (03CR) 10Mwalker: [C: 032 V: 032] "Yep; self review is bad; but this is an empty of code repo" [extensions/Collection] (OCG) - 10https://gerrit.wikimedia.org/r/96181 (owner: 10Mwalker) [01:14:09] (03CR) 10Mwalker: [C: 032 V: 032] Intial setup with known intial submodules [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96183 (owner: 10Mwalker) [01:18:15] (03PS1) 10Mwalker: Initial sketch of the frontend/backend manager [extensions/Collection/OfflineContentGenerator] - 10https://gerrit.wikimedia.org/r/96184 [01:21:34] (03PS1) 10Lyumn: create parser test branch [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/96185 [01:22:49] ebernhardson: I just looked into removal of the ./ prefix, and noticed that we'd then have to escape colons to avoid browsers interpreting pages as protocols [01:25:56] gwicke: unfortunatly, we cant use pure relative because of /w/index.php?title=Foo/Bar/Baz [01:26:12] that is a separate issue I believe [01:26:29] setting a in that case would fix it [01:26:47] /w/index.php?title= ... is not normally cacheable anyway [01:27:22] (getting rid of the /w/index.php entry point would also fix it of course) [01:27:28] hmm, i suppose for the mvp that will be enough. We arn't displaying topics from multiple sources on the same page yet [01:28:30] in the normal case (page views) no href munging is needed then [01:28:32] but that will be coming very soon-ish :) user subscriptions are going to have a big push before it can go on more pages [01:28:45] only in mixed-content situations it will be needed [01:29:06] well, the reason i was looking to fix it is i have bugs in bugzilla about /w/index.php :) [01:29:49] since the problem is a general one about relative links being broken when using /w/index.php I think it makes sense to fix it more generically [01:30:10] rather than working around it everywhere [01:30:27] it does, but i have little experience getting anything into core, if i had to put a timeline on me getting a fix like that through i would say Jan or Febuary [01:30:33] which is a bit late for a wikiproject's release [01:30:51] any other patch i've had for core has taken more than a month, and this one actually affets more things [01:31:22] s/affets/affects/ [01:31:42] yeah, makes sense [01:34:36] (03PS14) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [01:51:21] (03PS1) 10EBernhardson: Workaround for relative links in /w/index.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96189 [01:55:01] Hi! [01:55:16] (03PS2) 10EBernhardson: Workaround for relative links in /w/index.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96189 [01:56:28] (03Abandoned) 10EBernhardson: Hackish method of respecting parsoid base href [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 (owner: 10EBernhardson) [02:01:24] greg-g: MassMessage good for Tuesday? [02:02:14] (03Abandoned) 10Mwalker: WIP Node.JS Renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 (owner: 10Mwalker) [02:12:54] I started Google Code in today and claimed a wikimedia task. Is this the right place for me to ask some questions? [02:13:30] yep [02:14:55] the task I got wanted me to change the File page so that it uses a HiDPI srcset. It said to reuse the code that generates image thumbnails and I saw something like that in the Linker class. [02:15:21] I ended up editing the File.php page changing the createThumb method [02:15:28] was that what I was supposed to do? [02:24:20] (03CR) 10EBernhardson: Simplify LESS .buttonIcon method (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96173 (owner: 10EBernhardson) [02:31:42] (03PS1) 10TTO: Delete maintenance/language/zhtable/trad2simp_supp_unset.manual [core] - 10https://gerrit.wikimedia.org/r/96193 [02:33:46] (03PS1) 10Aarcos: Just testing the workflow. [core] - 10https://gerrit.wikimedia.org/r/96194 [02:42:19] anomie|away, Reedy: can one of you forward the email bsitu sent to mediawiki-api regarding the Echo API to the -announce list? [02:50:22] I'm having some trouble with Gerrit. $ git review -R $ asks for my login info (which it probably shouldn't because ssh-agent is active) and then fails. Any ideas for troubleshooting? [02:54:25] (03PS1) 10Theopolisme: Supress native "invalid email" warning on Special:ChangeEmail [core] - 10https://gerrit.wikimedia.org/r/96195 [02:56:07] (03PS1) 10Tholam: Reused processReponsiveImages method from Linker class in File page and added a call to the method in the createThumb method to generate the srcset Change-Id: I9fc007399e65b3a6f417766d8411b9bd207301a1 [core] - 10https://gerrit.wikimedia.org/r/96196 [03:03:32] (03CR) 10Brian Wolff: "Hi," [core] - 10https://gerrit.wikimedia.org/r/96196 (owner: 10Tholam) [03:08:42] (03PS2) 10Tholam: Reused processReponsiveImages method from Linker class in File page and added a call to the method in the createThumb method to generate the srcset Change-Id: I9fc007399e65b3a6f417766d8411b9bd207301a1 [core] - 10https://gerrit.wikimedia.org/r/96196 [03:09:10] (03PS3) 10Tholam: Updated File page to use HiPI Reused processReponsiveImages method from Linker class in File page and added a call to the method in the createThumb method to generate the srcset Bug: 56969 Change-Id: I9fc007399e65b3a6f417766d8411b9bd207301a1 [core] - 10https://gerrit.wikimedia.org/r/96196 [03:11:57] (03PS4) 10Tholam: Updated File page to use HiPI Reused processReponsiveImages method from Linker class in File page and added a call to the method in the createThumb method to generate the srcset Bug: 56969 [core] - 10https://gerrit.wikimedia.org/r/96196 [03:12:08] (03CR) 10MarkTraceur: [C: 04-2] "Congratulations! :)" [core] - 10https://gerrit.wikimedia.org/r/96194 (owner: 10Aarcos) [03:16:59] (03CR) 10Springle: "Couple questions after testing stuff on enwiki slaves:" [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [03:18:35] Elsie: should be, barring anything stupid [03:21:15] Never mind. I had the wrong URL set up, https instead of ssh. [03:21:35] (03PS1) 10HectorAE: shared.css: Start vectorizing common icons [core] - 10https://gerrit.wikimedia.org/r/96197 [03:21:56] Yep ^ [03:22:39] Hey, Im working on this task for GCI( http://www.google-melange.com/gci/task/view/google/gci2013/5815435647778816 ), and I was wondering, are all the changes needed to the files listed in those articles linkeed? [03:24:28] HectorAE: Glad to hear you got it figured out [03:25:50] Evan_M: There might be more pywikipediabot experts hanging about in #pywikipediabot who might be able to better answer questions about the pywikipedia side of things [03:26:17] Alright, Ill make sure to ask there, thanks! [03:28:39] HectorAE: For your change, on the left side of the page there's a text box with the label "Name or email or group" - I'd recommend you add Pau to that box (given he is listed as the mentor for that task on gci site), that will flag the change as requiring review by him [03:30:15] bawolff, thank you very much. I hadn't noticed that. [03:31:22] HectorAE: It probably isn't strictly neccesary - since the gci mentor folks are also supposed to be monitoring the google page, but it certainly can't hurt [03:32:59] (03PS5) 10Brian Wolff: Updated File page to use HiPI [core] - 10https://gerrit.wikimedia.org/r/96196 (owner: 10Tholam) [03:33:02] Yeah, might as well. Keep the mentors on their toes, lol. [03:33:18] (03CR) 10Brian Wolff: "Thanks, commit message looks much better now." [core] - 10https://gerrit.wikimedia.org/r/96196 (owner: 10Tholam) [03:35:30] yay! I got my first student!! [03:35:34] oh sheesh, gerrit bot is using my (commiter) name instead of author name. That's going to probably confuse someone :s [03:37:37] Rtdwivedi: This is fun, all these new faces on irc :) [03:38:00] how do i know whether or not I did my task correctly? [03:38:23] Hi Tholam [03:38:32] Is Jared here? [03:38:37] Tholam, when your mentor follows up on it. You'll be notified. [03:38:52] Ok [03:38:53] Tholam: Someone will review the task, and either leave a -1 if there is something more to do, or a "+2" if everything is good [03:39:04] bawolff: :D [03:39:12] Thanks for the help on the commit message bawolff [03:39:18] sorry I messed it up so many times [03:39:40] and possibly some fancy stuff on the GCI page to notify you once its accepted, I don't really know how that part works [03:40:20] On the gerrit page, there is a box on the left that has a field named status. Currently it says "Review in Progress". Once the change has been accepted, the status changes to "Merged" [03:40:59] Tholam: And no worries about the commit message, that's just a minor conventions sort of thing, you'll pick those sorts of things up as you go [03:41:38] Tholam: Actually one other convention type thing I noticed on your task [03:42:18] Tholam: Right after the end of the "processResponsiveImages" function you introduce, you have a newline that's entirely empty except for a tab [03:42:27] You should delete the tab, so its just a newline by itself, no extra tab [03:43:18] can i still change what i've put on gerrit? [03:43:22] Tholam: Specificly I'm referring to line 873. Its highlighted in red on https://gerrit.wikimedia.org/r/#/c/96196/5/includes/filerepo/file/File.php [03:43:32] Tholam: yep you can [03:43:59] just change what you want, do git add, and then do git commit --amend and finally do git review -R [03:46:19] (03PS6) 10Tholam: Updated File page to use HiPI [core] - 10https://gerrit.wikimedia.org/r/96196 [03:46:50] (03PS1) 10Aaron Schulz: [WIP] Improved on partitioning scheme for refreshLinks2 [core] - 10https://gerrit.wikimedia.org/r/96199 [03:48:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Improved on partitioning scheme for refreshLinks2 [core] - 10https://gerrit.wikimedia.org/r/96199 (owner: 10Aaron Schulz) [03:49:49] (03PS1) 10TTO: Remove needless leading dash on Main Page interlanguage links [core] - 10https://gerrit.wikimedia.org/r/96200 [03:51:44] (03PS2) 10HectorAE: shared.css: Start vectorizing common icons [core] - 10https://gerrit.wikimedia.org/r/96197 [03:52:30] Just made a small change deleting trailing whitespace too, oddly enough. [03:52:43] Though for the record I didn't actually write that image. [04:12:03] (03PS2) 10Siebrand: Address CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/96155 [04:15:34] (03PS3) 10Siebrand: Address CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/96155 [04:15:50] (03CR) 10Siebrand: "Thanks for the review, Tyler. Comments addressed in follow-up patch set." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96155 (owner: 10Siebrand) [04:17:42] (03CR) 10Siebrand: Update formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96156 (owner: 10Siebrand) [04:19:31] (03PS4) 10Legoktm: [WIP] Use ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [04:19:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [04:20:13] (03PS2) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96156 [04:27:29] hi andre__ [04:31:34] !wg [04:31:34] https://www.mediawiki.org/wiki/Manual:%24wg$1 [04:31:45] !wgVectorFeatures [04:31:57] !LocalSettings.php [04:33:16] !wg VectorFeatures [04:33:17] https://www.mediawiki.org/wiki/Manual:%24wgVectorFeatures [04:33:21] mayankmadan: Hi. :-) [04:33:33] (03PS5) 10Legoktm: [WIP] Use ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [04:33:37] hi Elsie [04:33:43] I think you can test in #wmbot. [04:33:46] But I don't remember. [04:38:06] andre__: online> [04:38:08] *? [04:40:36] mayankmadan: You might have better luck more during what usa would consider to be normal working hours [04:41:19] (03CR) 10MZMcBride: "Proposed for reversion at bug 57223." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/81373 (owner: 10CSteipp) [04:41:19] mayankmadan: Is there anything in particular you need help with that we could potentially help you with? [04:52:16] (03CR) 10Tim Starling: "I don't think it was ever used. CacheDependency was just an idea I had for a different way to do caching -- I committed it in 2006, but I " [core] - 10https://gerrit.wikimedia.org/r/95983 (owner: 10Siebrand) [04:54:00] (03PS1) 10Shirayuki: i18n: fix double-space [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/96201 [04:54:08] (03PS1) 10Jforrester: Update VisualEditor events to those added in gerrit 94284 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 [05:00:26] (03CR) 10Catrope: [C: 04-1] "Looks good except for spelling weirdness" (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 (owner: 10Jforrester) [05:01:44] (03PS2) 10Jforrester: Update VisualEditor events to those added in gerrit 94284 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 [05:03:48] (03PS3) 10Jforrester: Update VisualEditor events to those added in gerrit 94284 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 [05:06:04] (03CR) 10Jforrester: Update VisualEditor events to those added in gerrit 94284 (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 (owner: 10Jforrester) [05:06:22] ori-l: ling [05:06:24] ping [05:06:51] Krinkle: hey [05:07:15] ori-l: I'm checking out some caching issues related to event schemas, turn out to be a bug on my end, but in doing so I found something I'd like you to double check [05:07:28] i'd be happy to, what's up? [05:07:30] https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/includes/RemoteSchema.php#L30 [05:07:31] https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/includes/ResourceLoaderSchemaModule.php#L73 [05:07:38] that doesn't look like a timestamp [05:08:21] so it looks like (assuming revision ids are lower than any modern timestamp for now) this can potentially get globbered by a max() with an old timestam op [05:08:24] and thus never invalidate [05:09:23] using a non-timestamp value there only works if you're in an isolated context with nothing else [05:12:36] hrm, i see what you're saying. i have to refresh my memory by looking at the code, just a moment. [05:14:22] yeah, no worries. It hasn't caused problems yet afaik, just precautious [05:14:23] bawolff: why will it be better during usa working hours? [05:14:37] MatmaRex and lazowik are from poland [05:14:53] mayankmadan: WMF folks tend to be more active at that time [05:15:03] oh, nice. Just spotted I'm using Gerrit over IPv6 now. [05:15:15] ok [05:15:52] mayankmadan: Although I think andre is based somewhere in Europe, but it seems like the wmf employees still are often on irc more around us working hours (I guess so they can have meetings and what not) [05:16:07] oh [05:18:12] (03CR) 10Catrope: [C: 031] Update VisualEditor events to those added in gerrit 94284 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 (owner: 10Jforrester) [05:19:13] (03CR) 10Legoktm: [C: 032] Remove ugly $wgTitle comments [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96160 (owner: 10Chad) [05:19:23] (03CR) 10Legoktm: [V: 032] Remove ugly $wgTitle comments [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96160 (owner: 10Chad) [05:23:51] (03CR) 10Legoktm: [C: 032] Fix indentation of comment in tables.sql [core] - 10https://gerrit.wikimedia.org/r/96067 (owner: 10Umherirrender) [05:24:19] RoanKattouw, James_F: oh, man. It's awesome to have your help with the VE events. [05:24:23] I just noticed that. [05:24:43] (03CR) 10Parent5446: [C: 04-1] Address CodeSniffer errors and warnings (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96155 (owner: 10Siebrand) [05:25:36] ori-l: There's a bit of weirdness in that commit I just +1ed [05:25:39] * RoanKattouw retracts +1 [05:25:58] (03CR) 10Catrope: [C: 04-1] "Retracting +1 for weirdness with unused topic variable, James is on it already." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 (owner: 10Jforrester) [05:26:10] (03CR) 10Parent5446: [C: 032] "Will submit once underlying patch is done." [core] - 10https://gerrit.wikimedia.org/r/96156 (owner: 10Siebrand) [05:26:30] ori-l: I'm also doing some work in VE now to change the saveError.cause events to saveError, { topic: cause } or whatever [05:26:53] That's what James built support for in his commit, suggestions re naming (or anything really) are very welcome' [05:26:57] (03CR) 10Siebrand: "That won't work for this version, because it needs rebasing once the parent is updated." [core] - 10https://gerrit.wikimedia.org/r/96156 (owner: 10Siebrand) [05:26:58] (03Merged) 10jenkins-bot: Fix indentation of comment in tables.sql [core] - 10https://gerrit.wikimedia.org/r/96067 (owner: 10Umherirrender) [05:27:08] (03CR) 10Siebrand: Address CodeSniffer errors and warnings (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96155 (owner: 10Siebrand) [05:27:11] (03CR) 10Legoktm: [C: 032] Move RecentChangeTest to subdirectory [core] - 10https://gerrit.wikimedia.org/r/96035 (owner: 10Aude) [05:28:21] ori-l: I will also work on a patch for WikimediaEvents to move the ve.trackSubscribe rigging from the activate hook to a plugin module so we can track events in cases where the editor didn't successfully activate [05:28:28] (03CR) 10Legoktm: [C: 032] Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 (owner: 10Aude) [05:29:17] this is great [05:29:17] http://www.buzzfeed.com/jessicamisener/the-27-most-passive-aggressive-things-that-ever-happened?bffb [05:29:39] (03PS4) 10Siebrand: Address CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/96155 [05:30:31] (03CR) 10jenkins-bot: [V: 04-1] Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 (owner: 10Aude) [05:31:26] RoanKattouw: excellent. I haven't looked at plugins yet but yes, it sounds like the right way to go. [05:32:21] (03Merged) 10jenkins-bot: Move RecentChangeTest to subdirectory [core] - 10https://gerrit.wikimedia.org/r/96035 (owner: 10Aude) [05:34:12] (03CR) 10Legoktm: [C: 04-1] "includes/HTMLForm.php shouldn't be deleted and re-added, it should be renamed and have stuff removed from it (the main class should stay t" [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [05:35:29] (03PS4) 10Jforrester: Update VisualEditor events to those added in gerrit 94284 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 [05:36:03] ori-l: Well I haven't documented them yet, so ... :) [05:36:43] Krinkle: I think you're right, but it's really bizarre for this to not have been an issue until now [05:37:08] Krinkle: is the correct thing to do to set the mtime to $wgCacheEpoch + revision ID? [05:37:30] (03CR) 10Catrope: [C: 04-1] "There is no code checking for the presence of data.type and putting it in event.type (needed for https://gerrit.wikimedia.org/r/96203)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 (owner: 10Jforrester) [05:39:37] (03CR) 10Legoktm: "1.23wmf2 isn't deployed on any WMF sites anymore, so is this still needed?" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95089 (owner: 10Krinkle) [05:39:38] (03PS5) 10Jforrester: Update VisualEditor events to those added in gerrit 94284 [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 [05:51:39] (03CR) 10Krinkle: "No" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95089 (owner: 10Krinkle) [05:51:44] (03Abandoned) 10Krinkle: Add rc.unpatrolled to the recentchanges API [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95089 (owner: 10Krinkle) [05:52:29] ori-l: No, I woulnd't recommend that. That should cause the same problem. [05:53:09] The timestamp shouldn't just increase, it needs to be more than whatever else there can be. [05:53:22] that was last modified earlier [05:54:15] If it can't get the timestamp from the database (should be possible and relatively cheap, see RL WikiModule for example), an alternative would be to use implicit timestamp generation. Just use time() and cache it by revision id, whatever we first see a rev id, use time() etc. [05:54:24] awwww, i need to rebase.... [05:54:44] accurate enough for this purpose, we use this throughout rl modules when something isn't tied to a measurable event (e.g. LocalSettings changes affecting RL LanguageDataModule ) [05:55:04] we just hash the value and when it changes, replace timestamp. [05:55:37] ori-l: you can use your revision id as-is as the "hash" [05:56:09] Hm.. interesting, since this rev id is an option to the constructor, the new definition summary cache helper can be used here as well. [05:57:28] what about (for example) ResourceLoaderUserCSSPrefsModule, which sets the mtime to wfTimestamp( TS_UNIX, $wgUser->getTouched() ); [05:57:37] wouldn't it be subject to the same issue? [06:00:26] ori-l: How so? if the user changes preferences, the user is touched. So that's accurate, if anything that one is too sensitive. Though a not a problem in practice because it is embedded in the page (group=private) [06:01:03] basically you need to make sure that if your module and another module are loaded in 1 request, and one of them changes, the max() of the two is higher than it was before. [06:01:33] which means it needs to be the current (or a more recent) timestamp, not just incremented. [06:01:39] (03CR) 10Parent5446: [C: 04-1] "See inline comments." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96196 (owner: 10Tholam) [06:02:53] There's a few other factors related to this that I'm considering to majorly refactor next quarter in RL in general, but let's not revamp the system over this :) There's a lot of room for improvement, though most of is for relatively small gains in efficiency and ease of use. Definitely worth it, but understandably omitted from the first design. [06:03:12] (03PS2) 10Aude: Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 [06:10:06] (03PS1) 10TTO: Add a bit to intro text to state that ApiSandbox can modify the wiki [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 [06:15:55] (03CR) 10Krinkle: [C: 031] Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 (owner: 10Aude) [06:17:27] (03PS1) 10Catrope: Use addPlugin() to register VE listener [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 [06:17:46] (03CR) 10Legoktm: [C: 032] Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 (owner: 10Aude) [06:18:03] (03CR) 10Catrope: "Note that I didn't test this at all" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [06:20:45] (03Merged) 10jenkins-bot: Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 (owner: 10Aude) [06:32:13] (03CR) 10Parent5446: [C: 032] Address CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/96155 (owner: 10Siebrand) [06:32:20] (03PS3) 10Parent5446: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96156 (owner: 10Siebrand) [06:32:24] (03CR) 10Parent5446: [C: 032] Update formatting [core] - 10https://gerrit.wikimedia.org/r/96156 (owner: 10Siebrand) [06:35:58] (03Merged) 10jenkins-bot: Address CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/96155 (owner: 10Siebrand) [06:36:29] (03CR) 10Krinkle: [C: 04-1] Use addPlugin() to register VE listener [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [06:39:05] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96156 (owner: 10Siebrand) [06:40:06] (03PS2) 10Catrope: Use $wgVisualEditorPluginModules to register VE listener [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 [06:45:23] (03CR) 10Zfilipin: [C: 031] Remove references to VE in Flow tests, not supported now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96151 (owner: 10Cmcmahon) [06:47:09] (03CR) 10Ori.livneh: Controlled experiment to assess performance of module storage (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 (owner: 10Ori.livneh) [06:48:37] RoanKattouw: since you're in a WikimediaEvents frame of mind, care to review 95129? I'll review your patches now regardless. [06:49:05] !g 95129 [06:49:05] https://gerrit.wikimedia.org/r/#q,95129,n,z [06:49:37] !wm ExpandTemplates [06:49:37] There is no such key, you probably want to try: !botbrain2, !botnoob, !chansearch, !wikimedia, !wmf, !wmf-deployment, !wmo, !wm-bot, !reboot, !tryflow, !dirtydiffs, !parsoid-web, !parsoid-test, !logs, !wm-bot-ping, !htmllogs, [06:49:54] !botnoob [06:49:55] I don't know everything about everything. I am mostly for lazy experienced users to echo quick answers to very common mediawiki questions. Please don't randomly experiment with me for help. Everything I know is at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm and you can visit #mwbot which shares the same db (read only) [06:49:55] That's an !e. [06:50:11] !e ExpandTemplates [06:50:12] https://www.mediawiki.org/wiki/Extension:ExpandTemplates [06:50:42] (03Abandoned) 10Tholam: Updated File page to use HiPI [core] - 10https://gerrit.wikimedia.org/r/96196 (owner: 10Tholam) [06:58:22] (03PS1) 10Tholam: Updated ImagePage to use HiPI [core] - 10https://gerrit.wikimedia.org/r/96212 [06:59:09] ori-l: That WMEvents change looks fine to me. Would you like me to merge it? [06:59:24] RoanKattouw: sure, that'd be great. [07:00:44] (03PS2) 10Tholam: Updated ImagePage to use HiPI [core] - 10https://gerrit.wikimedia.org/r/96212 [07:03:17] (03CR) 10Catrope: [C: 032] Controlled experiment to assess performance of module storage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 (owner: 10Ori.livneh) [07:03:22] (03Merged) 10jenkins-bot: Controlled experiment to assess performance of module storage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 (owner: 10Ori.livneh) [07:03:38] thanks! still testing james's change [07:32:35] andre__: ping [07:36:28] (03CR) 10Ori.livneh: [C: 04-1] "You have to register each schema that you want to use as a ResourceLoader module -- that's the bit that is under the heading "PHP setup fo" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96202 (owner: 10Jforrester) [07:43:11] (03CR) 10Pginer: [C: 04-1] "Thanks for your first commit." [core] - 10https://gerrit.wikimedia.org/r/96197 (owner: 10HectorAE) [07:44:50] (03PS1) 10Siebrand: Remove superfluous parameters with default values [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96213 [07:48:42] (03CR) 10Ori.livneh: [C: 04-1] "* If you're using $wgVisualEditorPluginModules to load ext.wikimediaEvents.ve, you presumably want to remove the line that loads it uncond" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [07:50:43] (03CR) 10Siebrand: [C: 04-1] Add a bit to intro text to state that ApiSandbox can modify the wiki (031 comment) [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [07:53:50] (03CR) 10Spage: "Peanut gallery comment :)" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96189 (owner: 10EBernhardson) [07:55:15] (03PS3) 10Ori.livneh: Use $wgVisualEditorPluginModules to register VE listener [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [07:57:43] (03PS4) 10Ori.livneh: Use $wgVisualEditorPluginModules to register VE listener [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [07:58:22] (03CR) 10Kaldari: "@Tim: I'm afraid I don't see the equivalence you are referring to. Could you let me know which line number you are referring to? Thanks." (031 comment) [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [07:59:00] (03CR) 10Ori.livneh: [C: 031] "PS3 rebases; PS4 drops the unconditional loading in the BeforePageDisplay hook handler. OK to merge from my perspective." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [07:59:57] (03CR) 10Ori.livneh: [C: 032] "Thanks." [vagrant] - 10https://gerrit.wikimedia.org/r/96154 (owner: 10Adamw) [08:00:01] (03Merged) 10jenkins-bot: Make clone --recursive compatible with puppet ensure check [vagrant] - 10https://gerrit.wikimedia.org/r/96154 (owner: 10Adamw) [08:02:21] mayankmadan, pong [08:02:44] (03PS2) 10Hiong3-eng5: OmegaWiki TAGS [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/95994 [08:02:57] andre__: would you please check my task http://www.google-melange.com/gci/task/view/google/gci2013/5884303300886528 [08:03:32] mayankmadan: I'll try do this in the next three hours. I just got up [08:03:50] np [08:04:00] (03PS6) 10Ori.livneh: Make Git::Clone take an optional 'branch' parameter [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [08:04:23] (03CR) 10jenkins-bot: [V: 04-1] Make Git::Clone take an optional 'branch' parameter [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [08:06:38] have any idea when MatmaRex will come online? [08:06:53] It's like 9am for him [08:07:04] I don't know when he usually comes on line because I'm usually asleep at this time of day [08:07:17] (It's midnight in my home timezone, 1:30pm in my current timezone) [08:07:21] (03CR) 10Ori.livneh: Prepare for name-based virtualhosting (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [08:08:17] how's Pune? [08:08:44] It's good [08:09:20] (03PS1) 10Siebrand: Declare visibility on class properties of RCCacheEntry [core] - 10https://gerrit.wikimedia.org/r/96219 [08:09:21] (03PS1) 10Siebrand: Declare visibility on class properties of RecentChange [core] - 10https://gerrit.wikimedia.org/r/96220 [08:09:23] (03PS1) 10Siebrand: Declare visibility on class properties of LinkBatch [core] - 10https://gerrit.wikimedia.org/r/96221 [08:09:28] I'm jealous :P [08:11:37] RoanKattouw: so, how are you liking india? [08:12:05] It's all right [08:12:10] The food is really good actually [08:12:26] Not like any of the Indian food I'm able to get in SF [08:13:57] (03CR) 10Siebrand: [C: 032] "Thank you!" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/96201 (owner: 10Shirayuki) [08:13:59] (03CR) 10Kaldari: "@Tim: If you're referring to the output in equivset.txt, that is the result of I and L no longer both being mapped to the number 1 (which " [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [08:14:31] Also it's almost impossible to eat food that isn't spicy :) I don't mind that too much but I've been a bit careful for fear of upsetting my stomach [08:14:36] (03CR) 10Siebrand: [C: 032] Fix double-space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/95956 (owner: 10Shirayuki) [08:15:18] (03CR) 10Siebrand: [C: 032 V: 032] Fix double-space [extensions/ArticleFeedback] - 10https://gerrit.wikimedia.org/r/95958 (owner: 10Shirayuki) [08:15:31] (03PS2) 10TTO: Add a bit to intro text to state that ApiSandbox can modify the wiki [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 [08:15:46] (03CR) 10Siebrand: [C: 032 V: 032] Fix double-space [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/95961 (owner: 10Shirayuki) [08:16:00] (03CR) 10TTO: "Fair enough. Is the remaining message now clearer, or is the wording still too convoluted?" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:16:05] (03CR) 10Catrope: [C: 031] Use $wgVisualEditorPluginModules to register VE listener [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [08:16:06] (03CR) 10Siebrand: [C: 032] Fix double-space [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95965 (owner: 10Shirayuki) [08:16:19] (03CR) 10Siebrand: [C: 032 V: 032] Fix double-space [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/95968 (owner: 10Shirayuki) [08:17:20] (03CR) 10Catrope: "Good catch on the unconditional loading." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [08:18:18] RoanKattouw: I tested it, so happy to merge it if you like [08:18:29] OK go for it then [08:18:51] (03CR) 10Siebrand: [C: 032] "Useful addition, IMO. Thank you!" [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:18:52] (03CR) 10Ori.livneh: [C: 032] "Tested, looks good." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [08:19:19] (03CR) 10Siebrand: [C: 032 V: 032] Fix double-space [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/95978 (owner: 10Shirayuki) [08:19:44] (03Merged) 10jenkins-bot: i18n: fix double-space [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/96201 (owner: 10Shirayuki) [08:19:48] (03Merged) 10jenkins-bot: Fix double-space [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/95956 (owner: 10Shirayuki) [08:20:02] (03CR) 10jenkins-bot: [V: 04-1] Add a bit to intro text to state that ApiSandbox can modify the wiki [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:20:15] (03CR) 10Siebrand: [C: 032] Fix double-space [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96001 (owner: 10Shirayuki) [08:20:22] (03Merged) 10jenkins-bot: Fix double-space [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95965 (owner: 10Shirayuki) [08:20:51] (03CR) 10Siebrand: "Hmm, appears to have run into a merge conflict..." [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:21:16] (03CR) 10jenkins-bot: [V: 04-1] Add a bit to intro text to state that ApiSandbox can modify the wiki [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:21:21] (03Merged) 10jenkins-bot: Use $wgVisualEditorPluginModules to register VE listener [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/96208 (owner: 10Catrope) [08:21:36] (03Merged) 10jenkins-bot: Fix double-space [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96001 (owner: 10Shirayuki) [08:21:46] (03CR) 10Siebrand: [C: 032 V: 032] Capitalize JavaScript [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/96009 (owner: 10Shirayuki) [08:32:32] (03PS2) 10Siebrand: Declare visibility on class properties of LinkBatch [core] - 10https://gerrit.wikimedia.org/r/96221 [08:37:18] (03CR) 10Hashar: [C: 032] "Haven't found usages myself, and Tim apparently doesn't plan to use it. bye bye old code." [core] - 10https://gerrit.wikimedia.org/r/95983 (owner: 10Siebrand) [08:40:18] (03Merged) 10jenkins-bot: Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 (owner: 10Siebrand) [08:41:25] (03PS1) 10Darkdadaah: Proper getopt + head/tail options [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/96222 [08:43:15] (03CR) 10Hashar: [C: 031] "LinkBatch is missing a ton of public method to interact with the list of Titles, I don't think it is worth it. Keeping $data public give u" [core] - 10https://gerrit.wikimedia.org/r/96221 (owner: 10Siebrand) [08:43:49] (03CR) 10Zfilipin: [C: 031] "Is this the thread at QA mailing list?" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/96146 (owner: 10Cmcmahon) [08:44:41] (03PS3) 10TTO: Add a bit to intro text to state that ApiSandbox can modify the wiki [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 [08:45:00] (03CR) 10Siebrand: [C: 032] Add a bit to intro text to state that ApiSandbox can modify the wiki [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:45:02] (03Merged) 10jenkins-bot: Add a bit to intro text to state that ApiSandbox can modify the wiki [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:45:35] (03CR) 10TTO: "Fixed it." [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/96207 (owner: 10TTO) [08:48:27] (03CR) 10Aude: [C: 031] Declare visibility on class properties of RCCacheEntry [core] - 10https://gerrit.wikimedia.org/r/96219 (owner: 10Siebrand) [08:48:45] gcibot: hi [08:48:45] mayankmadan: Hey, I'm a bot written by aviraldg who inserts metadata about GCI links! Source at: https://github.com/aviraldg/gcibot. [08:51:38] (03PS2) 10Siebrand: Declare visibility on class properties of RecentChange [core] - 10https://gerrit.wikimedia.org/r/96220 [08:51:39] (03PS2) 10Siebrand: Declare visibility on class properties of RCCacheEntry [core] - 10https://gerrit.wikimedia.org/r/96219 [08:51:40] (03PS1) 10Siebrand: Add $counter which was defined dynamically [core] - 10https://gerrit.wikimedia.org/r/96224 [08:54:37] ori-l: So re the VisualEditorTiming suggestion [08:54:45] Is there a way that a property can be optional in an EventLogging schema? [08:55:00] Because all these timings have a duration property in common, but a few have other properties as well [08:55:07] (03CR) 10Legoktm: "L, l, i, I can all look similar which is why it makes sense to map them all to the same thing, which originally ended up being 1." [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [08:55:16] Like things about the AJAX request, or the type of error, or whatever [08:55:19] (03CR) 10Aude: [C: 031] Add $counter which was defined dynamically [core] - 10https://gerrit.wikimedia.org/r/96224 (owner: 10Siebrand) [08:58:19] nm I found required: true, [09:03:10] (03CR) 10Aude: [C: 031] "I don't see $mMovedToTitle used anywhere in core or extensions in gerrit." [core] - 10https://gerrit.wikimedia.org/r/96220 (owner: 10Siebrand) [09:18:24] (03PS9) 10Ori.livneh: Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [09:19:21] (03CR) 10Ori.livneh: [C: 032] "Thanks very much for this. I added your PHP snippet to the comment-block for the role definition and renamed the role itself 'xhprof'." [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [09:19:24] (03Merged) 10jenkins-bot: Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [09:29:31] anyone know if there's a way to view the current job queue on commons? [09:37:20] (03PS7) 10Ori.livneh: Make Git::Clone take an optional 'branch' parameter [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [09:37:35] (03CR) 10Ori.livneh: [C: 032] Make Git::Clone take an optional 'branch' parameter [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [09:37:38] (03Merged) 10jenkins-bot: Make Git::Clone take an optional 'branch' parameter [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [09:47:17] andre__: i dont get your comment on melange task page [09:47:33] mayankmadan, what is unclear? [09:47:38] did you click it? [09:48:44] (03PS1) 10Adamw: SmashPig payments listener and role [vagrant] - 10https://gerrit.wikimedia.org/r/96227 [09:48:45] (03CR) 10jenkins-bot: [V: 04-1] SmashPig payments listener and role [vagrant] - 10https://gerrit.wikimedia.org/r/96227 (owner: 10Adamw) [09:48:56] andre__: why are you pasting the list there? [09:49:11] mayankmadan, because it's one link that anybody can click, instead of ten links. :) [09:49:18] i have uploaded an ods with all the bugs [09:49:21] oh [09:49:23] sorry [09:49:24] :) [09:49:32] convenience :) [09:49:35] now can you mark the task complete? [09:50:03] mayankmadan: once I've reviewed it. I'll do this in the next two hours [09:50:08] been busy with other stuff so far [09:52:47] okay [09:57:52]