[00:02:02] It's not really useful for building an encyclopedia though, is it? [00:02:17] Yes [00:02:25] I mean, feel free to change in Sanitizer.php on your own installation if you have a use case for it. [00:02:31] (03PS1) 10Shirayuki: Fix double-space [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95965 [00:02:33] Nobody's stopping you [00:06:01] (03CR) 10Werdna: [C: 04-1] "A few things about this:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 (owner: 10Matthias Mullie) [00:07:08] MatmaRex: wouldn't 1.2.1 be lesser and 1.21 be higher? [00:07:25] I feel quite mean today. [00:07:42] werdna: today? :) [00:08:09] grrrit-wm: (CR) Werdna: [C: -1] grrrit-wm: (CR) Werdna: [C: -1] grrrit-wm: (CR) Werdna: [C: -1] etc [00:08:25] plus two more where I didn'ta ctually press the CR button :p [00:09:32] heyhey tfinc [00:10:01] Ryan_Lane: yes, which is fine unless you have to implement that comparison logic in a braindead piece of script [00:10:27] MatmaRex: it's easy though, no [00:10:31] Ryan_Lane: feel free to review https://gerrit.wikimedia.org/r/95962 :P [00:10:39] $versionParts = explode( '.', $version ) [00:10:59] and likewise for versionParts2 :p [00:11:02] werdna: somewhat, unless you have a script that accepts an operator as a parameter and eval()s stuff to apply it [00:11:08] ew [00:11:10] in which case it gets annoying [00:11:11] why are you doing that? [00:11:17] anyway, there's wfVersionCompare() in MW [00:11:25] there's version_compare in PHP too. [00:11:28] but none in JS [00:11:45] so i implemented it, feel free to review :P ^ [00:12:04] you could also get super tricky [00:12:34] and use pack() to make it into a plain number :p [00:12:44] or, I suppose, wfBaseConvert() [00:13:24] werdna: not me, and i don't even know who did that [00:13:39] the code comes from http://mediawiki.org/wiki/Special:Code/MediaWiki/72349 "Merging resourceloader branch into trunk" [00:14:19] foreach( explode( '.', $version ) as $part ) { $versionBinary .= str_pad( wfBaseConvert( $part, 10, 2 ), 8, '0', STR_PAD_LEFT ); } [00:14:41] $realVersion = wfBaseConvert( 2, 10, $versionBinary ) [00:14:43] :D [00:16:25] ok, review plz, and good night everyone. [00:17:01] gnight MatmaRex [00:20:41] (03PS11) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [00:21:01] (03PS1) 10Tim Starling: Exclude servers with zero load from lag checks [core] - 10https://gerrit.wikimedia.org/r/95967 [00:27:39] (03PS1) 10Shirayuki: Fix double-space [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/95968 [00:29:51] * werdna enjoyed TimStarling's rant on engineering@ :) [00:31:20] werdna: about? [00:32:06] si [00:35:30] wassup saper [01:13:22] (03PS1) 10MarkTraceur: Fix sitename use in section description [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95970 [01:51:17] What's he ranting about werdna? [01:51:53] what's who ranting about? [01:52:02] oh? timstarling [01:52:10] just some DB stuff [02:29:31] (03CR) 10Legoktm: [C: 032] "Thanks, nice catch." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/95852 (owner: 10UltrasonicNXT) [02:29:32] (03Merged) 10jenkins-bot: Fix mime type bug [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/95852 (owner: 10UltrasonicNXT) [02:38:37] (03CR) 10Legoktm: [C: 04-1] "Looks fine to me, just needs a rebase. Note that most of this code is going away with I9329573da7d4f2af60515ef32b3b64bb769e3755, which is " [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/95853 (owner: 10UltrasonicNXT) [02:44:49] (03PS1) 10Werdna: Consolidate and clean up "scroll to this element" code. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 [02:45:02] (03CR) 10jenkins-bot: [V: 04-1] Consolidate and clean up "scroll to this element" code. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [02:45:15] * werdna blows raspberries at jenkins-bot [02:47:25] (03PS2) 10Werdna: Consolidate and clean up "scroll to this element" code. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 [02:49:52] (03PS3) 10Werdna: Consolidate and clean up "scroll to this element" code. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 [02:59:23] O.o [03:38:20] (03PS2) 10Dan-nl: whitelisted-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 [03:39:17] (03CR) 10Dan-nl: "modified the commit message" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 (owner: 10Dan-nl) [04:04:36] (03PS2) 10Parent5446: (bug 48519) Basic support for WebP [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [04:05:06] (03PS4) 10Siebrand: Update defaults for addGoodLinkObj() to int [core] - 10https://gerrit.wikimedia.org/r/95945 [04:17:16] Krinkle: 07940059beedada6e5b93708bf783e88a75da239 [04:23:39] (03PS1) 10Shirayuki: Fix double-space [extensions/MaintenanceShell] - 10https://gerrit.wikimedia.org/r/95978 [04:33:32] (03PS5) 10Krinkle: Update defaults for addGoodLinkObj() to int [core] - 10https://gerrit.wikimedia.org/r/95945 (owner: 10Siebrand) [04:36:01] (03CR) 10Krinkle: [C: 031] Update LinkCache::addGoodLinkObj param defaults to int [core] - 10https://gerrit.wikimedia.org/r/95945 (owner: 10Siebrand) [04:39:14] (03PS1) 10Siebrand: Set visibility for class properties of DependencyWrapper [core] - 10https://gerrit.wikimedia.org/r/95981 [04:39:15] (03PS1) 10Siebrand: Set visibility on class properties for *Dependency classes [core] - 10https://gerrit.wikimedia.org/r/95982 [04:39:16] (03PS1) 10Siebrand: Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 [04:42:01] (03PS4) 10Krinkle: Add show=unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91845 [04:42:03] (03PS1) 10Gnosygnu: v0.11.1.0 [xowa] - 10https://gerrit.wikimedia.org/r/95984 [04:42:29] (03CR) 10BryanDavis: [C: 04-1] Mediawiki can be checked out on a branch (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [04:42:40] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/95984 (owner: 10Gnosygnu) [04:43:15] (03CR) 10Krinkle: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [04:52:50] (03PS2) 10Siebrand: Set visibility for class properties of DependencyWrapper [core] - 10https://gerrit.wikimedia.org/r/95981 [04:53:14] (03PS2) 10Siebrand: Set visibility on class properties for *Dependency classes [core] - 10https://gerrit.wikimedia.org/r/95982 [04:53:21] (03PS2) 10Siebrand: Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 [04:53:30] (03CR) 10BryanDavis: [C: 04-1] Add role::profiler utilizing XHProf (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [04:53:45] (03PS3) 10Siebrand: Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 [04:56:28] (03PS4) 10Siebrand: Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 [04:58:05] (03CR) 10jenkins-bot: [V: 04-1] Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 (owner: 10Siebrand) [04:59:01] (03PS5) 10Siebrand: Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 [05:05:42] (03PS5) 10Krinkle: Add show=unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91845 [05:19:40] (03PS1) 10Werdna: [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 [05:20:56] (03PS2) 10Werdna: [SCHEMA CHANGE] Refactor of moderation logging. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95985 [05:28:12] (03CR) 10BryanDavis: [C: 04-1] Provision the fundraising-crm project (0310 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [05:47:33] (03CR) 10Siebrand: Show an error to the user if the spamlist has no targets on it (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [05:55:12] (03CR) 10BryanDavis: [C: 031] whitelisted-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 (owner: 10Dan-nl) [05:59:26] (03PS1) 10Werdna: Moderated post/topic styling: * Actually apply classes that were supposed to be applied. * Remove coloured icons on hover; they falsely imply that the element is hot. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95986 [06:15:29] whaaat the fuck [06:15:34] * werdna glares at parsoid [06:22:45] heyhey brion [06:22:53] what up [06:23:33] how's brion life? [06:23:45] I hear you've found a new crib? [06:23:48] briontastic! [06:23:58] I'm not brion any of that. [06:23:59] yep, moving in like..... a week [06:24:00] * werdna runs [06:24:02] heh [06:24:14] sounds like the end of a very annoying era. Did the landlord pay you to do it up? [06:24:34] werdna: subtle attempt at a house welcoming invite? [06:25:20] p858snake|l: well, unless I plan on flying over to SF for it, it seems not so plausible [06:25:26] hehe [06:25:57] werdna: well brion could plan it around the summit if you are attending that [06:25:59] werdna just appears here intermittently, then disappears to other countries for months before returning like a ghost ship [06:26:39] brion: thaaat is annoying [06:28:48] brion: new place seems a bit better? [06:29:26] new place is run by a faceless corporation instead of a random landlord. and it requires no additional renovation :D and it's not at the top of a hill [06:29:28] so..... yeah [06:29:45] i think it's an all around win \o/ [06:33:47] brion: \o/ [06:33:51] hooray for faceless corporations! [06:34:14] oh I think you mentioned, big fancy secure building? [06:34:23] does it have a pool and a gym and all that neat shit? [06:35:06] not sure about a pool, but yes they have that sort of stuff :) [06:36:40] \o/ [06:37:44] (03PS2) 10IAlex: Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/95943 (owner: 10L10n-bot) [06:37:51] (03CR) 10IAlex: [C: 032] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/95943 (owner: 10L10n-bot) [06:43:11] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/95943 (owner: 10L10n-bot) [07:09:20] (03PS2) 10Robmoen: WIP: Target mobile on ve dependencies [core] - 10https://gerrit.wikimedia.org/r/93915 [07:42:56] (03CR) 10Robert Vogel: [C: 032 V: 032] "Thanks for your contribution" [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/95959 (owner: 10Shirayuki) [08:21:06] hi mwalker [08:21:23] greetings; what can I do for you? [08:24:45] nothing. :) just wanted to thank you for changing my rights to shell [08:24:54] mwalker: ^ [08:25:09] ah; np [08:25:18] you have everything else you need? [08:25:47] *not that I have rights to do much else; but I can at least prod the right people typically [08:27:20] everything else? [08:27:45] 8 hrs to go now before the start of the contest :) [08:28:29] that sounds ominous [08:29:57] its not ominous... Its actually a good thing thats about to happen [08:30:50] (03CR) 10Krinkle: Add show=unpatrolled to the recentchanges API (032 comments) [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [08:30:55] [08:31:57] Amgine: huh? [08:32:17] Why it might sound ominous. [08:32:45] Never mind, obscure north american references. [08:32:57] Hello [08:33:12] It's not obscure at all (I'm from Asia...) [08:33:24] what the hell is Jaws [08:33:35] Im from Asia too (India) [08:33:42] Also, can I ask- why does the contest start in 8 hours? [08:33:46] A horror/suspense movie about a shark which attacks people. [08:33:53] Does the GCI website not say 1700 UTC = GMT? [08:34:36] but the timer on the website says 8 hours 30 minutes for the contest to start [08:34:38] ahhh... that content [08:34:43] *contest [08:35:08] @mayankmadan, exactly, they don't match... [08:35:59] YuGin, Amgin are you two going to participate in the contest as well? [08:36:19] Yes, I am [08:36:57] what about Amgine? [08:37:10] Never mind about the timing issue, I just realised I interpreted it wrongly... [08:38:11] (03PS1) 10Hiong3-eng5: OmegaWiki TAGS [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/95994 [08:38:38] No, it matches [08:38:43] It's 8:38 UTC [08:38:52] Yes- I derped, lol [08:38:53] So 17:00 UTC is in 8 hours and 22 minutes [08:39:09] where are you from YuGin [08:39:15] Singapore [08:39:28] That's UTC+8, right? [08:39:42] Yup. Can we please forget I ever said anything about the timing :P [08:39:45] No worries :) [08:40:04] 1am start time for me. Meh. [08:40:09] RoanKattouw: aren't you supposed to be in India recovering from jet lag? [08:40:11] I am in UTC+5:30 right now and it's confusing the hell out of me :) [08:40:22] mwalker: We've already started the conference, it's 2pm on Monday afternoon already [08:40:41] ahhh [08:40:53] that means I should probably go to bed... [08:40:57] Jetlag recovery consisted of arriving at the hotel at 2:30am, going to sleep at 4am, waking up at 6:45pm, eating dinner, going to sleep at 4am, waking up at 8am to eat breakfast and start the event at 10am [08:42:27] Whats mediawiki doing in india [08:42:43] Language Summit at in Pune [08:42:46] -at [08:42:49] * RoanKattouw clearly has not slept enough [08:50:26] hello [08:50:33] (03PS5) 10Mwalker: WIP Node.JS Renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 [08:56:19] hello hashar [09:36:54] (03CR) 10Krinkle: [C: 04-1] "random braindump" (032 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 (owner: 10Mwalker) [09:47:37] (03PS1) 10Shirayuki: Fix double-space [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/96001 [10:16:11] (03CR) 10Shirayuki: [C: 031] "What next?" [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/95130 (owner: 10Shirayuki) [10:26:44] (03Draft1) 10Bartosz Dziewoński: Relicense jquery.placeholder.js to MIT [core] - 10https://gerrit.wikimedia.org/r/95748 [10:26:48] (03Draft2) 10Krinkle: Relicense jquery.placeholder.js to MIT [core] - 10https://gerrit.wikimedia.org/r/95748 (owner: 10Bartosz Dziewoński) [10:27:28] (03CR) 10Bartosz Dziewoński: [C: 032] "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/95748 (owner: 10Bartosz Dziewoński) [10:30:42] (03Merged) 10jenkins-bot: Relicense jquery.placeholder.js to MIT [core] - 10https://gerrit.wikimedia.org/r/95748 (owner: 10Bartosz Dziewoński) [10:32:31] (03CR) 10Physikerwelt: "To rewrite the texvc stuff with php is a little bit more work as I thought. The braket handling of texvc is not very intuitive and some re" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [10:44:10] (03PS1) 10Shirayuki: Capitalize JavaScript [extensions/ThemeDesigner] - 10https://gerrit.wikimedia.org/r/96009 [10:46:04] (03PS1) 10MaxSem: Add profiling [extensions/Math] - 10https://gerrit.wikimedia.org/r/96010 [10:46:09] anyone want to review the trivial ^^^ ? [10:46:19] (03CR) 10jenkins-bot: [V: 04-1] Add profiling [extensions/Math] - 10https://gerrit.wikimedia.org/r/96010 (owner: 10MaxSem) [10:46:25] fcuk [10:47:17] (03CR) 10MaxSem: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/96010 (owner: 10MaxSem) [10:48:20] physikerwelt__, any ideas why math rendering suddenly started timing out on WMF? [11:02:33] (03PS1) 10QChris: Clarify use of "--globals" in getSlaveServerTest [core] - 10https://gerrit.wikimedia.org/r/96011 [11:06:11] (03CR) 10QChris: Adding tests for dumps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/4155 (owner: 10QChris) [11:10:37] (03CR) 10QChris: [C: 04-1] "After applying this change, the test would no longer test the" [core] - 10https://gerrit.wikimedia.org/r/95868 (owner: 10Nikerabbit) [11:22:00] (03CR) 10Physikerwelt: [C: 032] "For the Jenkins problem see my comment on PS 11" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/96010 (owner: 10MaxSem) [11:22:12] (03CR) 10jenkins-bot: [V: 04-1] Add profiling [extensions/Math] - 10https://gerrit.wikimedia.org/r/96010 (owner: 10MaxSem) [11:23:31] (03CR) 10MaxSem: [V: 032] Add profiling [extensions/Math] - 10https://gerrit.wikimedia.org/r/96010 (owner: 10MaxSem) [11:33:43] Amgine: re convo on -labs, the 'style=' element, there exists https://bugzilla.wikimedia.org/show_bug.cgi?id=35704 [11:33:50] * yuvipanda disappears again [11:36:19] (03PS1) 10Dan-nl: mediafile-job-array [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 [11:40:26] (03CR) 10Bartosz Dziewoński: "Eh, I'll just mark this as unused in core and leave it. SpecialMobileWatchlist uses a few other message keys it really shouldn't be using " [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [11:40:41] Style yuvipanda ? we were talking about contenteditable="true" attribute... [11:41:35] (03CR) 10Siebrand: "Looks like I didn't hit the right button..." [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/95130 (owner: 10Shirayuki) [11:42:59] (is still amused by that bug...) it's like Wikipedia deprecating the hyphen in favour of various specialty dashes. Sure those may be more typographically correct, but everyone *has* a hyphen on the kbd... [11:43:58] aye...I'm a huge fan of — myself, but -- is a lot easier to type >.> [11:44:45] For the same reason, when you need a one-off style element, you just use style="blah" [11:46:03] aye...some folks even want to go further and use a extension because they can't be bothered editing [[MediaWiki:Common.css]] (or [[MediaWiki:Skinname.css]]) [11:47:28] MW can spend all the fuel in the world fighting gravity, but it might be better spent figuring out how make it easier to not use inline styles. [11:56:13] (03PS3) 10Bartosz Dziewoński: Remove 'prefsnologin' message, don't use 'watchnologin' where inappropriate [core] - 10https://gerrit.wikimedia.org/r/94411 [11:57:48] (03PS3) 10Bartosz Dziewoński: Canonicalize text and update docs of messages using 'loginreqlink' [core] - 10https://gerrit.wikimedia.org/r/94414 [11:58:21] (03PS1) 10Hashar: make-release: unit tests for MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96016 [11:59:55] (03PS1) 10Hashar: .gitignore: *.pyc [tools/release] - 10https://gerrit.wikimedia.org/r/96017 [12:00:06] (03CR) 10Hashar: [C: 032] .gitignore: *.pyc [tools/release] - 10https://gerrit.wikimedia.org/r/96017 (owner: 10Hashar) [12:00:45] (03Merged) 10jenkins-bot: .gitignore: *.pyc [tools/release] - 10https://gerrit.wikimedia.org/r/96017 (owner: 10Hashar) [12:03:46] (03PS2) 10Hashar: make-release: unit tests for MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96016 [12:19:14] hashar: did you get the glue installed? [12:19:49] AzaToth: needs ops to merge the change, build the package and upload it on apt.wikimedia.org [12:19:58] k [13:05:05] (03CR) 10Nikerabbit: "Please mark the test so that it is not executed by default or fix it. Printing megabytes of text during 'make safe' is not okay." [core] - 10https://gerrit.wikimedia.org/r/96011 (owner: 10QChris) [13:12:18] (03PS8) 10Hashar: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [13:12:21] (03CR) 10jenkins-bot: [V: 04-1] git-logs: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [13:15:16] (03PS1) 10Dan-nl: adviseStat [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96019 [13:22:00] (03CR) 10Cmcmahon: [C: 032] "documentation" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95591 (owner: 10Zfilipin) [13:24:41] (03CR) 10Addshore: [C: 031] Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 (owner: 10Aude) [13:34:28] (03PS1) 10Njw: Add :focus rules where :hover was, and reorganise css slightly [skins/erudite] - 10https://gerrit.wikimedia.org/r/96020 [13:47:45] (03CR) 10Addshore: Add tests for EnhancedChangesList class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/93611 (owner: 10Aude) [13:53:53] (03PS1) 10Njw: Use subsetted versions of the fonts to reduce file sizes. [skins/erudite] - 10https://gerrit.wikimedia.org/r/96021 [13:56:31] (03CR) 10QChris: "> Printing megabytes of text during 'make safe' is not okay." [core] - 10https://gerrit.wikimedia.org/r/96011 (owner: 10QChris) [13:57:10] (03CR) 10Njw: [C: 032 V: 032] Add :focus rules where :hover was, and reorganise css slightly [skins/erudite] - 10https://gerrit.wikimedia.org/r/96020 (owner: 10Njw) [14:00:21] (03CR) 10Njw: [C: 032 V: 032] Use subsetted versions of the fonts to reduce file sizes. [skins/erudite] - 10https://gerrit.wikimedia.org/r/96021 (owner: 10Njw) [14:06:37] (03PS1) 10Manybubbles: Description for new message key. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96022 [14:16:14] (03PS1) 10Zfilipin: Added links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/96023 [14:20:23] (03PS1) 10Yaron Koren: Made template-specific sections appear only for multi-instance templates, etc. [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/96024 [14:22:10] (03CR) 10Zfilipin: "How the new page looks like: https://git.wikimedia.org/blob/mediawiki%2Fselenium/233eabe179a75079b399cded6f458d1c4d8d917a/README.md" [selenium] - 10https://gerrit.wikimedia.org/r/96023 (owner: 10Zfilipin) [14:26:21] hi qgil [14:32:44] (03CR) 10Nikerabbit: "I usually (try to) run unit tests for core (and installed extensions) every couple of months. I fix and report few issues and then I get s" [core] - 10https://gerrit.wikimedia.org/r/96011 (owner: 10QChris) [14:38:33] (03PS3) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 [14:44:11] (03PS1) 10Shirayuki: Fix "action-*" message [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/96028 [14:45:59] (03PS2) 10Shirayuki: Fix "action-*" message [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/96028 [14:50:56] (03CR) 10Zfilipin: "Relevant bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=57188" [selenium] - 10https://gerrit.wikimedia.org/r/92650 (owner: 10Zfilipin) [14:52:53] (03CR) 10Yaron Koren: [C: 032 V: 032] Made template-specific sections appear only for multi-instance templates, etc. [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/96024 (owner: 10Yaron Koren) [14:58:49] (03CR) 10Anomie: [C: 032] "I do hope you will submit another changeset to add this and Ic947c6c7 to ApiQueryUserContributions and ApiQueryWatchlist as well." [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [14:58:56] (03CR) 10Zfilipin: "Relevant bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=57188" [selenium] - 10https://gerrit.wikimedia.org/r/93443 (owner: 10Zfilipin) [15:01:50] (03Merged) 10jenkins-bot: Add show=unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [15:05:42] (03PS1) 10IAlex: Allow null to be passed to User::setNewPassword() [core] - 10https://gerrit.wikimedia.org/r/96029 [15:08:10] mayankmadan, hi [15:20:47] (03CR) 10Aude: Add tests for EnhancedChangesList class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/93611 (owner: 10Aude) [15:30:45] (03PS1) 10Mwjames: Remove Scribunto from smw-core unit test suite [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96032 [15:38:38] guillom, hi! Our 1:1 is exactly at the same time than the beginning of GCI. Do you mind if I reschedule it to Wednesday? [15:40:13] (03PS4) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 [15:40:26] addshore: ^ if you like to give feedback :) [15:40:44] !gcibot [15:41:08] im having a strange feeling in my stomach :) [15:41:45] (03PS5) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 [15:46:25] (03PS1) 10Aude: Move RecentChangeTest to subdirectory [core] - 10https://gerrit.wikimedia.org/r/96035 [16:02:49] (03CR) 10Addshore: [C: 031] Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 (owner: 10Aude) [16:03:23] (03PS1) 10Hashar: make-release: enhance MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96038 [16:03:24] (03CR) 10Addshore: [C: 031] Move RecentChangeTest to subdirectory [core] - 10https://gerrit.wikimedia.org/r/96035 (owner: 10Aude) [16:03:43] aude: are you going to put your new test in the dir? :) [16:03:55] it is [16:03:59] ahh :D [16:04:48] then i was wondering if RecentChange had any tests.... [16:04:55] doubt it :D [16:05:01] not much but it does [16:05:05] :D [16:06:09] aude, core has a whopping 3.58 coverage :D [16:06:13] (03CR) 10Anomie: [C: 04-1] "Don't worry about the large number of comments, many are whitespace nitpicks that I'll fix if you don't want to." (0313 comments) [core] - 10https://gerrit.wikimedia.org/r/40337 (owner: 10btongminh) [16:06:16] hah, yes [16:06:55] covers the irc feed part [16:07:45] added by kri*nkle :) [16:07:49] aude: https://integration.wikimedia.org/cover/mediawiki-core/master/php/ssd_jenkins-slave_workspace_mediawiki-core-code-coverage_includes_Status.php.html [16:08:06] Give it a week and status can have full test coverage :D [16:08:23] \o/ [16:08:57] care to review https://gerrit.wikimedia.org/r/#/c/95620/ and https://gerrit.wikimedia.org/r/#/c/95770/ ? :) [16:09:03] get in line! [16:09:08] ;p [16:09:11] * aude has a long queue [16:09:33] * addshore has a long queue [16:09:39] :) [16:10:12] (03CR) 10Anomie: "> also note that WikitextContent is mutable, with stuff like addSectionHeader." [core] - 10https://gerrit.wikimedia.org/r/95519 (owner: 10Aaron Schulz) [16:11:57] (03CR) 10Aude: "@anomie you are right :)" [core] - 10https://gerrit.wikimedia.org/r/95519 (owner: 10Aaron Schulz) [16:14:49] (03CR) 10Addshore: [C: 032 V: 032] Add .gitreview and .gitignore [extensions/DataValueImplementations] - 10https://gerrit.wikimedia.org/r/88658 (owner: 10Reedy) [16:15:54] aude: which repo is the grrrit-wm config stuff in? :P [16:16:22] labs/tools/grrrit [16:16:22] :D [16:16:43] (03CR) 10Jeroen De Dauw: [C: 031] Remove Scribunto from smw-core unit test suite [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96032 (owner: 10Mwjames) [16:17:06] not all of it [16:17:27] no you are right [16:17:35] * aude confused with the labs projects [16:24:08] aude, JeroenDeDauw: so, I'm wondering how to best "hack" the PropertyDataTypeLookup into SnakSerializer. My current approach, injecting via the SerializationOptions and warning if it's missing, causes a lot of pain. [16:24:28] wrong channel? [16:24:29] DanielK_WMDE: :) [16:24:37] indeed [16:24:39] :P [16:24:41] thanks [16:28:19] Did anyone ask to enable gcibot in this channel? [16:28:28] (03CR) 10Hashar: "I wrote them to be able to refactor the MwVersion class in https://gerrit.wikimedia.org/r/#/c/96038/" [tools/release] - 10https://gerrit.wikimedia.org/r/96016 (owner: 10Hashar) [16:29:17] Oh, it's a Google Code-In thing. [16:29:26] (03CR) 10Hashar: "The refactoring is covered by unit tests. I did a few manual tests which went fine as well. A second testing round would be nice :-)" [tools/release] - 10https://gerrit.wikimedia.org/r/96038 (owner: 10Hashar) [16:29:34] qgil: Are you orchestrating the gcibot thing? [16:29:58] marktraceur, ??? I just saw it mentioned before. No idea what is this. [16:30:00] (03PS2) 10Hashar: make-release: enhance MwVersion [tools/release] - 10https://gerrit.wikimedia.org/r/96038 [16:30:03] hi all [16:30:06] Huh. [16:30:15] is there way to change the colour of login / create account ? [16:30:20] link* [16:30:29] marktraceur, hey [16:30:29] left atop page [16:30:46] aviraldg: Hi there. This is your bot, then :) [16:30:51] see https://en.wikivoyage.org/wiki/User:Nicholasjf21/MainPage2 [16:30:52] yep [16:31:04] Did you talk with someone our end about enabling it in this channel? [16:31:04] This is what it does: [16:31:05] https://google-melange.appspot.com/gci/task/view/google/gci2012/7948211 [16:31:08] I get the idea [16:31:08] [Eden] Mapping: Potlatch integration [16:31:08] Status: Reopened [16:31:08] Mentor(s): Fran, Pat Tressel [16:31:16] ...see, that could get annoying [16:31:26] Uh, no. Is there a problem? I can remove it then :) [16:31:36] Especially since we already have a bit of bot traffic, I'm a little cautious about adding more [16:31:50] But I'll defer to qgil [16:32:01] Sure :) [16:32:06] Just ping me if you don't want it here. [16:32:23] huh, it reports non-wikimedia stuff? [16:32:25] aviraldg: Generally, A) Ask the channel before enabling a bot, B) Put information about the bot in the WHOIS [16:32:50] will keep that in mind [16:32:57] hashar : you know [16:33:04] ? [16:33:04] marktraceur, aviraldg GCI is about to start in 28 mins. Letś discuss this bot !now, meaning later. :) [16:33:57] aviraldg, the idea is interesting, but please propose it first at https://www.mediawiki.org/wiki/Talk:Google_Code-in - thank you! [16:35:04] aviraldg, marktraceur maybe the right solution is to have a #wikimedia-gci channel during the GCI period? Anyway, happy to hear ideas but I can't discuss right now. [16:35:29] That's what Drupal and KDE are doing. [16:38:52] (03PS1) 10Addshore: Switch Query and QueryEngine to checks only [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96043 [16:39:35] (03PS1) 10Addshore: Remove dependancies that are not on gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96044 [16:40:28] (03PS2) 10Aude: Remove dependancies that are not on gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96044 (owner: 10Addshore) [16:40:49] (03CR) 10KartikMistry: [C: 031] "LGTM." [selenium] - 10https://gerrit.wikimedia.org/r/96023 (owner: 10Zfilipin) [16:41:45] (03CR) 10Aude: [C: 031] Remove dependencies that are not on gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96044 (owner: 10Addshore) [16:42:07] (03CR) 10Addshore: "As an alternative please see I0be4f86d2b862ee83ea1d6fa8a812d83f2b6cce8 and I866568379ed67d22343a86d565b249b7f763f01f" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [16:42:14] (03CR) 10Addshore: "As an alternative please see I0be4f86d2b862ee83ea1d6fa8a812d83f2b6cce8 and I866568379ed67d22343a86d565b249b7f763f01f" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95616 (owner: 10Jeroen De Dauw) [16:42:17] (03CR) 10Aude: [C: 031] Switch Query and QueryEngine to checks only [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96043 (owner: 10Addshore) [16:44:13] (03PS1) 10Cmcmahon: new test for editing existing title, also alphabetize and cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96047 [16:44:37] (03PS1) 10Zfilipin: MobileFrontend Jenkins jobs run just features/scenarios with appropriate tag [selenium] - 10https://gerrit.wikimedia.org/r/96048 [16:44:39] (03Abandoned) 10Cmcmahon: new test for editing existing title, also alphabetize and cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93069 (owner: 10Cmcmahon) [16:45:01] (03PS2) 10Zfilipin: MobileFrontend Jenkins jobs run just features/scenarios with appropriate tag [selenium] - 10https://gerrit.wikimedia.org/r/96048 [16:47:27] (03CR) 10Cmcmahon: [C: 032] "maintenance" [selenium] - 10https://gerrit.wikimedia.org/r/96048 (owner: 10Zfilipin) [16:48:06] (03CR) 10Anomie: [C: 031] Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [16:49:33] (03PS2) 10BryanDavis: Added fail-over support to JobQueueAggregatorRedis using "redisServers" option [core] - 10https://gerrit.wikimedia.org/r/95953 (owner: 10Aaron Schulz) [16:49:42] (03CR) 10BryanDavis: [C: 032] Added fail-over support to JobQueueAggregatorRedis using "redisServers" option [core] - 10https://gerrit.wikimedia.org/r/95953 (owner: 10Aaron Schulz) [16:50:28] (03CR) 10Jhall: [C: 031] Added links to Jenkins jobs [selenium] - 10https://gerrit.wikimedia.org/r/96023 (owner: 10Zfilipin) [16:51:01] (03CR) 10Parent5446: [C: 032] Allow null to be passed to User::setNewPassword() [core] - 10https://gerrit.wikimedia.org/r/96029 (owner: 10IAlex) [16:53:49] IMPORTANT: Google Code-in is about to start! If you are following this channel you probably want to read http://lists.wikimedia.org/pipermail/wikitech-l/2013-November/073160.html [16:54:32] (03Merged) 10jenkins-bot: Added fail-over support to JobQueueAggregatorRedis using "redisServers" option [core] - 10https://gerrit.wikimedia.org/r/95953 (owner: 10Aaron Schulz) [16:56:20] (03Merged) 10jenkins-bot: Allow null to be passed to User::setNewPassword() [core] - 10https://gerrit.wikimedia.org/r/96029 (owner: 10IAlex) [16:57:44] (03CR) 10BryanDavis: [C: 04-1] mediafile-job-array (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [17:03:50] (03CR) 10BryanDavis: [C: 031] "The core change looks fine but I'd rather not see Config::$version changing in a nearly random manner from changeset to changeset." (031 comment) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96019 (owner: 10Dan-nl) [17:06:08] yipee [17:06:10] gci is on [17:06:15] (03PS1) 10Njw: Add SVG master versions for all images [skins/erudite] - 10https://gerrit.wikimedia.org/r/96053 [17:06:45] qgil: I'd be in favour, but it would mean not being able to see the patchsets roll in live maybe [17:07:48] (03CR) 10Njw: [C: 032 V: 032] Add SVG master versions for all images [skins/erudite] - 10https://gerrit.wikimedia.org/r/96053 (owner: 10Njw) [17:07:51] (03CR) 10Dan-nl: "i haven't been consistent with incrementing the version number and just started to do it today. are you okay with me doing it from here on" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96019 (owner: 10Dan-nl) [17:08:31] marktraceur, aviraldg it would be good to know the traffic generated by the GCi bot. The documentation is... sparse :) [17:08:46] ? [17:09:01] aviraldg, I mean, when does your bot send a message to a channel [17:09:13] qgil: See the example aviraldg gave me - every time you link to a project description, it outputs three lines about the project [17:09:13] aviraldg, it is my/our first GCI, bear with us. :) [17:09:18] aviraldg: are you still eligible for gci? [17:09:33] yeah [17:09:51] and there are other commands (not pushed to the repo yet) but they're channel specific [17:10:14] no channel specific commands for #wikimedia-dev, though [17:10:20] ah, I thought it was a bot sending updates whenever a task was created, taken, completed... [17:11:01] Ugh, GCI is all organized through Melange? I say again ugh. [17:11:10] UGH [17:11:29] They should just rename it to "500 INTERNAL SERVER ERROR" [17:11:43] marktraceur, what do you expect? Our tasks point to bug reports and wiki pages, though [17:11:46] mayankmadan, yes [17:12:02] marktraceur, discussion and support requests are supposed to happen out of Melange, in our community channels [17:12:12] Well that's a start [17:13:01] marktraceur, all tasks with a common line sending students to read our GCI page, which starts with this section: https://www.mediawiki.org/wiki/Google_Code-in#Feedback_and_support [17:13:55] Also good-ish [17:14:37] I dunno, I'm vaguely uncomfortable with the sponsored mentorship programs since reading the news articles about Facebook's Open Academy thing [17:15:00] But, not the time to talk about it [17:15:05] Godo luck with GCI everyone :) [17:17:16] (03CR) 10BryanDavis: "Dan," [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96019 (owner: 10Dan-nl) [17:18:01] join #wikidata [17:18:03] marktraceur, about Facebook let's see whether they reply in the first place. :) [17:18:26] I am looking for someone called kelson [17:18:38] am i at the right place [17:18:39] (03CR) 10Dan-nl: "sounds good; i'll stop changing the version in each changeset." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96019 (owner: 10Dan-nl) [17:18:40] ugh_: ugh. [17:18:59] sakysharma: what is kelson's organisation? [17:19:21] qgil: I guess if they did, we could more accurately determine what the program looks like [17:19:35] qgil: are mentors supposed to receive a notification mail if a student claims their task? [17:20:21] Rtdwivedi, I believe so. [17:20:32] kelson == Emmanuel Engelhart (Kelson): Kiwix & offline [17:20:40] thanks. :-) [17:21:11] 'ey man, you L. Englehart? [17:22:49] sakysharma, try at #kiwix -- and I will add a list of mentors with contact points at https://www.mediawiki.org/wiki/Google_Code-in [17:22:55] (03CR) 10Addshore: [C: 04-1] More profiling points for WikiPage::doEditContent. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/46945 (owner: 10Daniel Kinzler) [17:23:06] DanielK_WMDE_: ^^ [17:23:07] (03PS1) 10Zfilipin: All MobileFrontend Jenkins jobs should send e-mail notification to the same addresses [selenium] - 10https://gerrit.wikimedia.org/r/96058 [17:24:02] is Bartosz Dziewoński MatmaRex? [17:24:13] mayankmadan, yes, he is [17:25:04] any idea when he will come online [17:28:59] addshore: DanielK_WMDE_ wow that is ancient [17:29:02] mayankmadan, nope, but he can be found here *very* often. Also, he is a former GCI student so he know how it feels. ;) [17:29:18] aude: what is? :P [17:29:29] https://gerrit.wikimedia.org/r/#/c/46945/ [17:29:42] oh wow, yes.... [17:30:06] * aude queues up to get gerrit change 100000 :D [17:30:23] (03CR) 10EBernhardson: Add role::profiler utilizing XHProf (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [17:40:22] go, aude, go ;) [17:40:33] Rtdwivedi, please add your data at https://www.mediawiki.org/wiki/Google_Code-in#Mentors [17:40:49] chrismcmahon, ^^^ [17:40:56] qgil: Already doing that. :) [17:41:13] aude: Change 100k is quite a ways off [17:42:11] RTdwivedi: you a mentor? [17:42:47] mayankmadan: yes. [17:44:12] marktraceur: maybe not so far, maybe another month [17:44:22] I'd say two weeks [17:44:28] could be [17:44:31] pretty soon :) [17:44:49] * aude wants a prize  [17:45:51] who is andre klapper? [17:46:05] mayankmadan: andre__ in here, but he's not around right now [17:46:09] andre__ on IRC. [17:47:07] Rtdwivedi, now I can confirm that you receive an email when someone claims a task you mentor. [17:47:15] I got a first student! Yay! http://www.google-melange.com/gci/task/view/google/gci2013/4926205350379520 [17:47:19] Create title cards to wrap MediaWiki related videos [17:47:19] Status: Claimed (3 hours, 23 minutes left) [17:47:19] Mentor(s): Guillaume Paumier, Quim Gil [17:47:28] ok, now I see :) [17:47:32] OK that's officially annoying [17:48:37] yep, I don't see it adds much value. It might be interesting in low-traffic IRC channels but here we have already several bots [17:49:08] aviraldg, please deactivate your bot in this channel. Thank you! See ^^^ [17:49:30] Sure. Sorry for the trouble! [17:49:41] :/ [17:49:56] (03CR) 10BryanDavis: Add role::profiler utilizing XHProf (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [17:50:58] qgil: sorry, I didn't see your ping earlier, but I assumed something like this happened when I saw the calendar update :) [17:51:19] You're smart, guillom :) [17:51:33] bd808: hmm, adding the 'include role::mediawiki' doesn't do the trick either [17:51:41] Unlike me, who hadn't thought before about the coincidence of meetings guillom [17:52:17] ebernhardson: :( My puppet fu is just strong enough to get me in trouble. [17:52:20] qgil: Well, I didn't realize it was the exact same time, but I thought "well, a busy week is starting so he had to do more urgent things" [17:52:29] anyway; dinner time now :) bbl [17:52:29] bd808: :) [17:52:59] ebernhardson: I bet ori-l can help figure out the "right" thing when he finds time to review the changeset [17:53:14] guillom, I took the liberty of adding you as co-mentor in "my" Outreach GCI tasks, just in case. You can almost-ignore any of those emails. [17:53:43] guillom, but if a student claims a task when you are quite certain that I'm sleeping feel free to assign it [17:54:24] guillom, just testing: did you receive also an email for the student claiming "CREATE TITLE CARDS TO WRAP MEDIAWIKI RELATED VIDEOS"? [17:55:55] hi matanya , mutante told me that you are succeeding as an Ops volunteer contributor! Congratulations. [17:56:21] qgil: yes, I got the "task claimed" and "task assigned" emails [17:56:38] guillom, good to know. Thank you [17:56:52] (03PS6) 10EBernhardson: Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 [17:57:29] sure [17:57:31] Thanks a lot qgil nice to hear positive feedback :) [17:58:29] guillom, please fill your entry at https://www.mediawiki.org/wiki/Google_Code-in#Common_instructions_for_tasks [17:59:20] matanya, mutante I was wondering whether there is a wiki page with the information needed to become an Ops contributor, or if you had to go through all the hops on your own / asking for the info needed [17:59:31] oops, I was too slow [18:00:31] What's the replacement for the deprecated getElementsByClassName? [18:04:40] qgil: where does the css rules for hlist needs to go in this task? https://google-melange.appspot.com/gci/task/view/google/gci2013/5772232571748352 [18:04:53] (03CR) 10EBernhardson: Add role::profiler utilizing XHProf (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [18:07:06] qgil: that mostly turns into a needed wiki page "how to sign an NDA with the wmf" [18:07:49] mutante: reminding you about the download role [18:08:01] (03PS7) 10EBernhardson: Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 [18:08:03] (03CR) 10Chad: [C: 032] Fix double-space [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95964 (owner: 10Shirayuki) [18:08:18] matanya_: yea, i didn't abandon it as a reminder to self [18:08:22] (03CR) 10Chad: [C: 032] Description for new message key. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96022 (owner: 10Manybubbles) [18:08:23] (03Merged) 10jenkins-bot: Fix double-space [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95964 (owner: 10Shirayuki) [18:08:35] (03Merged) 10jenkins-bot: Description for new message key. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/96022 (owner: 10Manybubbles) [18:08:59] and mutante the bugzilla patch looks very intersting too [18:09:23] mayankmadan, as the task explains, the details can be found at https://bugzilla.wikimedia.org/show_bug.cgi?id=40062 and you can ask there for more information [18:10:28] csteipp: any ETA on bug 57081? [18:11:03] mutante, matanya_ right, but still before/after the NDA part potential contributors need to know a) where to find tasks looking for contributors and b) learn how Ops is working in general [18:11:16] matanya_: No. We don't have a good solution for that yet. [18:11:28] (03PS1) 10EBernhardson: Remove the thank link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96063 [18:11:52] mutante, I guess matanya_ went alone through all these hops after a long period as community contributor. I wonder if a page documenting /linking to the righ pages would make the path easier for future Ops contributors [18:11:58] (03CR) 10Chad: [WIP] Allow enabling as default with a BetaFeature (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95837 (owner: 10Legoktm) [18:12:01] qgil: I would love to find a defined set of work needed. atm i bug ops for tasks and being a nudge in general [18:13:18] qgil: from my point of view we are missing a lot of contributers just because no one knows it is possible to contribute in those aspects [18:13:20] qgil: the tasks are in RT and Bugzilla, we dont usually assign tickets to people but keep them in a pool, so any open ticket can be picked [18:13:21] mutante, matanya_ ok, that helps knowing the situation. Apart from the "finding a task"part, is there a page documenting / linking to resources explaining how Ops expect tasks to be fixed by contributors? [18:13:54] I don't know about one [18:13:54] i'm not sure what the diffence is between the list of all open tickets and "defined set of work needed" [18:14:08] that should be the sum of tickets [18:14:48] mutante: for exapmle, i want to do puppet work, the only page i know about is puppet todo, but that is just a general page [18:14:59] qgil: i don't think there is a resource explaining how tasks should be fixed because every task is different [18:15:17] moreover, most of RT tasks require shell access, which i lack [18:15:40] matanya_, mutante what I mean is a page explaining "look, the relevant repos are here, we use Puppet to blah, you can find open tickets in Bugzilla here, we also use RT for blah reasons, if you want to request a task, do blah"... [18:16:32] i'll be back in 15 [18:17:46] matanya_, mutante, if I get a volunteer to draft such task, would you be fine joining a 30 minute conference (together or at separate times) to dump useful information and URLs from the top of your head & your browser? [18:17:49] qgil: the puppet,repo,git part is https://wikitech.wikimedia.org/wiki/Git#Git.2FGerrit_and_the_repositories [18:18:04] Say yes and I won't bother you until I find a skilled volunteer mutante matanya_ :) [18:18:47] i can paste those links right now [18:18:54] ok [18:19:02] (03CR) 10Chad: [C: 032] Address CodeSniffer comments in ApiBase.php [core] - 10https://gerrit.wikimedia.org/r/95814 (owner: 10Siebrand) [18:19:14] (03CR) 10Chad: [C: 032] Update indentation [core] - 10https://gerrit.wikimedia.org/r/95815 (owner: 10Siebrand) [18:19:44] qgil: so the above one on how to find the repo and use git/git-review (just like labs ) [18:20:13] qgil: where are the RT tickets? like here https://wikitech.wikimedia.org/wiki/RT#Which_queues_do_we_have_and_what_are_they_used_for.3F [18:20:16] (03CR) 10Bartosz Dziewoński: [C: 031] "I did not review the code much, but the idea seems sound to me." [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [18:21:25] qgil: BZ has "ops" flag for tickets and gerrit repo https://gerrit.wikimedia.org/r/#/q/project:operations/puppet,n,z / https://git.wikimedia.org/summary/operations%2Fpuppet.git [18:21:29] hi MatmaRex [18:21:54] hi mayankmadan [18:22:27] (03Merged) 10jenkins-bot: Address CodeSniffer comments in ApiBase.php [core] - 10https://gerrit.wikimedia.org/r/95814 (owner: 10Siebrand) [18:22:28] hi MatmaRex whenever you have time, pease add your info at https://www.mediawiki.org/wiki/Google_Code-in#Mentors [18:22:52] * qgil takes note of mutante links... [18:22:55] i need to paste the rules for hlists in shared.css , right? https://google-melange.appspot.com/gci/task/view/google/gci2013/5772232571748352 [18:23:34] (03CR) 10Chad: [C: 032] Address errors and warnings in CodeSniffer in api/ [core] - 10https://gerrit.wikimedia.org/r/95802 (owner: 10Siebrand) [18:23:40] (03PS1) 10Matthias Mullie: Design tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96065 [18:24:26] (03CR) 10Chad: [C: 032] Set visibility for class properties of DependencyWrapper [core] - 10https://gerrit.wikimedia.org/r/95981 (owner: 10Siebrand) [18:24:29] (03Merged) 10jenkins-bot: Update indentation [core] - 10https://gerrit.wikimedia.org/r/95815 (owner: 10Siebrand) [18:24:47] qgil: done [18:24:52] thx [18:25:29] mayankmadan: one minute :) i'm going through mail [18:25:35] np [18:28:24] (03Merged) 10jenkins-bot: Address errors and warnings in CodeSniffer in api/ [core] - 10https://gerrit.wikimedia.org/r/95802 (owner: 10Siebrand) [18:30:04] mutante: any new intersting stuff i can work on? [18:30:07] (03Merged) 10jenkins-bot: Set visibility for class properties of DependencyWrapper [core] - 10https://gerrit.wikimedia.org/r/95981 (owner: 10Siebrand) [18:30:11] (03PS2) 10Matthias Mullie: Design tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96065 [18:30:33] (03CR) 10Chad: [C: 032] Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/95816 (owner: 10Siebrand) [18:32:36] (03CR) 10Chad: [C: 032] Update formatting [core] - 10https://gerrit.wikimedia.org/r/95944 (owner: 10Siebrand) [18:32:48] MatmaRex: i need to paste the rules for hlists in shared.css , right? [18:32:56] (03CR) 10Chad: [C: 032] Break long lines in includes/cache/ [core] - 10https://gerrit.wikimedia.org/r/95946 (owner: 10Siebrand) [18:33:09] mayankmadan: see https://www.mediawiki.org/wiki/Snippets/Horizontal_lists – there's also a script that provides fallback for older browsers, you should probably adapt is as well and define a ResourceLoader module for both the styles and the script (see Resources.php) [18:33:24] (03CR) 10Chad: [C: 032] Remove underscore from class LocalisationCache_BulkLoad [core] - 10https://gerrit.wikimedia.org/r/95947 (owner: 10Siebrand) [18:33:35] (03CR) 10Chad: [C: 032] Declare visibility for class properties of LocalisationCacheBulkLoad [core] - 10https://gerrit.wikimedia.org/r/95948 (owner: 10Siebrand) [18:33:38] !master resources/Resources.php [18:33:38] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/resources%2fResources.php [18:34:17] (03CR) 10Chad: [C: 032] Set visibility on class properties for *Dependency classes [core] - 10https://gerrit.wikimedia.org/r/95982 (owner: 10Siebrand) [18:34:45] mayankmadan: you could also create an example about how these look in docs/uidesign :) [18:34:53] !rl [18:34:54] ResourceLoader is the delivery system for JavaScript/CSS in MediaWiki. First released in MediaWiki 1.17. See also https://www.mediawiki.org/wiki/ResourceLoader , https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_%28users%29 and https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_for_extension_developers [18:35:04] matanya: 6322 ? [18:35:18] (all these links are probably not relevant to this task, don't worry :P) [18:35:50] (03CR) 10Chad: Update LinkCache::addGoodLinkObj param defaults to int (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95945 (owner: 10Siebrand) [18:35:53] (03CR) 10CSteipp: [C: 032] "This is working under several different scenarios of wgSecureLogin that have in my dev environment. The resource loader bit should be full" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 (owner: 10Anomie) [18:36:17] (03PS1) 10Umherirrender: Fix indentation of comment in tables.sql [core] - 10https://gerrit.wikimedia.org/r/96067 [18:36:46] MatmaRex: i dont get the function of Resources.php [18:37:19] is it used for alternative css rules? [18:37:38] (03Merged) 10jenkins-bot: Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/95816 (owner: 10Siebrand) [18:39:31] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95944 (owner: 10Siebrand) [18:39:34] mutante, matanya would such page require references to use Labs for testing, or how are you supposed to test your changes before proposing a patch? Also, is there a page about the Ops team, your maling lists, IRC, etc? [18:39:39] mutante: yes, i asked Reedy about it. he didn't have any good idea too. it has nothing to do with the rest of the roles on that server [18:39:40] (03CR) 10Brion VIBBER: "* release notes should explain or link to a wiki page explaining what exactly is supported and how to enable it (eg, add 'webp' to $wgFile" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [18:40:15] (03CR) 10Chad: [C: 032] Remove underscore from classes LCStore_* [core] - 10https://gerrit.wikimedia.org/r/95949 (owner: 10Siebrand) [18:40:31] (03CR) 10Chad: [C: 032] Declare visibility on class properties of LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/95951 (owner: 10Siebrand) [18:40:44] qgil: using labs is always recommended. [18:40:44] (03CR) 10Chad: [C: 032] Declare visibility on class properties of LCStore* classes [core] - 10https://gerrit.wikimedia.org/r/95954 (owner: 10Siebrand) [18:41:28] (03Merged) 10jenkins-bot: Break long lines in includes/cache/ [core] - 10https://gerrit.wikimedia.org/r/95946 (owner: 10Siebrand) [18:42:33] MatmaRex: ? [18:42:42] qgil: yes, labs testing reference for puppet changes, though it's not (yet) really possible for everything, it is definitely a goal though [18:42:44] (03PS8) 10BryanDavis: Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [18:42:51] (03CR) 10BryanDavis: [C: 031] Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [18:43:00] mayankmadan: sorry, i'm back [18:43:18] (03Merged) 10jenkins-bot: Remove underscore from class LocalisationCache_BulkLoad [core] - 10https://gerrit.wikimedia.org/r/95947 (owner: 10Siebrand) [18:43:39] mayankmadan: the Resources.php file defines modules which can be used in mediawiki – "module" is a piece of CSS and JS code which can be loaded together [18:43:50] (03CR) 10Aude: "generally looks fine and works fine, though have some suggestions in the comments." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/94406 (owner: 10Bartosz Dziewoński) [18:44:17] mayankmadan: obviously not all CSS and JS mediawiki has defined is always loaded - e.g. some is only relevant to certain pages, like Special:Preferences [18:44:40] qgil: there is this one https://office.wikimedia.org/wiki/Operations [18:44:48] be back in a little [18:45:12] (03Merged) 10jenkins-bot: Declare visibility for class properties of LocalisationCacheBulkLoad [core] - 10https://gerrit.wikimedia.org/r/95948 (owner: 10Siebrand) [18:45:14] doesnt really list contacts. yep [18:45:15] mayankmadan: so you define a module to "contain" your scripts and styles, then you can load it on a page – by calling addModules() from PHP, or mw.loader.load() from JS [18:45:15] (03CR) 10Aude: "also, since there are a few dependent patches, I am okay with further improvement in follow up, if desired" [core] - 10https://gerrit.wikimedia.org/r/94406 (owner: 10Bartosz Dziewoński) [18:45:25] (03PS2) 10Dan-nl: mediafile-job-array [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 [18:46:08] (03CR) 10Dan-nl: "addresses bryan davis’ inline comments in ps1" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [18:46:12] (03CR) 10Brion VIBBER: "Ok, to get it working I had to also install libwebp ('brew install webp' on Mac OS X) *and* make sure that /usr/local/bin was in the PATH " [core] - 10https://gerrit.wikimedia.org/r/95872 (owner: 10btongminh) [18:46:31] mayankmadan: so, the hlist class and related things would be defined inside of a module, which then could be loaded on pages (we'll likely make it loaded by default everywhere if the class is used) [18:46:42] (03CR) 10Aaron Schulz: [C: 032] adviseStat [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96019 (owner: 10Dan-nl) [18:46:44] mayankmadan: does what i said make sense? :) [18:46:50] (03Merged) 10jenkins-bot: Set visibility on class properties for *Dependency classes [core] - 10https://gerrit.wikimedia.org/r/95982 (owner: 10Siebrand) [18:46:58] MatmaRex: mostly:) [18:47:08] (03Merged) 10jenkins-bot: Skip Special:CentralAutoLogin/start for JS anons [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 (owner: 10Anomie) [18:48:08] (03CR) 10Anomie: [C: 032] Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [18:48:18] (03CR) 10Chad: Remove unneeded uses of else{} in api/ (032 comments) [core] - 10https://gerrit.wikimedia.org/r/95887 (owner: 10Siebrand) [18:49:03] (03CR) 10BryanDavis: [C: 031] mediafile-job-array [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [18:49:13] (03PS1) 10Umherirrender: move page_restrictions.pr_id to top in tables.sql [core] - 10https://gerrit.wikimedia.org/r/96068 [18:49:15] mayankmadan: this is a little confusing at first, but pretty neat when you get comfortable with it :) [18:49:27] im hoping so [18:49:55] mayankmadan: basically, the reason we use it is because it makes it possible to apply certain loading optimizations to make the sites load faster :) [18:50:55] there's detailed information available at https://www.mediawiki.org/wiki/ResourceLoader , if you feel like reading, but as i said it probably won't be useful for you now (lots of technical details) [18:52:17] (03CR) 10Aude: [C: 031] General Cleanup of some Tests [core] - 10https://gerrit.wikimedia.org/r/95606 (owner: 10Addshore) [18:52:21] (03PS3) 10Matthias Mullie: Design tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96065 [18:54:13] MatmaRex: can you please tell me where to start i am currently not feeling good with this :) [18:54:27] (03Merged) 10jenkins-bot: Remove underscore from classes LCStore_* [core] - 10https://gerrit.wikimedia.org/r/95949 (owner: 10Siebrand) [18:55:42] (03CR) 10Chad: [C: 04-1] Set $wgNoFollowLinks to false iff "Authorized editors only" selected (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95755 (owner: 10leucosticte) [18:56:19] mayankmadan: hmm… i'd suggest by looking at an example :) [18:56:20] mayankmadan, have you set up your MediaWiki environment? That would be a start. [18:56:29] (03Merged) 10jenkins-bot: Declare visibility on class properties of LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/95951 (owner: 10Siebrand) [18:56:32] mayankmadan: e.g. the mediawiki.notification module [18:57:02] mayankmadan: it's pretty simple, with one stylesheet and one script [18:57:05] 'styles' => 'resources/mediawiki/mediawiki.notification.css', [18:57:05] 'scripts' => 'resources/mediawiki/mediawiki.notification.js', [18:57:21] and a dependency, which let's ignore for now [18:57:21] qgil: yes i have [18:57:40] * qgil shuts up :) [18:58:06] so, create similar files for the hlist class, and define a module similar to that one [18:58:23] (03Merged) 10jenkins-bot: Declare visibility on class properties of LCStore* classes [core] - 10https://gerrit.wikimedia.org/r/95954 (owner: 10Siebrand) [18:59:08] mayankmadan: do you know what a "JavaScript" console in a browser is? [18:59:18] yep [19:00:01] you can load any defined module dynamically by calling `mw.loader.load('module name')` in the console [19:00:32] (the name is the first part, the "mediawiki.notification" in our case) [19:00:41] thanks MatmaRex [19:00:48] really appreciate the help [19:01:05] mayankmadan: this might help, too: https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader [19:01:37] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix "action-*" message [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/96028 (owner: 10Shirayuki) [19:01:55] MatmaRex: script wont be needed for hlist, right? [19:01:58] (03Merged) 10jenkins-bot: adviseStat [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96019 (owner: 10Dan-nl) [19:02:49] mayankmadan: hlist does have a little script for backwards-compatibility with older Internet Explorers [19:02:52] at the bottom of https://www.mediawiki.org/wiki/Snippets/Horizontal_lists [19:04:04] mayankmadan: also, here's where we come to the "dependencies" thing :) [19:04:14] ok [19:04:20] mayankmadan: that code uses "$.client", which is a function defined by the 'jquery.client' module [19:04:52] bd808: https://gerrit.wikimedia.org/r/#/c/95886/ :) [19:04:54] mayankmadan: so you should mark your new module as depending on jquery.client [19:05:05] so that needs to be in the dependencies [19:05:07] with something like: 'dependencies' => 'jquery.client', [19:05:09] yep [19:05:11] got it [19:05:13] thanks [19:05:27] this will make the module be automatically loaded when your new module is loaded [19:05:47] (03PS2) 10BryanDavis: Tweaked WikiPage::clear() comment a bit [core] - 10https://gerrit.wikimedia.org/r/95886 (owner: 10Aaron Schulz) [19:05:56] (03CR) 10BryanDavis: [C: 032] Tweaked WikiPage::clear() comment a bit [core] - 10https://gerrit.wikimedia.org/r/95886 (owner: 10Aaron Schulz) [19:06:05] (i didn't notice this before, but the hlist JS code assumes that this module is always loaded, which might not be true :) ) [19:06:47] (03Merged) 10jenkins-bot: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [19:09:55] (03CR) 10Bartosz Dziewoński: Consistently handle anonymous users on logged-in-only special pages (033 comments) [core] - 10https://gerrit.wikimedia.org/r/94406 (owner: 10Bartosz Dziewoński) [19:10:02] aude: thanks for the review :) ^ [19:10:14] (03PS7) 10Aaron Schulz: Add WikiFilePage::getForeignCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [19:10:37] (03CR) 10Aaron Schulz: [C: 032] Add WikiFilePage::getForeignCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [19:11:51] (03Abandoned) 10Bsitu: Make flow message more readable in recent change page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95306 (owner: 10Bsitu) [19:12:20] @seen andre__ [19:12:21] MatmaRex: Last time I saw andre__ they were quitting the network with reason: Ping timeout: 245 seconds N/A at 11/18/2013 5:12:13 PM (2h7s ago) [19:12:43] what timezone is andre in? D: [19:12:49] he's never here when i'm looking for him. [19:17:08] MatmaRex: There is no error in the compiler [19:18:42] (03Merged) 10jenkins-bot: Tweaked WikiPage::clear() comment a bit [core] - 10https://gerrit.wikimedia.org/r/95886 (owner: 10Aaron Schulz) [19:19:09] (03PS1) 10Poke: Integrate feed-specific setup into general setup [core] - 10https://gerrit.wikimedia.org/r/96070 [19:20:39] how do i submit my work [19:20:43] in a diff? [19:20:46] to melange? [19:21:23] MatmaRex: ^ [19:21:55] mayankmadan: prefereablly to gerrit, and just link the patch on melange [19:22:02] (i think you've submitted patches before? or not yet?) [19:22:06] yep [19:22:07] preferably* [19:22:08] i have [19:22:39] it'll make any code review much easier :) [19:23:28] you wrote that the hlist js assumes that jquery.client module is always loaded [19:23:37] (03Merged) 10jenkins-bot: Add WikiFilePage::getForeignCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [19:23:44] it has to be always loaded to work doesnt it [19:24:17] MatmaRex: so whats the problem with it assuming that its always loaded [19:24:19] yes, jquery.client has to be loaded for the hlist fallback to work [19:24:33] mayankmadan: well, it might not be loaded, in which case the fallback will break :) [19:24:48] bd808|LUNCH: did you have a quick chance to mess with https://gerrit.wikimedia.org/r/#/c/91325/ ? [19:24:55] mayankmadan: if you defined jquery.client as a dependency to your module, then it will be loaded and all is fine [19:26:30] mayankmadan: (jquery.client is loaded by some other modules, among them the search suggestions module (mediawiki.searchSuggest), which in practice means that it will be present on normal pageviews, so the code worked) [19:27:04] i did included it in the dependencies so it should always work [19:27:10] (we like to be explicit about the dependencies – other modules might be changed to no longer load it, and then things break) [19:27:16] yes, it should if you did that :) [19:27:55] (03PS3) 10leucosticte: Set $wgNoFollowLinks to false iff "Authorized editors only" selected [core] - 10https://gerrit.wikimedia.org/r/95755 [19:27:58] (03PS4) 10Adamw: Mediawiki can be checked out on a branch [vagrant] - 10https://gerrit.wikimedia.org/r/95715 [19:28:43] (03PS5) 10Adamw: Mediawiki can be checked out on a branch [vagrant] - 10https://gerrit.wikimedia.org/r/95715 [19:28:57] (03CR) 10Adamw: Mediawiki can be checked out on a branch (032 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [19:30:26] (03PS1) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [19:30:59] (03PS12) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [19:31:38] (03CR) 10jenkins-bot: [V: 04-1] Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [19:32:08] matanya, mutante, andrewbogott see http://www.google-melange.com/gci/task/view/google/gci2013/5280487538950144 [19:32:27] MatmaRex: why did jenkins-bot failed the build [19:32:30] mayankmadan: ah. we have some code conventions for JS code that random snippets copied from elsewhere not always respect, so the test failed :) [19:32:35] https://www.mediawiki.org/wiki/CC/JS [19:32:49] mayankmadan: if you click the link next to "FAILURE", you will see detailed log [19:32:51] https://integration.wikimedia.org/ci/job/mediawiki-core-jslint/10458/console : FAILURE in 26s [19:33:36] should i use jquery instead of $? [19:33:48] MatmaRex: should i use jquery instead of $ [19:33:48] mayankmadan: the first error should be clear, the rest ("'$' is not defined") is because we only use jQuery and mediaWiki as global variables [19:33:51] basically, yes [19:34:00] https://www.mediawiki.org/wiki/CC/JS#Globals [19:34:15] mayankmadan: https://www.mediawiki.org/wiki/CC/JS#Closure [19:34:19] do this ^ [19:34:47] (and do read the "Coding conventions" pages :) ) [19:35:42] i dont get the closure thing [19:36:17] MatmaRex: ^ [19:37:12] mayankmadan: you don't have to, just use it :P http://benalman.com/news/2010/11/immediately-invoked-function-expression/ is apparently a nice explanation (it's linked in footnotes on the CC/JS page) [19:37:46] mayankmadan: and one last thing you should glance at, https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Example :) [19:38:02] sorry, i'm off for 20 minutes or so, need to eat something [19:38:08] i'll be back in a while [19:38:13] no problem [19:40:13] (03CR) 10Yurik: [C: 04-1] "I guess I don't mind the change, pls minor fix" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [19:42:28] Hello :) [19:42:46] qgil: this looks good [19:42:55] (03PS1) 10Bsitu: Fix some incorrect autoload definition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96074 [19:42:58] MatmaRex: Do i enclose the whole js file in iffy ? [19:43:52] matanya, thanks, let's see whether a volunteer shows up. Only writing down the task has been useful. I wanted to do this since last Spring. :) [19:45:48] I have a simple question [19:45:56] where am I? [19:46:13] <^d> You're on IRC. [19:46:18] I thought this is where I can connect with the mentors [19:47:47] ? [19:47:57] Mentors for Google Code-In? [19:48:06] yes [19:48:29] Rtdwivedi, MatmaRex, and qgil are here [19:48:43] I entered a task then a link [19:48:52] then ended up here [19:49:03] pro, hi, in what task are you interested? [19:50:07] pro, just in case it helps: https://www.mediawiki.org/wiki/Google_Code-in [19:50:26] I saw this link [19:50:33] but didn't help [19:50:40] pro, how can I help, then? [19:50:46] my problem is that after I find a task [19:50:49] and claim [19:50:57] like for an example [19:51:02] pro, can you share the URL of the task you have claimed? [19:51:02] one for fixing bugs [19:51:21] ok but let me complete my problem [19:51:28] okay* [19:51:45] the code that contains the bugs [19:51:52] from where can I get it [19:52:56] http://www.google-melange.com/gci/task/view/google/gci2013/4511900725411840 [19:53:00] this is the link [19:53:10] pro, this is why I am asking you to share the URL of the task you are referring to. [19:53:13] ah [19:53:52] that task is of haiku [19:53:55] pro, that is not a Wikimedia task bt a Haiku task. We can't help you. [19:54:05] pro, you are in #wikimedia-dev [19:54:06] ooh sorry [19:54:16] but the same for all [19:54:22] mayankmadan: yes, enclose the whole file (apart from the documentation comment at the top) [19:54:35] mayankmadan: in general, when in doubt, look at other files for examples of what to do :) [19:54:44] okay dokay [19:55:13] AaronSchulz: I haven't had time to test gerrit:91325 yet, and I don't see it happening for a couple of days. I'll trust your testing and +2 if it's blocking you. [19:55:52] MatmaRex: i had a doubt while using git commit [19:56:02] nah, it can wait [19:56:13] do i have to use git commit every time i make a change in a file before using git review? [19:56:58] Where can I find a channel for each mentor [19:57:00] ? [19:57:05] MatmaRex: i know that i did this before but i kinda forgot [19:57:34] (03PS3) 10Siebrand: Format email addresses more consistently [core] - 10https://gerrit.wikimedia.org/r/95821 [19:58:00] pro: use "/join #haiku"(without quotes) in order to join haiku's channel [19:58:02] mayankmadan: yes, but after the patch is already submitted, you should amend the existing commit instead of creating a new one – just use `git commit --amend` instead [19:58:08] hey AaronSchulz, do you think you'll be able to get to https://gerrit.wikimedia.org/r/#/c/95888/ and https://gerrit.wikimedia.org/r/#/c/96014/ today? [19:58:55] (03PS2) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [19:59:31] mayankmadan: i also very much recommend using some gui interface to git :) being able to easily see what branch you are on, or what are you committing, is awesome [19:59:50] okey dokey [19:59:57] mayankmadan: (i am personally using the standard "git gui" command, i think you can install it on linuxes with `apt-get install git-gui` or something like that) [20:00:08] (03CR) 10jenkins-bot: [V: 04-1] Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [20:00:10] (and i think it comes with the windows git installer by default, if you're using that) [20:00:52] pro, just as in the task you have questions about. That is a good start. [20:01:11] What the hell.. Another error :( [20:01:43] (03CR) 10Siebrand: "Fixed comments in next PS." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [20:02:11] pro, you can find details about the Wikimedia mentors at https://www.mediawiki.org/wiki/Google_Code-In#Mentors but if you are interested in Haiku, then that project might be organized in a different way [20:02:40] qgil: pro is gone [20:03:05] MatmaRex: are these two the errors? [20:03:08] resources/mediawiki/mediawiki.hlist.js: line 2, col 19, '$' is defined but never used. [20:03:09] 20:00:01 resources/mediawiki/mediawiki.hlist.js: line 2, col 16, 'mw' is defined but never used. [20:03:22] yep [20:03:50] i see you replaced the '$'s in the code with 'jQuery's, no need to do that if you wrapped the code in the closure already [20:04:14] yeah [20:04:14] and well yeah, 'mw' is not used, so just remove if from the argument list and from the '( mediaWiki, jQuery )' at the bottom [20:04:20] forgot about those [20:04:25] and mw should not be neededd [20:04:28] right? [20:04:30] mayankmadan: also, you can install jslint locally to run these tests yourself, before submitting [20:04:35] yep [20:04:55] i'm not sure if we have a guide for that, but it should be easy [20:05:26] okay [20:05:29] (03CR) 10BryanDavis: [C: 031] Mediawiki can be checked out on a branch [vagrant] - 10https://gerrit.wikimedia.org/r/95715 (owner: 10Adamw) [20:05:58] (03CR) 10Nikerabbit: [C: 031] Format email addresses more consistently [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [20:06:59] (03PS3) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [20:07:04] (03PS1) 10Umherirrender: Remove space before semicolon at end of line [core] - 10https://gerrit.wikimedia.org/r/96079 [20:07:46] (03Abandoned) 10Nikerabbit: Do not print $GLOBALS during unit test [core] - 10https://gerrit.wikimedia.org/r/95868 (owner: 10Nikerabbit) [20:07:59] (03CR) 10Siebrand: Update LinkCache::addGoodLinkObj param defaults to int (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95945 (owner: 10Siebrand) [20:08:47] MatmaRex: Success [20:09:25] mayankmadan: :D [20:09:48] mayankmadan: i'll look in a while [20:09:59] MatmaRex: np [20:11:05] (03CR) 10Yurik: [C: 04-1] Format email addresses more consistently (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [20:12:11] (03Abandoned) 10Nikerabbit: mediawiki.api: add postWithToken and getToken Similar to postWithEditToken in mw.api.edit, but more generic. [core] - 10https://gerrit.wikimedia.org/r/88464 (owner: 10SuchetaG) [20:12:17] (03PS6) 10Siebrand: Update LinkCache::addGoodLinkObj param defaults to int [core] - 10https://gerrit.wikimedia.org/r/95945 [20:18:16] (03CR) 10Siebrand: "Thanks for the reviews, Yuri." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [20:18:33] (03PS4) 10Siebrand: Format email addresses more consistently [core] - 10https://gerrit.wikimedia.org/r/95821 [20:20:23] (03CR) 10Chad: Update LinkCache::addGoodLinkObj param defaults to int (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95945 (owner: 10Siebrand) [20:20:28] (03CR) 10Chad: [C: 032] Update LinkCache::addGoodLinkObj param defaults to int [core] - 10https://gerrit.wikimedia.org/r/95945 (owner: 10Siebrand) [20:21:04] (03CR) 10Siebrand: Remove unneeded uses of else{} in api/ (032 comments) [core] - 10https://gerrit.wikimedia.org/r/95887 (owner: 10Siebrand) [20:21:25] (03CR) 10Siebrand: "PS5 will be a rebase, fixing one or more merge conflicts." [core] - 10https://gerrit.wikimedia.org/r/95887 (owner: 10Siebrand) [20:22:15] are there historical reasons that within Exception.php there are many different ways to render an exception? I really need to be able to render nested exceptions, but spreading the code across all the possible ways to render an exception from core's include/Exception.php seems wrong. If i consolidate the exception rendering what might i be breaking? [20:23:46] (03Merged) 10jenkins-bot: Update LinkCache::addGoodLinkObj param defaults to int [core] - 10https://gerrit.wikimedia.org/r/95945 (owner: 10Siebrand) [20:24:29] MatmaRex: ping [20:25:12] ori-l: any problems with me +2ing https://gerrit.wikimedia.org/r/#/c/94840/7 ? [20:25:22] oh it already has lol [20:25:25] mayankmadan: yep, i'm looking right now :) [20:25:51] MatmaRex: qgil told me that u were a student in gci in 2011 [20:26:05] can you give me some tips :) [20:28:05] (03PS5) 10Siebrand: Remove unneeded uses of else{} in api/ [core] - 10https://gerrit.wikimedia.org/r/95887 [20:28:09] mayankmadan: haha, not much, i didn't achieve a lot back them [20:28:37] mayankmadan: i've done some very simple tasks, just barely more than enough to get a t-shirt [20:28:45] did I say 2011? [20:28:55] (03CR) 10Yurik: [C: 032] Format email addresses more consistently [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [20:29:10] mayankmadan: (the first edition divided the possible tasks in three groups: easy, medium and hard, each worth a different number of points; this was since abandoned) [20:29:20] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I left comments inline. One trouble in mediawiki.hlist.js, the rest is just stylistic nitpicks :)" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [20:29:29] mayankmadan: ^ minor complaining :) [20:31:30] MatmaRex: yeah just saw it [20:32:03] (03PS1) 10Bartosz Dziewoński: Sort 'MediaWiki' resources definitions alphabetically [core] - 10https://gerrit.wikimedia.org/r/96084 [20:33:30] MatmaRex: can i just nest the code within the browser check if condition? [20:33:38] removing the importscript [20:33:38] (03Merged) 10jenkins-bot: Format email addresses more consistently [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [20:34:03] cause the code that was supposed to be in iefixes.js is included in this file [20:34:08] MatmaRex: ^ [20:34:16] mayankmadan: yes, sure [20:35:25] (03PS6) 10Siebrand: Remove unneeded uses of else{} in api/ [core] - 10https://gerrit.wikimedia.org/r/95887 [20:36:34] jdlrobson: the other half of that (https://gerrit.wikimedia.org/r/#/c/95129/) still needs a +2 [20:37:44] hi ori-l, wanna do some fun CR? :D https://gerrit.wikimedia.org/r/#/c/94511/ [20:38:10] "Rewrite CSSMin::remap to support multiple url() values in one rule" [20:38:12] (03PS4) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [20:38:34] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/96089 (owner: 10L10n-bot) [20:38:35] (03PS2) 10Umherirrender: Fixed spacing [core] - 10https://gerrit.wikimedia.org/r/96079 [20:38:38] MatmaRex: OK [20:38:55] (03PS1) 10Chad: Remove $wgArticle dependency [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/96113 [20:39:01] MatmaRex: done [20:39:12] (03CR) 10Umherirrender: "Patch Set 2: Fixed more spacing" [core] - 10https://gerrit.wikimedia.org/r/96079 (owner: 10Umherirrender) [20:40:00] (03CR) 10Bartosz Dziewoński: "Huh. Hashar, can you tell what happened here?" [core] - 10https://gerrit.wikimedia.org/r/96089 (owner: 10L10n-bot) [20:40:07] hashar: ^ [20:40:21] mayankmadan: looking [20:40:25] <^d> MatmaRex: $wgArticle ^^^ ughggghhhh :p [20:41:30] ^d: i don't even know what that extension does D: [20:41:56] <^d> Neither do I, it's doing some pretty ugly queries against revision and image on every page load though :p [20:42:03] heh [20:42:13] (03CR) 10Jeroen De Dauw: [C: 031] Switch Query and QueryEngine to checks only [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96043 (owner: 10Addshore) [20:42:16] <^d> I just want $wgArticle gone. :p [20:42:25] ^d: hmm, so wgArticle is/was set for any non-special page? [20:42:58] <^d> It was set for everything. [20:43:06] <^d> That isset() check didn't do what he thought it did. [20:43:37] heh [20:43:39] (03CR) 10Jeroen De Dauw: "This should only be merged in case Jenkins will +1 rather then +2 after this change." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/96043 (owner: 10Addshore) [20:44:05] ok everybody, wait a second, i am holding four simultaneous conversations now D: [20:45:09] (03CR) 10Parent5446: [C: 04-1] Integrate feed-specific setup into general setup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [20:45:42] mayankmadan: i think you missed the various minor things i mentioned on that patch? [20:46:05] mayankmadan: you can see the inline comments e.g. here: https://gerrit.wikimedia.org/r/#/c/96071/3//COMMIT_MSG and on other files [20:46:49] (03CR) 10Raimond Spekking: [C: 032 V: 032] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/96089 (owner: 10L10n-bot) [20:47:07] (03PS6) 10Siebrand: Remove unused classes Title[List]Dependency [core] - 10https://gerrit.wikimedia.org/r/95983 [20:47:15] (03CR) 10Jeroen De Dauw: [C: 031] Remove dependencies that are not on gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/96044 (owner: 10Addshore) [20:47:28] qgil_afk: http://codefirefox.com/ [20:47:55] MatmaRex: looking [20:47:58] MatmaRex: i think just the Commit Message is left to be fixed right> [20:48:01] *? [20:48:29] MatmaRex: and I thought l10n bot was no more running on mw/core ... [20:48:51] thanks ori-l ! Interesting [20:48:54] mayankmadan: see comments on the other files, too [20:49:29] mayankmadan: if you click on "Patch Set 3" on https://gerrit.wikimedia.org/r/#/c/96071/ , the information about that patchset will expand [20:49:43] mayankmadan: it shows which files have inline comments [20:49:49] got it [20:50:51] MatmaRex: AssertionError: len([]) != len(['hash mismatch', '', '']) [20:51:00] MatmaRex: Gerrit going wild I suppose :-/ [20:51:17] (03PS5) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [20:51:24] MatmaRex: Done [20:51:54] hashar: lols [20:52:03] hashar: i've seen this happen with some random patches for a month or so [20:52:11] in various repos [20:52:18] MatmaRex: or maybe somewhere else, cause the Jenkins jobs are fetching from a local daemon [20:52:47] (03PS1) 10Umherirrender: Remove unused global in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/96144 [20:52:55] MatmaRex: i just signed into gerrit and saw that it says that it depends on an earlier patch that i submitted. any ideas how to get rid of that? [20:52:57] MatmaRex: yeah there is a few occurrences in the Zuul debug log [20:55:07] mayankmadan: you could rebase the patch on the master branch, but that other patch is already merged, so it's not a problem [20:55:11] (it says "(MERGED)") [20:56:08] mayankmadan: if you feel like playing with this in the future – https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Unlink_bogus_dependencies_.28rebase_changes.29 :) [20:57:19] ^d: i am going to trust you that this code of yours works :) [20:57:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Should work at a glance… if it breaks, it's your fault :P" [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/96113 (owner: 10Chad) [20:58:44] heh, no jenkins. [20:58:48] MatmaRex: i dont understand your comment on css file about indentation [20:58:51] (03CR) 10Bartosz Dziewoński: [V: 032] Remove $wgArticle dependency [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/96113 (owner: 10Chad) [20:58:59] tabs are used and not spaces [21:00:06] um, i'm pretty sure they are spaces. maybe your editor displays them as tabs [21:00:17] you might have some option to convert tabs to spaces / spaces to tabs [21:02:04] (03PS6) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [21:02:06] MatmaRex: Done, this time it should be good to go [21:02:49] (03CR) 10Parent5446: [C: 032] Remove unused global in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/96144 (owner: 10Umherirrender) [21:02:54] mayankmadan: and same with the .js file, too. :P [21:03:14] damn [21:03:41] (03CR) 10Aude: [C: 031] "if you can make the $title parameter more clear & obvious, then the patch looks and works fine." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/94406 (owner: 10Bartosz Dziewoński) [21:04:34] (03PS1) 10Cmcmahon: UW sometimes takes time to process. Discussed on QA mail list [qa/browsertests] - 10https://gerrit.wikimedia.org/r/96146 [21:04:37] (03PS7) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [21:04:39] MatmaRex: done [21:04:44] now it should be good to go :) [21:07:32] (03PS1) 10Dan-nl: config-clean-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 [21:08:09] mayankmadan: alright, let me just test and check it again [21:10:15] (03CR) 10jenkins-bot: [V: 04-1] config-clean-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 (owner: 10Dan-nl) [21:10:39] (03Merged) 10jenkins-bot: Remove unused global in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/96144 (owner: 10Umherirrender) [21:14:50] (03CR) 10Helder.wiki: "Isn't the original code under CC-BY-SA?" [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [21:14:51] (03CR) 10Poke: Integrate feed-specific setup into general setup (032 comments) [core] - 10https://gerrit.wikimedia.org/r/96070 (owner: 10Poke) [21:16:05] MatmaRex: Ping [21:17:52] mayankmadan: i'm around :) [21:18:00] i'm responding to helder's comment right now [21:18:11] tl;dr, you shouldn't worry about it [21:19:57] (03CR) 10Bartosz Dziewoński: "@Helder, hmm, that's actually a pretty good question. The original code at https://www.mediawiki.org/wiki/Snippets/Horizontal_lists doesn'" [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [21:20:04] "But anyway, what we definitely should do is mention Edokter as the author of both files, just like the original snippets mention him." [21:22:11] mayankmadan: i have one last round of comments on the .js file, one second :) [21:23:25] (03PS3) 10Dan-nl: whitelisted-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 [21:23:26] (03PS2) 10Dan-nl: config-clean-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 [21:23:27] (03PS3) 10Dan-nl: mediafile-job-array [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 [21:24:18] Hello. I'm working on Google Code-in [21:24:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Per previous comment, also the very last! round of comments inline, I promise." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [21:25:01] Hi Aaron1011! [21:25:09] (03CR) 10Dan-nl: "rebased with master" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 (owner: 10Dan-nl) [21:25:11] I'm trying to run the tests for Pywikibot ("core") locally. One of the tests requires the password for the Pywikibot-test user [21:25:13] marktraceur: Hi! [21:25:14] mayankmadan: now really the final comments :) [21:25:42] (03CR) 10Dan-nl: "rebased with whitelisted-post" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [21:26:04] (03CR) 10Dan-nl: "rebased with mediafile-job-array" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96147 (owner: 10Dan-nl) [21:26:20] Aaron1011: I would suggest that you use your own account details to test, as opposed to finding the test user's password [21:26:32] marktraceur: Okay, thanks! [21:26:49] mayankmadan: as i mentioned, i'll wait for Edokter to see this patch before i merge it (since technically the license of his hlist code is not compatible with the license of MediaWiki code, unless he agrees to relicense it – which he almost certainly will, this is just a formality so we're crystal clear) [21:26:53] Or maybe use a throwaway account? I dunno. [21:27:16] mayankmadan: but i'll mark the GCI tasks as completed regardless of that [21:27:23] thank you!! [21:27:34] i really needed my first task [21:27:36] (i haven't though about it when creating the task, silly me. :) ) [21:28:05] mayankmadan: so, please just see the last round of comments :) [21:28:35] mayankmadan: (you can expand the comments at the bottom of https://gerrit.wikimedia.org/r/#/c/96071/ by clicking on each one, btw – this is not obvious in the UI :( ) [21:29:46] (03PS8) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [21:29:47] MatmaRex: Now it should be done :) [21:30:28] mayankmadan: also – it's "MediaWiki", not "mediawiki" – fun fact, you can edit the commit message straight from gerrit by clicking the small pen-and-paper icon in the top-right [21:30:46] (the one here: http://i.imgur.com/TNAwLIP.png) [21:31:11] (03PS9) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [21:31:14] ok done [21:32:21] MatmaRex: ^ [21:32:44] (03Draft3) 10Aude: Put status handling in EditPage into private function [core] - 10https://gerrit.wikimedia.org/r/96150 [21:32:57] mayankmadan: yes, i see [21:33:21] mayankmadan: in https://gerrit.wikimedia.org/r/#/c/96071/9/resources/mediawiki/mediawiki.hlist.js , there's a trailing space after "@author [[User:Edokter]]" [21:33:25] and missing one after "jQuery(" [21:34:38] oh, now i need to see how does one mark a task as completed :o [21:34:41] trailing space after "@author [[User:Edokter]] which space? [21:34:58] Sorry to intrude guys, but was wondering if this was the right place for gci students? [21:35:11] ojorgensen: yep [21:35:12] ojorgensen: certainly :) [21:35:25] MatmaRex: which trailing space? [21:35:46] Cheers guys, I think my mentor is you actually, MatmaRex [21:36:01] mayankmadan: gerrit should highlight them in red? http://i.imgur.com/L697PDF.png [21:36:11] mayankmadan: (or maybe i just have changed some settings, anyway it's that one) [21:37:09] (03PS10) 10Mayankmadan: Adding hlist module to mediawiki [core] - 10https://gerrit.wikimedia.org/r/96071 [21:37:10] MatmaRex: okay, now it should be done :) [21:37:35] mayankmadan: i'm trying to figure out how to mark a task as completed, heh [21:37:41] ojorgensen: :) [21:37:56] heh [21:38:41] (03PS1) 10Cmcmahon: Remove references to VE in Flow tests, not supported now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96151 [21:38:42] mayankmadan: ah, it seems like you need to click some button on the task first [21:39:13] "When you are ready to submit your work (before the task deadline) you can login to your student profile and go to “My Dashboard” on the left navigation bar. The window will display your current task and you can then upload your work as an attachment and click the red “Submit File” button or you can include a URL to your work and click the red “Submit URL.” Then you need to click the “Mark task as complete” button. You can opt [21:39:13] nally add a comment to the completed task if you wish." [21:39:26] Oh i forgot tp [21:39:28] *to [21:39:29] (03CR) 10Parent5446: [C: 04-1] Put status handling in EditPage into private function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96150 (owner: 10Aude) [21:39:32] MatmaRex: How would I get my own instance of wikimeida running? Is it on github, or some where on gerrit? [21:39:33] mark the task complete [21:39:59] MatmaRex: Now you can complete the task [21:41:33] ojorgensen: of MediaWiki :) [21:41:35] !wikipmediawiki [21:41:36] Confused about the differences between MediaWiki, Wikimedia, Wikipedia and wiki? See https://www.mediawiki.org/wiki/Wikipmediawiki [21:41:42] mayankmadan: thank you, done :) [21:42:06] ojorgensen: the primary code repository is on gerrit, but there's a mirror on github too [21:42:43] MatmaRex: can you tell me about this one? https://google-melange.appspot.com/gci/task/view/google/gci2013/5884303300886528 [21:42:45] :) [21:43:04] ojorgensen: depending on how comfortable you are with git etc., you might want to read https://www.mediawiki.org/wiki/Gerrit/Tutorial (detailed tutorial) or https://www.mediawiki.org/wiki/Gerrit/Getting_started (quick guide) [21:43:09] Thank you for coping with my stupid questions in the first task :) [21:43:49] ojorgensen: and https://www.mediawiki.org/wiki/Developer_access about how to contribute - https://www.mediawiki.org/wiki/Google_Code-in#Instructions_for_GCI_students contains a bunch of other helpful things, too :) [21:44:18] mayankmadan: :) [21:44:20] :MatmaRex cheers, I'm running Mint, so using git is quite easy, will read up on that. Cheers for that, will go from there :) [21:45:28] mayankmadan: any questions in particular? [21:45:35] thedj: Around? [21:46:16] mayankmadan: look at the "Depends on" section of the linked bug (https://bugzilla.wikimedia.org/show_bug.cgi?id=44881), look at the bugs which are not yet fixed (striked out) and see if they are still happening [21:46:23] (that's a non-coding task) [21:47:03] so i have to reproduce those bugs that are not striked out? [21:47:03] mayankmadan: i assigned it to you, i'll have to leave in half an hour or so, it's late evening here already :) [21:47:08] MatmaRex: ^ [21:47:13] mayankmadan: yep [21:47:40] its 3:30AM here :) so a non coding task will be perfect at the moment as im feeling sleepy [21:47:41] brb [21:47:48] mayankmadan: heh [21:48:17] late night is the best for some code crunching, unless you have to get up early the next day – and i do ;) [21:48:23] (be right back) [21:52:23] hi! google code in student here. does anyone have experience with pywikibot? [21:53:54] MatmaRex: please ping me when you are back [21:57:13] MatmaRex: Is this https://bugzilla.wikimedia.org/show_bug.cgi?id=40909 still a problem ? or did you assign it to someone ? [21:58:06] what is Vector? [21:58:08] (03PS1) 10Adamw: Make clone --recursive compatible with puppet ensure check [vagrant] - 10https://gerrit.wikimedia.org/r/96154 [21:58:54] like this: https://bugzilla.wikimedia.org/show_bug.cgi?id=44591 [22:00:17] pretty sure they mean https://en.wikipedia.org/wiki/Vector_graphics [22:04:09] hi andre__ [22:04:28] (03PS1) 10Siebrand: Address CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/96155 [22:04:33] AaronSchulz: i updated the ether pad with links to the corresponding gerrit commits [22:04:46] AaronSchulz: https://etherpad.wikimedia.org/p/GWToolsetReview [22:04:50] hi mayankmadan [22:04:52] mayankmadan, https://en.wikipedia.org/wiki/Wikipedia:Vector [22:05:09] mayankmadan: Vector is the default skin [22:05:14] (03CR) 10Jeroen De Dauw: [C: 031] "Kill ALL of the unused legacy code!" [core] - 10https://gerrit.wikimedia.org/r/95983 (owner: 10Siebrand) [22:05:18] venomch, no, it's not SVG :) [22:05:30] venomch: all open tasks are visible on Melange, i think? [22:05:46] MatmaRex: congrats! I think I've never seen a GCI task completely solved within the first 5 hours of the competion. [22:05:57] yes, we're not hiding any tasks :) [22:06:11] andre__: heh :P [22:06:21] venomch: that bug seems to correspond to https://google-melange.appspot.com/gci/task/view/google/gci2013/5315763447529472 [22:06:44] andre__: congratulate mayankmadan ;) [22:07:01] woot, why do i have 40 unread e-mails already. [22:07:05] ah! mayankmadan: Also congrats! [22:07:15] thank you :) [22:07:28] MatmaRex: Im sorry, dont know how reliable the page is, because I didnt load the forms yet so I cant claim it [22:07:59] MatmaRex, andre__: https://bugzilla.wikimedia.org/show_bug.cgi?id=37362 in this bug what does "change shape about line" mean? [22:09:24] (03CR) 10BryanDavis: [C: 031] whitelisted-post [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/95888 (owner: 10Dan-nl) [22:09:35] mayankmadan: hmm. after looking at the attachment I don't know myself either I must admit :-/ [22:09:49] plus the
element in HTML does not have a shape parameter :P [22:09:50] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/96156 [22:10:00] :) [22:10:20] venomch: any changes in the status will be visible on Melange first [22:11:31] (03CR) 10Jhall: [C: 031] UW sometimes takes time to process. Discussed on QA mail list [qa/browsertests] - 10https://gerrit.wikimedia.org/r/96146 (owner: 10Cmcmahon) [22:12:36] MatmaRex: Thanks. [22:12:47] (03CR) 10BryanDavis: [C: 031] mediafile-job-array [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/96014 (owner: 10Dan-nl) [22:12:58] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This looks perfect from the coding side, just waiting for Edokter. (The GCI task has been already marked as completed.)" [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [22:14:29] MatmaRex, andre__: just confirming about the task [22:14:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=25394 [22:15:28] MatmaRex, andre__: in this bug i have to comment that it is still reproducible as still the first section is expanded and the rest are collapsed [22:15:37] (03CR) 10Rudolf.grossmann: [C: 032 V: 032] Added HTML5 support (by Rudolf Grossmann) Extension should now support adding both HTML5 applets and Java applets [extensions/GeoGebra] - 10https://gerrit.wikimedia.org/r/95955 (owner: 10Zbynek) [22:16:27] (03PS1) 10EBernhardson: Use explicit transactions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96158 [22:16:35] mayankmadan: if you add a comment to the bug report, please also mention the browser and browser version and operating system that you use (because some browser have issues with collapsing sections while others have not) [22:18:48] <^d> Wow, that's creative. [22:19:06] <^d> Relying on $wgTitle and __toString at the same time :p [22:19:20] (03CR) 10Adamw: Provision the fundraising-crm project (037 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [22:19:58] (03PS4) 10Aude: Put status handling in EditPage into private function [core] - 10https://gerrit.wikimedia.org/r/96150 [22:20:00] (03PS2) 10Bartosz Dziewoński: Sort 'MediaWiki' resources definitions alphabetically [core] - 10https://gerrit.wikimedia.org/r/96084 [22:20:13] ^d: ^ [22:20:24] (03CR) 10Aude: Put status handling in EditPage into private function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96150 (owner: 10Aude) [22:21:12] <^d> MatmaRex: "[[$wgTitle]]" [22:21:31] <^d> Because when someone asks "How do I make a wiki link to the current page?" that is the obvious answer. [22:21:35] heh [22:21:45] well, yeah. that makes sense, in a certain way [22:21:54] * ^d shudders [22:22:01] how does it parse that? D: [22:22:08] directly calls Parser, i guess? [22:23:23] (03CR) 10Jhall: [C: 031] Remove references to VE in Flow tests, not supported now [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96151 (owner: 10Cmcmahon) [22:24:08] (03PS1) 10Chad: Remove ugly $wgTitle comments [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/96160 [22:32:07] I'm trying to run the tests for Pythonwikibot (core) locally, but I'm getting some failures [22:32:49] MatmaRex, andre__: good night guys... see you tomorrow [22:32:57] heh [22:34:05] Aaron1011: i think the pywikipedia folks mostly sit in some other IRC channel [22:34:21] MatmaRex: Do you know what channel? [22:34:31] Aaron1011: hey, we're in #pywikipediabot [22:34:31] i'm finding out [22:34:37] oh. thanks legoktm :D [22:34:42] legoktm: Thanks! [22:35:04] (03PS13) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [22:36:13] I have been getting some issues when submitting a patch for review. Here is the log: http://pastebin.com/WzfvBzcH . I committed, pulled and rebased. Does anyone know how can I fix this? [22:37:57] MegaAlex: git rebase -i HEAD~6 [22:38:03] and then remove ones that are not your [22:38:25] i assume the open search thing is yours [22:40:36] (03PS1) 10MegaAlex: API: Add default setting for OpenSearch limit parameter [core] - 10https://gerrit.wikimedia.org/r/96162 [22:41:53] (03CR) 10Adamw: [C: 04-1] Provision the fundraising-crm project (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [22:42:03] MegaAlex: so if you add the bug number like "Bug: ###" on it's own line, right before the Change-Id line, a bot will automatically leave a comment on the relevant bugzilla bug [22:42:34] I think that I did that [22:43:21] and thanks aude [22:43:30] MegaAlex: it links from gerrit to bugzilla [22:43:46] but not sure it will link the other way [22:43:49] MegaAlex: you only kind of sort of did :) see https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Example [22:44:02] the bot that adds gerrit links in bugzilla is very picky about format of commit messages [22:44:24] * MatmaRex is off to sleep. good night ~ [22:44:41] good night [22:49:17] (03PS1) 10Mattflaschen: Add return true to hook for back-compat with older core. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/96164 [22:49:40] (03CR) 10Jdlrobson: [C: 032] mediawiki.ui: Add right padding to .agora-field-styling() [core] - 10https://gerrit.wikimedia.org/r/95360 (owner: 10Bartosz Dziewoński) [22:49:41] (03PS2) 10Mattflaschen: Add return true to hook for back-compat with older core. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/96164 [22:49:54] (03CR) 10Edokter: [C: 031] "I've dual-licensed the code on the WikiMedia snippet page under CC-BY and GNU GPL v2+. I hope that satisfies any issues." [core] - 10https://gerrit.wikimedia.org/r/96071 (owner: 10Mayankmadan) [22:50:48] (03CR) 10Mattflaschen: [C: 032] "Self-merging trivial backwards compatibility fix. Tested locally." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/96164 (owner: 10Mattflaschen) [22:51:13] oh, I followed something other. Must read carefully next time. Is there a way to address the bug now? [22:51:28] (03Merged) 10jenkins-bot: Add return true to hook for back-compat with older core. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/96164 (owner: 10Mattflaschen) [22:51:43] (03PS9) 10Jdlrobson: git-logs: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 [22:51:53] (03CR) 10EBernhardson: Parsoid config for Flow can be different than VE, but VE is fallback (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95605 (owner: 10Matthias Mullie) [22:52:49] (03Merged) 10jenkins-bot: mediawiki.ui: Add right padding to .agora-field-styling() [core] - 10https://gerrit.wikimedia.org/r/95360 (owner: 10Bartosz Dziewoński) [23:07:13] (03CR) 10Parent5446: [C: 04-1] "Looks good. Just needs an entry in the RELEASE-NOTES-1.23 file (probably under New features) denoting the new configuration option." [core] - 10https://gerrit.wikimedia.org/r/96162 (owner: 10MegaAlex) [23:08:42] is there an appropriate way to share javascript between extensions? [23:08:59] one of our devs has a patch for $.fn.scrollIntoView, but i notice ULS already has a $.fn.scrollIntoView [23:09:05] s/for/creating / [23:10:04] (03CR) 10EBernhardson: [C: 04-1] Consolidate and clean up "scroll to this element" code. (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [23:10:38] (03CR) 10Jdlrobson: "@ori-l" (032 comments) [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 (owner: 10Ori.livneh) [23:14:02] (03CR) 10Parent5446: [C: 032] Put status handling in EditPage into private function [core] - 10https://gerrit.wikimedia.org/r/96150 (owner: 10Aude) [23:14:13] ori-l: ^ i think i'm misunderstanding something or there is a mistake? [23:15:55] (03CR) 10EBernhardson: Consolidate and clean up "scroll to this element" code. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95975 (owner: 10Werdna) [23:17:52] (03Merged) 10jenkins-bot: Put status handling in EditPage into private function [core] - 10https://gerrit.wikimedia.org/r/96150 (owner: 10Aude) [23:18:53] (03CR) 10EBernhardson: [C: 032] Fix some incorrect autoload definition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96074 (owner: 10Bsitu) [23:19:10] (03Merged) 10jenkins-bot: Fix some incorrect autoload definition [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96074 (owner: 10Bsitu) [23:22:58] (03PS6) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 [23:27:37] (03Abandoned) 10Tim Starling: Set $wgNoFollowLinks to false by default [core] - 10https://gerrit.wikimedia.org/r/94401 (owner: 10leucosticte) [23:30:08] (03CR) 10Parent5446: [C: 04-1] Address CodeSniffer errors and warnings (034 comments) [core] - 10https://gerrit.wikimedia.org/r/96155 (owner: 10Siebrand) [23:31:01] (03PS1) 10Legoktm: Add Special:Edit and Special:History which redirect to their action equivalents [core] - 10https://gerrit.wikimedia.org/r/96170 [23:31:36] (03CR) 10Parent5446: [C: 031] Update formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/96156 (owner: 10Siebrand) [23:31:38] (03PS2) 10Bsitu: Add preview function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 [23:33:21] ebernhardson: usually the adopted solution is "move it into core" :P I think [23:33:54] (03CR) 10jenkins-bot: [V: 04-1] Add preview function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 (owner: 10Bsitu) [23:34:01] but I'm saying so bases only on one precedent I know, so don't trust me (postedit which was needed by visualeditor or something) [23:34:45] (03PS7) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 [23:45:53] (03PS3) 10Bsitu: Add preview function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 [23:46:09] (03CR) 10jenkins-bot: [V: 04-1] Add preview function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 (owner: 10Bsitu) [23:47:55] (03PS4) 10Bsitu: Add preview function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 [23:50:44] (03CR) 10EBernhardson: "Minor cleanup suggestions" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/96065 (owner: 10Matthias Mullie) [23:52:33] (03CR) 10EBernhardson: "VE has a similar complaint related to the base href, its something on parsoids roadmap to fix but not a priority, we will need a temporary" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 (owner: 10EBernhardson) [23:52:52] (03CR) 10Bsitu: Add preview function (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 (owner: 10Bsitu)