[00:02:25] AaronSchulz: any chance you could look at https://gerrit.wikimedia.org/r/#/c/95148/ ? [00:07:13] (03PS3) 10EBernhardson: Add role::profiler utilizing XHProf from pecl [vagrant] - 10https://gerrit.wikimedia.org/r/91122 [00:07:43] (03PS1) 10Chad: Don't even mention $wgTitle [core] - 10https://gerrit.wikimedia.org/r/95736 [00:08:40] lol ^d [00:08:48] (03PS1) 10Bartosz Dziewoński: Call method with the same name it's defined with [core] - 10https://gerrit.wikimedia.org/r/95737 [00:09:10] (03CR) 10Bartosz Dziewoński: [C: 032] Don't even mention $wgTitle [core] - 10https://gerrit.wikimedia.org/r/95736 (owner: 10Chad) [00:09:17] ^d: trivial ^^ [00:09:22] * AaronSchulz watches $wgTitle keep getting mentioned [00:09:30] <^d> You know, core's pretty damn close to having $wgTitle be deprecate-able. [00:09:54] <^d> MessageCache, EditPage, HttpFunctions and Parser all need some loving. [00:10:01] <^d> Rest of it's just setting/swapping stuff around. [00:10:15] <^d> Linker. Dammit linker. [00:10:49] (03PS1) 10Awjrichards: Adds MWApi, a class for interfacing with the MediaWiki API [tools/release] - 10https://gerrit.wikimedia.org/r/95738 [00:10:56] <^d> Of course nothing calls Linker::makeExternalLink() with a $title param. [00:10:58] * ^d sighs [00:11:47] heh, Parser->Linker->Parser [00:12:04] (03CR) 10jenkins-bot: [V: 04-1] Adds MWApi, a class for interfacing with the MediaWiki API [tools/release] - 10https://gerrit.wikimedia.org/r/95738 (owner: 10Awjrichards) [00:14:44] (03Merged) 10jenkins-bot: Don't even mention $wgTitle [core] - 10https://gerrit.wikimedia.org/r/95736 (owner: 10Chad) [00:18:20] (03PS1) 10Bartosz Dziewoński: Watch user page and user talk page by default [core] - 10https://gerrit.wikimedia.org/r/95742 [00:19:30] (03CR) 10MarkTraceur: "Hilarious." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [00:19:39] (03CR) 10CSteipp: [C: 032] "Works, and I think this is a good direction, since we really need to assume useoauth (or some set of rights in the future)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95735 (owner: 10Aaron Schulz) [00:19:43] (03PS1) 10Chad: Deprecate calling Parser::transformMsg() without a Title [core] - 10https://gerrit.wikimedia.org/r/95743 [00:20:31] (03Merged) 10jenkins-bot: Enforce that all consumers have basic rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95735 (owner: 10Aaron Schulz) [00:22:13] (03CR) 10jenkins-bot: [V: 04-1] Deprecate calling Parser::transformMsg() without a Title [core] - 10https://gerrit.wikimedia.org/r/95743 (owner: 10Chad) [00:23:20] (03PS2) 10Chad: Deprecate calling 3 functions without a Title [core] - 10https://gerrit.wikimedia.org/r/95743 [00:23:42] "Tests: 5235, Assertions: 37101, Failures: 53, Errors: 1, Skipped: 16." [00:23:56] gj ^d :D [00:24:03] <^d> :) [00:24:42] (03CR) 10jenkins-bot: [V: 04-1] Deprecate calling 3 functions without a Title [core] - 10https://gerrit.wikimedia.org/r/95743 (owner: 10Chad) [00:25:24] <^d> Heh, I broke {{PLRUAL:}} support. [00:26:18] (03PS1) 10Jdlrobson: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 [00:26:25] (03CR) 10jenkins-bot: [V: 04-1] Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [00:26:32] (03CR) 10EBernhardson: "Possible concerns:" [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [00:27:25] (03PS5) 10AndyRussG: Disable institution-page cache when logged in [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/92335 [00:27:30] (03PS2) 10CSteipp: Include useoauth in UserIsEveryoneAllowed rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 [00:29:06] <^d> !!!!!!!!!!!! [00:29:10] <^d> Dammit. [00:29:26] <^d> MWTimestamp -> Gives you human formatted timestamps, which requires parsing the 'ago' message [00:29:30] <^d> Parsing needs a title. [00:29:37] <^d> Therefore, MWTimestamp needs a title. [00:30:12] (03PS5) 10Jdlrobson: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 [00:30:23] (03PS3) 10Jdlrobson: Link to dependencies, bugs and stories [tools/release] - 10https://gerrit.wikimedia.org/r/95732 [00:30:29] (03PS2) 10Jdlrobson: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 [00:30:50] (03CR) 10jenkins-bot: [V: 04-1] Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [00:32:09] ^d: kill "ago" ;) [00:32:48] (03CR) 10AndyRussG: Disable institution-page cache when logged in (033 comments) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/92335 (owner: 10AndyRussG) [00:33:52] (03PS3) 10CSteipp: Include useoauth in UserIsEveryoneAllowed rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 [00:34:11] <^d> Nemo_bis: Might have to. It's an innocent bystander, but it got caught in the crossfire between myself and $wgTitle. [00:34:19] <^d> Innocent lives lost? Sure. But for the greater good! [00:36:02] (03PS2) 10Awjrichards: Adds MWApi, a class for interfacing with the MediaWiki API [tools/release] - 10https://gerrit.wikimedia.org/r/95738 [00:36:07] (03CR) 10jenkins-bot: [V: 04-1] Adds MWApi, a class for interfacing with the MediaWiki API [tools/release] - 10https://gerrit.wikimedia.org/r/95738 (owner: 10Awjrichards) [00:36:14] (03CR) 10Chad: [C: 031] mediawiki.ui: Add right padding to .agora-field-styling() [core] - 10https://gerrit.wikimedia.org/r/95360 (owner: 10Bartosz Dziewoński) [00:36:57] (03PS4) 10CSteipp: Include useoauth in UserIsEveryoneAllowed rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 [00:41:33] (03PS5) 10CSteipp: Include useoauth in UserIsEveryoneAllowed rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 [00:44:31] (03CR) 10Aaron Schulz: [C: 032] Include implicit rights in UserIsEveryoneAllowed [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 (owner: 10CSteipp) [00:44:37] (03Merged) 10jenkins-bot: Include implicit rights in UserIsEveryoneAllowed [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 (owner: 10CSteipp) [00:44:57] (03PS4) 10EBernhardson: Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 [00:51:58] (03PS3) 10Jdlrobson: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 [00:52:22] (03CR) 10jenkins-bot: [V: 04-1] Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [00:53:39] (03PS3) 10Brian Wolff: Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 [00:53:40] (03PS1) 10Brian Wolff: Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 [00:53:44] hah, commit number "bdcdbbb". That's a lot of b's [00:53:45] (03CR) 10MarkTraceur: "Caching might be nice, but I'm not sure how intense a join between cl and pages would be. I'd +1 it, maybe even merge, after caching is ad" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [00:54:20] (03CR) 10jenkins-bot: [V: 04-1] Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 (owner: 10Brian Wolff) [00:54:28] boo, hiss [00:55:02] (03CR) 10jenkins-bot: [V: 04-1] Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 (owner: 10Brian Wolff) [00:58:00] (03PS4) 10Jdlrobson: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 [01:00:23] (03PS3) 10Mwalker: WIP Node.JS Renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 [01:00:59] (03CR) 10Faidon Liambotis: [C: 04-1] "I can't comment much on the ResourceLoader logic due to ignorance, but this seems fundamentally impossible as-is to me?" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 (owner: 10Anomie) [01:01:11] (03CR) 10BryanDavis: "Minor whitespace issues and a line of cruft in a header comment." (034 comments) [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [01:01:40] (03CR) 10CSteipp: Skip Special:CentralAutoLogin/start for JS anons (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 (owner: 10Anomie) [01:03:31] (03CR) 10Adamw: "As it turns out, I can't make namevirtualhosting play nice with port forwarding. The biggest difficulty is installing MediaWiki with $wgS" [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [01:14:58] (03CR) 10MarkTraceur: [C: 031] "I overreacted, caching isn't necessary. But I'll let Aaron chime in anyway." [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [01:17:17] (03PS7) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [01:19:09] (03PS2) 10Brian Wolff: Add UI to discover translated SVG files. [core] - 10https://gerrit.wikimedia.org/r/95746 [01:19:10] (03PS4) 10Brian Wolff: Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 [01:26:54] (03PS3) 10Adamw: Prepare for name-based virtualhosting [vagrant] - 10https://gerrit.wikimedia.org/r/95471 [01:27:44] (03PS3) 10Adamw: Mediawiki can be checked out on a branch [vagrant] - 10https://gerrit.wikimedia.org/r/95715 [01:27:52] (03PS1) 10Bartosz Dziewoński: Use 'Original file' instead of 'Full resolution' for original file link [core] - 10https://gerrit.wikimedia.org/r/95749 [01:29:19] * bawolff publicly whines about how echo emails don't include the contents of the actual message... [01:29:52] MatmaRex: hmm, I thought I already did that [01:31:21] hmm, guess not [01:31:24] bawolff: even if you did, you didn't link it on the bug :D [01:31:34] true enough :P [01:31:44] Someone definitely at some point asked me to do that [01:31:46] bawolff: echo emails do include the contents of the message almost always, unless they can't be parsed or something. [01:32:07] "You have a new message at tawiki. Click here to view..." [01:32:41] bawolff: you know, echo tries very hard to parse the message out of the dicussion page, but it sometimes can't do that [01:32:42] diff? [01:32:58] (actually, i don't know how hard it tries. it definitely does, though.) [01:33:19] https://ml.wikipedia.org/w/index.php?title=%E0%B4%89%E0%B4%AA%E0%B4%AF%E0%B5%8B%E0%B4%95%E0%B5%8D%E0%B4%A4%E0%B4%BE%E0%B4%B5%E0%B4%BF%E0%B4%A8%E0%B5%8D%E0%B4%B1%E0%B5%86_%E0%B4%B8%E0%B4%82%E0%B4%B5%E0%B4%BE%E0%B4%A6%E0%B4%82:Bawolff&oldid=prev&diff=1861866 [01:33:29] its some fancy table newsletter thingy [01:33:51] This was on my talk page, not a somebody has mentioned your name thingy [01:34:06] yeah [01:34:18] bawolff: echo does weird stuff to try to detect signatures [01:34:28] bawolff: grep for DiscussionParser if you're interested [01:34:37] i am not going down that rabbit hole tonight. [01:34:59] I'm happy just to whine non-productively on irc [01:35:08] heh. [01:35:17] bawolff: you could review some patches instead. [01:35:30] I was thinking of +2'ing your interface change [01:35:33] i think i have 41 open ones. [01:35:54] and then I was wondering if I should ask commons first, lest the users lynch mob me for changing their beloved interface [01:36:20] meh, they'll be able to easily "fix" that when it changes [01:36:55] I'll ask them on the irc channel. If no one responds in ten minutes I'll merge, and if they don't like it they can change it back locally [01:38:26] * bawolff also did review someone elses patch today [01:38:30] bawolff: i have numerous other patches to review, most quite trivial :) https://gerrit.wikimedia.org/r/#/q/owner:%22Bartosz+Dziewo%25C5%2584ski%22+status:open,n,z [01:38:32] * bawolff should review more things [01:38:45] bawolff: you could probably merge like 10 of them outright [01:39:28] * MatmaRex points bawolff to https://toolserver.org/~nemobis/crstats/core.txt to motivate him [01:39:43] * bawolff looks at 94615 to take one at random [01:40:38] wow, I'm pretty pathetic on that list. I thought I'd have at least more than 2 [01:44:42] (03PS1) 10Awjrichards: Create persistent requests session [tools/release] - 10https://gerrit.wikimedia.org/r/95750 [01:44:43] (03PS1) 10Awjrichards: Add method to create/edit articles [tools/release] - 10https://gerrit.wikimedia.org/r/95751 [01:44:48] (03CR) 10jenkins-bot: [V: 04-1] Create persistent requests session [tools/release] - 10https://gerrit.wikimedia.org/r/95750 (owner: 10Awjrichards) [01:45:02] (03CR) 10jenkins-bot: [V: 04-1] Add method to create/edit articles [tools/release] - 10https://gerrit.wikimedia.org/r/95751 (owner: 10Awjrichards) [01:46:48] (03PS3) 10Awjrichards: Adds MWApi, a class for interfacing with the MediaWiki API [tools/release] - 10https://gerrit.wikimedia.org/r/95738 [01:47:10] (03PS2) 10Awjrichards: Create persistent requests session [tools/release] - 10https://gerrit.wikimedia.org/r/95750 [01:47:25] (03PS2) 10Awjrichards: Add method to create/edit articles [tools/release] - 10https://gerrit.wikimedia.org/r/95751 [01:47:31] (03CR) 10jenkins-bot: [V: 04-1] Add method to create/edit articles [tools/release] - 10https://gerrit.wikimedia.org/r/95751 (owner: 10Awjrichards) [01:48:01] (03CR) 10Adamw: "Pretty sure I got it with PS3." [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [01:48:32] (03PS3) 10Awjrichards: Add method to create/edit articles [tools/release] - 10https://gerrit.wikimedia.org/r/95751 [01:49:26] (03PS8) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [01:57:48] hey, it's 3 am already. good night everyone. [01:59:06] (03CR) 10Brian Wolff: [C: 04-1] "With regards to the number of watching users things. With this change it becomes inconsistent for rc lines that have a rollback link on th" [core] - 10https://gerrit.wikimedia.org/r/94615 (owner: 10Bartosz Dziewoński) [01:59:38] (03CR) 10Brian Wolff: [C: 032] "Makes sense. This is confusing." [core] - 10https://gerrit.wikimedia.org/r/95749 (owner: 10Bartosz Dziewoński) [02:01:03] (03PS4) 10Mwalker: WIP Node.JS Renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 [02:02:37] (03Merged) 10jenkins-bot: Use 'Original file' instead of 'Full resolution' for original file link [core] - 10https://gerrit.wikimedia.org/r/95749 (owner: 10Bartosz Dziewoński) [02:06:03] (03PS1) 10MarkAHershberger: Revert "Remove unsupported and mostly non-functional Mssql support" [core] - 10https://gerrit.wikimedia.org/r/95752 [02:06:30] (03CR) 10MarkAHershberger: [C: 032] Revert "Remove unsupported and mostly non-functional Mssql support" [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [02:08:21] (03CR) 10Brian Wolff: [C: 032] "There's also an instance of this in the API." [core] - 10https://gerrit.wikimedia.org/r/95737 (owner: 10Bartosz Dziewoński) [02:11:32] (03Merged) 10jenkins-bot: Revert "Remove unsupported and mostly non-functional Mssql support" [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [02:25:26] (03PS1) 10Brian Wolff: Fix signature of ApiQueryVideoInfo::getPropertyDescriptions() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/95753 [02:28:47] (03PS4) 10Brian Wolff: Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [02:29:13] (03PS2) 10Brian Wolff: Fix signature of ApiQueryVideoInfo::getPropertyDescriptions() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/95753 [02:31:51] (03CR) 10jenkins-bot: [V: 04-1] Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [02:33:46] (03CR) 10Brian Wolff: "PS4 was just a rebase. The tests weren't failing for me locally, so I wanted to see if a recheck would fix it. Guess not" [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [02:41:45] (03CR) 10Legoktm: "Thanks. It should also get sent out to the mediawiki-api list, and I can ask a mod to forward it on to mediawiki-api-announce just in case" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84870 (owner: 10Bsitu) [03:08:20] (03PS5) 10Brian Wolff: Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [03:11:00] (03CR) 10Brian Wolff: [C: 031] "PS5: There was two problems with the unit tests" [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [04:02:05] (03PS1) 10Bsitu: Add preview function [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95754 [04:54:20] (03PS1) 10leucosticte: Set $wgNoFollowLinks to false if "Authorized editors only" selected [core] - 10https://gerrit.wikimedia.org/r/95755 [04:54:57] (03CR) 10jenkins-bot: [V: 04-1] Set $wgNoFollowLinks to false if "Authorized editors only" selected [core] - 10https://gerrit.wikimedia.org/r/95755 (owner: 10leucosticte) [05:04:49] (03PS5) 10EBernhardson: Add role::profiler utilizing XHProf [vagrant] - 10https://gerrit.wikimedia.org/r/91122 [05:13:44] (03CR) 10Parent5446: [C: 04-1] "Minor doc issue" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95717 (owner: 10IAlex) [06:46:30] (03PS2) 10leucosticte: Set $wgNoFollowLinks to false iff "Authorized editors only" selected [core] - 10https://gerrit.wikimedia.org/r/95755 [07:33:10] (03PS3) 10IAlex: Use the native set_chasert() method if available instead of SET NAMES [core] - 10https://gerrit.wikimedia.org/r/95717 [07:33:55] (03CR) 10IAlex: Use the native set_chasert() method if available instead of SET NAMES (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95717 (owner: 10IAlex) [07:57:53] (03PS4) 10Nikerabbit: Use the native set_chasert() method if available instead of SET NAMES [core] - 10https://gerrit.wikimedia.org/r/95717 (owner: 10IAlex) [08:52:30] (03CR) 10Nemo bis: "Diff looks sane, haven't tested." [core] - 10https://gerrit.wikimedia.org/r/95755 (owner: 10leucosticte) [09:14:16] (03PS5) 10Umherirrender: API: Return set values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [09:16:24] (03CR) 10Hashar: "Result can be seen on our giblit installation itself since it renders markdown:" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95591 (owner: 10Zfilipin) [09:19:54] (03PS4) 10Hashar: git-logs: adds MWApi, a class for interfacing with the MediaWiki API [tools/release] - 10https://gerrit.wikimedia.org/r/95738 (owner: 10Awjrichards) [09:19:55] (03PS3) 10Hashar: git-logs: Create persistent requests session [tools/release] - 10https://gerrit.wikimedia.org/r/95750 (owner: 10Awjrichards) [09:19:56] (03PS4) 10Hashar: git-logs: Add method to create/edit articles [tools/release] - 10https://gerrit.wikimedia.org/r/95751 (owner: 10Awjrichards) [09:22:15] (03CR) 10Hashar: "I would recommend using an existent python module for that. The pywikibot project surely can be reused." [tools/release] - 10https://gerrit.wikimedia.org/r/95738 (owner: 10Awjrichards) [09:23:33] (03PS3) 10Hashar: Allow use of -c argument [tools/release] - 10https://gerrit.wikimedia.org/r/95718 (owner: 10Jdlrobson) [09:23:47] (03PS6) 10Hashar: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 (owner: 10Jdlrobson) [09:23:55] (03PS7) 10Hashar: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 (owner: 10Jdlrobson) [09:24:01] (03PS4) 10Hashar: Link to dependencies, bugs and stories [tools/release] - 10https://gerrit.wikimedia.org/r/95732 (owner: 10Jdlrobson) [09:24:08] (03PS5) 10Hashar: Link to dependencies, bugs and stories [tools/release] - 10https://gerrit.wikimedia.org/r/95732 (owner: 10Jdlrobson) [09:24:16] (03PS5) 10Hashar: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [09:24:23] (03PS6) 10Hashar: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 (owner: 10Jdlrobson) [09:25:45] (03CR) 10Hashar: "I have no clue how CSSmin works sorry, removing myself from reviewers." [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [09:48:57] (03PS1) 10Umherirrender: Deprecate addButton and insertTags in mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/95764 [10:10:59] (03CR) 10Umherirrender: "Please backport to 1.23wmf3 and 1.24wmf4 to avoid confusion. Thanks." [core] - 10https://gerrit.wikimedia.org/r/95537 (owner: 10Anomie) [10:17:18] (03CR) 10Umherirrender: ""Please backport to 1.23wmf3 and 1.23wmf4 to avoid confusion."" [core] - 10https://gerrit.wikimedia.org/r/95537 (owner: 10Anomie) [10:21:52] (03PS1) 10Umherirrender: Fix typo in comment in mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/95766 [10:32:03] (03CR) 10IAlex: [C: 032] Fix typo in comment in mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/95766 (owner: 10Umherirrender) [10:34:58] (03Merged) 10jenkins-bot: Fix typo in comment in mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/95766 (owner: 10Umherirrender) [10:38:52] (03PS3) 10IAlex: Clean up some old readme files and remove references to SVN [core] - 10https://gerrit.wikimedia.org/r/94490 (owner: 10TTO) [10:38:58] (03CR) 10IAlex: [C: 032] Clean up some old readme files and remove references to SVN [core] - 10https://gerrit.wikimedia.org/r/94490 (owner: 10TTO) [10:43:49] (03Merged) 10jenkins-bot: Clean up some old readme files and remove references to SVN [core] - 10https://gerrit.wikimedia.org/r/94490 (owner: 10TTO) [10:45:41] (03PS4) 10IAlex: Remove SQL patches for old table 'validate' [core] - 10https://gerrit.wikimedia.org/r/94384 (owner: 10Umherirrender) [10:45:46] (03CR) 10IAlex: [C: 032] Remove SQL patches for old table 'validate' [core] - 10https://gerrit.wikimedia.org/r/94384 (owner: 10Umherirrender) [10:50:29] (03Merged) 10jenkins-bot: Remove SQL patches for old table 'validate' [core] - 10https://gerrit.wikimedia.org/r/94384 (owner: 10Umherirrender) [11:02:09] (03CR) 10Bartosz Dziewoński: [C: 031] "Woot, thanks. I really didn't feel like digging into that." [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [11:24:47] hi lazowik [11:24:56] hey [11:25:35] what's up? [11:27:24] nothing much [11:27:52] gci is going to begin in a couple of days !!! [11:27:54] :) [11:28:35] yup [11:30:56] (03PS1) 10Umherirrender: Fix function doc of ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/95767 [11:30:58] (03PS1) 10Addshore: General fixes, style and comments / phpdoc [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/95768 [11:31:13] (03PS1) 10Addshore: Add some phpdocs for IDEs [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/95769 [11:31:44] (03PS2) 10Addshore: Cleanup and expand Status tests [core] - 10https://gerrit.wikimedia.org/r/95620 [11:31:45] (03PS1) 10Addshore: Further expand Status unit tests [core] - 10https://gerrit.wikimedia.org/r/95770 [11:32:05] (03PS1) 10Addshore: Split mocks/media/MockBitmaphandler file [core] - 10https://gerrit.wikimedia.org/r/95771 [11:32:26] (03PS1) 10Addshore: Refactor skins/SideBarTest [core] - 10https://gerrit.wikimedia.org/r/95772 [11:35:27] (03PS1) 10Addshore: Split HTMLCheckMatrixTest into 2 files [core] - 10https://gerrit.wikimedia.org/r/95773 [11:35:28] (03PS1) 10Addshore: Split includes/HTMLForm [core] - 10https://gerrit.wikimedia.org/r/95774 [11:36:23] (03CR) 10Addshore: "Indeed, otherwise tests will fail [=" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [11:37:34] (03CR) 10jenkins-bot: [V: 04-1] Split mocks/media/MockBitmaphandler file [core] - 10https://gerrit.wikimedia.org/r/95771 (owner: 10Addshore) [11:39:02] (03PS2) 10Umherirrender: Add used message keys to ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/94515 [11:39:32] (03CR) 10Umherirrender: "Patch Set 2: comment change backed out to Ide072627e87c94da5a180d8d00aa38683af44f4e" [core] - 10https://gerrit.wikimedia.org/r/94515 (owner: 10Umherirrender) [11:41:46] (03PS2) 10Addshore: Split mocks/media/MockBitmaphandler file [core] - 10https://gerrit.wikimedia.org/r/95771 [11:42:20] (03CR) 10Bartosz Dziewoński: "So much splitting. Wanna do includes/SpecialPage next? :P" [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [11:43:15] Google Code-in 2013 discussion here? [11:44:41] (yes) [11:45:06] (03CR) 10Addshore: "Maybe I should!" [core] - 10https://gerrit.wikimedia.org/r/95774 (owner: 10Addshore) [11:45:34] very vivd one [11:46:13] why hello there lazowik [= [11:46:40] hey addshore, strange not on #*wikidata [11:50:43] (03CR) 10Addshore: [C: 04-1] "per my -1 to PS1" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95616 (owner: 10Jeroen De Dauw) [11:51:10] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Most of the cases you split away are actually testing HTMLCheckMatrixTest, and HTMLFormField is just accidentally there." [core] - 10https://gerrit.wikimedia.org/r/95773 (owner: 10Addshore) [11:54:00] (03CR) 10Bartosz Dziewoński: [C: 032] Deprecate addButton and insertTags in mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/95764 (owner: 10Umherirrender) [11:56:11] (03PS3) 10IAlex: Add used message keys to ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/94515 (owner: 10Umherirrender) [11:56:26] (03CR) 10IAlex: [C: 032] Add used message keys to ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/94515 (owner: 10Umherirrender) [11:56:45] addshore: can you find somebody who knows about Status to review those test changes? :) [11:56:59] (03Merged) 10jenkins-bot: Deprecate addButton and insertTags in mediawiki.action.edit [core] - 10https://gerrit.wikimedia.org/r/95764 (owner: 10Umherirrender) [11:57:06] which changes MatmaRex ? :P [11:58:33] (03PS2) 10Addshore: Cleanup HTMLCheckMatrixTest [core] - 10https://gerrit.wikimedia.org/r/95773 [11:58:44] addshore: the ones for Status tests [11:59:57] MatmaRex: I will try, any suggestions? CUrrently I am just writing tests for the behaviour the class currently has. [12:00:24] i dunno, grep for lines using it in core and blame who wrote them? :P [12:00:29] :D [12:00:57] (03CR) 10Bartosz Dziewoński: Split mocks/media/MockBitmaphandler file (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95771 (owner: 10Addshore) [12:01:04] addshore: hm, about ^ [12:01:12] shouldn't the new files keep the license header? [12:01:29] (the header is quite silly, but we seem to rather consistently use it) [12:01:43] (03Merged) 10jenkins-bot: Add used message keys to ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/94515 (owner: 10Umherirrender) [12:02:51] MatmaRex: done :) [12:02:53] (03PS3) 10Addshore: Split mocks/media/MockBitmaphandler file [core] - 10https://gerrit.wikimedia.org/r/95771 [12:03:06] mayankmadan: btw, have you been already pointed to https://www.mediawiki.org/wiki/Manual:Coding_conventions ? [12:03:15] the header is just so verbose, but I agree, it is everywhere [= [12:03:28] (and subpages for language-specific notes) [12:03:35] that's a very good read [12:04:02] also applies more or less to general coding of projects [12:04:06] not only mediawiki [12:04:20] (03PS4) 10Addshore: Split mocks/media/MockBitmaphandler file [core] - 10https://gerrit.wikimedia.org/r/95771 [12:05:54] (03CR) 10Bartosz Dziewoński: [C: 032] Prevent space before ellipsis when truncating [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [12:09:56] (03CR) 10Bartosz Dziewoński: [C: 032] "OK I guess, if the tests still pass." [core] - 10https://gerrit.wikimedia.org/r/95771 (owner: 10Addshore) [12:10:29] (03Merged) 10jenkins-bot: Prevent space before ellipsis when truncating [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [12:13:38] (03Merged) 10jenkins-bot: Split mocks/media/MockBitmaphandler file [core] - 10https://gerrit.wikimedia.org/r/95771 (owner: 10Addshore) [12:16:07] (03PS2) 10IAlex: Fix function doc of ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/95767 (owner: 10Umherirrender) [12:16:15] (03CR) 10IAlex: [C: 032] Fix function doc of ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/95767 (owner: 10Umherirrender) [12:20:53] (03Merged) 10jenkins-bot: Fix function doc of ContentHandler::getLocalizedName [core] - 10https://gerrit.wikimedia.org/r/95767 (owner: 10Umherirrender) [12:25:01] (03CR) 10Raimond Spekking: [C: 032] Links to mediawiki.org in messages should use HTTPS [core] - 10https://gerrit.wikimedia.org/r/95698 (owner: 10Bartosz Dziewoński) [12:26:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Stuff inline." (039 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [12:27:53] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Does it not work or what? Also, release notes." [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [12:28:03] (03Merged) 10jenkins-bot: Links to mediawiki.org in messages should use HTTPS [core] - 10https://gerrit.wikimedia.org/r/95698 (owner: 10Bartosz Dziewoński) [12:35:32] how can i hide the side bar please? [12:36:33] #sidebar{ [12:36:33] display:none; [12:36:33] } [12:36:33] ? [12:36:40] not works [12:38:23] (03PS1) 10Bartosz Dziewoński: SkinTemplate: Add $this as a parameter to PersonalUrls hook [core] - 10https://gerrit.wikimedia.org/r/95776 [12:38:43] (03Abandoned) 10Bartosz Dziewoński: Add context to PersonalUrls hook. [core] - 10https://gerrit.wikimedia.org/r/33273 (owner: 10Olenz) [12:40:37] (03CR) 10Bartosz Dziewoński: "BTW, I submitted a core change which would let us get rid of the globals: https://gerrit.wikimedia.org/r/#/c/95776/ – you could depend on " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [12:42:35] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Release notes need moving to 1.23. Please do not make unrelated changes in other code." [core] - 10https://gerrit.wikimedia.org/r/53529 (owner: 10devunt) [12:45:21] (03CR) 10Bartosz Dziewoński: "This is probably superseded by Krinkle's https://gerrit.wikimedia.org/r/#/c/95555/" [core] - 10https://gerrit.wikimedia.org/r/67166 (owner: 10Wizardist) [12:53:17] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs another rebase :(" [core] - 10https://gerrit.wikimedia.org/r/53964 (owner: 10Eranroz) [13:07:49] (03CR) 10Hashar: [C: 04-1] Misc fixes for build/test scripts [tools/release] - 10https://gerrit.wikimedia.org/r/95575 (owner: 10MarkAHershberger) [13:20:23] (03PS4) 10Umherirrender: Add continue editing link also to js and css pages [core] - 10https://gerrit.wikimedia.org/r/85232 [13:23:38] (03PS1) 10Bartosz Dziewoński: mediawiki.Title: Add 'params' parameter to #getUrl [core] - 10https://gerrit.wikimedia.org/r/95778 [13:26:11] @notify RoanKattouw [13:26:11] I'll let you know when I see RoanKattouw around here [13:26:23] @notify hoo [13:26:23] I'll let you know when I see hoo around here [13:28:04] @notify MatmaRex [13:28:04] This user is now online in #wikimedia-dev. I'll let you know when they show some activity (talk, etc.) [13:28:11] that bot is not that dumb [13:31:29] (03PS5) 10Hashar: abstract out version numbers [tools/release] - 10https://gerrit.wikimedia.org/r/86264 [13:31:32] hi hashar [13:31:36] (03CR) 10jenkins-bot: [V: 04-1] abstract out version numbers [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [13:31:44] hashar: why, exactly? you just got a notification that i talked. [13:31:51] yup [13:31:54] ah, *not*. :) [13:32:01] so it tells me in the chan that you are around [13:32:10] and whenever you act, it send me a private message as well :D [13:32:17] (03CR) 10Hashar: "rebased" [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [13:32:44] hashar: it also stalks multiple channels. so if somebody joins #wikimedia-growth or something equally silly, you will know. [13:33:00] (03PS6) 10Hashar: abstract out version numbers [tools/release] - 10https://gerrit.wikimedia.org/r/86264 [13:33:10] greaaat [13:33:15] (it will also most likely use the silliest channel name possible if they join multiple ones, but oh well, you can't have anything :P) [13:33:22] (03CR) 10Hashar: "fixed pyflakes mistake" [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [13:36:47] (03PS1) 10Mdale: Added COPYING file to clearly state GPL2 for the extension. [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/95779 [13:42:12] (03CR) 10Mdale: [C: 032 V: 032] Fix signature of ApiQueryVideoInfo::getPropertyDescriptions() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/95753 (owner: 10Brian Wolff) [13:44:02] (03PS1) 10Hashar: Revert "Put tar and diff files in the right place." [tools/release] - 10https://gerrit.wikimedia.org/r/95780 [13:44:47] (03CR) 10Hashar: [C: 032] "Mark, I am not sure what you were trying to do with https://gerrit.wikimedia.org/r/#/c/94478/ but it breaks a bunch of paths." [tools/release] - 10https://gerrit.wikimedia.org/r/95780 (owner: 10Hashar) [13:44:53] (03Merged) 10jenkins-bot: Revert "Put tar and diff files in the right place." [tools/release] - 10https://gerrit.wikimedia.org/r/95780 (owner: 10Hashar) [13:46:16] (03PS7) 10Hashar: make-release: abstract out version numbers [tools/release] - 10https://gerrit.wikimedia.org/r/86264 [13:46:41] (03CR) 10Hashar: "rebased once more :(" [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [13:47:46] (03CR) 10Hashar: [C: 032] "Good enough, eventual decoupling will be done later on." [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [13:47:51] (03Merged) 10jenkins-bot: make-release: abstract out version numbers [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [13:47:52] (03PS1) 10Mdale: Add GPL2 COPYING file to extension [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/95781 [14:15:42] (03PS1) 10Hashar: make-release: basic logging support [tools/release] - 10https://gerrit.wikimedia.org/r/95782 [15:02:59] (03PS1) 10Aude: Fix covers tag in GlobalTest [core] - 10https://gerrit.wikimedia.org/r/95784 [15:04:09] (03CR) 10Bartosz Dziewoński: [C: 032] Fix covers tag in GlobalTest [core] - 10https://gerrit.wikimedia.org/r/95784 (owner: 10Aude) [15:05:10] (03Draft2) 10Aude: Move SpecialPage::getTitleFor exception to SpecialPageFactory [core] - 10https://gerrit.wikimedia.org/r/95783 [15:06:45] (03PS1) 10UltrasonicNXT: Create {{#avatar:Username}} parser function [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/95785 [15:08:13] (03Merged) 10jenkins-bot: Fix covers tag in GlobalTest [core] - 10https://gerrit.wikimedia.org/r/95784 (owner: 10Aude) [15:19:14] (03CR) 10Aude: [C: 04-1] "need to handle the global variables" [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [15:29:27] (03CR) 10UltrasonicNXT: "I realise I've probably done all the setting up of this wrong, but I wasn't sure where to put the hook, class and i18n attachments. I'll h" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/95785 (owner: 10UltrasonicNXT) [16:00:31] (03CR) 10MarkAHershberger: "I discovered more problems last night but neglected to submit my fixes." [tools/release] - 10https://gerrit.wikimedia.org/r/95780 (owner: 10Hashar) [16:03:48] (03CR) 10MarkAHershberger: "never mind. I think I just forgot about this." [tools/release] - 10https://gerrit.wikimedia.org/r/95780 (owner: 10Hashar) [16:23:31] (03CR) 10Nikerabbit: "I'm afraid this will break things and might not be a wanted behavior. Instead of just working, now failure to add alias entry for all spec" [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [16:54:00] (03PS2) 10Jack Phoenix: Create {{#avatar:Username}} parser function [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/95785 (owner: 10UltrasonicNXT) [16:58:17] (03CR) 10Jack Phoenix: "Have I ever mentioned that git's a huge pain? Well, now I have." [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/95785 (owner: 10UltrasonicNXT) [16:59:31] (03CR) 10Alex Monk: "Where do you plan to use this?" [core] - 10https://gerrit.wikimedia.org/r/95776 (owner: 10Bartosz Dziewoński) [17:00:57] (03CR) 10Bartosz Dziewoński: "Anywhere where we need to check if the user is logged in or maybe access OutputPage to add some styles. In particular https://gerrit.wikim" [core] - 10https://gerrit.wikimedia.org/r/95776 (owner: 10Bartosz Dziewoński) [17:02:59] (03PS1) 10Umherirrender: Show correct links on cached result of Special:DeadendPages [core] - 10https://gerrit.wikimedia.org/r/95790 [17:04:10] (03PS2) 10Umherirrender: Show correct links on cached result of Special:DeadendPages [core] - 10https://gerrit.wikimedia.org/r/95790 [17:10:55] (03CR) 10Parent5446: [C: 032] Use the native set_charset() method if available instead of SET NAMES [core] - 10https://gerrit.wikimedia.org/r/95717 (owner: 10IAlex) [17:11:45] (03CR) 10Alex Monk: [C: 032] SkinTemplate: Add $this as a parameter to PersonalUrls hook [core] - 10https://gerrit.wikimedia.org/r/95776 (owner: 10Bartosz Dziewoński) [17:14:10] (03Merged) 10jenkins-bot: Use the native set_charset() method if available instead of SET NAMES [core] - 10https://gerrit.wikimedia.org/r/95717 (owner: 10IAlex) [17:15:42] (03Merged) 10jenkins-bot: SkinTemplate: Add $this as a parameter to PersonalUrls hook [core] - 10https://gerrit.wikimedia.org/r/95776 (owner: 10Bartosz Dziewoński) [17:20:32] (03PS1) 10Umherirrender: Avoid empty batch in ListredirectsPage::preprocessResults [core] - 10https://gerrit.wikimedia.org/r/95791 [17:25:40] (03CR) 10Brian Wolff: [C: 032] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/95791 (owner: 10Umherirrender) [17:29:40] (03PS3) 10UltrasonicNXT: Create {{#avatar:Username}} parser function [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/95785 [17:32:31] (03PS7) 10Jdlrobson: Add more context to bug reports, group other commits [tools/release] - 10https://gerrit.wikimedia.org/r/95744 [17:45:05] (03CR) 10Brian Wolff: [C: 04-1] "I think this should do the link patch thing, even if $wgMiserMode = false;" [core] - 10https://gerrit.wikimedia.org/r/95790 (owner: 10Umherirrender) [17:49:51] (03CR) 10Bartosz Dziewoński: Add Special:Thanks as a non-JS fallback (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [17:56:28] (03CR) 10Brian Wolff: [C: 032] "Looks fine to me. More consistency is good." [core] - 10https://gerrit.wikimedia.org/r/85232 (owner: 10Umherirrender) [18:01:09] (03CR) 10MarkAHershberger: "Thanks for this start. Was really needed." [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [18:03:13] bawolff: Thanks for going through those changesets. :-) [18:04:08] Elsie: Well those were easy reviews [18:04:44] and matmarex showed me how pathetically low I am on this list https://toolserver.org/~nemobis/crstats/core.txt ;) [18:06:24] * Nemo_bis mwahahahahhaha's [18:06:26] :> [18:06:53] woot, what did ^d do to have merged 59 patches this month. [18:07:20] probably he removed all preferences and we didn't notice [18:08:14] (03CR) 10MarkAHershberger: "I was able to reproduce the problem that I was trying to fix." [tools/release] - 10https://gerrit.wikimedia.org/r/95780 (owner: 10Hashar) [18:08:21] ah, siebrand's formatting fixes [18:08:33] Nemo_bis: Plust probably killed all the globals while he was at it [18:08:36] *plus [18:08:58] Nemo_bis: well, he did remove mssql support :P [18:09:09] (that was since reverted, can't really say if i agree) [18:09:44] If mssql is really that broken, seems like it should be moved out as an extension until people fix it up enough for it to work [18:11:10] bawolff: i think even the installer doesn't offer it [18:12:47] (03CR) 10Brian Wolff: "If MSSql is really broken, but there are people interested in fixing it up at some future point, I think the logical thing to do is turn i" [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [18:13:08] meh, everyone should use mysql! [18:13:27] also, everyone should speak the languages I speak! [18:23:09] (03CR) 10Umherirrender: "On Special:DeadendPages never redirects will be listed (page_is_redirect' => 0) but stub infos can used, that is right." [core] - 10https://gerrit.wikimedia.org/r/95790 (owner: 10Umherirrender) [18:28:44] (03CR) 10MarkAHershberger: "If a hook is provided for this, then we should make sure Oracle and/or Pg support can be implemented using it first. That will flush out " [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [18:31:07] (03PS3) 10Brian Wolff: LinkSearch: use default protocol if unsupported [core] - 10https://gerrit.wikimedia.org/r/84475 (owner: 10Ejegg) [18:31:41] (03CR) 10Brian Wolff: [C: 032] "I agree that this behaviour makes much more sense then the previous behaviour" [core] - 10https://gerrit.wikimedia.org/r/84475 (owner: 10Ejegg) [18:35:57] (03Merged) 10jenkins-bot: LinkSearch: use default protocol if unsupported [core] - 10https://gerrit.wikimedia.org/r/84475 (owner: 10Ejegg) [18:38:50] TextContent::diff looks wrong... Shouldn't $ntext use $that->getNativeData() ? [18:40:42] (03CR) 10Brian Wolff: "Actually, one doesn't even need a hook to make a Database "driver" as an extension. Simply name your class DatabaseMssql, make sure its a " [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [18:42:08] MatmaRex, ^ [18:43:39] Krenair: huh? [18:44:16] see includes/content/TextContent.php, specifically the diff function [18:47:08] Krenair: i still have no idea what you are asking, nor why are you aksing me D: [18:47:30] i don't remember ever looking at nor using that code [18:47:58] No, I just saw you were talking in the channel not that long ago and wanted someone else to take a look as well :p [18:48:30] I asked "Shouldn't $ntext use $that->getNativeData() ?" [18:49:35] (03CR) 10MarkAHershberger: "I think you're right. All that would be needed is the necessary auto-load setup." [core] - 10https://gerrit.wikimedia.org/r/95752 (owner: 10MarkAHershberger) [18:50:39] (03CR) 10Aude: "@nikerabbit: otherwise, you always get a warning if the special page is not listed in aliases, so essentially it is required." [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [18:51:01] Krenair: hmm [18:51:10] Krenair: heh yeah, that seems to compare the Content to itself [18:51:26] lol [18:59:57] (03PS1) 10Alex Monk: ContentHandler: TextContent::diff should compare to given object, not itself [core] - 10https://gerrit.wikimedia.org/r/95794 [19:02:49] (03PS1) 10Siebrand: Remove useless method overriding [core] - 10https://gerrit.wikimedia.org/r/95795 [19:04:23] (03CR) 10Brian Wolff: [C: 04-1] "Needs a rebase to apply cleanly" [core] - 10https://gerrit.wikimedia.org/r/92041 (owner: 10Yurik) [19:09:56] (03PS48) 10Frédéric Wang: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [19:25:06] (03PS1) 10Alex Monk: Don't send rollback notification if nothing changed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95797 [19:28:34] (03CR) 10PleaseStand: "For the record, I did find two bugs, which I fixed in Ie915726f and I8494de8c, with a very slightly modified version of this script. That " [core] - 10https://gerrit.wikimedia.org/r/93745 (owner: 10Chad) [19:45:23] (03PS3) 10Aude: Remove unused exception in SpecialPage::getTitleFor and add tests [core] - 10https://gerrit.wikimedia.org/r/95783 [19:47:23] (03CR) 10Hoo man: [C: 04-1] Remove unused exception in SpecialPage::getTitleFor and add tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [19:47:52] (03CR) 10Aude: "@nikerabbit I am keeping the current behavior (for now), although not convinced throwing a warning and then continuing is great thing to d" [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [19:48:16] (03CR) 10Aude: "hah" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [19:48:48] (03PS6) 10Aaron Schulz: Changed use of tag_summary to use change_tag with GROUP_CONCAT() [core] - 10https://gerrit.wikimedia.org/r/95584 [19:49:14] (03PS4) 10Aude: Remove unused exception in SpecialPage::getTitleFor and add tests [core] - 10https://gerrit.wikimedia.org/r/95783 [19:51:44] (03PS1) 10Brian Wolff: Call setRelevantTitle during revision delete [core] - 10https://gerrit.wikimedia.org/r/95800 [19:54:45] (03CR) 10Brian Wolff: "Without https://gerrit.wikimedia.org/r/95800 , this would change the tabs at the top of the page to be for the special page, which I think" [core] - 10https://gerrit.wikimedia.org/r/64528 (owner: 10Alex Monk) [19:55:08] (03CR) 10Hoo man: [C: 032] "Looks sane, as SpecialPageFactory::getLocalNameFor will never return anything other than a string (as long as we call it with a string). T" [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [19:56:05] I doubt many call SpecialPage::getTitleFor( false ); and similar :P [19:56:31] (03PS2) 10Yurik: Logic optimization for wfExpandUrl() [core] - 10https://gerrit.wikimedia.org/r/92041 [19:57:04] aude: An invalid argument exception would be suitable, but we don't use such in MediaWiki anyway [19:59:05] (03Merged) 10jenkins-bot: Remove unused exception in SpecialPage::getTitleFor and add tests [core] - 10https://gerrit.wikimedia.org/r/95783 (owner: 10Aude) [20:00:18] (03CR) 10Brian Wolff: [C: 032] "Looks fine to me" [core] - 10https://gerrit.wikimedia.org/r/92041 (owner: 10Yurik) [20:03:35] (03Merged) 10jenkins-bot: Logic optimization for wfExpandUrl() [core] - 10https://gerrit.wikimedia.org/r/92041 (owner: 10Yurik) [20:04:54] (03PS1) 10Siebrand: Address errors and warnings in CodeSniffer in api/ [core] - 10https://gerrit.wikimedia.org/r/95802 [20:04:55] (03PS1) 10Siebrand: Add documentation for DerivativeRequest::__construct [core] - 10https://gerrit.wikimedia.org/r/95803 [20:04:56] (03PS2) 10Brian Wolff: (Bug 47958) Make GENDER ignore everything after slash [core] - 10https://gerrit.wikimedia.org/r/62146 (owner: 10Wizardist) [20:07:20] (03PS2) 10Siebrand: Add documentation for DerivativeRequest::__construct [core] - 10https://gerrit.wikimedia.org/r/95803 [20:13:08] (03PS1) 10Siebrand: Fix incorrect parameter order for dieUsage() [core] - 10https://gerrit.wikimedia.org/r/95806 [20:13:43] (03PS2) 10Siebrand: Fix incorrect parameter order for dieUsage() [core] - 10https://gerrit.wikimedia.org/r/95806 [20:14:47] (03CR) 10Brian Wolff: [C: 04-1] "{{Gender:Project:Foo|m|f|?}} doesn't work properly for someone with the username "Project:Foo" (The second parameter to Title::newFromText" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/62146 (owner: 10Wizardist) [20:17:12] woah, where did my patch go? :) [20:17:33] alright, will submit follow up with more tests [20:18:01] (03PS2) 10Siebrand: Address errors and warnings in CodeSniffer in api/ [core] - 10https://gerrit.wikimedia.org/r/95802 [20:19:29] (03CR) 10Brian Wolff: "I think I would prefer to have the stub link formatting here. However I'd still consider it ok provided there is a todo code comment notin" [core] - 10https://gerrit.wikimedia.org/r/95790 (owner: 10Umherirrender) [20:20:28] thedj: ping [20:23:42] hexmode: i am around if needed [20:24:36] hashar: way too busy with other stuff atm :( [20:30:17] (03PS3) 10Umherirrender: Show correct link color on cached result of Special:DeadendPages [core] - 10https://gerrit.wikimedia.org/r/95790 [20:31:52] (03CR) 10Umherirrender: "Patch Set 3: Always run the LinkBatch to have also stub color on the links." [core] - 10https://gerrit.wikimedia.org/r/95790 (owner: 10Umherirrender) [20:32:57] (03CR) 10Aude: ContentHandler: TextContent::diff should compare to given object, not itself (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [20:33:30] aude, I'm also wondering what @since 1.21diff means [20:35:21] hah [20:36:27] (03CR) 10Siebrand: [C: 031] "i18n reviewed. I expect that users will start opening bugs for incomplete localisation. It would be a good idea if submitter would be able" [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [20:37:51] (03CR) 10Alex Monk: ContentHandler: TextContent::diff should compare to given object, not itself (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [20:44:20] (03PS2) 10Hashar: make-release: basic logging support [tools/release] - 10https://gerrit.wikimedia.org/r/95782 [20:44:53] (03CR) 10Hashar: "made INFO the default level, dropping --verbose." [tools/release] - 10https://gerrit.wikimedia.org/r/95782 (owner: 10Hashar) [20:49:36] (03CR) 10Aude: [C: 031] "change looks good, although I see some cleanup to do in the comment block for the method" [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [20:50:04] (03CR) 10Aude: "cleanup can be in follow up or whatever" [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [20:52:07] (03PS2) 10Alex Monk: ContentHandler: TextContent::diff should compare to given object, not itself [core] - 10https://gerrit.wikimedia.org/r/95794 [20:52:45] (03CR) 10Aude: [C: 031] ContentHandler: TextContent::diff should compare to given object, not itself [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [20:52:53] (03PS7) 10Daniel Kinzler: Detect leakage of error_reporting state in tests. [core] - 10https://gerrit.wikimedia.org/r/74170 [20:53:07] aude, can't you +2? [20:53:28] i can't [20:53:31] DanielK_WMDE can [20:53:35] or someone [20:54:56] (03CR) 10Jack Phoenix: [C: 04-1] "Gotcha time: while HTML is an abbreviation of "HyperText Markup Language" and in normal prose (i.e. articles and whatnot) it should always" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/95785 (owner: 10UltrasonicNXT) [20:55:13] (03CR) 10TMg: [C: 031] "I like simple solutions. Yes, users are importing other users monobook.js, for example. I think it's a good idea to not exclude user .css " [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [20:55:15] (03CR) 10Daniel Kinzler: "Removed option as per Krinkle, now unconditionally failing on leaked error_reporting state." [core] - 10https://gerrit.wikimedia.org/r/74170 (owner: 10Daniel Kinzler) [20:58:12] aude, Krenair: whut? [20:58:51] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/95794/ [20:58:57] easy chocolate [20:58:59] aude: huh, you don't have the right to +2 in core? [20:59:02] not yet [20:59:16] (03CR) 10Bartosz Dziewoński: [C: 032] ContentHandler: TextContent::diff should compare to given object, not itself [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [20:59:23] that's silly. [20:59:31] maybe soon (and addshore too) [21:00:07] (03PS1) 10Siebrand: Address CodeSniffer comments in ApiBase.php [core] - 10https://gerrit.wikimedia.org/r/95814 [21:01:36] (03CR) 10jenkins-bot: [V: 04-1] Address CodeSniffer comments in ApiBase.php [core] - 10https://gerrit.wikimedia.org/r/95814 (owner: 10Siebrand) [21:02:33] (03Merged) 10jenkins-bot: ContentHandler: TextContent::diff should compare to given object, not itself [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [21:05:36] (03PS1) 10Siebrand: Update indentation [core] - 10https://gerrit.wikimedia.org/r/95815 [21:06:14] (03CR) 10jenkins-bot: [V: 04-1] Update indentation [core] - 10https://gerrit.wikimedia.org/r/95815 (owner: 10Siebrand) [21:06:35] (03PS1) 10Siebrand: Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/95816 [21:07:46] (03CR) 10jenkins-bot: [V: 04-1] Remove unused local variables [core] - 10https://gerrit.wikimedia.org/r/95816 (owner: 10Siebrand) [21:08:05] aude: you are up for +2? I can't even seem to find the page where merge access to core is discussed >_< [21:09:38] (03CR) 10Daniel Kinzler: "oops :)" [core] - 10https://gerrit.wikimedia.org/r/95794 (owner: 10Alex Monk) [21:10:12] thanks for fixing... [21:11:28] It's https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership I think DanielK_WMDE [21:11:56] Krenair: i thought so too, but i can't find anything relevant there [21:12:02] https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership#MediaWiki_core is horribly outdated [21:12:48] (03CR) 10Brian Wolff: [C: 032] "looks good" [core] - 10https://gerrit.wikimedia.org/r/95790 (owner: 10Umherirrender) [21:12:54] (03PS1) 10Siebrand: Update some documentation in CacheTime and ParserCache [core] - 10https://gerrit.wikimedia.org/r/95817 [21:16:08] bawolff, hi [21:16:16] Hi [21:16:35] (03CR) 10jenkins-bot: [V: 04-1] Update some documentation in CacheTime and ParserCache [core] - 10https://gerrit.wikimedia.org/r/95817 (owner: 10Siebrand) [21:16:40] (03PS1) 10Siebrand: Update docs to reduce inconsistent type compatibility in api/ [core] - 10https://gerrit.wikimedia.org/r/95818 [21:16:40] I'm looking at https://gerrit.wikimedia.org/r/#/c/95800/1 but can't find much difference to the page after the change [21:17:15] Krenair: At the moment, there's only a difference if the url has ?title=Special:RevisionDeletion [21:17:25] DanielK_WMDE: aude: the general requests pages is https://www.mediawiki.org/wiki/Gerrit/Project_ownership [21:17:31] Ugh, of course. Sorry bawolff [21:17:39] page* [21:18:03] (03CR) 10jenkins-bot: [V: 04-1] Update docs to reduce inconsistent type compatibility in api/ [core] - 10https://gerrit.wikimedia.org/r/95818 (owner: 10Siebrand) [21:20:21] DanielK_WMDE: aude: but no idea how staff merge rights are handled [21:20:36] (03PS1) 10Siebrand: Add/update/remove incomplete/incorrect documentation [core] - 10https://gerrit.wikimedia.org/r/95820 [21:20:45] (03CR) 10Alex Monk: [C: 032] Call setRelevantTitle during revision delete [core] - 10https://gerrit.wikimedia.org/r/95800 (owner: 10Brian Wolff) [21:21:55] (03CR) 10jenkins-bot: [V: 04-1] Add/update/remove incomplete/incorrect documentation [core] - 10https://gerrit.wikimedia.org/r/95820 (owner: 10Siebrand) [21:22:22] thanks :) [21:22:29] (03PS2) 10Anomie: Skip Special:CentralAutoLogin/start for JS anons [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 [21:23:30] (03PS1) 10Siebrand: Format email addresses more consistently [core] - 10https://gerrit.wikimedia.org/r/95821 [21:24:27] (03Merged) 10jenkins-bot: Call setRelevantTitle during revision delete [core] - 10https://gerrit.wikimedia.org/r/95800 (owner: 10Brian Wolff) [21:24:43] (03PS2) 10Brian Wolff: Set title to Special:Revisiondelete on action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/64528 (owner: 10Alex Monk) [21:24:47] (03CR) 10jenkins-bot: [V: 04-1] Format email addresses more consistently [core] - 10https://gerrit.wikimedia.org/r/95821 (owner: 10Siebrand) [21:26:24] (03CR) 10Brian Wolff: [C: 032] Set title to Special:Revisiondelete on action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/64528 (owner: 10Alex Monk) [21:27:11] MatmaRex:i would be treated as volunteer (which i am and happen be wikidata staff, which comes with no extra rights) [21:27:40] MatmaRex: if you're a WMF staff member, you get added to the wmf ldap group which gives you +2 basically everywhere [21:27:41] * aude prefers to be treated as volunteer :) [21:27:43] Thanks bawolff [21:27:50] no problem [21:28:09] legoktm: I've noticed though, that that doesn't seem to apply to some WMF contractors [21:28:11] after all it's saturday and i'm coding :) [21:28:32] legoktm: For example, Jan was WMF contractor, but went through the "volunteer" process [21:28:51] bawolff: oh, no clue. I just asked someone on IRC and got added to it [21:29:46] It might have something to do with Jan primarily being a contractor just for TimedMediaHandler type stuff maybe (?) [21:30:17] legoktm: Well given you already had +2 rights, is there something else the WMF group gives you? [21:30:28] I didn't have +2 rights before >.> [21:30:41] * aude thinks legoktm would have no problem with the regular process [21:30:42] Oh. I didn't realize :P [21:30:45] (03Merged) 10jenkins-bot: Set title to Special:Revisiondelete on action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/64528 (owner: 10Alex Monk) [21:30:49] but can take a while [21:30:58] Indeed, I would have certainly voted for you in a vote [21:31:09] heh, thanks :) [21:31:30] I really thought you already did. I would have probably nominated you if I realized you didn't [21:33:17] To be honest though, I somewhat don't think the auto-get +2 when hired thing really makes sense. For new hires that were not hired from the community volunteer pool, they are probably quite competent programmers, but wouldn't be familar with mediawiki code conventions, etc [21:34:32] Then again, I also tend to lean towards there shouldn't be differences between WMF and non-WMF folks in general [21:35:54] (03PS1) 10Matanya: (bug 57144) Tipsy: using user class borks positioning of tip [core] - 10https://gerrit.wikimedia.org/r/95822 [21:45:07] (03CR) 10Hoo man: [C: 031] "Will +2 soon in case no objections are raised" [core] - 10https://gerrit.wikimedia.org/r/74170 (owner: 10Daniel Kinzler) [21:56:00] (03PS1) 10Hashar: make-release: update local repositories [tools/release] - 10https://gerrit.wikimedia.org/r/95825 [22:03:22] (03PS8) 10Daniel Kinzler: Detect leakage of error_reporting state in tests. [core] - 10https://gerrit.wikimedia.org/r/74170 [22:04:08] (03CR) 10Hoo man: [C: 031] "Will +2 soon in case no objections are raised" [core] - 10https://gerrit.wikimedia.org/r/74170 (owner: 10Daniel Kinzler) [22:05:17] (03PS1) 10Brian Wolff: Use master db for showing log extract on RevDel success page [core] - 10https://gerrit.wikimedia.org/r/95828 [22:18:37] Did somebody kill escapeQuotesHTML from the legacy javascript [22:18:47] bawolff: yes, i think [22:18:57] meh [22:19:00] and a bunch of other stuff [22:19:12] bawolff: visit a page with ?debug=true to get deprecation notices in the console [22:19:42] MWDeprecationWarning: Use of "escapeQuotesHTML" property is deprecated. Use mw.html instead [22:19:54] I'm now being asked to fix code I wrote in 2008 [22:20:17] there's mw.html.escape [22:20:24] which probably does mostly the same thing [22:20:32] but don't quote me on this [22:20:51] Its close enough for my usage [22:21:05] * bawolff just doesn't like that things are breaking for no good reason [22:22:42] bawolff: subscribe to wikitech-ambassadors :P [22:22:49] I am :P [22:22:50] krinkle actually sent a notice there [22:23:26] That would assume I'm actually maintaining any of these scripts [22:23:32] MatmaRex: the 1990s called, they want their mailing lists back [22:24:29] where the situation is more like I wrote a script for some people 5 years ago, before this resource loader stuff existed, and now I'm being asked to fix it all, just because some folks don't like the number of global symbols we have in js [22:26:33] just like with MW PHP code, then [22:27:00] things randomly break (because someone decides to "deprecate" method X by removing it) and it makes us third-party uses & developers unhappy :-( [22:27:06] * bawolff remembers back to the day where if you deprecated something (in PHP code) you were expected to grep and change all uses in extensions in our svn, and even then still keep it around for 2 versions with a notice [22:28:00] On top of that, most wikis outside of places like commons and enwikipedia, do not have javascript savvy users [22:28:21] their js is made by people who copy it from place to place/other scary things [22:28:31] its unrealistic to expect them to be able to fix it themselves [22:28:34] bawolff: we still do that. [22:28:38] (the grepping and fixing) [22:28:49] indeed... [22:28:57] and we usually do keep stuff around [22:28:59] MatmaRex: I haven't seen anyone change all uses in extensions since we've moved to git [22:29:02] gods, the stuff we keep around. [22:29:07] bawolff: i did [22:29:16] * bawolff gives MatmaRex a gold star :) [22:29:22] (and I remember a rather recent incident -- from the SVN era -- when someone removed a core method w/o updating all the (social) extensions using it, hence fatals) [22:29:22] i did do that myself, too [22:29:28] bawolff: we do such incompatible changes more rarely now because it's a major PITA [22:29:53] MatmaRex: well, you're awesome, but can you (or we, or anyone) assume that everyone whose code gets submitted to core is as awesome as you are? [22:30:12] I just fixed frwikinews, because they copied over some js to load the mw.ui styles, which they screwed up the copying by copying and pasting it into a comment block [22:30:21] ashley: i think that the people with +2 rights are competent enough to check usages before merging clearly backwards-incompatible changes [22:30:31] bawolff: heh, >.> [22:30:39] ashley: i also think that ops would get mad at you if you caused fatals to spike. :> [22:31:05] and we have like a few hundred different extensions *deployed* [22:31:45] Hey, is there a gadget yet for the new search? [22:32:06] 154, to be exact. [22:32:27] sjoerddebruin: i don't think there's any gadget, what would you need one for? [22:32:41] sjoerddebruin: also, the new search only works on a couple of wikis who opted in. [22:32:47] Yeah, nlwiki [22:33:05] Just one that adds “&srbackend=CirrusSearch” after every searchlink [22:33:19] hm. [22:33:24] i don't think anybody made one yet, no. [22:33:37] its unrealistic to expect them to be able to fix it themselves [22:33:38] Can you make it? :) [22:33:42] It's still their responsibility though. [22:34:29] If they can't even figure out where the error is, I don't think its fair to make it their responsibility [22:34:29] sjoerddebruin: I think aude made one [22:34:36] :O [22:34:53] (03CR) 10Hashar: "Got to amend it so that 'branch' is actually the branch (aka REL*_* or master) and move the tag to 'tag' :-]" [tools/release] - 10https://gerrit.wikimedia.org/r/86264 (owner: 10Hashar) [22:34:57] * bawolff also notes, things like this make me look at code I wrote 5 years ago. And wow, the horrors... [22:35:00] it's like three lines of code anyway, i can do it if there isn't already [22:35:09] It's unrealistic to expect MediaWiki developers to know the name of every wiki, forget having the time and rights necessary to update everything [22:35:46] sjoerddebruin: http://lists.wikimedia.org/pipermail/wikidata-tech/2013-November/000337.html [22:35:50] If the people who put the code there can't be considered responsible for it then we're stuck never being able to remove any functions/properties ever [22:36:04] On what wiki is it hosted legoktm [22:36:12] wikidata.org I assume [22:36:27] yup [22:36:27] https://www.wikidata.org/wiki/User:Aude/searchbackend.js [22:36:30] https://www.wikidata.org/wiki/User:Aude/searchbackend.js [22:36:33] ;) [22:36:40] Okay, gonna add it and post it in our “kroeg" [22:36:42] Krenair: People leave, people move on to other things [22:36:57] Besides they accepted responsibility for it when they put it there [22:37:00] MatmaRex: whose ops? [22:37:32] ashley: wikimedia's? [22:37:40] exactly... [22:37:52] i'm not sure what you're getting at. [22:38:15] this might come as a surprise, but...there's life outside Wikimedia and its wikis, too (*gasp*!) and relatively decent extensions _not_ deployed on WMF sites [22:38:26] legoktm: you're an admin on WD, right? [22:38:30] so the fact that WMF ops do some QA is _nice_, but not enough [22:38:39] Krenair: I would not consider it a bad thing, if things were only removed when they caused problems [22:38:43] legoktm: can i have you fix that script? a one-line change to make it work on non-english wikis [22:38:56] aude: or you, around? [22:39:03] It’s not working, yes... [22:39:16] Because of “Special:Search”? [22:39:20] sjoerddebruin: yes [22:39:43] sjoerddebruin: you need to replace: [22:39:44] mw.config.get( 'wgPageName' ) == 'Special:Search' [22:39:46] with: [22:39:48] mw.config.get( 'wgCanonicalSpecialPageName' ) === 'Search' [22:39:58] yes, that. :) [22:40:05] Hmmmm [22:40:15] I wonder if Aude'll stab me if I fix it >.> [22:40:19] that'll make it work in all languages [22:40:22] I don’t think so. [22:40:36] https://en.wikipedia.org/wiki/Wikipedia:Ignore_all_rules ;) [22:41:06] please wait while I'll get something heavy and beat this editor that is enabled on .css & .js pages with it [22:41:15] ashley: okay, but i don't see how that's relevant to not causing fatals [22:41:43] ashley: you can disable the piece of crap, y'know [22:41:58] fatals can exist outside WMF wikis and they can be caused by extension incompatibility (i.e. SocialProfile calling a method that was recently removed from MW core or something...) [22:41:58] (03CR) 10Parent5446: [C: 032] Remove useless method overriding [core] - 10https://gerrit.wikimedia.org/r/95795 (owner: 10Siebrand) [22:42:03] and do tell me how, please! [22:42:04] the /* button in top-left corner of toolbar. [22:42:19] omg yay, thanks :D [22:42:44] ashley: public methods are, as far as i know, rarely or never removed without being deprecated first [22:43:02] even with a major rewrite like contenthandler an effort was made to keep things working [22:43:32] ashley: definitely deprecate first :] [22:43:50] SPECIALLY in core! [22:44:01] or that get extensions author mad at us whenever we release a new mw version [22:44:02] ashley: what was the method that was so covertly removed? [22:44:15] hashar: yes, ashley is actually mad right now. :> [22:44:21] oops [22:44:23] bug ! [22:44:31] I mean: do fill a bug somewhere please [22:44:44] I think this was over something in the past [22:44:47] this isn't a specific issue, but more general ranting [22:44:57] (03Merged) 10jenkins-bot: Remove useless method overriding [core] - 10https://gerrit.wikimedia.org/r/95795 (owner: 10Siebrand) [22:45:09] hashar: I started the ball rolling with a rant over js function removals [22:45:10] ashley: the new search is disabled on wikidata [22:45:24] and go ahead and fix :) [22:45:31] It’s already fixed [22:45:38] hehe [22:45:40] I want to use it on nlwiki [22:45:56] ok :) [22:46:01] * ashley throws https://bugzilla.wikimedia.org/show_bug.cgi?id=49280 in the general direction of MatmaRex [22:46:32] :) [22:46:48] bawolff: I have no clue how the JS deprecation is handled [22:46:50] "The UserProfilePage class extends the core MediaWiki Article class and until MediaWiki 1.21, it worked flawlessly." [22:46:56] i am pretty sure that's not a supported use case. :D [22:47:00] bawolff: but Timo (==Krinkle) would surely know. [22:47:03] Article is a big ball of mud [22:47:12] well, yeah, maybe so [22:47:13] but [22:47:14] Hm, it’s still not working. [22:47:18] SP isn't the "only" offender [22:47:20] I have this in my common.js [22:47:21] mw.loader.load('//www.wikidata.org/wiki/User:Aude/searchbackend.js&action=raw&ctype=text/javascript'); [22:47:30] and there wasn't a huge, scary announcement beforehand or anything [22:47:38] ok [22:47:50] many extensions do similar things with the ArticleFromTitle hook AFAIK [22:47:57] * aude won't do random experiments there [22:47:58] sjoerddebruin: you have a typo there [22:47:59] or a few [22:48:06] hashar: Oh my rant came about because some users on a wiki I used to be active in a while back, complained that a js script I wrote really long ago (5 years, back in 2008) starting having errors, and it was due to arbitrary functions being removed in js [22:48:21] I’ve copied the loadingthingy for the RTRC MatmaRex [22:48:39] bawolff: you want to raise the issue on wikitech-l so [22:48:39] sjoerddebruin: mw.loader.load('//www.wikidata.org/wiki/User:Aude/searchbackend.js?action=raw&ctype=text/javascript'); [22:48:43] maybe [22:48:46] hashar: Anyways, issue is fixed, I just don't see the point of removing methods where they don't hurt things, especially when the majority of the smaller wikis aren't compotent enough to deal with it on their own [22:48:51] (one ampersand changed to a question mark) [22:49:00] Yeah, I already tried that. [22:49:02] ashley: that won't work either because action=raw is special [22:49:04] bawolff: when we released 1.19 we had a bunch of third parties angry. The step we took was to strictly enforce the use of wfDeprecated() [22:49:05] //www.wikidata.org/w/index.php?title=User:Aude/searchbackend.js&action=raw&ctype=text/javascript [22:49:07] this will work. [22:49:14] ...o__O [22:49:23] hashar: Maybe, maybe not, I'm more just ranting now ;) [22:49:24] Oh yes [22:49:32] bawolff: :-] [22:49:39] bawolff: i don't like how the JS deprecation thing was handled much, myself [22:49:42] Yeah its working [22:49:52] offf andsleeping [22:49:53] bawolff: they were removed and deprecated at the same time, which is not nice [22:50:09] bawolff: (stubs were kept in place to keep most stuff from throwing exceptions) [22:50:40] but oh well, it's a little too late now [22:51:10] hashar: To be honest, in my opinion (Which may just be hind sight seeming to be better), wfDeprecated was more strongly enforced around 1.17 era [22:51:11] at least the scripts that used these were or are being actively fixed, which would not have happened with a pleasant deprecation first [22:51:54] I don't see why we couldn't have deprecated things like escapeHtmlQuotes with a statement like escapeHtmlQuotes = mw.html.escape; [22:52:08] we could [22:52:10] but we didn't [22:52:12] which sucks [22:52:18] because breaking things is funnier, duh [22:52:22] but we should have though about that a month ago when this was being committed [22:52:22] bawolff: ^ [22:53:01] bawolff: the patch was https://gerrit.wikimedia.org/r/#/c/92457/ [22:53:14] (03CR) 10Parent5446: [C: 032] Add documentation for DerivativeRequest::__construct [core] - 10https://gerrit.wikimedia.org/r/95803 (owner: 10Siebrand) [22:53:32] it was merged in a hurry and backported [22:54:04] i dunno, i assumed somebody wanted this done and i've already interfered in enough things [22:54:20] i didn't get around to reviewing it before it was merged [22:55:02] Lets be realistic here. The biggest issue is I had to look at js I wrote in 2008, and its uncomfortable to be reminded how much I sucked in 2008 :P [22:55:06] huh... [22:55:19] (03CR) 10Parent5446: [C: 032] Fix incorrect parameter order for dieUsage() [core] - 10https://gerrit.wikimedia.org/r/95806 (owner: 10Siebrand) [22:55:24] why was I not added as a reviewer to that changeset? [22:55:35] there were two files changed in skins/ and I have my name on https://www.mediawiki.org/wiki/Git/Reviewers#mediawiki.2Fcore ... [22:55:48] But MatmaRex, is this going to be added to the new beta-thingy? [22:56:03] sjoerddebruin: what? the new search? [22:56:07] Yeah [22:56:15] (03Merged) 10jenkins-bot: Add documentation for DerivativeRequest::__construct [core] - 10https://gerrit.wikimedia.org/r/95803 (owner: 10Siebrand) [22:56:20] sjoerddebruin: Its not currently planned to be [22:56:33] It’s the perfect place for such things [22:56:37] sjoerddebruin: i don't think so, the beta-thingy is mostly for interface thingies [22:56:39] Although on wikis where that search is in beta, and have beta features on, it might make sense [22:56:47] but, hm, that's not a bad idea [22:56:57] marktraceur: ---^ [22:57:41] hmm, I'll file a bug for that in betafeatures [22:57:45] * aude has no idea how to put stuff in beta [22:57:46] sjoerddebruin: yeah, you should ask marktraceur and fabrice florin (who are doing the beta thingy) and nikolas everett (who is doing the search) [22:58:02] fabrice is on vacation right now I think [22:58:11] Then we wait for marktraceur [22:58:20] (03Merged) 10jenkins-bot: Fix incorrect parameter order for dieUsage() [core] - 10https://gerrit.wikimedia.org/r/95806 (owner: 10Siebrand) [22:58:27] ashley: well, dunno about other, but i didn't even know that the page you linked existed. [22:58:50] ah, you mean automatically [22:58:51] ashley: I've always used gerrits internal, email you if this path is touched thing, instead of the bot one, and it usually works well for me [22:59:07] then i dunno either. i managed my change subscriptions in gerrit, not in some external tool that may or may not work [22:59:09] looks easy [22:59:27] bawolff: there's such a thing? :o [22:59:27] ... [22:59:28] Wat [22:59:42] marktraceur: tl;dr new search should be a BetaFeature. [22:59:45] Ah. [22:59:58] marktraceur: and you have been pinged to make it so. :P [23:00:03] MatmaRex: I'm not sure it's sufficiently separated that it could be, but we could discuss it [23:00:11] There's a backlog of things-that-should-be-BetaFeatures [23:00:21] https://www.mediawiki.org/wiki/Beta_Features/New_Features [23:00:23] marktraceur: you have my word that it could [23:00:25] would it be something to implement in cirrus search extension? [23:00:31] that hooks into beta? [23:00:32] aude: yes [23:00:34] k [23:00:43] marktraceur: I think it could be just a js hack that changes the url [23:00:54] aude: basically it needs to add a new preference and that's (almost) it [23:01:01] yeah [23:01:28] But the “Beta Features”-thing is only going live with the photothingy? [23:01:56] sjoerddebruin: Not neccesarily, it can go live with other features. At the moment though, that is the primary beta feature [23:02:05] Okay. [23:02:08] and essentially the reason the entire thing was made [23:02:20] Lol [23:03:05] But it’s more easier than custom javascript and clearer than the gadgetspage. [23:06:53] Well I added it to that page - https://www.mediawiki.org/wiki/Beta_Features/New_Features#CirrusSearch [23:07:40] Ok, time for me to get food (I deprecate you dishes!!) [23:09:07] Thanks btw [23:49:12] (03CR) 10Parent5446: [C: 031] Changed use of tag_summary to use change_tag with GROUP_CONCAT() [core] - 10https://gerrit.wikimedia.org/r/95584 (owner: 10Aaron Schulz) [23:54:35] (03CR) 10Bartosz Dziewoński: "You can set the author by doing `git commit --author "Name "`, possibly with `--amend`." [core] - 10https://gerrit.wikimedia.org/r/95822 (owner: 10Matanya)