[00:01:40] FakeMaintenance [00:01:40] charming :p [00:02:45] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [00:16:45] (03CR) 10Gergő Tisza: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [00:18:59] (03PS3) 10Aaron Schulz: Avoid extra parsing in prepareContentForEdit() [core] - 10https://gerrit.wikimedia.org/r/95519 [00:22:59] (03PS6) 10Gergő Tisza: Add WikiFilePage::getForeignCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 [00:32:13] (03CR) 10EBernhardson: "Not entirely sure about this one. The first problem i noticed is that the base href can be stored as http://127.0.0.1:8080/wiki/Main_page" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 (owner: 10EBernhardson) [00:46:42] (03CR) 10Werdna: [C: 032] Always return unformatted content for unformatted posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95567 (owner: 10EBernhardson) [00:46:52] (03Merged) 10jenkins-bot: Always return unformatted content for unformatted posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95567 (owner: 10EBernhardson) [00:49:33] (03CR) 10Ori.livneh: "Why don't we disable redis authentication for now, instead? This is plausibly going to be fixed upstream. It seems wrong to complicate the" [core] - 10https://gerrit.wikimedia.org/r/94935 (owner: 10Aaron Schulz) [01:00:07] (03CR) 10Tim Starling: "This patch is mostly just addressing nitpicking, since client idle disconnections mostly occur in JobQueueRedis, which uses Lua scripts ex" [core] - 10https://gerrit.wikimedia.org/r/94935 (owner: 10Aaron Schulz) [01:01:08] * gwicke is wondering if there is anybody awake that can push out changes to the Jenkins config [01:01:47] no Antoine or Chad it seems [01:01:56] Krinkle ? [01:02:06] Yes? [01:02:11] Yes. [01:02:17] yay ;) [01:02:23] hey, I want to set up a local mirror of our git repo – I get that I can do git clone --mirror and get a mirror – but apart from a once-per-minute cron job, the only sensible way I can think of to update it is to have it update every few hours plus on demand when anything is requested [01:02:32] but git doesn't seem to have a "pre-send" hook [01:02:42] hey jorm, how are the Russians? [01:02:43] Krinkle: I pushed one minor tweak to master of jenkins-job-builder-config [01:02:49] I guess they were Russian to conclusions [01:02:53] defeated. [01:03:04] i'll be writing a blog post about it soon. [01:03:04] gwicke: link? [01:03:19] Krinkle: now I tried to follow the instructions on https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder#Deploy_changes, but it is fairly convoluted and jenkins-job crashes locally [01:03:36] jorm: I saw your FB post [01:03:37] Krinkle: c84a5ee546e65 [01:03:49] gwicke: Don't merge in jjb-config unless it is deployed. Because jjb-config is not software we run in production, but something we run locally to generate job configurations and then have to manually submit to jenkins one by one. If you merge it, I can't tell which of the jobs affected have been updated. [01:03:56] (03PS7) 10Dan-nl: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [01:03:58] !g c84a5ee546e65 [01:03:58] https://gerrit.wikimedia.org/r/#q,c84a5ee546e65,n,z [01:04:46] syncing master should always reset to what was previously deployed. anyway, checking out now [01:04:51] Krinkle: hm, ok- I think this was the way I updated the Jenkins job before [01:05:20] I was wondering if the config could deploy automatically on merge [01:05:30] then things would be automatically in sync [01:05:37] merging there does nothing, and until someone checks out the repo and regenerates and pushes that individual job on purpose, it would never be deployed. [01:05:42] (03CR) 10Dan-nl: "ps7 addresses inline comments by aaron and gergő in ps6" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [01:06:01] (03CR) 10Dan-nl: "(6 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [01:06:05] there is no 'scap' only 'sync-file' (to translate to mw terms) [01:06:41] yeah, it seems to be a fairly manual process still [01:07:32] for that reason my last change worked more like 'push change, then poke Antoine about it' [01:07:47] hey AaronSchulz let me know if there's anything else needed for https://gerrit.wikimedia.org/r/#/c/94748/. i'm hoping that this latest patch set takes care of your main concerns and we can merge and move forward ... [01:09:35] gwicke: pushed [01:09:50] gwicke: flow https://gist.github.com/Krinkle/7477518 [01:11:22] (03CR) 10Krinkle: "Generated and deployed job 'parsoid-roundtrip-test-check'." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95475 (owner: 10GWicke) [01:11:41] csteipp: is there anything i can do to help your review of gwtoolset? [01:14:00] Hi dan-nl, not really at this point. I've been working on the security release that just went out. Did you and Aaron get everything resolved for the file backend? [01:15:19] csteipp: we're almost there. there's one outstanding review in that regard https://gerrit.wikimedia.org/r/#/c/94748. i'm waiting on aaron to get back to me with more comments or a merge [01:15:20] (03PS3) 10Aaron Schulz: Expanded use of reauthenticateConnection() beyond just Lua calls [core] - 10https://gerrit.wikimedia.org/r/94935 [01:16:50] Krinkle: thanks a bunch! [01:17:48] I tried using the deb package for jenkins-job-builder, but that crashed in the second-to-last command in your gist [01:18:07] TimStarling: that avoids problems with the get/clearLastError methods and should avoid clearing them overzealously [01:18:30] ok [01:18:59] * Aaron|home is trying to keep this is simple a hack as possible [01:21:05] (03PS2) 10Werdna: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 [01:21:07] (03CR) 10jenkins-bot: [V: 04-1] Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [01:24:50] Krinkle: btw, do you have ideas for https://bugzilla.wikimedia.org/show_bug.cgi?id=39617 ? [01:26:36] (03PS3) 10Werdna: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 [01:27:40] gwicke: Can't use distribution packages for jjb, because we use edge and a fork of the edge even (right now our fork is just a mirror, but we've had minor patches in the past) [01:27:54] so always pull and combile before you use it every time to avoid undoing anything. [01:28:11] (that part is actually somewhat documented on mw:CI/JJB) [01:28:26] gwicke: checking bug in a bit, currently finishing up something else first [01:28:48] Krinkle: I see, thanks for the info [01:33:37] (03PS9) 10Krinkle: resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 [01:39:28] (03CR) 10CSteipp: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy) [01:44:44] Krinkle: this is basically what I have so far: http://jsfiddle.net/XpEk7/ [01:51:13] gwicke: Got a version that is broken? [01:51:36] (btw, it appears 2 semi colons were missing, rendering the last css rule ignored) [01:51:36] http://jsfiddle.net/pf5CM/ [01:53:14] Aaron|home: does https://gerrit.wikimedia.org/r/#/c/94748/ look okay to you now? [01:55:45] I still see the getLocalReference calls and a lot of extra GWTFileBackend.php complexity. If gt and bryan are OK with it I guess it can be merged and everything else done as follow-ups. [02:06:46] Aaron|home: there are two getLocalReference calls … why are they an issue? [02:07:52] the one in cleanupGWTFileBackend.php [02:08:07] why can't it just check the timestamp and decide to delete? [02:08:38] how can i get a reference to the file with out the getLocalReference call? [02:08:57] how can i get the timestamp without the getLocalReference call? [02:13:37] also need to make sure the file that will be deleted is a metadata file so i want to check the extension as far as i can tell using getLocalReference returns a $FSFile that allows me to check the timestamp and extension [02:20:00] Aaron|home in regards to GWTFileBackend.php complexity, what do you think i can change to make it more simple? [02:20:20] you can see the extension from the path the getFileList returns [02:20:51] a local reference is only useful when you want all the contents of the file in /tmp for some reason [02:29:02] Aaron|home k, so i can use pathinfo to sort the extension, what about the timestamp? [02:30:58] you can use FileBackend::extensionFromPath [02:31:06] getFileTimestamp() is fine for the timestamp [02:31:58] Isarra: there's a blame button when vieing a file on github. [02:32:01] errr [02:32:05] wrong channel, blegh [02:32:34] Not everyone knows how to use github or that it's even there. [02:34:26] Aaron|home: k, got it [02:34:39] i'll make that change now [02:35:00] what about your concern over the complexity of GWTFileBackend [02:35:11] what exactly do you find too complex? [02:40:34] dan-nl: it should be more like how math/timeline/score ect use filebackend, just a simple wrapper around some FileBackend calls. For example prepare() should just have the array for secure() in the method, instead of building it up using a bunch of fields and passing it through Filter [02:41:34] the only mentioning of lockManager should be 'lockManager' => 'nullLockManager' in setupFileBackend for the default backend [02:41:41] same with fileMode ect [02:42:10] k, so i can hard code that config array [02:42:13] if someone wants a different file mode then they can setup a $wgFileBackend for that and point to it [02:42:56] (03PS4) 10Tim Starling: Expanded use of reauthenticateConnection() beyond just Lua calls [core] - 10https://gerrit.wikimedia.org/r/94935 (owner: 10Aaron Schulz) [02:43:02] (03CR) 10Tim Starling: [C: 032] "It'll do." [core] - 10https://gerrit.wikimedia.org/r/94935 (owner: 10Aaron Schulz) [02:43:11] in the method [02:44:43] all of the hash wrappers are borrowed from math with a few adjustments where needed [02:45:04] right, there will be hash methods in there [02:45:58] retrieve, delete, createcleanupjob are all helper methodsin the class that make it easy to reference elsewhere in the extension [02:46:00] basically you should have zero config in that class that can't already be managed via $wgFileBackends [02:46:18] k, so the main concern sounds like config info [02:46:29] i'll hard code it instead [02:46:44] (03PS5) 10MarkAHershberger: make-release: initial tarball test script [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [02:46:46] (03PS1) 10MarkAHershberger: Misc fixes for build/test scripts [tools/release] - 10https://gerrit.wikimedia.org/r/95575 [02:46:49] I think when the excess config stuff is gone it should be fine [02:46:55] (03CR) 10jenkins-bot: [V: 04-1] Misc fixes for build/test scripts [tools/release] - 10https://gerrit.wikimedia.org/r/95575 (owner: 10MarkAHershberger) [02:47:40] (03CR) 10Legoktm: [C: 031] "Tested, works fine. Will +2, but is there anything that needs to be done on the translatewiki side to make sure translations don't get los" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/59760 (owner: 10Alex Monk) [02:47:45] (03Merged) 10jenkins-bot: Expanded use of reauthenticateConnection() beyond just Lua calls [core] - 10https://gerrit.wikimedia.org/r/94935 (owner: 10Aaron Schulz) [02:47:48] that sounds good … the only config piece i'll leave is the name and container paths … those will still pull from config or would you like me to hard code those there as well? [02:47:59] dan-nl: also in setupFileBackend() you don't even have to support the automatic backend like math does, you can require that the site admin configure a backend name [02:48:11] that would simplify even more a bit [02:48:30] math does that for convenience and backwards compatibility [02:49:31] so throw an error if the site admin has not provided a $wgFileBackend to use? [02:51:01] (03PS2) 10MarkAHershberger: Misc fixes for build/test scripts [tools/release] - 10https://gerrit.wikimedia.org/r/95575 [02:54:15] dan-nl: that will work [02:54:37] * Aaron|home goes afk [03:06:51] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [03:20:25] (03PS1) 10MarkAHershberger: rc2 [core] - 10https://gerrit.wikimedia.org/r/95576 [03:21:03] (03CR) 10jenkins-bot: [V: 04-1] rc2 [core] - 10https://gerrit.wikimedia.org/r/95576 (owner: 10MarkAHershberger) [03:26:31] (03CR) 10MarkAHershberger: [C: 032 V: 031] rc2 [core] - 10https://gerrit.wikimedia.org/r/95576 (owner: 10MarkAHershberger) [03:27:07] (03CR) 10jenkins-bot: [V: 04-1] rc2 [core] - 10https://gerrit.wikimedia.org/r/95576 (owner: 10MarkAHershberger) [03:35:16] (03Abandoned) 10MarkAHershberger: rc2 [core] - 10https://gerrit.wikimedia.org/r/95576 (owner: 10MarkAHershberger) [03:36:52] (03PS1) 10MarkAHershberger: RC2 [core] - 10https://gerrit.wikimedia.org/r/95578 [03:37:31] (03CR) 10jenkins-bot: [V: 04-1] RC2 [core] - 10https://gerrit.wikimedia.org/r/95578 (owner: 10MarkAHershberger) [03:42:33] (03Abandoned) 10MarkAHershberger: RC2 [core] - 10https://gerrit.wikimedia.org/r/95578 (owner: 10MarkAHershberger) [03:44:09] (03CR) 10MZMcBride: "Thanks for this. :-)" [core] - 10https://gerrit.wikimedia.org/r/95537 (owner: 10Anomie) [03:45:25] (03PS2) 10Legoktm: WIP Add notifications for new features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [03:45:47] (03PS1) 10Tim Starling: Improve redis connection error log [core] - 10https://gerrit.wikimedia.org/r/95579 [03:46:18] (03CR) 10Legoktm: "(2 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur) [03:48:12] (03PS1) 10MarkAHershberger: RC2 [core] - 10https://gerrit.wikimedia.org/r/95580 [03:48:49] (03CR) 10jenkins-bot: [V: 04-1] RC2 [core] - 10https://gerrit.wikimedia.org/r/95580 (owner: 10MarkAHershberger) [03:50:28] (03Abandoned) 10MarkAHershberger: RC2 [core] - 10https://gerrit.wikimedia.org/r/95580 (owner: 10MarkAHershberger) [03:51:46] (03PS1) 10MarkAHershberger: RC2 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95581 [03:54:02] (03CR) 10MarkAHershberger: [C: 032 V: 031] RC2 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95581 (owner: 10MarkAHershberger) [03:57:22] (03Merged) 10jenkins-bot: RC2 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95581 (owner: 10MarkAHershberger) [03:58:40] (03Abandoned) 10MarkAHershberger: remove old fork [tools/release] - 10https://gerrit.wikimedia.org/r/92045 (owner: 10MarkAHershberger) [05:09:47] (03PS3) 10MarkAHershberger: Misc fixes for build/test scripts [tools/release] - 10https://gerrit.wikimedia.org/r/95575 [05:13:02] (03CR) 10Tim Starling: [C: 032 V: 032] Fix timezone issue and PHP 5.4 support [php/wmerrors] - 10https://gerrit.wikimedia.org/r/94838 (owner: 10Tim Starling) [06:20:11] (03CR) 10Aude: [C: 04-1] "Looking at the code (and now testing the patch), I see it is "usurping" the talk page link and turning it into "you have new messages". I " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [06:21:28] aude: that's the current behavior of what echo does. [06:21:47] "You have new messages" still goes to your talk page though [06:22:17] really? [06:22:22] yes [06:22:27] except it does it via javascript [06:23:18] ick [06:23:38] ok [06:24:12] (03PS1) 10Werdna: WIP: Flow output refactoring. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95583 [06:24:14] (03CR) 10jenkins-bot: [V: 04-1] WIP: Flow output refactoring. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95583 (owner: 10Werdna) [06:24:38] (03CR) 10Aude: "okay, lego is not changing the current behaviour. I still think "usurping" the talk page link is not cool" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [06:24:52] me too :) [06:52:48] (03PS7) 10Aude: Link "You have new messages" to user talk diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 [06:53:01] (03CR) 10jenkins-bot: [V: 04-1] Link "You have new messages" to user talk diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 (owner: 10Aude) [06:53:03] legoktm: that's how i'd like it to work, though w/o js [06:53:05] gah [06:53:18] * legoktm clicks [06:53:43] too many var statements.... [06:54:51] hmmmmm [06:55:11] i'm sure there was some design decision [06:55:17] no idea where/why/how/what [06:55:39] (03PS8) 10Aude: Link "You have new messages" to user talk diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 [06:55:41] yeah [06:55:41] im not sure [06:55:41] i sent an email to Fabrice, but he's on vacation until the end of the week [06:55:59] it's weird to have the talk link disappear [06:56:04] it's been there forever [06:56:08] well, technically it's still there [06:56:11] just has different text [06:56:17] it used to say 'Talk: You have new messages' [06:56:17] well, then no diff :) [06:56:26] good to have both [06:56:35] but that was awkward, so we dropped the 'Talk: ' [06:56:55] no colon [06:57:02] that is awkward [06:57:24] * aude can always make this be a gadget but think it should be default behaviour [07:17:07] csteipp_afk: https://bugzilla.wikimedia.org/show_bug.cgi?id=57081 [07:25:46] (03PS1) 10Aaron Schulz: Changed use of tag_summary to use change_tag with GROUP_CONCAT() [core] - 10https://gerrit.wikimedia.org/r/95584 [07:26:09] (03PS2) 10Aaron Schulz: Changed use of tag_summary to use change_tag with GROUP_CONCAT() [core] - 10https://gerrit.wikimedia.org/r/95584 [07:31:26] (03PS3) 10Aaron Schulz: Changed use of tag_summary to use change_tag with GROUP_CONCAT() [core] - 10https://gerrit.wikimedia.org/r/95584 [07:45:50] Error: 42P01 ERROR: relation "archive_ar_id_seq" does not exist [07:45:58] so much for postgres and update.php [08:36:07] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [08:52:31] (03PS2) 10Matthias Mullie: Consistent behavior of actions on topics and posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95439 [08:53:19] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95439 (owner: 10Matthias Mullie) [09:38:22] hi all [09:38:35] common.js automatically includes javascript in the page? [09:38:35] ? [09:38:48] how javascript works in MW? [09:52:58] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95566 (owner: 10Spage) [10:03:32] (03PS2) 10IAlex: Enhance the destination control parameter of wfDebug() and wfDebugLog() [core] - 10https://gerrit.wikimedia.org/r/95356 [10:04:24] (03CR) 10IAlex: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [10:36:47] (03PS1) 10Shirayuki: Fix "flow-rev-message-deleted-topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95589 [10:37:56] (03PS1) 10Hashar: readme: fix MEDIAWIKI_USER blockstyle [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95590 [10:38:07] (03CR) 10Hashar: [C: 032] readme: fix MEDIAWIKI_USER blockstyle [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95590 (owner: 10Hashar) [10:58:53] (03CR) 10Zfilipin: [C: 032] readme: fix MEDIAWIKI_USER blockstyle [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95590 (owner: 10Hashar) [11:03:11] (03PS1) 10Zfilipin: Markdown requires four spaces to properly format a block of text as code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95591 [12:21:17] (03PS8) 10Dan-nl: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [12:26:08] (03CR) 10Dan-nl: "ps8 address irc chat concerns aaron had in ps7." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [12:38:53] (03PS1) 10Mattflaschen: Change id to add mwe-upwiz prefix and match casing style [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/95594 [12:39:55] (03CR) 10Mattflaschen: "Tested locally. There do not appear to be any accompanying CSS rules." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/95594 (owner: 10Mattflaschen) [12:47:35] (03CR) 10TMg: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [13:08:55] (03CR) 10Gergő Tisza: [C: 031] filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [13:42:21] (03CR) 10Deskana: [C: 031] Show notification on search page if configured [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [13:44:34] (03PS1) 10Matthias Mullie: Allow title to be passed to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 [13:46:09] (03CR) 10MZMcBride: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [13:51:50] (03CR) 10Manybubbles: [C: 04-1] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [13:55:02] (03CR) 10Nemo bis: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [14:02:18] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [14:04:58] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [14:09:21] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [14:12:00] (03PS2) 10Manybubbles: Show notification on search page if configured [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 [14:12:54] (03PS2) 10Liangent: Implement LanguageConverter for yue (Cantonese) [core] - 10https://gerrit.wikimedia.org/r/78504 [14:13:04] (03CR) 10MZMcBride: "Patch set 2 looks better. Thanks. :-)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [14:13:33] (03CR) 10jenkins-bot: [V: 04-1] (bug 57106) Implement LanguageConverter for yue (Cantonese) [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [14:17:42] (03PS3) 10Manybubbles: Show notification on search page if configured [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 [14:20:55] (03PS3) 10Liangent: (bug 57106) Implement LanguageConverter for yue (Cantonese) [core] - 10https://gerrit.wikimedia.org/r/78504 [14:22:01] (03PS1) 10Matthias Mullie: Parsoid config for Flow can be different than VE, but VE is fallback [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95605 [14:22:56] (03CR) 10Liangent: "Message changes have been excluded from this patch to avoid conflicts in the future." [core] - 10https://gerrit.wikimedia.org/r/78504 (owner: 10Liangent) [14:33:30] (03PS1) 10Addshore: General Cleanup of some Tests [core] - 10https://gerrit.wikimedia.org/r/95606 [14:58:36] (03PS1) 10Anomie: Skip Special:CentralAutoLogin/start for JS anons [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 [15:13:09] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/95610 [15:13:27] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95611 [15:13:47] (03PS1) 10Daniel Kinzler: Make sure we alwas restore the error handler. [core] - 10https://gerrit.wikimedia.org/r/95612 [15:14:18] (03PS1) 10Pigpen: Removed legacy extension 'BlockButton' [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95613 [15:14:19] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95614 [15:24:52] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95615 [15:25:27] (03PS1) 10Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95616 [15:31:31] (03CR) 10Addshore: [C: 04-1] "Needs to be changed in zuul-config first as far as I know." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95616 (owner: 10Jeroen De Dauw) [15:33:05] (03PS1) 10Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95617 [15:33:15] (03CR) 10Jeroen De Dauw: "https://gerrit.wikimedia.org/r/95617" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95616 (owner: 10Jeroen De Dauw) [15:33:58] (03Abandoned) 10Jeroen De Dauw: Do not run tests for Wikibase Query and QueryEngine [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [15:35:30] (03Abandoned) 10Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95617 (owner: 10Jeroen De Dauw) [15:35:32] (03Restored) 10Jeroen De Dauw: Do not run tests for Wikibase Query and QueryEngine [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [15:36:09] (03CR) 10Jeroen De Dauw: "Hashar, can you have a look at this? This blocks development." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [15:40:18] (03CR) 10Gergő Tisza: "Aude pointed out that we are working on the same thing; I added moment.js to MediaViewer in I332655778be3d694781b83fa5dea1e59770d8866" [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [15:42:49] (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/95618 [15:43:23] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/95618 (owner: 10Pigpen) [15:43:46] (03Abandoned) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/95610 (owner: 10Pigpen) [15:44:08] (03PS1) 10Matthias Mullie: Insert new revision when Flow is taking over [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95619 [15:44:14] (03Abandoned) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95611 (owner: 10Pigpen) [15:44:38] (03CR) 10Pigpen: [C: 032 V: 032] Removed legacy extension 'BlockButton' [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95613 (owner: 10Pigpen) [15:44:40] (03PS1) 10Addshore: Cleanup and expand Status tests [core] - 10https://gerrit.wikimedia.org/r/95620 [15:45:13] (03Abandoned) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95614 (owner: 10Pigpen) [15:45:28] (03Abandoned) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95615 (owner: 10Pigpen) [15:49:55] (03PS1) 10Pigpen: Conflicts: config.template/safemode-settings.php includes/AutoLoader.php includes/CommonAJAXInterface.php includes/Core.class.php includes/SpecialPage.class.php includes/html/htmlformfields/HTMLMultiSelectEx.php includes/html/htmlformfields/HTMLMul [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95622 [15:50:39] (03CR) 10Pigpen: [C: 032 V: 032] Conflicts: config.template/safemode-settings.php includes/AutoLoader.php includes/CommonAJAXInterface.php includes/Core.class.php inclu [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95622 (owner: 10Pigpen) [15:52:06] (03CR) 10Addshore: [C: 031] Make sure we alwas restore the error handler. [core] - 10https://gerrit.wikimedia.org/r/95612 (owner: 10Daniel Kinzler) [15:57:07] (03PS2) 10Matthias Mullie: Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 [15:57:36] * the_codebot  [15:58:01] (03CR) 10Gergő Tisza: [C: 031] API: Allow filtering keys in iiprop=extmetadata [core] - 10https://gerrit.wikimedia.org/r/95472 (owner: 10Anomie) [16:00:44] (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95623 [16:01:03] (03CR) 10Pigpen: [C: 032 V: 032] Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/95623 (owner: 10Pigpen) [16:11:27] (03CR) 10Zsaigol: [C: 031] "I've now had a look at the issues with the CentralAuth extension. This change shouldn't "break" Special:GlobalUsers, but as Hoo man says, " [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [16:21:05] (03PS1) 10Anomie: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 [16:27:48] (03CR) 10Matthias Mullie: "I'm not sure what to do with this one :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 (owner: 10EBernhardson) [16:36:51] (03CR) 10Jhall: [C: 031 V: 031] Markdown requires four spaces to properly format a block of text as code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95591 (owner: 10Zfilipin) [16:39:38] (03CR) 10Anomie: [C: 031] "Seems good to me. Of WMF-deployed extensions, only SemanticMediaWiki would be broken by this, for which I see on Ice1e304c that the approp" [core] - 10https://gerrit.wikimedia.org/r/95519 (owner: 10Aaron Schulz) [16:40:53] (03CR) 10Anomie: [C: 04-1] "Procedural -1 until either bug 10788 is fixed or it's determined that the filesort until then isn't a concern." [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [16:42:30] (03CR) 10Matthias Mullie: [C: 032] Fix "flow-rev-message-deleted-topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95589 (owner: 10Shirayuki) [16:42:39] (03Merged) 10jenkins-bot: Fix "flow-rev-message-deleted-topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95589 (owner: 10Shirayuki) [16:53:50] (03PS3) 10Matthias Mullie: Pass title to Parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 [16:54:59] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92504 (owner: 10Matthias Mullie) [16:57:35] (03PS2) 10Aude: Make sure we alwas restore the error handler. [core] - 10https://gerrit.wikimedia.org/r/95612 (owner: 10Daniel Kinzler) [16:58:13] (03CR) 10Addshore: [C: 031] Make sure we always restore the error handler. [core] - 10https://gerrit.wikimedia.org/r/95612 (owner: 10Daniel Kinzler) [17:00:11] (03PS2) 10Matthias Mullie: Give extensions a chance to hide their (unrelated) log entries [core] - 10https://gerrit.wikimedia.org/r/92504 [17:03:13] (03PS1) 10Odder: (bug 54951) Add Malayalam aliases for 828 and 829 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/95637 [17:06:36] (03PS2) 10Anomie: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 [17:06:38] (03PS6) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [17:10:56] Reedy: could you upload a tarball for me? https://rt.wikimedia.org/Ticket/Display.html?id=6316 [17:11:03] Nope [17:11:07] I still don't have access [17:11:17] oh, thought you did [17:11:27] Not unless I've been given it and not told... [17:11:41] (03CR) 10Mattflaschen: "What do you mean regarding "the forwarded port seemed to be broken"? The standard 8080->80 forwarding works for me (on a slightly old ver" [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [17:11:46] apergos: ? https://rt.wikimedia.org/Ticket/Display.html?id=6316 [17:12:08] apergos: forgot your nick or I would have asked long ago :P [17:12:19] (03CR) 10Anomie: [C: 032] "Looks sensible, and shouldn't make bug 53577 any worse when used normally. Don't forget to create [[mw:Manual:Hooks/Article::MissingArticl" [core] - 10https://gerrit.wikimedia.org/r/92504 (owner: 10Matthias Mullie) [17:13:25] Tpt_, please send me your gmail address [17:14:18] (03CR) 10Mattflaschen: [C: 031] "Willing to merge, giving the others a chance to look." [vagrant] - 10https://gerrit.wikimedia.org/r/95470 (owner: 10Adamw) [17:14:35] gonna have to wait, I'm trying to finish up soething before a meeting in 15' [17:14:46] ( hexmode [17:14:47] ) [17:15:25] (03Merged) 10jenkins-bot: Give extensions a chance to hide their (unrelated) log entries [core] - 10https://gerrit.wikimedia.org/r/92504 (owner: 10Matthias Mullie) [17:15:43] apergos: k, thx. I just wanted it before the w/e if possible. [17:19:20] (03PS1) 10Matthias Mullie: Move new hook release note to correct release notes file [core] - 10https://gerrit.wikimedia.org/r/95640 [17:19:35] you might be better off getting someone in a better tz (it will already be well into my evening and I think I will have post-meeting followup for tonight unfortunately) [17:21:55] (03CR) 10GWicke: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [17:22:35] apergos: ty, I'm checking... [17:22:52] (03CR) 10Anomie: [C: 032] "Ugh, I should have caught that." [core] - 10https://gerrit.wikimedia.org/r/95640 (owner: 10Matthias Mullie) [17:26:14] (03Merged) 10jenkins-bot: Move new hook release note to correct release notes file [core] - 10https://gerrit.wikimedia.org/r/95640 (owner: 10Matthias Mullie) [17:28:10] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [17:29:44] (03PS3) 10Brian Wolff: Prevent space before ellipsis when truncating [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [17:31:55] (03CR) 10Brian Wolff: "PS3: UltrasonicNXT was having some trouble getting unit tests to work locally, so I added some tests for him." [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [17:33:31] (03CR) 10Parent5446: [C: 04-1] "Can we at least have the Mssql and Oracle classes throw an exception, rather than waiting for the inevitable DB query error?" [core] - 10https://gerrit.wikimedia.org/r/95584 (owner: 10Aaron Schulz) [17:35:58] (03CR) 10MaxSem: [C: 032] API: Allow filtering keys in iiprop=extmetadata [core] - 10https://gerrit.wikimedia.org/r/95472 (owner: 10Anomie) [17:39:01] (03Merged) 10jenkins-bot: API: Allow filtering keys in iiprop=extmetadata [core] - 10https://gerrit.wikimedia.org/r/95472 (owner: 10Anomie) [17:39:14] (03CR) 10EBernhardson: [C: 04-1] "This is reasonable at the surface, but doesn't work for other api calls that perform block actions. Apparently $wgTitle there is just 'AP" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95599 (owner: 10Matthias Mullie) [17:50:06] (03PS3) 10Chad: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95381 (owner: 10Siebrand) [17:50:11] (03CR) 10Chad: [C: 032] Fix CodeSniffer errors and warnings on some API classes [core] - 10https://gerrit.wikimedia.org/r/95381 (owner: 10Siebrand) [17:51:37] (03CR) 10Chad: [C: 032] Update docs for files in includes/actions/ [core] - 10https://gerrit.wikimedia.org/r/95354 (owner: 10Siebrand) [17:51:45] (03CR) 10Chad: [C: 032] Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 (owner: 10Siebrand) [17:52:28] (03CR) 10Ori.livneh: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [17:52:40] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [17:52:58] (03PS2) 10Chad: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95382 (owner: 10Siebrand) [17:53:13] (03PS3) 10Chad: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95382 (owner: 10Siebrand) [17:53:18] (03CR) 10Chad: [C: 032] Fix CodeSniffer errors and warnings on yet more API classes [core] - 10https://gerrit.wikimedia.org/r/95382 (owner: 10Siebrand) [17:53:37] (03CR) 10Ori.livneh: [C: 031] "Fine by me." [vagrant] - 10https://gerrit.wikimedia.org/r/95470 (owner: 10Adamw) [17:54:50] (03CR) 10GWicke: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [17:55:25] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings on some API classes [core] - 10https://gerrit.wikimedia.org/r/95381 (owner: 10Siebrand) [17:56:29] (03CR) 10Krinkle: "I think this is a perfect case where we don't want to reinvent the wheel but instead improve upstream. I have a pretty good feeling about " [core] - 10https://gerrit.wikimedia.org/r/95555 (owner: 10Krinkle) [17:56:59] (03CR) 10GWicke: "Oh, and since you are POSTing: You can pass the 'body' flag to just retrieve the body contents instead of a full document from Parsoid. Mi" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [17:57:23] (03Merged) 10jenkins-bot: Update docs for files in includes/actions/ [core] - 10https://gerrit.wikimedia.org/r/95354 (owner: 10Siebrand) [17:58:31] (03PS1) 10Mwalker: WIP Node.JS Renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 [17:59:17] (03Merged) 10jenkins-bot: Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 (owner: 10Siebrand) [18:01:49] (03Merged) 10jenkins-bot: resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [18:05:51] hey Krinkle, re: your comment on https://gerrit.wikimedia.org/r/#/c/92450/2/resources/mediawiki/mediawiki.js, isn't that taken care of by the ( values || {} ) on line 81? [18:06:22] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings on yet more API classes [core] - 10https://gerrit.wikimedia.org/r/95382 (owner: 10Siebrand) [18:08:12] (03PS2) 10Chad: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95383 (owner: 10Siebrand) [18:08:15] (03PS3) 10Chad: Fix CodeSniffer errors and warnings (you guessed it, on API classes) [core] - 10https://gerrit.wikimedia.org/r/95383 (owner: 10Siebrand) [18:08:19] (03CR) 10Chad: [C: 032] Fix CodeSniffer errors and warnings (you guessed it, on API classes) [core] - 10https://gerrit.wikimedia.org/r/95383 (owner: 10Siebrand) [18:08:49] (03PS2) 10Chad: Declare visibility on class property [core] - 10https://gerrit.wikimedia.org/r/95384 (owner: 10Siebrand) [18:08:53] (03PS3) 10Chad: Declare visibility on class property in ApiQueryInfo [core] - 10https://gerrit.wikimedia.org/r/95384 (owner: 10Siebrand) [18:08:58] (03CR) 10Chad: [C: 032] Declare visibility on class property in ApiQueryInfo [core] - 10https://gerrit.wikimedia.org/r/95384 (owner: 10Siebrand) [18:10:19] (03PS2) 10Chad: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95438 (owner: 10Siebrand) [18:12:28] ori-l: Hm.. well, it's less of an issue that I originally suspected, but I couldn't explained it better. [18:12:32] (03CR) 10jenkins-bot: [V: 04-1] Fix CodeSniffer errors and warnings (you guessed it, on API classes) [core] - 10https://gerrit.wikimedia.org/r/95383 (owner: 10Siebrand) [18:12:32] ori-l: false vs. "false" [18:12:49] ori-l: undefined or false would be covered by that, but a truethy non-object value like "foo" or whatever. [18:13:01] >> var a = "foo"; a.x = 123; a.x; [18:13:01] Krinkle: undefined [18:13:06] no error [18:13:15] but no-op [18:13:20] right. I don't mind amending, but it seems to go beyond the kind of typechecking we usually do [18:13:48] the informal principle we seem to take (which seems like a good one) is to type-check against errors that are easy to make [18:16:26] (03CR) 10jenkins-bot: [V: 04-1] Declare visibility on class property in ApiQueryInfo [core] - 10https://gerrit.wikimedia.org/r/95384 (owner: 10Siebrand) [18:16:58] (03PS3) 10Addshore: Split Api Module into lovely small functions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/93316 [18:18:01] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings (you guessed it, on API classes) [core] - 10https://gerrit.wikimedia.org/r/95383 (owner: 10Siebrand) [18:19:18] If anybody here has an idea for a small code/qa/outreach/... task for a highschool student that s/he could mentor, please check out https://www.mediawiki.org/wiki/Google_Code-In#Mentors.27_corner [18:19:21] We still need 15 more tasks until Monday. [18:20:59] (03CR) 10Parent5446: [C: 032] Make sure we always restore the error handler. [core] - 10https://gerrit.wikimedia.org/r/95612 (owner: 10Daniel Kinzler) [18:22:39] (03CR) 10jenkins-bot: [V: 04-1] Fix a few more CodeSniffer errors and warnings on some API classes [core] - 10https://gerrit.wikimedia.org/r/95438 (owner: 10Siebrand) [18:22:44] (03Merged) 10jenkins-bot: Declare visibility on class property in ApiQueryInfo [core] - 10https://gerrit.wikimedia.org/r/95384 (owner: 10Siebrand) [18:29:44] (03Merged) 10jenkins-bot: Make sure we always restore the error handler. [core] - 10https://gerrit.wikimedia.org/r/95612 (owner: 10Daniel Kinzler) [18:31:19] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [18:31:41] (03CR) 10Aaron Schulz: "I don't really care about those classes since all stuff is not really maintained any, but it could be done that way." [core] - 10https://gerrit.wikimedia.org/r/95584 (owner: 10Aaron Schulz) [18:34:11] (03PS2) 10Chad: Fix CodeSniffer errors and warnings (final round for API classes) [core] - 10https://gerrit.wikimedia.org/r/95456 (owner: 10Siebrand) [18:34:12] (03PS2) 10Chad: Fix CodeSniffer errors and warnings on a number of ApiQuery classes [core] - 10https://gerrit.wikimedia.org/r/95455 (owner: 10Siebrand) [18:34:12] (03PS3) 10Chad: Fix a few more CodeSniffer errors and warnings on some API classes [core] - 10https://gerrit.wikimedia.org/r/95438 (owner: 10Siebrand) [18:34:32] (03CR) 10Chad: [C: 032] Fix a few more CodeSniffer errors and warnings on some API classes [core] - 10https://gerrit.wikimedia.org/r/95438 (owner: 10Siebrand) [18:35:19] (03CR) 10Chad: [C: 032] Fix CodeSniffer errors and warnings on a number of ApiQuery classes [core] - 10https://gerrit.wikimedia.org/r/95455 (owner: 10Siebrand) [18:36:39] (03PS1) 10Addshore: Add basic unit test for dieOnBadUser api method [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95647 [18:37:32] (03CR) 10Chad: [C: 032] Fix CodeSniffer errors and warnings (final round for API classes) [core] - 10https://gerrit.wikimedia.org/r/95456 (owner: 10Siebrand) [18:37:33] (03CR) 10Parent5446: [C: 04-1] "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [18:38:28] (03CR) 10Parent5446: "Ideally we should just remove them entirely. Honestly the only change would be to override the groupConcat method and throw a MWException " [core] - 10https://gerrit.wikimedia.org/r/95584 (owner: 10Aaron Schulz) [18:39:23] (03CR) 10Physikerwelt: "Hasahar, thank you for your feedback. You were the only who commented on that, even though I asked several times at the Bugzilla ticket:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [18:40:21] (03CR) 10Physikerwelt: "sorry for the typos... @Hashar" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [18:42:50] (03Merged) 10jenkins-bot: Fix a few more CodeSniffer errors and warnings on some API classes [core] - 10https://gerrit.wikimedia.org/r/95438 (owner: 10Siebrand) [18:44:43] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings on a number of ApiQuery classes [core] - 10https://gerrit.wikimedia.org/r/95455 (owner: 10Siebrand) [18:45:18] (03PS4) 10Aaron Schulz: Changed use of tag_summary to use change_tag with GROUP_CONCAT() [core] - 10https://gerrit.wikimedia.org/r/95584 [18:46:20] (03Merged) 10jenkins-bot: Fix CodeSniffer errors and warnings (final round for API classes) [core] - 10https://gerrit.wikimedia.org/r/95456 (owner: 10Siebrand) [18:49:42] (03PS1) 10Addshore: General Cleanup [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95650 [18:52:57] (03PS1) 10Chad: Remove unsupported and mostly non-functional Mssql support [core] - 10https://gerrit.wikimedia.org/r/95651 [18:53:04] <^d> AaronSchulz: Better solution than adding missing mssql support to your patch ^ [18:53:22] wasn't that removed before? [18:53:25] <^d> Yes. [18:53:26] * AaronSchulz feels deja vu [18:53:29] <^d> And then someone added it again. [18:55:08] <^d> Considering the new installer's never supported mssql, I doubt anyone's using it these days. [18:55:49] (03PS2) 10Addshore: General Cleanup [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95650 [18:59:53] (03PS2) 10Chad: Remove unsupported and mostly non-functional Mssql support [core] - 10https://gerrit.wikimedia.org/r/95651 [19:02:17] (03CR) 10Chad: [C: 032] Remove unsupported and mostly non-functional Mssql support [core] - 10https://gerrit.wikimedia.org/r/95651 (owner: 10Chad) [19:05:14] (03Merged) 10jenkins-bot: Remove unsupported and mostly non-functional Mssql support [core] - 10https://gerrit.wikimedia.org/r/95651 (owner: 10Chad) [19:05:22] (03PS1) 10Addshore: Add job for SideBarMenu [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95653 [19:09:19] (03PS1) 10Addshore: Add zuul trigger for SideBarMenu [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 [19:10:16] (03CR) 10Addshore: "Added jenkins job in https://gerrit.wikimedia.org/r/#/c/95653/ and https://gerrit.wikimedia.org/r/#/c/95654/" [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95650 (owner: 10Addshore) [19:11:00] (03CR) 10Dzahn: [C: 032] Sync our custom index.css with upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91792 (owner: 10Aklapper) [19:11:13] (03CR) 10Dzahn: [V: 032] Sync our custom index.css with upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91792 (owner: 10Aklapper) [19:12:53] (03PS2) 10Brian Wolff: Purge user css/js. [core] - 10https://gerrit.wikimedia.org/r/95095 [19:14:37] (03CR) 10Brian Wolff: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [19:15:25] (03CR) 10Dzahn: [C: 032 V: 032] Clean up custom show_bug.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91801 (owner: 10Aklapper) [19:16:54] (03PS1) 10Addshore: Fix SideBarMenu unit tests [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/95655 [19:17:33] (03CR) 10Addshore: "It appears tests will / should fail unless https://gerrit.wikimedia.org/r/#/c/95655/ is merged" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [19:17:38] notice any CSS changes at all in show_bug on Bugzilla ? we just removed all this but it shouldn't have any effect https://gerrit.wikimedia.org/r/#/c/91801/1/skins/contrib/Wikimedia/show_bug.css [19:17:46] (falls back to identical default) [19:20:28] @notify andre__ [19:20:28] I'll let you know when I see andre__ around here [19:20:44] qgil: you there? [19:21:51] i need somebody who can access https://google-melange.appspot.com/gci/task/view/google/gci2013/5866739032129536 (a GCI mentor) to test something for me [19:23:28] o hi andre__, i was just looking for you [19:23:42] andre__: is the "bug report" link on https://google-melange.appspot.com/gci/task/view/google/gci2013/5866739032129536 working for you? [19:29:44] MatmaRex, no shall I fix it? :) [19:30:20] andre__: well, i guess you could :P and the same applies to pretty much all such links on all tasks [19:30:31] MatmaRex, please try again now :) [19:30:34] so it'd be nice if there was some automated way [19:30:49] all the links have an additional " at the end :/ [19:30:56] (03PS5) 10Aaron Schulz: Changed use of tag_summary to use change_tag with GROUP_CONCAT() [core] - 10https://gerrit.wikimedia.org/r/95584 [19:30:56] urgh. I hate Google's CSV importer, it's so buggy [19:30:59] yeah, it's good now, thanks [19:31:11] basically I edited the HTML of those tasks :-/ [19:31:48] MatmaRex, I'll check the URLs now [19:33:26] andre__: (also, you've got mail) [19:42:42] (03PS4) 10Brian Wolff: Make generating Parser test class names more robust [core] - 10https://gerrit.wikimedia.org/r/67098 [19:43:26] lo [19:43:49] (03PS3) 10Anomie: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 [19:45:00] (03CR) 10Anomie: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [19:45:12] (03CR) 10Brian Wolff: "PS4: rebase" [core] - 10https://gerrit.wikimedia.org/r/67098 (owner: 10Brian Wolff) [19:45:13] (03CR) 10Anomie: [C: 04-1] "Procedural -1 until either bug 10788 is fixed or it's determined that the filesort until then isn't a concern." [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [19:48:53] (03CR) 10Hashar: "Sam, is that still needed?" [tools/release] - 10https://gerrit.wikimedia.org/r/70648 (owner: 10Reedy) [19:52:26] (03PS6) 10Daniel Kinzler: Detect leakage of error_reporting state in tests. [core] - 10https://gerrit.wikimedia.org/r/74170 [19:52:51] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 as per Krinkle" [core] - 10https://gerrit.wikimedia.org/r/74170 (owner: 10Daniel Kinzler) [19:53:23] (03CR) 10Mattflaschen: [C: 032] Use recursive git clone [vagrant] - 10https://gerrit.wikimedia.org/r/95470 (owner: 10Adamw) [19:53:29] (03Merged) 10jenkins-bot: Use recursive git clone [vagrant] - 10https://gerrit.wikimedia.org/r/95470 (owner: 10Adamw) [19:55:03] (03PS4) 10Aaron Schulz: API: Add prop=contributors [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [19:55:09] reading from design-l "it became clear he/she hadn't realised the hamburger icon was clickable" [19:55:17] What is the "hamburger icon"? [19:55:29] bawolff: three differently-colored horizontal stripes [19:55:33] (not kidding) [19:55:38] that's the dumbest name for anything ever. [19:55:52] And this is supposed to tell me to what, eat my phone :P [19:56:08] * bawolff goes finds his phone to figure out what this is in reference to [19:56:13] bawolff: actually, not even differently colored in our implementation [19:56:19] bawolff: https://en.m.wikipedia.org/w/index.php?title=Democratic_globalization&title=Democratic_globalization top-left [19:56:43] oh that [19:56:58] agreed on stupidest name ever [19:58:00] * bawolff doesn't actually like the mobile interface that much [19:58:19] I find I end up manually typing into the url bar, more often then actually clicking on the icons [19:58:28] which is a really bad sign for any interface [19:58:42] * MatmaRex doesn't like MobileFrontend in general [19:58:48] hey AaronSchulz did you have a chance to look at the patch set i uploaded earlier today? https://gerrit.wikimedia.org/r/#/c/94748/ [19:58:49] they reimplemented watchlist, badly :( [19:59:14] As far as I can tell, there's no link to talk pages [19:59:19] or history page [19:59:30] How can you possibly browse/edit a wiki without those [20:00:22] bawolff: the icons at the top do some things [20:00:33] * MatmaRex hates label-less icons with passion [20:00:51] I have an icon for edit page, add a picture, and watch [20:00:52] and "Last edited 6 months ago" links to history. [20:00:59] D: [20:01:14] That's pretty unintuitive [20:01:19] "pretty" [20:01:31] eh, those young whipper-snappers and their newfangled icony interfaces [20:01:35] time to die. [20:02:35] And then there's the whole red links just randomly turn into non-linked text, which is rather confusing [20:02:46] (03CR) 10CSteipp: [C: 031] "Looks ok as is. Having an error thrown on invalid email would be nice, but I think it's fine to do later too." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 (owner: 10Wikinaut) [20:03:30] * ^d longs for the old days [20:03:35] <^d> Before the dark times. [20:03:47] <^d> Before people decided to make MediaWiki pretty :) [20:10:27] (03PS1) 10Addshore: Remove duplicate AnitSpoof extension entry [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95660 [20:16:01] (03Merged) 10jenkins-bot: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [20:18:33] AaronSchulz: thanks [20:19:47] dan-nl: still not quite sure why the container name is configurable, though I guess it doesn't hurt [20:20:30] (03CR) 10Umherirrender: API: Add prop=contributors (033 comments) [core] - 10https://gerrit.wikimedia.org/r/95633 (owner: 10Anomie) [20:20:57] AaronSchulz: https://gerrit.wikimedia.org/r/#/c/94960/ depends on the change set just merged, but was based on an earlier version, does it just need to be rebased against master in order to merge or rebased against the filebackend change set? [20:21:51] (03PS1) 10Jack Phoenix: Updated README to use HTTPS instead of HTTP. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95663 [20:22:19] (03CR) 10Jack Phoenix: [C: 032] Updated README to use HTTPS instead of HTTP. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95663 (owner: 10Jack Phoenix) [20:22:27] (03Merged) 10jenkins-bot: Updated README to use HTTPS instead of HTTP. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95663 (owner: 10Jack Phoenix) [20:23:03] AaronSchulz: do you mean on line 342 of GWTFileBackend.php $this->_container = Filter::evaluate( $params['container'] ); ? [20:23:50] i couldn't figure out how to pull the container name from the FileBackend instance … if there's a way to do that then that param doesn't need to be passed in [20:24:17] if patch A depends on A' and A' changes or is merged, you can just use the "rebase" button [20:25:02] dan-nl: you supply the name when you do things with paths, so you could just always use 'gwtoolset-metadata' [20:25:26] it's nice when names have a format of - for consistency and wmf config reasons [20:25:42] that would do...of course if it is configurable one could just pick that value [20:27:26] bawolff, hmm, on mobile view, it seems that redlinks only disappear if you're not logged in. Still confusing (and debatable), but slightly logical. [20:27:45] quiddity: it's a beta feature, or something of that sort, IIRC [20:27:45] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [20:28:07] YuviPanda, stop typing! rest your wrists! and go study! [20:28:13] quiddity: Hmm, I thought they were not present when I was logged in [20:28:19] grrrit-wm: What the hell man [20:28:22] quiddity: I know, I know. addicted [20:28:31] my concern is that getHashPath() needs the container name in order to work and if the class is not aware of the container name then it won't work. so if a web admin happens to create a FileBackend with something besides gwtoolset-metadata as the container then there's an issue … also i'm thinking of using another container in the future. in the end passing in the container name makes the class more dynamic … are you ok with that? [20:29:06] bawolff: i think you need to opt in to beta for that [20:29:14] quiddity: just one patch, then I'll go away! [20:29:24] sure sure [20:29:37] * bawolff calls that weird... :P [20:29:52] did i miss something interesting? :D [20:30:36] MatmaRex: people finding mobile a little weird. [20:30:58] bd808|MEETING: do you happen to know if i need to rebase https://gerrit.wikimedia.org/r/#/c/94960/ against master or filebackend in order for it to update so that it can merge? [20:31:02] YuviPanda: ah, so day like every day. [20:31:06] heh [20:32:16] (03PS5) 10BryanDavis: lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [20:32:17] ahh, yes, I opted into mobile beta recently. I'd forgotten about that. https://en.m.wikipedia.org/w/index.php?title=Special:MobileOptions [20:32:41] dan-nl: yeah you do [20:32:48] (03PS2) 10Mwalker: WIP Node.JS Renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 [20:33:02] you should rebase it against master since the filebackend patch is merged [20:33:22] grrrit-wm: weirdness due to marktraceur adding a nice feature to it, so patience to everyone else! :) [20:33:47] bawolff: against master or against its depends on change set filebackend ... [20:33:57] looks like bd808|MEETING took care of it [20:34:00] it might be easier if you do git rebase -i, and tell git rebase to ditch the patch it depends on which is now merged [20:34:14] I just hit the "rebase" button :) [20:34:39] cool, i guess now it can be +2'd again to merge? [20:34:40] It shouldn't be *that* weird [20:37:06] 'kay, now the comment numbers are working. Actually. [20:37:57] (03CR) 10Wikinaut: [C: 032 V: 032] "ok. Merging now to get rid of it." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 (owner: 10Wikinaut) [20:38:02] (03CR) 10Brian Wolff: [C: 032] "Tested, looks good." [core] - 10https://gerrit.wikimedia.org/r/92251 (owner: 10Aude) [20:38:29] (03CR) 10Aaron Schulz: "I've tested this for all of mysql/sqlite/postgres (logging page query, history query)" [core] - 10https://gerrit.wikimedia.org/r/95584 (owner: 10Aaron Schulz) [20:38:47] (03PS10) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [20:38:57] hashar: So, now that I'm thinking about inline comments, I wonder if Jenkins/zuul could post comments to lines that are troublesome for various jobs... [20:39:14] Like "This line has a jshint failure: Too many var statements." [20:39:29] grmbl. where is andre__ again. [20:39:30] (03CR) 10GWicke: WIP Node.JS Renderer (031 comment) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95644 (owner: 10Mwalker) [20:39:30] @seen andre__ [20:39:30] MatmaRex: Last time I saw andre__ they were quitting the network with reason: Quit: Cheers & thanks for the fish. N/A at 11/15/2013 8:35:59 PM (3m31s ago) [20:39:32] "This line is the source of a fatal error: ..." [20:39:51] marktraceur: noo, hashar is busy setting up the automatic rebasing of release notes :( [20:39:57] (ain't you, hashar? :D) [20:39:58] Oh, that's fine then [20:40:04] But just thinking [20:40:17] (by which i mean, he probably already forgot about that :>) [20:40:37] unless Jenkins is dead or we plan to rewrite mediawiki in python, I am busy. sorry [20:40:50] 'kay :) [20:40:56] * marktraceur will keep dreaming [20:41:44] bd808|MEETING: thanks for the rebase, i guess now it can be +2'd again to merge? [20:42:09] hi MatmaRex [20:42:15] (03CR) 10BryanDavis: [C: 032] lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [20:42:34] hi qgil [20:42:47] qgil: i was going to bother you about GCI things, but andre came along :) [20:43:05] MatmaRex, sometimes itś good to be late. :) [20:43:07] qgil: i actually have more things to bother people about now, but they're mostly bugzilla-related [20:43:09] haha [20:43:55] MatmaRex, ok, I actually will be introducing my GCI tasks this afternoon, soon... [20:44:26] nice :) i'm going through some bugs myself right now too [20:46:26] dan-nl: I think it should be in master now [20:46:52] bd808|MEETING: thanks! that merged it [20:48:25] (03PS2) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 [20:48:51] AaronSchulz: i have been updating the ether pad, https://etherpad.wikimedia.org/p/GWToolsetReview, with tasks we've discussed in irc. i may not have gotten all of them please review and add/subtract to the m s c sections as you feel necessary [20:49:11] (03PS11) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [20:52:15] aaron, thanks [20:54:38] marktraceur: potentially we could have a post processing step that would read the phpcs / pep8 etc linting file and then report back in the inline diff. [20:54:49] StevenW: hi, who is Sam Smith? [20:54:57] marktraceur: no idea whether Gerrit as an easy to use API to post comments inline [20:55:07] MatmaRex: phuedx [20:55:10] csteipp GWToolset master is almost ready. there are a few additional items, i believe aaron, added to a m s c list in the ether pad. would it make sense for you to review master now taking into consideration the tasks currently outstanding in the ether pad? [20:55:29] or have you been reviewing all along? [20:56:26] dan-nl: I was waiting for it to be mostly done, otherwise I'll have to review it again [20:56:35] What's the etherpad? [20:56:42] (03PS1) 10Manybubbles: Allow users prefer articles with recent changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95697 [20:56:46] etherpad url that is? [20:56:53] csteipp: https://etherpad.wikimedia.org/p/GWToolsetReview [20:57:54] Cool. Have you finished the must task? [20:58:04] Or patch for it? [20:59:38] csteipp: haven't sorted the must task yet … do you want to wait until that's been uploaded as a patch? [21:00:27] (03PS2) 10Manybubbles: Allow users prefer articles with recent changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95697 [21:02:20] (03PS1) 10Bartosz Dziewoński: Links to mediawiki.org in messages should use HTTPS [core] - 10https://gerrit.wikimedia.org/r/95698 [21:03:29] a very quick db-performace related question: would making all new users watch their user and talk pages by default be bad? (https://bugzilla.wikimedia.org/show_bug.cgi?id=49719) [21:03:39] AaronSchulz? ^ [21:03:54] (03PS12) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [21:04:02] csteipp: i'll try and sort out the must task by the end of my day monday. will that work for you? [21:06:42] AaronSchulz: for the job queue size, what size should i check against? at what size should gwtoolset not add its media file jobs? [21:08:10] (03PS6) 10Hashar: make-release: initial tarball test script [tools/release] - 10https://gerrit.wikimedia.org/r/89158 [21:08:21] (03CR) 10Brian Wolff: [C: 04-1] "Per discussion on bug, this appears to be an issue with upload wizard not providing an interface to ignore warnings." [core] - 10https://gerrit.wikimedia.org/r/87020 (owner: 10Marco) [21:10:08] (03CR) 10Zfilipin: "Jeff, for future reference, you should never change values in "Verified" section when reviewing a commit. I am not sure why the section is" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95591 (owner: 10Zfilipin) [21:10:23] (03PS1) 10CSteipp: Include useoauth in UserIsEveryoneAllowed rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 [21:12:32] (03CR) 10Hashar: "This is a fairly large change. I eventually got too lazy to reply with all the issues so I have altered the code directly." [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [21:14:26] (03CR) 10Jhall: Markdown requires four spaces to properly format a block of text as code [qa/browsertests] - 10https://gerrit.wikimedia.org/r/95591 (owner: 10Zfilipin) [21:15:44] (03PS13) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [21:16:09] qgil: about GCI: do we use the "Time to complete" field in a meaningful way, or is it always "5 days"? [21:16:10] (03CR) 10Hashar: Misc fixes for build/test scripts (032 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/95575 (owner: 10MarkAHershberger) [21:17:59] (03CR) 10Anomie: [C: 031] "Slightly hacky in that it uses a magic key in the array that isn't the usual magic key ("*"), but it looks like it should work. Haven't te" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 (owner: 10CSteipp) [21:23:55] (03PS2) 10Hashar: Remove duplicate AnitSpoof extension entry [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95660 (owner: 10Addshore) [21:24:02] (03CR) 10Hashar: [C: 032] Remove duplicate AntiSpoof extension entry [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95660 (owner: 10Addshore) [21:24:34] (03Merged) 10jenkins-bot: Remove duplicate AntiSpoof extension entry [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95660 (owner: 10Addshore) [21:27:04] (03PS2) 10Hashar: Add job for SideBarMenu [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95653 (owner: 10Addshore) [21:27:19] (03CR) 10Hashar: [C: 032] Add job for SideBarMenu [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95653 (owner: 10Addshore) [21:27:54] (03Merged) 10jenkins-bot: Add job for SideBarMenu [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95653 (owner: 10Addshore) [21:29:43] (03Draft13) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [21:29:52] (03CR) 10Hashar: "Jobs deployed:" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95653 (owner: 10Addshore) [21:32:20] (03CR) 10Hashar: "I guess we want to wait for "upstream" to merge the changes you submitted." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95654 (owner: 10Addshore) [21:32:37] (03PS1) 10Bartosz Dziewoński: Fix TOC display for printing [core] - 10https://gerrit.wikimedia.org/r/95703 [21:33:16] (03PS1) 10Hashar: register MobileApp extension [extensions] - 10https://gerrit.wikimedia.org/r/95704 [21:33:28] (03CR) 10Hashar: [C: 032 V: 032] register MobileApp extension [extensions] - 10https://gerrit.wikimedia.org/r/95704 (owner: 10Hashar) [21:34:51] (03PS14) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [21:37:59] (03PS15) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [21:39:09] MatmaRex, no idea either. But I think I will default to 3 days. [21:39:33] MatmaRex, I *believe* it means the amount of time that a task will remain locked to a user without a resolution [21:39:45] MatmaRex, in order to avoi students blocking tasks forever? [21:40:55] (03CR) 10Wikinaut: [C: 031 V: 031] "A new version is (almost) ready." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [21:42:09] qgil: yeah, i know what it does (i was a GCI student once ;) ), it's just that apparently all of our tasks currently use 5 days at the time [21:42:19] and i'm not sure if it's intended or acidental or what [21:42:50] evil coincidence. That's my favourite scapegoat. [21:43:42] Do we have a script that does text file to page importing in bulk? So filename as Title, contents as page? [21:43:58] ImportTextFile.php does one at a time [21:44:02] xargs or something? [21:45:23] MatmaRex, that might just be andre exporting + others following. If you have a better number for your tasks, just use it [21:45:26] Small shell script + edit.php maybe ? [21:48:22] I'm sure this can be done as a one liner [21:48:57] (03CR) 10Bsitu: "I thought I had sent out an email to wikitech list about this change, somehow it's still sitting in my draft box, :(. I will send it out " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/84870 (owner: 10Bsitu) [21:52:14] (03PS2) 10Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95616 [21:52:16] (03PS2) 10Jeroen De Dauw: Do not run tests for Wikibase Query and QueryEngine [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 [21:53:15] (03PS3) 10Jeroen De Dauw: Remove Wikibase Query and QueryEngine [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95616 [21:55:57] (03CR) 10Aaron Schulz: "Then we should also grey out the check box on Special:OAuthConsumerRegistration/propose and make sure it also shows in consumer grants lis" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95701 (owner: 10CSteipp) [22:06:21] AaronSchulz: for the job queue size, what size should i check against? at what size should gwtoolset not add its media file jobs? [22:20:17] (03PS1) 10Adamw: Mediawiki can be checked out on a branch [vagrant] - 10https://gerrit.wikimedia.org/r/95715 [22:21:59] @notify TimStarling [22:21:59] I'll let you know when I see TimStarling around here [22:26:37] MatmaRex: won't be for ~2 days [22:26:45] tim isn't normally on during the weekend [22:27:41] aw, poop. :( [22:27:55] i want to ask someone about this: (asked here earlier too) [22:27:59] a very quick db-performace related question: would making all new users watch their user and talk pages by default be bad? (https://bugzilla.wikimedia.org/show_bug.cgi?id=49719) [22:28:11] brion: hi. you know, maybe? ^ [22:39:22] MatmaRex: take that as 'maybe'. [22:39:40] (03CR) 10MarkTraceur: [C: 032] "Thanks, Rillke! Helpful as ever. :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77491 (owner: 10Rillke) [22:39:47] (03Merged) 10jenkins-bot: Messages with links in it must be parsed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77491 (owner: 10Rillke) [22:47:45] (03CR) 10CSteipp: Skip Special:CentralAutoLogin/start for JS anons (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 (owner: 10Anomie) [22:49:55] (03PS2) 10Adamw: Prepare for name-based virtualhosting [vagrant] - 10https://gerrit.wikimedia.org/r/95471 [22:51:00] (03PS1) 10IAlex: Use the native set_chasert() method if available instead of SET NAMES [core] - 10https://gerrit.wikimedia.org/r/95717 [22:52:06] (03CR) 10jenkins-bot: [V: 04-1] Use the native set_chasert() method if available instead of SET NAMES [core] - 10https://gerrit.wikimedia.org/r/95717 (owner: 10IAlex) [22:52:28] (03PS1) 10Jdlrobson: Allow use of -c argument [tools/release] - 10https://gerrit.wikimedia.org/r/95718 [22:52:34] (03CR) 10Adamw: "@Mattflaschen: thanks for double-checking about the forwarded port. I've made sure it still works in the latest patchset." [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [22:52:39] (03CR) 10jenkins-bot: [V: 04-1] Allow use of -c argument [tools/release] - 10https://gerrit.wikimedia.org/r/95718 (owner: 10Jdlrobson) [22:54:05] (03PS2) 10Adamw: Mediawiki can be checked out on a branch [vagrant] - 10https://gerrit.wikimedia.org/r/95715 [22:55:15] (03PS2) 10Jdlrobson: Allow use of -c argument [tools/release] - 10https://gerrit.wikimedia.org/r/95718 [22:55:41] jdlrobson: ping re: changes? [22:57:38] (03PS2) 10IAlex: Use the native set_chasert() method if available instead of SET NAMES [core] - 10https://gerrit.wikimedia.org/r/95717 [23:14:37] ho ori-l, are you the right person to ask about database-related performance things? [23:14:43] hi ori-l. [23:14:47] "a very quick db-performace related question: would making all new users watch their user and talk pages by default be bad? (https://bugzilla.wikimedia.org/show_bug.cgi?id=49719)" [23:15:59] MatmaRex: hey [23:16:18] I don't know, off the top of my head [23:16:36] you can add the 'performance' keyword and I'll look into it [23:16:54] i want to make that a GCI task, if it's obvious, non-controversial and won't explode wikis [23:16:57] https://www.mediawiki.org/wiki/Google_Code-in [23:19:28] (03CR) 10Aaron Schulz: [C: 032] Remove recentchanges.rc_cur_time from sql statements [core] - 10https://gerrit.wikimedia.org/r/42278 (owner: 10Umherirrender) [23:19:56] (03CR) 10Krinkle: [C: 04-1] Skip Special:CentralAutoLogin/start for JS anons (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/95609 (owner: 10Anomie) [23:22:27] (03Merged) 10jenkins-bot: Remove recentchanges.rc_cur_time from sql statements [core] - 10https://gerrit.wikimedia.org/r/42278 (owner: 10Umherirrender) [23:24:11] (03PS1) 10Jdlrobson: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 [23:24:16] (03CR) 10jenkins-bot: [V: 04-1] Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 (owner: 10Jdlrobson) [23:25:20] (03PS2) 10Jdlrobson: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 [23:28:25] ^d: https://gerrit.wikimedia.org/r/#/c/95519/ [23:29:57] (03CR) 10Chad: [C: 032] Avoid extra parsing in prepareContentForEdit() [core] - 10https://gerrit.wikimedia.org/r/95519 (owner: 10Aaron Schulz) [23:32:59] (03Merged) 10jenkins-bot: Avoid extra parsing in prepareContentForEdit() [core] - 10https://gerrit.wikimedia.org/r/95519 (owner: 10Aaron Schulz) [23:34:44] (03CR) 10Krinkle: "minor enhancement suggestions" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86265 (owner: 10Anomie) [23:36:49] (03CR) 10Gergő Tisza: "I plan to add ForeignAPIFile support later. At the moment this is only used for CommonsMetadata, which already works with ForeignAPIFile v" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [23:37:56] (03CR) 10Krinkle: Remove recentchanges.rc_cur_time from sql statements (031 comment) [core] - 10https://gerrit.wikimedia.org/r/42278 (owner: 10Umherirrender) [23:40:59] huh, grrrit-wm has gotten some new styles. [23:45:35] The "2 comments" coloring? [23:45:45] csteipp: funny force-options-on in HTMLForm seems to cause the option not NOT be set [23:46:14] Elsie: yes, and also providing the cover message when inline comments are present. [23:46:16] it didn't do that before. [23:49:25] (03CR) 10Chad: "I think this should be an unlisted special page since it's mainly there for developers and not the casual MW user." [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [23:49:26] (03PS3) 10Jdlrobson: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 [23:49:27] (03PS1) 10Jdlrobson: Link to dependencies, bugs and stories [tools/release] - 10https://gerrit.wikimedia.org/r/95732 [23:52:10] (03PS2) 10Jdlrobson: Link to dependencies, bugs and stories [tools/release] - 10https://gerrit.wikimedia.org/r/95732 [23:52:11] (03PS4) 10Jdlrobson: Make script output raw wikitext [tools/release] - 10https://gerrit.wikimedia.org/r/95721 [23:54:29] (03CR) 10Chad: [C: 032] Allow users prefer articles with recent changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95697 (owner: 10Manybubbles) [23:54:35] (03Merged) 10jenkins-bot: Allow users prefer articles with recent changes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95697 (owner: 10Manybubbles) [23:54:49] (03CR) 10Chad: [C: 032] Show notification on search page if configured [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [23:54:53] (03Merged) 10jenkins-bot: Show notification on search page if configured [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 (owner: 10Manybubbles) [23:57:17] (03PS1) 10Aaron Schulz: Enforce that all consumers have basic rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/95735 [23:57:26] (03PS4) 10AndyRussG: Disable institution-page cache when logged in [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/92335 [23:58:07] csteipp: ^ [23:58:20] AaronSchulz: I was wondering about that [23:58:28] Since doesn't it set disabled? [23:58:54] right, so it doesn't go through...either way you need to force it on server-side, so doesn't really matter