[00:00:43] (03PS2) 10Ori.livneh: Controlled experiment to assess performance of module storage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 [00:03:43] (03PS3) 10Ori.livneh: Controlled experiment to assess performance of module storage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 [00:04:06] anyone available to review these changes? [00:08:12] (03PS1) 10Aaron Schulz: Added support to img_auth.php for non-repo containers [core] - 10https://gerrit.wikimedia.org/r/95304 [00:10:07] (03CR) 10Ori.livneh: "Added a bunch of reviewers to increase the chance that someone takes a look. I'm not waiting on any particular person, if if it looks good" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [00:13:26] (03CR) 10Legoktm: [C: 032] Rather than upsert module store, explicitly remove old value and then add new one [core] - 10https://gerrit.wikimedia.org/r/94959 (owner: 10Ori.livneh) [00:16:54] (03Merged) 10jenkins-bot: Rather than upsert module store, explicitly remove old value and then add new one [core] - 10https://gerrit.wikimedia.org/r/94959 (owner: 10Ori.livneh) [00:17:17] (03PS4) 10Ori.livneh: Controlled experiment to assess performance of module storage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 [00:22:04] (03CR) 10Aaron Schulz: "(4 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [00:24:22] (03PS1) 10Bsitu: Make flow message more readable in recent change page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95306 [00:24:23] (03CR) 10jenkins-bot: [V: 04-1] Make flow message more readable in recent change page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95306 (owner: 10Bsitu) [00:25:10] (03CR) 10MZMcBride: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94959 (owner: 10Ori.livneh) [00:25:42] (03PS2) 10Bsitu: Make flow message more readable in recent change page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95306 [00:26:00] (03PS1) 10AndyRussG: Refactor following breackage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [00:26:10] (03CR) 10jenkins-bot: [V: 04-1] Refactor following breackage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [00:32:02] marktraceur: so nearby pages should be live on beta labs soonish [00:32:18] Ooh cool [00:32:22] Oh, that reminds me [00:32:35] I failed to email greg-g probably [00:32:53] Oh, no, I totally didn't [00:32:58] marktraceur: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-betafeatures [00:33:01] it's there :) [00:33:14] Yuup [00:33:39] greg-g: I emailed you about VectorBeta, any chance of getting a deploy window tomorrow for it? :D [00:34:26] (03PS1) 10Krinkle: qunit macro: Make log/ directory writable instead of just the file [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95309 [00:34:57] (03PS2) 10AndyRussG: Refactor following breackage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [00:34:57] marktraceur: although sadly http://en.wikipedia.beta.wmflabs.org/w/api.php?format=json&action=query&colimit=max&prop=pageimages%7Ccoordinates&pithumbsize=180&pilimit=50&generator=geosearch&ggscoord=45.522466200000004%7C-122.60854020000001&ggsradius=10000&ggsnamespace=0&ggslimit=50%20Request%20Method:GET fail :-( [00:35:02] (03CR) 10jenkins-bot: [V: 04-1] Refactor following breackage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [00:35:20] Wuh oh [00:35:30] marktraceur: it's the same on Special:Nearby [00:35:31] http://en.wikipedia.beta.wmflabs.org/wiki/Special:Nearby [00:35:38] something to do with the beta labs setup [00:35:45] ^ awjr MaxSem might have an idea [00:35:53] o_O [00:36:18] awjr: Special:Nearby not working on beta labs - didn't it used to? [00:36:18] Krinkle / jdlrobson: do either of you have time to review https://gerrit.wikimedia.org/r/#/c/94840/ ? [00:36:33] (03PS3) 10AndyRussG: Refactor following breackage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [00:36:40] (03CR) 10jenkins-bot: [V: 04-1] Refactor following breackage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [00:36:53] dunno if it ever did on desktop, jdlrobson [00:36:58] ori-l: i will look at that tomorrow. Not sure it's a good candidate for one of my 4.30pm code reviews [00:37:10] jdlrobson, something with solr server or mw config on beta [00:37:13] oooof. [00:37:27] awjr: doesn't work on mobile either http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby [00:37:30] (03PS1) 10Krinkle: mwconf: Enable $wgDebugRawPage so that load.php errors are logged [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95310 [00:37:32] (03PS1) 10Krinkle: mwconf: Enable $wgDBerrorLog and $wgRateLimitLog [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 [00:37:41] (03CR) 10Krinkle: [C: 032] mwconf: Enable $wgDebugRawPage so that load.php errors are logged [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95310 (owner: 10Krinkle) [00:37:45] (03Merged) 10jenkins-bot: mwconf: Enable $wgDebugRawPage so that load.php errors are logged [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95310 (owner: 10Krinkle) [00:38:03] MaxSem: i forget - is solr set up for this stuff on betalabs? [00:38:20] should be, if i remeber right [00:38:26] (03CR) 10Krinkle: [C: 04-1] "Don't merge yet since this needs changing in the jjb job macro for qunit to set the chmod correctly. We should probably change it to chmod" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95311 (owner: 10Krinkle) [00:38:36] hmm yes - deployment-solr [00:38:55] (03CR) 10Awjrichards: [C: 032] Don't save secondary coordinates equal to primary one [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/88903 (owner: 10MaxSem) [00:39:02] (03Merged) 10jenkins-bot: Don't save secondary coordinates equal to primary one [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/88903 (owner: 10MaxSem) [00:40:19] (03PS4) 10AndyRussG: Refactor following breackage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [00:42:35] (03CR) 10EBernhardson: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95306 (owner: 10Bsitu) [00:43:50] dafuq? "Error occurred during initialization of VM" [00:43:52] judging form the error in the api response i would guess there's something wrong with solr [00:43:54] oh [00:43:59] that sounds whacky [00:44:36] (03PS1) 10Bsitu: Some fix to edit-title page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95312 [00:45:39] awjr, apprently has something to do with java changes in puppet, will investigate tomorrow [00:45:41] (03CR) 10Ori.livneh: "IMO, It should be entirely the responsibility of ResourceLoader::makeModuleResponse to construct the states array. ResourceLoader::Respond" [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [00:46:29] hmm, does prod work?:P [00:46:41] sometimes [00:46:58] harr harr [00:47:01] OpenJDK [00:47:57] hmm, my home VM also doesn't have Sun java [00:48:22] maybe, it's openjdk 1.6? [00:49:23] hehhehehe prod looks ok MaxSem, at least on enwiki [00:49:39] ori-l: James_F has a vagrant question, do you have some time? [00:50:12] TimStarling: https://bugzilla.wikimedia.org/show_bug.cgi?id=56849 looks quite interesting [00:50:16] sure, what's up? [00:50:33] ^ James_F [00:51:07] * AaronSchulz wants to look at that but should keep looking at some extension, sigh [00:51:12] ori-l: Where in the host OS is Vagrant's Parsoid repo (/srv/Parsoid) - can it be accessed from outside? [00:51:31] ori-l: I want to hack around with Parsoid inside my Vagrant stack, and I can't seem to see it. [00:52:23] yeah, /srv is not shared by default. which editor do you typically use? [00:52:45] ori-l: Sublime, but I can use nano if needed. [00:53:19] TimStarling: anyway, I did get around to https://gerrit.wikimedia.org/r/#/c/94935/ [00:53:29] I don't see any permissions errors left at the moment [00:53:59] probably since nothing that uses sessions tends to last for that long (except maybe large upload jobs) [00:54:55] James_F: you can run 'vagrant ssh' to get a shell on the VM. can you run 'sudo cp -R /srv/parsoid /vagrant/parsoid' ? [00:55:01] ok, I'll look at that after my meeting with robla [00:55:33] ori-l: Done. [00:56:39] James_F: now edit puppet/manifests/roles.pp (relative to the vagrant repo root on your host environment) [00:56:52] Is anyone else getting "preg_match() expects parameter 2 to be string" on /w/load.php?debug=true&lang=en&modules=startup&only=scripts&skin=vector&* on their local wiki? [00:56:58] ori-l: OK… [00:57:00] and change the line 218, which should read: "class { '::mediawiki::parsoid': } " [00:57:19] Yup. [00:57:32] to class { '::mediawiki::parsoid': dir => '/vagrant/parsoid', } [00:58:03] Kk. [00:58:10] then run 'vagrant provision' [00:58:13] and you should be done [00:58:27] (03CR) 10EBernhardson: [C: 032] Add mising parameter to participants message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95192 (owner: 10Matthias Mullie) [00:58:37] (03Merged) 10jenkins-bot: Add mising parameter to participants message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95192 (owner: 10Matthias Mullie) [00:58:51] Awesome. [00:59:34] ori-l: Do I need to vagrant up as well? [00:59:56] hi folks....I'm about to talk to Tim for a bit, but any ideas on this? https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#logged-out_way_too_often [01:00:39] has anyone checked the centralauth log for that username? [01:00:55] superm401, any chance the less patch gets reviewed today? if not, I might not have a chance to look at it until Monday [01:01:13] James_F: 'vagrant provision' presumes the machine is up; it'll nag you to run 'vagrant up' if it isn't [01:01:26] Ah, cool. [01:01:39] ori-l: Should I upstream these changes so others can use this? [01:02:13] jgonera, I'll have it up within the hour. [01:02:33] James_F: no, there are reasons for cloning it into /srv [01:02:46] robla: the logs corroborate the report [01:02:56] TimStarling: something came up that I should deal with now. can we postpone for 15 min? [01:03:03] ori-l: OK. [01:03:09] yes [01:03:12] James_F: but you could either amend the docs or file a bug if you want me to fix this more permanently [01:04:00] ori-l: Sure. Will do. [01:06:24] jgonera, in the meantime, can you check the above URL on your dev wiki? [01:06:50] superm401, which one? [01:07:25] It's /w/load.php?debug=true&lang=en&modules=startup&only=scripts&skin=vector&* [01:07:41] will do in a few minutes, in a meeting now [01:07:45] Okay, thanks. [01:10:50] (03Abandoned) 10PleaseStand: Add /S modifier to remaining uses of ASCII check regex [core] - 10https://gerrit.wikimedia.org/r/85105 (owner: 10PleaseStand) [01:22:30] dr0ptp4kt: you merged but did not deploy https://gerrit.wikimedia.org/r/#/c/95212/ [01:22:58] (03PS2) 10Aaron Schulz: Added support to img_auth.php for non-repo containers [core] - 10https://gerrit.wikimedia.org/r/95304 [01:24:23] ori-l, i see it got +2'd. how can that get pushed into prod? [01:24:44] cc: yurik ^ [01:24:46] wmf-config changes are merged immediately before syncing [01:24:47] <^demon|away> If people blindly git pull and sync. [01:25:26] I believe it's standing policy to not merge into that repo without planning to deploy. [01:26:12] yes, that's why jenkins doesn't auto-submit [01:26:49] Reverted in https://gerrit.wikimedia.org/r/#/c/95315/ [01:26:51] Elsie, ^demon|away (sorta), ori-l: i gathered as much from what MaxSem said yesterday regarding a different change. any recommendations on next step? [01:26:56] Elsie, i see :) [01:27:22] <^demon|away> dr0ptp4kt: Easy, re-revert the change in gerrit, then merge right before you plan to deploy it. [01:27:25] <^demon|away> And not earlier :) [01:27:30] :-) [01:28:09] Deployment requests have to be submitted in writing, in triplicate and notarized, to Greg G., I believe. [01:28:15] ^demon|away, yeah, i'm unable to do deploys (need to fix my IDs), so i don't bother trying to +2 stuff outside of the train. [01:28:42] alright, i'll follow up with yurik and see if he can coordinate a deploy tomorrow. it's not super urgent. [01:28:52] <^demon|away> Elsie: Every deploy is now subject to a 6-month RFC :) [01:29:07] en.wiki RFC * ;-) [01:29:12] The mediawiki.org ones are too easy. [01:29:22] that is sick and twisted. [01:29:27] i mean great [01:29:28] ??? [01:29:51] 7w1573d, you mean [01:30:49] <^demon|away> That looked like a git sha1, minus the w. [01:31:11] I heard "SHA" pronounced "shah" today. [01:31:12] I heh'd. [01:31:26] That's how I say it in my head :| [01:32:29] Not there's anything wrong with that. [01:32:37] Some people seem to naturally do that. [01:34:25] that's also how I say ot [01:34:34] how else are you supposed to say it [01:35:09] S. H. A. [01:35:19] boring [01:35:20] Or "hash." [01:35:28] (03PS5) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [01:35:40] illegal in several parts of the country I live in [01:36:05] (03PS3) 10Bsitu: Make flow message more readable in recent change page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95306 [01:37:05] I was going to say "as is homosexuality," but I'm not sure that's still true. [01:37:56] was decriminalized a few years ago [01:57:50] Elsie: btw, I also usually say "Shaw" (or shah), or more precisely "Shaw One". [01:58:42] Huh. [01:58:47] Maybe I'm the strange one! [02:02:33] Elsie: Linus says it http://www.youtube.com/watch?v=4XpnKHJAok8#t=56m27s [02:02:40] > 56:28But we also do a SHA-1 hash of the content, and we actually [02:03:02] transcript search rules :) [02:06:35] I mis-pronounce Linus for sure. [02:07:48] Elsie: I don't, but that's because that vowel is actually part of my native set. [02:08:35] Elsie: Lay nows? Leenos ? :P [02:08:38] Lieness [02:10:48] jgonera, code review looks fine. [02:11:02] Except for sass-cache, but that's trivial, so I can do it myself. [02:11:09] Double checking output, and running in IE6 and IE7 now. [02:11:13] oh, sorry, forgot about this one [02:11:26] Then I'll fix that (unless you beat me to it), and merge. [02:12:14] I also checked that URL superm401, it looks fine I guess, no errors [02:12:24] superm401, I'd be grateful, I'm still finishing other things [02:12:39] jgonera, okay, must be specific to my setup. [02:12:44] Will deal with that later. [02:12:51] Don't think it's related to your change. [02:12:55] what are you seeing? [02:13:40] "Warning: preg_match() expects parameter 2 to be string, array given in /vagrant/mediawiki/includes/Timestamp.php on line 83", with call stack backtrace. [02:13:50] For every single module, or every script or something like that. [02:14:00] When I'm done with the SASS one, I'll debug through with XDebug [02:17:08] superm401, try pulling the newest master and rebasing, that helped me with some other problems, might be that the commit that this is based on was messed up [02:30:29] jgonera, it happens on latest master. [02:35:46] (03PS10) 10Mattflaschen: Port mediawiki.ui SASS to LESS [core] - 10https://gerrit.wikimedia.org/r/93584 [02:42:02] Elsie, around? [02:42:24] (03CR) 10Aaron Schulz: [C: 032] Updated containers to set ACLs on [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/95286 (owner: 10Aaron Schulz) [02:42:27] (03Merged) 10jenkins-bot: Updated containers to set ACLs on [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/95286 (owner: 10Aaron Schulz) [02:47:13] (03Abandoned) 10Ragesoss: Revert "Remove Settings::newFromGlobals" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95185 (owner: 10Ragesoss) [03:06:36] marktraceur: bah, yeah, one sec [03:12:40] (03CR) 10Tim Starling: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94935 (owner: 10Aaron Schulz) [03:14:14] (03CR) 10Aaron Schulz: [C: 032] Add the log entry after we know the job is successful [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94689 (owner: 10Legoktm) [03:14:24] (03Merged) 10jenkins-bot: Add the log entry after we know the job is successful [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94689 (owner: 10Legoktm) [03:29:37] (03CR) 10JGonera: [C: 031] Port mediawiki.ui SASS to LESS [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [03:46:14] (03CR) 10Mattflaschen: [C: 032] "I did a quick amend just removing sass-cache" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [03:47:02] ^ jgonera, looks good. :) [03:47:11] (03PS1) 10Chad: Don't pretend to use $wgTitle [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/95319 [03:48:23] superm401, thanks! [03:49:17] (03Merged) 10jenkins-bot: Port mediawiki.ui SASS to LESS [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [03:54:23] (03PS5) 10Spage: Demonstrate use of oo-ui [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 [03:55:22] (03CR) 10Spage: "(2 comments)" [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 (owner: 10Spage) [03:58:47] (03PS5) 10AndyRussG: Refactor following breakage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [04:09:08] (03PS1) 10Chad: Remove unused $wgTitles [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95320 [04:09:09] (03PS1) 10Chad: Replace $wgTitle usage where it's not needed [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95321 [04:09:26] <^d> What a messy bunch of extensions :\ [04:16:04] (03PS1) 10Chad: Remove unused $wgTitle [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/95322 [04:16:08] (03CR) 10Mattflaschen: [C: 04-1] "I don't see the need to revive this extension. I would prefer to explicitly mark it obsolete." [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 (owner: 10Spage) [04:17:00] (03CR) 10Legoktm: [C: 032] Don't pretend to use $wgTitle [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/95319 (owner: 10Chad) [04:17:02] (03Merged) 10jenkins-bot: Don't pretend to use $wgTitle [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/95319 (owner: 10Chad) [04:20:52] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [04:21:54] (03CR) 10Legoktm: "This was already fixed in I34ea069d48a4d35381157c2112b76f941e498688." [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/95322 (owner: 10Chad) [04:22:11] ^d: maybe you have old copies of some extensions? [04:22:27] <^d> Hmm, I updated all my repos earlier this afternoon :) [04:23:09] <^d> Maybe not. Lez find out [04:31:41] (03PS1) 10Mattflaschen: Fix spacing for LESS [core] - 10https://gerrit.wikimedia.org/r/95323 [05:23:15] (03CR) 10Legoktm: [C: 032 V: 032] Remove unused $wgTitles [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95320 (owner: 10Chad) [05:24:59] Anyone know an image pastebin that preserves the filename? [05:25:27] (03PS6) 10AndyRussG: Refactor following breakage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [05:25:46] superm401: Wikimedia's Bugzilla installation. :-) [05:25:48] superm401: dropbox [05:25:50] Or Commons. [05:25:56] commons is best [05:26:21] Or Meta-Wiki or MediaWiki.org or the test Wikipedia. [05:26:31] Or a Labs account has a home dir, I think. [05:26:43] Yeah, I use all of those, except Dropbox (I have one but I don't really use it). [05:27:00] This is for stuff where there's no bug and it's too transient to be useful for Commons. [05:27:13] I made a Labs group under my username. [05:27:36] Shell users can also use noc, I believe. [05:28:06] http://tools.wmflabs.org/mzmcbride/ [05:28:16] Hello. [05:28:19] Tool Labs group, I suppose. [05:28:21] (03CR) 10Legoktm: [C: 032 V: 032] "According to https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateTabs, this hook was removed in 1.18, so I doubt it's even being run." [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/95321 (owner: 10Chad) [05:28:23] Hey ori-l [05:29:02] Elsie: that page is sending a content-type header of 'text/html'! [05:29:18] hey superm401 [05:29:29] legoktm: OH GOD. [05:29:54] Logging in and running "become mzmcbride" feels weird. ;-) [05:30:32] Maybe I'll make a "I put on my robe and wizard hat" bash alias. [05:31:22] marktraceur: btw, my excuse for not responding to your email is that you sent it to "ggrossmeier@" instead of "greg@" which makes it show up as my "not directly to me" color in mutt. (true fact, my legit username is greg@, ggrossmeier@ is an alias for backwards compat) [05:31:33] Ahhh. [05:31:40] greg-g: My bad. [05:31:47] no worries [05:31:52] Should I expect to not deploy that thing, then? [05:31:54] my bad for being behind in email [05:32:12] no conclusions yet, gimme 5 (I had to deal with a baby before) [05:34:06] 1pm? [05:34:40] * greg-g assumes yes [05:35:35] oh damn [05:36:06] marktraceur: 3pm? faidon resheduled his deploy [05:36:17] and I hadn't reloaded the page [05:36:20] What's going out? [05:36:23] BetaFeatures? [05:36:35] Elsie: MASSMESSAGE [05:36:37] VectorBeta, which'll be a betafeatures option [05:36:43] legoktm! [05:36:43] also what legoktm said :) [05:36:53] What types is MassMessage going out? [05:37:01] time? [05:37:03] Yes. [05:37:08] 11-1am pacifc [05:37:12] ic [05:37:12] 1900-2100 [05:37:20] probably closer to 11:30 is my guess [05:37:21] What time is that in human time? [05:37:39] I don't believe there are any real humans where you live [05:37:46] blegh, I have class at that time :/ [05:37:49] 11:30 a.m. PST is ... 3:30 p.m.? [05:37:56] 2:30 p.m.? [05:37:58] EST [05:38:01] Elsie: 2:30 est [05:38:12] greg-g: Yeah, sure [05:38:14] 3 hour dif [05:38:16] f [05:38:19] (man, typing) [05:38:19] Sorry, slow [05:38:37] (Tell me about it.) [05:38:50] Okay, so 2:30 p.m. on Thursday. [05:38:52] (It's hard) [05:39:12] legoktm: I'm not sure there's anything either of us need to do, though. [05:39:23] Update a few templates [05:39:23] It'll take a few weeks for everyone to fully figure it out. [05:39:41] yeah [05:39:41] I suppose the target template will need to be updated, yeah. [05:39:51] Or we could kill it. [05:40:16] I'm a little surprised nobody objected to that parser function name. [05:40:20] Oh well. [05:40:31] * legoktm points a #target on Elsie's back [05:40:34] paints* [05:42:23] man I hate timezones, making my deploy calendar confusing (4pm Pacific is 24:00/0:00 UTC, thus showing up as the next day :/) [05:44:09] time zones [05:44:32] I guess that's a Britishism. [05:48:31] wouldn't they say time sones [05:50:58] Tea time. [05:51:43] :) [07:46:27] no grrrit-wm? [07:46:45] legoktm: ^ can you help? [07:54:55] huh, so everyone except YuviPanda_zzz listed in https://wikitech.wikimedia.org/wiki/Grrrit-wm#Access is in SF timezone? [07:55:09] maybe not azatoth [07:55:17] and Elsie [07:56:43] I'm in SF, but not in SF timezone [07:57:29] gerrit-wm is silent, you want to look at it or should I? (I pushed and merged something and no messages in wm operations) [07:57:45] apergos: just restarted it [07:57:49] great [07:58:00] poor you, the squid stuff must be awful to deal with :/ [07:58:01] and there it is [07:58:22] me? nah, I just look and shoot [07:58:42] it's sort of a race, will they die before we move out of tampa :-D [07:58:58] heh :) [07:59:31] a brand new puppet era is dawnign though, I have reset the freshness whine to 3 hours (to take effect at next neon run) [07:59:40] very interested to see how effective that will be [08:00:05] yeah, ditto [08:00:38] if it isn't, I'll start getting more agressive about telling people they left X broken [08:00:46] the reports infrastructure in puppet can be used to emit alerts / logs / sonar blips on any puppet failure [08:00:48] (repeat offenders mainly) [08:01:20] but it requires several hours of focussed work to set up properly that i don't have and no one else does either [08:01:32] well right now we will notice failure to run, and disabling (but this is not the same as 'it's broken with an error' [08:02:03] yeah [08:02:10] i guess it does cover most cases, tho [08:02:12] I have a script which I check daily to tell me which hosts have various issues (it's the same one I use for all my other reports, 'in dns but not dhcp' etc) [08:03:04] well it doesn't cover 'it started to run and emitted the trap but then failed with an error' which is not a small number of errors it turns out [08:03:06] you should check it in or post it somewhere! [08:03:20] I know, gotta check it in. been saying that for two weeks [08:03:33] just gotta fix the broken cli host filtering, then in it goes, crap or no [08:03:40] (on today's todo) [08:03:57] cool cool, look forward to checking it out [08:04:31] aude: would you like to be added to the list of grrrit-wm admins? i can't imagine anyone objecting [08:08:43] (03PS1) 10Mattflaschen: Document the wikipage.content hook [core] - 10https://gerrit.wikimedia.org/r/95330 [08:41:57] hi all [08:42:09] need some help at https://en.wikivoyage.org/wiki/User:Nicholasjf21/MainPage2 [08:42:33] anyone willing to help please/ [08:59:34] no one? [09:00:50] Saqib: i'm probably going to bed, but you might have better luck if you state your problem [09:01:04] you just provided a link, nothing is obviously wrong with it, so i'm not sure what you're asking [09:01:16] ori-l: would be great [09:01:25] hmm [09:01:26] ok [09:01:35] good to have additional timezones covered :) [09:02:18] how can i make boxes in this page [09:02:26] like the boxes in this image https://en.wikivoyage.org/wiki/File:Main_page_mockup.png [09:02:49] grrrit-wm works :) [09:03:01] the boxes are already in the page but the position is different [09:06:36] any help will be appreciated please [09:11:12] or this page https://en.wikivoyage.org/wiki/User:Nicholasjf21/MainPage2/Carousel [09:11:53] i think it relates to css [12:25:38] (03PS1) 10Siebrand: Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 [12:35:23] (03PS1) 10Bartosz Dziewoński: mediawiki.ui: Add right padding to .agora-field-styling() [core] - 10https://gerrit.wikimedia.org/r/95360 [12:35:28] (03PS1) 10Bartosz Dziewoński: mediawiki.ui: Ensure that buttons and inputs are vertically aligned [core] - 10https://gerrit.wikimedia.org/r/95361 [12:38:15] (03PS2) 10Bartosz Dziewoński: Fix spacing for LESS [core] - 10https://gerrit.wikimedia.org/r/95323 (owner: 10Mattflaschen) [12:38:29] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.ui: Fix spacing for LESS [core] - 10https://gerrit.wikimedia.org/r/95323 (owner: 10Mattflaschen) [12:38:50] (03PS2) 10Aklapper: Sync our custom index.css with upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91792 [12:39:24] (03CR) 10Bartosz Dziewoński: "Good point Patrick, I didn't notice it before." [core] - 10https://gerrit.wikimedia.org/r/94276 (owner: 10Chad) [12:40:05] (03CR) 10Bartosz Dziewoński: "Submitted two followups for the two issues raised by Krinkle and Patrick: https://gerrit.wikimedia.org/r/95360 and" [core] - 10https://gerrit.wikimedia.org/r/94276 (owner: 10Chad) [12:43:09] (03CR) 10Raimond Spekking: "Step 2 done with I667dc6d4a8fe64e52875fbda6dc4b96172baf823" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94965 (owner: 10MaxSem) [12:43:33] (03Merged) 10jenkins-bot: mediawiki.ui: Fix spacing for LESS [core] - 10https://gerrit.wikimedia.org/r/95323 (owner: 10Mattflaschen) [12:48:08] (03CR) 10Aklapper: [C: 031] Sync our custom index.css with upstream [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91792 (owner: 10Aklapper) [12:50:57] (03PS2) 10Bartosz Dziewoński: mediawiki.ui: Ensure that buttons and inputs are vertically aligned [core] - 10https://gerrit.wikimedia.org/r/95361 [12:50:58] (03PS2) 10Bartosz Dziewoński: mediawiki.ui: Add right padding to .agora-field-styling() [core] - 10https://gerrit.wikimedia.org/r/95360 [12:51:20] (03PS1) 10MaxSem: Remove old message file [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95364 [12:55:11] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The LESS rewrite is now merged and this needs rebase (or, in fact, a rewrite) :(" [core] - 10https://gerrit.wikimedia.org/r/94489 (owner: 10Gerrit Patch Uploader) [12:57:48] (03CR) 10Bartosz Dziewoński: [C: 031] "I'll defer to Krinkle, because JSDuck doc formatting is still a mystery to me, and the package is impossible to set up." [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [13:02:14] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95365 [13:02:15] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95366 [13:02:16] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95367 [13:02:17] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95368 [13:02:18] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95369 [13:02:19] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95370 [13:02:20] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95371 [13:02:21] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95372 [13:13:57] (03CR) 10Bartosz Dziewoński: "Siebrand, do you think it makes sense to keep it, or should I remove it there too?" [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [13:14:39] (03CR) 10Siebrand: "Probably remove it there, too, and use a different key that has a future?" [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [13:15:24] (03CR) 10Siebrand: "Or introduce a new key in the extension itself. That may even be the better solution." [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [13:18:41] (03PS1) 10Raimond Spekking: Fix optional message key [core] - 10https://gerrit.wikimedia.org/r/95375 [13:19:02] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix optional message key [core] - 10https://gerrit.wikimedia.org/r/95375 (owner: 10Raimond Spekking) [13:22:21] (03PS3) 10Dan-nl: lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 [13:24:27] (03CR) 10Dan-nl: "ps3 addresses bryans’s comments in ps2" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [13:35:14] (03CR) 10Dan-nl: "ps3 addresses siebrand’s comments in ps2" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [13:36:35] (03CR) 10Dan-nl: "ps4 addresses issues aaron and i discussed in irc" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [13:50:25] (03CR) 10Krinkle: "If you have phython/gem, installing is 1 command: `gem install jsduck` (or, to use the same version we use on Jenkins, `gem install jsduck" [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [13:58:40] (03CR) 10Krinkle: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [14:02:33] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95381 [14:02:34] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95382 [14:12:48] anyone with big screens here? [14:17:50] (03PS5) 10Dan-nl: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [14:18:40] (03CR) 10Dan-nl: "(5 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [14:19:02] (03PS6) 10Dan-nl: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [14:19:35] (03CR) 10Dan-nl: "ps6 removes the patch set comments from the commit message" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [14:20:14] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95383 [14:20:15] (03PS1) 10Siebrand: Declare visibility on class property [core] - 10https://gerrit.wikimedia.org/r/95384 [14:37:25] (03PS13) 10Matthias Mullie: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [14:45:38] (03CR) 10Matthias Mullie: "(31 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [14:47:26] (03PS14) 10Matthias Mullie: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [14:50:53] (03PS1) 10Matthias Mullie: 'x time ago' timestamps don't play well withing full sentences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95385 [14:52:53] (03PS1) 10Matthias Mullie: Don't publish log entries to RC; we're taking care of that ourselves already [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95386 [14:53:00] (03PS3) 10Gergő Tisza: Add LocalFile::getParentCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 [14:55:12] (03CR) 10Gergő Tisza: "Changed the SQL query to explicit JOIN." [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [15:03:54] (03PS2) 10Zfilipin: WIP Moved Selenium tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/92879 [15:04:19] (03PS4) 10Gergő Tisza: Add LocalFile::getParentCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 [15:05:46] (03PS15) 10Matthias Mullie: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [15:06:43] (03CR) 10Gergő Tisza: "Cleanup; some noise got into the previous commit." [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [15:10:10] (03CR) 10Matthias Mullie: [C: 031] "Great improvement/addition overall." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [15:18:38] (03CR) 10Matthias Mullie: [C: 032] "A-HA, great catch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95196 (owner: 10EBernhardson) [15:18:47] (03PS1) 10MarkAHershberger: Don't record self-link from mw.title [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95389 [15:18:48] (03PS1) 10MarkAHershberger: Add timezone support to mw.lang:formatDate [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95390 [15:18:49] (03Merged) 10jenkins-bot: Set a posts replyToId before setting content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95196 (owner: 10EBernhardson) [15:18:56] (03PS1) 10MarkAHershberger: (bug 41769) Add frame:callParserFunction() and frame::extensionTag() [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95391 [15:19:01] (03PS1) 10MarkAHershberger: Improve caching in fetchModuleFromParser [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95392 [15:19:02] (03PS1) 10MarkAHershberger: Add text module [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95393 [15:19:07] (03PS1) 10MarkAHershberger: (bug 46405) Fix errors in mw.title.new( pageid ) [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95394 [15:19:13] (03PS1) 10MarkAHershberger: (bug 39655) Add Lua version info to Special:Version [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95395 [15:19:21] (03PS1) 10MarkAHershberger: (bug 46635) Recognize Windows path+drive letter [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95396 [15:19:21] (03CR) 10Aklapper: [C: 031] "WTF me hard... I've put the -1'ed patchset on boogs.wmflabs.org (4.2) plus my local 4.4 instance and of course it does work, sigh. So I am" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91801 (owner: 10Aklapper) [15:19:24] (03CR) 10Matthias Mullie: [C: 032] RecentChanges support for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95277 (owner: 10EBernhardson) [15:19:28] (03PS1) 10MarkAHershberger: Make pairs() work with various library objects [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95397 [15:19:29] (03PS1) 10MarkAHershberger: (bug 46294) Fix for Windows text-mode file handles [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95398 [15:19:35] (03PS1) 10MarkAHershberger: Remove mw.getLogBuffer and others from public interface [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95399 [15:19:37] (03PS1) 10MarkAHershberger: (bug 47268) lang:parseFormattedNumber should return a number, not a string [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95400 [15:19:37] (03Merged) 10jenkins-bot: RecentChanges support for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95277 (owner: 10EBernhardson) [15:19:40] (03PS1) 10MarkAHershberger: Don't pass negative years to Language::sprintfDate [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95401 [15:19:42] (03PS1) 10MarkAHershberger: (bug 47300) Fix sandboxing with require [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95402 [15:19:48] (03PS1) 10MarkAHershberger: Fix content format for ScribuntoContentHander [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95403 [15:19:50] (03PS1) 10MarkAHershberger: (bug 47365) Fix edge cases in mw.ustring.find, mw.ustring.match [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95404 [15:19:53] (03PS1) 10MarkAHershberger: Add frontier pattern (%f[set]) to ustring [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95405 [15:19:59] (03PS1) 10MarkAHershberger: Fix uncaught exception in LuaStandalone [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95406 [15:20:00] (03PS1) 10MarkAHershberger: Modules should be in English (while docs are not) [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95407 [15:20:02] (03PS1) 10MarkAHershberger: Handle bogus entries in MediaWiki:Scribunto-doc-page-name [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95408 [15:20:05] (03PS1) 10MarkAHershberger: Fix LuaSandbox mw.ustring.byteoffset with negative 'i' [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95409 [15:20:11] (03PS1) 10MarkAHershberger: Fix mw.ustring edge cases [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95410 [15:20:11] (03PS1) 10MarkAHershberger: Make lang:parseFormattedNumber more like tonumber [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95411 [15:20:12] (03PS1) 10MarkAHershberger: Improve disable_functions handling in LuaStandalone [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95412 [15:20:15] (03PS1) 10MarkAHershberger: Update ignores for some emacs tmp files [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95413 [15:20:16] (03PS1) 10MarkAHershberger: Add mw.logObject [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95414 [15:20:23] (03PS1) 10MarkAHershberger: More-compatible Linux standalone binaries [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95415 [15:20:28] (03PS1) 10MarkAHershberger: Fix possible fatal error [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95416 [15:20:29] (03CR) 10jenkins-bot: [V: 04-1] (bug 47300) Fix sandboxing with require [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95402 (owner: 10MarkAHershberger) [15:20:33] (03PS1) 10MarkAHershberger: Remove explicit direction: ltr [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95417 [15:20:36] (03PS1) 10MarkAHershberger: Handle backtrace where Lua can't guess the function name [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95418 [15:20:36] (03PS1) 10MarkAHershberger: Scribunto should error out sooner if lua isn't executable [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95419 [15:20:39] (03PS1) 10MarkAHershberger: Improve mw.text.nowiki [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95420 [15:20:46] (03PS1) 10MarkAHershberger: Improve mw.text.nowiki, part 2 [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95421 [15:20:50] (03CR) 10MarkAHershberger: [C: 032] Don't record self-link from mw.title [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95389 (owner: 10MarkAHershberger) [15:21:48] (03CR) 10MarkAHershberger: [C: 032] Add timezone support to mw.lang:formatDate [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95390 (owner: 10MarkAHershberger) [15:22:22] (03PS3) 10Zfilipin: Bump patch version [selenium] - 10https://gerrit.wikimedia.org/r/95340 [15:22:29] (03PS2) 10Zfilipin: Resize browser at Sauce Labs to maximum supported size [selenium] - 10https://gerrit.wikimedia.org/r/95338 [15:22:36] (03PS3) 10Zfilipin: Created Jenkins job that will run ULS tests at en.wikipedia.beta.wmflabs.org [selenium] - 10https://gerrit.wikimedia.org/r/95334 [15:22:41] (03CR) 10MarkAHershberger: [C: 032] (bug 41769) Add frame:callParserFunction() and frame::extensionTag() [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95391 (owner: 10MarkAHershberger) [15:22:54] (03CR) 10Matthias Mullie: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95299 (owner: 10EBernhardson) [15:23:21] (03CR) 10MarkAHershberger: [C: 032] Improve caching in fetchModuleFromParser [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95392 (owner: 10MarkAHershberger) [15:24:35] (03CR) 10Matthias Mullie: [C: 032] Some fix to edit-title page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95312 (owner: 10Bsitu) [15:25:12] (03CR) 10MarkAHershberger: [C: 032] Add text module [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95393 (owner: 10MarkAHershberger) [15:25:30] (03Merged) 10jenkins-bot: Some fix to edit-title page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95312 (owner: 10Bsitu) [15:26:10] (03CR) 10AndyRussG: "(1 comment)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [15:26:19] (03CR) 10MarkAHershberger: [C: 032] (bug 46405) Fix errors in mw.title.new( pageid ) [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95394 (owner: 10MarkAHershberger) [15:27:57] (03CR) 10MarkAHershberger: [C: 032] (bug 39655) Add Lua version info to Special:Version [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95395 (owner: 10MarkAHershberger) [15:29:01] (03CR) 10MarkAHershberger: [C: 032] (bug 46635) Recognize Windows path+drive letter [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95396 (owner: 10MarkAHershberger) [15:30:18] (03PS1) 10Matthias Mullie: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95423 [15:30:30] (03CR) 10Matthias Mullie: [C: 032] Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95423 (owner: 10Matthias Mullie) [15:30:41] (03Merged) 10jenkins-bot: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95423 (owner: 10Matthias Mullie) [15:30:45] (03CR) 10MarkAHershberger: [C: 032] Make pairs() work with various library objects [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95397 (owner: 10MarkAHershberger) [15:30:56] ... [15:30:58] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95277 (owner: 10EBernhardson) [15:32:52] (03CR) 10MarkAHershberger: [C: 032] (bug 46294) Fix for Windows text-mode file handles [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95398 (owner: 10MarkAHershberger) [15:35:07] (03CR) 10MarkAHershberger: [C: 032] Remove mw.getLogBuffer and others from public interface [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95399 (owner: 10MarkAHershberger) [15:35:48] (03CR) 10Matthias Mullie: "Not sure about this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95306 (owner: 10Bsitu) [15:36:24] (03CR) 10MarkAHershberger: [C: 032] Don't pass negative years to Language::sprintfDate [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95401 (owner: 10MarkAHershberger) [15:36:41] (03CR) 10MarkAHershberger: [C: 032] (bug 47268) lang:parseFormattedNumber should return a number, not a string [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95400 (owner: 10MarkAHershberger) [15:37:35] (03CR) 10MarkAHershberger: [C: 032] Fix content format for ScribuntoContentHander [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95403 (owner: 10MarkAHershberger) [15:39:00] (03CR) 10MarkAHershberger: [V: 032] Make pairs() work with various library objects [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95397 (owner: 10MarkAHershberger) [15:40:04] (03CR) 10MarkAHershberger: [V: 032] (bug 46294) Fix for Windows text-mode file handles [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95398 (owner: 10MarkAHershberger) [15:41:01] (03CR) 10MarkAHershberger: [V: 032] Remove mw.getLogBuffer and others from public interface [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95399 (owner: 10MarkAHershberger) [15:41:52] (03CR) 10MarkAHershberger: [V: 032] (bug 47268) lang:parseFormattedNumber should return a number, not a string [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95400 (owner: 10MarkAHershberger) [15:42:18] all the backports! [15:42:37] (03CR) 10MarkAHershberger: [V: 032] Don't pass negative years to Language::sprintfDate [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95401 (owner: 10MarkAHershberger) [15:43:35] (03PS16) 10Matthias Mullie: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [15:48:16] (03PS7) 10AndyRussG: Refactor following breakage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [15:49:41] (03CR) 10jenkins-bot: [V: 04-1] Refactor following breakage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [15:51:57] (03CR) 10jenkins-bot: [V: 04-1] Scribunto should error out sooner if lua isn't executable [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95419 (owner: 10MarkAHershberger) [15:52:05] (03CR) 10jenkins-bot: [V: 04-1] Improve mw.text.nowiki [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95420 (owner: 10MarkAHershberger) [15:52:08] (03CR) 10jenkins-bot: [V: 04-1] Improve mw.text.nowiki, part 2 [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95421 (owner: 10MarkAHershberger) [15:52:41] (03PS8) 10AndyRussG: Refactor following breakage due to change 69977 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 [15:56:40] (03PS3) 10Cmcmahon: VE takes a long time to appear [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95078 [15:56:42] (03CR) 10Liangent: "backport?" [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95407 (owner: 10MarkAHershberger) [15:57:38] (03CR) 10jenkins-bot: [V: 04-1] Fix content format for ScribuntoContentHander [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95403 (owner: 10MarkAHershberger) [15:57:40] (03CR) 10jenkins-bot: [V: 04-1] More-compatible Linux standalone binaries [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95415 (owner: 10MarkAHershberger) [15:57:41] (03CR) 10jenkins-bot: [V: 04-1] Fix possible fatal error [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95416 (owner: 10MarkAHershberger) [15:57:42] (03CR) 10jenkins-bot: [V: 04-1] Remove explicit direction: ltr [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95417 (owner: 10MarkAHershberger) [15:57:43] (03CR) 10jenkins-bot: [V: 04-1] Handle backtrace where Lua can't guess the function name [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95418 (owner: 10MarkAHershberger) [15:59:00] Nailed it. [16:02:33] hashar hi [16:02:40] i was looking for you [16:02:42] (03CR) 10MarkAHershberger: [C: 032 V: 032] (bug 47300) Fix sandboxing with require [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95402 (owner: 10MarkAHershberger) [16:02:56] (03CR) 10BryanDavis: [C: 031] lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [16:02:59] hexmode: mark? [16:03:11] you said this afternoon that that page is not looking perfect on your large screen size. right? [16:03:18] we need a screenshot of it please [16:03:21] (03CR) 10jenkins-bot: [V: 04-1] (bug 47300) Fix sandboxing with require [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95402 (owner: 10MarkAHershberger) [16:03:31] (03PS5) 10Gergő Tisza: Add WikiFilePage::getForeignCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 [16:03:46] (03CR) 10Hashar: "I am cancelling all your scribunto merge to REL1_21 please contact me online." [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95402 (owner: 10MarkAHershberger) [16:04:51] hashar , can you please upload screenshot somewhere like imgur ? [16:06:27] (03CR) 10Cmcmahon: [C: 032] VE takes a long time to appear [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95078 (owner: 10Cmcmahon) [16:11:16] (03PS2) 10Zfilipin: WIP moving code to the gem [qa/browsertests] - 10https://gerrit.wikimedia.org/r/93456 [16:12:40] (03CR) 10Gergő Tisza: "Moved the logic to WikiFilePage." [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [16:12:56] (03PS1) 10Aude: Update Wikibase, ensure uls js dependencies are loaded [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95427 [16:13:23] (03CR) 10Ragesoss: [C: 031 V: 031] "Tested, works for me. Note that the breaking change this addresses has been merged, the fix needs to come ASAP before it deploys and break" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [16:16:31] (03CR) 10Cmcmahon: [C: 032] "restore ULS job for beta enwiki" [selenium] - 10https://gerrit.wikimedia.org/r/95334 (owner: 10Zfilipin) [16:22:12] (03PS3) 10Cmcmahon: Resize browser at Sauce Labs to maximum supported size [selenium] - 10https://gerrit.wikimedia.org/r/95338 (owner: 10Zfilipin) [16:24:36] (03CR) 10Cmcmahon: [C: 032] "provisional" [selenium] - 10https://gerrit.wikimedia.org/r/95338 (owner: 10Zfilipin) [16:25:17] (03PS4) 10Cmcmahon: Bump patch version [selenium] - 10https://gerrit.wikimedia.org/r/95340 (owner: 10Zfilipin) [16:25:38] (03CR) 10Cmcmahon: [C: 032] "maintenance" [selenium] - 10https://gerrit.wikimedia.org/r/95340 (owner: 10Zfilipin) [16:26:05] (03PS1) 10Matthias Mullie: (bug 56808) Â â appearing sometimes, related to parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 [16:26:35] (03PS2) 10Matthias Mullie: (bug 56808) Â â appearing sometimes, related to parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 [16:26:52] (03CR) 10Cscott: [C: 04-1] "(2 comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [16:36:02] (03CR) 10BryanDavis: "I think this is looking much better but Aaron seems to still have some concerns that he and Dan should work through." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [16:43:56] (03PS1) 10Matthias Mullie: Make error messages more vague [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95431 [16:43:58] (03Abandoned) 10MarkAHershberger: Modules should be in English (while docs are not) [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95407 (owner: 10MarkAHershberger) [16:44:00] (03CR) 10Parent5446: "Looking good. This is good preparation for the eventual overhaul of the logging system that will be needed. I'll do a more thorough review" [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [16:45:04] (03Abandoned) 10MarkAHershberger: Scribunto should send lua error output to error log [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/75988 (owner: 10MarkAHershberger) [16:46:28] (03Abandoned) 10MarkAHershberger: (bug 47300) Fix sandboxing with require [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95402 (owner: 10MarkAHershberger) [16:46:33] (03Abandoned) 10MarkAHershberger: Handle backtrace where Lua can't guess the function name [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95418 (owner: 10MarkAHershberger) [16:46:35] (03Abandoned) 10MarkAHershberger: Remove explicit direction: ltr [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95417 (owner: 10MarkAHershberger) [16:46:36] (03Abandoned) 10MarkAHershberger: Fix possible fatal error [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95416 (owner: 10MarkAHershberger) [16:46:43] (03Abandoned) 10MarkAHershberger: More-compatible Linux standalone binaries [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95415 (owner: 10MarkAHershberger) [16:46:47] (03Abandoned) 10MarkAHershberger: Fix content format for ScribuntoContentHander [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95403 (owner: 10MarkAHershberger) [16:46:49] (03Abandoned) 10MarkAHershberger: Improve mw.text.nowiki, part 2 [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95421 (owner: 10MarkAHershberger) [16:46:53] (03Abandoned) 10MarkAHershberger: Improve mw.text.nowiki [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95420 (owner: 10MarkAHershberger) [16:46:57] (03Abandoned) 10MarkAHershberger: Scribunto should error out sooner if lua isn't executable [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95419 (owner: 10MarkAHershberger) [16:47:00] (03Abandoned) 10MarkAHershberger: Add mw.logObject [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95414 (owner: 10MarkAHershberger) [16:47:05] (03Abandoned) 10MarkAHershberger: Update ignores for some emacs tmp files [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95413 (owner: 10MarkAHershberger) [16:47:06] (03Abandoned) 10MarkAHershberger: Improve disable_functions handling in LuaStandalone [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95412 (owner: 10MarkAHershberger) [16:47:10] (03Abandoned) 10MarkAHershberger: Make lang:parseFormattedNumber more like tonumber [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95411 (owner: 10MarkAHershberger) [16:47:11] (03Abandoned) 10MarkAHershberger: Fix mw.ustring edge cases [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95410 (owner: 10MarkAHershberger) [16:47:13] (03Abandoned) 10MarkAHershberger: Fix LuaSandbox mw.ustring.byteoffset with negative 'i' [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95409 (owner: 10MarkAHershberger) [16:47:17] (03Abandoned) 10MarkAHershberger: Handle bogus entries in MediaWiki:Scribunto-doc-page-name [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95408 (owner: 10MarkAHershberger) [16:47:21] (03Abandoned) 10MarkAHershberger: Fix uncaught exception in LuaStandalone [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95406 (owner: 10MarkAHershberger) [16:47:22] (03Abandoned) 10MarkAHershberger: Add frontier pattern (%f[set]) to ustring [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95405 (owner: 10MarkAHershberger) [16:47:26] (03Abandoned) 10MarkAHershberger: (bug 47365) Fix edge cases in mw.ustring.find, mw.ustring.match [extensions/Scribunto] (REL1_21) - 10https://gerrit.wikimedia.org/r/95404 (owner: 10MarkAHershberger) [16:47:31] (03Abandoned) 10MarkAHershberger: Initial attempt at backporting [extensions/Scribunto] (REL1_19) - 10https://gerrit.wikimedia.org/r/75142 (owner: 10MarkAHershberger) [16:48:39] hexmode: nice :-] [16:49:16] :) [16:49:49] (03PS1) 10Manybubbles: Update CirrusSearch to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95435 [16:50:42] (03PS1) 10Cscott: Revert "Remove Settings::newFromGlobals" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95436 [16:54:35] (03PS9) 10Cscott: Remove Settings::newFromGlobals. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [16:54:53] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95438 [16:55:19] (03PS1) 10Matthias Mullie: Consistent behavior of actions on topics and posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95439 [16:55:26] (03CR) 10Cscott: [C: 032] "+2'ing this myself since it reverts a broken commit." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95436 (owner: 10Cscott) [16:57:32] (03Merged) 10jenkins-bot: Revert "Remove Settings::newFromGlobals" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95436 (owner: 10Cscott) [16:58:32] (03CR) 10Chad: [C: 032] Update formatting [core] - 10https://gerrit.wikimedia.org/r/95345 (owner: 10Siebrand) [17:01:32] (03CR) 10Chad: [C: 032] Update CirrusSearch to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95435 (owner: 10Manybubbles) [17:02:04] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95345 (owner: 10Siebrand) [17:03:22] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95365 (owner: 10Siebrand) [17:03:29] (03CR) 10Chad: [C: 032] Update formatting on API classes [core] - 10https://gerrit.wikimedia.org/r/95365 (owner: 10Siebrand) [17:04:01] (03PS7) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [17:05:41] (03Merged) 10jenkins-bot: Update CirrusSearch to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95435 (owner: 10Manybubbles) [17:07:42] (03PS10) 10Cscott: Remove Settings::newFromGlobals. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [17:08:08] (03CR) 10Gergő Tisza: "(2 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [17:08:15] (03PS1) 10Manybubbles: Update CirrusSearch to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95441 [17:08:25] (03PS8) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [17:09:03] (03CR) 10Chad: [C: 032 V: 032] Update CirrusSearch to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95441 (owner: 10Manybubbles) [17:09:35] (03Merged) 10jenkins-bot: Update formatting on API classes [core] - 10https://gerrit.wikimedia.org/r/95365 (owner: 10Siebrand) [17:10:20] (03PS1) 10Hashar: bump MediaWiki codesniffer standard 574f68d..0bebf0f7b [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95444 [17:10:56] (03CR) 10Hashar: [C: 032] "Really need to move that to git-deploy." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95444 (owner: 10Hashar) [17:11:11] (03PS1) 10Cscott: Remove Settings::newFromGlobals (fixed version) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95445 [17:11:50] (03CR) 10MarkTraceur: "(6 comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95307 (owner: 10AndyRussG) [17:13:36] (03CR) 10Gergő Tisza: [C: 031] lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [17:14:55] (03CR) 10Gergő Tisza: [C: 031] Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [17:16:05] (03Merged) 10jenkins-bot: bump MediaWiki codesniffer standard 574f68d..0bebf0f7b [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95444 (owner: 10Hashar) [17:18:31] thanks for the comments on AndyRussG's patch, marktraceur. Want to merge cscott's revert commit real quick, and then the urgency will be gone? [17:19:01] (03PS9) 10Wikinaut: Bug 54508: Add "provider only" mode; Bug 46617: allow Sysops to always create account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [17:19:06] Heh [17:19:43] ragesoss: Which is that? [17:19:53] https://gerrit.wikimedia.org/r/#/c/95445/ [17:19:57] On it [17:20:13] sweet [17:21:37] ragesoss: EP is hard to test, though - have you tested this one? [17:22:00] Or has csc wth [17:22:03] marktraceur: it's just a direct revert of the patch from Jeroen that broke it. [17:22:29] ragesoss: And there weren't intervening patchsets? Because if something else changed in the meantime we could be in trouble. [17:22:44] marktraceur: I'll do a smoke-test locally right now. [17:22:46] Hi marktraceur, thanks, testing it here [17:22:53] AndyRussG: That'll do :) [17:24:04] (03Abandoned) 10Chad: Remove unused $wgTitle [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/95322 (owner: 10Chad) [17:25:34] AndyRussG, marktraceur: looks like it's working. Incidentally, I don't think anything else has merged in the meantime. [17:25:37] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [17:25:46] Nothing has merged that affects this [17:26:26] Really? I thought the offending commit was, like, 6xxxx [17:26:53] marktraceur: it sat around until a couple days ago. [17:26:56] It was from eons ago [17:27:10] Ah. [17:27:14] Since this whole codebase is going to get very rewritten, I didn't see much point in it [17:27:18] thedj: Around? [17:31:24] marktraceur: Smoke tested fine [17:31:34] * marktraceur meeaaargges [17:31:43] (03CR) 10MarkTraceur: [C: 032] Remove Settings::newFromGlobals (fixed version) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95445 (owner: 10Cscott) [17:31:48] (03Merged) 10jenkins-bot: Remove Settings::newFromGlobals (fixed version) [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95445 (owner: 10Cscott) [17:33:10] (03PS1) 10Chad: Remove unused $wgTitle [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/95449 [17:33:37] thanks marktraceur! [17:33:52] * ragesoss sighs in relief. [17:35:01] Thanks a lot marktraceur [17:35:51] off see you tomorrow [17:36:14] hashar: take care [17:36:18] ran puppet on tin btw [17:36:23] thx! [17:36:35] will git-deploy tomorrow [17:36:50] got to update some scripts / jenkins jobs anyway. thx again [17:36:51] *wave* [17:36:55] bye [17:37:42] AndyRussG: oh, I see what happened now. Scott actually merged the revert himself, and this new patch was the redo of it with the same hacky solution to extension.php that I had found. [17:38:03] ragesos: yeah [17:38:10] I was confused a bit. [17:38:30] ragesoss: Me too... It wasn't that hacky [17:39:03] hacky from my perspective, in that all I did was take a wild guess and test whether it worked. [17:39:11] It was fine [17:39:16] I do think we need to review our standards for elegance in view of the extension's context [17:39:22] (03PS1) 10Chad: Don't even mention $wgTitle in a comment [extensions/Comments] - 10https://gerrit.wikimedia.org/r/95451 [17:39:22] regardless of the validity from the perspective of someone who knows what that code does. ;) [17:39:37] hahaha. very diplomatically states. [17:39:40] *stated. [17:39:54] (03CR) 10Hashar: [C: 031] "A prerequisite to enable $wgDBerrorLog and $wgRateLimitLog in https://gerrit.wikimedia.org/r/95311" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95309 (owner: 10Krinkle) [17:40:30] marktraceur, ragesoss: what do you think about sometime getting together to talk about the future of this extension? [17:41:05] ragesoss: I think maybe we could talk about it in detail first, then try to have a meeting with those who will be helping with code review, no? [17:41:23] * ragesoss nods. [17:41:24] I don't exactly maintain it [17:41:41] I'll drop merge hammers every once in a while, but I'm not sure how useful I can be otherwise [17:43:22] I don't know if you saw the comments from cscott and mwjames. I think they were really useful but may not have taken into account the extension's context and likely future [17:43:39] understood marktraceur. If Scott is going to be the main one reviewing your commits AndyRussG, maybe he'd be the one you want to include instead. [17:43:52] csc where could he be [17:44:00] ragesoss: sure, that's also fine [17:45:49] Maybe a very short planning document is all we'd need [17:47:56] hey AaronSchulz just wanted to check-in and see where we're at ... [17:50:46] (03CR) 10Legoktm: [C: 031] "(1 comment)" [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/95449 (owner: 10Chad) [17:51:00] ^d: ^ [17:51:41] (03CR) 10Legoktm: [C: 032 V: 032] Don't even mention $wgTitle in a comment [extensions/Comments] - 10https://gerrit.wikimedia.org/r/95451 (owner: 10Chad) [17:51:51] (03CR) 10Chad: "(1 comment)" [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/95449 (owner: 10Chad) [17:52:21] lol [17:52:32] (03CR) 10Legoktm: [C: 032 V: 032] Remove unused $wgTitle [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/95449 (owner: 10Chad) [17:54:10] (03PS2) 10Reedy: Update Wikibase, ensure uls js dependencies are loaded [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95427 (owner: 10Aude) [17:54:17] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, ensure uls js dependencies are loaded [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95427 (owner: 10Aude) [17:57:37] <^d> ashley: Ping [17:58:12] hi ^d, what's up? [17:58:22] <^d> Since you're working on CodeReview...can I beg a favor? [17:58:36] <^d> Can you find it in your heart to kill that awful awful $wgTitle usage? :p [17:59:03] haha, sure, let me check out a copy and see where that's being used :) [17:59:41] <^d> MakeGlobalVariablesScript hook [18:01:08] just use $out->getTitle() [18:01:35] <^d> ugh: There is no $out. [18:01:47] ^d: yes there is: https://www.mediawiki.org/wiki/Manual:Hooks/MakeGlobalVariablesScript [18:02:33] <^d> Durrr. [18:03:00] :) [18:03:40] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95455 [18:03:41] (03PS1) 10Siebrand: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95456 [18:05:30] *there* cscott is [18:05:37] I was so confused [18:05:57] sorry, bip crashed. then pidgin crashed. :( [18:06:01] cscott: AndyRussG and ragesoss were thinking about dragging you into a conversation about The Future Of EducationProgram [18:06:38] (03PS1) 10Jack Phoenix: Per special request: eliminate $wgTitle usage. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95457 [18:07:09] and then i had [18:07:47] to hangout. and now gwicke wants to meet. [18:08:00] hmm, what am I missing here? on https://gerrit.wikimedia.org/r/#/c/95457/ when I click on "Review" I can give it -1/0/+1...shouldn't I also be able to give it +2? [18:08:10] i'm not really qualified to discuss The Future Of EducationProgram. i just review code, i don't pretend to understand it. ;) [18:08:15] * ashley pings ^d for good measure^^ [18:08:26] (03CR) 10Legoktm: "(2 comments)" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95457 (owner: 10Jack Phoenix) [18:08:48] Hi cscott [18:08:53] ashley: well, you shouldn't be self-merging on wmf-deployed code :P [18:08:57] <^d> ashley: Try now? [18:09:02] cscott: I think he means the future of the EP extension [18:09:16] The code reviews have been really appreciated [18:09:26] ^d: looks much better, thanks ;) [18:09:44] cscott: more like a discussion of the tactics for AndyRussG's work, considering the state of the current extension and the anticipation that, in the long term, it would be rewritten from scratch (possibly by Growth team at some point) [18:09:46] ugh: I'm sure everyone will be all over me if I break MW.org's Special:Code, which gets OVER 9000 hits a day :D [18:10:10] ugh: anyway, thanks for the code review, I'll go update the docs; not sure re:horrible code [18:10:12] (03CR) 10Aaron Schulz: "(2 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [18:10:16] We're actually just talking about it now [18:10:37] ugh: I mean, the global is conditionally added (to subpages of Special:Code)...doesn't that fill the criteria of "horrible"? ;) [18:10:39] The idea eventaully is to make it much more modular and scalable [18:10:56] dan-nl: so what is the point of a lot of the stuff being in Config if it is hard coded anyway ($wgExtensionCredits is an obvious example of this) [18:11:00] ? [18:11:01] And since it doesn't use ContentHandler, there is a lot to be rewritten in any case [18:11:08] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95366 (owner: 10Siebrand) [18:11:09] i'm not a big fan of from-scratch rewritedsin general [18:11:15] (03PS3) 10Chad: Update formatting on more API classes [core] - 10https://gerrit.wikimedia.org/r/95366 (owner: 10Siebrand) [18:11:22] (03CR) 10Chad: [C: 032] Update formatting on more API classes [core] - 10https://gerrit.wikimedia.org/r/95366 (owner: 10Siebrand) [18:11:26] stupid webchat [18:11:30] OK [18:11:35] i find they tend to underestimate how much 'other stuff' is involved in any actual product [18:11:39] ugh_: Remind me again why you're even bothering with webchat [18:11:51] ie, do you really want to redo all the translations? [18:11:58] Right [18:12:05] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95367 (owner: 10Siebrand) [18:12:07] Well, the UX is really the pits right now [18:12:13] I'm afraid to say [18:12:21] marktraceur: my school blocks all ports above 1k-ish, so I can't connect to IRC nor my bouncer. Can't even push to gerrit. [18:12:26] Ahhh. [18:12:31] (03PS3) 10Chad: Update formatting on API classes, Part 3 [core] - 10https://gerrit.wikimedia.org/r/95367 (owner: 10Siebrand) [18:12:33] ugh_: Run your bouncer at port 666? [18:12:35] i haven't used it enough to really say [18:12:36] Or SSH tunnel? [18:12:39] (03CR) 10Chad: [C: 032] Update formatting on API classes, Part 3 [core] - 10https://gerrit.wikimedia.org/r/95367 (owner: 10Siebrand) [18:12:43] It was a good attempt and quite an impressive amount of work, but really it needs to be worked on from a design and UX perspective, pretty massively [18:12:44] marktraceur: ssh tunnel +1 [18:12:45] cscott: the idea that's been talked about (by Erik and Steven Walling, in particular) is to make a more general tool for collaborations, one that would be applicable to courses but also for all sorts of other outreach. [18:13:00] Exactly [18:13:15] marktraceur: can't, it's a shared webhost so all ports under 1k have already been taken by other people :/ [18:13:25] ssh tunnel would work, but the connection here isn't stable enough [18:13:25] Hah, terrible [18:13:44] and the VPN I have setup is using UDP on a port around 2k. [18:13:45] mosh tunnel? Ah, same problem. [18:13:48] Get a better server? [18:13:53] heh [18:13:54] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95368 (owner: 10Siebrand) [18:13:57] (03PS3) 10Chad: Update formatting on some API classes (must've forgotten these) [core] - 10https://gerrit.wikimedia.org/r/95368 (owner: 10Siebrand) [18:14:05] For example, there's a feature that allows teachers to track the edits of all their students. But that could be spun off as something independent, and there is work that0s converging with something like that, in fact [18:14:06] (03CR) 10Chad: [C: 032] Update formatting on some API classes (must've forgotten these) [core] - 10https://gerrit.wikimedia.org/r/95368 (owner: 10Siebrand) [18:14:31] Aaron|home: it's a container for all of the configuration information … some may change, others won't … if anything i could probably create constants for those config variables [18:14:32] marktraceur: I don't want to migrate the 200G of stuff I already have on this one :/ [18:14:39] [18:10:37] ugh: I mean, the global is conditionally added (to subpages of Special:Code)...doesn't that fill the criteria of "horrible"? ;) <-- probably xD [18:14:41] ^d: Now you're getting creative :) [18:14:55] cscott: we're operating on the assumption that we have a few more weeks of AndyRussG making improvements and fixing the worst of the usability issues, but after that it may not see much development for a while, and most likely would sort of limp along until Growth team takes on the more general project. [18:14:59] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95369 (owner: 10Siebrand) [18:15:02] (03PS3) 10Chad: Yet more formatting updates for yet more API classes [core] - 10https://gerrit.wikimedia.org/r/95369 (owner: 10Siebrand) [18:15:07] ragesoss, AndyRussG: that sounds reasonable. i guess i just don't have enough experience to offer informed opinions. i'm just reviewing code, and not always doing a good job of that. ;) [18:15:11] ^d: there's also another possibility, you can review them all separately, and when you've +1-ed them all, I can squash thme. [18:15:19] <^d> I'm having fun :) [18:15:31] (03CR) 10Chad: [C: 032] Yet more formatting updates for yet more API classes [core] - 10https://gerrit.wikimedia.org/r/95369 (owner: 10Siebrand) [18:15:36] ^d: heh :) [18:15:42] Other outreach and other projects may have workflows that are similar enough to make it worthwhile having a general outreach system that would be tweaked for specific cases [18:15:54] ^d: time for a commit summary generator tool? [18:16:11] dan-nl: the whole Config thing is a bit odd since MW does not have a config management class (though it should), so it's some extension-specific config system...but then a lot of it isn't actually config either [18:16:59] $wgExtensionCredits should just be defined like it is for pretty every other extension I've seen for example [18:17:00] cscott: it may well be more than a few weeks (I was just about to bring ragesoss up to speed on that, in fact), but for work on this extension or its replacement to take off, it will have to be more generally aplicable [18:17:03] (03Merged) 10jenkins-bot: Update formatting on more API classes [core] - 10https://gerrit.wikimedia.org/r/95366 (owner: 10Siebrand) [18:17:09] <^d> Aaron|home: It does, but nobody uses it because it's ugly :) [18:17:56] right, so there is no usable class atm [18:18:39] k, i just need to know how you'd like me to change things then ... [18:18:50] (03PS2) 10Chad: Break long lines [core] - 10https://gerrit.wikimedia.org/r/95346 (owner: 10Siebrand) [18:18:56] (03CR) 10Chad: [C: 032] Break long lines in Action classes [core] - 10https://gerrit.wikimedia.org/r/95346 (owner: 10Siebrand) [18:20:06] atm any of those values can be changes after the extension has been loaded with GWToolset\Config::$fsbackend_name='your-backend' [18:20:54] Aaron|home for now, is it a blocker? or can i re-factor it later? [18:21:36] (03PS2) 10Jack Phoenix: Per special request: eliminate $wgTitle usage. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95457 [18:21:50] dan-nl: how is that use of static variables better than $wg* stuff? [18:22:07] ugh: ^^that was far more painful than what it shoulda been, btw [18:22:22] it's namespaces and doesn't clutter the global namespace and avoidscollissions [18:22:34] it would fit better in wmf site configuration if it worked more like other extensions, though that could be worked around with a loop that sets the static vars I guess [18:22:40] (03PS11) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [18:22:48] (03PS7) 10Krinkle: resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 [18:22:52] (03Merged) 10jenkins-bot: Update formatting on API classes, Part 3 [core] - 10https://gerrit.wikimedia.org/r/95367 (owner: 10Siebrand) [18:23:06] i' okay with making the change if you recommend it … just need time to sort it out throughout the extension [18:23:07] (03CR) 10Chad: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/95354 (owner: 10Siebrand) [18:23:22] of course this would be a different commit (not the existing one) [18:23:32] (03CR) 10Legoktm: [C: 032] Per special request: eliminate $wgTitle usage. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95457 (owner: 10Jack Phoenix) [18:23:39] ashley: woot [18:23:41] yes, definitely [18:23:59] but is it required for release to beta? [18:24:14] yay, one $wgTitle less :D [18:24:49] (03PS1) 10Krinkle: [WIP] resourceloader: Refactor module links output [core] - 10https://gerrit.wikimedia.org/r/95463 [18:25:38] (03Draft2) 10Wikinaut: Bug 57065: E:OpenID does not accept temporary password when attaching an OpenID to an existing account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95461 [18:25:44] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95370 (owner: 10Siebrand) [18:25:48] (03PS3) 10Chad: Update formatting, return of the API classes [core] - 10https://gerrit.wikimedia.org/r/95370 (owner: 10Siebrand) [18:25:53] (03CR) 10Chad: [C: 032] Update formatting, return of the API classes [core] - 10https://gerrit.wikimedia.org/r/95370 (owner: 10Siebrand) [18:27:09] (03CR) 10Wikinaut: [C: 031 V: 031] "Ryan, Parent5446 and Chris, pls. have a look, thanks." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95461 (owner: 10Wikinaut) [18:28:00] (03Merged) 10jenkins-bot: Update formatting on some API classes (must've forgotten these) [core] - 10https://gerrit.wikimedia.org/r/95368 (owner: 10Siebrand) [18:28:20] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95371 (owner: 10Siebrand) [18:28:27] (03PS3) 10Chad: I'm in your API classes updating your formatting [core] - 10https://gerrit.wikimedia.org/r/95371 (owner: 10Siebrand) [18:28:33] (03CR) 10Chad: [C: 032] I'm in your API classes updating your formatting [core] - 10https://gerrit.wikimedia.org/r/95371 (owner: 10Siebrand) [18:29:15] (03PS2) 10Krinkle: [WIP] resourceloader: Refactor module links output [core] - 10https://gerrit.wikimedia.org/r/95463 [18:29:18] (03PS2) 10Chad: Update formatting [core] - 10https://gerrit.wikimedia.org/r/95372 (owner: 10Siebrand) [18:29:21] (03PS3) 10Chad: The light at the end of the API code format updating tunnel [core] - 10https://gerrit.wikimedia.org/r/95372 (owner: 10Siebrand) [18:29:41] (03PS4) 10BryanDavis: lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [18:29:43] (03CR) 10Chad: [C: 032] The light at the end of the API code format updating tunnel [core] - 10https://gerrit.wikimedia.org/r/95372 (owner: 10Siebrand) [18:29:52] Aaron|home: for the backend container … you mentioned that it should be more specific gwtoolset-metadata rather than metadata, but doesn't the combination of the directory and the container take care of that? gwtoolset\metadata ? [18:29:53] (03CR) 10BryanDavis: [C: 032] lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [18:30:30] dan-nl: you don't want containers to collide due to ACL handling being per-container for object stores [18:30:45] k [18:30:45] <^d> siebrand: The whole formatting topic's been reviewed. Gonna take a break before I do the phpcs one. [18:30:54] of course this isn't a problem for NFS and the like [18:31:05] now i understand why the container itself needs to be unique [18:31:18] ^d: ty! [18:31:25] (03PS3) 10Krinkle: [WIP] resourceloader: Refactor module links output [core] - 10https://gerrit.wikimedia.org/r/95463 [18:32:19] (03Merged) 10jenkins-bot: Yet more formatting updates for yet more API classes [core] - 10https://gerrit.wikimedia.org/r/95369 (owner: 10Siebrand) [18:35:15] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95365 (owner: 10Siebrand) [18:35:35] Aaron|home: so for https://gerrit.wikimedia.org/r/#/c/94748/6 i have the container name change to make, and one item tgr found to put in there. after that are you okay with that change set or is there something else? [18:36:11] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95365 (owner: 10Siebrand) [18:37:33] (03PS3) 10Wikinaut: Bug 57065: E:OpenID does not accept temporary password when attaching an OpenID to an existing account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95461 [18:37:47] (03PS2) 10Siebrand: Update docs for files in includes/actions/ [core] - 10https://gerrit.wikimedia.org/r/95354 [18:38:09] (03Merged) 10jenkins-bot: Break long lines in Action classes [core] - 10https://gerrit.wikimedia.org/r/95346 (owner: 10Siebrand) [18:38:20] (03PS4) 10Wikinaut: Bug 57065: does not accept temporary password when attaching OpenID to existing account [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95461 [18:38:34] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95366 (owner: 10Siebrand) [18:39:12] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95366 (owner: 10Siebrand) [18:39:30] (03CR) 10Krinkle: "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [18:40:11] (03CR) 10Wikinaut: [C: 031 V: 031] "uh, made a "logical" mistake (corrected now)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95461 (owner: 10Wikinaut) [18:40:52] dan-nl: you can get rid of Config::$fsbackend_directory and just put the files at the top of the container (or some hardcoded subdirectory) [18:40:53] (03PS1) 10Siebrand: Fix the fix: "? :" -> "?:" [core] - 10https://gerrit.wikimedia.org/r/95467 [18:41:06] (03Merged) 10jenkins-bot: Per special request: eliminate $wgTitle usage. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/95457 (owner: 10Jack Phoenix) [18:41:36] https://gerrit.wikimedia.org/r/#/c/94748/6/maintenance/cleanupGWTFileBackend.php looks more complicated that it should be [18:41:54] (03CR) 10Jdlrobson: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [18:42:18] would be nice to just see something like "$GWTFileBackend = new GWTFileBackend( array( 'name' => Config::$fsbackend_name ) );" [18:42:42] i based it on UploadStashCleanup [18:43:29] (03PS4) 10Jdlrobson: POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 [18:43:40] well that script doesn't have anything like GWTFileBackend ;) [18:44:05] (03CR) 10Chad: [C: 032] Update docs for files in includes/actions/ [core] - 10https://gerrit.wikimedia.org/r/95354 (owner: 10Siebrand) [18:46:41] i wasn't sure how else to access the GWTFileBackend without creating an instance of it … UploadStashCleanup uses the $tempRepo zones … but they don't include the GWTFileBackend because it's a private container … i guess [18:48:35] (03CR) 10Krinkle: [C: 04-1] "(5 comments)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 (owner: 10Ori.livneh) [18:49:20] (03CR) 10Krinkle: "(1 comment)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94973 (owner: 10Ori.livneh) [18:49:35] (03CR) 10Chad: [C: 032] Fix the fix: "? :" -> "?:" [core] - 10https://gerrit.wikimedia.org/r/95467 (owner: 10Siebrand) [18:49:37] cleanupGWTFileBackend.php is testing for the cutoff date in a similar way to UploadStashCleanup i just needed to get access to the file backend which the temprepo does not have access to [18:50:01] (03PS2) 10Chad: Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 (owner: 10Siebrand) [18:50:03] (03CR) 10Krinkle: "@Ori: Are you avoiding my question regarding bucket vs enabled? There's no wrong answer." [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [18:50:07] (03CR) 10Chad: [C: 032] Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 (owner: 10Siebrand) [18:50:20] (03Merged) 10jenkins-bot: Update formatting, return of the API classes [core] - 10https://gerrit.wikimedia.org/r/95370 (owner: 10Siebrand) [18:51:35] Aaron|home: i have an appointment i need to get ready for … what would really help me is to get a triage list of what needs to be done to finish off https://gerrit.wikimedia.org/r/#/c/94748/6 and then anything else which would be part of another commit [18:51:57] if you could add it to that ether pad that would be great ... [18:52:52] (03CR) 10Ori.livneh: "(2 comments)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 (owner: 10Ori.livneh) [18:55:24] hi again [18:55:24] (03CR) 10Anomie: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [18:55:40] need some help wit css carousel please [18:55:56] Aaron|home: i'll try and come back online later … if email is easier for that triage list feel free to do that instead … [18:56:17] (03Merged) 10jenkins-bot: I'm in your API classes updating your formatting [core] - 10https://gerrit.wikimedia.org/r/95371 (owner: 10Siebrand) [18:59:32] (03CR) 10Anomie: "Do we really need a series of 6 (or more?) patches to do this?" [core] - 10https://gerrit.wikimedia.org/r/95371 (owner: 10Siebrand) [19:00:51] (03CR) 10Siebrand: "I have found that big patch sets are not being reviewed because they are too big. So I've created smaller ones, that are being reviewed; I" [core] - 10https://gerrit.wikimedia.org/r/95371 (owner: 10Siebrand) [19:03:47] (03Merged) 10jenkins-bot: The light at the end of the API code format updating tunnel [core] - 10https://gerrit.wikimedia.org/r/95372 (owner: 10Siebrand) [19:06:13] (03PS5) 10Ori.livneh: Controlled experiment to assess performance of module storage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 [19:07:08] (03CR) 10jenkins-bot: [V: 04-1] Update docs for files in includes/actions/ [core] - 10https://gerrit.wikimedia.org/r/95354 (owner: 10Siebrand) [19:09:40] (03PS3) 10Siebrand: Update docs for files in includes/actions/ [core] - 10https://gerrit.wikimedia.org/r/95354 [19:10:25] (03CR) 10Wikinaut: [C: 04-2] "That's not the correct way to do it." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95461 (owner: 10Wikinaut) [19:11:56] (03CR) 10jenkins-bot: [V: 04-1] POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [19:12:47] (03CR) 10jenkins-bot: [V: 04-1] Update docs for files in includes/actions/ [core] - 10https://gerrit.wikimedia.org/r/95354 (owner: 10Siebrand) [19:15:08] (03CR) 10jenkins-bot: [V: 04-1] Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 (owner: 10Siebrand) [19:15:36] (03CR) 10Bartosz Dziewoński: "Sure, I can install it, but running mwjsduck-gen results in obscure errors from inside jsduck I've been unable to debug quickly. This migh" [core] - 10https://gerrit.wikimedia.org/r/95330 (owner: 10Mattflaschen) [19:16:42] (03CR) 10jenkins-bot: [V: 04-1] Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 (owner: 10Siebrand) [19:16:44] (03PS3) 10Siebrand: Exclude override to make method public from checks [core] - 10https://gerrit.wikimedia.org/r/95358 [19:17:26] (03Merged) 10jenkins-bot: Fix the fix: "? :" -> "?:" [core] - 10https://gerrit.wikimedia.org/r/95467 (owner: 10Siebrand) [19:22:23] marktraceur: So with this Commons metadata thing, if I wanted to get the license and attribution which extmetadata fields should I look at? For example, I see on File:Euphorbia avasmontana var avasmontana ies.jpg it returns "License" and "LicenseShortName" and "UsageTerms", and "Credit" and "Artist". [19:22:40] (03CR) 10Aaron Schulz: "(2 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [19:22:44] anomie: So...that's complicated, right [19:22:56] anomie: LicenseShortName is what we'll use, soon, in MultimediaViewer. [19:23:10] anomie: We use *both* Artist and Credit, because they're both important [19:23:30] marktraceur: And for that particular image, the "License" fields are showing CC-BY-SA while the "UsageTerms" is GFDL. Huh? [19:23:31] (03PS1) 10Adamw: Use recursive git clone [vagrant] - 10https://gerrit.wikimedia.org/r/95470 [19:23:32] (03PS1) 10Adamw: Prepare for name-based virtualhosting [vagrant] - 10https://gerrit.wikimedia.org/r/95471 [19:23:38] Uhhhh [19:23:47] lolwat. It might be an ordering thing. [19:24:14] anomie: My gut feeling is that, if there's a CC-BY-SA image, you can use it that way even if there are other licenses. [19:24:21] But tgr might have more insight there [19:24:28] And you might want to talk to lvillaWMF as well. :) [19:24:44] (depending on what you want to do0 [19:24:45] ) [19:25:09] anomie: LicenseShortName is parsed from HTML [19:25:22] most license templates supply it, some dont [19:25:35] marktraceur: We're looking at using it for the attribution in the PDF generation [19:25:39] (03PS17) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [19:25:52] the way we set License changes a lot [19:26:27] right now it is based on LicenseShortName, there is a pending change to look at categories as well [19:26:45] (03CR) 10EBernhardson: [C: 032] "reviewed mlitn adjustments. Rebased and merged(based on his approval)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [19:27:12] but it only recognizes those licenses for which MediaViewer has some special behavior [19:27:42] so right now LicenseShortName is more useful [19:27:54] (03PS1) 10Anomie: API: Allow filtering keys in iiprop=extmetadata [core] - 10https://gerrit.wikimedia.org/r/95472 [19:27:56] marktraceur, tgr: Also, https://gerrit.wikimedia.org/r/95472 [19:28:07] just be careful that it is a |-separated string for multilicensed files [19:28:43] (03CR) 10jenkins-bot: [V: 04-1] Prepare for name-based virtualhosting [vagrant] - 10https://gerrit.wikimedia.org/r/95471 (owner: 10Adamw) [19:29:39] tgr: File:Euphorbia avasmontana var avasmontana ies.jpg is multi-licensed but LicenseShortName isn't |-separated? [19:29:47] (03Merged) 10jenkins-bot: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [19:35:11] anomie, my bad, that change is not merged yet: https://gerrit.wikimedia.org/r/#/c/94088/ [19:36:03] in general, the extension is not very reliable for multilicensed images now [19:36:56] for example, if the first template has usage metadata, but no shortname, the second has shortname metadata, but no usage, then you will end up with inconsistent data [19:40:33] (03PS1) 10Catrope: Rename mw.util.wikiGetlink to getUrl [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95474 [19:41:33] (03PS1) 10GWicke: Adjust prefix to new format [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95475 [19:41:43] (03CR) 10GWicke: [C: 032] Adjust prefix to new format [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95475 (owner: 10GWicke) [19:42:42] (03Merged) 10jenkins-bot: Adjust prefix to new format [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95475 (owner: 10GWicke) [19:44:46] (03PS2) 10Parent5446: Fix CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/95381 (owner: 10Siebrand) [19:47:22] (03PS1) 10Catrope: Move wikiGetLink rename from 1.23 to 1.22 RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/95477 [19:47:54] (03CR) 10Catrope: "Backported to 1.22 in https://gerrit.wikimedia.org/r/95474 . https://gerrit.wikimedia.org/r/95477 updates release notes." [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [19:48:15] (03CR) 10Siebrand: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [19:50:19] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [19:51:19] (03CR) 10Bartosz Dziewoński: [C: 032] Rename mw.util.wikiGetlink to getUrl [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95474 (owner: 10Catrope) [19:51:25] (03CR) 10Bartosz Dziewoński: [C: 032] Move wikiGetLink rename from 1.23 to 1.22 RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/95477 (owner: 10Catrope) [19:54:54] (03Merged) 10jenkins-bot: Rename mw.util.wikiGetlink to getUrl [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95474 (owner: 10Catrope) [19:56:33] (03Merged) 10jenkins-bot: Move wikiGetLink rename from 1.23 to 1.22 RELEASE-NOTES [core] - 10https://gerrit.wikimedia.org/r/95477 (owner: 10Catrope) [20:00:26] (03PS1) 10EBernhardson: Add gender support for moderation messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95480 [20:00:58] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [20:04:15] (03CR) 10Edokter: "JGonera, I saw -ms- prefix in MSDN, but after checking again, it was only supported in IE10 preview. IE10 release indeed does not need the" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [20:08:34] (03CR) 10Edokter: [C: 04-1] "I am abandoning this patch, as the -ms- prefix is not needed at all, and the rest seems to be covered by the LESS rewrite." [core] - 10https://gerrit.wikimedia.org/r/94489 (owner: 10Gerrit Patch Uploader) [20:10:56] (03CR) 10Siebrand: [C: 032] "THanks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95480 (owner: 10EBernhardson) [20:10:58] (03Merged) 10jenkins-bot: Add gender support for moderation messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95480 (owner: 10EBernhardson) [20:12:45] (03Abandoned) 10Bartosz Dziewoński: Add support for gradients in Internet Explorer 10 and 11. Remove non-exixtent -ms-border-radius and -o-border-radius properties. Updated deprecated -moz-border-radius-XX (pre FF 3.0) properties. [core] - 10https://gerrit.wikimedia.org/r/94489 (owner: 10Gerrit Patch Uploader) [20:13:47] (03CR) 10Edokter: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94489 (owner: 10Gerrit Patch Uploader) [20:19:31] (03PS1) 10MaxSem: Rewrite of interaction with renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 [20:21:13] Nikerabbit: around? [20:21:54] (03PS1) 10Ori.livneh: Update UniversalLanguageSelector to b2f9e4211e [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95484 [20:22:49] ^ siebrand fyi [20:23:09] ori-l: Oh, thank you. I just saw the commit mail 20 seconds before your ping :) [20:23:34] (03PS1) 10Ryan Lane: Up versions of OATHAuth and OpenStackManager [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95485 [20:23:36] ori-l: Nikerabbit is ill. He unfortunately also had to cancel the trip to India of tomorrow :( [20:23:41] andrewbogott: ^^ [20:23:46] siebrand: is it all right with you? it would help things in prod to have the api call fix [20:24:03] siebrand: I heard but I momentarily forgot, I hope he's not troubled by the ping. [20:24:08] ori-l: yes, today fixes were merged I'd love to have in all wikis. [20:24:14] Ryan_Lane: ok, I think I know how to do that. If I remember :) [20:24:34] andrewbogott: https://wikitech.wikimedia.org/wiki/How_to_deploy_code [20:24:37] (03CR) 10Ori.livneh: [C: 032 V: 032] Update UniversalLanguageSelector to b2f9e4211e [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95484 (owner: 10Ori.livneh) [20:24:55] basically it's step1 and step2 is "get the code on virt0" :) [20:25:27] ori-l: fyi, you reopened the bug by doing that [20:25:40] ori-l: the patch notification bot will reopen bugs. [20:26:00] That bug has also been reported, MatmaRex :| [20:26:33] siebrand: yeah, and afair the status is 'no can do' [20:26:47] I enjoy that that page has items like 4: step 1; 5: step 2 [20:26:48] MatmaRex: oh, that's too bad :( [20:27:21] (03CR) 10Ryan Lane: [C: 032] Up versions of OATHAuth and OpenStackManager [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95485 (owner: 10Ryan Lane) [20:27:44] siebrand: basically the issue is that the bot is unable to get the status from bugzilla, it can only set it. don't ask me why. [20:28:15] MatmaRex: The funniest thing is that it also reopened on an abandoned patch. [20:28:25] MatmaRex: I think that's the one I reporte. [20:28:27] +d [20:28:32] MatmaRex: uh, it should be blocked as "write only" user :P [20:28:35] siebrand: heh. lol [20:33:37] MatmaRex: I didn't find anyone complaining about Echo email notification anywhere, so I filed https://bugzilla.wikimedia.org/show_bug.cgi?id=57074 [20:34:14] btw, I'm complaining [20:34:48] AzaToth: hmm, you mean talk page message notifications? they usually do contain the text for me [20:35:04] MatmaRex: I [20:35:10] MatmaRex: I mean the email notifications [20:35:25] yes, e-mail ones [20:35:28] AzaToth: i guess the text might be missing if Echo is unable to determine with 100% certainty which part to include, on non-trivial edits [20:35:56] MatmaRex: the notification from wikitech are pretty duh: http://i.imgur.com/7vBSlt1.png [20:36:10] AzaToth: ah [20:36:31] AzaToth: you should mention that. this might be an issue with the NovaSomething extension in use at wikitech [20:36:40] ah [20:36:49] and cc Ryan_Lane or whoever works on that [20:36:53] i think it's ryan :) [20:37:03] marktraceur: I'm currently doing the long-awaited momentjs implementation [20:37:07] Ryan_Lane you say [20:37:09] we have an open bug with a patch for this [20:37:14] ok [20:37:17] (03PS1) 10Aaron Schulz: Avoid extra parsing in prepareContentForEdit() [core] - 10https://gerrit.wikimedia.org/r/95519 [20:37:17] someone just needs to finish it up [20:37:21] linky? [20:37:32] https://gerrit.wikimedia.org/r/#/c/91906/ [20:37:39] Krinkle: Cool beans! We're just working on our in-extension solution for MMV [20:37:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=56202 ? [20:37:57] * MatmaRex too slow :( [20:38:07] ah, that bug is not linked to that commit. [20:38:13] ah, the usual i18n complains from siebrand [20:40:23] (03PS1) 10Ori.livneh: Revert "Update UniversalLanguageSelector to b2f9e4211e" [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95528 [20:40:25] hello [20:40:31] (03CR) 10Ori.livneh: [C: 032 V: 032] Revert "Update UniversalLanguageSelector to b2f9e4211e" [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95528 (owner: 10Ori.livneh) [20:41:10] (03CR) 10jenkins-bot: [V: 04-1] Avoid extra parsing in prepareContentForEdit() [core] - 10https://gerrit.wikimedia.org/r/95519 (owner: 10Aaron Schulz) [20:41:41] Hey hashar [20:41:49] You missed some of the fun, I think [20:41:57] fun? [20:42:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/91906 (owner: 10Alex Monk) [20:42:53] AzaToth: s7 was throwing a fit, site outages happened [20:43:10] oh [20:43:13] fun! [20:44:05] marktraceur: I will happily read the postmortem :D [20:44:14] scapegoat? [20:44:21] * marktraceur won't be writing it, I didn't freakin' do anything [20:44:30] it's still down I see [20:44:45] AzaToth: Still bits issues, but everything else seems good [20:44:52] it's always bits [20:47:10] (03PS7) 10Ori.livneh: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 [20:49:10] (03PS2) 10Aaron Schulz: Avoid extra parsing in prepareContentForEdit() [core] - 10https://gerrit.wikimedia.org/r/95519 [20:49:27] (03PS5) 10Wikinaut: adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 [20:49:55] (03PS1) 10Hashar: run-phpcs-mw: point to standard deployed via git-deploy [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95531 [20:50:06] (03CR) 10Wikinaut: [C: 032 V: 032] adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 (owner: 10Wikinaut) [20:50:10] ori-l: heh, so I either noticed or worked on 3 different extra parse-on-edit bugs this week, and if you go back a few more weeks, there is the CirrusSearch one (which is fixed now) [20:50:54] (03PS2) 10Hashar: run-phpcs-mw: point to standard deployed via git-deploy [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95531 [20:51:47] Aaron|home: that's pretty awesome [20:51:50] that you fixed them I mean [20:51:59] (03CR) 10Aaron Schulz: "As I said, I don't get how the singleton() gets destroyed per-test unless phpunit is working differently than I think (maybe it is)" [core] - 10https://gerrit.wikimedia.org/r/86218 (owner: 10Aaron Schulz) [20:52:18] ori-l: well Nik fixed the search one, I just complained about it ;) [20:53:00] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/95529 (owner: 10L10n-bot) [20:53:44] (03CR) 10Hashar: [C: 032] run-phpcs-mw: point to standard deployed via git-deploy [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95531 (owner: 10Hashar) [20:53:53] (03PS4) 10Wikinaut: Bug 54677: (partial) check email addresses Sanitizer::validateEmail() [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 [20:59:49] (03Merged) 10jenkins-bot: run-phpcs-mw: point to standard deployed via git-deploy [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95531 (owner: 10Hashar) [21:02:12] (03CR) 10Hashar: "deployed on slaves" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95531 (owner: 10Hashar) [21:14:11] (03PS1) 10leucosticte: Add --noredirects parameter to moveBatch.php [core] - 10https://gerrit.wikimedia.org/r/95535 [21:19:28] jdlrobson: So, our deploy window got cancelled because the cluster took a massive dump this morning [21:19:44] marktraceur: yeh i saw [21:19:45] And continues to feel very unsettled [21:19:54] So we're gonna go ahead and do it on Monday [21:20:12] Which probably means another window on Tuesday or Wednesday for pushing to Commons [21:20:40] jdlrobson: Throughout this experience, I found myself wondering, "Self, why is jdlrobson not the one deploying this?", so now I'm wondering it at you [21:20:52] i can't deploy marktraceur [21:20:56] so there is your answer :) [21:21:01] That makes sense [21:21:09] 'kay, I figured it was something silly like that [21:21:17] next time there is a lightning deployment awjr is gonna show me the ropes [21:21:28] jdlrobson: I mean, we could do that on Monday [21:21:43] that would be cool - i'll be back in the office Monday [21:21:50] Cool beans. [21:22:09] Once I get a window from Greg, I'll create a Calendar thing out of thin air [21:22:10] :) [21:25:02] (03PS1) 10EBernhardson: Repair per-post topic history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95536 [21:25:15] (03PS1) 10Anomie: Fix revdelete radio button labels [core] - 10https://gerrit.wikimedia.org/r/95537 [21:26:01] (03PS3) 10Bartosz Dziewoński: mediawiki.ui: Add right padding to .agora-field-styling() [core] - 10https://gerrit.wikimedia.org/r/95360 [21:26:43] marktraceur: sweet look forward to it [21:27:42] (03PS3) 10Bartosz Dziewoński: mediawiki.ui: Ensure that buttons and inputs are vertically aligned [core] - 10https://gerrit.wikimedia.org/r/95361 [21:28:02] (03CR) 10Anomie: "Followup: I13c6470b" [core] - 10https://gerrit.wikimedia.org/r/93163 (owner: 1001tonythomas) [21:28:23] (03CR) 10Bartosz Dziewoński: "This should be okay now that the Wikibase fix is merged. Aude, can you recheck?" [core] - 10https://gerrit.wikimedia.org/r/94288 (owner: 10Bartosz Dziewoński) [21:29:00] marktraceur: did you mean Monday? [21:29:43] (03CR) 10EBernhardson: [C: 032] 'x time ago' timestamps don't play well withing full sentences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95385 (owner: 10Matthias Mullie) [21:29:50] jdlrobson: Um, yeah? [21:29:55] I said Monday [21:30:01] marktraceur: the calendar invite says today :) [21:30:08] It did until I deleted it [21:30:23] Because I thought it would be today until greg-g cruelly yanked the window out from under me. :) [21:30:23] marktraceur: haha :) [21:30:29] (03Merged) 10jenkins-bot: 'x time ago' timestamps don't play well withing full sentences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95385 (owner: 10Matthias Mullie) [21:30:56] (03PS2) 10EBernhardson: Always use the topic post id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95299 [21:30:59] (03PS1) 10CSteipp: SECURITY: Improve css javascript detection [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95538 [21:31:01] (03PS1) 10CSteipp: SECURITY: Don't cache when a call could autocreate [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95539 [21:31:02] (03CR) 10jenkins-bot: [V: 04-1] Always use the topic post id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95299 (owner: 10EBernhardson) [21:31:04] (03PS1) 10CSteipp: Update Releasenotes and version number for 1.19.9 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95540 [21:31:06] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95299 (owner: 10EBernhardson) [21:31:43] (03CR) 10EBernhardson: [C: 032] Don't publish log entries to RC; we're taking care of that ourselves already [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95386 (owner: 10Matthias Mullie) [21:32:26] (03PS1) 10Manybubbles: Show notification on search page if configured [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95541 [21:32:42] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Improve css javascript detection [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95538 (owner: 10CSteipp) [21:32:48] (03PS1) 10CSteipp: SECURITY: Improve css javascript detection [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95542 [21:32:50] (03PS1) 10CSteipp: SECURITY: Don't cache when a call could autocreate [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95543 [21:32:51] (03PS1) 10CSteipp: Update Releasenotes and version number for 1.20.8 [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95544 [21:33:04] (03CR) 10jenkins-bot: [V: 04-1] SECURITY: Don't cache when a call could autocreate [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95539 (owner: 10CSteipp) [21:33:15] (03CR) 10EBernhardson: [C: 032] Make error messages more vague [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95431 (owner: 10Matthias Mullie) [21:34:14] (03Merged) 10jenkins-bot: Don't publish log entries to RC; we're taking care of that ourselves already [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95386 (owner: 10Matthias Mullie) [21:34:53] huh, we had an xss vulnerability? not pretty [21:34:58] (03PS1) 10CSteipp: SECURITY: Improve css javascript detection [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95545 [21:35:00] (03PS1) 10CSteipp: SECURITY: Don't cache when a call could autocreate [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95546 [21:35:01] (03PS1) 10CSteipp: Update Releasenotes and version number for 1.21.3 [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95547 [21:35:20] (03CR) 10jenkins-bot: [V: 04-1] Update Releasenotes and version number for 1.19.9 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95540 (owner: 10CSteipp) [21:35:42] (03CR) 10EBernhardson: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95439 (owner: 10Matthias Mullie) [21:36:55] (03CR) 10Legoktm: [C: 032] "Thanks, tested and confirmed working." [core] - 10https://gerrit.wikimedia.org/r/95537 (owner: 10Anomie) [21:39:46] (03Merged) 10jenkins-bot: Make error messages more vague [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95431 (owner: 10Matthias Mullie) [21:44:57] (03CR) 10EBernhardson: [C: 031] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [21:45:19] (03PS1) 10CSteipp: SECURITY: Don't show deleted usernames [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/95551 [21:47:43] (03Abandoned) 10EBernhardson: Always use the topic post id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95299 (owner: 10EBernhardson) [21:48:00] (03CR) 10CSteipp: [C: 032] "Reviewed by Niklas on the bug. Patched on cluster." [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/95551 (owner: 10CSteipp) [21:51:22] (03Merged) 10jenkins-bot: SECURITY: Don't show deleted usernames [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/95551 (owner: 10CSteipp) [21:52:38] (03Merged) 10jenkins-bot: Fix revdelete radio button labels [core] - 10https://gerrit.wikimedia.org/r/95537 (owner: 10Anomie) [21:53:44] (03PS1) 10Hashar: let us easily override PHPUnit version [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95552 [21:54:13] ^d: Do you need to give me privileges to see gerrit stream-events now, for some reason? [21:54:37] ...'kay [21:54:58] Does anyone know what's up with that? [21:55:59] Oh, huh, "Caller must be a member of the privileged Administrators group, or have been granted the Stream Events global capability. [21:56:02] " [21:56:41] Can someone add me to https://gerrit.wikimedia.org/r/#/admin/groups/539,members ? [21:57:02] * marktraceur looks at hashar [21:57:15] (03CR) 10Hashar: "Chris, that fix the tests in Jenkins for mw/core @ REL1_19" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95552 (owner: 10Hashar) [21:57:56] marktraceur: have you filled bureaucracy form x288-~3 and sold your soul to the devil? [21:58:03] (the later being optional) [21:58:43] marktraceur: I have no clue what stream-events is for, I guess it grants you the ability to receive events over json [21:59:22] !log Gerrit: added marktraceur to group [https://gerrit.wikimedia.org/r/#/admin/groups/539,members stream-events] [21:59:22] Wrong channel, try again. [21:59:28] .. [21:59:39] it knows about it [22:00:11] Thankee [22:00:32] (03PS1) 10Bsitu: header is loading history style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95553 [22:00:33] I disclaim all responsabilities :] [22:00:54] (03PS4) 10MarkTraceur: Standardise and minimise licence headers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [22:01:28] hashar: I was trying to figure out the structure of something [22:01:32] But I guess I can't do it anyway [22:01:39] (03CR) 10MarkTraceur: [C: 04-1] Standardise and minimise licence headers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [22:02:24] (03CR) 10CSteipp: [C: 032] "Looks sane, and gets tests passing. Thanks!" [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95552 (owner: 10Hashar) [22:04:45] (03Merged) 10jenkins-bot: let us easily override PHPUnit version [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95552 (owner: 10Hashar) [22:05:15] (03CR) 10CSteipp: [C: 032] "Deployed in production" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95545 (owner: 10CSteipp) [22:05:37] (03CR) 10CSteipp: [C: 032] "Deployed in production" [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95546 (owner: 10CSteipp) [22:06:01] (03CR) 10CSteipp: [C: 032] Update Releasenotes and version number for 1.21.3 [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95547 (owner: 10CSteipp) [22:06:25] (03PS2) 10CSteipp: SECURITY: Improve css javascript detection [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95538 [22:06:50] (03CR) 10CSteipp: [C: 032] SECURITY: Improve css javascript detection [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95542 (owner: 10CSteipp) [22:07:09] (03CR) 10CSteipp: [C: 032] SECURITY: Don't cache when a call could autocreate [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95543 (owner: 10CSteipp) [22:07:16] (03CR) 10CSteipp: [C: 032] Update Releasenotes and version number for 1.20.8 [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95544 (owner: 10CSteipp) [22:07:37] (03CR) 10Parent5446: "I'm wondering, would it be appropriate to throw an error if the email is invalid, rather than just pretending the email wasn't there in th" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 (owner: 10Wikinaut) [22:08:15] csteipp, "MediaWiki steward"? [22:08:57] (03PS1) 10Krinkle: [WIP] Add Moment.js library for working with date and time [core] - 10https://gerrit.wikimedia.org/r/95555 [22:09:31] dang it. [22:09:56] That even made it past my proof reader [22:10:02] marktraceur: so apparently stream-events can cause some stress on Gerrit and should not be abused. [22:10:49] (03Merged) 10jenkins-bot: SECURITY: Improve css javascript detection [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95545 (owner: 10CSteipp) [22:12:50] csteipp: so that is going to take a bunch of time to merge all those changes :D [22:13:19] csteipp: end of november I will enable parallel processing of jobs in gate-and-submit, that will speed it up a bit [22:13:37] (03Merged) 10jenkins-bot: SECURITY: Don't cache when a call could autocreate [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95546 (owner: 10CSteipp) [22:15:14] (03CR) 10Krinkle: "Theory: The repo has a license header (license file) so that if you decide to take an individual file, its the users responsibility to com" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [22:16:26] (03Merged) 10jenkins-bot: Update Releasenotes and version number for 1.21.3 [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/95547 (owner: 10CSteipp) [22:19:26] (03Merged) 10jenkins-bot: SECURITY: Improve css javascript detection [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95542 (owner: 10CSteipp) [22:19:52] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [22:21:31] (03Merged) 10jenkins-bot: SECURITY: Don't cache when a call could autocreate [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95543 (owner: 10CSteipp) [22:22:53] (03Merged) 10jenkins-bot: Update Releasenotes and version number for 1.20.8 [core] (REL1_20) - 10https://gerrit.wikimedia.org/r/95544 (owner: 10CSteipp) [22:24:10] (03CR) 10Bsitu: [C: 031] Give extensions a chance to hide their (unrelated) log entries [core] - 10https://gerrit.wikimedia.org/r/92504 (owner: 10Matthias Mullie) [22:26:41] (03CR) 10Parent5446: [C: 032] Add --noredirects parameter to moveBatch.php [core] - 10https://gerrit.wikimedia.org/r/95535 (owner: 10leucosticte) [22:29:16] (03PS2) 10MaxSem: Rewrite of interaction with renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 [22:30:14] hashar: Noted. I only ran it for three events. [22:30:31] (03CR) 10CSteipp: [C: 032] SECURITY: Improve css javascript detection [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95538 (owner: 10CSteipp) [22:30:47] (03PS2) 10CSteipp: SECURITY: Don't cache when a call could autocreate [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95539 [22:32:28] qgil: So I'm supposed to talk to you about rabble-rousing MediaWiki events in Cambridge/Boston in March, in the case of me going to LibrePlanet. [22:33:17] oook marktraceur , I mjst learn about LibrePPlanet myself [22:33:51] * marktraceur can mostly parse that [22:34:21] marktraceur, it's a Turing test [22:34:29] (03PS1) 10CSteipp: SECURITY: Improve css javascript detection [core] - 10https://gerrit.wikimedia.org/r/95557 [22:34:34] (03Merged) 10jenkins-bot: Add --noredirects parameter to moveBatch.php [core] - 10https://gerrit.wikimedia.org/r/95535 (owner: 10leucosticte) [22:35:56] (03Merged) 10jenkins-bot: SECURITY: Improve css javascript detection [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95538 (owner: 10CSteipp) [22:37:04] (03PS1) 10CSteipp: SECURITY: Don't cache when a call could autocreate [core] - 10https://gerrit.wikimedia.org/r/95558 [22:37:19] Can someone https://gerrit.wikimedia.org/r/#/c/95147/ ("cache administrator is nobody")? [22:37:57] (03CR) 10CSteipp: [C: 032] "Deployed in produciton" [core] - 10https://gerrit.wikimedia.org/r/95557 (owner: 10CSteipp) [22:41:27] (03PS3) 10MaxSem: Rewrite of interaction with renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 [22:44:33] (03PS4) 10MaxSem: Rewrite of interaction with renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 [22:47:15] (03Merged) 10jenkins-bot: SECURITY: Improve css javascript detection [core] - 10https://gerrit.wikimedia.org/r/95557 (owner: 10CSteipp) [22:47:48] (03CR) 10CSteipp: [C: 032] SECURITY: Don't cache when a call could autocreate [core] - 10https://gerrit.wikimedia.org/r/95558 (owner: 10CSteipp) [22:48:19] (03CR) 10CSteipp: [C: 032] SECURITY: Don't cache when a call could autocreate [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95539 (owner: 10CSteipp) [22:51:34] (03Merged) 10jenkins-bot: SECURITY: Don't cache when a call could autocreate [core] - 10https://gerrit.wikimedia.org/r/95558 (owner: 10CSteipp) [22:51:47] (03CR) 10Mwalker: [C: 032] Remove old message file [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95364 (owner: 10MaxSem) [22:52:48] (03Merged) 10jenkins-bot: SECURITY: Don't cache when a call could autocreate [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95539 (owner: 10CSteipp) [22:53:17] (03Merged) 10jenkins-bot: Remove old message file [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95364 (owner: 10MaxSem) [22:53:52] (03PS2) 10CSteipp: Update Releasenotes and version number for 1.19.9 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95540 [22:57:37] (03CR) 10CSteipp: [C: 032] "Merging this to match tarball. One more update to follow." [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95540 (owner: 10CSteipp) [22:59:36] (03CR) 10Wikinaut: "Parent5446 wrote" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 (owner: 10Wikinaut) [22:59:53] (03Merged) 10jenkins-bot: Update Releasenotes and version number for 1.19.9 [core] (REL1_19) - 10https://gerrit.wikimedia.org/r/95540 (owner: 10CSteipp) [23:00:25] (03PS2) 10Wikinaut: redesigned Special:OpenIDLogin page uses 'disabled' input fields to show proposed account names [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95069 [23:00:57] (03CR) 10Wikinaut: [C: 04-2] "simply not ready for merging" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95069 (owner: 10Wikinaut) [23:01:13] (03CR) 10Ori.livneh: "> Is it by design that the bucketing overrides the storageEnabled configuration (and visa versa?)." [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [23:08:44] (03CR) 10Krinkle: "I agree. Though I'd prefer to keep the effective change and implementation refactor separate. So the arguments signatures as-is within thi" [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [23:11:05] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [23:16:57] (03PS1) 10EBernhardson: Hackish method of respecting parsoid base href [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 [23:19:04] (03CR) 10Ori.livneh: "Helper script for testing: https://gist.github.com/atdt/7476194 (easy to run in nodejs)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [23:20:16] (03CR) 10Mwalker: [C: 04-1] "(5 comments)" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 (owner: 10MaxSem) [23:21:25] (03CR) 10Werdna: [C: 032] Repair per-post topic history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95536 (owner: 10EBernhardson) [23:21:35] (03Merged) 10jenkins-bot: Repair per-post topic history [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95536 (owner: 10EBernhardson) [23:21:50] (03PS2) 10EBernhardson: Hackish method of respecting parsoid base href [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 [23:22:02] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [23:22:17] (03PS3) 10EBernhardson: Hackish method of respecting parsoid base href [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95563 [23:24:17] (03CR) 10Werdna: [C: 032] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [23:24:27] (03Merged) 10jenkins-bot: (bug 56808) Â â appearing sometimes, related to parsoid [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95430 (owner: 10Matthias Mullie) [23:24:54] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95356 (owner: 10IAlex) [23:27:07] (03PS1) 10Spage: minor LESS CSS fixes (zero units, dimensions) [core] - 10https://gerrit.wikimedia.org/r/95566 [23:28:09] (03PS5) 10MaxSem: Rewrite of interaction with renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 [23:28:14] (03PS1) 10EBernhardson: Always return unformatted content for unformatted posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95567 [23:33:16] (03CR) 10Krinkle: [C: 031] minor LESS CSS fixes (zero units, dimensions) [core] - 10https://gerrit.wikimedia.org/r/95566 (owner: 10Spage) [23:37:54] (03CR) 10Krinkle: [C: 04-1] "Actually, never mind. I'll squash it into this one." [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [23:37:57] (03CR) 10Mwalker: [C: 032] Rewrite of interaction with renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 (owner: 10MaxSem) [23:38:10] (03Merged) 10jenkins-bot: Rewrite of interaction with renderer [extensions/Collection] - 10https://gerrit.wikimedia.org/r/95483 (owner: 10MaxSem) [23:52:14] (03CR) 10Werdna: [C: 032] "I really don't like using the header to show board history, but that's for another day." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95553 (owner: 10Bsitu) [23:52:23] (03Merged) 10jenkins-bot: header is loading history style [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95553 (owner: 10Bsitu) [23:54:01] (03CR) 10Krinkle: "Cleaned up but did keep the separate $missing array because we need the list of non-missing modules in quite a few places:" [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [23:54:27] (03PS8) 10Krinkle: resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 [23:56:22] * Aaron|home runs update.php with posgres...gets Fatal error: Cannot redeclare class FakeMaintenance in E:\var\www\DevWiki\core\maintenance\Maintenance.php on line 1260 [23:56:49] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [23:57:36] (03CR) 10jenkins-bot: [V: 04-1] resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle)