[00:01:24] (03CR) 10Ori.livneh: "@Anomie: I'm not certain that I understand your point. Could you explain?" [core] - 10https://gerrit.wikimedia.org/r/94690 (owner: 10Tim Starling) [00:03:05] (03PS2) 10Ori.livneh: In Special:AllPages, limit the size of hierarchical lists [core] - 10https://gerrit.wikimedia.org/r/94690 (owner: 10Tim Starling) [00:03:41] marktraceur, I believe we both met paulproteus first the the WMF Tech Days / All Hands 2012. Just in case that matters. :) [00:03:48] (03CR) 10Ori.livneh: [C: 032] "PS2 rebases and strip tailing whitespace from one line." [core] - 10https://gerrit.wikimedia.org/r/94690 (owner: 10Tim Starling) [00:04:19] qgil: No, SCaLE 9x was in 2011 [00:04:28] Oh, you mean jointly [00:04:52] (03PS2) 10Wikinaut: Bug 54677: Do account creation checks when creating users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 [00:07:57] (03Merged) 10jenkins-bot: In Special:AllPages, limit the size of hierarchical lists [core] - 10https://gerrit.wikimedia.org/r/94690 (owner: 10Tim Starling) [00:09:54] (03PS3) 10Wikinaut: Bug 54677: (partial) check email addresses Sanitizer::validateEmail() [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 [00:10:58] (03PS3) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [00:11:03] (03CR) 10Wikinaut: [C: 031 V: 031] Bug 54677: (partial) check email addresses Sanitizer::validateEmail() [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 (owner: 10Wikinaut) [00:13:14] (03CR) 10Wikinaut: [V: 032] Bug 54677: (partial) check email addresses Sanitizer::validateEmail() [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076 (owner: 10Wikinaut) [00:17:54] (03PS1) 10Cmcmahon: VE takes a long time to appear [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95078 [00:25:29] (03PS1) 10Aaron Schulz: Removed unused expandText() method [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/95080 [00:27:24] (03PS2) 10Parent5446: Fixed stream wrapper in PhpHttpRequest [core] - 10https://gerrit.wikimedia.org/r/91393 [00:28:30] (03CR) 10Parent5446: "PS2: Fixed everything. Also made the formatting a little nicer. I fully tested this one (luckily https://www.us.army.mil/ is a nice test s" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [00:29:27] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [00:32:01] (03PS5) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [00:32:51] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95075 (owner: 10Legoktm) [00:34:54] (03PS6) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [00:36:28] (03Draft6) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [00:39:20] (03CR) 10Parent5446: [C: 04-1 V: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [00:42:03] (03CR) 10Gergő Tisza: [C: 04-1] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [00:44:24] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [00:45:47] (03PS5) 10Ori.livneh: resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [00:46:20] bd808: https://gerrit.wikimedia.org/r/#/c/95080/1 easy [00:47:36] Aaron|home: anything I should test? Or can I just trust that you already ran the grep? [00:48:49] testing=running grep ;) [00:49:12] * Aaron|home is going to make a real commit soon [00:51:27] (03CR) 10BryanDavis: [C: 032] Removed unused expandText() method [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/95080 (owner: 10Aaron Schulz) [00:54:12] (03PS1) 10Aaron Schulz: Avoid silly double-parse bug [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/95083 [00:55:09] (03CR) 10Ori.livneh: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [00:55:29] TimStarling: want to look at https://gerrit.wikimedia.org/r/#/c/95083/1 ? [00:55:51] (03CR) 10Aaron Schulz: [V: 032] Removed unused expandText() method [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/95080 (owner: 10Aaron Schulz) [01:01:20] (03PS1) 10Ori.livneh: In Special:AllPages, limit the size of hierarchical lists [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95084 [01:01:25] (03CR) 10Krinkle: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/90320 (owner: 10Krinkle) [01:01:51] (03PS1) 10Ori.livneh: In Special:AllPages, limit the size of hierarchical lists [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95085 [01:01:54] (03PS6) 10Krinkle: resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 [01:02:33] (03PS1) 10Manybubbles: Always fork Cirrus LinksUpdate behavior [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95086 [01:02:50] (03CR) 10Krinkle: [C: 031] "Looks good." [core] - 10https://gerrit.wikimedia.org/r/95070 (owner: 10Ori.livneh) [01:04:01] (03PS4) 10Parent5446: Fix extension functionality and backwards compatibility [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 [01:04:09] (03CR) 10Parent5446: "(4 comments)" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 (owner: 10Parent5446) [01:04:20] (03CR) 10Ori.livneh: [C: 032] In Special:AllPages, limit the size of hierarchical lists [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95084 (owner: 10Ori.livneh) [01:04:55] (03CR) 10Ori.livneh: [C: 032] In Special:AllPages, limit the size of hierarchical lists [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95085 (owner: 10Ori.livneh) [01:09:02] awight: woot, thanks for the vagrant commits [01:09:12] ori-l: it's awesome! [01:09:34] Fundraising has so.. many.. moving parts. [01:09:55] * marktraceur vouches for that [01:09:56] (03PS2) 10Aaron Schulz: Avoid silly double-parse bug [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/95083 [01:10:02] greg-g: I'd like to backport https://gerrit.wikimedia.org/r/#/c/91844/ to wmf3 later today. Is there a spot available for me? [01:10:08] btw, I noticed that php5-redis does not exist for i386 [01:10:11] ori-l: does that look OK? [01:10:24] are we maintaining the amd64 package? [01:11:13] awight: yes http://apt.wikimedia.org/wikimedia/pool/main/p/php5-redis/ [01:11:45] aargh [01:11:48] k, thank you [01:11:52] heh, np [01:12:13] (03Merged) 10jenkins-bot: In Special:AllPages, limit the size of hierarchical lists [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95084 (owner: 10Ori.livneh) [01:12:46] ori-l: I was hoping to bump the guest OS down to 32-bit, unless you can think of a reason not to? [01:13:55] (03Merged) 10jenkins-bot: In Special:AllPages, limit the size of hierarchical lists [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95085 (owner: 10Ori.livneh) [01:14:16] Oh, for the java install? [01:14:28] Oh, no, not paying attention [01:14:34] * marktraceur stops worrying about it [01:14:39] I was hoping it would improve memory usage, tho it appears to not be the case [01:17:26] (03PS1) 10Krinkle: Add rc.unpatrolled to the recentchanges API [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95088 [01:17:27] Where is the config for apt.wikimedia.org builds? [01:17:58] (03PS1) 10Krinkle: Add rc.unpatrolled to the recentchanges API [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95089 [01:17:59] awight: not sure off the top of my head [01:18:04] re: 64 v 32 [01:18:11] cool [01:18:19] if there is a principled reason to switch i'm not opposed to it [01:18:36] not really. results were that memory usage is the same [01:18:58] the only real reason would be that we have devs on 32-bit host boxen [01:19:04] which is possible [01:19:10] but unlikely [01:19:11] Krinkle: later today? it's already 5pm? [01:19:24] greg-g: not where I live ;-) [01:19:35] Krinkle: sure, but for our deploy calendar it is [01:19:45] ie: most ops are either asleep or drinking soon [01:20:02] s/drinking/whatever it is they do at night/ [01:20:07] greg-g: argh, i deserve the heat for that [01:20:14] i explicitly invited the change to piggy back [01:20:56] i noticed the request just as i was gearing up to sync the allpages change [01:21:02] so, ori's is a bug fix that will remove 30sec+ queries on our slave dbs, this other one is a "new feature" (broadly defined) [01:21:06] you can see where I'm goign with this [01:21:28] greg-g: OK, that's news for me for mw-core lightning changes (deploys during ops/office hours only), but I'll keep that in mind [01:21:59] Krinkle: not really news [01:22:00] it's my screwup, sorry to both [01:22:02] of you [01:22:14] at least, that's what I was told when I joined [01:22:35] and I was yelled at by ops, enough so that leslie added "NO DEPLOYS" recurring events from 5pm-10am every day [01:22:47] k :) [01:22:53] * ori-l falls on his sword [01:22:59] (which I removed becuase it was noisy) [01:23:45] before our deployment calendar, Reedy, Roan and I used to backport quite frequently during whatever hours we're awake. Of course the rule of attending at least an hour after sync still rules, but afaik it never made an availability link with ops. This is the first I've heard that, but I'm not opposing it :) [01:24:02] especially since most of our working hours are outside sf hours. [01:24:14] yeah, things are different now :) [01:24:22] sorry for the confusion/whatever [01:24:34] I respect your ability and all that, it isn't about that [01:24:45] and I respect your historical precendet [01:24:54] yeah, no worries. Just trying to shrug the "good ol' wild times" feeling. [01:24:54] just, ya know, we're trying to be different now :) [01:24:58] yeah [01:25:00] I hear ya [01:25:12] alright, I have a kid who's jumping off a bookcase next to me [01:25:15] have a good night! [01:25:58] even Math.random() can end up hitting between 9am and 5pm many times in a row. This is the first time I asked for a deploy after 5pm :) [01:26:11] thx [01:26:28] Sorry, again. [01:29:09] Krinkle: Nowadays if you want to deploy something small, you ask Greg for a lightning deploy window (these are daily except Fridays, 4pm-5pm) [01:29:34] (with multiple people potentially sharing the window on an as-needed basis) [01:31:19] You should fix that parenthetical. [01:31:29] Monday through Thursday, not daily. [01:31:37] grammer police! [01:31:39] And 4 p.m. to 5 p.m. in PST or something. [01:31:59] Clarifying that it doesn't include the weekend (Saturday and Sunday) isn't grammar policing. ;-) [01:32:00] * awight hides the semicolons [01:32:12] Don't worry, kids. [01:32:14] I have extras. [01:32:18] Semicolons for all. [01:32:28] freesemicolons.org [01:32:48] The global moment, set them free! [01:33:07] ;;;;;;;;;;;;;;;;;;;;;;;! [01:33:09] When I hear that ULS was doing 41% of API requests or many other strange situations, I wonder what the purpose of limiting deploys to SF working hours is. [01:33:12] reminds me of https://github.com/madrobby/semicolon.js [01:33:12] Yeah, Mon-Thu 4pm-5pm P(S|D)T [01:33:43] Elsie: how are the two facts related? [01:33:58] "Exceptions know no timezone"? [01:34:00] That all kinds of crazy shit gets deployed regularly. [01:34:09] The time of day isn't relevant. [01:34:13] It's the code being pushed out. [01:34:16] And who's pushing it. [01:34:20] * * <%= timeshift(4-17) %> 1-5 * [01:34:30] And a million other uncontrollable factors. [01:34:42] Yeah deployment scheduling is no magic bullet [01:34:54] It just seems strange to adhere to Greg being around. [01:34:57] But there's enough deployment traffic that it makes sense for some regulation to be in place to prevent collisions [01:35:12] Sure. [01:35:15] But an IRC channel does that. [01:35:22] As do the log notifications. [01:35:25] * Elsie shrugs. [01:35:37] Not well enough in practice, apparently [01:36:05] Are there collisions? [01:36:20] All things considered, I'd consider eagerness to get code deployed a good problem to have. [01:36:34] Greg was talking about some push bot thing. [01:37:19] (03PS5) 10Parent5446: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [01:37:20] Maybe he's taking the contract and re-expand approach, but it seems a bit... I dunno. I trust the people who can deploy to do it when they're awake and sober-ish. [01:38:50] greg-g: Scrollback in here. ^^ [01:42:18] (03PS4) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [01:44:08] (03CR) 10Parent5446: "Uh, git-review done fucked up. Let me fix this." [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [01:45:29] (03PS6) 10Parent5446: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [01:46:52] (03PS3) 10Parent5446: Fixed stream wrapper in PhpHttpRequest [core] - 10https://gerrit.wikimedia.org/r/91393 [01:46:59] (03PS2) 10Bsitu: Trim trailing empty white space in block content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95056 [01:47:51] (03PS3) 10Bsitu: Trim trailing empty white space in block content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95056 [01:57:56] (03CR) 10Mattflaschen: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [02:28:11] (03PS1) 10Brian Wolff: Purge user css/js when not for a skin [core] - 10https://gerrit.wikimedia.org/r/95095 [02:30:16] (03PS2) 10Legoktm: Add GetLogTypesOnUser hook [core] - 10https://gerrit.wikimedia.org/r/95075 [02:31:19] (03CR) 10Legoktm: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95075 (owner: 10Legoktm) [02:33:58] (03CR) 10Mattflaschen: "I don't think it's depending on the actual value. It has:" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [02:37:38] (03CR) 10Mattflaschen: "Yes, I do want to exclude CSS files, and I also want to do a recursive search. As expected modules/*.js is not recursive (it wouldn't fit" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [02:39:41] (03CR) 10Parent5446: [C: 032] Add GetLogTypesOnUser hook [core] - 10https://gerrit.wikimedia.org/r/95075 (owner: 10Legoktm) [02:41:29] marktraceur: for betafeatures, did you ever look into how to add something to the p-tools menu without using javascript? [02:41:55] Uh [02:41:57] It should do that now [02:42:12] * legoktm re-looks at the code [02:42:35] ohlol [02:42:36] // TODO: Find a less painful way of doing this. [02:42:43] (03Merged) 10jenkins-bot: Add GetLogTypesOnUser hook [core] - 10https://gerrit.wikimedia.org/r/95075 (owner: 10Legoktm) [02:43:04] legoktm: https://git.wikimedia.org/blobdiff/mediawiki%2Fextensions%2FBetaFeatures/f8734a2788cb82d36911cbd7d217c6b57141da90/BetaFeaturesHooks.php [02:43:10] already looking there :P [02:43:14] thanks [02:43:21] i'm going to just modify your stuff [02:43:28] That's still there [02:44:27] <3 legoktm you wonderful thing. (marktraceur , he's fixing (or at least looking at) Echo bugs :) [02:44:33] Ah, right, because I had to fuck around with the order of the array [02:44:37] quiddity: Fun times! [02:44:45] And agreed, he is wonderful. [02:45:23] i think i need food. I appear to be babbling deliriously in various places... >.> [02:45:24] :) [02:46:30] (03PS1) 10Legoktm: Add handler for GetLogTypesOnUser hook [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/95097 [02:47:01] it would be cool if there was a script that automagically added documentation for a new hook. [02:47:22] otherwise I'll write one [02:47:45] (03CR) 10Mattflaschen: "Not sure. 068250313c952b2c0a487592305d382175b350c1 says, "default to pkg ensure present instead of to a specific version". That doesn't " [vagrant] - 10https://gerrit.wikimedia.org/r/94947 (owner: 10Adamw) [02:52:00] Aaron|home: what in FlaggedRevs was triggering the other parse? [02:52:20] alternatively, did you test it? [02:52:42] I just want to be able to verify that it fixes the bug you think it fixes [02:55:28] TimStarling: you can var_dump( $article ); before the $article->prepareContentForEdit() call autoReviewEdit() and see that mPreparedEdit was false [02:56:36] marktraceur: does wfArrayInsertAfter do what you need? [02:56:39] the fix actually carries over the output object to that point [02:56:41] thats how echo does it [02:57:00] *call in [02:57:04] ...damn, legoktm, why must you destroy my hopes and dreams [02:57:11] Also why is that a wf function [02:57:14] That sounds very wrong [02:57:48] heh [02:58:32] Let me try it. [02:59:29] luckily, I'm just going to modify an existing link, not add a new one [03:00:13] (03CR) 10Tim Starling: [C: 032] Avoid silly double-parse on edit bug [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/95083 (owner: 10Aaron Schulz) [03:00:17] legoktm: I think...it looks like this might only work for numeric arrays [03:00:20] I'm not sure though [03:00:47] marktraceur: well, this is what echo does: https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/Hooks.php#L681 [03:01:11] Hm [03:01:14] Seems like it would work [03:01:16] (03CR) 10Aaron Schulz: [V: 032] Avoid silly double-parse on edit bug [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/95083 (owner: 10Aaron Schulz) [03:01:20] I mean, it does. [03:01:23] So yeah [03:01:28] I guess we'll do that now [03:02:30] :D [03:04:07] (03PS2) 10Bsitu: Increase default size of expanded text field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95052 [03:07:33] (03PS1) 10MarkTraceur: Use existing global function for inserting personal link [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95100 [03:07:35] +7 -31, that's what I like to see [03:07:38] legoktm: ^^ [03:07:45] woot [03:07:52] i'll test it as soon as i fix this echo bug [03:08:00] Merci bocoup [03:08:38] Maybe I should stick my terrible and incomplete UI redesign on multimedia-alpha. That sounds like fun. [03:10:08] Grr, but pginer isn't around. [03:10:20] Curse timezones [03:13:25] (03PS1) 10Bsitu: Clicking on pencil icon keeps adding new header form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95101 [03:17:54] (03PS1) 10Legoktm: Add new messages indicator from a hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 [03:18:17] Gerrit requires a JavaScript enabled browser. :< [03:18:32] marktraceur: i will take a look when i get back from dinner [03:18:36] bbl [03:18:36] legoktm: Is there a non-js part of gerrit? [03:19:14] bawolff: Yes. All of it. [03:19:48] I was under the impression that there was no html under that massive load of javascript [03:20:04] bawolff: You're absolutely right, it's all SVG made to look like HTML [03:20:34] meh, wouldn't surprise me - the back end is written in prolog [03:20:42] like really, prolog?! [03:20:45] By having a straight XML document, a complicated XSLT stylesheet to transform what looks like HTML into SVG, and then JavaScript to perform actions on click events [03:20:52] bawolff: I thought it was all Java? [03:22:23] Oh hmm, maybe its mostly java. Googling suggests there are parts that are prology - https://gerrit-review.googlesource.com/Documentation/prolog-cookbook.html [03:22:51] * bawolff actually thinks prolog is a pretty cool language all things considered [03:23:14] Its one of the few languages I've ever learned that were totally not like anything I had seen before [03:23:45] Well yeah [03:23:50] It's a totally different paradigm [03:24:50] Everything else I've ever touched has pretty much been imperative or object orientied. Rather different mind set required [03:25:37] bawolff: Tried lisp? :) [03:25:56] I've had minor amounts of interaction [03:26:19] I've tried lambda calculus :P [03:27:17] In prolog, you're less programming and more setting up a giant graph where some of the nodes have side effects, and telling the computer to go depth-first-search it [03:27:23] or at least that's how I think of it [03:27:34] Heh [03:29:12] hi folks, is this the right place to ask about ios wikitext libraries? [03:30:38] * bawolff didn't even know there was such a thing [03:30:58] aidano1011: If that's something the mobile team is doing, you can also try at #wikimedia-mobile [03:31:35] baworlff: that's what i'm wondering :) do i build one myself, or did someone already to this. [03:31:45] i'll check that channel out. thanks [03:32:00] *do this* [03:32:37] aidano1011: Oh, as in you want a wikitext parsing library? /me still doesn't know the answer though [03:33:06] yep [03:33:28] so i can render to something other than html, say [03:33:39] You may want to check out parsoid [03:34:02] aidano1011: are you planning on building an iOS App? [03:34:03] If you're doing offline wikitext type project, you might also want to look at the kwiki project [03:34:27] YuviPanda: yes [03:34:49] I'm from the mobile apps team, we just started revamping our exiting mobile apps [03:35:00] by completely ditching the current phonegap one [03:35:04] and redoing them natively [03:35:23] aidano1011: we are using the API to fetch HTML, and then using webviews to display it. [03:35:44] aidano1011: check out action=mobileview in the API [03:36:27] YuviPanda:that's great. i was using a google mobile proxy before. i suspect yours will look better :) [03:36:27] aidano1011: I think directly parsing wikitext on a mobile device is a dead end - you need to do like hundreds (sometimes thousands?) of network calls to even fully render a page like Obama or India, I think [03:36:35] there was a google mobile proxy? [03:36:41] bawolff: thanks, those projects look interesting [03:36:46] yep, still is in fact [03:37:21] suggest playing around with the API on https://en.wikipedia.org/wiki/Special:ApiSandbox [03:37:27] what it creates is pretty ugly though. not good enough for 2013 [03:37:29] documentation etc is linked from there [03:37:42] thanks! [03:39:11] aidano1011: yw [03:39:32] aidano1011: mhurd and brion are rebuilding the iOS app - they aren't around now, but will be during PST [03:39:37] I do the android stuff [03:41:13] ah, cool. do you guys work together on maintaining consistency between android and iOS? [03:41:35] aidano1011: sortof. we don't know yet [03:41:46] there will be a good amount of consistency I believe [03:48:16] that's great. good luck with it. looking forward to seeing what you create - when's your first release or the rewrite? [03:48:26] *of* the rewrite [03:48:37] aidano1011: we're two weeks in only, so a few months off I'd think [03:49:07] aidano1011: we'll send announcements to https://lists.wikimedia.org/mailman/listinfo/mobile-l so if you subscribe... [03:49:14] aidano1011: plus all our code is open source anyway [03:50:16] i'll check it out [03:50:59] aidano1011: ok! [04:06:30] marktraceur: ok, reviewing now [04:08:45] (03PS2) 10Ori.livneh: looks like operations/puppet is back to mainline redis [vagrant] - 10https://gerrit.wikimedia.org/r/94947 (owner: 10Adamw) [04:09:36] (03CR) 10Legoktm: [C: 032] "Yay!" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95100 (owner: 10MarkTraceur) [04:09:41] (03Merged) 10jenkins-bot: Use existing global function for inserting personal link [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/95100 (owner: 10MarkTraceur) [04:09:57] (03CR) 10Ori.livneh: [C: 032] Replace version-specific redis package ensure property with generic 'present' [vagrant] - 10https://gerrit.wikimedia.org/r/94947 (owner: 10Adamw) [04:10:00] (03Merged) 10jenkins-bot: Replace version-specific redis package ensure property with generic 'present' [vagrant] - 10https://gerrit.wikimedia.org/r/94947 (owner: 10Adamw) [04:11:06] (03PS11) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [04:11:18] (03CR) 10jenkins-bot: [V: 04-1] Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [04:12:23] (03PS12) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [04:13:19] legoktm: Did you ever know that you're my heeeeero [04:13:24] :) [04:20:57] quiddity: I'm going to try and kill your list of top 10 echo bugs now. [04:44:44] (03PS1) 10Aude: Remove unnecessary Wikibase dependencies and stuff not in Gerrit now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 [04:52:47] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/95095 (owner: 10Brian Wolff) [04:53:23] (03CR) 10Krinkle: [C: 031] Rather than upsert module store, explicitly remove old value and then add new one [core] - 10https://gerrit.wikimedia.org/r/94959 (owner: 10Ori.livneh) [04:54:36] Elsie: yeah, there's this neat irc pushbot thingy that I haven't yet setup... helps with the queuing [05:00:22] We've discussed a bot to auto-merge (and deploy, I guess) code that sits unreviewed for more than month. [05:00:25] It's a popular idea. [05:00:42] a month * [05:00:43] heh [05:00:53] no objections? push! [05:01:19] No objections? Push! * [05:01:42] Krinkle: around? [05:02:38] aude: I'll have to disappear for a week or so to take care of an exam. Hopefully brion (or addshore?) can get that patch merged after adding tests in the meantime. [05:02:42] (03PS2) 10Aude: Remove unnecessary Wikibase dependencies and stuff not in Gerrit now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 [05:02:49] just a headsup on me disappearing :) [05:03:05] YuviPanda: awww [05:03:08] don't disappear :) [05:03:23] but okay, we can work with brion and addshore on the patch [05:03:58] aude: I'll still read bugmail and gerritmail and stuff [05:04:03] will just try to stay off IRC [05:04:25] although considering I've about 7 unmerged android patches just from today, that might not be easy [05:04:30] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [05:06:28] YuviPanda: ok [05:06:51] aude: did the perf problems with the terms table get sorted out? [05:07:24] not yet [05:07:27] working on it [05:07:35] legoktm, :o and, every dent in that list will be hugely appreciated. Let me know if anything is unclear. [05:07:46] also working to get us access to these tools :) [05:07:55] aude: ah. no ldap group yet? [05:08:10] quiddity: I will :D [05:17:21] (03CR) 10Aude: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [05:17:34] legoktm: & [05:17:37] ^ [05:19:46] (03CR) 10Legoktm: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [05:19:52] aude: responded [05:23:03] (03CR) 10Aude: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [05:23:24] k [05:40:28] (03Draft5) 10Aude: Link "You have new messages" to user talk diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 [05:41:20] (03PS1) 10Pastakhov: add 'extNumberFormat' function for extension Foxway ( version 0.6.1 ) [extensions/NumberFormat] - 10https://gerrit.wikimedia.org/r/95111 [05:43:07] (03PS1) 10Legoktm: Standardize spacing [core] - 10https://gerrit.wikimedia.org/r/95112 [05:43:27] (03CR) 10Legoktm: [C: 032] "Trivial" [core] - 10https://gerrit.wikimedia.org/r/95112 (owner: 10Legoktm) [05:45:54] heh [05:46:08] so i wrote something to parse docs/hooks.txt into a python dict [05:46:34] o.O [05:47:12] so now I'm going to get it to autocreate Manual:Hooks/Name pages for the ones that are missing [05:48:26] (03Merged) 10jenkins-bot: Standardize spacing [core] - 10https://gerrit.wikimedia.org/r/95112 (owner: 10Legoktm) [05:49:46] I need a way to figure out what version a hook was introduced in though. [05:53:29] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94489 (owner: 10Gerrit Patch Uploader) [06:09:53] (03CR) 10Yurik: [C: 04-1] "I agree in principal, but per ParentNNNN comments - should fix the "keys" instead of duplicating them." [core] - 10https://gerrit.wikimedia.org/r/93075 (owner: 10MaxSem) [06:11:17] (03CR) 10Werdna: [C: 032] Trim trailing empty white space in block content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95056 (owner: 10Bsitu) [06:11:33] (03Merged) 10jenkins-bot: Trim trailing empty white space in block content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95056 (owner: 10Bsitu) [06:29:35] (03CR) 10Werdna: [C: 032] Make actions box available to non-JS users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94877 (owner: 10Matthias Mullie) [06:29:44] (03Merged) 10jenkins-bot: Make actions box available to non-JS users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94877 (owner: 10Matthias Mullie) [06:31:56] yeee https://www.mediawiki.org/wiki/Manual:Hooks/GetLogTypesOnUser [06:32:01] magic! [06:43:14] (03CR) 10IAlex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [07:03:23] (03PS2) 10Ori.livneh: Expanded use of reauthenticateConnection() beyond just Lua calls [core] - 10https://gerrit.wikimedia.org/r/94935 (owner: 10Aaron Schulz) [07:04:03] (03PS1) 10Werdna: Refactor editor selection code to be less hardcoded. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95115 [07:09:09] (03CR) 10Hashar: "I can't really review OCAML beside adding/removing changes to a pattern match and the most simple/obvious changes." [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [07:22:50] * Nemo_bis throws flowers at aude for her new messages patch [07:25:39] (03PS1) 10Legoktm: Fix false positive in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/95116 [07:26:08] someone who is bored should merge that ^ [07:27:42] (03CR) 10Nemo bis: "Thanks, Matt. Siebrand, is that ok for you? If not I can perhaps replace helppage with another random message containing int, or a made up" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [07:31:40] (03CR) 10Mattflaschen: "Yeah, a made-up message name would also be fine, and would avoid the issue here." [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [07:33:50] Lol, this is what I get for checking out the first ever commit to phase3/|mediawiki/core... Open up core to check out something, end up staring at the codebase thinking "what happened to docs/hooks.txt" and also "WTF is this rdf/recent.phtml!" [07:34:01] (03CR) 10Werdna: [C: 032] Increase padding inside wikitext reply box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94953 (owner: 10EBernhardson) [07:34:11] (03Merged) 10jenkins-bot: Increase padding inside wikitext reply box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94953 (owner: 10EBernhardson) [07:34:56] (03CR) 10Werdna: [C: 032] Increase default size of expanded text field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95052 (owner: 10Bsitu) [07:35:10] (03Merged) 10jenkins-bot: Increase default size of expanded text field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95052 (owner: 10Bsitu) [07:35:13] Can't say there's nothing I dislike in recent changes... but MW hasn't gone that downhill ;) lol [07:47:56] (03PS3) 10Wikinaut: adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 [07:48:21] (03PS4) 10Wikinaut: adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 [07:49:13] (03CR) 10Aaron Schulz: [C: 032] Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 (owner: 10Chad) [07:50:16] * Aaron|home find himself reviews commits at 11:50PM while listening to What is Love [07:52:11] (03Merged) 10jenkins-bot: Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 (owner: 10Chad) [07:52:12] (03Merged) 10jenkins-bot: Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 (owner: 10Chad) [07:52:37] (03PS2) 10Werdna: Clicking on pencil icon keeps adding new header form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95101 (owner: 10Bsitu) [07:53:39] (03CR) 10Werdna: "I moved the check to in the setupEditForm function, and removed the pencil icon altogether when the header is being edited (which is what " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95101 (owner: 10Bsitu) [07:55:35] Aaron|home: Baby don't me… [07:56:35] * Aaron|home is already on Aqueous Transmission [08:31:20] (03CR) 10Hashar: "Sorry forgot to follow up. Can you put the unlink() calls in a new methods which we would call from our PHPUnit test ? I would like to no" [core] - 10https://gerrit.wikimedia.org/r/86218 (owner: 10Aaron Schulz) [08:43:23] Nikerabbit, does https://gerrit.wikimedia.org/r/#/c/94965/ look good? [08:48:20] MaxSem: yep [08:48:36] +2?:) [08:48:37] MaxSem: siebrand notes that big i18n files still are a performance problem, but this file is still small I think [08:49:11] you have some plans to move away from messages in PHP, right? [08:49:28] MaxSem: yep [08:54:26] Nikerabbit, can you +(1|2) on that change?:) [08:57:10] (03CR) 10Nikerabbit: [C: 031] "Size of i18n files do still matter, however ~200 lines for definitions is still reasonable imho." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94965 (owner: 10MaxSem) [08:57:33] thanks;) [09:00:56] (03PS46) 10Frédéric Wang: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [09:01:11] (03CR) 10jenkins-bot: [V: 04-1] Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [09:11:21] (03Abandoned) 10Hashar: Do not use colors by default for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/88984 (owner: 10Jeroen De Dauw) [09:13:50] !i18n [09:13:50] See http://www.mediawiki.org/wiki/Internationalisation for developer help on MediaWiki internationalisation. To translate MediaWiki in another language, please visit http://translatewiki.net [09:14:10] can someone please tell me what is i18n [09:14:50] mayankmadan_: Internationalization - i18n is a short form for that [09:15:14] so, translating? [09:15:31] mayankmadan_: no, it is localization [09:16:07] mayankmadan_: https://en.wikipedia.org/wiki/Internationalization_and_localization [09:27:36] (03CR) 10Addshore: [C: 031] Remove unnecessary Wikibase dependencies and stuff not in Gerrit now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 (owner: 10Aude) [09:34:21] mayankmadan_: and since they are so long to write, folks came out with abbreviations l10n and i18n where the number is the count of letters :-] [10:11:38] (03PS4) 10Spage: Demonstrate use of oo-ui [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 [10:28:41] (03PS1) 10Shirayuki: Fix grammar of flow-rev-message-reply-bundle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95128 [10:31:02] (03PS1) 10Ori.livneh: Controlled experiment to assess performance of module storage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/95129 [10:31:48] (03CR) 10Ori.livneh: "(1 comment)" [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 (owner: 10Spage) [10:36:54] (03PS1) 10Shirayuki: Fix grammar of the message "smoothgallery-no-images" [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/95130 [10:37:56] (03CR) 10Ori.livneh: "Oh, awesome! I see a bunch of TODOs -- should I hold off on reviewing this or are you looking for some feedback?" [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [10:42:08] (03PS1) 10Hashar: .gitreview file for integration/phpcs [integration/phpcs] - 10https://gerrit.wikimedia.org/r/95132 [10:42:10] (03PS1) 10Hashar: README.md and composer.json [integration/phpcs] - 10https://gerrit.wikimedia.org/r/95133 [10:42:12] (03PS1) 10Hashar: php codesniffer 1.4.7 [integration/phpcs] - 10https://gerrit.wikimedia.org/r/95134 [10:42:24] (03CR) 10Hashar: [C: 032 V: 032] php codesniffer 1.4.7 [integration/phpcs] - 10https://gerrit.wikimedia.org/r/95134 (owner: 10Hashar) [10:42:26] (03CR) 10Hashar: [C: 032 V: 032] .gitreview file for integration/phpcs [integration/phpcs] - 10https://gerrit.wikimedia.org/r/95132 (owner: 10Hashar) [10:42:28] (03CR) 10Hashar: [C: 032 V: 032] README.md and composer.json [integration/phpcs] - 10https://gerrit.wikimedia.org/r/95133 (owner: 10Hashar) [10:50:42] (03PS47) 10Frédéric Wang: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [10:52:54] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 (owner: 10Aude) [10:55:27] (03CR) 10Aude: "(1 comment)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 (owner: 10Aude) [10:57:07] (03PS1) 10Aude: Remove jobs for extensions no longer in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95138 [10:58:57] (03CR) 10Hashar: [C: 032] "Thank you!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 (owner: 10Aude) [11:01:00] (03PS3) 10Hashar: Remove unnecessary Wikibase dependencies and stuff not in Gerrit now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 (owner: 10Aude) [11:01:06] (03CR) 10Hashar: [C: 032] Remove unnecessary Wikibase dependencies and stuff not in Gerrit now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 (owner: 10Aude) [11:01:35] (03Merged) 10jenkins-bot: Remove unnecessary Wikibase dependencies and stuff not in Gerrit now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95106 (owner: 10Aude) [11:03:02] (03CR) 10Hashar: [C: 032] "Gone they are :) thx!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95138 (owner: 10Aude) [11:03:08] (03Merged) 10jenkins-bot: Remove jobs for extensions no longer in gerrit [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95138 (owner: 10Aude) [11:04:03] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/95138 (owner: 10Aude) [11:21:44] (03PS6) 10Aude: Link "You have new messages" to user talk diff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94506 [11:30:19] hashar: poke [11:31:15] hashar: you saw my fix in jenkins-debian-glue? [11:32:03] AzaToth: nop [11:32:35] hashar: https://github.com/mika/jenkins-debian-glue/commits/master [11:32:50] hashar: makes it read gbp.conf for branches [11:34:16] hashar: https://github.com/mika/jenkins-debian-glue/blob/master/scripts/generate-git-snapshot#L97-L137 [11:34:48] and #L311-L319 [11:35:43] (03PS1) 10IAlex: Fix one more profiling error from I0a9a7f10ea (f5a0c23) [core] - 10https://gerrit.wikimedia.org/r/95141 [11:35:55] hashar: so if you could update jenkins-debian-glue, that would be great! [11:39:21] niiiice [11:42:57] AzaToth: https://gerrit.wikimedia.org/r/#/c/91506/ bumps debian glue to v0.7.0 [11:43:33] we would need a new change following that [11:43:39] that would merge upstream and bump the version [11:43:59] aka from git-describe v0.7.1-6-gf618f4d [11:45:00] (03CR) 10Daniel Kinzler: [C: 032] Fix WikitextContentHandlerTest::testMakeRedirectContent() when content language is not english [core] - 10https://gerrit.wikimedia.org/r/94892 (owner: 10IAlex) [11:47:59] (03Merged) 10jenkins-bot: Fix WikitextContentHandlerTest::testMakeRedirectContent() when content language is not english [core] - 10https://gerrit.wikimedia.org/r/94892 (owner: 10IAlex) [12:03:25] (03CR) 10Zfilipin: [C: 031] VE takes a long time to appear [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95078 (owner: 10Cmcmahon) [12:12:59] (03PS2) 10IAlex: Fix false positive in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/95116 (owner: 10Legoktm) [12:13:05] (03CR) 10IAlex: [C: 032] Fix false positive in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/95116 (owner: 10Legoktm) [12:19:18] (03Merged) 10jenkins-bot: Fix false positive in findHooks.php [core] - 10https://gerrit.wikimedia.org/r/95116 (owner: 10Legoktm) [12:23:35] (03CR) 10Helder.wiki: [C: 04-1] "See:" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94954 (owner: 10MaxSem) [12:27:14] (03CR) 10MaxSem: "You don't seem to understand - mwlib will die in 2 weeks and the new renderer will *not* have a template blacklist, like it or not." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94954 (owner: 10MaxSem) [12:31:11] can anyone tell me where to go inside the translate extension to get the source code for https://bugzilla.wikimedia.org/show_bug.cgi?id=55389 [12:34:06] Lekshmi, what have you tried to find it? [12:37:44] I have tried to find the file using grep to find words listed in the code given in the bug [12:40:02] (03CR) 10Siebrand: [C: 032 V: 032] "yay!" [extensions/SmoothGallery] - 10https://gerrit.wikimedia.org/r/95130 (owner: 10Shirayuki) [12:40:59] (03CR) 10Siebrand: [C: 032] Fix grammar of flow-rev-message-reply-bundle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95128 (owner: 10Shirayuki) [12:41:11] (03Merged) 10jenkins-bot: Fix grammar of flow-rev-message-reply-bundle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95128 (owner: 10Shirayuki) [12:44:11] Lekshmi, ack "Other languages" => points to message tpt-languages-legend in PageTranslation.i18n.php. looking for it in other files yields tag/PageTranslationHooks.php line 323 [12:58:42] (03Restored) 10Jeroen De Dauw: Do not use colors by default for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/88984 (owner: 10Jeroen De Dauw) [12:59:18] (03CR) 10Jeroen De Dauw: "My OS supports ANSI. I just don't want colours in one particular window" [core] - 10https://gerrit.wikimedia.org/r/88984 (owner: 10Jeroen De Dauw) [13:01:13] omg 3RR [13:02:16] (03Abandoned) 10Hashar: Do not use colors by default for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/88984 (owner: 10Jeroen De Dauw) [13:04:45] * MaxSem drags JeroenDeDauw and hashar to arbcom:P [13:05:41] (03PS2) 10Nikerabbit: Add a class to interlanguage links [core] - 10https://gerrit.wikimedia.org/r/94899 (owner: 10Amire80) [13:13:59] arbcom is dangerous enemy indeed, soon it may also be able to get a copy of your passport if they wish [13:47:08] (03PS1) 10Gergő Tisza: Add LocalFile::getParentCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 [13:47:17] (03PS1) 10Matthias Mullie: Add missing legacy action name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95149 [13:48:28] (03PS2) 10Matthias Mullie: Add missing legacy action name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95149 [13:52:50] (03PS1) 10Matthias Mullie: (bug 56803) Recentchanges comment links formatted as external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95150 [13:53:14] (03PS2) 10Matthias Mullie: (bug 56803) Recentchanges comment links formatted as external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95150 [14:03:47] (03PS1) 10Matthias Mullie: (bug 56804) Each infinite scroll chunk addition, includes a different number of topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95152 [14:05:10] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87054 (owner: 10Hashar) [14:06:31] (03PS4) 10Hashar: installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 [14:06:50] (03PS5) 10Hashar: installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 [14:10:51] (03CR) 10Nikerabbit: [C: 032] installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 (owner: 10Hashar) [14:12:31] libgcc_s.so.1 must be installed for pthread_cancel to work [14:12:35] i love our cryptic errors [14:13:46] (03Merged) 10jenkins-bot: installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 (owner: 10Hashar) [14:15:13] (03PS2) 10Hydriz: (bug 41417) Check if the article exists first before actually displaying it. [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 [14:19:11] (03PS1) 10Hashar: mw-apply-settings: clear out log directories [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95154 [14:19:21] (03CR) 10Hashar: [C: 032] mw-apply-settings: clear out log directories [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95154 (owner: 10Hashar) [14:19:25] (03Merged) 10jenkins-bot: mw-apply-settings: clear out log directories [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95154 (owner: 10Hashar) [14:44:31] (03PS1) 10Ragesoss: Switch long comments to into PHPDoc format [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95158 [14:45:08] (03PS1) 10Reedy: Revert "Support CIDR ranges in $wgSquidServersNoPurge" [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95159 [14:45:14] (03PS1) 10Reedy: Revert "Support CIDR ranges in $wgSquidServersNoPurge" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95160 [14:46:19] (03PS2) 10Ragesoss: Switch long comments to PHPDoc format [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95158 [14:46:57] (03CR) 10Reedy: [C: 032 V: 032] Revert "Support CIDR ranges in $wgSquidServersNoPurge" [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95159 (owner: 10Reedy) [14:47:01] (03PS2) 10Reedy: Revert "Support CIDR ranges in $wgSquidServersNoPurge" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95160 [14:47:12] (03CR) 10Reedy: [C: 032 V: 032] Revert "Support CIDR ranges in $wgSquidServersNoPurge" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95160 (owner: 10Reedy) [14:52:32] (03PS1) 10Reedy: Short circuit $wgSquidServersNoPurge iteration if ip is specifically listed. Quicker! [core] - 10https://gerrit.wikimedia.org/r/95163 [14:56:25] (03CR) 10Hashar: [C: 04-1] "That looks tacky to me. Since we use IP::isInRange:" [core] - 10https://gerrit.wikimedia.org/r/95163 (owner: 10Reedy) [14:56:36] (03CR) 10Faidon Liambotis: [C: 031] "Quicker = the original CIDR changed combined with the original single IP 225-lines long $wgSquidServersNoPurge list bumped the appservers" [core] - 10https://gerrit.wikimedia.org/r/95163 (owner: 10Reedy) [15:00:08] (03CR) 10Hashar: [C: 032] "gooood for now. We can optimize the $wg setting later on." [core] - 10https://gerrit.wikimedia.org/r/95163 (owner: 10Reedy) [15:03:05] (03Merged) 10jenkins-bot: Short circuit $wgSquidServersNoPurge iteration if ip is specifically listed. Quicker! [core] - 10https://gerrit.wikimedia.org/r/95163 (owner: 10Reedy) [15:11:21] (03PS1) 10Manybubbles: Fix problems highlighting redirects [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95165 [15:27:28] (03CR) 10Chad: [C: 032] Trim text on the way into elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95071 (owner: 10Manybubbles) [15:27:33] (03Merged) 10jenkins-bot: Trim text on the way into elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95071 (owner: 10Manybubbles) [15:28:17] Anyone know offhand any examples of the timelin extension being used on wmf wikis? [15:29:04] (03CR) 10Chad: [C: 032] Always fork Cirrus LinksUpdate behavior [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95086 (owner: 10Manybubbles) [15:29:09] (03Merged) 10jenkins-bot: Always fork Cirrus LinksUpdate behavior [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95086 (owner: 10Manybubbles) [15:29:26] Reedy: I think so [15:30:10] Reedy: https://de.wikipedia.org/wiki/Bundespr%C3%A4sident_%28Deutschland%29 [15:30:14] in the infobox [15:32:05] Where's the source for it? [15:32:14] Reedy: lots of examples on mw.org doc page [15:32:34] most linking to en.wp templates [15:32:49] Reedy: https://de.wikipedia.org/w/index.php?title=Vorlage:Zeitleiste_Bundespr%C3%A4sidenten_%28Deutschland%29&action=edit [15:40:30] (03PS1) 10Manybubbles: Skip pages without revisions in forceSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 [15:40:45] Thanks [15:41:51] (03CR) 10Chad: [C: 04-1] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 (owner: 10Manybubbles) [15:41:52] (03CR) 10Manybubbles: "I verified this by manually removing a revision from a page in my database and running the script. It crashed before. Now it doesn't." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 (owner: 10Manybubbles) [15:43:20] (03PS1) 10Matthias Mullie: Reply textarea fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95168 [15:43:22] (03CR) 10Chad: [C: 032] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94967 (owner: 10Manybubbles) [15:43:47] (03Merged) 10jenkins-bot: Save links to the search index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94967 (owner: 10Manybubbles) [15:43:48] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 (owner: 10Manybubbles) [15:46:04] (03CR) 10Chad: [C: 032] Fix problems highlighting redirects [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95165 (owner: 10Manybubbles) [15:46:08] (03Merged) 10jenkins-bot: Fix problems highlighting redirects [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95165 (owner: 10Manybubbles) [15:48:18] (03PS2) 10Manybubbles: Skip pages without revisions in forceSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 [15:49:54] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 (owner: 10Manybubbles) [15:51:42] https://office.wikimedia.org/w/img_auth.php/timeline/92b6b06b956228bc173a1513808c91da.png [15:51:54] Anyone know where the "You are not allowed to execute the action you have requested." comes from? [15:51:59] It's not in MessagesEn.php.. [15:53:12] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 (owner: 10Manybubbles) [15:53:18] Reedy: includes/AjaxDispatcher.php ? [15:53:32] ah no languages/messages/MessagesEn.php:'badaccess-group0' => 'You are not allowed to execute the action you have requested.', [15:54:23] heh. that's the most creative workaround i've seen in a long time. https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=581487944&oldid=581472635 [15:54:25] Wonder why I couldn't see that in find... [15:54:27] Thanks [15:54:28] badaccess-group0 [15:54:29] $detailMsgKey = $wgImgAuthDetails ? $msg2 : 'badaccess-group0'; [15:54:29] $detailMsg = wfMessage( $detailMsgKey, $args )->escaped(); [15:54:36] hmm, maybe we should add a CSV type to the API? [15:54:42] lol [15:55:23] $wgImgAuthDetails [15:56:23] (03PS3) 10Manybubbles: Skip pages without revisions in forceSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 [15:58:28] (03CR) 10Chad: [C: 032] Update docs in CdbPHP.php [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [15:59:09] (03CR) 10Chad: [C: 032] Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 (owner: 10Siebrand) [16:00:20] (03CR) 10Chad: [C: 032] Break long lines [core] - 10https://gerrit.wikimedia.org/r/94744 (owner: 10Siebrand) [16:00:59] (03CR) 10BryanDavis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/95163 (owner: 10Reedy) [16:01:42] (03Merged) 10jenkins-bot: Update docs in CdbPHP.php [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [16:03:16] (03CR) 10Chad: [C: 032] Use capital as first letter for class names [core] - 10https://gerrit.wikimedia.org/r/94749 (owner: 10Siebrand) [16:03:48] (03Merged) 10jenkins-bot: Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 (owner: 10Siebrand) [16:05:54] (03Merged) 10jenkins-bot: Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [16:05:55] (03Merged) 10jenkins-bot: Break long lines [core] - 10https://gerrit.wikimedia.org/r/94744 (owner: 10Siebrand) [16:07:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(2 comments)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [16:09:10] (03Merged) 10jenkins-bot: Use capital as first letter for class names [core] - 10https://gerrit.wikimedia.org/r/94749 (owner: 10Siebrand) [16:11:46] (03CR) 10Parent5446: [C: 032] Fix one more profiling error from I0a9a7f10ea (f5a0c23) [core] - 10https://gerrit.wikimedia.org/r/95141 (owner: 10IAlex) [16:14:15] (03PS1) 10Chad: Remove extra space [core] - 10https://gerrit.wikimedia.org/r/95171 [16:15:08] (03PS2) 10Gergő Tisza: Add LocalFile::getParentCategories() method [core] - 10https://gerrit.wikimedia.org/r/95148 [16:15:10] (03Merged) 10jenkins-bot: Fix one more profiling error from I0a9a7f10ea (f5a0c23) [core] - 10https://gerrit.wikimedia.org/r/95141 (owner: 10IAlex) [16:28:12] (03PS1) 10Hashar: run-phpcs-mw: switch to Wikimedia deployed version [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95172 [16:28:26] (03CR) 10Hashar: [C: 032] run-phpcs-mw: switch to Wikimedia deployed version [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95172 (owner: 10Hashar) [16:28:29] (03Merged) 10jenkins-bot: run-phpcs-mw: switch to Wikimedia deployed version [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95172 (owner: 10Hashar) [16:45:04] (03PS1) 10Hashar: run-phpcs-mw: actually invoke $PHPCS [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95174 [16:45:39] (03CR) 10Hashar: [C: 032] run-phpcs-mw: actually invoke $PHPCS [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95174 (owner: 10Hashar) [16:45:42] (03Merged) 10jenkins-bot: run-phpcs-mw: actually invoke $PHPCS [integration/jenkins] - 10https://gerrit.wikimedia.org/r/95174 (owner: 10Hashar) [16:46:24] (03PS1) 10BryanDavis: Skip IP::isInRange() test if input is not in CIDR notation [core] - 10https://gerrit.wikimedia.org/r/95175 [16:46:43] (03CR) 10Bartosz Dziewoński: "Also, this might require coordinating / cross-checking with the alternate alert style at en.wp, lest they get mad at you for trying to be " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/95102 (owner: 10Legoktm) [16:54:41] hashar: hi, you very busy? :) [16:55:09] hashar: have you seen my last mail in that wikitech thread about release notes and gerrit/jenkins merges? thoughts? [16:55:22] MatmaRex: yeah seen it [16:55:25] hashar: (tl;dr we should have jenkins rebase usin my merge driver during gate-and-submit process) [16:55:27] no idea how to handle it though [16:56:16] handle which part? sounds rather straightforward to me, but of course i've never touched jenkins [16:56:43] the merge driver implementation is at https://github.com/MatmaRex/mediawikireleasenotes-driver [16:57:16] there is two issues [16:57:40] getting Zuul to use that merge drivers, whenever a change enter the gate-and-submit pipeline, Zuul merge the change on top of the tip of master [16:57:41] when jenkins checks out the patch for testing, have it first rebase on master, push the patch and and stop if the patch wasn't based on master; then rerun for next patchset [16:57:46] it fails horribly if it can't merge [16:57:49] * MatmaRex listens [16:57:57] so we got to find a way to make Zuul know about that driver [16:57:59] well, yeah. which is why i implemented the driver so that it can. [16:58:09] probably can be done using ~/.gitconfig [16:58:16] run https://github.com/MatmaRex/mediawikireleasenotes-driver/blob/master/mediawikireleasenotes-driver-installer.sh in the checkout directory. [16:58:24] it can, and i've got it covered. :D [16:58:29] then Zuul would magically be able to handle the merge and craft a commit that it is tested by Jenkins [16:58:44] i've used the driver for a few months myself and it works great [16:58:52] cat < $(git rev-parse --git-dir)/mediawikireleasenotes.rb [16:58:53] #!/usr/bin/env ruby [16:58:54] .. [16:59:02] crazy :] [16:59:03] (03PS1) 10Darkdadaah: Add a script to format lists to be published in a wiki. [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95177 [16:59:04] (03PS1) 10Darkdadaah: Print simple tabulated lists with nowiki parts. [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95178 [16:59:05] (03PS1) 10Darkdadaah: Split letters in articles titles for crossword search. - Add 30 columns, each for a single letter in the order of the title (ascii version). - Those can be used to efficiently find words with only a few hints anywhere in a word with a set length. [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95179 [16:59:07] well yeah, i embedded the actual script in the installer. [16:59:15] it was simpler that way. [16:59:18] so yeah git config merge.mediawikireleasenotes.driver [16:59:24] (03CR) 10Chad: [C: 032] Skip pages without revisions in forceSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 (owner: 10Manybubbles) [16:59:29] (03Merged) 10jenkins-bot: Skip pages without revisions in forceSearchIndex [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95167 (owner: 10Manybubbles) [16:59:29] scroll down for the config stuff. [16:59:39] the attributes, Zuul does not have any support for that [16:59:50] MatmaRex: :D Didn't knew people still do this in 2013... [16:59:57] hashar: the attributes are handled by git itself when merging [17:00:02] it would be nice to have it configurable in Zuul conf, that would need to be done in Zuul upstream code I guess [17:00:04] hoo: heh [17:00:39] hashar: when you run git-merge/rebase/cherry-pick, git uses the attributes file and the merge driver definition to figure out what to run [17:00:55] unless jenkins/zuul uses some magical other thing, it should just work [17:01:13] yup it would [17:01:18] but how would you apply that script ? :-] [17:01:25] Zuul use a python based git implementation [17:01:36] err [17:01:38] forget me [17:01:40] last time i checked, it used a small wrapper over the raw shell commands. [17:01:47] the issue is how to get Zuul to tweak the attributes [17:02:01] run `echo /RELEASE-NOTES* merge=mediawikireleasenotes >> $(git rev-parse --git-dir)/info/attributes` from shell? [17:02:03] that would have to be configurable somehow inside Zuul [17:02:13] yeah [17:02:15] (`git rev-parse --git-dir` finds the .git directory) [17:02:19] but that is not done in jenkins [17:02:28] all of that is handled by Zuul BEFORE the change is send to Jenkins [17:02:44] (03CR) 10Darkdadaah: [C: 032 V: 032] Add a script to format lists to be published in a wiki. [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95177 (owner: 10Darkdadaah) [17:03:06] (03CR) 10Chad: [C: 032] BacklinkCache performance tweaks [core] - 10https://gerrit.wikimedia.org/r/94582 (owner: 10Aaron Schulz) [17:03:07] hashar: i still fail to see why it can't be done, if not in jenkins, then in zuul [17:03:10] (03CR) 10Darkdadaah: [C: 032 V: 032] Print simple tabulated lists with nowiki parts. [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95178 (owner: 10Darkdadaah) [17:03:22] MatmaRex: it can be done [17:03:26] it would be quite nice indeed [17:03:47] would need to add support in Zuul too tweak attributes [17:03:53] (it would be of course even better to do it in gerrit itself, but i don't speak java at the required level) [17:03:57] the next step will be to let Gerrit knows about that merge driver. [17:04:20] cause neither Zuul nor Jenkins merge in Gerrit, When Jenkins tests are successful it says so to Zuul and then Zuul ask Gerrit to merge. [17:04:28] so you get to add the driver on Gerrit side as well [17:04:36] we can't do that, because it uses JGit. [17:04:51] i was thinking about zuul/jenkins/whatever rebasing the patch and submitting a new patchset [17:04:59] which is what I attempted to explain, using the driver in Zuul would let jenkins run the tests [17:05:04] unless you can get ^d or someone to do some java coding [17:05:14] * ^d snorts [17:05:15] then Zuul will ask Gerrit to submit the approved patch and Gerrit will fail because of a merge conflict :-((((((( [17:05:41] or [17:05:45] hashar: sure, but now we can rebase "locally" on zuul – so let's rebase and `git push gerrit HEAD:refs/for/master`? [17:05:46] we could rewrite Gerrit in python :-] [17:06:09] then run the gate-and-submit again for the new patchset, which at this point will be based on the tip of master [17:06:14] we can check that and not rebase again [17:06:14] MatmaRex: that would craft another commit yup [17:06:19] automatic rebase by Zuul .. [17:06:29] then we will get to test it out again :] [17:06:54] (03Merged) 10jenkins-bot: BacklinkCache performance tweaks [core] - 10https://gerrit.wikimedia.org/r/94582 (owner: 10Aaron Schulz) [17:08:05] MatmaRex: 'JGit should support merge drivers' https://bugs.eclipse.org/bugs/show_bug.cgi?id=418149 [17:08:17] hashar: so setting that up would probably require some fiddling, but the "algorithm" should be relatively simple [17:08:52] hashar: i think i linked that bug in the wikitech thread :) [17:08:54] (03CR) 10Reedy: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [17:08:55] so apparently there is some work in progress on jgit side [17:09:08] hashar: we could already implement the driver in java, i think, as part of jgit or something [17:09:10] (03CR) 10Umherirrender: "If the name of the variable in the test cases is still a blocker, please feel free to rename the variable to a name, which is supported by" [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [17:09:18] hashar: i'm pretty sure that part is already possible [17:09:31] (03PS2) 10Reedy: Skip IP::isInRange() test if input is not in CIDR notation [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [17:09:40] that would be nice :-] [17:10:00] hashar: also, the bug is unclear about what they are trying to provide, full git-like configuration "api"? [17:10:14] the wikitech-l thread is still unread in my mail client, so I will surely end up replying to it "soon" ™ [17:10:24] no clue [17:10:31] the bug looks like still a java-based option [17:10:34] maybe something like ~/.gitconfig ? [17:10:58] aaanyway we'd have to get ^d on it, and he will probably just snort at it again [17:11:36] (03CR) 10Anomie: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [17:12:16] MatmaRex: what would be possible though is to add a pre commit hook that attempt to merge with the tip of master and warn the user the test would fail [17:12:45] hashar: you mean on user's side? running `git pull` before every `git commit` would suck really bad [17:12:57] network is slow in general, and gerrit is slow in particular [17:12:57] MatmaRex: and we could hack something in Zuul to let it uses the 'ours' merge strategy for RELEASE-NOTES [17:13:00] which would discard it [17:13:09] but that does not solve the issue of Gerrit rejecting the change on gate-and-submit :-( [17:13:18] yeah [17:13:49] with zuul behaving the way it does now, at least you know why it won't merge [17:13:49] aude: how do I specify test wikidata wiki? that is, what's the db name? :-D [17:14:02] testwikidatawiki [17:14:04] ahh [17:14:06] thanks [17:14:09] k [17:14:16] MatmaRex: yup :( [17:14:25] (03PS2) 10Darkdadaah: Split letters in articles titles for crossword search. - Add 30 columns, each for a single letter in the order of the title (ascii version). - Those can be used to efficiently find words with only a few hints anywhere in a word with a set length. - Set th [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95179 [17:14:28] daniel is working on improved error output, but you can try with the option 2 int he bug [17:14:30] MatmaRex: sorry :( [17:14:41] MatmaRex: I am off for now, gotta take care of my little familly [17:14:45] hm that failed [17:14:47] see you [17:14:49] if you are asking about json dumps [17:15:12] maybe I have the wrong format for the stream wwrapper [17:15:31] compress.bzip2://wikidata.json.bz2 looked right but I guess it isn't [17:15:48] hoo: so is the Capiunto extension just a work around the fact we don't have global templates? [17:16:06] (03PS3) 10Darkdadaah: Split letters in articles titles for crossword search. - Add 30 columns, each for a single letter in the order of the title (ascii version). - Those can be used to efficiently find words with only a few hints anywhere in a word with a set length. - Set th [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95179 [17:17:23] ugh: No, it will feature proper i18n, unit tests, ... and it's in git, so it is superior to global templates [17:17:29] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [17:18:00] hoo: hmmm, sounds exciting :D [17:18:42] "Capiunto"? [17:19:09] Scribunto module for infoboxes in an extension [17:19:13] https://en.wiktionary.org/wiki/capiunto [17:19:34] woot. [17:19:40] aude: are we sure that the script will use the compress stream and doesn't just try to open the argument to --output? [17:19:43] why? [17:19:54] for small wikis, i guess? [17:19:56] MatmaRex: To have it in a consistent manner on all wikis [17:20:00] heh [17:20:06] well, that's not a good plan. :> [17:20:15] with proper semantics and everyhting [17:20:18] MatmaRex: Why? [17:20:29] pl.wp has a different infobox system than en.wp (and thus likely "all wikis") and we quite like it [17:20:43] i assume you only looked at the en.wp one? [17:20:49] or does de.wp have another? [17:20:53] apergos: i am not sure [17:20:54] (03CR) 10Darkdadaah: [C: 032 V: 032] Split letters in articles titles for crossword search. - Add 30 columns, each for a single letter in the order of the title (ascii version). [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95179 (owner: 10Darkdadaah) [17:20:57] maybe DanielK_WMDE knows [17:21:11] (03PS1) 10Ragesoss: Revert "Remove Settings::newFromGlobals" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95185 [17:21:36] MatmaRex: Dewiki's is very similar to enwiki's [17:22:07] where's the big difference you mentioned with plwiki? [17:23:05] hoo: basically it's a modular system – infobox rows are subtemplates, with some modules defined for common data types, like country names, locaiton maps, interwiki links, etc [17:23:32] $output = fopen( $outFile, 'wa' ); //TODO: Allow injection of an OutputStream [17:23:39] MatmaRex: You could even use that with the new extension I guess [17:24:01] another big point is that this will make it by far easier to create proper infoboxes from Wikibase data [17:24:23] e.g. see https://pl.wikipedia.org/w/index.php?title=Szablon:Jezioro_infobox&action=edit , not the cleanest example, but a reasonably good one [17:25:08] hoo: how? sounds interesting [17:26:15] MatmaRex: We don't yet know completely... but the plan is to not let the extensions know about each other... maybe DanielK_WMDE can tell you more [17:26:33] So this wont be specific to wikidata or something [17:26:37] heh [17:26:51] we've been experiementing with wikidata infoboxes too, e.g. https://pl.wikipedia.org/w/index.php?title=Szablon:Miejscowo%C5%9B%C4%87_WIKIDATA_infobox&action=edit [17:26:58] (actually that's the only working one, i think) [17:27:12] enwiki has quite a few wikidata based templates [17:27:20] it also features comparing the data between the box and the WD data [17:27:25] dunno about any infoboxes though. [17:27:25] MatmaRex: Not using the Lua api? :D [17:27:30] with magic categories and things [17:27:31] (03CR) 10Anomie: "> or if both interfaces relied on a common implementation" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [17:27:41] hoo: the lua api currently provides no value over the wikitext one [17:28:01] hoo: you still can only refer to the "current" page, so there's no point unless you're already writing in lua [17:28:02] You can do things over there you can't in wikitext [17:28:11] i'm not ware of any. [17:28:13] aware* [17:28:24] did it change since i last checked a few weeks ago? [17:28:25] it's going to be extended in the (nearer) future, btw [17:28:31] nope, not yet [17:28:58] iirc, #property only gives you the first property for that item, while lua let you access all of them [17:28:58] (03CR) 10Cscott: [C: 04-1] "It seems like the previous patch missed a call to Settings::newFromGlobals() in includes/Extension.php. In this case it would probably be" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95185 (owner: 10Ragesoss) [17:32:49] (03PS2) 10IAlex: Remove extra space [core] - 10https://gerrit.wikimedia.org/r/95171 (owner: 10Chad) [17:32:54] (03CR) 10IAlex: [C: 032] Remove extra space [core] - 10https://gerrit.wikimedia.org/r/95171 (owner: 10Chad) [17:33:01] qgil guillom: what do I need to do if I want to publish slides under cc license? [17:33:17] aude: Yes? [17:33:29] just upload them to commons? or should I make the license explicit at the last slide or somewhere? [17:33:42] Krinkle: hashar helped us [17:33:49] we had an issue with jenkins [17:34:09] zeljkof, see for instance https://commons.wikimedia.org/wiki/File:How_to_hack_on_Wikipedia.pdf [17:34:43] zeljkof, in that case I just mentioned it in the last slide and uploaded to Commons wth the same license [17:34:44] qgil: I was just looking at that [17:35:36] so just a small cc logo+link at the last slide and upload pdf to commons, looks like it should do it [17:37:04] qgil: thanks [17:37:40] (03Merged) 10jenkins-bot: Remove extra space [core] - 10https://gerrit.wikimedia.org/r/95171 (owner: 10Chad) [17:40:05] (03CR) 10Adamw: "@ori-l: Good question--I'll try to peel generic functionality out into separate patches, but in theory, this is ready for review at any po" [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [17:45:06] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [17:45:14] legoktm: Actually, usernames' first character doesn't have to be capitalised, if the right $wg is set, I believe. [17:45:14] (03PS4) 10Krinkle: mw.util.addPortletLink: Check length before access array index [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [17:45:21] (03CR) 10Krinkle: [C: 032] mw.util.addPortletLink: Check length before access array index [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [17:45:23] (03PS3) 10BryanDavis: Skip IP::isInRange() test if input is not in CIDR notation [core] - 10https://gerrit.wikimedia.org/r/95175 [17:45:52] zeljkof, happy to help [17:46:06] James_F: actually it has. there's a bug about that. [17:46:10] qgil: it ended up at the first page [17:46:16] James_F: nope, it overrides that. [17:46:18] fine :) [17:46:23] Huh. [17:46:32] usernames, special pages, and mediawiki messages have to be uppercase, no matter what [17:46:40] mediawiki namespace* [17:46:48] James_F: it would be rather simple to remove the special-case, but i assume there are reasons for it existing [17:47:01] MatmaRex: Well, for WMF cluster there are. [17:47:04] https://bugzilla.wikimedia.org/show_bug.cgi?id=26396 [17:47:10] MatmaRex: Specifically, usernames are global. [17:47:31] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [17:47:37] MatmaRex: So you can't have User:foo and User:Foo on Wiktionary, because they'd need to be distinguishable on Wikipedia. [17:47:49] MatmaRex: But I thought that that was a WMF cluster config, rather than how the code works. [17:48:33] James_F: you can set each namespace to use non-capitalized pages, you could also set User: to be lowercaseable on all wikis [17:48:39] assuming the bug i linked above is fixed [17:49:01] James_F: the patch seems to be just this: https://bugzilla.wikimedia.org/attachment.cgi?id=12648&action=diff [17:49:04] MatmaRex: But is that a useful change? [17:49:06] (03Abandoned) 10EBernhardson: [WIP] Design changes via meeting with may [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93002 (owner: 10EBernhardson) [17:49:52] James_F: it has a request filed for it, in 2010, and some dupes [17:50:02] James_F: some people want to have lowercase usernames. [17:50:15] there was even a guy who complained about that on VPT just yesterday or so. [17:50:21] (03Merged) 10jenkins-bot: mw.util.addPortletLink: Check length before access array index [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [17:50:30] (03CR) 10Aaron Schulz: [C: 04-1] "In theory:" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [17:50:34] MatmaRex: And I want a pony. However, I think that the scope for A<->a confusion is a little too large to be a comfortable decision. [17:51:02] James_F: we already have ways to mitigate creating spoof accounts, if that's what you mean [17:51:10] MatmaRex: This is a perfect example of a setting that pleases a couple of people very greatly, by inconveniencing a lot of people slightly. [17:51:22] !e AntiSpoof [17:51:22] https://www.mediawiki.org/wiki/Extension:AntiSpoof [17:51:26] <^d> Actually, MatmaRex is right. [17:51:32] MatmaRex: I'm aware. Has AntiSpoof been tested with this? [17:51:44] <^d> I shouldn't have enforced NS_USER to be always-uppercased when I did the namespace casing stuff years ago. [17:51:48] James_F: no, naturally. but i see no reason why it would not work, it already checks for case variations [17:51:54] <^d> It was based on flawed assumptions at the time. [17:52:02] * James_F nods. [17:52:13] Cool, if it works then we should totally flip the switch. :-) [17:52:14] ^d: now you have the opportunity to make things right again! :P [17:52:22] Though we may need to fix a huge number of links. [17:52:41] James_F: why? no one fixes links after user rename afaik [17:52:46] The number of people that have lazily linked [[user:jdforrester]] who will now find out that that doesn't work is likely to be in the millions of issues. [17:53:02] ah, that. [17:53:05] Yeah. [17:53:06] That. [17:53:08] :-) [17:53:24] Well, I don't think it should be enabled on WMF wikis. [17:53:24] <^d> Well, that's why you should never change capital links settings on wikis anyway. [17:53:26] that's why it should have been allowed from the start :P [17:53:36] ^d: Indeed. [17:53:39] <^d> It's really a setting you have to set from the start and stick with. [17:53:48] MatmaRex: Yes, but hindsight isn't very helpful. :[-) [17:53:53] <^d> Otherwise you end up with a bajillion old revisions that won't link right if you change it. [17:54:13] James_F: what we need is a new config setting. :P [17:54:24] MatmaRex: Sure we do. ;-0 [17:54:42] <^d> I'm getting ready to add two more config settings :D [17:54:52] * ^d has evil patches afoot, evil evil patches [17:56:26] ^d: Tsk. You know the new rule: One in, two out. :-) [17:56:39] ^d: So, what four config parameters are you getting rid of? :-) [17:57:00] <^d> I removed $wgArticle. That must count for like 10-15 new config variables. [17:57:12] <^d> Equivalent exchange and all ;-) [17:58:39] $wgUseConfigVariables = false; [17:58:47] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [17:59:12] (03CR) 10BryanDavis: "Reedy: Opened feature request https://bugzilla.wikimedia.org/show_bug.cgi?id=57021 to track further optimizations in IP class." [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [17:59:54] <^d> I wonder what would happen if we removed $wgTitle from core. [18:00:02] <^d> Wonder how many extensions are still misbehaving :p [18:01:27] <^d> Argghghhhh, my eyes. [18:02:36] <^d> http://p.defau.lt/?Jnk2Zy3O83KsG0ssFSLlkg - bad bad extensions! [18:03:28] ^d: patches welcome. :D [18:03:39] <^d> I'm going to see how many I can fix today. [18:03:48] ^d: or, check only the new ones and spank the WMF people responsible! [18:04:28] fix the evilMediaWikiBootstrap.php in wikibase :D [18:04:47] * aude not looked at it [18:04:58] qgil: here it is https://commons.wikimedia.org/wiki/File:How_to_fail_at_test_automation.pdf [18:05:09] aude: heh, why does that file exist in some many extensions [18:05:13] so many* [18:05:29] oh gah, horrible hooks [18:06:12] (03PS2) 10Aaron Schulz: Made cleanupUploadStash use batching for the last two loops [core] - 10https://gerrit.wikimedia.org/r/94451 [18:06:23] ^d: heh, your grep caught "$wgTitleBlacklistSources" [18:06:34] MatmaRex: something to do with tests [18:06:35] <^d> Yeah I was lazy :p [18:07:49] zeljkof, good! But you are using trademarks and... (just joking, I won't chase you for this) ;P [18:07:54] * aude assigns ^d to fix wikibase EditEntity test [18:08:11] that would be awesome, or otherwise it's a bit involved [18:08:15] qgil: where am I using trademarks? [18:08:34] I took some screen shots, that? [18:10:56] (03Abandoned) 10AzaToth: only show wlheader-showupdated if we are using the old watchlist [core] - 10https://gerrit.wikimedia.org/r/70540 (owner: 10AzaToth) [18:11:02] (03CR) 10EBernhardson: [C: 032] (bug 56804) Each infinite scroll chunk addition, includes a different number of topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95152 (owner: 10Matthias Mullie) [18:11:08] (03PS1) 10Chad: Don't use $wgTitle [extensions/Agora] - 10https://gerrit.wikimedia.org/r/95188 [18:11:28] ugh: btw, are you working on echo fulltime-ish, or have you just submitted some drive-by patches? :) [18:11:30] zeljkof, logos, never mind, I was joking. [18:11:49] ^d: no point, just scrap the extensions [18:11:54] ^d: i think everyone forgot about that one. [18:11:59] qgil: I do not know much about logos, I thought taking screen shots is safe [18:12:05] <^d> If it's in git, it's getting fixed. [18:12:16] <^d> Deleting the extension would've taken longer. [18:12:29] pfft. [18:12:30] zeljkof, if you don t stop now I won�t be ironic with you anymore :) [18:12:32] MatmaRex: I'm not even a full-time contractor, but I do plan on working on Echo [18:13:01] (03Merged) 10jenkins-bot: (bug 56804) Each infinite scroll chunk addition, includes a different number of topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95152 (owner: 10Matthias Mullie) [18:13:02] ugh: half-time-ish, then. yay :D [18:13:06] qgil: in that case, 'Stop! Hammer time!' :) [18:13:17] (03CR) 10EBernhardson: [C: 032] (bug 56803) Recentchanges comment links formatted as external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95150 (owner: 10Matthias Mullie) [18:13:45] (03Merged) 10jenkins-bot: (bug 56803) Recentchanges comment links formatted as external links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95150 (owner: 10Matthias Mullie) [18:13:55] (03CR) 10Bartosz Dziewoński: [C: 032] "Not like anyone cares about this extension anyway." [extensions/Agora] - 10https://gerrit.wikimedia.org/r/95188 (owner: 10Chad) [18:13:59] (03Merged) 10jenkins-bot: Don't use $wgTitle [extensions/Agora] - 10https://gerrit.wikimedia.org/r/95188 (owner: 10Chad) [18:19:48] (03PS1) 10Bartosz Dziewoński: mw.util.addPortletLink: Check length before access array index [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95190 [18:19:53] (03CR) 10Jeroen De Dauw: "The "test suite" is miles away from having any decent coverage. Do not rely on it for catching errors." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/95185 (owner: 10Ragesoss) [18:20:03] (03CR) 10Bartosz Dziewoński: [C: 032] "Regression fix backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95190 (owner: 10Bartosz Dziewoński) [18:21:42] (03PS7) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [18:22:11] (03CR) 10AzaToth: "That sadly won't work as of yet because git-buildpackage doesn't handle keeping upstream in a submodule" [gerrit] (wmf-debian) - 10https://gerrit.wikimedia.org/r/68485 (owner: 10AzaToth) [18:25:37] (03Merged) 10jenkins-bot: mw.util.addPortletLink: Check length before access array index [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/95190 (owner: 10Bartosz Dziewoński) [18:26:07] ^d: why does CirrusSearchTextFormatter.php use Article instead of WikiPage? The only thing that should use the former is code for displaying articles to a user [18:27:15] (03PS1) 10Matthias Mullie: Add mising parameter to participants message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95192 [18:28:11] (03PS1) 10EBernhardson: Display only the user name in auto-mentions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95193 [18:29:01] <^d> AaronSchulz: Old lazy code. Will fix. [18:30:07] I was looking at that code last night to see if there were no double parses...since Article defaults to using the $wgUser options (the same used in mPreparedEdit) it should be fine [18:30:34] if it's changed to WikiPage, one would want to make sure the context user gets passed in to avoid regression [18:34:51] (03PS8) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [18:38:52] MatmaRex: Why did you dupe 1574 into 26396? I thought that we always dupe down unless there's a really good reason, and I don't see it immediately… [18:39:32] James_F: the newer bug has some relevant discussion from non-ancient times :) [18:39:32] (03PS1) 10EBernhardson: Fix creating new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95194 [18:39:47] i though it was a good enough reason [18:40:10] it also has another bug duped to it [18:40:17] (03CR) 10Gergő Tisza: "Some more small formatting/phrasing issues." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [18:40:22] (03CR) 10EBernhardson: [C: 032] Display only the user name in auto-mentions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95193 (owner: 10EBernhardson) [18:40:27] MatmaRex: Then the normal thing to do it refer to it with "bug 26396 comment 4 has some great thoughts about this" or whatever. [18:40:48] James_F: feel free to invert that if it bothers you [18:40:52] * James_F grins. [18:40:53] (03CR) 10EBernhardson: [C: 032] Fix creating new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95194 (owner: 10EBernhardson) [18:40:54] Very well. [18:40:58] (03Merged) 10jenkins-bot: Display only the user name in auto-mentions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95193 (owner: 10EBernhardson) [18:41:10] greg-g: Can I push out Ic947c6c75eb7936fcebd today during the lighting window? Though it is technically an enhancement, it repairs a feature that will significantly increase productivity in patrolling tools (which currently have an ever increasing backlog). Most tools have already started writing code that assumes its present, the sooner it is out, the better. [18:41:17] (03Merged) 10jenkins-bot: Fix creating new topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95194 (owner: 10EBernhardson) [18:42:16] Krinkle: yep, so far you're the only one today, but check in around 4pm pacific [18:42:19] James_F: the good reason is that the older bug had been wontfixed ;) [18:42:30] (good from his pov) [18:43:49] Nemo_bis: Well, eh. Technically they're not DUPEs of each other, but… [18:45:21] (03PS1) 10EBernhardson: Set a posts replyToId before setting content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95196 [18:48:06] csteipp: just added you to https://bugzilla.mozilla.org/928470 [18:48:27] * csteipp looking [18:51:12] (03CR) 10Reedy: "I know this isn't the complete solution to the problem, but is it worth merging as is, so it can be run on the cluster?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy) [18:51:33] (03CR) 10Gergő Tisza: "(5 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [18:58:30] csteipp: tyvm [19:04:01] (03PS1) 10Reedy: Remove SimpleAntiSpam, CommunityHiring and CommunityApplications [tools/release] - 10https://gerrit.wikimedia.org/r/95198 [19:08:46] is the bcmath module available on the apaches? can i somewhere see which php modules are available? [19:09:24] hey Ryan_Lane, perhaps you know! [19:09:26] is the bcmath module available on the apaches? can i somewhere see which php modules are available? [19:10:29] * Ryan_Lane has no clue [19:10:29] :) [19:11:04] php -r "echo bcadd(1,1);" [19:11:22] reedy@mw1017:~$ php -m | grep math [19:11:22] bcmath [19:11:23] Yes [19:12:11] Reedy: thanks! [19:12:58] so we can implement unit conversion for wikidata without worrying about float errors [19:16:27] dan-nl: so dumping all of $POST into a field in a job is a little iffy, that should filtered down to fields that matter [19:17:04] AaronSchulz: the posted fields that are used are filtered when used [19:17:51] oh, writing unfiltered user input to the database? fun times... [19:18:54] job_params is a blob, so it has a limit for 64k. What'S the limit for post data? [19:19:00] more than 64k, i assume... [19:19:40] would also be nice if processMatchingElement() built the jobs up into an array and pushed them in batches instead of doing so as XML elements are read [19:20:06] AaronSchulz let me know if it's a blocker and i will investigate it further. each post will be dynamic depending on the mapping the user provides, categories and template selected [19:20:17] DanielK_WMDE: always good to filter and sanity check before storing stuff :) [19:20:44] job batching looks easy to do in processDOMElements() [19:22:21] dan-nl: try sending a post that contains a LOT of data, see what happens. [19:22:21] (03CR) 10CSteipp: "My fault for the delay. Yeah, concept looks ok, except I think you need to specify a LIMIT in the query, right? Or does the maintenance cl" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy) [19:23:56] AaronSchulz: k, it would be good to get a MoSCoW list of changes you'd like to see … you can put them in that etherpad [19:24:04] dan-nl: empty( $this->SpecialPage ) is kind of curious, can PHP_SAPI just be checked instead? [19:24:32] (03PS2) 10Reedy: Write maintenance script for AbuseFilter to purge old IP data from logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 [19:25:36] AaronSchulz: not familiar with PHP_SAPI yet … it would distinguish between cli php and web php? [19:25:44] yep, just a constant [19:25:51] * AaronSchulz lost the pad link [19:26:02] * dan-nl : looks [19:26:02] <^d> PHP_SAPI == 'cli'; // oh wow I'm on the command line! [19:26:08] (03PS3) 10Reedy: Write maintenance script for AbuseFilter to purge old IP data from logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 [19:26:10] (03CR) 10jenkins-bot: [V: 04-1] Write maintenance script for AbuseFilter to purge old IP data from logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy) [19:26:39] (03PS4) 10Reedy: Write maintenance script for AbuseFilter to purge old IP data from logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 [19:26:41] dan-nl: also it would be nice to have some queue flood protection...could be as simple as checking JobQueueGroup::singleton()->get( )->getSize() [19:26:41] (03CR) 10jenkins-bot: [V: 04-1] Write maintenance script for AbuseFilter to purge old IP data from logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 (owner: 10Reedy) [19:27:21] (and bailing out on new requests) [19:27:30] * AaronSchulz goes afk [19:27:53] (03PS5) 10Reedy: Write maintenance script for AbuseFilter to purge old IP data from logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/81255 [19:29:02] AaronSchulz: pm'd the ehterpad link … not sure yet what you mean by flood protection … the MetadataBatchJob has a throttle and currently only creates 10 MediaFileJobs at a time … is that what you mean? [19:34:31] (03PS1) 10Darkdadaah: Small bugs corrections. - Dump file handle proper closing - print_value exported by default by basic.pm [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95205 [19:34:32] (03PS1) 10Darkdadaah: Rewrite to use the new iterator. [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95206 [19:39:27] (03CR) 10Reedy: [C: 032] Remove SimpleAntiSpam, CommunityHiring and CommunityApplications [tools/release] - 10https://gerrit.wikimedia.org/r/95198 (owner: 10Reedy) [19:39:29] (03Merged) 10jenkins-bot: Remove SimpleAntiSpam, CommunityHiring and CommunityApplications [tools/release] - 10https://gerrit.wikimedia.org/r/95198 (owner: 10Reedy) [19:39:35] (03CR) 10Darkdadaah: [C: 032 V: 032] Small bugs corrections. - Dump file handle proper closing - print_value exported by default by basic.pm [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95205 (owner: 10Darkdadaah) [19:42:13] (03CR) 10Krinkle: "(1 comment)" [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 (owner: 10Spage) [19:43:27] (03CR) 10Spage: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [19:45:49] (03CR) 10Darkdadaah: [C: 032 V: 032] Rewrite to use the new iterator. [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/95206 (owner: 10Darkdadaah) [19:47:28] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [19:58:24] dan-nl: I mean total jobs in the queue [19:58:37] I guess if the entry points are throttled that works too [19:58:53] (e.g. how often someone can use the special page) [20:01:06] AaronSchulz so i could place the one metadatabatch job in the queue and it would reproduce itself if the total job queue size is > ? what throttle for the total queue size would you like me to set? [20:01:50] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [20:02:20] (03CR) 10JGonera: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [20:02:42] 28 Fatal error: Maximum execution time of 180 seconds exceeded in /usr/local/apache/common-local/php-1.23wmf2/includes/diff/DifferenceEngine.php on line 794 [20:03:03] (03PS9) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [20:05:47] dan-nl: not sure, I'm thinking a check at the special page level...though it's probably not a "must have" [20:07:19] k, i'm just about ready to push a new patch-set that takes into account what we discussed last night. i also added a maintenance cleanup job for the GWToolsetFileBackend [20:07:35] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [20:19:14] (03CR) 10Gergő Tisza: [C: 031] Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [20:23:00] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [20:23:26] hashar: Hey - got a phpcs fail of "/tmp/hudson6331435828967663556.sh: line 9: phpcs: command not found" in https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/1933/console - any thoughts? [20:23:43] !sal [20:23:43] http://wikitech.wikimedia.org/view/Server_admin_log [20:23:59] James_F: 16:48 hashar: Jenkins: phpcs jobs successfully running on lanthanum. !!! [20:24:00] :D [20:24:17] (and some other phpcs stuff today) [20:24:25] Ho-hum. :-( [20:24:28] !sal del [20:24:29] Successfully removed sal [20:24:30] !sal is https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:24:30] Key was added [20:27:42] James_F: aehrhagae [20:28:09] James_F: I swear I fixed that [20:28:27] (03CR) 10MarkTraceur: [C: 04-1] "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [20:29:05] holy shit [20:29:50] (03PS4) 10Dan-nl: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [20:33:08] Raymond_ is facing the same issue as James_F https://gerrit.wikimedia.org/r/#/c/95255/ [20:33:11] Raymond_: sorry broken :( [20:33:41] :-( [20:35:00] I am soo dumb [20:35:04] seriously [20:35:11] if I was Sue I would fire myself [20:35:38] * marktraceur hugs hashar [20:35:47] hashar: What happened? [20:36:05] I have made the phpcs jobs to be able to run on the 2nd slave [20:36:06] but [20:36:11] AaronSchulz: have an appointment to get to but will leave irc open. if possible, i think the "easiest" approach for the moment would be to triage the code and place a MoSCoW list of tasks in that ether pad unless you prefer something else ... [20:36:15] it doesn't have phpcs in its PATH :] [20:36:20] Ah, great. [20:36:30] hashar: There are dumber things [20:36:32] (03PS9) 10JGonera: Port mediawiki.ui SASS to LESS [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [20:36:54] hashar: np. I have overwritten Jenkins [20:37:49] superm401, I pushed a new sass->less patchset [20:38:14] jgonera, great, let me take a look. [20:38:18] (03PS1) 10Hashar: use full path for phpcs on legacy phpcs jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95268 [20:39:43] AaronSchulz: did you want to review my trebuchet changes before I merge them? [20:41:27] James_F: fixed. Sorry [20:41:50] hashar: No worries. [20:44:36] (03PS4) 10Reedy: Skip IP::isInRange() test if input is not in CIDR notation [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [20:44:54] (03CR) 10Reedy: [C: 032] Skip IP::isInRange() test if input is not in CIDR notation [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [20:44:55] Ryan_Lane: you can merge, I just wanted to look [20:45:03] ok, cool [20:45:14] so, the features added work [20:45:27] the fetch stage is slightly slower with shadow_reference support, unfortunately [20:46:27] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95268 (owner: 10Hashar) [20:49:37] (03Merged) 10jenkins-bot: use full path for phpcs on legacy phpcs jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95268 (owner: 10Hashar) [20:50:37] (03Merged) 10jenkins-bot: Skip IP::isInRange() test if input is not in CIDR notation [core] - 10https://gerrit.wikimedia.org/r/95175 (owner: 10BryanDavis) [20:54:34] MaxSem: heya, did you record the deploy training from yesterday? [20:54:44] greg-g, nope [20:54:50] :( :( [20:55:49] and that's good cause it wasn't glossy anyway [20:56:33] I don't want glossy [20:56:35] I want *real* [20:56:41] reality.. man... [20:58:48] greg-g: We should get Jeff Probst to host a deploy training [21:01:06] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [21:04:52] marktraceur: who? [21:10:42] greg-g: Host of Survivor [21:11:10] "I'm sorry, you've been voted off the deploy host." [21:17:32] (03CR) 10Gergő Tisza: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [21:21:25] marktraceur: too pop culture for me [21:22:39] (03PS1) 10EBernhardson: RecentChanges support for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95277 [21:24:19] Heh [21:29:08] (03PS10) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [21:34:35] (03PS1) 10Jdlrobson: POC: Add a living style guide to core [core] - 10https://gerrit.wikimedia.org/r/95279 [21:34:51] (03CR) 10Jdlrobson: [C: 04-2] "Needs a lot more work" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [21:37:04] (03CR) 10Jdlrobson: [C: 04-2] "Reinstore my -2" [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [21:38:09] (03CR) 10jenkins-bot: [V: 04-1] POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [21:41:05] off to bed *wave* [21:41:10] MatmaRex: what local stuff does enwiki have with the talk page indicator thing for echo? [21:43:47] (03CR) 10Anomie: [C: 032] "Code works, looks good. Existing -1 is based on WONTFIXed bugs." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94954 (owner: 10MaxSem) [21:44:02] (03Merged) 10jenkins-bot: Remove template blacklisting functionality [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94954 (owner: 10MaxSem) [21:44:19] (03PS3) 10Jdlrobson: POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 [21:46:56] (03CR) 10Anomie: [C: 031] "Seems sane to me." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94965 (owner: 10MaxSem) [21:47:32] (03CR) 10jenkins-bot: [V: 04-1] POC: Add a living style guide to core in Special:StyleGuide [core] - 10https://gerrit.wikimedia.org/r/95279 (owner: 10Jdlrobson) [21:48:32] (03CR) 10MaxSem: [C: 032] "Self-merging based on 2 existing reviews." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94965 (owner: 10MaxSem) [21:48:34] (03Merged) 10jenkins-bot: Merge i18n files, step 1 [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94965 (owner: 10MaxSem) [21:53:58] (03CR) 10EBernhardson: [C: 032] Refactor editor selection code to be less hardcoded. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95115 (owner: 10Werdna) [21:54:11] (03Merged) 10jenkins-bot: Refactor editor selection code to be less hardcoded. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95115 (owner: 10Werdna) [22:04:30] (03CR) 10EBernhardson: [C: 032] Reply textarea fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95168 (owner: 10Matthias Mullie) [22:04:48] (03Merged) 10jenkins-bot: Reply textarea fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95168 (owner: 10Matthias Mullie) [22:06:00] legoktm: there's a gadget that enabled a bigger almost-OBOD [22:06:24] lolwut [22:06:26] legoktm: "Display a floating alert when I have new talk page messages" under Appearance [22:06:31] so stupid. [22:06:32] ok [22:06:36] i'll make sure we dont fuck with it [22:07:01] legoktm: https://en.wikipedia.org/wiki/MediaWiki:Gadget-topalert.js https://en.wikipedia.org/wiki/MediaWiki:Gadget-topalert.css [22:07:29] aude: you might want to see ^ too, since it adds a diff link as well, it seems [22:07:59] i think that was made as part of the solution of the lack-of-OBOD problem en.wp had when echo was enabled [22:09:55] legoktm: that gadget also uses the code from echo.alert.js that had a FIXME comment that nothing uses it [22:13:06] legoktm: or in other words, you've gotten yourself in a wonderful mess. :D [22:13:21] :< [22:13:36] :D [22:13:42] well, actually i guess not really [22:13:48] you'll just have to rewrite the gadget a little [22:13:52] or entirely [22:14:01] but that doesn't seem to be particularly difficult at least [22:14:11] just a little silly [22:17:58] Nemo_bis, RE wikipedia.it: how did itwiki use JS to count visitors per minute without sending private user data to untrusted servers? [22:21:24] And can't you use JS to make it instead display a great big "this is not a valid site" notice? [22:21:35] ugh, looks like it used the toolserver: https://it.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=23062204&oldid=22907787 [22:23:10] (03PS1) 10Aaron Schulz: Updated containers to set ACLs on [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/95286 [22:25:49] Krenair: the toolserver was used to display a message [22:26:13] and yes, the JS forced the redirect to escape the frame [22:26:35] (03PS2) 10EBernhardson: RecentChanges support for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95277 [22:26:43] that was the main purpose, though per community request it also added a message and then a counter [22:28:33] (03CR) 10Aaron Schulz: ""patch set X" type comments should go in gerrit not in the git summary" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [22:40:40] (03CR) 10EBernhardson: [C: 032] Add missing legacy action name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95149 (owner: 10Matthias Mullie) [22:40:50] (03Merged) 10jenkins-bot: Add missing legacy action name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95149 (owner: 10Matthias Mullie) [22:51:01] (03CR) 10Parent5446: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/95148 (owner: 10Gergő Tisza) [22:51:13] (03CR) 10Edokter: "effects.less seem to be missing he -ms-linear-gradient and -o-linear-gradient properties (or I am looking at the wrong file)." [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [22:58:12] (03PS1) 10Foxtrott: bugfixes (path to glyphicons wrong; RL exception when LESS compiler fails) [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/95292 [22:58:38] <^demon|away> MatmaRex: Ping. [22:59:09] ^demon|away: pong [22:59:41] <^demon|away> Did you see the latest comment on the UI fixes I made? [22:59:53] (03CR) 10Foxtrott: [C: 032 V: 032] bugfixes (path to glyphicons wrong; RL exception when LESS compiler fails) [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/95292 (owner: 10Foxtrott) [23:02:26] ^demon|away: nope [23:02:41] <^demon|away> https://gerrit.wikimedia.org/r/#/c/94276/ - very bottom [23:02:45] (03CR) 10Hoo man: [C: 031] "Looks good (untested)." [core] - 10https://gerrit.wikimedia.org/r/42278 (owner: 10Umherirrender) [23:03:19] MatmaRex: Is the Wikibase watchlist thing resolved yet? [23:03:33] ^demon|away: ah, you mean "the latest comment on [the UI fixes I made]". then i did, and it's on my todo list [23:03:45] hoo: define 'resolved' [23:03:55] (03PS2) 10Cmcmahon: VE takes a long time to appear [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95078 [23:03:55] MatmaRex: Has it been tested against Wikibase [23:04:17] hoo: i don't think so, i certainly did not test it :) [23:04:18] <^demon|away> MatmaRex: Language is hard :) [23:04:20] ^demon|away: i'm just waiting for superm401 and jgonera to complete their mediawiki.ui rewrite [23:04:27] <^demon|away> *nod* [23:04:41] MatmaRex: ah ok... point me to the right gerrit change then and I'll have a very brief look [23:04:44] ^demon|away: i think we just need vertical-align:middle; on mw.ui inputs and buttons [23:05:02] I'm half asleep but there's so much code review to do :/ [23:05:15] <^demon|away> I wouldn't know :p [23:05:30] hoo: the core change is https://gerrit.wikimedia.org/r/94288 and its dependencies [23:05:36] hey wait, I call dibs on hoo. [23:05:48] hoo: or you could check the top of the stack [23:05:56] hoo: https://gerrit.wikimedia.org/r/#/c/94677/ [23:06:06] hoo: but i now see it all needs some rebasing, so meh [23:06:08] (03CR) 10Chad: [C: 032] Added --sleep-per-batch to purgeChangedFiles.php [core] - 10https://gerrit.wikimedia.org/r/91802 (owner: 10Aaron Schulz) [23:06:15] MatmaRex: mh [23:06:23] just poke me at some time, rather... [23:06:29] ^demon|away: i'm just saying in case someone brings this up :P i already mentioned it to juliusz in passing [23:06:41] <^demon|away> okie dokie [23:07:06] (03CR) 10Jhall: [C: 031] "Looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95078 (owner: 10Cmcmahon) [23:08:20] (03CR) 10JGonera: "Edokter, -ms-linear-gradient has never existed, only IE10 supports gradients and it does it without a prefix. Also, from a reply to one of" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [23:08:51] (03CR) 10Chad: [C: 032] Cleanups to DB transaction handling [core] - 10https://gerrit.wikimedia.org/r/93627 (owner: 10Aaron Schulz) [23:09:18] superm401, are you reviewing the sass->less patchset? I don't want to rush you but I'm flying to India tomorrow so my connectivity will be limited and this will get delayed if we don't sort it out today [23:09:30] (03Merged) 10jenkins-bot: Added --sleep-per-batch to purgeChangedFiles.php [core] - 10https://gerrit.wikimedia.org/r/91802 (owner: 10Aaron Schulz) [23:09:48] (03CR) 10Gergő Tisza: [C: 032] "Cool, seems like this simplifies things quite a bit." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 (owner: 10Dan-nl) [23:10:02] (03CR) 10Chad: [C: 031] Hash long memcached keys and warn about it in the logs [core] - 10https://gerrit.wikimedia.org/r/94989 (owner: 10Aaron Schulz) [23:11:28] (03PS2) 10BryanDavis: lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [23:12:36] (03Merged) 10jenkins-bot: re-factor save metadata mapping [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 (owner: 10Dan-nl) [23:13:32] (03Merged) 10jenkins-bot: Cleanups to DB transaction handling [core] - 10https://gerrit.wikimedia.org/r/93627 (owner: 10Aaron Schulz) [23:14:31] jgonera, yes, I'll have another review soon. [23:14:41] (03CR) 10Jhall: [V: 032] "Looks good!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95078 (owner: 10Cmcmahon) [23:14:43] (03CR) 10Wikinaut: [C: 031 V: 031] adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 (owner: 10Wikinaut) [23:15:06] (03CR) 10Wikinaut: "Siebrand, pls, can you check, thanks in advance" [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 (owner: 10Wikinaut) [23:17:36] (03CR) 10Chad: [C: 032] Made cleanupUploadStash use batching for the last two loops [core] - 10https://gerrit.wikimedia.org/r/94451 (owner: 10Aaron Schulz) [23:20:39] (03Merged) 10jenkins-bot: Made cleanupUploadStash use batching for the last two loops [core] - 10https://gerrit.wikimedia.org/r/94451 (owner: 10Aaron Schulz) [23:21:06] (03CR) 10Chad: [C: 032] Avoid HEAD requests for files missing from the destination [core] - 10https://gerrit.wikimedia.org/r/95073 (owner: 10Aaron Schulz) [23:22:05] (03PS1) 10EBernhardson: Always use the topic post id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95299 [23:22:09] (03CR) 10BryanDavis: [C: 04-1] "(3 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 (owner: 10Dan-nl) [23:22:10] (03PS1) 10Bsitu: Topic history has different cache key for loading and saving [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95300 [23:23:30] (03CR) 10Hoo man: "(1 comment)" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [23:25:05] hi [23:25:23] (03Merged) 10jenkins-bot: Avoid HEAD requests for files missing from the destination [core] - 10https://gerrit.wikimedia.org/r/95073 (owner: 10Aaron Schulz) [23:26:26] do we have an Etherpad or Etherpad Lite which I can use (to prepare a discussion with CSteipp) ? [23:26:48] Wikinaut: http://etherpad.wikimedia.org/ [23:26:54] ok [23:29:37] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95300 (owner: 10Bsitu) [23:30:12] (03PS7) 10Legoktm: Optionally integrate with AntiSpoof [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 [23:30:57] (03PS2) 10EBernhardson: Topic history has different cache key for loading and saving [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95300 (owner: 10Bsitu) [23:31:46] legoktm: It actually was ok for ::matches to take a title object as param. if just shouldn't have created a new one... but that looks ok either [23:32:05] Which way do you think is better? [23:32:08] (03CR) 10Hoo man: [C: 031] "Untested" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [23:32:12] okay :) [23:32:36] (03CR) 10EBernhardson: [C: 032] Topic history has different cache key for loading and saving [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95300 (owner: 10Bsitu) [23:32:46] (03Merged) 10jenkins-bot: Topic history has different cache key for loading and saving [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95300 (owner: 10Bsitu) [23:32:58] legoktm: That way actually is a little cleaner as we don't have a Title object in the function with a "wrong" value around at some point [23:33:11] yeah [23:33:53] My dashboard's overwhelming ... hopefully I find some time for CR soon :/ [23:34:31] I mean proper code review which actually leads to merges, not only +1s :D [23:34:32] (03PS2) 10Krinkle: Add rc.unpatrolled to the recentchanges API [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95089 [23:34:35] (03PS2) 10Krinkle: Add rc.unpatrolled to the recentchanges API [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95088 [23:44:09] (03CR) 10EBernhardson: [C: 032] Clicking on pencil icon keeps adding new header form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95101 (owner: 10Bsitu) [23:44:42] (03CR) 10BryanDavis: [C: 04-1] "(2 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [23:44:45] (03Merged) 10jenkins-bot: Clicking on pencil icon keeps adding new header form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95101 (owner: 10Bsitu) [23:45:49] (03PS5) 10Ori.livneh: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 [23:47:57] (03PS6) 10Ori.livneh: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840