[00:19:12] (03PS7) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 [00:21:03] ori-l: wfTimestamp() returns a string by default (eventhough format is TS_UNIX and default is int/0) [00:21:06] nasty ;-) [00:21:18] ran into it when writing that last patch revision [00:21:34] worked before because (5 levels of abstraction later) php's max() tolerates that and casts to a number [00:22:07] ori-l: You mean for the purpose of normalising the definition? We could sort the keys, but not the values. [00:23:44] (03CR) 10Krinkle: "Implemented hash-in-key as discussed." [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [00:24:32] (03CR) 10Krinkle: "And changed key to be moduledefinition instead of moduleDefinition to be consistent with other cache keys used by resourceloader." [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [00:40:20] (03PS1) 10Legoktm: Initial import of Ryan Schmidt's code [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94833 [00:40:21] (03PS1) 10Legoktm: Modernize i18n file, clean up code [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94834 [00:40:22] (03PS1) 10Legoktm: Use localizable message for extension description [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94835 [00:40:23] (03PS1) 10Legoktm: Use new GetPreferences hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94836 [00:40:24] (03PS1) 10Legoktm: [WIP] Use ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [00:40:34] thedj: Hi [00:40:42] or #mediawiki [00:42:21] (03CR) 10Legoktm: [C: 032 V: 032] Initial import of Ryan Schmidt's code [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94833 (owner: 10Legoktm) [00:43:07] (03CR) 10Legoktm: [C: 032 V: 032] Modernize i18n file, clean up code [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94834 (owner: 10Legoktm) [00:43:33] (03CR) 10Legoktm: [C: 032 V: 032] Use localizable message for extension description [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94835 (owner: 10Legoktm) [00:43:58] (03CR) 10Legoktm: [C: 032 V: 032] Use new GetPreferences hook [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94836 (owner: 10Legoktm) [00:44:07] (03CR) 10Legoktm: [C: 04-2] [WIP] Use ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [00:46:07] legoktm: Minor thing you might want to do while at it: Use https for the extension url (description msg and credits array) and presumably coding style at some point. [00:46:59] Krinkle: missed that, thanks [00:48:22] (03CR) 10Krinkle: "Since the config is now in 1 general array (which is empty by default) this code looks like it will emit a php warning on a clean install " [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [00:48:24] yw [00:48:55] What would a sane default be? [00:50:41] (03CR) 10Krinkle: "Someone should test it to confirm it works as expected in modern browsers. This looks sane, but I reviewed this extension myself (and work" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (owner: 10Nischayn22) [00:51:10] legoktm: Well, there can't be any. But setting them to false would be matching the CentralAuth patch. [00:51:28] then at least the variable isn't unknown and causing an access warning. [00:52:02] ok [00:52:18] brb in 10 [00:59:03] (03PS1) 10Tim Starling: Fix timezone issue and PHP 5.4 support [php/wmerrors] - 10https://gerrit.wikimedia.org/r/94838 [01:33:50] (03PS1) 10Legoktm: Use https for description link [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94839 [01:34:15] Krinkle: ^ I'm not going to attempt to clean up the code style since most of it will be removed in the RL patch [01:34:26] sure [01:34:59] legoktm: i18n [01:34:59] 'globalcssjs-desc' => '{{desc|name=Global CSS/JS|url=http://www.mediawiki.org/wiki/Extension:GlobalCssJs}}', [01:35:03] ah [01:35:09] one sec [01:35:41] (03PS2) 10Legoktm: Use https for description link [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94839 [01:38:05] (03CR) 10Krinkle: [C: 032] Use https for description link [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94839 (owner: 10Legoktm) [01:38:20] Krinkle: needs V2, no jenkins on that repo yet [01:38:47] legoktm: I wasn't going to merge it yet, but if that's alright, I'll do. [01:39:00] V+2 won't merge it either, needs a manual Submit [01:39:03] yeah its fine if you merge it [01:39:18] mhm [01:39:22] (03CR) 10Krinkle: [V: 032] Use https for description link [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94839 (owner: 10Legoktm) [01:39:26] (03PS2) 10Legoktm: [WIP] Use ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [01:39:35] CR+2, V+2, +Submit [01:39:57] as opposed to CR+2, Publish [01:40:10] (03CR) 10Legoktm: "I made $wgGlobalCssJsConfig default false, and also added in checks for if $wgGlobalCssJsConfig is not configured, to exit the hooks." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [01:44:10] I'm wondering if the global.js/css page should have a message on top of the edit window to indicate that this is a special page and has different implications [01:46:08] (03PS1) 10Ori.livneh: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 [01:47:07] Elsie: added you as "ethical review board" [01:54:31] (03CR) 10Krinkle: [C: 031] Use checkboxShiftClick for "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [02:02:02] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [02:04:15] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [02:06:49] ori-l: ? [02:07:02] ori-l: === 1, that returns boolean [02:07:03] var a = 1, b = 2, c = 3; [ a === 1, b === 2 ? b : 0, c === 2 ? c : 0 ] [02:07:10] >> var a = 1, b = 2, c = 3; [ a === 1, b === 2 ? b : 0, c === 2 ? c : 0 ] [02:07:12] Krinkle: (object) [true, 2, 0] [02:07:33] ori-l: anyhow, you can document the property (as opposed to the closure) [02:07:51] @property {boolean|number}, of change it to {number} if that's what you intended. [02:09:26] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [02:12:33] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [02:14:22] (03CR) 10Krinkle: [C: 04-1] Add 'mediawiki.ui' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/87296 (owner: 10Mattflaschen) [02:22:14] (03CR) 10Krinkle: "(3 comments)" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 (owner: 10Parent5446) [02:27:34] (03CR) 10Krinkle: "(2 comments)" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 (owner: 10Parent5446) [02:30:05] (03CR) 10Krinkle: "I actually meant you'd default the individual values to false, not the global itself. That only avoids access warnings the first version. " [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [02:30:15] oh [02:30:16] heh [02:32:52] Krinkle: So then should I check if (!$config['wiki']) { return; }? Or assume that it's been configured properly? [02:35:44] legoktm: You won't have to do any extra if/return check at the beginning [02:36:14] Unless you specifically want to have a global "enable this feature" flag separate from the user preferencs, at which point that should probably be its own value. [02:36:40] if config[wiki] is false, then it won't equal the id or anything else. [02:36:52] If there is a check needed, you could check against false indeed. [02:39:11] (03Abandoned) 10GICodeWarrior: The PHP_CSS_Parser is added as a git submodule to the CSS Extension. The given PHP code- parser_demo.php is a script takes input a CSS file and uses the parser to parse the CSS file. It removes all the background attributes and displays the modified CSS f [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94497 (owner: 10Sakshi) [02:40:03] (03PS2) 10Shirayuki: Put application name in quotes [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94491 [02:56:36] hm [02:56:41] doesn't look like the check is needed [03:23:22] (03PS3) 10Legoktm: [WIP] Use ResourceLoader [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 [03:23:23] (03PS1) 10Legoktm: Display a notice on top of the edit window when editing global.css/js [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94842 [03:26:18] (03CR) 10Legoktm: "Ok, I set both values to false." [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94837 (owner: 10Legoktm) [03:37:47] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [04:00:39] (03PS1) 10Tim Starling: thumb.php: map b/c params prior to attempting redirection [core] - 10https://gerrit.wikimedia.org/r/94844 [04:04:28] (03CR) 10Ori.livneh: "On reflection, I don't think it's desirable to exclude browsers without Navigation Timing support. The impact of module storage should be " [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [04:33:21] (03PS6) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [04:34:41] (03PS8) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [04:35:44] (03PS2) 10AndyRussG: Fix student name in dialogue for removing article [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91894 [04:36:32] (03PS3) 10AndyRussG: Disable institution-page cache when logged in [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/92335 [04:51:19] (03PS9) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [04:51:31] (03PS42) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [04:51:38] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [05:46:12] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [06:19:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [06:24:20] (03CR) 10Siebrand: [C: 032] Put application name in quotes [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94491 (owner: 10Shirayuki) [06:24:26] (03Merged) 10jenkins-bot: Put application name in quotes [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94491 (owner: 10Shirayuki) [06:29:46] (03CR) 10Shirayuki: "Thanks." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94491 (owner: 10Shirayuki) [06:37:33] (03CR) 10Siebrand: "(2 comments)" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94835 (owner: 10Legoktm) [06:38:08] siebrand: will submit a new patchset momentarily, thanks [06:38:16] for the review* [06:38:19] legoktm: Thanks [06:38:42] legoktm: I have no solution for the "central" part. [06:39:07] I was just going to remove the quotes [06:39:21] I had just copied what Skizzerz wrote [06:41:34] (03PS1) 10Legoktm: Fix a few messages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94850 [06:41:56] (03CR) 10Legoktm: "(2 comments)" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94835 (owner: 10Legoktm) [06:42:05] siebrand: ^ [06:42:46] legoktm: You may want to get Jenkins set up if you're planning to do more development on the extension. [06:43:01] legoktm: hasher will happily set this up for you if you create a bug for it. [06:43:03] yeah, i'll do that eventually [06:43:07] hasher, that is. [06:43:22] (03CR) 10Siebrand: [C: 032 V: 032] Fix a few messages [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/94850 (owner: 10Legoktm) [06:44:17] thanks! [06:45:06] legoktm: thank you :) [06:59:28] (03PS1) 10Legoktm: triggers for GlobalCssJs extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94852 [07:00:26] (03PS1) 10Legoktm: Jobs for GlobalCssJs extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94853 [07:19:54] (03CR) 10Legoktm: [C: 04-1] "(2 comments)" [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/62533 (owner: 10tosfos) [07:32:32] (03CR) 10Legoktm: [C: 032 V: 032] "Tested, works fine." [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/85702 (owner: 10MarkAHershberger) [07:35:03] (03Abandoned) 10Legoktm: Script to audit page table [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87992 (owner: 10Legoktm) [07:37:27] (03CR) 10Yuvipanda: [C: 032] Remove unused configuration variable [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89770 (owner: 10Legoktm) [07:37:33] (03Merged) 10jenkins-bot: Remove unused configuration variable [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89770 (owner: 10Legoktm) [07:39:19] PissedPanda: any chance you want to review https://gerrit.wikimedia.org/r/#/c/91549/ ? you can enable thanks + echo with the echo role in vagrant [07:40:46] legoktm: doubt it today. Last day before I disappear off the internets for exam purposes, so.. dunno [07:40:48] sorry! [07:41:09] okay :( [07:41:09] good luck :D [07:44:25] good luck, Yuvi [07:47:41] ori-l: ty [07:51:30] (03PS2) 10Phuedx: Add the gettingstarted tour from the GuidedTour extension. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94369 [07:52:07] (03PS2) 10Phuedx: Remove the gettingstarted tour. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/94370 [07:56:01] (03CR) 10Legoktm: "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [07:56:45] (03PS5) 10Legoktm: Tests for API action=revisiondelete [core] - 10https://gerrit.wikimedia.org/r/92168 [07:57:43] (03CR) 10Legoktm: [C: 04-1] "Need to implement Anomie's suggestion: "You could also throw in tests where you hide everything, then unhide just one and assert the resul" [core] - 10https://gerrit.wikimedia.org/r/92168 (owner: 10Legoktm) [08:37:28] (03PS1) 10Siebrand: Use 'pagetitle' in content language [core] - 10https://gerrit.wikimedia.org/r/94862 [09:05:25] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [09:08:25] !g 86868 [09:08:26] https://gerrit.wikimedia.org/r/#q,86868,n,z [09:09:43] (03CR) 10Nemo bis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [09:19:35] (03PS6) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [09:19:37] (03PS2) 10Hashar: get-mw-core now fallback on git.wikimedia.org [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/87059 [09:31:49] (03PS2) 10Ori.livneh: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 [09:45:43] ori-l: does the experiment have a way to clear the browser, in case there is an error and people are stuck with bad JS ? [09:49:13] (03PS7) 10Hashar: WIP WIP browsertests for extension WIP WIP [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86868 [09:49:55] (03CR) 10TheDJ: "I haven't looked too much at the implementation, but if we are gonna run this live, I think we should have a way to force ably clean up af" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [10:15:06] (03PS4) 10IAlex: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 [10:15:48] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [10:17:29] (03PS1) 10Matthias Mullie: Get rid of 3rd argument in calls to Templating::renderPost() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94873 [10:17:33] (03CR) 10IAlex: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [10:18:45] (03CR) 10IAlex: "Corrected behaviour when coming from Special:UserLogin, now the form is submitted to the correct special page." [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [10:32:14] (03PS1) 10Pastakhov: add operator T_FOREACH [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94874 [10:34:43] (03PS1) 10Matthias Mullie: CSS should be shown to non-JS users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94875 [10:48:20] (03PS1) 10Matthias Mullie: Make actions box available to non-JS users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94877 [11:17:14] (03PS1) 10Matthias Mullie: Get rid of post-specific rendering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94881 [11:22:44] (03CR) 10Hashar: "You then need to have it triggered by Zuul by editing the configuration in integration/zuul-config.git :-)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 (owner: 10Addshore) [11:24:33] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94853 (owner: 10Legoktm) [11:24:55] (03Merged) 10jenkins-bot: Jobs for GlobalCssJs extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94853 (owner: 10Legoktm) [11:26:15] (03PS4) 10Nemo bis: Add direct links to translation interface on Special:AllMessages [core] - 10https://gerrit.wikimedia.org/r/94064 [11:32:01] (03PS1) 10Hashar: more extensions [extensions] - 10https://gerrit.wikimedia.org/r/94883 [11:32:15] (03CR) 10Hashar: [C: 032 V: 032] more extensions [extensions] - 10https://gerrit.wikimedia.org/r/94883 (owner: 10Hashar) [11:33:35] (03CR) 10Hashar: [C: 032] triggers for GlobalCssJs extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94852 (owner: 10Legoktm) [11:33:46] (03Merged) 10jenkins-bot: triggers for GlobalCssJs extension [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94852 (owner: 10Legoktm) [11:34:48] (03CR) 10Nemo bis: "The test wiki was updated. Less extreme examples of search queries:" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [11:35:25] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94852 (owner: 10Legoktm) [11:36:10] (03CR) 10Nemo bis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [11:37:20] (03CR) 10Dereckson: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [11:40:05] (03PS3) 10Esanders: Standardise and minimise licence headers [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 [12:12:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 (owner: 10Legoktm) [12:59:37] (03PS1) 10IAlex: Fix WikitextContentHandlerTest::testMakeRedirectContent() when content language is not english [core] - 10https://gerrit.wikimedia.org/r/94892 [13:01:05] (03PS43) 10Frédéric Wang: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [13:07:56] (03CR) 10MZMcBride: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [13:08:41] (03CR) 10MZMcBride: [C: 032] "Okay." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94697 (owner: 10Legoktm) [13:08:51] (03Merged) 10jenkins-bot: Change default name to 'MediaWiki message delivery' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94697 (owner: 10Legoktm) [13:11:03] (03PS5) 10IAlex: Add support for "tabindex" in HTMLFormField subclasses [core] - 10https://gerrit.wikimedia.org/r/62014 [13:12:52] (03CR) 10IAlex: "Refactored the attributes retrieval code to reduce code duplication. I guess this addresses Hashar's comment." [core] - 10https://gerrit.wikimedia.org/r/62014 (owner: 10IAlex) [13:18:39] (03PS1) 10Siebrand: Change interlanguage link title message key [core] - 10https://gerrit.wikimedia.org/r/94893 [13:20:21] (03CR) 10Siebrand: "Keys for other languages will be renamed in translatewiki.net by Raimond after merge." [core] - 10https://gerrit.wikimedia.org/r/94893 (owner: 10Siebrand) [13:21:11] (03CR) 10Liangent: [C: 031] Fix WikitextContentHandlerTest::testMakeRedirectContent() when content language is not english [core] - 10https://gerrit.wikimedia.org/r/94892 (owner: 10IAlex) [13:23:25] (03PS3) 10Hashar: Add DataValues qunit test [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 (owner: 10Addshore) [13:24:44] (03PS10) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [13:25:04] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [13:25:07] (03CR) 10Physikerwelt: "retrigger jenkins" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [13:25:11] (03PS4) 10Hashar: Add DataValues qunit test [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 (owner: 10Addshore) [13:25:35] (03CR) 10Hashar: [C: 032] Add DataValues qunit test [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 (owner: 10Addshore) [13:25:57] (03Merged) 10jenkins-bot: Add DataValues qunit test [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 (owner: 10Addshore) [13:27:07] (03CR) 10Raimond Spekking: [C: 032] Change interlanguage link title message key [core] - 10https://gerrit.wikimedia.org/r/94893 (owner: 10Siebrand) [13:27:43] (03PS1) 10Hashar: triggers mwext-DataValues-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94895 [13:28:01] (03CR) 10Hashar: "Zuul triggers in https://gerrit.wikimedia.org/r/94895" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 (owner: 10Addshore) [13:28:29] (03CR) 10Addshore: [C: 031] triggers mwext-DataValues-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94895 (owner: 10Hashar) [13:28:47] (03CR) 10Hashar: [C: 032] triggers mwext-DataValues-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94895 (owner: 10Hashar) [13:29:29] (03Merged) 10jenkins-bot: triggers mwext-DataValues-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94895 (owner: 10Hashar) [13:30:17] (03Merged) 10jenkins-bot: Change interlanguage link title message key [core] - 10https://gerrit.wikimedia.org/r/94893 (owner: 10Siebrand) [13:36:37] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [13:49:15] (03PS2) 10Pastakhov: add operator T_FOREACH [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94874 [13:51:17] (03CR) 10Pastakhov: [C: 032] add operator T_FOREACH [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94874 (owner: 10Pastakhov) [13:51:27] (03Merged) 10jenkins-bot: add operator T_FOREACH [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94874 (owner: 10Pastakhov) [14:10:35] (03PS1) 10Amire80: Add a class to interlanguage links [core] - 10https://gerrit.wikimedia.org/r/94899 [14:12:05] (03PS1) 10Matthias Mullie: Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 [14:13:39] (03PS12) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [14:17:40] (03PS2) 10Amire80: Corrected message spelling [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94796 [14:21:14] (03PS2) 10Matthias Mullie: Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 [14:36:15] (03CR) 10Siebrand: [C: 032] Make 'quotation-marks' message non-optional [core] - 10https://gerrit.wikimedia.org/r/94827 (owner: 10Bartosz Dziewoński) [14:39:36] (03Merged) 10jenkins-bot: Make 'quotation-marks' message non-optional [core] - 10https://gerrit.wikimedia.org/r/94827 (owner: 10Bartosz Dziewoński) [14:44:13] (03PS1) 10Siebrand: Use country neutral "national identification number" [core] - 10https://gerrit.wikimedia.org/r/94903 [14:47:10] (03CR) 10Raimond Spekking: [C: 032] Use country neutral "national identification number" [core] - 10https://gerrit.wikimedia.org/r/94903 (owner: 10Siebrand) [14:52:11] (03Merged) 10jenkins-bot: Use country neutral "national identification number" [core] - 10https://gerrit.wikimedia.org/r/94903 (owner: 10Siebrand) [14:54:33] (03PS3) 10Matthias Mullie: Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 [14:57:58] (03PS1) 10Matthias Mullie: Automagically put username of user I'm replying to in replies to tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94906 [14:59:59] (03PS1) 10IAlex: Use correct case for SpecialRecentChanges class in SpecialPageFactory::$mList [core] - 10https://gerrit.wikimedia.org/r/94908 [15:13:09] (03PS2) 10Matthias Mullie: Automagically put username of user I'm replying to in replies to tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94906 [15:22:53] (03CR) 10BryanDavis: "It would be nice to roll this out this week in the deploy train." [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94396 (owner: 10BryanDavis) [15:23:07] (03PS2) 10BryanDavis: Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94392 [15:23:16] (03CR) 10BryanDavis: "It would be nice to roll this out this week in the deploy train." [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94392 (owner: 10BryanDavis) [15:37:26] Reedy: I hate to call you out, but can you help me find some logs relating to Bug 56936? [15:37:36] I can't find any logs of it and you are the best log finder I know [15:42:23] (03PS1) 10Matthias Mullie: Don't send additional notifications if user already received mention notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94912 [15:42:54] (03PS2) 10Matthias Mullie: Don't send additional notifications if user already received mention notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94912 [15:43:53] (03CR) 10Cscott: [C: 032] Increase limits to Special:MyCourses activity feeds [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/86880 (owner: 10Ragesoss) [15:44:04] (03Merged) 10jenkins-bot: Increase limits to Special:MyCourses activity feeds [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/86880 (owner: 10Ragesoss) [15:52:14] (03CR) 10Cscott: [C: 032] "Approving, but these extremely long single-line comments violate https://www.mediawiki.org/wiki/Manual:Coding_conventions#Line_continuatio" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/82888 (owner: 10Ragesoss) [15:52:36] (03Merged) 10jenkins-bot: Add comments to clarify the structure of the extension. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/82888 (owner: 10Ragesoss) [15:53:51] (03CR) 10Cscott: [C: 032] Remove Settings::newFromGlobals [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/69977 (owner: 10Jeroen De Dauw) [15:53:57] (03Merged) 10jenkins-bot: Remove Settings::newFromGlobals [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/69977 (owner: 10Jeroen De Dauw) [15:55:55] (03CR) 10Ragesoss: "Thanks for the feedback Cscott. This patch was mainly for my own edification, as I'm trying to get more familiar with the codebase. So fla" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/82888 (owner: 10Ragesoss) [15:57:23] (03CR) 10Cscott: "Check out the phpdoc comment structure, too. I can't recite it chapter and verse from the top of my head, but block-style comments can ap" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/82888 (owner: 10Ragesoss) [16:00:15] (03CR) 10Cscott: [C: 032] "Looks reasonable, and I'm merging it to try to get ahead of the backlog here. In the future, I usually strongly recommend adding extra in" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91894 (owner: 10AndyRussG) [16:00:23] (03Merged) 10jenkins-bot: Fix student name in dialogue for removing article [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91894 (owner: 10AndyRussG) [16:01:57] (03CR) 10Cscott: "Hm, lots of lint failures. Were they introduced in this patch, or were they preexisting?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [16:05:06] resending sad spam: [16:05:09] does anyone have a chance to look at Bug 56936? en.wp search failures that I can't reproduce or find logs for. [16:08:13] andre__, hi, just sent an email with the conf room [16:10:18] (03PS1) 10Cscott: Update INSTALL: this extension no longer uses SVN. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94919 [16:11:38] (03CR) 10Jeroen De Dauw: [C: 032] Update INSTALL: this extension no longer uses SVN. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94919 (owner: 10Cscott) [16:20:17] (03PS1) 10Tpt: Include base module in mobile view [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/94921 [16:20:51] (03CR) 10Siebrand: [C: 032] Corrected message spelling [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94796 (owner: 10Amire80) [16:21:06] (03Merged) 10jenkins-bot: Corrected message spelling [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94796 (owner: 10Amire80) [16:29:01] (03CR) 10Legoktm: "(2 comments)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [16:31:43] (03PS1) 10Cscott: Whitespace fixes: adhere to PHP code conventions. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94922 [16:32:06] (03PS11) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [16:32:20] (03CR) 10jenkins-bot: [V: 04-1] Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [16:35:21] (03PS1) 10Manybubbles: Fix two more query types that cause ES to choke [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 [16:48:59] (03CR) 10Physikerwelt: [V: 032] "@hashar: all tests passed locally. I did not change anything and did a rebase only. Maybe jenkins has no link to external resources anymor" [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 (owner: 10Physikerwelt) [16:53:54] (03PS1) 10Cscott: De-lint JavaScript sources. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94926 [16:55:34] (03CR) 10Cscott: "(Answering my own question:) They seem to be pre-existing, see https://gerrit.wikimedia.org/r/94926" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [17:00:31] (03CR) 10Cscott: [C: 04-1] "(3 comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/92335 (owner: 10AndyRussG) [17:01:16] (03CR) 10Cscott: "Should this patch set be abandoned?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/63914 (owner: 10Jeroen De Dauw) [17:02:44] REMINDER: Wikimedia Engineering Community Team meeting now starting in #wikimedia-meetbot - everybody is welcome to join! More info: https://www.mediawiki.org/wiki/Engineering_Community_Team/Meetings#2013-11-12 [17:04:57] (03CR) 10Cscott: [C: 04-1] "Looks good, but it would be nice to add test cases if possible." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [17:07:56] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [17:08:30] (03PS44) 10Frédéric Wang: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [17:10:35] (03CR) 10Greg Grossmeier: [C: 031] Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94392 (owner: 10BryanDavis) [17:10:42] (03CR) 10Greg Grossmeier: [C: 031] Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94396 (owner: 10BryanDavis) [17:12:55] (03PS1) 10Cscott: Fix spelling of 'addition' in code and messages. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94932 [17:16:46] (03PS9) 10Cscott: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [17:17:06] (03CR) 10Chad: [C: 032] Term containing * match against unstemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94373 (owner: 10Manybubbles) [17:17:18] (03Merged) 10jenkins-bot: Term containing * match against unstemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94373 (owner: 10Manybubbles) [17:17:36] (03CR) 10Chad: [C: 032] Tests for term containing * match unstemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94374 (owner: 10Manybubbles) [17:17:41] (03Merged) 10jenkins-bot: Tests for term containing * match unstemmed text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94374 (owner: 10Manybubbles) [17:20:27] (03CR) 10Chad: [C: 032] Use filtered query rather than results filtering [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94387 (owner: 10Manybubbles) [17:20:31] (03Merged) 10jenkins-bot: Use filtered query rather than results filtering [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94387 (owner: 10Manybubbles) [17:22:12] (03CR) 10Cscott: [C: 04-1] "(3 comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [17:23:34] (03PS45) 10Frédéric Wang: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [17:25:38] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 (owner: 10Manybubbles) [17:26:53] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [17:27:52] (03CR) 10Aaron Schulz: [C: 032] Localize plaintext log entry links properly [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94687 (owner: 10Legoktm) [17:27:55] (03CR) 10Chad: [C: 032] Suppress section edit links with action=render [core] - 10https://gerrit.wikimedia.org/r/94150 (owner: 10Bartosz Dziewoński) [17:28:21] marktraceur: it would be nice to improve the jenkins configuration for the education extension. hook up codestyle, eg. [17:28:33] (03Merged) 10jenkins-bot: Localize plaintext log entry links properly [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94687 (owner: 10Legoktm) [17:28:36] marktraceur: also, it seems that jshint is not being run consistently on patches. [17:28:49] cscott: Is "it would be nice to" code for "hey you should" [17:29:02] (03CR) 10Manybubbles: [C: 04-1] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 (owner: 10Manybubbles) [17:29:31] I'm not sure I have the cycles now, but I'd be happy to review patches and deploy stuff 'n' things [17:29:40] marktraceur: yeah, that's exactly my status ;) [17:30:03] it was code for 'one of us should, don't let me forget (and if you beat me to it, yay)' [17:30:06] Heh [17:30:11] * marktraceur files t3h bug [17:31:14] (03Merged) 10jenkins-bot: Suppress section edit links with action=render [core] - 10https://gerrit.wikimedia.org/r/94150 (owner: 10Bartosz Dziewoński) [17:35:52] manybubbles: I think the first part of the problem is that 'mwsearch' logging doesn't currently log anywhere [17:36:08] Reedy: I saw that. can/should we fix that? [17:36:13] <^d> Reedy, manybubbles: It's spammy, so I've only enabled it for short periods of time. [17:36:15] <^d> When needed. [17:36:39] really? [17:36:41] (03CR) 10Ragesoss: [C: 031 V: 031] "Looks right to me, and I tested a bit and the messages seems to all be still working." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94932 (owner: 10Cscott) [17:36:47] wfDebugLog( 'mwsearch', 'Search backend error: ' . $m[1] ); [17:36:48] <^d> Reedy: For enwiki it would be. [17:36:54] wfDebugLog( 'mwsearch', "Search timeout requesting $searchUrl" ); [17:37:03] <^d> Doesn't it also wfDebugLog() every normal search? [17:37:06] Quick scan suggests it only uses it for those 2 [17:37:11] <^d> nvm then. [17:37:13] <^d> turn it on. [17:37:19] <^d> It was spammy awhile back :p [17:37:20] not using the mwsearch key at least [17:37:28] ^d: we do - but we'll clean it up before enwiki [17:37:40] Did you fix it because it pissed you off? [17:37:45] <^d> Might've. [17:37:49] <^d> mwsearch does tend to piss me off. [17:38:00] (03PS2) 10Manybubbles: Fix two more query types that cause ES to choke [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 [17:38:02] (03CR) 10jenkins-bot: [V: 04-1] Fix two more query types that cause ES to choke [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 (owner: 10Manybubbles) [17:38:56] (03CR) 10Krinkle: "Maybe we could add some logic to clear the storage if the vary has changed (e.g. storage version) or the enabledness (either due to server" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [17:39:43] (03PS13) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [17:39:54] 2013-11-12 17:39:48 mw1109 srwiki: Search backend error: Empty search [17:39:54] 2013-11-12 17:39:49 mw1079 enwiki: Search backend error: Empty search [17:39:54] 2013-11-12 17:39:49 mw1077 enwiki: Search backend error: Empty search [17:40:06] manybubbles: /a/mw-log/mwsearch.log on fluorine is now getting stuff [17:40:16] 2013-11-12 17:40:10 mw1098 frwiki: Search backend error: Internal error in SearchEngine: Trying to extract field from zero-length list of terms [17:40:30] <^d> Yeah that's why I shut it off. [17:40:33] <^d> "empty search" [17:40:36] (03CR) 10EBernhardson: [C: 032] Fix element that seems to have changed in VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94347 (owner: 10Matthias Mullie) [17:40:39] Reedy: ah. that isn't too nice. [17:41:03] hmmm - I'm not really sure what to do with this problem then. I can't reproduce it [17:41:13] (03Merged) 10jenkins-bot: Fix element that seems to have changed in VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94347 (owner: 10Matthias Mullie) [17:41:28] (03CR) 10Ragesoss: [C: 031] Whitespace fixes: adhere to PHP code conventions. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94922 (owner: 10Cscott) [17:41:30] There's a few showing no error [17:41:35] 2013-11-12 17:41:29 mw1044 dewiki: Search backend error: [17:41:47] (03PS1) 10Aaron Schulz: Expanded use of reauthenticateConnection() beyond just Lua calls [core] - 10https://gerrit.wikimedia.org/r/94935 [17:41:52] 2013-11-12 17:41:45 mw1201 enwiki: Search timeout requesting http://10.2.2.11:8123/search/enwiki/Thor%202?namespaces=0&offset=0&limit=11&version=2.1&iwlimit=10&searchall=0 [17:42:27] (03PS14) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [17:42:44] (03CR) 10Manybubbles: [C: 04-1] "rebasing" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 (owner: 10Manybubbles) [17:43:50] (03PS15) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [17:46:07] (03PS1) 10Reedy: Don't log "Empty search" errors [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/94936 [17:46:10] ^d: manybubbles ^ [17:46:19] We can at least filter out the rubbish to begin with [17:46:51] (03CR) 10Chad: [C: 032] Don't log "Empty search" errors [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/94936 (owner: 10Reedy) [17:46:53] (03Merged) 10jenkins-bot: Don't log "Empty search" errors [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/94936 (owner: 10Reedy) [17:47:00] (03CR) 10Manybubbles: "I love it." [extensions/MWSearch] - 10https://gerrit.wikimedia.org/r/94936 (owner: 10Reedy) [17:47:17] tail -f mwsearch.log | grep -v "Empty search" does the same thing though ;) [17:47:36] I've been doing that [17:47:56] Only errors I can obviously see are the timeouts [17:48:07] And the no error ones which are possibly interesting [17:49:25] <^d> Reedy: But with patch we can keep the log from growing so much :p [17:49:26] and the zero-length list of terms [17:49:35] Heh, very true [17:49:38] I'll deploy [17:50:26] (03PS3) 10Manybubbles: Fix two more query types that cause ES to choke [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 [17:50:37] (03PS1) 10Reedy: Update MWSearch to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94937 [17:51:29] (03CR) 10Chad: [C: 032] Fix two more query types that cause ES to choke [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 (owner: 10Manybubbles) [17:52:24] (03PS1) 10Reedy: Update MWSearch to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94938 [17:52:51] (03CR) 10Reedy: [C: 032 V: 032] Update MWSearch to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94937 (owner: 10Reedy) [17:52:57] (03CR) 10Reedy: [C: 032 V: 032] Update MWSearch to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94938 (owner: 10Reedy) [17:52:58] (03Merged) 10jenkins-bot: Fix two more query types that cause ES to choke [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94924 (owner: 10Manybubbles) [17:54:32] (03CR) 10Jdlrobson: [C: 031] Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [17:54:32] (03PS16) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [17:55:59] Quiet log is quiet [17:58:01] Reedy: for search? I don't believe you [17:58:14] Nemo_bis: It's all relative [17:58:32] if it's relatively quiet, can we not disable it then? :) [17:58:50] so that we can at least wc -l it to see if things get worse over time [17:59:10] No [17:59:17] aww [17:59:17] It's going to grow in the same way all the other logs grow [17:59:30] One host just gave 10s of timeouts [17:59:32] as in sustainably? [17:59:53] It's not being spammed with a load of useless errors now [18:00:57] ah, empty search; good [18:04:58] (03CR) 10Aaron Schulz: [C: 032] thumb.php: map b/c params prior to attempting redirection [core] - 10https://gerrit.wikimedia.org/r/94844 (owner: 10Tim Starling) [18:06:10] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [18:07:07] (03CR) 10Krinkle: "(from PS1) Is it by design that the bucketing overrides the storageEnabled configuration (and visa versa?)." [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [18:08:03] (03Merged) 10jenkins-bot: thumb.php: map b/c params prior to attempting redirection [core] - 10https://gerrit.wikimedia.org/r/94844 (owner: 10Tim Starling) [18:15:57] hi all [18:16:20] i'm from Wikivoyage and we need some help on CSS [18:16:33] anybody with good knowledge of CSS around? [18:16:44] I guess I can help, but my time's limited ;) [18:16:55] oh [18:16:57] https://en.wikivoyage.org/wiki/Talk:Main_Page#Carousel_of_Progress [18:17:03] (03PS1) 10Aaron Schulz: Removed sanity regex since there are too many random formats to track [core] - 10https://gerrit.wikimedia.org/r/94940 [18:17:26] actually we're not figuring out how can we add buttons [18:17:30] Saqib: tl;dr? [18:17:38] which will upon clicking move the carousel slide [18:17:58] tl;dr? what [18:18:05] to long; didn't read [18:18:10] oh k [18:18:16] (03PS1) 10Aaron Schulz: Removed sanity regex since there are too many random formats to track [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94941 [18:18:28] do you have acc on WV? [18:18:29] I see... so you want to rotate the wikivoyage "star" triangle thing? [18:18:35] Sure [18:18:46] I got admin rights there as far as this goes [18:18:47] nop [18:19:07] i want you to visit this [18:19:07] https://en.wikivoyage.org/wiki/User:Nicholasjf21/MainPage2 [18:19:11] our proposed main page design [18:19:37] but in order to see it properly, you will need to add this code in your commons.css https://en.wikivoyage.org/wiki/User:Nicholasjf21/common.css [18:19:54] may i know your account on WV? [18:19:59] i will do it for you [18:20:37] (03PS1) 10Bartosz Dziewoński: Do not escape title attribute twice for tooltip-iwiki [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94942 [18:20:48] Saqib: You don't have to, I can apply them dynamically [18:20:55] ok [18:21:07] I work a lot with on site scripting ;) [18:21:12] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport, blocks backporting fix to bug 56129 too." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94942 (owner: 10Bartosz Dziewoński) [18:21:13] i see [18:21:35] so you're https://meta.wikimedia.org/wiki/User:Hoo_man [18:21:42] indeed [18:22:05] so can you see main page working for you properly/ [18:22:07] ? [18:22:31] it looks a little odd in Firefox [18:23:25] (03CR) 10MarkTraceur: [C: 04-1] "See comments on previous patchsets and in IRC." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [18:23:31] are you on WV logging in? [18:23:54] I'm logged in and have the CSS applied... and see the images changing [18:24:08] goof [18:24:09] good [18:24:37] i've also added them here https://en.wikivoyage.org/wiki/User:Hoo_man/common.css [18:24:43] so what we want is [18:24:46] that [18:24:54] (03CR) 10Bartosz Dziewoński: [V: 032] "(tired of waiting)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94942 (owner: 10Bartosz Dziewoński) [18:25:02] we need a button . which upon click change those image [18:25:58] You'll need JavaScript for that, I think... it might be doable with two images in CSS, but not with three [18:26:10] i see [18:26:21] (03PS1) 10Bartosz Dziewoński: Change interlanguage link title message key [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94945 [18:26:25] one thing more [18:27:03] (03CR) 10Bartosz Dziewoński: [C: 031] "Backport pending action by Siebrand or Raimond." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94945 (owner: 10Bartosz Dziewoński) [18:27:04] see this please https://en.wikivoyage.org/wiki/File:Main_page_mockup.png [18:27:26] can you make boxes like this with semi transparent background [18:27:46] the two boxes you can . one on right and another on left side [18:27:48] sure, use CSS opacity for that [18:28:09] hmm, but i don't know much how to do it [18:28:23] but I'd oppose that layout slightly, it's hard to read for visibility impaired users [18:28:45] who are visibility impaired users [18:29:11] but atleast can we give it a try? [18:29:38] Sure, but you have to make sure that you keep a decent letter size and contrast [18:29:56] ok [18:30:22] so... [18:30:37] are you going to help me with the codes please [18:31:58] Saqib: For the current main page or the new proposed one [18:31:59] ? [18:32:05] propose pne [18:32:29] obviously [18:32:57] for the boxes like " Destination of the Month: Fooland" ? [18:33:08] yes [18:33:11] (03PS1) 10Adamw: looks like operations/puppet is back to mainline redis [vagrant] - 10https://gerrit.wikimedia.org/r/94947 [18:37:08] Saqib: .carousel .panes li h2 { opacity: x; } [18:37:16] that will do what you want [18:37:39] there x is a number from 0 to 1 (0 meaning the item is totally invisible, 1 the item is 100 visible) [18:38:45] added here but nothing : https://en.wikivoyage.org/w/index.php?title=User%3ASaqib%2Fcommon.css&diff=2463119&oldid=2463063 [18:38:58] ops [18:41:19] nothing works [18:41:28] Saqib: between 0 and 1 [18:41:35] eg. 50% visibility is .5 ;) [18:41:58] .carousel .panes li h2 { opacity: .5; } [18:42:06] (03PS1) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [18:42:30] that would work... .5 is 0.5 [18:42:42] I'm a lazy person, that's why I often drop the leading zeros [18:43:11] hmm [18:43:14] it worked but [18:43:32] its also lighted the text as well [18:43:42] whereas i only wanted to lighten the background [18:43:47] that black bg [18:44:02] does anyone know if the jenkins cofigurations have been changed recently. I had written an integration test that called an external webservice which gets a timeout now even though the service is running and the test runs locally [18:44:25] without error [18:44:47] (03PS4) 10Krinkle: resourceloader: Use state "error" instead of "missing" in case of exceptions [core] - 10https://gerrit.wikimedia.org/r/90320 [18:44:53] (03PS8) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [18:45:02] Saqib: I see, that'll make the code slightly more complicated [18:45:48] np [18:46:13] (03CR) 10jenkins-bot: [V: 04-1] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [18:46:36] Saqib: Is the background supposed to be black? [18:46:42] no [18:46:43] white [18:46:52] (03CR) 10MarkAHershberger: [C: 032] Change interlanguage link title message key [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94945 (owner: 10Bartosz Dziewoński) [18:47:05] qgil: ping [18:47:05] ok, because the current version has it black [18:47:23] yes [18:47:28] will fix it [18:47:34] gwicke: RoanKattouw do you know the public IP for the parsoid service? [18:47:49] YuviPanda: http://parsoidcache.svc.eqiad.wikimedia.org/ [18:47:57] see the parsoid section in http://etherpad.wikimedia.org/p/Scrum-of-Scrums [18:48:21] YuviPanda: the gerrit change is not yet merged [18:48:26] ah [18:48:27] ok [18:49:15] gwicke: any idea when it'll be merged? [18:49:27] and link to gerrit patchset maybe? [18:49:35] YuviPanda: mark promised this week on the gerrit patch [18:49:42] it is linked already ;) [18:49:42] ah sweet [18:49:50] \o/ [18:49:54] ah nevermindd [18:50:13] (03PS1) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94951 [18:50:24] * YuviPanda stars it [18:51:30] its here : background-color:rgba(0,0,0,0.5); [18:51:42] i think i will have to changes the value to 255 . right? [18:51:51] To get the thing white, yes [18:52:00] ok [18:52:17] the last floating point number gives the opacity similar to what I showed you a few mins ago [18:52:42] hmm [18:52:51] siebrand or Nikerabbit, is there a way to merge 2 message files into one? [18:53:16] cat one two > notWhatYouWantProbably [18:54:18] will this code work : background-color:#ffffff [18:54:41] Yes, but that doesn't include any transparency [18:54:55] and don't forget the trailing ; or you might get syntax errors [18:55:23] ok . i change the box colour [18:55:28] can you please fix the text color [18:56:02] Saqib: In whose CSS? In https://en.wikivoyage.org/wiki/User:Saqib/common.css ? [18:56:09] MaxSem: just move the english keys (don't rename anything) and it should go automatically on next *full* export (should prolly request that) [18:56:21] sure [18:56:25] back to sauna [18:56:32] thanks! [18:56:52] spagewmf, chrismcmahon: https://gerrit.wikimedia.org/r/#/c/93939/ looks like it might already update parsoid in betalabs [18:57:36] Saqib: Shall I also add the transparency? And if so, with what percentage? [18:57:44] 50% [18:57:55] gwicke: I thought that was incomplete. [18:58:38] chrismcmahon: can you be specific about what is missing? [18:58:55] gwicke: actually, no. I [18:59:06] gwicke: I'd have to ask hashar [18:59:07] btw, hoo. you don't know js? [19:00:13] Saqib: :P I'm earning my money with JS (mostly) [19:00:24] oh [19:00:25] (03PS1) 10EBernhardson: Increase padding inside wikitext reply box [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94953 [19:01:08] can't you help with adding a button please [19:01:29] we only lacks a button feature and then our design is done [19:01:50] (03CR) 10EBernhardson: [C: 032] Never use getModeratedByUserText in history, always revision usertext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94358 (owner: 10Matthias Mullie) [19:02:00] (03Merged) 10jenkins-bot: Never use getModeratedByUserText in history, always revision usertext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94358 (owner: 10Matthias Mullie) [19:03:32] (03PS1) 10MaxSem: Remove template blacklisting functionality [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94954 [19:04:03] Saqib: I don't want to discourage you, but are you sure that's working across browsers (IE!!!) in a reliable way? I doubt that (although I didn't test it with anything else than Firefox) [19:04:18] greg-g: is the train going to hit en wiki today? [19:04:22] if so when? [19:04:29] yes it workings [19:04:40] i am using safari [19:04:40] YuviPanda: https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap#Schedule_for_the_deployments [19:04:57] many users using IE said it worked for them [19:05:02] greg-g: alright then. [19:05:10] greg-g: also, approximate time information? [19:05:13] 2013-11-12 14:14:26 mw1012 bnwiki: Memcached error for key "bnwiki:cirrus:linkcounts:Elizabeth_II_of_the_United_Kingdom,_Canada,_Australia,_New_Zealand,_Jamaica,_Barbados,_the_Bahamas,_Grenada,_Papua_New_Guinea,_the_Solomon_Islands,_Tuvalu,_St._Lucia,_St._Vincent_and_the_Grenadines,_Belize,_Antigua_and_Barbuda,_and_St._Kitts_and_Nevis" on server ":": A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE [19:05:20] Saqib: Well, you need to test it with older versions of IE also [19:05:37] such a legit title [19:05:54] hmm [19:06:21] YuviPanda: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_November_11 [19:06:29] * greg-g rtfm's YuviPanda  [19:06:31] ;) [19:06:39] heh :P [19:06:46] so hoo [19:07:00] yes? [19:07:13] greg-g: I didn't know of the wikitech page for deployments [19:07:18] you want me to first try the page on older IE? [19:07:36] YuviPanda: YOU DON'T READ MY EMAILS THEN! [19:07:38] (03PS8) 10EBernhardson: Copy tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [19:07:41] (03PS1) 10Bsitu: Fix the primary action message text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94955 [19:07:42] * greg-g pouts [19:07:51] :P [19:07:59] (03CR) 10EBernhardson: [C: 032] "rebased, and merge" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [19:08:26] (03Merged) 10jenkins-bot: Copy tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [19:09:19] Saqib: Updated your .css now [19:09:25] ok [19:09:54] I had to alter one of Nichlasjf21's pages, btw [19:10:09] sure [19:10:12] he won't mind [19:10:43] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [19:10:57] btw, i've been told to add something like this : document.getElementById("itsIDHere"), then attach an Event Listener like .addEventListener("click", functionThatRotatesTheImage) [19:11:24] use jQuery [19:11:43] the CSS stuff should look as you wanted it now [19:11:45] have fun [19:12:21] (03PS3) 10Ori.livneh: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 [19:12:45] not really [19:12:57] the text is still light [19:13:08] i can barely read it [19:13:12] hard reload the page (ctrl + f5 [19:13:13] ) [19:14:32] ( [19:14:41] gah. that was accidental, really. [19:14:52] (i'll be playing with the bot, don't mind me) [19:14:52] !!ask [19:14:52] Yes, #mediawiki has a lot of people idling. If they were all talking, there'd be no on-topic discussions at all. The channel can be social but is in no way required to be. If you take offense at the silence, you may wish to find a more social channel. If you need help, just ask, and please don't ask for help or for attention before actually asking your question, that's just a waste of time, see !ask [19:15:02] !!ask unalias [19:15:02] Alias removed! [19:15:06] !quiet alias tooquiet [19:15:06] Created new alias for this key [19:15:09] !quiet [19:15:09] Yes, #mediawiki has a lot of people idling. If they were all talking, there'd be no on-topic discussions at all. The channel can be social but is in no way required to be. If you take offense at the silence, you may wish to find a more social channel. If you need help, just ask, and please don't ask for help or for attention before actually asking your question, that's just a waste of time, see !ask [19:15:18] presto. [19:15:35] (03CR) 10MarkAHershberger: "self review so we get this in tarball." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94951 (owner: 10MarkAHershberger) [19:15:36] is anyone really using that functionality (despite for changing it) :P [19:15:50] (03CR) 10MarkAHershberger: [C: 032] "self review so we get this in tarball." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94951 (owner: 10MarkAHershberger) [19:16:07] (03PS3) 10Reedy: Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94392 (owner: 10BryanDavis) [19:16:13] (03CR) 10Reedy: [C: 032] Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94392 (owner: 10BryanDavis) [19:16:17] (03PS2) 10Reedy: Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94396 (owner: 10BryanDavis) [19:16:22] (03CR) 10Reedy: [C: 032] Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94396 (owner: 10BryanDavis) [19:17:37] (03PS6) 10EBernhardson: Move output functionality from AbstractRevision to Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [19:17:54] (03CR) 10Manybubbles: [C: 031] "Logic is sound and it works when I integrate it into CirrusSearch. I'd +2 it but I'm gunshy on +2ing mw/core." [core] - 10https://gerrit.wikimedia.org/r/94582 (owner: 10Aaron Schulz) [19:18:14] (03CR) 10EBernhardson: [C: 032] "rebased against newest master, and merge" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [19:21:29] anyway thanks hoo [19:21:38] i will catch you later [19:21:52] but we will definitely need your help with buttons [19:21:53] Saqib: Sorry, but my time is very limited... I'm always happy to assist with minor stuff, though [19:22:08] i can understand [19:22:37] (03PS1) 10Ori.livneh: Rather than upsert module store, explicitly remove old value and then add new one [core] - 10https://gerrit.wikimedia.org/r/94959 [19:24:45] (03CR) 10Jdlrobson: [C: 032] Add beta preferences icons for Hebrew and Arabic [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/94423 (owner: 10Amire80) [19:24:51] (03CR) 10Jdlrobson: [V: 032] Add beta preferences icons for Hebrew and Arabic [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/94423 (owner: 10Amire80) [19:25:10] (03PS3) 10Dan-nl: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [19:25:11] (03PS1) 10Dan-nl: lang-attribute [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94960 [19:26:34] (03Merged) 10jenkins-bot: Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94392 (owner: 10BryanDavis) [19:27:03] (03Draft1) 10Wikinaut: adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 [19:28:38] (03CR) 10Jeroen De Dauw: [C: 032] Whitespace fixes: adhere to PHP code conventions. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94922 (owner: 10Cscott) [19:28:40] (03Merged) 10jenkins-bot: Move output functionality from AbstractRevision to Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [19:28:42] c'mon jenkins [19:29:44] (03Merged) 10jenkins-bot: Support CIDR ranges in $wgSquidServersNoPurge [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94396 (owner: 10BryanDavis) [19:32:26] (03PS2) 10Wikinaut: adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 [19:33:40] (03Draft2) 10Wikinaut: adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 [19:33:58] (03CR) 10Wikinaut: [C: 031 V: 031] adding missing "rights" and "action" texts for Special:ListGroupRights [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 (owner: 10Wikinaut) [19:34:56] (03PS1) 10Jeroen De Dauw: Fix location of variable initialization [core] - 10https://gerrit.wikimedia.org/r/94962 [19:36:12] (03CR) 10Wikinaut: "Siebrand, I added you and kindly ask you to code-review my message texts." [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/94961 (owner: 10Wikinaut) [19:36:22] (03PS2) 10Jeroen De Dauw: Fix location of variable initialization [core] - 10https://gerrit.wikimedia.org/r/94962 [19:37:10] (03PS1) 10Bartosz Dziewoński: Expand release notes for Iab02cbd4 [core] - 10https://gerrit.wikimedia.org/r/94963 [19:37:23] ^ easy peasy, anyone? [19:37:44] (03CR) 10Hoo man: [C: 032] Fix location of variable initialization [core] - 10https://gerrit.wikimedia.org/r/94962 (owner: 10Jeroen De Dauw) [19:38:16] (03CR) 10Hoo man: [C: 032] Expand release notes for Iab02cbd4 [core] - 10https://gerrit.wikimedia.org/r/94963 (owner: 10Bartosz Dziewoński) [19:40:48] (03PS4) 10Ori.livneh: Enable module storage for 0.05% of visitors w/storage-capable browsers [core] - 10https://gerrit.wikimedia.org/r/94840 [19:43:36] (03PS2) 10EBernhardson: Fix parameter for a couple of msg; should be creator name, not revision user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94368 (owner: 10Matthias Mullie) [19:43:50] (03CR) 10EBernhardson: [C: 032] Fix parameter for a couple of msg; should be creator name, not revision user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94368 (owner: 10Matthias Mullie) [19:45:14] Reedy: jenkins loves you [19:45:42] (03Merged) 10jenkins-bot: Fix location of variable initialization [core] - 10https://gerrit.wikimedia.org/r/94962 (owner: 10Jeroen De Dauw) [19:47:42] (03Merged) 10jenkins-bot: Expand release notes for Iab02cbd4 [core] - 10https://gerrit.wikimedia.org/r/94963 (owner: 10Bartosz Dziewoński) [19:50:04] (03Merged) 10jenkins-bot: Fix parameter for a couple of msg; should be creator name, not revision user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94368 (owner: 10Matthias Mullie) [19:53:01] (03PS1) 10MaxSem: Merge i18n files, step 1 [extensions/Collection] - 10https://gerrit.wikimedia.org/r/94965 [19:54:56] (03CR) 10EBernhardson: [C: 032] auto-expand text-area as content grows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94285 (owner: 10Matthias Mullie) [19:55:40] (03CR) 10EBernhardson: [C: 032] Get rid of unused arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94724 (owner: 10Matthias Mullie) [19:56:24] (03CR) 10EBernhardson: [C: 032] Get rid of 3rd argument in calls to Templating::renderPost() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94873 (owner: 10Matthias Mullie) [19:56:57] (03CR) 10EBernhardson: [C: 032] Get rid of useless placeholder input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94725 (owner: 10Matthias Mullie) [19:57:56] (03Merged) 10jenkins-bot: auto-expand text-area as content grows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94285 (owner: 10Matthias Mullie) [19:58:00] (03CR) 10EBernhardson: [C: 032] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94881 (owner: 10Matthias Mullie) [19:58:32] (03Merged) 10jenkins-bot: Get rid of unused arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94724 (owner: 10Matthias Mullie) [19:58:47] (03Merged) 10jenkins-bot: Get rid of 3rd argument in calls to Templating::renderPost() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94873 (owner: 10Matthias Mullie) [19:59:10] (03Merged) 10jenkins-bot: Get rid of useless placeholder input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94725 (owner: 10Matthias Mullie) [19:59:33] (03Merged) 10jenkins-bot: Get rid of post-specific rendering [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94881 (owner: 10Matthias Mullie) [20:03:57] (03PS1) 10Manybubbles: Save links to the search index [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94967 [20:06:54] (03PS1) 10Manybubbles: Remove useless debug log [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94970 [20:08:18] (03PS2) 10BryanDavis: Removed sanity regex since there are too many random formats to track [core] - 10https://gerrit.wikimedia.org/r/94940 (owner: 10Aaron Schulz) [20:08:28] (03CR) 10BryanDavis: [C: 032] Removed sanity regex since there are too many random formats to track [core] - 10https://gerrit.wikimedia.org/r/94940 (owner: 10Aaron Schulz) [20:08:44] (03PS2) 10BryanDavis: Removed sanity regex since there are too many random formats to track [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94941 (owner: 10Aaron Schulz) [20:08:52] (03CR) 10BryanDavis: [C: 031] Removed sanity regex since there are too many random formats to track [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94941 (owner: 10Aaron Schulz) [20:13:14] (03Merged) 10jenkins-bot: Removed sanity regex since there are too many random formats to track [core] - 10https://gerrit.wikimedia.org/r/94940 (owner: 10Aaron Schulz) [20:13:39] (03PS1) 10Ori.livneh: [Do not merge] Clean up: remove module store from localStorage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94973 [20:14:15] (03PS2) 10Ori.livneh: [Do not merge] Clean up: remove module store from localStorage [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/94973 [20:16:59] (03CR) 10Andrew Bogott: "Yes, AbortNewAccount is just what I needed! Thanks, that's much better :)" [core] - 10https://gerrit.wikimedia.org/r/94590 (owner: 10Parent5446) [20:18:08] hey AaronSchulz, csteipp, just wanted to check-in and see how you'd like to proceed this week. i've got 2 gerrit commits outstanding that deal with architecture changes https://gerrit.wikimedia.org/r/#/c/94128/ and https://gerrit.wikimedia.org/r/#/c/94748/. tgr and bd808 will try and review them tomorrow [20:19:40] AaronSchulz: specifically for https://gerrit.wikimedia.org/r/#/c/94748/ i need your help with how to make it dynamic so that it can use the SwiftFileBackend … i don't understand yet if it's a global variable or if i have to create an instance of it to use ... [20:21:42] (03PS1) 10Ori.livneh: [Do not merge] Remove localStorage module caching from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/94976 [20:22:22] dan-nl: your code should not actual reference anything "Swift", you just have a $wgGWToolsetFileBackend variable and use FileBackendGroup::singleton()->get( $wgGWToolsetFileBackend ) to get the FileBackend [20:23:22] (03PS2) 10Ori.livneh: [Do not merge] Remove localStorage module caching from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/94976 [20:23:57] also I don't like having a FileBackend class in a difference namespace (it's a tad confusing) and I'm not sure why there are the separate FileBackend/FileBackendAbstract/FileBackendInterface entities when it seems like there can just be one class for all of that [20:24:31] (03Abandoned) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 (owner: 10Wikinaut) [20:25:23] (03CR) 10Aaron Schulz: [C: 032] Removed sanity regex since there are too many random formats to track [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94941 (owner: 10Aaron Schulz) [20:25:53] (03CR) 10Ori.livneh: "I have prepared cleanup patches Icafb803a6 & I4fdc3514c for removing the module storage implementation and clearing it from localStorage, " [core] - 10https://gerrit.wikimedia.org/r/94840 (owner: 10Ori.livneh) [20:26:33] Aaron|home: k, and what does $wgGWToolsetFileBackend refer to, an instance of the backend being used? so, new FSFileBackend or on commons new SwiftFileBackend? [20:26:42] (03PS1) 10Hashar: report fatals using UTC [php/wmerrors] - 10https://gerrit.wikimedia.org/r/94978 [20:27:47] (03CR) 10jenkins-bot: [V: 04-1] [Do not merge] Remove localStorage module caching from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/94976 (owner: 10Ori.livneh) [20:27:52] (03CR) 10Andrew Bogott: [C: 032] Implement AbortNewAccount hook to check shell name. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/94580 (owner: 10Andrew Bogott) [20:27:58] (03CR) 10Andrew Bogott: [V: 032] Implement AbortNewAccount hook to check shell name. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/94580 (owner: 10Andrew Bogott) [20:28:41] Aaron|home: new FSFileBackend being used in local dev for example and SwiftFileBackend being used on commons [20:29:11] (03PS1) 10Aaron Schulz: Hash long memcached keys and warn about it in the logs [core] - 10https://gerrit.wikimedia.org/r/94989 [20:29:12] dan-nl: it refers to a backend name (just a string) [20:29:20] (03PS3) 10Ori.livneh: [Do not merge] Remove localStorage module caching from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/94976 [20:29:30] the name is registered with config in $wgFileBackends [20:29:32] Aaron|home: i wrote the abstract and interface classes so that the code could be used by other extensions later if they want [20:29:37] it's the site admins job to set that up [20:30:05] dan-nl: I'd lean heavily on the KISS side unless there is actually some known use case [20:30:46] (03Merged) 10jenkins-bot: Removed sanity regex since there are too many random formats to track [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94941 (owner: 10Aaron Schulz) [20:31:04] k, i can remove them … [20:31:13] usually classes that wrap FileBackend deal with file path layout, any DB registration, and any special authenticated viewing/uploading logic [20:31:30] each extension is likely to want different things in that area [20:32:28] and rename the class to GWToolset\Helpers\GWToolsetBackend … would that work for you? [20:34:22] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/94990 (owner: 10L10n-bot) [20:35:00] dan-nl: sure [20:35:04] (03Draft3) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [20:35:28] (03CR) 10Chad: [C: 032] Remove useless debug log [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94970 (owner: 10Manybubbles) [20:40:31] locally, for $wgFileBackend, i need to add an index referencing a FileBackend instance? so $wgBackend['GWToolsetFileBackend'] = new FSFileBackend( $params ); and then use it later with $fb = $wgBackend['GWToolsetFileBackend'] ? [20:41:33] (03CR) 10Wikinaut: [C: 04-2] "- introducing new rights login-with-openid, create-account-with-openid" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 (owner: 10Wikinaut) [20:42:06] Aaron|home: would you be okay with me setting $wgGWToolsetFileBackend string in Config where i've got all of the other configs? it would be Gwtoolset\Config::$wgGWToolsetFileBackend? [20:42:40] dan-nl: $wgFileBackends is just config, not instances (see DefaultSettings.php) [20:42:57] for example we have http://noc.wikimedia.org/conf/highlight.php?file=filebackend.php [20:43:09] (03PS1) 10Bsitu: Editing a post twice in a row sends you to the isolated page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95048 [20:43:37] Aaron|home: ah okay, so those are the params [20:43:38] (03PS4) 10Wikinaut: Bug 46617: Always allow account creation for entitled users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/94977 [20:44:32] and i'd setup my own array for local use [20:45:55] dan-nl: can be something simple like http://pastebin.com/BgBpq5kP [20:46:29] nothing in GW should have to worry about lockManager either [20:46:58] all is really needs is that backend name (that points to something defined in site config) [20:47:33] Aaron|home: and then locally $wgGWToolsetFileBackend would = test-backend ? [20:47:51] (03Merged) 10jenkins-bot: Remove useless debug log [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94970 (owner: 10Manybubbles) [20:48:58] in that case, yes [20:49:52] ok thanks, i'll see what i can sort out and commit a new patch-set, probably tomorrow [20:50:57] Aaron|home: is this the last architecture issue or did you see something else? [20:51:56] I still need to look through it more to understand it better, but from glancing at the special page and job code, it's the stuff that stood out so far [20:53:02] k, thanks Aaron|home [21:28:20] (03PS1) 10Bsitu: Increase default size of expanded text field [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95052 [21:31:27] git question: i have deleted a file in a branch, someone else modified it in prod, how do i rebase? git is angry at me now [21:31:54] probably reedy can help here [21:32:28] rebase and just force delete the file? [21:33:22] Reedy: how do i do that? [21:34:00] matanya: when git complains about rebase conflicts after `git rebase master`, run `git rm `? [21:34:27] matanya: manifests/misc/download.pp: needs merge [21:34:47] Is that the file you deleted in your branch? [21:35:29] yes RoanKattouw, broken into some .pp files [21:36:28] OK [21:36:35] So, first off, what does 'git status' say? [21:36:47] And secondly, you should check what changes were made and make sure you update for them [21:37:26] [matanya@arch puppet]$ git status [21:37:27] # rebase in progress; onto 0b0d5a3 [21:37:27] # You are currently rebasing branch 'download' on '0b0d5a3'. [21:37:27] # (all conflicts fixed: run "git rebase --continue") [21:37:27] # [21:37:27] nothing to commit, working directory clean [21:37:41] Excellent [21:37:46] (all conflicts fixed: run "git rebase --continue") [21:37:49] (03CR) 10Nikerabbit: [C: 032] Use correct case for SpecialRecentChanges class in SpecialPageFactory::$mList [core] - 10https://gerrit.wikimedia.org/r/94908 (owner: 10IAlex) [21:37:54] So run that and you should be fine :) [21:38:18] i did that RoanKattouw it doesn't work [21:38:23] Applying: download: convert into a module and clean up [21:38:24] No changes - did you forget to use 'git add'? [21:38:24] If there is nothing left to stage, chances are that something else [21:38:24] already introduced the same changes; you might want to skip this patch. [21:38:24] When you have resolved this problem, run "git rebase --continue". [21:38:25] If you prefer to skip this patch, run "git rebase --skip" instead. [21:38:26] To check out the original branch and stop rebasing, run "git rebase --abort". [21:38:36] Right, OK [21:38:43] So I guess that commit *only* made changes to download.pp [21:38:49] That's fine, run git rebase --skip for now [21:39:00] (03PS1) 10Hashar: tie pywikibot-core-tests to gallium [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95054 [21:39:15] But also, you should go back later, figure out what changes that commit made, and apply them to your split-up version [21:40:11] (03CR) 10Hashar: [C: 032] "I have refreshed Jenkins job pywikibot-core-tests" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95054 (owner: 10Hashar) [21:40:14] yes, i have done that RoanKattouw, it took code from the file and moved it elsewhere (the same i did) [21:40:27] Ah OK [21:40:31] (03Merged) 10jenkins-bot: tie pywikibot-core-tests to gallium [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/95054 (owner: 10Hashar) [21:40:39] Then you should be fine [21:40:58] thanks for your help RoanKattouw [21:41:11] (03Merged) 10jenkins-bot: Use correct case for SpecialRecentChanges class in SpecialPageFactory::$mList [core] - 10https://gerrit.wikimedia.org/r/94908 (owner: 10IAlex) [21:41:56] so I just updated mediawiki to master and now I the embedded runJobs doesn't seem to be working for me. [21:42:30] RoanKattouw: it didn't work, now my branch is a mess :/ [21:43:16] What did you run? [21:43:28] I said to run git rebase --skip earlier, did you do that? [21:43:32] svn update [21:43:43] yes i have RoanKattouw [21:43:48] OK [21:43:53] Did it say the rebase finished? [21:43:59] than i ran git commit --amend [21:44:03] yes, it did [21:44:16] Wait, why did you run git commit --amend ? [21:44:22] and it pushed a whole new [21:44:40] i was fixing a patch i pushed in the past [21:44:50] Right [21:44:58] You were rebasing it, yeah? [21:45:10] that too [21:45:22] OK [21:45:30] And you're saying it pushed a new change? [21:45:35] yes [21:45:51] Oooh, merge commit [21:45:54] https://gerrit.wikimedia.org/r/#/c/95055/ instead of https://gerrit.wikimedia.org/r/#/c/90760/ [21:45:56] It looks like you were trying to amend a merge commit [21:46:22] yes, i see the issue now. gerrit isn't too smart [21:46:36] No you did *something* weird [21:46:37] Oh I see [21:46:42] git rebase --skip was the wrong answer [21:46:44] My bad [21:46:52] yes, i see why now [21:47:03] (03PS1) 10Bsitu: Trim leading and trailing empty white space in block content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95056 [21:47:14] I don't see why rebasing that change would lead to an empty change though [21:48:08] I do, it had a conflict, and i used the commit message of the merge [21:48:12] It rebases fine onto the production branch [21:48:25] Oh, hah [21:48:34] That's because it did update the change, 6 minutes ago [21:48:52] Although for some reason it now says Author: Andrew Bogott [21:49:32] oh well. [21:50:33] If you care about that, you can run git commit --amend --reset-author [21:53:35] (03PS2) 10Adamw: Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 [21:53:36] (03CR) 10jenkins-bot: [V: 04-1] Provision the fundraising-crm project [vagrant] - 10https://gerrit.wikimedia.org/r/94950 (owner: 10Adamw) [21:54:13] (03PS1) 10Bsitu: Fatal error: Class 'AbstractRevision' not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95058 [21:54:56] (03CR) 10EBernhardson: [C: 032] Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 (owner: 10Matthias Mullie) [21:54:58] (03CR) 10jenkins-bot: [V: 04-1] Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 (owner: 10Matthias Mullie) [21:55:31] (03CR) 10EBernhardson: [C: 032] Fatal error: Class 'AbstractRevision' not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95058 (owner: 10Bsitu) [21:55:41] (03Merged) 10jenkins-bot: Fatal error: Class 'AbstractRevision' not found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95058 (owner: 10Bsitu) [21:59:17] (03PS1) 10Tpt: Add parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/95060 [21:59:26] (03CR) 10jenkins-bot: [V: 04-1] Add parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/95060 (owner: 10Tpt) [21:59:53] (03Abandoned) 10Tpt: Add parser tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/95060 (owner: 10Tpt) [22:00:37] (03PS4) 10EBernhardson: Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 (owner: 10Matthias Mullie) [22:01:15] (03CR) 10EBernhardson: [C: 032] Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 (owner: 10Matthias Mullie) [22:01:29] (03Merged) 10jenkins-bot: Less hacky, configurable, way to limit threading [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94900 (owner: 10Matthias Mullie) [22:02:36] (03CR) 10EBernhardson: [C: 032] CSS should be shown to non-JS users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94875 (owner: 10Matthias Mullie) [22:02:47] (03Merged) 10jenkins-bot: CSS should be shown to non-JS users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94875 (owner: 10Matthias Mullie) [22:03:03] (03PS3) 10EBernhardson: Automagically put username of user I'm replying to in replies to tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94906 (owner: 10Matthias Mullie) [22:03:42] (03CR) 10EBernhardson: [C: 032] Automagically put username of user I'm replying to in replies to tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94906 (owner: 10Matthias Mullie) [22:04:02] (03Merged) 10jenkins-bot: Automagically put username of user I'm replying to in replies to tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94906 (owner: 10Matthias Mullie) [22:04:20] qgil: I found Aniuska Domínguez mail, responded to it. [22:04:40] spagewmf, great, thank you [22:04:40] (03CR) 10EBernhardson: [C: 032] Don't send additional notifications if user already received mention notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94912 (owner: 10Matthias Mullie) [22:04:50] (03Merged) 10jenkins-bot: Don't send additional notifications if user already received mention notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94912 (owner: 10Matthias Mullie) [22:05:31] (03CR) 10EBernhardson: [C: 032] Fix the primary action message text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94955 (owner: 10Bsitu) [22:05:42] (03Merged) 10jenkins-bot: Fix the primary action message text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94955 (owner: 10Bsitu) [22:08:24] (03Abandoned) 10Hashar: report fatals using UTC [php/wmerrors] - 10https://gerrit.wikimedia.org/r/94978 (owner: 10Hashar) [22:14:32] (03CR) 10EBernhardson: "checking with Maryana, it looks like we want to go a bit shorter with 6 lines of content rather than 10." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95052 (owner: 10Bsitu) [22:16:51] (03CR) 10EBernhardson: "to clarify, 10 rows of text is good for non-js users, but for users with js we would like to show it a bit narrower. Not sure how to do " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95052 (owner: 10Bsitu) [22:23:12] (03CR) 10Bsitu: "Yeah, I think we could use js to set a shorter height" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95052 (owner: 10Bsitu) [22:24:40] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95056 (owner: 10Bsitu) [22:29:34] (03CR) 10EBernhardson: [C: 032] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95048 (owner: 10Bsitu) [22:30:18] (03Merged) 10jenkins-bot: Editing a post twice in a row sends you to the isolated page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95048 (owner: 10Bsitu) [22:34:15] (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/95056 (owner: 10Bsitu) [22:36:57] (03PS6) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [22:39:17] (03PS1) 10MaxSem: Update MobileFrontend [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95065 [22:40:24] (03PS1) 10MaxSem: Update MobileFrontend to wmf2 tip [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95067 [22:41:19] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf2 tip [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/95067 (owner: 10MaxSem) [22:41:34] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/95065 (owner: 10MaxSem) [22:45:55] (03CR) 10Anomie: [C: 031] "Code seems to work in local testing. Although I wonder why not just set $maxTopLevelPages to 0; is there a point to keeping the index list" [core] - 10https://gerrit.wikimedia.org/r/94690 (owner: 10Tim Starling) [22:49:43] (03Draft1) 10Wikinaut: redesigned Special:OpenIDLogin page uses 'disabled' input fields to show proposed account names [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95069 [22:50:10] (03CR) 10Wikinaut: [C: 031 V: 031] redesigned Special:OpenIDLogin page uses 'disabled' input fields to show proposed account names [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95069 (owner: 10Wikinaut) [22:58:54] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94967 (owner: 10Manybubbles) [23:00:59] manybubbles: still around ? [23:01:04] manybubbles: have a look at http://logstash.openstack.org/ [23:01:14] manybubbles: basically it consumes syslog messages and let you search in them [23:01:20] hashar: let me dig around in there [23:01:32] I know that is one of those other "powered by elasticsearch" things [23:01:36] manybubbles: also Ori made it possible to report exceptions using json which could potentially be send to EventLogging and thus inserted in a database. [23:01:54] manybubbles: from there we could build a dashboard of exceptions, aggregate them and manually fill in the associated bug # [23:02:29] hashar: I wonder if logstash lets you update the log lines with a bug number [23:02:32] that'd be pretty sweet [23:02:41] :-) [23:02:51] then you could graph the logs from bugs [23:02:54] and unfiled [23:02:59] and "not-a-bug" [23:03:07] or even fill in bugs automatically [23:03:18] in a previous job that is what was happening. [23:03:36] we were not even looking at the monitoring screen which was mostly to show up to customers / prospects [23:03:44] instead we were handling bug reports :D [23:03:59] so yeah basically we get a bunch of data and metrics [23:04:06] but do not exploit them yet [23:04:53] Should new extensions automatically get added to the mediawiki/extensions repo? [23:05:18] RoanKattouw: you talking about VE on wikitech? [23:05:25] hashar: reminds me of "Improving Stability of Mozilla Products" http://laxstrom.name/blag/2013/02/11/fosdem-talk-reflections-23-docs-code-and-community-health-stability/ [23:06:28] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94967 (owner: 10Manybubbles) [23:06:29] Ryan_Lane: MW on wikitech in general [23:06:44] It's running a broken version of VE because it's running 1.22wmf18 or whatever [23:06:53] So I reserved a window this week to update it to something less old [23:06:55] heh, well, someone should prod me to update it [23:07:06] Yeah, I noticed this last week while you were off in HK [23:07:18] which version should I upgrade to? [23:07:23] 1.23wmf3 [23:07:24] 1.23wmf3? [23:07:25] ojk [23:07:26] *ok [23:08:19] So Greg asked "so who should take over updating it from Ryan when he leaves" and I pointed out that it was running code from a couple months back, meaning it already rarely gets updated [23:08:19] I'll just do it now [23:08:23] Awesome, thnaks [23:08:33] well, rarely may not be terribly accurate ;) [23:08:36] I'll cancel my window for tomorrow then [23:08:37] every month or so [23:08:40] Right [23:08:49] oh i just forgot to git pull. [23:08:59] Either way, we should make it someone's responsibility [23:09:34] probably whoever takes over labs should [23:09:57] Right [23:10:13] it would be nice if it could be deployed via tin [23:10:25] Ryan_Lane: I gotta step out for a couple minutes but could you ping me when you're done updating it? Then I can try out VE on it (to update the deployments page and cancel my window, two birds with one stone) [23:10:32] * Ryan_Lane nods [23:10:35] will do [23:10:36] Yeah, it would be better if it were hooked into the main deployment system [23:10:37] Awesome [23:10:39] Thanks again man [23:10:41] yw [23:10:48] getting it hooked into the main deployment system isn't simple [23:10:56] maybe a bit easier with git-deploy [23:12:41] ^d: Looks like old branches are not being pruned from the github mirror. [23:12:48] Is there something we can do about that? [23:18:23] <^d> Krinkle: They should be. Only time they don't afaik is when the branch to delete is the "active" branch on github. [23:18:34] <^d> (If not, we should be able to adjust the settings to do so) [23:19:18] ^d: It is a known problem/feature in the git protocol itself afaik. In that plain pushing and syncing of branches/tags does not remove branches, only create new ones. [23:19:41] e.g. in my local clone of mediawiki core I had to run "git remote prune origin" to have it delete obsolete branches in my local reflection of 'origin'. [23:19:43] <^d> Yes, which is why there's a setting for it. [23:19:46] <^d> That I usually enable :) [23:20:07] (03PS1) 10Ori.livneh: startup.js: log current time as global 'mediaWikiLoadStart' [core] - 10https://gerrit.wikimedia.org/r/95070 [23:20:08] RoanKattouw_away: done (had replied in the wrong channel) [23:23:06] (03PS1) 10Manybubbles: Trim text on the way into elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95071 [23:23:08] and off I am [23:23:09] (03PS1) 10Chad: Removing two extensions to be deleted [extensions] - 10https://gerrit.wikimedia.org/r/95072 [23:23:10] * hashar waves [23:23:40] (03PS2) 10Manybubbles: Trim text on the way into elasticsearch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/95071 [23:23:46] (03CR) 10Chad: [C: 032 V: 032] Removing two extensions to be deleted [extensions] - 10https://gerrit.wikimedia.org/r/95072 (owner: 10Chad) [23:25:02] (03PS1) 10Aaron Schulz: Avoid HEAD requests for files missing from the destination [core] - 10https://gerrit.wikimedia.org/r/95073 [23:25:34] (03CR) 10jenkins-bot: [V: 04-1] Avoid HEAD requests for files missing from the destination [core] - 10https://gerrit.wikimedia.org/r/95073 (owner: 10Aaron Schulz) [23:26:34] (03PS2) 10Aaron Schulz: Avoid HEAD requests for files missing from the destination [core] - 10https://gerrit.wikimedia.org/r/95073 [23:29:30] qgil: TIL you were at SCaLE 9x, which is where I first met paulproteus. [23:30:16] * marktraceur was amused [23:30:33] Ryan_Lane: Works great, thanks! [23:30:42] great [23:32:05] http://gizmodo.com/5893031/aim-is-unofficially-dead [23:33:22] :( [23:33:30] (03PS1) 10Legoktm: Add GetLogTypesOnUser hook [core] - 10https://gerrit.wikimedia.org/r/95075 [23:59:22] (03Draft1) 10Wikinaut: Bug 54677: Do account creation checks when creating users [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/95076