[00:21:51] (03PS7) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [00:22:10] (03CR) 10jenkins-bot: [V: 04-1] Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [00:52:50] bawolff: hmm, when RandomInCategory hits a category page as a result, I think it should recurse [00:52:50] or [00:52:55] something [00:52:59] could be part of the API [00:53:06] I'll probably write that tomorrow [00:53:33] Hmm, but what if you want a random category in the category ;) [00:54:21] I'm not sure if that's actually a worth it feature - you'd have to be careful about loops where the category only consists of subcategories which in turn point back to the original category [00:54:52] and probability wise, it wouldn't fairly look at the things inside the subcategory (probably, although nothing else about it is very good probability wise) [00:58:37] bawolff: well, have a recurse param that just calls RandomInCategory again :D [00:58:45] bawolff: and have a recurse limit [01:03:55] bawolff: I'm planning on moving the logic to the API and having the special page internally call the API [01:03:57] thoughts? [01:04:33] Sounds good to me (Really I probably should have made it work with the api from the get go) [01:04:56] calling the api internally doesn't seem to be done very much, but this seems like a good situation for it [01:11:20] you can also do it the other way around, and have the API call the special page internally :P [01:15:36] legoktm: nooooooo! [01:16:27] YuviPanda: https://gerrit.wikimedia.org/r/#/c/87311/ [01:16:34] also, I'm supposed to poke ori-l to review it [01:17:18] legoktm: offer to bribe him with a tuna sandwich [01:17:38] ori-l: I will buy you a sandwich the next time I'm in SF [01:19:20] legoktm: We could have a neutral interface for getting the information, divorced from presentation layer logic, which both the api and the special page could call [01:19:33] Yes. [01:19:35] nah, that's crazy [01:19:39] Or I could not refactor all my code [01:20:31] bawolff: if we have a neutral interface where would that live and what would you call it? [01:20:39] RandomPageCreatorFactory? [01:20:40] :D [01:20:54] * legoktm hands YuviPanda a singleton [01:20:55] oh please no.. [01:21:15] * YuviPanda hands legoktm a singleton factory singleton [01:22:18] some special pages do have static methods of the special page to just get the data, which the special page, and other things needing the data call [01:22:50] that sounds as bad as a fake api requeste [01:25:13] bawolff: think we can use similar methods to grab random elements from the pagelinks table? :D [01:25:33] I think not sadly [01:25:49] Umm, not quite, as there is no cl_timestamp equivalent [01:25:55] yeah [01:27:27] Are you thinking of random backlink or random forward link? [01:27:48] i.e. random page linking to current page, or random page that current page links to? [01:27:52] bawolff: former [01:28:06] I can easily already do the latter when I have current page's html [01:29:10] (03PS1) 10Legoktm: Clean up global state when job finishes [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94685 [01:29:40] Hmm, maybe one could do something like - get the first page link alphabetically, and the last one alphabetically, then take random number, and make a byte sequence that falls between the utf-8 values for the biggest and the smallest [01:30:13] which would sort of work if the titles were uniformly arranged around utf-8 code sequences [01:30:25] which probably means ok for english, horrible for non-latin languages [01:30:48] yeah [01:30:54] maybe ok if all the pages start with a letter of the same script [01:31:10] which seems to be an okayish assumption? [01:31:20] also better than nothing [01:40:51] In some cases, that might even work better than the timestamp method [01:47:23] bawolff: why so? [01:47:35] hmm, less clustering? [01:47:46] depends on how the range computation is done I guess [01:47:48] possibly [01:48:05] I guess that's more of a test and see type of question [01:48:09] bawolff: I guess the API should be done similar to how random is done? [01:48:38] I imagine (I don't know how random is done off the top of my head) [01:48:43] bawolff: I'm exploring different ways of showing 'related but random' articles when browsing a particular article [01:49:09] one is 1. pick non-hidden category randomly 2. Randomly display page from that [01:49:21] I had a friend who had an idea for getting related things from Wikipedia [01:49:25] two is 1. Pick random outbound wikilink 2. Display it [01:49:28] bawolff: oh? [01:49:38] three would be random backlink [01:49:47] I might even randomly switch between these three [01:50:05] She wanted a list browser type thing - where one looks at pagelinks (and possibly categories) for anything that is a List article, and then displays some sort of interface for "Lists that this article is a part of" [01:51:24] bawolff: ah that's a good one [01:51:47] bawolff: another one we thought of was to pick a wikiproject this was part of and then display a random article from that [01:52:03] Hmm, that would probably be interesting [01:52:17] yeah [01:52:17] it [01:52:24] is a subset of the category based idea [01:52:32] but with slight modifications [01:52:41] Imagine you'd get a lot of stuby mildly related articles ( Obama is part of WikiProject politics, so is mayor of nowhere village) [01:52:53] since the wikiproject related categories are in talk page [01:53:08] bawolff: we can filter by qualuty and importance too with wikiprojects [01:53:35] oh good idea [01:53:50] Also I guess you could try for the most specific wikiproject [01:54:00] ah that too! [01:54:00] one the article falls into multiple [01:54:02] yeah [01:54:10] but these are hard to do and also enwiki specific [01:54:22] yeah [01:54:23] wikiproject info is maintained by a bot that still runs on TS [01:54:26] afaik [01:54:39] if somehow we moved that in cluster... [01:54:46] I think wikipedians have asked for an extension to manage that type of stuff [01:54:58] it was my GSoC project [01:54:59] So they'd probably be open to it moving to a "real" system [01:55:02] :P [01:55:11] but it is currently bitrotting in SVN [01:55:38] and looking back, I dunno if that could've been deployed with the approach I took [01:55:56] although I imagine the larger problem is that other languages probably have different organizational notions [01:55:58] but with an approach similar to what geodata takes, I don't see why not [01:56:01] indeed [01:57:06] geodata sticks it into a lucene full text index type thingy right? [01:57:27] Which is something we should do for categories (imo) [01:57:34] could make DynamicPageList not be crap [01:58:19] fucking powercuts [01:58:21] and then they ask me why I don't like the city [01:58:23] grr [01:58:27] bawolff: I dunno if that as a problem is something that can be solved anytime soon [01:59:37] * legoktm pokes grrrit-wm  [01:59:41] https://gerrit.wikimedia.org/r/#/c/94687/ [01:59:55] * bawolff has evil plans to at least give an attempt to rewrite DPL to not be sucky [02:00:02] but have never gotten around to it [02:00:19] * bawolff is really much better and the small fixes rather then the longer term projects [02:00:52] legoktm: is it dead again? [02:00:58] dunno [02:01:00] it missed my change [02:01:08] legoktm: you have access rights to it :P [02:01:47] i know :P [02:01:54] legoktm: restart it? [02:02:04] i've to go sleep now it is 7:30 AM [02:02:18] psh [02:02:20] time to wake up! [02:05:17] power back [02:05:19] did i miss anything? [02:09:12] nope [02:09:41] grrrit-wm: working? [02:36:49] * bawolff is playing with svgedit. Its actually pretty cool [02:43:14] (03PS1) 10Legoktm: Add the log entry after we know the job is successful [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94689 [02:44:25] (03PS1) 10Tim Starling: In Special:AllPages, limit the size of hierarchical lists [core] - 10https://gerrit.wikimedia.org/r/94690 [03:01:34] (03PS1) 10Legoktm: Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 [03:09:52] (03PS1) 10Legoktm: Use a [[wikilink]] to display local targets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 [03:12:48] (03CR) 10Legoktm: "Ie834c7d47b13b6052335dd3c53c161e4556c9cfb should be merged by whoever merges this." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 (owner: 10Legoktm) [03:16:03] (03CR) 10MZMcBride: "Topic is "(detached"." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 (owner: 10Legoktm) [03:21:35] Elsie: Weird why? [03:22:20] I dunno. [03:22:30] It changes the parsing behavior in an unexpected way. [03:22:37] Maybe. [03:23:57] {{#target|Page}} becomes [[Page]] [03:25:56] It's closest to the existing behavior [03:26:00] * bawolff wonders what the roadmap is for wide deployment of oauth [03:26:33] Dan would know [03:31:36] legoktm: I think you mean {{#target:}}. [03:31:43] Uh, yes. [03:31:45] I did [03:31:51] And it only becomes [[Page]] under certain conditions. [03:32:12] I dunno. [03:32:37] I thought you could do {{#target:Page}} for a local link already. [03:32:38] There's no reason for it to be an external link if it links to something on the same wiki [03:32:41] You can [03:32:48] but it becomes an external link [03:33:17] {{#target:Page}} becomes [//whateverwiki.ext/w/index.php?title=Page Page] [03:33:19] Isn't it an index.php?title= link? [03:33:40] Right. [03:33:42] Yeah [03:34:01] I thought it only use $wgScriptPath. [03:34:34] used [03:34:38] no, $wgScript [03:34:41] $msg = wfMessage( 'massmessage-target' )->params( $site, $wgScript, $page )->plain(); [03:34:46] 'massmessage-target' => '[//$1$2?title={{urlencode:$3|WIKI}} $3]', [03:34:52] Hmm, right. [03:35:07] I think the conditional logic changing parsing behavior feels strnage. [03:35:13] But I wouldn't worry about it. [03:35:17] Well, it's a fixed conditional. [03:35:23] You really shouldn't be constantly changing it [03:36:04] Right. [03:36:18] I'm just not sure someone who notices the difference in behavior would be able to figure out why. [03:36:21] Or something. [03:37:22] the behavior will be consistent per-wiki [03:37:39] bbl dinner [04:30:36] (03CR) 10Legoktm: [C: 04-1] Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [05:03:37] (03PS1) 10Gnosygnu: v0.11.1.0 [xowa] - 10https://gerrit.wikimedia.org/r/94695 [05:03:54] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/94695 (owner: 10Gnosygnu) [05:06:36] (03PS2) 10Legoktm: Show an error to the user if the spamlist has no targets on it [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 [05:22:55] (03PS1) 10Legoktm: Link to [[mw:Help:Extension:MassMessage]] at top of the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 [05:25:04] (03PS1) 10Legoktm: Change default name to 'MediaWiki message delivery' [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94697 [05:34:58] (03PS1) 10Legoktm: Allow posting in all talk namespaces by default [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94698 [05:38:14] (03PS1) 10Pastakhov: fix foxway exceptions, now showing error messages for users [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94699 [05:44:45] (03CR) 10Pastakhov: [C: 032] fix foxway exceptions, now showing error messages for users [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94699 (owner: 10Pastakhov) [05:44:54] (03Merged) 10jenkins-bot: fix foxway exceptions, now showing error messages for users [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94699 (owner: 10Pastakhov) [06:31:56] anyone online know how to create a delayed job using jobReleaseTimestamp? [07:03:55] dan-nl: i didn't even know this exists... looks pretty new, perhaps the feature never was finished. [07:04:24] you'll want to talk to AaronSchulz about it, he apparently added it (and he (re)wrote most of the job system) [07:05:37] it looks like i need to create a JobQueueFederated or JobQueueRedis version of the job in order to use it, but i'm not sure host o do that yet … [07:06:03] ja, i have another approach i'll use for now [07:06:10] thanks for thinking with me [07:49:17] * legoktm nudges ori-l about the API module [07:50:27] oh, right [07:50:59] you haven't added me as a reviewer [07:51:20] i found it [07:51:37] oh, oops [07:51:54] (03PS11) 10Ori.livneh: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [08:17:08] (03CR) 10Ori.livneh: [C: 04-1] "Argh, sorry to ding this after a long delay in reviewing it, but having the API call the SpecialPage by faking a form submission seems rea" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [08:17:32] Hm. [08:17:42] ori-l: Well, I was trying to avoid a huge refactoring of the code [08:19:16] the whole extension is a little over a thousand lines (not counting the i18n file), so it'd hardly be a "huge" refactoring [08:19:31] it sounds like a good refactor [08:19:38] well, relatively :P [08:20:51] I think moving the code into an interface is probably the best [08:21:03] yeah, you know it in your heart! :P [08:21:34] refactoring doesn't get easier; now is the time to do it [08:22:22] yeah :/ [08:22:29] you could have the API module spin up a cloudbees browser testing instance and simulate a user navigating to the special page [08:22:39] heh [08:22:40] then take a screen shot of the result and OCR it [08:23:44] bah, gerrit is being slow. [08:23:45] anyways, i hate johnny-come-lately -1s, so i'm sorry [08:23:57] no worries [08:26:09] should I create a new class that's OOP-ish or just a bunch of static functions in MassMessage.body.php? [08:27:13] yes, UML diagrams or bust [08:27:18] (03PS12) 10Legoktm: [WIP] Allow the user to provide a translatable page as the message text [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 [08:27:31] (03PS1) 10Pastakhov: rename $wgFoxway_max_execution_time as Foxway\Runtime::$permittedTime [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94705 [08:27:49] it's up to you, i don't think it matters a whole lot [08:28:08] i prefer static functions but classes in PHP (and mediawiki specifically) aren't really "classes" anyway [08:28:23] they're like slightly stateful namespaces [08:28:36] (03CR) 10Pastakhov: [C: 032] rename $wgFoxway_max_execution_time as Foxway\Runtime::$permittedTime [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94705 (owner: 10Pastakhov) [08:28:43] (03Merged) 10jenkins-bot: rename $wgFoxway_max_execution_time as Foxway\Runtime::$permittedTime [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94705 (owner: 10Pastakhov) [08:42:31] hmm, three ori-ls to bz quips just in the span of a dota game [08:43:14] dota game? [08:43:47] ori-l: https://en.wikipedia.org/wiki/Defense_of_the_Ancients [08:43:56] ori-l: in a misguided effort to 'have a hobby', I've been... gaming [08:45:24] ori-l: also, if we were to have 'real' RandomInCategory, how would we do it? [08:45:31] have a random field in categorylinks? [08:45:37] and pre-populate them? [08:45:38] i guess [08:47:06] I asked on either wikitech-l or ops a while back and got some good suggestions [08:47:29] I vaguely recall Gabriel having had some ideas [08:48:24] oh I remember that therad [08:48:27] let me look that up [08:48:32] food first, I'd think [08:48:35] thanks for reminding! [08:48:38] * YuviPanda|away slinks away [08:48:50] wow, first attempt at refactoring and no test failures. [08:49:09] 00:17 ori-l: Well, I was trying to avoid a huge refactoring of the code [08:49:20] 00:48 wow, first attempt at refactoring and no test failures. [08:49:25] 31 minutes! [08:49:41] heh [08:52:15] (03PS1) 10Legoktm: Refactor some code from SpecialPage into individual class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [08:57:33] morning! [08:57:49] i'm looking for a way to filter the output of https://noc.wikimedia.org/cgi-bin/report.py [08:58:12] is there any documentation for this? [08:58:20] or maybe someone can point me to the source code :) [08:59:32] (03PS1) 10Pastakhov: add $transit variable, which allows to use Parser in user-defined functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94707 [09:00:18] (03CR) 10Pastakhov: [C: 032] add $transit variable, which allows to use Parser in user-defined functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94707 (owner: 10Pastakhov) [09:00:25] (03Merged) 10jenkins-bot: add $transit variable, which allows to use Parser in user-defined functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94707 (owner: 10Pastakhov) [09:02:56] (03PS2) 10Legoktm: Refactor some code from SpecialPage into individual class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [09:10:18] (03PS3) 10Legoktm: Refactor some code from SpecialPage into individual class [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94706 [09:11:10] ori-l: wanna review? ^ [09:46:44] MaxSem, on the half cut sentence https://gerrit.wikimedia.org/r/#/c/94614/3/includes/User.php , should I remove that whole sentence ? [09:46:59] does anyone of you know gerrithub.io I like the idea to have a two way synchronization between github and gerrit [09:47:11] do you have your oewn opinion? [09:47:19] *own [09:47:32] MaxSem, I think it should be there [09:47:45] YuviPanda|away: ^ [09:47:50] MaxSem, I meant the whole sentence [09:48:19] hahaha nice! [09:48:38] although i dunno if it works with our workflow [09:49:01] I really should sleep [09:50:22] physikerwelt: that looks cool. I'm going to try it :D [09:51:05] Yes I tried it, it only took 5 minutes until I could do my first commit [09:51:27] but can you interact with WMF's gerrit? [09:51:45] someone told me that there is someone who is planning to install something like that for wmf projects [09:52:20] no I just tried with projects unrelated to wmf [09:52:22] that was me, and I haven't found time to turn it on yet. [09:52:25] ah [09:52:58] I think the interesting feature is to import pull request [09:53:05] tonythomas01, okay -there's no such option anyomre, what should that sentence say? [09:53:45] physikerwelt: my bot has that feature [09:53:47] physikerwelt: see https://gerrit.wikimedia.org/r/#/q/owner:%22SuchABot+%253Cyuvipanda%252Bsuchabot%2540gmail.com%253E%22,n,z [09:53:51] @YuviPanda|away I think it can wait untul tormorrw [09:53:56] heh [09:54:46] MaxSem, 'Only do this delete if there is something there' thats all ? [09:55:19] yep [09:55:27] YuviPanda|away: is the bot running again? [09:55:48] legoktm: no, i haven't found time to start it up again [09:55:51] and test that it works, etc [09:55:53] @YuviPanda|away however, maybe it's intesting to look at the project [09:55:56] ok :/ [09:56:17] MaxSem, pl [09:56:22] MaxSem, *ok [09:59:30] (03PS4) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [10:06:47] (03PS1) 10Amire80: Removing parentheses [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94713 [10:08:17] (03CR) 10Amire80: [C: 031] Minor fix for consistency [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94491 (owner: 10Shirayuki) [10:09:25] (03CR) 10Amire80: [C: 031] Update i18n from TWN comments [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94425 (owner: 10CSteipp) [11:03:46] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 (owner: 10EBernhardson) [11:03:54] (03CR) 10Matthias Mullie: [C: 032] Require core edit permission to perform write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 (owner: 10EBernhardson) [11:04:06] (03CR) 10jenkins-bot: [V: 04-1] Require core edit permission to perform write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 (owner: 10EBernhardson) [11:09:37] (03PS4) 10Matthias Mullie: Require core edit permission to perform write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 (owner: 10EBernhardson) [11:10:00] (03CR) 10Matthias Mullie: [C: 032] Require core edit permission to perform write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 (owner: 10EBernhardson) [11:12:16] (03Merged) 10jenkins-bot: Require core edit permission to perform write actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 (owner: 10EBernhardson) [11:29:16] (03PS4) 10Sakshi: PHP script [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94497 [12:59:52] (03PS1) 10Nemo bis: Rephrase mw-ui-feature-requirements-skins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/94721 [13:02:37] (03CR) 10Nikerabbit: [C: 032] Rephrase mw-ui-feature-requirements-skins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/94721 (owner: 10Nemo bis) [13:02:50] (03Merged) 10jenkins-bot: Rephrase mw-ui-feature-requirements-skins [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/94721 (owner: 10Nemo bis) [13:23:10] andre__: I have made the changes in mediawiki/extensions/WikimediaMaintenance as well. [13:25:54] arav93, I know that, as I receive bugmail. Good :) [13:26:20] Thanks. How long would the review process take. [13:28:24] arav93, cannot generalize. If you're lucky somebody reviews quickly, with bad luck you have to ping/nag several times and wait weeks :-/ [13:28:28] it's open source... [13:28:42] arav93, adding potential reviewers in Gerrit might speed up the process [13:29:10] Shall I add you? :) [13:30:31] arav93, I don't review code - I would first need to understand it :P [13:31:20] :) [13:31:35] Could you suggest someone who might review? [13:34:58] arav93: Depending on the component you are working on, you can ask someone from this list: https://www.mediawiki.org/wiki/Developers/Maintainers [13:35:23] (03PS1) 10Matthias Mullie: Get rid of unused arguments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94724 [13:39:02] Rtdwivedi: Thanks. [13:42:20] (03PS1) 10Matthias Mullie: Get rid of useless placeholder input [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94725 [14:16:14] (03CR) 10Siebrand: [C: 032] Update i18n from TWN comments [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94425 (owner: 10CSteipp) [14:16:22] (03Merged) 10jenkins-bot: Update i18n from TWN comments [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94425 (owner: 10CSteipp) [14:17:06] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [14:18:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [14:23:02] (03CR) 10Siebrand: [C: 04-1] "Per Max." [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [14:26:59] (03CR) 10Siebrand: [C: 031] "L10n looks fine. i18n may be fine, but I cannot assess." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 (owner: 10Nemo bis) [14:29:19] (03CR) 10Siebrand: [C: 04-1] "Keeping my -1 per PS1." [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/87562 (owner: 10Nemo bis) [14:33:27] (03CR) 10Siebrand: [C: 032] New hook 'LocalisationChecksBlacklist' to allow to extend the localisation checks blacklist [core] - 10https://gerrit.wikimedia.org/r/94603 (owner: 10IAlex) [14:37:20] (03Merged) 10jenkins-bot: New hook 'LocalisationChecksBlacklist' to allow to extend the localisation checks blacklist [core] - 10https://gerrit.wikimedia.org/r/94603 (owner: 10IAlex) [14:38:10] andre__: Iam working on bug 55389 .Can you please tell me where to start with? [14:39:21] Lekshmi, is there a reason why you ask specifically me? [14:39:24] (03CR) 10Hashar: [C: 031] "I have no clue, was probably willing to use yes/no radio buttons instead of checkboxes, or maybe replace the namespace selector with a lis" [core] - 10https://gerrit.wikimedia.org/r/94452 (owner: 10Bartosz Dziewoński) [14:40:19] Krenair: ^ wanna +2? [14:40:40] My friends working on mediawiki suggested [14:41:37] Lekshmi: https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [14:41:46] Lekshmi: if you have a specific question, I'd recommend to ask it here and/or in #mediawiki-i18n [14:41:50] Lekshmi, http://www.mediawiki.org/wiki/Developer_access [14:41:57] Lekshmi, http://www.mediawiki.org/wiki/Gerrit/Tutorial [14:42:02] that's all I can tell :) [14:42:17] thank you [14:43:08] Lekshmi, just ask here in public if you have specific questions [14:43:21] Lekshmi, for the start, check out the code and get used to developer access. [15:04:16] (03CR) 10Alex Monk: [C: 032] "Okay then" [core] - 10https://gerrit.wikimedia.org/r/94452 (owner: 10Bartosz Dziewoński) [15:04:44] MatmaRex, Oh, I pressed 'and submit' didn't I... [15:04:46] oops [15:05:02] can never remember which repositories you have to do that on [15:06:30] Krenair: it won't submit unless you also V+2 [15:06:57] MatmaRex, well it said "Change has been successfully merged into the git repository." before jenkins-bot came along, so.. [15:07:20] did it? oh [15:07:31] well, it's not like that matters anyway in practice [15:07:53] apart from the rare cases where the tests haven't been run already, or where merge artifacts would break tests [15:24:54] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/94742 [15:24:55] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/94743 [15:24:56] (03PS1) 10Siebrand: Break long lines [core] - 10https://gerrit.wikimedia.org/r/94744 [15:31:05] hey AaronSchulz, i've got a first draft of the code ready for gwtoolset to use the file backend, but i need a bit of help in regards to setting things up so that it can use a SwiftFileBackend. atm the moment the code is able to use a FSFileBackend. do i need to worry about the SwiftFileBackend or would that be transparent to the extension? [15:33:14] (03PS1) 10Siebrand: Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 [15:34:35] (03CR) 10jenkins-bot: [V: 04-1] Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [15:37:36] (03PS2) 10Siebrand: Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 [15:41:08] (03CR) 10Bartosz Dziewoński: "Class names are case-insensitive anyway, so this is backwards-compatible." [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [15:41:40] (03CR) 10Siebrand: "Ah, that's good to know. Thanks." [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [15:43:27] (03PS1) 10Dan-nl: i ran into an issue while looking into developing a chunked upload solution for uploading xml metadata. the plan was to use the mw api to upload the metadata in slices and keep them in the upload stash for use, and dispose of them when no longer needed. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [15:44:01] (03PS2) 10Dan-nl: filebackend [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 [15:44:27] (03PS1) 10Siebrand: Use capital as first letter for class names [core] - 10https://gerrit.wikimedia.org/r/94749 [15:44:46] (03CR) 10Dan-nl: "patch-set 2 modifies the commit message." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [15:47:42] (03CR) 10Bartosz Dziewoński: [C: 032] "Can't hurt I guess." [core] - 10https://gerrit.wikimedia.org/r/94742 (owner: 10Siebrand) [15:48:31] (03PS2) 10Bartosz Dziewoński: Update formatting [core] - 10https://gerrit.wikimedia.org/r/94743 (owner: 10Siebrand) [15:49:14] (03CR) 10Bartosz Dziewoński: [C: 032] Update formatting in messages.inc [core] - 10https://gerrit.wikimedia.org/r/94743 (owner: 10Siebrand) [15:49:31] (03PS2) 10Bartosz Dziewoński: Break long lines [core] - 10https://gerrit.wikimedia.org/r/94744 (owner: 10Siebrand) [15:50:19] (03PS1) 10Siebrand: Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 [15:51:26] (03PS3) 10Bartosz Dziewoński: Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [15:51:31] (03PS4) 10Bartosz Dziewoński: Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [15:51:43] (03CR) 10Bartosz Dziewoński: [C: 032] Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [15:52:08] siebrand: i left one out (https://gerrit.wikimedia.org/r/#/c/94744/), find someone else to go through that. :P [15:52:35] MatmaRex: Thanks [15:52:52] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/94742 (owner: 10Siebrand) [15:53:00] (03CR) 10Inchikutty: "@MarkTraceur:Your review is helping me to learn more about the existing structure and code conventions. :)..and I am working on the improv" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [15:57:16] (03Merged) 10jenkins-bot: Update formatting in messages.inc [core] - 10https://gerrit.wikimedia.org/r/94743 (owner: 10Siebrand) [15:58:13] (03CR) 10jenkins-bot: [V: 04-1] Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 (owner: 10Siebrand) [15:58:42] hi sucheta , do you know anything about Gargi Keluskar? [15:59:18] (03PS2) 10Siebrand: Use capital as first letter for class names [core] - 10https://gerrit.wikimedia.org/r/94749 [15:59:26] (03PS2) 10Siebrand: Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 [15:59:51] (03CR) 10jenkins-bot: [V: 04-1] Use capital for classes Languages and ExtensionLanguages [core] - 10https://gerrit.wikimedia.org/r/94745 (owner: 10Siebrand) [16:00:02] (03PS3) 10Siebrand: Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 [16:00:11] (03PS4) 10Siebrand: Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 [16:02:25] sucheta, she has listed herself at https://www.mediawiki.org/wiki/Outreach_Program_for_Women/Round_7#Candidates but hasn't sent a proposal to opw. The deadline is in 3 hours. [16:04:06] legoktm: [16:04:09] [10 Nov 13 22:22] * legoktm * MatmaRex: both LQT and FlaggedRevs use the SpecialWatchlistQuery hook. My grep isn't finished yet though [16:04:09] [10 Nov 13 22:22] * legoktm * and MobileFrontend [16:04:19] legoktm: did anything else grep? i don't have all extensions locally [16:05:08] Need to know what uses SpecialWatchlistQuery? phpstorm is really quick at that. [16:05:51] sucheta, I left a message at https://www.mediawiki.org/wiki/User_talk:Gargi_K - this is all I can do with the (non)information provided... [16:05:54] Yay indexes [16:06:02] grep searches the tree pretty quickly too [16:06:08] Wikibase, core, MobileFrontend, LiquidThreads, FlaggedRevs [16:06:12] siebrand: yes, i'm breaking that hook a little bit [16:06:23] siebrand: https://gerrit.wikimedia.org/r/#/c/89380/ and https://gerrit.wikimedia.org/r/#/c/94288/ , feel free to review ;) [16:06:45] siebrand: i could grep for it easily using a variety of tools, but first i'd have to download a gigabyte of extensions, nothx [16:07:06] I don't have the BlueSpice and LiveTranslate extensions checked out, because they interfere in some ways in my IDE usage. For the rest I have ~610 extensions from Gerrit cloned and up to date. [16:07:14] I've got hem all! [16:07:17] * aude breaks MatmaRex ! [16:07:28] aude: oh, i've alreayd investigated wikibase [16:07:33] I have all 639 [16:07:35] ok [16:07:42] aude: you need to remove a type hint in one place, then it'll work. otherwise you'll get fatals :D [16:07:42] we'll be changing our use of the hook soon [16:07:52] Reedy: Looks like some new ones appeared since I last cloned... [16:07:55] or change the type hint [16:07:56] aude: silly you and your defensive coding L> [16:08:07] aude: no, remove it, to be compatible with both old and new versions of MW [16:08:14] hrm [16:08:18] * aude shall take a look [16:08:18] i pull them all every day.. [16:08:21] i'm changing an array to FormOptions [16:08:30] MatmaRex: How dare you. [16:08:37] Reedy: for CONSISTENCY! [16:09:05] siebrand: thanks for the list [16:09:47] Fatal error: Allowed memory size of 201326592 bytes exhausted (tried to allocate 125829120 bytes) in /usr/local/apache/common-local/php-1.23wmf2/includes/media/SVG.php on line 208 [16:09:51] SVG needs moar memory [16:10:58] (03CR) 10jenkins-bot: [V: 04-1] Use suppress/restoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/94753 (owner: 10Siebrand) [16:11:14] Jenkins doesn't like warnings [16:11:38] (03CR) 10Aude: [C: 04-1] "not necessarily a problem with this change, but wikibase needs to be made compatible and test this change against wikibase for any possibl" [core] - 10https://gerrit.wikimedia.org/r/94288 (owner: 10Bartosz Dziewoński) [16:12:03] just so it doesn't accidentally get merged too soon [16:12:14] * aude can review soon [16:12:17] aude: sure. i'll submit a patch in a while, will you test&merge? :) [16:12:26] ok [16:14:36] (03PS8) 10Krinkle: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [16:14:42] (03CR) 10Krinkle: [C: 031] Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [16:17:20] (03PS1) 10Siebrand: Declare visibility for class properties [core] - 10https://gerrit.wikimedia.org/r/94759 [16:18:44] (03CR) 10GICodeWarrior: [C: 032 V: 032] "Good to go. For next time, please wrap your commit message." [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94497 (owner: 10Sakshi) [16:18:57] aude: https://gerrit.wikimedia.org/r/94760 , if you can :) should be a trivial change [16:19:09] ok [16:19:28] (03PS1) 10GICodeWarrior: The PHP_CSS_Parser is added as a git submodule to the CSS Extension. The given PHP code- parser_demo.php is a script takes input a CSS file and uses the parser to parse the CSS file. It removes all the background attributes and displays the modified CSS f [extensions/CSS] (parser) - 10https://gerrit.wikimedia.org/r/94761 [16:19:50] (03CR) 10GICodeWarrior: [C: 032 V: 032] The PHP_CSS_Parser is added as a git submodule to the CSS Extension. The given PHP code- parser_demo.php is a script takes input a CSS file [extensions/CSS] (parser) - 10https://gerrit.wikimedia.org/r/94761 (owner: 10GICodeWarrior) [16:20:05] (03PS2) 10Siebrand: Declare visibility for class properties [core] - 10https://gerrit.wikimedia.org/r/94759 [16:20:30] (03CR) 10GICodeWarrior: "Submitted this here:" [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94497 (owner: 10Sakshi) [16:20:53] marcoil, are in contact with Be Birchall? She listed herself at our OPW page but we haven't receive their application at opw@. The deadline is in less than 3h. [16:21:00] (03CR) 10jenkins-bot: [V: 04-1] Declare visibility for class properties [core] - 10https://gerrit.wikimedia.org/r/94759 (owner: 10Siebrand) [16:27:06] andrewbogott, ping [16:27:32] andrewbogott, I was here when you sent the email. ;) [16:27:59] Oh! Guess I looked in #wikimedia-staff where I think you aren't. [16:28:57] andrewbogott, nah, I idle in the public channels only. What's up? [16:29:09] (03PS1) 10Siebrand: Excluded non-standard global in CodeSniffer checks [core] - 10https://gerrit.wikimedia.org/r/94763 [16:30:53] (03CR) 10Nikerabbit: "This broke Translate extension:" [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [16:31:08] RVERT [16:33:45] (03PS2) 10Siebrand: Excluded non-standard global in CodeSniffer checks [core] - 10https://gerrit.wikimedia.org/r/94763 [16:34:18] (03PS3) 10Amire80: Document the block duration tooltip [core] - 10https://gerrit.wikimedia.org/r/74950 [16:35:20] (03PS1) 10Siebrand: Revert "DifferenceEngine cleanup" [core] - 10https://gerrit.wikimedia.org/r/94764 [16:35:33] (03CR) 10Bartosz Dziewoński: "Three extensions in git use this hook: Wikibase, LiquidThreads and FlaggedRevs. Fix for Wikibase is https://gerrit.wikimedia.org/r/#/c/947" [core] - 10https://gerrit.wikimedia.org/r/94288 (owner: 10Bartosz Dziewoński) [16:36:06] (03CR) 10Bartosz Dziewoński: "Out of all of the extensions in gerrit all are compatible with the SpecialWatchlistQuery hook change here." [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [16:36:41] aude: btw, did you get a chance to look at the watchlist cleanup this is part of? :) https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:watchlist,n,z [16:36:48] MatmaRex: Did you forget MobileFrontend in the list of extensions using that hook? [16:37:01] siebrand: no, i mentioned it in second paragraph [16:37:06] not yet [16:37:07] siebrand: it doesn't use the hook, it fires it [16:37:11] quite a lot :) [16:37:13] because it reimplements the watchlist [16:37:16] MatmaRex: Ah, I only saw the line here. [16:37:17] because mobile are special [16:37:18] D: [16:37:31] Think of the back compat! [16:37:36] Reedy: i did! [16:37:40] :O [16:37:58] Reedy: wikibase only has troubles because they used a type hint in hook function definition [16:38:08] otherwise it would continue to chug along happily [16:38:47] yeah... PHP... the only language where half an hour sleeping on your keyboard is valid code... :P [16:39:11] hoo: you can review https://gerrit.wikimedia.org/r/#/c/94762/ :P [16:39:52] (03CR) 10Siebrand: "This change renamed public class properties without a proper search across extensions. Please make more of an effort to prevent regression" [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [16:41:19] (03CR) 10Nikerabbit: [C: 032] Revert "DifferenceEngine cleanup" [core] - 10https://gerrit.wikimedia.org/r/94764 (owner: 10Siebrand) [16:42:04] (03CR) 10Bartosz Dziewoński: "*Wikibase is https://gerrit.wikimedia.org/r/#/c/94760/" [core] - 10https://gerrit.wikimedia.org/r/94288 (owner: 10Bartosz Dziewoński) [16:42:14] hoo: i actually meant ^, but that one is fine too. :P [16:42:32] ewk [16:42:50] already wondered, because I'm not usually much into Mobile... :P [16:43:02] But I got an open path there either... in case you have spare time... [16:43:07] * patch [16:44:21] in MF? i don't think i've ever done anything with it, apart from that patch above [16:44:35] mh :P [16:45:40] (03PS2) 10Amire80: Show a warning on page deletion if a page is linked to [core] - 10https://gerrit.wikimedia.org/r/65162 [16:45:49] MatmaRex: done [16:46:52] hoo: yay, thanks [16:47:01] hoo: have you tested that with the core change? [16:47:09] (because i didn't) [16:47:14] nope [16:47:36] I though you did, meh [16:47:41] (03Merged) 10jenkins-bot: Revert "DifferenceEngine cleanup" [core] - 10https://gerrit.wikimedia.org/r/94764 (owner: 10Siebrand) [16:47:45] i mean, i know that the code was correct (as far as one can know that), but given the obscure workings of mediawiki i'd rather be sure it works [16:48:04] I'm happy if it's not causing regressions for now [16:48:24] I guess I'll test the core patch later tonight... but I should get back to hack on my JS now ;) [16:48:38] heh, okay. thanks [16:49:32] qgil, I think she is not applying this time, as much as I know. Also, why was there a news of the deadline being postponed till 18th? [16:50:38] sucheta, ? [16:51:30] sucheta, https://www.mediawiki.org/wiki/Outreach_Program_for_Women/Round_7#Candidates says "Apply by November 11 following the official FOSS OPW application process. [16:51:30] Candidates will be able to complete their microtask and proposal by November 18." [16:51:52] sucheta, is this what you mean? [16:51:59] (03CR) 10Siebrand: [C: 031] Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 (owner: 10Chad) [16:53:34] qgil, I mean, there were candidates asking if the proposal submission deadline has been postponed till 18th. Anyway, misconception, I suppose. [16:54:59] qgil, Hmm, Niharika was also doing a micro-task for the project I am mentoring. [16:55:41] sucheta, if these candidates that are in touch with you can still apply with a basic proposal on time, then they can have extra days to polish proposal and microtask. [16:56:30] sucheta, but if they don't send anything by the official deadline in two hours, then it will be more than difficult to accept them [16:57:21] sucheta, OPW is a project run woth others (GNOME), but we own the selection process for our candidates. This is why we can offer flexibility as long as the official deadline is observed [16:58:30] sucheta, Niharika Kohli has applied on time, btw [17:00:41] (03PS2) 10Bartosz Dziewoński: Make #contentSub slightly darker [core] - 10https://gerrit.wikimedia.org/r/90563 [17:08:44] qgil, Ah yes. I am wondering which project is Niharika applying for. Like, from the list it seems that she's working on the project to redesign the MediaWiki homepage. She's also working on the micro-tasks that we are assigning her to. [17:09:18] qgil, Could you point me to Niharika's proposal? [17:11:18] sucheta, she didn't link it from the OPW candidates table, but it is listed in her user page: https://www.mediawiki.org/wiki/User:Niharika/UniversalLanguageSelector [17:12:32] sucheta, I just forwarded you the proposal she has sent via email to opw@ [17:15:32] qgil, Ah, thanks. I had also dropped her an email to check if she has submitted the proposal. [17:23:02] (03CR) 10UltrasonicNXT: "I've talked with people in IRC, and the tests seem to be very broken (Reedy confirmed this for me), so is there some other way I can test " [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [17:23:56] (03PS1) 10Addshore: Add DataValues qunit test [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 [17:28:34] (03CR) 10Bartosz Dziewoński: "jenkins-bot will run tests for you if you're whitelisted (or if somebody whitelisted touches the patch for you)." [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [17:28:50] (03PS2) 10Bartosz Dziewoński: Prevent space before ellipsis when truncating [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [17:29:32] (03CR) 10Bartosz Dziewoński: "As for adding the tests, well, I suggest you're real careful when adding them to avoid unnecessary retries :P" [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [17:30:01] (03CR) 10Raimond Spekking: [C: 032] Remove duplicate entries in messages.inc [core] - 10https://gerrit.wikimedia.org/r/94576 (owner: 10Umherirrender) [17:31:17] (03CR) 10Raimond Spekking: [V: 032] Remove duplicate entries in messages.inc [core] - 10https://gerrit.wikimedia.org/r/94576 (owner: 10Umherirrender) [17:33:11] 12 Warning: Missing argument 3 for FlaggedRevsXML::pendingEditNoticeMessage(), called in /usr/local/apache/common-local/php-1.23wmf3/extensions/FlaggedRevs/fronte [17:33:11] nd/FlaggedRevsXML.php on line 423 and defined in /usr/local/apache/common-local/php-1.23wmf3/extensions/FlaggedRevs/frontend/FlaggedRevsXML.php on line 430 [17:33:17] Backport time [17:34:26] (03Merged) 10jenkins-bot: Remove duplicate entries in messages.inc [core] - 10https://gerrit.wikimedia.org/r/94576 (owner: 10Umherirrender) [17:36:30] (03PS1) 10Ebrahim: Add CKB namespace aliases [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/94773 [17:38:59] (03PS1) 10Reedy: Update FlaggedRevs to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94774 [17:39:18] (03CR) 10Reedy: [C: 032 V: 032] Update FlaggedRevs to master [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94774 (owner: 10Reedy) [17:42:35] (03CR) 10Calak: [C: 031] Add CKB namespace aliases [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/94773 (owner: 10Ebrahim) [17:43:32] (03PS2) 10Ebrahim: Add CKB namespace aliases [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/94773 [17:46:23] [17:48:20] (03CR) 10Calak: [C: 031] Add CKB namespace aliases [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/94773 (owner: 10Ebrahim) [17:51:15] (03CR) 10Reedy: "reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/tests/phpunit$ php phpunit.php languages/LanguageTest.php" [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [17:53:57] Y U SO NOISY TESTS!? [18:08:45] (03PS4) 10Umherirrender: Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 [18:10:02] (03CR) 10Umherirrender: "Patch Set 4: Wrap old code in wikibits.js in mw.log.deprecate call" [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [18:10:12] (03CR) 10Bartosz Dziewoński: [C: 032] "Should be fine." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/94773 (owner: 10Ebrahim) [18:11:16] (03CR) 10Patrick87: "I don't know if this is the right place to report since im not really into gerrit, but I think it reaches at least the right people (you c" [core] - 10https://gerrit.wikimedia.org/r/94276 (owner: 10Chad) [18:11:21] (03Merged) 10jenkins-bot: Add CKB namespace aliases [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/94773 (owner: 10Ebrahim) [18:33:55] (03CR) 10Krinkle: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [18:35:50] (03CR) 10Krinkle: [C: 04-1] "Looks good, but should have tests indeed." [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [18:38:54] (03CR) 10Krinkle: [C: 04-1] "Please avoid using find for this purpose. You can pass directories or patterns to jsduck (both through config.json or through its paramete" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [18:40:24] (03CR) 10Krinkle: "Also, modules/ will do a recursive search (see VisualEditor as example)." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/86057 (owner: 10Mattflaschen) [18:42:19] (03CR) 10Krinkle: [C: 031] No need to use custom mw.log anymore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/79917 (owner: 10MarkTraceur) [18:49:12] (03CR) 10Krinkle: [C: 031] Add checkboxShiftClick to "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [18:49:58] (03CR) 10Krinkle: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [18:50:26] (03PS2) 10Krinkle: (bug 38345) use :hover instead of jQuery based styling. [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (owner: 10Nischayn22) [18:55:22] (03CR) 10Krinkle: [C: 031] Use :hover instead of jQuery based styling [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (owner: 10Nischayn22) [19:03:29] (03CR) 10UltrasonicNXT: "Krinkle: I'd love to add tests, but they are broken, perhaps you can explain how I can get jenkins-bot to run them for me?" [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [19:12:48] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [19:17:43] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94748 (owner: 10Dan-nl) [19:20:39] Search backend error during full text search for '"10.5194/tcd-7-573-2013"'. Error message is: SearchPhaseExecutionException[Failed to execute phase [dfs], all shards failed; shardFailures {[hcnKx-c_SV-FBZlkyPBIYw][cawiki_content_1383856466][3]: RemoteTransportException[[testsearch1003] [19:26:58] (03PS5) 10Umherirrender: Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 [19:28:33] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [19:29:52] (03CR) 10Siebrand: [C: 032] Removing parentheses [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94713 (owner: 10Amire80) [19:30:00] (03Merged) 10jenkins-bot: Removing parentheses [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94713 (owner: 10Amire80) [19:31:58] (03CR) 10Siebrand: [C: 04-1] "(3 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94491 (owner: 10Shirayuki) [19:38:07] (03CR) 10Calak: "Thank you very much." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/94773 (owner: 10Ebrahim) [19:40:53] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 (owner: 10Legoktm) [19:41:14] (03PS1) 10Nikerabbit: Increase LanguageConverter cache version [core] - 10https://gerrit.wikimedia.org/r/94789 [19:42:34] (03CR) 10jenkins-bot: [V: 04-1] Increase LanguageConverter cache version [core] - 10https://gerrit.wikimedia.org/r/94789 (owner: 10Nikerabbit) [19:42:41] (03CR) 10Siebrand: [C: 04-1] "Better get rid of var_dumps here..." [core] - 10https://gerrit.wikimedia.org/r/94789 (owner: 10Nikerabbit) [19:43:21] (03PS1) 10Aude: Update Wikibase, fix for action=info [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94790 [19:43:22] Reedy: ^ [19:43:41] Thanks [19:43:58] Will sort it when it quietens down a bit [19:44:51] (03PS2) 10Nikerabbit: Increase LanguageConverter cache version [core] - 10https://gerrit.wikimedia.org/r/94789 [19:44:57] k [19:45:02] (03CR) 10Siebrand: "This probably has caused a weird issue with the LanguageConverter cache addressed with Change-Id: Ief8f4848ab33ae3cb3356e60030f76f20f135dc" [core] - 10https://gerrit.wikimedia.org/r/94253 (owner: 10Siebrand) [19:48:04] (03CR) 10Siebrand: [C: 032] Increase LanguageConverter cache version [core] - 10https://gerrit.wikimedia.org/r/94789 (owner: 10Nikerabbit) [19:48:46] (03CR) 10Krinkle: "Looks good at first. Maybe use a different image for "large file" than the MediaWiki logo as it will get outdated. Some random noise file " [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [19:49:20] (03CR) 10Krinkle: "Also, having the file name reflect its purpose would be helpful (e.g. 5kb.png)" [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [19:51:11] (03Merged) 10jenkins-bot: Increase LanguageConverter cache version [core] - 10https://gerrit.wikimedia.org/r/94789 (owner: 10Nikerabbit) [19:51:25] (03PS1) 10Raimond Spekking: Add i18n file [extensions/LanguageTag] - 10https://gerrit.wikimedia.org/r/94791 [19:53:01] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, fix for action=info [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94790 (owner: 10Aude) [19:53:20] (03CR) 10Siebrand: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94691 (owner: 10Legoktm) [19:54:26] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/LanguageTag] - 10https://gerrit.wikimedia.org/r/94791 (owner: 10Raimond Spekking) [19:55:17] Impressive. UglifyJS now optimises for repeated if/return early returns by instead wrapping the main code in the reversed condition. [19:55:28] var b = bar(); if (a === null) { return; } if (b.thing < 321) { return; } return a * 5; [19:55:35] var b=bar();if(null!==a&&!(b.thing<321))return 5*a [19:56:01] Not sure if that's better even after gzip, but surely interesting [19:57:26] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [20:05:52] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93163 (owner: 1001tonythomas) [20:09:47] Krinkle: what are your feelings on angular? [20:10:06] Ryan_Lane: bbl, dinner [20:10:10] * Ryan_Lane nods [20:15:55] (03PS1) 10Amire80: Corrected message spelling [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94796 [20:17:27] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94602 (owner: 10Umherirrender) [20:18:45] 189 Warning: Pool error searching Elasticsearch: pool-timeout [Called from {closure} in /usr/local/apache/common-local/php-1.23wmf2/extensions/CirrusSearch/includ [20:18:45] es/CirrusSearchSearcher.php at line 378] in /usr/local/apache/common-local/php-1.23wmf2/includes/debug/Debug.php on line 296 [20:18:45] 177 Warning: Pool error searching Elasticsearch: pool-queuefull [Called from {closure} in /usr/local/apache/common-local/php-1.23wmf2/extensions/CirrusSearch/incl [20:18:45] udes/CirrusSearchSearcher.php at line 378] in /usr/local/apache/common-local/php-1.23wmf2/includes/debug/Debug.php on line 296 [20:18:45] 50 Warning: Pool error searching Elasticsearch: pool-timeout [Called from {closure} in /usr/local/apache/common-local/php-1.23wmf3/extensions/CirrusSearch/includ [20:18:47] es/CirrusSearchSearcher.php at line 378] in /usr/local/apache/common-local/php-1.23wmf3/includes/debug/Debug.php on line 296 [20:18:49] 49 Warning: Pool error searching Elasticsearch: pool-queuefull [Called from {closure} in /usr/local/apache/common-local/php-1.23wmf3/extensions/CirrusSearch/incl [20:18:52] udes/CirrusSearchSearcher.php at line 378] in /usr/local/apache/common-local/php-1.23wmf3/includes/debug/Debug.php on line 296 [20:19:53] (03PS1) 10IAlex: Don't escape the mail's subject in Special:PasswordReset [core] - 10https://gerrit.wikimedia.org/r/94816 [20:23:12] (03CR) 10Siebrand: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94796 (owner: 10Amire80) [20:26:57] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [20:28:35] (03CR) 10Amire80: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94796 (owner: 10Amire80) [20:30:02] (03PS6) 10Umherirrender: Migrate redirectToFragment() from wikibits.js to own module [core] - 10https://gerrit.wikimedia.org/r/94412 [20:31:02] (03CR) 10Umherirrender: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94412 (owner: 10Umherirrender) [20:32:46] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/94580 (owner: 10Andrew Bogott) [20:33:34] (03CR) 10Hashar: [C: 032] "Looks perfect now, though I Safari got upgraded meanwhile :-] Thank you Timo!" [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [20:34:38] (03Merged) 10jenkins-bot: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [20:35:38] (03PS3) 10Umherirrender: Do not escape title attribute twice for tooltip-iwiki [core] - 10https://gerrit.wikimedia.org/r/94602 [20:35:46] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94602 (owner: 10Umherirrender) [20:35:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Trivial." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94500 (owner: 10Tinaj1234) [20:36:47] (03PS2) 10Hashar: Add DataValues qunit test [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94772 (owner: 10Addshore) [20:38:44] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 (owner: 10Rillke) [20:40:02] (03CR) 10Hashar: "Is there any reason for that variable to be global? Was wondering if we could move it as protected property of the class since it has a ge" [core] - 10https://gerrit.wikimedia.org/r/94763 (owner: 10Siebrand) [20:41:17] (03CR) 10Siebrand: "@hashar: Possibly. Best chat with Nikerabbit." [core] - 10https://gerrit.wikimedia.org/r/94763 (owner: 10Siebrand) [20:48:05] (03CR) 10Siebrand: [C: 032] Do not escape title attribute twice for tooltip-iwiki [core] - 10https://gerrit.wikimedia.org/r/94602 (owner: 10Umherirrender) [20:50:06] (03CR) 10Siebrand: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/94796 (owner: 10Amire80) [20:51:06] (03Merged) 10jenkins-bot: Do not escape title attribute twice for tooltip-iwiki [core] - 10https://gerrit.wikimedia.org/r/94602 (owner: 10Umherirrender) [20:54:38] (03PS4) 10Bartosz Dziewoński: More tests for CSSMin::remap [core] - 10https://gerrit.wikimedia.org/r/94588 [20:55:38] (03CR) 10Bartosz Dziewoński: "Done. I also moved the files to a separate directory instead of sticking them in media/." [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [21:00:03] (03PS5) 10Bartosz Dziewoński: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 [21:00:56] (03CR) 10Bartosz Dziewoński: "Rebased on dependency." [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [21:01:28] (03PS2) 10Rillke: Add checkboxShiftClick to "Copy Metadata" checkboxes [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 [21:02:15] (03CR) 10Nischayn22: "Mark and Krinkle are happy and I don't have merge rights. Someone please merge :P" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (owner: 10Nischayn22) [21:03:14] (03CR) 10Rillke: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84003 (owner: 10Rillke) [21:12:25] Hi all... Any experts on unit tests and databases have out there have a second pls...? I have a unit test in the Education Program extension that began failing since this change got merged: https://gerrit.wikimedia.org/r/#/c/90653/4 [21:13:00] The line that is killing things says this: [21:13:00] $database = $this->getMock( 'DatabaseMysql' ); [21:13:35] If anyone could point me to documentation on the "correct" way to get a mock DB object, I'd truly appreciate it...! [21:13:42] Thanks in advance!!!! [21:14:37] AndyRussG: a wild guess would be that the mock is defined somewhere in your tests, and that is has to be adjusted to new constructor in core [21:15:06] * MatmaRex looks, but don't expect much [21:16:18] Thanks a lot MatmaRex [21:16:49] As far as I have understood, that line does call a constructor [21:16:51] $database = $this->getMock( 'DatabaseMysql' ); [21:17:08] It goes to some code generation thing [21:18:37] (03PS1) 10Bartosz Dziewoński: DatabaseBase: Fix version number in deprecation notice [core] - 10https://gerrit.wikimedia.org/r/94826 [21:19:13] That code is in a is a subclass of PHPUnit_Framework_TestCase [21:19:49] AndyRussG: what is the error you're getting? [21:20:11] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [21:20:17] https://integration.wikimedia.org/ci/job/mwext-EducationProgram-testextensions-master/519/console [21:20:39] Use of DatabaseBase::__construct method called without parameter array. was deprecated in MediaWiki 1.22. [21:21:06] (03PS2) 10Rillke: Set message and group used on [[Special:SpecialPages]] [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 [21:21:27] That's the code that's eventually being called through PHPUnit_Framework_MockObject_Generator [21:21:58] yeah. hm [21:22:51] That error message was just added in the change that brought this on [21:22:51] https://gerrit.wikimedia.org/r/#/c/90653/4/includes/db/Database.php [21:23:34] AndyRussG: okay, getMock accepts some more parameters, and some of them are passed on to the actual constructor [21:23:49] Yeah [21:23:51] I tried that [21:24:01] now if only i could find some documentation for that [21:24:13] Yeah exactly [21:24:23] I was able to pass some paramters in [21:24:52] I tried $database = $this->getMock( 'DatabaseMysql', array(), array( array() ) ); [21:24:52] or something like: [21:24:53] $stub = $this->getMockBuilder('SomeClass') [21:24:54] ->disableOriginalConstructor() [21:24:54] ->getMock(); [21:24:56] maybe? [21:25:08] Ah hmmm [21:25:14] i copied it from some random manual exceprt at http://phpunit.de/manual/3.7/en/test-doubles.html [21:25:14] I didn't know about that option [21:26:15] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 (owner: 10Rillke) [21:26:29] (03CR) 10Rillke: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 (owner: 10Rillke) [21:28:43] (03CR) 10Siebrand: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 (owner: 10Rillke) [21:28:52] @seen andre__ [21:28:52] MatmaRex: Last time I saw andre__ they were quitting the network with reason: Ping timeout: 264 seconds N/A at 11/11/2013 7:37:26 PM (1h51m26s ago) [21:28:56] @seen qgil [21:28:56] MatmaRex: Last time I saw qgil they were quitting the network with reason: Quit: Leaving N/A at 11/11/2013 8:58:52 PM (30m4s ago) [21:29:00] great. [21:29:06] MatmaRex: I think that's it!!! [21:29:14] AndyRussG: yay [21:29:20] Ryan_Lane: So, angularjs. In what context (project and kind of use). e.g. as templating, backend, data fetching, or all of the above.. [21:29:21] \o/ [21:29:21] phpunit sucks, doesn't it. [21:29:33] I have to confess I'm a bit new to it [21:29:35] which channel can I ask for a revision to be hidden from public due to privacy concerns? [21:29:37] (03CR) 10Siebrand: [C: 032] "Watch out with backwards-compatibility in extensions if you start using this in them..." [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [21:30:07] Back in Javaland I did find some tools that I really enjoyed, especially Mockito [21:31:37] MatmaRex: Yay, it works, passes all tests! Thanks so much!!! [21:31:40] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92598 (owner: 10MaxSem) [21:31:59] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This should not be optional." [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [21:32:01] I guess I was stuck looking for actual Mediawiki documentation on how to do this [21:32:40] (03CR) 10Bartosz Dziewoński: "(I do not mean to *block* merging; but I feel like the point wasn't considered by i18n-knowledgeable people. If it was, please override me" [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [21:32:48] siebrand: ^ [21:33:02] AndyRussG: haha, you must be new here. [21:33:06] Since in the comments of the method it says "DatabaseBase subclasses should not be constructed directly in external code. DatabaseBase::factory() should be used instead. [21:33:17] MatmaRex: What? [21:33:24] dennyvrandecic: revision where? [21:33:30] siebrand: [22:31] (CR) Bartosz Dziewoński: [C: -2] "This should not be optional." [core] - https://gerrit.wikimedia.org/r/93880 (owner: Kaldari) [21:33:30] meta [21:33:32] [22:32] (CR) Bartosz Dziewoński: "(I do not mean to *block* merging; but I feel like the point wasn't considered by i18n-knowledgeable people. If it was, please override me" [core] - https://gerrit.wikimedia.org/r/93880 (owner: Kaldari) [21:33:36] MatmaRex: yeah, still a wee bit new...! [21:33:40] i am asking in stewars too right now [21:33:58] dennyvrandecic: yeah, that's probably the right place (or the right place to learn what the right one is) [21:34:04] MatmaRex: well, it's just fine as optional. [21:34:07] dennyvrandecic: definitely not here though :) [21:34:07] thanks MatmaRex :) [21:34:13] siebrand: well, not really just as fine [21:34:21] MatmaRex: But have fun there, I'm not going to bike shed about that. [21:34:21] (see comments there) [21:34:51] MatmaRex: And yes, your comment was considered. [21:35:11] dereckson's, too. [21:35:29] (03CR) 10Bartosz Dziewoński: Adding a quotation marks message to core. [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [21:35:43] MatmaRex: Dereckson's too. [21:35:52] i removed the -2, +2 again if you feel like this is the right way. [21:36:00] Like I said: I'm out of there. [21:36:15] resolved, thanks MatmaRex [21:36:20] heh. well, if you want to go about it this way… [21:36:29] (03PS3) 10Rillke: Set message and group used on [[Special:SpecialPages]] [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 [21:36:49] i merely stopped the bot for a few minutes since it looked like you missed the comments, not having replied for them. [21:36:54] (03CR) 10Rillke: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 (owner: 10Rillke) [21:36:59] but if you want to make htis difficult, go ahead. :/ [21:37:19] MatmaRex: As you stopped it, you could as well +2 it again. [21:37:45] i don't feel comfortable merging this in the current state. [21:38:25] (i would have done it already if i did.) [21:40:20] MatmaRex and siebrand > I think "" is understandable as quotes in a lot of languages, especially with the inheritance of the ASCII, so I won't press the issue either. [21:41:19] I trust the translators to notice the not perfect quotes and fix it in TranslateWiki, even as optional. [21:41:39] (03PS4) 10Rillke: Set message and group used on [[Special:SpecialPages]] [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 [21:41:53] (03CR) 10Bartosz Dziewoński: [C: 032] "I still do not agree with making this message optional, but Siebrand said he's, and I quote, "out of there". So I'm just going to merge th" [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [21:42:11] now, if nobody argues it MUST be optional, a solution could be to send a new patchset. [21:42:25] (03CR) 10Siebrand: [C: 032] Set message and group used on [[Special:SpecialPages]] [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 (owner: 10Rillke) [21:42:44] (03Merged) 10jenkins-bot: Set message and group used on [[Special:SpecialPages]] [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94499 (owner: 10Rillke) [21:44:15] (03CR) 10Siebrand: [C: 032] "Nice find." [core] - 10https://gerrit.wikimedia.org/r/94414 (owner: 10Bartosz Dziewoński) [21:44:53] (03Merged) 10jenkins-bot: Adding a quotation marks message to core. [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [21:45:32] (03PS1) 10Bartosz Dziewoński: Make 'quotation-marks' message non-optional [core] - 10https://gerrit.wikimedia.org/r/94827 [21:45:42] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/94827" [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [21:45:53] MatmaRex: no, those were the only things in the grep [21:45:54] (03PS1) 10AndyRussG: Fix CourseStoreTest after change to DatabaseBase [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94828 [21:46:18] legoktm: ok, thanks. i checked them and only wikibase needed a minor fix [21:46:42] (03CR) 10Dereckson: [C: 031] Make 'quotation-marks' message non-optional [core] - 10https://gerrit.wikimedia.org/r/94827 (owner: 10Bartosz Dziewoński) [21:46:58] woot. [21:47:12] (03CR) 10Siebrand: [C: 04-2] "ellipsis, comma separator, and friends are all optional messages. This one's just another one. No need to make an exception here." [core] - 10https://gerrit.wikimedia.org/r/94827 (owner: 10Bartosz Dziewoński) [21:48:01] (03CR) 10Bartosz Dziewoński: "Every single European language uses the same comma. However, almost every one uses a different style of quoting: https://en.wikipedia.org/" [core] - 10https://gerrit.wikimedia.org/r/94827 (owner: 10Bartosz Dziewoński) [21:50:28] AndyRussG: re DatabaseBase, this is how I fixed it in echo: https://gerrit.wikimedia.org/r/94282 [21:50:36] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [21:50:41] (03PS2) 10Siebrand: Remove 'watchnologin' and 'prefsnologin' messages [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [21:50:51] (03CR) 10Siebrand: [C: 032] Remove 'watchnologin' and 'prefsnologin' messages [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [21:51:26] (03PS2) 10Siebrand: Canonicalize text and update docs of messages using 'loginreqlink' [core] - 10https://gerrit.wikimedia.org/r/94414 (owner: 10Bartosz Dziewoński) [21:51:27] Hi legoktm [21:51:34] (03CR) 10Siebrand: [C: 032] Canonicalize text and update docs of messages using 'loginreqlink' [core] - 10https://gerrit.wikimedia.org/r/94414 (owner: 10Bartosz Dziewoński) [21:51:46] Thanks so much! Yeah, that was exactly MatmaRex's suggestion, worked like a charm [21:52:17] https://gerrit.wikimedia.org/r/94828 [21:52:21] (03CR) 10Dereckson: "In change Iebf628052ea14f0fb8b931d7c37a0501a24d3d45, it has been highlighted the difference between other separators and these new quotes " [core] - 10https://gerrit.wikimedia.org/r/94827 (owner: 10Bartosz Dziewoński) [21:52:22] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [21:52:39] (03CR) 10Legoktm: [C: 032] Fix CourseStoreTest after change to DatabaseBase [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94828 (owner: 10AndyRussG) [21:52:44] woot :D [21:53:28] Thanks legoktm, that rocks [21:53:42] Now I just have to add this as a dependency to the other patches I have in the pipeline... [21:53:57] (Or when it gets merged, rebase...) [21:54:20] AndyRussG: there's a "Rebase" button on gerrit changesets you can click :) [21:54:29] yeah, jenkins is busy though [21:55:32] (03CR) 10Siebrand: [C: 04-1] "watchnologin is used in MobileFrontend." [core] - 10https://gerrit.wikimedia.org/r/94411 (owner: 10Bartosz Dziewoński) [21:55:40] MatmaRex: right thx [21:56:10] (03CR) 10Nikerabbit: "http://www.unicode.org/cldr/charts/24/by_type/miscellaneous.linguistic_elements.html" [core] - 10https://gerrit.wikimedia.org/r/94827 (owner: 10Bartosz Dziewoński) [21:57:25] Krinkle: I've just been playing around with it and was wondering what your experience is with it [21:58:14] (03Merged) 10jenkins-bot: Fix CourseStoreTest after change to DatabaseBase [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/94828 (owner: 10AndyRussG) [21:58:32] Ryan_Lane: I haven't yet used it "proper" for a project, but so far my impression has been pretty good. The one thing I'm careful on is whether it integrates well, or is more of a framework. Either is fine, but just something to keep in mind. [21:58:47] it seems like a framework [21:59:13] e.g. can it work by plugging-in to what you have elsewhere, or should everything else become a plug-in to it. [21:59:24] It is primarily promoted, documented and applied as a framework. [21:59:49] Pretty stable code base, documentation and community. [22:00:02] Cool! [22:00:20] Haven't looked into the plugin architecture and community around that, but I imagine it's relatively small but on a good projectory. [22:00:22] Ryan_Lane: [22:00:27] * Ryan_Lane nods [22:00:59] the main community is pretty great, just the number and variaty of plugins available that is relativelt small I think. But I could be wrong. [22:01:20] yeah, not many plugins from what I've seen [22:01:30] it doesn't play well with jquery ui either [22:01:36] it does play well with bootstrap, though [22:01:58] But if it isn't intrusive, it might not need many plugins. e.g. server-side you can use any npm package, which is awesome. [22:02:57] client-side, might be a bit more difficult. Afaik server-side it provides an encalsulating framework. Client-side it is more of a mixin, e.g. you can have your own application structure to do whatever, and then use the angular interface to interact with the server and templates. [22:03:08] (03CR) 10Siebrand: [C: 031] Move output functionality from AbstractRevision to Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [22:03:17] yep. i've been playing around with it [22:03:33] which means you can only get in trouble client-side if your plugins alter the DOM significantly, like jQuery UI. [22:03:34] I had about 1000 lines of jquery code which turned into 300 or so of angular [22:03:42] + the extra HTML added for the templating [22:04:08] Though if you're using angular templates, it doesn't really make sense to use jQuery UI. Probably want to use a cleaner stylesheet/semantic markup lib like bootstrap. [22:04:20] yep. that's what I've been doing [22:04:23] cool [22:04:24] but bootstrap is missing some things [22:04:33] Anything in particular? [22:04:45] I'm making a simple music app that integrates with soundcloud to learn angular [22:04:57] I wanted to make a volume slider [22:05:04] doesn't exist in angular or bootstrap [22:05:09] Ryan_Lane: HTML5 ? [22:05:17] ;) [22:05:29] I used range [22:05:33] Right [22:05:36] but then angular can't bind an event to it [22:05:46] it doesn't support it currently [22:05:58] I'll need to use jquery for that until it does [22:06:18] we're thinking of using *parts* of bootstrap for the mobile app [22:06:22] otherwise I haven't seen anything really missing [22:06:24] specifically the grid system (only!) [22:06:38] I'd love to have even just the grid system [22:06:51] YuviPanda: you may want to talk to design [22:06:59] Ryan_Lane: this is design's idea [22:07:02] they are writing a grid system from scratch [22:07:15] Ryan_Lane: from what I understand, that has been stalled for a long time now [22:07:29] oh? cause I saw commits to it even relatively recently [22:07:52] oh? from what I was told, Munaf was working on it, and when he left... [22:07:52] anyway, that would be awesome [22:07:56] Ryan_Lane: hm.. not a generic range polyfil, but maybe interesting? http://demo.tutorialzine.com/2011/11/pretty-switches-css3-jquery/ [22:08:00] pau was working on it eh? [22:08:04] http://tutorialzine.com/2011/11/pretty-switches-css3-jquery/ [22:08:16] Ryan_Lane: hmm, I'll check with pau [22:08:21] heh, that's cool [22:08:21] will meet him in a week :D [22:08:49] YuviPanda: I had a normal range slider working with jquery easy enough [22:08:51] err [22:08:57] Krinkle: ^^ [22:09:10] (03CR) 10Legoktm: [C: 032] DatabaseBase: Fix version number in deprecation notice [core] - 10https://gerrit.wikimedia.org/r/94826 (owner: 10Bartosz Dziewoński) [22:09:20] I just needed to bind on the change and slide events [22:09:43] * YuviPanda is writing JS without jQUery seriously for the first time in his life for the app [22:09:53] (03CR) 10Siebrand: [C: 031] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [22:10:07] angular is the first attempt I've had at working without jquery [22:10:08] YuviPanda: young whippersnapper. [22:10:15] MatmaRex: hehe :P [22:10:27] by the time I started writing JS seriously, jQuery was already a thing [22:10:41] * YuviPanda huggles his years of C# and Python before JS [22:12:13] (03Merged) 10jenkins-bot: DatabaseBase: Fix version number in deprecation notice [core] - 10https://gerrit.wikimedia.org/r/94826 (owner: 10Bartosz Dziewoński) [22:26:10] (03CR) 10Siebrand: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [22:27:55] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [22:30:55] (03CR) 10Siebrand: [C: 032] Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 (owner: 10Chad) [22:36:24] (03CR) 10Nemo bis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [22:49:22] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 (owner: 10Legoktm) [22:50:43] (03PS2) 10Legoktm: Use a [[wikilink]] to display local targets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94692 [22:53:31] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 (owner: 10Legoktm) [22:53:36] (03PS2) 10Legoktm: Link to [[mw:Help:Extension:MassMessage]] at top of the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/94696 [23:07:09] (03CR) 10Daniel Friesen: "Damnit, I should have added "composer.json" to my review list." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93120 (owner: 10MarkAHershberger) [23:11:48] anyone know if a SwiftFileBackend instance is available globally on commons or if you have to create one? [23:35:16] (03PS6) 10Krinkle: resourceloader: Add definition hashing to improve cache invalidation [core] - 10https://gerrit.wikimedia.org/r/90541 [23:55:14] Krinkle: do you need to sort skinScripts / skinStyles?