[00:01:29] (03PS2) 10Bartosz Dziewoński: More tests for CSSMin::remap [core] - 10https://gerrit.wikimedia.org/r/94588 [00:02:51] (03CR) 10jenkins-bot: [V: 04-1] More tests for CSSMin::remap [core] - 10https://gerrit.wikimedia.org/r/94588 (owner: 10Bartosz Dziewoński) [00:05:09] huuuuuh. [00:05:32] 00:02:49 --- Expected [00:05:32] 00:02:49 +++ Actual [00:05:32] 00:02:49 @@ @@ [00:05:32] 00:02:49 -'foo { background: url(http://localhost/w/red.gif?timestamp) }' [00:05:32] 00:02:49 +'foo { background: url(http://localhost/w/red.gif?timestamp) };' [00:05:42] wtf is that trailing semicolon. stupid cssmin. [00:07:27] (03PS3) 10Bartosz Dziewoński: More tests for CSSMin::remap [core] - 10https://gerrit.wikimedia.org/r/94588 [00:33:28] (03PS2) 10Bartosz Dziewoński: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 [00:33:57] awaiting -1… [00:34:08] I can speed it up for you if you'd like. [00:34:16] heh [00:34:32] you mean by reviewing it? please do :P [00:34:40] (03CR) 10Yuvipanda: [C: 04-2 V: 04-1] "Speeding it up :P" [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [00:34:49] (03CR) 10jenkins-bot: [V: 04-1] Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [00:34:50] that's what you meant, right? [00:38:31] heh [00:39:10] so many failed tests [00:39:17] aw crap, my code is actually broken [00:39:45] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94513 (owner: 10Umherirrender) [00:39:53] hmmmm [00:40:00] array( [00:40:00] 'Expand absolute paths', [00:40:01] array( 'foo { prop: url(/w/skin/images/bar.png); }', false, 'http://example.org/quux', false ), [00:40:01] 'foo { prop: url(http://doc.example.org/w/skin/images/bar.png); }', [00:40:01] ), [00:40:14] "doc.example.org"? how has this test ever passed? [00:40:44] you know, you can run these tests locally? :P [00:41:01] i can't, i'm on windows [00:41:10] i tried to set up phpunit in a VM, but failed miserably [00:41:22] and i can't be arsed to download vagrant image, it's like 3 GB [00:41:30] would take hours [00:41:32] oh :( [00:42:17] aaaah, i see. that's set up in setUp() method [00:42:24] now the question is 'why' [00:42:59] ah, becase it's supposed to use wfExpandUrl [00:43:06] stupid dependencies [00:44:20] MatmaRex: Vagrant? [00:44:26] MatmaRex: or machine not powerful enough? [00:45:16] YuviPanda: i can run VMs mostly fine, but it would take unreasonable amount of time to download another image [00:45:42] and then download all of the stuff it vagrant installs after downloading the image [00:45:47] i tried once :P [00:45:47] MatmaRex: ssh into labs? [00:46:04] MatmaRex: ah, yes. [00:46:19] MatmaRex: similar issues for me in some spots, so I just do that when I'm at some place that has good connectivity [00:46:22] legoktm: uh… i am a simple man and i like simple solutions. so let's not. :P [00:47:47] * YuviPanda throws php at MatmaRex [00:47:51] simple solutions, you say? [00:56:31] (03PS3) 10Bartosz Dziewoński: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 [00:57:50] i *think* the failure was just because of too many slashes in tests. [00:57:51] (03CR) 10jenkins-bot: [V: 04-1] Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 (owner: 10Bartosz Dziewoński) [00:57:59] turns out i was wrong. [01:15:10] argh. i hate regexes [01:16:40] (03PS4) 10Bartosz Dziewoński: Rewrite CSSMin::remap to support multiple url() values in one rule [core] - 10https://gerrit.wikimedia.org/r/94511 [01:21:11] ha. works. [01:38:56] (03CR) 10Alex Monk: [C: 04-1] "I don't think this is okay for big wikis with 20+ tags showing in a list." [core] - 10https://gerrit.wikimedia.org/r/80781 (owner: 10Bartosz Dziewoński) [02:06:22] (03CR) 10Alex Monk: [C: 04-1] "I'm not sure it's a good idea in general to remove comments just because you don't understand them." [core] - 10https://gerrit.wikimedia.org/r/94452 (owner: 10Bartosz Dziewoński) [02:46:34] (03CR) 10Alex Monk: [C: 032] ext.echo.overlay: Unbreak removal logic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93114 (owner: 10Bartosz Dziewoński) [02:46:47] (03Merged) 10jenkins-bot: ext.echo.overlay: Unbreak removal logic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93114 (owner: 10Bartosz Dziewoński) [03:50:48] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94581 (owner: 10Andrew Bogott) [03:54:15] (03CR) 10Legoktm: "If you add a new message, please add documentation for it in the MessagesQqq.php file, see https://www.mediawiki.org/wiki/Localisation#Add" [core] - 10https://gerrit.wikimedia.org/r/94581 (owner: 10Andrew Bogott) [04:03:03] !wm--bot [04:03:09] !wm-bot [04:03:09] Hello, I'm wm-bot. The database for this channel is published at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [04:03:23] !api [04:03:23] The MediaWiki API provides direct, high-level access to the data contained in the MediaWiki databases. Client programs should be able to use the API to login, get data, and post changes. Find out more at < https://www.mediawiki.org/wiki/API >. For client libraries in various languages, see < https://www.mediawiki.org/wiki/API:Client_Code >. [04:05:33] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94276 (owner: 10Chad) [04:34:23] (03PS1) 10Parent5446: Revert "Add a hook to validate account creation fields." [core] - 10https://gerrit.wikimedia.org/r/94590 [05:12:38] (03PS3) 10Sakshi: PHP script [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94497 [06:15:19] (03PS1) 10TTO: Add language override options for rebuildInterwiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 [06:19:01] (03PS2) 10TTO: Add language override options for rebuildInterwiki [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94593 [06:28:15] (03CR) 10TTO: [C: 031] Script to enumerate wikis with a given setting [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/43097 (owner: 10MaxSem) [06:40:29] (03PS2) 10Umherirrender: Add content model to the page information [core] - 10https://gerrit.wikimedia.org/r/94513 [06:41:32] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94513 (owner: 10Umherirrender) [07:22:07] (03PS2) 10Nemo bis: OPW Microtask:adding button to show osm map [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [07:23:09] (03CR) 10Nemo bis: "Hello, thanks for your patch. Please add bug numbers of relevance to the footer. https://www.mediawiki.org/wiki/Gerrit/Commit_message_guid" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [07:24:29] (03CR) 10Legoktm: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [07:25:39] (03PS4) 10Legoktm: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 [07:27:08] (03CR) 10Parent5446: [C: 032] Add content model to the page information [core] - 10https://gerrit.wikimedia.org/r/94513 (owner: 10Umherirrender) [07:28:49] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [07:30:49] (03Merged) 10jenkins-bot: Add content model to the page information [core] - 10https://gerrit.wikimedia.org/r/94513 (owner: 10Umherirrender) [07:31:34] (03PS5) 10Legoktm: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 [07:32:15] oh you're fucking with me. [07:32:37] (03CR) 10jenkins-bot: [V: 04-1] Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [07:33:41] (03PS6) 10Legoktm: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 [07:36:04] (03PS3) 10Ori.livneh: Kranitor: Make JSHint pass [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94079 (owner: 10Krinkle) [07:36:15] (03CR) 10Ori.livneh: [C: 032] Kranitor: Make JSHint pass [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94079 (owner: 10Krinkle) [07:36:19] (03Merged) 10jenkins-bot: Kranitor: Make JSHint pass [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94079 (owner: 10Krinkle) [07:41:40] (03CR) 10Parent5446: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [07:42:32] (03CR) 10Parent5446: [C: 031] Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [07:53:02] hi [07:53:05] is this the right place for a question about dev account setup issues, particularly vagrant issues? [08:01:15] (03PS3) 10Legoktm: [WIP] Tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 [08:01:25] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 (owner: 10Legoktm) [08:01:53] wut. [08:02:18] I keep getting a NoMethodError [08:02:25] when I run vagrant up [08:03:52] hash723: sorry, I'm not sure. maybe ask on the talk page of https://www.mediawiki.org/wiki/Mediawiki-vagrant or file a bug in bugzilla? https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki-Vagrant [08:11:57] thanks legoktm [08:49:42] Could someone review this? https://gerrit.wikimedia.org/r/#/c/94598/ [08:59:38] (03Abandoned) 10UltrasonicNXT: Expand content to fill width [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/94566 (owner: 10UltrasonicNXT) [09:05:12] (03PS1) 10Umherirrender: mw.util.addPortletLink: Check length before access array index [core] - 10https://gerrit.wikimedia.org/r/94601 [09:25:25] (03PS1) 10Umherirrender: Do not escape title attribute twice for tooltip-iwiki [core] - 10https://gerrit.wikimedia.org/r/94602 [09:26:59] (03PS2) 10Umherirrender: Do not escape title attribute twice for tooltip-iwiki [core] - 10https://gerrit.wikimedia.org/r/94602 [09:28:30] (03CR) 10Umherirrender: "Patch Set 2: Mixed the bugs in commit message" [core] - 10https://gerrit.wikimedia.org/r/94602 (owner: 10Umherirrender) [09:36:15] (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [09:46:24] (03PS2) 10Umherirrender: mw.util.addPortletLink: Check length before access array index [core] - 10https://gerrit.wikimedia.org/r/94601 [09:47:10] (03CR) 10Umherirrender: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [10:01:26] (03CR) 10Nikerabbit: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [10:10:30] (03CR) 10Nemo bis: "Nikerabbit, try now. Can you define "actually works"?" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [10:13:08] (03PS1) 10IAlex: New hook 'LocalisationChecksBlacklist' to allow to extend the localisation checks blacklist [core] - 10https://gerrit.wikimedia.org/r/94603 [10:19:43] (03CR) 10Raimond Spekking: [C: 032] Revert "Add a hook to validate account creation fields." [core] - 10https://gerrit.wikimedia.org/r/94590 (owner: 10Parent5446) [10:22:20] (03PS3) 10IAlex: Update Special:ChangePassword to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/80411 [10:22:58] (03Merged) 10jenkins-bot: Revert "Add a hook to validate account creation fields." [core] - 10https://gerrit.wikimedia.org/r/94590 (owner: 10Parent5446) [10:23:45] Could someone review this? https://gerrit.wikimedia.org/r/#/c/94598/ [10:23:53] Mr.Dereckson, could you please? [10:37:32] (03PS3) 10Nemo bis: Add direct links to translation interface on Special:AllMessages [core] - 10https://gerrit.wikimedia.org/r/94064 [10:39:59] (03CR) 10Nemo bis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [10:53:22] (03PS3) 10Inchikutty: OPW Microtask:adding button to show osm map [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [11:00:39] (03CR) 10MarkTraceur: [C: 04-1] "(8 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [12:02:48] (03PS1) 10IAlex: Fix profiling error from I0a9a7f10ea (f5a0c23) [core] - 10https://gerrit.wikimedia.org/r/94604 [12:26:44] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94276 (owner: 10Chad) [12:27:22] (03CR) 10Bartosz Dziewoński: "Thus I added hashar as a reviewer. None of the interpretations of this comment I could come up with makes sense. :)" [core] - 10https://gerrit.wikimedia.org/r/94452 (owner: 10Bartosz Dziewoński) [13:13:59] (03PS4) 10Helder.wiki: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 [13:38:57] (03CR) 10MaxSem: [C: 031] "Looks reasonable. Anomie, do you still have reservations?" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [13:49:38] (03PS5) 10Helder.wiki: Return a promise from mw.loader.using() [core] - 10https://gerrit.wikimedia.org/r/75511 [13:56:32] (03CR) 10Nemo bis: "Matt, there is a text you added (e5a3f241) which depends on a specific text for the helppage message: can you explain what the test is mea" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [13:58:39] (03CR) 10Nemo bis: "(1 comment)" [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/87562 (owner: 10Nemo bis) [13:58:44] (03PS2) 10Nemo bis: Quote the alleged "edit" message directly in livetranslate-dictionary-* [extensions/LiveTranslate] - 10https://gerrit.wikimedia.org/r/87562 [13:58:50] (03PS1) 10Arav93: Renamed $wmf* to $wmg* for consistency. Bug 43956 required a change in this repository as well. [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/94609 [13:59:30] (03PS11) 10Nemo bis: Add GENDER support to pagetriage-byline and friend [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 [14:22:13] (03CR) 10MaxSem: [C: 04-1] "Looks good, however please add tests to it (tests/phpunit/languages/LanguageTest.php)." [core] - 10https://gerrit.wikimedia.org/r/94600 (owner: 10UltrasonicNXT) [14:42:46] (03PS1) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [14:53:09] (03CR) 10MaxSem: [C: 04-1] "The message neds to be removed from messages.inc. The preference needs to be removed from all places that use it, not just the UI." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [15:23:07] (03Abandoned) 10Bartosz Dziewoński: Enhanced RC: Remove the list of users who edited the page [core] - 10https://gerrit.wikimedia.org/r/75571 (owner: 10Bartosz Dziewoński) [15:36:06] MaxSem, I saw your comment for the gerrit patch, https://gerrit.wikimedia.org/r/#/c/94614/ , but I think I have removed the code from messages.inc too. as you could see from the https://gerrit.wikimedia.org/r/#/c/94614/1/languages/messages/MessagesEn.php [15:36:41] I said messages.inc, not MessagesEn.php;) [15:37:13] in maintenance/languages [15:37:50] MaxSem, thanks for that, will do [15:43:30] (03PS1) 10Bartosz Dziewoński: EnhancedChangesList: Minor formatting fixes [core] - 10https://gerrit.wikimedia.org/r/94615 [15:46:28] (03PS2) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [15:49:19] tonythomas01, what about the places that use this preference? [15:50:05] MaxSem, places? couldn't get you. You mean the UI ? [15:50:25] (03CR) 10Krinkle: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [15:50:43] search for rememberpassword in includes [15:51:16] also, worth mentioning in release notes:) [15:52:10] MaxSem, but that remember password seems to be for the login page right ? [15:52:37] MaxSem, the one in user-preferences is tog-remeberpassword right ? [15:53:33] all mentions in includes refer to that preference [15:53:41] they have to be fixed [15:53:54] otherwise, the preference is till there [15:55:05] (03CR) 10Krinkle: "fixme: Don't use php if's boolean cast to determine whether there is a relevant user name (`if ( $relevantUser ) {`). Please consult the i" [core] - 10https://gerrit.wikimedia.org/r/88773 (owner: 10Umherirrender) [15:56:55] MaxSem, but I was going through the languages/messages/MessagesEn.php and found 'remembermypassword' => 'Remember my login on this browser (for a maximum of $1 {{PLURAL:$1|day|days}})', [15:56:55] (03CR) 10MaxSem: [C: 04-1] "The pref still needs to be removed from other places." [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [15:57:08] MaxSem, but it was under user login/logout section [15:57:22] tonythomas01, cd includes [15:57:27] grep rememberpassword [15:58:42] for the reference, the result is http://p.defau.lt/?KcKYu__tNcUflm8rNDbRtw\ [15:58:51] err http://p.defau.lt/?KcKYu__tNcUflm8rNDbRtw [16:01:07] MaxSem, I noticed that on the grep, I know your concerns, but according to the script in lang/messages/messagesEn.php , during user login and logout pages, as the comment says [16:01:19] pfft [16:01:35] I'm not referring to messages [16:01:41] MaxSem, sorry for that [16:01:46] I'm referring to code that uses this preference [16:02:22] MaxSem, yeah. I understood, I was asking whether removing that code will affect the same Remeber my login stuff somewhere else [16:02:28] MaxSem, if not, then no probs \ [16:03:11] no. everything that has User::(get|set)Option( 'rememberpassword' ) refers to this preference [16:03:30] MaxSem, then no probs, will remove [16:05:21] What is a good commandline method to upload mediawiki wiki files generated from libreoffice or html pages into mw. [16:07:49] factor, you mean create pages from wikitext? maintenance/edit.php [16:08:13] or you want to convert stuff to wikitext? [16:10:40] MaxSem: I want to upload new pages to mediawiki and modify changed ones. [16:10:56] from what format? [16:11:14] do you have wikitext, or you want to convert from eg HTML? [16:11:37] I have converted WORD docs docx XLS to HTML , I can also convert to mw wiki text. But need to know how to upload the data from commandline [16:12:19] Does the libreoffice conversion have the images from the word doc as well . [16:12:34] libreoffice can convert directly to mediawkiki format. [16:12:42] edit.php then [16:12:55] Any examples on how to use this? [16:13:06] (03PS3) 1001tonythomas: Removed 'Remember my login' option from the Preferences page [core] - 10https://gerrit.wikimedia.org/r/94614 [16:14:01] (03CR) 10Bartosz Dziewoński: "Krinkle, no FIXME here, $relevantUser is a User object or null here." [core] - 10https://gerrit.wikimedia.org/r/88773 (owner: 10Umherirrender) [16:14:28] cat myfile.txt | php edit.php "Page title" -s "Edit summary" -u "Username" [16:14:46] Krinkle|detached: i see you're a fan of post-merge code review. :P [16:14:59] I am using currently MWImporter , which works with standard HTML/IMAGES and uploads them but some of the conversion wonkie. [16:16:10] MaxSem: Can the myfile.txt host a css image in it and be imported into mw as an image. [16:16:19] no [16:16:26] ok [16:18:49] MaxSem: then can I convert HTMl files with images to mediawiki format and upload them correctly? [16:19:00] if so how besides the MWimporter. [16:19:31] you'll have to upload the images separately with uploadBatch.php [16:19:32] which I am trying to work on upgrading. Just wanted to know if a method existed already. [16:19:38] ok [16:22:16] MaxSem: If I upload them separately , will they be correctly linked in the mediawiki page , or will I have to manually inser them. [16:22:25] them = images [16:22:47] (03CR) 10Bartosz Dziewoński: "Extracted the "While we're at it" bits to https://gerrit.wikimedia.org/r/#/c/94615/" [core] - 10https://gerrit.wikimedia.org/r/75571 (owner: 10Bartosz Dziewoński) [16:26:54] no [16:30:43] ok. [16:31:23] MWImporter works but is old, will try to see if I can upgrade it. [16:58:40] MaxSem, I have uploaded the new patch. Can you please go through it https://gerrit.wikimedia.org/r/#/c/94614/ [17:02:52] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80411 (owner: 10IAlex) [17:05:14] (03CR) 10Parent5446: [C: 04-2] "The "Remember me" option is a pretty important and prominent part of the login process. I'm can almost guarantee that it's used across the" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [17:11:11] (03PS3) 10Umherirrender: mw.util.addPortletLink: Check length before access array index [core] - 10https://gerrit.wikimedia.org/r/94601 [17:11:58] (03CR) 10Umherirrender: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/94601 (owner: 10Umherirrender) [17:28:13] (03PS1) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 [17:36:21] (03PS4) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [17:46:05] (03CR) 10MaxSem: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/94614 (owner: 1001tonythomas) [17:46:39] (03PS5) 10Inchikutty: Introducing a button to show coordinates in OSM [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 [18:03:43] MaxSem, Thanks for your comments in https://gerrit.wikimedia.org/r/#/c/94614/3/includes/specials/SpecialUserlogin.php Can you please tell what you meant by Undefined Index : remember ? should I just remove only the statement before || ? [18:03:59] yes [18:04:50] MaxSem, ok. I will try upload a new one [18:06:10] tonythomas01, put the following at the top of your LocalSettings.php: [18:06:12] error_reporting( E_ALL | E_STRICT ); [18:06:12] ini_set( 'display_errors', 1 ); [18:06:29] MatmaRex, done [18:06:55] it will display errors on the page itself ? [18:08:43] yes [18:46:50] (03CR) 10MarkTraceur: [C: 04-1] "(11 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [18:47:23] (03CR) 10MarkTraceur: "FYI, don't worry about the review cycle, I'm a bit thorough sometimes, but you're doing well :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/94587 (owner: 10Inchikutty) [19:40:59] (03CR) 10GICodeWarrior: [C: 04-1] "(1 comment)" [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94497 (owner: 10Sakshi) [20:03:44] (03CR) 10Legoktm: [C: 04-1] "Uh, where is the addModules function defined?" [core] - 10https://gerrit.wikimedia.org/r/94617 (owner: 10Bartosz Dziewoński) [20:04:16] aw, crap. [20:04:46] heh [20:05:47] that change is a part of a larger watchlist rewrite stack, i though i could submit it separately [20:05:58] silly me. [20:05:58] (03PS2) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 [20:06:47] heh, gerrit gets pretty silly when you submit a draft on top of a non-draft [20:06:57] lol [20:07:25] legoktm: i'm wondering, can you access the dependency of that? [20:07:40] nope [20:07:47] "Depends On: (none)" [20:07:53] derp [20:07:55] I think you broke it [20:07:59] :P [20:09:10] (03CR) 10Bartosz Dziewoński: "In draft dependencies I messed up while submitting." [core] - 10https://gerrit.wikimedia.org/r/94617 (owner: 10Bartosz Dziewoński) [20:09:43] (03CR) 10Legoktm: [C: 032] test: register them using the 'UnitTestsList' hook [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/94121 (owner: 10Hashar) [20:10:58] (03CR) 10Aaron Schulz: [C: 032] Fix profiling error from I0a9a7f10ea (f5a0c23) [core] - 10https://gerrit.wikimedia.org/r/94604 (owner: 10IAlex) [20:11:21] heh, i can fetch PS2 via anonymous HTTP even though it's a draft [20:12:22] >.> [20:18:56] (03Merged) 10jenkins-bot: test: register them using the 'UnitTestsList' hook [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/94121 (owner: 10Hashar) [20:20:34] (03PS6) 10Legoktm: Optionally integrate with AntiSpoof [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 [20:24:46] (03Merged) 10jenkins-bot: Fix profiling error from I0a9a7f10ea (f5a0c23) [core] - 10https://gerrit.wikimedia.org/r/94604 (owner: 10IAlex) [20:27:23] (03CR) 10Legoktm: [C: 032] Avoid PHP warning in strripos() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93779 (owner: 10Bsitu) [20:32:36] (03Merged) 10jenkins-bot: Avoid PHP warning in strripos() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93779 (owner: 10Bsitu) [20:35:05] (03PS4) 10Legoktm: Send AbuseFilter hits to CheckUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 [20:35:11] awww yeah, my great watchlist rewrite finally parses! [20:46:25] alright: [20:46:26] (03Draft4) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges: step 1 [core] - 10https://gerrit.wikimedia.org/r/89379 [20:46:32] (03Draft4) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 [20:46:40] (03Draft2) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 [20:46:45] (03Draft2) 10Bartosz Dziewoński: SpecialWatchlist: Don't overwrite context now that we don't have to [core] - 10https://gerrit.wikimedia.org/r/94289 [20:46:53] (03Draft1) 10Bartosz Dziewoński: SpecialWatchlist: Reorder some stuff in #execute [core] - 10https://gerrit.wikimedia.org/r/94627 [20:46:58] (03Draft1) 10Bartosz Dziewoński: SpecialWatchlist: Synchronise some code with newer versions from RC [core] - 10https://gerrit.wikimedia.org/r/94628 [20:47:04] (03Draft2) 10Bartosz Dziewoński: SpecialWatchlist: JS enhancements to namespace selector (like RC) [core] - 10https://gerrit.wikimedia.org/r/94617 [20:47:11] (03Draft1) 10Bartosz Dziewoński: SpecialWatchlist: Split #execute into subfunctions like SpecialRecentChanges [core] - 10https://gerrit.wikimedia.org/r/94677 [20:47:16] reviewplz. :D [20:47:33] legoktm: that's the stack you were "interested" about ^ [20:48:11] (03PS5) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges: step 1 [core] - 10https://gerrit.wikimedia.org/r/89379 [20:50:27] (03PS1) 10Tpt: Improve page pages CSS and JavaScript [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/94678 [20:51:29] (03Abandoned) 10Tpt: Improve page pages CSS and JavaScript [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/94678 (owner: 10Tpt) [20:52:50] (03PS2) 10Tpt: Improve page pages CSS and JavaScript [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/93154 [20:53:36] bawolff: wanna do some fascinating CR? https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:watchlist,n,z [20:55:18] fascinating is never a good word to use when talking about code review [20:55:30] mundane where I can just click yes is much better [20:55:51] heh [20:55:57] Did you rewrite the entire watchlist system :P [20:56:01] well, some of that is pretty mundane [20:56:06] nah, just Special:Watchlist [20:56:18] and i didn't really rewrite it yet, just unfucked it up a little [20:56:24] lol [20:57:00] * bawolff will look, no promises [20:57:02] basically, RC and WL were almost the same in 2006, and they were steadily diverging since [20:57:39] so i copied the updated code from RC and stuffed it into WL. [20:57:44] next i'm going to come up with a sane way to do proper inheritance instead of overriding entire methods [20:58:51] But then mediawiki might be architecturally sound... [20:58:53] we can't have that [20:59:18] i think you're overestimating me. :P [21:00:43] zomg [21:09:07] (03CR) 10Legoktm: [C: 031] Make SpecialWatchlist extend SpecialRecentChanges: step 1 [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [21:09:38] (03PS5) 10Legoktm: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 (owner: 10Bartosz Dziewoński) [21:19:28] (03PS3) 10Legoktm: Use the API to fetch the email if possible [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/88150 [21:19:34] (03PS4) 10Legoktm: [WIP] Use the API to fetch the email if possible [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/88150 [21:22:31] MatmaRex: both LQT and FlaggedRevs use the SpecialWatchlistQuery hook. My grep isn't finished yet though [21:22:40] and MobileFrontend [21:22:57] Wikibase relies on that one [21:23:05] yeah, I don't know how I feel about changing the hook [21:23:12] heavily [21:23:31] we need it in some way ... [21:23:56] oh heh. MobileFrontend calls that hook. it doesn't attach to it. [21:24:21] ugh, did i break the hook? [21:24:34] i didn't mean to break any hooks [21:25:16] legoktm: ^ [21:25:20] not sure [21:25:25] your commit message said "However, this breaks compatibility of the SpecialWatchlistQuery hook..." [21:25:26] everything should continue working exactly as it did [21:25:29] ah [21:25:34] MatmaRex: ewk [21:25:36] ugh, what did i do to that hook [21:25:36] I'm looking at https://gerrit.wikimedia.org/r/#/c/89380/ right now [21:25:43] ah [21:25:44] hm [21:25:46] I guess you haven't tested that against wikibase, have you? [21:26:11] hoo: of course i didn't :P but i think that sounds more scary than it is [21:26:26] hoo: does wikibase read any values from the array from that hook? or does it just add new ones? [21:26:28] we do a bit of scary things with that :P [21:26:30] grep finished. LQT, FlaggedRevs, and Wikibase use the hook, and MF calls the hook in it's MobileWatchlist [21:26:37] MatmaRex: It does scary things [21:26:47] but I'm not solely to blame :P [21:26:55] the hook was just bad... [21:27:01] hoo: hm [21:27:10] MatmaRex: https://dpaste.de/bnHA/raw/ [21:27:12] hoo: doesn't it have to do similar things for recent changes, whatever it does? [21:27:16] that's wikibase. [21:27:25] https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/client/WikibaseClient.hooks.php#L327 [21:27:40] thanks, legoktm [21:27:59] legoktm: that's compatible, then [21:28:05] i only poked with the $values array [21:28:23] that use should continue to work perfectly well [21:28:33] (maybe) [21:28:38] hm [21:29:03] actually, it won't, but it's not that commit that will break it :P [21:29:10] ... [21:29:15] it's the next one [21:29:23] is it broken on master now, or are you about to break it? [21:29:25] where $values becomes a FormOptions [21:29:55] hoo: nothing brekaing is merged yet [21:29:58] ok [21:30:12] so we just have to change  $values['hideWikibase'] === 0 into something more fancy? [21:30:25] hoo: i tihnk you will need a new hook inside SpecialWatchlist::getDefaultOptions [21:30:25] Also as a general rule, we usually go to pains to avoid not backwards compatible changes to hooks [21:30:45] hoo: (check out the most recent patchset on that stack) [21:30:51] bawolff: help is welcome. :D [21:30:52] FlaggedRevs doesn't touch $values [21:31:21] hoo: to register 'hideWikibase' as a thing [21:32:02] that reminds me, I should put in git my extension that uses that hook :P [21:32:06] MatmaRex: we use SpecialWatchlistFilters for that [21:32:07] hoo: actually, could you just test if wikibase works with https://gerrit.wikimedia.org/r/#/c/94677/ [21:33:12] hoo: do you use the SpecialRecentChangesPanel hook for RC? [21:33:29] nope [21:33:33] * MatmaRex clones Wikibase [21:33:37] at least not in client [21:33:40] well, what do you use for RC, then? D: [21:33:51] or do you not show wikibase changes in rc [21:33:59] SpecialRecentChangesQuery [21:34:14] if ( $rcFilterOpts->showWikibaseEdits() === false ) {                        $conds[] = 'rc_type != ' . RC_EXTERNAL;                } [21:34:22] that's what that one basically does [21:34:55] I'm not sure what repo does with watchlist/ recentchange... I doubt they do anything at all, but I haven't worked on that, so I can't tell [21:35:28] hoo: as a user, i can't hide wikidata changes on RC, can i? [21:35:37] (03CR) 10Brian Wolff: [C: 031] Make SpecialWatchlist extend SpecialRecentChanges: step 1 [core] - 10https://gerrit.wikimedia.org/r/89379 (owner: 10Bartosz Dziewoński) [21:36:40] MatmaRex: You can [21:37:02] hidewikidata=1 will hide 'em [21:37:06] (get param) [21:38:13] i can;t hide from UI, though. [21:38:57] where can i see live profiling data again? [21:39:01] i seem to have lost the link [21:41:04] DanielK_WMDE: I'm only aware of https://noc.wikimedia.org/cgi-bin/report.py and doing ?forceprofile=true to the end of the url. I think WMF has fancy things no adays, but I don't know where they are [21:41:12] DanielK_WMDE: https://noc.wikimedia.org/cgi-bin/report.py mh? [21:41:46] yea, i think that's what i was looking for. thanks [21:42:01] hoo: you know, i'm pretty sure that Wikibase will still work with my changes in spite of technically breaking back-compat [21:42:03] people also seem to throw around gdash.wikimedia.org - but I don't have access to that [21:42:13] hoo: can you test it? i don't have it set up [21:42:33] MatmaRex: I'd rather not today, as I got private stuff to do... can I do it tomorrow? [21:42:47] just add me as reviewer to everything that needs checking agains wb [21:42:49] hm, there was a way to filter these somehow, though... [21:43:23] hoo: check the current top of the stack - https://gerrit.wikimedia.org/r/#/c/94677/ [21:43:30] (added you) [21:43:37] it should Just Work(TM) [21:44:02] heh, I hope for that :) [21:45:07] (unless you were bright enough to do a typecheck for 'array' where you now will receive a 'FormOptions', but in that case you can only blame yourselves :P) [21:45:59] argh, yeah [21:46:04] you did a typecheck [21:46:12] you'll get fatals, but it'll work when you remove it. [21:46:17] (03PS5) 10Legoktm: Use the API to fetch the email and realname if possible [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/88150 [21:46:20] Ok, will do that then :P [21:46:24] silly you and your defensive coding. :P [21:46:44] Isarra: ^ [21:47:11] MatmaRex: :D [21:47:13] (03CR) 10Brian Wolff: "This needs a RELEASE-NOTES entry if it changes calling conventions on a hook in a non-backwards compatible way." [core] - 10https://gerrit.wikimedia.org/r/94288 (owner: 10Bartosz Dziewoński) [21:48:26] (03CR) 10Bartosz Dziewoński: [C: 04-1] "It technically does. Most operations on the value should be backwards-compatible (FormOptions implements ArrayAccess), but the type is dif" [core] - 10https://gerrit.wikimedia.org/r/94288 (owner: 10Bartosz Dziewoński) [21:56:40] Nwah? [21:57:40] legoktm: Check if it works and deploy it? :D [21:57:51] It *should* work :P [21:57:55] I'll test it in a ibt [21:57:56] Well, check. [21:57:57] bit* [21:57:59] Shiny. [22:38:13] (03PS2) 10Andrew Bogott: Implement AbortNewAccount hook to check shell name. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/94580 [22:38:22] (03PS8) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [22:39:11] (03CR) 10jenkins-bot: [V: 04-1] Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [22:39:57] (03CR) 10Legoktm: "(2 comments)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [22:40:18] (03PS14) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [22:40:27] hoo: ^ wanna review? :D [22:41:01] legoktm: Actually, I wanted to be in bed already, but I spend almost all day doing various things :P Maybe some time during this week [22:41:21] I need either more days a week, or more hours a day atm... preferable both [22:41:39] haha, same. [22:43:24] hoo: legoktm: ever heard of the 28-hour day schedule? :P [22:43:44] MatmaRex: There was an xkcd about that AFAIR [22:43:51] hoo: yes [22:44:01] https://xkcd.com/320/ [22:44:02] but it has the big downside that you loose any relation to the real time :P [22:44:36] MatmaRex: doesn't work if I have to show up to class. [22:45:00] damn rest of the world, always causing problems [22:45:06] yeah, probably... any real life activities would suffer [22:45:27] although I really like the idea [22:45:34] legoktm: meh, could probably be synchronised [22:45:49] or you'd miss some classes. big deal! :P [22:47:11] MatmaRex: I'm sortof on that sometimes [22:47:17] when I need to be up early on saturdays [22:47:30] woke up today at 10pm [22:50:15] heh [22:53:06] (03PS3) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 [22:57:57] (03PS1) 10Bartosz Dziewoński: Fix release notes formatting [core] - 10https://gerrit.wikimedia.org/r/94681 [22:58:19] (03CR) 10Bartosz Dziewoński: [C: 032] Fix release notes formatting [core] - 10https://gerrit.wikimedia.org/r/94681 (owner: 10Bartosz Dziewoński) [23:03:30] (03Merged) 10jenkins-bot: Fix release notes formatting [core] - 10https://gerrit.wikimedia.org/r/94681 (owner: 10Bartosz Dziewoński) [23:31:27] (03PS4) 10Bartosz Dziewoński: SpecialWatchlist: Use FormOptions for parameter handling [core] - 10https://gerrit.wikimedia.org/r/94288 [23:31:28] (03PS6) 10Bartosz Dziewoński: Rename Watchlist request parameters for consistency with RC's ones [core] - 10https://gerrit.wikimedia.org/r/89380 [23:31:29] (03PS6) 10Bartosz Dziewoński: Make SpecialWatchlist extend SpecialRecentChanges: step 1 [core] - 10https://gerrit.wikimedia.org/r/89379 [23:32:17] bawolff: release notes, just for you ^ [23:32:23] :D [23:36:03] (03PS1) 10MaxSem: Factor out some code to a separate function for better profiling [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/94683