[00:00:04] Just wrapping up a PM conversation [00:02:52] <^d> MaxSem: Will have to be ported in some manner or another. [00:03:03] <^d> Either A) they'll finish ext_zend_compat, and we can just drop it in [00:03:12] <^d> or B) We'll have to port it to hhvm-style extensions. [00:03:36] <^d> I'd prefer (A), but it's not exactly high priority to everyone :) [00:09:58] (03PS1) 10Chad: Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94071 [00:11:59] (03PS1) 10Werdna: Further history backwards compatibility [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94072 [00:13:17] (03PS1) 10Werdna: Improve failure case for MutliDimArray [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94073 [00:18:45] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94072 (owner: 10Werdna) [00:19:09] (03CR) 10EBernhardson: [C: 032] Improve failure case for MutliDimArray [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94073 (owner: 10Werdna) [00:19:19] (03Merged) 10jenkins-bot: Improve failure case for MutliDimArray [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94073 (owner: 10Werdna) [00:19:38] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94072 (owner: 10Werdna) [00:20:33] (03PS1) 10Chad: Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94076 [00:20:34] (03PS1) 10Chad: Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94077 [00:34:07] (03PS2) 10Werdna: Fix fallback handling for backwards-compatibility. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94072 [00:38:53] (03PS1) 10Krinkle: Kranitor: Make JSHint pass [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94079 [00:39:46] (03PS2) 10Krinkle: Kranitor: Make JSHint pass [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/94079 [00:43:10] (03PS24) 10Krinkle: Added Uri class and Uri Query classes. [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [00:43:46] (03CR) 10jenkins-bot: [V: 04-1] Add Uri class and Uri Query classes [core] - 10https://gerrit.wikimedia.org/r/22167 (owner: 10Parent5446) [00:44:20] (03CR) 10Awjrichards: [C: 032] Add a function to return a single page image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/93607 (owner: 10MaxSem) [00:44:30] (03Merged) 10jenkins-bot: Add a function to return a single page image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/93607 (owner: 10MaxSem) [00:55:33] (03PS1) 10Aaron Schulz: Handle Swift JSON listings with unqualified timestamps [core] - 10https://gerrit.wikimedia.org/r/94081 [00:58:54] (03CR) 10Aaron Schulz: "Also matches http://docs.openstack.org/api/openstack-object-storage/1.0/content/serialized-list-output.html" [core] - 10https://gerrit.wikimedia.org/r/94081 (owner: 10Aaron Schulz) [00:59:06] TimStarling: can you CR that? [01:00:18] after my meeting with robla [01:02:19] (03CR) 10Aaron Schulz: [C: 032] Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94071 (owner: 10Chad) [01:02:45] (03CR) 10Aaron Schulz: [C: 032] Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94076 (owner: 10Chad) [01:03:14] (03CR) 10Aaron Schulz: [C: 032] Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94077 (owner: 10Chad) [01:03:40] why not just add a question mark to the "Z" in the regex in MWTimestamp? [01:05:29] (03Merged) 10jenkins-bot: Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94071 (owner: 10Chad) [01:06:26] maybe...just assume GMT like TS_MW timestamps [01:08:27] (03Merged) 10jenkins-bot: Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94076 (owner: 10Chad) [01:08:28] actually Z can be ommitted, so I guess its valid...just ambiguous local time [01:10:21] (03Merged) 10jenkins-bot: Remove unused function [core] - 10https://gerrit.wikimedia.org/r/94077 (owner: 10Chad) [01:13:08] (03PS1) 10Aude: Remove use of deorecated ChangesList function [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/94082 [01:14:42] (03PS2) 10Aaron Schulz: Handle Swift JSON listings with unqualified timestamps [core] - 10https://gerrit.wikimedia.org/r/94081 [01:17:05] (03PS1) 10Aude: Remove deprecated ChangesList::newFromUser function [core] - 10https://gerrit.wikimedia.org/r/94083 [01:17:52] (03CR) 10Awjrichards: [C: 04-1] "unit tests fail:" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/88903 (owner: 10MaxSem) [01:18:29] (03CR) 10GICodeWarrior: [C: 04-1] "Thanks for the review Bartosz." [core] - 10https://gerrit.wikimedia.org/r/93993 (owner: 10Navdeep Bagga) [01:21:11] (03PS2) 10Aude: Remove use of deorecated ChangesList function [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/94082 [01:35:35] (03CR) 10Jdlrobson: "I'm wondering if setting override-height to auto or false has the same effect. Will check this tomorrow." [core] - 10https://gerrit.wikimedia.org/r/90679 (owner: 10JGonera) [01:37:30] anomie|away: If a lua module does multiple Title:getContent() calls for the same page, does it have to get the page text multiple times or is that optimized/cached? [01:37:49] legoktm: It's cached. [01:37:56] ok [01:38:05] Well, let me double check, but I'm pretty sure it's cached. [01:39:05] i'm looking for ways to make https://www.wikidata.org/wiki/Wikidata:List_of_properties/all faster [01:40:06] legoktm: Hmm. Actually, maybe it's not cached. [01:40:07] (03CR) 10Aaron Schulz: [C: 032] Cache page content language in Title object [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [01:40:14] to extract the labels/descriptions/datatype of a property, it gets the content of the page, uses a JSON module i found online to parse it into a lua table, then wrapped into a template [01:40:26] legoktm: Oh, ok. It's cached in memc by Revision::loadText [01:40:41] ok [01:41:13] any ideas on how we can make it faster? I'm not really sure how to profile lua scripts [01:41:14] Whee [01:41:14] Also, if you call it repeatedly for the same mw.title object, it's cached in Lua too. [01:41:28] I didn't even have to nag. [01:41:36] well, we have to create a new object since its invoked multiple times [01:41:43] https://www.wikidata.org/wiki/Module:WBHacks [01:42:54] legoktm: Profile Lua scripts by looking at the limit report comment in the page source ;) Also, if I7799616a and Idffd2d78 ever get merged then it'll show up on the bottom of preview pages too. [01:43:02] (03Merged) 10jenkins-bot: Cache page content language in Title object [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [01:43:08] (03PS3) 10Jdlrobson: Rewrite CSS for vectorTabs and #p-personal with nesting [core] - 10https://gerrit.wikimedia.org/r/90171 [01:43:32] hrm [01:43:32] 2180 ms 20.7% [01:44:06] https://bugzilla.wikimedia.org/show_bug.cgi?id=45470 [01:45:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=47071 [01:45:45] yes, that one too :P [01:52:45] (03CR) 10Tim Starling: [C: 032] Handle Swift JSON listings with unqualified timestamps [core] - 10https://gerrit.wikimedia.org/r/94081 (owner: 10Aaron Schulz) [01:55:51] (03Merged) 10jenkins-bot: Handle Swift JSON listings with unqualified timestamps [core] - 10https://gerrit.wikimedia.org/r/94081 (owner: 10Aaron Schulz) [02:11:57] (03CR) 10MarkTraceur: [C: 032] "<3 aharoni" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93992 (owner: 10Amire80) [02:12:16] (03Merged) 10jenkins-bot: Fix background image for RTL languages [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93992 (owner: 10Amire80) [02:17:03] also awjr if https://gerrit.wikimedia.org/r/93988 gets merged that means story 1301 can be considered complete [02:38:56] (03PS1) 10Gergő Tisza: Handle multiple license templates [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94088 [02:52:12] (03PS6) 10MarkTraceur: Add preference for watching uploaded files [core] - 10https://gerrit.wikimedia.org/r/11063 [02:54:00] (03PS7) 10MarkTraceur: Add preference for watching uploaded files [core] - 10https://gerrit.wikimedia.org/r/11063 [02:54:58] (03PS1) 10Aaron Schulz: Handle Swift JSON listings with unqualified timestamps [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94089 [02:55:15] (03PS1) 10Aaron Schulz: Handle Swift JSON listings with unqualified timestamps [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/94090 [02:55:22] (03CR) 10Aaron Schulz: [C: 032] Handle Swift JSON listings with unqualified timestamps [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/94090 (owner: 10Aaron Schulz) [02:55:28] (03CR) 10Aaron Schulz: [C: 032] Handle Swift JSON listings with unqualified timestamps [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94089 (owner: 10Aaron Schulz) [03:03:13] (03Merged) 10jenkins-bot: Handle Swift JSON listings with unqualified timestamps [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/94090 (owner: 10Aaron Schulz) [03:04:48] (03Merged) 10jenkins-bot: Handle Swift JSON listings with unqualified timestamps [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94089 (owner: 10Aaron Schulz) [03:12:30] (03PS1) 10Hydriz: Check if the article exists first before actually displaying it. [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/94091 [03:16:37] (03CR) 10MZMcBride: "I agree that it's possibly feature-creep, but given that this code is encapsulated within a MediaWiki extension and it provides more robus" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [03:17:03] (03CR) 10MZMcBride: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [03:17:42] (03CR) 10Legoktm: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [03:22:28] ori-l: https://gerrit.wikimedia.org/r/94092 [03:23:11] Oh my. [03:24:37] (03PS4) 10Brian Wolff: Fix issue with cloning of parser from hook. [core] - 10https://gerrit.wikimedia.org/r/92253 [03:25:56] ugh, stupid testing maybe it does make a difference [03:28:24] I could of sworn I tested that before I hit submit [03:29:13] have [03:29:25] (03CR) 10Brian Wolff: [C: 04-1] "Not quite ready yet. (I thought I tested before I hit submit, but apparently not...)" [core] - 10https://gerrit.wikimedia.org/r/92253 (owner: 10Brian Wolff) [03:29:49] I could have sworn I read that message for grammar issues before I hit enter [03:31:35] :-) [03:43:44] Hmm, someone forgot to do transforms in the new exception code [03:44:27] (03PS1) 10Sakshi: F [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94094 [03:44:28] (03PS1) 10Sakshi: A [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94095 [03:44:29] (03PS1) 10Sakshi: R [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94096 [03:44:30] (03PS1) 10Sakshi: PHP [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94097 [03:45:20] ??? [03:46:09] Holy crap [03:46:32] Quick, revoke his editbugs. [03:51:00] (03CR) 10Brian Wolff: "It would be nice if there was a global to control this. Debugging locally, it is useful to me to get the full stack trace with arguments s" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [03:52:04] Or actually, I suppose that makes logical sense when the exception is generated by the parser, that it doesn't try to parse things... [04:01:53] * YuviPanda pokes legoktm with https://gerrit.wikimedia.org/r/#/c/94093/ [04:05:55] AaronSchulz: join #webplatform-site [04:06:28] * Aaron|home will be at a gym in not too long though [04:06:32] * Ryan_Lane nods [04:06:53] Aaron|home: basically, renior should probably enable that extension update [04:06:58] renoir* [04:08:25] YuviPanda: I already looked at it :P [04:08:35] legoktm: +1 / -1? :P [04:08:38] Aaron|home: I'm pretty sure no one has [04:08:53] Aaron|home: anything special need to be done for it, or just update the extension and deploy it? [04:09:35] Ryan_Lane: I never actually made a pull request, so that fork would have to be used or merged first [04:09:45] and the esi global would have to be set to true [04:09:46] I wonder if I can merge it [04:09:59] not much secret sauce though [04:10:05] I think I'm an owner on the repos [04:10:14] * Aaron|home is curious how the CSS looks as he didn't touch that [04:10:38] hm, which repo in github is this? [04:11:00] oh, ugh, it's all under the mediawiki one? [04:11:13] heh, yeah [04:11:13] I don't see a pull request [04:11:15] https://github.com/AaronSchulz/mediawiki/tree/master/extensions/CompaTables [04:11:29] Elsie: just curious, why did you cc yourself on the mobileview api bug? [04:11:29] [20:09] Aaron|home Ryan_Lane: I never actually made a pull request, so that fork would have to be used or merged first [04:11:31] :) [04:11:34] oh [04:11:43] how can I deploy something not merged? :) [04:11:49] magic [04:11:50] duh [04:11:56] * Aaron|home plays with github [04:12:47] * Ryan_Lane waves his hands. *CompatTables deploys* [04:12:56] Ryan_Lane: check now [04:13:23] Ryan_Lane: so the old version wasn't deployed right? [04:13:33] I actually don't know :D [04:13:42] I haven't really done much with them in a while [04:14:16] we should probably actually use that channel ;) [04:14:19] well, at minimum I can deploy it on test [04:14:22] heh [04:14:27] that's why I told you to join it ;) [04:14:30] I did [04:14:34] oh [04:14:35] hahaha [04:14:38] (03PS5) 10Brian Wolff: No error anymore when uploading files with same base name [core] - 10https://gerrit.wikimedia.org/r/87020 (owner: 10Marco) [04:14:46] YuviPanda: I saw it in #mediawiki. [04:14:55] And I seem to cc myself nearly compulsively. [04:15:12] Then I noticed the bug summary typo. [04:15:21] * bawolff would be interested in stats on who is cc'd on the most bugs [04:28:21] (03CR) 10Tim Starling: "Why did you remove the l/I equivalence?" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [04:30:13] (03CR) 10Brian Wolff: "I think this might have been fixed somewhere down the line." [core] - 10https://gerrit.wikimedia.org/r/87020 (owner: 10Marco) [04:42:53] (03PS3) 10Brian Wolff: Rename Special:RandomInCategory to Special:RandomPageInCategory [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 [04:43:22] (03CR) 10Brian Wolff: "PS3 rebase" [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff) [04:45:03] (03PS2) 10Brian Wolff: Include error code in error message when convert fails [core] - 10https://gerrit.wikimedia.org/r/86390 [04:46:15] (03CR) 10Brian Wolff: "PS2: rebase, as a way to try to get this patch some attention ;)" [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [04:53:08] (03PS1) 10Navdeep Bagga: This Patch fix the font size of category tree according to the vector layout. [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/94099 [04:54:59] (03CR) 10Brian Wolff: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86387 (owner: 10Brian Wolff) [04:55:58] (03Abandoned) 10Brian Wolff: This Patch fix the font size of category tree according to the vector layout. [core] - 10https://gerrit.wikimedia.org/r/93993 (owner: 10Navdeep Bagga) [05:00:22] (03CR) 10Brian Wolff: "Hi, just to let you know, you submitted the patch correctly this time :)" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/94099 (owner: 10Navdeep Bagga) [05:16:36] (03PS3) 10Brian Wolff: Add the full resolution of a file to the list of "Other resolutions:" [core] - 10https://gerrit.wikimedia.org/r/86387 [05:17:05] (03CR) 10Brian Wolff: "PS3: clarify the code per Bryan's comments." [core] - 10https://gerrit.wikimedia.org/r/86387 (owner: 10Brian Wolff) [05:19:32] (03PS3) 10Legoktm: Optionally integrate with AntiSpoof [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 [05:22:07] (03PS2) 10Hiong3-eng5: API: added batch process to add text annotation [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/93922 [05:24:46] (03CR) 10Hiong3-eng5: "Kip, this is the final patch, unless you find some errors." [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/93922 (owner: 10Hiong3-eng5) [05:26:58] (03PS1) 10Legoktm: Make TitleBlacklist depend on AntiSpoof [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 [05:27:50] (03PS1) 10Werdna: Add access to historical revisions. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 [05:27:52] (03CR) 10Legoktm: "https://gerrit.wikimedia.org/r/#/c/94100 to make jenkins not skip the newly added tests: https://gerrit.wikimedia.org/r/#/c/94100" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [05:28:51] Wow, I really failed at adding that comment. [05:31:19] (03PS4) 10Legoktm: Optionally integrate with AntiSpoof [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 [05:31:20] (03CR) 10Legoktm: "(1 comment)" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [05:33:16] (03CR) 10Legoktm: "Bump?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87477 (owner: 10Legoktm) [05:42:16] (03PS5) 10Legoktm: Check for a message with no timestamp [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 [05:42:40] (03CR) 10Legoktm: "PS5: manual rebase" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [05:45:18] (03CR) 10Tim Starling: [C: 032] Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [05:45:47] (03CR) 10jenkins-bot: [V: 04-1] Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [05:46:58] (03PS5) 10Brian Wolff: Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 [05:47:35] (03CR) 10jenkins-bot: [V: 04-1] Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [05:48:14] (03PS1) 10EBernhardson: Require core edit permission to create topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 [05:49:46] (03CR) 10Brian Wolff: "PS5: Don't error out if not calling clear state. Also extend this for other things that clear state (like preprocess. Basically anything t" [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [05:50:33] ugh, I did git add without git commit [05:51:03] (03PS6) 10Brian Wolff: Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 [05:51:39] (03CR) 10jenkins-bot: [V: 04-1] Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [05:51:46] (03PS6) 10Legoktm: Check for a message with no timestamp [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 [05:52:12] (03PS7) 10Brian Wolff: Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 [05:52:16] (03CR) 10Legoktm: "PS6: Added "or signature" to message." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [05:53:03] (03CR) 10Brian Wolff: "I lied. PS6: was me fixing whitespace issue that was supposed to be in PS5, but I did git add without git commit." [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [05:56:06] (03PS2) 10Tim Starling: Add centralauth-welcomecreation-msg [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86874 (owner: 10Anomie) [05:56:21] (03CR) 10Tim Starling: [C: 032] Add centralauth-welcomecreation-msg [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86874 (owner: 10Anomie) [05:56:24] (03Merged) 10jenkins-bot: Add centralauth-welcomecreation-msg [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/86874 (owner: 10Anomie) [07:27:27] looks like crossword https://gerrit.wikimedia.org/r/#/q/owner:%22Sakshi%22,n,z [07:36:23] (03CR) 10Raimond Spekking: [C: 032] Rename Special:RandomInCategory to Special:RandomPageInCategory [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff) [07:37:22] (03CR) 10Raimond Spekking: [V: 032] Rename Special:RandomInCategory to Special:RandomPageInCategory [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff) [08:29:21] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [08:34:59] (03CR) 10Siebrand: [C: 04-1] "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [08:36:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [08:57:57] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [09:05:58] (03PS6) 10Nemo bis: [WIP] Moodle Extension [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/75109 (owner: 10Clancer) [09:08:39] (03CR) 10Nemo bis: "Is this still actually WIP? The placeholders seem to be worked on in the followup commit instead." [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/75109 (owner: 10Clancer) [09:19:56] (03CR) 10Nemo bis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [09:20:03] (03PS2) 10Nemo bis: Add direct links to translation interface on Special:AllMessages [core] - 10https://gerrit.wikimedia.org/r/94064 [09:27:08] (03PS1) 10Gerrit Patch Uploader: Changed the red boxed email and email confirmation options [core] - 10https://gerrit.wikimedia.org/r/94117 [09:27:12] (03CR) 10Matthias Mullie: [C: 032] Fix fallback handling for backwards-compatibility. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94072 (owner: 10Werdna) [09:27:14] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/94117 (owner: 10Gerrit Patch Uploader) [09:28:01] (03Merged) 10jenkins-bot: Fix fallback handling for backwards-compatibility. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94072 (owner: 10Werdna) [09:32:29] (03CR) 10Matthias Mullie: [C: 031] "We should probably also make sure the form is not displayed if a user has no permissions." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94103 (owner: 10EBernhardson) [09:33:16] (03PS1) 10Pastakhov: add operator T_LIST [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94118 [09:34:35] (03CR) 10Pastakhov: [C: 032] add operator T_LIST [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94118 (owner: 10Pastakhov) [09:34:42] (03Merged) 10jenkins-bot: add operator T_LIST [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/94118 (owner: 10Pastakhov) [09:43:17] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [09:43:48] (03PS16) 10Hashar: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [09:44:00] (03PS17) 10Hashar: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [09:48:32] (03CR) 10Matthias Mullie: "See https://gerrit.wikimedia.org/r/#/c/92346/4/Hooks.php for more details on why we'd need this for Flow" [core] - 10https://gerrit.wikimedia.org/r/92504 (owner: 10Matthias Mullie) [09:49:16] (03CR) 10Hashar: [C: 032] "Lets land this change in master, will cherry-pick for REL1_22 to get it included in the next release." [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [09:52:13] (03Merged) 10jenkins-bot: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [09:54:59] (03PS1) 10Hashar: MySQL method to find out view + fix fatal in tests [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94119 [09:55:09] (03CR) 10Hashar: "Proposed for inclusion in REL1_22 with https://gerrit.wikimedia.org/r/94119" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [09:57:06] (03CR) 10Hashar: "@brian Fill in an enhancement request in Bugzilla :-]" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [10:19:14] (03CR) 10Gergő Tisza: "Blocked by bug 56598." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza) [10:20:55] (03CR) 10Hashar: [C: 032] wrong arg count comparison [tools/release] - 10https://gerrit.wikimedia.org/r/92042 (owner: 10MarkAHershberger) [10:24:59] (03CR) 10Hashar: [C: 032] Make TitleBlacklist depend on AntiSpoof [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [10:25:01] (03CR) 10jenkins-bot: [V: 04-1] Make TitleBlacklist depend on AntiSpoof [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [10:25:12] (03CR) 10Hashar: "deployed. thanks!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [10:25:29] (03PS5) 10Hashar: Optionally integrate with AntiSpoof [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [10:32:40] (03PS1) 10Hashar: test: register them using the 'UnitTestsList' hook [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/94121 [10:32:43] (03CR) 10jenkins-bot: [V: 04-1] test: register them using the 'UnitTestsList' hook [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/94121 (owner: 10Hashar) [10:34:11] (03CR) 10Hashar: "Note that the extension did not have test registered :( https://gerrit.wikimedia.org/r/94121 should do it." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [10:34:53] (03PS2) 10Hashar: test: register them using the 'UnitTestsList' hook [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/94121 [10:36:15] (03CR) 10Hashar: "trying again" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [10:36:52] (03PS2) 10Hashar: Make TitleBlacklist depend on AntiSpoof [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [10:36:59] (03CR) 10Hashar: [C: 032] Make TitleBlacklist depend on AntiSpoof [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [10:37:38] (03Merged) 10jenkins-bot: Make TitleBlacklist depend on AntiSpoof [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94100 (owner: 10Legoktm) [11:23:05] (03PS1) 10Matthias Mullie: (bug 56126) Inconsistent replying behavior [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94124 [13:13:11] (03PS7) 10Brian Wolff: [WIP] Moodle Extension [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/75109 (owner: 10Clancer) [13:14:03] (03CR) 10Brian Wolff: [C: 032] "There's still some issues with this, but I'm going to merge so that later things have a base to improve on. Also gsoc is over and it doesn" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/75109 (owner: 10Clancer) [13:14:21] (03CR) 10Brian Wolff: [V: 032] "There's still some issues with this, but I'm going to merge so that later things have a base to improve on. Also gsoc is over and it doesn" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/75109 (owner: 10Clancer) [13:19:42] (03PS1) 10Dan-nl: Bryan Davis and Gergő Tisza mentioned concern about the special page handler AjaxHandler use of exit() and set_error_handler(). after reviewing the code and the possibility of extending the API instead i was able to instead make use of the existing API ac [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 [13:20:05] (03CR) 10Siebrand: "(1 comment)" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/75109 (owner: 10Clancer) [13:23:45] (03PS2) 10Siebrand: Bryan Davis and Gergő Tisza mentioned concern about the special page handler AjaxHandler use of exit() and set_error_handler(). after reviewing the code and the possibility of extending the API instead i was able to instead make use of the existing API ac [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 (owner: 10Dan-nl) [13:23:55] (03PS3) 10Dan-nl: re-factor save metadata mapping [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 [13:24:00] (03CR) 10Siebrand: "PS2 cleans up the edit summary." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 (owner: 10Dan-nl) [13:24:21] (03CR) 10Physikerwelt: "I really like the work done here. Thanks a lot to AlephNull and Hashar." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94119 (owner: 10Hashar) [13:24:25] (03CR) 10Siebrand: "Ah, Dan did the same, almost." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 (owner: 10Dan-nl) [13:30:47] Hello! Mr. Dereckson [13:32:04] (03PS2) 10Brian Wolff: Adding database schema and appropriate hook Grades page now interacts with database need to add functions on moodle end to get internal ids and grades [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/83628 (owner: 10Clancer) [13:32:08] Hello! andre__ [13:34:05] hi arav93 [13:34:59] There's this another bug, I'm working on https://bugzilla.wikimedia.org/show_bug.cgi?id=43956 [13:35:28] So, do you know where I might find the '$wmfRealm' global variable? [13:36:23] arav93: To find a variable I usually try grep -r "wmfRealm" *. [13:36:31] ^bash [13:36:49] (03CR) 10Brian Wolff: [C: 032 V: 032] "marging this, since Clancer does not appear to be working on comments, so might as well have what's done in the repo" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/83628 (owner: 10Clancer) [13:39:11] arav93: That's for the wmf config files, not mediawiki source, so you have to download a separate repo (operations/mediawiki-config.git I think) [13:39:30] When using git you can also use a command like [13:39:42] git grep "thingIWantToFind" [13:41:43] Oh, thanks bawolff. [13:41:57] I tried grep in the mediawiki source. [13:42:29] might not be the best thing for a first patch, as its not the easiest type of thing to test [13:43:36] So what should I do for it? [13:47:41] (03CR) 10Siebrand: "Should we just go ahead and merge this disabled test, or what's the expectation? Liangent, Cscott?" [core] - 10https://gerrit.wikimedia.org/r/78330 (owner: 10Cscott) [13:48:59] There's this problem I have with setting up git, I know this is wikimedia channel, but could anyone help me out? [13:50:39] (03CR) 10Siebrand: "This was merged without (most of) the comments being addressed in any way. What's the reason for that, Brian?" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/83628 (owner: 10Clancer) [13:51:05] arav93: I was told yesterday not to "ask to ask" but put up the question right away. [13:52:54] Ok, so I followed the steps for settign up git from http://www.mediawiki.org/wiki/Gerrit/Tutorial untill 'ssh @gerrit.wikimedia.org -p 29418' , where I get 'Permission denied (publickey).' , So what might be the problem? [13:53:50] (03PS1) 10Brian Wolff: Stylize [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/94129 [13:54:13] arav93: Did you add your public key in your gerrit preferences [13:54:21] Yes [13:54:28] failing that, ssh being set up improperly on you local install is most likely issue [13:56:05] I don't think there's any chance of that, because I just followed the code. [13:56:57] (03CR) 10Brian Wolff: "Seemed like it was better to merge into repo (Since no one is using the extension) so that other's can build on it, then to just have this" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/83628 (owner: 10Clancer) [13:58:02] (03PS1) 10Hashar: mwimport.py: unused python import [extensions/Offline] - 10https://gerrit.wikimedia.org/r/94130 [13:58:03] (03PS1) 10Hashar: pass pep8/pyflakes [extensions/Offline] - 10https://gerrit.wikimedia.org/r/94131 [13:58:41] (03CR) 10Brian Wolff: "Hmm, should I just self merge this. Style changes with esentially no code changes, for an extension not used on Wikimedia (or any other si" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/94129 (owner: 10Brian Wolff) [13:58:58] (03CR) 10Hashar: [C: 032 V: 032] mwimport.py: unused python import [extensions/Offline] - 10https://gerrit.wikimedia.org/r/94130 (owner: 10Hashar) [13:59:08] (03CR) 10Hashar: [C: 032 V: 032] pass pep8/pyflakes [extensions/Offline] - 10https://gerrit.wikimedia.org/r/94131 (owner: 10Hashar) [14:00:35] (03CR) 10Nemo bis: [C: 031] "Diff looks sane (but I didn't check SpecialMoodleWS.php because line matching makes gerrit's diff useless)" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/94129 (owner: 10Brian Wolff) [14:01:12] (03CR) 10Nemo bis: "bawolff, I'd say yes; especially as the next person committing a small patch will get stuck with whitespace -1" [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/94129 (owner: 10Brian Wolff) [14:01:38] (03CR) 10Brian Wolff: [C: 032 V: 032] Stylize [extensions/Moodle] - 10https://gerrit.wikimedia.org/r/94129 (owner: 10Brian Wolff) [14:02:39] bawolff: are you going to file the other issues from CR as bugs? [14:04:40] umm, possibly [14:06:30] (03CR) 10Bartosz Dziewoński: [C: 031] "Untested." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [14:07:35] (03PS1) 10Hashar: tweak pep8 exclude directives [integration/jenkins] - 10https://gerrit.wikimedia.org/r/94132 [14:08:07] (03CR) 10Hashar: [C: 032] tweak pep8 exclude directives [integration/jenkins] - 10https://gerrit.wikimedia.org/r/94132 (owner: 10Hashar) [14:08:11] (03Merged) 10jenkins-bot: tweak pep8 exclude directives [integration/jenkins] - 10https://gerrit.wikimedia.org/r/94132 (owner: 10Hashar) [14:09:08] I wrote it in the bug report for the extension itself [14:09:27] honestly there's a lot of problems with that extension [14:11:38] (03Abandoned) 10Bartosz Dziewoński: Changed the red boxed email and email confirmation options [core] - 10https://gerrit.wikimedia.org/r/93981 (owner: 10Gerrit Patch Uploader) [14:12:27] Hey, I am working on the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 , I have cloned the extension MultimediaViewer, and I know that a local only message should be added to the MultimediaViewer.i18n.php file, but I don't know where to add it, Could anyone please help me with it? [14:14:18] How do I download operations/mediawiki-config.git? [14:14:48] durga94: https://www.mediawiki.org/wiki/Localisation#Adding_new_messages [14:15:37] arav93: same as always, https://www.mediawiki.org/wiki/Download_from_Git#Using_Git_to_download_MediaWiki [14:16:05] git clone ssh://@gerrit.wikimedia.org:29418/operations/mediawiki-config.git [14:21:37] The git installation still does not work. I have tried both in superuser account and the normal one. Still 'Permission denied(public key).' [14:21:43] (03Abandoned) 10Hashar: Support fallback chains in Message::getKey(). [core] - 10https://gerrit.wikimedia.org/r/50364 (owner: 10Daniel Kinzler) [14:22:05] (03Abandoned) 10Hashar: Always call parent::setUp() in DiffHistoryBlobTest [core] - 10https://gerrit.wikimedia.org/r/76705 (owner: 10Nikerabbit) [14:22:49] (03Abandoned) 10Hashar: Testing bugzilla comments [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/70821 (owner: 10QChris) [14:23:53] arav93: permissions are on the server, su doesn't help [14:24:16] Yeah, I know. I accidently did it on the su thing first. [14:24:21] you're probably using the wrong username or you didn't upload your key to gerrit https://www.mediawiki.org/wiki/Gerrit/Tutorial#Setting_up_Git [14:24:23] (03CR) 10Hashar: [C: 04-1] "Please add an entry in the release-notes." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93120 (owner: 10MarkAHershberger) [14:27:00] (03CR) 10Hashar: [C: 032] Update formatting [core] - 10https://gerrit.wikimedia.org/r/93440 (owner: 10Siebrand) [14:28:28] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [14:28:43] (03CR) 10Siebrand: "Remaining errors should be fixed by merging https://gerrit.wikimedia.org/r/#/c/93450/ (skip check in CodeSniffer)." [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [14:29:21] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [14:30:40] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/93440 (owner: 10Siebrand) [14:42:29] (03CR) 10Hashar: "I still think duplicating plurals both in a XML and a Serialized files is a very bad idea." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [14:43:02] (03PS2) 10Hashar: wrong arg count comparison [tools/release] - 10https://gerrit.wikimedia.org/r/92042 (owner: 10MarkAHershberger) [14:43:18] (03Abandoned) 10Hashar: wrong arg count comparison [tools/release] - 10https://gerrit.wikimedia.org/r/92042 (owner: 10MarkAHershberger) [14:43:39] (03PS2) 10MarkAHershberger: Allow reuse of extension checkout [tools/release] - 10https://gerrit.wikimedia.org/r/92043 [14:43:45] (03PS2) 10Hashar: Clean up [tools/release] - 10https://gerrit.wikimedia.org/r/92044 (owner: 10MarkAHershberger) [14:43:50] (03PS2) 10Hashar: remove old fork [tools/release] - 10https://gerrit.wikimedia.org/r/92045 (owner: 10MarkAHershberger) [14:44:04] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92253 (owner: 10Brian Wolff) [14:46:50] (03CR) 10MarkAHershberger: "Why? They aren't modified normally (except when tarballs are built). It is just like any other cached data." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [14:46:57] (03Abandoned) 10Hashar: sphinx documentation [sartoris] - 10https://gerrit.wikimedia.org/r/81912 (owner: 10Hashar) [14:47:01] (03Abandoned) 10Hashar: flake8/pep8 tox environnement [sartoris] - 10https://gerrit.wikimedia.org/r/81907 (owner: 10Hashar) [14:47:12] (03Abandoned) 10Hashar: make-release had an unused local var 'length' [sartoris] - 10https://gerrit.wikimedia.org/r/81908 (owner: 10Hashar) [14:47:58] (03CR) 10Daniel Kinzler: [C: 04-1] "if the script called via the wrappe has something like" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [14:51:25] (03PS3) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 [14:52:18] (03PS5) 10Manybubbles: Add Elasticsearch version to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 [14:54:25] (03PS4) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 [14:54:57] (03CR) 10Siebrand: "In PS4, the class name changes were removed." [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [15:09:05] arav93: solved? [15:14:30] (03CR) 10Daniel Kinzler: [C: 031] "Looks sensible, but I'm unsure how this interacts with automatic transcription and the separator and digit substitution stuff." [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [15:15:26] (03PS1) 10Siebrand: Remove underscore from CdbReader_[DBA|PHP] classes and related file [core] - 10https://gerrit.wikimedia.org/r/94133 [15:20:33] hashar: did you commit the changes you made to the build routines? [15:24:37] (03CR) 10Daniel Kinzler: [C: 031] "Seems good, and would be very useful to extensions like Wikibase, that currently have to maintain huge lists of class -> file mappings." [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [15:26:58] (03CR) 10Brian Wolff: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92253 (owner: 10Brian Wolff) [15:30:41] I'm trying to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=43956 in which I have rename $wmfRealm to $wmgRealm. But in the comments another person has asked to rename several other variables too, should I do that as well? [15:32:29] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [15:32:44] (03PS7) 10Bartosz Dziewoński: Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 [15:34:01] hashar: I read your email on Labs-L :D [15:34:23] * addshore cant wait to see jenkins running there ;p [15:34:28] (03CR) 10Bartosz Dziewoński: "Needs rebase. Move notes to 1.23 (or please state that this needs backporting somewhere). Can't this cause duplicate information to be dis" [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [15:35:39] (03CR) 10Krinkle: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [15:37:17] (03CR) 10Hashar: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [15:38:02] arav93: I don't see any harm in doing them. :-) [15:39:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The child selector hacks for IE need to be replaced with the star hack:" [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [15:39:28] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92253 (owner: 10Brian Wolff) [15:40:11] * AzaToth tickles hashar  [15:40:48] (03PS8) 10Bartosz Dziewoński: Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 [15:42:13] (03CR) 10Bartosz Dziewoński: "Sorry, I mean the underscore hack. The star hack catches IE7 as well. (Any similar solution that keeps the rules closer together is fine t" [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [15:51:27] (03CR) 10Bartosz Dziewoński: [C: 032] "Alright. Please update https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Page-specific now! :)" [core] - 10https://gerrit.wikimedia.org/r/88773 (owner: 10Umherirrender) [15:54:30] (03Merged) 10jenkins-bot: Add "wgRelevantUserName" from skin to mw.config [core] - 10https://gerrit.wikimedia.org/r/88773 (owner: 10Umherirrender) [15:54:43] (03CR) 10Bartosz Dziewoński: [C: 032] mw.Map: add ability to map over an existing object other than 'window' [core] - 10https://gerrit.wikimedia.org/r/92450 (owner: 10Ori.livneh) [15:55:11] hashar: pushed a review to operations-debs-buck-debian-glue but I see no building going on [15:56:20] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91844 (owner: 10Krinkle) [15:56:24] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [15:58:44] (03Merged) 10jenkins-bot: mw.Map: add ability to map over an existing object other than 'window' [core] - 10https://gerrit.wikimedia.org/r/92450 (owner: 10Ori.livneh) [16:00:06] (03CR) 10Krinkle: "The phrasing of "to map over" seems confusing both in the commit message and in the documentation (e.g. the noun Map or verb to map over a" [core] - 10https://gerrit.wikimedia.org/r/92450 (owner: 10Ori.livneh) [16:01:10] (03CR) 10GICodeWarrior: [C: 04-2] "Thanks for getting this up for review!" [extensions/CSS] - 10https://gerrit.wikimedia.org/r/94097 (owner: 10Sakshi) [16:02:51] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92450 (owner: 10Ori.livneh) [16:06:13] (03CR) 10Krinkle: "Please use a less generic commit message next time. At least mention which function you removed. For one, there's 2 the same commits in re" [core] - 10https://gerrit.wikimedia.org/r/94076 (owner: 10Chad) [16:07:31] (03CR) 10Jdlrobson: "Can you guarantee switching from child to descendant selectors will not break anything else? I'd rather do this separately as this patch i" [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [16:07:48] (03PS3) 10BryanDavis: Include error code in error message when convert fails [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [16:08:09] AzaToth: that is broken so :/ [16:08:34] AzaToth: or maybe it is not enabled for buck :] [16:08:45] (03CR) 10BryanDavis: [C: 031] "Does anyone have an objection to this? Anything that makes it easier for bawolff to debug things for us is good in my book." [core] - 10https://gerrit.wikimedia.org/r/86390 (owner: 10Brian Wolff) [16:09:57] (03CR) 10Bartosz Dziewoński: "It *should not* break anything. I'd also rather do it separately, but before this patch or at least before this patch is merged, so we don" [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [16:10:24] (03PS1) 10Hashar: trigger operations-debs-buck-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94146 [16:10:26] AzaToth: yeah it is not in Zuul, adding it [16:10:42] (03CR) 10Hashar: [C: 032] trigger operations-debs-buck-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94146 (owner: 10Hashar) [16:10:59] (03PS4) 10BryanDavis: Add the full resolution of a file to the list of "Other resolutions:" [core] - 10https://gerrit.wikimedia.org/r/86387 (owner: 10Brian Wolff) [16:11:20] (03CR) 10BryanDavis: [C: 032] Add the full resolution of a file to the list of "Other resolutions:" [core] - 10https://gerrit.wikimedia.org/r/86387 (owner: 10Brian Wolff) [16:11:23] (03Merged) 10jenkins-bot: trigger operations-debs-buck-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94146 (owner: 10Hashar) [16:19:23] (03CR) 10Cscott: [C: 031] "Yes, please. It's just waiting for a +2 review." [core] - 10https://gerrit.wikimedia.org/r/78330 (owner: 10Cscott) [16:19:24] (03Merged) 10jenkins-bot: Add the full resolution of a file to the list of "Other resolutions:" [core] - 10https://gerrit.wikimedia.org/r/86387 (owner: 10Brian Wolff) [16:19:38] (03CR) 10BryanDavis: [C: 031] re-factor save metadata mapping [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/94128 (owner: 10Dan-nl) [16:20:44] (03PS2) 10Umherirrender: Fix call to function applyPatch in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/93777 [16:28:34] (03PS1) 10Bartosz Dziewoński: Suppress section edit links with action=render [core] - 10https://gerrit.wikimedia.org/r/94150 [16:36:57] (03CR) 10Siebrand: [C: 032] Add parserTests for language converter markup. [core] - 10https://gerrit.wikimedia.org/r/78330 (owner: 10Cscott) [16:39:58] (03Merged) 10jenkins-bot: Add parserTests for language converter markup. [core] - 10https://gerrit.wikimedia.org/r/78330 (owner: 10Cscott) [16:41:38] (03PS5) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 [16:42:10] Krinkle: Hey, would you be able to comment on the global CSS/JS bug on whether you think that feature should live in the CA extension? [16:43:03] I think it should. [16:43:09] link? [16:44:22] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=13953 [16:45:24] (03PS1) 10Reedy: Bump to Wikibase version 1.23wmf3 [tools/release] - 10https://gerrit.wikimedia.org/r/94156 [16:45:29] (03PS5) 10Zsaigol: Special:ListUsers: add a dropdown option to filter by blocked status [core] - 10https://gerrit.wikimedia.org/r/79041 [16:45:58] (03CR) 10Reedy: [C: 032] Bump to Wikibase version 1.23wmf3 [tools/release] - 10https://gerrit.wikimedia.org/r/94156 (owner: 10Reedy) [16:47:07] (03CR) 10jenkins-bot: [V: 04-1] Special:ListUsers: add a dropdown option to filter by blocked status [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [16:47:26] (03Merged) 10jenkins-bot: Bump to Wikibase version 1.23wmf3 [tools/release] - 10https://gerrit.wikimedia.org/r/94156 (owner: 10Reedy) [16:49:37] (03CR) 10Chad: [C: 032] Send updates for link counts instead of indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94057 (owner: 10Manybubbles) [16:49:46] (03Merged) 10jenkins-bot: Send updates for link counts instead of indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94057 (owner: 10Manybubbles) [16:52:13] (03PS1) 10Siebrand: Declare visibility on Autoloader::$autoloadLocalClassesLower [core] - 10https://gerrit.wikimedia.org/r/94157 [16:53:01] (03CR) 10Siebrand: "https://gerrit.wikimedia.org/r/#/c/94157/" [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [16:53:27] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [16:53:38] (03Abandoned) 10Zsaigol: Special:ListUsers: add a dropdown option to filter by blocked status [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [16:58:21] (03PS1) 10Siebrand: Move files with tests to reflect the code [core] - 10https://gerrit.wikimedia.org/r/94158 [16:59:49] (03CR) 10jenkins-bot: [V: 04-1] Move files with tests to reflect the code [core] - 10https://gerrit.wikimedia.org/r/94158 (owner: 10Siebrand) [17:03:23] (03PS2) 10Siebrand: Move files with tests to reflect the code [core] - 10https://gerrit.wikimedia.org/r/94158 [17:11:31] (03PS1) 10Siebrand: Break long lines [core] - 10https://gerrit.wikimedia.org/r/94159 [17:19:15] (03PS2) 10Siebrand: Remove underscore from CdbReader_[DBA|PHP] classes and related file [core] - 10https://gerrit.wikimedia.org/r/94133 [17:27:01] (03CR) 10Siebrand: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [17:27:11] (03CR) 10Chad: [C: 04-2] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [17:27:35] (03PS6) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 [17:28:24] (03PS4) 10MaxSem: Don't save secondary coordinates equal to primary one [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/88903 [17:29:14] (03Abandoned) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [17:29:32] (03Abandoned) 10Siebrand: Break long lines [core] - 10https://gerrit.wikimedia.org/r/94159 (owner: 10Siebrand) [17:29:43] (03Abandoned) 10Siebrand: Move files with tests to reflect the code [core] - 10https://gerrit.wikimedia.org/r/94158 (owner: 10Siebrand) [17:29:56] (03Abandoned) 10Siebrand: Declare visibility on Autoloader::$autoloadLocalClassesLower [core] - 10https://gerrit.wikimedia.org/r/94157 (owner: 10Siebrand) [17:30:10] (03Abandoned) 10Siebrand: Remove underscore from CdbReader_[DBA|PHP] classes and related file [core] - 10https://gerrit.wikimedia.org/r/94133 (owner: 10Siebrand) [17:30:22] (03Abandoned) 10Siebrand: Disable rule Squiz.WhiteSpace.OperatorSpacing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/93450 (owner: 10Siebrand) [17:30:38] (03PS5) 10Siebrand: Add close elements through code [core] - 10https://gerrit.wikimedia.org/r/88500 [17:30:41] (03Abandoned) 10Siebrand: Add close elements through code [core] - 10https://gerrit.wikimedia.org/r/88500 (owner: 10Siebrand) [17:31:48] (03CR) 10Jdlrobson: [C: 032] Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [17:33:34] (03CR) 10Jdlrobson: "OK, let's do that. I don't have much familiarity with the vector left nav - are there any situations on any projects where there are neste" [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [17:34:30] Krinkle: ignoring the the CA/extension issue, do you have some time to review the latest patchset I uploaded? [17:34:40] Not right now [17:35:22] ok, i'll bug you later :) [17:35:34] (03PS1) 10Krinkle: Migrate usage of legacy wikibits in core [core] - 10https://gerrit.wikimedia.org/r/94161 [17:35:55] (03CR) 10Chad: "There was no need to get all passive-aggressive and abandon the whole string of changes." [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [17:36:15] (03Merged) 10jenkins-bot: Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [17:36:16] (03PS2) 10Krinkle: Migrate usage of legacy wikibits in core [core] - 10https://gerrit.wikimedia.org/r/94161 [17:36:58] (03PS3) 10Krinkle: Migrate usage of wikibits in legacy protect.js and upload.js [core] - 10https://gerrit.wikimedia.org/r/94161 [17:36:59] (03Restored) 10Chad: Move files with tests to reflect the code [core] - 10https://gerrit.wikimedia.org/r/94158 (owner: 10Siebrand) [17:37:07] (03CR) 10Chad: [C: 032] Move files with tests to reflect the code [core] - 10https://gerrit.wikimedia.org/r/94158 (owner: 10Siebrand) [17:37:23] (03PS4) 10Krinkle: Migrate usage of wikibits in legacy protect.js and upload.js [core] - 10https://gerrit.wikimedia.org/r/94161 [17:37:48] (03Restored) 10Chad: Break long lines [core] - 10https://gerrit.wikimedia.org/r/94159 (owner: 10Siebrand) [17:38:05] (03CR) 10Bartosz Dziewoński: Rewrite CSS for vectorTabs and #p-personal with nesting [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [17:38:05] (03CR) 10Chad: [C: 032] Break long lines [core] - 10https://gerrit.wikimedia.org/r/94159 (owner: 10Siebrand) [17:38:13] (03PS5) 10Krinkle: Migrate usage of wikibits in legacy protect.js and upload.js [core] - 10https://gerrit.wikimedia.org/r/94161 [17:38:36] (03CR) 10Bartosz Dziewoński: "> are there any situations on any projects where there are nested lists that might be effected by such a styling change?" [core] - 10https://gerrit.wikimedia.org/r/90171 (owner: 10Jdlrobson) [17:38:39] (03CR) 10Krinkle: "Added legacy.wikibits back to legacy.ajax." [core] - 10https://gerrit.wikimedia.org/r/94161 (owner: 10Krinkle) [17:38:40] (03Abandoned) 10MarkTraceur: jquery.autoEllipsis: Add lines option [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [17:38:44] (03PS4) 10Anomie: Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 [17:38:49] (03Restored) 10Zsaigol: Special:ListUsers: add a dropdown option to filter by blocked status [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [17:38:55] (03Restored) 10Chad: Disable rule Squiz.WhiteSpace.OperatorSpacing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/93450 (owner: 10Siebrand) [17:39:00] (03CR) 10Chad: [C: 032] Disable rule Squiz.WhiteSpace.OperatorSpacing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/93450 (owner: 10Siebrand) [17:39:01] (03PS5) 10Anomie: Improve UI for page protection with $wgNamespaceProtection [core] - 10https://gerrit.wikimedia.org/r/71539 [17:39:43] (03Restored) 10Chad: Add close elements through code [core] - 10https://gerrit.wikimedia.org/r/88500 (owner: 10Siebrand) [17:39:48] (03CR) 10Chad: [C: 032] Add close elements through code [core] - 10https://gerrit.wikimedia.org/r/88500 (owner: 10Siebrand) [17:40:02] (03PS6) 10Zsaigol: Special:ListUsers: add a dropdown option to filter by blocked status [core] - 10https://gerrit.wikimedia.org/r/79041 [17:40:23] (03CR) 10Anomie: "PS4: Rebase" [core] - 10https://gerrit.wikimedia.org/r/71539 (owner: 10Anomie) [17:41:10] (03Restored) 10Chad: Declare visibility on Autoloader::$autoloadLocalClassesLower [core] - 10https://gerrit.wikimedia.org/r/94157 (owner: 10Siebrand) [17:42:00] (03PS2) 10Chad: Declare visibility on Autoloader::$autoloadLocalClassesLower [core] - 10https://gerrit.wikimedia.org/r/94157 (owner: 10Siebrand) [17:42:14] (03CR) 10Chad: [C: 032] Declare visibility on Autoloader::$autoloadLocalClassesLower [core] - 10https://gerrit.wikimedia.org/r/94157 (owner: 10Siebrand) [17:42:36] (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 (owner: 10CSteipp) [17:43:01] (03Restored) 10Chad: Remove underscore from CdbReader_[DBA|PHP] classes and related file [core] - 10https://gerrit.wikimedia.org/r/94133 (owner: 10Siebrand) [17:45:19] (03PS7) 10Zsaigol: Special:ListUsers: add a dropdown option to filter by blocked status [core] - 10https://gerrit.wikimedia.org/r/79041 [17:45:30] MatmaRex: there you go. Just tested in IE6 and it looks fine ^ [17:45:37] (03PS1) 10Jdlrobson: Hygiene: Cleanup IE6 specific rules by using * hack [core] - 10https://gerrit.wikimedia.org/r/94163 [17:45:40] ^ rather :) [17:45:43] (03Merged) 10jenkins-bot: Move files with tests to reflect the code [core] - 10https://gerrit.wikimedia.org/r/94158 (owner: 10Siebrand) [17:46:08] jdlrobson: yay, thanks [17:46:25] np thanks for sorting out the wikiGetlink function [17:46:59] (03CR) 10Anomie: [C: 032] "Code works, bug fixed. I'll trust you on the documentation bits." [core] - 10https://gerrit.wikimedia.org/r/94161 (owner: 10Krinkle) [17:48:03] (03CR) 10Zsaigol: [C: 04-1] "Patch set 6: better attempt at rebase" [core] - 10https://gerrit.wikimedia.org/r/79041 (owner: 10Zsaigol) [17:49:01] jdlrobson: huh, these rules for span>a at the bottom are weird [17:49:15] MatmaRex: i missed one? [17:49:25] i don't think you did [17:49:30] it's just weird [17:49:32] line 205 onward [17:49:38] only float on not-IE6? wat? [17:49:57] (03Merged) 10jenkins-bot: Break long lines [core] - 10https://gerrit.wikimedia.org/r/94159 (owner: 10Siebrand) [17:50:09] that makes no sense [17:50:11] at all [17:50:16] (not your faul, of course) [17:50:43] MatmaRex: yeh that is pretty strange…. Mm… i wonder where it comes from [17:51:19] actually, most of these hacks are really weird [17:51:31] setting inline-block for IE6 [17:51:36] on enwiki it has no effect [17:51:37] it doesn't even support that rule! [17:51:53] remove it on the Talk tab [17:51:57] (it can be emulated by display:inline;zoom:1, which is what i thought these hacks were actually doin) [17:51:59] doing* [17:52:00] and see that float: left seems to be doing nothing [17:52:14] maybe it's a workaround for some obscure IE RTL bugs [17:52:26] * jdlrobson tries he wiki [17:52:39] nope removing both those rules does nothing [17:52:40] i know that applying float:right in RTL mode can potentially cause things to render a few thousand pixels offscreen [17:52:55] MatmaRex: i think you found dead code personally :) [17:53:00] this is why LESS is nice :) [17:53:12] (learn that when wrestling with https://bugzilla.wikimedia.org/show_bug.cgi?id=46947) [17:53:14] meh [17:53:26] that is why somebody actually maintaining the code from time to time is nice [17:53:52] vector has way more bytes of CSS than it reasonably should [17:54:08] (03CR) 10Jdlrobson: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94163 (owner: 10Jdlrobson) [17:54:12] i always though half of it isn't needed [17:54:14] (03CR) 10Krinkle: "For the record: Star hack also applies to IE7. Haven't verified if that's a problem, but it might be." [core] - 10https://gerrit.wikimedia.org/r/94163 (owner: 10Jdlrobson) [17:54:24] (or works around obscure minor IE6 rendering glitches) [17:55:02] (03CR) 10Bartosz Dziewoński: "We're just talking about how bizarre this code is on IRC. Please do chime in :)" [core] - 10https://gerrit.wikimedia.org/r/94163 (owner: 10Jdlrobson) [17:55:22] MatmaRex: jdlrobson: Open it in IE6 to find out. I think Trevor made it so that the fallback is blocks of that are floated to the left [17:55:25] (03PS1) 10Matthias Mullie: Design changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94165 [17:55:36] which is the "other" way to simulate inline-block, floating collapses the width [17:55:55] and puts them next to each other. [17:56:02] is it time to blacklist styles from IE6 yet? :) [17:56:05] we did it for Netscape 4 years ago [17:56:20] Krinkle: what i wonder is why do we have two versions if floating would also work for sane browsers [17:56:24] It does seem unusual might but might be better in this case than inline blocks. Depends on the layout. [17:56:34] MatmaRex: double-margin bug maybe [17:56:44] anyway, try it and find out :) [17:56:45] that has a simple workaround, doesn't it? [17:56:54] this is a simple workaround, too. [17:57:19] no, this is a crappy-ass byzantine workaround [17:57:20] (03Merged) 10jenkins-bot: Add close elements through code [core] - 10https://gerrit.wikimedia.org/r/88500 (owner: 10Siebrand) [17:57:30] the simple workaround is adding "display:inline" to the floated element [17:57:35] (not kidding, it works) [17:58:44] (03CR) 10Matthias Mullie: "I'm just puzzled by these changes in the "hacky" patch, so I've ignored them (for now):" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94165 (owner: 10Matthias Mullie) [18:00:02] jdlrobson: this is why i suggested we do cleanup first, making sense of the hacks after we convert them to less will be an infinitely larger pain in the ass :( [18:01:22] MatmaRex: with git blame we can work out why a lot of these things exist and document them better going forward. I think the cleanup can happen via LESS rewriting :) [18:01:56] jdlrobson: well, if you're willing to be the one to wield the broom, be my guest ;) [18:04:06] (03CR) 10Anomie: "Jenkins?" [core] - 10https://gerrit.wikimedia.org/r/94161 (owner: 10Krinkle) [18:04:12] (03CR) 10Anomie: [C: 032] Migrate usage of wikibits in legacy protect.js and upload.js [core] - 10https://gerrit.wikimedia.org/r/94161 (owner: 10Krinkle) [18:04:22] (03Merged) 10jenkins-bot: Declare visibility on Autoloader::$autoloadLocalClassesLower [core] - 10https://gerrit.wikimedia.org/r/94157 (owner: 10Siebrand) [18:05:08] AndyRussG: weird, looks like the gate-and-submit pipeline isn't running [18:05:39] Hi, Krinkle [18:05:46] <^d> Krinkle: For all jobs? [18:05:48] What's the gate-and-submit pipeline? [18:05:51] <^d> I just merged a few things. [18:06:17] anomie: ^ [18:06:40] AndyRussG: i think you were a victim of incorrect tab completion ;) [18:06:44] ^d: Change 94161 seems to not be attracting Jenkins' attention [18:06:46] !tabcompletion [18:06:47] Instead of manually typing another person's nickname in IRC, you can type the beginning of their name and hit TAB on your keyboard to get it autocompleted, like on the command line. This avoids misspellings. Just make sure it's the right person! [18:07:11] <^d> anomie: [18:07:13] <^d> Patch Set 5: -Verified [18:07:13] <^d> Starting gate-and-submit jobs. [18:07:13] <^d> https://integration.wikimedia.org/zuul/ [18:07:16] ^d: Oh, there it goes. Or did you fix it? [18:07:31] it was probably busy with other changes? [18:07:33] MatmaRex: Awwww [18:07:36] https://gerrit.wikimedia.org/r/94157 was just merged [18:07:40] <^d> Patience is a virtue :p [18:09:29] (03Merged) 10jenkins-bot: Migrate usage of wikibits in legacy protect.js and upload.js [core] - 10https://gerrit.wikimedia.org/r/94161 (owner: 10Krinkle) [18:12:00] csteipp: Congrats, you're a project admin on the Multimedia labs project, our shit is at multimedia-alpha.pmtpa.wmflabs [18:12:57] MediaWiki is in /srv/mediawiki, managed by puppet or something, but mostly I ignore that and dump things into orig/LocalSettings.php and the extensions/ directory to better make YuviPanda|away cringe [18:15:51] so cruel. [18:16:05] ugh: It's how we roll [18:16:32] It's how we troll* [18:17:40] (03CR) 10MaxSem: "(1 comment)" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [18:20:51] (03CR) 10MaxSem: "Adding Sean to figure out if this is worth the effort to be run in prod or we can avoid renaming the indexes altogether (but this can get " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/40095 (owner: 10Dereckson) [18:21:40] is there a way to force git to mark a file as renamed? If too many lines have changed, it will always be displayed as Added/Deleted instead of Renamed [18:22:45] Danwe: when running `git log` and friends you can use an option to change the "similarity threshold" used for detecting file renames [18:23:39] Danwe: when doing a complicated merge there's some arcane dark magic low-level incantations that are supposed to make git understand what is what, but it didn't work for me the single time i tried [18:24:14] MatmaRex: thanks. But I guess that's no good for most use cases (e.g. code review on gerrit). Do you have a link to this dark magic :D ? [18:24:25] ori-l: Ping re https://gerrit.wikimedia.org/r/94092 [18:24:49] RoanKattouw: oh! I meant to review that. Doing so now. [18:24:50] Danwe: Use -M [18:24:57] Danwe: (the log option is -M%, aka --find-renames) [18:25:08] (03CR) 10EBernhardson: "Semi-related to this, two indexes in Echo were previously named but never changed in production. A bug is still outstanding on that, neve" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/40095 (owner: 10Dereckson) [18:25:24] Danwe: nope, i googled it, tried it and forgotten about it :) [18:25:32] can be a percentage, out a number from 1-10, or whatever. Lower numbers make the rename detection more aggressive (the number is a similarity threshold) [18:25:42] -out [18:25:53] "If generating diffs, detect and report renames for each commit. For following files across renames while traversing history, see --follow. If n is specified, it is a threshold on the similarity index (i.e. amount of addition/deletions compared to the file’s size). For example, -M90% means git should consider a delete/add pair to be a rename if more than 90% of the file hasn’t changed." [18:25:55] yay manpages [18:27:34] RoanKattouw: when would you need this reviewed by? The code looks fine, if there's time I'd like to quibble a little with the namespacing [18:27:44] Please quibble [18:27:54] ori-l: Ideally for LD today, I suppose? [18:28:03] event names should in l33t sp34k, for one [18:28:10] k, that's plenty of time [18:31:10] csteipp: ping [18:32:19] (03CR) 10CSteipp: "Sorry for the late comment on this, but yeah, if the whole thing is output with htmlspecialchars there, it should be sufficient to prevent" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [18:36:54] hoo|away: pong... whenever you get back [18:41:21] (03PS2) 10Anomie: Just like in getContentObject(), use anon-specific text if user is anon [core] - 10https://gerrit.wikimedia.org/r/83915 (owner: 10Matthias Mullie) [18:41:27] (03PS3) 10Anomie: Use anon-specific text in Article::showMissingArticle [core] - 10https://gerrit.wikimedia.org/r/83915 (owner: 10Matthias Mullie) [18:41:43] (03CR) 10Anomie: [C: 032] "Sensible, and works as advertised." [core] - 10https://gerrit.wikimedia.org/r/83915 (owner: 10Matthias Mullie) [18:43:16] (03PS4) 10Matthias Mullie: Copy tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 [18:47:57] (03Merged) 10jenkins-bot: Use anon-specific text in Article::showMissingArticle [core] - 10https://gerrit.wikimedia.org/r/83915 (owner: 10Matthias Mullie) [18:51:01] (03PS1) 10Catrope: Add .gitreview [oojs/core] - 10https://gerrit.wikimedia.org/r/94177 [18:51:06] Krinkle: ----^^ [18:51:07] csteipp: Hey :) That was bit of an unlucky timing [18:51:33] going to PM [18:53:10] (03CR) 10Anomie: [C: 032] Add rc.unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91844 (owner: 10Krinkle) [18:53:35] (03CR) 10Krinkle: [C: 032] Add .gitreview [oojs/core] - 10https://gerrit.wikimedia.org/r/94177 (owner: 10Catrope) [18:53:45] RoanKattouw: Oh, we need access control and jenkins. [18:53:56] (03CR) 10Krinkle: [V: 032] Add .gitreview [oojs/core] - 10https://gerrit.wikimedia.org/r/94177 (owner: 10Catrope) [18:54:07] RoanKattouw: I don't have a merge button [18:54:12] but I do have Verified+2 [18:54:19] looks like a weird hybrid fluke in the acl [18:55:11] (03PS1) 10MaxSem: Fix OpenSearchXml integration [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/94178 [18:55:39] Krinkle: Without setting up Jenkins I'm not sure that's gonna go anywhere on its own [18:56:23] You didn't have Publish and Submit? [18:56:23] RoanKattouw: I'd like you to do the jenkins-jobs set up. Should be relatively simple since we can re-use everything. Both because 1) then you'll know and 2) I'll be intermittently available [18:56:25] (03Merged) 10jenkins-bot: Add rc.unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91844 (owner: 10Krinkle) [18:56:33] Yeah I need to learn how to do that [18:56:45] RoanKattouw: apparantly not, did you create the repo? [18:56:52] I did [18:56:55] https://gerrit.wikimedia.org/r/#/admin/projects/oojs,access [18:57:00] The ACL is super simple, and you're a project owner [18:57:09] The ACL for oojs/core is literally empty [18:57:22] And you're an owner of oojs based on both being in the oojs group and being in ldap/wmf [18:57:33] well.. [18:57:54] Is submit not granted to owners by default? [18:58:02] Maybe [18:58:07] I mean if we get Jenkins set up I suppose it doesn't matter [18:58:18] And we can revoke V+2 and V+1 from humans [18:58:38] added Submit / +oojs [18:58:42] k [18:58:51] Yep, that did it [18:59:00] You wanna walk me through the Jenkins setup for oojs/core so I can then do oojs/ui as well? [18:59:05] Yep [18:59:31] RoanKattouw: For oojs-ui, be sure to add (or keep) authors/license as well. [18:59:39] Yup, already done [18:59:39] anyhow, for jenkins: [18:59:43] but not published yet [18:59:57] in jenkins-job-builder-config.git, set up oojs-core and oojs-ui [19:00:22] you should be able to use the same macros as we use for VE's pipeline [19:01:02] Although we'll need different handling for qunit because we can't do mw-setup and Special:JavaScriptTest, obviously [19:01:54] I could do that later, I'd recommend you just set up the check/test/gate-and-submit pipeline with jshint only for starters so we have the basic thign going and V+2/merge stuff. [19:02:38] OK [19:02:43] RoanKattouw: Create a new yaml file similar to integration.yaml, parsoid.yaml, translatewiki.yaml for oojs [19:03:26] (03PS1) 10Aude: Update Wikibase, fixes issues with references caught by selenium tests [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94180 [19:05:01] RoanKattouw: Most if not all of them have something weird or special, there is no clean example unfortunately. [19:05:41] I can only find -doc-publish and -doc-test [19:05:55] Those are the only matches for VisualEditor in mediawiki-extensions.yaml [19:06:30] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, fixes issues with references caught by selenium tests [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94180 (owner: 10Aude) [19:06:32] RoanKattouw: in zuul-config.git:/layout.yaml, on the bottom add a section for oojs/core and oojs/ui, both with check/test/gate-and-submit pipeline running oojs-core-jslint / oojs-ui-jslint [19:07:07] There is no layout.yaml [19:07:36] Oh, in zuul-config [19:07:47] OK so I'm still stuck on the jenkins config one [19:07:49] in jenkins-job-builder-config.git those two jobs need to exist. So in oojs.yaml you'd create 2 plain "job" objects with those 2 names and in the .builders property call the generic jslint macro [19:08:14] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/macro.yaml#L69-L73 [19:08:18] OK [19:08:21] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/mediawiki.yaml#L200-L221 [19:08:29] the latter is an example of a simple job [19:08:54] so in the new jjb-config/oojs.yaml file you'd have two job:s for oojs-core-jshint and oojs-uit-jshint that basically just list the jshint macro [19:08:59] in .builders [19:09:57] Actually, it might not even need that [19:10:11] le me check, I think we abstracted it into a generic job template that we can use directly [19:10:36] Yep [19:10:37] https://github.com/wikimedia/integration-jenkins-job-builder-config/blob/master/job-templates.yaml#L13-L22 [19:10:37] Yeah we did [19:10:45] I'm looking at operations-mw-config.yaml for guidance [19:11:00] So no need for a job or job-template for oojs-core-jshint, it can be created directly. [19:11:52] OK, so let me verify this [19:12:28] RoanKattouw: so in oojs.yaml, a project: 'oojs' (freeform, only used in the {name} later), and jobs: {name}-core-jslint and {name}-uit-jslint [19:12:34] Right [19:12:37] - project: [19:12:39] name: 'oojs' [19:12:40] jobs: [19:12:42] - '{name}-jslint' [19:12:53] Is what I had, but I guess I need both '{name}-core-jslint' and '{name}-ui-jslint' [19:13:05] Or really really what I need is a way to list the subprojects and jobs separately [19:13:08] mw-extensions does this [19:14:05] then those need to be comitted locally and pushed to gerrit (don't merge yet), then follow [[mw:CI/JJB]] for instructions on how to generate and deploy the actual Jenkins jobs. Once that's done (they'll exist on Jenkins but nothing will trigger them yet), merge the jjb-config commit (the repo is essentially a log). [19:14:27] Then the trigger in zuul-config.git, see [[mw:CI/Z]] for details on deploy for that. [19:14:57] (03PS1) 10Catrope: Add jobs for oojs/core and oojs/ui [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94181 [19:14:57] If there's any step where you need rights (the deploy might require Antoine, Chad or me to do it), just let me know and I'll run the neccecary command. [19:15:37] OK [19:16:02] Please review that patchset ---^^ and let me know if there's a way that I can list the projects (ui and core) and jobs (jslint and more in the future) separately so we don't need to list all NxM combinations [19:16:06] (03CR) 10Siebrand: [C: 031] "Still have my reservations about terminology ("topic" and "discussion"), but nothing to block over." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [19:16:08] RoanKattouw: I think it won't work like that. My mistake. [19:16:17] RoanKattouw: Need a separate project for oojs-core and oojs-ui in jjb-config [19:16:22] I see, OK [19:16:41] the job name {name}-core-jslint won't resolve I think. yeah. [19:16:55] k [19:17:02] <^d> Krinkle: Heh, I may have access but I haven't touched jenkins in forever. [19:17:07] <^d> 'cept to poke replication from gerrit [19:17:30] (03PS2) 10Catrope: Add jobs for oojs/core and oojs/ui [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94181 [19:18:11] RoanKattouw: yeah, that should be fine. Let me know if that passes the jjb validation [19:19:02] Still doing the zuul thing [19:20:35] Krinkle: Don't we also want jsduck jobs here? [19:21:13] I suppose we can do that later [19:21:14] Yeah, but not sure if we have generic enough macros for that. Besides, oojs requires JSDuck 5.x atm. [19:21:27] but getting the pipelines themselves set' up is going to be the most work. [19:22:11] (03PS1) 10Catrope: Add pipelines for oojs-core and oojs-ui [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94182 [19:24:18] Krinkle: Is Ps2 of that JJB-config change good enough for me to run the builder with? [19:24:44] RoanKattouw: Yeah, try to expand the jobs from yaml to xml locally and see if that works. [19:25:19] so the jjb-cli 'test' option, not 'update'. [19:25:28] WTF [19:25:36] (03PS1) 10Chad: Update Cirrus to master (64fab3d2) [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94183 [19:25:46] So, I ran develop.py as root, and that worked after I installed libyaml-dev. But develop.py --user as me fails with a permissions error [19:25:52] if it outputs no errors and output/oojs-core-jslint.xml is created and looks sane upon inspection, go ahead and set up auth and push it to jenkins. [19:26:54] Oh, wait, am I meant to run only one of those two [19:30:25] RoanKattouw: which? [19:30:39] nm I got it [19:30:45] Now going to get an API token [19:30:49] yeah, that's confusing [19:33:01] RoanKattouw: https://www.mediawiki.org/w/index.php?title=Continuous_integration%2FJenkins_job_builder&diff=815575&oldid=811023 [19:33:18] thanks [19:33:26] (03CR) 10Chad: [C: 032] "I wonder how many callers aren't using factory() yet. It would be really nice to make these constructors protected." [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [19:34:17] Krinkle: OK I'm going to install the jobs now [19:34:24] (03CR) 10Chad: [V: 032] Disable rule Squiz.WhiteSpace.OperatorSpacing [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/93450 (owner: 10Siebrand) [19:34:41] jenkins-jobs --config etc/jenkins_jobs.ini update config/ oojs-core right? [19:35:16] RoanKattouw: You'll have to run it twice, once for each job. [19:35:22] Yeah sure [19:35:25] Unless it supports a prefix for the job name like that [19:35:31] But that's the command line for it, right? [19:35:35] Yes [19:35:43] for job in oojs-core oojs-ui; do jenkins-jobs .... $job; done [19:35:58] -jslint [19:36:15] meh [19:36:20] Also, s/--config/--conf/ [19:36:23] (03Merged) 10jenkins-bot: Cleaned up DatabaseBase constructor to use an array [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [19:36:50] RoanKattouw: Eh, no, not if you did it right. [19:37:01] config/ should be a symlink to your jjb-config.git clone [19:37:10] No, the flag is called --conf not --config [19:37:20] The directory (symlink in my case) is called config [19:37:23] https://www.mediawiki.org/wiki/CI/JJB#Deploy_changes [19:37:30] jenkins.JenkinsException: create[oojs-core-jslint] failed [19:37:31] $ jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'mediawiki-core-jslint' [19:37:44] Yeah it's correct in the docs [19:37:46] I typed it wrong [19:37:48] Also, it failed :( [19:38:03] Does the file exist in output/? What username did you use in the ini? [19:38:10] username=catrope [19:38:34] And yes it exists in output/ [19:38:45] RoanKattouw: Try user=jobbuilder-bot instead. [19:38:52] k [19:38:55] For some reason the right delegation doesn't work for non-bot users in Jenkins. [19:38:59] (update token of course) [19:39:03] url=https://integration.wikimedia.org/ci/ [19:39:33] Oh, also, ini formatting fail [19:39:35] [jenkins] [19:39:37] [jenkins] [19:39:59] ? [19:40:24] I had [jenkins] in there twice [19:40:32] Meh it still failed [19:40:54] The URL is right, I have user=jobbuilder-bot and got a token for it instead of me [19:43:34] RoanKattouw: Can you gist/paste the one of the xml files? [19:43:56] Trying again with a trailing newline in the .ini file [19:44:02] Still crashed [19:44:05] Will gist the XML files [19:45:35] Krinkle: https://gist.github.com/catrope/7360719 [19:46:48] RoanKattouw: k [19:47:00] I'm gonna try to push a no-op to see if it works here [19:47:26] (03Abandoned) 10Umherirrender: Use always content language for localized ContentModel [core] - 10https://gerrit.wikimedia.org/r/84138 (owner: 10Umherirrender) [19:47:40] RoanKattouw: try [19:47:41] jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'mediawiki-core-jslin [19:47:43] jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'mediawiki-core-jslint' [19:48:10] That worked [19:48:32] interesting [19:50:31] RoanKattouw: And all you get is that one error line? [19:50:47] No, I get a traceback to [19:50:50] o [19:50:52] But with no specifics [19:50:54] Will pastebin [19:51:06] k [19:51:25] http://pastebin.com/fWVGicy2 [19:51:52] I guess I didn't put single quotes around the job name but that shouldn't matter [19:52:13] and indeed it doesn't [19:53:10] RoanKattouw: 've never seen that, maybe try a more detailed log level (see jjb --help) [19:53:26] h [19:53:27] k [19:53:39] log_level defaults to INFO [19:53:45] Doesn't tell me what other options I have [19:55:35] RoanKattouw: yeah, not sure what it is. documentation seems to suggest that it is a pythonism, so we;re supposed to know what the options are [19:56:02] wiki page says -l debug [19:56:07] k [19:56:46] lot of output but the relevant bit seems to be: [19:56:49] DEBUG:jenkins_jobs.builder:XMLifying project 'oojs-core' [19:56:50] DEBUG:jenkins_jobs.builder:Generating XML for template job {name}-jslint (params {'': '', 'jobs': ['{name}-jslint'], 'name': 'oojs-core'}) [19:59:29] Then after some more unrelated DEBUG stuff I get the same traceback [20:03:29] (03CR) 10Chad: [C: 032] Update Cirrus to master (64fab3d2) [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94183 (owner: 10Chad) [20:04:16] RoanKattouw: fetching your patch locally now [20:06:32] (03Merged) 10jenkins-bot: Update Cirrus to master (64fab3d2) [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94183 (owner: 10Chad) [20:07:05] (03PS1) 10BryanDavis: Support CIDR ranges in $wgSquidServersNoPurge [core] - 10https://gerrit.wikimedia.org/r/94186 [20:08:34] (03PS2) 10BryanDavis: Support CIDR ranges in $wgSquidServersNoPurge [core] - 10https://gerrit.wikimedia.org/r/94186 [20:08:56] RoanKattouw: wfm [20:09:28] https://gist.github.com/Krinkle/0381f96bdf68858b74b3 [20:09:53] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94186 (owner: 10BryanDavis) [20:09:57] OK, weird [20:10:01] Could you do the oojs-ui one too then? [20:10:06] Cause then I can proceed with zuul [20:10:17] (03PS7) 10Aude: Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 [20:10:40] RoanKattouw: done [20:10:42] dinner, brbl [20:10:57] thx [20:11:03] (03CR) 10Krinkle: [C: 032] "Deployed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94181 (owner: 10Catrope) [20:12:06] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/94186 (owner: 10BryanDavis) [20:12:48] Krinkle|detached: Can haz merge of zuul-config commit? [20:13:32] (03CR) 10BryanDavis: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94186 (owner: 10BryanDavis) [20:14:47] (03PS3) 10BryanDavis: Support CIDR ranges in $wgSquidServersNoPurge [core] - 10https://gerrit.wikimedia.org/r/94186 [20:15:40] (03Merged) 10jenkins-bot: Add jobs for oojs/core and oojs/ui [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94181 (owner: 10Catrope) [20:21:50] PHP Warning: Missing argument 3 for FlaggedRevsXML::pendingEditNoticeMessage(), called in /usr/local/apache/common-local/php-1.23wmf3/extensions/FlaggedRevs/frontend/FlaggedRevsXML.php on line 423 and defined in /usr/local/apache/common-local/php-1.23wmf3/extensions/FlaggedRevs/frontend/FlaggedRevsXML.php on line 430 [20:22:20] He said FlaggedRevs! :P [20:22:37] Krinkle|detached: I've now pushed the oojs-ui repo and I've got some changes lined up but I'm waiting for you to finish the zuul stuff before I submit those, so we can test zuul [20:35:53] (03CR) 10Parent5446: [C: 031] Support CIDR ranges in $wgSquidServersNoPurge [core] - 10https://gerrit.wikimedia.org/r/94186 (owner: 10BryanDavis) [20:41:16] Reedy: On it. [20:42:38] siebrand: Thanks. I opened a bug for it too [20:42:58] Krinkle|detached: you and your stupid deprecations :( https://pl.wikipedia.org/w/index.php?title=Specjalna:Wk%C5%82ad/Matma_Rex&offset=&limit=20&target=Matma+Rex [20:43:00] WebRTC IETF working group will be making a codec selection decision (VP8 vs H.264) today -- meeting is open to participation via xmpp chat. agenda: http://tools.ietf.org/wg/rtcweb/agenda?item=agenda-88-rtcweb.html [20:44:12] (03PS1) 10Siebrand: Fix incorrect call to pendingEditNoticeMessage [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/94233 [20:44:27] Reedy: https://gerrit.wikimedia.org/r/94233 [20:47:03] (03CR) 10Chad: [C: 032] Add Elasticsearch version to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [20:47:09] (03Merged) 10jenkins-bot: Add Elasticsearch version to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [20:52:49] (03PS1) 10Anomie: Migrate usage of wikibits in legacy protect.js and upload.js [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94235 [20:53:14] (03PS1) 10Anomie: Migrate usage of wikibits in legacy protect.js and upload.js [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94236 [20:54:01] (03PS1) 10Aaron Schulz: WIP: Improve "adviseStat" performance [core] - 10https://gerrit.wikimedia.org/r/94237 [20:57:05] (03CR) 10Aaron Schulz: [C: 032 V: 032] Fix incorrect call to pendingEditNoticeMessage [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/94233 (owner: 10Siebrand) [20:58:42] MatmaRex: Thx, though do note that these have been deprecated in 2010 in MediaWiki 1.17 ;-) [20:59:19] Krinkle: but they didn't have warnings :( [21:00:28] MatmaRex: Yep. I'm aware. Hence why we will have them from now on out. [21:03:50] (03CR) 10Anomie: [C: 032] "Backport fix." [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94235 (owner: 10Anomie) [21:04:00] (03CR) 10Anomie: [C: 032] "Backport fix." [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94236 (owner: 10Anomie) [21:07:09] (03Merged) 10jenkins-bot: Migrate usage of wikibits in legacy protect.js and upload.js [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94235 (owner: 10Anomie) [21:08:42] (03Merged) 10jenkins-bot: Migrate usage of wikibits in legacy protect.js and upload.js [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94236 (owner: 10Anomie) [21:09:21] (03CR) 10Reedy: "Probably should backport and deploy this fairly soon!" [core] - 10https://gerrit.wikimedia.org/r/94186 (owner: 10BryanDavis) [21:09:50] (03CR) 10Chad: [C: 032] Remove deprecated ChangesList::newFromUser function [core] - 10https://gerrit.wikimedia.org/r/94083 (owner: 10Aude) [21:10:42] (03Restored) 10Chad: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [21:12:21] (03CR) 10Bartosz Dziewoński: [C: 032] Remove use of deprecated ChangesList function [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/94082 (owner: 10Aude) [21:12:37] (03CR) 10Bartosz Dziewoński: [V: 032] Remove use of deprecated ChangesList function [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/94082 (owner: 10Aude) [21:14:01] (03Merged) 10jenkins-bot: Remove deprecated ChangesList::newFromUser function [core] - 10https://gerrit.wikimedia.org/r/94083 (owner: 10Aude) [21:18:32] (03PS3) 10Chad: Remove underscore from CdbReader_[DBA|PHP] classes and related file [core] - 10https://gerrit.wikimedia.org/r/94133 (owner: 10Siebrand) [21:19:03] (03CR) 10Chad: [C: 032] Remove underscore from CdbReader_[DBA|PHP] classes and related file [core] - 10https://gerrit.wikimedia.org/r/94133 (owner: 10Siebrand) [21:23:24] (03Merged) 10jenkins-bot: Remove underscore from CdbReader_[DBA|PHP] classes and related file [core] - 10https://gerrit.wikimedia.org/r/94133 (owner: 10Siebrand) [21:27:34] csteipp: Saw my PMs? [21:32:37] (03PS7) 10Siebrand: Address some PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 [21:34:34] (03CR) 10Hashar: [C: 031] "I am sleeping, but anyone with with access on gallium and ability to sudo as jenkins can deploy this. Doc at https://www.mediawiki.org/wi" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94182 (owner: 10Catrope) [21:35:53] (03PS1) 10Siebrand: Declare visibility on class property [core] - 10https://gerrit.wikimedia.org/r/94238 [21:39:23] (03PS1) 10JanZerebecki: Actually trigger mwext-MobileFrontend-phpcs-HEAD . [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94239 [21:42:17] (03PS1) 10Siebrand: Declare visibility on class properties [core] - 10https://gerrit.wikimedia.org/r/94240 [21:45:36] (03PS7) 10EBernhardson: [WIP] Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [21:48:33] (03CR) 10JanZerebecki: "Why does this change also make zuul-layoutdiff show a change to mediawiki-core-regression-phpcs-HEAD without changing anything like that i" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94239 (owner: 10JanZerebecki) [21:50:44] (03PS1) 10Jdlrobson: Create prepareTemplate function [core] - 10https://gerrit.wikimedia.org/r/94248 [21:51:14] (03CR) 10Chad: [C: 032] Address some PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [21:51:48] (03CR) 10Chad: [C: 032] Declare visibility on class properties [core] - 10https://gerrit.wikimedia.org/r/94240 (owner: 10Siebrand) [21:51:55] (03CR) 10Chad: [C: 032] Declare visibility on class property [core] - 10https://gerrit.wikimedia.org/r/94238 (owner: 10Siebrand) [21:57:13] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94102 (owner: 10Werdna) [21:59:27] (03Merged) 10jenkins-bot: Address some PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/93442 (owner: 10Siebrand) [22:02:47] (03Merged) 10jenkins-bot: Declare visibility on class properties [core] - 10https://gerrit.wikimedia.org/r/94240 (owner: 10Siebrand) [22:02:48] (03Merged) 10jenkins-bot: Declare visibility on class property [core] - 10https://gerrit.wikimedia.org/r/94238 (owner: 10Siebrand) [22:05:03] Krinkle: Hey I'm back from metrics lunch [22:05:16] Krinkle: You wanna merge my zuul-config change so i [22:05:19] can deploy ti? [22:05:23] metrics indigestion [22:05:42] RoanKattouw: k [22:06:41] (03PS1) 10Bartosz Dziewoński: wikibits: Add some missing deprecation messages [core] - 10https://gerrit.wikimedia.org/r/94251 [22:07:14] (03PS1) 10Siebrand: Set visibility of class properties of HashtableReplacer [core] - 10https://gerrit.wikimedia.org/r/94252 [22:07:15] (03PS1) 10Siebrand: Set visibility on class properties of ReplacementArray [core] - 10https://gerrit.wikimedia.org/r/94253 [22:07:16] (03PS1) 10Siebrand: Set visibility on class properties of ExplodeIterator [core] - 10https://gerrit.wikimedia.org/r/94254 [22:07:17] (03PS1) 10Siebrand: Set visibility for class property of RegexlikeReplacer [core] - 10https://gerrit.wikimedia.org/r/94255 [22:08:56] (03PS1) 10Bartosz Dziewoński: Migrate usage of wikibits in legacy protect.js and upload.js [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94256 [22:09:08] (03CR) 10Krinkle: [C: 031] wikibits: Add some missing deprecation messages [core] - 10https://gerrit.wikimedia.org/r/94251 (owner: 10Bartosz Dziewoński) [22:09:29] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94256 (owner: 10Bartosz Dziewoński) [22:10:00] RoanKattouw: Verifying a few things about the zuul change [22:10:20] (03CR) 10Krinkle: [C: 032] Add pipelines for oojs-core and oojs-ui [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94182 (owner: 10Catrope) [22:11:03] (03PS1) 10Chad: Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 [22:12:06] (03CR) 10Chad: "Can we do this since we're keeping the ID? :)" [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [22:13:43] (03CR) 10Bartosz Dziewoński: "Followups: https://gerrit.wikimedia.org/r/#/c/94161/ , https://gerrit.wikimedia.org/r/#/c/94251/" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92788 (owner: 10Krinkle) [22:14:27] gah, wrong branch. [22:14:30] (03CR) 10Bartosz Dziewoński: "Followups: https://gerrit.wikimedia.org/r/#/c/94161/ , https://gerrit.wikimedia.org/r/#/c/94251/" [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [22:15:14] ^d: #-comments? blasphemer [22:15:16] Krinkle: https://gerrit.wikimedia.org/r/#/c/94182/ ---> that repo doesn't have gate-and-submit apparently so you're gonna have to merge it manually [22:15:46] <^d> MatmaRex: Meh [22:16:04] RoanKattouw: uh, I should know. Thx [22:16:10] RoanKattouw: what's the motivation for having the save dialog be the first component of the name? [22:16:28] ori-l: I don't know, it was late and I needed to come up with something. I'm happy to defer to you on the naming scheme [22:16:49] I suppose I did that because we're timing various facets of how the user interacts with the save dialog, that's what these events had in common [22:17:08] The ones that measure actual request timings are performance.dom* [22:17:24] (03CR) 10Krinkle: [C: 032] wikibits: Add some missing deprecation messages [core] - 10https://gerrit.wikimedia.org/r/94251 (owner: 10Bartosz Dziewoński) [22:17:47] (03PS2) 10Gergő Tisza: Handle multiple license templates [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94088 [22:18:08] Krinkle: thanks. just wondering, will you be deploying that? [22:18:19] (also, needs backport like the other ones) [22:18:32] MatmaRex: To REL, yes, not to wmf right now (at least not by me). [22:18:49] (03CR) 10Chad: [C: 032] Set visibility of class properties of HashtableReplacer [core] - 10https://gerrit.wikimedia.org/r/94252 (owner: 10Siebrand) [22:19:06] (03PS1) 10Krinkle: wikibits: Add some missing deprecation messages [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94261 [22:19:17] (03CR) 10Krinkle: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94261 (owner: 10Krinkle) [22:19:24] (03PS2) 10Jdlrobson: Create prepareQuickTemplate function [core] - 10https://gerrit.wikimedia.org/r/94248 [22:19:45] (03CR) 10Bartosz Dziewoński: [C: 032] Remove stupid one-cell table [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [22:21:00] (03PS1) 10Catrope: Add .gitreview [oojs/ui] - 10https://gerrit.wikimedia.org/r/94262 [22:21:33] (03CR) 10Krinkle: [C: 032 V: 032] Add .gitreview [oojs/ui] - 10https://gerrit.wikimedia.org/r/94262 (owner: 10Catrope) [22:21:59] Krinkle: Dude [22:22:03] Oh, right. [22:22:13] Zuul, and all that [22:22:21] It'll still show up if it worked. [22:22:28] but it would've been nice to have more than 1 try. [22:22:28] It's in "queue only mode" right now [22:22:31] "Queue only mode: preparing to reconfigure, queue length: 49" [22:22:39] Krinkle: I have two other commits [22:22:50] But I'm only submitting those once that "queue only mode" message disappears [22:22:57] And please don't immediately merge or even +2 those ;) [22:23:06] RoanKattouw: kk [22:23:15] (03CR) 10Gergő Tisza: "Added some comments." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/94088 (owner: 10Gergő Tisza) [22:23:22] RoanKattouw: queue mode shouldn't be a problem, it'll just pick up. btw, you did reload, not restart, right? [22:23:27] (03Merged) 10jenkins-bot: Migrate usage of wikibits in legacy protect.js and upload.js [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94256 (owner: 10Bartosz Dziewoński) [22:23:28] Yes [22:23:41] RoanKattouw: btw, ui.git, are you going to push the old history on top or below? [22:23:52] Sure, I know it should pick up eventually, but I want quick feedback so I'll wait till it recovers [22:23:59] ui.git already has the old history below [22:24:04] check out the git log of the change you just merged [22:24:29] (03PS1) 10Catrope: Move files from modules/oojs-ui to the repository root [oojs/ui] - 10https://gerrit.wikimedia.org/r/94264 [22:24:40] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94258 (owner: 10Chad) [22:25:28] Alright now I wonder why zuul isn't executing these jobs [22:25:38] It says "queue lengths: 63 events, 8 results" but it's only running one job [22:26:55] (03PS1) 10Siebrand: Update docs [core] - 10https://gerrit.wikimedia.org/r/94267 [22:27:11] (03PS1) 10Chad: Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 [22:27:44] (03CR) 10jenkins-bot: [V: 04-1] Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 (owner: 10Chad) [22:27:52] (03CR) 10Siebrand: "Was meant to be a follow-up to https://gerrit.wikimedia.org/r/#/c/94258/ but Gerrit didn't want to play." [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [22:29:18] Krinkle: Ping? Zuul isn't processing any of my stuff it seems [22:29:33] (03CR) 10Siebrand: "New class should be in AutoLoader (caused test to fail)." [core] - 10https://gerrit.wikimedia.org/r/94258 (owner: 10Chad) [22:29:59] RoanKattouw: It is [22:30:30] Where? [22:30:39] 54 events, that's number of unprocessed events. Events it queued but hasn't acted on in any way. This includes events it won't act on (e.g. actions not relevant as it will find out) [22:30:42] (03PS1) 10Amire80: Fix images and related CSS for RTL wikis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/94269 [22:30:54] But why does that queue flush so incredibly slowly? [22:31:01] No idea [22:31:11] It should be doing more in parellel [22:31:18] When I see it say "57 events" and running only one job, I assume it's just sitting on its ass [22:31:27] Now it's running 2-4 parallel ones, but before it was 0-1 [22:31:39] at least submit them in the jenkins queue ahead of time, it looks like the job running is keeping it from even looking at the queued events. [22:31:56] RoanKattouw: exactly [22:32:35] (03CR) 10Siebrand: [C: 032] Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 (owner: 10Chad) [22:34:15] (03Merged) 10jenkins-bot: wikibits: Add some missing deprecation messages [core] - 10https://gerrit.wikimedia.org/r/94251 (owner: 10Bartosz Dziewoński) [22:35:10] (03PS2) 10Chad: Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 [22:35:11] (03PS2) 10Chad: Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 [22:35:24] (03Merged) 10jenkins-bot: Set visibility of class properties of HashtableReplacer [core] - 10https://gerrit.wikimedia.org/r/94252 (owner: 10Siebrand) [22:36:05] (03PS1) 10Krinkle: Rename mw.util.wikiGetlink to getUrl [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94270 [22:36:49] (03CR) 10Krinkle: [C: 032] Rename mw.util.wikiGetlink to getUrl [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94270 (owner: 10Krinkle) [22:39:34] (03Merged) 10jenkins-bot: wikibits: Add some missing deprecation messages [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/94261 (owner: 10Krinkle) [22:39:49] (03PS2) 10Chad: Update docs [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [22:40:00] (03PS1) 10Krinkle: Rename mw.util.wikiGetlink to getUrl [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94271 [22:40:11] (03CR) 10Krinkle: [C: 032] Rename mw.util.wikiGetlink to getUrl [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94271 (owner: 10Krinkle) [22:41:14] http://www.youtube.com/watch?v=X9dpXHnJXaE#t=387 - that explains a lot about certain users [22:42:49] (03Merged) 10jenkins-bot: Remove stupid one-cell table [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [22:43:35] ori-l: Reminder for you to review the VE instrumentation commit at some point [22:43:53] i think it's OK except the namespacing [22:43:57] Suggestions regarding renaming will be followed almost unquestioningly [22:43:59] saveDiag doesn't make sense to me [22:44:03] k [22:44:08] Tell me what you want it to be and I'll do it [22:44:24] As long as it's not oriWantsAUnicorn.* [22:44:45] well, i've been trying to follow this suggestion from the graphite docs: [22:44:54] * Each path component should have a clear and well-defined purpose. [22:44:54] * Volatile path components should be kept as deep into the hierarchy as possible. [22:45:13] OK [22:45:23] So #2 I think I've followed by putting the specific causes of save errors at the end [22:46:35] ^d: wanna merge https://gerrit.wikimedia.org/r/#/c/89423/ ? trivial [22:46:47] yet it's waiting for almost a month now [22:46:58] I'm not sure what #1 means in concrete terms here [22:47:05] Yeah, I'm bikeshedding with myself in my head [22:47:10] maybe you should just merge it [22:47:11] I think performance.* is a pretty clear category [22:47:15] Well I wrote it [22:47:18] So I'm not merging this [22:47:46] s/you/we/. a 'performance.' prefix would work, yes [22:47:56] (03CR) 10jenkins-bot: [V: 04-1] Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 (owner: 10Chad) [22:48:17] but I think we might want to replace these calls with somethink that mimics console.time() / console.timeEnd() [22:48:22] So, performance.* , I mean, is for timing requests for instance [22:48:45] But these things are measuring user behavior and user-perceived timings, not actual request performance [22:48:54] Perhaps we should separate those two categories [22:49:00] OK, let me stare at it for another 15 mins [22:49:07] k [22:49:14] and come up with an actual opinion rather than vague reservations [22:49:24] Sounds good [22:49:26] (I'm doing that, I mean) [22:49:39] (03CR) 10Chad: [C: 032] Simplify watchlist edit mode handling [core] - 10https://gerrit.wikimedia.org/r/89423 (owner: 10Bartosz Dziewoński) [22:51:06] (03CR) 10jenkins-bot: [V: 04-1] Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 (owner: 10Chad) [22:51:35] (03PS1) 10Bartosz Dziewoński: FormOptions: Implement FLOAT type [core] - 10https://gerrit.wikimedia.org/r/94274 [22:51:39] I still think it all falls under the umbrella of 'performance', but it would be proper to distinguish between user-oriented measurements and measurements of system processes [22:51:40] (03PS3) 10EBernhardson: Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [22:51:50] google uses 'user timing' for the former category (https://developers.google.com/analytics/devguides/collection/gajs/gaTrackingTiming) [22:52:12] in fact that's also the name of the W3C spec for an API oriented around this kind of data http://www.w3.org/TR/user-timing/ [22:52:40] the fact that it is timing data will be captured by the metric type in graphite, so it doesn't need to be included in the name [22:52:50] so 'performance.user.*' and 'performance.system.*'? [22:52:59] (03CR) 10Bartosz Dziewoński: "Rationale: I want to use this in my upcoming SpecialWatchlist rewrite, which has a comment saying "@todo use FormOptions!", and which uses" [core] - 10https://gerrit.wikimedia.org/r/94274 (owner: 10Bartosz Dziewoński) [22:53:02] OK, sounds good [22:53:09] So, there are actually three categories [22:53:10] (03PS4) 10EBernhardson: Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [22:53:11] performance.system is clear [22:53:20] (03CR) 10jenkins-bot: [V: 04-1] Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 (owner: 10Chad) [22:53:26] But performance.user has two categories in it, really [22:53:46] (03CR) 10jenkins-bot: [V: 04-1] Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 (owner: 10Chad) [22:53:56] Timings of user behavior (how long do they wait before clicking save), and timings of user-perceived performance (how long do they have to wait once they have clicked save before something happens) [22:54:00] <^d> Silly phpunit [22:54:17] So I figured we may want to split those two in some way [22:54:38] (conversation moved to #mediawiki-visualeditor) [22:55:19] (03PS3) 10Chad: Clean up CDB classes [core] - 10https://gerrit.wikimedia.org/r/94258 [22:56:02] (03CR) 10EBernhardson: "Changes:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [22:57:18] (03PS5) 10EBernhardson: Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [22:57:34] (03CR) 10EBernhardson: [C: 032] "rebase and merge" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [22:59:57] (03Merged) 10jenkins-bot: Rename mw.util.wikiGetlink to getUrl [core] (wmf/1.23wmf3) - 10https://gerrit.wikimedia.org/r/94270 (owner: 10Krinkle) [23:00:14] (03CR) 10EBernhardson: "to start using rc_source we also need to adjust Flow\Data\RecentChanges to insert to the field" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93969 (owner: 10Matthias Mullie) [23:01:06] (03CR) 10EBernhardson: [C: 032] "(actually it looks like i enabled that in another slightly unrelated patch, oops)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93969 (owner: 10Matthias Mullie) [23:01:58] (03CR) 10jenkins-bot: [V: 04-1] Update docs [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [23:02:32] (03PS3) 10Siebrand: Update docs [core] - 10https://gerrit.wikimedia.org/r/94267 [23:03:55] (03PS4) 10Krinkle: Update docs [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [23:04:05] (03CR) 10Krinkle: [C: 031] Update docs in CdbPHP.php [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [23:04:44] (03PS2) 10EBernhardson: Change all Exception for MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 (owner: 10Matthias Mullie) [23:05:03] (03CR) 10EBernhardson: [C: 032] "Rebased in PS2, merging" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 (owner: 10Matthias Mullie) [23:06:13] (03Merged) 10jenkins-bot: Rename mw.util.wikiGetlink to getUrl [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94271 (owner: 10Krinkle) [23:06:58] Krinkle: zuul finally got around to https://gerrit.wikimedia.org/r/#/c/94264/ , could you +2 ? [23:07:11] (03PS1) 10Catrope: Add AUTHORS and LICENSE files [oojs/ui] - 10https://gerrit.wikimedia.org/r/94275 [23:07:43] (03CR) 10EBernhardson: [C: 032] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93968 (owner: 10Matthias Mullie) [23:08:26] RoanKattouw: Hm.. zuul seems to have run very fast there. [23:08:30] I don't fully trust it [23:08:42] (03PS2) 10Aaron Schulz: Improve "adviseStat" performance [core] - 10https://gerrit.wikimedia.org/r/94237 [23:08:56] (03CR) 10JGonera: "(9 comments)" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [23:09:12] (03CR) 10Aaron Schulz: "This should make copyFileBackend script require less workarounds (low batch size)" [core] - 10https://gerrit.wikimedia.org/r/94237 (owner: 10Aaron Schulz) [23:09:35] (03CR) 10JGonera: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [23:10:17] Krinkle: Me neither [23:10:22] There's also no .jshintrc BTW [23:13:59] Krinkle: No the timing seems right, it takes 0.97s to jshint that repo on my machine [23:14:54] (03Merged) 10jenkins-bot: Simplify watchlist edit mode handling [core] - 10https://gerrit.wikimedia.org/r/89423 (owner: 10Bartosz Dziewoński) [23:15:18] (03PS3) 10Aaron Schulz: Improve "adviseStat" performance [core] - 10https://gerrit.wikimedia.org/r/94237 [23:15:27] (03CR) 10jenkins-bot: [V: 04-1] Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [23:15:45] (03CR) 10jenkins-bot: [V: 04-1] Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [23:16:43] (03CR) 10Krinkle: "*bump*" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93053 (owner: 10Krinkle) [23:16:45] (03PS2) 10Krinkle: Remove exclusive module group to reduce HTTP request fragmentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93053 [23:18:11] (03Merged) 10jenkins-bot: Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [23:20:16] (03CR) 10Aaron Schulz: "Passes all tests and works well in testing copyFileBackend" [core] - 10https://gerrit.wikimedia.org/r/94237 (owner: 10Aaron Schulz) [23:20:16] RoanKattouw: git tags seem to be missing [23:20:30] RoanKattouw: in oojs/core [23:20:38] Right, yeah I suppose they would be [23:20:43] I can restore them easily [23:20:50] k [23:21:00] (03PS4) 10Aaron Schulz: Improve "adviseStat" performance [core] - 10https://gerrit.wikimedia.org/r/94237 [23:21:03] (03PS1) 10Chad: Give the search page a little UI love [core] - 10https://gerrit.wikimedia.org/r/94276 [23:21:06] <^d> \o/ That was really easy [23:21:12] TimStarling: can you look at https://gerrit.wikimedia.org/r/#/c/94237/ when you get the chance? [23:22:09] (03CR) 10Krinkle: [C: 032] Move files from modules/oojs-ui to the repository root [oojs/ui] - 10https://gerrit.wikimedia.org/r/94264 (owner: 10Catrope) [23:22:21] (03PS2) 10Chad: Give the search page a little UI love [core] - 10https://gerrit.wikimedia.org/r/94276 [23:22:58] wtf [23:23:07] v1.0.3 went through but the rest were prohibited by Gerrit?! [23:23:35] (03CR) 10jenkins-bot: [V: 04-1] Change all Exception for MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 (owner: 10Matthias Mullie) [23:23:57] <^d> With mediawiki.ui you too can pretend to know how to make pretty UI things :p [23:24:22] (03CR) 10jenkins-bot: [V: 04-1] Change all Exception for MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 (owner: 10Matthias Mullie) [23:24:25] Oooh [23:24:30] Krinkle: Dude [23:24:41] Your tags aren't pure tags, they have commits that are unique to them it seems [23:24:48] Wait, no, that's not true [23:24:51] eh, pretty sure that's not true [23:25:00] <^d> RoanKattouw: Ooh? Did you see my screenshot? :) [23:25:26] Nope they're all tracked [23:25:28] *stacked [23:25:53] ^d: Nice :) [23:26:37] OK so why the hell would Gerrit forbid me from pushing all these tags except two [23:27:33] Anyways, I'll come back to that later [23:27:33] <^d> Hmm, wonder how to fix that bit on the right. [23:27:43] ^d: scary [23:27:48] (03Merged) 10jenkins-bot: Fixes in FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93968 (owner: 10Matthias Mullie) [23:27:55] <^d> The little (X) for clearing input [23:28:07] ^d: you know they are rewriting everything about these? [23:28:33] ^d: (the mediawiki.ui styles, i mean) [23:28:47] <^d> Well then that means I'll get pretty new styles when someone does find+replace on it :) [23:30:10] (03PS1) 10Krinkle: Restrict Verified/Submit to JenkinsBot and l10n-bot [oojs/core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/94278 [23:30:42] <^d> I'd like a blue button with a like magnifying glass in it but that was beyond my abilities :p [23:31:32] (03PS1) 10Krinkle: Restrict Verified/Submit to JenkinsBot and l10n-bot [oojs/ui] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/94279 [23:32:01] (03PS3) 10EBernhardson: Change all Exception for MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 (owner: 10Matthias Mullie) [23:32:33] (03CR) 10EBernhardson: [C: 032] "rebase against the *current* master, and try merging again :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 (owner: 10Matthias Mullie) [23:32:52] (03CR) 10jenkins-bot: [V: 04-1] Remove exclusive module group to reduce HTTP request fragmentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93053 (owner: 10Krinkle) [23:33:12] (03CR) 10Chad: "This isn't supposed to be earth-shattering or a radical rethink of the whole search page, but I thought it represented a small easy step i" [core] - 10https://gerrit.wikimedia.org/r/94276 (owner: 10Chad) [23:33:43] (03CR) 10Krinkle: "Error is unrelated, Echo master is broken." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93053 (owner: 10Krinkle) [23:33:50] Reedy: do you run checkoutMediaWiki more than once per branch? [23:34:02] No [23:34:08] Who do I ping to fix Echo master? [23:34:18] bsitu [23:34:59] Reedy: well, the script works, so it must be that it was called at the wrong point, prior to the 1.23wmf3 dir being created [23:35:25] or is it simply the case that ULS thought it refers to master? [23:35:48] no [23:35:52] to whatever version it's running [23:36:10] so uls master is/was newer than static-whatever so a newly added font file wasn't there on bits when requested [23:36:38] yeah, that's their mistake [23:36:42] i'll let them know [23:36:59] Is it? [23:37:07] It's all a bit of a blur [23:37:13] Self referencing [23:37:23] static-current is not static-head nor is meant to be; it's the latest deployed branch [23:37:23] (03PS9) 10Krinkle: (bug 13953) Allow global user CSS/JS. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [23:37:28] Right [23:37:50] But for any wikis running on something newer than that, their config for fonts will include fonts in the newer version [23:37:58] whether or not the older version has them [23:38:20] Yes, latest deployed branch. Which means when they backport a change, it is expected that it will work. [23:38:26] I dont think this was a mistake on their end. [23:38:52] i don't understand; how can something be running on something newer than "the latest deployed branch? other than beta, that is. [23:38:53] when we deployed wmf3, static-current should've been updated to point to wmf3 before any wiki was switched to it. [23:39:21] Echo is broken? [23:39:32] Krinkle: err, yes. [23:39:33] instead if was updated from wmf1 to wmf2, then wmf3 was rolled out to mediawiki.org, which includes ULS, and ULS@wmf3 introduced a font and references it. [23:39:40] legoktm: Its unit tests are, yes. [23:39:56] Grrr [23:39:59] Give me a few minutes. [23:40:02] Krinkle: right [23:40:08] It's using a DB method that was presumably deprecated some time ago, but either way, it is removed and causing a fatal now. [23:40:13] the bottom line is what you said: static-current should've been updated to point to wmf3 before any wiki was switched to it. [23:40:49] Reedy: do you run checkoutMediaWiki *after* moving wikis to the branch?! [23:40:51] * ori-l is confused [23:40:57] No [23:41:03] That does the clone and sets up all the symlinks [23:41:17] https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment_v2 is essentially what I do [23:41:35] (03Merged) 10jenkins-bot: Change all Exception for MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 (owner: 10Matthias Mullie) [23:42:19] (03CR) 10Chad: [C: 032] Set visibility on class properties of ReplacementArray [core] - 10https://gerrit.wikimedia.org/r/94253 (owner: 10Siebrand) [23:42:20] ok, so i think the issue is that updateBitsBranchPointers shouldn't glob dir names in /usr/local/apache/common-local [23:42:26] Yes [23:42:29] but in /a/common instead [23:42:29] That sounds very much an issue [23:42:38] (03CR) 10Chad: [C: 032] Set visibility on class properties of ExplodeIterator [core] - 10https://gerrit.wikimedia.org/r/94254 (owner: 10Siebrand) [23:42:47] (03CR) 10Chad: [C: 032] Set visibility for class property of RegexlikeReplacer [core] - 10https://gerrit.wikimedia.org/r/94255 (owner: 10Siebrand) [23:42:52] (03CR) 10Legoktm: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [23:42:57] Krinkle: ^ that broke it [23:42:59] Reedy: OK, patch coming. [23:43:04] :) [23:44:32] (03CR) 10Chad: [C: 032] FormOptions: Implement FLOAT type [core] - 10https://gerrit.wikimedia.org/r/94274 (owner: 10Bartosz Dziewoński) [23:44:51] (03CR) 10Chad: [C: 032] Update docs in CdbPHP.php [core] - 10https://gerrit.wikimedia.org/r/94267 (owner: 10Siebrand) [23:45:28] (03Merged) 10jenkins-bot: Set visibility on class properties of ReplacementArray [core] - 10https://gerrit.wikimedia.org/r/94253 (owner: 10Siebrand) [23:46:47] Uhh [23:47:01] How do I get a mock DatabaseBase if I can't call a constructor? [23:47:08] AaronSchulz ^ [23:47:13] (03Merged) 10jenkins-bot: Set visibility on class properties of ExplodeIterator [core] - 10https://gerrit.wikimedia.org/r/94254 (owner: 10Siebrand) [23:47:31] Oh [23:47:35] I have to construct it differently? [23:48:23] legoktm: $this->getMockBuilder()->disableOriginalConstructor()->getMock(); [23:48:36] depending on what you need the mock to do... that could work [23:48:47] link? [23:48:55] woo, let me try that [23:49:02] (03Merged) 10jenkins-bot: Set visibility for class property of RegexlikeReplacer [core] - 10https://gerrit.wikimedia.org/r/94255 (owner: 10Siebrand) [23:49:16] https://github.com/wikimedia/mediawiki-extensions-Echo/blob/master/tests/BatchRowUpdateTest.php#L232 [23:49:17] look at the StatusTest and maybe DifferenceEngineTest in core :) [23:49:43] so many merges! thanks ^d [23:50:07] StatusTest is good :) [23:50:09] ^d: are you by chance interested in that rewrite i mentioned? i could submit some WIP drafts [23:50:39] aude: or maybe you? i'm rewriting SpecialWatchlist to inherit from SpecialRecentchanges and in general suck less [23:50:53] MatmaRex: cool! [23:51:41] (03Merged) 10jenkins-bot: FormOptions: Implement FLOAT type [core] - 10https://gerrit.wikimedia.org/r/94274 (owner: 10Bartosz Dziewoński) [23:51:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=48641 [23:51:58] (03PS1) 10Chad: Main Page might not exist [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94281 [23:52:18] (03CR) 10Krinkle: "Is this still relevant with the recent changes regarding less error handling and exception handling in ResourceLoader?" [core] - 10https://gerrit.wikimedia.org/r/88677 (owner: 10JGonera) [23:52:34] <^d> MatmaRex: ^ 94281 is easy if you're interested :) [23:52:51] (03CR) 10JGonera: "Will check." [core] - 10https://gerrit.wikimedia.org/r/88677 (owner: 10JGonera) [23:53:02] (03PS1) 10Legoktm: Disable DatabaseBase constructor [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94282 [23:53:11] > Main Page might not exist [23:53:13] > We don't have a "title" for this job so we use the Main Page because it exists. [23:53:16] gj ^d [23:53:20] greg-g: I can haz LD window? [23:53:48] > Queue lengths: 19 events, 0 results. [23:53:49] (03CR) 10Swalling: [C: 031] "Yeah I think this is a good direction." [core] - 10https://gerrit.wikimedia.org/r/94276 (owner: 10Chad) [23:53:51] >.> [23:53:55] <^d> MatmaRex: Yeah, but I'm calling the function instead :p [23:54:19] well, i guess the function will use the localized name [23:54:20] legoktm: It was at 60+ before [23:54:32] does it actually matter? the page used there must exist? [23:54:46] * legoktm waits patiently. [23:55:32] <^d> MatmaRex: We're being paranoid. [23:55:37] <^d> It might not actually matter. [23:55:42] <^d> But doesn't hurt to :p [23:55:49] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94274 (owner: 10Bartosz Dziewoński) [23:56:08] ^d: let me just fix the commit summary, mkay. [23:56:18] (03PS2) 10Bartosz Dziewoński: Main Page might not exist [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94281 (owner: 10Chad) [23:56:23] stupid bot, i made it say "'Main Page' might not exist, use localized name" [23:56:48] (03CR) 10Bartosz Dziewoński: [C: 032] "Chad made me do it." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94281 (owner: 10Chad) [23:57:08] <^d> Bot doesn't report the new summary on commit summary updates. [23:57:12] i know. [23:57:15] there's a bug for that [23:57:18] <^d> Tis lame :) [23:57:20] and you haven't fixed it yet :> [23:57:21] Unless you do it locally. [23:57:30] <^d> MatmaRex: Not my bug? [23:57:32] (03PS1) 10Matthias Mullie: auto-expand text-area as content grows [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94285 [23:58:04] https://bugzilla.wikimedia.org/show_bug.cgi?id=54372 [23:58:04] aude, Krinkle: https://gerrit.wikimedia.org/r/#/c/94282/ can be merged, jenkins liked it [23:58:04] (03CR) 10Parent5446: [C: 04-1] "Why? The commit message has no indication of why wfIsWindows() isn't being used." [core] - 10https://gerrit.wikimedia.org/r/94268 (owner: 10Chad) [23:59:14] (03CR) 10Krinkle: [C: 032] Disable DatabaseBase constructor [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94282 (owner: 10Legoktm) [23:59:41] (03Merged) 10jenkins-bot: 'Main Page' might not exist, use localized name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94281 (owner: 10Chad) [23:59:41] (03PS3) 10Chad: Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 [23:59:41] (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/94274 (owner: 10Bartosz Dziewoński) [23:59:41] (03PS4) 10Chad: Don't use wfIsWindows() in CDB writers [core] - 10https://gerrit.wikimedia.org/r/94268 [23:59:41] legoktm: \o/ [23:59:49] (03Merged) 10jenkins-bot: Disable DatabaseBase constructor [extensions/Echo] - 10https://gerrit.wikimedia.org/r/94282 (owner: 10Legoktm) [23:59:50] :D