[00:13:07] (03CR) 10Werdna: "(10 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 (owner: 10Matthias Mullie) [00:13:41] (03CR) 10Ori.livneh: [C: 032] "Reproduced the bug and verified the fix. Nasty little bug!" [core] - 10https://gerrit.wikimedia.org/r/93872 (owner: 10Aaron Schulz) [00:16:42] (03Merged) 10jenkins-bot: Fixed redis reconnect handling when passwords are used in luaEval() [core] - 10https://gerrit.wikimedia.org/r/93872 (owner: 10Aaron Schulz) [00:17:00] (03PS1) 10Aaron Schulz: Fixed redis reconnect handling when passwords are used in luaEval() [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93898 [00:17:14] (03PS1) 10Aaron Schulz: Fixed redis reconnect handling when passwords are used in luaEval() [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93899 [00:19:02] (03CR) 10Aaron Schulz: [C: 032] Fixed redis reconnect handling when passwords are used in luaEval() [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93898 (owner: 10Aaron Schulz) [00:19:06] (03CR) 10Aaron Schulz: [C: 032] Fixed redis reconnect handling when passwords are used in luaEval() [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93899 (owner: 10Aaron Schulz) [00:20:02] (03CR) 10jenkins-bot: [V: 04-1] Fixed redis reconnect handling when passwords are used in luaEval() [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93898 (owner: 10Aaron Schulz) [00:21:57] * AaronSchulz wonders what the conflict could possibly be on [00:27:57] (03Merged) 10jenkins-bot: Fixed redis reconnect handling when passwords are used in luaEval() [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93898 (owner: 10Aaron Schulz) [00:28:06] ? [00:29:33] (03Merged) 10jenkins-bot: Fixed redis reconnect handling when passwords are used in luaEval() [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93899 (owner: 10Aaron Schulz) [00:30:14] (03PS3) 10Tim Starling: Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 [00:32:17] (03PS1) 10CSteipp: Link rights to OAuth/grants instead of tooltips [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93901 [00:33:09] (03CR) 10Tim Starling: "* PS2: in FauxRequest::getProtocol(), return a value given to the constructor, instead of throwing an exception" [core] - 10https://gerrit.wikimedia.org/r/93425 (owner: 10Tim Starling) [00:33:50] Am I only the one to go to Special:Preferences and expect an "OAuth" tab? [00:33:59] Or "connected applications" or whatever. [00:35:42] (03PS4) 10Tim Starling: Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 [00:37:35] (03PS2) 10MarkTraceur: ResourceLoader consistency file moves [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93867 [00:42:28] "Edit your watchlist | Edit your own watchlist. Note some actions will still add pages even without this right. (editmywatchlist)" [00:42:31] * AaronSchulz chuckles [00:43:45] csteipp: https://gerrit.wikimedia.org/r/#/c/93901/1/backend/MWOAuthUtils.php maybe that new method could go next to the related ones and have some quick comments? [00:44:35] Comments! Pff. Comments are for the weak... [00:45:32] Hi csteipp. [00:45:47] I laugh in the face of comments! [00:45:48] Ha ha ha. [00:45:56] I added https://bugzilla.wikimedia.org/show_bug.cgi?id=55554 as a blocker to OAuth. [01:08:51] (03CR) 10Ori.livneh: "Looks good, but: can you identify the worry that motivated this commit and document it in the commit message and the comment block?" [core] - 10https://gerrit.wikimedia.org/r/93866 (owner: 10Aaron Schulz) [01:10:47] (03PS3) 10Dan-nl: re-work exception handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 [01:11:26] (03CR) 10Dan-nl: "rebased with master" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [01:16:40] jgonera: tgr is the person to ask :) [01:17:48] tgr, my CommonsMetadata question was: is it easy to make license fetching work on any instance of mediawiki? I applied the license patch but I'm still not getting any license info on my local dev instance [01:18:48] jgonera, should work in theory [01:18:59] are you using instantcommons? [01:19:16] no, I'm using images from my local wiki [01:20:47] should still work, but you need the right html structure on the file description page [01:21:49] ok, I'll try to mimic what's on commons then [01:21:59] where is the actual code that parses the HTML? [01:23:27] ok, I see it [01:26:15] (03CR) 10Legoktm: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [01:30:21] (03CR) 10Gergő Tisza: [C: 031] re-work exception handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [01:31:13] (03CR) 10Phuedx: [C: 031] "This definitely fixes the major issue described in bug #56443. However, it doesn't cover using “confirmed” in place of “authorized”. I'll " [core] - 10https://gerrit.wikimedia.org/r/93394 (owner: 10IAlex) [01:34:38] (03CR) 10Aaron Schulz: "When I looked at the logs I was like "maybe the read errors are due to too many dangling connections"...but that was mostly just baseless " [core] - 10https://gerrit.wikimedia.org/r/93866 (owner: 10Aaron Schulz) [01:35:43] (03CR) 10Aaron Schulz: [C: 032] Minor doc tweak [core] - 10https://gerrit.wikimedia.org/r/93862 (owner: 10Aaron Schulz) [01:37:07] TimStarling: I'm curious what's up with https://bugzilla.wikimedia.org/show_bug.cgi?id=55958 [01:37:13] * AaronSchulz should probably go home though [01:38:41] (03Merged) 10jenkins-bot: Minor doc tweak [core] - 10https://gerrit.wikimedia.org/r/93862 (owner: 10Aaron Schulz) [01:39:30] (03PS1) 10Tim Starling: Clean up WikimediaMaintenance class [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93907 [01:42:19] reza1615 seems very excited! [01:42:28] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84880 (owner: 10Aaron Schulz) [01:42:40] (03Abandoned) 10Aaron Schulz: Allow for cancellation of deferred updates [core] - 10https://gerrit.wikimedia.org/r/84880 (owner: 10Aaron Schulz) [01:43:32] if null edits fix it, then I don't care as much [01:45:03] (03PS1) 10MarkTraceur: Rewrite of UI initialization [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93909 [01:45:11] only one way to find out [01:52:23] (03PS2) 10Tim Starling: Script to fix bug 53687 (failure of revision row deletion) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93645 [01:56:38] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93889 (owner: 10Gergő Tisza) [01:59:02] (03CR) 10Werdna: [C: 032] Dont insert serialized Message objects into recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93892 (owner: 10EBernhardson) [01:59:10] (03Merged) 10jenkins-bot: Dont insert serialized Message objects into recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93892 (owner: 10EBernhardson) [02:00:08] (03PS1) 10Phuedx: Talk about email addresses being “confirmed”, not “authorized”, on Special:ConfirmEmail and Special:Preferences. [core] - 10https://gerrit.wikimedia.org/r/93911 [02:11:12] (03CR) 10Werdna: "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [02:14:04] (03CR) 10Werdna: [C: 032] Make "Show history" tab display as selected when on Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93689 (owner: 10Matthias Mullie) [02:14:13] (03Merged) 10jenkins-bot: Make "Show history" tab display as selected when on Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93689 (owner: 10Matthias Mullie) [02:15:24] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93889 (owner: 10Gergő Tisza) [02:32:23] (03CR) 10Phuedx: "While this makes the interface more consistent it doesn't address: the inconsistencies in function names, e.g. User#isEmailConfirmed and U" [core] - 10https://gerrit.wikimedia.org/r/93911 (owner: 10Phuedx) [03:28:09] (03PS1) 10Robmoen: WIP: Target mobile on ve dependencies [core] - 10https://gerrit.wikimedia.org/r/93915 [03:28:43] (03CR) 10Robmoen: [V: 04-1] "WIP, do not merge." [core] - 10https://gerrit.wikimedia.org/r/93915 (owner: 10Robmoen) [03:42:56] (03PS5) 10Legoktm: (bug 13953) Allow global user CSS/JS. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [03:43:00] (03CR) 10jenkins-bot: [V: 04-1] (bug 13953) Allow global user CSS/JS. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [03:50:45] AaronSchulz: is there a way to clean up duplicate jobs from a queue? [03:51:01] webplatform has 3.5m jobs, most of which are the same job over and over [03:53:05] (03PS6) 10Legoktm: (bug 13953) Allow global user CSS/JS. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [03:59:24] (03CR) 10Tim Starling: [C: 032] "Committing for test on server." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93645 (owner: 10Tim Starling) [03:59:27] (03Merged) 10jenkins-bot: Script to fix bug 53687 (failure of revision row deletion) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93645 (owner: 10Tim Starling) [04:00:44] fucking SMW. almost all of the jobs are for it [04:02:32] Ryan_Lane: Job::getDeduplicationInfo() and ignoreDuplicates() can be overridden in the subclass to provide duplicate removal [04:03:00] well, the federated queue does this automatically, right? [04:03:06] I may just switch to redis + federated queue [04:03:30] what is the job name? [04:04:03] SMWUpdateJob [04:04:14] I'm just deleting all of them and force rebuilding SMW's data [04:04:21] it's 3.8m jobs [04:04:33] I think a bot went crazy [04:04:57] this is on wikitech? [04:05:15] no. docs.webplatform.org [04:05:25] we're at 0 jobs on wikitech [04:07:35] ignoreDuplicates() would return false for it [04:07:58] so you wouldn't get any automatic duplicate removal, regardless of backend [04:08:13] ah [04:47:32] (03CR) 10Tim Starling: "This also fixes the bug whereby the first non-option argument is removed, regardless of whether --wiki was used." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93907 (owner: 10Tim Starling) [04:48:36] (03PS1) 10CSteipp: More UX changes [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93918 [04:49:09] So if I run a query that select's MAX(rev_id), how do I access that from the object? $row->MAX(rev_id) won't work :/ [04:49:36] legoktm: I think $row->{"MAX(rev_id)"} might? [04:49:48] Alternatively, get the result as an array rather than an object, and you can use $row["..."] [04:50:05] Or, do SELECT ... MAX(rev_id) AS highest_rev_id and you'll have $row->highest_rev_id [04:50:50] the {} thing works, but I'm going to use the AS because that's cleaner. [04:50:52] thanks! [05:00:29] I usually use AS for that [05:09:35] (03PS7) 10Legoktm: (bug 13953) Allow global user CSS/JS. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [05:10:59] (03CR) 10Legoktm: "I merged both classes into one ResourceLoaderGlobalUserModule class. It now extends ResourceLoaderWikiModule, which implements the getModi" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [05:35:25] (03PS1) 10Hiong3-eng5: API: added batch process to add text annotation [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/93922 [05:35:37] (03PS1) 10Pastakhov: add T_EMPTY operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93923 [05:37:10] (03CR) 10Pastakhov: [C: 032] add T_EMPTY operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93923 (owner: 10Pastakhov) [05:37:17] (03Merged) 10jenkins-bot: add T_EMPTY operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93923 (owner: 10Pastakhov) [05:38:46] (03PS3) 10Ori.livneh: tests for includes/exception.php [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [05:38:59] (03CR) 10Hiong3-eng5: "Kindly check for errors or corrections. Thanks" [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/93922 (owner: 10Hiong3-eng5) [05:40:11] (03CR) 10jenkins-bot: [V: 04-1] tests for includes/exception.php [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [05:44:57] (03CR) 10CSteipp: "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [05:50:26] (03PS4) 10Ori.livneh: Tests for MWExceptionHandler::jsonSerializeException [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [05:53:06] (03PS1) 10Legoktm: Cleanup some i18n and fix documentation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/93924 [05:53:07] (03CR) 10Rasel160: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [06:38:26] (03PS2) 10Nemo bis: Added highlighting after clicking "Drag to new location" button of Liquid Threads. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 (owner: 1001tonythomas) [06:39:22] (03CR) 10Nemo bis: "Thanks for the patch! I've added a couple reviewers." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 (owner: 1001tonythomas) [06:39:40] ori-l: you're still awake? [06:39:47] ori-l: I guess not [06:44:16] YuviPanda: ye of little faith [06:44:36] ori-l: indeed. [06:44:43] * YuviPanda gives self 100 lashes of the whip [06:45:03] ori-l: i'm at the office, and have figured that there's a 24h open subway *right* behind the office :D [06:46:29] this is why we work at the wikimedia foundation [06:48:08] (03CR) 10Ori.livneh: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [06:50:51] (03PS3) 10Nemo bis: Fixed css issue where long copyright text and radio buttons are separated [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/61339 (owner: 10Rasel160) [06:51:09] (03Merged) 10jenkins-bot: Tests for MWExceptionHandler::jsonSerializeException [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [07:20:02] (03CR) 10Nemo bis: [C: 04-1] "Thanks for your patch and welcome in MediaWiki development." [core] - 10https://gerrit.wikimedia.org/r/93911 (owner: 10Phuedx) [07:25:48] (03PS1) 10Spage: Fix browsertests by pointing to special QA URL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93929 [07:29:10] (03CR) 10Spage: "flow_edit_title_anon.feature passes on ee-flow.wmflabs.org in conjunction with my gerrit change to point to Talk:Flow_QA. I'll try to revi" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93069 (owner: 10Cmcmahon) [08:10:57] (03PS1) 10Pastakhov: add T_ISSET operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93933 [08:12:09] (03CR) 10Pastakhov: [C: 032] add T_ISSET operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93933 (owner: 10Pastakhov) [08:12:17] (03Merged) 10jenkins-bot: add T_ISSET operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93933 (owner: 10Pastakhov) [08:40:20] (03PS1) 10Pastakhov: add T_UNSET operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93935 [08:41:22] ori-l: if you are still awake, I enabled the exception-json log bucket on beta cluster. [08:41:34] (03CR) 10Pastakhov: [C: 032] add T_UNSET operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93935 (owner: 10Pastakhov) [08:41:40] (03Merged) 10jenkins-bot: add T_UNSET operator [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93935 (owner: 10Pastakhov) [08:41:50] hashar: Hey, so before I go to bed [08:41:53] ori-l: and enabled the ganglia graph you wrote for production. We now have a graph of errors on labs :-] [08:42:08] I fixed up the Parsoid setup in labs, turned out it was configured almost perfectly, I just needed to fix one thing [08:42:10] RoanKattouw: ah yeah sorry for yesterday, got swamped with more private messages :-( [08:42:18] awesome! [08:42:21] And so now the only remaining thing is it needs to update to master automatically [08:42:45] we already have a job updating mediawiki/extensions.git for us automatically [08:42:48] Yeah don't worry about it, I had to go pick up my passport from the visa people [08:43:01] Alright, but this particular extension runs on a different instance [08:43:07] deployment-parsoid2 [08:43:20] hashar: that's awesome [08:43:26] RoanKattouw: yeah, the code is fetched in the shared directory [08:43:33] shared as in project storage? [08:43:56] ori-l: it is displayed on https://integration.wikimedia.org/ and posted on qa-l about it. The plugin is on deployment-fluoride you (?) created a while back [08:44:25] So you're saying I could access that shared dir from the other instance, and even symlink it perhaps? [08:44:44] RoanKattouw: yes under /data/project/apache/common-local/php-master/extensions/** [08:44:50] Holy crap that's very useful [08:44:56] that is how we do the deployment [08:45:02] if you were around at the Zwinger epoch [08:45:04] that is the same system [08:45:05] I suppose I'll have to put localsettings.js in that shared dir then [08:45:10] Right, yeah [08:45:15] Long live NFS, huh [08:45:16] aka the Apaches read from the NFS server [08:45:41] and deployment-bastion is a jenkins slave, so Jenkins drive a job to do the git pull / submodule update / l10n regeneration etc [08:45:46] but other than the fact that I'll have to throw an unversioned config file in there, this is great [08:45:47] Nice [08:45:51] Oh that job runs on the bastion, awesome [08:46:06] the Jenkins jobs are listed on https://integration.wikimedia.org/dashboard/ [08:46:10] (under Beta Cluster) [08:46:24] and in the "Beta" Jenkins view at https://integration.wikimedia.org/ci/view/Beta/ [08:46:29] the beta-code-update does all the magic [08:46:33] running every six minutes. [08:46:42] it is a brute force approach though. [08:46:53] I thought we had postmerge jobs for that? [08:47:15] yup that would work for mediawiki/core [08:47:34] And I guess we do have postmerge for mw-config? [08:47:40] but Gerrit does not send ANY events for mediawiki/extensions.git [08:47:50] ugh [08:48:02] So we'd need postmerge in every single extension repo, and that sucks [08:48:19] yeah that is not manageable [08:48:28] unless we enforce Jenkins jobs to get changes merged in [08:48:32] that would force people to add the jobs [08:48:38] so I am using mediawiki/extensions.git [08:48:43] right, yeah [08:49:48] OK, awesome [08:50:15] I'm not gonna set this up at almost 1am and not without talking to Gabriel and Chris first, but I'll probably set it up tomorrow [08:50:36] we can follow up by email if you want :-] [08:50:40] would probably be easier [08:50:51] also you got to adapt the puppet class for varnish [08:50:56] No that's already done [08:51:00] oh [08:51:07] I checked, and the Varnish stuff all works already [08:51:11] WTF!???? nothing else to do ? [08:51:15] It was even being used already, I set that up before [08:51:26] The only thing was I had to configure Parsoid's serializer to use the Varnish cahce [08:51:27] \O/ [08:51:33] which was one line of config [08:51:46] But it was a new-ish config option that I didn't know about [08:52:20] so we would want that config file to be somewhere in puppet / a git repo so we can deploy it automatically [08:52:37] and need a way to reload the parsoid daemon when we are updating the code [08:52:40] Yes [08:53:04] Also, rebuild npm modules when updating [08:53:15] aren't they in a git repo ? [08:53:23] I guess we can make that conditional on the update actually having pulled in changes [08:53:27] The npm modules are in the private config repo on tin [08:53:30] (03CR) 10Dan-nl: "bryan, please let me know if you have any further questions or merge if you think everything looks good." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [08:53:34] Which is exactly why it's not public yet [08:53:56] We need to deploy those with git-annex or whatever so we have a clean config repo, then we can publish that repo and have a labs file in there just like mw-config [08:53:57] I wasn't even aware of a private config repo :D [08:54:07] tin:/srv/deployment/parsoid/config [08:54:15] ahh [08:54:42] re npm, the manifest of what's needed (package.json) is in the Parsoid repo, but the modules themselves (which include compiled code) are not, they're fetched by npm [08:54:58] And sometimes Parsoid changes its dependencies and the modules need to be refetched [08:55:13] Just running 'npm install' would probably work [08:55:20] I am fine running npm on beta [08:55:38] Cool [08:55:53] so I guess we could cd to extensions/Parsoid and run npm install [08:56:02] I was already running it on deployment-parsoid2 earlier today (your yesterday) when I updated Parsoid to the currently deployed version [08:56:06] or whatever magic needed [08:56:10] cd extensions/Parsoid/js but yeah that [08:56:22] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/93934/2/modules/ve-mw/init/ve.init.mw.Target.js -- line 599 looks funny; is that really supposed to be a !response.visualeditor ? [08:56:26] RoanKattouw: it is 1am so my yesterday is your as well now. [08:56:40] and then to restart the service you run /etc/init.d/parsoid restart as root on deployment-parsoid2 [08:57:11] ori-l: Crap you're right, that logic is backwards. I changed my mind about it twice [08:57:18] ori-l: Also, thanks for reviewing my Promise Chaining Commit of Doom [08:57:20] that one will have to be figured out somehow since the Jenkins job execute on deployment-bastion [08:59:19] But since it's 1am perhaps we should talk about that tomorrow [08:59:43] yes [08:59:50] i say we replace the graphs with this: http://vis.berkeley.edu/courses/cs294-10-fa07/wiki/images/0/0c/Pac_chart.gif [08:59:57] haha [09:00:10] We should graph the number of promises chained [09:00:22] I counted, in pathological cases it's 7 for a save, and that's excluding any ve.track hookups [09:00:42] wait you guys are up too? [09:01:06] nope [09:01:11] i went to bed hours ago [09:01:52] you just got back up :) [09:02:09] actually that's why I did [09:02:20] Get cache key ----> submit edit with cache key --(badcachekey)--> submit edit with HTML --(badtoken)--> get new token ----> get cache key --(instant fail)--> submit edit with HTML [09:02:29] I guess that's only 6 because I made it clear the cache key on badcachekey [09:02:37] Before that it would actually try to use it again [09:03:02] owww [09:03:05] i forgot about tokens [09:03:17] Hence my tech debt bug about migrating to mw.Api [09:03:20] so did phpredis, as aaron found out earlier [09:03:24] It has postWithToken() which does that for you [09:03:46] it transparently reconnects if the connection drops for whatever reason but it doesn't tell you about it and it doesn't re-auth [09:03:53] haha [09:03:57] That's useful [09:03:57] you could go with that approach, it has the element of surprise on its side [09:04:19] Fortunately, what I outlined above will never happen in practice [09:04:35] Because the API checks the token before it checks the cache key [09:04:35] (03CR) 10Pastakhov: [C: 032] delete old classes Runtime, Interpreter, ErrorMessage [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93938 (owner: 10Pastakhov) [09:04:41] (03Merged) 10jenkins-bot: delete old classes Runtime, Interpreter, ErrorMessage [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93938 (owner: 10Pastakhov) [09:05:17] Anyway, time for bed, see you guys tomorrow [09:05:19] ok, i am officially adjourning this meeting [09:05:24] damn it [09:05:30] beat me to it :P [09:08:03] ori-l: can you confirm the HHVM triage meeting is canceled tomorrow ? :D [09:08:31] yes, i fucked up the scheduling in every way it is possible to fuck up scheduling [09:08:36] and then a few additional ways [09:08:41] fine to me :-] [09:08:47] this way I can sleep tonight [09:08:59] and thank you for the udp2log demux filter tweak (exception but not exception-json) [09:09:44] 1) it overlapped the RFC review, 2) the SF conf room was reserved for some other use, 3) i have a doctor's appointment scheduled during the same time, 4) it conflicted with rob/chad's 1:1, 5) it was outside or partially outside your & brad's working hours [09:10:03] and i moved it a week without explaining, and cancelled it without explaining [09:10:13] i think i deserve a prize [09:11:52] like having my google calendar privileges revoked [09:12:11] anyways, sleep. [09:13:20] ori-l: good night :] [09:27:41] (03CR) 10Bartosz Dziewoński: "This actually sounds like something that should be implemented in Language, possibly also supporting nested quotes (somehow; I don't have " [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [09:33:18] (03PS1) 10Pastakhov: merge functions T_PRINT and T_ISSET ... in Compiler.php [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93940 [09:38:26] (03CR) 10Pastakhov: [C: 032] merge functions T_PRINT and T_ISSET ... in Compiler.php [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93940 (owner: 10Pastakhov) [09:38:33] (03Merged) 10jenkins-bot: merge functions T_PRINT and T_ISSET ... in Compiler.php [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93940 (owner: 10Pastakhov) [09:40:25] (03PS1) 10Hashar: beta-code-update: use mwdeploy home for wmf-beta-autoupdate [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93941 [09:44:08] (03CR) 10Hashar: [C: 032] beta-code-update: use mwdeploy home for wmf-beta-autoupdate [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93941 (owner: 10Hashar) [09:44:27] (03Merged) 10jenkins-bot: beta-code-update: use mwdeploy home for wmf-beta-autoupdate [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93941 (owner: 10Hashar) [10:16:26] (03CR) 10Deskana: [C: 031] "Looks good." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93918 (owner: 10CSteipp) [10:32:10] (03PS1) 10Pastakhov: fix for functions that contain zero params [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93942 [10:32:45] (03CR) 10Pastakhov: [C: 032] fix for functions that contain zero params [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93942 (owner: 10Pastakhov) [10:32:51] (03Merged) 10jenkins-bot: fix for functions that contain zero params [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93942 (owner: 10Pastakhov) [10:34:53] (03CR) 10TTO: "Bumping again... this is a fairly trivial change" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77491 (owner: 10Rillke) [13:14:10] https://bugzilla.wikimedia.org/show_bug.cgi?id=30405 http://pandorawiki.org/index.php?title=Talk:Main_Page_sswam&mobileaction=toggle_view_mobile works http://pandorawiki.org/index.php?title=Main_Page&mobileaction=toggle_view_mobile doesnt. Same content [13:14:59] Also, if you switch to norwegian language in settings, you get a "Artikkel av bidragsytere som deg" in plaintext on the bottom of the first [13:21:47] (03CR) 10Siebrand: [C: 04-1] "Two issues: This needs and entry in maintenance/language/messages.inc for the newly added core message key, and an entry in the optional a" [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [13:27:32] (03CR) 10Siebrand: "qqq is missing for newly added messages. Please see https://www.mediawiki.org/wiki/I18n#Message_documentation for details." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [13:28:22] (03CR) 10Siebrand: [C: 031] "L10n reviewed. Trivial changes." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93918 (owner: 10CSteipp) [13:29:46] (03CR) 10Siebrand: [C: 04-1] "Per Nemo." [core] - 10https://gerrit.wikimedia.org/r/93911 (owner: 10Phuedx) [13:43:03] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [13:43:26] Hi, Is Mr. Dereckson here? [13:44:24] (03CR) 10Siebrand: "Is there a screenshot/mock up somewhere?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93723 (owner: 10Matthias Mullie) [13:52:21] aravindkn: hello. Yes, I'm here. [13:54:02] Thank you sir! [13:54:47] You're welcome. Thank you to you to contribute to Wikimedia config. [13:56:34] So you already have installed git and git-review on your machine? [13:56:53] No. [13:57:04] I'll do it now. [13:57:31] Ok, you'll find instructions on https://www.mediawiki.org/wiki/Gerrit/Tutorial [13:57:55] Oh, Thank you! [14:18:40] (03CR) 10Matthias Mullie: "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [14:18:47] (03PS2) 10Matthias Mullie: Copy tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 [14:18:49] (03CR) 10jenkins-bot: [V: 04-1] Copy tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [14:18:57] (03CR) 10Siebrand: [C: 032] Use a more standard "Forgot your password?" in userlogin-resetpassword-link [core] - 10https://gerrit.wikimedia.org/r/87656 (owner: 10Nemo bis) [14:19:13] (03CR) 10Anomie: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [14:21:06] (03PS3) 10Matthias Mullie: Copy tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 [14:22:12] (03Merged) 10jenkins-bot: Use a more standard "Forgot your password?" in userlogin-resetpassword-link [core] - 10https://gerrit.wikimedia.org/r/87656 (owner: 10Nemo bis) [14:27:02] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 (owner: 10Matthias Mullie) [14:31:38] (03CR) 10Bartosz Dziewoński: "> On the alleged "proper" quotes: We only use "QUOTATION MARK" symbols…" [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [14:31:59] (03CR) 10Siebrand: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [14:33:09] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93608 (owner: 10Gergő Tisza) [14:34:03] (03CR) 10Bartosz Dziewoński: "And another thing. I'd argue that this message *shouldn't* be optional, as most languages (even European ones) actually use different quot" [core] - 10https://gerrit.wikimedia.org/r/93880 (owner: 10Kaldari) [14:42:24] (03PS1) 10Matthias Mullie: Move output functionality from AbstractRevision to Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 [14:46:37] (03CR) 10Anomie: [C: 031] "Why not do the same for Special:OAuthConsumerRegistration/propose?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93901 (owner: 10CSteipp) [14:55:27] (03PS2) 10Siebrand: Move output functionality from AbstractRevision to Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [14:55:50] (03CR) 10Siebrand: "Broke long line in commit message for PS2." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [14:57:05] (03Abandoned) 10Matthias Mullie: Fix moderation usertext (messages had been taken over by History) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93723 (owner: 10Matthias Mullie) [14:58:49] aravindkn: I will leave soon, to come back around 23h UTC. Do you have some questions about git/git-review/gerrit or is all fine? [15:06:15] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/47442 (owner: 10Micke) [15:06:20] (03CR) 10Cmcmahon: [C: 032] "thanks S" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93929 (owner: 10Spage) [15:06:22] (03PS4) 10Manybubbles: Push bulk indexing onto the job queue [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 [15:07:51] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/91906 (owner: 10Alex Monk) [15:09:19] (03CR) 10Manybubbles: [C: 04-1] "(2 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [15:27:29] marktraceur: around? [15:27:41] marktraceur: https://www.mediawiki.org/w/index.php?title=Talk:About_Beta_Features&diff=814568&oldid=814440 [15:28:50] Reedy: i can haz BetaFeatures master on wmf wikis? ^ [15:29:32] Opera sucks! [15:29:50] so does MediaWiki, but people use both [15:30:10] Reedy: the only changes since currently deployed version seem to be that and some i18n fixes [15:30:31] (and l10n-bot spam, naturally) [15:31:30] (03PS11) 10Hashar: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [15:31:41] (03CR) 10Hashar: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [15:32:10] (03CR) 10jenkins-bot: [V: 04-1] MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [15:33:09] (03PS3) 10Matthias Mullie: Move output functionality from AbstractRevision to Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 [15:33:10] MatmaRex: We're doing that today at 11:00 [15:34:51] (03PS4) 10Matthias Mullie: Move output functionality from AbstractRevision to Templating [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 [15:34:52] marktraceur: oh. yay [15:35:10] (SF time, i assume) [15:35:16] Right [15:35:19] (03CR) 10Hashar: "Added Daniel to /CREDITS" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [15:35:22] 19:00 UTC [15:35:24] Sorry [15:36:28] (03PS12) 10Hashar: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [15:37:09] (03CR) 10Hashar: "rebased" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [15:39:07] (03CR) 10Matthias Mullie: "I had broken commit message anew by submitting additions to PS1 :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [15:45:38] (03CR) 10AlephNull: [C: 031] "This is awesome." [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [15:49:49] (03PS15) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [15:50:56] (03CR) 10BryanDavis: [C: 032] re-work exception handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [15:51:05] (03Merged) 10jenkins-bot: re-work exception handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [15:53:19] Are you still here Mr. Dereckson? [15:54:39] (03CR) 10BryanDavis: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86387 (owner: 10Brian Wolff) [16:00:14] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [16:00:31] (03CR) 10Physikerwelt: [C: 031] "Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [16:00:46] (03PS3) 10BryanDavis: filebackend: path normalization fixes [core] - 10https://gerrit.wikimedia.org/r/93086 (owner: 10Aaron Schulz) [16:01:09] (03CR) 10BryanDavis: [C: 032] filebackend: path normalization fixes [core] - 10https://gerrit.wikimedia.org/r/93086 (owner: 10Aaron Schulz) [16:01:41] stupid question: when will 1.22 be released? [16:01:57] physikerwelt_: end of novemeber hopefully [16:02:52] !1.22 [16:02:52] MediaWiki 1.22 is the alpha version of MediaWiki, being deployed to Wikimedia sites every week. See https://www.mediawiki.org/wiki/MediaWiki_1.22 [16:02:59] hmm. [16:03:04] !1.22 del [16:03:04] Successfully removed 1.22 [16:03:26] MatmaRex: Do you review MobileFrontend changes? [16:03:28] !1.22 is MediaWiki 1.22 is due to be released in November 2013. See https://www.mediawiki.org/wiki/MediaWiki_1.22 [16:03:28] Key was added [16:03:33] hashar:thx [16:03:50] hoo: never did and i don't have it set up to test [16:04:01] pity, thanks anyway ;) [16:04:29] if it's something simple, i could probably test in "live" (if it's JS) or trust automated tests ;) [16:04:38] test it "live" * [16:04:43] JS/CSS* [16:05:26] siebrand: You suggested to add some realease notes to https://gerrit.wikimedia.org/r/#/c/87479/ . I'm not sure if I addressed your question correctly. Can you comment on that? [16:05:28] MatmaRex: Not really simple... it has full unit tests coverage, but still someone needs to per hand test it, I guess (despite the bit I did) [16:05:49] (03Merged) 10jenkins-bot: filebackend: path normalization fixes [core] - 10https://gerrit.wikimedia.org/r/93086 (owner: 10Aaron Schulz) [16:06:32] physikerwelt_: why RELEASE-NOTES-1.22 and not 1.23? [16:06:38] do you want to backport this change? [16:06:44] (if not, you should move the notes to 1.23 :) ) [16:06:48] hoo: :( [16:07:27] (03PS2) 10Hashar: Ensure variables are defined [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89819 (owner: 10Siebrand) [16:09:24] MatmaRex: Siebrand said:"If this gets merged anytime soon, it should be 1.22, not 1.23. Deprecation needs release notes." [16:09:37] That why I changend everything from 1.22 to 1.23 [16:09:42] (03PS2) 10BryanDavis: Made redis lock manager get EX/SH locks in one go [core] - 10https://gerrit.wikimedia.org/r/91325 (owner: 10Aaron Schulz) [16:09:53] (03PS3) 10Hashar: Ensure variables are defined [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89819 (owner: 10Siebrand) [16:10:16] (03CR) 10Hashar: [C: 032] "PS2 is a rebase" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89819 (owner: 10Siebrand) [16:10:20] (03PS2) 10Manybubbles: Add Elasticsearch version to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 [16:10:52] (03CR) 10BryanDavis: [C: 031] "I don't have an environment setup to test the redis bits." [core] - 10https://gerrit.wikimedia.org/r/91325 (owner: 10Aaron Schulz) [16:10:58] (03Merged) 10jenkins-bot: Ensure variables are defined [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89819 (owner: 10Siebrand) [16:11:10] (03PS2) 10Hashar: Declare visibility on class properties [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89820 (owner: 10Siebrand) [16:11:15] (03CR) 10Siebrand: "tx" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89819 (owner: 10Siebrand) [16:11:45] (03CR) 10Hashar: [C: 032] Declare visibility on class properties [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89820 (owner: 10Siebrand) [16:12:09] gnah [16:12:19] don't exchange var with public blindly [16:12:26] many of those aren't supposed to be public [16:12:27] (03PS6) 10BryanDavis: [HEAVY WIP] Add varnish role [vagrant] - 10https://gerrit.wikimedia.org/r/87623 (owner: 10Yuvipanda) [16:12:38] (03PS2) 10Hashar: Declare class properties, update docs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89821 (owner: 10Siebrand) [16:12:45] (03CR) 10Hashar: [C: 032] Declare class properties, update docs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89821 (owner: 10Siebrand) [16:12:52] (03Merged) 10jenkins-bot: Declare visibility on class properties [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89820 (owner: 10Siebrand) [16:13:01] MatmaRex: In the end it's just a deprecation note. Since I got a -1 for using 1.23 instead of 1.22 I changed it from 1.23 to 1.22. I'm not very motivated to change it back to 1.23 [16:13:12] physikerwelt_: gah, well, it didn't get merged "soon", but it can probably be backported [16:13:29] (03Merged) 10jenkins-bot: Declare class properties, update docs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89821 (owner: 10Siebrand) [16:13:40] yeah, i'm looking, it's just comments [16:13:49] (03PS1) 10Hoo man: Revert "Declare visibility on class properties" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/93963 [16:13:49] oh, you have one 1.23 in there. in Language.php [16:13:52] hashar: ^ [16:14:09] (03CR) 10MarkTraceur: "Krinkle, do you want to merge this so it can go out in the deploy today?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 (owner: 10MarkTraceur) [16:14:16] Kriiiinkleeeee [16:14:24] Oh, he gone. [16:14:59] MatmaRex: Thank you. I'll fix that [16:15:40] (03CR) 10Hoo man: "Same here, please don't use public blindly... AbuseFilter already is bad, please don't make it worse" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89821 (owner: 10Siebrand) [16:15:44] siebrand: ^ [16:16:13] physikerwelt_: since it's just comment changes, i can probably merge that for you and backport [16:16:34] physikerwelt_: i assume you want to add wfDeprecated() later (in 1.23 release, possibly?) per your comment [16:17:15] (03CR) 10Hashar: [C: 032] Update documentation [core] - 10https://gerrit.wikimedia.org/r/88497 (owner: 10Siebrand) [16:17:17] marktraceur: that looks trivial, i can merge if you explain why it's needed [16:17:20] MatmaRex: The idea would be to remove the code in 1.23 (it should be used by the math extension only) [16:17:52] physikerwelt_: hmm. i would suggest doing wfDeprecated() first just in case [16:17:52] hashar: https://gerrit.wikimedia.org/r/93963 [16:17:58] oh well, we can worry about that later [16:18:05] (03PS1) 10Pastakhov: Add phpunit tests for pcre functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93964 [16:18:43] physikerwelt_: please fix that single 1.23 and i'll merge and backport :) [16:18:43] siebrand: your abusefilter patch to set visibility on some properties is being reverted :D [16:18:44] siebrand: old patch https://gerrit.wikimedia.org/r/#/c/89820/ [16:18:51] siebrand: revert is https://gerrit.wikimedia.org/r/#/c/93963/ [16:18:54] MatmaRex: OK! [16:20:06] (03CR) 10Pastakhov: [C: 032] Add phpunit tests for pcre functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93964 (owner: 10Pastakhov) [16:20:08] hoo: I will let siebrand follow up :) [16:20:23] (03Merged) 10jenkins-bot: Update documentation [core] - 10https://gerrit.wikimedia.org/r/88497 (owner: 10Siebrand) [16:20:25] I'll stay out of AbuseFilter. [16:20:39] (03Merged) 10jenkins-bot: Add phpunit tests for pcre functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93964 (owner: 10Pastakhov) [16:20:48] MatmaRex: Basically because if something funky happens, I don't want to get a fatal error on every page :) [16:20:52] (03PS6) 10Matthias Mullie: (bug 56277) Update RecentChanges to use history i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 [16:21:04] MatmaRex: So I check for the existence of the element before messing with it [16:21:18] siebrand: It's bad legacy code and we should really avoid encouraging bad practices by blindly declaring everything public explicitly [16:21:47] hoo: It's not like to ever be addressed, and the issues keep coming up. [16:21:56] (03Abandoned) 10Hashar: Enable Generic.Formatting.NoSpaceAfterCast [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/66961 (owner: 10Hashar) [16:22:06] hoo: It prevents seeing the forest from the trees if not addresses. [16:22:10] addressed. [16:22:12] marktraceur: but that's jquery, working on empty sets shouldn't cause errors [16:22:29] (03PS1) 10Matthias Mullie: Change all Exception for MWException [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93967 [16:22:39] marktraceur: unless jq,tipsy does something weird, i dunno [16:22:42] that's why i'm asking [16:22:59] siebrand: Well... true, but probably 80% of those could be protected/ private without any issues [16:23:21] MatmaRex: I saw errors before, now I don't [16:23:23] *shrug* [16:24:08] hoo: Yes, and there are usually no tests for those, so that makes those changes a lot of work, where making them public is a safe change, that's compliant. [16:24:53] (03PS16) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [16:24:54] (03PS1) 10Matthias Mullie: Fixes in FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93968 [16:25:14] legoktm: Any reason you made me a template editor on en.wp? [16:25:50] siebrand: True, true... I can hardly count how often we already agreed on screwing the current AbuseFilter, someday hopefully we can throw it awy [16:26:06] marktraceur: heh, okay. [16:26:41] (03PS1) 10Matthias Mullie: Start using rc_source [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93969 [16:27:15] hoo: I think not reverting that merged change if more effective for future code quality than it is to revert it. But it's often that perfect if the enemy of better, and I'm really not in favour of that. [16:27:56] Anyone here familiar with WikiEditor? [16:28:04] (03CR) 10Matthias Mullie: "(10 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 (owner: 10Matthias Mullie) [16:28:06] (03CR) 10Bartosz Dziewoński: [C: 032] "I'm not quite sure why this is needed (I guess jquery.tipsy doesn't support working on empty sets like, oh I dunno, literally everything e" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 (owner: 10MarkTraceur) [16:28:26] (03Merged) 10jenkins-bot: Check for link existence in JS [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 (owner: 10MarkTraceur) [16:28:31] Thanks MatmaRex [16:28:47] my pleasure [16:28:51] Reedy, robla says he will be 5 mins late [16:30:09] I am trying to detach the buildup of toolbar from textarea and build it around a div, which may contain multiple textareas. My purpose is to ensure that with just one toolbar, all textareas would be workable. [16:31:14] I am half done, but the toolbar is not being displayed and I don't get any errors in the console log. [16:31:57] can someone please help me on this? [16:33:38] (03CR) 10MarkTraceur: [C: 032] Shorter text for license link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93608 (owner: 10Gergő Tisza) [16:33:42] (03Merged) 10jenkins-bot: Shorter text for license link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93608 (owner: 10Gergő Tisza) [16:34:28] (03CR) 10Siebrand: "Some comments (redacted) from our IRC discussion:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/93963 (owner: 10Hoo man) [16:37:31] MatmaRex: Any more things to do concerning https://gerrit.wikimedia.org/r/#/c/87479/? [16:39:20] (03CR) 10Siebrand: "Not sure if this has had a design pass yet. From the screenshot, there's very little (no?) distinction between the text "Suppressed" and "" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [16:39:40] physikerwelt_: sorry, i was afk [16:39:57] physikerwelt_: there's an (apparently) accidental newline in release notes, i'll just fix that [16:41:49] physikerwelt_: i'm changing the rel. notes text to 'Code specific to the Math extension was marked as deprecated.', is that okay with you? [16:41:57] sure [16:41:59] (03PS1) 10Hashar: more extensions [extensions] - 10https://gerrit.wikimedia.org/r/93970 [16:42:16] (03CR) 10Hashar: [C: 032] more extensions [extensions] - 10https://gerrit.wikimedia.org/r/93970 (owner: 10Hashar) [16:42:23] (03CR) 10Hashar: [V: 032] more extensions [extensions] - 10https://gerrit.wikimedia.org/r/93970 (owner: 10Hashar) [16:42:29] (03PS17) 10Bartosz Dziewoński: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [16:42:30] (03CR) 10Siebrand: "Not sure if something like (literal text) "[Username suppressed]" would make this clearer, or maybe it should have some CSS to make it app" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [16:43:24] (03CR) 10Bartosz Dziewoński: [C: 032] "Amended release notes, let's do this." [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [16:43:43] (03PS1) 10Bartosz Dziewoński: Mark Math-specific functions in core as deprecated [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93971 [16:43:53] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93971 (owner: 10Bartosz Dziewoński) [16:44:02] (03CR) 10Umherirrender: "The returned false will result in a message 'undo-failure'" [core] - 10https://gerrit.wikimedia.org/r/93788 (owner: 10Umherirrender) [16:44:30] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [16:46:55] MatmaRex: Thank you [16:47:19] (03PS2) 10Reedy: Clean up WikimediaMaintenance class [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93907 (owner: 10Tim Starling) [16:47:29] (03Merged) 10jenkins-bot: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [16:47:48] (03CR) 10Reedy: [C: 032] "I think this may also fix bug 48263" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93907 (owner: 10Tim Starling) [16:47:59] physikerwelt_: my pleasure [16:49:36] (03CR) 10Reedy: [V: 032] Clean up WikimediaMaintenance class [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93907 (owner: 10Tim Starling) [16:50:28] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [16:51:18] (03Merged) 10jenkins-bot: Mark Math-specific functions in core as deprecated [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93971 (owner: 10Bartosz Dziewoński) [16:52:18] (03PS1) 10Reedy: Update WikimediaMaintenance to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93973 [16:52:49] (03CR) 10Reedy: [C: 032 V: 032] Update WikimediaMaintenance to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93973 (owner: 10Reedy) [16:54:01] (03CR) 10Parent5446: [C: 031] Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 (owner: 10Tim Starling) [16:56:58] (03CR) 10Reedy: "Yup, it did fix bug 48263. Thanks!" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93907 (owner: 10Tim Starling) [16:57:37] (03CR) 10EBernhardson: "Conceptually i like this, will review more when i get a chance" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [16:58:58] (03CR) 10Hashar: "For the context: I don't have MySQL installed on my dev boxes so I rely on mocking :]" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [17:01:11] Reedy, fwiw andre__ and me found out what iwas going on with these "Please assign me bug NNNNN" emails. It's a group of students at http://foss.amrita.ac.in and we have explained to them who it is done. [17:01:24] Looking forward to see some bugs fixed by them after all. [17:01:34] would be cool, yeah [17:01:35] And hopefully a contributor or two sticking? [17:01:41] I hope they share some knowledge though [17:02:04] Don't want to explain using grep to find something in the code to 20 more students :D [17:02:57] andre__, I do my best answering with URLs, sometimes after editing page XYZ because the documentation could indeed be improved [17:03:09] I mean "I try to do my best" :) [17:05:05] heh, me too, if I don't get sidetracked by mailing lists, like today, which sidetracks me again from fighting damn bugs in Google Melange when importing GCI tasks :P [17:06:03] * andre__ grumbles that Google Melange is as crappy and buggy as two years ago [17:06:51] qgil: sadly they seem to mostly be focusing on asking people to "mentor" them :( [17:07:02] (yeah, i've gotten e-mail too) [17:07:04] yeah :-/ [17:07:23] well, we've explained several times now that private emails don't make much sense, if the wisdom is with the crowd in the public [17:07:28] feel free to repeat that :) [17:10:39] qgil: Sorry to say something disappointing but most people won't mail again once you give them minor tasks. [17:12:40] Rtdwivedi: reality bites, I know :) [17:13:21] I don't expect anybody to ask for resetting the assignee of a bug report back to default either when people might give up. :) [17:13:32] (03PS5) 10MaxSem: Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 (owner: 10Tim Starling) [17:14:17] Rtdwivedi, yes, but I guess this is part of our work and role as a popular open source project. :) This is why at least we want them to use the community channels and learn something even if they don't fix the bug at all. [17:14:20] andre__: lets hope for the best. [17:14:53] Rtdwivedi, in the worse case scenario they will keep receiving notification of these bugs, or they will need to learn to un-assign / un-CC themselves. :) [17:15:57] qgil: 1 in 100 might just stick around. :-) [17:16:23] Rtdwivedi, in situations like I remember when I started trying to do something in an open source project. I actually made some of the most common mistakes: coming up to bug disruptive ideas in the wrong mailing list, promising to take a task that I could not complete.... :) [17:17:15] "big disruptive ideas" - I also wrote hundreds of typos especially omn IRC, and I still do. :P [17:17:23] you see? :D [17:17:35] qgil: I remember bugging marktraceur for almost everything while I was trying to get started with Mediawiki last November. :D [17:17:53] well, but he deserved that! :) [17:18:17] haha! [17:18:19] :D [17:18:48] (03CR) 10MaxSem: [C: 032] "My PS was a purely stylistic change (s/WebRequest::/self::/)." [core] - 10https://gerrit.wikimedia.org/r/93425 (owner: 10Tim Starling) [17:18:55] ... and you seem to be sticking around Rtdwivedi ! It is very rewarding to see a contributor going up the stream one step at a time like you are doing. [17:20:45] Well, I like it here and my mentors were quite helpful, so it's been nice for me. :) And I would really like to see Wikisource get more users. :-) [17:21:04] :'-) [17:21:05] qgil: So, I am just trying to contribute my bit. [17:22:02] * marktraceur waves to Rtdwivedi [17:22:26] qgil: Whom should I contact if I have questions regarding WikiEditor? [17:22:48] * Rtdwivedi gives a high-5 to marktraceur [17:22:52] :D [17:22:59] Rtdwivedi: TrevorParscal is the one I'd bug [17:23:03] (03Merged) 10jenkins-bot: Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 (owner: 10Tim Starling) [17:23:08] Rtdwivedi, find the answer at https://www.mediawiki.org/wiki/Developers/Maintainers [17:23:24] He's not here for some reason, but he's in #mediawiki-visualeditor [17:23:51] marktraceur, qgil Thanks! :) [17:23:56] Rtdwivedi: Is the question "Why? WHY?!"? :-) [17:24:02] :D [17:26:45] James_F: No. I am trying to make some changes but I'm kind of stuck at one point, so I thought it would be nice to get some help. :-) [17:28:41] Rtdwivedi: My sympathies. :-( [17:29:27] James_F: Damn, why the WikiEditor hate? [17:29:56] VisualEditor? ;-) [17:30:24] marktraceur: Have you used it? [17:30:34] marktraceur: Also, Trevor's allowed to hate on it, as he built it. [17:30:34] Yeah! [17:30:48] I really like it as a wikitext editor [17:30:56] ebernhardson: http://www.infoq.com/presentations/php-history <~ a good overview of hphp and hack, if you haven't seen it already [17:32:07] phuedx: oh excellent, i had seen the slides (https://github.com/strangeloop/StrangeLoop2013/blob/master/slides/sessions/Adams-TakingPHPSeriously.pdf ) but that looks to be the presentation with adams speach that goes with it? [17:32:21] yarrrp [17:32:32] Rtdwivedi: I probably should have said this first, but don't ask to ask :) [17:32:33] will watch it tonight :) [17:32:39] Just mob Trevor [17:32:42] He'll get to you [17:33:04] apparently he's done a few more presentations on hphp and hack as well but i ain't seen 'em [17:33:11] <^d> Who wants a super-easy patch to review? [17:33:17] marktraceur: ah! I'll ask it right away then. thanks! [17:33:27] ^d: Define "super-easy" [17:33:50] <^d> Super easy. n. Something that is not hard. See also: https://gerrit.wikimedia.org/r/#/c/93887/ [17:34:12] * marktraceur scolds ^d for not using the permalink [17:36:33] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [17:37:22] (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [17:38:12] (03CR) 10MarkTraceur: [C: 04-1] "Agreed with Bartosz." [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [17:38:22] yup, that was super easy :) [17:38:22] Good catch MatmaRex [17:39:07] (03CR) 10Siebrand: [C: 032] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/93976 (owner: 10L10n-bot) [17:40:26] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [17:41:33] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [17:42:12] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/93976 (owner: 10L10n-bot) [17:42:37] (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93887 (owner: 10Chad) [17:44:17] (03PS4) 10Aude: Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 [17:44:47] (03CR) 10Aude: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [17:44:49] (03PS3) 10Chad: Remove stupid one-cell table [core] - 10https://gerrit.wikimedia.org/r/93887 [17:45:40] <3 [17:46:35] dammit, hashar. [17:46:42] why did he leave just when i wanted to pester him. [17:46:51] MatmaRex: That's his job, mate [17:49:21] (03PS5) 10Aude: Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 [17:50:39] marktraceur: yeah, and he's pretty good at it [17:53:39] (03PS1) 10Siebrand: Update comments a bit [core] - 10https://gerrit.wikimedia.org/r/93978 [17:57:46] (03CR) 10Nikerabbit: [C: 032] Update comments a bit [core] - 10https://gerrit.wikimedia.org/r/93978 (owner: 10Siebrand) [17:59:02] (03PS1) 10Anomie: Add a RefreshLinks job when a template is deleted [core] - 10https://gerrit.wikimedia.org/r/93980 [18:00:51] (03Merged) 10jenkins-bot: Update comments a bit [core] - 10https://gerrit.wikimedia.org/r/93978 (owner: 10Siebrand) [18:02:05] I think there are also some Korean student with some assignment about XML dumps [18:05:04] (03CR) 10Chad: [C: 04-1] "So right now we're checking for the cached result outside of the pool counter, which means we'll return early and doCachedWork() would onl" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:05:11] (03PS3) 10Chad: Add Elasticsearch version to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:06:10] (03PS4) 10Chad: Add Elasticsearch version to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:08:23] (03CR) 10Siebrand: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [18:12:28] csteipp: I created a testcase for you: https://translatewiki.net/wiki/User:Siebrand/test [18:12:43] csteipp: the conclusion is that plain links can be combined. [18:15:53] siebrand: Thanks for that. Yeah, seems good enough like that. [18:16:29] (03PS1) 10Gerrit Patch Uploader: Changed the red boxed email and email confirmation options [core] - 10https://gerrit.wikimedia.org/r/93981 [18:16:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/93981 (owner: 10Gerrit Patch Uploader) [18:25:36] (03CR) 10Aaron Schulz: [C: 032] Add mw.isSubsting() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93019 (owner: 10Anomie) [18:25:49] <^d> brion_: You can haz hhvm formula for homebrew. https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-OSX-10.9 (first section) [18:26:07] \o/ [18:26:56] (03Merged) 10jenkins-bot: Add mw.isSubsting() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93019 (owner: 10Anomie) [18:31:44] (03CR) 10Manybubbles: "I modeled the early checking of the cache on how we handle articles. The way you have it we'll hardly use the cache at all but the data w" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:33:13] (03CR) 10Aaron Schulz: [C: 032] Add a RefreshLinks job when a template is deleted [core] - 10https://gerrit.wikimedia.org/r/93980 (owner: 10Anomie) [18:33:42] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/47442 (owner: 10Micke) [18:34:12] (03PS2) 10Gergő Tisza: Use description HTML structure instead of categories to identify license [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93889 [18:34:54] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Please remove code instead of commenting it out. There's a reason we use a version control system like git." [core] - 10https://gerrit.wikimedia.org/r/93981 (owner: 10Gerrit Patch Uploader) [18:36:00] @notify hashar [18:36:01] I'll let you know when I see hashar around here [18:36:07] mumble grumble. [18:36:58] (03Merged) 10jenkins-bot: Add a RefreshLinks job when a template is deleted [core] - 10https://gerrit.wikimedia.org/r/93980 (owner: 10Anomie) [18:38:01] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [18:38:08] MatmaRex: memoserv? [18:39:33] marktraceur: do people read memoserv's messages? [18:39:42] Generally, I think [18:39:45] But maybe not [18:39:53] I'd expect hashar to given that he logs out of IRC [18:40:12] i'd expect people to read bugmail, but i've been told they don't :( [18:40:23] so i try to avoid non-standard communication channels [18:40:45] irc or email it is, and i just wanted to ask in relation to a particular email. [18:41:21] MatmaRex: I generally skim bugmail, but I'm _determined_ to be better at that [18:41:26] Maybe I can pull that off this weekend [18:41:32] the always relevant, http://xkcd.com/1254/ [18:42:19] At the very least I always read the title of bugmail. Sometimes I skip some bugmail about bugs that are in areas of the code base I'm not super interested in (e.g. javascript centric stuff) [18:42:52] i at least open each one, and read most which are not walls of texts :D [18:42:56] (a good email client helps) [18:45:04] (03PS2) 10Phuedx: Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/93394 (owner: 10IAlex) [18:45:10] (03CR) 10jenkins-bot: [V: 04-1] Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/93394 (owner: 10IAlex) [18:45:38] hey, only 12 bugs left marked for 1.22. [18:45:43] !bug milestone:22 [18:45:43] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=milestone%3a22 [18:45:54] (7 have patches) [18:46:38] (03CR) 10MarkTraceur: [C: 032] Use description HTML structure instead of categories to identify license [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93889 (owner: 10Gergő Tisza) [18:46:40] (03Merged) 10jenkins-bot: Use description HTML structure instead of categories to identify license [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93889 (owner: 10Gergő Tisza) [18:47:46] (03PS6) 10Aude: Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 [18:48:40] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [18:50:31] (03CR) 10Chad: "You're right." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:51:30] (03CR) 10Manybubbles: "I'm always right. That doesn't mean we shouldn't just keep what you had because it gives us more up to date results at a pretty low cost." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:52:01] (03CR) 10Parent5446: [C: 031] Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [18:53:22] (03CR) 10Chad: "Actually, now I'm wondering if we should bother with the pool counter for this at all." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:54:59] (03PS4) 10Anomie: Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 [18:55:46] (03CR) 10Manybubbles: "Meh, we use it for everything else so it is more symmetric with the pool counter. I don't believe it'll hurt anything." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [18:58:05] (03PS1) 10Gergő Tisza: Trim license shortnames [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93985 [18:58:45] (03CR) 10MarkTraceur: [C: 032] "Huzzah" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93985 (owner: 10Gergő Tisza) [18:58:50] (03Merged) 10jenkins-bot: Trim license shortnames [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93985 (owner: 10Gergő Tisza) [19:02:14] (03PS3) 10Phuedx: Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/93394 (owner: 10IAlex) [19:03:38] (03CR) 10Chad: [C: 032] Change mode of non-executable files back to 0644 [core] - 10https://gerrit.wikimedia.org/r/93649 (owner: 10IAlex) [19:06:05] (03PS2) 10Aaron Schulz: Cleanups to DB transaction handling [core] - 10https://gerrit.wikimedia.org/r/93627 [19:06:44] (03Merged) 10jenkins-bot: Change mode of non-executable files back to 0644 [core] - 10https://gerrit.wikimedia.org/r/93649 (owner: 10IAlex) [19:08:06] (03PS1) 10Bartosz Dziewoński: Change mode of non-executable files back to 0644 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93987 [19:08:38] (03CR) 10Aaron Schulz: "In config you can do something like:" [core] - 10https://gerrit.wikimedia.org/r/91325 (owner: 10Aaron Schulz) [19:08:42] (03CR) 10Chad: [C: 032] Change mode of non-executable files back to 0644 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93987 (owner: 10Bartosz Dziewoński) [19:08:55] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks like a good thing to do on REL1_22 as well. (Only these two files need fixing, apparently, this was an automated cherry-pick.)" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93987 (owner: 10Bartosz Dziewoński) [19:09:33] speed ^demon. [19:10:05] <^demon> I amended my other change ;-) [19:10:13] <^demon> To keep the ugly id name. [19:10:27] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [19:11:06] (03CR) 10MarkTraceur: [C: 032] Update Multimedia extensions to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93986 (owner: 10MarkTraceur) [19:11:39] Agh, I always forget [19:11:46] (03CR) 10MarkTraceur: [V: 032] Update Multimedia extensions to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93986 (owner: 10MarkTraceur) [19:13:23] (03CR) 10Aaron Schulz: [C: 031] Push bulk indexing onto the job queue [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [19:14:13] (03PS4) 10CSteipp: Improve user-facing error messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 [19:14:25] (03CR) 10CSteipp: "(6 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [19:15:54] (03Merged) 10jenkins-bot: Change mode of non-executable files back to 0644 [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93987 (owner: 10Bartosz Dziewoński) [19:16:46] (03CR) 10Chad: [C: 032] Push bulk indexing onto the job queue [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [19:16:56] (03CR) 10Phuedx: "Thank you both for the review. I've submitted a far smaller change, which has the same effect, as patch set #3 here: https://gerrit.wikime" [core] - 10https://gerrit.wikimedia.org/r/93911 (owner: 10Phuedx) [19:17:06] (03Abandoned) 10Phuedx: Talk about email addresses being “confirmed”, not “authorized”, on Special:ConfirmEmail and Special:Preferences. [core] - 10https://gerrit.wikimedia.org/r/93911 (owner: 10Phuedx) [19:18:29] (03Merged) 10jenkins-bot: Push bulk indexing onto the job queue [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [19:21:00] (03CR) 10Aaron Schulz: [C: 032] Move ManualLogEntry to RecentChange logic into own function [core] - 10https://gerrit.wikimedia.org/r/93653 (owner: 10Legoktm) [19:21:25] (03CR) 10Anomie: [C: 031] "Looks good, haven't tested." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [19:22:39] (03PS13) 10AlephNull: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 [19:24:02] (03Merged) 10jenkins-bot: Move ManualLogEntry to RecentChange logic into own function [core] - 10https://gerrit.wikimedia.org/r/93653 (owner: 10Legoktm) [19:25:26] (03CR) 10Awjrichards: "(1 comment)" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/93607 (owner: 10MaxSem) [19:28:50] (03CR) 10MaxSem: "(1 comment)" [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/93607 (owner: 10MaxSem) [19:29:12] (03PS3) 10Aaron Schulz: Cleanups to DB transaction handling [core] - 10https://gerrit.wikimedia.org/r/93627 [19:29:40] (03CR) 10AlephNull: "I made one minor change which makes the patch work as intended. With this change it does not try and duplicate MySQL VIEWs when doing the " [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [19:30:04] (03CR) 10Chad: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [19:30:47] (03CR) 10jenkins-bot: [V: 04-1] Cleaned up DatabaseBase constructor to use an array [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz) [19:36:02] (03CR) 10Aaron Schulz: [C: 04-1] "(6 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [19:36:25] (03PS2) 10CSteipp: Link rights to OAuth/grants instead of tooltips [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93901 [19:37:08] (03CR) 10Aaron Schulz: "I guess we can leave WMF message in...but it might be nice to run a single OAuth hook with the key name so we can swap the key in some wmf" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [19:38:10] (03CR) 10Aaron Schulz: [C: 032] Link rights to OAuth/grants instead of tooltips [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93901 (owner: 10CSteipp) [19:38:15] (03Merged) 10jenkins-bot: Link rights to OAuth/grants instead of tooltips [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93901 (owner: 10CSteipp) [19:42:35] (03CR) 10Daniel Kinzler: [C: 032] Avoid fatal in ContentHandler::getUndoContent by null content [core] - 10https://gerrit.wikimedia.org/r/93788 (owner: 10Umherirrender) [19:43:28] (03CR) 10Siebrand: [C: 04-1] "Per comments on L10n/plainlinks on PS3." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [19:45:31] (03Merged) 10jenkins-bot: Avoid fatal in ContentHandler::getUndoContent by null content [core] - 10https://gerrit.wikimedia.org/r/93788 (owner: 10Umherirrender) [19:46:02] (03PS1) 10Amire80: Fix background image for RTL languages [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93992 [19:47:11] (03PS4) 10Chad: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 [19:47:15] (03CR) 10jenkins-bot: [V: 04-1] Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 (owner: 10Chad) [19:47:33] (03CR) 10Siebrand: [C: 032] Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/93394 (owner: 10IAlex) [19:49:03] (03PS1) 10Navdeep Bagga: This Patch fix the font size of category tree according to the vector layout. [core] - 10https://gerrit.wikimedia.org/r/93993 [19:50:35] (03Merged) 10jenkins-bot: Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/93394 (owner: 10IAlex) [19:52:05] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [20:04:57] hey, hashar. [20:05:08] hashar: have you seen my reply on wikitech about the release notes thing? [20:07:16] (03CR) 10Siebrand: [C: 032] "Thanks." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/93924 (owner: 10Legoktm) [20:07:24] (03Merged) 10jenkins-bot: Cleanup some i18n and fix documentation [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/93924 (owner: 10Legoktm) [20:07:28] (03PS1) 10Hashar: qa-browsertests-postmerge to create a tarball [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93994 [20:07:45] (03PS1) 10Hashar: qa-browsertests-postmerge to create a tarball [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93995 [20:08:21] (03PS2) 10Hashar: qa-browsertests-postmerge to create a tarball [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93994 [20:08:31] (03CR) 10Hashar: [C: 032] qa-browsertests-postmerge to create a tarball [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93995 (owner: 10Hashar) [20:08:58] (03CR) 10Hashar: [C: 032] qa-browsertests-postmerge to create a tarball [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93994 (owner: 10Hashar) [20:09:07] (03Merged) 10jenkins-bot: qa-browsertests-postmerge to create a tarball [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93994 (owner: 10Hashar) [20:09:16] (03Merged) 10jenkins-bot: qa-browsertests-postmerge to create a tarball [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93995 (owner: 10Hashar) [20:09:30] What are the conventions wrt to color in CSS? HEX or are color names also okay? [20:09:52] siebrand: both are okay, i think, the color names are well-defined [20:10:16] siebrand: but in practice designs rarely use any predefined colors unless you're making something simple [20:10:44] MatmaRex: Could you glance over this one? Uses two color names I think I've seen for the first time, but I usually pay little attention to CSS... [20:10:48] https://gerrit.wikimedia.org/r/#/c/93740/2/lqt.css [20:11:12] <^demon|lunch> I know aquamarine is one. [20:11:15] MatmaRex: BF is on MediaWiki.org now, do you want to test it out? [20:11:30] siebrand: there are like 200 names defined, see https://en.wikipedia.org/wiki/X11_colors [20:11:43] siebrand: both seems to be on that list [20:11:46] seem* [20:11:50] k [20:13:30] <^demon|lunch> "Indian Red" [20:13:31] <^demon|lunch> Heh [20:14:23] (03CR) 10Aaron Schulz: [C: 032] More UX changes [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93918 (owner: 10CSteipp) [20:14:24] wow [20:14:35] (03Merged) 10jenkins-bot: More UX changes [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93918 (owner: 10CSteipp) [20:14:42] MatmaRex: re release-notes, yeah will read wikitech tomorrow or on monday [20:14:53] (03PS2) 10Hoo man: Revert "Declare visibility on class properties" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/93963 [20:14:56] heh [20:15:05] doh [20:15:08] hashar: tl;dr please set up jenkins to rebase using my merge driver before merging [20:15:19] (if it's possible) [20:15:32] (03Abandoned) 10Hoo man: Revert "Declare visibility on class properties" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/93963 (owner: 10Hoo man) [20:15:35] dr: don't have time for that right now:D [20:16:18] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 (owner: 10Hashar) [20:16:23] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [20:16:56] (03PS4) 10Aaron Schulz: Cleaned up DatabaseBase constructor to use an array [core] - 10https://gerrit.wikimedia.org/r/90653 [20:17:08] <^demon|lunch> bawolff: Heh, https://en.wikipedia.org/wiki/List_of_colors [20:18:24] marktraceur: ugh. it naturally still doesn't work, even though it worked when i wrote that patch [20:18:25] (03CR) 10CSteipp: "(4 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [20:18:33] marktraceur: the code is deployed all right, it just doesn't work [20:18:34] fuck me. [20:18:36] wtf. [20:18:46] Hah [20:19:01] MatmaRex: Try again, I guess? [20:19:05] Oh [20:19:12] ^demon|lunch: Reading the Wikipedia article about Indian red makes thing sound a lot less racist [20:19:15] MatmaRex: It was a CSS change, so it might be that the cache is fucked up again [20:19:28] marktraceur: no, the styles are being applied [20:19:33] (03CR) 10CSteipp: "And I always forget Siebrand is the opposite if Steipp with i's and e's. Sorry about that :)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [20:19:51] Who operated the bot that changes status in bugzilla based on gerrit changes? [20:19:59] (and where should I file a bug about it?) [20:20:17] <^demon|lunch> It's not a bot, it's a gerrit plugin. [20:20:25] <^demon|lunch> File in the usual place [20:20:43] Well [20:20:45] In that case [20:20:47] Hah [20:20:50] ^demon|lunch: Ah. In https://bugzilla.wikimedia.org/show_bug.cgi?id=48450#c10 it changed a status to "patch to review" when a patch set was abandoned... :) [20:21:10] <^demon|lunch> bawolff: Indeed. Just couldn't help notice the obvious connotation. [20:21:59] marktraceur: hmmmmmmmmmm. [20:22:16] <^demon|lunch> siebrand: That...sucks :\ [20:22:26] ^demon|lunch: yes :) [20:22:26] marktraceur: it looks like it works, but opera refuses to show the svg background D: [20:22:35] Aw no! [20:22:40] ugh [20:22:48] MatmaRex: I'll rewrite it in LESS and use the cool mixin for SVG/PNG fallbacks [20:22:56] anyway, that's probably just me [20:23:02] i don't think it's because of the fallbacks [20:23:08] opera supports SVG backgrounds all right [20:23:16] it's just that for me, they sometimes disappear [20:23:21] which is driving me mad [20:24:12] (03PS1) 10Brian Wolff: Don't use the "Pop-up" video viewer thing during iframe embed. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/93999 [20:24:33] ^demon|lunch: reported https://bugzilla.wikimedia.org/show_bug.cgi?id=56689. [20:24:42] <^demon|lunch> Thanks [20:25:28] marktraceur: so anyway, it works, except when it doesn't. but that's not debuggable anyway [20:26:23] i probably need more ram. the closer to swapping i am, the more often this kind of thing happens [20:27:58] (03CR) 10Siebrand: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [20:28:08] (03PS1) 10Hashar: rename qa-browsertests-{build,run} [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94000 [20:30:11] (03PS1) 10Hashar: qa-browsertests: always build before running tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94001 [20:30:18] (03CR) 10Hashar: [C: 032] rename qa-browsertests-{build,run} [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94000 (owner: 10Hashar) [20:30:27] (03Merged) 10jenkins-bot: rename qa-browsertests-{build,run} [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94000 (owner: 10Hashar) [20:30:45] (03CR) 10Bartosz Dziewoński: [C: 04-2] "This is the wrong project to submit this patch. It should be submitted to mediawiki/extensions/CategoryTree." [core] - 10https://gerrit.wikimedia.org/r/93993 (owner: 10Navdeep Bagga) [20:30:58] (03PS4) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [20:31:00] (03CR) 10Siebrand: "Is a non-JS fallback really needed here? I feel it may add code that will not be used that much. As this isn't an essential part of the UI" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [20:31:08] * MatmaRex weeps for clueless people [20:32:27] hey, we were all newbs once... :P [20:32:43] (03PS1) 10Hashar: qa-browsertests-run is now non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94002 [20:32:54] (03CR) 10Hashar: [C: 032] qa-browsertests-run is now non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94002 (owner: 10Hashar) [20:33:04] (03Merged) 10jenkins-bot: qa-browsertests-run is now non voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94002 (owner: 10Hashar) [20:33:49] <^demon|lunch> bawolff: Speak for yourself ;-) [20:34:04] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 (owner: 10Hashar) [20:34:34] (03PS5) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [20:35:40] ah yes, demons exist outside time, and always existed :P [20:36:10] (03CR) 10Siebrand: [C: 04-1] "-1, because I think something should be done to ensure the difference between Suppress and a username is made clear." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93953 (owner: 10Matthias Mullie) [20:37:25] hashar: Why are the exception-related backports to _22 not merged? [20:37:38] (03CR) 10Siebrand: [C: 032] Native digits on campaign uploads and contributions numbers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 (owner: 10Ebrahim) [20:37:45] (03Merged) 10jenkins-bot: Native digits on campaign uploads and contributions numbers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 (owner: 10Ebrahim) [20:40:03] (03CR) 10Siebrand: [C: 032] "(1 comment)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/93771 (owner: 10Ebrahim) [20:40:07] (03Merged) 10jenkins-bot: Native digits on Special:TimedMediaHandler [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/93771 (owner: 10Ebrahim) [20:41:43] (03CR) 10Mdale: [C: 032 V: 032] "Looks like a good way to fix this issue. More details on bug 56405 thread." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/93999 (owner: 10Brian Wolff) [20:42:03] (03CR) 10Siebrand: [C: 032] "Thank you!" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/93079 (owner: 10Ebrahim) [20:42:11] (03CR) 10Siebrand: [V: 032] Native digits on $revsSince [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/93079 (owner: 10Ebrahim) [20:43:32] (03PS1) 10Hashar: Revert "rename qa-browsertests-{build,run}" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94005 [20:43:40] (03CR) 10Hashar: [C: 032] Revert "rename qa-browsertests-{build,run}" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94005 (owner: 10Hashar) [20:44:16] (03Merged) 10jenkins-bot: Revert "rename qa-browsertests-{build,run}" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94005 (owner: 10Hashar) [20:47:25] (03PS1) 10Aaron Schulz: Catch temp container thumbnails in cleanup script [core] - 10https://gerrit.wikimedia.org/r/94019 [20:47:28] (03PS2) 10Hashar: qa-browsertests: always build before running tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94001 [20:48:52] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/94023 (owner: 10L10n-bot) [20:49:36] (03CR) 10Hashar: [C: 032] qa-browsertests: always build before running tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94001 (owner: 10Hashar) [20:49:53] csteipp: https://gerrit.wikimedia.org/r/#/c/94019/ random commit [20:50:58] lots of these 120px-hash.hash.number.jpg files [20:54:54] (03Merged) 10jenkins-bot: qa-browsertests: always build before running tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94001 (owner: 10Hashar) [20:56:52] (03PS6) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [20:57:27] AaronSchulz: patch is fine if your regex is right.. are you really sure about it?? [20:58:03] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 (owner: 10Parent5446) [21:01:57] (03CR) 10Legoktm: "If you look at the bug, some kind of fallback is needed. Right now we have a link that is shown to all users, but does absolutely nothing " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 (owner: 10Legoktm) [21:03:56] (03PS1) 10MarkTraceur: Update TimedMediaHandler to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94045 [21:04:17] (03CR) 10MarkTraceur: [C: 032 V: 032] Update TimedMediaHandler to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94045 (owner: 10MarkTraceur) [21:05:35] I need to get a change made to a template on en.wp. Anyone who can help me with that? It's used on the main page, and should have a CSS class added. [21:06:26] (03CR) 10Krinkle: [C: 04-1] "(5 comments)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [21:06:53] hashar: [21:09:35] siebrand: errr, I made CommonsDelinker a template editor. I guess the email went to you? [21:09:40] (03PS7) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [21:12:19] legoktm: I totally don't understand your comment. Please elaborate. [21:13:38] siebrand: I added the CommonsDelinker account to the template editor group, which sent the email to your email account, so you thought I added you to the group. [21:14:11] legoktm: ah! [21:14:17] legoktm: Thanks for explaining :) [21:14:37] np :) [21:14:42] legoktm: I guess "you" is wrong for that message, and should apparently mention a specific account name. [21:14:53] legoktm: Can you edit protected templates on en.wp? [21:14:58] probably. I think there's a bug somewhere for that [21:15:05] Yes, I'm an admin :) [21:15:39] legoktm: I'd like to propose some changes to https://en.wikipedia.org/wiki/Template:Wikipedia_languages. Should I make a copy, and ask you to make those changes based on that copy? [21:16:11] yeah, that would be best [21:16:50] legoktm: The autonyms need the class "autonym" so that no fonts but the Autonym font are being applied/loaded for them. [21:17:02] legoktm: There are two ways to do that, from what I can see. [21:17:37] (03PS8) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 [21:18:03] legoktm: Can add it to Template:Wikipedia languages/core, which causes many sections to have the class, or we can add it 4 times in https://en.wikipedia.org/wiki/Template:Wikipedia_languages [21:18:18] legoktm: What do you think is best (the latter option "feels" faster to me) [21:18:33] i like the latter one too [21:19:04] (03CR) 10Krinkle: "@MatmaRex: Thanks, to explain:" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 (owner: 10MarkTraceur) [21:19:18] legoktm: Okay, will work on that. [21:19:25] legoktm: ETA 3 mins. [21:20:21] (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [21:20:50] :) [21:22:33] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 (owner: 10Hashar) [21:23:31] legoktm: aharoni had already made the change in the /core template. [21:23:43] legoktm: I was wondering why I couldn't reproduce it anymore... [21:25:00] heh [21:25:00] :D [21:27:18] (03CR) 10Krinkle: [C: 032] Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93701 (owner: 10Hashar) [21:27:32] hashar: [21:27:43] (03CR) 10Krinkle: "@Hashar: Ping, see irc." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/57292 (owner: 10Hashar) [21:30:27] (03Merged) 10jenkins-bot: Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93701 (owner: 10Hashar) [21:33:53] (03CR) 10Krinkle: [C: 032] exception: Use MWExceptionHandler::logException in more places [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93702 (owner: 10Hashar) [21:34:02] Krinkle: I can't see your text on irc sorry :D [21:34:28] hashar: Those last 2 were empty pings to get your attention, I said something earlier [21:34:36] ahh [21:34:38] I was asking why those 2 exeption-related commits were not merged [21:34:50] I thought you were sending white text which would not have worked with my white background [21:35:11] I have cherry picked a bunch of changes related to exceptions [21:35:16] and submitted a merge commit for it [21:35:20] merge --no-ff [21:35:31] top change is https://gerrit.wikimedia.org/r/#/c/93705/ [21:36:20] MatmaRex: I'm splitting out oojs-ui (split off from the generic parts of ve.ui) into its own repo, and I'm now writing an AUTHORS.txt file. Should I credit you as MatmaRex (which is what the git authorship data shows me) or with your real name? [21:37:09] (03Merged) 10jenkins-bot: exception: Use MWExceptionHandler::logException in more places [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93702 (owner: 10Hashar) [21:37:13] RoanKattouw: hm, did i commit anything worth crediting there? [21:37:26] RoanKattouw: anyway, full name pretty please [21:37:40] Krinkle: bah :( [21:37:42] One commit, "Ensure ve-ui-panelLayout-scrollable is actually scrollable" [21:37:50] (my newer commits for mediawiki things use full name too) [21:37:52] Krinkle: Gerrit sucks. It should blocks the commits till the merge commit is merged in :( [21:38:02] You wrote like 2 lines of CSS that made it in, so you're listed as a minor contributor [21:38:08] well, not sure if that's worth crediting me as an author, but feel free to :P [21:38:31] There's a separate section for major contributors [21:38:38] I ran the numbers and Trevor blows everyone out of the water, of coures [21:38:42] (Bartosz Dziewoński ) [21:38:46] hah [21:38:59] http://pastebin.com/x71iwdZr [21:39:05] Mediawiki RFC review meeting in 20 minutes in #wikimedia-meetbot. Details at https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2013-11-06. Previous meeting notes at http://etherpad.wikimedia.org/p/RFC%20review [21:40:27] That's 40.5% of all commits in oojs-ui made by Trevor [21:42:09] csteipp: the regex looks fine [21:42:23] it's based straight of what I'm seeing in the output of the script [21:42:43] (03PS1) 10Hashar: mediawiki-selenium-gembuild job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94052 [21:42:49] (03CR) 10Krinkle: [C: 04-2] "Eh, redundant/unwanted merge commit?" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93705 (owner: 10Hashar) [21:42:54] (03CR) 10Hashar: [C: 032] mediawiki-selenium-gembuild job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94052 (owner: 10Hashar) [21:43:14] (03PS1) 10Aaron Schulz: Catch temp container thumbnails in cleanup script [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94053 [21:43:23] (03CR) 10CSteipp: [C: 032] "Aaron says the regex is correct. The rest looks fine." [core] - 10https://gerrit.wikimedia.org/r/94019 (owner: 10Aaron Schulz) [21:43:34] (03PS1) 10Aaron Schulz: Catch temp container thumbnails in cleanup script [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/94054 [21:43:46] hashar: Why? Just backport them one by one. There shouldn't be any merge commits in review in our model, and also no need to keep them pending. Just merge them. [21:43:51] (03Merged) 10jenkins-bot: mediawiki-selenium-gembuild job [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/94052 (owner: 10Hashar) [21:44:07] (03Abandoned) 10Krinkle: merge exception logging changes from master [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93705 (owner: 10Hashar) [21:44:13] (03CR) 10Aaron Schulz: [C: 032] Catch temp container thumbnails in cleanup script [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/94054 (owner: 10Aaron Schulz) [21:44:21] (03CR) 10Hashar: "Na the merge commit is intended. It should have been +2ed then the previous changes reviewed and +2 until the oldest one. That would have" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93705 (owner: 10Hashar) [21:44:27] (03CR) 10Aaron Schulz: [C: 032] Catch temp container thumbnails in cleanup script [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94053 (owner: 10Aaron Schulz) [21:44:40] hashar: The merge commit is redundant, there is nothing to resolve against afaics [21:44:47] the commits are all linear on top of REL1_22 [21:44:50] just +2 from the bottom up [21:44:51] Krinkle: that was not the point [21:45:10] Krinkle: the idea was to make it obvious they are all linked together. but that is not a big deal :D [21:45:36] The commits are atomic and reviewed separately in core, so they can be backported as such as well. Shouldn't be an issue. [21:45:55] Afaik redundant noise (perhaps use a common topic of you like). Anyway.. [21:46:30] especially because the commit is empty, and the merge commit didn't actually "link" those 4 commits. It just was a no-op merge between the top of that stack and the current head of rel1_22 [21:46:48] (03PS1) 10Hashar: trigger mediawiki-selenium-gembuild on postmerge [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94055 [21:46:50] I don't mind it, but I think we should avoid it for sake of consistency and clearity in the current model. [21:47:04] (03CR) 10Hashar: [C: 032] trigger mediawiki-selenium-gembuild on postmerge [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94055 (owner: 10Hashar) [21:47:53] Krinkle: the --no-ff : http://paste.debian.net/64404/ [21:48:17] (03Merged) 10jenkins-bot: Catch temp container thumbnails in cleanup script [core] - 10https://gerrit.wikimedia.org/r/94019 (owner: 10Aaron Schulz) [21:48:58] I don't think that would've ever reflected in core, only on your local copy [21:49:30] it would [21:49:42] if you +2 / submit the changes from the most recent one to the oldest [21:49:57] the most recent would be blocked because a dependent change is not submitted yes [21:49:59] yet [21:50:04] anyway, like I said, I don't mind it, it is just unusual/uncommon in our model. We tend to use other methods to group them (topics, comments, .. ), not no-op merge commits to annotate the branch history :-/ [21:50:12] when you ends up approving the oldest one, Gerrit unleash them all :] [21:50:19] I was merely trying it [21:50:25] hashar: No, in that case you don't need the merge commit. Gerrit automatically merges multiple commits together if they are +2'ed from top to bototm [21:50:27] and went ahead and submitted the whole chain [21:50:31] it will create that merge commit for you. [21:50:35] ahh [21:51:13] it'd be like "Merge change Iaaa, Iccc, Iddd, Ifff" [21:51:35] There's a few of those in VE history from RoanKattouw, who likes to do that :) [21:51:57] (03Merged) 10jenkins-bot: Catch temp container thumbnails in cleanup script [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/94054 (owner: 10Aaron Schulz) [21:51:57] !g I58ad0a2aac51fcb5e2b10c2452bf24d50c341540 [21:51:57] https://gerrit.wikimedia.org/r/#q,I58ad0a2aac51fcb5e2b10c2452bf24d50c341540,n,z [21:52:00] anyway, that's just an implementation detail. [21:52:02] (03Merged) 10jenkins-bot: trigger mediawiki-selenium-gembuild on postmerge [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/94055 (owner: 10Hashar) [21:52:04] Krinkle: indeed :) [21:52:12] Krinkle: the most important is to get all of them in REL1_22 :D [21:53:28] Krinkle: while I am around, I will upgrade Zuul to be gearman based, most probably next week on wednesday morning. [21:53:32] (03Merged) 10jenkins-bot: Catch temp container thumbnails in cleanup script [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/94053 (owner: 10Aaron Schulz) [21:53:34] haven't scheduled it yet though [21:53:48] annnd will finally have Zuul upgradde :] [21:53:50] hashar: estimated down time? [21:53:59] a couple hours during european morning [21:54:36] but there is still a bunch of stuff I need to finalize [21:54:44] so might not be able to upgrade it next week [21:54:52] OK. Be sure to let people know via mailing list (and best to try again later if jenkins-bot is not responding or incorrectly failing the change) [21:55:11] yeah I got way to revert the change [21:55:43] I mean, for other people, best for them to try again later if jb is not responding.. ^ [21:55:49] ah yeah [21:56:08] I do all my maintenance during european morning and ping the wikidata / i18n folks :] [21:56:44] but yeah [21:56:51] scheduling + mailing list. definitely [21:57:13] (03PS1) 10Manybubbles: Send updates for link counts instead of indexes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94057 [21:57:57] i am off to bed [21:57:59] late already [21:58:31] (03CR) 10Manybubbles: "This is a pretty nasty one and I'd like to get it deployed in tomorrow so we can repair the damage this thing caused." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/94057 (owner: 10Manybubbles) [21:58:47] Tim-away, hi, see you at #wikimedia-meetbot ... now! [21:59:10] (03CR) 10Anomie: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 (owner: 10CSteipp) [22:02:02] ^demon|lunch: -> #wikimedia-meetbot for RFC meeting? [22:04:42] jdlrobson: Are you going to make the rfc meeting to talk about Allow styling in templates? [22:21:32] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [22:27:27] (03CR) 10Krinkle: [C: 04-1] "Thanks for your patch, these files were missing much needed reference protection." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/92666 (owner: 10Cillian.deRoiste) [22:35:14] (03PS2) 10Krinkle: Peserve jQuery references to avoid conflicts [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/92666 (owner: 10Cillian.deRoiste) [22:36:08] (03CR) 10Krinkle: [C: 032] Peserve jQuery references to avoid conflicts [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/92666 (owner: 10Cillian.deRoiste) [22:36:13] (03Merged) 10jenkins-bot: Peserve jQuery references to avoid conflicts [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/92666 (owner: 10Cillian.deRoiste) [22:53:36] Krinkle: regarding global js/css and adding a constructor, I don't see where the object would be created and how to specify what options get passed to it [22:54:02] legoktm: the $modules array you have with 'class' => globalusermodule, that options array is passed to the constructor [22:54:13] it is transparently handled by the resourceloader module registry and construction [22:54:30] oh. awesome :D [22:57:08] ^d: Hey so I want to create Gerrit projects for oojs and oojs-ui. Do you have any guidance as to naming for those? [22:57:51] <^d> Maybe if I knew what oojs and oojs-ui were :p [22:57:52] Background: oojs is a JS library that provides utilities for building object-oriented structures in JS (Java in JS, kind of) that was split out of VisualEditor, oojs-ui is a UI widget library that's built on top of oojs and was also broken out of VE [22:58:07] RoanKattouw: ^d: Also, lets make sure they have sensible node-library style names on github (so oojs and oojs-ui, no prefixes beyond that) [22:58:09] oojs is currently in github (ugh), oojs-ui has only just been split [22:58:23] <^d> Java in JS? You guys are trying to do the opposite of GWT? [22:58:38] oojs-ui now has a very very temporary home in github but it has no non-Gerrit commits, it's just a filter-branch of VE at this point [22:58:42] I suspect we'll want to do something like oojs/oojs.git and oojs/oojs-ui.git or oojs/core.git and oojs/ui.git [22:58:46] ^d: they implemented classes in JS. *shudder* [22:58:49] oojs has a history that grew entirely on github IIRC [22:59:07] Krinkle: I suppose that makes sense, yeah [22:59:20] <^d> I don't care too much, you seem to have a better idea of where you want it :) [22:59:24] and then change the puppet config to replicate to different names on github, like we already do for labs projects. [22:59:42] <^d> Just remember if you don't want them to replicate 1:1 like they do now you'll have to adjust manifests/role/gerrit.pp [22:59:49] OK [22:59:55] So do I change that before or after creating the projects? [23:02:27] Depends on whether that config breaks gerrit if it contains a ref that doesn't exist. I think it should be okay to do the gerrit config first, that way we won't need someone to delete the other one on github later. Unless the gerrit config you referred to makes alias in addition to the regular one, in which case it doens't matter. [23:02:31] ^d: Which is it? [23:02:33] <^d> RoanKattouw: Good question. [23:02:40] <^d> Before should be safest. [23:02:44] k [23:02:49] <^d> After means you're more likely to have cleanup to do later. [23:03:22] hmm, this looks scary [23:07:47] RoanKattouw: James_F|Away: https://bugzilla.wikimedia.org/show_bug.cgi?id=56698 [23:08:33] Krinkle: Some oojs-ui bugs can be moved from VE as well [23:08:51] Yep [23:09:26] Krinkle: btw, i'm sorry for not re-reviewing the RL patch yet, crazy week [23:11:20] So, bd808 points out that https://gdash.wikimedia.org/dashboards/reqerror/deploys has some worrisome-looking 5xx peaks [23:11:35] It would be nice to see what those are and make sure they weren't caused by my scaps [23:11:55] Anyone have a pointer to where I can see them? [23:12:06] marktraceur: ssh to fluorine, look at /a/mw-log/fatals.log [23:12:06] Krinkle, ^d: Please CR https://gerrit.wikimedia.org/r/94063 [23:13:24] ori-l: Are all 5xx errors reported there? If so I saw them coming in and they weren't related. [23:13:52] You'll note it's not a 500 response, because the 500 line didn't spike during the same period [23:13:57] It's probably 503 or something [23:14:04] No fatals.log is only PHP fatals [23:14:13] Which are a subset (vast majority) of 500s [23:14:26] But don't include 502/503/other 5xx [23:15:13] <^d> RoanKattouw: lgtm. Lemme know when you want it live, we'll have to reload the replication plugin after puppet puts the conf live. [23:15:27] Can we put it live before the repo exists? [23:15:35] If so, let's just put it live as soon as reasonably possible [23:16:06] <^d> Yeah we should be able to :) [23:16:19] (03PS1) 10Nemo bis: Add direct links to translation interface on Special:AllMessages [core] - 10https://gerrit.wikimedia.org/r/94064 [23:16:55] csteipp: any reason i can't login to wikipedia right now? [23:16:58] (03PS8) 10Legoktm: (bug 13953) Allow global user CSS/JS. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [23:18:29] (03CR) 10Legoktm: "(5 comments)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [23:18:31] AaronSchulz: How far down on your never ending list of things to do is the architecture review for GWToolset? [23:19:27] * AaronSchulz was looking at temp files in swift now [23:19:35] ^d: k, then let me know when it's live and once it is, I will create the repos and push stuff into them [23:19:50] <^d> Well it's gotta merge on puppetmaster :) [23:20:29] * AaronSchulz also is dealing with some unexpected slowness with a sanity file copy script [23:21:40] ^d: No rush, just let me know when it's done [23:21:53] (03CR) 10Nemo bis: "Tested, seems to work quite well even with extremely long messages, parameters and stuff. For instance, http://nemobis.altervista.org/w/in" [core] - 10https://gerrit.wikimedia.org/r/94064 (owner: 10Nemo bis) [23:23:16] AaronSchulz: Understood. /me knows you are busy. Any chance of getting to it by the end of next week? [23:24:19] maybe, all I can now is that I don't think that first phase will work (no chunked upload for the xml file) [23:24:42] x00mb uploads don't really fly like that [23:24:47] (03CR) 10Mattflaschen: [C: 04-1] "(10 comments)" [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [23:26:34] dan-nl: ^^ Have you looked into the chunked upload addition at all? I think what Aaron is staying is that you are going to have to expect a much lower max file size without them. [23:28:34] bd808: no i haven't looked into the chunked uploading yet [23:29:12] bd808, so a 100mb upload or even 50mb upload without chunked upload will most likely fail? [23:32:43] (03CR) 10Werdna: [C: 032] "Thanks for the adjustments!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 (owner: 10Matthias Mullie) [23:32:49] (03PS1) 10Chad: Work around HHVM bug with stdin/stdout in proc_open() [core] - 10https://gerrit.wikimedia.org/r/94065 [23:32:54] AaronSchulz, bd808: so if we limit the file size for direct uploads. what would work? [23:32:54] (03Merged) 10jenkins-bot: (bug 56277) Update RecentChanges to use history i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 (owner: 10Matthias Mullie) [23:33:18] (03CR) 10Chad: "Untested, will test shortly :)" [core] - 10https://gerrit.wikimedia.org/r/94065 (owner: 10Chad) [23:33:44] dan-nl: I'm going to look at the commons config for a reasonable answer… hang on [23:33:52] (03PS14) 10AlephNull: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 [23:34:47] dan-nl: I think 500MB would be the hard upper limit [23:34:54] (03CR) 10AlephNull: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [23:34:56] (03PS2) 10Chad: Work around HHVM bug with stdin/stdout in proc_open() [core] - 10https://gerrit.wikimedia.org/r/94065 [23:35:21] bd808: that should cover the xml metadata file. we haven't seen anything over 250mb yet [23:35:29] dan-nl: But what Aaron is implying is that the hard limit and the reality may differ [23:35:57] bd808: i will look into chunked uploading [23:36:31] * bawolff thought 100mb was limit for direct upload [23:37:06] (03CR) 10jenkins-bot: [V: 04-1] MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [23:37:07] my concern then is the media files … if they're videos ... [23:37:23] regardless of config, it's just hard to get those uploads to be reliable (you'll get 504s back) [23:37:54] chunking+assembly/completion polling was done to avoid that [23:38:03] k, is that 500mb limit also for background jobs … let's say someone tries to upload a 600mb video [23:38:22] dan-nl: I haven't looked in a while, but I thought the extension was downloading the video files, the upload limit shouldn't apply to server side downloads [23:38:28] that will be 1GB soon [23:38:36] assuming erik's patch is merged [23:39:25] bawolff: that's correct it will be downloading the media files from an external site [23:40:09] would there be an issue there on a 1gb video file being downloaded? [23:40:17] ^d, any ideas what will happen to wikidiff2 once we move to hhvm - will it need to be ported, or hiphop is fast enough? [23:43:00] I don't think so, downloading is a much more reliable process than uploading, and probably shouldn't have the same issues. However I imagine there is some point where mediawikis file handling capabilities don't work as well for big files, swift might have some arbitrary limit on file size or something like that [23:43:47] (03PS15) 10AlephNull: MySQL method to find out view + fix fatal in tests [core] - 10https://gerrit.wikimedia.org/r/65301 [23:43:54] thanks … i'll see if i can quickly sort out the chunked upload for the metadata files. [23:46:02] (03CR) 10AlephNull: "Ooops, dang, I missed a typo causing the build to fail. As they say at Vistaprint "You break the build, your code gets killed!"" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [23:47:14] (03CR) 10Parent5446: "I'm still really hesitant about the whole expiration being set by a hook thing. It's almost like saying that the functionality is extensio" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [23:55:12] (03PS1) 10Werdna: Fix bug where VE editor was not being loaded correctly. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94067 [23:55:40] (03CR) 10EBernhardson: [C: 032] Fix bug where VE editor was not being loaded correctly. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94067 (owner: 10Werdna) [23:55:53] (03Merged) 10jenkins-bot: Fix bug where VE editor was not being loaded correctly. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/94067 (owner: 10Werdna) [23:57:36] ori-l: So, wanna talk about ve.track() in an optimistic serialization world? [23:58:09] RoanKattouw: sure, are you in the office? [23:58:48] Yes [23:59:30] ori-l: I'll wander over in a minute [23:59:47] OK