[00:05:44] ori-l, I just noticed that for some reason I'm not able to import things using a relative path in LESS even though this: https://github.com/leafo/lessphp/pull/144 was fixed 2 years ago... do you have any idea why this might be happening? [00:14:47] (03Merged) 10jenkins-bot: Fix editing of posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93485 (owner: 10Matthias Mullie) [00:16:04] (03PS2) 10Gergő Tisza: Shorter text for license link [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93608 [00:16:06] jgonera: Example? [00:19:11] (03Merged) 10jenkins-bot: Post reply is broken due to a mismatch of a clas name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93614 (owner: 10Bsitu) [00:22:49] Elsie, a.less imports something/b.less, then something/b.less wants to import something/c.less and @import "c.less"; doesn't work, but @import "something/c.less"; does [00:23:03] (03Merged) 10jenkins-bot: ext.echo.overlay: Only build the 'mark all as read' button if it's used [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93112 (owner: 10Bartosz Dziewoński) [00:32:18] jgonera: I'm not sure; file a bug if you're seeing something that looks wrong. [00:32:41] ok, I'll see if I can replicate this outside of MW [00:33:19] I'm not sure it's unexpected behavior... but I agree with Ori. [00:35:01] magic... now it works... [00:35:10] (03PS1) 10Gergő Tisza: Make category-related code more readable [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93625 [00:35:18] Heisenbugs abound. :-) [00:35:33] anyway, I discovered another thing, if you try to @import something that doesn't exist, it doesn't throw any exception [00:35:47] It --> the compiler? [00:35:55] probably another patch for lessphp needed ori-l, will check it later [00:35:58] Elsie, probably [00:36:14] Elsie, or we're swallowing it somewhere [00:36:22] If you find bugs, you can file them at https://bugs.wikimedia.org [00:36:28] Maybe. [00:36:42] Only if you're really bored [00:36:48] yes, I know Elsie ;) [00:36:49] We don't want more owrk [00:37:08] I just usually fix the ones I find myself [00:37:18] jgonera: selfish! [00:39:51] (03PS7) 10JGonera: Port mediawiki.ui SASS to LESS [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [00:45:14] (03PS8) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [00:45:21] (03PS1) 10Aaron Schulz: Cleanups to DB transaction handling [core] - 10https://gerrit.wikimedia.org/r/93627 [00:48:36] ^d: https://gerrit.wikimedia.org/r/#/c/93603/ is tiny :) [00:48:53] (03CR) 10Chad: [C: 032] Include server in redis lua errors [core] - 10https://gerrit.wikimedia.org/r/93603 (owner: 10Aaron Schulz) [00:52:24] <^d> AaronSchulz: https://gerrit.wikimedia.org/r/#/c/93622/ isn't so small :p [00:52:32] <^d> But I'm about 95% sure it works. [00:53:16] (03Merged) 10jenkins-bot: Include server in redis lua errors [core] - 10https://gerrit.wikimedia.org/r/93603 (owner: 10Aaron Schulz) [00:53:38] (03CR) 10Aaron Schulz: [C: 032] API: Have action=parse indicate hidden categories [core] - 10https://gerrit.wikimedia.org/r/87187 (owner: 10Anomie) [00:57:26] (03Merged) 10jenkins-bot: API: Have action=parse indicate hidden categories [core] - 10https://gerrit.wikimedia.org/r/87187 (owner: 10Anomie) [00:58:06] (03CR) 10Werdna: [C: 032] Post link in notification should take users to specific post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93583 (owner: 10Bsitu) [00:58:53] (03Merged) 10jenkins-bot: Post link in notification should take users to specific post [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93583 (owner: 10Bsitu) [01:17:57] (03PS2) 10MaxSem: Add a custom terms of use message and a hook to set it up [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/92993 [01:22:43] (03CR) 10Werdna: [C: 032] Only link to history if there are changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93487 (owner: 10Matthias Mullie) [01:25:02] (03PS2) 10Werdna: (bug 56335) Timestamp jumps to the left on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93453 (owner: 10Matthias Mullie) [01:25:39] (03CR) 10Awjrichards: [C: 032] "w00t thanks!" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/92993 (owner: 10MaxSem) [01:25:40] (03CR) 10Werdna: [C: 032] "Changed the commit message to coax Jenkins into doing his/her job." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93453 (owner: 10Matthias Mullie) [01:25:59] (03PS1) 10Reedy: Invalid argument supplied for foreach() in FormatMetadata.php on line 1566 [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93630 [01:27:33] (03Merged) 10jenkins-bot: Only link to history if there are changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93487 (owner: 10Matthias Mullie) [01:28:43] (03Merged) 10jenkins-bot: Add a custom terms of use message and a hook to set it up [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/92993 (owner: 10MaxSem) [01:28:53] (03Merged) 10jenkins-bot: (bug 56335) Timestamp jumps to the left on hover [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93453 (owner: 10Matthias Mullie) [01:54:08] spagewmf: did you ever get to setting up another flow instance? [02:22:57] RoanKattouw: any idea what 'remote: (W) No changes between prior commit bc9de99 and new commit 90679ca' means/ [02:23:02] when trying to push to gerrit [02:23:36] legoktm: ^ [02:23:37] Did you get any more messages than that? [02:23:46] To ssh://yuvipanda@gerrit.wikimedia.org:29418/apps/android/wikipedia [02:23:46] ! [remote rejected] HEAD -> refs/publish/master/93424 (no changes made) [02:23:46] error: failed to push some refs to 'ssh://yuvipanda@gerrit.wikimedia.org:29418/apps/android/wikipedia' [02:23:50] RoanKattouw: ^ [02:23:55] RoanKattouw: right after a rebase [02:24:12] RoanKattouw: commit bc9de99 doesn't exist [02:24:17] which is... weird [02:24:30] Open the Gerrit page for that change [02:24:35] !g 93424 [02:24:35] https://gerrit.wikimedia.org/r/#q,93424,n,z [02:24:51] hah, no bc9de99, you're right [02:25:09] OK, clearly Gerrit is on crack [02:25:20] I recommend you make a change to that commit's summary and try again [02:25:34] RoanKattouw: 90679ca exists and is the previous commit [02:26:04] RoanKattouw: ! [remote rejected] HEAD -> refs/for/master (duplicate request) [02:26:04] wat [02:26:46] maybe i should try a new change-id [02:27:03] Oooh [02:27:08] No no [02:27:11] Don't do a new change ID [02:27:18] What does 'git show 90679ca' show? [02:27:21] RoanKattouw: tried it, ! [remote rejected] HEAD -> refs/for/master (no changes made) [02:27:25] for new change id [02:27:29] let me revert back to old change id [02:27:37] Does it show a diff? Because I fear the commit may literally be empty [02:27:41] RoanKattouw: yes, it does show a diff [02:27:46] hah [02:27:47] I... don't think so [02:30:25] RoanKattouw: 90679ca is https://gerrit.wikimedia.org/r/#/c/93420/2 [02:30:37] RoanKattouw: locally, that is [02:31:39] And what is bc9de99 ? [02:31:47] RoanKattouw: doesn't exist [02:31:58] RoanKattouw: fatal: ambiguous argument 'bc9de99': unknown revision or path not in the working tree. [02:32:35] OK so maybe that's part of Gerrit being on crack [02:32:45] You could try making minor edits to commit summaries [02:32:49] already tried [02:32:55] RoanKattouw: ! [remote rejected] HEAD -> refs/for/master (duplicate request) [02:33:12] these are like, 7 changes that are dependent on each other lienarly [02:33:24] I could abandon them all and push again, but I bet I'll have to change the Change-Id manually [02:33:29] WTF [02:33:29] which sounds painful [02:33:37] It's actually not that bad [02:33:44] Change-Id manually? [02:33:52] Removing and regenerating the Change-Id's is easy to automate [02:33:56] RoanKattouw: i'll also lose the comments that brion had made on a few of them alreay [02:34:01] which is a bit more painful [02:34:08] Yeah that would suck, so let's avoid that [02:34:12] yeah [02:34:16] Did you make material changes to any of these? [02:34:19] yeah [02:34:20] one [02:34:33] https://gerrit.wikimedia.org/r/#/c/93422/ [02:34:57] OK [02:35:02] Might I note that that one has an outdated dependency [02:35:45] RoanKattouw: sure, but if I push now, shouldn't that dependency get automatically updated/ [02:35:54] Depends on what you're pushing [02:36:02] let me hit rebase [02:36:20] no help [02:36:57] RoanKattouw: rebased 'em all, still ! [remote rejected] HEAD -> refs/for/master (no changes made) [02:37:00] grr [02:37:41] wtf [02:38:40] RoanKattouw: okay, so I got it to work [02:39:18] RoanKattouw: git review -d 93632, git rebase -i gerrit/master, edit that particular commit I wanted to update, copy paste changes from previous branch (now renamed fuckall), git commit --amend, git rebase --continue, then push [02:39:42] RoanKattouw: which is also the exact sequance of steps I did the last time [02:39:54] Hm [02:40:31] RoanKattouw: Gerrit does seem to be on crack [02:40:45] no idea why it worked this time and didn't the last time [02:40:52] OK let me take that stack and amend the whole thing [02:40:59] Just changing Committer: to my name [02:41:26] RoanKattouw: ok [02:43:14] Right I also get remote: (W) No changes between prior commit bc9de99 and new commit 36b29b5 , but that's fair, I didn't change the commit summaries [02:43:32] RoanKattouw: you changed commiter but? [02:43:55] There [02:43:59] RoanKattouw: right, that went through [02:44:05] I removed the period at the end of the summary of the bottom commit [02:44:15] That qualifies as a change, and the others qualify because they're rebasese [02:44:30] It's already rebased onto master BTW, I ran git rebase master but that said it was already up-to-date [02:44:36] right. But I substantially changed the code itself, and *that* doesn't? [02:44:45] RoanKattouw: yes, it's rebased because I pushed my stuff [02:44:55] haha [02:48:23] RoanKattouw: lol [02:48:24] RoanKattouw: ! [remote rejected] HEAD -> refs/for/master (no changes made) [02:48:25] again [02:48:28] rebased first change [02:48:43] I think Gerrit is trying to be smart here, and failing miserably somewhere [02:50:12] RoanKattouw: that worked [02:50:26] RoanKattouw: so yay? [02:51:09] yay [02:52:25] RoanKattouw: dinner later? [02:53:21] Ideally now-ish, I'm hungry [02:53:35] RoanKattouw: sure. tell me when you want me to pack up [03:45:30] (03PS1) 10Catrope: Update VisualEditor to wmf2 branch for cherry-pick [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93643 [03:46:22] (03PS1) 10Catrope: Update VisualEditor to wmf1 branch for cherry-pick [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93644 [03:46:37] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf2 branch for cherry-pick [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93643 (owner: 10Catrope) [03:46:49] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf1 branch for cherry-pick [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93644 (owner: 10Catrope) [04:13:01] Fatal error: Call to undefined function wddx_deserialize() in /srv/mw/core/tests/phpunit/includes/api/format/ApiFormatWddxTest.php on line 14 [04:15:25] the mind boggles [04:18:22] (03PS8) 10Mayankmadan: Add ability to show the time taken by update.php [core] - 10https://gerrit.wikimedia.org/r/93323 [04:19:42] siebrand: you've worked on WikiBhasha? [04:45:59] (03CR) 10GWicke: "I'm not sure what the privacy implications of logging a full user agent string is. Could we normalize the agent before saving it?" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93526 (owner: 10Ori.livneh) [05:07:27] (03PS1) 10Tim Starling: [WIP] Script to fix bug 53687 (failure of revision row deletion) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/93645 [05:29:49] (03CR) 10MZMcBride: "I have a stupid question: where do events get logged to? I looked at https://meta.wikimedia.org/wiki/Schema:LoginUserAgent and couldn't se" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93526 (owner: 10Ori.livneh) [05:29:57] (03PS3) 10Spage: Demonstrate use of oo-ui [extensions/Agora] - 10https://gerrit.wikimedia.org/r/93525 [05:35:39] FAILURES! [05:35:40] Tests: 8152, Assertions: 433705, Failures: 32, Errors: 62, Skipped: 74. [05:36:16] Time: 13.96 minutes, Memory: 1237.00Mb [05:36:36] this is on plain master, after fixing the wddx test [05:36:50] and people wonder why I don't run phpunit before every commit [05:51:23] (03PS2) 10Werdna: Recursive function should also perform callback on initial element (usually topic title) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93481 (owner: 10Matthias Mullie) [05:52:49] (03CR) 10Werdna: "PS2: Added short-circuit if finishing a child finishes all callbacks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93481 (owner: 10Matthias Mullie) [06:07:57] (03PS1) 10Tim Starling: ApiFormatWddxTest @requires wddx_deserialize [core] - 10https://gerrit.wikimedia.org/r/93647 [06:54:38] (03CR) 10Werdna: "(8 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [06:55:22] (03CR) 10Werdna: [C: 04-1] Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [07:14:50] (03PS1) 10IAlex: Change mode of non-executable files back to 0644 [core] - 10https://gerrit.wikimedia.org/r/93649 [07:42:56] (03PS13) 10Legoktm: Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [07:47:37] (03CR) 10Legoktm: "The code is pretty much ready for review at this point, nothing has blown up in my tests so far :)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [08:05:11] (03PS1) 10Legoktm: Move ManualLogEntry to RecentChange logic into own function [core] - 10https://gerrit.wikimedia.org/r/93653 [08:05:49] (03CR) 10Legoktm: "Where this will come in handy: https://gerrit.wikimedia.org/r/#/c/92053" [core] - 10https://gerrit.wikimedia.org/r/93653 (owner: 10Legoktm) [08:09:49] (03PS1) 10Legoktm: Add comment to updateCheckUserData indicating other extensions may call it [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/93654 [08:10:16] (03CR) 10Legoktm: "(3 comments)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 (owner: 10Legoktm) [08:10:28] (03PS3) 10Legoktm: Send AbuseFilter hits to CheckUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 [08:11:01] (03PS1) 10Amire80: Handle the case of zero users enabling the feature [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93655 [08:17:29] (03PS1) 10Amire80: Add more plural support for single or multiple features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93656 [08:30:44] (03PS1) 10Pastakhov: fix for math operation with result of functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93657 [08:31:59] (03CR) 10Pastakhov: [C: 032] fix for math operation with result of functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93657 (owner: 10Pastakhov) [08:32:05] (03CR) 10jenkins-bot: [V: 04-1] fix for math operation with result of functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93657 (owner: 10Pastakhov) [08:34:45] (03PS2) 10Pastakhov: fix for math operation with result of functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93657 [08:35:43] (03CR) 10Pastakhov: [C: 032] fix for math operation with result of functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93657 (owner: 10Pastakhov) [08:35:50] (03Merged) 10jenkins-bot: fix for math operation with result of functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/93657 (owner: 10Pastakhov) [08:38:27] (03CR) 10Nikerabbit: [C: 032] Add more plural support for single or multiple features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93656 (owner: 10Amire80) [08:38:33] (03Merged) 10jenkins-bot: Add more plural support for single or multiple features [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93656 (owner: 10Amire80) [08:39:04] (03CR) 10Nikerabbit: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93655 (owner: 10Amire80) [08:42:00] (03CR) 10Nikerabbit: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93614 (owner: 10Bsitu) [08:43:00] (03CR) 10Nikerabbit: [C: 031] Move ManualLogEntry to RecentChange logic into own function [core] - 10https://gerrit.wikimedia.org/r/93653 (owner: 10Legoktm) [09:52:39] (03CR) 10Matthias Mullie: [C: 032] "Good addition to quit early" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93481 (owner: 10Matthias Mullie) [09:52:58] (03Merged) 10jenkins-bot: Recursive function should also perform callback on initial element (usually topic title) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93481 (owner: 10Matthias Mullie) [10:34:06] (03PS1) 10Tinaj1234: Removed the indentation button from the WikiEditor toolbar. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 [10:37:51] (03PS2) 10Tinaj1234: Removed the indentation button from the WikiEditor toolbar. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 [10:46:43] (03PS3) 1001tonythomas: Removed the indentation button from the WikiEditor toolbar. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 (owner: 10Tinaj1234) [11:24:43] (03PS1) 10Njw: Remove $wgEruditeBannerImg usage [skins/erudite] - 10https://gerrit.wikimedia.org/r/93671 [11:25:24] (03PS14) 10Hashar: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [11:27:32] (03CR) 10Njw: [C: 032 V: 032] Remove $wgEruditeBannerImg usage [skins/erudite] - 10https://gerrit.wikimedia.org/r/93671 (owner: 10Njw) [11:28:54] (03CR) 10Hashar: [C: 031 V: 031] "Added a JSON example when $wgLogBacktrace is true." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [11:36:30] (03CR) 10Hashar: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [11:36:45] (03PS2) 10Hashar: tests for includes/exception.php [core] - 10https://gerrit.wikimedia.org/r/92328 [11:37:19] (03CR) 10Hashar: [C: 031] "Rebased and made testJsonSerializeException() to use a data provider so we can test that both MWException and Exception are json serializa" [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [11:41:09] (03PS4) 10Hashar: Split ApiTest class into seperate module classes [core] - 10https://gerrit.wikimedia.org/r/91392 (owner: 10Addshore) [11:41:38] (03CR) 10Hashar: [C: 032] "rebased and removed trailing whitespaces at end of some files." [core] - 10https://gerrit.wikimedia.org/r/91392 (owner: 10Addshore) [11:46:30] (03Merged) 10jenkins-bot: Split ApiTest class into seperate module classes [core] - 10https://gerrit.wikimedia.org/r/91392 (owner: 10Addshore) [11:47:04] (03CR) 10Jeroen De Dauw: "Hashar: that is a question on how we plan to deploy things, which is a quite different topic then unbreaking Jenkins so we can continue to" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [12:05:31] (03CR) 10Addshore: [C: 031] Do not run tests for Wikibase Query and QueryEngine [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [12:29:50] (03CR) 10Aklapper: "I don't entirely understand the commit message, like "is to removed" or "inserted to html code". Maybe "to be removed" and "into HTML", de" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 (owner: 10Tinaj1234) [12:32:06] (03PS2) 10Amire80: Handle the case of zero users enabling the feature [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93655 [12:34:31] (03PS1) 10Njw: Release v1.5 [skins/erudite] - 10https://gerrit.wikimedia.org/r/93681 [12:35:00] (03CR) 10Njw: [C: 032 V: 032] Release v1.5 [skins/erudite] - 10https://gerrit.wikimedia.org/r/93681 (owner: 10Njw) [12:36:07] (03PS4) 10Tinaj1234: Removed the indentation button from the WikiEditor toolbar. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 [12:52:40] When I submitted the patch in gerrit, one of the tests by jenkins-bot showed a FAILURE message. Can anyone please look into it and tell me why the code didn't compile ? https://integration.wikimedia.org/ci/job/mwext-WikiEditor-jslint/156/console [13:19:35] (03PS1) 10Aude: remove WikibaseDatabase submodule [extensions] - 10https://gerrit.wikimedia.org/r/93687 [13:22:38] (03PS2) 10Aude: remove WikibaseDatabase submodule [extensions] - 10https://gerrit.wikimedia.org/r/93687 [13:26:03] (03CR) 10MaxSem: [C: 032] Adding some comments to explain what various classes are for. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/91782 (owner: 10Kaldari) [13:26:10] (03PS4) 10Matthias Mullie: Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 [13:26:16] (03Merged) 10jenkins-bot: Adding some comments to explain what various classes are for. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/91782 (owner: 10Kaldari) [13:27:35] (03CR) 10Jeroen De Dauw: [C: 031] "Where exactly was this used? I thought we had no users of this thing so far? If this is some stupid list that has everything in it for no " [extensions] - 10https://gerrit.wikimedia.org/r/93687 (owner: 10Aude) [13:28:08] (03PS1) 10Matthias Mullie: Make "Show history" tab display as selected when on Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93689 [13:28:10] (03CR) 10Aude: "beta labs clones all the extensions in gerrit" [extensions] - 10https://gerrit.wikimedia.org/r/93687 (owner: 10Aude) [13:28:23] (03CR) 10Hashar: [C: 04-2] "I am not going to disable those jobs, instead we should get the root cause fixed. By looking at both extensions build history the issue i" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [13:29:17] (03PS1) 10Matthias Mullie: Some paths were not prepending [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93690 [13:30:43] (03CR) 10Matthias Mullie: "(8 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [13:34:56] (03PS4) 10Matthias Mullie: Update RecentChanges to use history i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 [13:36:26] (03PS5) 10Matthias Mullie: (bug 56277) Update RecentChanges to use history i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 [13:40:46] (03Abandoned) 10Hashar: more extensions registered [extensions] - 10https://gerrit.wikimedia.org/r/92992 (owner: 10Hashar) [13:42:23] (03PS3) 10Hashar: installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 [13:46:52] (03PS5) 10Matthias Mullie: Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 [13:54:41] (03CR) 10Siebrand: [C: 032] Handle the case of zero users enabling the feature [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93655 (owner: 10Amire80) [13:54:47] (03Merged) 10jenkins-bot: Handle the case of zero users enabling the feature [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93655 (owner: 10Amire80) [13:57:12] (03CR) 10Bartosz Dziewoński: [C: 04-1] installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 (owner: 10Hashar) [14:05:06] (03CR) 10Jeroen De Dauw: "It is not. This repo no longer exists on WMF hosting." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93428 (owner: 10Jeroen De Dauw) [14:07:24] (03CR) 10MaxSem: [C: 04-1] "Sure, but you need to mention that PECL client is now supported, not mention only the pure-PHP solution which might lead people to thinkin" [core] - 10https://gerrit.wikimedia.org/r/92264 (owner: 10Kaldari) [14:10:05] (03PS6) 10Matthias Mullie: Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 [14:14:58] (03CR) 10MaxSem: [C: 032] Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 (owner: 10Dereckson) [14:18:03] (03Merged) 10jenkins-bot: Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 (owner: 10Dereckson) [14:21:41] (03CR) 10MZMcBride: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [14:22:41] (03Abandoned) 10Parent5446: Rewrote WebVideoTranscodeJob and encoding. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/51663 (owner: 10Parent5446) [14:24:26] (03PS1) 10Yaron Koren: Added "minor fields" CSS, to denote less-important fields within the GUI [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/93696 [14:24:41] (03CR) 10Parent5446: [C: 032] Add ability to show the time taken by update.php [core] - 10https://gerrit.wikimedia.org/r/93323 (owner: 10Mayankmadan) [14:27:01] (03CR) 10Yaron Koren: [C: 032 V: 032] Added "minor fields" CSS, to denote less-important fields within the GUI [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/93696 (owner: 10Yaron Koren) [14:27:47] (03Merged) 10jenkins-bot: Add ability to show the time taken by update.php [core] - 10https://gerrit.wikimedia.org/r/93323 (owner: 10Mayankmadan) [14:29:16] (03CR) 10MaxSem: "Is anyone interested in working on this?" [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [14:31:35] (03CR) 10Siebrand: "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 (owner: 10Legoktm) [14:33:22] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [14:35:22] (03PS1) 10Hashar: Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93701 [14:35:23] (03PS1) 10Hashar: exception: Use MWExceptionHandler::logException in more places [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93702 [14:35:24] (03PS1) 10Hashar: redact exception traces and abstract getTrace [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93703 [14:35:25] (03PS1) 10Hashar: MWException: Cleanup exception message output [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93704 [14:35:26] (03PS1) 10Hashar: merge exception logging changes from master [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93705 [14:36:26] (03CR) 10Dereckson: "Ia2782d64 and Ie10784d1 merged." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/40095 (owner: 10Dereckson) [14:37:28] (03CR) 10Hashar: "REL1_22 backport proposal in https://gerrit.wikimedia.org/r/#/c/93701/ made via a non fast-worward merge commit: https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [14:37:53] (03CR) 10Bartosz Dziewoński: "A proper solution is blocked by bug 53945. I am rather interested in that bug, but realistically I am not going to submit a patch anytime " [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/82604 (owner: 10Raimond Spekking) [14:38:19] (03CR) 10Parent5446: [C: 031] Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93701 (owner: 10Hashar) [14:38:29] (03CR) 10Hashar: "REL1_22 backport proposal in https://gerrit.wikimedia.org/r/#/c/93702/ made via a non fast-worward merge commit: https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [14:39:13] (03CR) 10Hashar: "REL1_22 backport proposal in https://gerrit.wikimedia.org/r/#/c/93703/ made via a non fast-worward merge commit: https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [14:40:03] (03CR) 10Hashar: "REL1_22 backport proposal in https://gerrit.wikimedia.org/r/#/c/93704/ made via a non fast-worward merge commit: https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/93087 (owner: 10Anomie) [14:41:00] (03CR) 10Hashar: "Merge commit of changes cherry-picked from master." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93705 (owner: 10Hashar) [14:42:03] (03CR) 10Daniel Kinzler: [C: 031] "that extension shouldn't be there. we really need a distinction between libs and extensions..." [extensions] - 10https://gerrit.wikimedia.org/r/93687 (owner: 10Aude) [14:49:29] (03CR) 10Anomie: "(6 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [14:57:38] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [14:59:00] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93615 (owner: 10Bsitu) [14:59:23] (03PS4) 10Matthias Mullie: Remove Special:Flow special page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93615 (owner: 10Bsitu) [15:00:07] (03CR) 10Matthias Mullie: [C: 032] Remove Special:Flow special page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93615 (owner: 10Bsitu) [15:00:17] (03Merged) 10jenkins-bot: Remove Special:Flow special page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93615 (owner: 10Bsitu) [15:04:50] (03PS2) 10Matthias Mullie: Spacing between consecutive collapsed topic cards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92442 (owner: 10EBernhardson) [15:05:14] (03PS2) 10BryanDavis: Invalid argument supplied for foreach() in FormatMetadata.php on line 1566 [core] - 10https://gerrit.wikimedia.org/r/93616 (owner: 10Reedy) [15:05:26] (03CR) 10BryanDavis: [C: 032] Invalid argument supplied for foreach() in FormatMetadata.php on line 1566 [core] - 10https://gerrit.wikimedia.org/r/93616 (owner: 10Reedy) [15:05:35] (03CR) 10Matthias Mullie: [C: 032] "Yeah yeah; couldn't merge because dependency has not yet been merged." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92442 (owner: 10EBernhardson) [15:06:57] (03Merged) 10jenkins-bot: Spacing between consecutive collapsed topic cards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92442 (owner: 10EBernhardson) [15:08:26] (03Abandoned) 10Matthias Mullie: Update script for flow_revision.rev_change_type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93138 (owner: 10Spage) [15:11:24] (03Merged) 10jenkins-bot: Invalid argument supplied for foreach() in FormatMetadata.php on line 1566 [core] - 10https://gerrit.wikimedia.org/r/93616 (owner: 10Reedy) [15:15:35] (03PS2) 10Reedy: Invalid argument supplied for foreach() in FormatMetadata.php on line 1566 [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93630 [15:15:42] (03CR) 10Reedy: [C: 032] Invalid argument supplied for foreach() in FormatMetadata.php on line 1566 [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93630 (owner: 10Reedy) [15:19:47] (03CR) 10Anomie: [C: 031] "Seems generally sane" [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [15:20:17] anomie: I haven't tested the REL1_22 backports of the exceptions tweaks :( [15:20:39] (03Merged) 10jenkins-bot: Invalid argument supplied for foreach() in FormatMetadata.php on line 1566 [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93630 (owner: 10Reedy) [15:21:21] hashar: I'm inclined to relying on the people working on the 1.22 release to handle testing and merging the backports, generally [15:32:45] (03PS1) 10Matthias Mullie: Fix moderation usertext (messages had been overtaken by History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93723 [15:32:49] (03PS1) 10Manybubbles: Escape query string during phrase search detection [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93724 [15:33:38] (03PS1) 10Manybubbles: Tests for boolean operators around quotes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93725 [15:35:04] <^d> manybubbles: Did you see the one comment I left on https://gerrit.wikimedia.org/r/#/c/92665/? [15:35:11] <^d> Other than that, it's good and I'd like to land it :) [15:35:43] ^d: I did now:) [15:35:47] let me address it [15:35:51] anomie: sounds sane. thanks! [15:36:00] Dear Changeset, [15:36:31] <^d> Do u like me? Yes/No [15:36:34] <^d> (Plz circle 1) [15:36:41] <^d> xoxo, [15:36:46] <^d> Nik [15:37:39] (03CR) 10Addshore: [C: 031] remove WikibaseDatabase submodule [extensions] - 10https://gerrit.wikimedia.org/r/93687 (owner: 10Aude) [15:38:31] (03CR) 10Hashar: [C: 032] "fixing up beta." [extensions] - 10https://gerrit.wikimedia.org/r/93687 (owner: 10Aude) [15:38:44] (03CR) 10Hashar: [V: 032] remove WikibaseDatabase submodule [extensions] - 10https://gerrit.wikimedia.org/r/93687 (owner: 10Aude) [15:39:25] (03PS2) 10Manybubbles: Better handle PoolErrors. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92665 [15:39:48] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92665 (owner: 10Manybubbles) [15:40:15] (03CR) 10Chad: [C: 032] Better handle PoolErrors. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92665 (owner: 10Manybubbles) [15:40:20] (03Merged) 10jenkins-bot: Better handle PoolErrors. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92665 (owner: 10Manybubbles) [15:40:29] <^d> manybubbles: Gotcha, thanks. I figured as much, but being explicit helps :) [15:40:41] ^d: thanks for keeping my honest! [15:40:56] (03PS1) 10Ragesoss: Change the "View Activity" tab to standard case: "View activity" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/93727 [15:42:11] Hi, everyone... I'd like to bother anyone amenable to being bothered with a quick question again: server-side, from PHP, if I have a list of usernames, what's the easiest way to get back a list of userids, and info about any usernames in the list that weren't valid? Do I do somethng with ApiQueryAllUsers, or is there another way? Thanks!!!! [15:43:11] <^d> manybubbles: Also, http://www.quora.com/Wikipedia/How-does-Wikipedia-order-its-search-autocomplete-results is cool :) [15:45:07] git log [15:45:10] gah [15:45:11] hey cool [15:45:16] ^d: nice response. [15:45:56] <^d> aude: 2cf410a Merge "Add expensive parser functions {{REVISION*:}}" [15:46:02] <^d> 53b44ec Merge "mediawiki.user: Return a promise from getRights/getGroups" [15:46:05] <^d> ;-) [15:46:27] heh [15:47:49] (03CR) 10Anomie: [C: 04-1] "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [15:47:51] ^d: may want to add that the results are sorted by the number of incoming links which hopefully makes them more relevant than alphabetical [15:52:22] (03PS1) 10Hashar: limit history of beta-code-update to 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93735 [15:53:03] (03CR) 10Hashar: [C: 032] limit history of beta-code-update to 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93735 (owner: 10Hashar) [15:53:28] (03Merged) 10jenkins-bot: limit history of beta-code-update to 15 days [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93735 (owner: 10Hashar) [15:56:18] (03PS1) 10Aude: Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 [15:59:19] (03PS3) 10Cmcmahon: new test for editing existing title, also alphabetize and cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93069 [16:05:03] >>> 0 === false [16:05:04] hashar: (boolean) false [16:05:09] tinaj ^^^^ [16:05:10] (03PS1) 1001tonythomas: Added highlighting after clicking "Drag to new location" button of Liquid Threads. Bug: 25538 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/93740 [16:05:24] tinaj: the ecmabot-wm bot let you pass it some javascript :] [16:05:36] >>> 0 == false; 0 === false; [16:05:36] hashar: (boolean) false [16:05:39] bah [16:06:33] oh [16:07:56] hashar:then, shall I leave them just like that and just correct the whitespace error? [16:09:21] (03CR) 10Daniel Kinzler: [C: 031] Add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [16:14:05] (03PS1) 10Chad: Delete fuzz-tester.php [core] - 10https://gerrit.wikimedia.org/r/93745 [16:15:00] DanielK_WMDE_: don't you have +2 on core ? [16:16:57] (03CR) 10Daniel Kinzler: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [16:17:44] hashar: sure, but i won't use it on my own patches :) [16:18:21] or do you mean re the DB patch? [16:18:39] i won't +2 that without manual testing - and i really don't want to set up all these databases to test them [16:19:11] * aude gives DanielK_WMDE_ mssql to install [16:20:12] http://www.microsoft.com/en-gb/download/details.aspx?id=29062 [16:20:18] :) [16:20:22] DanielK_WMDE_: yeah make sense. was just wondering :] [16:20:32] do we still support MSSQL ? [16:20:38] I though we dropped it already [16:20:44] i think we do, at least technically [16:20:49] We dropped an old version of the code [16:20:50] in theary [16:20:52] Then we got a new version [16:20:53] theory* [16:26:45] qgil, ping [16:29:11] hashar: ping [16:30:30] hashar: I was wondering about the current status of Parsoid in beta labs and test- chrismcmahon mentioned that you set something up there? [16:31:29] hi gwicke hashar I believe that beta labs is updated to the current version of master every six minutes, including parsoid code. [16:32:01] chrismcmahon: that sounds like PHP code [16:32:10] greg-g: chrismcmahon : the code update has been broken since Oct 30th [16:32:20] which code update? [16:32:24] got it partially fixed a few minutes ago, still investigating [16:32:31] code update of mediawiki extensions + core on the beta cluster [16:32:39] https://integration.wikimedia.org/dashboard/ [16:32:43] it's MW code [16:32:44] gwicke, chrismcmahon, that wouldn't quite work since we need a specific revision of parsoid to be tested. [16:32:45] hashar: is there a Parsoid setup in betalabs? [16:32:54] i don't knoow about parsoid [16:33:01] gwicke: I think Roan has set one up to play test VisualEditor [16:33:03] know* and how it is updated.... puppet? [16:33:04] I don't know of parsoid in betalabs, but I'd love to see it there [16:33:10] gwicke: it might still be running, I have no clue honestly. [16:33:33] in fact, we really should have parsoid in betalabs so that VE can be accurately tested, if nothing else [16:33:35] I vaguely remember him pointing it to parsoid.wmflabs.org at some point [16:33:35] gwicke: Yes, there is, but I don't think it's running as a continuous deploy. [16:33:35] but I am 100% sure we had VE working there [16:33:37] hashar: I know we are running parsoid in beta labs, because VisualEditor works. [16:33:44] chrismcmahon: \O/ [16:33:55] chrismcmahon, maybe it points to parsoid.wmflabs.org then? [16:34:01] gwicke, do you know? [16:34:03] I have no clue how parsoid is setup on beta nor how it get updated though. [16:34:05] subbu: Perhaps? [16:34:17] hashar: assume puppet [16:34:25] $wgVisualEditorParsoidURL = 'http://10.4.0.61/'; // deployment-parsoidcache2 [16:34:28] sounds like [16:34:45] could we have a goal of getting parsoid continuously deployed to the beta cluster, like everything else, for accurate VE testing? [16:35:07] sounds good [16:35:11] awesome [16:35:41] you would want to find out whoever maintains that deployment-parsoidcache2 instance and point them to me to figure out a deployment strategy. [16:35:58] presumably it is running the code already updated [16:36:07] though it is most probably not reloaded on code update [16:36:14] greg-g: https://bugzilla.wikimedia.org/show_bug.cgi?id=56590 [16:36:46] gwicke: wasn't sure if that's what that bug was about :) [16:37:06] greg-g: it is about testing our HTML interfaces [16:37:10] not about VE [16:37:24] but if VE also exercises our HTML interfaces, then that will be useful too [16:37:58] * greg-g nods [16:38:08] hashar: ideally we'd set up varnishes etc the same way as they are in production [16:39:30] gwicke: we have varnishes for the mobile/text/bits caches. Never looked at the parsoid setup though (neither in prod nor in labs). [16:40:13] hashar: it is RoanKattouw_away who built those parsoidcache hosts [16:40:14] 10.4.0.61 already seems to have a varnish [16:40:25] back in May [16:40:29] maybe Roan used it to test varnishes before puppetizing them [16:40:30] and rebuilt it in June [16:41:15] we'd also like to do rolling deploys [16:41:56] maybe we can figure out a way to have several Parsoid versions running on the cluster on different ports and point to the correct backend from varnish [16:43:36] for those curious about how the Parsoid caching etc works: https://wikitech.wikimedia.org/wiki/Parsoid [16:45:19] yupih extensions are updating again https://integration.wikimedia.org/ci/view/Beta/job/beta-code-update/ :D [16:45:49] Reedy: Around for some quick deployment advice? 1.23wmf2 has a message missing in English, but working in French/German/etc. - any idea how this can happen? [16:47:08] gwicke: the Parsoid team should probably taking care of setting up in beta. Will be happy to help but I can't reasonably digest the parsoid architecture. [16:47:33] James_F: scap apahasia [16:47:37] aphasia [16:47:43] ori-l: Hmm. :-( [16:48:13] hashar: I was hoping that we could find somebody else to do it for VE ;) [16:48:32] ori-l: Does it happen often? [16:48:47] James_F: i was just making a bad joke; it shouldn't happen ever [16:48:50] gwicke: yeah we tried that, it does scale :-] [16:48:54] i am not aware of it being a 'thing' [16:48:58] gwicke: but I will be more happy to assist your team. [16:48:59] ori-l: Oh, right. Hmm. [16:49:17] hashar: but more seriously, Roan should be a good candidate to look into this [16:49:29] he did all the puppetization for VE and the caches [16:50:01] James_F: i'm currently gawking at http://ganglia.wikimedia.org/latest/?r=week&cs=&ce=&tab=v&vn=VisualEditor [16:50:09] (03CR) 10Siebrand: [C: 032] Change the "View Activity" tab to standard case: "View activity" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/93727 (owner: 10Ragesoss) [16:50:15] James_F: before i poke further, any immediate thoughts about what would cause that? [16:50:15] The problem is that automatic deploys of Parsoid to the beta cluster will give us misleading impressions. [16:50:17] it's clearly broken [16:50:19] (03Merged) 10jenkins-bot: Change the "View Activity" tab to standard case: "View activity" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/93727 (owner: 10Ragesoss) [16:50:40] Missing message in english is a scary one [16:51:03] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=56616 - scap should fix, maybe? Working in beta cluster. [16:51:19] ori-l: That's when wmf1 went out to production, right? [16:51:53] James_F: as far as I'm concerned every bit of testing helps [16:51:58] ori-l: Looking at https://www.mediawiki.org/wiki/MediaWiki_1.23/wmf1/Changelog#VisualEditor - maybe https://gerrit.wikimedia.org/r/#/c/90258/ ? [16:52:04] gwicke: No, you misunderstand. [16:52:32] gwicke James_F so how is parsoid maintained for test2wiki/mw.o then? [16:52:58] gwicke: Testing master of VisualEditor (which is about to be auto-deployed) against master of Parsoid (which isn't) will make us think it's working when it's not (e.g. master of VE doesn't work with production of Parsoid), or broken when it's fine (e.g. master of VE works with master of Parsoid but not production). [16:53:05] chrismcmahon: it is using production afaik [16:53:10] (03CR) 10Siebrand: "I guess this looks okay, but I have no idea in which context these messages are used. Can you refer to a screenshot or something?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93723 (owner: 10Matthias Mullie) [16:53:11] chrismcmahon: I think Roan manually updates it every now and then. [16:53:13] there is only one parsoid cluster [16:53:30] mw.org definitely runs production [16:53:38] gwicke: We're not talking about mw.org. [16:53:48] gwicke: We're talking about en.wikipedia.beta.wmflabs.org [16:54:02] oh, chrismcmahon asked about mw.o [16:54:32] Tabs look broken on mw.org [16:54:37] gap below the tabs [16:55:33] gwicke: if the beta parsoid runs out of the already updated code base, we could add a script in the Jenkins to reload/restart parsoid after update. [16:56:14] James_F: is it fair to say that it would be worthwhile to have parsoid deployment in step with VE deployment? [16:56:51] hashar: for CI I'm more inclined to go for faster pure-Parsoid testing [16:56:54] chrismcmahon: No. [16:57:20] hashar: did you mean this for CI? [16:57:30] gwicke: na for beta [16:57:34] James_F: sigh. yes. that is exactly it. (90258, that is.) [16:57:35] how are tests on betalabs run currently? [16:57:40] gwicke: I have no clue how often parsoid is updated on beta [16:57:43] James_F: I did not update WikimediaEvents [16:57:59] ori-l: Ah, oops. [16:58:01] I'd guess that it would be too slow for CI [16:58:07] *oojs [16:58:11] gwicke: the tests are made against VisualEditor using Selenium. That is being twice per days [16:58:30] makes sense [16:58:45] gwicke: and I am working on adding the browser tests to be triggered whenever someone send a patchset against VisualEditor. [16:59:42] hashar: a lot of the issues we'd like to test in betalabs are caching-related [16:59:46] gwicke: the browser tests will target beta labs and also test2wiki. [17:00:01] so we should make sure that the varnish setup is really identical [17:00:19] the other varnishes are setup using the production configuration [17:00:30] the only changes being the ip address / domain ( .org -> .beta.wmflabs.org ) [17:00:39] and the disk names iirc [17:01:02] James_F: It's not the only missing message [17:01:09] so yeah, you would have something identical to production :] [17:01:10] we might also have to set up LVS [17:01:14] Reedy: Argh. [17:01:21] Reedy: In VE alone, or other places? [17:01:22] visualeditor-mweditmodesource-warning too [17:01:26] (03PS5) 10Umherirrender: Add "wgRelevantUserName" from skin to mw.config [core] - 10https://gerrit.wikimedia.org/r/88773 [17:01:34] hashar: will ping Roan about it later [17:01:44] https://www.mediawiki.org/w/index.php?title=Special%3AAllMessages&prefix=Visualeditor&filter=all&lang=en&limit=500 [17:02:06] (03CR) 10Umherirrender: "Patch Set 5: Rebased" [core] - 10https://gerrit.wikimedia.org/r/88773 (owner: 10Umherirrender) [17:02:12] (03PS1) 10Ori.livneh: Update VisualEditor performance event names [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93757 [17:02:29] James_F: It's not there in de either [17:02:47] (03CR) 10Ori.livneh: [C: 032] "Self-merging; trivial." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93757 (owner: 10Ori.livneh) [17:03:27] reedy@tin:/a/common/php-1.23wmf2$ grep -c visualeditor-mweditmodesource extensions/VisualEditor/VisualEditor.i18n.php [17:03:27] 4 [17:03:38] (03Merged) 10jenkins-bot: Update VisualEditor performance event names [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/93757 (owner: 10Ori.livneh) [17:03:41] en and qqq in the localisation file [17:03:55] greg-g: ^ i'm going to sync that; it's stupidly trivial but vital [17:10:48] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93759 [17:11:24] (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93760 [17:11:58] (03CR) 10Ori.livneh: [C: 032 V: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93759 (owner: 10Ori.livneh) [17:12:10] (03CR) 10Ori.livneh: [C: 032 V: 032] Update WikimediaEvents to master [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93760 (owner: 10Ori.livneh) [17:13:34] Reedy: Any ideas? [17:14:29] Reedy: It's almost like we didn't scap after the deploy of wmf2? [17:14:43] If we didn't scap there'd be no messages [17:14:51] at all [17:15:07] l10nupdate should have "fixed" that anyway [17:15:15] We can run scap "now" if no one is deploying [17:16:26] i synced my two files [17:16:31] gj ori-l [17:16:47] * ori-l thanks the Academy [17:19:19] Reedy: Yeah… [17:19:21] * James_F sighs. [17:24:42] ori-l: on call, but I think that's cool [17:25:01] greg-g: yep, already done [17:26:39] (03PS1) 10Dan-nl: re-work exception handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 [17:26:41] (03CR) 10Anomie: "What "unknown error" is being avoided? As far as I can tell, the only use of getPossibleErrors or getFinalPossibleErrors is to be returned" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92193 (owner: 10Umherirrender) [17:27:10] Reedy: were you going to scap? [17:27:28] Maybe [17:27:35] I haven't checked if stuff is free though [17:28:17] (03PS2) 10Aude: Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 [17:28:54] hey all right, if i get by, it's mine [17:28:57] mine all mine! [17:34:11] ori-l: Still no data on http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&tab=v&vn=VisualEditor - does it take time to come through? [17:35:54] James_F: yes, give it a couple [17:36:05] ori-l: Kk. [17:38:29] Reedy: Roan's told me that he forgot to scap last night, and l10n-bot doesn't sync en messages, only the other ones. [17:38:46] Aha [17:38:55] I guess that explains it then [17:39:07] RoanKattouw_away: Fool. :-P [17:39:18] James_F: http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&tab=v&vn=VisualEditor [17:39:28] ori-l: Yay. [17:41:57] James_F: i'd be interested in refining for the nov 7 deploy somehow, so we can capture the user's experience [17:42:18] (03CR) 10Umherirrender: "Yes, that is right. Only on this request: https://en.wikipedia.org/w/api.php?action=paraminfo&querymodules=checkuser|checkuserlog" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92193 (owner: 10Umherirrender) [17:42:22] presumably optimistic saving is going to reduce user-perceived latency quite a lot but that won't register on these graphs [17:45:13] Reedy: Turns out that change never made it into the original wmf2 deploy and accidentally hitched a ride with my hotfix last night [17:45:36] So scapping at any point should fix it [17:45:51] (03PS1) 10Ebrahim: Native digits on campaign header [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 [17:46:47] ori-l: Sure. [17:47:04] ori-l: Particular refinements in mind? [17:48:42] What's the chances features are scapping sometime soon? [17:50:20] James_F: time from save button click to save completion [17:50:22] Reedy: Little. No deploys today from features, just the wmf2 push to phase1. [17:50:24] "12:38 < James_F> Reedy: Roan's told me that he forgot to scap last night, and l10n-bot doesn't sync en messages, only the other ones." -- Is there a reason this is the case? should this be "fixed"? [17:50:38] hu subbu , sorry, I was meeting/afk [17:50:50] greg-g: Normally en messages shouldn't change, so this is an efficiency thing, I guess. [17:50:57] Tuesday, November 05 23:00–00:00 15:00–16:00 Matt F Growth Team catchup deploy from previous week - see notes [17:51:15] Reedy: s/today/this morning/ :-P [17:51:20] James_F: seems there should be a check, at least :) [17:51:22] Yeah... In theory we could "fix it" [17:51:30] greg-g: Perhaps. [17:51:31] But yeah.. en changes even less frequently [17:51:32] qgil, np .. i was just trying to figure out the 'micro tasks' for opw and what migh tbe good ones .. and marktraceur gave me some good suggestions. [17:52:01] (03CR) 10Catrope: [C: 04-1] "(4 comments)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/93665 (owner: 10Tinaj1234) [17:52:09] 2.1M l10n_cache-en.cdb [17:52:32] ok subbu , have you got a candidate interested? [17:52:38] Reedy, greg-g: Ideally we should "fix" it by abandonning the current system and going to lightweight JSON files, like we've agreed. ;-) [17:52:54] qgil, two candidates actually [17:53:07] James_F: oh? /me doesn't know about that [17:53:24] they expressed interest in the same project but one also was interested in another proj. so figured we'll just split them into those two. [17:53:29] subbu, very good! Hopefully they are a good match for our project ideas [17:54:49] greg-g: The plan is to work on that at the Language Summit, I think. [17:54:58] James_F: oh neato! [17:55:01] greg-g: Niklas would know more, probably. [17:55:03] * greg-g nods [17:55:08] no worries for now then I guess [17:55:55] (03PS1) 10Matthias Mullie: Copy tweaks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93768 [17:56:05] greg-g: Sorry for causing this, I did a hotfix last night to make VE compatible with the rolled-back version of Parsoid, and this change accidentally hitched a ride with it. It was meant to have already been put into wmf2 but that got lost in the ferry-related craziness last week [17:56:37] greg-g: we should sync aude's cherry-pick (https://gerrit.wikimedia.org/r/#/c/93767/) at some point today [17:56:40] RoanKattouw: no worries, glad we caught it and it seems like a relative corner case [17:57:17] it should resolve one of the items in the site stability issues thread from sept [17:57:20] ori-l: indeed, we have a nice big 2 hour window we don't need due to the deploy going well yesterday :) [17:57:36] 11-1 Pacific [17:58:01] yayy [17:58:05] Reedy: mind syncing out that aude change above? [17:58:19] "aude change" == "odd change" == :-) [17:58:38] well, we need the config change too, aude, right? [17:59:41] (03PS1) 10Aude: Update Wikibase, use siteGroup setting instead of doing lookup [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93769 [17:59:55] need to update wmf1 also [18:00:26] (03CR) 10Ori.livneh: [C: 032] Update Wikibase, use siteGroup setting instead of doing lookup [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93769 (owner: 10Aude) [18:00:47] this patch will do the same thing as currently, so should work fine without settings change [18:00:57] but won't be fully effective without settings [18:01:27] if the setting is not there* same as current, though one lookup instead of two [18:02:04] aude: have you seen https://gerrit.wikimedia.org/r/#/c/93648/ ? [18:02:13] no [18:02:26] (03PS1) 10Umherirrender: fix typo in @deprecated [core] - 10https://gerrit.wikimedia.org/r/93770 [18:02:29] oh, yes [18:02:30] i saw that [18:04:17] (03PS1) 10Ebrahim: Native digits on Special:TimedMediaHandler [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/93771 [18:05:01] (03PS1) 10Aude: Update Wikibase, use siteGroup setting instead of doing lookup [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93772 [18:06:04] (03CR) 10Ori.livneh: [C: 032] Update Wikibase, use siteGroup setting instead of doing lookup [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93772 (owner: 10Aude) [18:06:11] aude: thanks for jumping on this so quickly [18:06:19] aude: do you think you could submit the config additions too? [18:06:28] i am looking at it now [18:06:44] awesome, thanks :) [18:07:00] (03Merged) 10jenkins-bot: Update Wikibase, use siteGroup setting instead of doing lookup [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93769 (owner: 10Aude) [18:07:12] thanks for reporting the issue to us [18:07:21] * aude needs to look at ganglia more often [18:10:17] (03CR) 10IAlex: [C: 032] fix typo in @deprecated [core] - 10https://gerrit.wikimedia.org/r/93770 (owner: 10Umherirrender) [18:11:39] (03Merged) 10jenkins-bot: Update Wikibase, use siteGroup setting instead of doing lookup [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93772 (owner: 10Aude) [18:13:42] (03Merged) 10jenkins-bot: fix typo in @deprecated [core] - 10https://gerrit.wikimedia.org/r/93770 (owner: 10Umherirrender) [18:16:29] (03CR) 10Legoktm: "* I don't know why you think it's overkill. Do you have a better idea?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92050 (owner: 10Legoktm) [18:19:12] (03PS1) 10Ebrahim: Native digits on 'mwoauth-prefs-managegrantslink' [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93774 [18:32:40] (03CR) 10Bsitu: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93508 (owner: 10Gerrit Patch Uploader) [18:36:54] ori-l: ping [18:37:48] * aude is going home in 5 minutes but then available again a bit later [18:38:12] (03CR) 10Bsitu: [C: 032] Some paths were not prepending [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93690 (owner: 10Matthias Mullie) [18:38:21] (03Merged) 10jenkins-bot: Some paths were not prepending [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93690 (owner: 10Matthias Mullie) [18:44:15] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [18:46:40] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [18:59:43] (03PS1) 10Umherirrender: Fix call to function applyPatch in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/93777 [19:01:11] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [19:01:29] aude: hey, had to go for a bit [19:01:33] are things ok to sync? [19:03:04] (03PS4) 10Cmcmahon: new test for editing existing title, also alphabetize and cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93069 [19:03:27] (03PS1) 10Bsitu: Avoid PHP warning in strripos() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93779 [19:04:02] (03PS2) 10Bsitu: Avoid PHP warning in strripos() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93779 [19:21:16] (03PS1) 10Aaron Schulz: Include server in redis lua errors [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93782 [19:21:26] (03CR) 10Aaron Schulz: [C: 032] Include server in redis lua errors [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93782 (owner: 10Aaron Schulz) [19:26:06] (03Merged) 10jenkins-bot: Include server in redis lua errors [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93782 (owner: 10Aaron Schulz) [19:29:25] (03CR) 10Esanders: "Ping" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [19:30:08] (03CR) 10MarkTraceur: "RIGHT" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [19:30:47] marktraceur: https://gerrit.wikimedia.org/r/#/c/91040/5/img/form-icon/feature-discussion.svg,unified works? [19:31:27] Oh, wow [19:31:58] marktraceur: Yay for gerrit hiddenness? [19:32:10] Indeed [19:37:10] (03PS1) 10Manybubbles: Push bulk indexing onto the job queue [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 [19:37:56] (03CR) 10Manybubbles: "I'm worried about what kind of backlog we could use this to create on the job queue but I think we're long overdo trying this." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [19:39:22] (03PS1) 10Umherirrender: Avoid fatal in ContentHandler::getUndoContent by null content [core] - 10https://gerrit.wikimedia.org/r/93788 [19:44:18] (03CR) 10Hoo man: [C: 031] "I don't see how this could harm, but maybe there's a nicer way to handle the errors." [core] - 10https://gerrit.wikimedia.org/r/93788 (owner: 10Umherirrender) [19:49:28] (03PS1) 10Bsitu: Post perm-link is not working [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93793 [19:51:06] (03PS1) 10Ori.livneh: Configurable log sampling via $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/93794 [20:04:58] hi ori-l [20:05:06] things look much better now :) [20:05:25] aude: :) yep [20:07:52] (03CR) 10Hashar: [C: 032] "We could probably apply at the class level:" [core] - 10https://gerrit.wikimedia.org/r/93647 (owner: 10Tim Starling) [20:08:32] (03CR) 10Aaron Schulz: [C: 032] Configurable log sampling via $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/93794 (owner: 10Ori.livneh) [20:10:10] AaronSchulz: that one was missing a release notes entry :D [20:11:26] (03Merged) 10jenkins-bot: ApiFormatWddxTest @requires wddx_deserialize [core] - 10https://gerrit.wikimedia.org/r/93647 (owner: 10Tim Starling) [20:12:35] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93737 (owner: 10Aude) [20:12:59] (03Merged) 10jenkins-bot: Configurable log sampling via $wgDebugLogGroups [core] - 10https://gerrit.wikimedia.org/r/93794 (owner: 10Ori.livneh) [20:15:56] (03CR) 10Umherirrender: "There is no way to handle the errors, because a null from Revision::getContent usually means that the content is corrupt. It also possible" [core] - 10https://gerrit.wikimedia.org/r/93788 (owner: 10Umherirrender) [20:16:36] (03PS15) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [20:18:31] (03PS2) 10MaxSem: Add a function to return a single page image [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/93607 [20:20:43] (03PS3) 10Aude: Add convenience maintenance script wrapper [core] - 10https://gerrit.wikimedia.org/r/93737 [20:20:59] (03PS1) 10Manybubbles: Add Elasticsearch version to Special:Version [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 [20:24:00] (03PS1) 10Ori.livneh: Release notes & comment fix for Ib0ece5d5d [core] - 10https://gerrit.wikimedia.org/r/93804 [20:24:42] (03CR) 10Ori.livneh: [C: 032] Release notes & comment fix for Ib0ece5d5d [core] - 10https://gerrit.wikimedia.org/r/93804 (owner: 10Ori.livneh) [20:25:31] AaronSchulz: Hi! Could you review this change please? I'm not sure I've implemented it well. https://gerrit.wikimedia.org/r/#/c/91619/ [20:28:46] (03Abandoned) 10Chad: Rewrite SearchUpdate as a Job instead of a DeferredUpdate [core] - 10https://gerrit.wikimedia.org/r/92825 (owner: 10Chad) [20:29:13] (03Merged) 10jenkins-bot: Release notes & comment fix for Ib0ece5d5d [core] - 10https://gerrit.wikimedia.org/r/93804 (owner: 10Ori.livneh) [20:35:10] (03CR) 10Chad: [C: 031] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [20:37:03] (03CR) 10Anomie: [C: 032] Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [20:37:33] (03CR) 10jenkins-bot: [V: 04-1] Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [20:40:38] (03PS16) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [20:41:41] (03CR) 10Anomie: [C: 032] Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [20:41:51] (03PS2) 10Manybubbles: Push bulk indexing onto the job queue [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 [20:45:46] (03Merged) 10jenkins-bot: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [20:46:00] anomie: ori-l \O/ [20:46:02] (03PS1) 10Aaron Schulz: Include server in redis lua errors [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93809 [20:46:14] (03CR) 10Aaron Schulz: [C: 032] Include server in redis lua errors [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93809 (owner: 10Aaron Schulz) [20:49:57] (03CR) 10Hashar: "Thank you ori and brad. That is awesome." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [20:50:20] hashar: Hey so I've been told that you're the person to talk to about getting Parsoid to be updated automatically on beta labs? [20:50:46] RoanKattouw: yup we talked about it earlier with gabriel. [20:51:05] So I need to refamiliarize myself with how Parsoid is set up in beta [20:51:12] And we need to add a production-like caching setup to that [20:51:13] RoanKattouw: I got half an hour right now if you want to chit chat about it [20:51:16] OK cool [20:51:19] Let's do it [20:51:35] gwicke: do you have a link to the public parsoid domain name that leslie setup yday? [20:51:55] Hah, we have deployment-parsoidcache3 [20:51:58] I wonder if it's used [20:52:02] (03Merged) 10jenkins-bot: Include server in redis lua errors [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93809 (owner: 10Aaron Schulz) [20:52:55] RoanKattouw: I have no idea how it has been setup in beta nor I have any idea what the architecture is in production [20:53:05] the varnish cache sounds like a frontend cache to offload the parsoid parsers [20:53:28] it must be in puppet so it should be possible to adapt the existing manifest / vcl templates to fit in beta. [20:54:01] Yeah it is [20:54:05] And there is an instance for it in deployment already [20:54:15] I'm just looking at mediawiki-config to figure out if it's used [20:54:23] we also have ganglia in labs : http://ganglia.wmflabs.org/latest/?c=deployment-prep&h=deployment-parsoidcache3 [20:54:37] it works sometime [20:55:40] (03PS6) 10MarkTraceur: New icons [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [20:56:05] RoanKattouw: http://ganglia.wmflabs.org/latest/?c=deployment-prep&h=deployment-parsoidcache3&m=cpu_report&r=hour&s=descending&hc=4&mc=2 [21:02:54] (03CR) 10MarkTraceur: [C: 04-1] "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 (owner: 10Ebrahim) [21:03:07] (03CR) 10MarkTraceur: "Also it was a great opportunity to blame YuviPanda for something" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 (owner: 10Ebrahim) [21:04:31] (03CR) 10Yuvipanda: [C: 04-1] "Same comments as mark. Can you also update the commit message to be a little bit more descriptive?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 (owner: 10Ebrahim) [21:14:51] (03Draft1) 10Aude: Add tests for EnhancedChangesList class [core] - 10https://gerrit.wikimedia.org/r/93611 [21:15:15] (03CR) 10MarkTraceur: [C: 04-1] "Right, so:" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [21:16:24] (03CR) 10Aude: "open to suggestions on how to make the tests better." [core] - 10https://gerrit.wikimedia.org/r/93611 (owner: 10Aude) [21:16:39] (03PS1) 10RobH: adding matanya's other email to trusted users [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93856 [21:18:01] (03CR) 10Gergő Tisza: [C: 04-1] "HTML (pre-HTML5) permits whitespace in the comment-closing markup: http://www.w3.org/TR/html401/intro/sgmltut.html#h-3.2.4" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [21:19:18] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93856 (owner: 10RobH) [21:20:07] (03PS2) 10RobH: adding matanya's other email to trusted users [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93856 [21:20:34] (03CR) 10Aaron Schulz: "(2 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [21:21:37] (03PS8) 10Mattflaschen: Port mediawiki.ui SASS to LESS [core] - 10https://gerrit.wikimedia.org/r/93584 [21:22:02] (03CR) 10Hashar: [C: 032] "Thank you RobH!" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93856 (owner: 10RobH) [21:22:24] (03CR) 10Mattflaschen: "I put Juliusz as the author, since he did most of the work, and made a minor tweak to the commit message." [core] - 10https://gerrit.wikimedia.org/r/93584 (owner: 10Mattflaschen) [21:22:37] (03CR) 10Manybubbles: [C: 04-1] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [21:25:49] (03CR) 10BryanDavis: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [21:26:48] (03CR) 10Gergő Tisza: "Actually, if we are concerned about very old browsers, the situation is worse: in Firefox 3, it seems to be possible to break out of a com" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [21:30:37] (03Merged) 10jenkins-bot: adding matanya's other email to trusted users [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93856 (owner: 10RobH) [21:31:03] thanks RobH [21:31:49] quite welcome [21:33:43] (03CR) 10Hashar: "deployed :)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93856 (owner: 10RobH) [21:40:45] (03PS1) 10CSteipp: Add OAuth identify method [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93859 [21:41:12] (03PS2) 10Ebrahim: Native digits on campaign uploads and contributions numbers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 [21:43:10] (03CR) 10MarkTraceur: [C: 031] "YuviPanda, you should test! :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/93766 (owner: 10Ebrahim) [21:43:21] yuvipanda: No -staff? :( [21:43:52] marktraceur: ah, got kicked out due to bouncer issues [21:45:23] (03PS1) 10CSteipp: Fix SpecialPage name for api [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93860 [21:46:04] (03CR) 10BryanDavis: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [21:52:17] (03CR) 10Aaron Schulz: [C: 032] Fix SpecialPage name for api [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93860 (owner: 10CSteipp) [21:52:23] (03Merged) 10jenkins-bot: Fix SpecialPage name for api [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93860 (owner: 10CSteipp) [21:53:28] (03PS2) 10Kaldari: Fixing documentation for memcached. [core] - 10https://gerrit.wikimedia.org/r/92264 [21:55:11] (03CR) 10Aaron Schulz: [C: 032] Fixing documentation for memcached. [core] - 10https://gerrit.wikimedia.org/r/92264 (owner: 10Kaldari) [21:55:57] (03CR) 10CSteipp: [C: 032] Native digits on 'mwoauth-prefs-managegrantslink' [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93774 (owner: 10Ebrahim) [21:56:07] (03Merged) 10jenkins-bot: Native digits on 'mwoauth-prefs-managegrantslink' [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93774 (owner: 10Ebrahim) [21:57:10] (03CR) 10CSteipp: [C: 032] Wiki/consumer language cleanup [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93520 (owner: 10Aaron Schulz) [21:57:19] (03Merged) 10jenkins-bot: Wiki/consumer language cleanup [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93520 (owner: 10Aaron Schulz) [21:58:08] (03CR) 10Gergő Tisza: "(3 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [21:58:13] (03Merged) 10jenkins-bot: Fixing documentation for memcached. [core] - 10https://gerrit.wikimedia.org/r/92264 (owner: 10Kaldari) [21:59:10] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93802 (owner: 10Manybubbles) [21:59:25] (03Abandoned) 10Kaldari: Changing usage instructions for ContentHandler::getContentText() [core] - 10https://gerrit.wikimedia.org/r/92827 (owner: 10Kaldari) [21:59:41] (03PS1) 10Aaron Schulz: Minor doc tweak [core] - 10https://gerrit.wikimedia.org/r/93862 [22:01:51] (03CR) 10Chad: [C: 032] Escape query string during phrase search detection [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93724 (owner: 10Manybubbles) [22:02:06] (03CR) 10Chad: [C: 032] Tests for boolean operators around quotes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93725 (owner: 10Manybubbles) [22:02:07] (03Merged) 10jenkins-bot: Escape query string during phrase search detection [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93724 (owner: 10Manybubbles) [22:02:14] (03PS7) 10Andrew Bogott: Add a gui for creation/deletion of labs proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 [22:02:16] (03Merged) 10jenkins-bot: Tests for boolean operators around quotes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93725 (owner: 10Manybubbles) [22:06:50] (03CR) 10CSteipp: [C: 032] Added a /grants subpage to give a grant/rights table to Special:OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92029 (owner: 10Aaron Schulz) [22:06:51] (03CR) 10jenkins-bot: [V: 04-1] Added a /grants subpage to give a grant/rights table to Special:OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92029 (owner: 10Aaron Schulz) [22:07:12] (03CR) 10Hoo man: "Mh... and you don't think we should throw an exception in these cases?" [core] - 10https://gerrit.wikimedia.org/r/93788 (owner: 10Umherirrender) [22:08:16] (03CR) 10EBernhardson: [C: 032] Post perm-link is not working [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93793 (owner: 10Bsitu) [22:08:27] (03Merged) 10jenkins-bot: Post perm-link is not working [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93793 (owner: 10Bsitu) [22:13:55] Hey wikimedia-dev, question for you all. Could someone point me towards an instance when MediaWiki was used for group-troubleshooting of a problem? I'm hoping to find a format I can follow for my own needs. [22:17:42] (03PS2) 10CSteipp: Added a /grants subpage to give a grant/rights table to Special:OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92029 (owner: 10Aaron Schulz) [22:17:44] (03PS1) 10Aaron Schulz: Added some sanity close() calls to RedisConnectionPool [core] - 10https://gerrit.wikimedia.org/r/93866 [22:18:30] (03CR) 10CSteipp: [C: 032] "PS 2 was a manual rebase" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92029 (owner: 10Aaron Schulz) [22:18:41] (03Merged) 10jenkins-bot: Added a /grants subpage to give a grant/rights table to Special:OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92029 (owner: 10Aaron Schulz) [22:18:45] (03CR) 10Gergő Tisza: "Not related to this change, but I would feel calmer if someone with more MediaWiki experience could look at AjaxHandler - I am not sure ca" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [22:19:35] (03PS2) 10Dan-nl: secure [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 [22:20:53] (03CR) 10Dan-nl: "based on Gergő’s research and Bryan’s suggestion i have changed the code so that it uses htmlspecialchars() instead." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [22:22:11] * AzaToth don't understand why migrate sass to less [22:22:33] (03CR) 10Andrew Bogott: [C: 032] Add a gui for creation/deletion of labs proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 (owner: 10Andrew Bogott) [22:22:36] (03Merged) 10jenkins-bot: Add a gui for creation/deletion of labs proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 (owner: 10Andrew Bogott) [22:22:44] (03PS1) 10MarkTraceur: ResourceLoader consistency file moves [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93867 [22:22:49] MOVE ALL THE THINGS [22:24:39] (03CR) 10Chad: [C: 032] Added "maxPartitionsTry" option to JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/90726 (owner: 10Aaron Schulz) [22:24:47] (03PS1) 10Bsitu: header editing is broken for headers created by anon users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93868 [22:26:25] (03CR) 10Gergő Tisza: "That still does not stop people from using -- to end the comment in FF3. Not sure if that is a treat that should be taken seriously (FF3 u" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [22:26:52] (03CR) 10BryanDavis: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [22:27:36] (03Merged) 10jenkins-bot: Added "maxPartitionsTry" option to JobQueueFederated [core] - 10https://gerrit.wikimedia.org/r/90726 (owner: 10Aaron Schulz) [22:28:52] (03PS11) 10BryanDavis: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [22:29:35] (03CR) 10Gergő Tisza: "Forget the last comment - as long as the full string is htmlescaped, it doesn't really matter if it is possible to break out of the commen" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [22:29:48] (03CR) 10Gergő Tisza: [C: 031] secure [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [22:32:34] hey gwicke, so you have a plan for PDF rendering? [22:32:51] (03CR) 10BryanDavis: [C: 032] "I think the only bad thing that can happen with full html entity encoding applied is that a user may see weird output in the File: page." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [22:32:56] (03Merged) 10jenkins-bot: secure [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93776 (owner: 10Dan-nl) [22:34:16] (03PS1) 10Mattflaschen: Bump GettingStarted for Growth team deploy [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93869 [22:36:02] (03PS1) 10Mattflaschen: Bump GuidedTour for Growth team deploy [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93870 [22:37:07] (03PS1) 10Hashar: exception/fatals graph for beta on main page [integration/docroot] - 10https://gerrit.wikimedia.org/r/93871 [22:37:58] (03CR) 10Hashar: [C: 032] "lets please everyone :-) I posted about it on the qa-l list." [integration/docroot] - 10https://gerrit.wikimedia.org/r/93871 (owner: 10Hashar) [22:38:14] (03Merged) 10jenkins-bot: exception/fatals graph for beta on main page [integration/docroot] - 10https://gerrit.wikimedia.org/r/93871 (owner: 10Hashar) [22:44:11] (03PS1) 10Aaron Schulz: Fixed redis reconnect handling when passwords are used in luaEval() [core] - 10https://gerrit.wikimedia.org/r/93872 [22:44:26] (03PS1) 10Mattflaschen: Bump GettingStarted for Growth team deploy [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93873 [22:44:53] (03PS1) 10Mattflaschen: Bump GuidedTour for Growth team deploy [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93874 [22:46:14] (03PS2) 10Gergő Tisza: Make category-related code more readable [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93625 [22:47:39] (03CR) 10Bsitu: [C: 031] "Looks good from a quick glance, I will do some more testing on this later" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [22:47:51] (03PS2) 10Matthias Mullie: Fix moderation usertext (messages had been taken over by History) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93723 [22:47:53] (03PS7) 10Matthias Mullie: Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 [22:49:51] (03CR) 10MarkTraceur: [C: 032] "My OCD satisfied, we ride!" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93625 (owner: 10Gergő Tisza) [22:50:07] (03Merged) 10jenkins-bot: Make category-related code more readable [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93625 (owner: 10Gergő Tisza) [22:54:00] (03CR) 10EBernhardson: [C: 032] header editing is broken for headers created by anon users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93868 (owner: 10Bsitu) [22:54:09] (03Merged) 10jenkins-bot: header editing is broken for headers created by anon users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93868 (owner: 10Bsitu) [22:55:18] (03CR) 10Aaron Schulz: "Easy repro in eval.php:" [core] - 10https://gerrit.wikimedia.org/r/93872 (owner: 10Aaron Schulz) [23:00:48] (03PS3) 10Manybubbles: Push bulk indexing onto the job queue [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 [23:02:11] (03CR) 10Manybubbles: "(2 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [23:06:15] (03CR) 10MarkTraceur: [C: 031] "(7 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [23:08:16] (03PS1) 10Kaldari: Adding a quotation marks message to core. [core] - 10https://gerrit.wikimedia.org/r/93880 [23:10:22] (03CR) 10Mattflaschen: [C: 032] "Latest master" [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93869 (owner: 10Mattflaschen) [23:11:42] (03CR) 10Mattflaschen: [C: 032] "Latest master" [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93870 (owner: 10Mattflaschen) [23:12:03] (03CR) 10Tim Starling: "Like I said, the format module under test works without the wddx extension, it's just the test itself that requires the extension. So skip" [core] - 10https://gerrit.wikimedia.org/r/93647 (owner: 10Tim Starling) [23:12:11] (03CR) 10Mattflaschen: [C: 032] "Latest master" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93873 (owner: 10Mattflaschen) [23:12:37] (03CR) 10Mattflaschen: [C: 032] "Latest master" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93874 (owner: 10Mattflaschen) [23:12:45] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93787 (owner: 10Manybubbles) [23:14:19] (03Merged) 10jenkins-bot: Bump GettingStarted for Growth team deploy [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93869 (owner: 10Mattflaschen) [23:16:09] (03Merged) 10jenkins-bot: Bump GuidedTour for Growth team deploy [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/93870 (owner: 10Mattflaschen) [23:19:04] (03Merged) 10jenkins-bot: Bump GettingStarted for Growth team deploy [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93873 (owner: 10Mattflaschen) [23:19:31] (03Merged) 10jenkins-bot: Bump GuidedTour for Growth team deploy [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93874 (owner: 10Mattflaschen) [23:19:50] hey multimedia team, is there a way to display a clipped and zoomed page 3 of a PDF in another wiki page? [[File:Agora specs.pdf|page=3|500px|select=50,200,450,380]] ? [23:26:10] werdna: Quim is here about the OPW, do you understand better about the animation idea? [23:26:27] ??? [23:28:34] hi werdna spage [23:28:49] https://www.mediawiki.org/wiki/FOSS_Outreach_Program_for_Women [23:28:59] Deadline for candidates is next Monday [23:29:01] oh, that's what OPW stands for [23:29:21] spagewmf: re: PDF, poke marktraceur, or bawolff (not here!) perhaps? [23:29:34] (03PS2) 10Dan-nl: re-work exception handling [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 [23:29:34] we need a Flo related project that would take *you* about 2 weeks == 3 months to a new intern [23:29:39] Flow [23:29:59] werdna, spagewmf look at the projects other teams are proposing to have an idea [23:30:13] as you see, all we need at this point is one paragraph and 1-2 mentors [23:30:29] more if-when interested candidates ask more details in order to work on their proposals [23:30:49] so animations with the back and forth would take a bit of time. We'd have to get designers to elucidate a bit about what they want. [23:31:00] but we need that paragraph as soon as possible! I have been chasing the Flow team for a while and it would be sad not to get anything at the end :) [23:31:54] I don't know about the project. I just hope that when you say "animations"we are talking about something more than an AJAX wheel :) [23:32:05] (03PS1) 10Andrew Bogott: Add 'http://' to the proxy backend definitions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/93886 [23:32:28] (03CR) 10Andrew Bogott: [C: 032 V: 032] Add 'http://' to the proxy backend definitions. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/93886 (owner: 10Andrew Bogott) [23:32:59] spagewmf, werdna proposal: discuss, agree, send me three lines explaining what you agreed via email, and I will write the paragraph for the wiki page out of that. [23:33:13] If you can send the three lines this afternoin then I can publish the text tonight [23:33:23] we don't have much time left [23:33:27] Ah, I figured the deadline was Monday… [23:33:38] but now I understand that the deadline on Monday is for candidates [23:33:40] not for proposals [23:33:47] werdna, the deadline for the candidates. Yep. [23:33:50] (03CR) 10Yuvipanda: "(1 comment)" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/93886 (owner: 10Andrew Bogott) [23:34:02] we are still welcomingnew candidates every day [23:34:15] qgil understood. We'd have to get a designer to flesh out what they're envisioning. qgil, can we add it to the "Raw projects" section instead of e-mail? [23:34:40] spagewmf, add it to the Featured projects directly [23:34:47] (03PS1) 10Chad: Remove stupid one-cell table [core] - 10https://gerrit.wikimedia.org/r/93887 [23:34:57] ... which is the one transcluded to the OPW page [23:35:32] (03CR) 10Dan-nl: "the set_error_handler() in the AjaxHandler is meant to take care of a E_USER_NOTICE that is triggered when display_errors is set to true. " [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/93763 (owner: 10Dan-nl) [23:35:35] BUT really: is this a 2 week work for an experienced contributor, a 3 month internship??? [23:35:47] spagewmf, werdna ^^^^^that is very important [23:36:21] qgil: we'll talk about it I guess [23:36:30] (03PS2) 10Chad: Remove stupid one-cell table [core] - 10https://gerrit.wikimedia.org/r/93887 [23:36:40] (03CR) 10Andrew Bogott: "(1 comment)" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/93886 (owner: 10Andrew Bogott) [23:36:50] (03PS1) 10Gergő Tisza: Use description HTML structure instead of categories to identify license [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93889 [23:37:23] spagewmf: In general I wouldn't mind having a project other than animation, but maybe we can talk about it at standup [23:38:02] werdna qgil, me too, I couldn't think of one. Dealing with designers could be days, could be months :) [23:38:05] werdna, spagewmf I'd rather wait one extra day in exchange of a good project than offering one that turns out to be very simple: that would deceive the purpose of the internship. [23:38:52] (03CR) 10Dan-nl: "thanks mark. this works fine in our test environment." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [23:38:54] when is your standup? [23:39:10] in like 45 minutes [23:39:42] ah, good. Then yes please. Discuss and let me know or publish directly the project idea under Featured projects. Thank you! [23:40:43] have to run now, thanks spagewmf werdna [23:40:58] seeya [23:43:28] (03PS1) 10EBernhardson: Dont insert serialized Message objects into recentchanges [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93892 [23:49:23] (03CR) 10EBernhardson: [C: 032] Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [23:49:36] (03Merged) 10jenkins-bot: Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [23:50:27] (03CR) 10BryanDavis: [C: 032] "Approving based on Mark's "merge if it works" +1 and Dan's "yes it works" response." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [23:50:35] (03Merged) 10jenkins-bot: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [23:52:05] (03PS2) 10Tim Starling: Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 [23:53:25] (03CR) 10jenkins-bot: [V: 04-1] Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 (owner: 10Tim Starling) [23:59:00] (03CR) 10Catrope: [C: 031] Introduce WebRequest::getProtocol() [core] - 10https://gerrit.wikimedia.org/r/93425 (owner: 10Tim Starling)