[00:18:35] Dereckson: apparently. [01:02:18] Reedy, why did you abandon the commit of live hacks? [01:06:06] I always do [01:06:09] So it's not an open changest [01:06:17] It's automatically pulled into the new branch [01:06:20] No need for it to stay open [06:12:28] how do i code for kwix ? [08:01:09] hi MatmaRex [08:39:00] I don't understand, is the silent grrrit-wm reported on bugzilla? I don't see anything [08:44:09] oh, emails resurrected? [08:51:22] Nemo_bis: I filed a bug about it, so if no one is around, chad or Ryan_Lane can fix it when they are online [08:52:32] filed when? I just filed https://bugzilla.wikimedia.org/show_bug.cgi?id=56528 [08:53:06] a minute before you by the looks [08:54:25] duplicated, if you don't mind, because mine had some more info :) [12:01:17] hi MatmaRex [12:03:14] hi mayankmadan [12:03:30] can you send that link with the bugs again [12:03:46] sure [12:03:51] i think it was https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=NEW%20%21easy%20-whiteboard%3Agci2013 ? [12:03:56] i was using my dad's computer yesterday and couldnt save it [12:05:02] can you also explain me what is the use of mediawiki?? i just cloned it from git and installed it but i dont get it [12:05:31] mayankmadan: this IRC channel is also publicly logged, so you can find everything that was said in the past [12:05:34] !htmllogs [12:05:34] http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23mediawiki [12:05:59] (that should actually be http://tools.wmflabs.org/wm-bot/logs/index.php?display=%23wikimedia-dev – the link above points to logs for a different channel, sorry) [12:06:09] mayankmadan: well, the primary use is Wikipedia? [12:07:58] but now as i installed it, what can i do with it? [12:08:26] is it something that one can use as a template for building websites? [12:09:55] you can use it to build "wiki"-type sites, similar to Wikipedia [12:10:04] okay [12:10:12] https://en.wikipedia.org/wiki/Wiki [12:10:25] MediaWiki was originally written for Wikipedia [12:11:25] (also, you might want to read https://www.mediawiki.org/wiki/Differences_between_Wikipedia,_Wikimedia,_MediaWiki,_and_wiki if all the similar terms are getting mixed up for you) [12:11:59] thanks [12:21:04] MatmaRex: can you explain me this bug? [12:21:08] https://bugzilla.wikimedia.org/show_bug.cgi?id=49077 [12:21:38] steps to reproduce says to click vote [12:21:54] where is the 'vote' mentioned here [12:23:45] mayankmadan: this is a bug report about our Bugzilla itself, it's probably not relevant to GCI tasks – but sure, one sec [12:24:00] http://i.imgur.com/rYlZZxF.png [12:24:42] (then click "Change My Votes" on the next page) [12:24:49] ugh why is that upstream bug assigned to anyone… [12:25:15] and its already fixed upstream anyway by the looks… [12:25:22] mayankmadan: note the Product and Component fields – they describe where the bug is in [12:25:38] mayankmadan: you will probably be interested with the ones where Product is "MediaWiki" or "MediaWiki extensions" [12:25:50] okay [12:48:34] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=28278 [12:48:38] this bug [12:50:12] i used time() twice and saved it in 2 variables and used gmdate() to convert it in minutes and seconds [12:50:17] but how do i test this? [12:51:46] mayankmadan: hmm, just run the update.php script? if your database is up-to-date (it definitely is if you just installed MediaWiki), it will just print information that everything is okay [12:52:00] run `php maintenance/update.php` from shell [12:52:30] it is normally used when updating your MediaWiki installation to a newer version (https://www.mediawiki.org/wiki/Manual:Upgrading#Command_line ) [12:52:46] (https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script , rahter) [12:58:29] MatmaRex: $wgShowExceptionDetails where is this variable [12:59:01] mayankmadan: i don't understand? all $wg variables are documented on mediawiki.org (or at least should be) [12:59:02] !wg ShowExceptionDetails [12:59:03] https://www.mediawiki.org/wiki/Manual:%24wgShowExceptionDetails [12:59:22] most of them is defined in includes/DefaultSettings.php [13:21:16] update.php is giving me an error [13:21:49] it says no viable database extension for mysql but i have lampp installed and it has a mysql database [13:22:10] huh. does MediaWiki itself work? [13:23:07] yep [13:24:03] huh. that's weird, i don't really know what to do [13:24:10] can you copy-paste the entire error message? [13:24:12] !pastebin [13:24:12] To avoid overflowing the channel with inane amounts of text, use https://dpaste.org/ or other awesome pastebin sites to share code, errors, and other large texts. [13:24:43] (and the command you ran) [13:25:43] here is exact error [13:25:44] http://pastebin.com/xTbt7kx9 [13:27:42] hmm [13:28:03] mayankmadan: are you sure the PHP that runs the "normal" MediaWiki and the one that runs from command-line is the same one? [13:28:25] mayankmadan: maybe try running `php5 maintenance/update.php` or something [13:29:00] same error [13:29:14] it would seem like your command-line PHP doesn't have the 'mysql' extension installed [13:29:26] but MediaWiki checks for that during installation, and won't be installed in such case [13:30:13] system updates? [13:32:17] mayankmadan: php -r "phpinfo();" [13:34:29] mayankmadan: if you don't make it work, you can always run MediaWiki inside a virtual machine – we have a Vagrant package, set up so it Just Works :) [13:34:30] !vagrant [13:34:30] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [13:35:27] and by the way i installed php separately after installing lampp [13:37:58] mayankmadan: yeah… your lampp stack is probably using a different executable than the one available on command line [13:38:12] is there a quick fix for that? [13:39:10] uh, maybe [13:39:29] let me try some things [13:40:03] mayankmadan: please run `which -a php` and tell me the output [13:40:18] lazowik: http://pastebin.com/DNP1WTAR [13:40:23] output of phpinfo [13:40:31] mayankmadan: this should print paths to all 'php' executables you have in your PATH [13:40:46] /usr/bin/php [13:41:10] how about a symlink to php in lampp [13:41:11] MatmaRex: http://pastebin.com/DNP1WTAR -> no mysql at all [13:41:38] mayankmadan: yeah, if you can find the other php, you could symlink it somewhere or just run it directly [13:42:32] but that's pretty weird [13:42:55] or you could just try installing mysql support for the command-line php [13:43:15] `apt-get install php5-mysql` or something, probably, i'm not an expert in these things [13:43:41] ^ that's ok [13:43:57] (the command would probably depend on your linux distro) [13:44:15] ah, its ubuntu, so that should be okay [13:44:18] yep [13:45:45] after installing the mysql extension [13:45:53] the error changes to [13:46:03] DB connection error: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) (localhost) [13:46:37] that's probably mysql configuration issue [13:47:02] mysqld is running? :p [13:48:12] mayankmadan: http://stackoverflow.com/questions/5376427/cant-connect-to-local-mysql-server-through-socket-var-mysql-mysql-sock-38 [13:55:06] v [13:55:07] mysqladmin -u root -p status [13:55:38] this command first gave me an error that mysqladmin is not installed [13:55:43] then i installed it [13:56:12] now it asks for passwords which i think is '' but it gives an error [13:56:17] lazowik: ^ [13:56:21] em [13:56:37] try without -p [13:57:15] error: 'Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)' [13:57:15] Check that mysqld is running and that the socket: '/var/run/mysqld/mysqld.sock' exists! [13:57:25] okay [13:57:30] service mysql status ? [13:57:38] (without question mark :p) [13:57:54] or mysqld [13:58:44] unrecognized service [13:59:04] with mysqld also? [13:59:37] it wants me to install mysql-server-core [13:59:45] em [14:00:05] how did you install lamp? [14:00:09] also [14:00:13] dont remember [14:00:14] ps aux | grep mysql [14:00:19] it was a long time ago [14:00:51] basically i have to servers install [14:00:54] lampp and nginx [14:01:08] i have to stop nginx everytime i want to start lampp [14:01:21] nginx gets started on startup [14:01:27] mhm [14:01:47] how do you start lampp? [14:03:01] (sorry everyone, i'm out of here for now – good luck and if you can't get linux to cooperate, try the vagrant image :) ) [14:03:28] sudo /opt/lampp/lampp start [14:03:47] lampp is a port of xampp back to Linux? :) [14:03:59] apparently [14:04:05] quite strange setup [14:04:36] mayankmadan: ls /opt/lampp/bin/* | grep php [14:05:38] /opt/lampp/bin/php [14:05:38] /opt/lampp/bin/php-5.4.7 [14:05:38] /opt/lampp/bin/php-cgi [14:05:38] /opt/lampp/bin/php-cgi-5.4.7 [14:05:38] /opt/lampp/bin/php-config [14:05:38] /opt/lampp/bin/php-config-5.4.7 [14:05:40] /opt/lampp/bin/phpize [14:05:42] yay ! [14:05:42] /opt/lampp/bin/phpize-5.4.7 [14:05:44] /opt/lampp/bin/swftophp [14:05:44] stop! [14:06:00] now try running /opt/lampp/bin/php update.php [14:07:50] finally it worked [14:07:52] !!! [14:07:52] There is no such key, you probably want to try: !tss, !hss, !bribe, [14:07:53] :) [14:08:01] !bribe | mayankmadan [14:08:01] mayankmadan: Stroopwafels for everyone!!! [14:08:23] :D [14:08:47] mayankmadan: btw. me, MatmaRex and saper are all from Poland :p [14:09:01] poland!! [14:09:08] well im from india [14:09:23] there is a significant difference in timezone [14:09:33] mayankmadan: now if you want to keep using this setup, use /opt/lampp/bin/php for php [14:11:21] mayankmadan: and if you're going to install lamp in the future, do it the right(tm) way [14:11:22] http://howtoubuntu.org/how-to-install-lamp-on-ubuntu#.UnZZL5RaatU [14:11:37] each package separately [14:12:00] then they also get updated together with normal system updates [14:12:19] okey doke [14:12:26] and then your php is the right php :) [14:12:55] how do i make a patch for a bug [14:13:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=28278 [14:13:11] for this one [14:13:22] i have solved the bug [14:13:46] mayankmadan: [[:mw:Developer_hub]] [14:13:55] wm-bot: ^ [14:13:55] Hi lazowik, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [14:14:05] pffff [14:14:06] https://www.mediawiki.org/wiki/Developer_hub [14:16:23] you need to get handy with git [14:16:36] then with https://www.mediawiki.org/wiki/Gerrit [14:16:46] do i submit a diff on gerrit or what [14:17:10] firstly you sign up for developer access [14:17:17] then you set that up [14:17:22] get your clone of git repo [14:17:28] make changes locally [14:17:32] commit them locally [14:17:37] and then push to review [14:18:41] if you haven't worked with git/gerrit yet you need to read a bit [14:18:57] and then probably set your own repo on github or somewhere [14:19:03] play with that a but [14:19:19] and when you confident with that read about gerrit [14:19:22] sorry, got to go [14:19:52] anyone else ready to assist? :p [14:23:04] wm-bot: [14:23:04] Hi mayankmadan, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [14:23:36] mayankmadan: also for the future: if you got questions about mediawiki (like the one with update.php) it's better to ask at #mediawiki [14:23:39] What's up with grrrit-wm? Looks dead :/ [14:48:57] i cannot push the changes [14:49:35] it asks for gerrit username and password and then says authentication failed but i know that i entered the right credentials [14:54:17] is it because i didnt use my username while cloning the repository? [14:58:11] mayankmadan: No [14:58:57] Have you configured you public key on gerrit properly? [15:05:12] hoo: than what could be the problem? [15:05:54] mayankmadan: Is it asking you for the passphrase of your ssh private key? [15:08:16] no its asking me for username of gerrit.wikipedia.org [15:08:40] i havent confirmed my email address :) [15:08:43] could it be a prob [15:09:25] hoo: ^ [15:09:44] I doubt... can you login on gerrit.wikimedia.orG [15:09:46] * org [15:10:04] yes [15:13:16] hoo: now what? [15:14:06] It's asking you for your gerrit user name and then immediately tells you authentication failed? [15:14:22] no [15:14:30] then it asks for my password [15:14:41] then it says authentication failed [15:22:52] hi MatmaRex [15:23:16] lazowik solved the problem with php [15:23:27] but now im stuck at pushing my changes [15:23:37] mayankmadan: oh, cool :) what's going wrong? [15:24:05] it first asks for my gerrit username then my password then it says authentication failed [15:24:48] mayankmadan: are you using git-review? [15:24:54] yes [15:25:09] mayankmadan: have you create a public/private key pair and submitted your public key to gerrit? [15:25:16] yes [15:25:22] the rsa key right [15:25:44] yeah [15:25:45] hmm. [15:26:05] okay, obvous next question – what's the full output of the command when it doesn't work? :) [15:26:49] git push [15:26:49] Username for 'https://gerrit.wikimedia.org': mayankmadan [15:26:49] Password for 'https://mayankmadan@gerrit.wikimedia.org': [15:26:49] fatal: Authentication failed [15:27:01] i run git push [15:27:23] ah [15:27:29] try running `git review` instead [15:27:50] just git review?? [15:27:53] yes [15:28:20] (you will not need `git push` normally when working with gerrit, it does its own weird things :) ) [15:28:50] no error now [15:29:18] has it submitted a review request on gerrit? [15:30:16] mayankmadan: it should link the review page in the message in prints [15:30:28] mayankmadan: and you should see it on your dashboard on https://gerrit.wikimedia.org/ [15:30:41] there it is, https://gerrit.wikimedia.org/r/#/c/93323/ :) [15:31:03] usually new review requests are relayed to this channel too, but the bot that does it is apparently broken [15:31:13] YuviPanda: grrrit-wm is down? [15:31:56] now is the code right or it is lacking something [15:32:05] it gives the desired output [15:32:27] mayankmadan: it looks nice at a glance :) [15:32:35] mayankmadan: can you update the commit message per https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Example ? [15:34:29] MatmaRex: Gerrit is broken by the looks not grrrit [15:34:31] mayankmadan: and can you update the whitespacing in your code to match the rest of it? we usually add spaces within parentheses and around operators [15:34:39] rumor has it that gerrit isn't sending emails or something [15:34:51] mayankmadan: (i posted an inline comment on https://gerrit.wikimedia.org/r/#/c/93323/1/maintenance/update.php with an example) [15:34:56] p858snake|l: hmm. [15:35:39] but grrrit-wm isn't using the e-mails afaik [15:35:46] it uses some ssh feed or something [15:35:48] so not just emails [15:35:48] eh. [15:38:06] anyway, there is a bug filed about it [15:38:48] MatmaRex: now how do i change the update.php in gerrit [15:38:56] !b 56528 [15:38:56] https://bugzilla.wikimedia.org/56528 [15:39:34] p858snake|l: thanks [15:39:49] mayankmadan: amend your commit (using `git commit --amend`) and run `git review` again [15:40:47] mayankmadan: sorry, i have to disappear now, i'll check what you come up with later – but i see you've already figured out how it all works :D [15:50:44] https://wikitech.wikimedia.org/wiki/Talk:Main_Page#Signup_messages_improvements [16:12:13] grrrit-wm: [16:12:19] grrrit-wm help [16:12:31] meh... can someone it? [16:12:36] * restart it [16:14:21] hoo: it's gerrit that's broken [16:14:31] no gerritmail either [16:14:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=56528 [16:14:45] and, this being weekend, there's no one around to fix it [16:15:17] ... -.- [16:21:20] I restarted it (=grrrit-wm) five or six hours ago [16:21:43] after looking it up on Wikitech and discovering to my great surprise that my name is in the list of admins [16:22:18] so yeah, it's not the bot [16:22:28] :/ [16:22:37] i think yuvi rigged up something that pipes gerrit events into redis [16:22:47] is jenkins picking up changes? [16:23:13] jenkins uses the gerrit stream-events interface (or at least it did), but it did not rely on the tool labs setup [16:23:29] *does not rely [16:23:42] ori-l: it is, e.g. https://gerrit.wikimedia.org/r/#/c/93323/ [16:24:13] so it's likely the gerrit-to-redis piece that is malfunctioning [16:25:45] hm. [16:25:48] yeah, gerrit stream-events works [16:26:00] i just rebased a patch and it showed up in the stream [16:28:51] icinga-wm> PROBLEM: #wikimedia-dev is being taken over by humans. [16:30:11] local-gerrit-to-redis@tools-login:~$ tail -1 ~/logs/stream-receiver [16:30:11] 2013-11-02 20:43:12,576 Pushed to 1 clients [16:30:23] that is indeed the last change that appeared on IRC, IIRC. [16:33:02] i *think* i restarted gerrit-to-redis just now? [16:33:13] someone generate some gerrit activity [16:33:57] (03PS3) 10Bartosz Dziewoński: mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 (owner: 10Ori.livneh) [16:34:02] done. [16:34:12] thanks ori-l, you're the best [16:34:36] uuh [16:35:01] .bash_history is the best [16:35:10] lol [16:36:01] \o/ [16:36:03] i'll update the page on wikitech [16:36:12] (03CR) 10Bartosz Dziewoński: "CR from IRC:" [core] - 10https://gerrit.wikimedia.org/r/92895 (owner: 10Ori.livneh) [16:36:37] also, http://tools.wmflabs.org/wm-bot/logs/ eats my Unicode ellipses and pauses :( [16:36:38] btw, it doesn't need to be wrapped in a try/catch [16:36:42] i remembered why [16:36:53] because it's wrapped in a check for mw.loader.store.enabled [16:37:02] which isn't set to true unless localStorage worked [16:37:26] but the Math.max thing is still wtf [16:37:41] MatmaRex: it's probably related to the bug about unicode bugzilla usernames relayed by wikibugs, some IRC libraries seem to have problems with unicode [16:38:27] Nemo_bis: it's 2013 and we still can't manage to not break a byte stream during transmission. :( [16:38:31] ori-l: ah, cool, thanks [16:41:07] Nemo_bis: but the logs are generated by wm-bot, i think, which has literally everything different than wikibugs [16:41:30] it's written in C#, for one [16:45:08] but wikibus is probably writing with mixed encoding or something [16:45:14] *wikibugs [16:48:14] https://wikitech.wikimedia.org/w/index.php?title=Grrrit-wm&diff=87837&oldid=86404 [16:51:59] ori-l: <3 [16:52:05] ori-l: "(Tag: VisualEditor)"? living on the edge i see [16:52:58] it's pretty nice, you know [16:54:52] i don't use it for everything but when i do i usually find i enjoy it [16:55:21] of course my 2005-2013 edit count is roughly equivalent to nemo's daily output [17:08:40] (03PS4) 10Ori.livneh: mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 [17:09:30] ugh. [17:09:32] trailing comma. [17:09:51] strange that we don't have a check for that [17:10:14] we don't? i'm pretty sure we used to have [17:10:20] via jshint [17:10:24] (03PS5) 10Ori.livneh: mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 [17:12:50] i put a try / catch anyway, btw [17:13:17] the modernizr localStorage feature capability test has a sobering comment about localStorage [17:13:45] https://github.com/Modernizr/Modernizr/blob/6df5f80eb3af3d54c51c52d59fc23586cffc2133/feature-detects/storage/localstorage.js#L21 [17:14:40] yeah [17:19:42] (03CR) 10Ori.livneh: "PS2-5: Made changes suggested by Bartosz. I kept the slightly silly GB / TB / PB support with an eye toward making this helper function a " [core] - 10https://gerrit.wikimedia.org/r/92895 (owner: 10Ori.livneh) [17:24:38] anyone notice anything wonky with test or test2 over the last couple of days? [17:25:22] yes, but it was supposedly fixed [17:25:27] (related to betafeatures release0 [17:25:28] ) [17:25:42] kk [17:25:50] i quietly enabled module storage [17:26:05] ah, that's why you're asking :D [17:26:06] i meant to e-mail wikitech but haven't been diligent enough to write it up [17:27:40] it'll be disabled for a while on production wikis but opt-in-able by manually setting a cookie [17:27:53] http://i.imgur.com/K94sHFH.png heh, the button gets squished. [17:28:18] heh [17:32:17] the code fails over to normal module loading via requests to bits [17:32:31] and i think the cache invalidation piece is right too [17:33:01] (03CR) 10Legoktm: "(2 comments)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/93161 (owner: 10Addshore) [17:35:43] (03PS6) 10Ori.livneh: mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 [17:38:46] argh, one more revision [17:39:48] (03PS7) 10Ori.livneh: mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 [17:40:18] (03CR) 10Ori.livneh: "PS6: rebase; PS7: make report return an array" [core] - 10https://gerrit.wikimedia.org/r/92895 (owner: 10Ori.livneh) [17:44:42] (03CR) 10Ori.livneh: [C: 032] Remove obtrusive styles for [core] - 10https://gerrit.wikimedia.org/r/89174 (owner: 10Bartosz Dziewoński) [17:44:52] (03PS2) 10Ori.livneh: Remove obtrusive styles for [core] - 10https://gerrit.wikimedia.org/r/89174 (owner: 10Bartosz Dziewoński) [17:44:59] (03CR) 10Ori.livneh: [C: 032] Remove obtrusive styles for [core] - 10https://gerrit.wikimedia.org/r/89174 (owner: 10Bartosz Dziewoński) [17:46:27] legoktm, your irc.wikimedia.org bot keeps getting killed for excess flood [17:46:43] errr [17:46:44] wtf [17:46:47] what nick? [17:46:57] legobot [17:47:04] (03CR) 10Umherirrender: "Sounds like bug 23192" [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/87643 (owner: 10Lambdafu) [17:47:17] fml [17:47:19] i killed it [17:47:26] presumably running somewhere in tool labs because it has the username "local-lego" [17:47:35] yeah [17:47:58] sorry about that [17:49:09] well, it doesn't really affect me, but I thought you should know anyway [17:50:16] (03Merged) 10jenkins-bot: Remove obtrusive styles for [core] - 10https://gerrit.wikimedia.org/r/89174 (owner: 10Bartosz Dziewoński) [18:03:56] (03PS1) 10Karima Rafes: Fix a little error in the text [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/93327 [18:05:39] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93324 (owner: 10Nemo bis) [18:07:08] (03CR) 10Karima Rafes: [C: 032 V: 032] Fix a little error in the text [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/93327 (owner: 10Karima Rafes) [18:19:38] (03CR) 10Siebrand: [C: 032] No title case [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93318 (owner: 10Matthias Mullie) [18:19:46] (03Merged) 10jenkins-bot: No title case [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93318 (owner: 10Matthias Mullie) [18:20:29] how do i work for kiwix ? [18:21:09] sakysharma: http://sourceforge.net/p/kiwix/kiwix/ci/master/tree/COMPILE has the instructions for setup [18:25:46] (03PS1) 10Hoo man: Fix cite parser tests [extensions/Cite] - 10https://gerrit.wikimedia.org/r/93330 [18:26:39] very easy merge [18:26:47] anyone? Blocks another change... [18:27:09] ok i got the procedure and say i have worked on a particular request now how do i submit it ? [18:27:47] MatmaRex: maybe ^ [18:31:24] (03CR) 10Bartosz Dziewoński: [C: 032] Fix cite parser tests [extensions/Cite] - 10https://gerrit.wikimedia.org/r/93330 (owner: 10Hoo man) [18:31:31] (03Merged) 10jenkins-bot: Fix cite parser tests [extensions/Cite] - 10https://gerrit.wikimedia.org/r/93330 (owner: 10Hoo man) [18:31:35] \o/ :) [18:31:41] thanks [18:32:11] (03CR) 10Hoo man: [C: 032] Only load RL modules when a tag is being used [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 (owner: 10Legoktm) [18:32:17] (03Merged) 10jenkins-bot: Only load RL modules when a tag is being used [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 (owner: 10Legoktm) [18:34:12] (03CR) 10Rtdwivedi: [C: 031] Add composer.json [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/93321 (owner: 10Tpt) [18:35:12] my pleasure [18:39:35] hoo: you probably want to backport that per the bug [18:39:41] hoo: or fix the milestone on the bug, either way [18:40:37] MatmaRex: Backport what? [18:41:46] hoo: the change you just merged, to REL1_22 branch [18:41:54] legoktm: or you. [18:43:10] the performance optimization? I don't think that's big enough to be backported [18:43:15] cite hasn't got this much JS [18:44:01] the bug is marked as 1.22 as the target milestone [18:44:21] so i guess it should be unmarked [18:46:34] probably, yes [18:47:18] (03CR) 10Bartosz Dziewoński: [C: 032] mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 (owner: 10Ori.livneh) [18:50:14] (03Merged) 10jenkins-bot: mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 (owner: 10Ori.livneh) [19:02:41] (03CR) 10Raimond Spekking: "I would be happy if you could add message documentation, see https://www.mediawiki.org/wiki/I18n#Message_documentation" [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/93327 (owner: 10Karima Rafes) [19:08:12] (03CR) 10Tpt: [C: 032] "Minor change reviewed by Aarti (thanks)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/93321 (owner: 10Tpt) [19:08:23] (03Merged) 10jenkins-bot: Add composer.json [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/93321 (owner: 10Tpt) [19:12:55] (03CR) 10Hoo man: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92348 (owner: 10Aude) [19:27:21] (03CR) 10Nemo bis: "PS3 (hopefully) fixes the whitespace and documentation issues; Chad's point is still to address." [core] - 10https://gerrit.wikimedia.org/r/47442 (owner: 10Micke) [19:33:15] awesome :D [19:33:55] Uhm. Thank you Legoktm. I'll take that as praise. [19:34:24] heh, hi Amgine [19:34:33] [19:55:50] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93354 (owner: 10L10n-bot) [19:59:48] (03PS1) 10IAlex: Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/93394 [21:17:30] MatmaRex: thanks [21:25:22] (03CR) 10Kaldari: [C: 031] "Looks good, haven't tested." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/93316 (owner: 10Addshore) [21:28:11] hoo: hey, do you understand how CentralAuth locking works? I'm trying to figure out how to force a user to be logged out for global rename, and have a hunch that it has something to do with clearing the session, but I'm a bit stuck. [21:30:33] legoktm: I do know how locks work, yes [21:31:06] so if i wanted to "lock" an account without actually locking it, how would i go about that? [21:33:09] I guess you could add that logic to CentralAuthHooks::onUserLoadFromSession [21:33:56] to store the state you should be using a new database table (we agreed on that in HK) [21:34:04] yes, that's what im doing [21:34:16] https://gerrit.wikimedia.org/r/#/c/92468/ [21:34:17] (03PS13) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [21:34:52] (03CR) 10jenkins-bot: [V: 04-1] Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [21:36:13] hoo: is it safe to read the master database in that function? [21:36:32] safe == not cause major performance issues [21:38:11] legoktm: ewk, I guess that's ok as the new table will be very short [21:38:45] we could also use memcached to help [21:40:43] (03PS11) 10Legoktm: [WIP] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [21:41:00] https://gerrit.wikimedia.org/r/#/c/92468/11/CentralAuthHooks.php [21:42:03] does that look correct? [21:42:30] renameInProgress shouldn't be a static method [21:43:14] it probably shouldn't. [21:43:16] ugh [21:48:45] (03PS12) 10Legoktm: [WIP] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [21:48:51] hoo: fixed [21:53:35] (03PS14) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [21:56:39] legoktm: :) By the time you're ok with it, I'll give it an extended code review [21:56:44] (03CR) 10Jdlrobson: [C: 04-2] "If it's good enough for Siebrand :)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88719 (owner: 10Raimond Spekking) [21:57:01] (03CR) 10Jdlrobson: [C: 032] "whoops negation sign was not what i wanted there ;-)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88719 (owner: 10Raimond Spekking) [21:57:02] pity we don't have a hackathon in autumn/ winter to pair code review that [21:58:31] i think i should be ready for real reviews by tomorrow, just want to test a few more things [21:58:39] :) [22:01:20] are you coming to the thing in january? [22:01:33] you are :D [22:01:43] I am, yes ;) [22:03:06] but I hope to have that in prior to that date [22:04:04] yes! [22:04:15] legoktm, it's probably a good thing that you're storing the global rename statuses in a table [22:04:23] and can show the status of renames on a wiki [22:04:32] ori-l: my pleasure [22:04:38] I can't remember why we tried to avoid that... [22:04:57] Krenair: I dunno, I always told people to do it like that [22:06:25] always? I thought this was the second attempt? [22:06:51] Well, we had a few talks about that at hackathons and on IRC [22:07:12] especially the pair code review in HK was very productive [22:07:20] (03PS1) 10Jdlrobson: Vector: Set media screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/93408 [22:07:42] you discussed global user rename in HK hoo? [22:08:05] Yes, did a pair code review with Chris [22:09:14] on my code? [22:10:23] Yes, it was your change AFAIR [22:10:40] ah, but he had added patchsets to it at that point [22:10:41] ok [22:15:59] (03PS1) 10Legoktm: Use $dbw since it's a master database [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/93409 [22:16:13] someone wanna merge that? ^ [22:17:27] (03CR) 10Hoo man: [C: 032] Use $dbw since it's a master database [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/93409 (owner: 10Legoktm) [22:17:29] done [22:17:30] (03Merged) 10jenkins-bot: Use $dbw since it's a master database [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/93409 (owner: 10Legoktm) [22:18:02] thanks [22:30:14] (03PS3) 10Addshore: Check key exists before using the value [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/93172 [22:30:20] hoo ^^ (nice spot..!) [22:31:25] (03CR) 10Hoo man: [C: 032] Check key exists before using the value [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/93172 (owner: 10Addshore) [22:31:28] (03Merged) 10jenkins-bot: Check key exists before using the value [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/93172 (owner: 10Addshore) [22:31:33] addshore: ;) Done [22:32:03] cheers ;p [22:32:27] been scanning through some mediawiki logs recently and I just kept seeing this notice EVERYWHERE! [22:56:56] (03PS2) 10Bartosz Dziewoński: Vector: Set media screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/93408 (owner: 10Jdlrobson) [22:58:10] (03CR) 10Jdlrobson: [C: 031] Vector: Set media screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/93408 (owner: 10Jdlrobson) [22:59:31] jdlrobson: let me recheck https://gerrit.wikimedia.org/r/#/c/92762/ first, i'd like to merge that too [23:00:14] hmm actually, let's not touch that right now [23:00:26] ori-l: around? ^ needs review from somebody who knows PHPUnit [23:01:18] i know phpunit? [23:01:36] (03Abandoned) 10Bartosz Dziewoński: Add missing media screen [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92672 (owner: 10Bartosz Dziewoński) [23:01:58] (03Abandoned) 10Bartosz Dziewoński: Vector: Set media=screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [23:02:32] (03CR) 10Bartosz Dziewoński: [C: 032] "I think this is the best we can do here. (I just fixed indentation.)" [core] - 10https://gerrit.wikimedia.org/r/93408 (owner: 10Jdlrobson) [23:02:43] ori-l: certainly better than me [23:02:48] ori-l: and resourceloader, too. [23:03:20] (03CR) 10Bartosz Dziewoński: "(Verified on IE8.)" [core] - 10https://gerrit.wikimedia.org/r/93408 (owner: 10Jdlrobson) [23:03:31] (03PS1) 10Bartosz Dziewoński: Vector: Set media screen on styles.less [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93412 [23:04:03] (03CR) 10Bartosz Dziewoński: [C: 032] Vector: Set media screen on styles.less [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93412 (owner: 10Bartosz Dziewoński) [23:04:14] alllllright. [23:05:38] legoktm: [23:05:40] https://www.mediawiki.org/w/index.php?title=Help%3AExtension%3AMassMessage&diff=812960&oldid=809939 [23:05:45] is beautiful! [23:05:47] Thanks! [23:05:49] :) [23:05:50] np [23:05:58] (03Merged) 10jenkins-bot: Vector: Set media screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/93408 (owner: 10Jdlrobson) [23:06:02] That whole page is lovely. [23:08:42] (03PS5) 10Bartosz Dziewoński: ResourcesTest: Assert no @media is used inside 'media'-specified resources [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [23:09:22] (03Merged) 10jenkins-bot: Vector: Set media screen on styles.less [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93412 (owner: 10Bartosz Dziewoński) [23:11:13] jdlrobson: thanks. [23:11:30] thanks MatmaRex for merging - was getting uncomfortable with how long a fix was going out :-) [23:12:33] jdlrobson: we should also get https://gerrit.wikimedia.org/r/#/c/92762/4 merged so we can avoid at least a part of this mess in the future [23:12:57] jdlrobson: the test looks okay to me, but i don't know enough about phpunit and RL to be comfortable with merging it [23:13:59] (03CR) 10Bartosz Dziewoński: [C: 031] ResourcesTest: Assert no @media is used inside 'media'-specified resources [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [23:15:10] phpunit on core is a bit broken for me spits out lots of BagOStuff errors (Warning: Invalid argument supplied for foreach() in /Users/jrobson/Sites/w/includes/objectcache/SqlBagOStuff.php on line 232) [23:18:48] MatmaRex: which patch? [23:19:04] ori-l: https://gerrit.wikimedia.org/r/92762 [23:19:46] i'm off to sleep. hope i didn't break anything with that [23:19:49] good night [23:19:55] good night [23:22:29] I'm going to try having Bugzilla and Gerrit e-mails go to the same folder. [23:22:34] We'll see what happens. [23:24:26] (03CR) 10Jdlrobson: [C: 031] "Codewise looks fine. PHPUnit on core is failing spectacularly for me due to some issues with SqlBagOStuff so I can't verify it does what i" [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [23:34:43] (03PS2) 10Tim Starling: Move the DeferredUpdates hierarchy to its own directory [core] - 10https://gerrit.wikimedia.org/r/93021 [23:35:38] (03CR) 10Tim Starling: [C: 032] "PS2: rebase." [core] - 10https://gerrit.wikimedia.org/r/93021 (owner: 10Tim Starling) [23:39:27] (03Merged) 10jenkins-bot: Move the DeferredUpdates hierarchy to its own directory [core] - 10https://gerrit.wikimedia.org/r/93021 (owner: 10Tim Starling) [23:39:50] (03CR) 10Hoo man: "(1 comment)" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/83354 (owner: 10Legoktm) [23:40:23] legoktm: [23:40:28] I updated . [23:40:28] Elsie: [23:40:31] ok [23:40:34] I'm going to update the help page soon. [23:42:34] (03PS1) 10Shirayuki: Fix pluralization (is/are) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93414 [23:46:49] legoktm: https://www.mediawiki.org/wiki/Help:Extension:MassMessage [23:48:04] woo thanks :D [23:53:47] (03PS2) 10Tim Starling: Introduce includes/utils directory [core] - 10https://gerrit.wikimedia.org/r/93022