[00:00:05] see ya Krinkle enjoy your time with Ed :) [00:00:11] thx [00:08:20] (03CR) 10MZMcBride: "I have two stupid questions:" [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [00:11:50] (03CR) 10Legoktm: [C: 04-1] "(1 comment)" [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [00:16:13] (03PS2) 10Werdna: Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [00:18:15] (03CR) 10Werdna: [C: 031] "PS2: A couple of minor adjustments:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 (owner: 10Matthias Mullie) [00:30:11] (03PS2) 10Werdna: Design changes via meeting with may [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93002 (owner: 10EBernhardson) [00:30:28] (03CR) 10Werdna: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93002 (owner: 10EBernhardson) [00:33:00] (03CR) 10Alex Monk: "MZMcBride:" [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 (owner: 10Alex Monk) [00:43:01] (03CR) 10Brion VIBBER: [C: 031] Only allow throttling if object caching is enabled... [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 (owner: 10Kaldari) [01:11:48] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Match method signature in base class [extensions/Push] - 10https://gerrit.wikimedia.org/r/92911 (owner: 10Jeroen De Dauw) [01:20:32] (03PS2) 10Werdna: (bug 56132) Hide hover-over for posts that are being edited [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92492 [01:22:41] (03CR) 10Werdna: "PS2: Change hiding method to use CSS instead of directly hiding." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92492 (owner: 10Werdna) [01:52:35] (03CR) 10Werdna: [C: 031] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92454 (owner: 10EBernhardson) [02:26:03] (03PS3) 10EBernhardson: Design changes via meeting with may [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93002 [02:26:20] (03PS4) 10EBernhardson: [WIP] Design changes via meeting with may [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93002 [02:27:26] (03PS1) 10Anomie: Add mw.isSubsting() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93019 [03:57:52] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93008 (owner: 10Jeroen De Dauw) [04:22:20] (03PS3) 10Legoktm: Unbreak some unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 [04:22:29] (03CR) 10jenkins-bot: [V: 04-1] Unbreak some unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [04:26:44] (03PS4) 10Legoktm: Unbreak the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 [04:27:21] (03PS5) 10Legoktm: Unbreak the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 [04:29:48] (03CR) 10EBernhardson: [C: 032 V: 032] "lgtm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [04:29:55] (03CR) 10jenkins-bot: [V: 04-1] Actually run all the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [04:31:13] (03PS3) 10EBernhardson: Actually run all the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [04:31:20] (03CR) 10jenkins-bot: [V: 04-1] Actually run all the unit tests. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [04:31:23] (03CR) 10EBernhardson: [C: 032 V: 032] Actually run all the unit tests. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [04:31:30] (03CR) 10jenkins-bot: [V: 04-1] Actually run all the unit tests. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [04:32:46] (03CR) 10Legoktm: "Hashar: do you know how we can override jenkins-bot? This is ready to be merged now that the tests are fixed in the follow up patch." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [04:41:34] yhager: found something wrong with facebook rendering for anons on some pages. tangentially wikipedia related [04:42:19] yhager: see the facebook logo in upper left corner. https://s3.amazonaws.com/f.cl.ly/items/122Y0e380H0V3Y3X1M38/Screen%20Shot%202013-10-31%20at%209.37.09%20PM.PNG [04:43:37] yhager: that says "wikipedia.org". and shows inset in the image below on chrome. same rendering for me on older iceweasel and someone else on OS X 10.9/Firefox 25. but Chromium on Wheezy renders in a more normal way [04:44:32] (who *should* i report these things to? i generally avoid logging in to facebook at all. which is part of why I noticed this... I was browsing logged out while researching another wikipedia issue) [05:09:54] i found a somewhat relevant pgae but it does in fact require having an account... [05:10:16] page* [05:10:36] anyway, yhager's gone [05:10:39] bbl :) [05:19:49] (03PS1) 10Tim Starling: Move the DeferredUpdates hierarchy to its own directory [core] - 10https://gerrit.wikimedia.org/r/93021 [06:30:18] (03PS1) 10Tim Starling: Introduce includes/utils directory [core] - 10https://gerrit.wikimedia.org/r/93022 [08:13:12] (03PS6) 10Hashar: Unbreak the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [08:15:38] (03CR) 10Hashar: [C: 032 V: 032] "In short: you can't really override jenkins-bot. It is meant to prevent people from merging in "bad" code :-D" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [08:22:27] (03CR) 10Hashar: [C: 032] "That is not an ideal fix, but it does fix them in a way which is sane enough to receive a merge :-D" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [08:22:36] (03Merged) 10jenkins-bot: Unbreak the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [08:26:11] (03CR) 10Mwjames: "You should never assume that a system sets an id or for that matter is available nor should you rely on GLOBALS during testing." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [09:08:03] (03PS1) 10Hashar: fix race condition in qunit tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93030 [09:10:49] (03CR) 10Hashar: [C: 032] fix race condition in qunit tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93030 (owner: 10Hashar) [09:11:07] (03Merged) 10jenkins-bot: fix race condition in qunit tests [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93030 (owner: 10Hashar) [09:50:07] (03PS1) 10Raimond Spekking: Consistency tweak in preparation for adding extension to translatewiki.net [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93036 [09:50:51] (03CR) 10Raimond Spekking: [C: 032 V: 032] Consistency tweak in preparation for adding extension to translatewiki.net [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93036 (owner: 10Raimond Spekking) [09:58:35] (03PS1) 10Raimond Spekking: Unbreak translatewiki.net scripts [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93040 [09:59:02] (03CR) 10Raimond Spekking: [C: 032 V: 032] Unbreak translatewiki.net scripts [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/93040 (owner: 10Raimond Spekking) [10:08:43] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88719 (owner: 10Raimond Spekking) [10:38:02] (03CR) 10Siebrand: [C: 032] Renamed "Your name" to "Your username" to match with the Media wiki login page [core] - 10https://gerrit.wikimedia.org/r/92681 (owner: 10Gerrit Patch Uploader) [10:41:21] (03Merged) 10jenkins-bot: Renamed "Your name" to "Your username" to match with the Media wiki login page [core] - 10https://gerrit.wikimedia.org/r/92681 (owner: 10Gerrit Patch Uploader) [11:31:30] (03PS4) 10Siebrand: Add close elements through code [core] - 10https://gerrit.wikimedia.org/r/88500 [11:35:48] (03PS10) 10Siebrand: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 [11:36:49] (03CR) 10Siebrand: "PS10 fixes merge conflict." [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [11:40:33] (03PS4) 10Siebrand: Update documentation [core] - 10https://gerrit.wikimedia.org/r/88497 [11:40:55] (03CR) 10Siebrand: "PS4 fixes merge conflict." [core] - 10https://gerrit.wikimedia.org/r/88497 (owner: 10Siebrand) [11:49:44] (03PS1) 10Krinkle: Remove exclusive module group to reduce HTTP request fragmentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93053 [11:51:59] (03CR) 10Hoo man: "Should we abandon this then? (With screen readers the links should work anyway as those modify the way anchors work)" [core] - 10https://gerrit.wikimedia.org/r/80799 (owner: 10TheDJ) [11:52:58] (03CR) 10Hoo man: ""but I still would like to see a way to make it clear to users (not only screenreader ones) that they can use the arrow keys to navigate" " [core] - 10https://gerrit.wikimedia.org/r/78640 (owner: 10TheDJ) [11:55:35] (03CR) 10Siebrand: [C: 04-1] "Per Timo." [core] - 10https://gerrit.wikimedia.org/r/4051 (owner: 10Daniel Friesen) [11:57:57] (03CR) 10Siebrand: [C: 04-1] "Per comments on PS2." [core] - 10https://gerrit.wikimedia.org/r/37685 (owner: 10Jarry1250) [12:05:25] (03CR) 10Daniel Kinzler: "If the developer knows that it's a WikitextContent object, use use $content->getNativeData()." [core] - 10https://gerrit.wikimedia.org/r/92827 (owner: 10Kaldari) [12:09:55] (03CR) 10Daniel Kinzler: [C: 031] "It's an improvement, though I agree with Bartosz: this should go into the Revision class (or a yet-to-be-create RevisionInfoStore service)" [core] - 10https://gerrit.wikimedia.org/r/92348 (owner: 10Aude) [12:15:18] (03CR) 10Siebrand: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/84212 (owner: 10Ara) [12:25:54] (03CR) 10Hoo man: [C: 032] "looks sane, merging per Brion" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 (owner: 10Kaldari) [12:26:35] (03Merged) 10jenkins-bot: Only allow throttling if object caching is enabled... [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 (owner: 10Kaldari) [12:28:12] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [12:29:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [12:32:09] (03CR) 10Hoo man: [C: 032] API: Add text for Unknown error: "permissiondenied" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92191 (owner: 10Umherirrender) [12:32:16] (03Merged) 10jenkins-bot: API: Add text for Unknown error: "permissiondenied" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92191 (owner: 10Umherirrender) [12:49:41] (03CR) 10Nemo bis: "Siebrand, updated how? As I said, I have no idea what that test is meant for." [core] - 10https://gerrit.wikimedia.org/r/83221 (owner: 10Nemo bis) [12:54:19] (03CR) 10Hoo man: [C: 032] "Worked fine (tested as Krinkle suggested)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 (owner: 10Legoktm) [12:54:30] (03CR) 10jenkins-bot: [V: 04-1] Only load RL modules when a tag is being used [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 (owner: 10Legoktm) [12:55:40] yay for unrelated test failures [12:55:40] legoktm: ^ [12:55:40] away for now [12:58:39] (03CR) 10Jeroen De Dauw: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93008 (owner: 10Jeroen De Dauw) [12:59:52] (03PS2) 10Jeroen De Dauw: Make it possible to install extensions using Composer [core] - 10https://gerrit.wikimedia.org/r/93008 [13:00:23] (03PS3) 10Jeroen De Dauw: Make it possible to install extensions using Composer [core] - 10https://gerrit.wikimedia.org/r/93008 [13:13:30] (03CR) 10Parent5446: "Dev requirements aside, the package suggestions are relevant for most users." [core] - 10https://gerrit.wikimedia.org/r/93008 (owner: 10Jeroen De Dauw) [13:13:43] (03CR) 10Parent5446: [C: 04-1] Make it possible to install extensions using Composer [core] - 10https://gerrit.wikimedia.org/r/93008 (owner: 10Jeroen De Dauw) [13:37:38] (03PS4) 10Jeroen De Dauw: Make it possible to install extensions using Composer [core] - 10https://gerrit.wikimedia.org/r/93008 [13:38:45] (03CR) 10Parent5446: [C: 031] Make it possible to install extensions using Composer [core] - 10https://gerrit.wikimedia.org/r/93008 (owner: 10Jeroen De Dauw) [13:41:20] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/91154 (owner: 10Addshore) [13:41:32] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [core] - 10https://gerrit.wikimedia.org/r/91392 (owner: 10Addshore) [13:42:35] (03CR) 10Addshore: [C: 031] Make it possible to install extensions using Composer [core] - 10https://gerrit.wikimedia.org/r/93008 (owner: 10Jeroen De Dauw) [13:45:17] (03CR) 10Parent5446: [C: 032] Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [13:46:25] (03CR) 10Siebrand: "Thanks, Tyler." [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [13:47:37] (03PS2) 10Krinkle: Only load RL modules when a tag is being used [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 (owner: 10Legoktm) [13:47:43] (03CR) 10jenkins-bot: [V: 04-1] Only load RL modules when a tag is being used [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 (owner: 10Legoktm) [13:48:17] (03Merged) 10jenkins-bot: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [13:49:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Yay for not Wikimedia specific." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/92993 (owner: 10MaxSem) [13:51:44] (03CR) 10Parent5446: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [13:54:54] (03CR) 10Danny B.: "Awesome! Many thanks!" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93019 (owner: 10Anomie) [14:10:23] (03PS1) 10Hashar: mwext-MobileFrontend-qunit-mobile is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93063 [14:10:33] (03CR) 10Hashar: [C: 032] mwext-MobileFrontend-qunit-mobile is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93063 (owner: 10Hashar) [14:10:43] (03Merged) 10jenkins-bot: mwext-MobileFrontend-qunit-mobile is now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/93063 (owner: 10Hashar) [14:26:28] (03CR) 10Kipcool: [C: 032 V: 032] API add_annotations:added test mode;ow_downloads:DfM [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/92485 (owner: 10Hiong3-eng5) [15:07:07] (03CR) 10Anomie: "ArrayUtils seems like it could go in includes/libs, unless the reasoning is that it's just too trivial to be a lib. Same goes for ScopedPH" [core] - 10https://gerrit.wikimedia.org/r/93022 (owner: 10Tim Starling) [15:10:12] hi, is there any separate channel for the new wikipedia android app? [15:10:31] #wikimedia-mobile perhaps? [15:11:16] bawolff, thanks :) [15:12:29] I made a mistake while filing a report on bugzilla. I was making reports for tasks that I am proposing for Google Code-in. [15:12:46] (03CR) 10Brion VIBBER: "Why not just use CSS for this? Let the browser do the work on sizing text!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 (owner: 10MarkTraceur) [15:13:20] I should have mentioned something like "minor to-do". [15:15:19] I don't see an option to add it now. [15:20:35] Rtdwivedi: Just add a comment [15:20:53] google code in bugs should also probably have the keyword "easy" in the keyword field [15:22:54] it't not a bug actually, just a minor feature enhancement. [15:24:32] bawolff: Thanks! :) [15:25:01] well the line between bug and "enhancement" tends to be very blurry around here anyways [15:25:16] (03PS1) 10Brion VIBBER: Bug 55477: MultimediaViewer hi-DPI support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93068 [15:25:44] darkowlzz: #wikimedia-mobile is the place yes :D [15:27:59] (03PS3) 10Parent5446: Fix extension functionality and backwards compatibility [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 [15:28:27] brion, thanks, I am already there :) [15:29:26] great :D [15:30:18] (03PS1) 10Cmcmahon: new test for editing existing title, also alphabetize and cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93069 [15:32:13] (03PS2) 10Cmcmahon: new test for editing existing title, also alphabetize and cleanup [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93069 [15:35:00] (03CR) 10Cmcmahon: "new test for anonymous user to click the pencil icon to manifest all the elements to change a topic title. I checked this in FF and Chrom" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93069 (owner: 10Cmcmahon) [15:40:28] (03PS1) 10Luis Felipe Schenone: Fixed a bug and simplified the special page [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/93070 [15:46:03] (03CR) 10Gergő Tisza: "There is no browser support currently for truncating multiline text AFAIK. We could use a fixed-max-height, overflow-hidden block, but tha" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 (owner: 10MarkTraceur) [15:51:35] (03CR) 10Brion VIBBER: "For a multiline field, I'd expect to be able to scroll if it doesn't fit..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 (owner: 10MarkTraceur) [15:56:52] (03PS1) 10Anomie: Update phpunit @group annotations [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93072 [15:57:10] brion: THAT'S BRILLIANT, IT CAN BE A SCROLLING DIV [15:57:18] Sorry to yell at you there [15:57:21] I hadn't thought of that [15:58:00] (03PS1) 10Anomie: LuaStandalone: Release functions when no longer referenced [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/93073 [15:58:20] \o/ [15:58:24] :D [15:58:48] bonus points if you make an awesome gradient fade-out on the bottom edge for when the scrolling is needed [15:59:00] holy crap is it 9am already? [15:59:03] i've been up since like 3 [15:59:08] my sleep schedule is all kinda of messed up [15:59:58] on the plus side i was awake when the trash truck came by so i didn't miss it :D [16:00:12] Hah [16:00:47] brion: Wait, are you suggesting I make this a non-browser-default scroll behaviour? [16:00:55] Because that sounds purty awful [16:01:14] i don't know what i'm suggesting anymore [16:01:17] i shoulda slept more :D [16:01:21] Yes [16:01:23] Always true [16:01:43] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Fixed a bug and simplified the special page [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/93070 (owner: 10Luis Felipe Schenone) [16:03:24] brion: Should I ignore your patches, then, until you've had a chance to look at them fully awake? :) [16:04:22] :D [16:05:58] (03PS1) 10Luis Felipe Schenone: Minor improvements [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/93074 [16:06:52] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Minor improvements [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/93074 (owner: 10Luis Felipe Schenone) [16:08:25] * marktraceur snickers at roblaAWAY's comment about Tim Starling Day [16:13:41] (03PS1) 10MaxSem: Allow callers to specify timestamp formats outputted by API [core] - 10https://gerrit.wikimedia.org/r/93075 [16:13:46] Wait, are we instantiating this "new extensions need their own deploy window" thing today? [16:13:52] 'cause if so [16:13:57] I need to find a deploy window [16:16:48] (03CR) 10Anomie: "The first question I have here is "what problem does this solve"? It seems like a lot of added complexity when clients should find ISO 860" [core] - 10https://gerrit.wikimedia.org/r/93075 (owner: 10MaxSem) [16:20:05] (03PS2) 10MarkTraceur: Bug 55477: MultimediaViewer hi-DPI support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93068 (owner: 10Brion VIBBER) [16:28:38] csteipp: Saw my PM earlier? [16:29:26] hoo: Yeah, let me look at it... [16:39:07] ^d: I shot all but one of those maintenance scripts because [16:39:19] they kept growing in memory use until the machine went into swap [16:39:30] <^d> Yeah. We're in the home stretch now. [16:39:32] so I picked em off 1 or 2 at a time hoping that it would be enough [16:39:35] but it never was [16:40:00] <^d> I'll be keeping a close eye on them today so I can max out the number of procs without swapping. [16:40:12] i.e. there's one right now using 10gb [16:40:58] <^d> I've killed that one. [16:41:57] ps and ganglia claim otherwise! [16:42:58] <^d> Which pid? I thought it was 22273 [16:43:14] <^d> Ah, 22277 [16:43:15] 22277 [16:43:16] yep [16:44:37] so the problem with these processes is that they grow to fill all available memory [16:44:55] <^d> Yeah. I'm working on a rewrite that ends up using the jobqueue instead. [16:45:00] <^d> So we can spread the load. [16:45:35] ok, but it's ot about load, it's about a memmory leak I guess... unless you actually need all the data for the entire range to be in memory [16:45:40] *not about [16:46:38] is ti building a giant table or something? or is there something it's not releasing after it does a batch? [16:46:44] <^d> Well by spreading the load so each job only has a set # of pages to handle then exit, you won't have the memory problem. [16:46:47] I thought these batches were realtively small... [16:46:59] <^d> It handles 500 pages at a time then releases all of that stuff. [16:47:04] *relatively (typing is hard) [16:47:16] ok so somewhere it is not releasing quite everything [16:47:31] <^d> Even if Cirrus does everything right, it could be core's fault. [16:48:09] <^d> It doesn't surprise me at all that a MW maintenance script running for 18+ hours starts to use up all the memory. [16:48:31] <^d> Especially one parsing pages ;-) [16:48:33] well we have dumps that run a lot longer than that... [16:48:37] ^d: can it restart? [16:48:41] <^d> Yep. [16:48:44] like give it a batch [16:48:52] <^d> I restarted the killed ones from where they left off. [16:48:53] run, stop , do next batch [16:48:57] ok [16:48:58] some of these othr maintenance scripts are pretty slow iirc [16:48:59] anyways [16:49:21] <^d> aude: And that's what I'm doing anyway. We're actually spreading the 14mil pages over 16 batches. [16:49:34] 16 batches might be too few [16:49:56] <^d> Can't run any more than 16 in parallel. [16:49:58] in hindsight (which is always 20-20) having a little script that would do 100k pages in a batch and cycle through them [16:50:01] <^d> Even that's pushing it. [16:50:01] oh, ok [16:50:20] from some start and endpoint, might have avoided being stuck in swap [16:50:21] <^d> apergos: I can give the things ranges, but I might need smaller ranges :) [16:50:32] well what I mean is, a bash script [16:50:36] <^d> Yeah [16:50:41] that gives the maintenance script the first 100k [16:50:52] then the next... etc til it's done its 1 million, ay [16:50:53] say [16:51:01] anyways, like I say, easy to say in hindsight [16:51:20] <^d> Yeah. Anyway the whole thing doesn't scale, period. [16:51:29] <^d> My current thinking is using the jobqueue, like I said. [16:52:01] ^d: but not for force index? [16:52:07] only for search update [16:52:48] <^d> Yeah. [16:52:58] <^d> I was thinking SearchUpdate on Wednesday but wasn't thinking :p [16:53:06] <^d> Defeats the point of NRT! [16:53:07] makes sense [16:54:53] <^d> Yay, batch 3145998-4194664 finished :D [16:54:59] :) [16:56:31] <^d> We're at 10266192 documents now, whatever percentage that is :p [16:57:13] Hello Everyone! I am here for GCI [16:57:15] that's a good amount, though sounds like half are in general, half in content index [16:57:31] can anyone please tell me what programming languages would i need for competing? [16:57:49] mayankmadan: Hi! [16:57:52] hi mayankmadan [16:58:03] mayankmadan: primarily PHP and JavaScript, I think [16:58:10] great!! [16:58:16] mayankmadan: We tend to use PHP and JavaScript, but we also have a bunch of projects that you could use Lua or Python for [16:58:17] lua, perhaps [16:58:23] for making templates [16:58:39] python is also good for me [16:58:40] :) [16:58:44] Maybe even C#, if petan is willing to let GCI people loose in the wm-bot codebase :P [16:58:44] python is good [16:58:57] qgil: ^^ [16:58:59] there is work on pywikibot [16:59:06] pywikipedia [16:59:28] java for android apps [16:59:32] mayankmadan: qgil is "da man" when it comes to our developer outreach programs, so hopefully he'll have some insight :) [17:00:04] are there any example task list? [17:00:12] Or maybe he'll walk away [17:00:16] Uhhh [17:00:19] https://www.mediawiki.org/wiki/Google_Code-In [17:00:24] mayankmadan: we're working on the list, the WIP version is available there ^ [17:00:28] what aude linked [17:01:11] Thanks MatmaRex, marktraceur, aude :) [17:03:53] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/93075 (owner: 10MaxSem) [17:04:34] mayankmadan, you are the first student asking about Google Code-in. Take this as an honorific first point. :) [17:05:53] mayankmadan, Please take some time reading https://www.mediawiki.org/wiki/Google_Code-In (thanks aude ) and the related links. [17:06:15] mayankmadan, in fact, you could already find out how to "watch" that page to receive notifications when we update it [17:07:46] (03PS1) 10Brion VIBBER: Fullscreen support for IE 11 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93076 [17:08:03] Oooh. [17:08:19] brion: Wait, IE11 doesn't "just" support the normal JS way of fullscreening? [17:08:36] Danny_B, ^d: either of you two around? I have a request related to an email list [17:08:41] well it's not 100% standardized, all the vendors use prefixes on it so far afaik [17:09:38] hi marktraceur, got a question for you: when I bring up the page for UploadWizard, the browser sends a number of calls to 'load.php?debug=false&lang=en&etcetcetc'. Is there a certain time that UW will wait for such a call to complete? If so, how much time is it, and does UW retry if such a call times out? [17:09:40] marktraceur: also beware -- there seems to be some disagreement on capitalization of (prefix)RequestFull[Ss]creen :P [17:10:00] Krenair: yes? [17:10:10] Danny_B, will PM you [17:10:15] brion: Argh. [17:10:29] Uh [17:10:34] chrismcmahon: Those are ResourceLoader calls [17:11:21] marktraceur: yes, understood. I'm interested in what the client e.g. UW does when waiting for such a call to complete. [17:11:47] chrismcmahon: I'm pretty sure that for the scripts, it waits... and if it fails, you're doomed [17:12:09] brion: any chance that the client would re-try the call after some period of time? [17:12:45] * chrismcmahon looks at the source [17:13:07] i'm pretty sure it's not designed to retry [17:13:20] though that might be a handy addition :D [17:17:04] anyone in here doing intensive work with the api servers might want to pause their stuff for a bit.. as they have been falling over for a little while [17:17:14] anything that can help take the load off temporarily [17:23:52] (03CR) 10MarkTraceur: [C: 032] "Does not appear to be any worse for the wear." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93068 (owner: 10Brion VIBBER) [17:23:56] (03Merged) 10jenkins-bot: MultimediaViewer hi-DPI support [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93068 (owner: 10Brion VIBBER) [17:26:22] (03PS1) 10Ebrahim: Native digits on $revsSince [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/93079 [17:27:21] (03CR) 10MarkTraceur: [C: 032] "<3 brion" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93076 (owner: 10Brion VIBBER) [17:27:24] (03Merged) 10jenkins-bot: Fullscreen support for IE 11 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93076 (owner: 10Brion VIBBER) [17:31:23] (03PS1) 10Yaron Koren: Fixed display problem when XML attributes contain ampersands [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/93080 [17:37:58] (03CR) 10Yaron Koren: [C: 032 V: 031] Fixed display problem when XML attributes contain ampersands [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/93080 (owner: 10Yaron Koren) [17:38:21] (03CR) 10Yaron Koren: [V: 032] Fixed display problem when XML attributes contain ampersands [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/93080 (owner: 10Yaron Koren) [17:48:32] are there any wiki pages which break down the difference between global and local users? Or if not what extension i should start digging through to get a better understanding? [17:49:59] !e CentralAuth [17:49:59] https://www.mediawiki.org/wiki/Extension:CentralAuth [17:50:17] ebernhardson: ^ [17:50:44] https://meta.wikimedia.org/wiki/Help:Unified_login [17:50:55] MatmaRex: thanks [18:01:28] (03CR) 10Ori.livneh: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:02:09] (03PS9) 10Ori.livneh: redact exception traces and abstract getTrace [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:02:43] (03CR) 10jenkins-bot: [V: 04-1] redact exception traces and abstract getTrace [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:08:32] (03PS10) 10Ori.livneh: redact exception traces and abstract getTrace [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:08:43] (03PS3) 10Bartosz Dziewoński: Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 [18:10:10] (03CR) 10Bartosz Dziewoński: "Rebased, notes → 1.23." [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [18:10:43] is hashar about? [18:10:46] @seen hashar [18:10:46] MatmaRex: Last time I saw hashar they were quitting the network with reason: Quit: I am a manual virus, please copy me to your quit message. N/A at 11/1/2013 3:53:23 PM (2h17m23s ago) [18:11:24] it is not a very contagious virus [18:11:35] heh. [18:11:52] ori-l: you volunteering to help me track down some badly written PHPUnit tests in core? [18:12:19] because that patch that's about to fail testing really shouldn't be failing testing [18:13:09] it does because unrelated tests rely on the value of $wgDefaultUserOptions and change global state [18:13:14] yay, huh? [18:13:18] (03CR) 10jenkins-bot: [V: 04-1] Set 'watchcreations' and 'watchdefault' options to true [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [18:13:25] yeah. ^ [18:14:11] Hi [18:14:21] Does anyone know how to correctly build full url to api.php? [18:14:31] In JS? [18:14:34] PHP [18:14:41] MatmaRex: hmm. looking [18:14:42] wfScript( 'api' ) I think? [18:15:05] RoanKattouw: thank you!! [18:16:08] that's not full url, I guess it would have to be concatenated [18:16:32] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 (owner: 10Matthias Mullie) [18:16:33] InezK: wfExpandUrl() it? [18:17:28] MatmaRex: sweet [18:17:53] (03PS2) 10Parent5446: Added DatabaseBase::startAtomic and endAtomic [core] - 10https://gerrit.wikimedia.org/r/90856 [18:22:04] (03CR) 10Siebrand: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [18:22:54] spagewmf: Just FYI, we're making some changes in oojs-ui, renaming this.$ to this.$element and this.$$ to this.$ . This will probably confuse the crap out of you but it'll make things more intuitive for people who've never seen it before [18:23:31] MatmaRex: shouldn't testWatchClear use doApiRequestWithToken rather than insert the token by itself? [18:24:09] RoanKattouw: Thanks for the heads up. Will the change be in master on Monday? [18:24:48] ori-l: am i supposed to know? :D [18:24:52] (03PS4) 10MarkAHershberger: [PATCH] Disable $wgContentHandlerUseDB during upgrade where fields don't exist. [core] - 10https://gerrit.wikimedia.org/r/59369 [18:24:57] spagewmf: We'll try to make that happen [18:25:16] ori-l: the best part of PHPUnit tests for me is that I rarely have to write them [18:25:28] (QUnit sucks a lot less) [18:26:21] ori-l: if you make tests stop failing with that patch, Nemo_bis will be owing you a beer ;) [18:26:22] (03PS5) 10MarkAHershberger: [PATCH] Disable $wgContentHandlerUseDB during upgrade where fields don't exist. [core] - 10https://gerrit.wikimedia.org/r/59369 [18:27:47] <^d> manybubbles: So, we had a spike on the elasticsearch metrics on ganglia today. [18:27:51] <^d> Briefly. [18:27:52] <^d> http://ganglia.wikimedia.org/latest/?r=day&cs=&ce=&c=Miscellaneous+eqiad&h=testsearch1001.eqiad.wmnet&tab=m&vn=&mc=2&z=small&metric_group=ALLGROUPS [18:28:20] ^d: ignore everything about ganglia today unless you can tie it to something known real:) [18:28:34] <^d> Will do :p [18:28:56] <^d> I was watching disk space on the boxes and was like...wait, ES metric?!? [18:28:58] ^d: been fixing that script and ganglia didn't seem to like use blowing the rrds out from under it [18:29:33] yeah, I'm not sure what to do about that spike other than ignore it [18:30:05] ganglia is keeping around a bunch of metrics I'm no longer sending it too [18:30:19] well, that isn't 100% true [18:30:22] but it is still annoying [18:30:40] MatmaRex: i gotta run in a minute, but try something like this maybe? (https://dpaste.de/RhNX) [18:30:52] (03CR) 10MarkAHershberger: [C: 032] "Chad said this was ok after rebase and I fixed the problem that Umherirrender spotted." [core] - 10https://gerrit.wikimedia.org/r/59369 (owner: 10MarkAHershberger) [18:31:03] didn't have a chance to test it [18:31:22] manybubbles: there's a trick [18:31:36] I'm sure! [18:31:52] ori-l: it seems like a tricky program at times [18:31:59] understatement of the century [18:32:11] (03CR) 10Anomie: [C: 032] "Ok, let's get this merged. I'll look at adding a unit test and cleaning up the rest in a followup." [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:32:25] gmetric --spoof="hostName:hostName" -n your.metric.name -v expiring -t string -d 10 [18:32:37] replacing 'hostName' (both of them) with the actual host [18:32:40] what this does, horribly enough [18:32:55] is replace the metric with a static metric set to a fixed string value, "expiring" [18:33:12] with a dmax of 10, which causes the metric to fall out of ganglia if it doesn't receive an update for 10 seconds [18:33:26] so you run it, wait ten seconds, and it disappears [18:33:36] but don't have your gmond module updating the metric in the background! [18:33:59] your problem is caused by the fact that you have dmax set to 0 [18:34:19] which means "retain forever" [18:34:35] so any new metrics get added on top, even if the slope, etc. change [18:36:56] (03Merged) 10jenkins-bot: redact exception traces and abstract getTrace [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:37:49] (03PS1) 10Anomie: Add test for getRedactedTrace and reference args [core] - 10https://gerrit.wikimedia.org/r/93084 [18:38:14] ori-l: where do you see the dmax? [18:38:33] ori-l: I'm reaching at this through what feels like a frustrating number of layers of abstraction [18:40:53] dmax = 0 is implicit for gmond modules [18:41:08] ganglia regularly inspires feelings of rage [18:41:27] manybubbles: if you read the docs you'll find such pearls as: [18:41:36] http://sourceforge.net/apps/trac/ganglia/wiki/ganglia_gmond_python_modules [18:41:52] time_max: maximum time in seconds between metric collection calls The exact nature of this element is unclear, as is its relationship to the 'collect_every' configuration directive in your pyconf for the module. For all intents and purposes, this element seems... useless. [18:42:00] ^ that's a quote from the docs. nice, no? [18:42:04] ori-l: I saw that this morning [18:42:13] I'm not really sure what I think about that site [18:42:22] I mean, honest [18:42:28] it certainly is honest [18:42:28] (03PS1) 10Aaron Schulz: filebackend: path normalization fixes [core] - 10https://gerrit.wikimedia.org/r/93086 [18:43:39] (03CR) 10Siebrand: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [18:43:45] (03CR) 10jenkins-bot: [V: 04-1] filebackend: path normalization fixes [core] - 10https://gerrit.wikimedia.org/r/93086 (owner: 10Aaron Schulz) [18:44:05] manybubbles: ganglia does have the following thing going for it though, and it is that once you devise a metric module that works it'll work basically forever [18:44:31] anyways, graphite is about to become a lot better, paravoid and i have been working on that [18:44:38] so that'll be more viable soon too [18:45:10] ok, i really did have to go, don't know why i'm rambling. bbl. [18:48:21] (03PS1) 10Anomie: MWException: Cleanup exception message output [core] - 10https://gerrit.wikimedia.org/r/93087 [18:49:00] (03CR) 10Legoktm: "Yeah, we really should do that. I was just going for the simplest solution to fix them. I'll try and improve them later on." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [18:49:30] (03Abandoned) 10MarkTraceur: Truncate a few fields with autoEllipsis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 (owner: 10MarkTraceur) [18:49:51] (03CR) 10Anomie: "See also followup commits Iaaba3ef2 and I8a9b4831." [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:50:45] (03PS2) 10Aaron Schulz: filebackend: path normalization fixes [core] - 10https://gerrit.wikimedia.org/r/93086 [18:51:00] (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [18:53:33] (03PS1) 10Manybubbles: Make test more resilient to things taking longer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93088 [18:54:57] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [18:55:04] (03PS2) 10Manybubbles: Use a job to handle link updates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92643 [18:55:04] ^d: just in case you were doing other (productive) things, memory creeping up again on arsenic [18:55:15] <^d> Yep, I'm watching. [18:55:16] just happened to notice, prolly not going to look again tonight (dinner) [18:55:25] <^d> I'm watching those processes closely. [18:55:37] <^d> Enjoy your dinner and evening :) [18:55:41] ok, if you're on it, ... I'm off :-D (still on irc but only for the purposes of being unproductive) [18:55:43] thanks! [18:56:57] (03PS1) 10Ebrahim: Making agora-field-styling direction neutral [core] - 10https://gerrit.wikimedia.org/r/93089 [18:57:36] (03CR) 10Hashar: "THANK YOU BRAD!!!! :-]" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [18:59:16] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [18:59:45] (03CR) 10Hashar: "My reason for the fast +2 was to unbreak the tests as fast as possible. :D" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [19:05:13] PHP Warning: CirrusSearch couldn't get parser output for User:S Page (WMF)/My setup. Returning null text which should be skipped. [Called f CirrusSearchTextFormatter::formatWikitext in /usr/local/apache/common-local/php-1.23wmf1/extensions/CirrusSearch/includes/CirrusSearchTextFormatter.php at line 34] in /usr/local/apache/common-local/php-1.23wmf1/includes/debug/Debug.php on line 296 [19:05:22] (03CR) 10Aaron Schulz: "Is $this->mTrxAutomaticAtomic even needed?" [core] - 10https://gerrit.wikimedia.org/r/90856 (owner: 10Parent5446) [19:05:33] There's a few of Search backend highlighted a redirect (Mobile QA/Mobile Uploads & Commons Test Plan) but didn't return it etc [19:06:38] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [19:07:44] (03PS1) 10MarkTraceur: Make description scrollable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93092 [19:07:52] tgr: ^^ mind merging that bad boy? [19:09:44] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [19:11:12] marktraceur: sorry, brain fart on my part, that probably should be overflow: auto [19:11:25] overflow-y: auto i mean [19:11:40] otherwise the scrollbar looks weird with short descriptions [19:12:02] marktraceur: hmmmmmmm [19:12:21] marktraceur: does BetaFeatures unconditionally add that "Beta" link to personal menu for all users? [19:12:37] marktraceur: i was expecting it to be added only for people who enabled at least one non-standard feature [19:12:51] (the way google's labs features work) [19:20:02] (03PS2) 10MarkTraceur: Make description scrollable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93092 [19:20:16] Wait wat [19:20:32] * marktraceur learned something new [19:21:43] (03PS3) 10MarkTraceur: Make description scrollable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93092 [19:22:05] MatmaRex: No, we went with everyone [19:22:12] MatmaRex: We're considering toning it down though [19:23:48] tgr: PS3 should be better [19:24:16] I also added in some bits about display: none but that's just common sense, not really a functional change [19:24:44] tgr: If you wait a while the PS4 is being released [19:25:09] (03PS1) 10MarkAHershberger: Add forgotten RELEASE-NOTES line [core] - 10https://gerrit.wikimedia.org/r/93094 [19:25:22] ... [19:25:35] γροαν [19:25:39] er "groan" [19:25:44] Reedy: Remind me to hurt you [19:25:44] ( at reedy) [19:25:54] (03CR) 10MarkAHershberger: [C: 032] Add forgotten RELEASE-NOTES line [core] - 10https://gerrit.wikimedia.org/r/93094 (owner: 10MarkAHershberger) [19:26:24] marktraceur: there's already a, to put it mildly, shitload of things in the personal menu on many wikis :) [19:26:54] MatmaRex: I've heard that [19:27:08] marktraceur: i have once developed something slightly similar as a gadget, enabled it for everyone, and was quickly told to get rid of it [19:27:21] Urgh [19:27:40] (it was an additional preferences page, for managing preferences of other gadgets) [19:27:43] MatmaRex: I'm interested to see what happens, but I hoped that four characters would be small enough that it wouldn't be an issue [19:27:55] marktraceur: it won't be four characters in translations [19:28:07] MatmaRex: I think we agreed that was an upstream bug in Polish [19:28:14] heh [19:28:29] marktraceur: so yeah, "beta features" is very difficult to translate well, and the translations are likely not to include the word "beta" [19:28:38] Fine with me [19:28:52] anomie: Brad, I'm catching up on commit mail. Was your comment on https://gerrit.wikimedia.org/r/#/c/91425/ about https://gerrit.wikimedia.org/r/#/c/91765/ resolved, or is there still an issue? [19:29:53] (03Merged) 10jenkins-bot: Add forgotten RELEASE-NOTES line [core] - 10https://gerrit.wikimedia.org/r/93094 (owner: 10MarkAHershberger) [19:29:57] anomie: If something like that happens, please ping Raymond_. He'll do what he can to fix it. [19:32:15] siebrand: I believe he cleaned it up manually, although 91425 was merged before the next L10n-bot run so it probably turned out to be irrelevant. I don't know if the underlying problem was fixed or not. [19:33:10] anomie: The underlying problem in this case was human error, but usually these issues are a result of unfortunate timing -- hardly avoidable (i.e. out of sync). [19:33:37] anomie: Usually it only happens with English message, because those are usually the only ones changed in patches. [19:34:43] (03CR) 10Chad: "I'd much rather see us get rid of DeferredUpdates." [core] - 10https://gerrit.wikimedia.org/r/93021 (owner: 10Tim Starling) [19:35:35] (03PS2) 10Umherirrender: API: Return changed values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [19:37:53] (03CR) 10Umherirrender: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [19:38:38] (03CR) 10jenkins-bot: [V: 04-1] API: Return changed values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [19:40:27] (03CR) 10Chad: [C: 032] Make test more resilient to things taking longer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93088 (owner: 10Manybubbles) [19:40:31] (03Merged) 10jenkins-bot: Make test more resilient to things taking longer. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/93088 (owner: 10Manybubbles) [19:44:06] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [19:45:32] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [19:49:42] (03CR) 10Greg Grossmeier: [C: 031] Update Wikibase, fix for property input field [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92985 (owner: 10Aude) [19:51:19] (03PS1) 10Hashar: fix path for puppet_pep8.py wrapper [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93096 [19:51:26] (03CR) 10Gergő Tisza: [C: 032] Make description scrollable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93092 (owner: 10MarkTraceur) [19:51:30] (03Merged) 10jenkins-bot: Make description scrollable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/93092 (owner: 10MarkTraceur) [19:51:33] (03CR) 10Hashar: [C: 032] fix path for puppet_pep8.py wrapper [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93096 (owner: 10Hashar) [19:52:02] (03Merged) 10jenkins-bot: fix path for puppet_pep8.py wrapper [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/93096 (owner: 10Hashar) [19:54:04] (03CR) 10Siebrand: "Wikipedia uses it as a proper noun: https://en.wikipedia.org/wiki/Lightbox_%28JavaScript%29" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92040 (owner: 10Shirayuki) [19:55:00] (03CR) 10Bartosz Dziewoński: "-1. I'd say Wikipedia is wrong here." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92040 (owner: 10Shirayuki) [19:55:43] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, fix for property input field [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92985 (owner: 10Aude) [19:56:28] The Great lightbox Wars of 2013 [19:57:46] Like all great wars, in retrospect it looked like it was started over something trivial. But then it grew, and became an event in and of itself... [20:34:15] chrismcmahon, can you see your profile at https://google-melange.appspot.com/gci/profile/google/gci2013 ? [20:35:50] chrismcmahon, see http://en.flossmanuals.net/gci-melange/mentors/before-the-program/ [20:36:08] thanks qgil|away [20:37:47] qgil: I only ever did OPW before. apparently someone has to invite me to GCI [20:38:22] chrismcmahon, you have to register to Melange. I need an userid [20:40:22] qgil: I'm reading "Melange intentionally does not support self-nominated Mentors for Google Code-in. Mentors must be named by the Organization Administrator of a Mentoring Organization." at http://en.flossmanuals.net/gci-melange/mentors/before-the-program/ [20:40:50] chrismcmahon, sure, but you should be able to register to Melange and give a username. Without a username I can't do anything. [20:41:57] qgil: nope, all I get is "This page is inaccessible because you do not have a profile in the program at this time." from https://google-melange.appspot.com/gci/profile/google/gci2013 with no way to do any other actions [20:42:14] chrismcmahon, ok interesting. mmm... [20:49:40] (03CR) 10Bsitu: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/81157 (owner: 10Kaldari) [20:51:32] (03PS1) 10Reedy: Update MultimediaViewer to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93102 [20:51:39] marktraceur: ^ [20:51:56] Thanks [20:52:21] I scripted (very simply) that process because I end up having to do it so often [20:52:29] (03CR) 10MarkTraceur: [C: 032] Update MultimediaViewer to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93102 (owner: 10Reedy) [20:52:33] Yeah [20:52:54] I did actually have it approve and submitting itself at one point too... [20:53:04] Hah [20:53:43] the scripts are going self-approving... [20:53:56] saves me having to open it in a browser [20:54:27] Does it not merge? [20:54:45] Bloody hell [20:54:52] (03CR) 10MarkTraceur: [V: 032] Update MultimediaViewer to master [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93102 (owner: 10Reedy) [20:54:55] I was going to say [20:55:00] I usually V 2 it too [20:55:08] We don't care a great deal about unit tests [20:55:49] Heh. [20:56:12] (03CR) 10EBernhardson: "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [21:13:08] (03PS1) 10Mormegil: Unify name of Czech language with CLDR [core] - 10https://gerrit.wikimedia.org/r/93105 [21:15:44] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [21:17:31] Reedy: ebernhardson AaronSchulz regarding rc_source, do you think we should make use of rc_source optional (contigent on the field existing)? [21:17:34] per https://www.mediawiki.org/wiki/Development_policy#Database_patches [21:17:48] (03PS1) 10Chad: Kill $wgArticle [core] - 10https://gerrit.wikimedia.org/r/93106 [21:17:51] or revert the change again, until we are sure the schema change is applied everywhere? [21:18:52] apparently the new column is only on "a quarter of wikis" [21:19:53] * aude thinks revert [21:20:04] marktraceur: you should also update https://www.mediawiki.org/wiki/Extension:CommonsMetadata at some point in the future [21:21:08] bawolff, tgr, it's your baby jointly, maybe you can be amazing and help out with docs [21:26:22] (03CR) 10Siebrand: [C: 032] Unify name of Czech language with CLDR [core] - 10https://gerrit.wikimedia.org/r/93105 (owner: 10Mormegil) [21:29:28] (03Merged) 10jenkins-bot: Unify name of Czech language with CLDR [core] - 10https://gerrit.wikimedia.org/r/93105 (owner: 10Mormegil) [21:35:55] (03PS1) 10Aude: Revert "Revert "Revert "Add new recentchanges field rc_source to replace rc_type""" [core] - 10https://gerrit.wikimedia.org/r/93110 [21:37:17] (03CR) 10Aude: "per development policy [1], I am open to instead making usage of the column optional/contingent on the field existing. Not totally convinc" [core] - 10https://gerrit.wikimedia.org/r/93110 (owner: 10Aude) [21:38:07] Krinkle|detached: ecmabot-wm has been on quite a wild ride today [21:41:39] (03PS1) 10Bartosz Dziewoński: ext.echo.overlay: Only build the 'mark all as read' button if it's used [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93112 [21:41:41] (03PS1) 10Bartosz Dziewoński: ext.echo.overlay: Various minor consistency fixes and cleanup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93113 [21:41:43] (03PS1) 10Bartosz Dziewoński: ext.echo.overlay: Unbreak removal logic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93114 [21:41:45] (03PS1) 10Bartosz Dziewoński: ext.echo.overlay: Show a spinner while waiting for data [WIP] [extensions/Echo] - 10https://gerrit.wikimedia.org/r/93115 [21:42:15] so many overlay patches [21:42:23] benny is going to hate me [21:49:55] (03CR) 10EBernhardson: [C: 031] Revert "Revert "Revert "Add new recentchanges field rc_source to replace rc_type""" [core] - 10https://gerrit.wikimedia.org/r/93110 (owner: 10Aude) [21:50:13] Revert "Revert "Revert " [21:50:24] now that's what I call a revert... [21:50:36] wut [21:50:36] aude: hey [21:50:44] aude: why don't you just do that for wmf branch? [21:50:47] not master [21:50:52] it's okay in master [21:51:04] and hopefully we can uncrap that before next wmf branch [21:51:27] hell, it's already in the release candidate [21:51:51] (where it causes very funny behavior if you forget to run update.php, btw, unrelated shit blowing up) [21:52:07] Reedy: ^ [21:52:08] ebernhardson: ^ [21:52:30] i don't know if it is actually in the release [21:52:35] i do. it is. [21:52:37] yes it's in the release notes i see [21:52:39] oh [21:52:57] (03CR) 10Bartosz Dziewoński: [C: 04-1] "[22:50] aude: why don't you just do that for wmf branch?" [core] - 10https://gerrit.wikimedia.org/r/93110 (owner: 10Aude) [21:53:24] MatmaRex: well, that gives us a week to get the schema changes applied fully, everywhere [21:53:32] definitely possible [21:54:15] aude: even better, it gives us a week to decide if we should revert this on master [21:54:21] aude: you'll have to revert on wmf branch anyway [21:54:27] hmmmm, ok [21:54:56] (03PS1) 10Aude: Revert "Revert "Revert "Add new recentchanges field rc_source to replace rc_type""" [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/93117 [21:55:17] hurray for cherry pick button [21:55:40] i'll leave the master patch open in case we want it [21:56:43] (03CR) 10Bartosz Dziewoński: [C: 04-2] "-2 to prevent someone from accidentally merging (overrule if needed). This needs to be done on wmf branch first anyway, we've got a week t" [core] - 10https://gerrit.wikimedia.org/r/93110 (owner: 10Aude) [21:56:53] (03CR) 10MarkAHershberger: [C: 032] "Yes!" [core] - 10https://gerrit.wikimedia.org/r/93008 (owner: 10Jeroen De Dauw) [21:56:58] (03CR) 10Siebrand: "Chris, can you explain why this must be a core feature and not an extension?" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [21:57:49] marktraceur: agh, tell you what. your sexy checkboxes don't work on Opera [21:58:03] and fuck me if i know why. getting mysterious exceptions [21:58:09] (Opera 12, naturally) [21:58:29] Mysterious exceptions!? Those are my favourites. [21:58:34] MatmaRex: File bugs against BF? [21:59:58] marktraceur: that actually looks like an Opera bug to me :( [22:00:06] Ah. [22:00:07] 'kay [22:06:37] (03PS1) 10MarkAHershberger: Make it possible to install extensions using Composer [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93120 [22:11:29] (03PS1) 10CSteipp: Improve user-facing error messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 [22:12:02] (03CR) 10jenkins-bot: [V: 04-1] Improve user-facing error messages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [22:19:37] (03CR) 10Siebrand: [C: 04-1] "(5 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/93121 (owner: 10CSteipp) [22:23:50] (03PS3) 10MaxSem: DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 [22:24:26] (03CR) 10jenkins-bot: [V: 04-1] DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [22:25:20] YuviPanda, marktraceur: done [22:26:08] tgr: Thanks :) [22:26:22] Also, congrats on getting a working product onto a prod wiki [22:26:32] You too bawolff, thanks a lot [22:26:54] * bawolff didn't have much to do with it, it was all you guys [22:27:03] congrats on the deploy [22:35:58] (03CR) 10Aude: [C: 031] DifferenceEngine minor fixes [core] - 10https://gerrit.wikimedia.org/r/92598 (owner: 10MaxSem) [22:43:19] (03PS4) 10MaxSem: DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 [22:43:20] (03PS2) 10MaxSem: DifferenceEngine minor fixes [core] - 10https://gerrit.wikimedia.org/r/92598 [22:46:28] aude, now rebased^^:P [22:47:31] ok [22:50:23] ok marktraceur, explain yourself [22:50:31] marktraceur: why are the hidden checkboxes display:none? [22:51:00] * marktraceur blinks [22:51:14] MatmaRex: I'm gonna let this play out before I answer [22:51:18] instead of position:asbolute;top:-9999ox or something [22:51:25] px* [22:51:35] Why...would that need to be...that's not necessary [22:51:49] i'm pretty sure display:none is uncool for a11y reasons [22:51:55] I don't want to reposition the checkbox, I want to hide it [22:52:18] It still gets affected by the label [22:52:26] (03CR) 10Aude: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [22:52:37] MaxSem: sorry :( [22:52:44] easy to fix, though [22:52:54] MatmaRex: I'd merge that patch if it worked though [22:52:57] marktraceur: also, that makes opera stop falling over itself [22:53:01] Heh [22:53:11] owchie:P [22:53:12] MatmaRex: Opera will _never_ stop falling over itself :) [22:53:19] marktraceur: apparently it doesn't expect changing the state of a checkbox that should not be accessible for clicking [22:53:26] yeah :( [22:53:27] which is a pretty reasonable assumption to make, isn't it? [22:54:17] okay, let's write a patch [22:54:23] oh, that reminds me [22:54:30] aude, one (and only) thing I miss about SourceSafe is its lack of edit conflicts... it just locks stuff for everyone else1 [22:54:31] !! [22:54:32] [22:54:39] marktraceur: BetaFeatures wasn't in the mediawiki/extensions repository last time i checked. [22:54:48] (it didn't have a submodule) [22:54:52] Oh? [22:55:14] i checked on wednesday, i think [22:55:17] Well [22:55:22] MaxSem: heh [22:55:28] Wait [22:55:29] @seen ^d [22:55:29] MatmaRex: Last time I saw ^d they were quitting the network with reason: Quit: i'm too cool for irc N/A at 11/1/2013 10:27:56 PM (27m32s ago) [22:55:33] hrmph. [22:55:44] MatmaRex: What process is used to add a submodule? [22:55:58] marktraceur: i'm afraid a manual one :P [22:56:16] git submodule add , apparnetly [22:56:29] MatmaRex: In mediawiki/extensions? [22:56:33] That's easy enough [22:56:35] http://man.cx/git-submodule [22:56:48] I'd also watch you do that and merge it [22:56:52] marktraceur: yeah, so it would seem [22:56:53] haha [22:57:01] * marktraceur is full of helpful tips today [22:57:10] i should have ^d do it [22:57:40] but let's see if it's gonna work [22:57:55] (03CR) 10Nemo bis: "Ori, rumors say that you may look into the test failures; if you don't have time to, let us know. :)" [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [22:58:06] (03PS5) 10MaxSem: DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 [23:00:15] whyyyy is git so slow on repos which are a gigabyte big [23:00:37] i'm waiting a minute for a git checkout -b to finish D: [23:01:24] git receive-pack? [23:01:35] git git or gerrit? [23:01:57] git checkout -b [23:02:02] on a repo with hundreds of submodules [23:02:06] takes two minutes to run [23:02:32] submodules are evil I thin [23:03:29] i wonder how long git status will take [23:03:57] git status is local [23:05:30] it is [23:05:36] that doesn't mean it's instant [23:05:44] (i really need a ssd.) [23:05:55] hmm whaaat. [23:06:01] why do i have changes in dozens of submodules [23:06:14] "(new commits)" in each [23:06:20] i guess i checked something out in them, eh [23:13:52] (03CR) 10BryanDavis: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [23:15:22] (03PS1) 10Bartosz Dziewoński: Add BetaFeatures and MultimediaViewer [extensions] - 10https://gerrit.wikimedia.org/r/93132 [23:15:31] woot [23:15:33] marktraceur: ^ [23:15:58] agh what, merge conflict? [23:16:19] (03CR) 10Jeroen De Dauw: [C: 031] Make it possible to install extensions using Composer [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93120 (owner: 10MarkAHershberger) [23:24:53] (03CR) 10Hashar: "Probably worth an entry at the top of the release-notes :-D" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/93120 (owner: 10MarkAHershberger) [23:29:37] (03CR) 10Hashar: [C: 032] "Great :-)" [core] - 10https://gerrit.wikimedia.org/r/93087 (owner: 10Anomie) [23:32:30] (03Merged) 10jenkins-bot: MWException: Cleanup exception message output [core] - 10https://gerrit.wikimedia.org/r/93087 (owner: 10Anomie) [23:35:38] (03CR) 10Aude: [C: 031] DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [23:36:14] (03PS2) 10Hashar: Add test for getRedactedTrace and reference args [core] - 10https://gerrit.wikimedia.org/r/93084 (owner: 10Anomie) [23:36:29] (03CR) 10Hashar: [C: 032] Add test for getRedactedTrace and reference args [core] - 10https://gerrit.wikimedia.org/r/93084 (owner: 10Anomie) [23:37:22] (03CR) 10Ori.livneh: "I didn't look into this in detail, but it seemed like the way the test was acquiring a token and adding it to requests was broken, and cou" [core] - 10https://gerrit.wikimedia.org/r/89604 (owner: 10Bartosz Dziewoński) [23:37:40] greg-g: The Deployments calendar on Wikitech now says that we're doing LDs on Fridays, but not on Thursdays - is this right? [23:38:54] <^d> We could a LD every time lightening strikes somewhere? [23:39:02] <^d> "Quick, a lightening strike. Find something to deploy!" [23:39:45] but... but... read only fridays... [23:40:12] p858snake|l: Hence my confusion. :-) [23:40:41] <^d> James_F: I would imagine that's a typo somehow, I don't think that's changing. [23:41:05] (03Merged) 10jenkins-bot: Add test for getRedactedTrace and reference args [core] - 10https://gerrit.wikimedia.org/r/93084 (owner: 10Anomie) [23:41:13] ^d: Right. But I'm loathe to revert the Platform Release Manager™ on what the calendar says. :-) [23:41:35] <^d> wikitech doesn't have 3RR ;-) [23:41:58] but it does have the block function >.> [23:42:13] <^d> None of us are +sysop :p [23:42:52] a small setback, but i'm sure you can work around that [23:43:42] marktraceur: omg noooo [23:43:47] marktraceur: why is BetaFeatures using scss [23:44:09] worse [23:44:14] scss that's not commited to the repo [23:44:45] MatmaRex: I tore it out of mediawiki.ui [23:44:49] and even worse, you've got 'gray' spelled wrong all over [23:44:52] I edit the CSS directly, fuck scss [23:44:57] lol [23:45:14] MatmaRex: We'll convert to LESS and tear out the line number comments in a bit [23:45:20] <^d> I don't use css ;-) [23:45:56] ^d was using html based styling before it was cool? [23:48:40] (03PS1) 10Bartosz Dziewoński: Keep pretty checkboxes accessible [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93136 [23:48:44] <^d> p858snake|l: No, I just never moved from html to css because I'm lazy and make shit user interfaces anyway :p [23:48:48] marktraceur: DING DING DING [23:48:50] ^ [23:48:53] <^d> So no bother wasting time making it all pretty with css :p [23:49:00] <^d> Someone will come behind me and make it non-barfy [23:49:12] Heh [23:49:13] should clearly be JS only [23:49:59] $( '#selector' ).totallyNotCss( 'text-align', 'center' ); [23:50:00] CSS-less design is the best design [23:50:58] <^d> Table-based design degrades nicely on ancient browsers like NN4 ;-) [23:52:12] MatmaRex: Do you mean to say "0px" there? [23:52:21] nope [23:52:23] And if so, wouldn't "0" work? [23:52:26] Whyyy [23:52:27] almost [23:52:32] apparently some Ie6 or something [23:52:38] Sigh. [23:52:44] marktraceur: the values don't mean what you think they mean [23:52:49] What? [23:52:52] They're positions. [23:52:56] ^d: and supports jidanni! [23:53:06] marktraceur: (there is no 1px square left or anything) [23:53:11] No, I know [23:53:25] (that syntax is bizarre, eh) [23:53:26] But it's silly to take the 1,1th 0 pixels instead of the 0,0th one [23:53:37] But if IE is a fucking moron we'll just let it be [23:53:49] #ohwait I should have expected that [23:54:50] Ugh this is terrible [23:57:05] (03CR) 10MarkTraceur: [C: 032] "MatmaRex is a wonderful, wonderful person." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93136 (owner: 10Bartosz Dziewoński) [23:57:14] (03Merged) 10jenkins-bot: Keep pretty checkboxes accessible [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/93136 (owner: 10Bartosz Dziewoński) [23:58:41] Thanks Bartosz [23:59:30] thanks mark