[00:06:03] mwalker: hey, 1 day's notice! [00:06:21] mwalker: add to calendar, I'll review when I get home/am not tethering [00:06:25] kk! [00:12:32] ebernhardson: whenever I see MVP I think "Most Valuable Player" [00:13:54] AaronSchulz: lol, typical :P [00:21:05] (03CR) 10Hoo man: "Yes, both Graham and I tested this with actual screen readers. If I recall it right, it's still not perfect due to https://bugzilla.wikime" [core] - 10https://gerrit.wikimedia.org/r/88033 (owner: 10Hoo man) [00:21:07] MatmaRex: ^ [00:25:50] (03CR) 10Bartosz Dziewoński: [C: 032] "OK." [core] - 10https://gerrit.wikimedia.org/r/88033 (owner: 10Hoo man) [00:29:46] (03Merged) 10jenkins-bot: Accessibility: Make the collapsible sidebar screen reader friendly [core] - 10https://gerrit.wikimedia.org/r/88033 (owner: 10Hoo man) [00:30:28] MatmaRex: Thanks :) \o/ [00:34:29] hoo: about time that was merged, eh. [00:39:47] (03PS8) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [00:39:49] (03CR) 10jenkins-bot: [V: 04-1] Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [00:41:57] (03CR) 10EBernhardson: "looks good to me, just one spot where can reuse an existing value" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [00:42:29] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [00:48:57] (03PS1) 10Chad: Rewrite SearchUpdate as a Job instead of a DeferredUpdate [core] - 10https://gerrit.wikimedia.org/r/92825 [00:49:22] <^d> AaronSchulz: ^ :) [00:50:45] (03CR) 10jenkins-bot: [V: 04-1] Rewrite SearchUpdate as a Job instead of a DeferredUpdate [core] - 10https://gerrit.wikimedia.org/r/92825 (owner: 10Chad) [00:51:45] (03PS2) 10Chad: Rewrite SearchUpdate as a Job instead of a DeferredUpdate [core] - 10https://gerrit.wikimedia.org/r/92825 [00:53:31] (03CR) 10jenkins-bot: [V: 04-1] Rewrite SearchUpdate as a Job instead of a DeferredUpdate [core] - 10https://gerrit.wikimedia.org/r/92825 (owner: 10Chad) [00:56:19] (03PS9) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [00:56:21] (03CR) 10jenkins-bot: [V: 04-1] Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [01:24:00] (03PS4) 10Krinkle: Add lines option to jq.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [01:37:40] (03PS1) 10Kaldari: Changing usage instructions for ContentHandler::getContentText() [core] - 10https://gerrit.wikimedia.org/r/92827 [01:50:53] (03CR) 10Aude: "probably worth mentioning in release notes" [core] - 10https://gerrit.wikimedia.org/r/92825 (owner: 10Chad) [01:51:44] (03CR) 10Krinkle: "Release notes" [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [02:38:10] (03PS19) 10EBernhardson: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [02:38:59] (03CR) 10EBernhardson: [C: 032] "Rebased conflict in Templating.php" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [02:39:11] (03Merged) 10jenkins-bot: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [02:39:44] (03PS4) 10Legoktm: [WIP] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [03:09:42] YuviPanda, bd808|BUFFER : Flow has a labs instance running role::mediawiki-install::labs , can it run role::labs::vagrant *as well* to give us two MediaWiki installs on it? I assume they'll conflict at mysql or apache2 or somewhere [03:11:45] spagewmf: The vagrant role will clobber the apache config if nothing else [03:12:03] (03CR) 10Chad: "Only two extensions affected :p" [core] - 10https://gerrit.wikimedia.org/r/92825 (owner: 10Chad) [03:13:06] bd808 yeah, figured as much and that's what legoktm said. We want one instance to serve a second MediaWiki at a different URL running different patches. [03:13:55] spagewmf: That should be possible with manual setup. [03:14:37] But I don't think any of the roles I've seen will manage multiple installs [03:16:05] thx [03:17:32] * bd808 makes a note to look into making such a thing possible [03:19:13] there's a bug somewhere for a wikifarm role [03:19:23] would be nice if that farm could support mutliple versions ;) [03:19:28] multiple* [03:39:36] (03PS5) 10Legoktm: [WIP] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [03:55:21] (03PS10) 10EBernhardson: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [03:56:38] (03CR) 10EBernhardson: [C: 032] "rebased, fixed bug with no 'View History' link when no underlying title exists" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [03:56:48] (03Merged) 10jenkins-bot: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [03:58:34] (03PS4) 10EBernhardson: Replying to reply sends notification to the wrong target [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92678 (owner: 10Bsitu) [04:22:29] (03CR) 10Werdna: "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [04:22:43] (03CR) 10Werdna: [C: 04-1] Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [04:41:39] (03CR) 10Mattflaschen: [C: 032] "Code looks solid, tests locally fine. In fact, I'm already using it for bug 55550." [core] - 10https://gerrit.wikimedia.org/r/89608 (owner: 10Ori.livneh) [04:44:35] (03Merged) 10jenkins-bot: Add method for inspecting module dependency relations [core] - 10https://gerrit.wikimedia.org/r/89608 (owner: 10Ori.livneh) [05:02:09] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92825 (owner: 10Chad) [05:12:18] (03CR) 10Mgrover: [C: 032 V: 032] Changed from str to message [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [05:12:26] (03Merged) 10jenkins-bot: Changed from str to message [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [05:17:02] (03PS2) 10Werdna: Show flow events in watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [05:17:04] (03CR) 10jenkins-bot: [V: 04-1] Show flow events in watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [05:19:42] (03PS3) 10Werdna: Show flow events in watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [05:20:04] (03CR) 10Werdna: [C: 031] "PS2: Changed RC_FLOW in Hooks.php to Flow\Data\RecentChanges::SRC_FLOW." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [05:42:43] (03CR) 10Zfilipin: "Repositories are not using this code until they update the version of mediawiki-selenium gem in Gemfile.lock, so this commit could not cau" [selenium] - 10https://gerrit.wikimedia.org/r/92650 (owner: 10Zfilipin) [05:44:47] (03PS6) 10Legoktm: [WIP] Allow for global renaming of users [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/92468 [05:56:55] (03PS2) 10Mattflaschen: Implement support for post-edit with VisualEditor. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/92670 [06:21:27] (03CR) 10Mattflaschen: "I appeased Jenkins by removing the hookName parameter (though jshint is not 100% consistent about when it tolerates unused parameters). I" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/92670 (owner: 10Mattflaschen) [06:36:45] spagewmf: they'll conflict badly, yeah [06:37:59] thx YuviPanda [06:38:14] spagewmf: you can create a new instance... :) [06:38:24] spagewmf: also shouldn't you be sleeping? [06:39:46] YuviPanda: maybe, but we want to try two wikis sharing one Flow db [06:40:01] spagewmf: hmm, right. you can always point the other instance to this db [06:40:17] spagewmf: so 1. create new instance, 2. use vagrant there, 3. point that to the other one's db [06:41:39] maybe, I want to try labs-vagrant [06:42:26] spagewmf: yeah, labs-vagrant is what I meant [07:07:05] (03CR) 10PleaseStand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [07:34:46] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [07:47:51] (03CR) 10Mattflaschen: [C: 04-1] "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [07:53:16] (03CR) 10Mattflaschen: [C: 032] "Good catch. The less untracked clutter, the better." [core] - 10https://gerrit.wikimedia.org/r/76118 (owner: 10MarkTraceur) [07:56:18] (03Merged) 10jenkins-bot: Add .sass-cache to .gitignore [core] - 10https://gerrit.wikimedia.org/r/76118 (owner: 10MarkTraceur) [07:57:10] (03CR) 10Mattflaschen: "I'm not sure. Maybe '1.22' should mean the first official release of 1.22?" [core] - 10https://gerrit.wikimedia.org/r/92368 (owner: 10BryanDavis) [09:07:15] (03PS1) 10Matthias Mullie: Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 [09:07:32] (03CR) 10Mattflaschen: [C: 032] "Looks good, works locally." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88476 (owner: 10Alex Monk) [09:07:48] (03Merged) 10jenkins-bot: Fix a few remaining things in mw.LanguageUpWiz.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88476 (owner: 10Alex Monk) [09:13:06] (03CR) 10Helder.wiki: "FYI: This fixes bug 56201." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92788 (owner: 10Krinkle) [10:14:31] (03PS3) 10Pastakhov: add support for user functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91589 [10:18:15] (03PS1) 10Umherirrender: More 1.22 -> 1.23 [core] - 10https://gerrit.wikimedia.org/r/92851 [10:18:44] (03CR) 10Aude: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [10:23:52] (03PS1) 10Aude: use getOldid and getNewid methods in DifferenceEngineTest [core] - 10https://gerrit.wikimedia.org/r/92852 [10:27:00] (03PS4) 10Pastakhov: add support for user functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91589 [10:27:56] (03PS5) 10IAlex: Put get diff body cache key into own function [core] - 10https://gerrit.wikimedia.org/r/92167 (owner: 10Aude) [10:28:02] (03CR) 10IAlex: [C: 032] Put get diff body cache key into own function [core] - 10https://gerrit.wikimedia.org/r/92167 (owner: 10Aude) [10:32:39] (03Merged) 10jenkins-bot: Put get diff body cache key into own function [core] - 10https://gerrit.wikimedia.org/r/92167 (owner: 10Aude) [10:33:49] (03CR) 10Pastakhov: [C: 032] add support for user functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91589 (owner: 10Pastakhov) [10:33:57] (03Merged) 10jenkins-bot: add support for user functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91589 (owner: 10Pastakhov) [10:38:02] (03CR) 10Bartosz Dziewoński: [C: 032] More 1.22 -> 1.23 [core] - 10https://gerrit.wikimedia.org/r/92851 (owner: 10Umherirrender) [10:41:02] (03Merged) 10jenkins-bot: More 1.22 -> 1.23 [core] - 10https://gerrit.wikimedia.org/r/92851 (owner: 10Umherirrender) [10:41:14] (03PS2) 10IAlex: Avoid strip markes on transcluded Special:RecentChanges[Linked] [core] - 10https://gerrit.wikimedia.org/r/91889 (owner: 10Umherirrender) [10:41:20] (03CR) 10IAlex: [C: 032] Avoid strip markes on transcluded Special:RecentChanges[Linked] [core] - 10https://gerrit.wikimedia.org/r/91889 (owner: 10Umherirrender) [10:41:58] (03CR) 10Bartosz Dziewoński: [C: 032] use getOldid and getNewid methods in DifferenceEngineTest [core] - 10https://gerrit.wikimedia.org/r/92852 (owner: 10Aude) [10:47:00] (03Merged) 10jenkins-bot: Avoid strip markes on transcluded Special:RecentChanges[Linked] [core] - 10https://gerrit.wikimedia.org/r/91889 (owner: 10Umherirrender) [10:48:36] (03Merged) 10jenkins-bot: use getOldid and getNewid methods in DifferenceEngineTest [core] - 10https://gerrit.wikimedia.org/r/92852 (owner: 10Aude) [11:06:48] (03CR) 10Zfilipin: "Please revert this revert since the problem was in something else:" [selenium] - 10https://gerrit.wikimedia.org/r/92764 (owner: 10Cmcmahon) [11:07:05] (03PS1) 10leucosticte: Bug: 56404 Add RefCallback hook [extensions/Cite] - 10https://gerrit.wikimedia.org/r/92857 [11:26:40] (03PS1) 10IAlex: Use HTTPS for the link in FAQ [core] - 10https://gerrit.wikimedia.org/r/92862 [11:27:15] (03CR) 10jenkins-bot: [V: 04-1] Use HTTPS for the link in FAQ [core] - 10https://gerrit.wikimedia.org/r/92862 (owner: 10IAlex) [11:41:20] (03CR) 10Addshore: "If we are going to do this we should probably include a few more from http://phpunit.de/manual/3.7/en/appendixes.annotations.html" [core] - 10https://gerrit.wikimedia.org/r/92782 (owner: 10Hashar) [11:42:16] (03CR) 10Hashar: "Not sure ever, so we might want to write them all in a php test file and play with it until we are happy with the rendered documentation." [core] - 10https://gerrit.wikimedia.org/r/92782 (owner: 10Hashar) [11:43:12] (03CR) 10leucosticte: [C: 04-1] "Actually I messed up in my testing; this still doesn't do what I was wanting it to do." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/92857 (owner: 10leucosticte) [13:20:02] (03CR) 10MarkTraceur: [C: 031] "Looks good but I'd like to talk to Matt about how to test it before +2." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/92670 (owner: 10Mattflaschen) [13:20:06] superm401: ^^ [13:20:28] Gonna shower and commute now [13:54:04] (03Abandoned) 10leucosticte: Bug: 56404 Add RefCallback hook [extensions/Cite] - 10https://gerrit.wikimedia.org/r/92857 (owner: 10leucosticte) [13:54:22] (03CR) 10Anomie: [C: 032] "Looks sane. Let's do it." [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [13:56:58] (03CR) 10Manybubbles: [C: 031] "I agree with Parent5446 but once those are resolved it looks good to me." [core] - 10https://gerrit.wikimedia.org/r/92825 (owner: 10Chad) [13:58:32] (03Merged) 10jenkins-bot: exception: Use MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [13:58:48] (03CR) 10Anomie: [C: 031] "Code seems good. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [14:01:23] (03PS2) 10IAlex: Use HTTPS for the link in FAQ [core] - 10https://gerrit.wikimedia.org/r/92862 [14:02:57] (03CR) 10Bartosz Dziewoński: [C: 032] "Related: https://bugzilla.wikimedia.org/show_bug.cgi?id=54835" [core] - 10https://gerrit.wikimedia.org/r/92862 (owner: 10IAlex) [14:06:59] (03Merged) 10jenkins-bot: Use HTTPS for the link in FAQ [core] - 10https://gerrit.wikimedia.org/r/92862 (owner: 10IAlex) [14:12:29] (03PS5) 10Gergő Tisza: jquery.autoEllipsis: Add lines option [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [14:16:20] superm401: So how should I try testing the GuidedTour patch? [14:19:08] (03PS14) 10Addshore: Add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [14:21:47] Ah, never mind, he was up at 02:00 [14:21:54] * marktraceur looks it up [14:22:33] (03PS1) 10Zfilipin: WIP Move UploadWizard tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92875 [14:23:30] :D [14:23:41] * marktraceur huge fan [14:23:54] (03CR) 10Aude: "seems fine and is a big improvement, although I have some concerns that the abstract DiffFormatter class may have a bit much code specific" [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [14:24:59] (03Abandoned) 10Bartosz Dziewoński: vector: Restore @body-font-color to black [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92351 (owner: 10Bartosz Dziewoński) [14:25:30] !roadmap [14:25:30] For long-term engineering goals roadmap, see . For short-term WMF deployments roadmap, see . [14:25:34] !roadmap del [14:25:35] Successfully removed roadmap [14:25:42] !roadmap is For long-term engineering goals roadmap, see . For short-term WMF deployments roadmap, see . [14:25:42] Key was added [14:28:35] (03PS3) 10Umherirrender: Add continue editing link also to js and css pages [core] - 10https://gerrit.wikimedia.org/r/85232 [14:30:07] (03CR) 10MarkTraceur: [C: 032] "I lied, I figured it out. :)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/92670 (owner: 10Mattflaschen) [14:31:18] (03PS2) 10Zfilipin: WIP Move UploadWizard tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92875 [14:31:50] (03Merged) 10jenkins-bot: Implement support for post-edit with VisualEditor. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/92670 (owner: 10Mattflaschen) [14:32:19] Reedy: hey there :-] Do you have any idea why we have to clear the RL cache from time to time and if we do it on new release / scap ? [14:32:42] (03CR) 10BryanDavis: "I think it's reasonable that '1.22' means 'the first official release of 1.22'. It seems like the version_compare() tarpit really only app" [core] - 10https://gerrit.wikimedia.org/r/92368 (owner: 10BryanDavis) [14:32:43] Reedy: wondering whether we should clear the RL cache on the beta cluster. Chris Mc Mahon reported some javascript errors on https://bugzilla.wikimedia.org/show_bug.cgi?id=56279#c1 [14:36:35] restart bits for it? shouldn't hurt... [14:39:35] (03PS3) 10Zfilipin: WIP Move UploadWizard tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92875 [14:40:51] Reedy: how do we clear RL cache in prod ? [14:41:05] cause I might well add some job on beta to clear it up from time to time [14:42:37] (03PS1) 10Zfilipin: WIP Moved Selenium tests from browsertests repository [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/92879 [14:43:42] (03PS4) 10Zfilipin: WIP Move UploadWizard tests to UploadWizard repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92875 [14:53:25] Krinkle|detached: tgr and I found http://dotdotdot.frebsite.nl/ and it is SO SEXY. [14:53:38] i.e. sexier than jq.autoEllipsis [14:53:48] Or rather tgr found it and I watched him. [15:04:44] (03CR) 10Gergő Tisza: [C: 04-1] "Drops links from description. Also truncated fields do not update anymore then the lightbox is closed and reopened on another image." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 (owner: 10MarkTraceur) [15:07:08] (03CR) 10MarkTraceur: [C: 04-1] "tgr and I are talking about maybe using http://dotdotdot.frebsite.nl/ instead of our internal library. Will revisit." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 (owner: 10MarkTraceur) [15:08:13] (03CR) 10Gergő Tisza: [C: 04-1] "Doesn't handle HTML in truncated text." [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [15:27:10] (03PS1) 10Zfilipin: Tests in MobileFrontend repository are now in tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/92881 [15:27:35] (03PS2) 10Zfilipin: Tests in MobileFrontend repository are now in tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/92881 [15:27:52] (03PS3) 10Zfilipin: Tests in MobileFrontend repository are now in tests/browser folder [selenium] - 10https://gerrit.wikimedia.org/r/92881 [15:37:11] I am getting the Internal sever error while installing Bugzilla. Please helpo [15:37:20] I was trying to fix a bug in it [15:37:46] but, I cant finish the installation [15:40:17] (03PS1) 10Zfilipin: Deleted pages that are moved to UniversalLanguageSelector repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92883 [15:49:16] hashar: It should be doable by touching wmf-config php things [15:49:25] and resources/Resources.php and startup.js [15:55:12] (03PS1) 10Anomie: Properly handle spaces/underscores in mw.site.namespaces [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/92886 [15:55:23] (03PS1) 10Anomie: Regularize whitespace handling in mw.title [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/92887 [16:06:26] Oh bah [16:06:36] Those 3 new extensions are going to piss scap off [16:06:59] Labs "hack" global... [16:08:04] Reedy: Anything I can help with? (wait, our extensions?) [16:08:16] Not your fault [16:08:30] Just the way the localisations caches are made [16:08:32] Ah [16:08:36] Fair enough [16:08:38] it gets pissed off if an extension is in one branch and not another [16:08:41] I've got an idea though [16:09:00] Reedy: I'm alert and ready to help out if you need anything [16:09:14] Cheers [16:13:41] (03PS1) 10Cmcmahon: Revert "This is causing "Unable to pick a platform" errors in all Jenkins builds" [selenium] - 10https://gerrit.wikimedia.org/r/92888 [16:15:41] Reedy: marktraceur even got up way early today to get to the office before 7:45 am. :) [16:16:03] I'm super serial about this you guys. :P [16:16:51] (03CR) 10Cmcmahon: [C: 032] "docs" [selenium] - 10https://gerrit.wikimedia.org/r/92881 (owner: 10Zfilipin) [16:19:33] (03CR) 10Zfilipin: [C: 032] Revert "This is causing "Unable to pick a platform" errors in all Jenkins builds" [selenium] - 10https://gerrit.wikimedia.org/r/92888 (owner: 10Cmcmahon) [16:19:43] (03PS7) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [16:19:55] (03Merged) 10jenkins-bot: Revert "This is causing "Unable to pick a platform" errors in all Jenkins builds" [selenium] - 10https://gerrit.wikimedia.org/r/92888 (owner: 10Cmcmahon) [16:24:14] (03CR) 10Cmcmahon: [C: 032] "remove unused info" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92883 (owner: 10Zfilipin) [16:32:53] I'd better move out of my car [16:37:06] wtf [16:37:14] nearly every car alarm on this ferry just went off [16:39:15] (03PS1) 10Ori.livneh: mw.inspect: add report for mw.loader.store [core] - 10https://gerrit.wikimedia.org/r/92895 [16:39:33] Reedy: deploy alarms? [16:40:12] eh? [16:40:31] and again [16:40:45] Explosions? [16:41:23] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [16:41:41] I'm still with the cars... ;) [16:43:23] googling it... seems very common [16:46:29] marktraceur: Can you amend https://gerrit.wikimedia.org/r/#/c/92793/ and remove your changes to extension-list please? [16:46:37] Should be faster than me trying to do it via laggy ssh [16:47:22] Reedy: Sure [16:48:26] Done [16:52:42] (03PS1) 10Ori.livneh: mediawiki.inspect#dumpTable: fix broken FF workaround [core] - 10https://gerrit.wikimedia.org/r/92899 [16:55:17] MatmaRex: added you to two straightforward patches to mw.inspect (https://gerrit.wikimedia.org/r/#/c/92895/ & https://gerrit.wikimedia.org/r/92899) [16:56:45] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.inspect#dumpTable: fix broken FF workaround [core] - 10https://gerrit.wikimedia.org/r/92899 (owner: 10Ori.livneh) [16:58:31] (03PS1) 10Subramanya Sastry: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/92901 [17:00:33] (03PS2) 10Ori.livneh: mediawiki.inspect#dumpTable: fix broken FF workaround [core] - 10https://gerrit.wikimedia.org/r/92899 [17:01:23] (03PS1) 10Jeroen De Dauw: Fix a PHP notice occuring in the autoloader [core] - 10https://gerrit.wikimedia.org/r/92902 [17:03:38] (03PS1) 10Matthias Mullie: Update RecentChanges to use history i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 [17:08:13] ori-l: looking [17:08:34] ori-l: hmm… shouldn't `console.table.call( console.table, data );` have been `console.table.call( console, data );`? [17:09:28] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92902 (owner: 10Jeroen De Dauw) [17:11:16] (03CR) 10PleaseStand: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92902 (owner: 10Jeroen De Dauw) [17:13:53] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92899 (owner: 10Ori.livneh) [17:15:58] (03PS4) 10Gergő Tisza: Add info links for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [17:16:43] (03PS1) 10MarkTraceur: Icon changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92908 [17:18:09] MatmaRex: hah, I am a moron [17:20:39] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92899 (owner: 10Ori.livneh) [17:20:53] (03PS3) 10Ori.livneh: mediawiki.inspect#dumpTable: fix broken FF workaround [core] - 10https://gerrit.wikimedia.org/r/92899 [17:23:59] (03CR) 10Freakolowsky: "I was the busy bunny who had no time to merge this." [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [17:25:42] (03PS4) 10Bartosz Dziewoński: mediawiki.inspect#dumpTable: fix broken FF workaround [core] - 10https://gerrit.wikimedia.org/r/92899 (owner: 10Ori.livneh) [17:25:52] fixed a space in commit message [17:26:04] ori-l: does it work like this? [17:26:32] (03CR) 10MarkTraceur: [C: 031] "tgr, do the honours? :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [17:26:36] (03PS1) 10Jeroen De Dauw: Match method signature in base class [extensions/Push] - 10https://gerrit.wikimedia.org/r/92911 [17:27:00] (03CR) 10MarkTraceur: [C: 032] "302 /marktraceur" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [17:27:09] (03Merged) 10jenkins-bot: Add info links for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [17:32:26] (03CR) 10Jeroen De Dauw: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92902 (owner: 10Jeroen De Dauw) [17:33:22] (03CR) 10Gergő Tisza: [C: 032] "Works as expected." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92908 (owner: 10MarkTraceur) [17:33:26] (03Merged) 10jenkins-bot: Icon changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92908 (owner: 10MarkTraceur) [17:33:29] Huzzah [17:33:37] marktraceur, you can copy http://toro.wmflabs.org/wiki/MediaWiki:Guidedtour-tour-firsteditvesandbox.js to your local wiki, then go to any article with ?tour=firsteditvesandbox added on. [17:34:24] superm401: I figured it out :) [17:34:48] You'll notice the patch is merged [17:35:31] superm401: I was able to test with ?tour=firsteditve without copying anything [17:38:02] marktraceur, sorry, didn't check my email yet. [17:38:19] However, firsteditve doesn't have a post-edit. [17:38:25] Got to go for a meeting. [17:38:36] spagewmf: We have docs for ooui on line now BTW: https://doc.wikimedia.org/VisualEditor/master/#!/api/OO.ui.BarToolGroup [17:41:46] reedy has lost internet access if that matter [17:45:14] superm401: Ah. Well. [17:45:19] It seemed to fire the events. [17:46:23] Yeah, it would still listen to the events, it just wouldn't display a post-edit step unless you added one. [17:48:28] That's fine, I just made sure the events were going [17:48:35] It seemed to only be a hook patch [17:50:56] (03PS1) 10Cmcmahon: hopefully make UW a bit more reliable [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92914 [17:51:20] (03PS2) 10Cmcmahon: hopefully make UW a bit more reliable [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92914 [17:51:36] (03PS1) 10Catrope: Update VisualEditor to tip of wmf2 branch for cherry-pick [core] (wmf/1.23wmf2) - 10https://gerrit.wikimedia.org/r/92915 [17:51:42] (03CR) 10Cmcmahon: [C: 032] "refactor, no-op, robustification" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92914 (owner: 10Cmcmahon) [17:51:54] Reedy: Any chance I can sneak in https://gerrit.wikimedia.org/r/92915 before wmf2 goes live? [17:52:39] RoanKattouw: Reedy is offline right now [17:52:46] :( [17:52:57] or so says hashar, see #-tech [17:59:37] (03CR) 10Matthias Mullie: [C: 04-1] "Not sure if I've got everything covered in here; did not get a good chance to test it yet." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 (owner: 10Matthias Mullie) [18:01:51] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92902 (owner: 10Jeroen De Dauw) [18:02:56] (03Abandoned) 10Jeroen De Dauw: Fix a PHP notice occuring in the autoloader [core] - 10https://gerrit.wikimedia.org/r/92902 (owner: 10Jeroen De Dauw) [18:07:49] (03CR) 10Matthias Mullie: "Note to self: RC_FLOW thingy is changing." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 (owner: 10Matthias Mullie) [18:12:07] * YuviPanda waves at hashar [18:12:28] (03PS2) 10Matthias Mullie: Update RecentChanges to use history i18n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92903 [18:12:31] hashar: do you have time to help setup unit tests and checkstyle for the app projects or should I ping you later? [18:13:04] (03PS2) 10Matthias Mullie: Fold history config into FlowActions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92842 [18:14:05] hey chrismcmahonbrb [18:14:08] oh brb [18:14:08] ok [18:14:11] (03PS4) 10Bsitu: Show flow events in watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [18:14:15] hi YuviPanda [18:14:29] YuviPanda: later, outage in progress [18:14:38] hashar: okay! thanks! [18:15:04] chrismcmahonbrb: so, I've been writing unit tests for the Android app from the start, and need to set up automated tests for it somewhere [18:15:16] chrismcmahonbrb: think you have time to talk about it now or should I ping you later? [18:15:26] (03CR) 10Bsitu: "PS4: Removed a redundant constant" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [18:15:44] YuviPanda: still in Java? [18:15:55] chrismcmahonbrb: unit tests so far, so Java [18:16:27] chrismcmahonbrb: but these Unit tests need a device to run, since they are dependent on the Android runtime / system being present [18:16:52] YuviPanda: you know who's probably more expert than me in both Java and Android would be Michelle Grover [18:17:19] chrismcmahonbrb: aha! [18:17:22] chrismcmahonbrb: ok, I'll poke her [18:17:32] whoops, I'm not brb [18:17:53] chrismcmahon: so we can also run these on sauce labs or in jenkins itself, but with a VM [18:18:03] but SauceLabs is better, I guess, since it gives us a lot more coverage [18:34:14] (03CR) 10PleaseStand: "This also seems to break HHVM compatibility:" [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [18:39:50] (03CR) 10Parent5446: "@PleaseStand: That's strange, because even looking at the code now HHVM seems to support php://stdin. Maybe it's an HHVM bug?" [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [18:52:24] (03CR) 10AlephNull: "Not sure what else this needs..." [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [18:55:27] (03CR) 10Legoktm: "If the dependency is reversed, then the patches will "pass" jenkins but jenkins won't actually be testing them. We should fix all the unit" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [18:56:55] (03CR) 10Bartosz Dziewoński: "(+1 to Lego about the appropriate workflow; we could also do it in one commit, but that might be too large to review)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [18:59:54] spagewmf: this.upButton.connect( this, { 'click': ['emit', 'move', -1] } ); // this.emit( 'move', -1 ) [19:00:15] spagewmf: OO.ui.OutlineControlsWidget.js:45 [19:01:37] spagewmf: Equivalent to this.upButton.connect( this, { 'click': 'onUpButtonClick' } ); where onUpButtonClick does this.emit( 'move', -1 ); [19:08:13] Krinkle: any chance you could take a look at https://gerrit.wikimedia.org/r/92804 for me? I'm not sure how this stuff works but really keen to get qunit running on MobileFrontend.. [19:12:29] (03CR) 10Aaron Schulz: [C: 032] Add clarification to wfUseMW() phpdoc [core] - 10https://gerrit.wikimedia.org/r/92368 (owner: 10BryanDavis) [19:14:45] (03CR) 10Aaron Schulz: [C: 032] Remove call to deprecated Job::safeBatchInsert [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/92481 (owner: 10Legoktm) [19:15:05] (03Merged) 10jenkins-bot: Remove call to deprecated Job::safeBatchInsert [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/92481 (owner: 10Legoktm) [19:20:19] (03CR) 10PleaseStand: [C: 04-1] "I think there might still be some schema inconsistencies I need to track down." [core] - 10https://gerrit.wikimedia.org/r/92502 (owner: 10PleaseStand) [19:20:59] (03CR) 10Bartosz Dziewoński: "That sounds reasonable to me, thanks. I'll update the commit message and the author and merge." [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [19:21:30] (03CR) 10Aaron Schulz: [C: 032] Regularize whitespace handling in mw.title [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/92887 (owner: 10Anomie) [19:21:41] (03Merged) 10jenkins-bot: Add clarification to wfUseMW() phpdoc [core] - 10https://gerrit.wikimedia.org/r/92368 (owner: 10BryanDavis) [19:23:22] (03CR) 10Dan-nl: "(3 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [19:23:33] (03Merged) 10jenkins-bot: Regularize whitespace handling in mw.title [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/92887 (owner: 10Anomie) [19:23:43] (03PS10) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [19:26:32] (03PS2) 10Bartosz Dziewoński: Fix of oracle installation sql [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [19:26:42] (03PS3) 10Gergő Tisza: Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [19:29:01] (03CR) 10Gergő Tisza: "Commit message is now unfeeling to Mark's pain." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [19:34:09] (03CR) 10Aaron Schulz: [C: 032] Properly handle spaces/underscores in mw.site.namespaces [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/92886 (owner: 10Anomie) [19:36:05] (03Merged) 10jenkins-bot: Properly handle spaces/underscores in mw.site.namespaces [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/92886 (owner: 10Anomie) [19:36:15] (03PS3) 10Bartosz Dziewoński: Fix Oracle installation SQL [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [19:37:36] (03CR) 10Gergő Tisza: [C: 04-1] "Eh, don't mind me. Firefox apparently opens links from pinned tabs in new windows. Track on leave issue still needs to be handled." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [19:38:23] (03CR) 10Bartosz Dziewoński: [C: 032] "Banzai!" [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [19:41:49] (03Merged) 10jenkins-bot: Fix Oracle installation SQL [core] - 10https://gerrit.wikimedia.org/r/80538 (owner: 10Petrb) [19:45:28] (03PS5) 10Bartosz Dziewoński: Vector: Set media=screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [19:46:17] (03CR) 10Bartosz Dziewoński: "This should fail now thanks to the new test added in https://gerrit.wikimedia.org/r/#/c/92762/" [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [19:50:01] (03CR) 10Bartosz Dziewoński: [C: 032] Treat action=submit as 'alreadyediting' [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/91034 (owner: 10Mattflaschen) [19:50:09] (03Merged) 10jenkins-bot: Treat action=submit as 'alreadyediting' [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/91034 (owner: 10Mattflaschen) [19:53:02] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92643 (owner: 10Manybubbles) [19:57:39] (03CR) 10GWicke: [C: 032] Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/92901 (owner: 10Subramanya Sastry) [19:59:58] (03PS4) 10Gergő Tisza: Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [20:01:44] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests. [core] - 10https://gerrit.wikimedia.org/r/92901 (owner: 10Subramanya Sastry) [20:07:13] (03CR) 10Gergő Tisza: "Added delay and created bug 56426 as a reminder to test it." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 (owner: 10MarkTraceur) [20:12:33] (03PS1) 10Darkdadaah: Progress stats on a single line for articles_list.pl [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/92927 [20:13:48] (03PS1) 10Umherirrender: API: Return changed values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 [20:14:05] (03CR) 10Darkdadaah: [C: 032 V: 032] Progress stats on a single line for articles_list.pl [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/92927 (owner: 10Darkdadaah) [20:15:39] (03CR) 10Darkdadaah: [C: 032 V: 032] Add option to find a pattern in the pages [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/71044 (owner: 10Darkdadaah) [20:17:16] (03CR) 10jenkins-bot: [V: 04-1] API: Return changed values for action=options [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [20:32:09] (03CR) 10Bartosz Dziewoński: "Huh." [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [20:36:45] (03CR) 10Aaron Schulz: "Guess this needs @since 1.23" [core] - 10https://gerrit.wikimedia.org/r/90856 (owner: 10Parent5446) [20:37:29] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [20:37:59] (03CR) 10Anomie: "Also, of course, you'll need to fix the unit tests." [core] - 10https://gerrit.wikimedia.org/r/92928 (owner: 10Umherirrender) [20:59:03] MatmaRex: https://gerrit.wikimedia.org/r/#/c/92899/4 ? [21:05:18] ori-l: uh, yes. i assume you tested that? [21:05:34] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.inspect#dumpTable: fix broken FF workaround [core] - 10https://gerrit.wikimedia.org/r/92899 (owner: 10Ori.livneh) [21:05:49] ori-l: sorry, forgot about it :) are we backporting it to release? [21:07:41] MatmaRex: i was going to if we can keep the cluster up long enough [21:08:28] i mean release, not wmf [21:08:34] was the whole thing backported earlier? [21:08:48] ah, let's just see if it can be cherry-picked [21:08:52] (03PS1) 10Bartosz Dziewoński: mediawiki.inspect#dumpTable: fix broken FF workaround [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92979 [21:09:02] ok, it can. so it needs a backport. [21:09:21] (03Merged) 10jenkins-bot: mediawiki.inspect#dumpTable: fix broken FF workaround [core] - 10https://gerrit.wikimedia.org/r/92899 (owner: 10Ori.livneh) [21:09:22] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport of a trivial fix for a silly issue." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92979 (owner: 10Bartosz Dziewoński) [21:09:32] MatmaRex: <3 thanks [21:10:46] MatmaRex: there's https://gerrit.wikimedia.org/r/#/c/92895/ too if you're feeling inspect-y. but now i'm just being greedy :P [21:11:30] some other time :) i don't really know how the store things works, you know ;) [21:11:58] ori-l: butttttt, *you* could do https://gerrit.wikimedia.org/r/#/c/92181/ or https://gerrit.wikimedia.org/r/#/c/91667/ [21:12:11] * ori-l looks [21:14:01] (03PS1) 10Darkdadaah: Added support for language sections detections for de: and ru: - Limited to main languages [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/92984 [21:14:07] MatmaRex: i'll do #2, not touching the first one with a ten foot pole [21:14:26] ori-l: heh [21:14:40] don't like echo? [21:15:02] my computer is configured to shut down if any two of the words 'monobook', 'helvetica' and 'orange' appear on the screen at one time [21:15:29] heh [21:15:41] okay [21:15:57] yay, looks like I'm a confirmed participant for the architecture summit then [21:16:16] (03PS1) 10Aude: Update Wikibase, fix for property input field [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92985 [21:16:30] (03Merged) 10jenkins-bot: mediawiki.inspect#dumpTable: fix broken FF workaround [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92979 (owner: 10Bartosz Dziewoński) [21:19:10] (03CR) 10Darkdadaah: [C: 032 V: 032] Added support for language sections detections for de: and ru: - Limited to main languages [wiktionary/anagrimes] - 10https://gerrit.wikimedia.org/r/92984 (owner: 10Darkdadaah) [21:25:07] Krenair: great :-] [21:25:54] aude: need a deploy ? [21:28:39] (03CR) 10Ori.livneh: [C: 032] SkinTemplate: Move debug HTML above bottomscripts [core] - 10https://gerrit.wikimedia.org/r/91667 (owner: 10Bartosz Dziewoński) [21:29:38] (03CR) 10Bartosz Dziewoński: "(Removing myself from reviewer list, as I'm really not qualified for that here. ;) E-mail me if you need me.)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [21:29:53] thanks ori-l [21:33:42] (03Merged) 10jenkins-bot: SkinTemplate: Move debug HTML above bottomscripts [core] - 10https://gerrit.wikimedia.org/r/91667 (owner: 10Bartosz Dziewoński) [21:34:19] (03PS1) 10Bartosz Dziewoński: SkinTemplate: Move debug HTML above bottomscripts [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92990 [21:34:36] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92990 (owner: 10Bartosz Dziewoński) [21:35:37] MatmaRex: ah, cool. was going to do the backport but you beat me to it [21:35:59] ori-l: i hate waiting. :) [21:38:28] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [21:40:14] (03PS11) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [21:41:01] (03Merged) 10jenkins-bot: SkinTemplate: Move debug HTML above bottomscripts [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92990 (owner: 10Bartosz Dziewoński) [21:41:06] (03CR) 10Physikerwelt: "" RELEASE-NOTES updated"" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [21:45:14] (03CR) 10Bsitu: [C: 032] Show flow events in watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [21:45:30] (03Merged) 10jenkins-bot: Show flow events in watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [21:52:54] (03CR) 10Brion VIBBER: "(2 comments)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 (owner: 10Kaldari) [21:53:01] jdlrobson: ^ [21:53:21] Thanks brion appreciated :) [21:53:39] looks like it should work but i'll try and test it :D [21:53:42] you're wonderfully helpful as always :D [21:56:33] (03PS1) 10Hashar: more extensions registered [extensions] - 10https://gerrit.wikimedia.org/r/92992 [21:57:03] jdlrobson: we should give brion a new role : "Chief Happiness Officer" [21:57:11] hashar: :D [21:57:18] ohhhh hashar you know jenkins right? [21:57:23] you and him are good friends? [21:57:23] :DD [21:57:43] Master Jenkins. [21:57:57] Head of Windows Phone [21:58:00] hashar: would you mind looking at https://gerrit.wikimedia.org/r/92804 - jenkin's and I speak different languages so I'm unable to communicate with him [21:58:03] brion: you would have no one reporting to you, but would move along from a desk to another providing nice tips to make people happier in their job / hack .. [21:58:07] jdlrobson: yeah I am Mr Jenkins [21:58:17] aww [21:58:23] (03PS2) 10Hashar: more extensions registered [extensions] - 10https://gerrit.wikimedia.org/r/92992 [21:58:46] it will be like Uber delivering kittens [21:58:53] jdlrobson: niiiiceee [21:58:57] we need to get a brion happiness t-shirt [21:59:36] (03PS5) 10Kaldari: Only allow throttling if object caching is enabled... [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 [21:59:45] jdlrobson: oh you had to escape the curly braces . was it causing some issues ? [22:00:02] hashar: the curly braces? [22:00:05] jdlrobson: I was just looking at https://en.wikipedia.org/wiki/File:Brion_Vibber_Day.jpg [22:00:14] jdlrobson: https://gerrit.wikimedia.org/r/#/c/92804/1/macro.yaml,unified line 137 [22:00:23] I'm not sure if there were shirts. Plenty of balloons, though. [22:00:28] hashar: i didn't write the patch - i don't understand yaml either [22:00:46] jdlrobson: oh that is jan. Even nicer. [22:01:18] this is very brion me thinks: http://www.etsy.com/listing/84332957/cat-japanese-2-byte-cute-emoticon-t?ref=sr_gallery_7&ga_search_query=emoticon+t+shirt&ga_view_type=gallery&ga_ship_to=US&ga_search_type=all&ga_facet=emoticon+t+shirt [22:01:25] (03CR) 10Brion VIBBER: "Ok seems to do what it says on the tin! If I have CACHE_NONE set, the throttle options are hidden on filter create/update." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 (owner: 10Kaldari) [22:01:41] oh i need that shirt [22:01:55] and if you want to go in the wikitech direction ;-) http://img1.etsystatic.com/000/0/6378568/il_340x270.286333891.jpg [22:01:58] (03CR) 10Mattflaschen: [C: 032] "Thanks! The code looks good, and I tested both aspects (page name and LangSwitch/user language) locally." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/89499 (owner: 10Rillke) [22:02:13] hehe [22:02:48] (03Merged) 10jenkins-bot: Parse pages and text in context of user language [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/89499 (owner: 10Rillke) [22:03:32] (03PS1) 10MaxSem: Add a custom terms of use message and a hook to set it up [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/92993 [22:04:31] (03PS1) 10MarkTraceur: Fix bug in spinner code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92995 [22:04:53] >.< who will review iths [22:04:54] this [22:08:52] superm401: Mind looking at 92995 there? Fixes MultimediaViewer in prod environments [22:09:07] marktraceur, sure, after our standup. [22:09:11] Grazie [22:10:06] Maybe we can bloody fix beta... [22:10:49] jdlrobson: it is too late for me to review the change, will look / deploy it tomorrow [22:12:00] marktraceur: what's wrong with beta? [22:12:09] chrismcmahon: Lightbox won't load [22:12:19] Not entire beta, just the bit I care about. :P [22:13:17] hashar: thanks mate - appreciated :) [22:13:30] completely understand.. i remember oh too well working in a european time zone :) [22:13:41] jdlrobson: well [22:13:52] jdlrobson: that patch output is so nice that I am going to deploy it right now [22:14:00] marktraceur: actually, UploadWizard on beta has been doing some strange things I'd like to run down with you, but I'm not sure I'm in a position to ask a reasonable question yet. [22:14:11] chrismcmahon: Also I'm not in a position to help much [22:14:19] Release attempt took it all out of me [22:14:39] 'mong other things [22:15:59] marktraceur: next week maybe. I'm starting to think me and Zeljko and the QA folks on the mail list might be in a good position to help with with multimedia schtuff of various kinds [22:16:19] Good point [22:16:50] chrismcmahon: For now, putting Beta Labs on https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment would be awesome [22:16:54] Avoid pain in the future [22:16:57] marktraceur: it boils down to: multimedia is hard to do without a lot of human eyeballs looking at stuff. [22:17:15] Yeah [22:17:30] chrismcmahon: You'd need, at least, a load of really specialized stuff [22:17:43] (03PS1) 10Hashar: mwext-MobileFrontend-qunit-mobile (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92997 [22:17:52] jdlrobson: unleashing it :-] [22:18:01] oooh [22:18:06] UNLEASH THE POWERRRRR [22:18:10] :D :D [22:18:25] (03PS1) 10Gergő Tisza: Fullscreen fix [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92999 [22:18:31] marktraceur: I have opinions but eh, next week is soon enough [22:18:38] Whoa, tgr, you're still up? [22:18:57] (03CR) 10Hashar: [C: 032] mwext-MobileFrontend-qunit-mobile (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92997 (owner: 10Hashar) [22:19:05] (03CR) 10MarkTraceur: [C: 032] "Ah, thanks." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92999 (owner: 10Gergő Tisza) [22:19:09] (03Merged) 10jenkins-bot: mwext-MobileFrontend-qunit-mobile (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92997 (owner: 10Hashar) [22:19:20] (03Merged) 10jenkins-bot: Fullscreen fix [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92999 (owner: 10Gergő Tisza) [22:19:38] hashar: how can i trigger it [22:19:41] i want to see the POWEEERRRR [22:19:47] i love how good Jenkins is getting these days [22:20:19] jdlrobson: can you send a test change ? [22:20:28] marktraceur: sure, it's not even midnight yet [22:20:32] Heh. [22:20:42] jdlrobson: yeah more and more people are involved in jenkins / testing, that is nice. [22:20:55] hashar: anything with JS right? [22:20:58] tgr: Want to look at 92995 then? superm401 said he'd be game but I'd be OK with getting it in faster. :D [22:21:01] marktraceur, looking at the spinner one now. [22:21:03] jdlrobson: i don't think it matters. [22:21:05] Ah, never mind. :P [22:21:09] hashar: can i trigger a recheck? [22:21:13] Is it actually broken in prod, or you just know it will break in prod? [22:21:21] Not sure how much I should be rushing. [22:21:22] superm401: Tested in beta [22:21:26] jdlrobson: na a new patchset (aka new change or a rebase) [22:21:26] Not deployed yet [22:21:29] hashar: rebased https://gerrit.wikimedia.org/r/#/c/92583/ [22:21:34] assume that will trigger it? [22:21:41] it did :-] [22:21:51] jdlrobson: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/1/ [22:21:56] #1 !!!!!!!!!!!!!!!!!!!!!!!!! [22:22:32] the query path is wrong :-] [22:22:59] marktraceur, what is: [22:23:02] $this.closest( '.thumb' ).find( '.image img' ).prop( 'sr [22:23:04] c' ) [22:23:07] ? [22:23:27] superm401: Finding the source of the image that's inside the thumbnail div [22:23:32] oohh hashar jenkins explodeddd [22:23:47] na exploding is MUCH more nasty [22:23:58] :) [22:24:01] marktraceur, what is that expected to be? [22:24:11] I see it was the spinner on the left (before change). [22:24:13] superm401: Tricky 'cause there are two links that can trigger it, each of which have images inside them - it'll be the already-loaded thumbnail image [22:24:29] So no cost over the network but puts in something non-null [22:25:29] I could also rewrite it to optionally not try to load the image right away, or pull the spinner into the library or something, but I haven't gotten that to work yet anyway [22:25:50] hashar: so the url is incorrectly written? [22:26:05] yeah fixing it [22:26:28] marktraceur, are the two the actual image, and that little "click here to expand" icon? [22:26:34] Yeah [22:26:52] Okay, I think I get it, and the code looks okay, just a tiny bit tricky (but there a comment). [22:26:54] Testing now. [22:26:59] So you'll always get the image's thumbnail in the lightbox, but hidden, and the spinner loads separately now [22:27:23] Wait, what's the point in putting it there if you're just going to hide it the whole time, then put the full-size one later? [22:27:33] I get why to put the spinner, but not the thumb. [22:27:43] hashar: much <3 you're competing with brion now for my affection ;-) [22:30:55] superm401: Not setting it causes the lightbox library to try to load /wiki/Undefined [22:31:11] Setting it to the existing image at least doesn't raise the error and doesn't cost anything [22:31:27] Oh, I saw that /Undefined thing. [22:31:43] superm401: I guess the alternative would be to "load" the spinner, get the background-image URL, and stick that in the src attribute [22:31:46] But that sounds trrbl [22:31:50] jdlrobson: I have spent 10 minutes tracking an issue that was caused by code duplication :-] [22:31:58] Or fix the lightbox so it doesn't do /Undefined junk. [22:32:20] But this is okay for now, as long as it doesn't trigger an unnecessary load, which it shouldn't since the thumb is already loaded. [22:32:27] superm401: Yup yup [22:32:27] jdlrobson: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/2/console that one is my final call. [22:32:37] marktraceur, can you add a comment about it, though. [22:32:44] I'm trying to get InstantCommons to cooperate again [22:32:46] Sure [22:32:52] Ironically, I think enabling UploadWizard broke it. [22:33:49] Done [22:33:50] (03PS2) 10MarkTraceur: Fix bug in spinner code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92995 [22:33:56] superm401: Would not surprise me [22:34:18] (03CR) 10Hashar: "(3 comments)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92804 (owner: 10JanZerebecki) [22:34:21] https://bugzilla.wikimedia.org/show_bug.cgi?id=54202 [22:34:34] (03PS2) 10Hashar: Add mwext-MobileFrontend-qunit-mobile with useformat=mobile. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92804 (owner: 10JanZerebecki) [22:38:09] (03CR) 10Hashar: [C: 032] "Well done Jan, I am impressed. You ended up having to interact with all the tricky part of JJB (macro, curly braces escaping, passing para" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92804 (owner: 10JanZerebecki) [22:38:37] (03Merged) 10jenkins-bot: Add mwext-MobileFrontend-qunit-mobile with useformat=mobile. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92804 (owner: 10JanZerebecki) [22:38:53] jdlrobson: Jan did an awesome job there. [22:39:40] jdlrobson: there is something wrong going on, I am not sure what though. No test are being found :/ [22:40:00] (03CR) 10Mattflaschen: [C: 032] "Looks good. Comment/TODO addresses my code clarity concerns." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92995 (owner: 10MarkTraceur) [22:40:02] jdlrobson: you have the $wgDebugLogFile for both cli commands and apache on the build page https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/2/ [22:40:10] (03Merged) 10jenkins-bot: Fix bug in spinner code [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92995 (owner: 10MarkTraceur) [22:41:55] (03CR) 10Legoktm: "I've narrowed it down to all being related to using bad (well, not good) User objects, so it should be fine to do in one patchset." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [22:41:59] Right, awaiting deploy to beta. :) [22:42:33] marktraceur: you can ping the qa-l to attact folks on your new features [22:42:38] I am off to bed [22:43:00] jdlrobson: you can follow up with timo for the qunit tests. I am off to bed [22:44:07] hashar: Will do :) [22:44:33] hashar: Sleep well mate [22:45:08] yeah i need [22:52:12] Uhhh... [22:52:20] BetaLabs updated the JS but not the CSS [22:52:27] Predictably, that ain't goin' too well [22:54:05] Krinkle|detached: guessing you are asleep? [22:54:41] He works on honolulu hours, presumably. [22:54:55] Though this week may not be as good [22:56:43] greg-g: Possible to grab a LD slot for VE? Need to back-port something to wmf2 that missed the cut… [22:57:38] (03PS1) 10EBernhardson: Design changes via meeting with may [extensions/Flow] - 10https://gerrit.wikimedia.org/r/93002 [22:58:27] James_F: wmf2 is currently not deployed anywhere. [22:59:28] James_F: the deployment was a mess, i didn't exactly follow what happened [22:59:46] MatmaRex: Argh. [22:59:59] * aude wants to backport something to wikibase :) [23:00:05] to wmf2 [23:00:05] James_F: something related to betefeatures broke [23:00:19] MatmaRex: Hmm. [23:00:42] need to sort out what went wrong and make sure it's right first [23:00:55] marktraceur, jdlrobson: Krinkle|detached is on European hours for the next ~7 days because of conferences in AMS [23:01:04] Ahh [23:03:00] errr, to wmf1 :) [23:03:54] (03PS6) 10Jdlrobson: Vector: Set media=screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/92658 [23:04:39] RoanKattouw, AaronSchulz: are you aware of some session locking in MW that would prevent two concurrent requests using the same session? [23:04:48] re https://gerrit.wikimedia.org/r/#/c/91111/ [23:05:57] (03CR) 10Jdlrobson: "Mm.. something not quite working in mobile. Now both qunit and qunit-mobile tests are failing for unknown reasons :(" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92804 (owner: 10JanZerebecki) [23:06:36] RoanKattouw: is qunit failing for you? [23:06:41] with latest master [23:12:32] (03CR) 10Aaron Schulz: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/90856 (owner: 10Parent5446) [23:14:29] (03CR) 10Bartosz Dziewoński: "This should not work (nor pass tests) according to what Krinkle said earlier. I think." [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [23:14:48] greg-g: you here? [23:15:41] jdlrobson: He's commuting, what's up? [23:15:55] marktraceur: something suddenly broke on enwiki [23:15:58] i assume deployment train related [23:16:10] jdlrobson: There *is* no deployment train, what happened? [23:16:18] ^demon, Reedy, ^^ [23:16:19] marktraceur: it worked earlier today but now isn't [23:16:27] we're getting a JavaScript error [23:16:30] no JS is running [23:16:56] Ahhhhh [23:16:59] Holy eff [23:17:10] all wiki sites but not wiktionary or mediawiki [23:17:38] i'm very confused [23:17:52] jdlrobson: I see the error in an articlefeedback module, same for you? [23:18:07] * werdna waves [23:18:10] marktraceur: i can't work out where it is occurring. [23:18:24] Hm [23:19:15] so we didn't have any deployments today?! [23:19:21] Hm, no, looks like jquery.cookie isn't loading [23:19:27] (03Abandoned) 10Alex Monk: Remove the default revert summary from revert email notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/61722 (owner: 10Alex Monk) [23:19:31] I can't see any errors [23:19:32] Or...it is, but too late? [23:20:01] (03Abandoned) 10Alex Monk: (bug 26390) Add a note to the top of the discussion page history view pointing to the header history [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/49817 (owner: 10Alex Monk) [23:20:19] Exception thrown by mobile.stable.common: Cannot read property 'defaults' of undefined [23:20:27] jdlrobson: wikipedias got switched to 1.23wmf1 [23:20:27] jdlrobson: What page? [23:20:33] https://en.m.wikipedia.org/wiki/Main_Page [23:20:38] aude: Are you sure? [23:20:41] debug=true is fine [23:20:46] so i think some assets need touching [23:20:57] yes, unless it got reverted [23:21:00] we've had similar caching problems in the past when we rename files [23:21:08] http://en.wikipedia.org/wiki/Special:Version [23:21:14] yes, it's on 1.23wmf1 [23:21:19] jdlrobson: I'm seeing errors with debug=true on starting VE [23:21:22] everything is [23:21:24] (cc James_F) [23:21:36] Fuuun [23:21:42] (03Abandoned) 10Alex Monk: Kill Phalanx::getExpireValues [extensions/Phalanx] - 10https://gerrit.wikimedia.org/r/23225 (owner: 10Alex Monk) [23:21:48] marktraceur: Hmm. [23:23:33] James_F: marktraceur aude you are see issues elsewhere other than mobile? [23:23:35] (03CR) 10Alex Monk: [C: 04-1] "need to deal with hoo's comments from july" [core] - 10https://gerrit.wikimedia.org/r/36330 (owner: 10Alex Monk) [23:23:47] jdlrobson: "I'm seeing errors on starting VE" [23:23:56] It was the first thing I could think of that was JS on enwiki [23:23:58] so something weird could be going on..? [23:25:03] marktraceur: What page/browser? https://en.wikipedia.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit works just fine for me in debug true and false. [23:25:41] (03Abandoned) 10Alex Monk: Revert "Delete the editWarning feature" [extensions/Vector] (REL1_21) - 10https://gerrit.wikimedia.org/r/67254 (owner: 10Alex Monk) [23:25:45] no issues here [23:26:31] touch everything [23:26:37] (03Abandoned) 10Alex Monk: Redact second parameter of SpecialChangePassword::attemptReset by default in stack traces [core] - 10https://gerrit.wikimedia.org/r/85437 (owner: 10Alex Monk) [23:26:43] James_F: https://en.wikipedia.org/wiki/Orrefors?debug=true [23:27:10] OK, no more errors. [23:27:24] (03PS5) 10Alex Monk: (bug 32782) Log use of DisableAccount [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/32577 [23:27:25] marktraceur: Works fine for me - caching error? [23:27:34] Maybe so [23:27:39] Reedy: still seeing it on mobile consistently :( [23:27:40] I still can't edit [23:27:43] marktraceur: Text me/Roan if you find anything bad - I'm running off. [23:27:54] 'kayp [23:27:57] mobile seems to be loading old JS [23:28:02] (03PS6) 10Alex Monk: (bug 44900) Allow wildcard searching in wiki IDs for interwiki user rights logs [core] - 10https://gerrit.wikimedia.org/r/48661 [23:28:05] Probably caching issues [23:28:18] Eff this, I'm going home, if it's still a problem when I come back online I'll address it then. [23:28:36] marktraceur: is anyone in the office that can help me? [23:28:53] the whole mobile site is broken because of this [23:29:17] let me do the obvious and non invasive [23:29:29] thanks Reedy [23:29:40] we've had similar problems in the past which have been resolved by file touching [23:29:58] indeed. worth trying at least [23:30:23] jdlrobson: I'd suggest bothering ori-l if it's an emergency and Reedy cannot fix, but that's a hail mary suggestion [23:30:29] I'll be back online in 30 minutes [23:30:34] ok :( [23:30:38] thanks Reedy [23:33:09] (03PS7) 10Alex Monk: Allow wildcard searching in wiki IDs for interwiki user rights logs [core] - 10https://gerrit.wikimedia.org/r/48661 [23:34:32] (03PS2) 10Legoktm: Unbreak some unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 [23:34:44] Any mailman admins around? [23:35:47] Reedy: what ever you did seems to have worked.. [23:36:03] (03CR) 10jenkins-bot: [V: 04-1] Unbreak some unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [23:36:09] blegh [23:37:20] * jdlrobson hugs Reedy [23:39:41] Wheee [23:48:09] (03PS1) 10Jeroen De Dauw: Make it possible to install extensions using Composer [core] - 10https://gerrit.wikimedia.org/r/93008 [23:49:18] mmmmm! [23:51:11] <^d> I don't think there's two r's in composer. [23:52:02] heh [23:53:27] -2 it! [23:53:52] <^d> Then I'd be stuck getting followup e-mails for it :p [23:57:13] jdlrobson: no, not asleep. Was out having dinner with Ed. [23:57:24] We're both in NL for a few days during the Wikimedia Nederland conference. [23:57:24] Krinkle: ooh you're in London? [23:57:27] ooh nice [23:57:51] Krinkle: i need to go now but I mailed out to mobile-l about the problem - qunit tests are exploding for some reason since we introduced the ability to run mobile qunit tests [23:57:55] jdlrobson: Anything I can help with, or is it obsolete? [23:58:02] k [23:58:31] sometimes mobile tests are successful, sometimes they fail due to no tests running but more worringly core tests fail all of a sudden for timeout issues and core QUnit tests are voting :( [23:58:46] jdlrobson: link? [23:58:51] example: https://gerrit.wikimedia.org/r/#/c/91535/ [23:59:27] I've got to run sadly - let me know on mail if there is anything I can do - I can be online later to respond!