[00:06:24] (03PS1) 10Krinkle: Update documentation [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92600 [00:06:34] (03CR) 10Krinkle: [C: 032] Update documentation [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92600 (owner: 10Krinkle) [00:07:03] (03Merged) 10jenkins-bot: Update documentation [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92600 (owner: 10Krinkle) [00:09:17] (03CR) 10Krinkle: "Pending whether we can reproduce this and it being a genuine case, it may be better to instead document this method as requiring a link th" [core] - 10https://gerrit.wikimedia.org/r/92596 (owner: 10Catrope) [00:17:55] (03PS8) 10Ori.livneh: redact exception traces and abstract getTrace [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [00:23:01] (03PS1) 10MarkTraceur: Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 [00:23:08] Krinkle: ^^ [00:23:15] That looks way better, thanks. [00:24:25] (03PS6) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [00:28:34] (03PS2) 10Krinkle: [WIP] exception: Use new MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 [00:28:48] (03CR) 10Krinkle: "Rebased to resolve JobQueueFederated.php merge conflict." [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [00:33:12] (03PS3) 10Krinkle: exception: Use MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 [00:44:44] (03PS7) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [00:45:07] TimStarling: Do you recall why DatabaseError's have getLogMessage returning false? https://github.com/wikimedia/mediawiki-core/commit/bcb9f9e1c0d (7 years ago) [00:45:44] Why would db errors not be logged? [00:46:44] because they are logged in their own channel (dberror.log), logging them as an exception as well would be redundant [00:49:15] TimStarling: OK [00:50:54] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [01:04:26] (03CR) 10PleaseStand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [01:19:07] (03CR) 10PleaseStand: "Filed as bug 56360." [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [01:48:18] (03PS1) 10PleaseStand: wfShellExec: Work around PHP 5.3 stream_select() issue [core] - 10https://gerrit.wikimedia.org/r/92607 [01:49:49] (03PS2) 10PleaseStand: wfShellExec: Work around PHP 5.3 stream_select() issue [core] - 10https://gerrit.wikimedia.org/r/92607 [01:54:21] (03PS4) 10Krinkle: [WIP] exception: Use MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 [01:55:38] (03PS3) 10PleaseStand: wfShellExec: Work around PHP 5.3 stream_select() issue [core] - 10https://gerrit.wikimedia.org/r/92607 [01:56:24] (03CR) 10PleaseStand: "Added the PHP bug number." [core] - 10https://gerrit.wikimedia.org/r/92607 (owner: 10PleaseStand) [01:58:16] (03CR) 10Rtdwivedi: [C: 04-1] "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92158 (owner: 10Tpt) [09:52:19] which me luck [09:52:19] wish me luck [09:52:19] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 [09:56:03] it is not even fun [10:00:36] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [10:05:18] (03PS1) 10Hashar: Extensions point to PHPUnit deployed by WMF deployment system [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92623 [10:05:38] (03CR) 10Hashar: [C: 032] Extensions point to PHPUnit deployed by WMF deployment system [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92623 (owner: 10Hashar) [10:05:41] (03Merged) 10jenkins-bot: Extensions point to PHPUnit deployed by WMF deployment system [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92623 (owner: 10Hashar) [10:14:25] (03PS1) 10Hashar: mw coverage points to PHPUnit deployed by WMF deployment system [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92624 [10:15:28] (03CR) 10Hashar: [C: 032] mw coverage points to PHPUnit deployed by WMF deployment system [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92624 (owner: 10Hashar) [10:15:47] (03Merged) 10jenkins-bot: mw coverage points to PHPUnit deployed by WMF deployment system [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92624 (owner: 10Hashar) [10:23:22] (03PS1) 10Hashar: label some jobs needing PHPUnit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92625 [10:23:37] (03CR) 10Hashar: [C: 032] label some jobs needing PHPUnit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92625 (owner: 10Hashar) [10:24:01] (03Merged) 10jenkins-bot: label some jobs needing PHPUnit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92625 (owner: 10Hashar) [10:29:50] (03PS1) 10Hashar: /var/lib/jenkins -> /srv/slave-scripts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92626 [10:30:07] (03CR) 10Hashar: [C: 032] /var/lib/jenkins -> /srv/slave-scripts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92626 (owner: 10Hashar) [10:30:25] (03Merged) 10jenkins-bot: /var/lib/jenkins -> /srv/slave-scripts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92626 (owner: 10Hashar) [10:52:28] (03CR) 10Aude: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [10:53:21] * MaxSem bites aude_ [10:53:35] heh [10:53:49] our coding conventions don't require strictly one class per file [10:54:38] strictly speaking but it makes the code more clear and understandable [10:55:03] that's your opinion [10:55:12] and eventually someday we can do autoloading magically :) [10:55:24] I find navigating through code harder when there's a myriad of files [10:55:46] well, otherwise browsing the code, i have no idea these classes exist or where they come from without scrolling down to bottom of some other file [10:55:56] so I wanted to separate diff rendering from hard maths [10:55:59] vs. seeing the files [10:56:06] MaxSem: that's good :) and agree [10:56:47] if you want to improve on this, fine - but you can't expect one commit to make everything perfect instead of just better:) [10:57:29] it's far from perfect but splitting up the stuff into classes seems a good tiem to do this and part of commit [10:57:51] also note that DifferenceEngine also does a lot of formatting [10:58:22] later on it would be nice if it could also be split, but only in another commit [10:58:22] yup, and that ewill also change;) [10:58:29] good [10:58:36] * aude is adding unit tests now for it [10:58:46] for the calculating part [10:59:57] srsly, I hate committing to core because it's just too much ikeshedding [11:00:05] yeah [11:00:21] it's just minor detail and if others disagree, then fine [11:00:25] can be split later [11:00:43] and if I split it, other will comp0lain that it's too many files, and so on [11:00:50] i hope not :) [11:01:36] the tests will be one file per class [11:02:05] although think not to many people care as much about the tests, to be honest [11:02:11] too many [11:05:24] okay, I'll add a few platform ppl to that change, but your -1 is a serious deterrent to someone even looking at it [11:05:40] let's see what they think [11:06:04] if i could +2, i would once the stuff is split [11:06:29] zealot!:P [11:06:42] :) [11:06:58] badly needed cleanup and appreciate it :) [11:13:48] oh, we have one platform folk [11:13:59] Reedy, what do you think?^:P [11:14:14] wut [11:14:54] (03CR) 10Tpt: "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92158 (owner: 10Tpt) [11:15:01] stop breaking git blame [11:15:22] (03PS1) 10Rcdeboer: Just testing [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/92631 [11:15:53] * MaxSem merges everything into one file and gives it to Reedy [11:16:46] (03PS1) 10Hashar: /var/lib/jenkins/ --> /srv/slave-scripts/ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92632 [11:16:56] (03CR) 10Hashar: [C: 032] /var/lib/jenkins/ --> /srv/slave-scripts/ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92632 (owner: 10Hashar) [11:16:59] (03Merged) 10jenkins-bot: /var/lib/jenkins/ --> /srv/slave-scripts/ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92632 (owner: 10Hashar) [11:19:32] (03PS1) 10Matthias Mullie: Use page-less Parsoid API for Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92633 [11:39:47] (03CR) 10Raimond Spekking: "Due to an translatewiki import fault (my fault..) I have had to redo your changes manually in translatewiki.net." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [11:42:19] * p858snake|l breaks git blame on Reedy [11:59:26] (03Abandoned) 10Krinkle: (DRAFT) stash from review conversation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92597 (owner: 10Krinkle) [12:03:21] * Nemo_bis collects shards [12:07:42] (03PS3) 10Krinkle: [WIP] Wrap up legacy javascript stuff [core] - 10https://gerrit.wikimedia.org/r/92457 [12:08:03] (03CR) 10Krinkle: "Rebased to resolve conflict." [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [12:08:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Wrap up legacy javascript stuff [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [12:10:22] (03PS4) 10Krinkle: Wrap up remaining legacy javascript (IEFixes, wikibits) [core] - 10https://gerrit.wikimedia.org/r/92457 [12:11:25] (03CR) 10jenkins-bot: [V: 04-1] Wrap up remaining legacy javascript (IEFixes, wikibits) [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [12:17:32] (03Restored) 10Krinkle: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [12:17:43] (03PS2) 10Krinkle: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [12:18:46] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [12:35:06] Krinkle: i am there [12:35:10] so hmm [12:35:14] I crashed Jenkins jobs :/ [12:35:17] gotta fix them [12:36:01] (03CR) 10Rcdeboer: [C: 031] Just testing [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/92631 (owner: 10Rcdeboer) [12:40:12] Krinkle: going to fix the jobs [12:40:48] (03PS1) 10Hashar: switch mediawiki jobs to use git:// ZUUL repository [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92637 [12:41:12] (03CR) 10Hashar: [C: 032] switch mediawiki jobs to use git:// ZUUL repository [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92637 (owner: 10Hashar) [12:41:37] (03CR) 10Nikerabbit: "In Translate we use just "@license GPL-2.0+" because it is readable for machines as well as humans." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92525 (owner: 10Esanders) [12:42:03] https://gerrit.wikimedia.org/r/92637 fix it (aka change the git repo URL to use git://integration.wikimedia.org/ [12:42:05] (03Merged) 10jenkins-bot: switch mediawiki jobs to use git:// ZUUL repository [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92637 (owner: 10Hashar) [12:46:45] (03PS3) 10Krinkle: $wgCapitalLinks=false not ignored during article creation in parser tests anymore [core] - 10https://gerrit.wikimedia.org/r/20534 (owner: 10Daniel Werner) [12:47:48] (03CR) 10jenkins-bot: [V: 04-1] Don't ignore $wgCapitalLinks=false in page creation parser tests [core] - 10https://gerrit.wikimedia.org/r/20534 (owner: 10Daniel Werner) [12:50:50] (03PS3) 10Krinkle: (bug #20789) What links here pager falsely says "No pages link to" [core] - 10https://gerrit.wikimedia.org/r/37685 (owner: 10Jarry1250) [12:51:33] (03CR) 10jenkins-bot: [V: 04-1] Whatlinkshere: Pager incorrectly shows "No pages link here" [core] - 10https://gerrit.wikimedia.org/r/37685 (owner: 10Jarry1250) [12:52:12] (03CR) 10Krinkle: "Ping, status?" [core] - 10https://gerrit.wikimedia.org/r/48233 (owner: 10Liangent) [12:53:03] (03CR) 10Nikerabbit: "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92439 (owner: 10Jdlrobson) [12:54:12] (03Abandoned) 10Krinkle: Fixed per coding standards and copied the fix over to getAliasList() where the same issue occurs. [core] - 10https://gerrit.wikimedia.org/r/59520 (owner: 10Alexia) [12:55:04] (03PS3) 10Krinkle: Add code to randomly remove idling records from email batch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/63097 (owner: 10Bsitu) [12:56:04] (03PS5) 10Krinkle: (Bug 44790) API bug with sqlite returns duplicate categories [core] - 10https://gerrit.wikimedia.org/r/48098 (owner: 10Yurik) [12:56:29] (03PS6) 10Krinkle: (Bug 44790) API bug with sqlite returns duplicate categories [core] - 10https://gerrit.wikimedia.org/r/48098 (owner: 10Yurik) [12:57:42] (03CR) 10Krinkle: "ping, needs merge conflict resolution." [core] - 10https://gerrit.wikimedia.org/r/64569 (owner: 10Hashar) [13:00:58] (03CR) 10Krinkle: "ping" [core] - 10https://gerrit.wikimedia.org/r/53793 (owner: 10Brion VIBBER) [13:11:16] (03Abandoned) 10Liangent: Merge branch 'chinese-collation' into 'master' [core] - 10https://gerrit.wikimedia.org/r/48233 (owner: 10Liangent) [13:12:27] (03CR) 10Krinkle: "ping, needs merge con" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/55602 (owner: 10Anomie) [13:14:08] (03PS7) 10Krinkle: Fix bugs in jqueryMsg implementation. [core] - 10https://gerrit.wikimedia.org/r/4051 (owner: 10Daniel Friesen) [13:14:42] (03CR) 10Krinkle: [C: 04-1] "need rebase, need tests" [core] - 10https://gerrit.wikimedia.org/r/4051 (owner: 10Daniel Friesen) [13:15:06] (03CR) 10jenkins-bot: [V: 04-1] jqueryMsg: Fix bugs in implementation [core] - 10https://gerrit.wikimedia.org/r/4051 (owner: 10Daniel Friesen) [13:16:55] (03PS6) 10Krinkle: Handle strings evaluating false correctly [core] - 10https://gerrit.wikimedia.org/r/66375 (owner: 10Liangent) [13:17:37] (03CR) 10Krinkle: "Updated commit message to specify what it is about ("Handle strings evaluating false" is quite generic and could mean anything). Feel free" [core] - 10https://gerrit.wikimedia.org/r/66375 (owner: 10Liangent) [13:18:06] (03PS1) 10Hashar: /var/lib/git -> /srv/ssd/gerrit [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92639 [13:18:19] (03CR) 10Hashar: [C: 032] /var/lib/git -> /srv/ssd/gerrit [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92639 (owner: 10Hashar) [13:18:48] (03Merged) 10jenkins-bot: /var/lib/git -> /srv/ssd/gerrit [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92639 (owner: 10Hashar) [13:22:03] (03PS2) 10Krinkle: Fixed EZConnect string regex in OracleInstaller class. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/66324 (owner: 10Freakolowsky) [13:25:58] (03CR) 10Nemo bis: "Is the extension still about Vector only?" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92439 (owner: 10Jdlrobson) [13:26:04] (03PS3) 10Krinkle: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [13:26:25] Krinkle: jobs are still being updated :-( [13:30:09] (03CR) 10Freakolowsky: [C: 031] Fixed EZConnect string regex in OracleInstaller class. [core] (REL1_21) - 10https://gerrit.wikimedia.org/r/66324 (owner: 10Freakolowsky) [13:31:09] hashar: ain't nobody got time for that [13:34:05] there is a job blocked for some reasons [13:34:11] which is blocking the mw/core test pipeline [13:37:01] (03CR) 10jenkins-bot: [V: 04-1] API bug with sqlite returns duplicate categories [core] - 10https://gerrit.wikimedia.org/r/48098 (owner: 10Yurik) [13:45:33] (03PS7) 10Hashar: API bug with sqlite returns duplicate categories [core] - 10https://gerrit.wikimedia.org/r/48098 (owner: 10Yurik) [13:49:26] 2013-10-30 13:44:38,765 DEBUG zuul.Jenkins: Started job mediawiki-core-qunit (change ) in 335.58661294s (tried 0 time(s)) [13:49:27] nicee [13:49:35] took almost 6 Minutes to trigger a job :5 [13:57:05] (03CR) 10jenkins-bot: [V: 04-1] LanguageConverter: Handle strings in parseRules evaluating false correctly [core] - 10https://gerrit.wikimedia.org/r/66375 (owner: 10Liangent) [13:57:48] (03PS1) 10Hashar: git-mwcore macro used wrong reference [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92640 [14:00:59] (03CR) 10jenkins-bot: [V: 04-1] API bug with sqlite returns duplicate categories [core] - 10https://gerrit.wikimedia.org/r/48098 (owner: 10Yurik) [14:06:59] (03PS4) 10Gergő Tisza: Return assessment level [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 [14:10:02] (03CR) 10Rtdwivedi: [C: 031] "Yes, it was output on view as a normal Wikipage. Otherwise, I don't really see any problem with this change." [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92158 (owner: 10Tpt) [14:19:01] (03CR) 10Anomie: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [14:23:10] (03PS1) 10Manybubbles: Use a job to handle link updates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92643 [14:28:43] (03CR) 10Matthias Mullie: "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [14:28:48] (03PS3) 10Matthias Mullie: Flow moderation actions in logs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 [14:35:06] (03CR) 10Esanders: [C: 032] "We need to set up translations on the about page." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92568 (owner: 10MarkTraceur) [14:35:32] (03Merged) 10jenkins-bot: Add info and discussion links for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92568 (owner: 10MarkTraceur) [14:37:11] (03PS1) 10Njw: Release v1.4 [skins/erudite] - 10https://gerrit.wikimedia.org/r/92645 [14:37:33] (03CR) 10Njw: [C: 032 V: 032] Release v1.4 [skins/erudite] - 10https://gerrit.wikimedia.org/r/92645 (owner: 10Njw) [14:41:53] (03PS2) 10Nikerabbit: Actually run all the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [14:42:28] (03CR) 10Nikerabbit: "I guess you should reverse the dependency for these patches to pass Jenkins." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [14:42:40] (03CR) 10jenkins-bot: [V: 04-1] Actually run all the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [14:43:18] (03CR) 10Anomie: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [14:45:54] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [14:47:30] (03PS7) 10Krinkle: exception: Use MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 [14:47:55] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [14:52:43] (03CR) 10Hashar: [C: 032] git-mwcore macro used wrong reference [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92640 (owner: 10Hashar) [14:52:45] (03CR) 10Anomie: [C: 032] "Not sure what the point of this file is, but the change seems sane." [php/luasandbox] - 10https://gerrit.wikimedia.org/r/91857 (owner: 10Reedy) [14:53:25] (03Merged) 10jenkins-bot: git-mwcore macro used wrong reference [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92640 (owner: 10Hashar) [14:53:30] (03Merged) 10jenkins-bot: Replace php_sapi_name() with PHP_SAPI [php/luasandbox] - 10https://gerrit.wikimedia.org/r/91857 (owner: 10Reedy) [14:56:18] (03PS1) 10Hashar: /var/lib/git -> /srv/ssd/gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92647 [15:01:46] (03CR) 10Erjiang: [C: 04-1] "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/92466 (owner: 10saper) [15:02:23] (03CR) 10Anomie: "Given I3369851b removes the linkprefix message entirely, I'm not inclined to continue to mess with the translations." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [15:02:56] edsanders: Thanks man [15:04:22] anomie, what's the party's policy on class <--> file relationship in core, strictly one class per file or not? [15:05:20] (03CR) 10Gergő Tisza: [C: 04-1] "(5 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [15:06:11] MaxSem: I don't know if there's an official policy, but my impression is that we generally like one class per file, but in some cases where two classes are tightly linked we do multiple. Like all those DiffOp subclasses in your recent patch, I can't really see the point in splitting all of those into separate files when the GPL headers would be bigger than the classes themselves. [15:06:30] (03CR) 10MarkTraceur: "Weird, Chromium liked the label handling. What browser did you test on?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [15:07:05] There are also people who don't care. :P [15:07:12] (see also HTMLForm) [15:07:55] anomie, so what's your opinion on my patch? [15:08:46] (03CR) 10Anomie: [C: 032] "Tim +2ed PS2 yesterday but it didn't merge, and PS3 is a simple rebase. So let's re-+2 it before l10n-bot runs again and requires yet-anot" [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [15:10:03] I'm happy to split, but would prefer not to have it merged again when other ppl complain that it's too many small files:) [15:10:35] MaxSem: Seems like a general renaming, sane enough. I don't object to the three separate-filings aude requested, although I wouldn't object to not separate-filing them either. [15:11:13] (03CR) 10Gergő Tisza: "FF24/Win8." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [15:11:17] meh [15:11:24] marktraceur, no problem [15:11:29] marktraceur, did you make the packed gallery? [15:11:42] (03CR) 10saper: "(1 comment)" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/92466 (owner: 10saper) [15:11:56] (03PS4) 10saper: Add uoi_user_registration for PostgreSQL [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/92466 [15:12:40] (03Merged) 10jenkins-bot: Remove linkprefix message, add $linkPrefixCharset [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [15:13:02] MaxSem: One other objection to separate files for everything, it means that that many more files have to be opened and read in, which can be slower than reading one combined file. Again, that applies most strongly to tightly-linked classes. [15:13:28] edsanders: That was bawolff [15:13:30] yeah, that's what I told aude:) [15:13:35] aude^^ [15:14:06] anomie: i doubt that is a very significant advantage vs. readability of the code [15:14:22] being able to find stuff is important [15:14:37] apparently, we have different ideas about readability;) [15:14:41] and someday autoloading without maintaining the list of stuff in AutoLoader.php [15:15:06] aude: It depends on the number of tiny files. And for some (myself included), having to open dozens of files to see the classes is less readable when the classes are tightly linked. [15:15:08] some day, we will use a language not as stupid as PHP, I hope:P [15:16:00] In this case, most of it is 6 versus half-a-dozen IMO. [15:16:02] well, the abstract DiffFormatter class is a separate thing [15:16:21] from all the implementations.... one which should be the stuff in DifferenceEngine [15:16:26] and maybe something in Wikibase [15:16:39] (03CR) 10MarkTraceur: "(4 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [15:16:50] having Dafaik (sp) implementation in DiffFOrmatter is weird [15:17:00] and not separate files :) [15:17:57] (03CR) 10Erjiang: [C: 031] "migration seemed to run on my postgresql setup." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/92466 (owner: 10saper) [15:18:31] whatever [15:18:52] who's gonna +2 it in present state? [15:19:05] * aude retains -1 but if someone wants to +2, then whatever :) [15:19:51] srsly, if bikeshedding will take too long and will do everything I need in MF [15:20:02] s/and/I/ [15:34:28] (03CR) 10Theaitetos: [C: 032 V: 032] Fix Cite restoration for current Cite extension [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/61269 (owner: 10Poke) [15:35:17] (03PS2) 10Aude: Add tests for DifferenceEngine for revision loading [core] - 10https://gerrit.wikimedia.org/r/92503 [15:36:08] (03CR) 10Gergő Tisza: "Doesn't always work for me (usually the link is not visible for the first time, but closing and reopening fixes it)." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [15:38:53] (03PS2) 10Aude: Put get diff body cache key into own function [core] - 10https://gerrit.wikimedia.org/r/92167 [15:39:05] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92503 (owner: 10Aude) [15:39:13] :) [15:40:08] marktraceur, why can't I comment on https://gerrit.wikimedia.org/r/#/c/92440/1 ? [15:42:06] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92503 (owner: 10Aude) [15:43:04] (03CR) 10Gergő Tisza: "Using the label for focus makes sense for checkboxes and the like because the label is much easier to hit with the mouse. That is not the " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [15:43:30] * aude happy that someone looks at my patches [15:43:51] <^d> aude: Soooo, we got about 10% done yesterday, but I had to abort for awhile. [15:43:57] <^d> Causing too much load on terbium ;-) [15:44:01] wow, slow [15:44:19] <^d> Yeah, I think it was probably going to take the better part of 48h. [15:44:36] hmmmm [15:44:43] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92503 (owner: 10Aude) [15:44:47] <^d> I'm planning to resume today from a new box. [15:44:51] ok [15:46:11] (03PS3) 10Aude: Add tests for DifferenceEngine for revision loading [core] - 10https://gerrit.wikimedia.org/r/92503 [15:46:35] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92503 (owner: 10Aude) [15:48:32] (03CR) 10MaxSem: [C: 032] Add tests for DifferenceEngine for revision loading [core] - 10https://gerrit.wikimedia.org/r/92503 (owner: 10Aude) [15:48:45] thanks MaxSem :) [15:48:51] (03PS2) 10MaxSem: Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/92588 [15:50:07] (03PS2) 10Anomie: Allow ParserLimitReportFormat to change $value [core] - 10https://gerrit.wikimedia.org/r/80412 [15:50:56] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [15:51:19] (03PS8) 10Anomie: Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 [15:52:22] (03Merged) 10jenkins-bot: Add tests for DifferenceEngine for revision loading [core] - 10https://gerrit.wikimedia.org/r/92503 (owner: 10Aude) [15:52:45] (03PS3) 10Anomie: Expose mw.log data on preview [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/55602 [15:53:35] aude, are you already doing something with DifferenceEngine? [15:53:39] (03CR) 10Anomie: "PS3: Rebase and clean up. Note Jenkins is going to fail until change I7799616a to core is merged." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/55602 (owner: 10Anomie) [15:54:07] (03CR) 10Gergő Tisza: [C: 031] "I would use a smaller font for this." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [15:56:17] i am poking at it [15:56:56] aude, any objections if I remove the m prefixes from variables before it's too late? [15:57:03] go ahead [15:57:07] :) [16:00:12] (03CR) 10Hashar: "Nice catch :-]" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [16:00:21] edsanders: I dunno [16:00:34] edsanders: I can, d'you want to tell me what's up with it? [16:00:44] marktraceur, I was going to +2 [16:00:49] 'kay [16:00:55] (03CR) 10MarkTraceur: [C: 032] "Per ed." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92440 (owner: 10Jdlrobson) [16:01:00] (03CR) 10jenkins-bot: [V: 04-1] Use the new limit report hooks [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/53804 (owner: 10Anomie) [16:01:56] (03PS1) 10Zfilipin: I could not figure out another way of having passwords in environment variables but not displayed in Jenkins console log [selenium] - 10https://gerrit.wikimedia.org/r/92650 [16:02:13] (03CR) 10Hashar: [C: 032] /var/lib/git -> /srv/ssd/gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92647 (owner: 10Hashar) [16:04:56] (03CR) 10jenkins-bot: [V: 04-1] Expose mw.log data on preview [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/55602 (owner: 10Anomie) [16:06:19] (03PS1) 10Hashar: tie operations-mw-config-tests to gallium for now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92653 [16:07:04] (03Merged) 10jenkins-bot: /var/lib/git -> /srv/ssd/gerrit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92647 (owner: 10Hashar) [16:08:36] (03PS1) 10Krinkle: [WIP] recentchanges: Implement support for pagesets [core] - 10https://gerrit.wikimedia.org/r/92654 [16:13:35] (03CR) 10Gergő Tisza: [C: 032] "Looks & works fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92438 (owner: 10MarkTraceur) [16:14:01] jdlrobson: I've added you on the translation patch for VectorBeta, https://gerrit.wikimedia.org/r/88719 [16:14:25] You should review and either merge in spite of siebrand or change the message and let siebr merge it [16:14:31] thanks marktraceur [16:14:34] Yup yup [16:14:55] (03Merged) 10jenkins-bot: Load thumbnails, use loading image in core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92438 (owner: 10MarkTraceur) [16:15:33] i'll fix now marktraceur doesn't list me as an author :P [16:17:54] (03PS2) 10Jdlrobson: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88719 (owner: 10Raimond Spekking) [16:18:07] (03CR) 10Jdlrobson: "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88719 (owner: 10Raimond Spekking) [16:18:12] (03CR) 10Gergő Tisza: [C: 032] "Looks and works fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92353 (owner: 10MarkTraceur) [16:18:22] jdlrobson: Little important, sure :) [16:18:22] (03Merged) 10jenkins-bot: position: fixed for multilightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92353 (owner: 10MarkTraceur) [16:19:06] (03CR) 10Cmcmahon: [C: 032] "wfm" [selenium] - 10https://gerrit.wikimedia.org/r/92650 (owner: 10Zfilipin) [16:25:41] (03PS1) 10Jdlrobson: Add missing media screen [core] - 10https://gerrit.wikimedia.org/r/92658 [16:27:34] (03PS1) 10Jdlrobson: i18n: Fix double space [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92659 [16:28:27] (03CR) 10Jdlrobson: "Yup - if you look at the requirements it only works on Vector. It was named generic VectorBeta as various other Vector related enhancement" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92439 (owner: 10Jdlrobson) [16:29:13] (03PS4) 10MarkTraceur: WIP Add "use this file" link and dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 [16:29:18] (03CR) 10jenkins-bot: [V: 04-1] WIP Add "use this file" link and dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [16:39:39] (03CR) 10Rtdwivedi: [C: 031] "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92319 (owner: 10Tpt) [16:40:50] (03PS2) 10Tpt: Reimplement toogleLayout feature [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92319 [16:41:37] (03CR) 10Tpt: "PS2: fix horizontal/vertical naming issue + optimisation of selectors." [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92319 (owner: 10Tpt) [16:42:36] (03CR) 10Hashar: [C: 032] tie operations-mw-config-tests to gallium for now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92653 (owner: 10Hashar) [16:51:31] (03PS1) 10Manybubbles: Better handle PoolErrors. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92665 [16:52:15] (03PS3) 10MarkTraceur: Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 [16:54:02] (03CR) 10Rtdwivedi: [C: 031] Reimplement toogleLayout feature [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92319 (owner: 10Tpt) [16:56:57] (03PS1) 10Cillian.deRoiste: Wrap jQuery in an anonymous function to avoid conflicts [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/92666 [16:57:01] (03CR) 10Tpt: [C: 032] "Reviewed" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92319 (owner: 10Tpt) [16:58:32] (03Merged) 10jenkins-bot: tie operations-mw-config-tests to gallium for now [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92653 (owner: 10Hashar) [16:58:48] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92654 (owner: 10Krinkle) [16:59:27] (03CR) 10Calak: [C: 031] "Why you don't merge this patch?" [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [17:00:14] (03CR) 10jenkins-bot: [V: 04-1] Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 (owner: 10MarkTraceur) [17:01:26] (03Merged) 10jenkins-bot: Reimplement toogleLayout feature [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92319 (owner: 10Tpt) [17:05:06] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [17:07:19] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92665 (owner: 10Manybubbles) [17:07:37] (03PS4) 10MarkTraceur: Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 [17:07:47] tgr: Uses your algo now, thanks [17:07:53] (03CR) 10jenkins-bot: [V: 04-1] Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 (owner: 10MarkTraceur) [17:07:59] (03CR) 10Ori.livneh: [C: 031] "Looks good. I'm downloading an IE6 VM at the moment and plan to do a quick test for regressions later today." [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [17:08:53] marktraceur: i omitted the part about leaving a span in the place of a whitelisted element, hope that is not a problem [17:08:59] It's not [17:09:01] would be easy to add though [17:09:16] tgr: There wasn't any reason for it, I just needed to replace it with something; your way is better [17:09:21] (03CR) 10Chad: [C: 031] Use a job to handle link updates. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92643 (owner: 10Manybubbles) [17:14:32] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [17:14:35] ori-l: browserstack/saucelabs/crossbrowsertesting ? [17:14:49] log in, set up tunnel, open url :) [17:15:05] don't even have to leave the browser (though VNC can be used as well) [17:15:19] anyway, whatever works for you [17:15:39] do they have IE6? [17:15:44] well, the vm almost finished downloading anyway [17:19:08] (03PS18) 10Matthias Mullie: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [17:19:25] (03PS1) 10Ori.livneh: mw.log.deprecate: fire mediaWiki.deprecated hook on deprecated property access [core] - 10https://gerrit.wikimedia.org/r/92667 [17:19:30] (03CR) 10Bsitu: "how about setting userId to -1 if the user is hidden?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 (owner: 10Bsitu) [17:19:33] ^ Krinkle [17:19:48] (03PS2) 10Ori.livneh: mw.log.deprecate: fire mediaWiki.deprecated hook on deprecated property access [core] - 10https://gerrit.wikimedia.org/r/92667 [17:20:06] bbiab [17:20:44] (03CR) 10jenkins-bot: [V: 04-1] mw.log.deprecate: fire mediaWiki.deprecated hook on deprecated property access [core] - 10https://gerrit.wikimedia.org/r/92667 (owner: 10Ori.livneh) [17:21:24] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92643 (owner: 10Manybubbles) [17:21:28] (03PS5) 10MarkTraceur: Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 [17:22:12] (03PS1) 10MaxSem: DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 [17:22:16] (03CR) 10jenkins-bot: [V: 04-1] Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 (owner: 10MarkTraceur) [17:23:09] (03CR) 10Bsitu: [C: 032] Respect the core 'edit' user permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91892 (owner: 10EBernhardson) [17:24:29] (03Merged) 10jenkins-bot: Respect the core 'edit' user permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91892 (owner: 10EBernhardson) [17:24:43] (03CR) 10Krinkle: [C: 04-1] "Hook name "mediaWiki.deprecated" seems odd. Prefix "mediawiki" is redundant (and should be stylised as MediaWiki or mediawiki). If we don'" [core] - 10https://gerrit.wikimedia.org/r/92667 (owner: 10Ori.livneh) [17:25:20] ori-l: Looks good, I've been looking for something like that so that I can easily extract them. [17:25:36] However now that I think about it, a hook might not be the best approach. [17:26:50] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92643 (owner: 10Manybubbles) [17:27:45] (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [17:28:16] (03PS1) 10Mattflaschen: Implement support for post-edit with VisualEditor. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/92670 [17:29:20] (03CR) 10jenkins-bot: [V: 04-1] Implement support for post-edit with VisualEditor. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/92670 (owner: 10Mattflaschen) [17:29:40] (03CR) 10Krinkle: "mw.hook might not be the best approach due to race conditions. Since this has come up a few times now, maybe we should expose the differen" [core] - 10https://gerrit.wikimedia.org/r/92667 (owner: 10Ori.livneh) [17:30:08] (03CR) 10jenkins-bot: [V: 04-1] DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [17:30:39] (03CR) 10Krinkle: "May want to use browserstack/saucelabs/crossbrowsertesting.com instead. Instant IE6 VM in your browser + tunnel. Let me know if I can help" [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [17:30:45] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [17:31:15] (03CR) 10Siebrand: [C: 04-1] "Per PS4 comment." [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [17:32:38] (03PS6) 10MarkTraceur: Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 [17:32:49] (03CR) 10jenkins-bot: [V: 04-1] Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 (owner: 10MarkTraceur) [17:34:42] (03CR) 10Krinkle: "Try to use a better commitmsg next time ("refresh" is ambiguous should probaby be "extend" or "add to", and specifying it being about a me" [core] - 10https://gerrit.wikimedia.org/r/89692 (owner: 10TTO) [17:36:43] (03CR) 10Krinkle: "Since whitelistHtml is now a standalone method, maybe expose it as a static method so that you can write unit tests for it (e.g. not on th" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 (owner: 10MarkTraceur) [17:37:26] (03PS7) 10MarkTraceur: Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 [17:38:11] (03PS2) 10MaxSem: DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 [17:40:08] (03PS2) 10Bartosz Dziewoński: Add missing media screen [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [17:40:23] (03CR) 10Bartosz Dziewoński: [C: 032] Add missing media screen [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [17:40:35] (03PS1) 10Bartosz Dziewoński: Add missing media screen [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92672 [17:40:52] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92672 (owner: 10Bartosz Dziewoński) [17:41:48] (03CR) 10jenkins-bot: [V: 04-1] DifferenceEngine cleanup [core] - 10https://gerrit.wikimedia.org/r/92668 (owner: 10MaxSem) [17:41:52] (03CR) 10Bsitu: [C: 032] Only allow Thanks for public revisions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 (owner: 10Legoktm) [17:42:04] (03CR) 10Krinkle: "What does the core API do when fetching revisions with prop=ids|user that have a hidden user?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 (owner: 10Bsitu) [17:43:28] (03CR) 10Krinkle: [C: 04-1] "This breaks any nested media query. We specifically removed it when we merged the vector-hd into it." [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [17:44:05] (03PS3) 10MaxSem: Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/92588 [17:45:02] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92588 (owner: 10MaxSem) [17:46:00] (03CR) 10Gergő Tisza: [C: 032] "Tested manually, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 (owner: 10MarkTraceur) [17:47:04] (03Merged) 10jenkins-bot: Only allow Thanks for public revisions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 (owner: 10Legoktm) [17:47:20] (03CR) 10Bartosz Dziewoński: "It did not break neither the print stylesheets not the HD stylesheets for me when I tested." [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [17:47:53] (03CR) 10Bartosz Dziewoński: "(Pending https://gerrit.wikimedia.org/r/#/c/92658/ )" [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92672 (owner: 10Bartosz Dziewoński) [17:48:09] (03PS3) 10Krinkle: Add missing media screen [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [17:48:38] (03CR) 10Legoktm: "The output of action=query&titles=User talk:Test&prop=revisions looks like (03Merged) 10jenkins-bot: Fix up whitelistHtml [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92602 (owner: 10MarkTraceur) [17:53:52] (03PS13) 10MarkTraceur: Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [17:53:53] (03CR) 10jenkins-bot: [V: 04-1] Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [17:54:09] MatmaRex: http://jsfiddle.net/4Kxv3/ [17:54:26] Chrome landed support for it recently, but it isn't accross the board and afaik non-standard. [17:54:59] Either way, even if it works, it is not supported by ResourceLoader (do not use 'media' on a file with @media inside) [17:55:42] Krinkle: WFM on Opera 12. that's not the latest browser, so i expected this to be a basic feature if even opera has it [17:55:43] oh well [17:55:55] so we're splitting hd back out? [17:56:10] Could do [17:56:19] easier would be to wrap in @media screen inside instead of outside [17:56:29] so that you don't nest the other @media [17:56:46] and verify the included files don't @media [17:57:28] sounds error-prone [17:59:21] how does one "officially" request that a new component be added in bugzilla.wikimedia.org? [17:59:47] while doing 'git clone ssh://USERNAME@gerrit.wikimedia.org:29418/mediawiki/core.git' I am getting the error message ssh: connect to host gerrit.wikimedia.org port 29418: Connection timed out [17:59:47] fatal: The remote end hung up unexpectedly [17:59:58] can anyone sort me out [18:00:46] csteipp: https://gerrit.wikimedia.org/r/92602 merged now [18:01:43] tonythomas01, can you ping gerrit.wikimedia.org? [18:02:17] yes, I can ping [18:02:18] tonythomas01, are you behind a filtering proxy/firewall or something? [18:02:46] actually, I am , but sure that itself is causing the troubles [18:02:47] ? [18:02:59] It could be [18:03:02] dan-nl: ask andre__ / file a bug in the Wikimedia / Bugzilla component [18:03:06] depending on how restrictive it is [18:03:29] dan-nl, https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component [18:03:29] tonythomas01, you should contact whoever manages the filtering stuff [18:03:33] Krenair, can we use any other port to clone the same ? [18:03:47] To clone only? [18:03:54] tonythomas01: you can clone from github or git.wikimedia.org, and use https://tools.wmflabs.org/gerrit-patch-uploader/ to upload patches [18:03:58] hm, actually I think you can push over https [18:04:05] Krenair: not for gerrit [18:04:14] Really? [18:04:15] thanks andre__ that's what i needed ... [18:04:19] that's what I do since my university blocks all ports over 100ish [18:04:25] dan-nl, no problem :) [18:04:31] What's the "HTTP Password" section of my gerrit settings then legoktm? [18:04:42] Krenair: to log into the web interface :) [18:04:53] no [18:05:17] legoktm, I could clone using https [18:05:33] but how am I able to submit a patch with https ? [18:05:47] dan-nl: file a bug in the Bugzilla component [18:06:05] dan-nl: ah, i'm late with the answer. :) [18:06:18] :) [18:06:35] MatmaRex: did you happen to see my review request? [18:08:13] tonythomas01, https://tools.wmflabs.org/gerrit-patch-uploader/ [18:08:23] Please keep this conversation in #wikimedia-dev tonythomas01 [18:08:52] tonythomas01, go to https://gerrit.wikimedia.org/r/#/settings/http-password and hit generate password [18:09:16] try using it when prompted when you push [18:09:22] I could login into the gerrit-patch uploaader [18:09:37] but wait a minute ,where will be the testing phase done ? [18:09:43] we simply upload the patch ? [18:09:58] ... yes? [18:10:03] I have no idea what you're asking [18:10:23] sorry for that ! I will try with the tool [18:10:47] dan-nl: which one? i've still got unread emails that arrived on monday [18:11:06] MatmaRex: https://gerrit.wikimedia.org/r/#/c/90041/ [18:11:23] gwtoolset? i don't even know what that is D: [18:11:40] but only if you have time. patch set 2 has marktraceur's comments [18:12:12] https://www.mediawiki.org/wiki/Extension:GWToolset [18:12:47] MatmaRex: no worries, if you're too busy [18:13:01] (03PS4) 10Jdlrobson: Vector: Set media=screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/92658 [18:13:52] if you have time and it interests you or you have any questions just let me know [18:14:03] (03CR) 10Calak: "But we remove mdy format, now what do you want?" [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [18:14:07] dan-nl: i'd like to help, but i'd have to first figure out how all that works, and i really don't have time for that now :( [18:14:30] dan-nl: i can non-committally read the code and possibly comment on it, if you want :) [18:15:29] np, it looks like i'm going to have to wait for marktraceur to clear his very busy plate. thanks though. [18:18:14] (03CR) 10Kaldari: [C: 04-1] "Please use $wgHooks['HookName'][] = Blah;" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 (owner: 10MarkTraceur) [18:19:08] (03Abandoned) 10MarkTraceur: Use Hooks class instead of wgHooks [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 (owner: 10MarkTraceur) [18:19:20] Sorry about that kaldari [18:19:56] marktraceur: No problem :) [18:21:34] (03PS1) 10EBernhardson: Include missing tag [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92675 [18:22:35] marktraceur: BTW, LESS is supported in core now, so feel free to use it for the Multimedia viewer [18:22:44] it makes managing your CSS a lot easier [18:23:13] (03CR) 10Kaldari: [C: 032] Take down the font size in lis, tweak colour [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92453 (owner: 10MarkTraceur) [18:23:17] (03Merged) 10jenkins-bot: Take down the font size in lis, tweak colour [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92453 (owner: 10MarkTraceur) [18:23:18] kaldari: I figured I'd do that after the first go :) [18:24:07] (03CR) 10Kaldari: [C: 032] Increase title font size, bold it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92451 (owner: 10MarkTraceur) [18:24:14] (03Merged) 10jenkins-bot: Increase title font size, bold it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92451 (owner: 10MarkTraceur) [18:24:32] (03CR) 10Bartosz Dziewoński: "(3 comments)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [18:24:43] dan-nl: ^ very quick comments :) [18:24:55] MatmaRex: thanks :) [18:29:24] (03CR) 10MarkTraceur: [C: 04-1] "Designers want it left-aligned or so anyway." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [18:31:00] (03PS1) 10Anomie: Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 [18:32:25] (03CR) 10Kaldari: [C: 031] Truncate a few fields with autoEllipsis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 (owner: 10MarkTraceur) [18:33:50] (03CR) 10Kaldari: "Could you add documentation for this at https://www.mediawiki.org/wiki/ResourceLoader/Default_modules#jquery.autoEllipsis (assuming it get" [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [18:34:21] (03CR) 10jenkins-bot: [V: 04-1] Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [18:34:31] (03PS1) 10Bsitu: Replying to reply sends notification to the wrong target [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92678 [18:36:22] (03CR) 10Legoktm: [C: 04-1] "This needs to be re-done now that we wrap jobs in a submit job." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/78946 (owner: 10Legoktm) [18:39:28] (03PS2) 10Anomie: Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 [18:39:42] (03CR) 10Kaldari: "Hmmm, someone needs to rewrite mediawiki.ui using LESS instead of SASS + CSS." [core] - 10https://gerrit.wikimedia.org/r/76118 (owner: 10MarkTraceur) [18:39:55] I was working on a patch, succesffully made the git diff and all, but after a git pull origin master, I lost the diffs made and git diff shows nothing [18:40:02] how to get back my diff ? [18:41:06] kaldari: You're not kidding [18:41:40] tonythomas01: What commands did you run exactly? Did you run 'git commit' at any point? [18:41:55] marktraceur: I might take a look at doing that today actually [18:42:24] RoanKattouw, I did, actually, I was on an anonymously cloned git core. I was trying to make a diff patch file [18:42:30] OK, good [18:42:38] So, first, run git pull --rebase origin master [18:43:02] Then run 'git log --oneline -5' and pastebin it [18:43:52] kaldari: Fun times [18:44:05] RoanKattouw, Doing it [18:44:06] kaldari: FWIW that module isn't really much of an mw.ui thing anymore [18:44:15] It's portable but not terribly integrated [18:44:38] marktraceur: what's it being used for these days? [18:44:42] RoanKattouw, the request is taking a lot time to get done [18:45:30] marktraceur: There seems to be a chicken and egg problem. Devs won't use mw.ui until it is more integrated, but it won't get more integrated until more devs use it and build on it. [18:46:38] MatmaRex: http://www.browserstack.com/screenshots/6f8249c254c13883d3bfffe081bb81a942031b63 http://jsfiddle.net/rWVB7/embedded/result/ [18:46:48] testing for nested media queries (both css3 and non-css3) [18:47:02] RoanKattouw,the first commit is the one I am after [18:47:09] anything with lvl-1 in the screenshot means it doesn't support nested [18:47:45] tonythomas01: Excellent [18:48:02] So, are you intending to submit this commit to Gerrit, and do you have git-review set up? [18:48:19] BTW you can view your diff now by running 'git show' [18:48:29] RoanKattouw, actually, I couldn't connect to gerrit via ssh [18:48:36] so must upload via the tool [18:48:39] Oh OK [18:49:34] RoanKattouw, thanks for that [18:50:49] Krinkle: hmm, interesting. [18:51:40] RoanKattouw, where should this change go in the Project list ? [18:51:47] RoanKattouw, to mediawiki core ? [18:51:58] (03CR) 10EBernhardson: [C: 032] "Looks good. There is a problem with how we display(or actually, just bail with a fatal exception) deleted items to users that dont have p" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [18:52:00] (03CR) 10jenkins-bot: [V: 04-1] Flow moderation actions in logs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [18:52:11] RoanKattouw, any idea ? as it is editing the installer of mediawiki [18:52:19] The installer is in MW core, yes [18:52:30] MatmaRex: http://jsfiddle.net/j4A2h/embedded/result/ http://www.browserstack.com/screenshots/c68ad86f7263aa4a7197e2f3f270641921c29bc2 [18:52:33] better one [18:52:34] (03PS3) 10Bsitu: Suppressed agent name should be hidden in API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 [18:53:13] (03PS4) 10Bsitu: Suppressed agent name should be hidden in API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 [18:53:33] (03PS14) 10MarkTraceur: Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [18:53:44] Under what Project category should I submit a diff of editing the installer of Mediawiki [18:53:45] ? [18:54:04] in http://tools.wmflabs.org/gerrit-patch-uploader/ [18:54:11] mediawiki/core [18:55:30] <^d> I should've called that mediawiki. The /core was superfluous. [18:56:31] (03CR) 10Legoktm: [C: 032] Suppressed agent name should be hidden in API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 (owner: 10Bsitu) [18:56:37] (03Merged) 10jenkins-bot: Suppressed agent name should be hidden in API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 (owner: 10Bsitu) [18:57:51] (03CR) 10Gergő Tisza: [C: 032] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [18:57:56] (03Merged) 10jenkins-bot: Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [19:00:04] (03PS4) 10EBernhardson: Flow moderation actions in logs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [19:00:23] (03CR) 10EBernhardson: [C: 032] Flow moderation actions in logs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [19:00:32] (03Merged) 10jenkins-bot: Flow moderation actions in logs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [19:01:02] (03Abandoned) 10EBernhardson: Add missing test cases to Hooks.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/76648 (owner: 10EBernhardson) [19:03:03] I get this error while adding patch with the patch upload tool - fatal: No existing author found with '01tonythomas@gmail.com' [19:03:03] Upload failed [19:03:04] Reason: Commit failed (incorrect format used for author?) (check log above for details) [19:03:40] tonythomas01: do you have a gerrit account? [19:03:48] you can create that over the web interface [19:04:42] ugh, I have, the same username itself [19:05:35] huh [19:05:42] not havng an account shouldn't be a problem [19:05:47] "ncorrect format used for author?" [19:06:09] hmmm [19:06:13] you used http://tools.wmflabs.org/gerrit-patch-uploader/bugzilla/fromurl ? [19:06:59] MatmaRex, http://tools.wmflabs.org/gerrit-patch-uploader [19:07:03] yes [19:08:24] let me try [19:08:30] i wonder what could be making it complain [19:08:51] now, I am doing it again, [19:10:20] i'm trying to submit the patch using that tool right now [19:10:35] (it's working, apparently) [19:10:45] (working as in busy) [19:10:57] (03PS1) 10Gerrit Patch Uploader: Renamed "Your name" to "Your username" to match with the Media wiki login page [core] - 10https://gerrit.wikimedia.org/r/92681 [19:11:01] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/92681 (owner: 10Gerrit Patch Uploader) [19:11:02] (03PS1) 10Gerrit Patch Uploader: Renamed "Your name" to "Your username" to match with the Media wiki login page [core] - 10https://gerrit.wikimedia.org/r/92682 [19:11:05] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/92682 (owner: 10Gerrit Patch Uploader) [19:11:18] ok submitted [19:12:39] lol MatmaRex. [19:12:51] heh [19:12:51] well [19:12:56] it worked for both of us [19:13:00] MatmaRex, looks like it uploaded [19:13:06] (03Abandoned) 10Bartosz Dziewoński: Renamed "Your name" to "Your username" to match with the Media wiki login page [core] - 10https://gerrit.wikimedia.org/r/92682 (owner: 10Gerrit Patch Uploader) [19:13:26] but see, I uploaded the same patch in the Bugzilla page too, will it create some problems ? [19:13:31] no [19:13:33] all is well now [19:13:54] it seems we both managed to upload the patch, but i deleted mine :) [19:14:08] (technically "abandoned" it, nevermind the term) [19:14:57] hey, it uploaded twice in gerrit [19:14:58] :( [19:15:19] no [19:15:22] it went okay [19:15:24] but i broke it [19:15:26] Hello. [19:15:26] it's fixed now [19:15:38] thanks ;) [19:15:40] MatmaRex: you have a comentor for the tasks you offered in Google Code In? [19:16:30] Dereckson: i probably don't :( most of the other people who work on mediawiki's frontend are too busy to take part in such puny things [19:16:36] (03PS1) 10Manybubbles: Don't write to _all field. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92685 [19:17:26] Ok. I'm available as fallback secondary mentor and volunteer in this case. [19:18:26] (03PS7) 10CSteipp: Password Expiration (WIP) [core] - 10https://gerrit.wikimedia.org/r/92037 [19:20:54] Dereckson: yay, thanks [19:28:14] (03CR) 10MarkTraceur: [C: 032] "I'm a fan. :)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/92572 (owner: 10Gergő Tisza) [19:28:16] (03Merged) 10jenkins-bot: Use standard multilang arrays [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/92572 (owner: 10Gergő Tisza) [19:28:51] (03CR) 10MarkTraceur: [V: 032] "Tested locally." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92440 (owner: 10Jdlrobson) [19:29:32] (03PS2) 10Aaron Schulz: Various grants management message cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 [19:30:23] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88719 (owner: 10Raimond Spekking) [19:30:38] (03CR) 10MarkTraceur: [C: 032 V: 032] "Trivial" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92659 (owner: 10Jdlrobson) [19:30:49] jdlrobson: One -1 for you [19:33:56] ori-l: has anybody though about optimizing mediawiki thumbnail images for size? I'm wondering whether I should write to wikitech [19:34:25] post processing? pngcrush etc? [19:34:34] yeah [19:34:53] it's enough of a miracle when they're produced at all [19:35:18] I ran (something like) find *.png | xargs optipng -o7 on my thumbs, but of course that's not really a solution [19:35:29] Nikerabbit: plop [19:35:31] and originals I don't dare to touch [19:35:38] YuviPanda: hio [19:35:48] heh... yeah. originals is a funny one [19:35:52] Nikerabbit: has there been any analysis of the ULS eventlogging data? [19:35:58] and have any been published anywhere? [19:36:00] siebrand: ^ [19:36:03] doing it after resizing and such makes sense [19:36:09] me and legoktm were just taking a look [19:36:21] shouldn't be hard to add in. or improve parameters [19:39:40] (03CR) 10EBernhardson: [C: 032] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92437 (owner: 10Werdna) [19:48:16] (03Merged) 10jenkins-bot: Flow: Fix bug where URL was not updated in address bar when permalink icon was clicked [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92437 (owner: 10Werdna) [19:48:34] hello [19:49:13] (03CR) 10Bartosz Dziewoński: "(You don't want wgMonthNames, you want the mediawiki.language.monthNames module.)" [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [19:49:52] (03CR) 10Deskana: [C: 031] "Tested on my own install. Looks good!" [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [19:50:02] (03CR) 10CSteipp: [C: 032] Various grants management message cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [19:52:38] (03PS3) 10CSteipp: Various grants management message cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [19:53:06] (03CR) 10CSteipp: [C: 032] "Manual rebase" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [19:53:33] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92167 (owner: 10Aude) [19:55:54] (03CR) 10EBernhardson: "Ping. Please review :) Initial concerns regarding limitations within the templates was just for testing and has been removed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [19:56:30] (03PS3) 10Aude: Put get diff body cache key into own function [core] - 10https://gerrit.wikimedia.org/r/92167 [19:58:57] (03CR) 10jenkins-bot: [V: 04-1] Various grants management message cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [19:59:23] (03Merged) 10jenkins-bot: Various grants management message cleanups [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92594 (owner: 10Aaron Schulz) [19:59:35] (03PS5) 10MarkTraceur: WIP Add "use this file" link and dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 [20:00:59] (03CR) 10jenkins-bot: [V: 04-1] WIP Add "use this file" link and dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [20:01:47] (03PS4) 10Aude: Put get diff body cache key into own function [core] - 10https://gerrit.wikimedia.org/r/92167 [20:06:28] (03PS6) 10MarkTraceur: Add "use this file" link and dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 [20:06:45] (03CR) 10MarkTraceur: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [20:06:54] (03CR) 10MarkTraceur: "Rebased, looking very nice." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [20:10:35] YuviPanda: best email siebrand [20:12:54] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks okay to me, but I'm not an expert on this." [core] - 10https://gerrit.wikimedia.org/r/92167 (owner: 10Aude) [20:23:02] (03PS1) 10MarkTraceur: Clear entire interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92760 [20:24:37] Reedy: Did you get a chance to look at MultimediaViewer, CommonsMetadata, or VectorBeta for performance review? [20:25:58] (03CR) 10Bsitu: [C: 04-1] "hmm, this seems introducing another form display bug" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92678 (owner: 10Bsitu) [20:26:49] (03CR) 10Nikerabbit: "I have vague memory that I've proposed this or something similar many years ago and it was rejected. Don't let that hold you this time ;)" [core] - 10https://gerrit.wikimedia.org/r/92247 (owner: 10Brian Wolff) [20:27:13] (03CR) 10Gergő Tisza: [C: 032] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [20:27:18] (03Merged) 10jenkins-bot: Add "use this file" link and dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92476 (owner: 10MarkTraceur) [20:27:19] (03PS1) 10Krinkle: Vector: Remove media=screen from skins.vector.beta module [core] - 10https://gerrit.wikimedia.org/r/92761 [20:27:20] (03PS1) 10Krinkle: ResourcesTest: Assert no @media is used inside 'media'-specified resources [core] - 10https://gerrit.wikimedia.org/r/92762 [20:28:30] (03PS3) 10Deskana: Add "unsaved changes" warning to Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [20:28:33] MatmaRex: Hm.. could you maybe rename your "release note bot" account? I keep adding it when autocompleting on your nickname in gerrit [20:28:37] meh, won't help I suppose. It picks it up on e-mailaddress [20:28:38] nvm :) [20:28:42] I'll type Bart instead of Mat :) [20:29:16] (03CR) 10Gergő Tisza: [C: 032] "Works fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92760 (owner: 10MarkTraceur) [20:30:00] (03CR) 10Krinkle: "Please rebase on Iee20d5003 and the working solution to skins.vector.beta as well." [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [20:30:16] (03CR) 10Deskana: "Added a line break between the first and second sentence per some feedback from Jared." [core] - 10https://gerrit.wikimedia.org/r/92677 (owner: 10Anomie) [20:30:34] (03CR) 10Krinkle: [C: 04-2] "Not yet merged in master." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92672 (owner: 10Bartosz Dziewoński) [20:31:18] (03CR) 10Krinkle: "I mean, I85d652da7c1." [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [20:31:38] (03PS1) 10Jforrester: Add optional info-msg and discussion-msg configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 [20:31:54] Krinkle: i would kill it if i could, the idea didn't go over well anyway [20:32:07] (03PS1) 10Cmcmahon: This is causing "Unable to pick a platform" errors in all Jenkins builds [selenium] - 10https://gerrit.wikimedia.org/r/92764 [20:32:08] Krinkle: but i do read mail sent to that address ;) [20:32:34] (03CR) 10Krinkle: [C: 04-1] Vector: Set media=screen on styles.less [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [20:32:52] marktraceur: See https://gerrit.wikimedia.org/r/92763 - would be great to get some review and tell me what I did wrong. :-) [20:33:10] (03CR) 10Cmcmahon: [C: 032] "reverting" [selenium] - 10https://gerrit.wikimedia.org/r/92764 (owner: 10Cmcmahon) [20:33:32] (03PS2) 10Krinkle: ResourcesTest: Assert no @media is used inside 'media'-specified resources [core] - 10https://gerrit.wikimedia.org/r/92762 [20:34:05] (03CR) 10Krinkle: "Using CSSMin instead of trim() to avoid potential false positives from /* comments */." [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [20:34:16] On it, James_F [20:34:42] (03Merged) 10jenkins-bot: Clear entire interface [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92760 (owner: 10MarkTraceur) [20:34:43] marktraceur: Thanks. :-) [20:35:14] (03CR) 10jenkins-bot: [V: 04-1] Add optional info-msg and discussion-msg configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [20:35:36] (03Merged) 10jenkins-bot: This is causing "Unable to pick a platform" errors in all Jenkins builds [selenium] - 10https://gerrit.wikimedia.org/r/92764 (owner: 10Cmcmahon) [20:36:07] (03CR) 10Bsitu: [C: 032] Include missing tag [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92675 (owner: 10EBernhardson) [20:36:28] (03CR) 10MarkTraceur: [C: 04-1] "(3 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [20:36:40] James_F: Eensy weensy problems, but good [20:37:08] marktraceur: Yay. [20:37:35] (03Merged) 10jenkins-bot: Include missing tag [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92675 (owner: 10EBernhardson) [20:38:54] marktraceur: Actually, isn't isset() the same weight as var references? [20:39:05] marktraceur: So we can just kill hasInfoLink? [20:39:14] Yeah [20:40:49] (03CR) 10Parent5446: [C: 031] "I'll wait for Wikinaut to give final approval." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/92466 (owner: 10saper) [20:40:59] (03PS2) 10Jforrester: Add optional info-msg and discussion-msg configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 [20:42:54] (03CR) 10Jforrester: "(3 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [20:45:21] (03CR) 10Jdlrobson: "I'm confused what needs to change to skins.vector.beta ?" [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [20:45:22] marktraceur: {{fixed}}, I think. [20:47:12] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/53793 (owner: 10Brion VIBBER) [20:49:22] * marktraceur looks [20:49:47] (03CR) 10Bartosz Dziewoński: "I assume https://gerrit.wikimedia.org/r/#/c/92761/1" [core] - 10https://gerrit.wikimedia.org/r/92658 (owner: 10Jdlrobson) [20:49:48] MatmaRex: Documentation issue. LESS only refers to https://gerrit.wikimedia.org/r/#/c/78669/ with a funny note in configuration about what not use for external extensions, but we don't have a LESS guide to tell extensions and skins developers how they can use it. [20:51:38] Dereckson: the baseline is, if you are already using ResourceLoader to manage modules, and rename your .css files to .less, and fix the paths in RL, then it will just work [20:51:57] Dereckson: there are some guidelines at https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#Less [20:52:08] Dereckson: you really should ask ori-l about LESS things, though [20:52:20] James_F: I'm not seeing an href on the links, strangely - does VE already have those params? [20:52:21] Yes, it's how I learned about LESS last week: when I wanted to know the coding conventions for CSS [20:52:56] I'm very glad we have a working CSS preprocessor solution. [20:53:22] marktraceur: No, we'd need to set it. [20:53:27] Ahhh, it's false now [20:53:34] Which is apparently true when passed through isset [20:53:38] Lol. [20:53:42] marktraceur: Oh, yes, truthy. [20:53:45] * James_F sighs. [20:53:54] marktraceur: I'll fix that for VE in a follow-up commit. [20:54:25] (03CR) 10Bartosz Dziewoński: "I want to see this fail, and I don't have PHPUnit set up locally, and I want to get this done sooner than later. I'll rebase this patch on" [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [20:54:36] (03PS3) 10Krinkle: ResourcesTest: Assert no @media is used inside 'media'-specified resources [core] - 10https://gerrit.wikimedia.org/r/92762 [20:56:05] (03CR) 10jenkins-bot: [V: 04-1] ResourcesTest: Assert no @media is used inside 'media'-specified resources [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [20:56:36] (03CR) 10Bartosz Dziewoński: [C: 032] Vector: Remove media=screen from skins.vector.beta module [core] - 10https://gerrit.wikimedia.org/r/92761 (owner: 10Krinkle) [20:56:42] James_F: I can actually submit that patch, I wrote it anyway, for testing [20:56:53] (03CR) 10Bartosz Dziewoński: "Do we want to backport this to 1.22?" [core] - 10https://gerrit.wikimedia.org/r/92761 (owner: 10Krinkle) [20:56:58] James_F: Now I'm running into the problem that info-link and discussion-link are still required fields [20:57:21] (03PS1) 10Krinkle: Vector: Remove media=screen from skins.vector.beta module [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92770 [20:57:21] marktraceur: Ah. [20:57:34] (03CR) 10Krinkle: "Yep" [core] - 10https://gerrit.wikimedia.org/r/92761 (owner: 10Krinkle) [20:57:55] (03CR) 10Bartosz Dziewoński: [C: 032] Vector: Remove media=screen from skins.vector.beta module [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92770 (owner: 10Krinkle) [21:00:12] jdlrobson: ping [21:00:20] (03Merged) 10jenkins-bot: Vector: Remove media=screen from skins.vector.beta module [core] - 10https://gerrit.wikimedia.org/r/92761 (owner: 10Krinkle) [21:00:35] (03PS4) 10Bartosz Dziewoński: ResourcesTest: Assert no @media is used inside 'media'-specified resources [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [21:00:58] (03CR) 10Bartosz Dziewoński: [C: 031] "Appears to be the right thing to do, but I barely know PHPUnit, so just +1 from me." [core] - 10https://gerrit.wikimedia.org/r/92762 (owner: 10Krinkle) [21:01:52] Krinkle: can you recheck https://gerrit.wikimedia.org/r/#/c/92201/ while we're at CSS issues? :) [21:03:06] k [21:03:37] (03Merged) 10jenkins-bot: Vector: Remove media=screen from skins.vector.beta module [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92770 (owner: 10Krinkle) [21:05:03] marktraceur: Well, what we want is miserably-complex (you need to have info-link XOR info-msg && description-link XOR description-info). [21:05:17] marktraceur: So just not require in code, and instead shout at humans? [21:05:48] Well, one of the two [21:05:51] James_F: Up to you [21:06:07] marktraceur: I guess. [21:06:09] James_F: As edsanders discovered, there's a simple way around the requirements [21:06:24] marktraceur: Well, yeah. Whoops. [21:07:17] marktraceur: OK, fixing. [21:07:31] Grazie [21:08:19] (03Abandoned) 10Merlijn van Deen: Testing [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/90697 (owner: 10Merlijn van Deen) [21:08:25] (03PS1) 10Dzahn: whitelist odder (Tomasz K.) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92773 [21:09:18] (03PS3) 10Jforrester: Add optional info-msg and discussion-msg configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 [21:09:23] marktraceur: Done. [21:11:29] (03CR) 10Bartosz Dziewoński: [C: 031] whitelist odder (Tomasz K.) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92773 (owner: 10Dzahn) [21:11:41] * marktraceur not so sure [21:11:50] marktraceur: No? [21:11:55] James_F: I'll finish one MMV patch (the last one (fingers crossed)) and review it [21:12:00] marktraceur: Kk. [21:12:13] (03CR) 10Hashar: [C: 032] whitelist odder (Tomasz K.) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92773 (owner: 10Dzahn) [21:12:32] (03Merged) 10jenkins-bot: whitelist odder (Tomasz K.) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92773 (owner: 10Dzahn) [21:13:14] (03PS2) 10MarkTraceur: Add info links for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 [21:13:21] (03CR) 10jenkins-bot: [V: 04-1] Add info links for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [21:13:21] tgr: ^^ [21:13:24] Bollocks [21:13:28] Sorry [21:15:37] (03PS3) 10MarkTraceur: Add info links for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 [21:15:41] OK seriously [21:16:06] marktraceur: your code or jenkins related? :/ [21:16:20] My code [21:16:22] hashar: Rebase [21:18:00] (03CR) 10Krinkle: [C: 032] vector: Restore gray search input placeholder [core] - 10https://gerrit.wikimedia.org/r/92201 (owner: 10Bartosz Dziewoński) [21:18:15] Zuul is busy reloading right now [21:18:18] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [21:18:22] waiting for REL1_22 documentation to complete [21:18:48] (03PS1) 10Krinkle: vector: Restore gray search input placeholder [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92774 [21:19:12] (03CR) 10Krinkle: [C: 032] "Backporting 1.22 regression bugfix from master." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92774 (owner: 10Krinkle) [21:19:25] Krinkle: thanks. wanna do another silly regression in 1.22? one-line change: https://gerrit.wikimedia.org/r/#/c/91667/ [21:19:31] "SkinTemplate: Move debug HTML above bottomscripts" [21:19:38] Later maybe. [21:19:51] moving $.ready() before broke that one [21:21:06] But if there's something you want to approve in this queue https://gerrit.wikimedia.org/r/#/q/owner:krinkle+is:open,n,z I'll get back to that one in a moment. [21:21:09] Fixing a firefox bug in VE now. [21:21:54] https://bugzilla.wikimedia.org/show_bug.cgi?id=52112 [21:23:18] [22:22:10.771] "Exception thrown by ext.betaFeatures.popup" [21:23:19] [22:22:10.771] "TypeError: this.data(...) is undefined" [object Error] [21:23:20] Now what.. [21:24:56] Krinkle: Will look [21:25:11] Uncaught TypeError: Cannot call method 'show' of undefined jquery.tipsy.js:139 [21:25:11] $.fn.tipsy jquery.tipsy.js:139 [21:25:12] (anonymous function) ext.betaFeatures.popup.js:23 [21:25:14] (anonymous function) ext.betaFeatures.popup.js:38 [21:25:16] marktraceur: I can file a bug if you want [21:25:38] I've successfully tested that MatmaRex. But I read somewhere on MediaWiki any valid CSS were valid LESS. @font-face declarations parsed by LESS broke my former CSS file. [21:25:45] marktraceur: Happens on every page when logged out and opening visual editor. [21:25:45] Krinkle: i'll get to the TemplateData stuff later this week (assuming the "sematic" issues are cleared up) [21:25:56] Krinkle: No need, I can hit it [21:26:03] MatmaRex: that commit is only the top of the stack though [21:26:03] (Fortunately, resource loader makes split between a CSS file and a less file ok) [21:26:13] Wait, I thought it only happened on logged-in accounts... :( [21:26:14] MatmaRex: anyhow, thanks for all the reviews lately. [21:26:22] Dereckson: well, any CSS2, i guess. :) [21:26:22] marktraceur: maybe, I'm getting it logged-out in incognito mode [21:26:26] Krinkle: yeah, i know [21:27:30] (03PS4) 10Jforrester: Add optional info-msg and discussion-msg configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 [21:27:30] http://stackoverflow.com/questions/8338241/how-we-can-use-font-face-in-less-type-of-css gives some valid LESS for @font-face. [21:27:34] (03CR) 10Jforrester: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [21:29:22] (03PS1) 10MarkTraceur: Fix bug in popup loading script [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92776 [21:29:25] Krinkle: ^^ [21:29:30] See if that fixes it for you [21:30:47] marktraceur: It does, but the patch worries me [21:31:07] Krinkle: Why? [21:31:17] the exceptoin is thrown via tipsy [21:31:30] why does something break in javascript based on whether you're logged in or not [21:32:12] Ah, the problem is that the element doesn't exist [21:32:28] Yeah, that would do it [21:32:37] $( '#pt-betafeatures a' ) [21:32:48] Should I check it exists first? [21:33:00] well, the module shouldn't be loaded if it doesn't exist :) [21:33:06] so the patch makes sense now [21:33:17] but ideally the outputting of that element and the loading of that module are together [21:33:25] and not reproduced from a hook [21:33:53] (03Merged) 10jenkins-bot: vector: Restore gray search input placeholder [core] - 10https://gerrit.wikimedia.org/r/92201 (owner: 10Bartosz Dziewoński) [21:34:00] Krinkle: Ideally as in this-needs-to-happen or this-should-happen? [21:35:53] (03Merged) 10jenkins-bot: vector: Restore gray search input placeholder [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92774 (owner: 10Krinkle) [21:35:56] James_F: Does the message not exist for the VE links? I'm getting as the href [21:36:05] marktraceur: Hmm. [21:36:06] marktraceur: needs to happen: condition must be exactly the same, should happen: don't maintain it in 2 places because it causes issues like these [21:36:28] marktraceur: in this case, the PersonalUrls hook should probably pass $skin so that you can add the module from the hook that adds that link [21:36:28] Krinkle: 'kay, and "needs to" is covered by that patch [21:36:34] Yep [21:36:41] Wonderful [21:36:56] marktraceur: btw, by passing $skin, you can also change the hook usage in bf to not use global wgUser [21:37:06] you'd have skin->getSkin [21:37:06] getUser* [21:37:16] and getOut->addModules of ourse [21:37:38] marktraceur: okay, if I +2 that change? [21:37:44] Yup! [21:37:48] (03CR) 10Krinkle: [C: 032] Fix bug in popup loading script [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92776 (owner: 10MarkTraceur) [21:37:49] Krinkle: Bug filed for code quality issue [21:40:38] (03Merged) 10jenkins-bot: Fix bug in popup loading script [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92776 (owner: 10MarkTraceur) [21:40:52] <3 thanks Krinkle [21:41:08] marktraceur: re: bug comment 2, does the link work without javascript [21:42:29] Krinkle: It does, I'm just joking :) [21:43:47] marktraceur: Note, that this reminds me of something else [21:43:59] You do need the check in javascript, perhaps even create it on-demand. [21:44:05] because of html cache [21:44:19] Hrm [21:44:32] All right, that's annoying, but I'll do that too [21:44:43] Right now you're at the first iteration. So any page that has this module in the load queue also has the latest html. [21:44:44] hmmm [21:44:49] why is MW master throwing errors [21:45:05] but next time anything changes in the html output from this extension, you need to account for the fact that there will be pages that get the new javascript, but old html still. [21:45:11] marktraceur: [21:45:31] (03CR) 10Legoktm: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [21:45:42] https://bugzilla.wikimedia.org/show_bug.cgi?id=56269 blah. [21:46:22] Krinkle: I may as well write the patch now [21:47:22] (03PS1) 10MarkTraceur: Check for link existence in JS [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 [21:49:55] (03CR) 10Krinkle: "(2 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 (owner: 10MarkTraceur) [21:50:16] (03PS1) 10Hashar: doc: alias PHPUnit commands [core] - 10https://gerrit.wikimedia.org/r/92782 [21:50:34] >> obj = {}; arr = []; if ( obj && arr ) { console.log('yep'); } else { console.log('nope'); } [21:50:34] Krinkle: undefined; Console: 'yep' [21:50:39] marktraceur: ^ [21:51:18] Wat [21:51:37] I take it you're surprised. [21:51:50] Not particularly [21:51:58] I was just confused as to why you were saying that [21:51:58] hehe [21:51:59] But thanks [21:52:30] yeah, surprised is the wrong word. javascript's oddities are famous http://www.youtube.com/watch?v=et8xNAc2ic8 [21:52:50] (03PS7) 10Bartosz Dziewoński: Exception: Clean up html document for error pages [core] - 10https://gerrit.wikimedia.org/r/84991 (owner: 10Krinkle) [21:53:03] (03CR) 10Bartosz Dziewoński: [C: 032] Exception: Clean up html document for error pages [core] - 10https://gerrit.wikimedia.org/r/84991 (owner: 10Krinkle) [21:53:43] (03PS5) 10Jforrester: Add optional info-msg and discussion-msg configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 [21:53:59] (03CR) 10Jforrester: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [21:54:29] legoktm: You picky bastard, making James_F do more work... :P [21:54:35] wat [21:54:37] * James_F grins. [21:54:57] oh, heh [21:54:58] legoktm: To be fair, I was riffing off the use of -msg in user-count-msg. [21:55:41] James_F: you forgot to update the commit message [21:57:22] legoktm: And now it won't fit as a commit message. [21:57:30] heueheheh [21:57:37] (03CR) 10Hashar: [C: 04-1] "Does not properly expand all possibilities, came across an issue with something like: @covers Class:method" [core] - 10https://gerrit.wikimedia.org/r/92782 (owner: 10Hashar) [21:57:39] better re-write all the code to use msg then ;) [21:57:44] (03Merged) 10jenkins-bot: Exception: Clean up html document for error pages [core] - 10https://gerrit.wikimedia.org/r/84991 (owner: 10Krinkle) [21:58:34] (03PS6) 10Jforrester: Add optional info-msg and discussion-msg configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 [21:59:22] (03CR) 10MarkTraceur: [C: 032] "Thanks so much, James_F!" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [21:59:32] marktraceur: :-) [21:59:46] :) [22:00:06] James_F: you know there's a PHP keyword for xor right? $a xor $b [22:00:25] That's terrible [22:00:35] legoktm: Yes, but I don't want to much with marktraceur's code for checking status. [22:00:51] okay [22:00:54] (03Merged) 10jenkins-bot: Add optional info-message and discussion-message configs [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92763 (owner: 10Jforrester) [22:01:12] legoktm: We can add checking XOR if you really want. :-) [22:01:14] marktraceur: is it worth having mediawiki/extensions/VectorBeta check for the existence of BetaFeatures? [22:01:32] AaronSchulz: It should probably be doing the same thing every other BF extension is doing [22:01:46] not sure what that is ;) [22:01:47] AaronSchulz: Yes. [22:01:55] AaronSchulz: Silent dependencies are bad. [22:02:06] jdlrobson: Bug in yer code [22:02:27] if ( array_key_exists( 'GetBetaFeaturePreferences', $wgHooks ) ) { [22:02:27] $wgHooks['GetBetaFeaturePreferences'][] = 'VisualEditorHooks::onGetBetaPreferences'; [22:02:27] } [22:02:30] jdlrobson: Check for the BetaFeatures class existing before you use it please [22:02:35] AaronSchulz: S'not hard. :-) [22:02:57] I'm actually no longer totally sure the hooks check is necessary, but yeah [22:03:04] That too [22:03:28] I guess I put it into an extension function or something [22:03:48] You can register hooks if they never get called. [22:03:53] You don't need an extension function [22:03:55] not a huge deal, but MultimediaViewer.php does leave a bit of global pollution [22:05:01] AaronSchulz: Can clean up if you'd like [22:05:18] heh [22:05:41] I mean, I can [22:05:57] I have some small amount of confidence that I will have time. :P [22:07:37] (03PS2) 10MarkTraceur: Check for link existence in JS [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 [22:07:48] (03PS1) 10Legoktm: Remove hard dependency upon BetaFeatures [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 [22:07:54] "Why are these not chained?" Because I'm an idiot. A tired idiot. [22:08:04] * legoktm hugs marktraceur  [22:08:34] (03CR) 10Ori.livneh: [C: 032] "Verified" [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [22:11:06] I guess I have some config patches to write! [22:14:34] (03CR) 10Krinkle: [C: 031] Check for link existence in JS [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/92781 (owner: 10MarkTraceur) [22:14:42] greg-g: What can I do to make it easier on you and Reedy tomorrow re: BetaFeatures/MultimediaViewer/CommonsMetadata? [22:15:33] (03Merged) 10jenkins-bot: Wrap up remaining legacy javascript (IEFixes, wikibits) [core] - 10https://gerrit.wikimedia.org/r/92457 (owner: 10Krinkle) [22:15:39] (03PS1) 10Krinkle: Wrap up remaining legacy javascript (IEFixes, wikibits) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92788 [22:16:14] Or maybe James_F can point me at the right wiki page or something. [22:16:33] marktraceur: Wiki page? [22:16:36] (03CR) 10Krinkle: [C: 032] "Merging commit targeted at at 1.22 release from master." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92788 (owner: 10Krinkle) [22:16:40] For config patches adding new extensions? [22:16:50] (03CR) 10Wikinaut: "I am listening, just returned from a journey. Allow me a few days." [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/92466 (owner: 10saper) [22:19:40] * AaronSchulz gets "connection reset" on page preview on his wiki [22:20:07] * AaronSchulz has no idea what that comes from [22:20:44] marktraceur: have config changes ready for merge [22:21:08] greg-g: How I ask you [22:21:09] Howwww [22:21:21] so there's this thing called gerrit [22:21:23] ops/puppet? Anywhere else? [22:23:45] marktraceur: https://git.wikimedia.org/tree/operations%2Fmediawiki-config.git [22:25:05] See, I would have lost myself for hours without you greg-g [22:25:14] Ok [22:25:14] Minutes [22:25:15] But still [22:26:44] :) [22:27:29] restarting apache2 fixed that...huh [22:27:43] marktraceur: where? [22:28:49] jdlrobson: Never mind, legoktm fixed it [22:28:57] you could review [22:28:59] thanks legoktm :) [22:29:16] (03PS1) 10Ori.livneh: mw.loader.store: temporarily allow users to opt-in via cookie [core] - 10https://gerrit.wikimedia.org/r/92791 [22:29:55] (03Merged) 10jenkins-bot: Wrap up remaining legacy javascript (IEFixes, wikibits) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92788 (owner: 10Krinkle) [22:30:11] \o/ [22:31:22] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 (owner: 10Legoktm) [22:31:43] Krinkle or brion: do you have a moment for https://gerrit.wikimedia.org/r/92791 ? (three lines of code) [22:32:06] marktraceur: so the viewer doesn't touch files for now? [22:32:13] moment [22:32:21] AaronSchulz: Correct [22:32:21] yay [22:32:23] Bug to do that soon [22:32:42] (03CR) 10Krinkle: "Works and looks good. Maybe merge it into the below condition though (setting mw.config ResourceLoaderStorageEnabled may not be useful to " [core] - 10https://gerrit.wikimedia.org/r/92791 (owner: 10Ori.livneh) [22:33:05] ori-l: Can you file a bug blocking 1.23 to remove it? [22:33:21] Krinkle: yes, that is a good idea. Doing so. [22:33:46] (03CR) 10Legoktm: "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 (owner: 10Legoktm) [22:33:52] (03CR) 10Chad: [C: 032] Don't write to _all field. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92685 (owner: 10Manybubbles) [22:34:12] (03Merged) 10jenkins-bot: Don't write to _all field. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92685 (owner: 10Manybubbles) [22:34:39] (03PS1) 10Yurik: Updated Zero ext [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92792 [22:35:34] (03CR) 10Yurik: [C: 032 V: 032] Updated Zero ext [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92792 (owner: 10Yurik) [22:38:18] (03CR) 10Jdlrobson: "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 (owner: 10Legoktm) [22:38:36] greg-g: Config patch in - should I do a submodule patch for the extensions as well? :D [22:38:42] jdlrobson: what's the point of an extension that does nothing? [22:38:56] marktraceur: yessir [22:39:09] * marktraceur skips off giddily to do that [22:39:15] jdlrobson: if someone wants to use the new beta styles, why must they have betafeatures? [22:39:39] legoktm: well think of the opposite - someone forgot to install BetaFeatures now there whole wiki has experimental styles :) [22:39:52] *their whole wiki [22:39:58] jdlrobson: "forgot" assumes a lot of incompetence... [22:40:10] i'd rather they explicitly enabled it via a global [22:40:19] legoktm: because people opposed the preference in core, and apparnetly it's harder to move the styles for this out of core, [22:40:20] then rely on the lack of installation of BetaFeatures [22:40:33] legoktm: so the styles are in core and do nothing, and the preference is in this extension and does nothing by itself as well [22:40:36] if that would happen you would immediately notice. if the extension did nothing, its much harder to debug [22:40:43] (03PS2) 10Bsitu: Replying to reply sends notification to the wrong target [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92678 [22:40:46] lazy bad design, eh [22:41:07] s/the styles/the skins.vector.beta module/ [22:41:25] MatmaRex: actually RL doesn't allow you to mix core stylesheets and extension stylesheets so please don't state lazy bad design without understanding the constraints.. [22:41:45] ummmm, i'm pretty sure it does [22:41:55] you'd just have to fiddle with the paths a little bit [22:42:01] MatmaRex: if you want to spend some time proving me wrong please be my guest I'd love to see that [22:42:12] but you can't assume that the extensions folder and the core folders will be on the same machine [22:42:29] which makes things problematic - Krinkle will be able to provide detail around that [22:42:35] but i know the path to both, don't i? [22:43:07] also, you could just define a module in core encompassing the common styles for skins.vector and skins.vector.beta (apparently just the common*.css stuff) [22:43:23] (03PS8) 10Aaron Schulz: exception: Use MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [22:43:30] and make it a dependency to skins.vector and skins.vector.beta, with some additional handling for dep resolution with addModuleStyles() [22:43:31] Yeh but that breaks caching as you are changing the contents of a module that is specified in a link in the head of the document [22:43:32] no biggie [22:44:00] (03CR) 10jenkins-bot: [V: 04-1] exception: Use MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [22:44:13] well, we'd need a transitional period [22:44:32] with the core module both having the dependency and including the styles itself [22:44:35] MatmaRex: anyway feel free to address this but i think you will find it is not as easy as you think when you actually sit down to do it [22:44:41] the extension module could do it right from the beginning [22:45:15] jdlrobson: it sounds like a very boring thing that someone who introduces such beta things should spend their time solving properly [22:45:32] i'd rather spend my free time on something more productive [22:47:40] (03PS2) 10Legoktm: Remove hard dependency upon BetaFeatures [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 [22:47:41] (03PS9) 10Aaron Schulz: exception: Use MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [22:47:42] (03CR) 10Legoktm: "(1 comment)" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 (owner: 10Legoktm) [22:47:56] (03CR) 10Aaron Schulz: "Manual rebase" [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [22:47:57] (03PS3) 10Bsitu: Replying to reply sends notification to the wrong target [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92678 [22:48:40] (03PS1) 10Yurik: Updated Zero ext [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92796 [22:51:44] (03CR) 10Gergő Tisza: [C: 031] "Looks & works fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92573 (owner: 10MarkTraceur) [22:51:57] (03PS2) 10Ori.livneh: mw.loader.store: temporarily allow users to opt-in via cookie [core] - 10https://gerrit.wikimedia.org/r/92791 [22:53:36] (03PS3) 10Ori.livneh: mw.loader.store: temporarily allow users to opt-in via cookie [core] - 10https://gerrit.wikimedia.org/r/92791 [22:53:47] (03CR) 10Ori.livneh: "PS2: took Krinkle's suggestion; PS3: rebase" [core] - 10https://gerrit.wikimedia.org/r/92791 (owner: 10Ori.livneh) [22:54:47] (03CR) 10Yurik: [C: 032 V: 032] Updated Zero ext [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92796 (owner: 10Yurik) [22:55:08] Krinkle: ^ [22:55:35] (03PS1) 10MarkTraceur: Add BetaFeatures and MultimediaViewer [core] - 10https://gerrit.wikimedia.org/r/92798 [22:55:39] \o/ so exciting [22:55:56] (03CR) 10Adamw: [C: 032] Adding description how to use Special:Redirect [core] - 10https://gerrit.wikimedia.org/r/86350 (owner: 10Yuvipanda) [22:56:18] Argh, and CommonsMetadata. #important [22:56:18] marktraceur: er, you need to add them to the wmf branch [22:56:19] (03CR) 10Adamw: [V: 032] Adding description how to use Special:Redirect [core] - 10https://gerrit.wikimedia.org/r/86350 (owner: 10Yuvipanda) [22:56:26] not master [22:57:02] you need to update the tools/release make-wmf-branch script [22:57:38] greg-g: Can we have an LD now for VE? [22:57:48] greg-g: Cherry-pick of an anti-corruption thing. [22:58:40] legoktm: greg-g LIED to me!? [22:58:40] James_F: max is before you, but sure, as long as the jobqueue issue isn't long lasting [22:58:48] greg-g: Thanks! [22:58:50] marktraceur: possible [22:58:50] Krinkle: hm, mw.log.deprecate() only prints the warnings with &debug=true. is this still intended? [22:59:06] ah, i guess yes [22:59:10] * marktraceur resolves to pee all _over_ greg-g's cornflakes [22:59:14] MatmaRex: yep [22:59:17] (i finished reading your e-mail) [22:59:31] okay, next question: why? [22:59:47] I don't know if that's really an equal retaliation, marktraceur [23:01:10] (03PS1) 10MaxSem: Update MobileFrontend to wmf1 tip [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92803 [23:01:31] (03PS1) 10JanZerebecki: Add mwext-MobileFrontend-qunit-mobile with useformat=mobile. [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/92804 [23:02:01] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf1 tip [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92803 (owner: 10MaxSem) [23:02:34] (03PS1) 10MaxSem: Update MobileFrontend to wmf22 tip [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92805 [23:02:49] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to wmf22 tip [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92805 (owner: 10MaxSem) [23:11:40] Krinkle: ping? [23:12:14] ori-l: yes? [23:13:15] i can sync that change if you re-review [23:13:18] (the cookie thing) [23:13:22] i have a slot [23:14:10] cookies for all? [23:15:12] (03PS1) 10MaxSem: Revert "Update MobileFrontend to wmf1 tip" [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92807 [23:15:19] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Update MobileFrontend to wmf1 tip" [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92807 (owner: 10MaxSem) [23:17:09] (03CR) 10Parent5446: [C: 04-1] "Why would anything with the word "beta" in it belong in MediaWiki core? If sysadmins want to give beta features to their users, they can j" [core] - 10https://gerrit.wikimedia.org/r/92798 (owner: 10MarkTraceur) [23:18:11] ori-l: You plan on backporting to wmf? [23:18:23] Krinkle: yep [23:19:40] (03CR) 10Krinkle: [C: 032] mw.loader.store: temporarily allow users to opt-in via cookie [core] - 10https://gerrit.wikimedia.org/r/92791 (owner: 10Ori.livneh) [23:20:06] Krinkle: thanks [23:20:17] (03PS3) 10Awjrichards: Changed from str to message [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [23:23:48] (03CR) 10Bartosz Dziewoński: "I think this was totally not supposed to go to this branch." [core] - 10https://gerrit.wikimedia.org/r/92798 (owner: 10MarkTraceur) [23:23:56] (03CR) 10Bartosz Dziewoński: [C: 04-2] Add BetaFeatures and MultimediaViewer [core] - 10https://gerrit.wikimedia.org/r/92798 (owner: 10MarkTraceur) [23:24:35] (03CR) 10jenkins-bot: [V: 04-1] Changed from str to message [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [23:25:14] (03PS4) 10Awjrichards: Changed from str to message [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [23:26:18] (03Merged) 10jenkins-bot: mw.loader.store: temporarily allow users to opt-in via cookie [core] - 10https://gerrit.wikimedia.org/r/92791 (owner: 10Ori.livneh) [23:26:39] (03CR) 10jenkins-bot: [V: 04-1] Changed from str to message [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [23:26:43] marktraceur: by the way, "beta features" is damned nasty to translate beautifully. [23:27:13] Polish has no clear word for "beta" nor for "feature" [23:27:20] (03PS1) 10Catrope: Update VisualEditor to wmf/1.23wmf1 branch tip for cherry-pick [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92812 [23:27:28] (03PS1) 10MaxSem: Revert "Revert "Update MobileFrontend to wmf1 tip"" [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92813 [23:28:08] (03CR) 10Awjrichards: [C: 031] "I addressed my own concern about using glob in patchset 3 (and removed unused glob in patchset 4). Instead of trying to figure out the mor" [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [23:29:04] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Revert "Update MobileFrontend to wmf1 tip"" [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92813 (owner: 10MaxSem) [23:32:18] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf/1.23wmf1 branch tip for cherry-pick [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92812 (owner: 10Catrope) [23:32:19] (03PS5) 10Awjrichards: Changed from str to message [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [23:32:41] (03CR) 10Awjrichards: [C: 031] "/me grumbles about pep8" [tools/release] - 10https://gerrit.wikimedia.org/r/86210 (owner: 10Mgrover) [23:34:25] MatmaRex: Can we file a bug in Polish? [23:34:27] :) [23:34:55] marktraceur: ;) [23:35:08] marktraceur: i'll make them "experimental functions", i guess [23:35:11] Sure [23:35:17] close enough [23:35:20] MatmaRex: Sorry about the core patch, greg-g lied to me [23:35:28] marktraceur: heh [23:35:51] (03Abandoned) 10MarkTraceur: Add BetaFeatures and MultimediaViewer [core] - 10https://gerrit.wikimedia.org/r/92798 (owner: 10MarkTraceur) [23:35:53] marktraceur: you have to trick gerrit into submitting it to the wmf branches [23:36:08] MatmaRex, marktraceur: Use the Cherry Pick To button in Gerrit [23:36:11] MatmaRex: The appropriate branch doesn't exist yet [23:36:16] CC RoanKattouw [23:36:20] also, extensions require some weird stuffs [23:36:30] i think [23:36:34] Reedy would know [23:36:38] greg-g: you know how you were complaining about spontaneous CentralNotice deploys... I have two patches that I would love to deploy tomorrow -- https://gerrit.wikimedia.org/r/#/c/92777 and https://gerrit.wikimedia.org/r/#/c/92806/ [23:36:40] (03CR) 10Jdlrobson: [C: 032 V: 032] Remove hard dependency upon BetaFeatures [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 (owner: 10Legoktm) [23:36:40] No I wouldn't [23:36:43] I never know [23:37:06] MatmaRex: Backporting extension changes to wmf* branches? [23:37:10] (Cause that's what I did today) [23:37:16] No [23:37:34] (03CR) 10Jdlrobson: "Thanks Legoktm!" [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92785 (owner: 10Legoktm) [23:37:34] MatmaRex: Add the extensions to medawiki/tools/release.git make-wmf-branch/default.conf [23:37:49] Reedy: Thanks [23:37:53] Then the script removes the heartache tomorrow as it's done automagically [23:38:07] jdlrobson: no problem :) [23:40:02] Reedy: Done :) [23:40:03] (03PS1) 10MarkTraceur: Add three Multimedia extensions [tools/release] - 10https://gerrit.wikimedia.org/r/92814 [23:40:26] I think that's game [23:40:33] i.e. I think we're ready to go for tomorrow [23:41:25] You might want to prepare the medawiki-config changes too [23:41:36] ie enablement variables, inclusions etc [23:41:47] Reedy: Done also [23:41:50] Great [23:42:46] (03CR) 10Reedy: [C: 032] Add three Multimedia extensions [tools/release] - 10https://gerrit.wikimedia.org/r/92814 (owner: 10MarkTraceur) [23:42:48] (03Merged) 10jenkins-bot: Add three Multimedia extensions [tools/release] - 10https://gerrit.wikimedia.org/r/92814 (owner: 10MarkTraceur) [23:43:53] <3 [23:45:49] (03CR) 10Krinkle: [C: 031] "Thx" [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle) [23:51:58] (03CR) 10MarkTraceur: "I would be happy to. :)" [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [23:54:36] (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson) [23:58:48] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 (owner: 10EBernhardson)