[00:02:42] (03PS2) 10saper: Don't expose blocked IP address in error message [core] - 10https://gerrit.wikimedia.org/r/92254 [00:04:47] (03CR) 10saper: "Thanks -- a whole discussion whether it is bug or not takes place in bug 53008, I was just wondering what would be the "proper" way to get" [core] - 10https://gerrit.wikimedia.org/r/92254 (owner: 10saper) [00:15:20] (03PS1) 10Legoktm: Remove EchoEvent::updateExtra, MWEchoBackend::updateEventExtra [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92259 [00:15:23] (03CR) 10Ori.livneh: "Actually, no. $wgRedactedFunctionArguments is a major design blunder that we should excise from MediaWiki rather than build on. I'll updat" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [00:18:25] (03PS3) 10Legoktm: [WIP] Add Redis backend [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92248 [00:18:45] legoktm: mmmm! :) [00:18:49] :D [00:19:16] it mostly works [00:19:17] legoktm: landed, btw [00:19:21] as in [00:19:22] in SF [00:19:39] woot [00:39:12] Krenair: around? [00:39:19] YuviPanda: hey! [00:39:21] ori-l, yep [00:40:09] ori-l: hey! [00:40:10] ori-l: I landed [00:40:30] Krenair: I think $wgRedactedFunctionArguments is a bad idea, and I had in mind to write to wikitech-l proposing we remove it [00:40:46] YuviPanda: I didn't know you were coming! I think you told me but I forgot. Exciting! [00:41:07] ori-l: :D here for two weeks-ish [00:41:32] ori-l, ugh [00:41:37] ori-l, fine, what do you want to replace it with? [00:41:37] Krenair: so, I wanted to give you a heads up, and to explain in advance that I think the implementation is fine, but that the idea itself is flawed [00:41:52] you want to run regexes on the default one or something? [00:42:11] I don't think we should replace it with anything [00:42:47] Let me see if I can convince you :) [00:43:11] Um, no, you can't just get rid of it and not replace it with anything. [00:43:53] Well, I'm not militant about it, so I could run through my argument quickly and you tell me if it's persuasive. Maybe I'm missing something. [00:44:47] okay then. [00:45:07] So, a thought experiment: suppose some solid MediaWiki developer spent a week building up $wgRedactedFunctionArguments, populating it with all the potentiall-sensitive function arguments she could think of. It goes through rigorous review, people make additional suggestions, etc. [00:45:56] Patch gets merged; someone suggests making the exception logs publicly accessible via the web. [00:46:36] Would you support the idea? If not, why not? [00:47:43] Depends what you mean by 'making the exception logs publicly accessible' [00:48:11] you can browse redacted stack traces at Special:ExceptionLog, say. [00:48:19] I would like us to ditch the really annoying setting that stops them being shown to the user whose request triggered it. [00:48:56] I think that's totally legitimate, but I'm not sure that this is the right way to go about it. [00:48:58] Making a public record of them all sounds like a surefire way to leak private information if someone else comes along and adds a method which deals with private info but was not added to $wgRedactedFunctionArguments, or if we missed one. [00:50:53] Yeah, that's basically what happened with the tool labs data breach [00:51:43] whitelisting is a bad approach, because it is only as secure as it is exhaustive and scrupulously updated [00:52:50] I think that whether we'd feel OK about making the traces public is a good gut check about whether we're convinced that the redacted trace contains no private data [00:53:27] and if the answer is no, then I think it follows that we should not mislead other users of MediaWiki by offering this feature [00:54:24] It's not just this, but we're also trying to hide the information from system administrators (they can make MW leak it if they really want to, but private info like this shouldn't show up in the logs if I can help it) [00:56:21] Well, I agree, but first: do you agree that whitelisting is unlikely to ever be completely thorough and up-to-date, and that keeping the feature is liable to inspire false confidence? [00:57:16] Also, you should have waited for ^demon and Reedy to be online before starting this conversation. They requested and approved it. [00:58:06] OK, fair. I shouldn't put you on the spot by asking you to agree / disagree, either. [00:58:20] ori-l, it will only inspire false confidence if you for some bizarre reason decide to trust it to produce proper sanitised logs for anyone to read at any time [00:58:26] How often are the user related functions going to be changed [00:58:38] NO, YOU CAN'T HAVE THIS APPROVED TILL YOU UPDATE THE REDACTEDNESSS [00:58:47] It is up to the site administrators to decide that [00:58:57] Reedy: we add code handles sensitive records all the time [00:59:02] *code that [00:59:15] where? [00:59:39] oauth, centralauth, forced password reset [01:00:04] we don't do the last one all the time! [01:00:21] The release notes is quite clear that this only handles certain functions, not all the ones that might handle private stuff [01:00:53] yeah, but it's not a question of due diligence about documenting the limitations, IMO [01:00:57] Though [01:01:13] it's just bad to offer security features that aren't secure [01:01:19] Where did we ask for exception logs publically? [01:02:17] Didn't that come out of me accidentally posting a specific stack trace with a password in? [01:02:59] I proposed it as a thought-experiment -- the point I was trying to make is that we'd feel nervous about it, and the nervousness is indicative of the feature being insecure. [01:03:21] Whitelisting this would be almost impossible [01:03:30] Reedy marked some silly feature the other day. [01:03:34] But I've forgotten what it was. [01:03:36] Death to globals. [01:03:42] Old bug [01:03:44] Oh, newPP HTML comment. [01:03:49] You could've closed it before hand [01:03:52] BUT YOU DIDN'T [01:03:56] YOUR FAULT ELSIE [01:04:05] Reedy: obvs [01:04:07] Nobody asked me. [01:04:22] Well, I think I did comment on it. [01:04:25] I don't remember. [01:04:28] I think there's a simpler solution for scrubbing traces, and that's to exclude argument values [01:04:44] Can that be done reliably? [01:04:48] yes [01:04:49] yes [01:04:57] Sounds good to me. [01:05:01] their debug value is pretty limited [01:05:12] Possibly.. [01:05:20] Yeah, until you happen to want to know the value and can prove it's not private. [01:05:39] I'm poking at https://bugzilla.wikimedia.org/show_bug.cgi?id=56219 at the moment. [01:05:44] I'm not sure why. [01:05:44] anomie pointed out one (hook name to wfRunHook) but then immediately followed by saying that it's obvious from the stack which hook got called [01:06:30] Yeah, until you happen to want to know the value and can prove it's not private. [01:06:41] ^ can you expand? What sort of scenario do you have in mind? [01:06:55] Just about any situation where you want to know what value was passed to the function [01:07:41] well, we could have redacted traces that exclude argument values and full traces that include them [01:08:18] redacted for showing to users or sysadmins, non-redacted for back-end log aggregation [01:08:32] um [01:08:38] the sysadmins read the back-end logs [01:09:01] Krenair: if only :D [01:09:07] so we redact the logs. but we can't get rid of all function params from the logs. [01:09:09] but yeah, I misspoke [01:09:25] what do you mean? [01:13:01] Are you saying that if we ████████ the other ████████████████████ would, if the ███████████████ sometimes? Wouldn't █████████████ the ███████████████? I don't think Squirrels could be trained to do that, personally. [01:14:17] Ugh, just write to wikitech-l if you want [01:14:46] It's 1:15AM and I'm not really interesting in arguing, especially at this time of night [01:15:10] The night is young [01:15:12] https://gerrit.wikimedia.org/r/#/c/76304/ is amusing. [01:15:15] * Elsie clicks star. [01:15:25] Oh, I'm already following it. [01:15:29] gj elsie [01:15:38] Krenair: OK! I'll wait as long as you like before acting on it [01:16:05] And I'm open to having my mind changed [01:16:07] It seems silly that we're removing this purely because someone might get confused by it [01:16:08] Get some sleep :) [01:16:29] good night [01:16:41] good night. thanks for fielding my questions [01:16:42] Death to globals. [01:16:47] death to globals, etc. [01:16:53] globals are dead, long live globals [01:17:22] ori-l: Okay, wanna help me with my problem? [01:17:27] I looked at the Flow prototype. [01:17:32] And I don't know when I start filing bugs. [01:17:33] the thing with the ██████████ ? [01:17:35] I can [01:17:36] Is that sanitary? [01:17:50] OK, what's the problem? [01:18:01] I haven't looked at the Flow prototype recently, so I might have to catch up first [01:18:29] http://ee-flow.wmflabs.org/wiki/Main_Page [01:18:32] That's it. [01:19:13] http://ee-flow.wmflabs.org/w/index.php?title=User_talk:HELLO&action=view [01:19:41] What am I looking at? [01:19:50] Flow. [01:20:59] And? [01:21:29] > And I don't know when I can start filing bugs. [01:21:52] I wonder what it means when it says my comment has been deleted... [01:21:55] Now, I imagine? [01:22:19] Okay. [01:22:27] I mean, I don't know, why not? [01:22:35] Well, sometimes it can be annoying. [01:22:38] Maybe. [01:22:40] I dunno. [01:22:46] There's a flow to these kinds of things. :-) [01:23:24] The prototype seems pretty awful and I want to think most of the obvious things are simply under construction rather than intentionally designed that way. [01:23:46] But I don't know the timeline. [01:24:24] Seems the reply box is hardcoded to two lines. [01:25:25] I don't know what to do about this. [01:25:59] I've heard that it is possible to use Bugzilla to troll [01:26:05] This doesn't sound like trolling [01:26:23] I'd say exercise good judgment, be kind, and go for it [01:28:24] I suppose you might be asked to withhold judgement until the development process is further along; I think that it can be a reasonable reaction, depending on the bug [01:28:55] ori-l: http://ee-flow.wmflabs.org/wiki/Special:Flow/HELLO [01:29:00] I started a new thread. [01:29:10] And apparently thread titles don't support wikilinks. [01:29:11] But I don't think it's your responsibility to self-censor; esp. if there's a public prototype out. [01:29:15] Or any wikitext, I guess. [01:29:25] So I'm immediately completely lost. [01:29:53] Are there Flow office hours? [01:30:02] I think so. [01:31:20] You can ask there, if you want an explicit invitation; but I think it'd be appropriate regardless, provided you were acting in good faith [01:31:46] http://ee-flow.wmflabs.org/w/index.php?title=Special:Flow/HELLO&workflow=0507f2b597010e132562fa163e68c4ac&action=view [01:31:54] The header is unconditionally bold. [01:32:07] Presumably some of these are design decisions. [01:32:14] They just seem like the wrong design decisions. [01:33:22] * ori-l shrugs. [01:34:00] headers are plain text [01:34:20] I don't know what you mean. [01:34:29] er, no wikimarkup supported [01:34:44] In thread titles, you mean? [01:34:53] yes [01:37:02] errrrrrrr [01:37:04] I don't really know how to appropriately respond to Flow. [01:37:08] when I said 'whitelisting' earlier, I meant 'blacklisting' [01:38:11] Elsie: here's what I think you're asking: [01:39:01] Is the word 'prototype' a ploy to reject feedback and criticism, and if so, should it be honored? [01:39:25] I don't think it is a ploy; on the contrary. It seems to me like the intent was to solicit feedback. [01:39:48] from what i understand, most of the design is finalized, just not all the features (like history) have been implemented [01:40:06] and they mainly have the prototype to seek feedback on design rather than functionality. [01:41:27] Oh, OK. [01:41:35] * legoktm looks through logs [01:42:28] [02:26:43 PM] Maybe it's too early to start asking for beta testers then? [01:42:28] [02:27:06 PM] <+ebernhardson> well, i think what they were looking for was more comments/criticism's on the design aspects rather than functionality [01:42:34] that was 10 days ago [01:42:44] who is 'they'? [01:43:00] ████████████████████. [01:43:28] they is people who set up the prototype? dunno [01:44:10] I don't think anything is off-limits; at worst you'd be told that the Flow team is aware, and asked to wait and withhold judgement [01:48:16] (03PS1) 10Rfaulk: add - ref to Git-Tools. [sartoris] - 10https://gerrit.wikimedia.org/r/92260 [01:48:34] right. i've already filed a few flow bugs [01:48:37] (03CR) 10preilly: [C: 032 V: 032] "Looks good to me." [sartoris] - 10https://gerrit.wikimedia.org/r/92260 (owner: 10Rfaulk) [01:52:03] WTF User::getRequest! [01:56:14] (03PS2) 10Aude: set url used in createaccount-text to main page canonical url [core] - 10https://gerrit.wikimedia.org/r/92251 [01:57:20] (03CR) 10Aude: "Canonical main page url should work here okay. It is much better than with "index.php"" [core] - 10https://gerrit.wikimedia.org/r/92251 (owner: 10Aude) [02:00:43] T_T I go and try to eliminate the request-context-dependent getSkin from User... and a few months later someone goes and makes User even more context dependent by adding the request to it! [02:00:47] AGH! [02:00:58] Louder. [02:01:31] I don't have "Come on Eileen" on my iPod. [02:01:55] I'm sure it's on YouTube [02:05:53] Yes. [02:05:57] https://www.youtube.com/watch?v=oc-P8oDuS0Q [02:05:57] Hi... can I bug anyone here with a really quick question? It is: what is the proper way to use, in an extension, a non-standard jQuery plugin? Do I just copy the source into the extension's git repository and update license info as necessary? Or is there more to it? Thanks a lot!! [02:06:20] Yes, pretty much [02:07:04] Cool [02:07:34] Thanks so much!!! [02:11:46] I'll do that to the tune of "Come on Eileen" then [02:15:21] (03CR) 10Daniel Friesen: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92179 (owner: 10saper) [02:22:25] (03CR) 10Springle: "Schema change has been applied to all WMF wikis." [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [02:47:05] (03PS1) 10Legoktm: [WIP] Tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 [02:59:02] (03CR) 10Legoktm: "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92248 (owner: 10Legoktm) [03:06:03] (03PS1) 10Gnosygnu: v0.10.3.0 [xowa] - 10https://gerrit.wikimedia.org/r/92262 [03:06:24] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/92262 (owner: 10Gnosygnu) [03:59:35] (03CR) 10Tim Starling: "There is already a Language object cache, used by Language::factory(), limited by $wgLangObjCacheSize. So storing the language code alone " [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [04:10:43] (03CR) 10Tim Starling: "What testing have you done?" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [04:18:20] (03PS1) 10TTO: Stop using prettifyIP for user links [core] - 10https://gerrit.wikimedia.org/r/92263 [04:23:14] (03CR) 10Kaldari: "Done: change Ibb281bde" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [04:26:09] (03PS3) 10Dan-nl: SpecialGWTooset clean-up & fix [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92171 [04:32:09] (03CR) 10Tim Starling: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [04:42:56] (03CR) 10Tim Starling: "HTML cache invalidation causes re-parsing as new requests for those pages come in. So any cache invalidation causes a temporary increase i" [core] - 10https://gerrit.wikimedia.org/r/91858 (owner: 10Reedy) [04:58:09] (03CR) 10PleaseStand: "> Do you know of any PHP4-serialized objects in the wild, for which we need to preserve this backwards compatibility? Also, do you think t" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [05:04:39] (03PS2) 10Tim Starling: Don't break $wgFileExtensions structure when removing 'mp4' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87715 (owner: 10Bartosz Dziewoński) [05:07:30] (03CR) 10Tim Starling: [C: 032] "array_values(array_diff($wgFileExtensions, array('mp4'))) could also have been used." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87715 (owner: 10Bartosz Dziewoński) [05:07:34] (03Merged) 10jenkins-bot: Don't break $wgFileExtensions structure when removing 'mp4' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87715 (owner: 10Bartosz Dziewoński) [05:11:11] (03PS1) 10Kaldari: Fixing documentation for memcached. [core] - 10https://gerrit.wikimedia.org/r/92264 [05:33:29] (03PS3) 10Adamw: Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 [05:34:17] (03CR) 10Adamw: "Great answer, thanks for the details. I've updated the patch to reflect this info." [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [05:34:58] (03CR) 10jenkins-bot: [V: 04-1] Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [05:39:55] (03PS4) 10Adamw: Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 [05:49:46] (03PS1) 10Kaldari: Only allow throttling if object caching is enabled... [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 [05:52:17] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/92257 (owner: 10saper) [05:54:54] (03CR) 10Tim Starling: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89488 (owner: 10Bartosz Dziewoński) [05:55:48] (03CR) 10Parent5446: [C: 04-2] "From Brion:" [core] - 10https://gerrit.wikimedia.org/r/92179 (owner: 10saper) [05:57:48] (03CR) 10Parent5446: [C: 04-2] "User class should definitely not be sub-classed." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92252 (owner: 10saper) [06:04:34] (03PS2) 10Legoktm: [WIP] Tests for the built-in notification types [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92261 [06:08:52] (03PS1) 10Legoktm: Actually run all the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 [06:09:01] (03CR) 10jenkins-bot: [V: 04-1] Actually run all the unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92268 (owner: 10Legoktm) [06:09:07] bahahaha [06:15:01] (03CR) 10Tim Starling: "So... have you tested it?" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [06:25:22] (03CR) 10Adamw: "@tstarling: Well, the tests included in PS4 are passing. That should cover the legacy cases that PleaseStand listed. I guess system test" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [06:34:53] (03PS1) 10Legoktm: Unbreak some unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 [06:35:01] (03CR) 10jenkins-bot: [V: 04-1] Unbreak some unit tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92270 (owner: 10Legoktm) [06:41:48] (03CR) 10Tim Starling: [C: 04-1] "I looked at those unit tests, and I didn't see any test of unserialize(). It doesn't seem like much to ask, just:" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [06:55:05] (03PS5) 10Adamw: Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 [06:55:12] Anyone around? I found a minor security bug [06:55:37] ori-l: ping [06:56:19] (03PS7) 10Netbrain: Added #subpage functionality and various minor fixes * improved error reporting on syntax failure * fixed small js scope issue [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 [06:58:16] legoktm: hey. pm? [06:58:41] yup [07:04:16] (03CR) 10Netbrain: [C: 032 V: 032] Added #subpage functionality and various minor fixes * improved error reporting on syntax failure * fixed small js scope issue [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 (owner: 10Netbrain) [07:47:48] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89488 (owner: 10Bartosz Dziewoński) [07:52:08] (03PS3) 10Bartosz Dziewoński: IcuCollation: Sort digits under localised digits' headings [core] - 10https://gerrit.wikimedia.org/r/89488 [08:15:08] (03Abandoned) 10Dereckson: Fixes stacktrace output when an internal function is called. [core] - 10https://gerrit.wikimedia.org/r/90067 (owner: 10Dereckson) [08:19:12] (03CR) 10Raimond Spekking: [C: 032] Improve wording of eauthentsent message for email confirmation [core] - 10https://gerrit.wikimedia.org/r/92249 (owner: 10Aude) [08:22:07] (03Merged) 10jenkins-bot: Improve wording of eauthentsent message for email confirmation [core] - 10https://gerrit.wikimedia.org/r/92249 (owner: 10Aude) [08:43:15] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [08:45:46] (03CR) 10Krinkle: [C: 04-1] "This will break backwards compatibility. Since this is serialised as a numerical array (not an object), the numerical keys are the only w" [core] - 10https://gerrit.wikimedia.org/r/91379 (owner: 10Raimond Spekking) [08:49:29] (03Abandoned) 10Raimond Spekking: Avoid empty values for JS variables wgMonthNames/wgMonthNamesShort [core] - 10https://gerrit.wikimedia.org/r/91379 (owner: 10Raimond Spekking) [08:55:46] (03CR) 10Krinkle: ">> Purge modules from cache no longer existent registry (due to the cache being 1 blob, they don't expire)." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [09:02:48] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89488 (owner: 10Bartosz Dziewoński) [09:04:30] (03CR) 10Ori.livneh: "> However if this is intended, it should be documented in the code." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [09:07:49] (03CR) 10Krinkle: "Does it not get cleared by git workspace cleaning? That should remove any untracked files and dirty changes." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90428 (owner: 10Hashar) [09:10:33] (03CR) 10Nikerabbit: [C: 032] Renamed folder where browser tests live in MobileFrontend repository [selenium] - 10https://gerrit.wikimedia.org/r/91982 (owner: 10Zfilipin) [09:10:36] (03Merged) 10jenkins-bot: Renamed folder where browser tests live in MobileFrontend repository [selenium] - 10https://gerrit.wikimedia.org/r/91982 (owner: 10Zfilipin) [09:19:17] (03CR) 10Krinkle: "I think the arguments for analysis or IDE are invalid. This is perfectly fine use of javascript. Most if not all arguments for it being a " [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [09:21:13] (03CR) 10Bartosz Dziewoński: "The particular editor I had in mind is Sublime Text two, which is unable to find this method with its goto-anything functionality." [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [09:21:50] (03CR) 10Krinkle: "The redefinition of the fallback is redundant indeed. Perhaps focus on that by wrapping the assignment in an if statement (thus naturally " [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [09:23:23] (03CR) 10Bartosz Dziewoński: "Hmm, sounds like a good idea, but wouldn't that affect doc generation?" [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [09:30:50] (03CR) 10Brion VIBBER: "May I recommend:" [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [09:42:05] (03CR) 10Krinkle: "The feature test was there already, this patch set removed it. We'd move it from a ternary (which requires repeating the value, and that's" [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [09:42:14] (03PS6) 10Krinkle: Generalise filename-matching in mediawiki.Title.newFromImg() [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [09:50:18] (03CR) 10Krinkle: "No, it doesn't affect the doc generator." [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [09:50:32] (03CR) 10Krinkle: [C: 032] mediawiki.Title: Generalise filename-matching in newFromImg [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [09:53:32] (03Merged) 10jenkins-bot: mediawiki.Title: Generalise filename-matching in newFromImg [core] - 10https://gerrit.wikimedia.org/r/90897 (owner: 10Jarry1250) [10:07:23] (03CR) 10Krinkle: "I also use Sublime Text 2." [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [10:08:20] (03PS1) 10Krinkle: mediawiki.log: Do not dynamically redefine mw.log.deprecate [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92281 [10:08:30] (03CR) 10Krinkle: [C: 032] mediawiki.log: Do not dynamically redefine mw.log.deprecate [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92281 (owner: 10Krinkle) [10:11:23] (03PS9) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [10:13:42] (03Merged) 10jenkins-bot: mediawiki.log: Do not dynamically redefine mw.log.deprecate [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92281 (owner: 10Krinkle) [10:15:56] (03CR) 10Bartosz Dziewoński: "(I am totally confused as to what happened here with the cherry-pick. I'll submit another patchset regardless.)" [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [10:22:39] (03PS10) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [10:23:19] Krinklee: hmm. jsduck should work on Windows, right? [10:23:36] (03PS1) 10Tpt: Escape index entry name in regex [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/92284 [10:24:51] (03PS11) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [10:34:54] (03PS5) 10Bartosz Dziewoński: Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 [10:35:53] (03CR) 10Bartosz Dziewoński: "Added docs. I am unable to make jsduck work locally (…/jsduck-5.3.4/lib/jsduck/options.rb:871:in `parse_options': invalid option: --config" [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [10:36:07] (03CR) 10Ori.livneh: "PS9:" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [10:37:38] (03CR) 10Ori.livneh: "The PHP bug is , by the way." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [10:37:54] (03CR) 10jenkins-bot: [V: 04-1] Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [10:38:30] (03PS1) 10Bartosz Dziewoński: Fix typo in usage of mwjsduck-gen [core] - 10https://gerrit.wikimedia.org/r/92285 [10:39:46] (03PS2) 10Tpt: Improves EditPage code [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92158 [10:41:39] (03PS12) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [10:42:24] (03CR) 10Ori.livneh: "PS12 updates the doc comment for jsonSerializeException for the changes between PS8 & PS9." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [10:42:26] (03CR) 10Bartosz Dziewoński: "> However we can remove the fallback entirely, since it is already defined in mediawiki.js." [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [10:44:40] (03PS1) 10Ori.livneh: Fix typo in doc comment for Message.prototype#toString [core] - 10https://gerrit.wikimedia.org/r/92286 [10:44:51] (03CR) 10Hoo man: "(3 comments)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 (owner: 10Legoktm) [10:45:03] (03CR) 10Ori.livneh: [C: 032] "Self-merge trivial commit" [core] - 10https://gerrit.wikimedia.org/r/92286 (owner: 10Ori.livneh) [10:49:43] (03Merged) 10jenkins-bot: Fix typo in doc comment for Message.prototype#toString [core] - 10https://gerrit.wikimedia.org/r/92286 (owner: 10Ori.livneh) [10:49:51] \o/ [10:50:03] forgot to add release notes [10:53:13] heh [10:53:21] (03PS6) 10Bartosz Dziewoński: Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 [10:53:49] stupid jsduck won't work for me :( [10:55:18] I don't think we support 5.3.4 yet [10:55:33] 4.whatever refused to install [10:55:46] libv8 claimed i don't have python, even though i definitely have [10:55:53] i'll just play with jenkins, i guess [10:56:22] per timo: gem install --user-install jsduck --version '< 5' [10:56:46] i tried --version '~> 4', which should be the same thing [10:56:50] i'm not sure that the result of that would be any different than '4.whatever refused to install' [10:56:51] yeah [10:57:06] F:/Ruby193/lib/ruby/gems/1.9.1/gems/libv8-3.16.14.3/ext/libv8/builder.rb:58:in `setup_python!': libv8 requires python 2 [10:57:06] to be installed in order to build, but it is currently not available (RuntimeError) [10:57:20] python 2.7 is installed and in PATH [10:57:32] oh, the build went through now. [10:57:53] potential workaround in http://stackoverflow.com/a/18583502 [10:59:27] hmm, let's try [11:17:24] F:/Ruby193/bin/ruby.exe: invalid switch in RUBYOPT: -a (RuntimeError) [11:17:26] whaa. [11:31:50] (03CR) 10Ori.livneh: [C: 032] Fix typo in usage of mwjsduck-gen [core] - 10https://gerrit.wikimedia.org/r/92285 (owner: 10Bartosz Dziewoński) [11:34:41] (03Merged) 10jenkins-bot: Fix typo in usage of mwjsduck-gen [core] - 10https://gerrit.wikimedia.org/r/92285 (owner: 10Bartosz Dziewoński) [12:38:46] (03PS1) 10Njw: Don't hide table of contents and format it neatly [skins/erudite] - 10https://gerrit.wikimedia.org/r/92297 [12:40:21] (03CR) 10Njw: [C: 032 V: 032] Don't hide table of contents and format it neatly [skins/erudite] - 10https://gerrit.wikimedia.org/r/92297 (owner: 10Njw) [12:45:08] Krinklee: you around? two patches to some very simple but very annoying RL-related bugs need review before 1.22 release :) [12:45:25] https://gerrit.wikimedia.org/r/#/c/91667/ https://gerrit.wikimedia.org/r/#/c/92065/ [12:45:34] (and https://gerrit.wikimedia.org/r/#/c/92201/ i guess) [12:45:42] ori-l: or maybe you? ^ [12:47:49] (03PS1) 10Gergő Tisza: Use moment.js for date formatting [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92298 [13:04:46] (03CR) 10Krinkle: [C: 031] "Code looks like it'll work, haven't tested yet. Any particular reason you went for making the placeholder rules more specific instead of m" [core] - 10https://gerrit.wikimedia.org/r/92201 (owner: 10Bartosz Dziewoński) [13:06:25] (03CR) 10Bartosz Dziewoński: "Simplicity, I guess. I haven't tested the other way 'round, but I see no reason why it couldn't work." [core] - 10https://gerrit.wikimedia.org/r/92201 (owner: 10Bartosz Dziewoński) [13:08:17] (03CR) 10Krinkle: "Well, it's not impossible ` log = function () {}; log.deprecate = mw.log.deprecate; mw.log = log; `, but that would only make sense if we " [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [13:08:55] (03PS2) 10Bartosz Dziewoński: vector: Restore gray search input placeholder [core] - 10https://gerrit.wikimedia.org/r/92201 [13:09:45] (03CR) 10Bartosz Dziewoński: "I still don't like the ternary in function definition, but I can abandon the patch if abandoning the ternary is so unacceptable." [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [13:11:05] (03CR) 10Bartosz Dziewoński: "(Tested and this works too.)" [core] - 10https://gerrit.wikimedia.org/r/92201 (owner: 10Bartosz Dziewoński) [13:20:13] (03PS16) 10Matthias Mullie: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [13:24:01] (03CR) 10Matthias Mullie: "EBernhardson: good point about all required data already being available. Added that check in now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [13:30:03] (03PS1) 10Bartosz Dziewoński: Update documentation for $join_conds in DatabaseBase::select() [core] - 10https://gerrit.wikimedia.org/r/92301 [13:30:06] (03PS1) 10Cmcmahon: "Next" button often takes a long time to appear [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92302 [13:34:22] (03CR) 10Bartosz Dziewoński: "> I haven't yet taken a close look at the code, though I do question whether this should really be part of core MediaWiki. As stated in me" [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [13:42:41] (03CR) 10Zfilipin: [C: 04-1] "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92302 (owner: 10Cmcmahon) [13:52:59] (03PS2) 10Cmcmahon: "Next" button often takes a long time to appear [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92302 [14:00:25] (03CR) 10Zfilipin: [C: 032] "Next" button often takes a long time to appear [qa/browsertests] - 10https://gerrit.wikimedia.org/r/92302 (owner: 10Cmcmahon) [14:13:28] (03CR) 10Gergő Tisza: [C: 032] Fix EL dependency loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92034 (owner: 10MarkTraceur) [14:13:30] (03Merged) 10jenkins-bot: Fix EL dependency loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92034 (owner: 10MarkTraceur) [14:20:22] (03CR) 10Gergő Tisza: [C: 04-1] "I can't get this to work. The extmetadata response has a License field with the value "cc-by-sa-3.0", but the link still says "Licensing i" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [14:22:28] ori-l, I definitely think we should add a setting to allow all function parameters to be redacted from stack traces. [14:22:57] Whether to remove wgRedactedFunctionArguments, well... let's see what wikitech-l decides on that [14:41:30] (03CR) 10Krinkle: "I have no reservation for the ternary. The issue is in it not being guarded by the feature test. Using if/else would be fine if you want t" [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [14:49:52] (03Abandoned) 10Bartosz Dziewoński: mediawiki.log: Do not dynamically redefine mw.log.deprecate [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [14:59:56] (03CR) 10Krinkle: "Follow-up: If you want to use if/else instead of ternary for function values in general (this patch didn't do that though), that should be" [core] - 10https://gerrit.wikimedia.org/r/92067 (owner: 10Bartosz Dziewoński) [15:01:03] (03PS11) 10Bartosz Dziewoński: Inline confirmation for rollback links [WIP] [core] - 10https://gerrit.wikimedia.org/r/90729 [15:01:04] (03PS1) 10Bartosz Dziewoński: jQuery.confirmable: New inline confirmation module [WIP] [core] - 10https://gerrit.wikimedia.org/r/92315 [15:01:45] (03CR) 10Bartosz Dziewoński: "Split the general implementation to https://gerrit.wikimedia.org/r/92315 ." [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [15:02:44] (03PS12) 10Bartosz Dziewoński: Inline confirmation for rollback links [WIP] [core] - 10https://gerrit.wikimedia.org/r/90729 [15:05:11] (03PS8) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [15:06:27] (03CR) 10Bartosz Dziewoński: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [15:06:50] (03CR) 10Krinkle: "Do not use Verified, Do not submit merge manually bypassing Jenkins." [core] - 10https://gerrit.wikimedia.org/r/65346 (owner: 10Spage) [15:06:57] (03PS1) 10Manybubbles: Allow old boolean operators. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92317 [15:07:17] (03PS2) 10Manybubbles: Allow boolean operators. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92317 [15:08:15] (03PS1) 10Manybubbles: Tests for boolean operators. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92318 [15:19:07] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [15:20:30] (03CR) 10Krinkle: "Requesting input or confirmation from design and UX perspective." [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [15:23:43] (03CR) 10Bartosz Dziewoński: "I chatted with Steven and Isarra and they were okay-ish with it – any design input or fixes will be appreciated :) I think Steven consulte" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [15:23:57] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [15:26:43] (03PS1) 10Tpt: Reimplement toogleLayout feature [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92319 [15:28:15] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [15:54:24] (03PS9) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [15:54:33] (03PS1) 10Aude: Update Wikibase, fix for uncaught exception in ByPropertyListUnserializer [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92323 [15:56:53] Failed asserting that 'array' is of type "array". [15:56:57] arghh [16:07:38] Krinklee: around ? [16:09:38] hashar: could you help me a bit? [16:22:06] hashar: Check your work account google plus / hangout messages. [16:22:46] Krinkle: nothing :- [16:22:47] D [16:26:54] (03PS1) 10Hashar: tests for includes/exception.php [core] - 10https://gerrit.wikimedia.org/r/92328 [16:28:08] (03CR) 10Hashar: [C: 031] "Not much more to say, thank you Ori :-]" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [16:29:27] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [16:31:13] greg-g: fyi, I've scheduled another CentralNotice bugfix deployment for 2300 UTC today. [16:31:24] * greg-g does math [16:31:27] Krinkle: received on my phone hehe [16:31:36] anomie: :-] [16:31:38] hehe 2pm pacific [16:31:38] awight: what's the bug? [16:31:48] awight: also, just fyi, it's customary to ask first :) [16:31:52] greg-g: in the calendar. two bugs in Special:GlobalAllocation [16:31:59] since, LD's are for low risk things as determined by you and me :) [16:32:08] greg-g: no problem, thanks for the policy info [16:32:13] anomie: I forgot to read ori email on wikitech :-( [16:32:32] greg-g: it's definitely negotiable ;) [16:32:45] awight: also, you mean 2100 UTC, right? ie: 2pm? [16:33:10] ie: the page says 2100 UTC :) [16:33:19] * awight drools. [16:33:31] greg-g: thanks [16:33:32] hashar: I don't excessively care which way that wikitech-l discussion goes (although I find being able to see which value was passed rather than "int" or "string" useful on occasion). But we don't need two slightly-different versions of the logging. [16:33:47] yes 2100UTC [16:33:51] awight: :) cool [16:34:40] greg-g: great, that way I have time to schedule the rollback for during LD [16:34:43] :p [16:38:23] (03CR) 10GWicke: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [16:40:20] awight: :P [16:40:47] (03CR) 10EBernhardson: [C: 031] "Per schema change request, the new schema is deployed to WMF wiki's." [core] - 10https://gerrit.wikimedia.org/r/91993 (owner: 10EBernhardson) [16:45:00] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [16:47:12] (03PS1) 10Aude: add Tpt, trusted long-time contributor to Wikibase, ProofreadPage, etc. [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/92332 [16:47:17] anomie: yeah that was my point with ori: get both format to contains the same amount of information [16:47:56] (03CR) 10Mwalker: [C: 032] Remove undeed methods in tests [core] - 10https://gerrit.wikimedia.org/r/91831 (owner: 10Addshore) [16:48:44] undead methods? [16:48:57] (03PS2) 10Bartosz Dziewoński: Remove undeed methods in tests [core] - 10https://gerrit.wikimedia.org/r/91831 (owner: 10Addshore) [16:49:14] (03CR) 10Bartosz Dziewoński: [C: 032] "Typos? Over my dead body!" [core] - 10https://gerrit.wikimedia.org/r/91831 (owner: 10Addshore) [16:49:33] (03CR) 10Hashar: [C: 04-1] "Bah was not careful, -1 just so we remember to extract out the variable exports so that both text and json output contains them." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [16:49:40] (03CR) 10Swalling: [C: 031] "I've tried this out on a testwiki, and I think inline confirmation is a good direction to go in. It's far superior to the modal confirmati" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [16:53:32] (03CR) 10Bartosz Dziewoński: "> There is one important design issue we haven't solved here yet, and it's context. Both the confirm action and the language describing it" [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [16:55:10] anomie: what do you think of MWExceptionHandler::formatArgumentsInCall() ? :) [16:55:17] (03CR) 10Mwalker: "@Krinkle; yep I know -- too much of a habit from spending time in the fundraising repos without tests. I did stay around and watch to make" [core] - 10https://gerrit.wikimedia.org/r/65346 (owner: 10Spage) [16:55:42] (03Merged) 10jenkins-bot: Remove unneeded methods in tests [core] - 10https://gerrit.wikimedia.org/r/91831 (owner: 10Addshore) [16:57:18] (03CR) 10GWicke: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [16:57:38] hashar: As a function name? Assuming it takes an individual call and formats the arguments as the name implies, that'd be fine. [16:58:24] (03PS1) 10Hashar: MWExceptionHandler::formatArgumentsInCall [core] - 10https://gerrit.wikimedia.org/r/92334 [16:59:40] (03CR) 10Hashar: "I have extracted the argument formatting code in a new static function MWExceptionHandler::formatArgumentsInCall() which returns an array " [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [16:59:57] (03PS1) 10AndyRussG: Disable institution-page cache when logged in [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/92335 [17:00:28] anomie: sent and added ori and you as reviewers. I am off for now, see you later tonight for the team meeting [17:01:17] (03CR) 10Swalling: "Okay, I see it now in your qqq file etc." [core] - 10https://gerrit.wikimedia.org/r/92315 (owner: 10Bartosz Dziewoński) [17:02:46] thanks MatmaRex :) [17:03:26] (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [17:04:07] aude: my pleasure [17:04:16] aude: i'm just filing a bug about how dumb that is [17:05:13] (03CR) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [17:05:27] MatmaRex: better that the community can set the logo, anyway [17:05:50] (03PS2) 10AndyRussG: Disable institution-page cache when logged in [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/92335 [17:07:12] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=56257 [17:07:41] greg-g: should the standup meetings be on the calender? [17:07:47] (03CR) 10Deskana: [C: 031] "The MW prefix definitely needed removing." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [17:08:20] MatmaRex: thanks! [17:08:22] AaronSchulz: ugh, yes [17:10:12] anomie: my code is rusty :( [17:10:52] OK [17:12:20] csteipp, Reedy, we're looking to get deploy reviews done hard 'n' heavy this week, do you guys have the bandwidth for that? https://bugzilla.wikimedia.org/show_bug.cgi?id=55749 https://bugzilla.wikimedia.org/show_bug.cgi?id=56140 https://bugzilla.wikimedia.org/show_bug.cgi?id=56133 [17:12:56] There are open bugs blocking one of them, but we'll be cleaning those up today and tomorrow. VectorBeta and CommonsMetadata are ready to go now, though we may want extra performance attention to CMD [17:14:39] hey marktraceur, deployin' stuff? because i have some backports to deploy i was hoping to get in today [17:14:59] https://gerrit.wikimedia.org/r/92181 https://gerrit.wikimedia.org/r/92065 https://gerrit.wikimedia.org/r/92201 [17:15:03] marktraceur: Are there patches for those? How much code? [17:15:16] csteipp: They're all in gerrit with a fairly mature and CR'd master [17:15:17] (all trivial, all annoying) [17:15:26] MatmaRex: I'm not deploying anything until Thursday [17:15:32] And only extensions then [17:15:53] anomie: We could also use a final sprint-push on https://gerrit.wikimedia.org/r/78926 if you have the time - blocks CMD deployment [17:15:57] (you could still review these and i'd poke Reedy about the backports :>) [17:16:07] MatmaRex: This is _not_ the week [17:16:11] csteipp: https://gerrit.wikimedia.org/r/#/c/91500/ is still pending [17:16:28] AaronSchulz: Reviewing it right now, and alieases are sucking [17:16:29] http://ganglia.wikimedia.org/latest/?c=Redis%20eqiad&h=rdb1003.eqiad.wmnet&m=cpu_report&r=hour&s=by%20name&hc=4&mc=2 [17:16:35] * AaronSchulz watches the bits flow \o/ [17:16:40] MatmaRex: I'll spend all Saturday reviewing patches for you, but this work week is shot to hell with deploy prep [17:17:20] I am off, see you later tonight [17:17:33] marktraceur: heh [17:17:41] marktraceur: I see tgr has a -1 on that one. [17:17:59] i need frontend platform people :( [17:18:04] marktraceur: My answer approaches "no" as $time-to-find-what-you-want-reviewed passes 30 seconds.... Can you point me to patches, or send me an eamil with exactly what you need? [17:18:20] csteipp: Sure, will CC Reedy [17:18:46] anomie: That appears to be the case, yes - sorry for jumping the gun. tgr, poke anomie when you've addressed your own concerns, I guess. :) [17:19:04] AaronSchulz: In your current patchset, on my test wiki, now MAOAuth redirects to OAuth, which messes with the signatures (since title is a signed parameter) [17:19:21] Is that just my test wiki? Or is that how aliases are supposed to work? [17:20:31] anomie, marktraceur: multilang is broken in the extmetadata API, not sure how to fix it, i'll just rip it out and re-add it later [17:20:31] will ping you when its done [17:22:00] csteipp: do you have that https redirect flag on [17:22:16] As in securelogin? [17:22:19] aliases should not send redirects if that's what you mean [17:22:41] That's what I thought... I wasn't sure if it's my test setup or the patchset [17:23:25] 'kay [17:23:30] Thanks tgr [17:24:49] (03CR) 10Hoo man: [C: 04-1] "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 (owner: 10Kaldari) [17:26:10] tgr: Is the problem that you have to include iiextmetadatamultilang=1 in your query from ForeignAPIFile.php in change 88889? [17:27:46] anomie: yes, for multilang to work, the ForeignAPIFile constructor should itseld do a multilang query [17:28:05] and i have no idea what to do with iiextmetadatalanguage [17:28:38] and the language handling part of CommonsMetadata would have to be changed as well [17:28:50] Pull the language code out of the context? Or do you not have the context there either? Looks like not. Hmm. [17:29:35] as far as i understand, the context language comes from the uselang parameter, or whatever default [17:29:42] (03Abandoned) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [17:29:46] and iiextmetadatalanguage is something different [17:30:40] so trying to make the constructor depend on that is probably not the way to go [17:31:08] always fetching all languages from the repo might work, i'm not sure if there are performance implications [17:31:34] anyway, we don't actually need any of this, so it is best to separate it into a different changeset [17:37:18] (03PS2) 10Kaldari: Only allow throttling if object caching is enabled... [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 [17:39:20] (03CR) 10BryanDavis: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [17:42:26] (03PS3) 10Kaldari: Only allow throttling if object caching is enabled... [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 [17:43:09] (03PS4) 10Kaldari: Only allow throttling if object caching is enabled... [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 [17:43:30] (03CR) 10BryanDavis: [C: 032] SpecialGWTooset clean-up & fix [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92171 (owner: 10Dan-nl) [17:43:37] (03Merged) 10jenkins-bot: SpecialGWTooset clean-up & fix [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92171 (owner: 10Dan-nl) [17:44:12] csteipp, Reedy, Krinkle|detached, I've sent you mail about deploy review for three extensions and a note about two other extensions that are involved in this week's craziness [17:44:17] (03CR) 10Dan-nl: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [17:44:59] (03PS1) 10Mwalker: Re-enable adyen autoselection [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/92341 [17:50:12] <^d> manybubbles: Hmm, I'm futzing with cirrus_versions but having an issue. [17:50:24] <^d> _id is supposedly a string, but it's not letting me use a string for the id. [17:50:36] (03CR) 10Aaron Schulz: [C: 032] Revert "Revert "Add new recentchanges field rc_source to replace rc_type"" [core] - 10https://gerrit.wikimedia.org/r/91993 (owner: 10EBernhardson) [17:51:06] ^d: hmm - so you are posting a string to it and it isn't coming back that way? [17:51:20] ^d: you might want to try it with curl first to see if it is something funky with Elastica [17:51:32] <^d> I'm posting a string to it and it's throwing a response exception. [17:53:56] (03Merged) 10jenkins-bot: Revert "Revert "Add new recentchanges field rc_source to replace rc_type"" [core] - 10https://gerrit.wikimedia.org/r/91993 (owner: 10EBernhardson) [17:54:15] AaronSchulz: Both with and without wgSecureLogin, I get redirects for the alias on both of my dev wikis. Is there a setting the prevents that? [17:56:32] csteipp: are you hitting a subpage of MWOAuth? Could be $wgMWOAuthSecureTokenTransfer [17:57:54] Yeah, title=Special%3AMWOAuth%2Finitiate.. [17:58:34] Just tested with and without wgMWOAuthSecureTokenTransfer.. still get redirected (I get redirected to http:// link) [18:00:33] ^d: can you post contents of the exception somewhere? [18:00:34] heh, searching for "gerrit" in bugzilla isn't useful anymore :) [18:01:15] <^d> heh [18:01:16] csteipp: you mean an actual 302? I don't get that with curl [18:01:26] Yep, 302 [18:01:38] <^d> manybubbles: http://p.defau.lt/?lRRRlp3bcJ6DokprZ1GHLA [18:02:22] csteipp@linux-hv06:~> curl -I 'http://localhost/wiki/index.php?format=json&oauth_callback=oob&oauth_consu891c531fe041c36c&oauth_nonce=0578f3be96db4b2edfbb3e33429addc4&oauth_signature=xSrx2RzqioO%2B%2BHFZmxU8v%2Bn3NPA%3D&oauth_signature_method=HMAC-S982514&oauth_version=1.0&title=Special%3AMWOAuth%2Finitiate' [18:02:22] HTTP/1.1 302 Found [18:02:34] <^d> $d = new \Elastica\Document( $index, array( 'version' => self::VERSION ) ); [18:02:34] <^d> $this->index->addDocuments( array( $d ) ); [18:02:42] <^d> ^ That was my code. $index is just a string. [18:03:34] (03CR) 10BryanDavis: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [18:03:35] ^d: it is eating the response exception message which is kind of important to know _why_ es doesn't like it [18:04:31] my next step would be to convince it not to eat the exception. [18:04:34] <^d> Lemme dump the exception and see if there's something nicer. [18:05:26] siebrand: Could you do a quick i18n review of https://gerrit.wikimedia.org/r/#/c/92155/? dan-nl is adding 2 new messages to his extension. [18:05:26] <^d> Got it. [18:05:29] <^d> {"error":"ActionRequestValidationException[Validation Failed: 1: type is missing;]","status":500} [18:06:24] bd808: we won't need the i18n review because of the switch to wfUseMW. i'll use its message instead [18:06:31] <^d> I'm probably being a little over simplistic when creating my initial mapping/config. [18:07:19] dan-nl: Ok. siebrand I guess we're good :) [18:07:33] bd808: k. L10n/i18n looked fine. [18:07:46] siebrand: Thanks [18:07:55] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [18:08:03] <^d> greg-g: If you're looking for gerrit bugs, search "Wikimedia -> Git/Gerrit" [18:08:16] <^d> If it's not there, assume it's just a link or something :p [18:08:47] (03PS19) 10Gergő Tisza: Add "extended" file metadata to API [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [18:08:48] (03PS11) 10Gergő Tisza: Add extmetadata to the ForeignAPIFile iiprops [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [18:08:57] !bug :gerrit [18:08:57] https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=%3agerrit [18:09:14] ^d: you probably don't have to create the type - it'll still autocreate that for you. you will have to set one on the command though. [18:09:36] thanks siebrand [18:10:39] so, is there seriously no one i could ping today to review and deploy fixes for regressions in UI? [18:10:39] ^d: yeah :) [18:10:48] (03CR) 10Gergő Tisza: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [18:11:04] (https://gerrit.wikimedia.org/r/92181 https://gerrit.wikimedia.org/r/92065) [18:11:17] tgr: Is 88889 a blocker for CMD deploy? [18:11:26] At least, to Commons? [18:12:38] not in the strict sense, but would be pointless to deploy without it [18:12:59] anyway, it is a very simple change, the parent is the complex one [18:13:10] Heh [18:13:11] Yeah [18:13:18] (03PS1) 10Matthias Mullie: Flow moderation actions in logs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 [18:13:34] if you want to use MV on commons only, that would work without 88889 [18:14:08] Thaaat would go over like a lead balloon [18:14:20] Let's update requirements, I guess [18:14:25] (03CR) 10Gergő Tisza: "Removed language handling. Will be re-added in a separate changeset soon." [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [18:14:40] <^d> manybubbles: Here's the code I've been playing with: http://p.defau.lt/?Heh_b_vfuW0VBE3EdjGjKQ [18:15:20] (03CR) 10Dan-nl: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [18:15:44] anomie: done, could you review 88889 and parents? [18:15:46] 78926 is a bit simpler now [18:16:03] tgr: ok, will look in a few minutes [18:16:12] thx [18:17:19] ^d: I think it'd work better if you replaced $index with a $type. You can add documents to that too. [18:17:23] and it'll work! [18:17:51] csteipp: I see [18:18:15] can people just update the consumers? No one is using this now [18:18:47] it will only get more annoying over time [18:19:20] and at the rate this is going, people will have done so before deploy [18:19:57] (03CR) 10saper: "Thanks for your valuable input!" [core] - 10https://gerrit.wikimedia.org/r/92179 (owner: 10saper) [18:20:11] (03Abandoned) 10saper: Allow robotic Users to determine their IP address [core] - 10https://gerrit.wikimedia.org/r/92179 (owner: 10saper) [18:20:24] <^d> manybubbles: Swapping for $index with a type gives me the same error about not having a type. [18:21:08] (03Abandoned) 10saper: Introduce AbuseFilterUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92252 (owner: 10saper) [18:21:47] ^d: hmmm - that is pretty much what we do with pages. $type->addDocuments( array( some document ) ); [18:22:07] <^d> Yeah I pretty much copied that bit from what we did before. [18:22:34] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [18:23:46] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase, fix for uncaught exception in ByPropertyListUnserializer [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92323 (owner: 10Aude) [18:24:39] (03CR) 10Hoo man: [C: 031] "Didn't test" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92266 (owner: 10Kaldari) [18:25:07] * Reedy -1s hoo [18:25:48] * hoo merges anyway :D [18:26:24] (03PS2) 10Dan-nl: wikichecks - additional check & cleaned-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 [18:28:14] hey, hoo [18:28:25] hoo: wanna review two really small patches really quickly? [18:28:28] (03CR) 10Adamw: [C: 032 V: 032] Re-enable adyen autoselection [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/92341 (owner: 10Mwalker) [18:28:34] (https://gerrit.wikimedia.org/r/92181 and https://gerrit.wikimedia.org/r/92065 [18:28:43] because i really want those deployed [18:29:14] mh, I actually wanted to buy new in-ears on amazon, but let's have a look :P [18:30:11] (03CR) 10Aaron Schulz: "It also wastes job runner time as implemented though. Maybe jobs types could have a throttle using (count,period) that would make isQueueD" [core] - 10https://gerrit.wikimedia.org/r/91858 (owner: 10Reedy) [18:31:10] (03CR) 10CSteipp: [C: 04-1] "So this alias seems to for a 302 redirect to, which means that the signature fails if the Consumer follows the redirect." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [18:33:00] (03CR) 10CSteipp: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [18:34:55] (03PS3) 10CSteipp: Password Expiration (WIP) [core] - 10https://gerrit.wikimedia.org/r/92037 [18:34:57] (03CR) 10Hoo man: [C: 032] "Style changes really shouldn't happen as part of maintenance changes... looks good." [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [18:35:30] (03CR) 10jenkins-bot: [V: 04-1] Password Expiration (WIP) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [18:36:02] bd808|LUNCH: the wfUseMW message didn't work out so i went ahead and used the one that was in the i18n file, so siebrand's review was needed after all. [18:36:39] is it just me or is gerrit crazy slow? [18:36:43] thanks hoo [18:37:03] (03PS1) 10Bartosz Dziewoński: vector: Restore @body-font-color to black [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92350 [18:37:13] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92350 (owner: 10Bartosz Dziewoński) [18:37:28] MatmaRex: You're welcome... I'm not sure about the echo change, though... I hope you find someone else to merge it [18:37:29] (03PS1) 10Bartosz Dziewoński: vector: Restore @body-font-color to black [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92351 [18:38:02] (03CR) 10Bartosz Dziewoński: "Backport to WMF branch. Minor issue, but pretty silly. (But I'll understand if y'all don't want to deploy just this.)" [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92351 (owner: 10Bartosz Dziewoński) [18:38:10] (03Draft1) 10Aude: Split code for loading revision tags into separate functions [core] - 10https://gerrit.wikimedia.org/r/92348 [18:38:29] hoo: you know, nobody is working on echo anymore [18:38:45] hoo: apart from legoktm :P [18:39:13] (03Merged) 10jenkins-bot: vector: Restore @body-font-color to black [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [18:39:39] MatmaRex: That sounds fun... is the deploy on dewiki still planned? [18:40:26] (03PS1) 10MarkTraceur: position: fixed for multilightbox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92353 [18:40:26] hoo: yeah. apparently that's not a contradiction [18:41:24] (03CR) 10Anomie: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [18:41:30] there also are a few a11y things that could need a fix... [18:41:30] (03CR) 10Anomie: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [18:42:26] (03CR) 10Dan-nl: [C: 031] Added an expiry field to upload stash table [core] - 10https://gerrit.wikimedia.org/r/87607 (owner: 10Aaron Schulz) [18:42:34] a11y is pretty minor compared to some issues with echo, eh [18:42:38] (03CR) 10MarkTraceur: "What?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92040 (owner: 10Shirayuki) [18:42:45] like https://gerrit.wikimedia.org/r/87477 [18:43:03] (03Merged) 10jenkins-bot: vector: Restore @body-font-color to black [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92350 (owner: 10Bartosz Dziewoński) [18:43:03] but apparently if it's deployed, then it's platform's trouble [18:43:14] and foundation resources move elsewhere [18:43:31] Platform inherits abandonware [18:43:33] Lucky us [18:43:40] Dev and run? [18:43:44] Reedy: wanna deploy that for me? ^ [18:43:46] Reedy: Drive-by patches [18:43:56] Reedy: But in return, you get all of our love. :D [18:43:57] (backport to 1.23wmf1 submitted) [18:44:07] https://gerrit.wikimedia.org/r/92351 [18:45:24] I think Benny is supposed to be working on some of the echo issues in his free time. [18:45:29] (03PS18) 10Chad: Update populateRevisionLength maintenance script to populate archive.ar_len [core] - 10https://gerrit.wikimedia.org/r/54111 (owner: 10Reedy) [18:45:38] (03CR) 10Chad: [C: 032] Update populateRevisionLength maintenance script to populate archive.ar_len [core] - 10https://gerrit.wikimedia.org/r/54111 (owner: 10Reedy) [18:45:53] I wonder where we are with schema changes... [18:46:09] I imagine there'll soon be a request to run that ;) [18:46:36] csteipp: "free time" is the keyword here [18:46:43] (03PS2) 10Aude: Split code for loading revision tags into separate functions [core] - 10https://gerrit.wikimedia.org/r/92348 [18:46:48] Non paid? ;) [18:46:49] csteipp: he does review patches in his free time, and i'm thankful for that [18:47:06] but this being free time, it's quite limited [18:47:14] not nearly enough to, like, fix bugs [18:47:25] or review non-trivial changes [18:47:27] If it's not being actively worked on... [18:47:34] Why did it just get deployed nearly everywhere? [18:47:59] *crickets* [18:48:18] * Reedy sighs [18:49:26] (03CR) 10Chad: [C: 032] Allow boolean operators. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92317 (owner: 10Manybubbles) [18:49:52] (03CR) 10Chad: [C: 032] Tests for boolean operators. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92318 (owner: 10Manybubbles) [18:51:48] (03Merged) 10jenkins-bot: Update populateRevisionLength maintenance script to populate archive.ar_len [core] - 10https://gerrit.wikimedia.org/r/54111 (owner: 10Reedy) [18:52:08] wheee [18:55:56] (03Merged) 10jenkins-bot: Allow boolean operators. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92317 (owner: 10Manybubbles) [18:56:07] (03Merged) 10jenkins-bot: Tests for boolean operators. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92318 (owner: 10Manybubbles) [18:59:52] (03CR) 10Jdlrobson: "You need to update the beta file. I'm doing a follow up to correct this. This was indeed an oversight on my part. Good spot." [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [19:00:27] ^ MatmaRex [19:00:43] oh, thanks jdlrobson [19:00:45] (03PS1) 10Jdlrobson: Add correct font color override to beta variables [core] - 10https://gerrit.wikimedia.org/r/92354 [19:00:46] (just catching up with the weekend) [19:01:02] jdlrobson: the beta file had 'inherit' for that value iirc, i assumed it's intended to inherit it from whatever [19:01:30] yeh i think the variables somehow got switched [19:01:40] it was suppose to be inherit in normal version [19:01:48] but black does the same thing so no problem :) [19:02:19] hmm, using inherit could be bad if we set the background color directly (and we do) [19:02:40] since somebody could have e.g. high-contrast settings in their browser, to display white text on black background by default [19:02:45] so we'd end up with white on white [19:02:58] either keep everything default or nothing [19:03:08] (03CR) 10EBernhardson: [C: 04-1] "(14 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu) [19:06:17] MatmaRex: agreed. black makes sense for normal. [19:07:48] (03CR) 10Bartosz Dziewoński: [C: 032] "Tested, works as advertised." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm) [19:08:16] (03Merged) 10jenkins-bot: Check for unescaped language links [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm) [19:08:54] jdlrobson: that new patch https://gerrit.wikimedia.org/r/#/c/92354/ ready to merge? [19:09:13] yup as long as you think the name change makes sense! [19:09:20] ^ MatmaRex [19:09:37] it does for me [19:09:38] (03PS1) 10Manybubbles: Prevent search index updates of nonexistant pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92357 [19:09:42] i'll merge and backport to 22 [19:09:43] (03CR) 10BryanDavis: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [19:09:57] (03CR) 10Bartosz Dziewoński: [C: 032] "Thanks for looking into this." [core] - 10https://gerrit.wikimedia.org/r/92354 (owner: 10Jdlrobson) [19:10:05] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [19:10:08] (03PS1) 10Bartosz Dziewoński: Add correct font color override to beta variables [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92358 [19:10:09] thanks MatmaRex :) [19:10:16] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92358 (owner: 10Bartosz Dziewoński) [19:10:19] (03PS2) 10Manybubbles: Prevent search index updates of nonexistant pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92357 [19:10:43] jdlrobson: you might have to get it backported to wmf branch if you're planning to deploy that in the beta features thing soon-ish [19:10:53] (no idea when y'all are planning that) [19:11:37] MatmaRex: I think it is being deployed on Thursday so it should be okay for the deployment train but I will check. [19:12:15] jdlrobson: Yeah, it's fine. [19:12:34] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [19:12:57] (03PS1) 10Manybubbles: Tests catching some invalid word count causes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92359 [19:13:09] MatmaRex: thanks :D [19:13:14] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The error message should mention "timestamp or signature" or something similar to be clearer." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm) [19:13:35] ugh: my pleasure [19:13:45] jdlrobson: could you look at https://gerrit.wikimedia.org/r/#/c/92181/ , btw? [19:14:49] MatmaRex: sure just clearing my backlog but I'll make sure I take a look when i get a spare moment :) [19:14:52] (i [19:14:56] (i've starred it in the meantime) [19:15:29] (03Merged) 10jenkins-bot: Add correct font color override to beta variables [core] - 10https://gerrit.wikimedia.org/r/92354 (owner: 10Jdlrobson) [19:16:09] (03CR) 10Bartosz Dziewoński: [C: 032] Remove link to Special:MassMessage in log entry description [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90282 (owner: 10Legoktm) [19:16:34] (03PS4) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [19:17:05] (03CR) 10Bartosz Dziewoński: [C: 032] "I'm going to assume that you know what you're doing and that these tests do pass when you have the right environment set up. :D" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [19:17:28] heh [19:17:50] ugh: you have way too many open changesets, you know. [19:17:58] i know >.> [19:18:17] in fact you have more than me, and that's unacceptable. :D [19:18:33] (03CR) 10Dan-nl: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [19:18:46] https://www.mediawiki.org/wiki/Gerrit/Reports/Open_changesets_by_owner <-- I'm winning [19:19:02] lol [19:19:06] https://gerrit.wikimedia.org/r/#/c/92268/ "Actually run all the unit tests" [19:19:07] V-2 [19:19:11] (03Merged) 10jenkins-bot: Remove link to Special:MassMessage in log entry description [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90282 (owner: 10Legoktm) [19:19:13] yeah [19:19:16] the tests are broken [19:19:18] isn't that lovely [19:19:45] i unbroke some of them in a follow up, but there are still like 5 that don't work [19:19:48] (03Merged) 10jenkins-bot: Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [19:19:59] (03Merged) 10jenkins-bot: Add correct font color override to beta variables [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92358 (owner: 10Bartosz Dziewoński) [19:20:06] (03PS5) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [19:20:26] bbl, going to the office :D [19:22:08] anomie, about the extmetadata response format: it has two parts, the file metadata and the hook metadata [19:22:39] the file metadata is pretty much the same as for the already existing metadata api [19:22:51] (03CR) 10Bartosz Dziewoński: "Will this explode existing notifications saved in the database?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [19:22:53] (03CR) 10AndyRussG: "This patch set: refactor some code for checking if a user is an instructor or campus/online ambassador for a course." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [19:23:03] tgr: The existing metadata gets reformatted though [19:23:53] only in very obvious ways [19:24:15] we use property names as array keys, that's true [19:25:14] is there an easy way to sanitize them? like, strip out every non-alphanumeric character? [19:26:28] (03PS6) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [19:26:29] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Move notes to 1.23. Can't this cause duplicate information to be displayed in edge cases?" [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [19:27:24] (03CR) 10AndyRussG: "This patch set: fixed minor detail w/ local variable." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [19:27:30] You'd have to make sure the keys (including the keys in subarrays) don't begin with a number or have other characters not allowed in XML tag names or property names (spaced will get automatically turned to underscores, though). And also not be "*", or "_element". [19:27:57] (03CR) 10Ori.livneh: [C: 04-1] "I don't think the comparison to the ability to specify multiple CSS or JS files in a single module declaration is apt. A module represents" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [19:29:37] Krinkle: should I update the @since tags and release notes for https://gerrit.wikimedia.org/r/#/c/86867/ for 1.23? [19:33:05] ori-l: Hm.. yeah, prolly good idea [19:33:27] Ideally we can iterate the experiment within the .23 cycle and make it stable before 23.0 [19:33:36] should give us enough time. [19:34:41] (03CR) 10Ori.livneh: [C: 031] "I think we're in agreement about the set of issues that this patch leaves outstanding, and I don't think they all need to be resolved up f" [core] - 10https://gerrit.wikimedia.org/r/91617 (owner: 10Krinkle) [19:36:26] * ori-l nods [19:36:33] csteipp: how about https://gerrit.wikimedia.org/r/#/c/91488/ ? [19:37:22] Guest45487: nice nick :) [19:38:57] (03CR) 10CSteipp: [C: 032] "MZ, feel free to ping if you feel strongly about this. But merging it now to keep pushing this ahead." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91488 (owner: 10Aaron Schulz) [19:39:04] (03Merged) 10jenkins-bot: Disabled the feature to change wiki scope for a consumer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91488 (owner: 10Aaron Schulz) [19:42:31] (03PS3) 10Dan-nl: wikichecks - additional check & cleaned-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 [19:46:16] (03PS2) 10Brian Wolff: Work around weird issue with Parser::mStripState. [core] - 10https://gerrit.wikimedia.org/r/92253 [19:46:22] (03CR) 10Bartosz Dziewoński: [C: 031] "Untested, but I approve in general." [core] - 10https://gerrit.wikimedia.org/r/91617 (owner: 10Krinkle) [19:49:02] (03PS32) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [19:52:02] (03PS33) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [19:52:50] (03CR) 10Ori.livneh: "PS32: rebase. PS33: RELEASE-NOTES / @since tags: 1.22 -> 1.23" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [19:58:46] (03PS1) 10BryanDavis: Add clarification to wfUseMW() phpdoc [core] - 10https://gerrit.wikimedia.org/r/92368 [20:00:48] (03PS2) 10BryanDavis: Add clarification to wfUseMW() phpdoc [core] - 10https://gerrit.wikimedia.org/r/92368 [20:04:14] (03CR) 10BryanDavis: [C: 032] wikichecks - additional check & cleaned-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [20:04:45] (03Merged) 10jenkins-bot: wikichecks - additional check & cleaned-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 (owner: 10Dan-nl) [20:09:56] (03CR) 10Bartosz Dziewoński: "Looks sane at a glance, any particular reason?" [core] - 10https://gerrit.wikimedia.org/r/92348 (owner: 10Aude) [20:10:17] (03CR) 10Hashar: "Rebasing an old patch uncarefully leads to mistake :-/" [core] - 10https://gerrit.wikimedia.org/r/92334 (owner: 10Hashar) [20:10:54] (03CR) 10Hashar: "Your code will not escape master!" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [20:11:39] (03CR) 10Deskana: "We should go ahead with this for consistency, and it does make sense to do this now rather than further down the line." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [20:18:23] (03CR) 10CSteipp: [C: 032] "Thanks Deskana. Merging this as is, and I'll send a notice to wikitech-l." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [20:20:59] (03CR) 10EBernhardson: "As long as we are consolidating action definitions, would it make sense to also try to roll Flow\RecentChanges/Formatter::buildActionLinks" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [20:27:19] if possible, looking for a front-end dev who can review, https://gerrit.wikimedia.org/r/#/c/90041/ and +2 it. marktraceur's initial comments are in patch set 2 [20:28:46] (03CR) 10Krinkle: "@Ori: Regarding comment on **89, yes I saw that. But that is about why we use a try/catch around reads/writes in general. That imho doesn'" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:28:51] (03CR) 10Krinkle: [C: 031] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:33:24] (03CR) 10jenkins-bot: [V: 04-1] Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [20:34:24] (03PS4) 10Brian Wolff: Throw an error if calling parser recursively [core] - 10https://gerrit.wikimedia.org/r/92247 [20:41:06] (03CR) 10Aude: "Wikibase needs to de-duplicate code that is here, and having this class with tests added, broken into smaller methods helps." [core] - 10https://gerrit.wikimedia.org/r/92348 (owner: 10Aude) [20:48:43] (03CR) 10EBernhardson: "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92346 (owner: 10Matthias Mullie) [20:56:20] (03CR) 10Legoktm: "It shouldn't since the category isn't stored in the event table." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [21:01:41] hashar: ping ping ping [21:01:55] hashar: jenkins-job tests is failing [21:01:59] IOError: [Errno 2] No such file or directory: 'output/analytics-asana-stats-pep8' [21:02:18] marktraceur, there is an OPW student interested in https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#UploadWizard:_OSM_map_embedding [21:02:30] marktraceur, is there any mentor I could point her to? [21:02:40] marktraceur, or does this project make still sense? [21:02:55] aude might have some interest with it being OSM [21:03:14] * marktraceur wouldn't know [21:03:28] Hm.. looks like the output/ directory didn't exist anymore [21:03:29] weird [21:05:47] Krinkle: jenkins-job ? [21:05:52] Krinkle: like the bot / zuul being dead? [21:07:33] hashar: no, the cli app "jenkins-job" [21:07:35] to generate jobs [21:07:48] after pulling to latest copy of jjb in wikimeida's fork, it failed. [21:07:55] had to re-create the output/ directory manually. [21:08:11] Either it was an empty directory in git and exists no longer, or there is a regression in jjb that deletes or fails to re-create it somehow [21:08:25] it's working now that I re-created it manually before running it [21:10:54] (03PS1) 10Adamw: update CentralNotice submodule [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92419 [21:11:50] (03PS1) 10Adamw: update CentralNotice submodule [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92420 [21:13:05] Krinkle: ah yeah output is not in the gitrepository and JJB does not create it [21:13:16] Krinkle: we might want to create the output dir for us :-] [21:14:10] (03PS3) 10Tim Starling: Improve logging for wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/91115 [21:14:20] (03CR) 10Adamw: [C: 032 V: 032] update CentralNotice submodule [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92419 (owner: 10Adamw) [21:14:30] (03CR) 10Adamw: [C: 032 V: 032] update CentralNotice submodule [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92420 (owner: 10Adamw) [21:15:11] Hey. # modified: extensions/WikimediaMaintenance (modified content) [21:15:22] (03PS34) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [21:15:52] (03CR) 10Ori.livneh: "PS34: Amend comment per Timo's suggestion." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [21:15:57] Krinkle: ^ [21:16:35] marktraceur, do you know Cristian Cantoro? https://www.mediawiki.org/w/index.php?title=Mentorship_programs%2FPossible_projects&diff=682084&oldid=680746 [21:16:49] Sort of yeah [21:17:00] He's involved in the Wikisource projects IIRC [21:17:04] Or, n, [21:17:06] no* [21:17:11] Maybe the WLM projects? [21:17:59] Reedy: u know anything about uncommitted changed to extensions/WikimediaMaintenance on tin? [21:18:12] RoanKattouw / Krinkle: would appreciate your help in seeing that localStorage through. I am trying to be disciplined about this by reminding myself that the performance impact in the wild may not ultimately be good enough to warrant keeping this feature, so I'd really like to start testing it more broadly asap. [21:18:32] marktraceur, ok, thanks [21:18:45] AFAIK I've addressed all issues / requests / etc [21:18:51] (03CR) 10EBernhardson: "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [21:18:52] awight: Most likely me. Which version of mw? [21:19:09] Reedy: no worries. I think this was php-1.22wmf22 [21:19:24] I only needed to sync-dir, but thought u would like to CYA [21:19:31] marktraceur: my apologies for https://bugzilla.wikimedia.org/show_bug.cgi?id=56279, guessing it's not a high priority, but I got it narrowed that far, figured I'd at least write it down. [21:19:32] Fixed [21:19:35] cool. [21:19:46] greg-g: deployment finished. [21:19:55] chrismcmahon: Fair enough, thanks [21:20:39] marktraceur: I thought it was a performance problem in the env, but I made the timeout ridiculously long and that wasn't it. [21:21:49] awight: broke anything? ;) [21:22:22] greg-g: /me runs for the hills. [21:22:23] ori-l: Looks good. Will do one more smoke test later today and then merge it. [21:22:27] greg-g: not that I know of [21:22:54] ori-l: The only thing left worrying me is that it seems hard or impossible to debug localStorage once this has been activited. Seems chrome can't handle the string (at least once Visualeditor has loaded) [21:23:08] from the dev tools panel that is. [21:23:18] (03CR) 10Krinkle: [C: 031] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [21:23:58] (03PS1) 10Reedy: Fixed use of wrong callback array element [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92421 [21:24:20] (03CR) 10Reedy: [C: 032 V: 032] Fixed use of wrong callback array element [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/92421 (owner: 10Reedy) [21:25:21] awight: sweet [21:25:24] Krinkle: I'll write a few helper functions for debugging and bundle them somehow, maybe as a debugScript. would prefer to keep that a separate patch tho [21:25:52] ori-l: this is just localStorage in general, not specific to anything mw [21:26:19] basically whenever I go to Resources > Local storage which renders a table, it freezes that browser tab indefinitely [21:29:08] Krinkle: Oh dear. :-( [21:29:16] Krinkle: Does this mean it won't be +2'ed today? :-( [21:29:59] James_F: Depends, I don't think it is a blocking issue because it only affects the debugger. [21:30:07] * James_F nods. [21:30:14] Krinkle: So it'll hit 1.22? The window's closing… [21:30:19] Krinkle: works for me in 32 (http://i.imgur.com/fxq3gHW.png) [21:30:24] no, it won't. [21:30:46] Krinkle: REL_1.22 is still open… [21:30:53] James_F: yeah, I already changed the release notes to reference 23 [21:30:59] Boo. :-( [21:31:22] that doesnt prevent it from being deployed :-D [21:31:36] it's disabled by default anyway, it's experimental and (to my knowledge) not yet tested enough for to know it has enough performance benefit. [21:32:06] yeah, so initial deployment would be focussed on beta cluster + test / test2 wiki anyhow [21:34:22] (03PS1) 10EBernhardson: Show flow events in watchlist [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92427 [21:35:10] Krinkle: ori-l do you need a +2 on local storage patch ? [21:35:15] hashar: Sure, but not making 1.22 means that most third parties won't be able to use it for another 6 months. [21:35:22] (03PS1) 10PleaseStand: Fixed use of wrong callback array element [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92428 [21:35:50] James_F: well it is a new feature, 1.22.0 is cut by end of november so I am not sure it should be shipped as is [21:36:00] hashar: yeah, but I'd ideally like it to come from Roan or Timo [21:36:08] ori-l: okkk :-] [21:36:11] hashar: It's feature-flagged and off by default. [21:36:20] cause my +2 would be merely useless when it comes to local storage / js hehe [21:36:53] hashar: i can think of other patches, though :P [21:37:02] James_F: ah yeah sorry. Can be cherry picked with a release notes stating to ask for testing [21:37:10] * James_F nods. [21:37:26] i'd be in favor, yeah [21:37:27] ori-l: your json patch, you can forget about it :-]  Will take care of "polishing" it up with anomie [21:37:34] hashar: Can't I do "git diff" from within a jenkins job shell? [21:37:49] ori-l: where polishing is a shortcut for "meet the conservative and bike shedding of mwcore team :D " [21:37:49] hashar: kk! [21:38:26] Krinkle: what I do is that I checkout the last version, generate the conf for it under output-previous/ [21:38:38] hashar: There is no .git ? [21:38:46] Krinkle: then do my hack, generate the resulting conf in output/ and : colordiff -ur output{-previous,}/ [21:39:09] (03PS1) 10EBernhardson: Revert .htaccess permissions back to 0644 [core] - 10https://gerrit.wikimedia.org/r/92429 [21:39:12] hashar: I [21:39:17] hashar: I'm not talking about that anymore [21:39:24] I'm mean inside a job, on gallium in the workspace [21:39:28] (or whatever server) [21:39:31] (03CR) 10MarkAHershberger: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [21:39:58] (03PS6) 10Tim Starling: Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [21:40:04] Krinkle: I have NO clue what you are referring to :-] [21:40:07] (03CR) 10Tim Starling: [C: 032] Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [21:40:39] hashar: There is something I'm working on, it changes files in the repository. I'd like to know if we should be able to do `git diff` or whatever git command. [21:40:41] TimStarling: thank you :) [21:40:51] hashar: Should the workspace have .git? Is it a bug if it is missing? [21:42:05] (03CR) 10Hashar: "More or less similar to https://gerrit.wikimedia.org/r/#/c/64926/ from May 2013. Thanks for the fix :)" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [21:42:15] (03Abandoned) 10Hashar: deprecate autoloading a class with mismatching case. [core] - 10https://gerrit.wikimedia.org/r/64926 (owner: 10Hashar) [21:43:09] Krinkle: it really depends on the job. The git plugin does clone in the workspace directory so you should have a git dir there [21:43:27] I don't see one [21:43:31] Krinkle: but some (such as the mw extensions one), put a snapshot of mediawiki in the workspace and the actual git dir under extension/Foobar [21:43:31] (03CR) 10Reedy: [C: 032] Fixed use of wrong callback array element [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92428 (owner: 10PleaseStand) [21:43:50] hashar: ah, right [21:44:15] Krinkle: what are you trying to do ? :) [21:44:15] OK, found it [21:44:22] hashar: long story, don't bother. [21:44:31] damn [21:44:33] I'm like 10 inception levels deep and this is a breakpoint. [21:44:59] I'll explain when I'm closer to reality, maybe tomorrow :) [21:45:08] ok ok !!! [21:45:22] don't get lost too deep in the matrix [21:48:37] (03Merged) 10jenkins-bot: Minor optimization to the AutoLoader [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [21:49:56] (03CR) 10saper: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/51675 (owner: 10Reedy) [21:50:50] (03Merged) 10jenkins-bot: Fixed use of wrong callback array element [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/92428 (owner: 10PleaseStand) [21:50:53] (03PS4) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [21:52:08] (03CR) 10Adamw: "@hashar: too bad about the duplicated effort, I wish I'd seen your patch. PleaseStand gave some good reasons to continue supporting this " [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [21:55:10] hashar: I can't do sudo -su jenkins-slave? [21:55:17] Can we haz? [21:55:19] (03CR) 10Adamw: "Here's a more fleshed-out example of PSR-4 refactoring:" [core] - 10https://gerrit.wikimedia.org/r/59804 (owner: 10Adamw) [21:55:44] Something is causing my script to fail, being able to run it there quickly in a temp job would safe some time. No worries, read commands only :) [21:55:47] (03CR) 10Hashar: "@adamw the code dupe is fine, just a pity someone else had to find that slow down :-] At least it is fixed now! Thx" [core] - 10https://gerrit.wikimedia.org/r/92170 (owner: 10Adamw) [21:56:00] Krinkle: oh my [21:56:26] I mean manually of course, not inside a job. [21:56:37] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/92328 (owner: 10Hashar) [21:58:09] Hey qgil [21:58:28] You tried to send me an email - what was the original address you trie? [21:58:55] Krinkle: ah you have such rights on lanthanum , but not on gallium :D [21:59:07] qgil, also legoktm is not @wikimedia.org - he is also a volunteer and they do not give us wikimedia.org addresses [22:00:07] hashar: OK [22:01:21] Krinkle: https://gerrit.wikimedia.org/r/92431 would add sudo as jenkins-slave on gallium. I will let you poke ops to get it merged :] [22:02:36] (03PS5) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [22:05:21] (03CR) 10Bartosz Dziewoński: [C: 031] "I'm okay with this, but I'll let someone who knows what they're doing merge." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 (owner: 10Legoktm) [22:06:13] (03PS7) 10CSteipp: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [22:06:41] (03CR) 10CSteipp: [C: 032] "PS7: manual rebase" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [22:07:03] (03Merged) 10jenkins-bot: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [22:08:30] hi Krenair , I was just talking with legoktm [22:08:31] :) [22:08:55] hi [22:09:02] Krenair, silly me I typed @gmail.org manually......... [22:09:32] heh, okay [22:09:45] (03PS1) 10Reedy: Fix populateRevisionLength.php so it's not trying to select revision fields from the archive table (they won't exist!) [core] - 10https://gerrit.wikimedia.org/r/92432 [22:10:44] qgil, I'm not really sure how we could possibly integrate MassMessage with Echo. Echo has been designed with the structure of each message basically coded into the software [22:10:51] (03CR) 10Reedy: "Noting this currently breaks update.php when run" [core] - 10https://gerrit.wikimedia.org/r/92432 (owner: 10Reedy) [22:11:08] MassMessage... seems like you'd want to have the whole thing defined by a user [22:11:09] Copy paste [22:11:11] (03PS1) 10saper: Add ar_id and el_id sequences for PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/92433 [22:11:11] It wouldn't be that difficult [22:11:23] Just take the user input and format it nicely [22:11:42] it would end up just being a public API for people to send echo notifications with [22:11:49] I don't really know what OPW is like [22:12:20] Krenair, legoktm my no-secret agenda is https://www.mediawiki.org/wiki/Extension:Newsletter#Wishlist or equivalent functionality [22:12:47] Krenair, OPW is about one intern workin full time duing almost 4 months [22:13:37] Krenair, and a potential future community contributor, of course [22:15:01] (03CR) 10Chad: [C: 032] Prevent search index updates of nonexistant pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92357 (owner: 10Manybubbles) [22:15:46] (03Merged) 10jenkins-bot: Prevent search index updates of nonexistant pages [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92357 (owner: 10Manybubbles) [22:15:52] Do the mentors have any obligations apart from helping the intern with the task? [22:16:03] qgil, ^ [22:16:25] Krenair, legoktm the idea of Echo integration would be to send Echo notifications "Your newsletter about ABC is available at XYZ"(or something) as opposed to post them in peoples Talk pages [22:16:33] right. [22:17:03] it wouldn't be that difficult to do, it would just require a new backend to be added to MassMessageJob.php [22:17:06] Oh okay, so just a generic "There's a new edition of X waiting for you at Y" message? that should be easy. [22:17:08] (03CR) 10Chad: [C: 032] Tests catching some invalid word count causes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92359 (owner: 10Manybubbles) [22:17:12] (03Merged) 10jenkins-bot: Tests catching some invalid word count causes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92359 (owner: 10Manybubbles) [22:17:19] Krenair, mentors are responsible of assessing the proposals related with their projects, accept or no the interns, and once they are accepted give them support. That's it. [22:17:58] I don't think this would take 4 months. [22:18:26] Krenair, legoktm mentors must attend an initial meeting, they gt sporadic questions from me as org admin, and what matters is to keep regular contact with the intern, as a team member of sorts [22:18:40] mentors must attend an initial meeting? [22:18:52] IRC meeting or conference call [22:18:57] oh, okay. [22:19:16] the scope of work is about 2 weeks of an experienced contributor. [22:19:33] Krenair, see https://www.mediawiki.org/wiki/Mentorship_programs/Lessons_learned [22:19:51] Basically you need to add onboarding, testing, bugfixing & documentation [22:19:53] yeah, this wouldn't take an experienced contributor 2 weeks I don't think [22:20:02] what is "this"? [22:20:33] managing multiple newsletters? UI to create newsletters, archives... [22:20:34] this task [22:21:09] only discussing and agreeing the exact scope and implementation would take some time [22:21:10] The task you suggested in your email. [22:21:49] ok, this is because I have no idea and you are the experts. :) This is also why I pointed to the Wishlist in the email. [22:22:46] Krenair, legoktm note also that usually one mentors has a primery role and the other one is there for support and complementary skills [22:23:18] it works better than with just one mentor in most cases. This is why I'm proposing a project like this to both of you. [22:23:22] ok [22:24:18] (03CR) 10saper: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/54111 (owner: 10Reedy) [22:24:31] Think about it. I'm happy answering any questions legoktm Krenair [22:26:44] ^d: what were those two commits again? [22:27:09] <^d> https://gerrit.wikimedia.org/r/#/c/91879/ - easy css thing [22:27:29] Reedy: ^^ ? [22:27:30] <^d> https://gerrit.wikimedia.org/r/#/c/84743/ - swapping JSON for JSON_SINGLE [22:29:34] (03CR) 10MarkTraceur: [C: 04-1] Compatibility filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [22:32:08] (03PS2) 10PleaseStand: Add ar_id and el_id sequences for PostgreSQL [core] - 10https://gerrit.wikimedia.org/r/92433 (owner: 10saper) [22:32:46] (03CR) 10MarkTraceur: "Jon and I put our heads together briefly and also figured out that it should probably link to the skins section of preferences to let the " [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [22:32:52] (03PS1) 10Werdna: Flow: Fix bug where URL was not updated in address bar when permalink icon was clicked [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92437 [22:32:54] Do the needful [22:33:21] (03PS1) 10MarkTraceur: Load thumbnails, use loading image in core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92438 [22:34:02] (03PS1) 10Jdlrobson: Rename the typography beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92439 [22:34:03] (03PS1) 10Jdlrobson: Add skin requirements to experiment [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92440 [22:34:17] (03CR) 10Jdlrobson: [C: 032] Rename the typography beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92439 (owner: 10Jdlrobson) [22:34:24] (03CR) 10Jdlrobson: [V: 032] Rename the typography beta feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/92439 (owner: 10Jdlrobson) [22:35:07] (03PS2) 10MarkTraceur: Load thumbnails, use loading image in core [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92438 [22:36:25] (03PS1) 10Bsitu: Suppressed agent name should be hidden in API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 [22:36:41] allo allo [22:37:02] (03PS5) 10Chad: General code cleanup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91119 [22:37:03] (03PS3) 10Chad: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 [22:37:16] Allo, salut, cintiero un...haiduc [22:37:22] (03PS2) 10Bsitu: Suppressed agent name should be hidden in API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 [22:37:30] Numa numa iei, numa numa numa iei [22:38:07] * marktraceur not as good at that language as he thought [22:40:49] saper: I'd committed the fix for that 15 minutes before you commented aobut it being broken ;) [22:45:09] (03CR) 10Chad: "Would be nice to land this one." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91119 (owner: 10Chad) [22:45:36] (03CR) 10Krinkle: "Beware that preferences are account bound, whereas javascript is browser bound. Meaning, one user can use multiple browsers. I haven't loo" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [22:48:11] (03CR) 10Krinkle: "It seems it is only for the messages, not the pref label/value itself. Nevermind then :)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [22:48:21] (03PS1) 10EBernhardson: Spacing between consecutive collapsed topic cards [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92442 [22:48:58] (03PS1) 10saper: Really populate ar_len this time [core] - 10https://gerrit.wikimedia.org/r/92443 [22:49:34] (03Abandoned) 10Jdlrobson: Allow ResourceLoaderSchemaModules to contain more than one module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [22:50:33] (03PS2) 10saper: Really populate ar_len this time [core] - 10https://gerrit.wikimedia.org/r/92443 [22:50:35] (03CR) 10Reedy: [C: 04-2] "I'd already done this half an hour ago... https://gerrit.wikimedia.org/r/#/c/92432/" [core] - 10https://gerrit.wikimedia.org/r/92443 (owner: 10saper) [22:50:43] (03CR) 10MarkTraceur: "Oh, right - and the other issue is that we don't check the requirements during the session - if you uncheck VE's base, then try to check V" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [22:51:39] (03CR) 10saper: "Fix proposed in I18fab8012b9d59adde637607931c7a5ea6adf2a1" [core] - 10https://gerrit.wikimedia.org/r/54111 (owner: 10Reedy) [22:52:01] saper: Again, I'm half an hour ahead of you [22:52:11] (03CR) 10Legoktm: [C: 04-1] "The user id is still exposed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/92441 (owner: 10Bsitu) [22:52:13] Uploaded Oct 28, 2013 10:09 PM [22:53:54] Reedy: sorry, looks like git fetch is too slow to me [22:54:21] still not in my git fetch [22:55:23] Because it's not merged [22:55:58] (03PS1) 10MarkTraceur: Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 [22:56:19] ah, right [22:56:35] Your commit is scarily similar to mine though ;) [22:56:36] wonder which implementation is better :):):):) [22:56:55] Reedy: should resolve to the same sha1, shouldn't it? [22:57:05] <^d> Reedy: saper's been eavesdropping on your keyboard ;-) [22:57:19] * saper was eavesdropping on his update.php :( [22:57:46] (03PS2) 10MarkTraceur: Measure sitename clicks too [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92445 [22:58:24] (03CR) 10saper: [C: 031] "I am saper and I approve this change." [core] - 10https://gerrit.wikimedia.org/r/92432 (owner: 10Reedy) [22:58:36] Heh. [22:58:58] "Paid for by the Committee to Re-Elect saper's change into mediawiki/core [22:58:59] (03PS1) 10Krinkle: mw-install-sqlite: Fix double slash [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92446 [22:59:11] (03CR) 10Krinkle: [C: 032] mw-install-sqlite: Fix double slash [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92446 (owner: 10Krinkle) [22:59:14] (03Merged) 10jenkins-bot: mw-install-sqlite: Fix double slash [integration/jenkins] - 10https://gerrit.wikimedia.org/r/92446 (owner: 10Krinkle) [22:59:45] whatever, my update.php worked [23:00:27] and now I forgot what was the original bug I wanted to fix :) [23:01:10] (03PS1) 10Chad: Don't mention Solr since we don't use it [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/92447 [23:02:05] PleaseStand: thanks [23:02:21] (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91892 (owner: 10EBernhardson) [23:02:46] saper: https://bugzilla.wikimedia.org/show_bug.cgi?id=54407 obvs [23:03:12] (03CR) 10Chad: [C: 032] Fix populateRevisionLength.php so it's not trying to select revision fields from the archive table (they won't exist!) [core] - 10https://gerrit.wikimedia.org/r/92432 (owner: 10Reedy) [23:05:11] (03Abandoned) 10Chad: Add new hook ParserBeforePreprocess [core] - 10https://gerrit.wikimedia.org/r/89013 (owner: 10Chad) [23:06:37] we do have mysql update.php tests, don't why? [23:06:41] don't we? [23:06:44] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91892 (owner: 10EBernhardson) [23:07:00] <^d> saper: Tests for updater-related code? [23:07:03] <^d> Nope. [23:08:20] I thought there was jenkins-something (a smoke test) [23:08:28] (03Merged) 10jenkins-bot: Fix populateRevisionLength.php so it's not trying to select revision fields from the archive table (they won't exist!) [core] - 10https://gerrit.wikimedia.org/r/92432 (owner: 10Reedy) [23:09:34] <^d> saper: Well it kind of smoke tests because it does install/upgrade before running tests. [23:09:44] <^d> But it's sqlite, I believe. [23:15:03] (03PS1) 10Ori.livneh: mw.Map: add ability to map over an existing object other than 'window' [core] - 10https://gerrit.wikimedia.org/r/92450 [23:19:00] (03CR) 10Ori.livneh: "*Someone* has to pull the trigger..." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [23:19:23] (03CR) 10jenkins-bot: [V: 04-1] mw.Map: add ability to map over an existing object other than 'window' [core] - 10https://gerrit.wikimedia.org/r/92450 (owner: 10Ori.livneh) [23:20:34] (03PS1) 10MarkTraceur: Increase title font size, bold it [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92451 [23:23:29] (03PS2) 10Ori.livneh: mw.Map: add ability to map over an existing object other than 'window' [core] - 10https://gerrit.wikimedia.org/r/92450 [23:25:40] (03PS1) 10MarkTraceur: Take down the font size in lis, tweak colour [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92453 [23:27:06] (03PS1) 10EBernhardson: Post topic without comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92454 [23:29:49] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [23:30:07] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [23:35:35] (03PS11) 10MarkTraceur: Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [23:35:51] (03CR) 10MarkTraceur: "Rebased" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [23:40:07] (03PS12) 10MarkTraceur: Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [23:40:19] (03CR) 10MarkTraceur: "Now it should actually work" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur)