[00:28:05] (03PS1) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [00:29:49] (03CR) 10jenkins-bot: [V: 04-1] Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [00:53:33] (03PS1) 10Legoktm: Test for Status::hasMessage [core] - 10https://gerrit.wikimedia.org/r/92039 [01:08:43] (03PS1) 10Shirayuki: Capitalize "Lightbox" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92040 [01:09:35] (03CR) 10Mwalker: [C: 032] Test for Status::hasMessage [core] - 10https://gerrit.wikimedia.org/r/92039 (owner: 10Legoktm) [01:12:28] (03Merged) 10jenkins-bot: Test for Status::hasMessage [core] - 10https://gerrit.wikimedia.org/r/92039 (owner: 10Legoktm) [01:15:13] (03PS2) 10CSteipp: Password Expiration [core] - 10https://gerrit.wikimedia.org/r/92037 [01:16:52] (03CR) 10jenkins-bot: [V: 04-1] Password Expiration (WIP) [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [01:27:49] (03PS1) 10Yurik: Logic optimization for wfExpandUrl() [core] - 10https://gerrit.wikimedia.org/r/92041 [02:21:04] (03PS1) 10MarkAHershberger: wrong arg count comparison [tools/release] - 10https://gerrit.wikimedia.org/r/92042 [02:21:05] (03PS1) 10MarkAHershberger: Allow reuse of extension checkout [tools/release] - 10https://gerrit.wikimedia.org/r/92043 [02:21:06] (03PS1) 10MarkAHershberger: Clean up [tools/release] - 10https://gerrit.wikimedia.org/r/92044 [02:21:07] (03PS1) 10MarkAHershberger: remove old fork [tools/release] - 10https://gerrit.wikimedia.org/r/92045 [02:39:45] (03PS1) 10Shirayuki: Capitalize "Lightbox" [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/92046 [02:55:45] (03CR) 10AndyRussG: "(1 comment)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91894 (owner: 10AndyRussG) [04:10:15] (03PS1) 10Shirayuki: Add/remove full-stop [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92049 [04:38:08] (03PS1) 10Legoktm: Allow extensions to override the IP address [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92050 [04:39:24] (03PS1) 10Legoktm: Override the IP for the filter user in CheckUser data [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92051 [04:42:28] (03CR) 10Legoktm: "Example usage of hook: https://gerrit.wikimedia.org/r/#/c/92051/" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92050 (owner: 10Legoktm) [04:49:18] (03CR) 10Legoktm: "User::getGroupName calls wfMessage(key)->text() basically. My code would call BasicFormatter::getMessage, which has a check to ensure that" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [05:25:51] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [05:57:06] (03CR) 10Umherirrender: "(2 comments)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [06:07:03] (03PS6) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [06:23:03] (03CR) 10Ori.livneh: "> Purge modules from cache no longer existent registry (due to the cache being 1 blob, they don't expire)." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [06:23:56] (03PS29) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [06:26:52] (03PS30) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [06:39:58] (03PS31) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [06:40:27] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [06:42:54] (03CR) 10Ori.livneh: "PS29: Rebase. PS30: Replaced mw.loader.store#remove, which would purge stale copies of one specific module, with mw.loader.store#prune, wh" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [06:44:37] (03CR) 10Ori.livneh: "recheck" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [07:01:54] (03PS1) 10Legoktm: Send AbuseFilter hits to CheckUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 [07:06:28] (03CR) 10Ori.livneh: [C: 032] Remove dialogFitWindow and jquery.ui.dialog from mwEmbedUtil [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/88943 (owner: 10Mattflaschen) [07:06:36] (03Merged) 10jenkins-bot: Remove dialogFitWindow and jquery.ui.dialog from mwEmbedUtil [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/88943 (owner: 10Mattflaschen) [07:07:18] (03PS2) 10Legoktm: Send AbuseFilter hits to CheckUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92053 [07:32:24] (03PS1) 10Legoktm: Add HelpPages::getCacheKey to get the memcache key [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/92054 [07:32:48] (03CR) 10Legoktm: [C: 032 V: 032] Add HelpPages::getCacheKey to get the memcache key [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/92054 (owner: 10Legoktm) [08:25:57] (03PS1) 10Kaldari: Make sure AntiSpoof mappings are mapping in the correct direction. For example, 5 should map to S, not the other way around. Also correcting some lowercase to uppercase mappings. There are a lot more mappings in equivset.in that need to be fixed but this [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 [08:27:08] (03PS2) 10Kaldari: Make sure AntiSpoof mappings are mapping in the correct direction. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 [08:29:55] (03CR) 10Gergő Tisza: [C: 031] Fix EL dependency loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92034 (owner: 10MarkTraceur) [08:30:09] (03PS3) 10Kaldari: Make sure AntiSpoof mappings are mapping in the correct direction. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 [08:32:41] (03PS4) 10Kaldari: Make sure AntiSpoof mappings are mapping in the correct direction. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 [08:47:12] Hah! The solution to AbuseFilter bugs is only to move them to another component. [09:35:55] (03CR) 10Helder.wiki: "Maybe it is good idea to fix this related problem as well?" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92057 (owner: 10Kaldari) [09:39:24] (03CR) 10Nikerabbit: "I would sprinkle @since 1.2x in few places." [core] - 10https://gerrit.wikimedia.org/r/92037 (owner: 10CSteipp) [10:18:27] (03CR) 10saper: [C: 04-1] "Hold on, there is opportunity to fix two bugs at once here, need to review carefully" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/92051 (owner: 10Legoktm) [10:18:55] (03CR) 10saper: [C: 04-1] "Hold on, there is opportunity to fix two bugs at once here, need to review carefully" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/92050 (owner: 10Legoktm) [10:39:27] (03PS1) 10Nikerabbit: Fix typo in message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92062 [10:41:14] (03PS1) 10Nikerabbit: Remove period from title for consistency [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92063 [10:42:22] (03CR) 10Amire80: [C: 032] Fix typo in message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92062 (owner: 10Nikerabbit) [10:42:31] (03Merged) 10jenkins-bot: Fix typo in message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92062 (owner: 10Nikerabbit) [11:05:05] (03PS1) 10Bartosz Dziewoński: vector: Restore @body-font-color to black [core] - 10https://gerrit.wikimedia.org/r/92065 [11:05:31] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [11:06:20] (03CR) 10Bartosz Dziewoński: "Please merge quickly, needs backporting to release and WMF branch." [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [11:15:09] (03CR) 10Helder.wiki: "This might be intentional. See the new Agora colors in the image of" [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [11:17:43] (03CR) 10Bartosz Dziewoński: "That patch wasn't supposed to change any styling for non-beta mode. If this was intentional, it should have been mentioned in the commit m" [core] - 10https://gerrit.wikimedia.org/r/92065 (owner: 10Bartosz Dziewoński) [11:37:28] (03Draft8) 10Bartosz Dziewoński: Inline confirmation proof of concept [core] - 10https://gerrit.wikimedia.org/r/90729 [11:57:50] (03CR) 10Helder.wiki: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [12:15:18] (03PS1) 10Bartosz Dziewoński: mediawiki.log: Do not dynamically redefine mw.log.deprecate [core] - 10https://gerrit.wikimedia.org/r/92067 [12:52:44] (03PS9) 10Bartosz Dziewoński: Inline confirmation proof of concept [core] - 10https://gerrit.wikimedia.org/r/90729 [12:55:52] (03CR) 10Tpt: [C: 032] Replace jquery.panZoom by a lighter zoom widget [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90710 (owner: 10Tpt) [12:56:14] (03CR) 10Tpt: [C: 032] "Minor change" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90690 (owner: 10Tpt) [12:56:15] (03Merged) 10jenkins-bot: Replace jquery.panZoom by a lighter zoom widget [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90710 (owner: 10Tpt) [12:56:28] (03Merged) 10jenkins-bot: Support for custom image width [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90690 (owner: 10Tpt) [13:05:21] (03PS2) 10Tpt: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 [14:28:18] (03CR) 10Rtdwivedi: [C: 031] Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 (owner: 10Tpt) [18:58:09] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [18:58:37] (03PS3) 10Bartosz Dziewoński: Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 [18:59:11] (03CR) 10jenkins-bot: [V: 04-1] Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [19:02:41] (03PS4) 10Bartosz Dziewoński: Rename mw.util.wikiGetlink to getUrl [core] - 10https://gerrit.wikimedia.org/r/90569 [19:03:01] (03CR) 10Bartosz Dziewoński: "Rebased on master, moved release notes to 1.23." [core] - 10https://gerrit.wikimedia.org/r/90569 (owner: 10Bartosz Dziewoński) [19:13:59] MatmaRex: what do you think of https://bugzilla.wikimedia.org/show_bug.cgi?id=55764#c4? [19:16:03] helderwiki: +1 :) [19:16:10] helderwiki: rawurlencode is probably copied from php: http://us3.php.net/manual/en/function.rawurlencode.php [19:16:20] do you think it is better to open a new bug? [19:16:28] and wikiUrlencode is probably some variant of that, i guess [19:16:54] http://us3.php.net/manual/en/function.urlencode.php [19:17:02] so these are both phpisms [19:17:17] hmm [19:17:41] so we might want to either keep these awful names, or rename to something more javascripty [19:17:47] let's see what do these functions even do [19:18:09] hmm [19:18:23] they call javascript's encodeURIComponent(), then apply some other replacements [19:19:03] indeed [19:19:21] helderwiki: if you have a good idea of what to do with these babies, i'd suggest just submitting a patch :) [19:29:33] (03CR) 10Ori.livneh: "> This commit uses a cache key by module name. So it overwrites the old data. When 3 updates happen (old > new > revert to old), the third" [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [19:44:34] (03PS10) 10Bartosz Dziewoński: Inline confirmation for rollback links [WIP] [core] - 10https://gerrit.wikimedia.org/r/90729 [20:18:55] (03CR) 10PleaseStand: [C: 04-1] "I haven't yet taken a close look at the code, though I do question whether this should really be part of core MediaWiki. As stated in mess" [core] - 10https://gerrit.wikimedia.org/r/90729 (owner: 10Bartosz Dziewoński) [20:31:48] (03PS1) 10Kaldari: Adding missing equivalents for I, L, O, and S. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92154 [20:36:47] (03PS1) 10Dan-nl: wikichecks - additional check & cleaned-up [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/92155 [20:38:47] (03PS2) 10Kaldari: Adding missing equivalents for I, L, O, and S. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/92154 [20:55:57] (03PS1) 10Rfaulk: add - start/abort section. [sartoris] - 10https://gerrit.wikimedia.org/r/92156 [20:55:58] (03PS1) 10Rfaulk: add - start/revert sction. [sartoris] - 10https://gerrit.wikimedia.org/r/92157 [20:56:17] (03CR) 10Rfaulk: [C: 032 V: 032] add - start/abort section. [sartoris] - 10https://gerrit.wikimedia.org/r/92156 (owner: 10Rfaulk) [20:56:27] (03CR) 10Rfaulk: [C: 032 V: 032] add - start/revert sction. [sartoris] - 10https://gerrit.wikimedia.org/r/92157 (owner: 10Rfaulk) [21:00:27] (03PS1) 10Tpt: Improves EditPage code [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/92158 [21:38:09] (03CR) 10Bartosz Dziewoński: "A bug for this has been filed in the meantime: bug 56202." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/91906 (owner: 10Alex Monk) [21:39:06] (03PS14) 10Bsitu: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [21:39:08] (03PS1) 10Bsitu: Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 [21:42:10] (03CR) 10Bsitu: [C: 04-2] Board History [extensions/Flow] - 10https://gerrit.wikimedia.org/r/92159 (owner: 10Bsitu)