[00:00:22] ^d: it looks like our search indexes got trashed yesterday [00:00:26] quiddity: there is a bug... [00:00:40] <^d> manybubbles: Yes, it would appear so. I think I've fixed most of it. [00:00:45] (03PS7) 10MarkTraceur: Add license to the header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [00:00:50] (03CR) 10jenkins-bot: [V: 04-1] Add license to the header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [00:01:00] Oh for christ's sake [00:01:46] <^d> manybubbles: So, yesterday when you e-mailed me and told me to rebuild, I ran with --rebuild. [00:01:54] <^d> It didn't seem to do much, so I added --forceReindex [00:02:18] ^d: hmmm. can you send me the commands you sent? [00:02:52] maven isn't actually so bad! [00:02:54] <^d> Well it was just updateSearchIndexConfig with --rebuild, then with --rebuild and --forceReindex. [00:03:15] <^d> The latter time, I saw a new error...ES complained about documents already existing. [00:03:31] marktraceur, you need to associate a pleasant tune with the word "rebase". That way it'll induce more of a rueful grin, rather than a cry of agony. ;) [00:03:31] <^d> That's when I knew we were a little wonky and I started trying to clean up. [00:04:14] (03PS2) 10Brian Wolff: Pass language to File::getDescriptionText [core] - 10https://gerrit.wikimedia.org/r/91426 (owner: 10Umherirrender) [00:04:33] (03CR) 10Brian Wolff: [C: 032] Pass language to File::getDescriptionText [core] - 10https://gerrit.wikimedia.org/r/91426 (owner: 10Umherirrender) [00:05:08] reBassssssseeeeeeeee! [00:05:09] ^d: I'm going to clean up and go update some docs. I think you broke it but I think I told you to. [00:05:10] <^d> YuviPanda: Neither is a sinus infection. But you still don't want it :p [00:05:41] so, my fault for making this shit complicated [00:05:47] <^d> If I didn't break it I certainly made it worse. [00:05:52] quiddity: I only have _one more_ to go! [00:05:54] <^d> But I *think* most wikis are fixed now. [00:05:55] But it's totally broken [00:06:02] <^d> enwikisource is still reindexing. [00:06:11] ^d: heh, true. But I did get working checkstyle and test coverage without having to do much, so... [00:06:21] ^d: Is there an obvious reason for a patchset based on origin/master not being mergeable with the "current state of the repository"? [00:06:51] <^d> Link? [00:07:11] https://gerrit.wikimedia.org/r/90267 [00:07:52] marktraceur: jenkins has issues some times. [00:07:58] <^d> marktraceur: Jenkins being stupid. [00:08:03] <^d> recheck [00:08:14] <^d> Gerrit says "Can merge: Yes" which is what matters. [00:09:02] (03CR) 10MarkTraceur: "recheck dummy" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [00:09:09] (03CR) 10MarkTraceur: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 (owner: 10MarkTraceur) [00:09:14] * marktraceur got carried away [00:09:24] marktraceur: just edit the commit message, recheck only does the +1 tests [00:09:46] JENKINS KNOWS BEST! [00:10:12] addshore: where are you generating code coverage stats? [00:10:24] (03Merged) 10jenkins-bot: Pass language to File::getDescriptionText [core] - 10https://gerrit.wikimedia.org/r/91426 (owner: 10Umherirrender) [00:10:37] (03CR) 10Mattflaschen: "This is ready for review." [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/88943 (owner: 10Mattflaschen) [00:10:39] (03CR) 10Aaron Schulz: [C: 032] Triple default $wgMaxShellMemory (raise to 300 MB) [core] - 10https://gerrit.wikimedia.org/r/91501 (owner: 10Bartosz Dziewoński) [00:10:50] I think it only does +1 tests anyway [00:11:06] ^d: a bunch of the wikivoyages are broken and itwiktionary was busted too. I'm not sure why, but they all look like they got autocreated with the crap settings. we should turn off autocreate, it is causing us more trouble then good. [00:11:27] <^d> Grr, I thought I fixed itwiktionary. [00:11:52] <^d> Yeah that autocreate has bitten us two or three times before. [00:13:29] ^d: I'll turn that shit off in the morning. how do I run stuff for labswiki? [00:13:32] it looks "special" [00:13:43] <^d> wikitech.wm.o? [00:14:06] <^d> We have to bug Ryan_Lane. It's not on the cluster (on purpose) [00:14:22] (03CR) 10Aaron Schulz: "How large are Language objects? If this gets called a dozen titles different languages, what happens?" [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [00:14:37] turn what off? [00:14:51] ^d: Elasticsearch has a setting that has screwed us a few times [00:14:55] Ryan_Lane: ^ [00:15:01] what do I need to do to fix it? [00:15:03] I'll do it now [00:15:13] Ryan_Lane: I'll send you the code [00:15:17] oh, wait [00:15:23] I need to deploy something for this? [00:15:29] (03Merged) 10jenkins-bot: Triple default $wgMaxShellMemory (raise to 300 MB) [core] - 10https://gerrit.wikimedia.org/r/91501 (owner: 10Bartosz Dziewoński) [00:15:29] if it's a cherry-pick, no problem :) [00:15:45] <^d> manybubbles had some question about labswiki. [00:16:14] right, this code I'm needing to add is for labswiki? [00:16:33] Ryan_Lane: no, its scripts to run [00:16:38] ah. ok [00:16:42] lay it on me :) [00:16:46] emailed [00:17:18] Ryan_Lane: so, elasticsearch autocreates indexes if you just send it data to index, but, that is stupid because it doesn't make then just how we want them [00:17:41] and, when you've got constant traffic it'll autocreate the index before you can create it manually unless you are careful [00:17:45] YuviPanda: https://integration.wikimedia.org/cover/mediawiki-core/master/php/index.dashboard.html [00:17:49] I think. [00:17:56] or something. [00:17:58] cirrussearch has instructions on how to "be careful" but we don't tend to follow our own advice [00:18:11] heh, nice, legoktm [00:18:18] so, we're going to turn autocreate off on our Elasticsearch cluster [00:18:19] testsearch1001? .eqiad.wmnet? [00:18:21] because it is annoying us [00:18:25] Ryan_Lane: yes [00:18:28] legoktm: the one that jave produces is more... ancient [00:18:33] legoktm: uses frames, for example [00:18:36] for navigation [00:18:37] >.> [00:18:57] yeah [00:19:00] but hey, it works! [00:19:49] <^d> manybubbles: So, the idea I brought up last week about introducing something à la __version__? I think I'm going to do it anyway. We'll just make it a simple integer, and increment it when we make completely breaking changes. [00:20:00] <^d> At the very least, it'll help us detect the problem and warn explicitly. [00:20:24] ^d: are you thinking of putting it in each document? [00:21:02] ^d: I still haven't traced down what was wrong in the first place. It was all _supposed_ to work with new and old config.... [00:21:09] <^d> I thought about introducing a new index that's only for tracking versions. [00:21:56] <^d> A new shared index, that is. At it's simplest, it'd be something like cirrus_versions(index_name, index_version) [00:23:05] ^d: just an index with that name? [00:23:08] makes sense to me [00:23:34] <^d> Yeah, I kinda noodled the idea today while I was playing fix-the-indexes. [00:24:17] <^d> Then we don't waste a ton of space storing a stupid integer that's more or less the same on every document :p [00:27:06] yeah [00:28:10] (03PS1) 10Reedy: Add input callback for tables.sql to prevent indexes being created on the search index table. [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/91811 [00:32:03] manybubbles: done [00:32:17] Ryan_Lane: looks great! [00:32:19] thanks [00:32:20] (03CR) 10MarkTraceur: "(1 comment)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza) [00:32:27] <^d> manybubbles: But yeah, the reason the graphs were bouncing around like that was me trying to recover. When I realized things were hosed I realized the safest recovery for the smaller wikis would be to just blow them away and reindex. [00:32:31] i'll make sure this can't come up agian [00:32:49] ^d: probably the safest thing. [00:34:59] (03CR) 10Legoktm: [C: 04-1] "(12 comments)" [extensions/IssueTracker] - 10https://gerrit.wikimedia.org/r/91565 (owner: 10leucosticte) [00:35:10] (03CR) 10MarkTraceur: "(2 comments)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza) [00:35:34] (03PS2) 10MarkTraceur: Fix border colours in BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91049 (owner: 10Esanders) [00:35:40] (03CR) 10MarkTraceur: [C: 032] Fix border colours in BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91049 (owner: 10Esanders) [00:35:48] (03Merged) 10jenkins-bot: Fix border colours in BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91049 (owner: 10Esanders) [00:37:54] (03CR) 10Legoktm: "(1 comment)" [extensions/IssueTracker] - 10https://gerrit.wikimedia.org/r/91565 (owner: 10leucosticte) [00:40:49] looking at my phone has becoming intimidating now [00:41:10] I have 500 emails waiting to be read or skimmed or blindly archived [00:41:11] <^d> Oh? [00:41:16] <^d> You need filters. [00:41:18] <^d> ;-) [00:41:23] some of it [00:41:29] about 300 of it is from Elasticsearch [00:41:40] about 150 of those only get the subject lines read [00:42:22] I think I need to start muting some conversations instead of archiving them [00:42:23] See, email updates like that should be batchable [00:43:51] marktraceur: I've got github emailing me when they "do things" in their project. gmail "batches" them reasonably well. but, still, I'll filter through 100 conversations in the morning [00:44:02] <^d> Oh man, github is spammy. [00:44:07] <^d> I disabled all that e-mail ages ago. [00:44:13] Yeah, I'm pretty happy to breeze through a big list of email [00:44:26] But I'd muuuch rather glance at a screen that says "Nothing important changed, really" [00:44:37] Automatically [00:44:48] <^d> Only important stuff hits my inbox. [00:44:55] <^d> That's why I filter the hell out of my stuff. [00:45:05] final protected function getScopedPHPBehaviorForOps() { [00:45:05] if ( php_sapi_name() != 'cli' ) { // http://bugs.php.net/bug.php?id=47540 [00:45:20] <^d> If it's unimportant and hits my inbox, I add a new filter :p [00:45:21] Wasn't it decided PHP_SAPI was better/faster? [00:45:21] I actually like getting updates about what they are working on - I can poke them when they do things I don't like [00:45:23] ori-l: ^ [00:45:59] <^d> Reedy: Faster insofar as a function call is always slower than a magic constant. [00:46:25] <^d> But yeah, I think we settled on PHP_SAPI :) [00:47:32] <^d> Heh, I love php.net [00:47:44] <^d> Since namespace were introduced, it would be nice to have a magic constant or function (like get_class()) which would return the class name without the namespaces. [00:47:44] <^d> On windows I used basename(__CLASS__). (LOL) [00:48:12] <^d> The comments have some hidden gems. And a ton of clueless people :) [00:48:28] ^d: they also have a lot of traps, I think [00:48:56] <^d> Hm? [00:50:00] like "helpful" things that are only marginally better/actually worse but you think you did a good job by using the thing in the comments. I don't recall a specific example at this point, unfortunately [00:50:17] <^d> Heh, that's what I meant by clueless people. [00:50:39] dangerous, clueless people [00:51:10] <^d> Well, just assume every code snippet you see there isn't going to work. [00:51:22] (03CR) 10Reedy: "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy) [00:51:31] <^d> Then when you find a good one you're presently surprised ;-) [00:51:46] makes ctrl-f an adventure [00:51:57] ^ Couple of comments on our current WMF live hacks.. [00:56:26] <^d> Reedy: For MessageBlobStore, I say just add a config for it. [00:56:30] <^d> Then turn it off on wmf. [01:06:28] (03CR) 10Mwalker: [C: 032] add basic Status unit test [core] - 10https://gerrit.wikimedia.org/r/91783 (owner: 10Addshore) [01:07:11] (03CR) 10Ori.livneh: "The inclusion of string arguments is a hazard, since (as we saw recently with the bug) if the size of the string is large enou" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [01:07:14] (03CR) 10Mwalker: [C: 032] @covers tags for the rest of test files.. [core] - 10https://gerrit.wikimedia.org/r/91672 (owner: 10Addshore) [01:09:47] (03CR) 10Legoktm: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/91783 (owner: 10Addshore) [01:09:58] (03CR) 10Mwalker: [C: 032] @covers tags for more test classes [core] - 10https://gerrit.wikimedia.org/r/91660 (owner: 10Addshore) [01:11:03] (03CR) 10Mwalker: [C: 032] @covers tags for unit tests [core] - 10https://gerrit.wikimedia.org/r/91625 (owner: 10Addshore) [01:11:32] (03CR) 10Ori.livneh: "Incidentally, the fact that I don't think it's worth the trouble doesn't mean nobody else should do it. But by -1ing the patch, you are sa" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [01:11:44] legoktm: ah; damn; I missed those; I'll patch it since I merged it [01:11:48] nah [01:11:48] i got it [01:11:53] uploading a patchset in a sec [01:14:50] the gerrit-patch-uploader is being slow >.> [01:16:34] (03PS1) 10Legoktm: Add some missing :'s [core] - 10https://gerrit.wikimedia.org/r/91815 [01:16:38] mwalker: ^ [01:17:08] (03CR) 10Mwalker: [C: 032] Add some missing :'s [core] - 10https://gerrit.wikimedia.org/r/91815 (owner: 10Legoktm) [01:17:36] <^d> manybubbles: Which wikis are still busted? [01:18:08] ^d: two are still rebuilding for me: bnwiki and cawiki. you are still rebuilding enwikisource [01:18:14] all others are fine now [01:18:31] ^d: my trick: run this: curl localhost:9200/_cluster/state?pretty | less [01:18:33] <^d> Yeah I've only got about 30-40k pages left on ensource. [01:18:48] and then search for this: curl localhost:9200/_cluster/state?pretty | less [01:18:54] no, this: _content" : [01:19:00] like, exactly [01:19:21] if there is a wiki who's index is named _content without anything after it then it was autocreated, thus broken [01:19:30] and in the morning I'm turning off autocreation [01:19:33] I hates it [01:20:21] <^d> I can't think of a reason we'd ever want to autocreate. [01:20:28] <^d> So yeah, I'm definitely +1 on that. [01:21:09] yeah [01:22:52] (03Merged) 10jenkins-bot: Add some missing :'s [core] - 10https://gerrit.wikimedia.org/r/91815 (owner: 10Legoktm) [01:23:01] heh, that took a while [01:23:04] thanks mwalker :) [01:34:59] <^d> manybubbles: Finally done with enwikisource. [01:42:19] ^d: bnwiki too. cawiki will run overnight. I will sleep soon [02:27:39] (03PS1) 10Legoktm: Split user rights changes into their own category [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91817 [02:31:47] (03PS2) 10Legoktm: Log rev_id to EventLogging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90497 [02:32:22] (03CR) 10Legoktm: "Updated the revid and incremented the version by .1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90497 (owner: 10Legoktm) [04:38:56] (03PS2) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [04:44:40] (03CR) 10AndyRussG: "Patch Set 2: fixes an issue with logs, and one with adding article assignments for others if you're not also enrolled in the same course. " [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [05:40:06] (03PS3) 10Ori.livneh: Log rev_id to EventLogging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90497 (owner: 10Legoktm) [05:41:16] (03CR) 10Ori.livneh: [C: 032] Update to latest revision of Echo schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90497 (owner: 10Legoktm) [05:41:18] (03PS2) 10Dan-nl: registering namespace with Extension_default_namespaces [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91818 [05:41:23] (03Merged) 10jenkins-bot: Update to latest revision of Echo schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90497 (owner: 10Legoktm) [05:41:57] ori-l: so how does it not break the echo dashboards on labs? [05:42:06] and thanks :) [05:43:17] the analytics team is sharp, i'm sure they'll figure something out [05:43:38] :D [05:43:53] like having their query join the two tables, say [05:43:59] or populating the newer table with older data [05:44:15] or not querying immutable historic data repeatedly to derive the same figures [05:44:30] lots of options :) [05:47:28] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [05:47:51] (03PS9) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [05:47:53] (03CR) 10jenkins-bot: [V: 04-1] Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [05:48:12] :/ [05:49:12] (03PS10) 10Legoktm: Add API module to send MassMessages [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 [05:53:58] (03PS8) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [06:03:15] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 (owner: 10Legoktm) [06:03:17] (03PS9) 10Legoktm: Add tests for API module [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87416 [06:14:49] (03PS1) 10Aaron Schulz: Fixed use of wrong callback array element [core] - 10https://gerrit.wikimedia.org/r/91819 [06:24:16] (03CR) 10Nikerabbit: "In the past I've seen lots of out of memory errors caused by creating lots of language objects for different languages. It seems to be cau" [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [06:41:10] (03PS1) 10Rfaulk: fix - spacing. [sartoris] - 10https://gerrit.wikimedia.org/r/91820 [06:41:36] (03CR) 10Rfaulk: [C: 032 V: 032] fix - spacing. [sartoris] - 10https://gerrit.wikimedia.org/r/91820 (owner: 10Rfaulk) [07:09:14] (03PS1) 10Odder: (bug 54464) Fix URL appearing on Special:Version [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/91821 [07:19:32] (03PS3) 10TTO: Format protection_expiry timestamp in ISO format for API results [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 [07:19:46] (03PS4) 10TTO: Format protection_expiry timestamp in ISO format for API results [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 [08:28:12] (03PS1) 10Rfaulk: add - basic start/sync usage. [sartoris] - 10https://gerrit.wikimedia.org/r/91825 [08:28:34] (03CR) 10Rfaulk: [C: 032 V: 032] add - basic start/sync usage. [sartoris] - 10https://gerrit.wikimedia.org/r/91825 (owner: 10Rfaulk) [08:34:53] morning [08:35:26] hi hashar [08:37:37] (03PS1) 10Ebrahim: Preventing joining cursive script character across HTML elements [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/91828 [08:39:59] (03CR) 10Ebrahim: "For fixing cursive character joining. It has no cleaner way and this approach is used before https://gerrit.wikimedia.org/r/#/c/84216/" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/91828 (owner: 10Ebrahim) [08:46:22] (03CR) 10Amire80: [C: 031] Preventing joining cursive script character across HTML elements [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/91828 (owner: 10Ebrahim) [08:57:21] (03CR) 10Nikerabbit: [C: 032] Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 (owner: 10Siebrand) [09:00:30] (03Merged) 10jenkins-bot: Use i18n instead of hardcoded brackets and spaces [core] - 10https://gerrit.wikimedia.org/r/90892 (owner: 10Siebrand) [09:09:55] (03CR) 10Hashar: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [09:12:09] hashar: you merged them all :D [09:12:32] addshore: not really, I think other people +2ed your @covers as well [09:13:04] ori-l: if you are still around, get to bed before receiving my Gerrit review email (don't read it!!! sleep!) [09:13:06] *goes to check :), Yesterday we went from 1.58 to 3.48 line coverage! :P [09:13:11] \O/ [09:13:21] how can we cover .48 of a line? [09:13:36] hah, this is % ;p and an average :) [09:13:46] 9573/274901 [09:13:59] there is one thing I would love in the coverage reports is that it shows the method visibility [09:14:49] hmmm [09:14:58] why? :) [09:15:06] a static method being uncovered is probably very easy to cover [09:15:19] since (imho) it is usually isolated code [09:15:21] hmm, indeed [09:15:26] and thus a full coverage is easy to achieve [09:16:16] (03PS1) 10Zfilipin: Set up Code Climate for all repositories that have Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/91830 [09:16:16] might not be supported though [09:16:18] (03CR) 10Addshore: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91783 (owner: 10Addshore) [09:17:47] hashar: looking [09:18:25] (03PS2) 10Zfilipin: Set up Code Climate for all repositories that have Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/91830 [09:19:11] (03CR) 10Amire80: [C: 032] Set up Code Climate for all repositories that have Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/91830 (owner: 10Zfilipin) [09:19:13] (03Merged) 10jenkins-bot: Set up Code Climate for all repositories that have Ruby code [selenium] - 10https://gerrit.wikimedia.org/r/91830 (owner: 10Zfilipin) [09:20:15] hashar: http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/66454/ [09:22:49] (03CR) 10Addshore: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91783 (owner: 10Addshore) [09:23:24] ori-l: yeah I hate it [09:24:35] ori-l: in this case the -1 is really to unbold the change, there is no real problem with the patch beside the refactoring proposal. I might end up doing it in a different patch and rebase your on top of it, thus clearing the -1 :-] [09:24:46] ori-l: that being said, you really want to sleep :] [09:25:03] i'm waiting for k-rinkle [09:25:13] i can't waittttttttttt to enable localStorage for RL on the beta cluster!! [09:25:16] * ori-l jumps around. [09:25:20] ahh [09:25:38] be bold and enable it using a feature switch in some -labs.php ? [09:25:52] yeah, there is a feature switch [09:26:00] i was hoping to do so, is that ok? [09:26:07] probably [09:26:10] ori-l: you sound very excited [09:26:11] we can always revert it if needed [09:26:25] if you want to play it safe, mail up the qa-l list to let folks informed [09:26:35] yes, was going to do that [09:26:44] the usual issue is the cluster going wild (unlikely to be the case there) and browser tests failing [09:26:46] Nikerabbit: yep! [09:27:01] but if qa-l is notified, the browser tests folks would be aware of it and can then either report bugs or fix their tests [09:27:48] or disable the feature if it's broken [09:27:59] hashar: assuming we/they can differentiate what's newly broken [09:29:13] (03PS7) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [09:29:18] (03CR) 10jenkins-bot: [V: 04-1] WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [09:34:23] (03PS8) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [09:36:33] (03PS1) 10Bartosz Dziewoński: Triple default $wgMaxShellMemory (raise to 300 MB) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91833 [09:37:17] (03CR) 10Bartosz Dziewoński: [C: 032] "Merging backport, +2'd by Aaron in master." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91833 (owner: 10Bartosz Dziewoński) [09:37:47] (03PS1) 10Jshm: Modified codes in Example [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/91834 [09:37:48] (03PS1) 10Jshm: Add some comments. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/91835 [09:37:53] (03Draft1) 10Addshore: Remove undeed methods in tests [core] - 10https://gerrit.wikimedia.org/r/91831 [09:39:14] (03CR) 10Jshm: [C: 031] "looks good" [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/91834 (owner: 10Jshm) [09:41:31] (03Merged) 10jenkins-bot: Triple default $wgMaxShellMemory (raise to 300 MB) [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91833 (owner: 10Bartosz Dziewoński) [09:43:55] (03PS1) 10Zfilipin: Added Code Climate link for mediawiki-selenium gem [selenium] - 10https://gerrit.wikimedia.org/r/91837 [09:48:51] (03CR) 10Ori.livneh: "> In this case, we want to strip the string to a sane length, maybe adding elipse '[...]' to it." [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [09:55:10] (03CR) 10Bartosz Dziewoński: [C: 032] (bug 54464) Fix URL appearing on Special:Version [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/91821 (owner: 10Odder) [09:55:12] (03Merged) 10jenkins-bot: (bug 54464) Fix URL appearing on Special:Version [extensions/UserDailyContribs] - 10https://gerrit.wikimedia.org/r/91821 (owner: 10Odder) [09:55:38] (03CR) 10Amire80: [C: 032] Added Code Climate link for mediawiki-selenium gem [selenium] - 10https://gerrit.wikimedia.org/r/91837 (owner: 10Zfilipin) [09:55:40] (03Merged) 10jenkins-bot: Added Code Climate link for mediawiki-selenium gem [selenium] - 10https://gerrit.wikimedia.org/r/91837 (owner: 10Zfilipin) [09:56:15] (03CR) 10Amire80: [C: 032] Deleted Jenkins jobs that are known to fail [selenium] - 10https://gerrit.wikimedia.org/r/91610 (owner: 10Zfilipin) [09:56:18] (03Merged) 10jenkins-bot: Deleted Jenkins jobs that are known to fail [selenium] - 10https://gerrit.wikimedia.org/r/91610 (owner: 10Zfilipin) [10:21:38] (03PS1) 10Aklapper: Remove obsolete CSS definitions. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91839 [10:41:14] (03CR) 10Aklapper: [C: 031] Delete unused custom bug_activity.css file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91776 (owner: 10Aklapper) [10:41:24] (03CR) 10Aklapper: [C: 031] Remove unused custom help.css file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91777 (owner: 10Aklapper) [10:41:33] (03CR) 10Aklapper: [C: 031] Remove custom skins.tgz file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91780 (owner: 10Aklapper) [10:41:44] (03CR) 10Aklapper: [C: 031] Remove unused custom yui/calendar.css and yui/sprite.png [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91781 (owner: 10Aklapper) [10:42:02] (03CR) 10Aklapper: [C: 031] Delete custom IE-fixes.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91794 (owner: 10Aklapper) [11:15:14] (03CR) 10Nikerabbit: [C: 032] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91819 (owner: 10Aaron Schulz) [11:18:13] (03Merged) 10jenkins-bot: Fixed use of wrong callback array element [core] - 10https://gerrit.wikimedia.org/r/91819 (owner: 10Aaron Schulz) [11:20:05] (03PS2) 10Pastakhov: add support for user functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91589 [11:30:15] (03PS1) 10Krinkle: Add rc.unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91844 [11:30:16] (03PS1) 10Krinkle: Add show=unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91845 [11:47:49] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91844 (owner: 10Krinkle) [11:48:57] (03CR) 10Parent5446: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [12:45:00] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza) [12:46:15] (03PS3) 10Gergő Tisza: Return assessment level [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 [12:46:42] (03CR) 10Gergő Tisza: "Fixed spacing." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza) [12:51:51] (03PS1) 10Zfilipin: Ruby lint should run after every patch set submission for all repositories that contain Ruby code [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91853 [12:57:46] (03PS1) 10Reedy: Replace php_sapi_name() with PHP_SAPI [core] - 10https://gerrit.wikimedia.org/r/91854 [12:59:16] (03PS1) 10Reedy: Replace php_sapi_name() with PHP_SAPI [tools/code-utils] - 10https://gerrit.wikimedia.org/r/91855 [13:00:54] (03PS1) 10Reedy: Replace php_sapi_name() with PHP_SAPI [php/wikidiff] - 10https://gerrit.wikimedia.org/r/91856 [13:01:04] (03CR) 10jenkins-bot: [V: 04-1] Replace php_sapi_name() with PHP_SAPI [php/wikidiff] - 10https://gerrit.wikimedia.org/r/91856 (owner: 10Reedy) [13:02:37] (03PS1) 10Reedy: Replace php_sapi_name() with PHP_SAPI [php/luasandbox] - 10https://gerrit.wikimedia.org/r/91857 [13:05:16] (03PS1) 10Reedy: Add sleep call to HTMLCacheUpdateJob update loop [core] - 10https://gerrit.wikimedia.org/r/91858 [13:14:54] (03PS1) 10Cmcmahon: prevent false failure like https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/338/testReport/ [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91861 [13:15:13] (03CR) 10Parent5446: [C: 032] Replace php_sapi_name() with PHP_SAPI [core] - 10https://gerrit.wikimedia.org/r/91854 (owner: 10Reedy) [13:17:53] (03CR) 10MZMcBride: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 (owner: 10CSteipp) [13:18:37] (03Merged) 10jenkins-bot: Replace php_sapi_name() with PHP_SAPI [core] - 10https://gerrit.wikimedia.org/r/91854 (owner: 10Reedy) [13:19:10] (03PS2) 10Hashar: ruby1.9.3 lint jobs for some repositories [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91853 (owner: 10Zfilipin) [13:19:47] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy) [13:20:11] (03CR) 10Hashar: [C: 032] "Deployed on Jenkins, will add the Zuul triggers." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91853 (owner: 10Zfilipin) [13:20:31] (03Merged) 10jenkins-bot: ruby1.9.3 lint jobs for some repositories [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91853 (owner: 10Zfilipin) [13:25:20] (03PS1) 10Hashar: ruby1.9.3 lint jobs for some repositories [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91862 [13:25:54] (03CR) 10Hashar: "Zuul triggers with same changeid: https://gerrit.wikimedia.org/r/91862" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91853 (owner: 10Zfilipin) [13:26:14] (03CR) 10Hashar: [C: 032] ruby1.9.3 lint jobs for some repositories [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91862 (owner: 10Hashar) [13:26:19] (03Merged) 10jenkins-bot: ruby1.9.3 lint jobs for some repositories [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91862 (owner: 10Hashar) [13:27:25] (03CR) 10Umherirrender: "Yes, User::getGroupName is using the global context (maybe need a seperate param), but the changed code path already used $wgLang, so ther" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [13:30:44] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [13:31:01] (03PS5) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 [13:32:05] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86118 (owner: 10Hashar) [13:39:06] (03PS1) 10Hashar: trigger rubylint for VisualEditor and Wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91867 [13:39:31] (03CR) 10Hashar: [C: 032] trigger rubylint for VisualEditor and Wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91867 (owner: 10Hashar) [13:39:36] (03Merged) 10jenkins-bot: trigger rubylint for VisualEditor and Wikibase [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91867 (owner: 10Hashar) [13:40:12] We have too many repos [13:40:14] arrgh [13:54:36] (03CR) 10Hashar: "Sorry, I should have been more careful :(" [core] - 10https://gerrit.wikimedia.org/r/87510 (owner: 10Siebrand) [13:56:55] (03CR) 10Ragesoss: [C: 031 V: 031] "Tested locally, and it works." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [13:57:16] (03PS9) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [13:58:13] (03CR) 10Hashar: [C: 032] gitmodules: Consistently use .git in the urls [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91647 (owner: 10Krinkle) [13:58:17] (03Merged) 10jenkins-bot: gitmodules: Consistently use .git in the urls [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91647 (owner: 10Krinkle) [13:58:28] (03CR) 10Ragesoss: "The layout issue in the commit message is bug 39595, which this appears to fix." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [14:02:44] (03CR) 10Hashar: "deployed on all slaves. I basically ran:" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91647 (owner: 10Krinkle) [14:05:02] (03CR) 10Hashar: [C: 032] "the ant build file is still valid, no clue how git will update its modules though :/" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91648 (owner: 10Krinkle) [14:05:05] (03Merged) 10jenkins-bot: Remove obsolete testswarm submodule and ant task [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91648 (owner: 10Krinkle) [14:09:08] (03CR) 10Hashar: "Updated." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91648 (owner: 10Krinkle) [14:09:15] (03PS10) 10Matthias Mullie: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [14:11:40] (03CR) 10Manybubbles: [C: 032 V: 032] "This is handled on line 102 of the same file. It is hard set to wfWikiId() which is good enough I think." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91129 (owner: 10Chad) [14:12:39] (03CR) 10Manybubbles: "I'm still not sure wikis should be connecting to eachother's Elasticsearch instances directly." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 (owner: 10Chad) [14:24:01] (03CR) 10Zfilipin: [C: 032] prevent false failure like https://wmf.ci.cloudbees.com/job/browsertests-en.wikipedia.beta.wmflabs.org-windows-internet_explorer_9/338/testR [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91861 (owner: 10Cmcmahon) [14:33:16] (03PS11) 10Matthias Mullie: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [14:36:58] (03CR) 10Chad: "We'll still need to for the cirrus_versions index we talked about yesterday." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 (owner: 10Chad) [14:41:22] (03CR) 10Manybubbles: "Makes sense to me. Should we default name to wfWikiId() if it isn't passed? I don't suppose there is much reason to do so because Cirrus" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 (owner: 10Chad) [14:49:18] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [14:52:30] (03PS2) 10Zfilipin: Moving shared code to mediawiki-selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/87552 [14:54:36] (03CR) 10Zfilipin: "I have rebased the commit and resolved merge conflict. Tested on file at en.wikipedia.beta.wmflabs.org, looks like everything is working." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/87552 (owner: 10Zfilipin) [14:56:27] (03CR) 10Raimond Spekking: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [15:03:09] (03CR) 10Cmcmahon: [C: 032] "use the Ruby gem" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/87552 (owner: 10Zfilipin) [15:03:13] (03Merged) 10jenkins-bot: Moving shared code to mediawiki-selenium Ruby gem [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/87552 (owner: 10Zfilipin) [15:04:41] (03CR) 10BryanDavis: "(1 comment)" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91818 (owner: 10Dan-nl) [15:08:09] (03PS1) 10Anomie: Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] - 10https://gerrit.wikimedia.org/r/91872 [15:09:49] (03CR) 10Matthias Mullie: [C: 032] Preventing joining cursive script character across HTML elements [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/91828 (owner: 10Ebrahim) [15:10:28] (03Merged) 10jenkins-bot: Preventing joining cursive script character across HTML elements [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/91828 (owner: 10Ebrahim) [15:15:06] (03CR) 10Parent5446: [C: 031] Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [15:22:00] (03PS1) 10Gergő Tisza: Improve date display [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 [15:23:15] (03CR) 10Matthias Mullie: [C: 032] (bug 55861) Better error message for invalid params parameter. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91551 (owner: 10Werdna) [15:23:25] (03Merged) 10jenkins-bot: (bug 55861) Better error message for invalid params parameter. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91551 (owner: 10Werdna) [15:23:55] (03PS1) 10Aklapper: Fix one warning and backport upstream hooks in our extremely customized footer.html.tmpl. (Hooks can be used by extensions and I have had the fun of non-working extensions in Wikimedia Bugzilla already before, due to missing hooks.) [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91875 [15:24:11] (03CR) 10Matthias Mullie: [C: 032] Post action permissions for reply and edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91793 (owner: 10EBernhardson) [15:24:19] (03Merged) 10jenkins-bot: Post action permissions for reply and edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91793 (owner: 10EBernhardson) [15:25:50] (03CR) 10Gergő Tisza: "Using browser locale sucks; I looked at the default ResourceLoader modules but didn't find anything appropriate." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 (owner: 10Gergő Tisza) [15:27:07] (03PS2) 10Krinkle: Add rc.unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91844 [15:27:08] (03PS2) 10Krinkle: Add show=unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91845 [15:27:17] (03CR) 10Krinkle: "Rebased on dependent patchset update." [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [15:27:19] (03PS2) 10Aklapper: Fix one warning and backport upstream hooks in our extremely customized footer.html.tmpl. (Hooks can be used by extensions and I have had the fun of non-working extensions in Wikimedia Bugzilla already before, due to missing hooks.) [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91875 [15:27:28] (03CR) 10Krinkle: "Documented unpatrolled property," [core] - 10https://gerrit.wikimedia.org/r/91844 (owner: 10Krinkle) [15:27:50] (03PS3) 10Dan-nl: registering namespace with Extension_default_namespaces [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91818 [15:28:04] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [15:28:08] (03PS3) 10Krinkle: Add show=unpatrolled to the recentchanges API [core] - 10https://gerrit.wikimedia.org/r/91845 [15:28:14] (03CR) 10Krinkle: "Spacing." [core] - 10https://gerrit.wikimedia.org/r/91845 (owner: 10Krinkle) [15:28:49] (03CR) 10Dan-nl: "re-ordered the user list." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91818 (owner: 10Dan-nl) [15:30:01] hey bd808, thanks for the quick reviews [15:30:25] dan-nl: Thank you for making the changes short [15:30:35] :) [15:30:48] (03PS3) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [15:32:17] (03CR) 10BryanDavis: [C: 032] registering namespace with Extension_default_namespaces [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91818 (owner: 10Dan-nl) [15:32:19] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 (owner: 10Gergő Tisza) [15:33:03] marktraceur: btw, you should add a jshintrc file to that repo so that jshint has a chance of passing :) [15:33:29] (03Merged) 10jenkins-bot: registering namespace with Extension_default_namespaces [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91818 (owner: 10Dan-nl) [15:33:36] (03CR) 10Liangent: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [15:36:02] (03CR) 10AndyRussG: "In this patch set: tweaked CSS a bit and added some comments." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 (owner: 10AndyRussG) [15:36:28] (03PS1) 10Aklapper: Backport upstream fix to our custom header.html.tmpl template [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91880 [15:37:07] (03CR) 10Aklapper: [C: 031] "One-liner that we really should get in." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91880 (owner: 10Aklapper) [15:40:44] (03PS12) 10Matthias Mullie: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [15:40:54] (03PS1) 10Cmcmahon: no need to log in twice [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91881 [15:41:22] (03PS2) 10Zfilipin: no need to log in twice [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91881 (owner: 10Cmcmahon) [15:41:47] (03CR) 10Zfilipin: [C: 032] no need to log in twice [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91881 (owner: 10Cmcmahon) [15:42:39] (03PS2) 10Anomie: Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] - 10https://gerrit.wikimedia.org/r/91872 [15:43:31] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [15:45:01] Krinkle: Will do in a bit [15:45:57] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 (owner: 10EBernhardson) [15:46:02] (03CR) 10Krinkle: [C: 031] Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [15:47:33] (03PS13) 10Matthias Mullie: Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [15:50:35] (03PS1) 10Aklapper: 'token' id defined twice on logged-out pages [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91883 [15:50:52] (03CR) 10Aklapper: [C: 031] 'token' id defined twice on logged-out pages [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91883 (owner: 10Aklapper) [15:55:28] (03PS7) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [15:56:40] (03CR) 10Dan-nl: "rebased with master." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [16:16:26] (03CR) 10Nemo bis: "Related: https://gerrit.wikimedia.org/r/#/c/42279/" [core] - 10https://gerrit.wikimedia.org/r/91844 (owner: 10Krinkle) [16:16:43] (03CR) 10Nemo bis: "Can someone rebase?" [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/79168 (owner: 10Brian Wolff) [16:28:07] (03PS5) 10Krinkle: Allow hiding patrol entries from main Special:log [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff) [16:28:13] (03PS6) 10Krinkle: Allow hiding patrol entries from Special:log for all users [core] - 10https://gerrit.wikimedia.org/r/42279 (owner: 10Brian Wolff) [16:36:38] (03CR) 10Gergő Tisza: "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 (owner: 10Gergő Tisza) [16:41:49] (03CR) 10Dzahn: [C: 032] Delete unused custom bug_activity.css file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91776 (owner: 10Aklapper) [16:42:14] (03CR) 10Dzahn: [V: 032] Delete unused custom bug_activity.css file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91776 (owner: 10Aklapper) [16:44:42] (03CR) 10Dzahn: [C: 032 V: 032] Remove unused custom help.css file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91777 (owner: 10Aklapper) [16:45:45] (03CR) 10Dzahn: [C: 032 V: 032] Remove custom skins.tgz file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91780 (owner: 10Aklapper) [16:45:58] (03PS1) 10Umherirrender: Avoid strip markes on transcluded Special:RecentChanges[Linked] [core] - 10https://gerrit.wikimedia.org/r/91889 [16:47:04] (03CR) 10EBernhardson: "Mostly looks good, just 1 bug: Following a post's permalink only does the "highlight" (left side border) if taken to a new page, if its j" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [16:53:59] (03CR) 10EBernhardson: "For the post timestamp linking to history we can see if any history exists by seeing if the post has a previous revision id populated." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [16:55:16] (03PS2) 10Gergő Tisza: Improve date display [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 [16:56:16] (03CR) 10Gergő Tisza: "Fixed spacing, switched to straightforward way of stripping html instead of horribly overcomplicated one" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 (owner: 10Gergő Tisza) [16:56:24] (03CR) 10Parent5446: [C: 031] "Interesting. Didn't know it was capitalized like that either. Haven't tested yet." [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [16:58:51] no hashar [17:09:30] (03CR) 10Liangent: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [17:09:38] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy) [17:11:33] (03PS1) 10EBernhardson: Respect the core 'edit' user permission [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91892 [17:14:09] (03CR) 10Liangent: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/91889 (owner: 10Umherirrender) [17:14:47] @notify hashar [17:14:48] I'll let you know when I see hashar around here [17:14:52] (03CR) 10Dzahn: [C: 032 V: 032] Remove unused custom yui/calendar.css and yui/sprite.png [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91781 (owner: 10Aklapper) [17:17:34] (03CR) 10Dzahn: [C: 032 V: 032] Delete custom IE-fixes.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91794 (owner: 10Aklapper) [17:21:02] (03CR) 10Dzahn: [C: 032 V: 032] Fix InlineHistory's "marked as a duplicate" detection being too eager [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91362 (owner: 10Aklapper) [17:22:37] Krinkle: Did you have a patch around core that dealt with date and time formatting? [17:24:02] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy) [17:24:15] marktraceur: Nope, never got 'round doing that. However the idea was to include momentjs [17:24:19] oH RIGHT [17:24:21] Caps [17:24:34] Krinkle: Would that do e.g. per-user configured date formats? [17:24:37] Or i18n? [17:24:40] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/22466 (owner: 10Reedy) [17:24:47] (03CR) 10Dzahn: [C: 032 V: 032] Backport upstream fix to our custom header.html.tmpl template [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91880 (owner: 10Aklapper) [17:25:01] marktraceur: both. It takes date() like formats (not sure if it's the same syntax, but you get the idea) [17:25:06] as well as timeago, and timefromnow etc. [17:25:11] like "just now" and "3 weeks ago" [17:25:18] and parsing of ISO and UTC formats etc. [17:25:36] yet, it's a pretty concise and cross-browser lib with no dependencies. [17:25:46] You mean Date() I assume [17:26:02] no [17:26:11] js Date() takes no formatting, if only it did. [17:26:13] I mean php date(). [17:26:16] Ah. [17:26:19] 'kay [17:26:28] I mean for output [17:26:37] (03CR) 10Aaron Schulz: [C: 032 V: 032] Add input callback for tables.sql to prevent indexes being created on the search index table. [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/91811 (owner: 10Reedy) [17:26:39] Ah, yeah, makes sense [17:27:00] Which is good, 'cause it means we don't need to export a whole different format for the frontend bits [17:27:04] (03CR) 10Aaron Schulz: "This needs more context" [core] - 10https://gerrit.wikimedia.org/r/91858 (owner: 10Reedy) [17:27:10] e.g. easily get YYYY-MM-DD withotu having to do getYear(), strpad(getMonth() + 1 (!) , 2, '0'), , strpad(getDay()+1, 2, '0') [17:27:17] (03CR) 10Aaron Schulz: [C: 04-1] Add sleep call to HTMLCacheUpdateJob update loop [core] - 10https://gerrit.wikimedia.org/r/91858 (owner: 10Reedy) [17:27:35] With %F or so I guess [17:27:39] Anywho [17:27:50] Krinkle: Multimedia's gonna need something like that soonish [17:28:21] So either we could put it in MMV for now and add it to $thingsWeWantToMergeIntoCore, or we could try to fight this into core now [17:28:50] Preferences? [17:29:00] (03CR) 10Dzahn: [C: 032 V: 032] "https://bugzilla.mozilla.org/show_bug.cgi?id=850126" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91883 (owner: 10Aklapper) [17:29:04] Go for it in core, you have my full support :) [17:31:05] marktraceur: Let me know if you need pointers (at first I'd say, it should probably be similar to jquery-ui's i18n. If they don't have it as separate js files, we could instead do a combination like with languagedatamodule where we generate the js file and include the right json file with i18n for the module) [17:31:50] basically momentjs + wrap( momentjs/.json ) [17:32:32] ah, great, no need for the wrap, they changed from ajax json file loading to .js files [17:32:37] so we can combine them easily [17:32:54] https://github.com/moment/moment/tree/2.3.1/lang [17:36:38] (03PS4) 10Mglaser: make-release: initial tarball test script [tools/release] - 10https://gerrit.wikimedia.org/r/89158 (owner: 10Hashar) [17:37:34] (03PS1) 10AndyRussG: Fix student name in dialogue for removing article [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91894 [17:38:42] (03CR) 10Reedy: "# WM patch: throttle to avoid apache CPU exhaustion -- TS" [core] - 10https://gerrit.wikimedia.org/r/91858 (owner: 10Reedy) [17:39:51] Krinkle: I gotta figure we can do it the way I did mw.Time back in the day, though admittedly I haven't looked at moment yet [17:39:54] * marktraceur looks [17:40:36] Krinkle: localStorage! I'm literally losing sleep over it [17:40:46] help a brother out [17:40:48] ori-l: More sleep than usual? [17:42:09] * ori-l is off for a bit to take his son to his 2-year checkup! :) [17:42:38] D'aw! Good luck! [17:42:48] ori-l: So something I notice everytime (both earlier and with the latest patch version) is that it is virtually impossible to debug localStorage now [17:43:00] the crash isn't from the code [17:43:07] but from clicking "Local storage" in the dev tools [17:43:13] complete freeze [17:43:20] I guess http://momentjs.com/docs/#/i18n/changing-language/ [17:44:22] Yep, not ajax, but the object itself. Perfect for us. So only languages available are available. Since resourceloader modules are fragemented by user language, it will bundle the 1 language it needs. [17:44:27] Yup [17:44:29] just like we do with jqui [17:44:31] perfect [17:45:10] (03PS1) 10Manybubbles: Rename --rebuild to --startOver [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91896 [17:45:43] (03CR) 10Ragesoss: [C: 031 V: 031] "tested, works" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91894 (owner: 10AndyRussG) [17:52:17] Reedy: https://gerrit.wikimedia.org/r/#/c/91344/3/wmf-config/InitialiseSettings.php shouldn't that be using $wmg? [17:52:43] otherwise the ext default overrides the config [17:53:27] Yup, you're right [17:55:20] (03PS2) 10CSteipp: Improve wiki selection [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 [17:57:58] (03CR) 10MarkTraceur: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 (owner: 10Gergő Tisza) [17:59:47] (03PS2) 10Manybubbles: Rename --rebuild to --startOver [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91896 [18:00:20] Krinkle: tgr and I are going to add multiline support to https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fjquery%2Fjquery.autoEllipsis.js - it's maintained by us, locally, right? No upstream? [18:02:35] (03PS1) 10MaxSem: Fix Tidy quietly breaking TOC disabling [core] - 10https://gerrit.wikimedia.org/r/91902 [18:03:27] (03CR) 10Aaron Schulz: [C: 04-1] "(5 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 (owner: 10CSteipp) [18:04:00] csteipp: https://gerrit.wikimedia.org/r/#/c/91500/ [18:04:48] marktraceur: Indeed, developed by Trevor. Also worked on by others incl. Roan and myself. [18:08:08] Cool [18:08:16] * marktraceur sets to work [18:09:00] ori-l: sorry, found another issue [18:09:27] has to do with skin/user variance [18:09:59] so I was trying to see whether it would indeed blow away the cache if you switch languages. That'd be fine, we only want to have 1 cache at a time, and if you switch skins or languages, you simply loose the cache [18:10:14] hm.. [18:11:41] (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [18:11:55] ori-l: okay, this is weird. [18:12:23] so I thought that was an acceptable loss, at the gain of not having the cache grow whenever you switch languages or skin (probably a long-term choice anyway) [18:12:47] so then I thought, does that mean I can nuke your cache xss-style by opening up a useskin or uselang url. [18:12:58] and indeed, it can. But it seems to have a 1-off bug. [18:13:24] when you switch, that page load, it disregards existing cache (as expected), but doesn't put a different cache in place either. [18:13:32] then the next page view it stores it. [18:13:55] what do you think? [18:14:17] (03PS4) 10Aaron Schulz: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 [18:16:01] (03CR) 10Chad: [C: 032] Rename --rebuild to --startOver [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91896 (owner: 10Manybubbles) [18:16:05] (03Merged) 10jenkins-bot: Rename --rebuild to --startOver [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91896 (owner: 10Manybubbles) [18:19:11] (03CR) 10Krinkle: [C: 04-1] "Found 2 issues:" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [18:22:53] (03PS1) 10Alex Monk: WIP: Fix Echo email notifications [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/91906 [18:23:58] (03CR) 10Alex Monk: [C: 04-1] "more messages need creating, need qqq docs" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/91906 (owner: 10Alex Monk) [18:29:37] (03CR) 10Krinkle: "Ignore the first of two issues mentioned, I wasn't accounting for the 2.5s delay." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [18:39:20] (03PS3) 10CSteipp: Improve wiki selection [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 [18:39:35] (03CR) 10CSteipp: "(5 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 (owner: 10CSteipp) [18:42:54] (03CR) 10Aklapper: [C: 031] "Applied on boogs.wmflabs.org and footer on index.cgi still works. ;)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91875 (owner: 10Aklapper) [18:45:58] (03PS1) 10Krinkle: mediawiki.js: Handle error better in log() and move out of mw.loader [core] - 10https://gerrit.wikimedia.org/r/91911 [18:46:35] (03CR) 10CSteipp: [C: 031] "Everything looks good, but since this a breaking change for any existing consumers, we will need to be careful about how we roll it out." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [18:47:51] (03CR) 10CSteipp: "Actually, can we also alias MWOAuth -> OAuth for now? I don't want all the app developers to have to update their apps at the exact time t" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [18:48:38] (03CR) 10Krinkle: "* The site module is cached with invalid javascript: "mw.loader.implement("site",,,);"" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [18:49:51] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.js: Handle error better in log() and move out of mw.loader [core] - 10https://gerrit.wikimedia.org/r/91911 (owner: 10Krinkle) [18:51:40] (03PS2) 10Krinkle: mediawiki.js: Handle error better in log() and move out of mw.loader [core] - 10https://gerrit.wikimedia.org/r/91911 [18:53:58] (03PS1) 10Liangent: DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/91943 [18:57:26] (03CR) 10Bartosz Dziewoński: "Related: https://bugzilla.wikimedia.org/show_bug.cgi?id=55989" [core] - 10https://gerrit.wikimedia.org/r/91911 (owner: 10Krinkle) [18:57:49] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91911 (owner: 10Krinkle) [18:58:16] MatmaRex: How is that bug related? This doesn't log anything more or less. It just changes the log method itself. [18:58:40] Krinkle: the fix to that bug touches literally the same lines of code :) [18:58:48] brb [18:59:01] (03PS3) 10Krinkle: mediawiki.js: Handle error better in log() and move out of mw.loader [core] - 10https://gerrit.wikimedia.org/r/91911 [18:59:55] sure, but that seems far fetched to make links. John changed this component, so here's a dozen unrelated other things that can be improved in this module :P Enough traffic from bugzilla already. [19:00:13] anyway, thanks. Fixed the \n [19:00:17] yes, yes [19:00:31] seeing the commit message, at first i though you're fixing that [19:00:53] the only reason i didn't submit a patch was that i didn't know how to phrase the error message sanely [19:01:46] As for exceptions from the .ready callback, I disagree. [19:01:57] Those shouldn't be caught at all. And certainly not trigger a potential error callback as well [19:02:07] That violates the core principles of ok/error [19:02:23] Which is a bug on itself. [19:02:35] This is the only part of rl that does that and it shouldn't. [19:02:57] that whole block i pasted in bug comment seemed a little weird to me, but i assumed there were reasons for it [19:03:17] half of the RL architecture seems very damn weird, and most of it has reasons (or so i hope) [19:03:42] i just wanted to add an else { … } to that if ( $.isFunction( job.error ) ) { … } there [19:04:52] (03PS2) 10Bartosz Dziewoński: Fix Tidy quietly breaking TOC disabling [core] - 10https://gerrit.wikimedia.org/r/91902 (owner: 10MaxSem) [19:05:46] Hey. Is there a huge backlog with notifications on the Dutch Wikipedia? [19:05:46] (03CR) 10Bartosz Dziewoński: "Rage." [core] - 10https://gerrit.wikimedia.org/r/91902 (owner: 10MaxSem) [19:06:29] I'm getting a notification two minutes ago for a page link two days ago. [19:07:13] reedy@tin:~$ mwscript showJobs.php nlwiki [19:07:13] 18 [19:07:15] Shouldn't be.. [19:08:19] Oh, my fault. I've clicked on the wrong link. [19:08:32] Javascript wasn't working btw. [19:08:57] (03CR) 10Aklapper: [C: 04-1] "Ahem. So we don't fall back to standard CSS." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91792 (owner: 10Aklapper) [19:10:05] rfarrand: I recall that at some point in the past we had a subscription to browser stack -- do we still have that? [19:10:06] (03PS2) 10Liangent: DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/91943 [19:10:20] (03PS5) 10Aaron Schulz: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 [19:10:22] mwalker: yup [19:10:32] (03PS3) 10Liangent: (bug 56184) Allow 3-way merge from arbitary revisions [core] - 10https://gerrit.wikimedia.org/r/91943 [19:10:33] (03PS2) 10Bartosz Dziewoński: Expose iw_trans in siteinfo API interwikimap prop [core] - 10https://gerrit.wikimedia.org/r/91522 [19:11:31] rfarrand: shiny! would you mind sending an email to K4-7131 about that -- we're debugging something currently that would be easier in that enviornment [19:12:11] Oh man. [19:12:18] Do want. [19:12:52] actually though K4-7131; I just found it on crossbrowsertesting too: http://crossbrowsertesting.com/blog/test-local-files-or-web-servers-behind-your-firewall [19:13:44] sjoerddebruin: if you can reproduce the problem with javascript(or there are some console messages or whatever about the failure) a bug report may be usefull [19:13:47] Local Connection, eh? [19:15:11] (03PS1) 10Krinkle: mw.loader: Always log exceptions caught from userland callbacks [core] - 10https://gerrit.wikimedia.org/r/91981 [19:16:52] ebernhardson: Javascript is failing in the last few weeks. I don't know why, more users with the problem... Like watch listing a page. [19:19:39] sjoerddebruin: do you have any links of users describing the problem? Basically its very hard to debug 'doesnt work' without some way to see the issue :) [19:19:58] sjoerddebruin: its ok if they are in dutch, i imagine google translate will be close enough for us to start investigating [19:20:31] * sjoerddebruin is going to dig [19:20:35] sjoerddebruin: thanks [19:21:38] mwalker: pming [19:21:53] legoktm: ping? [19:23:37] (03CR) 10Bartosz Dziewoński: [C: 032] mw.loader: Always log exceptions caught from userland callbacks [core] - 10https://gerrit.wikimedia.org/r/91981 (owner: 10Krinkle) [19:24:16] edsanders|away: Or ask a Dutch person :) [19:24:24] sjoerddebruin: [19:24:30] :P [19:24:39] Oh sjoerddebruin, I assume you are Dutch as well? [19:24:50] (03CR) 10jenkins-bot: [V: 04-1] Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [19:24:50] :\ [19:25:07] Wat denk je zelf? [19:25:29] Inderdaad, mooie Nederlandse naam. [19:25:31] Ik zat potverdorie feedback te geven voor de beta-RTRC. [19:25:42] sjoerddebruin: Zelfde nickname? [19:25:42] (03CR) 10Dzahn: [C: 032 V: 032] Configure Bugzilla's Guided Bug Entry Form [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/74360 (owner: 10Aklapper) [19:25:53] Dacht het wel [19:26:00] Ik onthoudt ze niet allemaal meer, sorry :) Niks persoonlijks. [19:26:15] :( [19:26:16] RTRC is bij uitstek mn meest gebruikte gadget. [19:26:37] :) [19:26:47] Zojuist vandaag 500 actieve gebruikers bereikt. [19:26:51] :D [19:26:57] http://krinkle-tools.grizzdesign.nl/KrinkleSausage.php [19:27:27] en dat is alleen maar gebruikers die de tracking bit aan hebben laten staan en het gebruiken via mw.loader.load in hun gebruikers scripts [19:27:42] Gebruikers die het via de Gadget voorkeuren aanzetten tel ik nog niet eens mee. [19:28:31] ebernhardson: Can't find anything... Damn. [19:29:06] (03PS1) 10Zfilipin: Renamed folder where browser tests live in MobileFrontend repository [selenium] - 10https://gerrit.wikimedia.org/r/91982 [19:29:40] (03PS2) 10Zfilipin: Renamed folder where browser tests live in MobileFrontend repository [selenium] - 10https://gerrit.wikimedia.org/r/91982 [19:30:18] sjoerddebruin: i will still mention it to bsitu(lead echo engineer), we will try and reproduce but can't promise much [19:31:06] (03CR) 10Aklapper: [C: 031] "Tested on boogs.wmflabs.org with buglist.cgi and colchange.cgi and everything still looking as expected. +1." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91839 (owner: 10Aklapper) [19:32:02] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.js: Handle error better in log() and move out of mw.loader [core] - 10https://gerrit.wikimedia.org/r/91911 (owner: 10Krinkle) [19:32:15] (03CR) 10Aklapper: [C: 04-1] "Same issue as with https://gerrit.wikimedia.org/r/#/c/91792/ - we DO NOT fall back to standard CSS." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91801 (owner: 10Aklapper) [19:33:20] (03PS1) 10Manybubbles: Add comments about Elasticsearch prod config [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91983 [19:33:31] (03CR) 10Dzahn: [C: 032 V: 032] Remove obsolete CSS definitions. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91839 (owner: 10Aklapper) [19:35:35] (03CR) 10Dzahn: [C: 032 V: 032] Fix one warning and backport upstream hooks in our extremely customized footer.html.tmpl. (Hooks can be used by extensions and I have had th [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91875 (owner: 10Aklapper) [19:38:16] (03Merged) 10jenkins-bot: mw.loader: Always log exceptions caught from userland callbacks [core] - 10https://gerrit.wikimedia.org/r/91981 (owner: 10Krinkle) [19:38:19] (03Merged) 10jenkins-bot: mediawiki.js: Handle error better in log() and move out of mw.loader [core] - 10https://gerrit.wikimedia.org/r/91911 (owner: 10Krinkle) [19:40:03] (03CR) 10Bartosz Dziewoński: [C: 032] "And when I said "Rage.", what I actually meant was fuck Tidy with a rake. Sorry about not testing the original patch hard enough. :)" [core] - 10https://gerrit.wikimedia.org/r/91902 (owner: 10MaxSem) [19:40:29] (03PS1) 10Bartosz Dziewoński: Fix Tidy quietly breaking TOC disabling [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91984 [19:40:37] (03CR) 10Bartosz Dziewoński: [C: 032] "Backport." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91984 (owner: 10Bartosz Dziewoński) [19:41:32] Krinkle: want me to backport the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=55989 and dep? [19:41:41] (you set 1.22 milestone) [19:41:56] well, didn't he just choose the perfect moment to disappear [19:44:05] Krinkle|detached: don't run away, I'm amending :P [19:44:13] (03Merged) 10jenkins-bot: Fix Tidy quietly breaking TOC disabling [core] - 10https://gerrit.wikimedia.org/r/91902 (owner: 10MaxSem) [19:44:19] okay then, backporting it [19:44:26] i'm backporting way too much stuff to 1.22, heh. [19:45:02] (03PS1) 10Bartosz Dziewoński: mediawiki.js: Handle error better in log() and move out of mw.loader [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91986 [19:45:29] (03CR) 10Bartosz Dziewoński: [C: 032] "Backporting dependency of the fix for bug 55989, per https://bugzilla.wikimedia.org/show_bug.cgi?id=55989#c2 (milestone=1.22)." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91986 (owner: 10Bartosz Dziewoński) [19:48:11] (03CR) 10Bartosz Dziewoński: [V: 032] "Ain't nobody got time for this." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91986 (owner: 10Bartosz Dziewoński) [19:48:17] (03Merged) 10jenkins-bot: Fix Tidy quietly breaking TOC disabling [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91984 (owner: 10Bartosz Dziewoński) [19:48:49] (03PS1) 10Bartosz Dziewoński: mw.loader: Always log exceptions caught from userland callbacks [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91987 [19:49:11] (03CR) 10Bartosz Dziewoński: [C: 032] "Backporting per https://bugzilla.wikimedia.org/show_bug.cgi?id=55989#c2 (milestone=1.22)." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91987 (owner: 10Bartosz Dziewoński) [19:56:07] YuviPanda: pong [19:56:47] legoktm: Wikidata property values are not constrained other than by type, right? [19:57:02] yes [19:57:08] but [19:57:19] there are some soft constraints imposed by the community via abusefilter [19:57:37] legoktm: right [19:57:42] legoktm: but no hard constraints [19:57:51] mhm [19:58:11] legoktm: okay [19:58:42] (03Merged) 10jenkins-bot: mw.loader: Always log exceptions caught from userland callbacks [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91987 (owner: 10Bartosz Dziewoński) [20:05:08] (03PS1) 10Cmcmahon: wait for the textarea to appear, this fixes occasional flaky failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91989 [20:12:00] (03PS1) 10Cmcmahon: wait for image, this fails sometimes in IE without it [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91992 [20:16:33] (03PS27) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [20:17:16] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:18:46] (03PS28) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [20:20:09] (03CR) 10Ori.livneh: "PS27: exclude modules in 'site' group or modules with partial descriptors. PS28: rebase." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:20:29] Krinkle|detached: ^ [20:21:28] (03PS1) 10EBernhardson: Revert "Revert "Add new recentchanges field rc_source to replace rc_type"" [core] - 10https://gerrit.wikimedia.org/r/91993 [20:21:47] (03CR) 10Ori.livneh: [C: 032] Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [20:22:32] (03CR) 10EBernhardson: [C: 04-1] "Should be -2, schema not yet completed but in pipeline." [core] - 10https://gerrit.wikimedia.org/r/91993 (owner: 10EBernhardson) [20:22:34] (03CR) 10Zfilipin: [C: 032] wait for image, this fails sometimes in IE without it [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91992 (owner: 10Cmcmahon) [20:22:53] (03PS1) 10Cmcmahon: wait for errorbox, this causes flaky IE failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91994 [20:23:00] (03CR) 10Zfilipin: [C: 032] wait for the textarea to appear, this fixes occasional flaky failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91989 (owner: 10Cmcmahon) [20:26:43] (03CR) 10Zfilipin: [C: 032] wait for errorbox, this causes flaky IE failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91994 (owner: 10Cmcmahon) [20:27:02] (03Merged) 10jenkins-bot: Distinguish redactions from the string "REDACTED" in formatRedactedTrace [core] - 10https://gerrit.wikimedia.org/r/91872 (owner: 10Anomie) [20:28:16] (03CR) 10Ori.livneh: "With Brad's change (Ia2a761687), it is possible to tell apart redacted values from the string 'REDACTED'. OK. I'll consolidate the redacti" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [20:30:25] (03PS1) 10Chad: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 [20:30:27] (03CR) 10jenkins-bot: [V: 04-1] Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 (owner: 10Chad) [20:30:37] <^demon|lunch> \o/ [20:30:41] (03PS1) 10Legoktm: Add HTML ID to tag filter input [core] - 10https://gerrit.wikimedia.org/r/91996 [20:32:34] (03CR) 10Legoktm: [C: 032] Add $wgAllowGlobalMessaging to the README [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90865 (owner: 10Legoktm) [20:33:29] (03PS4) 10Chad: General code cleanup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91119 [20:33:30] (03PS2) 10Chad: Implement interwiki searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 [20:33:32] (03Merged) 10jenkins-bot: Add $wgAllowGlobalMessaging to the README [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90865 (owner: 10Legoktm) [20:36:50] <^demon|lunch> manybubbles: I may be totally crazy with 91995 :P [20:37:22] oooooooh [20:37:56] (03CR) 10Bartosz Dziewoński: [C: 032] Add HTML ID to tag filter input [core] - 10https://gerrit.wikimedia.org/r/91996 (owner: 10Legoktm) [20:38:03] (03CR) 10Chad: [C: 04-2] "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91995 (owner: 10Chad) [20:38:46] <^demon|lunch> Nemo_bis: I'm not joking when I say completely untested. Like, all I tested was "does it lint" [20:39:13] <^demon|lunch> :) [20:40:48] (03Merged) 10jenkins-bot: Add HTML ID to tag filter input [core] - 10https://gerrit.wikimedia.org/r/91996 (owner: 10Legoktm) [20:45:38] Aw great... I randomly had a great idea on how to transition MediaWiki into supporting an administrative interface for configuring it. Now I'm stuck with either running with it an wasting another day writing an RFC or wiki page on it. Or actually getting work done. T_T [20:47:39] <^demon|lunch> Dantman: Is it an extension of my config database rfc? [20:47:45] <^demon|lunch> If so, I'd say just help refine that one. [20:47:51] Probably not. [20:48:00] I'll check. [20:48:17] <^demon|lunch> https://www.mediawiki.org/wiki/Requests_for_comment/Configuration_database [20:50:51] Maybe a little maybe a little not... [20:51:40] I had a thought of adding contexts of where the config was defined into the mix. [20:53:38] MatmaRex: is '== true' in Ruby true for anything other than 'true'? [20:54:43] ori-l: no, == is sane [20:55:13] ori-l: (unless the object you're calling it on redefines == to not be sane, but no competent programmer does that) [20:55:22] cool, thanks [20:56:44] <^demon|lunch> Dantman: Yeah, I want to update that RFC to reflect modern reality. [20:56:55] <^demon|lunch> If you think your idea + mine would work well together, I welcome revisions. [20:57:56] * Using the config database would be per-setting opt in. (ie: Nothing uses it till the relevant code starts using it. And not every setting would have that.) [20:59:21] * AaronSchulz has fun reading https://github.com/guzzle/guzzle/issues/349 [20:59:34] * LocalSettings can still set settings. These are set on some local instance rather that globally. Say $config (not sure where it'll be created) with something like maybe $config->set( 'foo', 'bar' ); [20:59:47] <^demon|lunch> Dantman: Well we don't want to break existing globals, right? It's going to take a long time for everyone to upgrade all their extensions :) [20:59:56] Coming up in a bit [21:01:34] (03CR) 10Chad: "I want Cirrus to handle wfWikiId(), not here." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 (owner: 10Chad) [21:02:04] * The $config instance understands it's context making note that everything set on it is set in LocalSettings.php. Likely understanding the __FILE__ path. But more importantly that these settings come from a file the server can't modify (or at least shouldn't). [21:02:05] (03CR) 10Manybubbles: [C: 032 V: 032] Fix ElasticaConnection to not care what wiki we're on [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 (owner: 10Chad) [21:03:05] (03PS6) 10EBernhardson: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [21:03:07] (03CR) 10jenkins-bot: [V: 04-1] Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [21:03:12] (03CR) 10Chad: "This is fine to land as soon as I53056c40 is." [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 (owner: 10Chad) [21:04:04] * For compatibility, or just to continue supporting $wg style configuration these config options can optionally source configs from $wg variables (well global variables, nothing hardcoded about the $wg prefix). [21:04:25] <^demon|lunch> I had mentioned that in the past I believe. [21:06:42] * A config database may exist. Which configuration is sourced from being put into a different context. [21:07:54] * We may also support an interface for this that could let 3rd parties write their own class to source some configs from a different location. eg: Configuring some parts of MW from an existing hosting panel. [21:09:10] * I haven't thought enough about it. But context may be considered when caching of settings is handled. [21:11:33] * The administration interface lists all the formally defined configuration settings no matter where they are configured. [21:13:55] * But makes strong use of context. When something is configured in LocalSettings.php the administration interface will make it uneditable, tell you it's value, and then tell you where it is configured and how to edit it (or kill the configuration there so it'll become editable in the interface). [21:15:49] Sitename: "Test Wiki" ... "This wiki's sitename has been configured in a settings file using $wgSitename. You can edit that setting or erase it from the file to make it editable here." [21:19:03] <^demon|lunch> Dantman: I'm doing step 1 now. [21:19:08] <^demon|lunch> It's easy and we should've done it ages ago. [21:19:16] <^demon|lunch> And doesn't preclude us from cleaning up other things. [21:19:44] (03PS1) 10Chad: Begin exposing SiteConfiguration via site contexts [core] - 10https://gerrit.wikimedia.org/r/92004 [21:20:00] ^demon|lunch: Btw, keep in mind that when I think about configuration interfaces it's in a context where I think of some configuration settings to be to complex for a configuration database and expect them to not be given a configuration setting and instead get a dedicated interface at some point in time. [21:21:10] Namespaces in particular. The hazards of messing with the integer mapping are far to complex to expose to a simple configuration interface. [21:22:02] I'd handle that by doing it as part of moving MW into a namespace registry instead. [21:22:22] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91894 (owner: 10AndyRussG) [21:23:54] ((And there goes the time I had before 3PM to get some work done before deciding whether I would or wouldn't go to today's event)) [21:25:08] (03PS1) 10MarkTraceur: Add lines option to jq.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/92005 [21:25:25] (03PS1) 10MarkTraceur: Truncate a few files with autoEllipsis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 [21:25:36] (03PS7) 10EBernhardson: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [21:25:47] (03PS2) 10MarkTraceur: Add lines option to jq.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/92005 [21:26:24] Krinkle|detached: https://gerrit.wikimedia.org/r/92005 FYI [21:26:32] Maybe CC Trev damn it [21:28:37] On the subject of config DB stuff, please see https://gerrit.wikimedia.org/r/#/c/74678/ which has been waiting for review for 3 months [21:29:27] (03CR) 10EBernhardson: [C: 032] Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [21:29:34] <^d> Krenair: Yeah so I've rethought that and I don't think your way should go in. [21:29:45] (03Merged) 10jenkins-bot: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [21:29:53] ^d, okay, what are we changing [21:29:56] <^d> I think we should go in way smaller increments. [21:30:28] <^d> I think we can reuse most of SiteConfiguration, just cleaning things up. [21:30:36] <^d> And abstracting it so it can load settings from a variety of sources. [21:31:05] <^d> And I'm less convinced of a db table. I'm kinda leaning turning LocalSettings.php into LocalSettings.json ;-) [21:34:32] ^d the code in my change would allow for such a file to be made but only as a key-value thing IIRC [21:36:36] <^d> Well the idea is a key => value store. I'm wondering though if there's not enough overlap with https://www.mediawiki.org/wiki/Requests_for_comment/DataStore for config's storage requirements. [21:40:03] <^d> Krenair: Anyway, I'm mostly unconvinced of the singleton crap I proposed in the RFC and my code that you resurrected. I'd much rather see site configuration instantiated and held by context. [21:40:14] <^d> Hence, https://gerrit.wikimedia.org/r/#/c/92004/ [21:43:36] brion around? [21:44:13] (03PS3) 10MarkTraceur: Add lines option to jq.autoEllipsis [core] - 10https://gerrit.wikimedia.org/r/92005 [21:45:42] (03PS1) 10Aaron Schulz: Performance tweaks for curl_multi [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/92010 [21:47:13] (03PS2) 10Aaron Schulz: Performance tweaks for curl_multi [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/92010 [21:47:58] gwicke: https://gerrit.wikimedia.org/r/#/c/92010/ [21:48:05] that was driving me crazy [21:49:30] (03CR) 10Aaron Schulz: "Local time in testing for 50 tiny files goes from 4.6 => .11 sec. All swift backend tests pass." [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/92010 (owner: 10Aaron Schulz) [21:51:18] (03PS6) 10Aaron Schulz: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 [21:51:20] csteipp: ^ [21:52:07] so many conflicts [21:54:45] hey chrismcmahon [21:54:53] hi YuviPanda [21:55:16] chrismcmahon: so, wikipedia app rewrite kicks off next week, and me and brion have decided that we're going to be doing tests from day 0 [21:55:27] chrismcmahon: have any thoughts on android UI testing frameworks? [21:55:52] chrismcmahon: google just released http://googletesting.blogspot.in/2013/10/espresso-for-android-is-here.html and it looks pretty sweet, so we're thinking of going there [21:56:01] YuviPanda: yep. I think Appium is the future: http://appium.io/ [21:56:41] chrismcmahon: ah, interesting! hadn't heard of that before [21:56:59] YuviPanda: I actually saw the Espresso presentation at GTAC [21:57:09] chrismcmahon: aha! [21:58:19] YuviPanda: I like Appium because it works on a client-server model, where your test is implemented in the W3C standard WebDriver format, but the server works with the internals of the mobile device. So as devices evolve, the client side remains (more or less) stable. [22:00:01] YuviPanda: I am biased because architecturally Appium is very much like Selenium, and was created by the people who maintain Selenium. I think it is a good model, and Se has proved the model. [22:01:36] chrismcmahon: right. looks promising, and I suppose it can be easily run from our jenkins too [22:01:44] (03CR) 10Aaron Schulz: [C: 032] Improve wiki selection [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 (owner: 10CSteipp) [22:01:52] (03Merged) 10jenkins-bot: Improve wiki selection [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 (owner: 10CSteipp) [22:01:59] chrismcmahon: if we do end up using appium, do you think we should stick to the Ruby driver? [22:02:04] YuviPanda: should run nicely in Jenkins, yes [22:03:44] YuviPanda: actually, I'd choose whatever client language driver makes sense. Ruby makes sense for the browser tests because of low barrier to entry and standard test libraries Cucumber/RSpec/watir-webdriver/page-object. Appium is too new to have a 'standard' approach, so I wouldn't care about the client language. [22:04:28] YuviPanda: I would suggest that either Python or Ruby would probably be the best choice. [22:05:21] chrismcmahon: right [22:06:01] chrismcmahon: so the current way we're doing it is, since we're building bottom up, to start by writing the underlying libraries in a TDD fashion, and then go upwards [22:06:04] but I don't really know :-) [22:06:49] chrismcmahon: https://github.com/wikimedia/apps-android-java-mwapi/tree/master/src/test are the first tests I've written in a long long time, and they aren't much yet (but they do provide pretty good coverage for the code) [22:06:58] chrismcmahon: would be nice if you can take a look and tell me if there are 'best practices' as such I'm missing [22:09:12] gwicke: it might be nice to backport that soon if it's ok [22:10:10] (03PS2) 10MarkTraceur: Truncate a few files with autoEllipsis [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92006 [22:11:41] (03CR) 10Bartosz Dziewoński: "Bleh, more lines of code in this awful, awful module…" [core] - 10https://gerrit.wikimedia.org/r/92005 (owner: 10MarkTraceur) [22:12:15] * marktraceur waits for MatmaRex to offer a better solution. :P [22:13:30] YuviPanda: ah, reading Java... the one thing I'd suggest is to understand the "Page Object" design pattern, it applies to any sort of UI testing. in a nutshell, PO says to define the elements in the pages as abstractions in a single page; exercise all the actions on the abstractions of the elements and not the elements themselves; and control the actions in a way that tells you what went wrong when the test fails. [22:14:09] chrismcmahon: right. [22:14:20] YuviPanda: google for "Page Object" might be helpful, or Zeljko or I could talk about it in a hangout or whatever. [22:14:26] i'll google up :) [22:14:30] marktraceur: i was going to say text-overflow, but apparently it doesn't work for multiline [22:14:36] Definitely not [22:14:46] marktraceur: (and apparently it used to work for multiline in opera! http://dev.opera.com/static/dstorey/text/text-overflow.html ) [22:14:53] Whoa, seriously? [22:15:01] text-overflow: -o-ellipsis-lastline [22:15:17] That's a super sexy idea [22:15:23] Too bad it's not in CSS proper [22:29:00] (03CR) 10Chad: [C: 032] Add comments about Elasticsearch prod config [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91983 (owner: 10Manybubbles) [22:29:06] (03Merged) 10jenkins-bot: Add comments about Elasticsearch prod config [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91983 (owner: 10Manybubbles) [22:29:47] (03CR) 10Chad: [C: 032] FormatJson: Remove whitespace from empty arrays and objects [core] - 10https://gerrit.wikimedia.org/r/88651 (owner: 10PleaseStand) [22:32:12] marktraceur: hmmm [22:32:28] marktraceur: there's something called -webkit-line-clamp [22:32:30] marktraceur: http://codepen.io/martinwolf/pen/qlFdp [22:32:53] also http://www.css-101.org/articles/line-clamp/line-clamp_for_non_webkit-based_browsers.php and http://css-tricks.com/line-clampin/ [22:33:14] (03Merged) 10jenkins-bot: FormatJson: Remove whitespace from empty arrays and objects [core] - 10https://gerrit.wikimedia.org/r/88651 (owner: 10PleaseStand) [22:38:36] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91393 (owner: 10Parent5446) [22:40:09] (03CR) 10Chad: [C: 032] Remove unused variable and fix outdated comment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91118 (owner: 10Chad) [22:40:25] (03Merged) 10jenkins-bot: Remove unused variable and fix outdated comment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91118 (owner: 10Chad) [22:44:14] (03PS4) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [22:44:16] (03CR) 10jenkins-bot: [V: 04-1] Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [22:47:09] (03PS7) 10Bartosz Dziewoński: Correctly update wl_notificationtimestamp when viewing old revisions [core] - 10https://gerrit.wikimedia.org/r/84315 [22:47:25] (03CR) 10Bartosz Dziewoński: "Somebody review and merge, pretty-please?" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [22:57:22] (03PS9) 10MarkTraceur: Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [23:01:48] (03CR) 10MarkTraceur: [C: 032] "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 (owner: 10Gergő Tisza) [23:01:52] (03Merged) 10jenkins-bot: Improve date display [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91874 (owner: 10Gergő Tisza) [23:02:27] (03PS10) 10MarkTraceur: Add image's license to the lightbox header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [23:04:23] AaronSchulz: did you test that with latest libcurl? [23:05:25] (03PS5) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [23:09:27] (03CR) 10GWicke: [C: 032] "I did not test this with latest libcurl, but as this does not loop on curl_multi_select === 1 this should be fine." [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/92010 (owner: 10Aaron Schulz) [23:11:20] gwicke: 7.29.0 [23:12:14] AaronSchulz: the curl_multi_select issue starts with 7.32 [23:12:27] Starting with libcurl3 7.32, curl_multi_select often returns -1 immediately, [23:12:28] and continues to do so until curl_multi_exec is called to perform more work. [23:12:41] we used to loop on that, but your patch does not [23:12:46] so not an issue [23:13:16] (03CR) 10Aaron Schulz: [V: 032] Performance tweaks for curl_multi [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/92010 (owner: 10Aaron Schulz) [23:14:15] gwicke: is there a way to update an extension in branch to master without a local checkout? I guess not [23:14:20] * AaronSchulz was getting used to that for core [23:14:46] not that I know of, but that does not mean that there is no way [23:15:07] heh [23:15:18] I'll port your fix to our CurlClient too [23:15:33] we should make it a common library real soon now TM [23:15:56] it's slowing down the swift copy script a lot most likely [23:16:22] broken pipelining mostly, or is it the unnecessary wait? [23:16:41] I'd guess pipelining as the wait is to short for such a slow-down [23:16:46] *too [23:17:12] I'd have to strace around a bit more [23:17:29] well, tcpdump [23:18:32] k [23:18:34] gwicke: you should test it with parsoid to see if it relates to the server too [23:18:47] I doubt it [23:19:17] I was surprised that pipelining is still disabled in most browsers nowadays [23:19:39] except for mobile [23:19:49] spdy will hopefully clean up that mess [23:19:57] aka HTTP2 [23:21:48] (03PS1) 10Aaron Schulz: Added a /grants subpage to give a grant/rights table to Special:OAuth [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/92029 [23:25:24] (03CR) 10devunt: [C: 04-1] Change namespageNames and namespaceAliases in Korean [core] - 10https://gerrit.wikimedia.org/r/84212 (owner: 10Ara) [23:27:30] (03PS1) 10Legoktm: Remove dependency upon BetaFeatures extension [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92030 [23:27:39] marktraceur, Elsie ^ [23:27:46] Hrm [23:27:49] You beat me to it [23:28:40] legoktm: I haven't filed a bug yet! [23:28:46] #tooslow [23:28:51] Wait [23:29:16] legoktm: Why would it matter the load order? The getModules thing almost certainly runs after EL has loaded... [23:29:29] Or does it use the modules hook too and I'm screwed either way? [23:29:40] er [23:30:15] right now if ( isset( $wgResourceModules['ext.eventLogging'] ) ) { is run right when you do the require_once MultimediaViewer [23:30:20] which means if your LS looks like: [23:30:25] require_once MultimediaViewer [23:30:28] require_once EventLogging [23:30:41] that isset call will return false, even though really EventLogging is enabled [23:30:50] Right right [23:31:13] so you just need to defer it to once you know all extensions will be loaded, which you can do in an EF [23:31:35] (03CR) 10devunt: "Many patches and projects that contains hard-coded legacy code will be affected." [core] - 10https://gerrit.wikimedia.org/r/84212 (owner: 10Ara) [23:31:49] 'kay [23:32:28] Oh, I misread the patch. /me durrr [23:32:47] Oh yeah, my patch does something totally different :P [23:39:45] (03PS1) 10Aaron Schulz: Updated SwiftCloudFiles to master [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92033 [23:40:09] (03CR) 10Aaron Schulz: [C: 032 V: 032] Updated SwiftCloudFiles to master [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/92033 (owner: 10Aaron Schulz) [23:40:41] (03PS1) 10MarkTraceur: Fix EL dependency loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92034 [23:41:20] legoktm: Trade review? :D [23:41:26] sure :) [23:42:19] (03CR) 10Legoktm: [C: 04-1] "Extension functions should start with the prefix "ef" or you can just use a closure here." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92034 (owner: 10MarkTraceur) [23:42:25] Booo. [23:43:02] (03PS2) 10MarkTraceur: Fix EL dependency loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92034 [23:43:07] Closures huzzah [23:43:17] * marktraceur frontend dev, obvs [23:43:46] (03CR) 10Legoktm: [C: 031] Fix EL dependency loading [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92034 (owner: 10MarkTraceur) [23:43:51] :D [23:44:04] (03CR) 10MarkTraceur: [C: 032] Remove dependency upon BetaFeatures extension [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92030 (owner: 10Legoktm) [23:44:07] (03Merged) 10jenkins-bot: Remove dependency upon BetaFeatures extension [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/92030 (owner: 10Legoktm) [23:44:12] Oh, can you not merge there? Meh. [23:44:22] I don't have +2 everywhere [23:45:37] I'm going to continue my streak of not self-merging in any Multimedia repos [23:51:35] gwicke: thanks [23:51:39] legoktm for +2! [23:51:46] yus plz [23:51:51] * AaronSchulz sees the difference in prod with eval.php [23:51:57] * marktraceur would love that [23:52:04] legoktm: Do you have it in core? [23:52:11] no [23:52:12] now, where was that requests page [23:52:16] I don't do much core stuff [23:52:17] * marktraceur disappointed [23:52:19] mainly extensions [23:52:22] Well, still [23:55:02] legoktm: If you have any extensions you've worked on that you want +2 on, do ping me about maybe endorsing you (I think the Multimedia ones are too young, but I could be convinced) [23:56:02] well, if you have some time and want to review some code? cuz +2 doesn't help much since i can't self-merge https://gerrit.wikimedia.org/r/#/q/owner:%22Legoktm+%253Clegoktm.wikipedia%2540gmail.com%253E%22+status:open,n,z [23:56:26] and i can review some of your stuff if you add me [23:57:51] * p858snake|l adds legoktm to everything! [23:57:59] :<