[00:01:12] (03PS1) 10Kaldari: Cherrypicking change I8d750d4f82f from master for MobileFrontent [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91536 [00:01:59] DB connection error: No such file or directory (localhost) [00:02:00] hmph [00:02:27] ^d: fwiw, I am on Mavericks for the last few days (installed GM), and homebrew works just fine with XCode 5.0 [00:02:37] <^d> 5.0 or 5.0.1? [00:02:41] 5.0 [00:02:49] <^d> Yeah my homebrew doesn't like 5.0 [00:02:53] ^d: I get a warning everytime I use it asking me to upgrade, but I just ignore it [00:03:09] Warning: Your Xcode (5.0) is outdated [00:03:12] Please install Xcode 5.0.1. [00:03:14] and then keeps going [00:03:18] I just upgraded xcode while I was asleep [00:03:33] <^d> Yeah I couldn't build cmake with xcode 5.0.1 [00:03:39] ah [00:03:43] ^d: for hhvm? [00:03:44] <^d> 5.0 [00:03:45] <^d> I mean [00:03:45] <^d> Yeah [00:03:51] <^d> hhvm is totally borked on 10.9 [00:04:00] right [00:04:13] <^d> https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-OSX-10.9 [00:04:20] <^d> "You can't yet, lots of things are broken :(" [00:04:29] awww [00:04:36] Whoa, they're almost to Mac OS XI [00:04:52] Pronounced "Mack-oss-shee" [00:04:59] nah [00:05:02] okay what the hell is going on here [00:05:05] andrew-macbook:core andrew$ mysql -hlocalhost -e 'show databases;' [00:05:06] works fine [00:05:09] Mac OS 10.23.45? [00:05:10] they'll just end up with OS10.22 [00:05:17] andrew-macbook:core andrew$ php maintenance/sql.php [00:05:18] DB connection error: No such file or directory (localhost) [00:05:38] werdna: Spell it out, do 127.0.01 [00:05:38] broken dns resolution? [00:05:40] .1* [00:05:41] (03CR) 10Kaldari: [C: 032] Cherrypicking change I8d750d4f82f from master for MobileFrontent [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91534 (owner: 10Kaldari) [00:05:43] swap it for the IP [00:05:49] marktraceur: There's no place like not home [00:05:55] (03CR) 10Kaldari: [C: 032] Cherrypicking change I8d750d4f82f from master for MobileFrontent [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91536 (owner: 10Kaldari) [00:06:14] Reedy: hmm, works [00:06:16] but still, wtf [00:06:23] DNS lookups are slow [00:06:26] <^d> Search bugs.php.net [00:06:28] Enjoy your new found wiki speed! [00:06:29] ^d: think you can get to the new repo request on https://www.mediawiki.org/wiki/Git/New_repositories/Requests? just one! [00:06:30] <^d> This is an old thing :) [00:06:34] ^d: and no importing! [00:07:38] <^d> werdna: https://bugs.php.net/bug.php?id=45150 for fun. [00:14:47] (03PS1) 10Aaron Schulz: Only show the log on the management wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91538 [00:16:22] (03PS1) 10Aaron Schulz: Slight tweak to grant list ordering [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91539 [00:18:29] there is probably a good reason why I'm working with my laptop on the ground, face down on a bean bag [00:19:25] werdna: I used to do that. Then CTS hit, and I couldn't hold a toothbrush in my right hand [00:19:29] ori-l, you there? console.table fails in Firefox, but doesn't throw. [00:20:14] werdna: You don't own a hammock? [00:20:18] That's a good reason [00:20:32] (03PS8) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [00:20:32] superm401: really? spagewmf said it worked for him [00:20:40] Reedy: I haven't even built a wardrobe in my new apartment yet [00:20:56] ori-l, I'm running Iceweasel (Firefox) 23 [00:21:07] Can you try Help->Restart with addons disabled? [00:21:18] That will give you just the built-in web inspector (not considered an add-on). [00:21:41] superm401: oh, you mean plain Firefox, not Firebug? Wait, it sets a 'console.table'? [00:21:41] I have a lot of Firefox config, but it still happens for me like that. [00:21:55] what is typeof console.table ? [00:22:01] No, I'm speculating, but I think they decided to be clever and not throw on any console.whatever() call. [00:22:05] >>> typeof console.table; [00:22:06] ori-l: (string) 'undefined' [00:22:40] ori-l, "undefined" in built-in Web Console [00:22:47] yep, confirmed. [00:22:55] * werdna is slightly distracted by bugzilla quips [00:22:56] are there docs for this anywhere? <@^demon> Hahahahaha. You must be new here. [00:23:10] OK, we should add a check, rather than expect an exception to be thrown [00:23:31] werdna: there's one that's not on bugzilla involving ^d and guillom that's probably the funniest ever [00:23:35] werdna: :D [00:23:36] thanks Firefox! [00:23:51] YuviPanda: ? [00:23:57] ori-l, can you also convert it to use jquery.json? [00:24:03] I hit this when trying to test a patch for that. [00:24:04] 05:52 werdna is slightly distracted by bugzilla quips [00:24:15] It's pretty simple, just depend on jquery.json and use $.toJSON instead of JSON.stringify. [00:24:16] YuviPanda: yeah but what is it :) [00:24:16] "slightly" [00:24:44] ori-l, I can submit it separately if you want, though. [00:26:29] >>> var a = 0, b = -0; [a === b, 1/a === 1/b] [00:26:29] PiRSquared: (object) [true, false] [00:26:35] cool [00:27:23] superm401: submit a patch or a bug? [00:27:39] ori-l, okay, I'll submit both. [00:27:43] Do you prefer together or separate? [00:27:45] superm401: I have a patch half-ready [00:27:51] (03CR) 10Jeroen De Dauw: "This is a non-functional change that removes a not needed method." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/69977 (owner: 10Jeroen De Dauw) [00:27:56] >>> navigator.userAgent; [00:27:57] PiRSquared: ReferenceError: navigator is not defined [00:27:58] so just hang on :) [00:28:04] node.js or something? [00:28:14] I wasn't going to file a bug, but can if you prefer. [00:28:59] PiRSquared: Ecmascript [00:29:18] (03PS5) 10Werdna: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 [00:29:25] marktraceur: what is it written in? [00:29:48] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [00:29:53] That, I don't know. Krinkle|detached? Ah, he's away. [00:30:03] either that or he's just sitting at his laptop [00:30:07] wondering what the point of everything is [00:30:11] saying "Man, I just feel so detached" [00:30:23] y'know? [00:30:23] PiRSquared: https://github.com/oftn/oftn-bot node.js apparently [00:40:28] (03PS1) 10Ori.livneh: mediawiki.inspect: use $.toJSON & add workaround for FF oddity [core] - 10https://gerrit.wikimedia.org/r/91543 [00:41:08] What is needed for this to be deployed? https://gerrit.wikimedia.org/r/#/c/7274/ [00:42:00] PiRSquared: Are the comments not clear? [00:42:48] "Use Function.prototype#call to call Firefox's bluff" - Heh [00:42:48] (03PS3) 10Aaron Schulz: Disabled the feature to change wiki scope [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91488 [00:43:06] superm401: :) [00:44:00] TimStarling: way back in August you looked over a patch I submitted for making MediaWiki log exceptions as JSON if a config var is set. IIRC, you were OK with the implementation, but you wanted the ability to log using both current & JSON formats. I finally got around to updating the patch: https://gerrit.wikimedia.org/r/#/c/7274/ [00:44:05] could you take a look? [00:44:20] er, wrong URL. https://gerrit.wikimedia.org/r/#/c/76304/ [00:44:28] ori-l, it could use $.isFunction, but perf doesn't matter that much since it's purely a debugging call. [00:45:23] superm401: yeah. [00:48:13] (03PS2) 10Werdna: Add basic experimental hotkey navigation. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91348 [00:50:47] (03CR) 10Mattflaschen: [C: 032] "Looks good, works in Firefox, including with no addons enabled (showing it's using Web Console with no interference)." [core] - 10https://gerrit.wikimedia.org/r/91543 (owner: 10Ori.livneh) [00:51:55] ori-l: ok [00:52:27] ori-l: What is mediawiki.inspect? [00:53:49] (03Merged) 10jenkins-bot: mediawiki.inspect: use $.toJSON & add workaround for FF oddity [core] - 10https://gerrit.wikimedia.org/r/91543 (owner: 10Ori.livneh) [00:54:34] werdna, interface for displaying information about the loaded ResourceLoader modules. [00:54:41] It helps with performance debugging. [00:54:49] ooh [00:54:49] nice [00:55:11] ori-l: looks fine to me [00:55:19] (03PS10) 10Werdna: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 [00:55:50] I do love indentation [00:55:51] https://gerrit.wikimedia.org/r/#/c/90260/9/modules/moderation/moderation.js [00:55:56] Aaron|home: thanks, feel free to merge if you like [00:56:04] oh, Tim is looking at it [00:56:11] well, thanks for looking either way. [00:57:46] (03CR) 10Aaron Schulz: [C: 031] Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [00:59:22] ori-l: Are you still in the office? [01:08:25] (03PS1) 10MaxSem: Update MobileFrontend to wmf21 tip [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91547 [01:09:10] (03PS1) 10MaxSem: Update MobileFrontend to wmf22 tip [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91548 [01:09:15] kaldari, ^^^ [01:10:18] (03CR) 10Kaldari: [C: 032] Update MobileFrontend to wmf21 tip [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91547 (owner: 10MaxSem) [01:10:30] (03CR) 10Kaldari: [C: 032] Update MobileFrontend to wmf22 tip [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91548 (owner: 10MaxSem) [01:15:34] (03PS1) 10Legoktm: Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 [01:20:39] (03Merged) 10jenkins-bot: Update MobileFrontend to wmf21 tip [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91547 (owner: 10MaxSem) [01:22:14] (03Merged) 10jenkins-bot: Update MobileFrontend to wmf22 tip [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91548 (owner: 10MaxSem) [01:24:32] (03PS1) 10Werdna: (bug 55861) Better error message for invalid params parameter. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91551 [01:27:35] (03CR) 10Legoktm: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91551 (owner: 10Werdna) [01:27:44] what I do now [01:27:47] xD [01:28:15] thaaat's embarrassing [01:28:18] (03PS2) 10Werdna: (bug 55861) Better error message for invalid params parameter. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91551 [01:28:45] (03CR) 10Legoktm: [C: 031] (bug 55861) Better error message for invalid params parameter. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91551 (owner: 10Werdna) [01:28:52] heheh [01:30:14] werdna: somewhat relatedly, i'm not a fan of having one parameter store other parameters. Why couldn't you make the expected values normal API parameters? doing it the current way makes the autogenerated docs somewhat useless, same with ApiSandbox. [01:32:24] RoanKattouw: no, I'm not -- I WFH today [01:34:48] werdna: https://gerrit.wikimedia.org/r/#/c/90260/9/modules/moderation/moderation.js -- no, come on [01:34:51] ori-l: OK cool [01:34:51] that's not cool [01:35:13] ori-l: So we were looking at the Parsoid DOM timing data and I noticed there's a very nasty bug in its implementation that makes the data untrustworthy [01:35:32] So, on ViewPageTarget line 545 [01:35:39] ori-l: ?? [01:35:40] You do this.loading.done( track thingy ); [01:35:58] But, at that point onLoad has already bound to .done(), so it will be executed first [01:36:06] It turns out that onLoad does two things [01:36:10] werdna: the cliffs of despair (indentation) -- but, hang on -- let me see what Roan is pointing at [01:36:13] legoktm: mmm, I'm not 100% a fan either, but I guess I like the ability to have one backend and make the API a shallow way to access that programmatically [01:36:23] 1) It parses the received HTML into a DOM, which can take up to 300ms on large pages [01:36:53] 2) It kicks off the first stage of VE initialization, but ONLY if the code from RL has already arrived, so whether this step happens is actually determined by a race condition [01:37:30] So the time taken by #1 (which is in the 3-300ms range) and by #2 (which is usually a measurable amount, but sometimes zero) is included in the Parsoid DOM timing [01:38:00] werdna: why not have the API code handle it? switch ( $params['actionname'] ) { case 'newpost': $p = array( ... => $params[...] ); etc } [01:38:09] So what I think we should do is this.loading.then( function () { do timing } ).done( ... ) or something [01:38:19] To ensure that the timing executes before any of the other handlers [01:38:30] legoktm: I have no idea what you mean [01:38:36] I had code in Parsoid to log the time it takes it to serialize the DOM [01:38:37] Or maybe it should be this.loading = $.ajax( .... ).then( timing ); , I'm not sure offhad [01:38:44] Trying to figure out where it went; hang on a moment. [01:39:01] werdna: uhh let me type out some less abstract code, one sec. [01:39:23] do you mean build the parameter arrays in the API module? [01:39:31] yes [01:39:32] That ruins the API module's genericity [01:40:26] I mean, if I were to reform it, I'd do it this way: Have the Block objects declare their parameters in a function [01:40:48] then you could pull those parameters including definitions into the API module getParameters() and getParamDescription() calls [01:41:29] and then you could build the arrays in a generic way in the API module [01:42:41] that sounds like a good idea [01:43:03] RoanKattouw: does the deployed version of Parsoid include I1d7fd94f2? [01:43:49] Checking [01:44:14] Yes [01:44:57] Ah, and, in fact, we do get that on more recent events [01:45:11] legoktm: but… patches welcome, I'm working on other things at the moment [01:45:49] werdna: i'll try and send a patch by next week. still getting familiar with the code base [01:45:55] nod [01:45:58] it's a tricky one, hey? [01:46:02] lots of Flow specific conventions [01:46:12] and the storage stuff is pretty abstract [01:46:33] (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [01:47:34] RoanKattouw: I think my initial thinking was that by logging Parsoid duration and subtracting that from the total duration we can determine the time spent receiving data and doing work with it client-side [01:48:06] but we're not subtracting it, and it wouldn't be very helpful anyway to have a figure that conflates network latency with JS work [01:48:38] so yes, I think we should log each discrete stage as a separate interval [01:50:16] RoanKattouw: https://dpaste.de/aUEN/raw/ [01:50:39] that in ms. [01:54:46] I guess it depends what you're hoping to learn from the data. I think there's merit to the perspective of not differentiating between different kinds of waiting, just as the user does not differentiate between different kinds of waiting -- time spent waiting for VE to load is time spent waiting for VE to load. [01:55:18] I think that can help you determine whether you're meeting your user experience targets. [01:55:23] ori-l: Sure, and we should probably measure both the Parsoid load and the total wait [01:55:34] But we shouldn't have a poorly defined metric that changes based on a race condition, is my point [01:55:51] Yeah, that part is unobjectionable [01:57:35] (03CR) 10Mattflaschen: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [01:59:13] RoanKattouw: let me think about it -- I think swapping the order in which the .done() is right, but I'd like the fix to also ensure the total load time is captured [01:59:21] in which the .done() handlers are registered, I mean. [01:59:26] I'd like it to not depend on that, ideally [01:59:32] Hence the .then() suggestion [02:01:04] maybe have a $.Deferred for the whole load process [02:01:18] that receives progress events from the load process [02:01:28] and is resolved at its conclusion [02:01:38] at which point the ve.track call is actually made [02:02:44] i don't want to log multiple events for a single loading of VE, but updating the state of some deferred tracking call from multiple places in VE might be unsavory too [02:03:15] dinner time, but I'll submit a patch tonight. If the .then() suggestion is adequate I'm not opposed to that either, but I want to poke first. [02:03:37] Awesome [02:03:38] Yeah take your time [02:18:15] (03CR) 10Werdna: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [02:28:39] (03CR) 10Ori.livneh: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [02:40:13] (03PS10) 10AlephNull: (bug 43571) Fixing fatal error when duplicating VIEWs in MySQL [core] - 10https://gerrit.wikimedia.org/r/65301 [02:42:58] (03CR) 10AlephNull: "I have addressed the issues present, opting for the slightly more efficient equals operator in place of LIKE in the SQL statement and for " [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [02:43:37] (03CR) 10AlephNull: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [03:17:18] (03CR) 10MZMcBride: "Is there background or context to this commit?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91488 (owner: 10Aaron Schulz) [03:33:58] (03CR) 10MZMcBride: "We should resolve them? I'm not sure what you're asking." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7300 (owner: 10Szymon Świerkosz) [03:37:50] (03PS2) 10Legoktm: Add Special:Thanks as a non-JS fallback [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91549 [03:47:03] (03PS1) 10Legoktm: Remove outdated comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91556 [03:57:22] ori-l, is the RL group your mechanism to avoid storing user-specific modules (it's not a vary)? [04:07:15] superm401: can you rephrase the question? [04:07:36] ori-l, you asked a while back, "Should this vary by user ID?" [04:07:58] I don't see an apparent solution to this except private groups (which as I'll explain is only partial), but I want to make sure I'm not missing anything. [04:08:40] why don't you say what you have in mind? [04:08:59] It seems like private modules are excluded, but user modules are not. [04:11:00] can you give a full scenario? [04:11:50] Let me just test. :) [04:17:18] (03PS1) 10Legoktm: Fix phpdoc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91557 [04:19:34] (03PS1) 10Santhosh: Code formatting fixes [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91558 [04:20:51] (03CR) 10Santhosh: "(1 comment)" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91192 (owner: 10Siebrand) [04:25:08] ori-l: Is there a good way to test that localStorage change, particularly its fallback capability? It makes me feel weird. [04:27:09] Elsie: is there a background or a context to this feeling? [04:27:31] Not really. [04:27:41] superm401: how would you feel about pulling that patch to one of your labs wikis? [04:27:41] It just seems like a big change to the way CSS and JS is delivered. [04:28:03] I'm not worried about newer browsers. [04:28:30] it doesn't run on older browsers [04:28:56] How does it fallback? [04:29:17] ori-l's code for excluding browsers without localStorage is solid and based on existing Modernizr code. [04:29:30] It will be tested throughly before making it onto WMF sites or being in core by default. [04:29:49] thoroughly [04:30:04] I trust the reviewers. :-) [04:30:13] <^d> You mean that the other way around, right? One would hope it would land in core before we pushed it out ;-) [04:30:33] Yeah we were talking about landing it in core real soon now [04:30:34] ^d, there's a gating variable. [04:30:36] That's what I mean. [04:30:52] I've been meaning to merge it every day this week but every time I wake up to Timo having found new issues with it [04:31:04] So the gating variable is for testing? [04:31:12] Once merged we figured we'd put it on testwiki first and see how that goes [04:31:25] It's behind a feature flag so it doesn't do anything by default [04:31:36] * Elsie nods. [04:31:37] Well both testing and review [04:31:50] Elsie: more or less. I wouldn't feel comfortable blessing it for the whole world to use just yet. [04:31:54] We were past patchset 20 when I noticed that it failed to initialize itself with a totally cold localStorage :) [04:32:11] RoanKattouw: that was only the case for one patchset [04:32:15] because up to that point I'd been keeping Ori busy by just reading the code and pointing things out without testing :) [04:32:21] it was the 'fix' I applied immediately beforehand that caused it [04:32:28] Yeah, it must've worked originally [04:32:34] I am trying to understand how it varies on user. [04:32:40] But my point was I didn't start testing it until pretty late [04:32:41] It seems to work, but I don't fully understand why. [04:33:51] <^d> That should be our slogan. [04:34:02] <^d> "MediaWiki: It seems to work, but I don't fully understand why" [04:34:10] haha [04:34:15] superm401: You're right that it doesn't vary on user [04:34:24] superm401: well, because IIRC ResourceLoaderWikiModules (which ResourceLoaderUserModule subclasses) use the timestamp of the last rev ID as the version [04:34:32] It should either do so, or not attempt to cache user-specific code [04:35:18] superm401: so yes, if you and I share the same computer and we each saved our common.js at the exact same second, there's an issue [04:35:42] It seems that only code that would otherwise be fetched over the network is run through the store so for really private stuff it doesn't appear to be an issue [04:35:42] oddly all the other user.* modules have their group set to private [04:35:43] As that's inlined [04:35:53] Well that's because they contain tokens and stuff [04:35:59] i guess with the user module the thought was that it's not really 'private', i.e., any one can look at those pages [04:36:03] The Common.js module has public contents [04:36:24] On some wikis. [04:37:00] it should exclude group => user [04:37:02] ori-l, I think the private ones are all either tokens (clearly private data) or private preferences. [04:37:14] But if user.tokens were exposed as a module through load.php , you could do [04:37:47] Hm, you'd need &only=scripts for that particular code to work [04:38:06] god damn it, i want to hang on to a Roan +1 for 24 full hours :P [04:38:08] But the point is that load.php responses are trivially CSRF-able because they're code. You'd just need to make sure that window.mw.loader.implement exists [04:38:19] ori-l: I'm here, I can re-+1 :) [04:38:52] ok [04:38:53] * ori-l amends [04:39:06] RoanKattouw: btw, haven't tested this yet, but i guess this is what you had in mind? https://dpaste.de/pmFZ/raw/ [04:39:29] excuse the whitespace [04:39:31] Something like that [04:39:36] I don't think you even have to return a value there [04:39:50] The return jqxhr; bit should be unnecessary I believe [04:39:51] yeah, the docs are confusing on this point [04:40:02] i was going to experiment [04:40:09] On editors? [04:40:30] Death to E3. Long live E3. [04:40:49] Yeah the .then() docs are extremely unclear [04:40:51] I still think the E3 jokes are pretty rude [04:41:04] I only learned about .then() last week thanks to sucheta [04:41:15] because they were never actually made within earshot of the people who came up with the name [04:41:35] Her code actually did return a new promise, and I had to read the docs twice before I was confident that that was actually something that was supposed to work [04:42:56] ori-l: I wouldn't use .then() for that last step because that ends up returning yet a different promise, so I'd suggest just using .done( .. ).fail( .. ) there [04:43:02] ori-l: As Shania Twain would say, it was good while it lasted it, but now I'm past it. [04:43:05] Because I'd like this.loading to end up being set to something sane [04:43:38] (03PS7) 10PleaseStand: installer: Run the LESS compiler for screen.less [core] - 10https://gerrit.wikimedia.org/r/89610 [04:44:29] (03PS8) 10PleaseStand: installer: Run the LESS compiler for *.less files [core] - 10https://gerrit.wikimedia.org/r/89610 [04:44:30] * sucheta waves, as she holds her oscar for implementing .then() [04:44:43] hah! :) hi [04:45:01] Oh, I see, user.groups is also a wiki module. [04:45:14] Hi ori-l. [04:45:14] I think maybe it seems to work just because those modules were empty. [04:45:33] if they weren't the versions would vary [04:46:18] but i agree user modules should be excluded [04:46:58] Hehe. ori-l was the one to introduce me to sumanah, when I first entered #mediawiki and was asking questions related to OPW [04:47:03] Time flies. [04:47:07] ori-l, they don't need to be excluded on privacy grounds. [04:47:15] So it's just what you think is best for performance. [04:47:25] they do [04:47:36] For privacy? Which one? [04:47:39] if i thought you might be loading and executing my user scripts [04:47:42] i could plant something malicious [04:47:50] Yeah, I was going to say: [04:48:00] You can't actually let it run the wrong script, but as long as you download the right one later (then run that) it's okay.. [04:48:21] (03CR) 10Catrope: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [04:48:24] btw, the reason I don't want to vary by user ID is -- well, take library computers [04:48:33] Right, it would explode the size. [04:48:36] (03CR) 10Catrope: [C: 031] installer: Run the LESS compiler for *.less files [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [04:48:41] But if one user had a script, and the other was empty, it would need to be evicted. [04:48:46] it wouldn't explode the size; when the cache varies the cache gets nuked [04:49:00] but it would mean that you're constantly populating and purging localStorage [04:49:04] Oh, right. [04:49:07] So that would happen every time you log in or out then [04:49:15] right, don't want that [04:49:21] The only thing it varies on is db name. [04:49:23] hence: exclude 'user' group, but don't vary on user ID [04:49:27] So we should probably just exclude all user-dependent modules? If that's something we can detect [04:49:40] Yeah, we should be able to based on group. [04:49:42] Or it's a bug. [04:49:59] Actually of course it is, because user-specific modules aren't fetchable through the loader [04:50:17] Only 'user' is fetchable from load.php and that one is special-cased in OutputPage.php because it needs a &user=Username query param [04:50:53] and also special-cased to be set to 'loading' or something before the loader runs, to prevent the loader from trying to request t [04:50:58] So I think that should all be fine [04:51:22] If anyone tries to create any other modules whose contents vary on the user without taking these same precautions, it'll just break and not actually vary on user, with or without localStorage [04:53:09] well, a module.group !== 'user' check doesn't hurt, and is easier to reason about [04:53:31] so I'm still in favor of adding it [04:54:29] (03PS23) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [04:54:52] Sounds good [04:55:02] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [04:55:14] ori-l, what do you think of setting wgAllowUserJs => true in MW-Vagrant? [04:55:26] superm401: yes, sounds good [04:55:40] Alright, will do. [04:56:08] ori-l: Was that patchset a rebase? [04:56:25] no, I added the group !== 'user' check [04:56:31] I'm rebasing now [04:56:38] That's not what the 22..23 diff tells me [04:57:17] what the hell? [04:57:39] ori-l: You undid some of your earlier changes [04:57:43] https://gerrit.wikimedia.org/r/#/c/86867/22..23/resources/mediawiki/mediawiki.js [04:57:53] Also note how 22 and 23 have different parents [05:00:04] (03PS24) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [05:00:36] OK, 24 is what 23 should have been [05:00:38] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [05:01:12] lgtm [05:01:17] Except for the merge conflict then :) [05:03:22] (03PS9) 10PleaseStand: installer: Run the LESS compiler for *.less files [core] - 10https://gerrit.wikimedia.org/r/89610 [05:03:34] (03PS25) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [05:04:26] (03PS1) 10Mattflaschen: Allow user JS [vagrant] - 10https://gerrit.wikimedia.org/r/91560 [05:04:33] (03CR) 10Ori.livneh: "PS23: never happened. PS24: explicitly exclude modules in 'user' group. PS25: rebase." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [05:06:24] superm401: looks good, waiting for jenkins to catch up [05:10:56] ori-l, RoanKattouw, user.groups has the explicit makeResourceLoaderLink too. [05:11:06] Still, definitely easier to reason about if user is excluded. [05:11:13] in OutputPage.php [05:14:03] right [05:14:26] Do we have coding conventions for Puppet? [05:14:34] yes, on wikitech somewhere [05:24:12] * werdna waves [05:24:33] 'lo, werdna [05:31:20] RoanKattouw: you have to return jqxhr, I think. [05:31:35] (03PS1) 10EBernhardson: Consolidate action access to a single location [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91562 [05:31:56] ori-l: What happens if you don't? [05:33:13] (03PS1) 10PleaseStand: mw.language.convertPlural: Check if matching form exists [core] - 10https://gerrit.wikimedia.org/r/91563 [05:34:39] RoanKattouw: .done() is still called, but not with a jqXHR signature [05:34:55] i.e., you don't get (data, status, jqxhr) [05:35:00] Oooh [05:35:13] OK [05:36:06] $.get('/').done( function () { console.log( arguments.length ); }); === 3 [05:36:13] $.get('/').then( function () {} ).done( function () { console.log( arguments.length ); }); === 1 [05:36:44] (03PS2) 10PleaseStand: mw.language.convertPlural: Check if matching form exists [core] - 10https://gerrit.wikimedia.org/r/91563 [05:37:27] $.get('/').then( function ( data, status, jqxhr) { return jqxhr; } ).done( function () { console.log( arguments.length); }); === [05:37:28] 3 [05:37:55] hah [05:38:36] it makes sense, I think [05:40:12] (03PS6) 10Netbrain: Added #subpage functionality and various minor fixes * improved error reporting on syntax failure * fixed small js scope issue [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 [05:40:16] https://github.com/jquery/jquery/blob/master/src/deferred.js#L33 [05:51:04] (03CR) 10Adamw: [C: 032 V: 032] "Much better than before!" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/86395 (owner: 10Ori.livneh) [06:02:28] (03CR) 10Mattflaschen: "Re iOS 3.2, fair enough. It shouldn't break hard anyway, since it looks like the first use of 'JSON.' is inside the same try as the first" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [06:04:25] superm401: s/shouldn't break hard/shouldn't break at all/ [06:05:49] ori-l, yeah, fair enough. [06:06:08] It's not taking advantage of 3.2's apparent localStorage support, but it's fine. [06:13:55] (03CR) 10Ori.livneh: [C: 032] Allow user JS [vagrant] - 10https://gerrit.wikimedia.org/r/91560 (owner: 10Mattflaschen) [06:13:59] (03Merged) 10jenkins-bot: Allow user JS [vagrant] - 10https://gerrit.wikimedia.org/r/91560 (owner: 10Mattflaschen) [06:22:23] (03CR) 10Nikerabbit: [C: 032] Code formatting fixes [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91558 (owner: 10Santhosh) [06:22:33] (03Merged) 10jenkins-bot: Code formatting fixes [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91558 (owner: 10Santhosh) [06:24:04] (03CR) 10Nikerabbit: [C: 032] Fix phpdoc [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/91557 (owner: 10Legoktm) [06:32:28] (03PS1) 10leucosticte: Add IssueTracker extension [extensions/IssueTracker] - 10https://gerrit.wikimedia.org/r/91565 [07:15:04] (03PS26) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [07:16:41] (03CR) 10Matthias Mullie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [07:18:44] (03CR) 10Ori.livneh: "PS26: Address Timo's point by declining to store modules that fail to execute." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [07:57:14] (03CR) 10Physikerwelt: [C: 031] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [08:03:24] (03PS3) 10Hashar: Fix scope on all /phpunit test methods [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:04:47] (03CR) 10Hashar: [C: 032] "I honestly think it is a lost of time since a function is public by default and those classes are not exposed API :-] But that is fine, " [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:06:10] (03CR) 10jenkins-bot: [V: 04-1] Fix scope on all /phpunit test methods [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:11:52] (03CR) 10Hashar: [C: 04-1] "ERrrrr changing my mind in the middle of something is not nice." [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:12:44] (03PS2) 10Hashar: Cleanup tests/includes/media [core] - 10https://gerrit.wikimedia.org/r/91521 (owner: 10Addshore) [08:15:49] (03CR) 10Hashar: [C: 032] Cleanup tests/includes/media [core] - 10https://gerrit.wikimedia.org/r/91521 (owner: 10Addshore) [08:18:50] (03Merged) 10jenkins-bot: Cleanup tests/includes/media [core] - 10https://gerrit.wikimedia.org/r/91521 (owner: 10Addshore) [08:28:12] (03CR) 10Hashar: "bah it is everywhere already ...." [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:32:15] (03PS4) 10Hashar: Fix scope on all /phpunit test methods [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:33:12] (03CR) 10Hashar: [C: 032] "rebased, fixed conflicts" [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:34:27] uh-oh, http://code.google.com/p/gerrit/issues/detail?id=298 fixed [08:35:38] (03PS7) 10Krinkle: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [08:37:02] (03Merged) 10jenkins-bot: Fix scope on all /phpunit test methods [core] - 10https://gerrit.wikimedia.org/r/91525 (owner: 10Addshore) [08:41:30] (03CR) 10Krinkle: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/63378 (owner: 10Daniel Friesen) [08:41:50] (03CR) 10Hashar: [C: 031] "Well done Timo!!! :-] Looks perfect on Safari 6 and whatever Chromium version I might have. Thank you!" [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [08:42:59] (03CR) 10Krinkle: "There's one difference with the referenced change in PHP. The JS here not only checked array length on top, it also checked that the value" [core] - 10https://gerrit.wikimedia.org/r/91563 (owner: 10PleaseStand) [08:45:19] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [08:58:05] (03CR) 10Gergő Tisza: [C: 031] Fixes from MLB upstream [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91531 (owner: 10MarkTraceur) [08:59:55] (03CR) 10Gergő Tisza: [C: 031] Clear interface before opening again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91533 (owner: 10MarkTraceur) [09:05:02] (03PS3) 10Zfilipin: WIP Moved confing files from qa/browsertests repository [selenium] - 10https://gerrit.wikimedia.org/r/90560 [09:05:39] (03PS3) 10Zfilipin: WIP Moved config files to mediawiki/selenium repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90559 [09:05:43] (03PS1) 10Dan-nl: cleaned-up the class [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91579 [09:19:45] hashar: I see you had fun this morning ;p [09:24:09] addshore: yeah I was not really happy to see public keyword added everywhere [09:24:14] addshore: since that does not add any value [09:24:29] addshore: but there is a bunch of them already there, so changed my mind and merged the public addition :] [09:24:51] our coverage still sucks :-] https://integration.wikimedia.org/cover/mediawiki-core/master/php/ [09:26:04] hashar: https://docs.google.com/spreadsheet/pub?key=0ArUN7tgsOZ8qdDNUWUJvN3dwVHdjWS10UXppWXpSSmc&output=html [09:26:10] (it has a graph now) ;p [09:26:15] ahah [09:26:26] well done! [09:26:33] coverage has probably doubled since you turned it on as I missed the first day ;p [09:26:59] got to get the phpclover support merged in jenkins job builder [09:27:05] maybe that will produce a nice dashboar [09:27:05] d [09:27:24] still a lot of clases without coverage though https://etherpad.wikimedia.org/p/r.B0XlRhOdKRWT6xuH (though that means sooo much stuff is also totally untested :P) [09:27:37] (03PS1) 10Deskana: Simplify language so it's easier for end-users to understand. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91581 [09:29:07] addshore: I once wrote a bunch of tests for the global functions aka under tests/phpunit/includes/GlobalFunctions [09:29:11] low hanging fruits there [09:29:16] indeed [09:29:28] need to check how to mark coverage for global functions :P [09:29:37] @covers ::wfGlobalFunction [09:29:38] iirc [09:29:53] lovely :) never had to write any tests for global functions before ;p [09:30:01] see http://phpunit.de/manual/3.7/en/appendixes.annotations.html#appendixes.annotations.covers [09:30:18] Specifies that the annotated test method covers the specified global function. bingo [09:30:31] isn't it lovely ? [09:32:58] indeed :P [09:33:20] it would be more lovely if the tags were alredy everywhere actually ;p [09:36:07] (03CR) 10Zfilipin: [C: 032] Adding new CREDITS and LICENSE files, and license headers to all files. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86355 (owner: 10Yuvipanda) [09:44:41] (03PS2) 10Tim Starling: Improve linkprefix regular expressions [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [09:49:17] (03PS7) 10Zfilipin: Adding new CREDITS and LICENSE files, and license headers to all files. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86355 (owner: 10Yuvipanda) [09:49:41] (03CR) 10Zfilipin: [C: 032] Adding new CREDITS and LICENSE files, and license headers to all files. [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86355 (owner: 10Yuvipanda) [09:50:20] (03CR) 10Tim Starling: [C: 032] "In reply to Siebrand's objections:" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [09:51:28] (03CR) 10Siebrand: "Thanks." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [09:52:14] (03CR) 10Siebrand: "@brad: Can you add the fuzz tester code somewhere?" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [09:53:08] can someone review https://gerrit.wikimedia.org/r/80578 please?:) [09:53:12] (03Merged) 10jenkins-bot: Improve linkprefix regular expressions [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [09:53:27] (03CR) 10Zfilipin: "Luis, if anything should be fixed, please let us know." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/86355 (owner: 10Yuvipanda) [09:54:23] (03CR) 10Ori.livneh: [C: 04-1] "You have to update the schema ID in Echo.php or the events you generate will fail to validate." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90497 (owner: 10Legoktm) [09:54:51] (03PS1) 10Addshore: @covers for all GlobalFunc tests [core] - 10https://gerrit.wikimedia.org/r/91582 [09:54:55] hashar: ^^ [09:55:16] (03PS2) 10Hashar: @covers for all GlobalFunc tests [core] - 10https://gerrit.wikimedia.org/r/91582 (owner: 10Addshore) [09:56:01] addshore: tests/phpunit/includes/FallbackTest.php ?? [09:56:04] that is a new one :] [09:56:14] ahh split [09:56:36] (03CR) 10jenkins-bot: [V: 04-1] @covers for all GlobalFunc tests [core] - 10https://gerrit.wikimedia.org/r/91582 (owner: 10Addshore) [09:56:45] (03PS3) 10Addshore: @covers for all GlobalFunc tests [core] - 10https://gerrit.wikimedia.org/r/91582 [09:56:46] indeed, just fixed 3 minor things ^^ [09:56:52] (03PS1) 10Tim Starling: Improve linkprefix regular expressions (MFM to 1.22wmf21) [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91584 [09:57:27] $ git diff --check HEAD^; echo $? [09:57:28] tests/phpunit/includes/FallbackTest.php:73: trailing whitespace. [09:57:29] +} [09:57:30] tests/phpunit/includes/UserMailerTest.php:14: trailing whitespace. [09:57:31] +} [09:57:32] 2 [09:57:37] yep, they have gone ;p [09:57:53] (03CR) 10Tim Starling: [C: 032] Improve linkprefix regular expressions (MFM to 1.22wmf21) [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91584 (owner: 10Tim Starling) [09:57:54] and my redeclration of a class ;p [09:58:12] TimStarling: \O/ [09:58:28] MFM? CPFM? [09:58:46] merge from master maybe ? [09:59:13] yes, that is what it stands for [09:59:21] in subversion we used MFT [10:00:57] (03PS4) 10Hashar: @covers for all GlobalFunc tests [core] - 10https://gerrit.wikimedia.org/r/91582 (owner: 10Addshore) [10:00:59] addshore: rebasing / merging [10:01:08] :P [10:01:29] (03CR) 10Hashar: [C: 032] @covers for all GlobalFunc tests [core] - 10https://gerrit.wikimedia.org/r/91582 (owner: 10Addshore) [10:04:45] (03Merged) 10jenkins-bot: Improve linkprefix regular expressions (MFM to 1.22wmf21) [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91584 (owner: 10Tim Starling) [10:04:56] (03PS1) 10Addshore: @covers for ApiQuery stuff [core] - 10https://gerrit.wikimedia.org/r/91585 [10:05:33] 77 test classes to go! [10:07:19] (03CR) 10Ori.livneh: [C: 04-1] "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [10:09:12] (03Merged) 10jenkins-bot: @covers for all GlobalFunc tests [core] - 10https://gerrit.wikimedia.org/r/91582 (owner: 10Addshore) [10:10:40] (03PS4) 10Hashar: Cleanup skins/SiteBarTest and @todo/covers [core] - 10https://gerrit.wikimedia.org/r/91168 (owner: 10Addshore) [10:11:22] (03CR) 10Hashar: [C: 032] Cleanup skins/SiteBarTest and @todo/covers [core] - 10https://gerrit.wikimedia.org/r/91168 (owner: 10Addshore) [10:12:32] (03CR) 10jenkins-bot: [V: 04-1] Cleanup skins/SiteBarTest and @todo/covers [core] - 10https://gerrit.wikimedia.org/r/91168 (owner: 10Addshore) [10:15:39] (03Merged) 10jenkins-bot: Cleanup skins/SiteBarTest and @todo/covers [core] - 10https://gerrit.wikimedia.org/r/91168 (owner: 10Addshore) [10:16:21] (03PS9) 10Ori.livneh: Fix double-parsing of account creation messages. [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [10:27:34] hey YuviPanda, do you happen to have a few moments? [10:29:56] (03PS1) 10Tim Starling: Improve linkprefix regular expressions (MFM to 1.22wmf22) [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91587 [10:30:20] (03CR) 10Ori.livneh: [C: 032] Fix double-parsing of account creation messages. [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [10:30:21] (03CR) 10Tim Starling: [C: 032] Improve linkprefix regular expressions (MFM to 1.22wmf22) [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91587 (owner: 10Tim Starling) [10:33:49] (03PS4) 10TTO: Make the link in import log entry always use canonical namespace [core] - 10https://gerrit.wikimedia.org/r/84197 [10:35:32] (03Merged) 10jenkins-bot: Fix double-parsing of account creation messages. [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [10:37:08] (03Merged) 10jenkins-bot: Improve linkprefix regular expressions (MFM to 1.22wmf22) [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91587 (owner: 10Tim Starling) [10:55:09] (03PS1) 10Addshore: @covers tags for inclues/*Test [core] - 10https://gerrit.wikimedia.org/r/91588 [10:56:35] (03CR) 10Hashar: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [10:56:42] (03CR) 10Hashar: [C: 04-1] Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [10:56:51] (03CR) 10Addshore: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91588 (owner: 10Addshore) [11:07:27] (03PS1) 10Pastakhov: add support for user functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91589 [11:08:05] (03CR) 10Pastakhov: [C: 04-2] add support for user functions [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91589 (owner: 10Pastakhov) [11:08:09] (03CR) 10Ori.livneh: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [12:49:06] (03PS3) 10Hashar: mediawiki-release [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89215 [12:52:14] (03CR) 10Hashar: [C: 032] "The mediawiki-core-release has already been deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89215 (owner: 10Hashar) [12:52:32] (03Merged) 10jenkins-bot: mediawiki-release [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89215 (owner: 10Hashar) [13:00:39] (03PS1) 10Zfilipin: Clone Git repositories via anonymous HTTP [selenium] - 10https://gerrit.wikimedia.org/r/91593 [13:08:53] @seen springle [13:08:53] MatmaRex: Last time I saw springle they were changing the nickname to springle-away and springle-away is still in the channel #wikimedia-operations at 10/24/2013 10:34:34 AM (2h34m18s ago) [14:17:05] (03PS9) 10Gergő Tisza: Add an interface for getting "standard" file metadata. [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [14:22:10] (03CR) 10Gergő Tisza: "Brian wrote very detailed documentation about the exact format on mw.org (thanks!), I've added a link to the phpdoc. That should clarify t" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [14:44:54] (03CR) 10MarkTraceur: "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [14:45:00] (03CR) 10MarkTraceur: [C: 04-1] Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [14:45:05] (03CR) 10MarkTraceur: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 (owner: 10MarkTraceur) [14:49:07] (03PS3) 10PleaseStand: mw.language.convertPlural: Check if matching form exists [core] - 10https://gerrit.wikimedia.org/r/91563 [15:21:49] (03CR) 10Cmcmahon: [C: 032] "documentation for checkout scheme from Cloudbees" [selenium] - 10https://gerrit.wikimedia.org/r/91593 (owner: 10Zfilipin) [15:22:06] (03PS4) 10Cmcmahon: Bump patch version [selenium] - 10https://gerrit.wikimedia.org/r/90906 (owner: 10Zfilipin) [15:22:41] (03CR) 10Cmcmahon: [C: 032] "updates to shared test code" [selenium] - 10https://gerrit.wikimedia.org/r/90906 (owner: 10Zfilipin) [15:23:41] (03CR) 10CSteipp: "MZ: UX thought it was too complicated is for the user. On the granting side, it also makes for some strange cases (like if a user grants a" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91488 (owner: 10Aaron Schulz) [15:24:27] (03Abandoned) 10Cmcmahon: WIP test aiming to play Commons Media of the Day [qa/browsertests] - 10https://gerrit.wikimedia.org/r/50468 (owner: 10Cmcmahon) [15:25:10] (03Abandoned) 10Cmcmahon: restore working ULS tests [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90380 (owner: 10Cmcmahon) [15:30:44] (03CR) 10BryanDavis: [C: 032] cleaned-up the class [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91579 (owner: 10Dan-nl) [15:30:51] (03Merged) 10jenkins-bot: cleaned-up the class [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/91579 (owner: 10Dan-nl) [15:31:53] (03CR) 10Calak: [C: 031] "Good job!" [core] - 10https://gerrit.wikimedia.org/r/84197 (owner: 10TTO) [15:39:04] (03PS1) 10Zfilipin: Deleted Jenkins jobs that are known to fail [selenium] - 10https://gerrit.wikimedia.org/r/91610 [15:41:07] (03CR) 10CSteipp: [C: 032] Simplify language so it's easier for end-users to understand. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91581 (owner: 10Deskana) [15:41:17] (03Merged) 10jenkins-bot: Simplify language so it's easier for end-users to understand. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91581 (owner: 10Deskana) [15:45:25] (03CR) 10Krinkle: "@Jon:" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [15:54:45] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 (owner: 10MarkTraceur) [15:54:56] (03CR) 10CSteipp: [C: 032] Only show the log on the management wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91538 (owner: 10Aaron Schulz) [15:55:01] (03Merged) 10jenkins-bot: Only show the log on the management wiki [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91538 (owner: 10Aaron Schulz) [15:55:30] (03PS1) 10AndyRussG: Let instructors and volunteers assign articles [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91613 [16:00:06] (03PS9) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [16:00:19] (03CR) 10Addshore: "PS9 is a rebase" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [16:01:07] (03CR) 10jenkins-bot: [V: 04-1] add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [16:03:28] (03PS10) 10Addshore: add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [16:03:56] (03CR) 10Addshore: "PS10 Added RemoveIdentifierQuotes for MSSql + small fix" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [16:04:05] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 (owner: 10MarkTraceur) [16:04:28] (03CR) 10jenkins-bot: [V: 04-1] add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [16:15:14] (03PS1) 10Krinkle: mediawiki.user: Return a promise from getRights/getGroups [core] - 10https://gerrit.wikimedia.org/r/91617 [16:19:15] (03CR) 10Jdlrobson: "Will be looking at this and fixing it today. Note we have styles, scripts, messages and templates (in mobile) so I'd prefer to have The pl" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [16:20:58] (03PS1) 10Tpt: Add a maintenance script in order to replace hardcoded content model for Page: page in the page DB table [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/91619 [16:31:16] (03PS5) 10MarkTraceur: Fix interface creation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 [16:35:49] (03PS12) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [16:36:54] (03PS6) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [16:43:19] (03PS13) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [16:43:40] (03PS14) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [16:44:16] (03PS7) 10MarkTraceur: Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 [16:44:27] (03CR) 10Anomie: "I copied the wording from the existing titleprotectedwarning message (line 1537). But I'm open to suggestions; anything I think of that us" [core] - 10https://gerrit.wikimedia.org/r/90357 (owner: 10Anomie) [16:44:28] (03PS6) 10MarkTraceur: Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 [16:44:34] (03PS3) 10MarkTraceur: Add whitelistHtml method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 [16:44:48] (03PS8) 10MarkTraceur: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 [16:44:55] (03PS3) 10MarkTraceur: Fix a few fullscreen bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 [16:44:59] (03PS2) 10MarkTraceur: Fixes from MLB upstream [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91531 [16:45:02] (03PS2) 10MarkTraceur: Clear interface before opening again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91533 [16:45:42] (03CR) 10Krinkle: "e.g. in cases like this: https://github.com/Krinkle/mw-gadget-rtrc/blob/f9d6e47f83ce/src/rtrc.js#L1229-L1234" [core] - 10https://gerrit.wikimedia.org/r/91617 (owner: 10Krinkle) [16:47:04] (03PS1) 10Addshore: @covers tags for unit tests [core] - 10https://gerrit.wikimedia.org/r/91625 [16:48:40] (03PS2) 10EBernhardson: Refactor information collection for i18n to dedicated class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 [16:49:48] Rebase allllll the patches [16:56:21] (03PS1) 10Reedy: Update Wikibase extensions [tools/release] - 10https://gerrit.wikimedia.org/r/91626 [16:56:29] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91617 (owner: 10Krinkle) [16:56:34] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91625 (owner: 10Addshore) [16:57:12] (03CR) 10Reedy: [C: 032] Update Wikibase extensions [tools/release] - 10https://gerrit.wikimedia.org/r/91626 (owner: 10Reedy) [16:57:14] (03Merged) 10jenkins-bot: Update Wikibase extensions [tools/release] - 10https://gerrit.wikimedia.org/r/91626 (owner: 10Reedy) [16:57:58] !wg SemiprotectedRestrictionLevels [16:57:58] https://www.mediawiki.org/wiki/Manual:%24wgSemiprotectedRestrictionLevels [16:58:08] anomie: ^ oh noes [16:58:41] anomie: docsplz, or i'll file a bug to shame you. :D [16:59:49] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 (owner: 10EBernhardson) [17:00:12] MatmaRex: Sure, just a minute. [17:03:59] (03CR) 10Matthias Mullie: [C: 04-1] "(14 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91562 (owner: 10EBernhardson) [17:05:35] (03PS2) 10Anomie: Remove linkprefix message, add $linkPrefixCharset [core] - 10https://gerrit.wikimedia.org/r/91425 [17:07:58] (03CR) 10Anomie: "PS2: Rebased." [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [17:13:44] (03PS1) 10Reedy: Initial bump to 1.23 [core] - 10https://gerrit.wikimedia.org/r/91629 [17:13:59] (03CR) 10Reedy: [C: 032 V: 032] Initial bump to 1.23 [core] - 10https://gerrit.wikimedia.org/r/91629 (owner: 10Reedy) [17:18:16] (03PS1) 10Gerrit Patch Uploader: Use localized group names for user rights changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 [17:18:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [17:20:45] MatmaRex: There you go. [17:21:22] anomie: thank you [17:21:32] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [17:23:56] (03PS2) 10Addshore: @covers tags for unit tests [core] - 10https://gerrit.wikimedia.org/r/91625 [17:26:22] (03PS11) 10Addshore: add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [17:26:30] (03CR) 10Addshore: "PS11 fixes jenkins tests" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [17:27:42] (03CR) 10Umherirrender: "You can use User::getGroupName to get the localized text." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [17:27:46] (03CR) 10Addshore: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [17:28:08] (03PS12) 10Addshore: add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [17:28:19] bd808 ^^ lets see what jenkins does :) [17:28:28] (03CR) 10Aaron Schulz: [C: 032] Fixed test script for protocal relative config [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91483 (owner: 10Aaron Schulz) [17:29:37] (03Merged) 10jenkins-bot: Fixed test script for protocal relative config [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91483 (owner: 10Aaron Schulz) [17:29:44] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [17:30:10] Reedy: Oops. :-) [17:30:27] Bah, mis-send. [17:30:32] * James_F glares at his unhelpful fingers. [17:31:30] (03CR) 10jenkins-bot: [V: 04-1] add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [17:32:23] bd808: ^^ [17:32:55] addshore: boo :( [17:33:00] indeed :( [17:33:15] I almost felt like splitting it up into 2 different test methods [17:33:29] which might make sense :) [17:34:06] also getting rid of the createUnicodeString method which is just missleading :P [17:35:49] addshore: Give it a shot. That helper method was mostly to get those min/max unicode chars into the test "easily" [17:38:34] (03PS1) 10Reedy: If minor is 1, previous minor is major-- and minor is 22 [tools/release] - 10https://gerrit.wikimedia.org/r/91632 [17:39:31] (03CR) 10Reedy: [C: 032] If minor is 1, previous minor is major-- and minor is 22 [tools/release] - 10https://gerrit.wikimedia.org/r/91632 (owner: 10Reedy) [17:39:33] (03Merged) 10jenkins-bot: If minor is 1, previous minor is major-- and minor is 22 [tools/release] - 10https://gerrit.wikimedia.org/r/91632 (owner: 10Reedy) [17:43:25] (03CR) 10Jdlrobson: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [17:43:36] (03PS1) 10Reedy: Updating all numbers helps [tools/release] - 10https://gerrit.wikimedia.org/r/91633 [17:43:56] (03CR) 10Reedy: [C: 032] Updating all numbers helps [tools/release] - 10https://gerrit.wikimedia.org/r/91633 (owner: 10Reedy) [17:43:58] (03Merged) 10jenkins-bot: Updating all numbers helps [tools/release] - 10https://gerrit.wikimedia.org/r/91633 (owner: 10Reedy) [17:50:25] (03CR) 10Ori.livneh: "I'm not entirely sure what problem this is trying to solve -- can you make the case for this a bit clearer?" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [17:56:35] (03CR) 10Mwalker: [C: 032] @covers tags for inclues/*Test [core] - 10https://gerrit.wikimedia.org/r/91588 (owner: 10Addshore) [17:57:24] (03PS13) 10Addshore: Add RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [17:58:24] (03CR) 10Addshore: "PS13 restores PS11 which tried to address the comments in PS10." [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [17:58:56] (03PS1) 10MarkAHershberger: set $wgVersion [core] - 10https://gerrit.wikimedia.org/r/91636 [18:01:25] (03CR) 10Mwalker: [C: 032] @covers for ApiQuery stuff [core] - 10https://gerrit.wikimedia.org/r/91585 (owner: 10Addshore) [18:02:11] (03CR) 10jenkins-bot: [V: 04-1] set $wgVersion [core] - 10https://gerrit.wikimedia.org/r/91636 (owner: 10MarkAHershberger) [18:04:11] (03Abandoned) 10MarkAHershberger: set $wgVersion [core] - 10https://gerrit.wikimedia.org/r/91636 (owner: 10MarkAHershberger) [18:04:47] (03CR) 10Mwalker: [C: 04-1] "Currently can not merge -- path conflict that requires manual rebase." [core] - 10https://gerrit.wikimedia.org/r/91388 (owner: 10Addshore) [18:05:41] (03PS1) 10Addshore: @covers tags for the rest of /media/* tests [core] - 10https://gerrit.wikimedia.org/r/91639 [18:07:53] (03PS3) 10Addshore: Add more ApiFormat format tests [core] - 10https://gerrit.wikimedia.org/r/91388 [18:08:05] (03CR) 10Addshore: "PS3 is rebase" [core] - 10https://gerrit.wikimedia.org/r/91388 (owner: 10Addshore) [18:12:28] (03CR) 10Ori.livneh: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91617 (owner: 10Krinkle) [18:13:22] (03PS1) 10Addshore: @covers tags for maintenance tests [core] - 10https://gerrit.wikimedia.org/r/91642 [18:13:26] Krinkle: btw, i figured out a good solution for the error-in-stored-script case, dunno if you saw the updated patch [18:14:55] legoktm: still around? [18:15:11] (03CR) 10Mwalker: "I'd +2 this; but it needs a rebase" [core] - 10https://gerrit.wikimedia.org/r/91398 (owner: 10Addshore) [18:15:23] legoktm: triggering the simpleantispam filter show the edit form without save buttons – is it intended / same as before? [18:16:00] (03CR) 10Mwalker: [C: 032] @covers tags for maintenance tests [core] - 10https://gerrit.wikimedia.org/r/91642 (owner: 10Addshore) [18:17:06] (03CR) 10Mwalker: [C: 032] @covers tags for the rest of /media/* tests [core] - 10https://gerrit.wikimedia.org/r/91639 (owner: 10Addshore) [18:17:20] question re: information hiding and suppress/delete/etc. Should the user visible error message for access control report access control, or should we hide the information and use the exact same messaging as when something doesnt exist? [18:17:50] (03PS2) 10Addshore: Cleanup Api phpunit Tests [core] - 10https://gerrit.wikimedia.org/r/91398 [18:17:53] (03CR) 10Mwalker: [C: 032] Add more ApiFormat format tests [core] - 10https://gerrit.wikimedia.org/r/91388 (owner: 10Addshore) [18:18:16] ebernhardson: all such things in core report access denied error [18:18:23] ebernhardson: including revision deleting or oversighting [18:18:28] mwalker, having fun? :) [18:18:37] I was about to ask you the same thing [18:18:40] :P [18:18:59] I have about 40 test files to go! :P [18:19:26] prtksxna|away: poke? [18:19:30] MatmaRex: reasonable enough, thanks [18:19:31] can someone review https://gerrit.wikimedia.org/r/80578 please?:) [18:19:34] but after this we will have an accurate representation of our coverage :) [18:19:54] (03Merged) 10jenkins-bot: @covers tags for maintenance tests [core] - 10https://gerrit.wikimedia.org/r/91642 (owner: 10Addshore) [18:20:09] (03CR) 10Mwalker: [C: 032] Cleanup Api phpunit Tests [core] - 10https://gerrit.wikimedia.org/r/91398 (owner: 10Addshore) [18:21:16] addshore: do you want to add names for the data items provided in https://gerrit.wikimedia.org/r/#/c/91154/ ? [18:22:18] jzerebecki: names? :) [18:22:31] *looks* [18:22:50] yea each item in a data provider can have a name [18:23:00] @seen ugh [18:23:00] MatmaRex: Last time I saw ugh they were quitting the network with reason: Ping timeout: 250 seconds N/A at 10/24/2013 5:59:01 PM (23m58s ago) [18:23:44] jzerebecki: really? (im guessing as the key in the arrray) ? [18:24:37] yup. i'm trying to find it in the phpunit docs... :) [18:24:42] (03PS1) 10MarkAHershberger: update $wgVersion [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91644 [18:24:44] So am I :) [18:25:02] hexmode, whee! [18:25:17] cant find it on http://phpunit.de/manual/3.7/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.data-providers :/ [18:25:46] (03CR) 10MaxSem: [C: 032] update $wgVersion [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91644 (owner: 10MarkAHershberger) [18:27:04] (03Merged) 10jenkins-bot: Add more ApiFormat format tests [core] - 10https://gerrit.wikimedia.org/r/91388 (owner: 10Addshore) [18:27:38] (03CR) 10Jdlrobson: "It's mostly a matter of code hygiene from my perspective and consistency with the rest of ResourceLoader." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [18:28:31] MaxSem: :) [18:29:36] (03Merged) 10jenkins-bot: Cleanup Api phpunit Tests [core] - 10https://gerrit.wikimedia.org/r/91398 (owner: 10Addshore) [18:30:12] addshore: yea it's not in there. again one of those things sebastian taught me without documenting it :( but i know it works. just used it here https://gerrit.wikimedia.org/r/#/c/65300/ [18:30:30] (03PS1) 10Krinkle: gitmodules: Consistently use .git in the urls [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91647 [18:30:32] (03PS1) 10Krinkle: Remove obsolete testswarm submodule and ant task [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91648 [18:30:51] 4 Warning: Search backend error during full text search for ''. Error message is: IndexMissingException[[foundationwiki_content] missing] [Called from {closure} in /usr/local/apache/common-local/php-1.22wmf22/extensions/CirrusSearch/includes/CirrusSearchSearcher.php at line 349] in /usr/local/apache/common-local/php-1.22wmf22/includes/debug/Debug.php on line 296 [18:30:52] addshore: then --debug or --testdox will use those names [18:30:57] jzerebecki: thats very nice to know! so it will fail with a name rather than an annoying number [18:30:58] ^d: ^^ [18:31:03] yup [18:31:16] jzerebecki: I may start using that in everything I do from now ;p [18:31:58] <^d> Reedy: I know. I'm rebuilding a ton of indexes. [18:32:07] Aha [18:32:19] addshore: nice :) and btw. thank you for working on the test [18:32:24] <^d> Reedy: Was this in the last few minutes, or about 20m ago? [18:32:31] <^d> I should've fixed foundationwiki already. [18:32:43] I'm just looking at a wall of noise on the apache syslogs [18:32:51] No idea [18:32:54] thanks ^d [18:33:11] (03Merged) 10jenkins-bot: update $wgVersion [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91644 (owner: 10MarkAHershberger) [18:33:51] np jzerebecki :) Once everything has coverage tags we can see what needs some tests ;p [18:34:12] statistically, it's probably after some 20 min ago :) https://ganglia.wikimedia.org/latest/graph.php?r=hour&z=xlarge&title=MediaWiki+errors&vl=errors+%2F+sec&x=0.5&n=&hreg[]=vanadium.eqiad.wmnet&mreg[]=fatal|exception>ype=stack&glegend=show&aggregate=1&embed=1 [18:36:11] hah! [18:39:23] (03CR) 10CSteipp: [C: 032] Slight tweak to grant list ordering [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91539 (owner: 10Aaron Schulz) [18:39:38] (03Merged) 10jenkins-bot: Slight tweak to grant list ordering [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91539 (owner: 10Aaron Schulz) [18:43:32] 3 Warning: Invalid argument supplied for foreach() in /usr/local/apache/common-local/php-1.22wmf22/extensions/OpenSearchXml/ApiOpenSearchXml.php on line 120 [18:43:32] 3 Warning: array_map() [function.array-map]: Argument #2 should be an array in /usr/local/apache/common-local/php-1.22wmf22/extensions/OpenSearchXml/ApiOpenSearchXml.php on line 114 [18:43:32] 3 Warning: array_filter() expects parameter 1 to be array, null given in /usr/local/apache/common-local/php-1.22wmf22/extensions/OpenSearchXml/ApiOpenSearchXml.php on line 114 [18:45:00] ^d: Yup, still happening [18:45:01] Oct 24 18:43:58 10.64.16.169 apache2[1222]: PHP Warning: Search backend error during full text search for 'g.dj.dm w'. Error message is: IndexMissingException[[foundationwiki_content] [18:46:12] hexmode: around? [18:46:27] MatmaRex: yep [18:46:31] (03PS5) 10Bartosz Dziewoński: Backport information boxes' styles from vforms to shared CSS [core] - 10https://gerrit.wikimedia.org/r/82828 [18:46:35] hexmode: what do you think about including https://gerrit.wikimedia.org/r/#/c/90291/ in 1.22 release? ("Merge SimpleAntiSpam extension into core") [18:46:44] <^d> Reedy: Mmk. [18:47:25] MatmaRex: I think that was on Markus' TODO list. We talked about SAS in particular. [18:47:45] (03CR) 10Bartosz Dziewoński: "Rebased once again. I was hoping this would be included in 1.22, but no dice, eh?" [core] - 10https://gerrit.wikimedia.org/r/82828 (owner: 10Bartosz Dziewoński) [18:47:58] let me ping him [18:47:58] hexmode: i don't mean bundling, i mean merging into core [18:48:03] oh [18:48:09] it's like 20 lines of code (which has already been written) [18:48:38] I have no objections, but I haven't looked at it. 1s [18:49:24] i was going to just merge it in time for the REL1_22 branch, but that's been created earlier than it was supposed to [18:49:43] When was it supposed to be created? [18:49:55] MatmaRex: :) well, we're supposed to branch no later than tmw [18:50:00] so today is ok [18:50:01] If anything, it's probably late [18:50:05] <^d> Reedy: Fixing foundationwiki now. [18:50:22] Reedy: i assumed it'd be created a week from the announcement [18:50:24] anyway, doesn't matter [18:51:04] MatmaRex: So I just glanced and it looks like something that might help and would be useful [18:51:15] until the bots figure it out :P [18:51:45] okay. so i'm going to merge and backport? [18:51:46] heh, you'd think they would already have figured it out [18:52:01] (i tested and it doesn't break stuff) [18:52:04] MatmaRex: yep [18:52:18] ugh: the mediawiki-specific ones did [18:52:23] well yeah [18:52:45] also, TWN will need to export the messages to the backport as well [18:52:47] don't forget to update the release notes [18:52:49] (03CR) 10Bartosz Dziewoński: [C: 032] "This is a very simple piece of code that offers clear improvement over current state according to at least some sources (http://lists.wiki" [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [18:53:00] hexmode: it has release notes [18:53:02] needs rebase tho [18:53:17] (03CR) 10jenkins-bot: [V: 04-1] Merge SimpleAntiSpam extension into core [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [18:53:17] twin is on top of it... they know how to do all that :) [18:53:23] (03CR) 10CSteipp: [C: 04-1] "Missing change to maintenance script, but otherwise seems to be complete." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [18:53:26] you can use your fancy rebase tool :P [18:53:46] sure i will [18:54:26] the best thing about that tool is that it does everything for me :D [18:55:05] (03CR) 10Parent5446: [C: 04-1] "Doesn't this need MessagesQqq? @Siebrand?" [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [18:55:15] errrr [18:55:18] he didnt read the comment. [18:55:25] they should be imported, shouldn't they? [18:55:45] (03PS3) 10Jdlrobson: Allow ResourceLoaderSchemaModules to contain more than one module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 [18:55:47] WHY IS GERRIT SO SLOW AGAIN. [18:55:57] (03CR) 10Legoktm: "From above, "Qqq will be added automatically, as the keys already exist."" [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [18:56:05] yes [18:56:20] (03CR) 10Bartosz Dziewoński: "AFAIK they will be imported from TWN with all other messages (as per the commit message here)." [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [18:56:26] gah, too slow [18:56:36] (03PS4) 10Bartosz Dziewoński: Merge SimpleAntiSpam extension into core [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [18:57:12] (03CR) 10Jdlrobson: "(1 comment)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [18:57:18] it would be nice if he came on IRC.... [18:57:37] (03CR) 10Bartosz Dziewoński: [C: 032] "Rebased (release notes conflict only)." [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [18:57:52] (03PS1) 10Bartosz Dziewoński: Merge SimpleAntiSpam extension into core [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91650 [18:58:04] hexmode: wanna +2 or should i? ^ [18:58:33] oh, I will [18:59:12] (03CR) 10MarkAHershberger: [C: 032] Merge SimpleAntiSpam extension into core [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91650 (owner: 10Bartosz Dziewoński) [18:59:18] woot :D [18:59:22] killed an extension. [18:59:27] 1 down, 753 to go. [18:59:36] don't forget those in SVN [18:59:47] ugh. [19:00:10] Wait, is it alternate nick day again? [19:00:30] I use different nicks for each IRC client I use. [19:00:36] ugh == webchat [19:01:10] (03PS15) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [19:01:20] hexmode: is jenkins-bot behind or does it not merge on REL1_22? [19:01:30] ugh: i think it's just slow [19:01:35] (hopefully) [19:01:49] where's that dashboard thingy… [19:01:58] (03Merged) 10jenkins-bot: Merge SimpleAntiSpam extension into core [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [19:02:29] ugh: it's working on it, i think - see https://integration.wikimedia.org/zuul/ [19:02:36] ugh: seems slower on branches [19:02:38] yeah [19:02:44] 91650 under gate-and-submit [19:02:57] hexmode: it's just processing everything in sequence [19:03:02] 90921 was first [19:03:21] now all the tests have to run again, so it's going to take a few minutes [19:03:47] AaronSchulz: am I correct to assume that the y axis in https://graphite.wikimedia.org/render?from=-24hours&until=now&width=1200&height=680&target=*.job-insert-ParsoidCacheUpdateJobOnEdit.count&target=*.job-pop-ParsoidCacheUpdateJobOnEdit.count is jobs per minute? [19:04:06] it would fit with https://gdash.wikimedia.org/dashboards/editswiki/ [19:05:45] qgil: in Firefox on shared computers, sign out of Google. I'm in ur calendar on R31 :) [19:05:47] should be [19:06:00] (03Merged) 10jenkins-bot: Merge SimpleAntiSpam extension into core [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91650 (owner: 10Bartosz Dziewoński) [19:06:48] hexmode: i'd also want to backport https://gerrit.wikimedia.org/r/#/c/80578/ [19:07:15] hexmode: it looks like it'll be very useful for at least two extensions we probably want to support for third-parties, cirrussearch and mobilefrontend [19:07:39] AaronSchulz: k, thx [19:07:55] AaronSchulz: is that generally the case for most ganglia even stats? [19:08:00] *event [19:08:01] hexmode: (sorry about pinging you about all the stuff, i though i had the weekend to re-review and merge these) [19:08:07] I believe [19:08:17] ok [19:08:35] MatmaRex: np. I like the attention ;) [19:10:44] (03PS2) 10EBernhardson: Consolidate action access to a single location [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91562 [19:10:55] MatmaRex: yeah, looks good for backporting, but we need review for parser peeps [19:11:19] hexmode: subbu +1'd, that's good enough for me [19:11:34] i reviewed it earlier and it seemed okay too [19:11:47] spagewmf, gosh [19:11:49] i'm re-reading the code now [19:12:09] k, that's good. I don't know who is a parson person and who isn't except Tim [19:13:40] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [19:14:04] (03CR) 10Bartosz Dziewoński: [C: 032] "Subbu +1'd, that's good enough for me. Let's do this. I chatted with Mark and we'll backport to 1.22 too." [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [19:14:25] wee, thanks a lot MatmaRex [19:14:26] hexmode: subbu and gwicke are parsoid people [19:14:44] (03PS1) 10Bartosz Dziewoński: Make TOC hideable [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91652 [19:14:53] hexmode: ^ :) [19:15:06] MaxSem: my pleasure [19:15:18] well, my native parser knowledge is still a little spotty and incomplete. [19:15:28] :) [19:15:46] which is why i didn't +2 it. [19:15:55] hexmode: Also cscott when he's around [19:15:55] it has tests and they pass, what else to want? :P [19:15:58] Wait where's cscott [19:16:25] cscott is on a cruise [19:16:45] (03PS1) 10Reedy: Add description to createExtensionTables.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/91653 [19:17:09] Ahhh. [19:18:18] (03CR) 10MarkAHershberger: [C: 032] Make TOC hideable [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91652 (owner: 10Bartosz Dziewoński) [19:18:32] (03CR) 10Anomie: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [19:18:33] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [19:19:19] (03PS1) 10Aude: Fix undefined variable in Status::getMessage() [core] - 10https://gerrit.wikimedia.org/r/91654 [19:19:27] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [19:19:30] ori-l: am looking for the cache hit / miss thing in graphite, but did not find it by looking in 'visualeditor' graphs- any pointers? [19:19:56] (03CR) 10Aude: "see https://gerrit.wikimedia.org/r/#/c/91654/" [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [19:20:46] ori-l: if you are around, can you please review https://gerrit.wikimedia.org/r/#/c/91654/ ? [19:21:03] it's causing test failure in wikibase and appears to be a bug.... should be backported [19:22:19] (03PS2) 10Aude: Fix undefined variable in Status::getMessage() [core] - 10https://gerrit.wikimedia.org/r/91654 [19:22:34] (03Merged) 10jenkins-bot: Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [19:23:51] Jenkins is busy [19:23:53] (03CR) 10Aude: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91654 (owner: 10Aude) [19:24:59] (03CR) 10Ori.livneh: [C: 032] Fix undefined variable in Status::getMessage() [core] - 10https://gerrit.wikimedia.org/r/91654 (owner: 10Aude) [19:26:16] (03Merged) 10jenkins-bot: Make TOC hideable [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91652 (owner: 10Bartosz Dziewoński) [19:26:46] Reedy: backporting all the things [19:26:59] It was only branched a couple of hours ago!! [19:27:30] i was expecting it to branch after the weekend and i was going to merge stuff before then [19:27:36] Better to shift the concrete about a few hours after pouring than a few days [19:27:53] Reedy: oh btw, you can kill SimpleAntiSpam extension from WMF config in two weeks [19:28:00] OMFG [19:28:03] Reedy: i just merged it into core (but it won't explode, no worries) [19:28:20] Jenkins needs a twin [19:28:29] Jeeves [19:28:34] Then we can ask him things [19:28:35] 1 down, 753 to go. [19:29:18] (03PS3) 10Aude: Fix undefined variable in Status::getMessage() [core] - 10https://gerrit.wikimedia.org/r/91654 [19:31:13] (03CR) 10Aude: "note, this really needs tests! I may poke at that in follow up" [core] - 10https://gerrit.wikimedia.org/r/91654 (owner: 10Aude) [19:32:22] (03PS1) 10Bartosz Dziewoński: mediawiki.inspect: Support IE8's style.sheet.rules property [core] - 10https://gerrit.wikimedia.org/r/91657 [19:34:13] hexmode: also, should we poke you before merging things into REL1_22, or are you watching it anyway and don't want to be bothered with tiny things like ^ ? :) [19:34:13] (03PS1) 10Reedy: Prevent some log noise when search related problems occur. [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/91659 [19:34:44] MatmaRex: I'll be watching [19:36:03] (03PS1) 10Addshore: @covers tags for more test classes [core] - 10https://gerrit.wikimedia.org/r/91660 [19:38:48] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza) [19:42:30] (03CR) 10Addshore: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91660 (owner: 10Addshore) [19:42:48] (03CR) 10Gergő Tisza: [C: 032] "Looks good. Not really testable, I guess." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 (owner: 10MarkTraceur) [19:42:49] (03PS1) 10Aude: Add visibility to Status functions and variables [core] - 10https://gerrit.wikimedia.org/r/91661 [19:44:01] hexmode: does the 'Backport_to_Stable' flag on Bugzilla now refer to 1.22? [19:44:21] hexmode: and if not, can/should we have a flag for that? or just use milestone? [19:44:25] (03Merged) 10jenkins-bot: Fix interface creation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 (owner: 10MarkTraceur) [19:44:47] MatmaRex: it refers to previous versions. We'll have to review them tomorrow. [19:45:03] okay, thanks [19:46:59] (03CR) 10Matthias Mullie: [C: 032] Consolidate action access to a single location [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91562 (owner: 10EBernhardson) [19:47:15] (03Merged) 10jenkins-bot: Consolidate action access to a single location [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91562 (owner: 10EBernhardson) [19:47:41] (03CR) 10Esanders: [C: 032] Add popup CTA for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91314 (owner: 10MarkTraceur) [19:47:49] <3 [19:47:52] All these merges [19:47:56] It's not even my birthday [19:48:04] Almost my half-birthday I guess [19:48:07] (03Merged) 10jenkins-bot: Add popup CTA for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91314 (owner: 10MarkTraceur) [19:49:21] Oh, no, maths, yesterday was [19:49:28] So now I dunno why y'all are being awesome [19:50:23] marktraceur: wait, you're born on april 24? [19:50:46] No, 28th [19:51:01] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91657 (owner: 10Bartosz Dziewoński) [19:51:44] I went and figured the day numbers for 04-28 and added 178 [19:51:50] day number* [19:52:33] i typed "24 october - half a year" into wolframalpha. :P [19:52:52] Hah [19:53:00] (and i happen to be born on 24th, which is why i got interested) [19:53:03] It probably converted "Half a year" into 6 months [19:53:53] it actually used 183 days, it seems [19:54:04] whatever. [19:54:10] dates are hard [19:54:45] http://www.wolframalpha.com/input/?i=April+28th+%2B+%28+356+%2F+2+%29+days [19:56:02] marktraceur: 356 is almost correct. :> [19:56:19] Oh my god -.- [19:56:28] * marktraceur needs to find more caffeine clearly [19:56:47] 'kay, Sunday. [19:56:48] http://www.wolframalpha.com/input/?i=April+28th+%2B+%28+365+%2F+2+%29+days [19:58:13] :D [19:58:35] (03PS2) 10Reedy: Prevent some log noise when search related problems occur. [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/91659 [20:01:32] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91657 (owner: 10Bartosz Dziewoński) [20:01:39] * MatmaRex stabs IE8 [20:02:46] (03PS2) 10Bartosz Dziewoński: mediawiki.inspect: Support IE8's style.sheet.rules property [core] - 10https://gerrit.wikimedia.org/r/91657 [20:03:07] MatmaRex: Was it fatal? Please oh please. [20:04:08] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/91659 (owner: 10Reedy) [20:04:26] marktraceur: ^^ [20:04:40] it's not alive, but not dead either! [20:05:52] (03CR) 10Reedy: "(1 comment)" [extensions/OpenSearchXml] - 10https://gerrit.wikimedia.org/r/91659 (owner: 10Reedy) [20:07:27] (03CR) 10Gergő Tisza: [C: 032] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [20:07:33] (03Merged) 10jenkins-bot: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [20:08:46] (03CR) 10Gergő Tisza: [C: 032] "Looks good, cannot be tested directly." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 (owner: 10MarkTraceur) [20:08:48] (03CR) 10jenkins-bot: [V: 04-1] Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 (owner: 10MarkTraceur) [20:11:02] (03CR) 10Umherirrender: [C: 031] "That works!" [core] - 10https://gerrit.wikimedia.org/r/91657 (owner: 10Bartosz Dziewoński) [20:17:15] (03CR) 10Gergő Tisza: [C: 032] "Tested, works. Affected by bug 56055 but there is a separate patch for that so i'll mark as +2." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [20:17:17] (03CR) 10jenkins-bot: [V: 04-1] Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [20:20:04] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87510 (owner: 10Siebrand) [20:20:38] (03CR) 10Gergő Tisza: [C: 032] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [20:20:41] (03CR) 10jenkins-bot: [V: 04-1] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [20:22:19] (03PS1) 10Bartosz Dziewoński: SkinTemplate: Move debug HTML above bottomscripts [core] - 10https://gerrit.wikimedia.org/r/91667 [20:25:33] (03PS1) 10Bartosz Dziewoński: Set $parentLen in contributions [core] - 10https://gerrit.wikimedia.org/r/91668 [20:26:17] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87510 (owner: 10Siebrand) [20:28:04] (03PS1) 10Bartosz Dziewoński: Set $parentLen in contributions [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91669 [20:28:32] (03PS1) 10Bartosz Dziewoński: Set $parentLen in contributions [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91670 [20:28:48] somebody please merge and deploy these ^ [20:29:35] (03CR) 10Gergő Tisza: [C: 032] "Tested, works." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90455 (owner: 10MarkTraceur) [20:29:49] Woooo [20:30:21] (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 (owner: 10EBernhardson) [20:30:24] Awww they're all not merging [20:31:15] (03Merged) 10jenkins-bot: Only add handlers on image thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90455 (owner: 10MarkTraceur) [20:31:17] (03PS1) 10Aaron Schulz: Font size, width, and padding tweaks to authorize form [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91671 [20:31:40] (03PS1) 10Addshore: @covers tags for the rest of test files.. [core] - 10https://gerrit.wikimedia.org/r/91672 [20:32:59] (03CR) 10jenkins-bot: [V: 04-1] @covers tags for the rest of test files.. [core] - 10https://gerrit.wikimedia.org/r/91672 (owner: 10Addshore) [20:38:56] (03PS2) 10Addshore: @covers tags for the rest of test files.. [core] - 10https://gerrit.wikimedia.org/r/91672 [20:39:28] hashar! Thats it! [20:40:04] all coverage tags are now in review except 4 test files that I really struggle to find out what exactly the tests are trying to test :P [20:40:22] yeah our tests are pretty bad :/ [20:40:31] need to at least decouple unit and "integration" tests [20:40:37] I am not sure how to do it though [20:40:48] maybe two directories :] [20:40:51] hey hashar [20:40:51] :D [20:41:12] hashar: yup, two directories work, tis what we do. /unit and /integration [20:41:17] hashar: https://bugzilla.wikimedia.org/show_bug.cgi?id=56110 just a fyi :D [20:41:26] (03PS8) 10MarkTraceur: Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 [20:41:27] evening YuviPanda :) [20:41:34] hi addshore :D [20:41:53] addshore: the apps team is trying to do TDD for the Wikipedia App from day 0 :D [20:41:53] * addshore cant wait for the coverage report once all of these are merged :P [20:42:01] (03PS4) 10MarkTraceur: Add whitelistHtml method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 [20:42:02] YuviPanda: cc me on the bug :) too late for me to click on it :] [20:42:06] YuviPanda: good! :D [20:42:09] hashar: yes sir! [20:42:10] :) [20:42:17] addshore: coverage is run at 3:00am UTC iirc. So tomorrow morning :] [20:42:19] hashar: ah, you already are [20:42:21] tis what we do over at wikibase :) [20:42:35] YuviPanda: will look at it tomorrow so [20:42:37] (03CR) 10Gergő Tisza: [C: 04-1] "Tested in console, got an error ($ele.contents is not a function) for this:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 (owner: 10MarkTraceur) [20:42:50] hehe, hashar thats only if you going to go and review the 5 remaining patchsets before then ;p [20:43:42] (03CR) 10Reedy: [C: 032] Set $parentLen in contributions [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91669 (owner: 10Bartosz Dziewoński) [20:44:25] (03PS2) 10Aaron Schulz: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 [20:44:33] Wat. [20:44:59] (03CR) 10jenkins-bot: [V: 04-1] Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 (owner: 10Aaron Schulz) [20:46:37] Reedy: wanna merge the others too? [20:47:19] (03Merged) 10jenkins-bot: Set $parentLen in contributions [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91669 (owner: 10Bartosz Dziewoński) [20:48:27] (03PS7) 10MarkTraceur: Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 [20:49:22] hashar: hmm that reminds me -- I'm not sure offhand how hard it would be to make automated tests for iOS app that jenkins can run. :) possibly i could rig something up on one of my spare macs that's triggered by something that jenkins can ping, but .... ehhhhh [20:49:32] mediawiki.org search broken? https://www.mediawiki.org/w/index.php?search=Python&button=&title=Special%3ASearch [20:49:33] unless i can rig up "pure" obj-c tests than compile and run on linux ;) [20:49:54] addshore: any one in the wmf LDAP group can trigger the build. Will review your change tomorrow morning and run the job :] [20:50:19] (03CR) 10Bartosz Dziewoński: [C: 032] Fix undefined variable in Status::getMessage() [core] - 10https://gerrit.wikimedia.org/r/91654 (owner: 10Aude) [20:50:25] brion: basically, if we can get the test requirements as debian package on Precise, we can get them installed by ops on the jenkins servers [20:50:33] brion: if that is not possible, we can fallback to a labs instance [20:50:37] (03PS1) 10Bartosz Dziewoński: Fix undefined variable in Status::getMessage() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91743 [20:50:48] (03CR) 10Bartosz Dziewoński: [C: 032] Fix undefined variable in Status::getMessage() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91743 (owner: 10Bartosz Dziewoński) [20:50:48] heh [20:50:54] brion: the rest is just about listing somewhere the command you want to be run. Yuvi told me it would be as simple as running 'mvn check' or something [20:50:59] there was seriously large amount of really broken code merged lately. [20:51:03] just in time for the release. [20:51:05] hashar: ok i'll see if i can rig up something that runs on linux, if not i'll see what i can do that would be pinged remotely [20:51:14] brion: creating the jobs in jenkins / adding the triggers in Zuul is usually trivial. [20:51:14] anyone know, how does one get buy-in on an extension namespace id and name? [20:51:17] hashar: yeah android will be easier ;) [20:51:24] since those java bits can run on linux easy [20:51:46] hashar: can you merge these? followup to commit you merged: https://gerrit.wikimedia.org/r/#/q/I17bd160577e6b287cc5a61e2a3b983b035c87f81,n,z [20:52:11] (03CR) 10Gergő Tisza: "Fallback date looks like 2013-10-24T19:53:46Z. Not sure how much we care since non-fallback dates are even more random, but it should be p" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 (owner: 10MarkTraceur) [20:52:20] brion: I think that is bug 56110 """ Setup checkstyle based linting for apps/android/java-mwapi """ isn't it ? https://bugzilla.wikimedia.org/show_bug.cgi?id=56110 [20:52:22] (03PS2) 10Reedy: Set $parentLen in contributions [core] - 10https://gerrit.wikimedia.org/r/91668 (owner: 10Bartosz Dziewoński) [20:52:37] (03CR) 10Gergő Tisza: [C: 032] Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 (owner: 10MarkTraceur) [20:52:42] (03CR) 10Reedy: [C: 032] Set $parentLen in contributions [core] - 10https://gerrit.wikimedia.org/r/91668 (owner: 10Bartosz Dziewoński) [20:52:47] MatmaRex: I am about to get to bed so not really willing to break something in prod :/ [20:52:49] hashar: i think we want more tests than that, but the linter will be a start yes [20:52:55] hashar: don't worry, you already did :D [20:53:39] brion: my recommendation is to start with something easy :] That might require a bunch of prerequisites such as maven or whatever java world might need [20:53:47] heh yeah [20:53:50] brion: for check style, I think we simply need the check style package [20:53:56] that'll be simple yeah [20:54:29] (03CR) 10Gergő Tisza: [C: 04-1] "{{ec}}" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 (owner: 10MarkTraceur) [20:54:37] brion: can poke that with Yuvi since our timezone nicely overlap and he usually persuade me to get his stuff done! [20:54:44] excellent :D [20:54:55] thanks hashar ! [20:54:56] hashar: awesome :) [20:54:58] (03Merged) 10jenkins-bot: Fix undefined variable in Status::getMessage() [core] - 10https://gerrit.wikimedia.org/r/91654 (owner: 10Aude) [20:55:18] brion: but overall, Jenkihns/Zuul is usually not a blocker :] [20:55:25] sweet [20:55:47] and once we know the actual coverage hasher im going to set a target for the end of the year ;p [20:55:59] :) [20:56:04] or do you just add one to https://www.mediawiki.org/wiki/Extension_default_namespaces and leave it at that? [20:56:21] addshore: is core on coveralls? [20:56:37] no, its on integration.wikimedia.org/cover/mediawiki-core/master/php/ :) [20:56:44] ok [20:56:58] web 1.0 style :( [20:57:00] I have spent the last few days adding @covers tags to everything :P [20:57:22] and wikibase is not there? [20:57:31] this is just core currently :) [20:57:32] aude: we found out with add shore that jenkins has a plugin to generate coverage reports ; will see how it go [20:57:40] cool! [20:57:49] * aude may start with Status.php [20:57:57] since i found a bug there and no tests [20:57:59] (03Merged) 10jenkins-bot: Fix undefined variable in Status::getMessage() [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91743 (owner: 10Bartosz Dziewoński) [20:58:04] extension is not done yet, I usually push new feature for core since that it is easier for me [20:58:12] hehe aude :P [20:58:12] (03CR) 10Ori.livneh: [C: 032] "Thank you!" [core] - 10https://gerrit.wikimedia.org/r/91657 (owner: 10Bartosz Dziewoński) [20:58:19] aude: >> https://integration.wikimedia.org/cover/mediawiki-core/master/php/index.dashboard.html [20:58:22] wikibase caught th core bug [20:58:49] \O/ [20:58:56] (03CR) 10Gergő Tisza: [C: 032] "Haven't tested this one but looks simple enough." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 (owner: 10MarkTraceur) [20:58:58] (03CR) 10Bartosz Dziewoński: [C: 032] "Self-merging trivial backport, merged in master by Reedy." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91670 (owner: 10Bartosz Dziewoński) [20:59:16] (03PS1) 10Bartosz Dziewoński: mediawiki.inspect: Support IE8's style.sheet.rules property [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91766 [20:59:32] (03CR) 10Bartosz Dziewoński: [C: 032] "Self-merging trivial backport, merged in master by Ori." [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91766 (owner: 10Bartosz Dziewoński) [20:59:33] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91617 (owner: 10Krinkle) [20:59:34] (03Merged) 10jenkins-bot: Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 (owner: 10MarkTraceur) [20:59:38] merge all the things. [20:59:47] Merge...all the things? [20:59:49] (03CR) 10Gergő Tisza: [C: 032] "Looks good, cannot be tested directly." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91531 (owner: 10MarkTraceur) [20:59:53] lol [20:59:57] jenkins will be busy for hours [21:01:31] it already run all the tests anyway [21:01:32] (03CR) 10Gergő Tisza: [C: 032] "Looks good, cannot be tested directly." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 (owner: 10MarkTraceur) [21:02:01] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 (owner: 10EBernhardson) [21:02:17] gwicke: knock knock... I'd like to deploy a CentralNotice bugfix 1500-1530 PDT, sound good? [21:02:21] gwicke: oops! [21:02:27] greg-g: ^-2 [21:03:40] (03CR) 10CSteipp: [C: 032] Font size, width, and padding tweaks to authorize form [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91671 (owner: 10Aaron Schulz) [21:04:37] (03Merged) 10jenkins-bot: Set $parentLen in contributions [core] - 10https://gerrit.wikimedia.org/r/91668 (owner: 10Bartosz Dziewoński) [21:04:57] (03PS5) 10MarkTraceur: Add whitelistHtml method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 [21:05:20] awight: you have my blessing, in case that helps ;) [21:05:54] (03CR) 10Gergő Tisza: [C: 032] "Works. (Haven't tested the gender thing.)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [21:06:08] hehe, now I am undefeatable! [21:06:15] (03PS3) 10EBernhardson: Refactor information collection for i18n to dedicated class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 [21:07:06] (03PS9) 10MarkTraceur: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 [21:07:18] (03CR) 10MarkTraceur: "Just a rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [21:08:45] (03PS10) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [21:08:52] (03CR) 10MarkTraceur: "Only a rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [21:09:04] (03CR) 10MarkTraceur: "Believe I fixed it" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 (owner: 10MarkTraceur) [21:10:11] (03CR) 10Gergő Tisza: [C: 032] "Cannot be properly tested since most UI elements are in independent changesets. I'll +2 this and retest once everything is merged." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91533 (owner: 10MarkTraceur) [21:11:30] MatmaRex: around? [21:11:44] sorta [21:12:21] MatmaRex: could you look at this and +2 it? https://gerrit.wikimedia.org/r/#/c/89340/ [21:15:03] hexmode: looks hackish. brb, sandwiches. [21:15:16] * ^d steals a sandwich [21:15:36] joke's on you, i have yet to make them [21:16:17] <^d> Foiled again [21:16:26] Jenkins, u drunk again? [21:17:30] MatmaRex: If you can tell me what is hackish, I'll tell you why or fix the hack. :) [21:17:49] (03CR) 10Gergő Tisza: [C: 032] "Uhh, sorry about the previous -1. Turns out jQuery.parseHTML returns a plain array, not a jQuery object; so probably the code was already " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 (owner: 10MarkTraceur) [21:18:18] Hah [21:18:59] <^d> marktraceur: If I were jenkins, I would stay drunk. [21:19:38] (03CR) 10Gergő Tisza: [C: 032] Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [21:20:21] (03CR) 10Gergő Tisza: [C: 032] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [21:20:35] Oh my goodness this is so exciting. [21:20:42] (03CR) 10Brian Wolff: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [21:20:53] If there were a Jenkins bot around to merge them all I'd be even happier [21:23:11] (03CR) 10Gergő Tisza: [C: 032] "Moved date formatting issue into separate bug: #56123" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 (owner: 10MarkTraceur) [21:23:29] marktraceur: it's probably busy merging all of my backports [21:23:40] God damn it MatmaRex [21:24:01] hexmode: that patch literally touches only the parts of MediaWiki i don't have a slightest clue about :( [21:24:18] heh [21:24:24] oh well.... [21:24:56] https://integration.wikimedia.org/zuul/ [21:24:56] (03CR) 10jenkins-bot: [V: 04-1] EventLogging support for MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 (owner: 10MarkTraceur) [21:24:59] Queue lengths: 177 events, 0 results. [21:27:45] (03CR) 10Legoktm: "User::getGroupName won't work here since it doesn't let us change the language based on whatever the formatter wants/needs. I'll adapt tha" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [21:33:27] (03CR) 10jenkins-bot: [V: 04-1] Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [21:33:40] (03CR) 10jenkins-bot: [V: 04-1] Refactor information collection for i18n to dedicated class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 (owner: 10EBernhardson) [21:33:57] anyone around who can give isalix@gmail.com editbugs on bugzilla? he's a pywikibot dev [21:34:10] (03Merged) 10jenkins-bot: Font size, width, and padding tweaks to authorize form [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91671 (owner: 10Aaron Schulz) [21:36:17] (03Merged) 10jenkins-bot: mediawiki.inspect: Support IE8's style.sheet.rules property [core] - 10https://gerrit.wikimedia.org/r/91657 (owner: 10Bartosz Dziewoński) [21:36:45] (03PS1) 10Adamw: Update CentralNotice [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91772 [21:36:50] <^d> Whee, getting added to changes I'm not going to review :D [21:37:01] * YuviPanda writes a bot that adds ^d to everything [21:37:18] (03PS2) 10Legoktm: Use localized group names for user rights changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91630 (owner: 10Gerrit Patch Uploader) [21:37:46] (03PS1) 10Adamw: Update CentralNotice [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91773 [21:37:55] * ^d bans YuviPanda from BZ [21:38:01] (03Merged) 10jenkins-bot: Set $parentLen in contributions [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91670 (owner: 10Bartosz Dziewoński) [21:38:22] ^d: already hidden that bot :P [21:38:43] * ^d blocks all IP addresses originating from India [21:39:05] (03Merged) 10jenkins-bot: Add whitelistHtml method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 (owner: 10MarkTraceur) [21:39:10] ^d: The India Education Program all over again! [21:39:11] (03PS1) 10Adamw: Update CentralNotice [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91774 [21:39:23] (03Merged) 10jenkins-bot: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [21:39:28] (03CR) 10jenkins-bot: [V: 04-1] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [21:39:32] <^d> YuviPanda: Only this time we get to blame you :D [21:39:41] (03CR) 10Adamw: [C: 032] Update CentralNotice [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91774 (owner: 10Adamw) [21:40:09] (03CR) 10Adamw: [C: 032] Update CentralNotice [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91773 (owner: 10Adamw) [21:40:10] (03CR) 10jenkins-bot: [V: 04-1] Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 (owner: 10MarkTraceur) [21:40:21] ^d: heh, if we get as much drama as last time, there's enough blame for a lot of fun :P [21:40:32] (03CR) 10Adamw: [C: 032] Update CentralNotice [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91772 (owner: 10Adamw) [21:42:23] (03Merged) 10jenkins-bot: mediawiki.inspect: Support IE8's style.sheet.rules property [core] (REL1_22) - 10https://gerrit.wikimedia.org/r/91766 (owner: 10Bartosz Dziewoński) [21:44:43] 2.1G /srv/mw-log [21:44:44] hmmmm [21:44:48] do you reckon maybe I left debug logging on? :) [21:47:33] wmf/1.22wmf21? [21:47:39] is that still deployed? [21:48:00] awight: ^ [21:48:30] No [21:49:02] (03PS1) 10Aklapper: Delete unused custom bug_activity.css file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91776 [21:49:37] <^d> MatmaRex: You can verify what versions are deployed you know :) [21:49:37] /opme #wikimedias-staff [21:49:40] Crap. [21:49:49] MatmaRex: ok thanks for the tip [21:50:00] I'll try not to rsync blast it out ;) [21:52:04] ^d: but that would require effort! [21:54:20] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91617 (owner: 10Krinkle) [21:54:56] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 (owner: 10Gergő Tisza) [21:55:04] (03Merged) 10jenkins-bot: Update CentralNotice [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91773 (owner: 10Adamw) [21:55:32] greg-g: /me begins to sneak towards improvised deploy window [21:57:03] (03Merged) 10jenkins-bot: Update CentralNotice [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91772 (owner: 10Adamw) [21:57:22] (03PS2) 10Gergő Tisza: Return assessment level [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90919 [21:59:26] (03PS1) 10Aklapper: Remove unused custom help.css file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91777 [22:00:24] (03PS1) 10Jdlrobson: Update links to feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/91778 [22:01:02] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91657 (owner: 10Bartosz Dziewoński) [22:01:03] awight: so, what's up (sorry, was on a call when you last messaged) [22:01:04] (03CR) 10Jdlrobson: [C: 032 V: 032] Update links to feature [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/91778 (owner: 10Jdlrobson) [22:01:32] greg-g: I jammed myself into the deploy lineup. starting now unless there are objections... [22:04:26] awight: no objections, we already have one group doing an LD at 4, so this is fine. [22:04:46] (03PS1) 10Aklapper: Remove custom skins.tgz file [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91780 [22:04:50] k [22:08:04] (03Abandoned) 10Physikerwelt: startup script skeleton for upstart [extensions/Math] - 10https://gerrit.wikimedia.org/r/90731 (owner: 10Physikerwelt) [22:09:46] greg-g: done, thanks! [22:11:11] (03PS1) 10Aklapper: Remove unused custom yui/calendar.css and yui/sprite.png [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91781 [22:11:12] (03PS1) 10Kaldari: Adding some comments to explain what various classes are for. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/91782 [22:12:52] (03PS1) 10Addshore: add basic Status unit test [core] - 10https://gerrit.wikimedia.org/r/91783 [22:13:03] aude: ^^ ;p [22:13:09] still a way to go [22:13:50] (03PS2) 10Addshore: add basic Status unit test [core] - 10https://gerrit.wikimedia.org/r/91783 [22:14:56] (03PS1) 10Brian Wolff: Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 [22:16:46] (03CR) 10jenkins-bot: [V: 04-1] Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 (owner: 10Brian Wolff) [22:16:56] boo! [22:17:05] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [22:17:08] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [22:18:52] (03PS4) 10MarkTraceur: Fix a few fullscreen bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 [22:19:23] (03PS3) 10MarkTraceur: Fixes from MLB upstream [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91531 [22:19:31] (03PS3) 10MarkTraceur: Clear interface before opening again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91533 [22:21:25] (03PS8) 10MarkTraceur: Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 [22:22:38] (03PS11) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [22:23:36] (03CR) 10Krinkle: "Please use a more descriptive and consistent message key in the future. "tooltip-iwiki" is not very descriptive and "iwiki" is not consist" [core] - 10https://gerrit.wikimedia.org/r/35871 (owner: 10Wizardist) [22:24:16] (03PS16) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [22:24:16] jdlrobson: "Uncaught InvalidCharacterError: The string contains invalid characters. " [22:24:26] jdlrobson: http://jonrobson.me.uk/lsg/ no work for me. :-( [22:24:42] what browser? which stylesheet you trying it on? still a few teething problems ;-) [22:24:52] send me the stylesheet and i'll fix it pronto [22:25:03] jdlrobson: All of them, Chrome/Mac. [22:25:34] jdlrobson: The base page throws "Uncaught InvalidCharacterError: The string contains invalid characters. " and "Uncaught TypeError: Cannot call method 'init' of undefined " [22:25:56] (03PS3) 10Addshore: add basic Status unit test [core] - 10https://gerrit.wikimedia.org/r/91783 [22:26:23] jdlrobson: What browser did it work in for you? Firefox? [22:27:22] (03CR) 10Krinkle: "Filed tech debt bug 56129, please (author/reviewer) resolve before 1.22." [core] - 10https://gerrit.wikimedia.org/r/35871 (owner: 10Wizardist) [22:33:03] (03CR) 10Gergő Tisza: [C: 032] Fix a few fullscreen bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 (owner: 10MarkTraceur) [22:33:11] (03Merged) 10jenkins-bot: Fix a few fullscreen bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 (owner: 10MarkTraceur) [22:33:27] Woo. [22:33:36] * marktraceur will never lose enthusiasm about that [22:33:37] Krinkle: I'll amend to use $.parseJSON -- any other outstanding issues before i do? [22:34:03] (03PS3) 10MarkTraceur: EventLogging support for MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 [22:34:13] Ah crap I'm gonna need to do more rebasing [22:34:14] ori-l: That was a generic reply (had it drafted in gerrit, forgot to submit) [22:34:18] * marktraceur hates this game [22:34:31] ori-l: I don't think using parseJSON is needed in this case since we also need JSON.stringify later on, right/ [22:34:33] Krinkle: actually, let's not use $.parseJSON [22:34:34] right [22:35:08] * ori-l really really wants to test this on beta labs [22:36:06] ori-l: I'm collapsing from a long day traveling and getting my visa stuff in order (which I didn't succeed in yet..) - I'll check it out tomorrow and verify the issues are solved. The script array bug I can tell is resolved easily by looking at the diff. I'll be checking how the error handling goes. [22:36:40] and throwing it a few curve balls to see how it behaves [22:36:40] Krinkle: are you cool with Roan merging it if he's satisfied that it works? [22:37:06] I think I can get it out today for the beta cluster, prob not tomorrow since it's Friday [22:37:15] James_F: Chrome Mac for me too. that's weird.. [22:37:28] ori-l: we can merge in master on any day, and beta deploy is automatic, right? [22:37:49] Krinkle: hrm, right. I guess the wmf-config change for the beta cluster could go out on a Friday [22:38:25] James_F: what version of Chrome? [22:38:36] jdlrobson: 30. [22:38:45] (03CR) 10Krinkle: "To another reviewer: please verify that debug mode isn't broken, that switching between debug mode true/false works properly and that modu" [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [22:38:53] James_F: same.. this is super weird [22:38:57] can you show me? [22:38:58] ori-l: anyway, summarised my concerns ^ [22:39:01] jdlrobson: FWIW, I totally agree that we need to do a serious push on tech debt. [22:39:08] roan can merge it [22:39:09] i'm in quarterly review right now but am keen to fix any bugs [22:39:10] jdlrobson: Of course - want to come over? [22:39:10] Does anyone else get the impression that they're just straight up fabricating version numbers at this point? [22:39:19] James_F: will come over after :) [22:39:24] I just figure beta has a lot of extensions / modules, and we'd catch stuff pretty quickly, and my preference would be to just follow-up with a bugfix for any outstanding issues we discover in beta [22:39:24] though I will likely be awake much earlier [22:39:26] jdlrobson: OK. [22:39:26] Krinkle: cool, thanks [22:39:29] my tomorrow is in 7 hours [22:39:36] Krinkle: oh, ok :) [22:39:42] i can probably sit on my hands that long [22:39:45] which means my today must end within a few minutes [22:39:49] (03CR) 10Gergő Tisza: [C: 032] Fixes from MLB upstream [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91531 (owner: 10MarkTraceur) [22:39:50] sleep well [22:39:51] cya! [22:39:54] (03Merged) 10jenkins-bot: Fixes from MLB upstream [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91531 (owner: 10MarkTraceur) [22:40:29] (03PS6) 10MarkTraceur: Add license to the header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 [22:40:51] (03Abandoned) 10MarkTraceur: Merge repo info patch into extmeta patch [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90425 (owner: 10MarkTraceur) [22:41:06] (03CR) 10Gergő Tisza: [C: 032] Clear interface before opening again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91533 (owner: 10MarkTraceur) [22:41:10] (03Merged) 10jenkins-bot: Clear interface before opening again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91533 (owner: 10MarkTraceur) [22:41:11] Oh my god the open MMV patches fit on the dashboard now [22:41:20] marktraceur: :-D [22:41:28] (03PS2) 10Brian Wolff: Extract list of languages svg is translated into. [core] - 10https://gerrit.wikimedia.org/r/91784 [22:42:07] Oh right [22:42:11] (03CR) 10Krinkle: "Ugh, wrong patch set." [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [22:42:18] * marktraceur opens deploy review bugs for CMD and MMV [22:42:39] (03CR) 10Krinkle: "To another reviewer: please verify that debug mode isn't broken, that switching between debug mode true/false works properly and that modu" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [22:46:40] (03CR) 10Gergő Tisza: [C: 032] Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 (owner: 10MarkTraceur) [22:46:41] addshore: nice :) [22:46:44] (03Merged) 10jenkins-bot: Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 (owner: 10MarkTraceur) [22:47:04] every once in awhile the memcache server on our labs instance (ee-flow) will report 99% cpu usage. I've strace'd the process and its not reading or writing anything to network sockets (would be visible as system calls) ... any idea whats wrong? Typically i just bounce memcache when i notice [22:47:26] unfortunatly i just bounced it so not investigatable right now, but what should i look for next time> [22:47:38] (03CR) 10Gergő Tisza: [C: 032] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [22:47:40] (03CR) 10jenkins-bot: [V: 04-1] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [22:47:57] Aughhh [22:48:01] It was going so bloody well [22:48:46] (03CR) 10Gergő Tisza: [C: 032] Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [22:50:16] (03CR) 10jenkins-bot: [V: 04-1] Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [22:53:08] (03PS3) 10Aaron Schulz: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 [22:53:26] csteipp: so is https://gerrit.wikimedia.org/r/#/c/91488/ ok ? [22:53:54] (03PS1) 10Aklapper: Clean up custom index.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91792 [22:54:16] AaronSchulz: I think so. I was going to give Elsie a little while to raise any objections, but otherwise I'd merge it. [22:56:01] (03PS17) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [22:56:12] (03CR) 10Gergő Tisza: [C: 032] EventLogging support for MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 (owner: 10MarkTraceur) [22:56:16] (03Merged) 10jenkins-bot: EventLogging support for MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 (owner: 10MarkTraceur) [22:58:50] (03CR) 10Gergő Tisza: [C: 032] Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [22:58:53] (03Merged) 10jenkins-bot: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [22:59:06] (03PS1) 10EBernhardson: Post action permissions for reply and edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91793 [22:59:22] (03PS12) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [22:59:27] (03CR) 10jenkins-bot: [V: 04-1] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [22:59:28] (03CR) 10Gergő Tisza: [C: 032] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [22:59:28] (03CR) 10jenkins-bot: [V: 04-1] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [22:59:40] (03PS13) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [23:03:08] (03CR) 10Gergő Tisza: [C: 032] Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [23:03:18] (03Merged) 10jenkins-bot: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [23:03:41] (03PS1) 10Aklapper: Delete custom IE-fixes.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91794 [23:05:58] (03CR) 10EBernhardson: [C: 032] Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [23:06:10] (03Merged) 10jenkins-bot: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [23:06:29] (03PS2) 10EBernhardson: Post action permissions for reply and edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91793 [23:08:38] (03PS13) 10Gergő Tisza: Make FormatMetadata accept RequestContext, instead of hard coding $wgLang. [core] - 10https://gerrit.wikimedia.org/r/78162 (owner: 10Brian Wolff) [23:09:10] (03PS17) 10Gergő Tisza: Add "extended" file metadata to API [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [23:09:38] (03PS9) 10Gergő Tisza: Add extmetadata to the ForeignAPIFile iiprops [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [23:10:09] tgr: I'm not convinced we need ^ that patch anymore [23:10:33] Unless we only want CMD on Commons proper [23:11:09] maybe not only, but we definitely do want it on commons [23:11:30] so its needed as far as i can see [23:12:15] tgr: Let's talk about the performance implications of that tomorrow maybe [23:13:17] (03PS18) 10Gergő Tisza: Add "extended" file metadata to API [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [23:13:18] (03PS10) 10Gergő Tisza: Add extmetadata to the ForeignAPIFile iiprops [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [23:14:08] You can hook into the core module and therefore add it via an extension [23:15:04] (03PS3) 10Bartosz Dziewoński: Triple default $wgMaxShellMemory (raise to 300 MB) [core] - 10https://gerrit.wikimedia.org/r/91501 [23:17:14] (03PS4) 10Bartosz Dziewoński: Triple default $wgMaxShellMemory (raise to 300 MB) [core] - 10https://gerrit.wikimedia.org/r/91501 [23:17:55] (03CR) 10Bartosz Dziewoński: "+release notes (for 1.22, I think this should go in the release)." [core] - 10https://gerrit.wikimedia.org/r/91501 (owner: 10Bartosz Dziewoński) [23:18:25] (03CR) 10Gergő Tisza: [C: 04-1] "Language settings were not respected in the file part of the extmetadata (specifically, XMP-like multilang arrays were returned even when " [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [23:19:03] (03CR) 10Gergő Tisza: "(rebased)" [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [23:24:28] marktraceur: lets do that, see you tomorrow [23:33:54] (03PS1) 10Aaron Schulz: Fixed broken quickDescribe() method [core] - 10https://gerrit.wikimedia.org/r/91799 [23:36:25] (03PS1) 10Kaldari: Update MobileFrontend with cherrypick [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91800 [23:36:46] (03CR) 10Kaldari: [C: 032] Update MobileFrontend with cherrypick [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91800 (owner: 10Kaldari) [23:37:35] (03PS1) 10Aklapper: Clean up custom show_bug.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91801 [23:37:37] (03CR) 10BryanDavis: [C: 032] Fixed broken quickDescribe() method [core] - 10https://gerrit.wikimedia.org/r/91799 (owner: 10Aaron Schulz) [23:41:22] (03Merged) 10jenkins-bot: Update MobileFrontend with cherrypick [core] (wmf/1.23wmf1) - 10https://gerrit.wikimedia.org/r/91800 (owner: 10Kaldari) [23:42:53] (03Merged) 10jenkins-bot: Fixed broken quickDescribe() method [core] - 10https://gerrit.wikimedia.org/r/91799 (owner: 10Aaron Schulz) [23:43:18] (03PS1) 10Aaron Schulz: Added --sleep-per-batch to purgeChangedFiles.php [core] - 10https://gerrit.wikimedia.org/r/91802 [23:43:33] (03PS7) 10Aaron Schulz: filebackend: Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 [23:43:57] (03PS8) 10Aaron Schulz: filebackend: Added supported for retrieving file metadata/headers [core] - 10https://gerrit.wikimedia.org/r/86642 [23:52:16] (03PS1) 10Kaldari: Update MobileFrontend for cherrypick [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91805 [23:52:33] (03CR) 10Kaldari: [C: 032] Update MobileFrontend for cherrypick [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91805 (owner: 10Kaldari) [23:52:44] (03PS6) 10Brian Wolff: Cache page content language in Title object [core] - 10https://gerrit.wikimedia.org/r/90769 [23:53:17] (03CR) 10Brian Wolff: "PS6: per Aaron" [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [23:57:47] (03Merged) 10jenkins-bot: Update MobileFrontend for cherrypick [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91805 (owner: 10Kaldari) [23:58:47] Is the current setup with bugzilla attachments ("The attachment is not viewable in your browser due to security restrictions enabled by your Bugzilla administrator") a permanent change, or is there a bug-ticket for it? [23:59:22] (03PS1) 10CSteipp: Improve wiki selection [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91806 [23:59:26] quiddity, https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 [23:59:51] ty Krenair :)