[00:01:23] Hi, everyone, I have a quick question: does anyone know how to create a message with an internal link to a subpage? I'm able to create on with a link to a normal page, but as soon as there's a slash in the title, it doesn't get rendered as a link... [00:01:44] (03Draft2) 10Addshore: General cleanup of Parser tests [core] - 10https://gerrit.wikimedia.org/r/91324 [00:02:03] As in, if my message text is 'Check out [[Article Title]]', I get Article Title rendered as an internal link correctly [00:03:23] But if I my message is 'Check out [[Article/Sub Page]]' it gets rendered as Article/Sub Page [00:04:10] (03CR) 10Addshore: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91154 (owner: 10Addshore) [00:05:10] I've been digging into the core Message class to figure it out, but if anyone happens to know the answer... [00:05:39] (Or maybe this is the wrong place to ask?) [00:06:26] AndyRussG: Are you *on* said page? [00:06:31] Because that's what selflink means [00:06:52] RoanKattouw: is there a daily limit on waffles/day per person? [00:07:01] Not as far as I'm concerned [00:07:08] ;) [00:07:10] There will be more tomorrow [00:07:23] there would be even more if you went to costco [00:07:32] True [00:07:40] Well, we did go, but we didn't pick up any of those stroopwafels [00:09:16] RoanKattouw: I guess sort of. The message is to go in an ErrorPageError that comes from said page [00:10:13] AndyRussG: What I'm asking is, does the [[../Foo]] link link to the current page? [00:11:03] Yes, basically. I mean, that must be it [00:11:05] (03PS8) 10Werdna: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 [00:11:46] Well then it's behaving "correctly" [00:11:56] The URL has "title=Said_Page&action=edit" in it, but the user is actually getting an error page [00:12:04] Right, yeah [00:13:09] I do want it to be an actual link. Context: the EP extension, the user creates a EP page, such as a course, then hits the back button and tries to re-submit the form they used for creating the page [00:13:39] OK [00:13:43] Well you can't easily do that in wikitext [00:13:56] So I'm throwing an ErrorPageError [00:14:02] You can, however, put a $1 in that spot in the message and have PHP generate the link and substitute it in [00:14:09] (03PS9) 10Werdna: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 [00:14:29] OK [00:14:35] I guess that's the easiest way to go [00:15:43] (03CR) 10Anomie: "Err, the manual says it has no effect when /m *is* specified." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [00:16:02] Seems a bit workaround-y, maybe there's a standard way of getting the URL for the "Read" tab or something [00:16:25] I guess I see how to get the URL, sorry [00:18:49] (03CR) 10Aaron Schulz: [C: 032] "Can't hurt" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/90543 (owner: 10Anomie) [00:18:51] Still if I make the anchor element myself, and one day the parser changes some detail about the HTML created for internal links... [00:19:55] (03Merged) 10jenkins-bot: Vary on X-Forwarded-Proto for changing-protocol redirects [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/90543 (owner: 10Anomie) [00:20:29] TimStarling: is https://gerrit.wikimedia.org/r/#/c/67387/2 ok? [00:21:17] ori-l: Re localStorage commit, you removed wgDBname from the vary keys, doesn't that break things? [00:22:52] (03PS3) 10Tim Starling: Avoid master queries in Revision::newFromTitle(..., Revision::READ_NORMAL) [core] - 10https://gerrit.wikimedia.org/r/67387 [00:22:58] (03CR) 10Tim Starling: [C: 032] Avoid master queries in Revision::newFromTitle(..., Revision::READ_NORMAL) [core] - 10https://gerrit.wikimedia.org/r/67387 (owner: 10Tim Starling) [00:23:19] yes, it looks fine [00:23:35] I'm just reviewing anomie's linkprefix thing [00:23:45] (03CR) 10Aaron Schulz: [C: 031] Avoid master queries in Revision::newFromTitle(..., Revision::READ_NORMAL) [core] - 10https://gerrit.wikimedia.org/r/67387 (owner: 10Tim Starling) [00:24:29] I am reviewing the regexes, it looks like nobody else has done that [00:24:31] RoanKattouw: I did on Timo's suggestion. What breakage do you expect? [00:25:56] ori-l: Two wikis on the same domain would share the same cache, so they would pollute each others' caches, right? [00:26:24] (03PS1) 10CSteipp: Utility function to get central id from username [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91329 [00:26:30] RoanKattouw: only if the modules had the same mtime but different contents [00:27:03] (03PS1) 10CSteipp: Implement OAuth hook to get userid from username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/91331 [00:27:34] RoanKattouw: maybe wgDBname should be part of the localStorage key, rather than the interned vary string? [00:28:21] if we vary on wgDBname but keep the key the same for multiple wikis, the use of localStorage would almost certain be detrimental to performance, since you'd be rebuilding the module cache every time you move from one wiki to the other [00:28:32] (03Merged) 10jenkins-bot: Avoid master queries in Revision::newFromTitle(..., Revision::READ_NORMAL) [core] - 10https://gerrit.wikimedia.org/r/67387 (owner: 10Tim Starling) [00:29:07] Right, yeah [00:29:12] So we should put it in the key then [00:29:50] (03CR) 10CSteipp: "Doesn't work on non-central wikis at the moment, since the ListConsumers page is only on the central wiki. But we can fix that once Ie17ca" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91295 (owner: 10Anomie) [00:29:51] (03CR) 10Aaron Schulz: [C: 04-1] "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91329 (owner: 10CSteipp) [00:30:03] OK, that's an easy change, I'll amend -- don't run away yet :P [00:30:50] RoanKattouw: thanks so much for the help. Hi to everyone else, too [00:32:43] ori-l: RoanKattouw: I did indeed point it out, but afaik it wasn't to make it clash, more to make it not clash. [00:32:50] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/91331 (owner: 10CSteipp) [00:32:55] I considered two wikis on 1 domain, that was the reason iirc. [00:33:12] Krinkle: What if the 2 wikis are different versions? :D [00:33:25] RoanKattouw: Whether they're different versions doesn't matter, it shouldn't clash. [00:33:46] e.g. separate storage for that reasons, exactly because they can be different versions [00:33:53] also because it can be a different user or configuration. [00:33:58] e.g. languagedata comes to mind. [00:34:03] (03PS5) 10Aaron Schulz: Cache page content language in Title object. [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [00:34:05] Yeah as we were saying they should just use different localStorage keys so they're completely separate [00:35:23] ori-l: Also I think you should make mw.loader.store.init() idempotent. I assumed it was because (as Krinkle pointed out) there's a code path that potentially calls it multiple times, but it doesn't seem to be [00:36:06] loader.work() runs multiple times [00:36:12] which is where it was in [00:38:11] (03CR) 10Catrope: [C: 04-1] "Per IRC conversation:" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [00:41:31] RoanKattouw: how would you feel about doing it by having init set itself to $.noop? [00:41:40] lol [00:41:53] That sounds fine [00:42:08] I guess there's no usage of this. anywhere [00:42:14] What about all the .enabled checks though? [00:42:30] what about them? [00:42:45] Oh, I see, that's determined dynamically in init [00:43:16] Well I suppose if you're going that route, then if init detects that the store isn't enabled, it could $.noop out the remaining methods too [00:43:29] But I think it's probably clearer if we just write if ( !condition ) { return ; } at the top of each function [00:43:33] (03PS3) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [00:43:40] Otherwise it's fairly mysterious to readers of the code [00:43:47] alternately 'enabled' could be set to null by default and 'false' by init if it determines it shouldn't enable the store [00:43:54] hmmmm [00:44:01] Actually let's just go with simple if checks [00:44:22] $.noop is clever but hurts readability and init() isn't called *that* often [00:44:57] (03CR) 10Tim Starling: "The regex is very impressive. It was your own idea?" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [00:45:29] RoanKattouw: so -- are you saying I shouldn't modify it? [00:45:36] Yeah [00:45:57] Oh, wait now I see what you meant by making .enabled tri-state [00:45:59] That takes care of it too [00:46:09] Because init() can just refuse to run if .enabled !== null [00:46:15] since that means it's already run before [00:46:31] right [00:46:36] I think that's probably best, no? [00:47:11] Yes [00:47:17] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [00:47:22] Good suggestion, I just didn't immediately see the connection there :) [00:52:25] (03PS15) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [00:52:29] RoanKattouw: amended [00:57:04] (03CR) 10Ori.livneh: "PS15:" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [01:04:18] (03CR) 10Tim Starling: "I was thinking about doing the fuzz tester myself, but maybe that's not wise if the bug has been open for months and there's lots of other" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [01:05:41] ori-l: i guess you had seen https://github.com/gibiansky/IHaskell [01:05:48] yes :) [01:07:19] ori-l: I tested it locally and found a bug. It never populates an empty localStorage [01:07:35] (03CR) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [01:07:46] Basically on first load, there won't be anything in LS for this feature because you've just enabled it, and so init() thinks there was some sort of problem and disables itself [01:09:15] RoanKattouw: yes. it should be set to false before the try block [01:09:23] this would also prevent hanging localStorage calls from piling [01:09:23] (03CR) 10Werdna: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [01:09:45] ori-l: No no you misunderstand the issue [01:09:50] It ends up being explicitly set to false [01:10:03] yes, I know, I was just thinking about where it should move to [01:10:11] Because localStorage.get() returns null, JSON.parse(null) apparently gracefully returns nullm etc, [01:10:21] Hmm, maybe raw should be initialized as undefined instead? [01:10:37] (03CR) 10Tim Starling: "> Err, the manual says it has no effect when /m *is* specified." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [01:10:39] Then there will be three possible values for raw [01:10:51] undefined means calling localStore.getItem() crashed [01:10:56] null means the localStorage key is missing [01:11:09] Any other value means we failed to interpret what came back from localStorage [01:11:32] RoanKattouw: I think that's best, yes. [01:11:36] that's a good idea. [01:15:34] (03PS16) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [01:15:51] RoanKattouw: OK, amended and tested all scenarios [01:16:16] you can test the localStorage crashes scenario by just changing localStorage.getItem to nonexistent.getItem [01:16:37] (03PS2) 10CSteipp: Utility function to get central id from username [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91329 [01:19:06] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [01:20:04] I hope that's not a jsduck failure, ori-l will haunt me. [01:20:08] No [01:20:09] jshint [01:20:19] ori-l: jshint disapproves of explicitly doing var raw = undefined; [01:20:31] Instead simply do var raw; and it'll be undefined [01:20:45] really? you don't think that that is worse? [01:20:56] (03PS2) 10CSteipp: Implement OAuth hook to get userid from username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/91331 [01:21:07] I think being explicit makes the intent clearer, but sure [01:21:16] between that and adding a jshint exemption [01:21:31] Or add a comment? [01:21:42] var foobar, raw/* = undefined*/; or something [01:22:05] (Also as a matter of style, explicitly initialized variables should come after uninitialized ones, so var raw = undefined, foo; was wrong anyway [01:22:19] * ori-l eats his hat. [01:22:34] I think /* = undefined */ seems weird; I'll just leave it uninitialized [01:22:38] k [01:23:15] (03PS17) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [01:23:29] RoanKattouw: thanks for looking at this btw, if there's something I can take off your plate let me know [01:24:13] Nothing I can think of offhand [01:24:20] <^d> Poor me :( [01:24:22] <^d> https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-OSX-10.9 [01:27:25] VAGRANT! [01:27:54] (03CR) 10Werdna: "(7 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 (owner: 10EBernhardson) [01:28:08] YOU VAGRANT [01:28:13] * werdna tells off YuviPanda  [01:38:24] <^d> YuviPanda: That'd be nice. [01:38:50] <^d> But useless for what I want to do. I need to either compile for OSX or have a fast VM. [01:38:55] right [01:38:57] <^d> Virtualbox is many things. Fast is not one of them. [01:39:53] (03CR) 10Anomie: "Yes, the regex is my own creation. Thanks." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [01:40:20] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [01:43:09] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [01:59:36] (03CR) 10Catrope: [C: 031] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [02:25:04] (03PS1) 10Werdna: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 [02:35:16] (03CR) 10Tim Starling: "> The link prefix feature as a whole could probably use improvement -- I will file a bug with some ideas. But I don't think that should ho" [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [03:21:59] (03PS2) 10Tim Starling: Use restriction-level-* messages in Linker::formatTemplates [core] - 10https://gerrit.wikimedia.org/r/90551 (owner: 10Anomie) [03:22:05] (03CR) 10Tim Starling: [C: 032] Use restriction-level-* messages in Linker::formatTemplates [core] - 10https://gerrit.wikimedia.org/r/90551 (owner: 10Anomie) [03:27:14] (03Merged) 10jenkins-bot: Use restriction-level-* messages in Linker::formatTemplates [core] - 10https://gerrit.wikimedia.org/r/90551 (owner: 10Anomie) [03:32:07] (03PS4) 10Parent5446: Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 [03:32:42] (03CR) 10jenkins-bot: [V: 04-1] Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [03:35:28] (03CR) 10Tim Starling: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90552 (owner: 10Anomie) [03:41:49] (03CR) 10Tim Starling: [C: 04-1] "Were you intending on actually using $1 in the three relevant messages?" [core] - 10https://gerrit.wikimedia.org/r/90357 (owner: 10Anomie) [03:45:29] (03PS5) 10Parent5446: Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 [03:47:04] (03CR) 10jenkins-bot: [V: 04-1] Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [03:54:45] (03PS2) 10Werdna: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 [03:57:59] (03PS6) 10Parent5446: Moved account creation throttle to ping limiter [core] - 10https://gerrit.wikimedia.org/r/65867 [04:07:49] (03CR) 10Ori.livneh: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [04:12:37] (03PS18) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [04:12:55] (03PS19) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [04:14:10] (03CR) 10Ori.livneh: "PS18: change $.isEmptyObject check to check mw.loader.store.enabled instead; removed extra whitespace from implements script. PS19: rebase" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [04:17:30] (03Abandoned) 10Tim Starling: Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [04:27:27] * werdna chuckles at TimStarling's commit message [04:54:49] (03Restored) 10Ori.livneh: Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [04:55:24] (03CR) 10Ori.livneh: [C: 031] Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [05:21:13] so I was cleverly checking for lqt-post classes in a piece of Flow code [05:21:18] old habits die hard [05:32:47] (03PS3) 10Werdna: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 [05:48:26] (03PS7) 10Tim Starling: Parser::replaceInternalLinks: fix batching [core] - 10https://gerrit.wikimedia.org/r/89835 (owner: 10PleaseStand) [05:48:30] (03CR) 10Tim Starling: [C: 032] Parser::replaceInternalLinks: fix batching [core] - 10https://gerrit.wikimedia.org/r/89835 (owner: 10PleaseStand) [05:53:10] (03Merged) 10jenkins-bot: Parser::replaceInternalLinks: fix batching [core] - 10https://gerrit.wikimedia.org/r/89835 (owner: 10PleaseStand) [05:58:36] (03CR) 10Ori.livneh: "Ping?" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/86395 (owner: 10Ori.livneh) [06:00:15] (03PS1) 10Tim Starling: Remove poorly-phrased doc comment and the FIXME which went with it [core] - 10https://gerrit.wikimedia.org/r/91346 [06:04:57] (03CR) 10Ori.livneh: "The same two lines also appear in in the doc block for Parser::replaceLinkHolders (includes/parser/Parser.php 5039-5041)." [core] - 10https://gerrit.wikimedia.org/r/91346 (owner: 10Tim Starling) [06:14:52] (03PS8) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [06:17:47] (03CR) 10Adamw: [C: 031] "Will character literals be highlighted correctly?" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/86395 (owner: 10Ori.livneh) [06:22:50] (03CR) 10Adamw: [C: 031] "Hehe, I seriously doubt Tim's claim to have read the surrounding context. Almost every one of these examples embeds "iff" in some horribl" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [06:32:42] (03PS4) 10Werdna: Post permalinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 [06:32:44] (03PS1) 10Werdna: Add basic experimental hotkey navigation. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91348 [06:33:02] (03CR) 10jenkins-bot: [V: 04-1] Add basic experimental hotkey navigation. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91348 (owner: 10Werdna) [06:39:42] (03CR) 10KartikMistry: [C: 031] "LGTM." [extensions/cldr] - 10https://gerrit.wikimedia.org/r/90890 (owner: 10Siebrand) [06:45:56] (03PS1) 10Rfaulk: add - test repo and key path config to git config. [sartoris] - 10https://gerrit.wikimedia.org/r/91349 [06:46:20] (03CR) 10Rfaulk: [C: 032 V: 032] add - test repo and key path config to git config. [sartoris] - 10https://gerrit.wikimedia.org/r/91349 (owner: 10Rfaulk) [06:58:24] (03PS1) 10Rfaulk: mod - remove PKEY and PROJECT_PATH deps. [sartoris] - 10https://gerrit.wikimedia.org/r/91350 [06:58:51] (03CR) 10Rfaulk: [C: 032 V: 032] mod - remove PKEY and PROJECT_PATH deps. [sartoris] - 10https://gerrit.wikimedia.org/r/91350 (owner: 10Rfaulk) [07:06:15] (03PS2) 10Siebrand: Update formatting [extensions/cldr] - 10https://gerrit.wikimedia.org/r/90890 [07:07:22] (03Abandoned) 10Siebrand: Update formatting [extensions/cldr] - 10https://gerrit.wikimedia.org/r/90890 (owner: 10Siebrand) [07:08:34] (03CR) 10Amire80: [C: 032] mw.api.postWithToken now forwards promise on fail if we have token [core] - 10https://gerrit.wikimedia.org/r/91159 (owner: 10Nikerabbit) [07:11:23] (03Merged) 10jenkins-bot: mw.api.postWithToken now forwards promise on fail if we have token [core] - 10https://gerrit.wikimedia.org/r/91159 (owner: 10Nikerabbit) [07:39:35] hellllo [07:58:16] (03PS3) 10Hashar: Cleanup MagicVariableTest [core] - 10https://gerrit.wikimedia.org/r/91158 (owner: 10Addshore) [07:58:38] (03CR) 10Hashar: [C: 032] "Thank you Addshore and Jan :-]" [core] - 10https://gerrit.wikimedia.org/r/91158 (owner: 10Addshore) [07:59:32] (03CR) 10jenkins-bot: [V: 04-1] Cleanup MagicVariableTest [core] - 10https://gerrit.wikimedia.org/r/91158 (owner: 10Addshore) [07:59:49] (03CR) 10Hashar: "I have manually cancelled test job" [core] - 10https://gerrit.wikimedia.org/r/91158 (owner: 10Addshore) [08:01:59] (03Merged) 10jenkins-bot: Cleanup MagicVariableTest [core] - 10https://gerrit.wikimedia.org/r/91158 (owner: 10Addshore) [08:38:22] (03PS1) 10Rfaulk: mod - remove config_local deps. [sartoris] - 10https://gerrit.wikimedia.org/r/91354 [08:38:23] (03PS1) 10Rfaulk: mod - more example docs on README. [sartoris] - 10https://gerrit.wikimedia.org/r/91355 [08:38:26] (03CR) 10jenkins-bot: [V: 04-1] mod - remove config_local deps. [sartoris] - 10https://gerrit.wikimedia.org/r/91354 (owner: 10Rfaulk) [08:41:38] (03PS1) 10Rfaulk: fix - refs to config_local. [sartoris] - 10https://gerrit.wikimedia.org/r/91357 [08:41:49] (03CR) 10Rfaulk: [C: 032 V: 032] mod - remove config_local deps. [sartoris] - 10https://gerrit.wikimedia.org/r/91354 (owner: 10Rfaulk) [08:42:05] (03CR) 10Rfaulk: [C: 032 V: 032] mod - more example docs on README. [sartoris] - 10https://gerrit.wikimedia.org/r/91355 (owner: 10Rfaulk) [08:42:38] (03CR) 10Rfaulk: [C: 032 V: 032] fix - refs to config_local. [sartoris] - 10https://gerrit.wikimedia.org/r/91357 (owner: 10Rfaulk) [08:44:36] (03PS4) 10Netbrain: Added #subpage functionality and various minor fixes * improved error reporting on syntax failure * fixed small js scope issue [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 [08:54:27] (03CR) 10Nikerabbit: [C: 032] The first Jenkins job for Translate extension [selenium] - 10https://gerrit.wikimedia.org/r/91153 (owner: 10Zfilipin) [08:54:34] (03Merged) 10jenkins-bot: The first Jenkins job for Translate extension [selenium] - 10https://gerrit.wikimedia.org/r/91153 (owner: 10Zfilipin) [08:57:58] (03PS5) 10Netbrain: Added #subpage functionality and various minor fixes * improved error reporting on syntax failure * fixed small js scope issue [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90536 [09:03:55] (03Abandoned) 10Hashar: profiling: add newlines to profile errors [core] - 10https://gerrit.wikimedia.org/r/88990 (owner: 10Hashar) [09:58:07] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/55496 (owner: 10Bartosz Dziewoński) [09:59:34] (03PS1) 10Aklapper: Fix InlineHistory's "marked as a duplicate" detection being too eager [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91362 [10:00:31] (03PS1) 10Bartosz Dziewoński: tablesorter: Unbreak abbreviated month name support [core] - 10https://gerrit.wikimedia.org/r/91363 [10:01:04] (03CR) 10Aklapper: [C: 031] "Tested on http://boogs.wmflabs.org/show_bug.cgi?id=12 before and after applying the patch by disabling and re-enabling "When viewing a bug" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91362 (owner: 10Aklapper) [10:04:14] (03CR) 10Bartosz Dziewoński: [C: 031] "(1 comment)" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91362 (owner: 10Aklapper) [10:10:14] hashar: aware of anyone else I could add to these patchsets so you dont just get flooded by then? :P [10:11:15] addshore: jeroen ? [10:11:20] I am not sure [10:11:30] you could ask in wikitech-l as well [10:11:34] probably, he has enough of my patchsets already ;p [10:11:45] hehe [10:14:22] WikiPage class is no longer in the top 10 for worst risk ;p [10:31:24] (03CR) 10Mormegil: [C: 031] tablesorter: Unbreak abbreviated month name support [core] - 10https://gerrit.wikimedia.org/r/91363 (owner: 10Bartosz Dziewoński) [10:33:54] (03PS9) 10Hashar: (bug 43571) Fixing fatal error when duplicating VIEWs in MySQL [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [10:34:30] (03PS7) 10Ori.livneh: Log JSON-formatted exceptions to 'exception-json' log bucket [core] - 10https://gerrit.wikimedia.org/r/76304 [10:36:37] (03CR) 10Ori.livneh: "I finally found the time to come back to this patch. I wasn't able to separate the rebase from the code changes this time around. PS7 pres" [core] - 10https://gerrit.wikimedia.org/r/76304 (owner: 10Ori.livneh) [10:37:22] hashar: you might remember this patch from august ^ :) [10:37:35] i put it off until now [10:38:25] ahh yeah [10:38:30] good morning ori-l [10:38:38] Nikerabbit: i'm going to bed [10:38:40] ! [10:38:40] [10:38:41] ori-l: will attempt to have a look at it this afternoon if time allow [10:38:50] ori-l: and we got to get it on beta :] sleep well! [10:39:26] ori-l: it will be morning there soon ;) [10:39:55] Nikerabbit: i am too excited about the unicode conference keynote to sleep [10:40:07] (sorry, couldn't resist) [10:40:55] OK, not funny. FINE. :D /me sleeps. [10:46:52] (03PS1) 10Raimond Spekking: Add i18n file [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/91368 [10:54:59] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [10:57:28] (03PS1) 10Zfilipin: WIP Moved MediaWiki username and password from general Jenkins configuration to jobs [selenium] - 10https://gerrit.wikimedia.org/r/91369 [11:09:34] (03Abandoned) 10Tim Starling: Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [11:17:22] (03CR) 10Santhosh: [C: 032] Do not add empty arrays [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91192 (owner: 10Siebrand) [11:17:32] (03Merged) 10jenkins-bot: Do not add empty arrays [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91192 (owner: 10Siebrand) [11:58:08] re [11:58:26] Has synchronisation from gerrit to GitHub stopped? [11:59:00] I see Cleanup MagicVariableTest as last commit there. [11:59:36] false alert. Please ignore. [12:26:16] (03PS3) 10Hashar: General cleanup of Parser tests [core] - 10https://gerrit.wikimedia.org/r/91324 (owner: 10Addshore) [12:27:07] (03CR) 10jenkins-bot: [V: 04-1] General cleanup of Parser tests [core] - 10https://gerrit.wikimedia.org/r/91324 (owner: 10Addshore) [12:27:21] (03CR) 10Hashar: [C: 032] General cleanup of Parser tests [core] - 10https://gerrit.wikimedia.org/r/91324 (owner: 10Addshore) [12:30:08] (03Merged) 10jenkins-bot: General cleanup of Parser tests [core] - 10https://gerrit.wikimedia.org/r/91324 (owner: 10Addshore) [12:31:05] (03PS5) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88466 [12:33:19] (03PS6) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88466 [12:34:08] (03CR) 10Siebrand: "PS5 and PS6 fix merge conflicts." [core] - 10https://gerrit.wikimedia.org/r/88466 (owner: 10Siebrand) [12:38:49] (03PS2) 10Hashar: installer: shows status message on DB connection error [core] - 10https://gerrit.wikimedia.org/r/87054 [12:42:08] (03PS7) 10Hashar: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88466 (owner: 10Siebrand) [12:42:59] (03CR) 10jenkins-bot: [V: 04-1] Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88466 (owner: 10Siebrand) [12:43:22] (03CR) 10Hashar: [C: 032] Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88466 (owner: 10Siebrand) [12:46:08] (03Merged) 10jenkins-bot: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88466 (owner: 10Siebrand) [12:47:05] (03PS1) 10Aklapper: Sync the MoreBugUrl default extension with upstream trunk. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91372 [12:50:02] (03CR) 10Parent5446: [C: 031] Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [13:03:01] (03PS41) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [13:05:09] PS41 [13:06:11] heh, nice. [13:06:44] +1950, -854 [13:07:05] i haven't seen this before, but looks pretty sexy according to the commit message [13:07:25] I had one that crossed 50, I think [13:08:25] mostly because of the github bot [13:10:37] yeah [13:10:38] agreed [13:11:01] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/91368 (owner: 10Raimond Spekking) [13:27:18] * YuviPanda waves at hashar [13:27:30] hashar: do we already have any project using zuul for checkstyle or findbugs? [13:27:36] java codelinting tool [13:27:37] s [13:32:53] (03PS1) 10Raimond Spekking: Avoid empty values for JS variables wgMonthNames/wgMonthNamesShort [core] - 10https://gerrit.wikimedia.org/r/91379 [13:33:03] YuviPanda: we have phpcs [13:33:18] hashar: doesn't really work for Java, does it? :D [13:33:21] YuviPanda: if there is a Java code linter you know that has a package in Precise, we can surely add it to the Jenkins slave [13:33:24] and build jobs for that [13:33:27] ok [13:33:31] phpcs does php/css :D [13:33:38] who would've thought :P [13:33:40] for Java I think the standard is something named checkstyle [13:33:44] yeah [13:33:58] first step: bug fill something in Wikimedia > continuous integration [13:34:09] :-] [13:34:09] $ apt-cache search checkstyl [13:34:10] checkstyle - checks Java source against a coding standard [13:34:10] \O: [13:34:14] hmm, I think we'll also add some android specific things [13:34:16] I mean \O/ [13:34:18] mvn check [13:34:30] yeah or that [13:34:34] :D [13:34:41] going to start on that next week [13:34:47] will file bugs when appropriate! [13:35:13] * brion wonders if we have an Obj-C linter :D [13:35:24] potentially [13:35:49] lang_objc [13:35:51] hmm [13:35:52] yeah [13:37:00] brion: Facebook as hired a french "OCAML" guy [13:37:16] being french and knowing ocaml, he unsurprisingly wrote a language static analyser [13:37:27] that seems to be common for that kind of pedigree (frecnh+ocaml) [13:37:28] :D [13:37:34] hehe [13:37:37] anyway, it is open source https://github.com/facebook/pfff/ [13:37:49] supports a bunch of C (cpp, sharp, objc) [13:37:50] and [13:37:55] wait for it [13:37:55] PHP !!! [13:37:55] nice [13:37:58] :D [13:38:07] as well as caml obviously [13:38:17] so basically it is parsing the source files into a common AST [13:38:29] and then there is a bunch of tools that let you analyze the language agnostic AST [13:38:40] awesome! [13:38:44] and find bugs / miss assignment, unused var / dup code whatever [13:38:51] but [13:38:58] I never managed to find time to seriously look at it :( [13:39:30] * brion wonders about a tool to automatically generate a cool clickable class diagram [13:39:52] class diagrams are cool? [13:40:16] brion: https://github.com/facebook/pfff/wiki/CodeMap#screnshots [13:40:20] err [13:40:32] those class diagrams are fucking scary :D [13:40:32] not what you are asking for [13:40:49] though a breakdown of 'where the hell is all the code' would be neat too [13:41:20] YuviPanda: those of us who didn't do formal CS didn't get diagram overload in school ;) [13:41:28] :D [13:41:30] probably that [13:41:35] when we start refactoring mediawiki core classes, we might well start adopting a convention like the ones being used in other php project [13:41:37] 'Animal inherits from Organism!' [13:41:44] haha [13:41:48] something like Foo_Bar_Dummy being in /foo/bar/dummy.php [13:42:02] yeah especially if we go namespaces \o/ [13:42:04] Foo_Bar_Dummy_Child /foo/bar/dummy/child.php [13:42:05] that'll be a fun day [13:42:10] yeah namespace hmm [13:42:13] you will have to fight for it :/ [13:42:18] hehe [13:42:24] the consensus is to be conservative and not use them in core [13:42:27] might be easier to switch everything to node.js ;)) [13:42:48] we aren't how namespaces is going to provide us added value :/ [13:42:51] why does consensus always tend to being conservative? tch tch [13:43:10] and node.js, you should talk with Gabriel. A crazy idea would be to make MediaWiki rely mostly on backend webservice [13:43:15] how can we get ahead with our goal of breaking things X times a year [13:43:18] mwahahaha [13:43:22] which would essentially provide a stable / well documentedAPI [13:43:33] and potentially we could phase out php and migrate to python :] [13:43:53] would be a few thousands lines hitting the backend services and serving JavaScript to the client [13:44:04] or s/python/nodejs/ [13:44:11] should RFC tht [13:44:22] i wish firefox nightly on android would update itself without prompting me... i wonder if there's a standard system permission for that or if google play is special-cased somehow [13:44:47] brion: INSTALL_PACKAGES [13:45:07] lemme check bugzilla.mozilla.org real quick before i forget :D [13:45:09] brion: but of course, that won't be granted to everyone :P needs to be signed [13:45:23] ooh, signed and nightly build probably don't agree ;) [13:45:39] yeah :) [13:45:59] brion: afaik there's no way to install an APK without the user having to click *something* [13:46:08] brion: if you just open it with apkinstaller, it asks 'are you sure?' [13:46:15] play is just granted that perm [13:46:26] so i've got a build environment for Firefox OS set up in my Ubuntu VM now. :D i'l have to try CyanogenMod or something too, play with that screen recording patch that's floating around [13:46:35] brion: heh [13:47:16] Just did a quick test comparing performance of Gerrit and GitHub. [13:47:18] FFOS is weird, at a low level it uses bunch of android pieces, but it's totally not android compatible :) so i guess ZTE isn't contractually prohibited from making phones that run it [13:47:32] Cloned 40 repos we use in twn. [13:47:41] GitHub: 2m23.024s [13:47:41] Gerrit: 2m41.518s [13:47:47] Updating them: [13:47:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Unless I'm missing something this will break code all over by making these arrays become objects when converted to JavaScript (as the zero" [core] - 10https://gerrit.wikimedia.org/r/91379 (owner: 10Raimond Spekking) [13:48:00] Gerrit: 0m48.768s [13:48:00] (03CR) 10Aklapper: [C: 04-1] "I just realized that the whole MoreBugUrl extension is currently completely useless on the server, as it misses some hooks in core that ar" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/91372 (owner: 10Aklapper) [13:48:00] GitHub: 0m28.886s [13:48:13] (repos were fully up to date, of course) [13:48:17] (03PS3) 10Hashar: mediawiki/conf.d/_join.php minor fix + comment update [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90114 [13:48:22] (03CR) 10Hashar: [C: 032] mediawiki/conf.d/_join.php minor fix + comment update [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90114 (owner: 10Hashar) [13:48:26] siebrand: nice! [13:48:26] (03Merged) 10jenkins-bot: mediawiki/conf.d/_join.php minor fix + comment update [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90114 (owner: 10Hashar) [13:49:15] These were the repos cloned: AdminLinks APC ApiSandbox Babel CharInsert cldr CleanChanges ConfirmEdit ContributionScores DataValues DeleteBatch EventLogging ExpandTemplates Gadgets I18nTags Interwiki InviteSignup LiquidThreads Maps NewUserMessage Nuke ParserFunctions Renameuser ReplaceText SemanticForms SemanticMaps SemanticMediaWiki Solarium SpamBlacklist SyntaxHighlight_GeSHi TitleBlacklist Translate TwnMainPage [13:49:16] UniversalLanguageSelector UserMerge UserOptionStats Validator Vector WebChat WikiEditor [13:50:13] We're now running twn's sandbox extensions off GitHub, but that'll likely be production too in the future. Much quicker updates. [13:50:27] :D [13:50:50] siebrand: deploying in the cluster usually doesn't make these issues apparent, since gerrit is local network [13:51:26] YuviPanda: 500ms/connect isn't just latency because of distance, I guess.... [13:51:48] siebrand: of course! gerrit re-implements its own ssh server and git protocol, so that's probably what is sucking [13:52:01] Also getting weird private key permission denied errors and stuff with Gerrit. [13:52:13] yeah, still intermittently getting those [13:52:19] (03Abandoned) 10Hashar: disable suoshin mem handler for code coverage [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/83940 (owner: 10Hashar) [13:52:28] possibly. Know little about gerrit, just that I have a love/hate relationship with it. [13:53:08] And that SSH on my windows installation basically still doesn't work with Gerrit, but it does with every other SSH git server [13:53:33] (03Draft2) 10Hashar: Cleanup skins/SiteBarTest and @todo/covers [core] - 10https://gerrit.wikimedia.org/r/91168 (owner: 10Addshore) [13:53:35] Except when it does work, some 1 out of 25 times, which is utterly confusing. [13:53:40] heh [13:53:42] addshore: still a draft so ? [13:53:55] ust published it [13:53:56] siebrand: we also have nobody working on fixing gerrit issues primarily, so [13:54:10] didnt notice :) [13:54:21] oh my trying to typeon a flexible keyboardis fun [13:54:29] it doesnt detect all ofthe keypresses.... [13:54:34] especiall space... [13:54:58] Wasn't there supposed to be a contractor for that at some point? Or has that come and gone? [13:55:10] (03CR) 10Raimond Spekking: "Does this mean, the empty value "" is there for reasons as mentioned above? Then this patch set should be abandoned and I will add a comme" [core] - 10https://gerrit.wikimedia.org/r/91379 (owner: 10Raimond Spekking) [13:55:29] siebrand: wasn't that qchris? [13:55:29] no idea [13:55:46] * qchris denies everything [13:55:57] * YuviPanda chains qchris to a rock [13:55:57] :P [13:56:06] Hmm, maybe. He's in Analytics now, at least that's what he proclaimed last time I asked him something about Gerrit :) [13:56:17] As long as it's not an RT ticket, I am fine with a rock. [13:56:37] * qchris reads scrollback [13:59:34] siebrand: Yes, I've been contracting around gerrit, but that contract ran out. I found a new contract in analytics, and I am trying to help out around gerrit wherever possible. [13:59:56] qchris: *nod* I figured that much :) [14:00:15] siebrand: We have fixed some gerrit SSH problems in the past. And gerrit's SSH is based on Apache MINA. [14:00:39] This project has many rough edges. [14:01:02] I also see the permission errors occasionally. [14:01:16] Like 1 in a few thousand commits. [14:01:45] And as we're like severly underpowered in Analytics, there is hardly time to work on such issues. [14:02:35] qchris: sure. No need to defend yourself. :) [14:02:36] But I really loved working on the gerrit side ... if there is need to devote more time to gerrit, please escalate. [14:03:13] Well ... yes, there is need to defend. It just plain sucks if gerrit gives you errors :-( [14:03:53] (03CR) 10Aklapper: "The way cleaner approach (less diff to upstream) would be using the MoreBugUrl extension, however that requires hooks in Bugzilla core whi" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/90565 (owner: 10Aklapper) [14:05:43] (03CR) 10Gergő Tisza: "The problem (or at least one problem, I don't know if there are other cases when the value is an array) is with multilingual XMP data whic" [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [14:14:57] 49.3138 284.0M Class array not found; skipped loading [14:14:58] bahh [14:18:28] (03CR) 10Mattflaschen: ""Because for some stupid reason the ping limiter doesn't apply IP-based limiting if the user is autoconfirmed (which makes literally no se" [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [14:23:04] (03PS2) 10Addshore: Refactor OutputPageTest [core] - 10https://gerrit.wikimedia.org/r/91154 [14:24:20] (03PS3) 10Addshore: Cleanup skins/SiteBarTest and @todo/covers [core] - 10https://gerrit.wikimedia.org/r/91168 [14:24:56] (03CR) 10Mattflaschen: [C: 04-1] "Or if not changed in the ping limiter, the behavioral change for account creation at least needs to be documented in the release notes. I" [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [14:25:28] any dev around know how to get the profiling in debug log ? [14:26:16] bah [14:26:26] Maintenance supports --profiler text :-] [14:27:23] time to attack some more tests :P [14:43:17] (03CR) 10Gergő Tisza: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff) [14:45:29] (03PS1) 10Hashar: mw-run-phpunit.sh: +api +parser targets [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91384 [14:45:33] (03CR) 10Hashar: [C: 032] mw-run-phpunit.sh: +api +parser targets [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91384 (owner: 10Hashar) [14:46:38] (03PS2) 10Hashar: mw-run-phpunit.sh: +api +parser targets [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91384 [14:46:49] (03CR) 10Hashar: [C: 032] mw-run-phpunit.sh: +api +parser targets [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91384 (owner: 10Hashar) [14:46:52] (03Merged) 10jenkins-bot: mw-run-phpunit.sh: +api +parser targets [integration/jenkins] - 10https://gerrit.wikimedia.org/r/91384 (owner: 10Hashar) [14:53:03] !jenkins mediawiki-core-phpunit-api [14:53:03] https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-api [14:55:30] (03CR) 10Brian Wolff: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff) [14:56:18] (03PS1) 10Hashar: mediawiki phpunit no more use ant and LOG! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91385 [15:01:09] Nikerabbit: I am hitting http://127.0.0.1:8080/wiki/Special:TranslationStash, but that just redirects me back to Main_page [15:01:09] wat [15:07:21] (03CR) 10Rtdwivedi: "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90741 (owner: 10Tpt) [15:11:29] (03PS1) 10Addshore: Add more ApiFormat tests [core] - 10https://gerrit.wikimedia.org/r/91388 [15:13:22] fucking gerrit [15:13:26] :D [15:16:37] YuviPanda: That'd be really uncomfortable! [15:17:54] (03CR) 10jenkins-bot: [V: 04-1] Add more ApiFormat tests [core] - 10https://gerrit.wikimedia.org/r/91388 (owner: 10Addshore) [15:22:00] Coren: indeed! [15:23:33] Java is full of holes [15:23:35] You'll be fine [15:25:33] (03PS2) 10Zfilipin: Updated Jenkins documentation [selenium] - 10https://gerrit.wikimedia.org/r/91369 [15:26:44] (03CR) 10Gergő Tisza: "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [15:29:18] (03CR) 10Zfilipin: "Michelle, Chris, I think the two of you made a few changes to the template and/or Jenkins jobs. In the future, please also update the docu" [selenium] - 10https://gerrit.wikimedia.org/r/91369 (owner: 10Zfilipin) [15:31:27] \o/ [15:33:31] (03PS2) 10Anomie: Add $wgSemiprotectedRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/90552 [15:33:43] (03CR) 10Anomie: "PS2: Update doc comment" [core] - 10https://gerrit.wikimedia.org/r/90552 (owner: 10Anomie) [15:35:39] hashar: interesting failure? O_o https://integration.wikimedia.org/ci/job/mediawiki-core-phpunit-databaseless/14174/console [15:36:50] addshore: yeah retrigger it [15:37:00] addshore: I am updating some mw core jobs sorry [15:38:02] (03PS1) 10Addshore: Split ApiTest class into seperate module classes [core] - 10https://gerrit.wikimedia.org/r/91392 [15:38:34] (03PS2) 10Addshore: Add more ApiFormat format tests [core] - 10https://gerrit.wikimedia.org/r/91388 [15:38:39] (03CR) 10Hashar: [C: 032] mediawiki phpunit no more use ant and LOG! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91385 (owner: 10Hashar) [15:38:53] addshore: so yeah some side effect of the job update :( [15:39:24] (03CR) 10Anomie: "I wasn't planning on using it in the default messages, just on making them available for local wiki customization." [core] - 10https://gerrit.wikimedia.org/r/90357 (owner: 10Anomie) [15:40:32] (03PS1) 10Parent5446: Fixed stream wrapper in PhpHttpRequest [core] - 10https://gerrit.wikimedia.org/r/91393 [15:40:35] (03CR) 10Gergő Tisza: [C: 031] Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [15:40:45] (03CR) 10jenkins-bot: [V: 04-1] Split ApiTest class into seperate module classes [core] - 10https://gerrit.wikimedia.org/r/91392 (owner: 10Addshore) [15:41:06] (03Merged) 10jenkins-bot: mediawiki phpunit no more use ant and LOG! [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91385 (owner: 10Hashar) [15:41:43] addshore: again me sorry [15:41:55] hehe, it can up with your name in the console output ;p [15:41:59] (03PS3) 10Hashar: Add $wgSemiprotectedRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/90552 (owner: 10Anomie) [15:42:05] no worries, Ill leave them all and poke them later :D [15:51:25] (03CR) 10Catrope: [C: 032] tablesorter: Unbreak abbreviated month name support [core] - 10https://gerrit.wikimedia.org/r/91363 (owner: 10Bartosz Dziewoński) [15:51:48] (03CR) 10Jdlrobson: "Does this /fix/ the bug or lessen it?" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/88903 (owner: 10MaxSem) [15:52:35] hashar: Hi. [15:52:55] Is JSHint known to be broken? [15:53:05] I noticed a subtle failure today: [15:53:50] at https://gerrit.wikimedia.org/r/#/c/91170/ , I would expect the first patch set to complain about line 141 in https://gerrit.wikimedia.org/r/#/c/91170/1/resources/js/ext.translate.mainpage.signup.js because of an extra comma. [15:54:18] (03Merged) 10jenkins-bot: tablesorter: Unbreak abbreviated month name support [core] - 10https://gerrit.wikimedia.org/r/91363 (owner: 10Bartosz Dziewoński) [16:00:00] (03CR) 10Gergő Tisza: [C: 04-1] "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 (owner: 10MarkTraceur) [16:02:14] (03PS1) 10Anomie: Adjust wording of preference link [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91397 [16:03:23] (03Draft1) 10Addshore: Cleanup Api phpunit Tests [core] - 10https://gerrit.wikimedia.org/r/91398 [16:05:52] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 (owner: 10MarkTraceur) [16:07:02] (03CR) 10Gergő Tisza: [C: 031] Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 (owner: 10MarkTraceur) [16:10:51] (03CR) 10Gergő Tisza: [C: 031] Fix a few fullscreen bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 (owner: 10MarkTraceur) [16:11:16] (03CR) 10Aaron Schulz: [C: 032] Adjust wording of preference link [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91397 (owner: 10Anomie) [16:11:22] (03Merged) 10jenkins-bot: Adjust wording of preference link [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91397 (owner: 10Anomie) [16:12:14] (03CR) 10Anomie: "Wait, that mt regex is a-ż, not a-z. I missed the diacritic, I probably thought it was a speck of dust on my screen. Yeah, that's broken, " [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [16:14:47] (03CR) 10Physikerwelt: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/65301 (owner: 10AlephNull) [16:20:05] (03CR) 10Gergő Tisza: "(2 comments)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [16:23:05] (03PS1) 10Wizardist: Translate namespaces for [be] [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/91404 [16:23:16] (03CR) 10Gergő Tisza: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 (owner: 10MarkTraceur) [16:24:46] (03CR) 10Aaron Schulz: [C: 032] Utility function to get central id from username [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91329 (owner: 10CSteipp) [16:24:53] (03Merged) 10jenkins-bot: Utility function to get central id from username [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91329 (owner: 10CSteipp) [16:31:13] (03CR) 10Gergő Tisza: [C: 031] "I would separate logging code away from the rest, but that is probably a matter of taste." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 (owner: 10MarkTraceur) [16:31:38] - // When we upgrade to mysql 4.1, the insert+update [16:32:26] (03PS1) 10Reedy: Replace insert() and update call() with upsert() call [core] - 10https://gerrit.wikimedia.org/r/91405 [16:33:29] (03PS3) 10Physikerwelt: startup script skeleton for upstart [extensions/Math] - 10https://gerrit.wikimedia.org/r/90731 [16:33:46] YuviPanda: yes, why are you testing it? ;) [16:35:30] Aaron|home: Are you looking at the centralauth hook too? Or should I get someone else to look at it? [16:36:01] (03PS2) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [16:36:23] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91405 (owner: 10Reedy) [16:37:27] (03CR) 10Aaron Schulz: [C: 032] Implement OAuth hook to get userid from username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/91331 (owner: 10CSteipp) [16:37:34] (03Merged) 10jenkins-bot: Implement OAuth hook to get userid from username [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/91331 (owner: 10CSteipp) [16:37:59] (03CR) 10Reedy: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91405 (owner: 10Reedy) [16:38:30] (03CR) 10Gergő Tisza: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff) [16:40:21] (03PS2) 10Reedy: Replace insert() and update call() with upsert() call [core] - 10https://gerrit.wikimedia.org/r/91405 [16:42:58] AndyRussG: poke [16:43:22] * AndyRussG a bit ticklish [16:43:25] Hi aude [16:43:49] (03PS1) 10Aude: add AndyRussG to trusted list [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91408 [16:44:08] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91405 (owner: 10Reedy) [16:44:09] (03PS2) 10Aude: add AndyRussG to trusted list [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91408 [16:44:27] (03CR) 10Cmcmahon: [C: 032] "documentation" [selenium] - 10https://gerrit.wikimedia.org/r/91369 (owner: 10Zfilipin) [16:44:29] AndyRussG: https://gerrit.wikimedia.org/r/#/c/91408/ this is so jenkins runs unit tests for you [16:44:40] i noticed it is not doing that now and think it is helpful [16:45:02] it requires hashar approval [16:45:33] csteipp: merge [16:45:35] *merged [16:45:40] Thanks! [16:46:03] (03PS3) 10Reedy: Replace insert() and update call() with upsert() call [core] - 10https://gerrit.wikimedia.org/r/91405 [16:46:27] aude: thanks! [16:46:40] sure [16:47:23] about to send another patchset in fact [16:47:45] it won't work until hashar approves and i don't see him here at the moment [16:49:04] (03CR) 10Gergő Tisza: [C: 031] Only add handlers on image thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90455 (owner: 10MarkTraceur) [16:50:48] aude: OK [16:52:23] (03CR) 10Subramanya Sastry: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [16:54:17] (03PS1) 10Mattflaschen: Fix doc error in new incr test [core] - 10https://gerrit.wikimedia.org/r/91410 [16:54:54] (03CR) 10Mattflaschen: "I thought about this, but somehow must have copied the wrong thing anyway." [core] - 10https://gerrit.wikimedia.org/r/91410 (owner: 10Mattflaschen) [16:55:16] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [16:56:06] (03PS2) 10Mattflaschen: Fix doc error in new incr test [core] - 10https://gerrit.wikimedia.org/r/91410 [16:58:04] (03CR) 10Siebrand: [C: 032] Fix doc error in new incr test [core] - 10https://gerrit.wikimedia.org/r/91410 (owner: 10Mattflaschen) [16:58:19] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [16:58:26] (03PS1) 10Aaron Schulz: Enable consumer listing page everywhere [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91412 [16:58:38] csteipp: ^ [16:58:47] (03CR) 10Krinkle: [C: 04-1] "Perhaps this can be abstracted into MWExceptionHandler::formatRedactedTrace to avoid repeating it? This traversing looks like something we" [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [16:59:30] Aaron|home: I'll look at it in a bit [16:59:49] (03CR) 10Subramanya Sastry: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [17:01:16] (03Merged) 10jenkins-bot: Fix doc error in new incr test [core] - 10https://gerrit.wikimedia.org/r/91410 (owner: 10Mattflaschen) [17:01:17] (03CR) 10EBernhardson: "The problem with formatRedactedTrace is just that, its only the trace. You also want the exception type and message for the nested except" [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [17:02:31] (03CR) 10Tpt: "(1 comment)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90741 (owner: 10Tpt) [17:04:05] ( ! ) Fatal error: Class 'EchoHooks' not found in /var/www/wiki/mediawiki/extensions/Echo/Echo.php on line 532 [17:04:09] Installer brokened [17:08:25] (03CR) 10Krinkle: "* What is this "disabled" property for? It's a , disabled doesn't exist on a span and setting it does nothing afaik." [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [17:11:10] Crap... couldn't register for https://www.mediawiki.org/wiki/Architecture_Summit_2014 because I was on holiday -.- [17:12:31] hoo: Ask robla; you might still be ok to do it (more so with being a known member of the community etc) [17:12:43] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=55469 [17:12:56] I'm confirming another bug!!! [17:13:05] What's the name of that damned hook that people used to use set everything up for their extension [17:13:57] It's used for conditional setting of stuff [17:14:01] based on globals etc [17:14:20] Not a hook [17:14:20] $wgExtensionFunctions [17:15:53] hoo: email rob [17:16:44] subbu, so what about PHP is unclear in https://gerrit.wikimedia.org/r/#/c/80578/9/includes/parser/Parser.php ? [17:17:19] MaxSem, never mind. I chatted with gwicke about it .. and I got conflused about $vars and wfSetVar, etc. I'll read up on it :) [17:17:22] MaxSem: Uhh [17:17:25] ARenjkjlk;km [17:17:29] WRONG AUTOCOMPLETE [17:17:42] s/conflused/confused [17:17:46] subbu, so that rev is good? [17:17:51] fine with me. [17:18:02] MatmaRex: Yup, had already found that after I complained. Explained and even proposed a fix ;) [17:18:02] +2?:P [17:18:06] aude: Might be a good idea... hope to see you around then [17:18:15] I can +1 it and let someone else +2 it :) [17:18:26] i don't know if i can actually go but hope so [17:18:41] MaxSem, doing a round of parsoid updates .. will get to it in about an hour. [17:18:54] subbu, thanks!:) [17:19:43] (03CR) 10Siebrand: [C: 031] ";)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [17:19:47] (03CR) 10Hashar: "> What is this "disabled" property for? It's a , disabled doesn't exist on a span and setting it does nothing afaik." [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [17:19:58] siebrand: Don't you wink at me [17:20:01] My soul is dying [17:20:08] * siebrand grins at marktraceur  [17:32:34] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91314 (owner: 10MarkTraceur) [17:32:56] (03CR) 10Subramanya Sastry: [C: 031] Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [17:33:48] (03PS1) 10Parent5446: Fix extension functionality and backwards compatibility [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 [17:35:03] (03PS3) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [17:37:35] (03PS2) 10Parent5446: Fix extension functionality and backwards compatibility [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 [17:42:12] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 (owner: 10MarkTraceur) [17:43:06] (03PS4) 10EBernhardson: Display nested exception backtrace's [core] - 10https://gerrit.wikimedia.org/r/91073 [17:43:28] I herd u liek backtraces... [17:43:53] (03PS1) 10Yurik: Updating Zero [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91418 [17:44:16] (03PS4) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [17:44:39] (03CR) 10Yurik: [C: 032] Updating Zero [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91418 (owner: 10Yurik) [17:46:12] (03CR) 10Esanders: "Looks good otherwise, +2 when qqq'd." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91314 (owner: 10MarkTraceur) [17:47:31] (03Restored) 10Aaron Schulz: Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [17:48:32] (03CR) 10Hashar: [C: 032] "well done! deploying" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91408 (owner: 10Aude) [17:48:39] (03CR) 10Bartosz Dziewoński: [C: 031] Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [17:48:41] (03Merged) 10jenkins-bot: add AndyRussG to trusted list [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91408 (owner: 10Aude) [17:49:27] (03Merged) 10jenkins-bot: Updating Zero [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91418 (owner: 10Yurik) [17:50:13] (03PS5) 10Krinkle: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [17:50:44] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [17:52:25] (03CR) 10Jeroen De Dauw: "I did indeed mean those singletons." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [17:55:27] (03CR) 10Hashar: "Much better :-] Now we have to find out how to make the span a fixed width or at least to keep its width when switching from updating to" [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [17:56:46] (03PS3) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [17:57:28] (03CR) 10jenkins-bot: [V: 04-1] WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [17:58:40] (03PS1) 10Yurik: Updating Zero [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91421 [17:58:53] (03PS2) 10Aaron Schulz: Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [17:59:13] (03CR) 10AndyRussG: "Siebrand: OK, no problem, let me fix that..." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [17:59:22] (03CR) 10Aaron Schulz: "Manual rebase" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [17:59:26] (03PS4) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [17:59:29] (03CR) 10Yurik: [C: 032 V: 032] Updating Zero [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91421 (owner: 10Yurik) [18:00:15] (03CR) 10Matthias Mullie: [C: 032] New hook accomidates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [18:00:27] (03CR) 10Krinkle: "* Addressed layout issues." [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [18:01:05] (03CR) 10Bartosz Dziewoński: "(7 comments)" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 (owner: 10Parent5446) [18:01:27] (03CR) 10Aaron Schulz: [C: 032] "Meh, since "if" in code tends to almost always be exclusive, we could just stick to that as a convention." [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [18:03:35] (03PS5) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [18:03:40] (03CR) 10jenkins-bot: [V: 04-1] New hook accomidates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [18:07:17] (03CR) 10Aaron Schulz: [C: 032] "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91295 (owner: 10Anomie) [18:07:42] (03CR) 10AndyRussG: "(2 comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [18:08:23] (03Merged) 10jenkins-bot: Provide default messages for OAuth tags [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91295 (owner: 10Anomie) [18:09:19] oh, wait, https://gerrit.wikimedia.org/r/#/c/91412/ still pending [18:09:19] (03CR) 10MZMcBride: "I'm hoping we can get this merged before the end of 2013." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7274 (owner: 10Szymon Świerkosz) [18:09:26] anomie: can you merge that one? [18:10:09] (03CR) 10MZMcBride: "I'm hoping we can get this merged before the end of 2013." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7300 (owner: 10Szymon Świerkosz) [18:10:41] * anomie looks [18:13:43] Aaron|home: Do we need to add an implementation of the OAuthGetCentralIdFromUserName hook to CentralAuth for it to work? [18:13:57] that was merged [18:14:13] oh, ok [18:14:33] (03CR) 10Anomie: [C: 032] "Looks sane." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91412 (owner: 10Aaron Schulz) [18:14:37] Elsie: Good one :P [18:14:41] (03Merged) 10jenkins-bot: Enable consumer listing page everywhere [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91412 (owner: 10Aaron Schulz) [18:15:06] (03Merged) 10jenkins-bot: Updating Zero [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91421 (owner: 10Yurik) [18:16:49] (03Merged) 10jenkins-bot: Remove all instances of the word "iff" [core] - 10https://gerrit.wikimedia.org/r/68121 (owner: 10Tim Starling) [18:17:15] (03CR) 10PiRSquared17: "What about the problems above (code-review -1)?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/7300 (owner: 10Szymon Świerkosz) [18:18:07] csteipp: https://bugzilla.wikimedia.org/show_bug.cgi?id=56021 [18:18:13] so where should the link be? [18:22:17] (03CR) 10Nikerabbit: [C: 032] Translate namespaces for [be] [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/91404 (owner: 10Wizardist) [18:22:47] (03PS6) 10Nemo bis: Add link to PD help translatable pages from sidebar [core] - 10https://gerrit.wikimedia.org/r/83221 [18:23:05] (03CR) 10Nikerabbit: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [18:23:42] (03Merged) 10jenkins-bot: Translate namespaces for [be] [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/91404 (owner: 10Wizardist) [18:23:58] MatmaRex: now that the uncontroversial patch was made controversial by your opposition, this other patch has become uncontroversial, in case you want to help :) https://gerrit.wikimedia.org/r/#/c/83221/ [18:24:18] (03CR) 10Mattflaschen: [C: 032] "Looks good. I've been running with allkeys-lru for a little while (both this patch and my own local changes before it), and it seems to h" [vagrant] - 10https://gerrit.wikimedia.org/r/91127 (owner: 10Ori.livneh) [18:24:59] (03Merged) 10jenkins-bot: redis: 16M -> 64M, volatile-lru -> allkeys-lru [vagrant] - 10https://gerrit.wikimedia.org/r/91127 (owner: 10Ori.livneh) [18:25:02] wait, what? [18:25:03] which one? [18:27:59] uncontroversial: https://gerrit.wikimedia.org/r/83221 [18:29:01] Aaron|home: The link should be in the intro text. As for where it points, I'm not sure about that [18:29:41] (03Abandoned) 10Umherirrender: Use always context for messages on ImagePage [core] - 10https://gerrit.wikimedia.org/r/86008 (owner: 10Umherirrender) [18:30:00] (03Abandoned) 10Umherirrender: Use always context for messages on Article [core] - 10https://gerrit.wikimedia.org/r/87610 (owner: 10Umherirrender) [18:34:54] (03PS1) 10Anomie: Remove linkprefix message, add $linkPrefixCharset [core] - 10https://gerrit.wikimedia.org/r/91425 [18:35:51] (03CR) 10Anomie: "Note that change I3369851b obsoletes this change." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [18:36:15] (03CR) 10Rtdwivedi: [C: 031] Move rendering of Page: pages to ProofreadPageViewAction [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90741 (owner: 10Tpt) [18:38:14] (03CR) 10Anomie: "Fuzz tester has successfully run over 6000000 random strings so far through each pair of regular expressions (excluding Diq, and making th" [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [18:40:48] (03PS1) 10Umherirrender: Pass language to File::getDescriptionText [core] - 10https://gerrit.wikimedia.org/r/91426 [18:42:55] (03PS1) 10Raimond Spekking: Fix message key [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/91427 [18:43:06] (03CR) 10Krinkle: [C: 032] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/85526 (owner: 10Bartosz Dziewoński) [18:43:09] (03CR) 10Raimond Spekking: [C: 032 V: 032] Fix message key [extensions/ExtTab] - 10https://gerrit.wikimedia.org/r/91427 (owner: 10Raimond Spekking) [18:46:03] (03Merged) 10jenkins-bot: mediawiki.util: Use 'wikipage.content' hook for TOC hiding [core] - 10https://gerrit.wikimedia.org/r/85526 (owner: 10Bartosz Dziewoński) [18:53:33] (03CR) 10Umherirrender: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84197 (owner: 10TTO) [18:53:59] Krinkle: could you look over https://gerrit.wikimedia.org/r/#/c/86867/ one last time and merge it if it's OK? My intent is to have it running in beta for a while before we enable the config in prod [18:55:54] ori-l: I'm not yet convinced about the version number [18:56:06] if there's a security issue, wouldn't we have to disable it? [18:56:31] the attacker could update the version number easily I suppose, we'd have to fix it in core and deploy, in that fix we'd up the version numnber in js. and until that time disable it (as we proll have to anyway) [18:56:36] no, we'd probably want to make sure the cache is actively purged [18:57:18] so it overwrites, not create another registry? [18:57:27] yes [18:57:34] (03CR) 10Anomie: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91295 (owner: 10Anomie) [18:58:07] ori-l: ah, it's in getVary now [18:58:09] Hm.. [18:58:15] that's better indee [18:58:59] it just seems like the sort of fail-safe that you very rarely regret having but quite often regret not having [18:59:29] so, how about we get someone to focus on a11y like ori-l focuses on perf? :-) [18:59:40] who cares at all about a11y? [18:59:43] ori-l: well, comming to mediawiki-config and syncing or mediawiki-wmf, that isn't a major difference worth on itself? [19:00:15] sorry, can you explain? i don't understand what you're asking [19:00:29] I probably misunderstand the usecase [19:00:59] ok, here's an example. for whatever reason, we decide to change the syntax for 'implements' call [19:01:03] *calls [19:01:12] ori-l: Nope, that's a given inside resourceloader [19:01:24] Krinkle: yes, but not for things that are already in localstorage [19:01:28] by design that can never be incompatible because of load.php cache, we still support MW 1.17 syntax. [19:01:48] which is the same call [19:02:08] So the use case is not for when we change loader.store itself or loader.implement but if something bad happens and we need to purge the cache. [19:02:16] something bad not in mediawiki core but on our site. [19:02:28] (03PS5) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [19:02:51] I just don't understand why you wouldn't consider it nice to have the cache signature vary on a configuration variable that is 'free' and could be manipulated without altering the behavior of other systems [19:03:21] I think that signature is useful, I'm merely doubtful whether it is worth it to have server-side as opposed to somewhere inside mediawiki.js [19:03:30] e.g. for it to change separately from mediawiki core itself. [19:04:45] basically that it adds to the startup module, and that it makes it variable in localsettings which seems like something that shouldn't be changable from localsettings, at least not the for the reason I think it is for. But it's not bad in general if there's a use for it, we should keep it. [19:05:08] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [19:05:19] just want to make sure I understand what it is for and that we can't avoid it before we add more config globals and to the startup. [19:05:56] Krinkle: quick question - what is the rationale for skinStyles in RL module definitions? (apart from "'cuz it's easier for core skins") [19:06:41] Krinkle: OK, suppose a naive developer thought the module store was a means of storing any MediaWiki-related data [19:06:52] and added some things to store.items that get synced to localStorage [19:07:28] and someone reports it. how do we respond? [19:07:58] (03PS2) 10MarkTraceur: Add popup CTA for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91314 [19:08:17] it seems like incrementing the cache version in mediawiki-config and syncing the setting file is an easy, quick first step that we can do to mitigate the immediate issue of potential private / garbage-y data [19:08:30] (03CR) 10Bsitu: [C: 04-1] "(1 comment)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88680 (owner: 10Legoktm) [19:08:39] (03CR) 10MarkTraceur: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [19:08:54] (03CR) 10Bartosz Dziewoński: "The empty value is there because some people like their months numbered from 1. I don't like it either, but I see little value in changing" [core] - 10https://gerrit.wikimedia.org/r/91379 (owner: 10Raimond Spekking) [19:09:12] ori-l: a developer like in, something in core or extensions that got merged? Or from a, say, a site script? [19:09:30] either one [19:09:32] In both cases, it'd say it's a good argument to make this interface not public. [19:09:47] because they could be screwing with that 24/7. [19:09:56] well, 'localStorage' is public [19:10:07] True [19:10:26] Hm.. [19:11:14] okay, so as I suspected, the server-side number is a sign of something being venerable. [19:11:17] but we can't change that [19:11:19] ori-l: are you at home today? [19:11:24] aude: yep [19:11:26] ok [19:11:39] you can't lock down localStorage. Given that this imposes a limit on how truly 'private' you can make things, my preference is to have something flexible and scruitble [19:11:40] i don't really need anything but i am adding a wikibase role to vagrant [19:11:57] ori-l: if the implement() sig changes, we need to be back-compat because of load.php cache, race conditions and loader.storage. So that won't be allowed to break unless we rename the method. And if we change loader.store itself, we could just increment that number inside mediawiki.js. [19:12:01] might need you to review it when i am done [19:12:04] This is not for either of those things. [19:12:12] OK, good, makes sense now [19:12:13] aude: awesome, happy to help via IRC or if you want to pair up in person tomorrow i'd be cool with that too [19:12:16] ok [19:12:27] it looks straightforward, although wikibase is not so simple [19:12:29] [19:13:01] ori-l: Can you rebase once more and add release notes? I'll +2 [19:13:26] Krinkle: two things [19:13:27] 1) YES. [19:13:30] 2) YAY. [19:13:46] 3) [19:14:31] * Krinkle and then the Dr Who theme song started playing [19:14:44] Heheh [19:14:57] only 1 more month [19:16:53] (03PS1) 10Aaron Schulz: Fixed test script for protocal relative config [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91483 [19:18:49] [19:19:43] Anyone around that can talk to me about $wgCentralAuthAutoLoginWikis ? [19:20:44] csteipp: ^ [19:20:48] :> [19:22:20] I know it is "Mapping from domain name to wiki id for other wikis to automatically login into" but cant actually find any example use anywhere [19:26:45] (03CR) 10Parent5446: "(6 comments)" [extensions/Persona] - 10https://gerrit.wikimedia.org/r/91417 (owner: 10Parent5446) [19:27:08] addshore: https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings.php#L1208 like that? [19:27:31] hah, hoo, thanks, not sure how I missed that.. [19:27:43] potentially had a typo in my find ... [19:28:03] uh Amgine abandoning our soil [19:28:19] hm, I thought you were in Europe but not EU :P [19:28:24] (03PS1) 10Hashar: WMF: debug time to launch a build in Jenkins [integration/zuul] - 10https://gerrit.wikimedia.org/r/91484 [19:29:21] [19:29:23] (03PS20) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [19:29:56] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [19:30:35] (03CR) 10Aaron Schulz: "Maybe resetArticleID needs updating" [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [19:31:13] (03CR) 10Hashar: [C: 032 V: 032] WMF: debug time to launch a build in Jenkins [integration/zuul] - 10https://gerrit.wikimedia.org/r/91484 (owner: 10Hashar) [19:31:41] (03PS21) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [19:32:07] (03PS2) 10Addshore: Split ApiTest class into seperate module classes [core] - 10https://gerrit.wikimedia.org/r/91392 [19:32:08] (03CR) 10Ori.livneh: "PS20: Add release note. PS21: Rebase." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [19:32:44] (03PS1) 10Bsitu: Remove class constant variable reference from Echo.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/91485 [19:33:35] Krinkle: done [19:51:50] (03PS1) 10Aaron Schulz: Fixed missing ":" on wiki field [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91486 [19:53:28] ori-l, have you ever got "PHP Fatal error: Allowed memory size of 52428800 bytes exhausted" in phpsh? [19:53:32] Reedy: Can I add three config changes for VE to your list for tomorrow's 1.23wmf1 push? https://gerrit.wikimedia.org/r/#/c/90923/ https://gerrit.wikimedia.org/r/#/c/91197/ and https://gerrit.wikimedia.org/r/#/c/91198/ ? [19:53:44] It looks like it hit the PHP memory limit. [19:58:12] (03CR) 10Jdlrobson: "Vector first but yes it would be good to start LESSify all other skins to find the common components but first this one needs testing and " [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [19:58:47] (03PS1) 10Aaron Schulz: Disabled the feature to change wiki scope [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91488 [20:00:36] (03PS6) 10Krinkle: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [20:00:56] superm401: no, I haven't. that's a pretty low limit though [20:01:00] i'm in favor of changing it [20:01:03] it's 50M [20:01:38] Krinkle: ping re: 86867 ? [20:01:42] ori-l, sounds good to me. Maybe 75M for now? [20:01:56] Disabling cldr and uploadwizard was enough to put it under for me. [20:02:04] ori-l: yeah [20:02:11] tab is open [20:02:13] superm401: I'd prefer 100M [20:02:25] (03Abandoned) 10Aaron Schulz: Fixed missing ":" on wiki field [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91486 (owner: 10Aaron Schulz) [20:02:50] ori-l, alright. We can always tweak later, no that it's spelled out. [20:02:56] 'now that' I mean. [20:03:01] superm401: the limit isn't pre-allocated AFAIK, so the question is 'how much memory is enough to warrant putting the breaks on things' [20:03:14] we use nearly 200 on the clyster! :-D [20:03:28] Reedy: for CLI too? [20:03:36] Krinkle: ok, thanks, sorry for nagging. [20:04:01] Reedy, do the cluster machines have 768M of RAM? :-D [20:04:20] Yeah, it's tough. I already raised my VM to 1 GB total, but the default is 768. [20:04:31] ori-l's right, though, it's a maximum, not pre-allocated. [20:05:13] (03PS2) 10Aaron Schulz: Disabled the feature to change wiki scope [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91488 [20:05:15] Where is it even getting 50M? [20:05:32] The PHP hard-coded default is supposed to be 128 M, and the php.ini files say the same. [20:06:54] csteipp: https://gerrit.wikimedia.org/r/#/c/91483/ [20:06:56] ori-l: I haven't actually tested it, so doing that now, belated. [20:07:10] Looks like it has some issues trying to store VisualEditor, browser tab crashed :-( [20:07:37] it added an item on page load for the init modulees, then when I clicked Edit and it went to load more, it crashed whem they arrived. [20:07:57] brakes [20:07:59] Hm.. could be unrelated. h/o [20:08:29] Krinkle: works for me [20:13:25] ori-l: "mw.loader.implement("ext.visualEditor.core",http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/ve.Range.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/ve.Node.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/ve.BranchNode.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/ve.LeafNode.js,http://alpha.wikip [20:13:25] edia.krinkle.dev/extensions/VisualEditor/modules/ve/ve.Element.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/ve.Document.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/ve.EventSequencer.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.Mo [20:13:25] del.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.ModelRegistry.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.NodeFactory.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.AnnotationFactory.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.AnnotationSet.js,http://alpha [20:13:26] .wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.MetaItemFactory.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.Node.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.BranchNode.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.LeafNode.js,http://alpha.wikipedia.krinkle.dev/extensions/Vi [20:13:28] sualEditor/modules/ve/dm/ve.dm.Annotation.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.InternalList.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.MetaItem.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.MetaList.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.Tran [20:13:30] sactionProcessor.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.Transaction.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.Surface.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.SurfaceFragment.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.DataString.js,http://alp [20:13:32] ha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.Document.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.LinearData.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.DocumentSynchronizer.js,http://alpha.wikipedia.krinkle.dev/extensions/VisualEditor/modules/ve/dm/ve.dm.IndexValueStore.js,http://alpha.wikipedia.krinkle [20:14:53] okay, that string looked shorter in the console [20:14:55] ori-l: mw.loader.store; ... mw.loader.implement("ext.visualEditor.core",http://alpha.wikipedia.krinkle.dev/extensions/Vi... [20:14:57] looks like debug mode pollutes the storage with invalid javascript [20:15:01] when I switched between the 2 modes, it broke everything [20:15:03] and no exception in the console.error like resourceloader ususally does for an bad module [20:15:05] silent [20:15:09] a* [20:15:20] arghhh. it's not meant to work in debug mode [20:15:29] i was aware of this, dunno why i didn't include a debug check in init [20:16:29] is debug mode the only case in which you get URL-loading implement calls? [20:17:06] ori-l: Yes and no [20:17:16] (03CR) 10Aaron Schulz: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91405 (owner: 10Reedy) [20:17:20] most probably yes, but that's an implementation detail. implement() takes both and should always support both [20:17:43] so what broke? [20:17:50] ori-l: script.toString [20:17:56] script being an array [20:17:59] not a function [20:18:09] so you get implement( unquoted string ) [20:18:24] OK, so it needs to check for debug mode (because we don't want to cache URL-loading versions) [20:18:27] and it needs to check for arrays [20:18:31] blargh [20:18:40] i gotta run for an hour, bbiab [20:18:44] so problem 1) serialise arrays as arraays with json, 2) make sure there is no silent failure if localStorage contains invalid js [20:18:47] ori-l, the memory limit comes from wgMemoryLimit, which defaults to 50M. MW raises it if the memory limit is below that. [20:18:49] I'll comment on gerrit [20:21:48] (03CR) 10Swalling: [C: 031] "Simple change, but important for a minority of editors." [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/91034 (owner: 10Mattflaschen) [20:23:14] (03CR) 10MZMcBride: "Thanks, Anomie. :-)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91397 (owner: 10Anomie) [20:23:27] (03CR) 10Krinkle: [C: 04-1] "Found two issues of concern:" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:28:23] (03CR) 10Tpt: [C: 032] "Reviewed by Aarti (thanks a lot!)" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90741 (owner: 10Tpt) [20:28:52] (03CR) 10Aaron Schulz: [C: 032 V: 032] ValidationStatistics: Showing unreviewed pages depends on config [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/91205 (owner: 10Umherirrender) [20:29:22] (03Merged) 10jenkins-bot: Move rendering of Page: pages to ProofreadPageViewAction [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90741 (owner: 10Tpt) [20:34:23] (03CR) 10Hashar: "Looks like nicer now." [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [20:37:27] (03CR) 10Nemo bis: "(Also needs rebase.)" [core] - 10https://gerrit.wikimedia.org/r/63378 (owner: 10Daniel Friesen) [20:40:40] (03PS1) 10Cmcmahon: disable ProveIt gadget on beta for now, it's causing Chrome failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91498 [20:41:49] (03CR) 10Cmcmahon: [C: 032] "disabling ProveIt gadget on beta because it's causing test failures for Chrome, so don't run the test" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91498 (owner: 10Cmcmahon) [20:52:14] (03PS1) 10Aaron Schulz: Removed MW prefix from special pages [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91500 [20:53:55] (03CR) 10Nikerabbit: "(1 comment)" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91192 (owner: 10Siebrand) [20:53:56] (03CR) 10Brian Wolff: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/62306 (owner: 10Wizardist) [20:55:14] (03CR) 10Brian Wolff: "(I should also mention I saw this linked from a bug, and didn't notice the PoC/DO not merge note at the top when making my comment)" [core] - 10https://gerrit.wikimedia.org/r/62306 (owner: 10Wizardist) [20:57:18] (03PS1) 10Bartosz Dziewoński: Triple default $wgMaxShellMemory (raise to 300 MB) [core] - 10https://gerrit.wikimedia.org/r/91501 [20:57:34] (03PS2) 10Bartosz Dziewoński: Triple default $wgMaxShellMemory (raise to 300 MB) [core] - 10https://gerrit.wikimedia.org/r/91501 [20:58:59] hey Reedy or RoanKattouw - I've just emailed an announcement to the api mailing list, could you forward it to mediawiki-api-announce, please? [20:59:18] Sure [20:59:39] (03CR) 10Nemo bis: "Thanks Brian! The parent changeset also needs opinions, though the question may be Translate-specific hence perhaps outside your interest." [core] - 10https://gerrit.wikimedia.org/r/62306 (owner: 10Wizardist) [20:59:48] MaxSem: Done [20:59:53] thanks:) [21:09:43] (03CR) 10Brian Wolff: [C: 031] "This looks good at first glance. I'll merge it next time I'm doing mediawiki coding." [core] - 10https://gerrit.wikimedia.org/r/91426 (owner: 10Umherirrender) [21:18:39] (03PS7) 10EBernhardson: New hook accomidates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 [21:19:11] (03CR) 10EBernhardson: "Rebase for conflict in RELEASE-NOTES-1.22" [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [21:22:26] (03CR) 10Bartosz Dziewoński: "(Shameless plug, you will enjoy https://github.com/MatmaRex/mediawikireleasenotes-driver for release notes rebases.)" [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [21:24:21] (03PS1) 10Hashar: operations-debs-jenkins-debian-glue-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91508 [21:24:52] (03CR) 10Hashar: [C: 032] operations-debs-jenkins-debian-glue-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91508 (owner: 10Hashar) [21:25:17] (03Merged) 10jenkins-bot: operations-debs-jenkins-debian-glue-debian-glue [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91508 (owner: 10Hashar) [21:28:31] (03PS4) 10Jeroen De Dauw: Remove Settings::newFromGlobals [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/69977 [21:32:34] (03PS1) 10Jdlrobson: Allow ResourceLoaderSchemaModules to contain more than one module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 [21:33:11] (03CR) 10jenkins-bot: [V: 04-1] Allow ResourceLoaderSchemaModules to contain more than one module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [21:33:22] (03CR) 10Jdlrobson: "Note I've been unable to run the PHP unit tests locally for some reason - can't work it out so can't verify they will pass :)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [21:34:13] (03PS2) 10Jdlrobson: Allow ResourceLoaderSchemaModules to contain more than one module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 [21:34:41] (03CR) 10jenkins-bot: [V: 04-1] Allow ResourceLoaderSchemaModules to contain more than one module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [21:36:27] (03CR) 10AndyRussG: "I'm not too familiar with the Settings work yet.. Any more background on this change? How should I test it?" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/69977 (owner: 10Jeroen De Dauw) [21:38:44] Krinkle|detached: can we make qunit non-voting on mobile? it's stopping anything from getting merged right now.. [21:41:11] (03PS2) 10MarkTraceur: Add whitelistHtml method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 [21:41:51] (03CR) 10MarkTraceur: "I'm glad jslint is nonvoting for now, it will be passing after at least one of the child commits is merged too." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 (owner: 10MarkTraceur) [21:46:29] (03PS1) 10Hashar: operations-debs-jenkins-debian-glue-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91516 [21:46:44] (03CR) 10Hashar: [C: 032] operations-debs-jenkins-debian-glue-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91516 (owner: 10Hashar) [21:47:16] (03PS2) 10Hashar: operations-debs-jenkins-debian-glue-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91516 [21:47:49] (03CR) 10Hashar: [C: 032] operations-debs-jenkins-debian-glue-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91516 (owner: 10Hashar) [21:47:55] (03Merged) 10jenkins-bot: operations-debs-jenkins-debian-glue-debian-glue [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91516 (owner: 10Hashar) [21:50:39] (03CR) 10Hoo man: [C: 04-1] "Needs rebase, if I still want this(?)" [core] - 10https://gerrit.wikimedia.org/r/79053 (owner: 10Hoo man) [21:52:40] (03CR) 10Wizardist: "Thanks for input, Brain!" [core] - 10https://gerrit.wikimedia.org/r/62306 (owner: 10Wizardist) [21:53:20] (03PS1) 10MarkTraceur: Make MobileFrontend qunit tests nonvoting for now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91518 [21:53:23] :P [21:53:23] jdlrobson: +1 please ^^ [22:00:28] (03CR) 10Mattflaschen: "I retested (note that this is with a Redis main cache) and everything looks good (though I found a couple Redis issues in the process, the" [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [22:01:20] csteipp, can you look at https://gerrit.wikimedia.org/r/#/c/65867/ when you have a chance? [22:01:45] It looks pretty good, but there's a behavioral change for accounts created by autoconfirmed users, and I was wondering if you had any thoughts. [22:09:59] (03CR) 10EBernhardson: [C: 04-1] "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91341 (owner: 10Werdna) [22:10:48] Can I assume EventLogging is installed before MobileFrontend? [22:10:50] ^ ori-l ? [22:11:11] (03Abandoned) 10Jdlrobson: Make MobileFrontend qunit tests nonvoting for now [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91518 (owner: 10MarkTraceur) [22:11:19] jdlrobson: no [22:11:32] you shouldn't, at any rate [22:11:35] ori-l: mm. so we might a problem [22:11:38] https://gerrit.wikimedia.org/r/#/c/91513/ < ori-l [22:11:55] we need to make sure if EventLogging is setup the modules are registered [22:12:46] (03PS1) 10Hashar: use repo jenkins-debian-glue for glued packages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91520 [22:13:14] * marktraceur again points jdlrobson at UW and MMV that both have checks for this purpose [22:13:27] (03CR) 10Hashar: [C: 032] use repo jenkins-debian-glue for glued packages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91520 (owner: 10Hashar) [22:13:52] marktraceur: UW? [22:13:54] (03Merged) 10jenkins-bot: use repo jenkins-debian-glue for glued packages [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/91520 (owner: 10Hashar) [22:14:00] jdlrobson: no, you don't. that doesn't actually invoke EventLogging, it just registers the schema, and it checks for $wgUseEventLogging [22:14:00] UploadWizard [22:14:09] I think it's OK to crash if $wgUseEventLogging is true and EventLogging isn't configured at all [22:14:15] (03PS1) 10Addshore: Cleanup tests/includes/media [core] - 10https://gerrit.wikimedia.org/r/91521 [22:14:33] ori-l: does that patch look okay then? [22:14:42] yep [22:15:01] ori-l: is this likely to cause any issues on the cluster [22:15:54] ... [22:16:32] (03PS1) 10Bartosz Dziewoński: Expose iw_trans in siteinfo API interwikimap prop [core] - 10https://gerrit.wikimedia.org/r/91522 [22:16:33] ori-l: sorry sorry for some reason i disappeared from wikimedia-dev [22:16:43] it should be safe, yes. [22:17:48] ori-l: i'm just worried that if EventLogging is included after MobileFrontend and wgLogEvents i set then those modules will not get registered and things will explode [22:17:56] and no event logging [22:18:51] i'm telling you that it's fine, but if you are skeptical (which is a good, healthy attitude :P) then try it and see. [22:19:50] PHP doesn't magically break because you have a string value that refers to a class name that hasn't been loaded. It's just a string. [22:20:14] It isn't used for anything until ResourceLoader actually instantiates the module class, and that is guaranteed to happen after EventLogging has loaded. [22:20:37] ori-l: but what about 'if ( $wgUseEventLogging ) {' [22:21:04] what about it? [22:21:32] is that safe to use in our main extension file? [22:21:46] @seen ^d [22:21:46] MatmaRex: Last time I saw ^d they were quitting the network with reason: Remote host closed the connection N/A at 10/23/2013 9:23:48 PM (57m57s ago) [22:22:03] safe, yes. properly encapsulated, no. you should have your own config var. [22:22:08] i thought there was one? [22:22:38] no not currently [22:22:42] in MobileFrontend.php, add a config var, set to false by default: $wgMobileFrontendUseEventLogging = false; [22:23:00] ori-l: yeah, that sounds like a better idea [22:23:01] then in CommonSettings.php, set $wgMobileFrontendUseEventLogging = $wgUseEventLogging; [22:24:01] that way you're not polluting the extension code with something that is an artifact of the way the wikimedia production cluster is configured specifically [22:27:18] gah [22:27:24] guess what throws BadTitleErrors [22:27:28] hint: not Title. [22:28:04] Page!? [22:28:16] No wait. IContextSource!? [22:28:54] Hah, MediaWiki. [22:29:05] 'this guy'? [22:29:21] ori-l: No, that's the answer to "Who has two thumbs and throws BadTitleErrors?" [22:29:22] ori-l: actually, that's not going to work either [22:29:39] kaldari: why not? [22:30:11] are you checking wgMobileFrontendUseEventLogging at top scope? [22:30:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=12330 [22:30:41] a redirect loop causes a BadTitleErrors. wat. [22:30:57] ori-l: We can't set $wgMobileFrontendUseEventLogging to false and them immediately test for it to be true. [22:31:57] ori-l: my suggestion was that we put an EventLogging class within MobileFrontend and just register the RL modules with that. [22:32:18] ^d, I'm getting "Does specified change number belong to this project? and Couldn't find remote ref refs/changes/12/91512/2" with: [22:32:24] git review -d 91512 [22:32:31] kaldari: no, add the modules in a hook handler [22:32:46] <^d> superm401: Git review sucks, I refuse to support it. [22:32:53] ori-l: that sounds workable [22:32:56] kaldari: 'ResourceLoaderRegisterModules' [22:32:57] can someone review https://gerrit.wikimedia.org/r/80578 please? [22:32:58] superm401: does it belong to that project? [22:33:01] ^d, never mind, it was my fault anyway, wrong project indeed. [22:33:07] kaldari: that's the hook, I mean. [22:33:22] ori-l: got it [22:33:54] (03CR) 10EBernhardson: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [22:35:01] ori-l: sorry to bug you about something we could have figured out on our own, but we only have 30 minutes to fix it :) [22:35:21] thanks for the help [22:35:23] kaldari: oh, I didn't realize this was an issue in prod [22:35:25] no problem at all [22:35:34] it's not an issue in prod until tomorrow [22:35:43] but we have a lightning window at 4 [22:39:10] (03CR) 10Tim Starling: "Is it possible to rebase this on top of Iaa7eaa44? On this one, I think I'd rather wait for comments, whereas I'm happy to merge Iaa7eaa44" [core] - 10https://gerrit.wikimedia.org/r/91425 (owner: 10Anomie) [22:50:03] RoanKattouw: so I'm slightly sick of Dutch people complaining that people might possibly be offended by them dressing up in blackface [22:50:37] Yeah me too [22:50:40] So I fled the country on Monday [22:51:04] who is dressing up in blackface? [22:51:19] St Nicholas's helpers [22:51:28] right, was almost going to say black piet [22:51:31] Some stupid Dutch tradition that I now don't have to deal with any more [22:51:36] Yup that's the one [22:51:38] I read about it on wikipedia a year or two ago [22:52:08] do you know it was pretty explicitly racist a couple of centuries ago [22:52:25] No I don't know much about the history there [22:52:52] black piet was said to be an evil moor [22:52:59] hah [22:53:10] So racist against fellow European people then [22:53:23] Because Moors are from Spain, right? [22:53:26] well, the moors weren't black [22:53:44] <^d> RoanKattouw: Moors were from northern Africa and took over Spain. [22:53:49] (03Draft2) 10Addshore: Fix scope on all /phpunit test methods [core] - 10https://gerrit.wikimedia.org/r/91525 [22:53:50] Aah [22:54:03] So they were in Spain but not from there, gotcha [22:54:03] they were african, yes [22:54:23] But surely Northern African, near present-day Morocco? [22:54:28] <^d> Yes. [22:54:39] So not black but more Arab-like in skin tone? [22:54:41] <^d> "The Moors were the medieval Muslim inhabitants of Morocco, western Algeria, Western Sahara, Mauritania, the Iberian Peninsula, Septimania, Sicily and Malta." [22:54:51] <^d> Opening of [[w:Moors]] [22:54:53] hah [22:55:05] (03CR) 10Ori.livneh: "> Should probably segment the module storage by "debug" as well in addition to "skin", "lang", and "storageVersion". Just like ResourceLoa" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [22:55:53] (03PS22) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [22:56:33] See, I don't know much about the whole thing, maybe by some miracle nobody actually feels excluded or targeted by it [22:56:46] but… I mean… all these dutch people act surprised [22:56:57] like "Oh my god, how could you think it's racist?" [22:56:58] <^d> RoanKattouw: Further reading, see [[w:Umayyad conquest of Hispania]] and [[w:Reconquista]] [22:57:10] and you're like welllllll… [22:57:45] my favourite are the clueless people who say "No, it's soot from the chimney" [22:58:02] <^d> Actually, [[Al-Andalus]] is probably more comprehensive than the Umayyad conquest. [22:58:04] and I'm like "Oh, right, that explains the red lips and the curly hair, doesn't it?" [22:58:14] (03CR) 10Ori.livneh: "PS22: 1) Support arrays as script values. 2) Decline to enable in debug mode." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [22:59:10] I think I'm missing context here; but how is blackface more racist than claiming jesus is white? [22:59:21] Krinkle|detached: could you re-review? ^ [22:59:39] well, the usual problem with blackface is that you're caricaturing black people [22:59:50] (03CR) 10Mattflaschen: [C: 04-1] "(6 comments)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [23:00:07] you dress up as a black person and say "haw haw, look at how funny those black people are" [23:00:23] according to http://www.racialicious.com/2012/12/05/zwarte-piet-a-racist-caricature/ the reason black pete looks sub-saharan is because of the influence of US blackface [23:00:46] <^d> *sigh* Once again, I apologize for my country. [23:03:17] On the other hand, it's totally hilarious that anyone thinks that the Dutch are just going to drop the tradition on the ground. [23:04:32] Lots of my Dutch friends are indignant because somebody in the UN has decided to say that it should be abolished. Which just brings out emotional reactions from people who were brought up on it. [23:05:13] (03CR) 10Catrope: [C: 031] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [23:05:32] ori-l: Waiting for Krinkle|detached to re-review too, he should already be asleep though and will probably be reasonably busy tomorrow [23:06:04] i literally bit my knuckle [23:06:26] * ori-l bounces a little. [23:06:33] interesting; according to Tim's article; originally it was a embodiment of good vs evil (saint vs devil) -- so I would argue that it's not racist because of the caricature; but because you're insinuating that black people are more 'evil' somehow than white people [23:06:45] RoanKattouw: thanks :) [23:07:10] (that would be a generic you're; not directing that at anyone) [23:07:12] mwalker: mm, then he became a "devil" picked up in ethiopia [23:07:15] <^d> Enough racism. I'm going to change the topic. [23:07:23] <^d> I like apple juice. Opinions? [23:07:39] oooh! the apple juice that comes in little plastic grenade bottles [23:07:42] sooooo tasty [23:07:59] * werdna changes the topic [23:08:49] Snrk. [23:09:09] (03CR) 10Mattflaschen: "I asked csteipp to take a look at this, particularly regarding the ip issue (see comment about 'ipallusers', etc.)." [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [23:09:21] (03CR) 10Jdlrobson: [C: 04-1] "(6 comments)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [23:10:58] jdlrobson, does the PHPUnit command I gave work? [23:14:46] superm401: looking :) [23:15:58] superm401: works perfect [23:15:59] thank you :D [23:16:10] No problem. :) [23:16:31] That's the nice thing about Vagrant. [23:19:19] (03CR) 10EBernhardson: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [23:19:26] (03PS4) 10Tim Starling: Add $wgSemiprotectedRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/90552 (owner: 10Anomie) [23:19:31] jdlrobson, could you also explain a little better why it's needed? [23:19:31] (03CR) 10Tim Starling: [C: 032] Add $wgSemiprotectedRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/90552 (owner: 10Anomie) [23:19:47] superm401: you mean the startup module stuff? [23:19:57] Well, startup too. I didn't see the answer to that. [23:20:04] But also, RL can combine modules into one HTTP response in a lot of cases anyway, so I'm just not sure if this is worth the complexity. [23:20:15] superm401: mostly it's for cleaner code [23:20:29] but if you look at https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=startup&only=scripts&skin=mobile&target=mobile&* [23:20:50] you'll see lots of schema module names [23:21:05] i envision a world where we have schemas.echo, schemas.mobile, schemas.growth etc [23:21:33] jdlrobson, oh, the schema names. Yeah, but I'm not that worried about that. [23:21:43] TimStarling: hi, did you get the bugmail about https://bugzilla.wikimedia.org/show_bug.cgi?id=56041 ? [23:21:46] It's a fraction even of the startup module. [23:22:00] As an example of a RL url combining them: [23:22:01] http://127.0.0.1:8080/w/load.php?debug=true&lang=en&modules=schema.GettingStartedOnRedirect,GuidedTour&only=scripts&skin=vector&version=20131003T195902Z [23:22:11] I hand-crafted that, but the same idea applies to the URLs RL makes. [23:22:20] (03CR) 10Tim Starling: "In that case, the vagueness of the new protectedpagewarning message concerns me. It doesn't seem very user-friendly." [core] - 10https://gerrit.wikimedia.org/r/90357 (owner: 10Anomie) [23:22:49] MatmaRex: yes, I saw it [23:23:22] TimStarling: okay, just checking – i've been told some people ignore their bugmail :) [23:24:50] (03Merged) 10jenkins-bot: Add $wgSemiprotectedRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/90552 (owner: 10Anomie) [23:26:18] 2621 unread out of 4170 since January [23:26:31] so, 50/50 chance you see something? :) [23:26:39] little better than 50/50 [23:26:43] err, worse [23:26:49] heh [23:26:51] well, if the subject line is interesting then it's probably better than 50/50 [23:28:18] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90902 (owner: 10Matthias Mullie) [23:29:35] (03CR) 10Mattflaschen: "(3 comments)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [23:31:29] MatmaRex: so no change was made in response to Sean's complaints? [23:31:59] AaronSchulz: about? [23:32:11] yes [23:32:18] * Aaron|home was reading http://aphyr.com/posts/292-call-me-maybe-nuodb [23:32:43] (03CR) 10Mattflaschen: "He also mentioned the new module names would be like schemas.echo, schemas.mobile, schemas.growth, etc." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/91512 (owner: 10Jdlrobson) [23:34:12] Aaron|home: just wondering if you had any issue with me +2ing https://gerrit.wikimedia.org/r/#/c/90051/ [23:34:12] (03CR) 10EBernhardson: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91348 (owner: 10Werdna) [23:35:32] (03PS1) 10MarkTraceur: Fixes from MLB upstream [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91531 [23:36:31] Has mingle replaced bugzilla? [23:36:34] werdna: no [23:36:39] <^d> PiRSquared: No? [23:36:53] PiRSquared: It's sort of supplementing Bugzilla [23:36:57] For some teams [23:37:17] Yeah, I asked about this in -corefeatures a few days ago. [23:37:29] Still not quite sure why some bugs are copied there and some aren't. [23:37:40] <^d> s/-corefeatures/-lamechannelnumber73/ [23:37:46] (e.g., https://bugzilla.wikimedia.org/show_bug.cgi?id=56008 ) [23:38:12] they're copied over because bugzilla is good for issue tracking whereas mingle is good for project planning [23:38:32] <^d> For certain values of good. [23:38:45] haha, for which half? [23:39:08] <^d> Both ;-) [23:39:28] PiRSquared: basically, mingle is more about the team planning "what am I doing today, tomorrow, and what do we expect to be done at the close of each work iteration", [23:39:29] :D [23:39:52] PiRSquared: so for tracking bugs, they just happen to get imported so they can be put into the work schedule [23:39:54] (03PS8) 10Werdna: New hook accommodates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [23:40:05] sorry ebernhardson, had to fix the spelling in the commit message :p [23:40:07] it was bugging me [23:40:07] Okay. [23:40:10] werdna: no problem :) [23:40:19] (03CR) 10Werdna: [C: 032] New hook accommodates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [23:43:08] thats it for me today, might be back a bit later [23:43:53] heyhey rfarrand [23:44:09] <^d> Who wants to help me wontfix a bunch of bugs? [23:44:29] * ori-l wonthelp [23:44:43] (03Merged) 10jenkins-bot: New hook accommodates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [23:44:56] more like who won'ts to fix me a bunch of bugs [23:44:57] amirite [23:45:10] <^d> Nope :p [23:45:34] OK, time to clear up something that has been bothering me for a while: when you refer to an instance method of a class in a comment, do you use '::' or '->'? That is, Exception::getTrace, or Exception->getTrace? [23:45:37] ^d: i'm sure Elsie will [23:45:38] >.> [23:45:59] <^d> ori-l: Are you coding or writing about it? [23:46:02] writing about it [23:46:09] <^d> I generally always use double-colons. [23:46:13] <^d> Probably wrong :) [23:46:24] I do it too because it looks 'right' somehow. [23:46:32] ClassName->methodName looks wrong. [23:46:50] <^d> I can type :: faster than -> [23:46:52] ClassName#methodName 4life. [23:46:56] <^d> Chalk it up to lazziness? [23:47:10] why not [23:47:34] <^d> laziness even. [23:47:39] <^d> Don't know where that second z came from. [23:48:01] for some reason I imagine people dancing in sequins when I hear "lazziness" [23:48:08] (03CR) 10Mattflaschen: "I forgot to mention, I did confirm by testing that there was a difference in behavior for autoconfirmed users (you can also see that the o" [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [23:48:46] <^d> werdna: Now I have an image of you dancing in sequins. Thank you for that. [23:50:25] ^d: The sequins are not required to make the image bad :D [23:50:36] brb, my mysql is being stubborn [23:52:00] (03PS1) 10MarkTraceur: Clear interface before opening again [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91533 [23:58:09] (03PS1) 10Kaldari: Cherrypicking change I8d750d4f82f from master for MobileFrontent [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91534