[00:01:01] aude: That pull request is likely to be a mess. I'll try to rebase it. [00:03:28] or i can do it [00:22:34] (03PS4) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [00:25:28] (03CR) 10Dan-nl: "fixed mwext-GWToolset-jslint #30 issue: Bad line breaking before '!=='" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [00:30:12] (03CR) 10Mattflaschen: "Commit should have said "It does *not* need to write to this directory in general" (i.e. www-data doesn't have to write to the rest of /va" [vagrant] - 10https://gerrit.wikimedia.org/r/89619 (owner: 10Mattflaschen) [00:32:55] mwalker: hey, sorry I was away, sounds like fun happened [00:33:28] I've had more fun [00:33:31] but it wasn't bad [00:33:35] are we good now? [00:33:45] well; awight would still like to deploy his patch [00:33:55] greg-g: yeah no worries if it's not a good time [00:34:02] let's wait 'til tomorrow [00:34:05] cool? [00:34:08] sure [00:34:12] awesomesauce [00:34:15] I'm leaving again then! [00:34:16] ;) [00:34:17] later [00:49:06] (03PS5) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [00:49:55] (03CR) 10Dan-nl: "added jsdoc comments." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [01:29:03] (03PS2) 10Spage: Add 'mediawiki.ui' CSS module to all pages [core] - 10https://gerrit.wikimedia.org/r/87296 (owner: 10Mattflaschen) [01:35:45] (03PS1) 10Tim Starling: Fixes for duplicateStderr (I833aeb3a) [core] - 10https://gerrit.wikimedia.org/r/91114 [01:35:46] (03PS1) 10Tim Starling: Improve logging for wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/91115 [01:38:35] ori-l, you there? [01:48:25] (03PS6) 10Spage: Add Agora mw-ui-button classes to various buttons [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [02:15:46] (03CR) 10Brian Wolff: "Ignore my last comment, I misinterpreted what you meant. Contactinfo and software can be formatted differently. I suppose that is unideal." [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [02:28:50] (03PS1) 10Spage: Mention the new HTMLForm 'vform' display format. [core] - 10https://gerrit.wikimedia.org/r/91116 [02:31:31] (03CR) 10Aaron Schulz: [C: 032] Fixes for duplicateStderr (I833aeb3a) [core] - 10https://gerrit.wikimedia.org/r/91114 (owner: 10Tim Starling) [02:34:29] (03Merged) 10jenkins-bot: Fixes for duplicateStderr (I833aeb3a) [core] - 10https://gerrit.wikimedia.org/r/91114 (owner: 10Tim Starling) [02:34:45] (03CR) 10Mwalker: [C: 032] Mention the new HTMLForm 'vform' display format. [core] - 10https://gerrit.wikimedia.org/r/91116 (owner: 10Spage) [02:46:47] (03CR) 10Spage: "PS6 depends on not-abandoned version of "Add 'mediawiki.ui' CSS module to all pages". Although from reading that commit's RELEASE-NOTES-1." [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [02:54:38] (03CR) 10Mattflaschen: "Yeah, anything in code that relies on mediawiki.ui (a special page, extension UI, etc.) should add mediawiki.ui directly." [core] - 10https://gerrit.wikimedia.org/r/52169 (owner: 10Mattflaschen) [03:15:35] (03PS1) 10Chad: Remove unused variable and fix outdated comment [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91118 [03:32:39] (03PS1) 10Chad: General code cleanup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91119 [03:43:09] (03CR) 10Parent5446: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [03:53:02] (03CR) 10Werdna: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91073 (owner: 10EBernhardson) [03:53:26] (03CR) 10PleaseStand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [03:54:25] (03PS6) 10PleaseStand: installer: Run the LESS compiler for screen.less [core] - 10https://gerrit.wikimedia.org/r/89610 [03:57:06] (03PS1) 10EBernhardson: Add role::profiler utilizing XHProf from pecl [vagrant] - 10https://gerrit.wikimedia.org/r/91122 [04:00:40] (03PS2) 10Chad: General code cleanup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91119 [04:09:21] (03PS5) 10Pastakhov: Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 [04:14:04] (03CR) 10Pastakhov: [C: 032] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [04:14:10] (03CR) 10jenkins-bot: [V: 04-1] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [04:14:38] (03CR) 10Parent5446: [C: 04-1] "(7 comments)" [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [04:15:25] superm401: hey [04:16:02] ori-l, hey, I was going to ask you about Redis, but I did some more research then filed https://bugzilla.wikimedia.org/show_bug.cgi?id=55981 [04:18:47] superm401: Increasing it to 32M (or more) is a good idea [04:18:55] whoa, this looks kinda scary :p https://www.mediawiki.org/wiki/Extension:Foxway [04:19:46] superm401: we could also store sessions in a separate logical redis database (a single redis instance can have up to 16 databases, where a redis 'database' is a key namespace with its own set of settings) [04:20:05] ori-l, yeah, that might be a good idea. [04:20:27] I wasn't able to find whether you could have different memory policies for each database, though I did find a post where someone discouraged having multiple DBs. [04:20:32] If you track that info down, can you post to the bug? [04:20:38] yeah, sure [04:21:28] can you try articulating the problem again? The bug is informative, and I agree that the setup seems a bit poorly-configured, but to have a really good configuration I think we'd need to get specific about what issues we're looking to avoid. [04:22:20] (03PS6) 10Pastakhov: Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 [04:22:54] (03CR) 10Pastakhov: [C: 032] Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [04:22:59] (03Merged) 10jenkins-bot: Add CONTINUE and BREAK operators [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/90492 (owner: 10Pastakhov) [04:23:23] ori-l, tried to clarify it. [04:23:41] Basically, it eventually makes Redis unusable. [04:23:45] Or at least can with some usage patterns. [04:23:56] unwritable to be specific. [04:24:01] Edited the bug. [04:24:04] superm401: oh, right -- I see that now. [04:24:20] I didn't catch the volatile-lru / allkeys-lru distinction at first [04:24:39] I think the proper fix is exactly what you proposed [04:25:15] I'll submit a patch, just a moment. [04:36:20] (03CR) 10Zfilipin: [C: 032] add when_present clauses to reduce flaky test failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91096 (owner: 10Cmcmahon) [04:38:42] Thanks ori-l. [04:38:54] (03CR) 10PleaseStand: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [04:38:57] I'm getting "Unable to load dynamic library '/usr/lib/php5/20090626/igbinary.so'" when I start phpsh. [04:39:03] And then it can't evaluate any PHP. [04:39:16] ori-l, would appreciate any thoughts on that when you have a chance. [04:41:22] (03PS1) 10Ori.livneh: redis: 32M -> 64M, volatile-lru -> allkeys-lru [vagrant] - 10https://gerrit.wikimedia.org/r/91127 [04:43:31] superm401: is the problem easy to reproduce? (i.e., does it happen every time you try to run phpsh?) what happens if you free up some memory? (for example, by stopping the apache2 and redis-server services) [04:51:40] (03PS1) 10AndyRussG: Fix errors if course/org forms are re-submitted [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 [04:53:35] ori-l, yeah, it's reproducible. [04:53:57] I have about 140 MB free, so I don't think it's memory. [04:54:03] I suspect it might be related to removing memcached. [04:56:25] (03PS1) 10Chad: Remove unused and largely pointless function [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91129 [04:59:57] ori-l, fixed with: [05:00:10] sudo apt-get purge php5-igbinary php5-memcached [05:00:23] Actually, php5-memcached doesn't seem to be a problem, but the igbinary config files were. [05:00:39] vagrant provision doesn't try to put them back (since memcached is fully removed), so it shouldn't be an issue for fresh installs. [05:01:42] (03PS2) 10Tim Starling: Improve logging for wfShellExec() [core] - 10https://gerrit.wikimedia.org/r/91115 [05:02:00] (03CR) 10Tim Starling: "(9 comments)" [core] - 10https://gerrit.wikimedia.org/r/91115 (owner: 10Tim Starling) [05:10:24] (03CR) 10Mattflaschen: [C: 04-1] "It was 16 MB before." [vagrant] - 10https://gerrit.wikimedia.org/r/91127 (owner: 10Ori.livneh) [05:10:49] (03PS2) 10Ori.livneh: redis: 32M -> 64M, volatile-lru -> allkeys-lru [vagrant] - 10https://gerrit.wikimedia.org/r/91127 [05:15:02] (03PS3) 10Mattflaschen: redis: 16M -> 64M, volatile-lru -> allkeys-lru [vagrant] - 10https://gerrit.wikimedia.org/r/91127 (owner: 10Ori.livneh) [05:15:30] superm401: oh, hah. I missed the 'double' [05:15:31] (03CR) 10Mattflaschen: "Edited to fix double." [vagrant] - 10https://gerrit.wikimedia.org/r/91127 (owner: 10Ori.livneh) [05:15:36] thanks [05:15:41] No problem. [05:16:06] I'd kind of like to test a little more, then I'll merge. [05:16:22] There still might be a better approach to avoid stuff getting evicted too fast, but we can iterate. [05:20:16] sure, thank you. [05:27:17] (03PS1) 10EBernhardson: [WIP] Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [05:28:12] (03CR) 10EBernhardson: [C: 04-2] "still has some issues updating historical revision moderation, and needs styling for display of moderated topic content." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 (owner: 10EBernhardson) [05:43:59] (03PS1) 10Chad: Fix ElasticaConnection to not care what wiki we're on [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 [05:44:40] (03CR) 10Chad: "Bwahahaha! Evil plans step 1!" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/91137 (owner: 10Chad) [05:50:22] (03CR) 10Santhosh: [C: 032] "Technically correct. Correctness per language verified by Base_w" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88202 (owner: 10Odder) [05:50:25] (03Merged) 10jenkins-bot: Modify vocative case for Ukrainian Wikinews [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88202 (owner: 10Odder) [05:54:46] (03CR) 10devunt: [C: 031] "ping?" [core] - 10https://gerrit.wikimedia.org/r/54120 (owner: 10devunt) [05:57:10] (03PS1) 10Mattflaschen: Test BagOStuff->incr method [core] - 10https://gerrit.wikimedia.org/r/91138 [06:20:50] (03PS1) 10Zfilipin: test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91139 [06:22:08] (03Abandoned) 10Zfilipin: test [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91139 (owner: 10Zfilipin) [06:43:33] (03PS1) 10Rfaulk: mod - updates to README doc. [sartoris] - 10https://gerrit.wikimedia.org/r/91140 [06:43:56] (03CR) 10Rfaulk: [C: 032 V: 032] mod - updates to README doc. [sartoris] - 10https://gerrit.wikimedia.org/r/91140 (owner: 10Rfaulk) [07:14:14] (03PS1) 10Pastakhov: add operator T_STATIC [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91142 [07:17:15] (03PS3) 10Chad: General code cleanup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91119 [08:03:30] hello [08:12:30] (03CR) 10Hashar: "(1 comment)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [08:12:37] (03PS2) 10Hashar: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 [08:49:13] (03PS1) 10Zfilipin: The first Jenkins job for Translate extension [selenium] - 10https://gerrit.wikimedia.org/r/91153 [08:55:52] (03PS1) 10Addshore: Refactor OutputPageTest [core] - 10https://gerrit.wikimedia.org/r/91154 [08:58:08] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91077 (owner: 10Addshore) [08:59:01] (03PS2) 10Hashar: Add more @covers tags and test cleanup [core] - 10https://gerrit.wikimedia.org/r/91077 (owner: 10Addshore) [08:59:44] (03PS3) 10Hashar: Add more @covers tags and test cleanup [core] - 10https://gerrit.wikimedia.org/r/91077 (owner: 10Addshore) [09:01:15] (03CR) 10Hashar: [C: 032] "Per quick rereview with addshore over IRC." [core] - 10https://gerrit.wikimedia.org/r/91077 (owner: 10Addshore) [09:04:51] (03Merged) 10jenkins-bot: Add more @covers tags and test cleanup [core] - 10https://gerrit.wikimedia.org/r/91077 (owner: 10Addshore) [09:39:04] (03CR) 10Pastakhov: [C: 032] add operator T_STATIC [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91142 (owner: 10Pastakhov) [09:39:11] (03Merged) 10jenkins-bot: add operator T_STATIC [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91142 (owner: 10Pastakhov) [09:40:57] (03PS1) 10Hashar: no more voting on code-review [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91157 [09:41:43] (03CR) 10Hashar: [C: 032] no more voting on code-review [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91157 (owner: 10Hashar) [09:41:51] (03Merged) 10jenkins-bot: no more voting on code-review [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91157 (owner: 10Hashar) [09:43:03] (03CR) 10Hashar: "deployed" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/91157 (owner: 10Hashar) [09:48:30] (03PS1) 10Addshore: Cleanup MagicVariableTest [core] - 10https://gerrit.wikimedia.org/r/91158 [09:49:45] (03CR) 10jenkins-bot: [V: 04-1] Cleanup MagicVariableTest [core] - 10https://gerrit.wikimedia.org/r/91158 (owner: 10Addshore) [09:52:27] (03PS2) 10Addshore: Cleanup MagicVariableTest [core] - 10https://gerrit.wikimedia.org/r/91158 [09:52:45] (03PS1) 10Nikerabbit: mw.api.postWithToken now forwards promise on fail if we have token [core] - 10https://gerrit.wikimedia.org/r/91159 [09:58:25] (03PS4) 10Werdna: WIP: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 [10:23:00] (03CR) 10Aklapper: "IMO, Patchset 4 is ready to get deployed on live Bugzilla. Not sure if csteipp wants to make another review." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/74360 (owner: 10Aklapper) [10:34:35] hashar: ready for a fun changeset? :> [10:34:40] (03PS1) 10Addshore: Cleanup /languages/* tests [core] - 10https://gerrit.wikimedia.org/r/91163 [10:36:04] no way :D [10:36:43] :> [10:36:57] its amazing what you cna do when your waiting to fly home :P [10:39:34] I imagine coverage will no longer report Language as the number 2 risk class ;p [10:52:57] (03PS1) 10Pastakhov: add operator T_GLOBAL [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91166 [10:53:57] (03CR) 10Pastakhov: [C: 032] add operator T_GLOBAL [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91166 (owner: 10Pastakhov) [10:54:02] (03Merged) 10jenkins-bot: add operator T_GLOBAL [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/91166 (owner: 10Pastakhov) [11:02:50] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91138 (owner: 10Mattflaschen) [11:10:30] (03CR) 10Addshore: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [11:15:06] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [11:19:26] (03CR) 10Addshore: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [11:33:01] (03PS5) 10Werdna: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 [11:36:11] (03CR) 10Addshore: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [11:37:59] (03PS6) 10Werdna: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 [11:57:33] (03CR) 10Werdna: [V: 031] New hook accomidates non-revision rc queries [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [12:08:08] (03CR) 10Hashar: [C: 032] Cleanup /languages/* tests [core] - 10https://gerrit.wikimedia.org/r/91163 (owner: 10Addshore) [12:08:15] addshore: some more coverage landing in [12:10:28] (03CR) 10Santhosh: [C: 04-1] "(1 comment)" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/88712 (owner: 10Siebrand) [12:11:01] (03Merged) 10jenkins-bot: Cleanup /languages/* tests [core] - 10https://gerrit.wikimedia.org/r/91163 (owner: 10Addshore) [12:12:11] addshore: manually triggered the code coverage job, we should see updated content in roughly 45 minutes [12:15:38] awesome :) [12:15:48] im just about to go the the airport but will check it when I land :D [12:33:43] (03PS8) 10Gergő Tisza: Add extmetadata to the ForeignAPIFile iiprops [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [12:34:13] (03CR) 10Gergő Tisza: "Added explicit visibility per Siebrand's comments." [core] - 10https://gerrit.wikimedia.org/r/88889 (owner: 10MarkTraceur) [12:42:52] (03PS1) 10Zfilipin: another test commit [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91176 [12:44:34] (03PS1) 10Aude: Remove extra margin in related sites list [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/91177 [12:44:58] (03CR) 10JanZerebecki: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [12:46:56] (03Abandoned) 10Zfilipin: another test commit [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91176 (owner: 10Zfilipin) [12:48:05] (03CR) 10Esanders: "There is? I looked but couldn't find one." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [13:02:20] (03PS1) 10Zfilipin: the third test commit [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91178 [13:03:47] (03Abandoned) 10Zfilipin: the third test commit [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91178 (owner: 10Zfilipin) [13:23:38] (03CR) 10Krinkle: "Should these icons be @embed'ed?" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91040 (owner: 10Esanders) [13:24:39] (03PS10) 10Cmcmahon: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [13:25:35] (03CR) 10JanZerebecki: [C: 031] Cleanup MagicVariableTest [core] - 10https://gerrit.wikimedia.org/r/91158 (owner: 10Addshore) [13:25:55] (03CR) 10Cmcmahon: [C: 032] "merging this pending one more change to mark the test @chrome-bug per Bug 55751" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [13:26:13] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [13:30:42] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [13:32:15] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/77645 (owner: 10Parent5446) [13:41:12] (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/91177 (owner: 10Aude) [13:45:46] (03CR) 10Aude: "(1 comment)" [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/91177 (owner: 10Aude) [13:46:23] (03PS1) 10Cmcmahon: don't run the ProveIt test for Chrome because of Bug 55751 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91180 [13:47:10] (03CR) 10Chad: [C: 04-1] "Realized as I was going to sleep last night that this has a ton of problems. Will amend." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/91119 (owner: 10Chad) [13:50:23] (03CR) 10Krinkle: [C: 04-1] "* Don't forget to remove the attr() call." [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [13:52:44] FOR GOD SAKE GERRIT [13:53:13] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/91116 (owner: 10Spage) [13:53:16] * werdna hugs hashar  [13:54:07] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91116 (owner: 10Spage) [13:54:39] (03CR) 10Hashar: "(1 comment)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [13:54:44] (03PS3) 10Hashar: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 [14:00:56] (03PS4) 10Hashar: Zuul status page: indicator learned waiting state [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 [14:02:06] (03CR) 10Hashar: "Sorry the chaining was being done on $container instead of $indicator which broke the page." [integration/docroot] - 10https://gerrit.wikimedia.org/r/91057 (owner: 10Hashar) [14:02:17] (03Abandoned) 10Cmcmahon: don't run the ProveIt test for Chrome because of Bug 55751 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91180 (owner: 10Cmcmahon) [14:03:49] (03PS1) 10Zfilipin: test commit #4 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91181 [14:05:53] (03PS1) 10Cmcmahon: ProveIt gadget causes Page test to fail in Chrome Bug 55751 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91182 [14:05:59] (03CR) 10jenkins-bot: [V: 04-1] ProveIt gadget causes Page test to fail in Chrome Bug 55751 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91182 (owner: 10Cmcmahon) [14:07:36] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [14:10:34] (03Abandoned) 10Zfilipin: test commit #4 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91181 (owner: 10Zfilipin) [14:13:04] (03CR) 10Amire80: [C: 031] mw.api.postWithToken now forwards promise on fail if we have token [core] - 10https://gerrit.wikimedia.org/r/91159 (owner: 10Nikerabbit) [14:19:01] (03CR) 10Brian Wolff: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/67047 (owner: 10Brian Wolff) [14:23:17] (03PS2) 10Zfilipin: ProveIt gadget causes Page test to fail in Chrome Bug 55751 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91182 (owner: 10Cmcmahon) [14:52:24] (03CR) 10Cmcmahon: [C: 032] ProveIt gadget causes Page test to fail in Chrome Bug 55751 [qa/browsertests] - 10https://gerrit.wikimedia.org/r/91182 (owner: 10Cmcmahon) [15:12:07] (03CR) 10Siebrand: "PS3 will not contain the file that was commented on." [extensions/cldr] - 10https://gerrit.wikimedia.org/r/88712 (owner: 10Siebrand) [15:28:09] (03CR) 10Anomie: [C: 031] "Should work, haven't tested though." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91051 (owner: 10Aaron Schulz) [15:38:51] (03PS3) 10Siebrand: Update formatting [extensions/cldr] - 10https://gerrit.wikimedia.org/r/88712 [15:39:05] (03CR) 10JanZerebecki: [C: 04-1] "Looks good. Please also add names for the data items provided (the key in the array will be used as a name)." [core] - 10https://gerrit.wikimedia.org/r/91154 (owner: 10Addshore) [15:44:40] (03PS1) 10Siebrand: WIP: No newline in empty arrays [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91192 [15:46:33] (03CR) 10JanZerebecki: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91154 (owner: 10Addshore) [15:59:14] (03PS7) 10Werdna: Moderation confirmation dialogues. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 [16:11:38] (03PS1) 10EBernhardson: Stub profiler for the XHProf pecl extension [core] - 10https://gerrit.wikimedia.org/r/91193 [16:15:53] (03CR) 10Amire80: [C: 032] Update formatting [extensions/cldr] - 10https://gerrit.wikimedia.org/r/88712 (owner: 10Siebrand) [16:16:02] (03Merged) 10jenkins-bot: Update formatting [extensions/cldr] - 10https://gerrit.wikimedia.org/r/88712 (owner: 10Siebrand) [16:16:06] (03CR) 10EBernhardson: "Related patch for mediawiki to generate xhprof profiles is at https://gerrit.wikimedia.org/r/91193" [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson) [16:18:33] (03CR) 10MarkTraceur: "OK, well, I should pull out the dependencies for the rest of these patches since the language stuff will take time to resolve." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [16:21:02] (03CR) 10MarkTraceur: "Or maybe I'll write the fix, but I should still pull out the dependencies." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [16:21:50] (03CR) 10Jeroen De Dauw: [C: 031] Increase limits to Special:MyCourses activity feeds [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/86880 (owner: 10Ragesoss) [16:22:17] (03CR) 10Jeroen De Dauw: [C: 031] Add comments to clarify the structure of the extension. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/82888 (owner: 10Ragesoss) [16:23:57] (03CR) 10Jeroen De Dauw: [C: 031] "Looks like a decent solution within the existing framework. Global state usage and whatnot, though that can hardly be avoided in the exten" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [16:24:59] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [16:25:52] (03CR) 10Ragesoss: [C: 031 V: 031] "Tested locally, and this works to solve the problem of users creating duplicate courses. It also prevents a similar thing for institutions" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [16:27:03] (03PS2) 10Siebrand: Do not add empty arrays [extensions/cldr] - 10https://gerrit.wikimedia.org/r/91192 [16:41:57] (03PS2) 10EBernhardson: Add role::profiler utilizing XHProf from pecl [vagrant] - 10https://gerrit.wikimedia.org/r/91122 [16:42:08] (03PS1) 10Aaron Schulz: Slight message tweak to be cleared [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91196 [16:42:42] (03PS2) 10Krinkle: Remove extra margin in related sites list [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/91177 (owner: 10Aude) [16:43:37] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91138 (owner: 10Mattflaschen) [16:45:14] (03PS2) 10Aaron Schulz: Slight message tweak to be cleared [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91196 [16:47:25] (03CR) 10Krinkle: [C: 031] mw.api.postWithToken now forwards promise on fail if we have token [core] - 10https://gerrit.wikimedia.org/r/91159 (owner: 10Nikerabbit) [16:47:37] (03CR) 10Anomie: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm) [16:50:57] (03PS1) 10MarkTraceur: Fix interface creation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 [16:51:14] (03PS8) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [16:54:26] (03CR) 10BryanDavis: [C: 032] item specific categories throws an exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90527 (owner: 10Dan-nl) [16:54:32] (03Merged) 10jenkins-bot: item specific categories throws an exception [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90527 (owner: 10Dan-nl) [16:58:18] (03PS9) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [16:58:19] (03PS2) 10MarkTraceur: Fix interface creation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 [16:59:09] ^d: hey, can you point me to some documentation on gerrit and lucene? [16:59:54] (03PS6) 10Dan-nl: second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [17:00:17] <^d> manybubbles: https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#_a_id_index_a_section_index is as much I know of. [17:00:26] <^d> We're not using it yet, we're a bit far behind master. [17:00:59] thanks [17:01:34] (03CR) 10Dan-nl: "rebased with master." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 (owner: 10Dan-nl) [17:02:03] (03CR) 10MarkTraceur: "Was rebasing, will write fix for nasty grungy gender support later." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [17:06:51] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88990 (owner: 10Hashar) [17:09:11] (03CR) 10Siebrand: [C: 032] Slight message tweak to be clearer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91196 (owner: 10Aaron Schulz) [17:09:16] (03Merged) 10jenkins-bot: Slight message tweak to be clearer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91196 (owner: 10Aaron Schulz) [17:14:15] (03CR) 10Siebrand: [C: 031] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [17:16:55] csteipp: if I understand this correctly the current OAuth implementation basically sets up wgUser and does the normal permission checking using that [17:18:09] (03PS5) 10BryanDavis: lockmanager: QuorumLockManager subclasses can get EX/SH locks at once [core] - 10https://gerrit.wikimedia.org/r/69021 (owner: 10Aaron Schulz) [17:19:58] (03CR) 10Siebrand: "This is waiting for who to +2?" [core] - 10https://gerrit.wikimedia.org/r/91159 (owner: 10Nikerabbit) [17:20:36] gwicke: Sort of. It checks the OAuth headers to make sure it's authorized, then gets the authorizing user and sets up wgUser, then when permissions are checked anywhere, it intercepts the call and only allows permissions authorized by the user [17:22:48] csteipp: ah, ok- so it does some subsetting as well [17:23:22] that might mean that groups are too coarse for db-less authorization [17:23:23] yes, that's one of the major features of OAuth [17:23:29] (03CR) 10MarkTraceur: [C: 04-1] "Sorry, lost the -1 there." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [17:23:43] gwicke: It's based on rights, not groups [17:23:57] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [17:24:08] yes, was just thinking if your proposal to include groups would be sufficient info for authorization [17:24:14] the answer is no [17:24:20] (03PS1) 10Umherirrender: ValidationStatistics: Showing unreviewed pages depends on config [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/91205 [17:24:23] (03PS1) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [17:24:24] Ah, yeah, I think we'll list all the granted rights too [17:24:46] that would be great [17:25:11] (03CR) 10Umherirrender: "A follow up exists: I6c779b9ab425deaea9cab8ea4813563c095db889" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89412 (owner: 10Umherirrender) [17:26:03] (03CR) 10Anomie: [C: 04-1] "Gergő raises a good point, if these arrays are breaking stuff that needs fixing." [core] - 10https://gerrit.wikimedia.org/r/81598 (owner: 10Brian Wolff) [17:26:04] csteipp: for authorization we might want to go off granted rights directly, to avoid having to infer those from groups [17:26:22] avoids complexity and potential for bugs [17:26:29] (03CR) 10EBernhardson: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [17:27:08] csteipp: how long is the list of rights currently? [17:27:24] It all depends on what the user granted for the OAuth Consumer [17:27:36] yeah, and the granularity [17:27:42] If they grant everything available, that's somethink like 100 rights [17:28:25] that would need an efficient encoding to be workable [17:28:50] the JWT is not compressed [17:30:17] has to fit in 4k [17:31:57] can always use a bitmask ;) [17:32:02] what has to fit in 4k? [17:32:08] the JWT [17:32:37] it should really be much smaller than that, but 4k is the practical limit for HTTP headers [17:32:38] Is that in the spec? [17:32:57] The jwt shouldn't be in a header.... [17:32:58] no, it's not in the HTTP spec either [17:33:12] oh- so no bearer tokens? [17:34:17] re HTTP header sizes: http://stackoverflow.com/questions/686217/maximum-on-http-header-values [17:35:25] No disagreement on apache's max header size. I'm just not sure the Bearer token would ever include a JWT assertion [17:35:44] in OAuth connect it normally does [17:35:51] OpenID connect that is [17:36:02] and OAuth 2 with bearer tokens [17:36:24] transmitting 100 bits should be doable though [17:37:29] I'm looking at 2.3.1 on http://openid.net/specs/openid-connect-basic-1_0.html [17:37:36] Only the access token is sent. [17:37:45] in the Authorization header [17:37:56] (03CR) 10Bartosz Dziewoński: [C: 032] "(1 comment)" [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/91177 (owner: 10Aude) [17:37:58] (03Merged) 10jenkins-bot: Remove extra margin in related sites list [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/91177 (owner: 10Aude) [17:38:27] But I'll admit I don't know the whole spec, so if they might send it somewhere else.. [17:38:43] csteipp: the access token is an OAuth2 bearer token though [17:38:47] so JWT or SAML [17:39:28] for my use case it would of course make sense for the access token to contain the granted rights [17:40:13] gwicke: I don't think that's quite right, but I'll see if that is done anywhere [17:41:28] csteipp: my understanding is based on http://datatracker.ietf.org/wg/oauth/ [17:41:56] there are bearer specs for JWT and SAML2 currently [17:42:43] gwicke: Right, no disagreement there. The disagreement is I don't think OpenID Connect's access token is ever anything except a cryptographically random string [17:43:07] to the user it is opaque [17:43:15] We would *not* be implementing other OAuth2 specs [17:43:30] but a bearer token normally contains more than an ID [17:43:52] OpenID connect references http://datatracker.ietf.org/doc/rfc6750/ [17:44:10] ori-l: you around? [17:44:14] Right. We would only implement http://openid.net/specs/openid-connect-basic-1_0.html [17:45:04] csteipp: and you'd pick a simple id token over a bearer token? [17:45:36] (03CR) 10EBernhardson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91193 (owner: 10EBernhardson) [17:46:13] gwicke: I'll look through the spec and see what options it gives. My understanding is that is what the spec uses. But it's still in draft, so feel free to get your comments in :) [17:46:42] csteipp: my understanding is that it supports any bearer token you'd want to use [17:47:25] including http://openid.net/specs/draft-jones-oauth-jwt-bearer-03.html [17:48:16] (03PS3) 10MarkTraceur: Fix interface creation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 [17:57:28] (03PS1) 10Aaron Schulz: Split up ManageMyGrants form into update and revoke forms [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91212 [17:58:37] csteipp: https://gerrit.wikimedia.org/r/#/c/91089/ fairly simple [18:00:26] mooeypoo: hey [18:01:29] (03CR) 10Aaron Schulz: "Ugly, but reliable." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91051 (owner: 10Aaron Schulz) [18:04:36] (03CR) 10BryanDavis: [C: 032] lockmanager: QuorumLockManager subclasses can get EX/SH locks at once [core] - 10https://gerrit.wikimedia.org/r/69021 (owner: 10Aaron Schulz) [18:05:28] (03PS2) 10Aaron Schulz: Added log excepts to ManageMyGrants page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91089 [18:06:21] AaronSchulz: Is that really a good idea? Seems like users might get confused about that... [18:07:33] csteipp: the log? [18:07:39] (03Merged) 10jenkins-bot: lockmanager: QuorumLockManager subclasses can get EX/SH locks at once [core] - 10https://gerrit.wikimedia.org/r/69021 (owner: 10Aaron Schulz) [18:07:40] Yeah [18:08:10] csteipp: maybe, if they were expecting the log to be their stuff and not app stuff [18:08:24] Yeah, that's what I was thinking [18:09:09] actually that should go in https://gerrit.wikimedia.org/r/#/c/88251/ [18:10:31] (03PS8) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [18:10:45] (03CR) 10MarkTraceur: "Rebased, no longer depends on username patch." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [18:10:52] (03CR) 10EBernhardson: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [18:11:43] (03PS3) 10Aaron Schulz: Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 [18:11:44] (03CR) 10jenkins-bot: [V: 04-1] Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 (owner: 10Aaron Schulz) [18:12:05] (03Abandoned) 10Aaron Schulz: Added log excerpts to ManageMyGrants page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91089 (owner: 10Aaron Schulz) [18:12:42] AaronSchulz: on https://gerrit.wikimedia.org/r/#/c/89236/1, is there any case where that is actually hit? Wouldn't the wiki have to pass validation, which does a check for a valid wiki id, first? [18:12:46] conflict, yeah [18:12:52] *yay [18:14:47] (03PS4) 10Aaron Schulz: Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 [18:15:03] csteipp: yeah, but it's stupid to even let that in the DB [18:15:15] or give the appearance that it makes any sense for the user to to [18:15:18] *to do [18:15:25] AaronSchulz: Probably so.. [18:15:34] (03PS9) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [18:15:38] * AaronSchulz rages at http://productforums.google.com/forum/#!topic/websearch/RAgNBkvgkXY [18:15:45] (03CR) 10MarkTraceur: "Updated message" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [18:16:02] (03CR) 10CSteipp: [C: 032] "Kinda redundant, but works ok and makes the intent clear in that section of code too." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89236 (owner: 10Aaron Schulz) [18:16:03] (03CR) 10jenkins-bot: [V: 04-1] Added sanity check for updating "wiki" field of consumer acceptance [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89236 (owner: 10Aaron Schulz) [18:17:36] (03PS2) 10Aaron Schulz: Added sanity check for updating "wiki" field of consumer acceptance [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89236 [18:17:52] (03CR) 10EBernhardson: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 (owner: 10Matthias Mullie) [18:19:42] (03CR) 10EBernhardson: [C: 032] Fix moderation permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90351 (owner: 10Matthias Mullie) [18:19:48] (03Merged) 10jenkins-bot: Fix moderation permissions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90351 (owner: 10Matthias Mullie) [18:20:35] (03CR) 10Aaron Schulz: [C: 032] Added sanity check for updating "wiki" field of consumer acceptance [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89236 (owner: 10Aaron Schulz) [18:20:40] (03Merged) 10jenkins-bot: Added sanity check for updating "wiki" field of consumer acceptance [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89236 (owner: 10Aaron Schulz) [18:21:25] (03CR) 10EBernhardson: [C: 032] Hide mediawiki action tabs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90917 (owner: 10Matthias Mullie) [18:21:30] (03Merged) 10jenkins-bot: Hide mediawiki action tabs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90917 (owner: 10Matthias Mullie) [18:24:05] (03PS1) 10ArielGlenn: xml dump maintenance scripts should use the 'dump' db group [core] - 10https://gerrit.wikimedia.org/r/91213 [18:24:40] (03PS2) 10Matthias Mullie: WIP - Historical view of a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91206 [18:24:52] (03PS4) 10MarkTraceur: Fix interface creation [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91201 [18:24:52] hm and who do I ping for a review on xml dump maintenance scripts... ugh [18:24:58] no one looks at these evah [18:25:30] (03PS10) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [18:25:37] * apergos adds Reedy rather randomly (feel free to suggest someone that's a better match) [18:25:44] legoktm: phpstorm7 apparently has vagrant integration [18:25:45] apergos: silently self merge when everyone else is sleeping? :D [18:25:45] apergos: also, I was poking about if there's something I can do to help with getting pageview data onto labs [18:26:00] clone me *sigh* [18:26:15] there's a cron job which is in puppet for that, [18:26:20] * apergos checks that it's in puppet [18:26:32] For cloning you? [18:26:33] for the copy to the gluster public data partition I mean [18:26:44] ah I wish... if there is, it's been broken since forever [18:27:35] files/mirror/gluster-rsync-cron.sh [18:28:11] ah [18:28:12] looking [18:28:14] so adding something onto the end that rsyncs over the pageview stuff [18:28:27] is the current dumps on toollabs on... gluster!? [18:28:30] onto the end of the sh script, and add me as reviewer [18:28:33] oh [18:28:35] erm [18:28:44] I think that was the discussion right? about space and etc [18:29:02] what's the bug, do you have the link handy? [18:29:45] apergos: looking [18:30:05] apergos: https://bugzilla.wikimedia.org/show_bug.cgi?id=48894 [18:30:17] labs is on NFS, not gluster [18:30:48] home is [18:30:50] (03PS11) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [18:31:03] what's in public/datasets/public right now? [18:31:10] (03CR) 10MarkTraceur: "Bunch of tweaks, but now I'm happier about the look of this patch." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [18:32:54] apergos: i'm trying to find out if they're on nfs or glusterfs [18:33:10] (03CR) 10Ori.livneh: "Your thinking seems sound so I'm removing my -1. Hope to go over this patch more thoroughly sometime this week." [core] - 10https://gerrit.wikimedia.org/r/90541 (owner: 10Krinkle) [18:33:12] just see what mount says on one of those instances [18:34:56] apergos: i'm trying to find out where /public is mounted on, but mount has no entry, and I can't find a symlink anywhere... [18:34:59] is it on localdisk!? [18:35:02] ori-l: Do you mind explaining what you meant originally though? "the modification time for x′ will roll back to x. " was that about before the change, after the change or what the change should be [18:35:15] I think you have a good point. [18:35:21] seems pretty unlikely [18:35:23] oh nevermind [18:35:23] apergos: it's nfs [18:35:30] from what host? [18:35:32] Whether it's worth changing is something else, but I'd like to know the case we're giving up :) [18:36:12] apergos: i'll poke at puppet. thanks [18:37:52] ok what we'll want is: rsyncd running on the nfs host, a stanza that lets the dataset* hosts write to that directory, and a cron job one liner added to the end (for now) of the gluster cron.sh, so I don't wind up with several rsyncs going at once on there [18:38:30] guess I should rename that script after that [18:38:30] (03PS6) 10MarkTraceur: Fetch extended metadata from the API [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 [18:38:37] thanks for volunteering to look at it [18:39:36] apergos: :D [18:39:48] apergos: yeah, to not say glusterfs [18:39:52] yeah [18:40:28] (03CR) 10CSteipp: "(2 comments)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 (owner: 10Aaron Schulz) [18:41:11] apergos: so if I understand it correctly, it runs a special python script if it isn't already running for copying over the dumps, and then just rsyncs for incremental dumps [18:41:49] if I want pagecount data, I can just use whatever the current incrementaldumps stuff does [18:43:50] (03PS2) 10MarkTraceur: Fix a few fullscreen bugs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 [18:44:01] (03CR) 10MarkTraceur: "Rebased out of the nasty username patch" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90660 (owner: 10MarkTraceur) [18:44:38] Krinkle: yes, I intend to follow-up. I just thought your response is plausibly right, and -1s tend to repel reviewers, and I didn't want your patch to be blocked just because I haven't found the time to reason through it and reply in detail. [18:45:03] ori-l: okay :) [18:45:03] yes, the special python script is because we want to copy just certain files etc [18:45:13] ori-l: btw, evil plan: https://www.mediawiki.org/wiki/Continuous_integration/Workflow_v2_specification [18:45:15] so just stick the additional rsync on at the end [18:45:30] making sure you don't run it if it's still running from the last time [18:45:39] YuviPanda: [18:45:48] apergos: yeah, will do [18:45:53] thanks! [18:45:59] Krinkle: oooh, looks cool [18:53:06] [blocked] The page at https://www.mediawiki.org/w/index.php?title=Continuous_integration/Workflow_v2_specification&action=edit ran insecure content from http://wikimediafoundation.org/wiki/Special:BannerRandom?uselang=en&sitenam…roject=wikimedia&anonymous=false&bucket=0&country=NL&device=desktop&slot=5. [18:53:34] Krinkle: #wikimedia-fundraising [18:53:37] possibly [18:54:41] k [18:55:13] awight: oh, you're over here, I asked mwalker over in -tech, but, when do ya'll wanna do your fix today? [18:55:28] greg-g: I'm in many places :) [18:55:30] sounds like during the LD [18:55:32] mwalker: ditto [18:55:33] yep [18:55:33] :/ [18:55:35] k [18:55:36] thanks [18:55:38] cool, I'll add it [18:56:16] (03PS10) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [18:56:45] {{done}} [19:02:21] (03CR) 10MarkTraceur: "Based on the interface patch because it makes merging variable lists easier later on." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89103 (owner: 10MarkTraceur) [19:08:25] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/91216 (owner: 10L10n-bot) [19:23:54] greg-g: BTW, I edited https://wikitech.wikimedia.org/wiki/Deployments to add a VE LD today (we didn't do it yesterday despite your prompting, sorry). [19:24:56] James_F: saw, and thanks [19:27:28] (03PS8) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [19:28:25] (03PS1) 10Aude: Update Wikibase [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91283 [19:28:29] (03PS1) 10Aude: Update RelatedSites extension [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91284 [19:28:48] greg-g: Reedy (if you are available and around) ^ [19:29:29] one for wikibase and i went ahead and fixed a small ugly bug for wikivoyage [19:35:24] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/91216 (owner: 10L10n-bot) [19:39:01] StevenW: hi, did you get my mail? [19:39:52] MatmaRex: aw shit I just remembered that I promised to look at that thing [19:40:21] ori-l: hah [19:40:43] happens all the time [19:42:38] (03PS5) 10MarkTraceur: Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 [19:43:24] (03PS3) 10Bartosz Dziewoński: mediawiki.util: Use 'wikipage.content' hook for TOC hiding [core] - 10https://gerrit.wikimedia.org/r/85526 [19:49:08] (03PS2) 10Mattflaschen: Test BagOStuff->incr method [core] - 10https://gerrit.wikimedia.org/r/91138 [19:51:14] (03CR) 10Mattflaschen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/91138 (owner: 10Mattflaschen) [19:53:54] (03PS1) 10MarkTraceur: Add whitelistHtml method [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/91286 [19:55:15] (03PS9) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [19:57:33] (03PS7) 10MarkTraceur: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 [19:58:12] (03CR) 10AndyRussG: "(2 comments)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/91128 (owner: 10AndyRussG) [20:12:56] (03PS11) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [20:21:45] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 (owner: 10Aaron Schulz) [20:26:30] (03PS5) 10Aaron Schulz: Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 [20:26:39] (03CR) 10jenkins-bot: [V: 04-1] Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 (owner: 10Aaron Schulz) [20:27:17] (03PS12) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [20:28:51] (03PS3) 10EBernhardson: Display nested exception backtrace's [core] - 10https://gerrit.wikimedia.org/r/91073 [20:33:30] (03CR) 10MarkTraceur: "Well, siebrand, I feel really dirty, but that should suffice for now. I'm going to investigate what happens when a cross-domain request is" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [20:40:02] (03PS13) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [20:40:31] (03CR) 10MarkTraceur: "Now that's how you take care of business." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [20:43:03] (03PS2) 10MarkTraceur: Only add handlers on image thumbnails [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90455 [20:44:16] (03CR) 10MarkTraceur: [C: 04-2] "I'll abandon this once I get the two parents rebased on top of each other, but for now it serves as a harrowing reminder of what is and wh" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90425 (owner: 10MarkTraceur) [20:46:03] I feel like I've done enough/too much rebasing today. [20:47:49] aude: Does "optimizely" ring a bell for you? [20:48:01] multichill: no [20:49:08] My dad just pointed it out to me. Apparently one of my family members funded that and when I googled it, the office was right next to the WMF office ;-) [20:51:14] oh, cool [20:51:51] many offices have no signs outside, so it's mysterious [20:52:35] stealth startup [20:52:41] :) [20:53:14] aude: https://www.optimizely.com/contact is almost on top of you [20:53:51] cool :) [20:54:52] (03PS6) 10Aaron Schulz: Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 [21:02:24] (03PS1) 10Anomie: Provide default messages for OAuth tags [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91295 [21:06:47] (03PS2) 10Anomie: Provide default messages for OAuth tags [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91295 [21:11:41] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/91216 (owner: 10L10n-bot) [21:29:29] (03CR) 10Chad: [C: 032] Remove calls to wfDebugDieBacktrace [extensions/OAI] - 10https://gerrit.wikimedia.org/r/91078 (owner: 10PleaseStand) [21:29:34] (03Merged) 10jenkins-bot: Remove calls to wfDebugDieBacktrace [extensions/OAI] - 10https://gerrit.wikimedia.org/r/91078 (owner: 10PleaseStand) [21:32:30] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91283 (owner: 10Aude) [21:32:48] (03CR) 10Reedy: [C: 032 V: 032] Update RelatedSites extension [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91284 (owner: 10Aude) [21:37:51] (03PS1) 10Mattflaschen: Fix Redis increment behavior [core] - 10https://gerrit.wikimedia.org/r/91296 [21:38:24] (03CR) 10jenkins-bot: [V: 04-1] Fix Redis increment behavior [core] - 10https://gerrit.wikimedia.org/r/91296 (owner: 10Mattflaschen) [21:38:26] (03PS2) 10Mattflaschen: Fix Redis increment behavior by using BagOStuff->incr instead [core] - 10https://gerrit.wikimedia.org/r/91296 [21:39:18] (03PS3) 10Mattflaschen: Fix Redis increment behavior by using BagOStuff->incr instead [core] - 10https://gerrit.wikimedia.org/r/91296 [21:40:00] (03CR) 10Mattflaschen: "This is on top of the commit adding a test, so it can be tested with:" [core] - 10https://gerrit.wikimedia.org/r/91296 (owner: 10Mattflaschen) [21:42:46] (03CR) 10Tim Starling: "What is the /D modifier for? The manual says that it has no effect when the /m modifier is not specified." [core] - 10https://gerrit.wikimedia.org/r/81368 (owner: 10Anomie) [21:44:38] (03PS1) 10Katie Horn: Revert "Revert "Adding RapidError Pages! woo."" Yep: Revert the revert. It's time to use these error forms. [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/91297 [21:44:55] (03PS1) 10Ori.livneh: mediawiki.inspect: add CSS report [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91298 [21:45:50] (03CR) 10Mattflaschen: "It turns out that there were a couple Redis-related bugs affecting my Vagrant instance, where I was testing this (Redis is used for everyt" [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [21:48:56] (03CR) 10Adamw: [C: 032 V: 032] "the "gateway" parameter is tripping me out. But otherwise..." [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/91297 (owner: 10Katie Horn) [21:49:52] (03CR) 10Spage: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [21:50:36] (03PS1) 10Ori.livneh: mw.inspect: decline to report module sizes when in debug mode [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91299 [21:51:05] (03CR) 10Addshore: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [21:56:13] (03CR) 10Ori.livneh: [C: 032] mw.inspect: decline to report module sizes when in debug mode [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91299 (owner: 10Ori.livneh) [21:56:58] (03CR) 10Ori.livneh: [C: 032] mediawiki.inspect: add CSS report [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91298 (owner: 10Ori.livneh) [21:57:34] manybubbles: ^demon With cirrus could sort do some sort of title case matching? [21:57:39] uh, elastic [21:57:55] Like, say I visited "List of The Walking Dead Episodes" [21:57:57] Which doesn't exist [21:58:04] What I wanted was actually "List of The Walking Dead episodes" etc [21:58:23] !e TitleKey | Reedy [21:58:24] Reedy: https://www.mediawiki.org/wiki/Extension:TitleKey_%7c_Reedy [21:58:31] WTF wm-bot [21:58:38] aww [21:58:44] lol [21:58:48] (03CR) 10Aaron Schulz: "Ideally digit strings would not be serialized, just like with memcached. Maybe setOption() could be abused a bit to disable and re-enable " [core] - 10https://gerrit.wikimedia.org/r/91296 (owner: 10Mattflaschen) [21:58:49] <^demon> TitleKey doesn't help for PrefixSearching and hasn't in years. [21:58:51] !ask | RoanKattouw [21:58:52] RoanKattouw: Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [21:58:56] See that does work [21:59:01] * RoanKattouw files bug against wm-bot [21:59:03] <^demon> It's basically only good for the fallback behavior for direct page matching :) [21:59:21] (03Merged) 10jenkins-bot: mw.inspect: decline to report module sizes when in debug mode [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91299 (owner: 10Ori.livneh) [21:59:40] (03PS1) 10Ori.livneh: mediawiki.inspect: add CSS report [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91301 [21:59:46] (03CR) 10Ori.livneh: [C: 032] mediawiki.inspect: add CSS report [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91301 (owner: 10Ori.livneh) [21:59:47] There must be tonnes of case differing hits where people don't find what htey want [22:01:11] (03Merged) 10jenkins-bot: mediawiki.inspect: add CSS report [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91298 (owner: 10Ori.livneh) [22:03:39] can someone remind me how to add qunit to jenkins ? [22:04:02] jdlrobson: I'm not sure that's something mortals can do, you might have to ask hashar or Krinkle [22:04:18] RoanKattouw: i seem to remember it was a config switch in some magical file [22:04:21] define 'adding qunit to jenkins' [22:04:28] (03CR) 10CSteipp: [C: 032] Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 (owner: 10Aaron Schulz) [22:04:58] well i just want MobileFrontend to run qunit tests specific to mobile with every commit (non-voting to start off with) [22:05:08] (03CR) 10Spage: "A couple of times the Hide post reason dialog (which shouldn't appear for Hide actions) remained on-screen underneath the "Successfully hi" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [22:05:19] jdlrobson: ah, a new job. In that case look at integration/jenkins-job-builder-config [22:05:23] see [[mw:CI/JJB]] [22:05:36] should be able to just use the macro we have already for core and VisualEditor etc. [22:05:38] that's the one! thanks [22:05:39] so 1 line [22:05:55] (03Merged) 10jenkins-bot: mediawiki.inspect: add CSS report [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91301 (owner: 10Ori.livneh) [22:05:58] jdlrobson: it might exist already, in which case you need to edit int/zuul-config to enable it [22:05:59] (03Merged) 10jenkins-bot: Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 (owner: 10Aaron Schulz) [22:06:21] thanks Krinkle - taking a look now [22:06:26] right now we generate most jobs automatically by pattern, so there's lots of jenkins jobs not triggered by Zuul [22:06:34] jdlrobson: k :) [22:07:52] Krinkle: i see '{name}-{ext-name}-qunit': [22:07:56] under MobileFrontend [22:08:06] sorry: - '{name}-{ext-name}-qunit': [22:08:25] * jdlrobson not familiar with yaml files [22:08:41] RoanKattouw: duped. [22:09:07] jdlrobson: If that's listed, then 1) see if it was pushed to jenkins by accessing the url for it, if not hashar or I will have to generate and deploy that [22:09:26] that on itself doesn't enable it, also ensure it is present in the Zuul config for the MobileFrontend pipeline [22:09:36] Krinkle: how do i find the url? [22:09:44] e.g. https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/ [22:10:09] that url exists... [22:10:21] and https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit/ as well [22:10:26] and it has past builds too [22:10:35] to the zuul.. [22:10:37] last triggered just a few hours ago [22:11:00] Are you sure we're answering the same question? [22:11:10] https://gerrit.wikimedia.org/r/#/c/91202/ [22:11:13] it ran there [22:11:19] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit/1920/console : SUCCESS in 25s [22:11:47] Krinkle: ahh yes now i see them - ok so i suspect the problem is targets :) [22:12:15] Krinkle: is there anyway http://localhost:9412/mediawiki-extensions-MobileFrontend-f69afc75945bab1a0c5d6ea5f87686d4353a4d77/index.php?title=Special:JavaScriptTest/qunit can be written with target=mobile ? [22:12:24] or do we need to enable all our modules on desktop? [22:17:00] jdlrobson: I suppose not [22:17:19] but the unit tests, what logical units are you testing that are mobile-only? [22:17:36] assuming you're not doing UI testing in QUnit [22:18:15] Hm.. are the tests actually registered? [22:18:23] Not a single mobilefrontend module is loaded on that test page [22:18:31] Krinkle: in theory JS should run fine on desktop - the problem is they might look funky on desktop if ever loaded so it adds leakage that we may want to avoid [22:19:12] Krinkle: do they need to be registered in a different way from normal? [22:19:29] there's a hook for it [22:19:42] anyway, I don't think it's wise to enable them all for desktop indeed. [22:20:13] We'll have to add a parameter to that url somehow and make it overridable through lots of abstraction layers to eventualluy allow MobileFrontend/jenkins to set it [22:20:18] Open a bug instead :) [22:20:32] Antoine or myself will implement it soon. [22:21:45] Krinkle: where should i open said bug? [22:21:58] e.g. which product [22:24:30] xD [22:24:37] jdlrobson: Wikimedia > C O [22:24:41] Cont Int [22:24:48] thanks Krinkle ;-) [22:27:28] (03PS4) 10Legoktm: redis: 16M -> 64M, volatile-lru -> allkeys-lru [vagrant] - 10https://gerrit.wikimedia.org/r/91127 (owner: 10Ori.livneh) [22:42:39] (03PS2) 10EBernhardson: Moderate a post or topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91135 [22:48:59] (03CR) 10Werdna: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 (owner: 10Werdna) [22:49:34] (03PS1) 10EBernhardson: Refactor much of the php code out of post.html.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 [22:50:15] (03CR) 10EBernhardson: "In a way this seems better than what we have, but in a way it just seems like splitting the template into two files. I dunno, critique th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/91306 (owner: 10EBernhardson) [22:58:38] (03PS1) 10Mwalker: Updating centralnotice to masterish -- missing mobile patch [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91308 [23:03:27] (03CR) 10Mwalker: [C: 032] Updating centralnotice to masterish -- missing mobile patch [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91308 (owner: 10Mwalker) [23:08:06] greg-g, RoanKattouw: OK; my deploy is done [23:08:14] er, wrong channel [23:08:51] :) [23:12:44] (03PS1) 10Catrope: Update VisualEditor to wmf21 branch for cherry-picks [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91313 [23:13:27] (03PS3) 10TTO: Make the link in import log entry always use canonical namespace [core] - 10https://gerrit.wikimedia.org/r/84197 [23:14:01] (03PS1) 10MarkTraceur: Add popup CTA for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/91314 [23:14:11] (03CR) 10Catrope: [C: 032] Update VisualEditor to wmf21 branch for cherry-picks [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91313 (owner: 10Catrope) [23:15:26] (03PS1) 10Catrope: Update VisualEditor to wmf22 branch for cherry-picks [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91315 [23:15:41] (03CR) 10Catrope: [C: 032] Update VisualEditor to wmf22 branch for cherry-picks [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91315 (owner: 10Catrope) [23:18:31] (03Merged) 10jenkins-bot: Update VisualEditor to wmf21 branch for cherry-picks [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/91313 (owner: 10Catrope) [23:21:18] (03PS2) 10CSteipp: Split up ManageMyGrants form into update and revoke forms [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91212 (owner: 10Aaron Schulz) [23:21:19] (03CR) 10jenkins-bot: [V: 04-1] Split up ManageMyGrants form into update and revoke forms [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91212 (owner: 10Aaron Schulz) [23:21:45] (03Merged) 10jenkins-bot: Update VisualEditor to wmf22 branch for cherry-picks [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91315 (owner: 10Catrope) [23:26:49] (03PS1) 10Catrope: Update VisualEditor to wmf22 again [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91320 [23:26:59] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor to wmf22 again [core] (wmf/1.22wmf22) - 10https://gerrit.wikimedia.org/r/91320 (owner: 10Catrope) [23:35:48] RoanKattouw: do you think you'll have the time to look over / greenlight the localStorage patch for testing on a production wiki? [23:36:16] ori-l: When I come back from running some visa docs over, sure [23:36:26] You pinged me about this earlier today but I forgot about it, sorry [23:36:36] np :) thank you! [23:39:39] (03CR) 10CSteipp: [C: 031] "Seems reasonable. Security looks fine." [core] - 10https://gerrit.wikimedia.org/r/84197 (owner: 10TTO) [23:42:53] (03PS3) 10CSteipp: Split up ManageMyGrants form into update and revoke forms [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91212 (owner: 10Aaron Schulz) [23:43:29] (03CR) 10CSteipp: [C: 032] "PS3 was a manual rebase" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91212 (owner: 10Aaron Schulz) [23:43:34] (03Merged) 10jenkins-bot: Split up ManageMyGrants form into update and revoke forms [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91212 (owner: 10Aaron Schulz) [23:44:24] (03CR) 10Aaron Schulz: [C: 032] Test BagOStuff->incr method [core] - 10https://gerrit.wikimedia.org/r/91138 (owner: 10Mattflaschen) [23:44:41] (03CR) 10Aaron Schulz: [C: 032] Fix Redis increment behavior by using BagOStuff->incr instead [core] - 10https://gerrit.wikimedia.org/r/91296 (owner: 10Mattflaschen) [23:44:56] (03Abandoned) 10Aaron Schulz: Hack to set a default ManageMyGrants form button [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/91051 (owner: 10Aaron Schulz) [23:47:27] (03Merged) 10jenkins-bot: Test BagOStuff->incr method [core] - 10https://gerrit.wikimedia.org/r/91138 (owner: 10Mattflaschen) [23:49:02] (03Merged) 10jenkins-bot: Fix Redis increment behavior by using BagOStuff->incr instead [core] - 10https://gerrit.wikimedia.org/r/91296 (owner: 10Mattflaschen) [23:51:25] ori-l: Wow: http://httparchive.org/viewsite.php?pageid=11675485#bytesFont&reqFont [23:51:40] ori-l: (Thanks for the link re. httparchive!) [23:52:18] James_F: yes, fonts are 942kB out of 1298kB total for that report [23:52:31] the situation should be improved by the time the next report runs [23:52:47] Good. [23:52:53] I hate to think what "worse" would be. [23:53:05] (03PS1) 10Aaron Schulz: Made redis lock manager get EX/SH locks in one go [core] - 10https://gerrit.wikimedia.org/r/91325 [23:53:32] * AaronSchulz grins at bd808 [23:53:57] Also, apparently we should run some additional compression on our image thumbnails, which is the least surprising but possibly easiest noticeable fix in that report. [23:54:03] (After fonts.) [23:54:45] AaronSchulz: More stuff for me to review? [23:54:54] * bd808 looks at the patch quickly [23:55:50] bd808: easier to look at the new file from scratch [23:56:05] * AaronSchulz noticed some fun bugs while at it [23:56:13] Looks like it might be. I'll put it on my list. [23:56:53] I just got my own project to work on too. \o/ [23:59:58] (03CR) 10EBernhardson: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/91122 (owner: 10EBernhardson)