[00:39:24] (03PS1) 10Physikerwelt: startup script skeleton for upstart [extensions/Math] - 10https://gerrit.wikimedia.org/r/90731 [01:07:48] (03PS3) 10Legoktm: Merge SimpleAntiSpam extension into core [core] - 10https://gerrit.wikimedia.org/r/90291 [01:28:05] (03CR) 10Jeroen De Dauw: "Hashar: I think whitelist is better. In any case, blacklist vs whitelist is really a nitpick, this approach works and fixes the problem." [core] - 10https://gerrit.wikimedia.org/r/90584 (owner: 10JanZerebecki) [03:26:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90739 (owner: 10Gerrit Patch Uploader) [03:28:11] Elsie: thanks for https://wikitech.wikimedia.org/wiki/Site_performance_brainstorming :D [03:30:00] No problem. [03:30:12] There's also now /Site_performance. [03:31:24] Oh, cool. I'm going to try and use that to log work on site performance. [03:32:09] Nice. [06:47:19] My accomplishment for the day: writing and uploading a patch to gerrit entirely on my iPhone. [06:48:02] legoktm: That's terrible [06:48:32] :( [06:52:46] Wouldn't it have taken less time and effort to go find a laptop? [06:55:04] There were no laptops where I was :( [07:10:09] (03PS1) 10Tpt: Move rendering of Page: pages to ProofreadPageViewAction [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90741 [07:14:00] (03PS2) 10Tpt: Move rendering of Page: pages to ProofreadPageViewAction [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/90741 [07:40:46] (03CR) 10Hashar: "Mark, my question is more how we could skip plurals entirely when the xml extension is not present. This way we would be able to die out " [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [08:22:41] (03PS1) 10Ori.livneh: mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 [08:25:40] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [08:30:04] (03PS1) 10Legoktm: Remove duplicate "global $wgUser" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90743 [08:40:58] Change on 12mediawiki a page WMF Projects/Data Dumps was modified, changed by Nemo bis link https://www.mediawiki.org/w/index.php?diff=805058 edit summary: added [[Category:Import/Export]] using [[w:Wikipedia:HotCat|HotCat]] [09:33:02] (03PS1) 10Legoktm: EchoBasicFormatter::formatFragment returns a Message object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90747 [09:50:14] (03CR) 10Legoktm: "Er, when would that be the case? The only situation I can think of would be when a notification is bundled, and in those cases, it would l" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90688 (owner: 10Legoktm) [10:05:35] (03PS3) 10Legoktm: Make it possible for EditPage::getCopyrightWarning to return HTML [core] - 10https://gerrit.wikimedia.org/r/90289 [10:05:53] (03CR) 10Legoktm: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90289 (owner: 10Legoktm) [10:41:31] (03PS2) 10Physikerwelt: Install node and phantomjs for serverside MathJax execution [vagrant] - 10https://gerrit.wikimedia.org/r/90702 [10:43:14] (03CR) 10Physikerwelt: "see also https://gerrit.wikimedia.org/r/#/c/90733/" [vagrant] - 10https://gerrit.wikimedia.org/r/90702 (owner: 10Physikerwelt) [10:44:18] (03PS7) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 [10:45:03] (03PS4) 10Legoktm: Have action=info check protected namespaces [core] - 10https://gerrit.wikimedia.org/r/39845 [10:45:11] (03CR) 10Legoktm: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [10:52:49] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90289 (owner: 10Legoktm) [10:54:11] (03CR) 10Bartosz Dziewoński: [C: 031] Make it possible for EditPage::getCopyrightWarning to return HTML [core] - 10https://gerrit.wikimedia.org/r/90289 (owner: 10Legoktm) [11:14:39] (03CR) 10TTO: [C: 031] Fix double-parsing of account creation messages. [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [11:57:14] (03CR) 10Bartosz Dziewoński: "(8 comments)" [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [12:08:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [12:20:07] (03PS39) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [12:29:23] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [12:52:33] (03PS1) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [12:59:46] (03PS2) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [14:08:13] (03CR) 10Nikerabbit: [C: 032] Use $this->msg instead of $context->msg [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90739 (owner: 10Gerrit Patch Uploader) [14:08:27] (03Merged) 10jenkins-bot: Use $this->msg instead of $context->msg [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90739 (owner: 10Gerrit Patch Uploader) [14:09:25] (03PS2) 10Hashar: mediawiki/conf.d/_join.php minor fix + comment update [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90114 [14:10:42] (03PS1) 10Hashar: more extensions [extensions] - 10https://gerrit.wikimedia.org/r/90757 [14:11:04] (03CR) 10Hashar: "rebased" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90114 (owner: 10Hashar) [14:11:10] (03CR) 10Hashar: [C: 032] more extensions [extensions] - 10https://gerrit.wikimedia.org/r/90757 (owner: 10Hashar) [14:11:40] (03CR) 10Hashar: [V: 032] more extensions [extensions] - 10https://gerrit.wikimedia.org/r/90757 (owner: 10Hashar) [14:40:51] (03CR) 10Alex Monk: [C: 032] Remove duplicate "global $wgUser" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90743 (owner: 10Legoktm) [14:41:00] (03Merged) 10jenkins-bot: Remove duplicate "global $wgUser" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90743 (owner: 10Legoktm) [14:48:55] (03CR) 10Alex Monk: [C: 032] EchoBasicFormatter::formatFragment returns a Message object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90747 (owner: 10Legoktm) [14:50:43] (03Merged) 10jenkins-bot: EchoBasicFormatter::formatFragment returns a Message object [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90747 (owner: 10Legoktm) [14:55:58] (03Abandoned) 10Foxtrott: (bug 54930) Labels for checkboxes/radiobuttons should appear inline [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88240 (owner: 10Huji) [15:48:27] (03CR) 10Mdale: [C: 031 V: 032] "Looks fine. But interesting its an issue to begin with, I take it, unset does not update the index but array_splice does? Or how is this d" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87715 (owner: 10Bartosz Dziewoński) [17:26:42] (03CR) 10Bartosz Dziewoński: "Yes:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87715 (owner: 10Bartosz Dziewoński) [17:34:27] (03PS3) 10Umherirrender: Clean up old title on move before reset article id [core] - 10https://gerrit.wikimedia.org/r/89226 [18:01:19] MatmaRex: gave it a -1 with a comment, will go through when my internet stops sucking [18:01:23] and gerrit stops sucking as bad as it is now [18:01:36] heh, okay [18:01:36] MatmaRex: comment being 'Should probably mention this in the docstring too, considering that the current 4 ones are mentioned there.' [18:01:40] also, fuck gerrit [18:01:48] +1 [18:01:55] which change was that about? [18:02:00] (03CR) 10Yuvipanda: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90652 (owner: 10Bartosz Dziewoński) [18:02:06] MatmaRex: ^ [18:02:08] ok. [18:03:22] MatmaRex: I'll merge https://gerrit.wikimedia.org/r/#/c/90155/1 after testing [18:03:58] i'm fixing the other one up, just waiting for it to download locally [18:04:07] heh ok [18:04:11] i'll go have a shower now [18:04:15] also, fuck timezones :P [18:09:52] (03PS2) 10Bartosz Dziewoński: BaseTemplate: Exclude two more attributes in makeLink() [core] - 10https://gerrit.wikimedia.org/r/90652 [18:10:33] (03CR) 10MarkAHershberger: "Serializing the data allows us to use it without an XML parser. We would still use the CLDR lookup, but we would be using the serialized " [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [18:25:32] (03CR) 10Yuvipanda: "(1 comment)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88151 (owner: 10Legoktm) [18:47:52] (03PS3) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [18:52:49] (03PS4) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [18:58:41] (03PS5) 10Physikerwelt: Breakdown of texvc [extensions/Math] - 10https://gerrit.wikimedia.org/r/90748 [19:13:37] MatmaRex: ping [19:13:43] why not (bool) instead of + 'required' => !!$this->data['emailrequired'], [19:13:56] sorry, stupid paste [19:29:13] YuviPanda: ugh, i dunno, JS habit [19:29:26] MatmaRex: change to cast? [19:29:40] i hate casts [19:29:48] isn't that guaranteed boolean, anyway? [19:29:58] brb [19:32:48] MatmaRex: either way, !! is bad [19:34:01] MatmaRex: indeed, it's used like it is boolean elsewhere [19:44:09] YuviPanda: on it, thanks [19:47:01] (03PS2) 10Bartosz Dziewoński: Simplify boolean attribute handling for Html::input in templates [core] - 10https://gerrit.wikimedia.org/r/90155 [19:50:46] (03PS2) 10Brian Wolff: Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 [19:51:19] (03CR) 10jenkins-bot: [V: 04-1] Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [19:51:27] (03CR) 10Brian Wolff: "PS2: per MatmaRex" [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [19:52:08] i don't ever remember commenting on that :o [19:52:28] (03PS3) 10Brian Wolff: Add Special:ListDuplicatedFiles expensive query special page. [core] - 10https://gerrit.wikimedia.org/r/85446 [19:52:47] MatmaRex: I actually totally forgot you did too, until I looked at it right now [19:53:39] (03CR) 10Brian Wolff: "ps3: rebase" [core] - 10https://gerrit.wikimedia.org/r/85446 (owner: 10Brian Wolff) [20:03:31] Am I missing something obvious (likely!) or is the first line of code here circular and unneeded: https://de.wikipedia.org/wiki/MediaWiki:Gadget-navigation-popups.js [20:47:48] (03CR) 10Ori.livneh: "(7 comments)" [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [20:48:23] (03PS2) 10Ori.livneh: mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 [20:51:18] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [20:51:42] (03PS1) 10Brian Wolff: Cache Page content language in Title object. [core] - 10https://gerrit.wikimedia.org/r/90769 [20:54:28] (03Abandoned) 10Brian Wolff: [DO NOT MERGE] Make image on desc page not clickable if $file->mustRender() true. [core] - 10https://gerrit.wikimedia.org/r/86383 (owner: 10Brian Wolff) [20:54:37] (03CR) 10jenkins-bot: [V: 04-1] Cache Page content language in Title object. [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [20:56:29] (03CR) 10GWicke: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent) [20:59:17] (03Merged) 10jenkins-bot: Don't match HTML entities in language conversion syntax [core] - 10https://gerrit.wikimedia.org/r/83112 (owner: 10Liangent) [21:02:42] (03PS6) 10PleaseStand: Parser::replaceInternalLinks: fix batching [core] - 10https://gerrit.wikimedia.org/r/89835 [21:08:01] has someone already filed a bug for git.wm.o and github replication being broken? [21:15:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=55948 [21:17:34] (03PS40) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [21:18:08] legoktm: there's a saved search called "Bugs filed today", i recommend it :) [21:18:49] heh [21:19:31] there's also "Bugs filed yesterday", fun when you're bored and want to wontfix a bug or two [21:19:38] heh :P [21:35:28] (03PS1) 10MaxSem: Port to express [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/90770 [21:42:51] (03PS3) 10Ori.livneh: mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 [21:45:14] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90652 (owner: 10Bartosz Dziewoński) [21:45:28] ^ MatmaRex [21:45:31] and ^^ MatmaRex [21:45:32] :) [21:45:48] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [21:46:01] fucking jsduck ugh [21:46:52] oh, my fault this time. [21:47:18] (03PS4) 10Ori.livneh: mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 [21:54:16] (03PS2) 10Brian Wolff: Cache page content language in Title object. [core] - 10https://gerrit.wikimedia.org/r/90769 [21:56:26] ori-l: you know, gerrit really should allow for direct code editing, eh [21:59:00] heh [21:59:06] It's quite nice in github for little things [22:00:48] ori-l: I hear you're doing performance related stuff now - you might be interested in the conversation at https://commons.wikimedia.org/wiki/User_talk:Daniel78#Bot_doesn.27t_close_new_nominations (Its about a page on commons taking a long time to render) [22:01:39] I had to use Github pull requests in the past two days. The organisation that I was helping unfortunately can't give me an account on their gerrit. [22:01:58] Didn't realise how much I appreciated Gerrit's workflow compared to Github's until then [22:06:52] (03CR) 10Brian Wolff: "PS2: Make it actually work with unit tests and stuff. Plus fix me being stupid." [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [22:11:17] (03PS3) 10Ori.livneh: BaseTemplate: Exclude two more attributes in makeLink() [core] - 10https://gerrit.wikimedia.org/r/90652 (owner: 10Bartosz Dziewoński) [22:11:31] (03PS4) 10Ori.livneh: BaseTemplate: Exclude two more attributes in makeLink() [core] - 10https://gerrit.wikimedia.org/r/90652 (owner: 10Bartosz Dziewoński) [22:11:42] (03CR) 10Ori.livneh: [C: 032] BaseTemplate: Exclude two more attributes in makeLink() [core] - 10https://gerrit.wikimedia.org/r/90652 (owner: 10Bartosz Dziewoński) [22:12:01] bawolff: OK, I'll check it out [22:13:03] * bawolff made a commit to try and optimize one part, but there may be other things that could be optimized too [22:13:26] could we track this in a bug? [22:15:41] ori-l: oh, thanks [22:15:50] ori-l: i had to leave for a while there [22:15:53] ori-l: Sure, I'll file one [22:16:05] i submitted a patch via http://tools.wmflabs.org/gerrit-patch-uploader/ before it left, but apparently it failed. oh well [22:16:31] before i left* [22:17:13] (03Merged) 10jenkins-bot: BaseTemplate: Exclude two more attributes in makeLink() [core] - 10https://gerrit.wikimedia.org/r/90652 (owner: 10Bartosz Dziewoński) [22:19:33] bawolff: your patch looks good. I think I'll need help reviewing it, but I'll poke people. [22:19:41] (03CR) 10Bartosz Dziewoński: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [22:20:27] ori-l: ^ if that's ready to merge by you, i'll retest tomorrow and do it [22:21:15] bawolff: these small changes sometimes have bizarre action-at-a-distance effects that I have difficulty anticipating [22:21:33] MatmaRex: looking. thanks! [22:22:09] ori-l: Yeah, I already had some fun with the parser tests exploding on my first attempt [22:22:40] and it seems like something that affects language converter, which is an area of the code base I generally consider scary [22:24:06] (03PS5) 10Ori.livneh: mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 [22:25:57] (03PS3) 10Brian Wolff: Cache page content language in Title object. [core] - 10https://gerrit.wikimedia.org/r/90769 [22:27:01] (03PS6) 10Ori.livneh: mediawiki.inspect: add CSS report [core] - 10https://gerrit.wikimedia.org/r/90742 [22:27:19] MatmaRex: OK, ready from my perspective [22:28:48] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks okay, I'll retest and recheck tomorrow and merge." [core] - 10https://gerrit.wikimedia.org/r/90742 (owner: 10Ori.livneh) [22:28:57] ori-l: poke me if i forget [22:29:12] i'm off to sleep now and don't wanna merge stuff and disappear [22:29:28] It only disappears if we abandom it [22:30:11] (03CR) 10Ori.livneh: "Tim, what do you think? It looks good to me, but it affects parts of the code that have bizarre, action-at-a-distance effects that I often" [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [22:31:00] bye MatmaRex, hi Reedy [22:31:05] * ori-l runs off too [22:31:16] Pfft [22:33:33] REEDY IS LAST MAN LEFT STANDING! [22:42:25] (03PS8) 10Bartosz Dziewoński: Fix double-parsing of account creation messages. [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [22:43:21] (03CR) 10Bartosz Dziewoński: "Rebased, fixed trivial merge conflict in Message, did not test or review much." [core] - 10https://gerrit.wikimedia.org/r/47821 (owner: 10Parent5446) [22:43:39] and with that i am in fact off. somebody should review it and get it into 1.22. ^ [22:44:03] good night [23:11:31] (03CR) 10Parent5446: [C: 031] Have action=info check protected namespaces [core] - 10https://gerrit.wikimedia.org/r/39845 (owner: 10Legoktm) [23:17:35] (03CR) 10Parent5446: [C: 031] Cache page content language in Title object. [core] - 10https://gerrit.wikimedia.org/r/90769 (owner: 10Brian Wolff) [23:29:11] (03CR) 10Parent5446: [C: 031] Merge SimpleAntiSpam extension into core [core] - 10https://gerrit.wikimedia.org/r/90291 (owner: 10Legoktm) [23:37:59] (03PS2) 10MaxSem: Port to express [extensions/Minifier] - 10https://gerrit.wikimedia.org/r/90770 [23:41:45] (03CR) 10Parent5446: [C: 04-1] "(9 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [23:47:22] (03CR) 10Parent5446: [C: 031] "Good idea. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/90653 (owner: 10Aaron Schulz)