[00:00:00] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Add type hinting [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89383 (owner: 10Legoktm)
[00:00:53] <grrrit-wm>	 (03CR) 10Dereckson: "Follow-up: I57e82a75a5147582da83ea24bdcd518dc30e5607" [core] - 10https://gerrit.wikimedia.org/r/88628 (owner: 10Dereckson)
[00:01:55] <grrrit-wm>	 (03CR) 10MarkTraceur: "The Hooks class makes it possible to have things out of order - i.e. not putting the BetaFeatures include before anything that registers i" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 (owner: 10MarkTraceur)
[00:02:08] <grrrit-wm>	 (03CR) 10MaxSem: "> 'this->filters' is unused, remove for now? Or keep to move values of the configurable into this." [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem)
[00:02:46] <grrrit-wm>	 (03CR) 10Dereckson: "See Hashar comment Ib345518e338bc12ba110fdde754aaab4e56302df. His position is we should include available information in stacktrace. I con" [core] - 10https://gerrit.wikimedia.org/r/90067 (owner: 10Dereckson)
[00:03:24] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89357 (owner: 10Legoktm)
[00:04:19] <grrrit-wm>	 (03CR) 10Catrope: "Re use case, I'm assuming this is for the project that Max has been poking at that sets up a minifier service in node that uses uglifyjs a" [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem)
[00:04:47] <Elsie>	 RoanKattouw: I really like your new staff photo. :-)
[00:04:59] <RoanKattouw>	 Elsie: Link?
[00:05:03] <RoanKattouw>	 I wonder which one they used
[00:05:16] <Elsie>	 https://wikimediafoundation.org/wiki/File:Roan_Kattouw_(WMF)_2013.jpg
[00:05:25] <RoanKattouw>	 I probably saw it but I wasn't really paying attention at the time, all-staff + family visiting = Roan doesn't have time for anything
[00:05:33] <RoanKattouw>	 Nice
[00:05:35] <RoanKattouw>	 Yeah that's a good one
[00:08:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add type hinting [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89383 (owner: 10Legoktm)
[00:08:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Re-implement parser function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89357 (owner: 10Legoktm)
[00:08:30] <grrrit-wm>	 (03CR) 10Legoktm: "As long as the hook is registered in $wgHooks before the wfRunHooks call is made, it will work regardless of the order the extensions are " [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 (owner: 10MarkTraceur)
[00:10:55] <grrrit-wm>	 (03CR) 10Aaron Schulz: "(2 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89382 (owner: 10Legoktm)
[00:11:16] <grrrit-wm>	 (03CR) 10MarkTraceur: "De facto doesn't mean standard :)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 (owner: 10MarkTraceur)
[00:11:30] <legoktm>	 marktraceur :)
[00:12:09] <hashar>	 AzaToth: well too late for now (2am) so I am going to sleep a bit :-]
[00:12:13] <hashar>	 AzaToth: will keep you updated
[00:13:14] <grrrit-wm>	 (03CR) 10Legoktm: "PHP is weird: https://dpaste.de/3wGA/raw/" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 (owner: 10MarkTraceur)
[00:14:03] <AzaToth>	 ok
[00:15:31] <marktraceur>	 legoktm: Excuse me I have to go HIT SOMETHING
[00:15:49] <legoktm>	 hahaha 
[00:17:59] <legoktm>	 marktraceur: fwiw, there are 59 uses of Hooks::register in all extensions in gerrit
[00:18:13] <legoktm>	 according to my grep at least
[00:18:46] <hashar>	 i am not sure why we are not using Hooks:: class
[00:19:13] <hashar>	 I guess we can't really deprecate wfRunHooks()
[00:19:20] <hashar>	 and Hooks:* might not always be available
[00:19:32] <hashar>	 worth a mail in wikitech-l if anyone has time
[00:19:35] * hashar  sleeps

[00:21:01] <grrrit-wm>	 (03PS2) 10Legoktm: Use batch inserting of jobs [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89382 
[00:21:02] <grrrit-wm>	 (03CR) 10Legoktm: "(2 comments)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89382 (owner: 10Legoktm)
[00:21:19] <marktraceur>	 legoktm: I'd be fine with abandoning that patch at the conclusion of non-zero community discussion
[00:22:42] <legoktm>	 marktraceur: I don't really have an opinion either way, I'm not exactly sure how I stumbled on that patchset either. The -1 is more for the creating an empty array in $wgHooks rather than using the class over globals
[00:24:35] <marktraceur>	 Ahhh.
[00:24:58] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/84625 (owner: 10MarkTraceur)
[00:25:14] <marktraceur>	 Not gonna lie
[00:25:28] <marktraceur>	 mw.user.id() and mw.user.getId() returning separate things is really bloody stupid
[00:25:37] <marktraceur>	 Krinkle: ^^
[00:26:16] <Krinkle>	 Yes, I told someone so
[00:26:25] <Krinkle>	 but it was ironically done for consistency
[00:26:41] <Krinkle>	 move 'ironically' to another place in that sentence.
[00:26:50] <Krinkle>	 it wasn't ironic act, oh well, maybe it was.
[00:26:58] <Krinkle>	 anyway, for consistency with User.php#getId
[00:27:03] <Krinkle>	 and .id existed already
[00:27:10] <marktraceur>	 Krinkle: It does seem a lot like rain on my wedding day, so yeah
[00:27:16] <marktraceur>	 OK, well, that's annoying
[00:27:44] <marktraceur>	 Why not deprecate .id() and replace it with like getName()
[00:27:50] <grrrit-wm>	 (03CR) 10Legoktm: "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders)
[00:28:08] <Krinkle>	 marktraceur: taken
[00:28:11] <Krinkle>	 but I see your point
[00:29:00] <Krinkle>	 https://github.com/wikimedia/mediawiki-core/commit/164bcc780e3d52543f7817926bf133656bc1df56
[00:29:05] <Krinkle>	 https://gerrit.wikimedia.org/r/#/c/75836/
[00:29:14] <grrrit-wm>	 (03PS1) 10MarkTraceur: EventLogging support for MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 
[00:29:27] <Krinkle>	 "This is somewhat confusing with mw.user.id()."
[00:29:33] <Krinkle>	 I did merge it though, so yeah..
[00:29:55] <marktraceur>	 Krinkle: Fine, getUsername()
[00:29:59] * marktraceur  will end you

[00:30:14] <Krinkle>	 marktraceur: lol, hypocrite ?
[00:30:19] <marktraceur>	 What?
[00:30:23] <Krinkle>	 thats not at all confusing with user.getName()
[00:30:24] <Krinkle>	 xD
[00:30:35] <marktraceur>	 No no no
[00:30:44] <marktraceur>	 user.getUsername !== user.getUserName
[00:30:45] <grrrit-wm>	 (03PS1) 10Legoktm: fix typo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90074 
[00:30:56] <marktraceur>	 One is "get the username of this person" one is "get the name of the user"
[00:31:07] <Krinkle>	 marktraceur: since the implementation of id = -> getName || getId
[00:31:13] <Krinkle>	 why not deprecate it without succeeder
[00:31:17] <marktraceur>	 Wait it is
[00:31:25] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] fix typo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90074 (owner: 10Legoktm)
[00:31:29] <marktraceur>	 How bloody idiotic is that
[00:31:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: fix typo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/90074 (owner: 10Legoktm)
[00:31:59] <Krinkle>	 sessionid, not getId
[00:32:00] <Krinkle>	 but yeah
[00:32:08] <grrrit-wm>	 (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89357 (owner: 10Legoktm)
[00:32:14] <Krinkle>	 marktraceur: getSessionName maybe
[00:32:31] <marktraceur>	 Wait
[00:32:33] <Krinkle>	 id = getSessionName = getName() || sessionId()
[00:32:57] <grrrit-wm>	 (03CR) 10Bsitu: "I agree with Alex that this is probably not the way we want to go down the road. Mixing data from multiple wikis would add another level o" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88668 (owner: 10Legoktm)
[00:33:03] * marktraceur  weeps openly

[00:33:15] <marktraceur>	 Krinkle: Never let me ask about mw.user internals ever again
[00:33:30] <grrrit-wm>	 (03Abandoned) 10Legoktm: [WIP] Enable backend support for sending cross-wiki notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88668 (owner: 10Legoktm)
[00:33:33] <Krinkle>	 hey, at least mw.Title is sane now,
[00:33:36] <Krinkle>	 It's a start :)
[00:33:58] <Krinkle>	 and we renamed user to getUser for consistency with conventions as well as the PHP API
[00:34:12] <grrrit-wm>	 (03PS7) 10EBernhardson: Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 
[00:34:14] <Krinkle>	 and anonymous -> isAnon
[00:34:18] <Krinkle>	 and added getId
[00:34:21] <Krinkle>	 so it's getting there
[00:36:25] <ebernhardson>	 what can scroll the viewport in jquery, besides the scrollTop?  I've commented out everything in our js that changes scrollTop and something(i dont know what, thats what i want to find) is still scrolling the viewport
[00:40:10] <grrrit-wm>	 (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90067 (owner: 10Dereckson)
[00:41:05] <grrrit-wm>	 (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90067 (owner: 10Dereckson)
[00:41:59] <Krinkle>	 ebernhardson: scrollIntoView is one
[00:43:14] <Krinkle>	 ebernhardson: location.hash, and location.href and location.replace is another
[00:43:52] <Krinkle>	 and naturally clicking (real or simulated) on <a href=" .. # .."> of course
[00:45:28] <Krinkle>	 ebernhardson: lastly, window scrollTo. Those are the ones I know.
[00:46:09] <Krinkle>	 there's also scrollLeft, scrollOffset etc., but afaik those are not setters, only getters
[00:47:17] <Krinkle>	 ebernhardson: if that doesn't fix it, maybe you're dynamically adding or removing content (causing the scroll to collapse and/or be forced to extend again)
[00:56:59] <grrrit-wm>	 (03PS1) 10EBernhardson: Scroll elements to middle of the screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90077 
[00:57:42] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Add new method to process a param in escaped format [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90046 (owner: 10Bsitu)
[00:57:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add new method to process a param in escaped format [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90046 (owner: 10Bsitu)
[00:58:20] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Remove redundant <p> tag from notification & escape topic title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90035 (owner: 10Bsitu)
[00:58:56] <ebernhardson>	 Krinkle: oh, we are dynamically adding content (sorry for taking so long to get back)
[00:59:06] <grrrit-wm>	 (03CR) 10Anomie: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90067 (owner: 10Dereckson)
[01:02:14] <Krinkle>	 ebernhardson: We've had a long track of dealing with scrollTop in VE. Though I can't say for sure, I think scrollTop animation on <html> will not work
[01:02:18] <Krinkle>	 research https://bugzilla.wikimedia.org/show_bug.cgi?id=54928#c1
[01:02:43] <Krinkle>	 tldr: use it on document.body (<body>) instead of document.documentElement (<html>)
[01:03:25] <Krinkle>	 "No exception, but scroll unchanged."
[01:03:34] <ebernhardson>	 Krinkle: heh, ok will do that
[01:13:52] <grrrit-wm>	 (03PS2) 10MarkTraceur: EventLogging support for MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90073 
[01:19:44] <grrrit-wm>	 (03CR) 10EBernhardson: "Also, this patch worked this morning, but something we merged today broke it and not entirely sure what. Javascript complains about $form" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie)
[01:23:10] <Elsie>	 ori-l: Also unranked.
[01:23:18] <Elsie>	 It basically involves losing water weight.
[01:23:32] <Elsie>	 By giving yourself regular lemon water laxatives.
[01:23:33] <Elsie>	 Or something.
[01:23:43] <Elsie>	 I think this was featured on "Orange Is the New Black."
[01:23:52] <Elsie>	 Beyoncé allegedly did one from "Dreamgirls," I read.
[01:23:52] <ori-l>	 is orange in fact the new black?
[01:23:55] <Elsie>	 THE MORE YOU KNOW.
[01:24:07] <Elsie>	 Yes, because prisons because lesbians.
[01:24:24] <ori-l>	 !log orange is new black
[01:24:24] <wm-bot>	 Wrong channel, try again.
[01:24:36] <Elsie>	 wm-bot: <3
[01:24:36] <wm-bot>	 Hi Elsie, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-)
[01:24:43] <Elsie>	 Adorbz.
[01:29:38] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "(7 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders)
[01:29:46] <grrrit-wm>	 (03PS1) 10Hiong3-eng5: added check mode and corrections API add_syntrans [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/90080 
[01:29:51] <grrrit-wm>	 (03CR) 10Spage: [C: 04-1] "I believe you should document new hooks as part of the patch in docs/hooks.txt and RELEASE-NOTES_1.22. (and then http://www.mediawiki.org" [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson)
[01:36:46] <grrrit-wm>	 (03CR) 10Plavi: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi)
[01:42:00] <grrrit-wm>	 (03CR) 10Plavi: "(3 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi)
[01:52:32] <grrrit-wm>	 (03PS8) 10Plavi: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 
[02:36:55] <grrrit-wm>	 (03CR) 10MZMcBride: "By you?" [core] - 10https://gerrit.wikimedia.org/r/89514 (owner: 10Gerrit Patch Uploader)
[02:38:10] <legoktm>	 Elsie: Yes, that's the point of the tool using OAuth for verification.
[02:39:40] <Elsie>	 legoktm: So that it can be uploaded as Gerrit Patch Owner?
[02:39:42] <Elsie>	 Or whatever.
[02:39:48] <legoktm>	 sure
[02:39:53] <Elsie>	 What.
[02:47:23] <grrrit-wm>	 (03PS2) 10Arlolra: Rename sections in parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/89141 
[02:48:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rename sections in parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra)
[02:52:01] <grrrit-wm>	 (03PS3) 10Arlolra: Rename sections in parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/89141 
[02:52:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rename sections in parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra)
[03:17:46] <grrrit-wm>	 (03CR) 10MZMcBride: "I missed the Author/Committer part of the interface (cf. <http://lists.wikimedia.org/pipermail/wikitech-l/2013-October/072472.html>. I'm n" [core] - 10https://gerrit.wikimedia.org/r/90002 (owner: 10Gerrit Patch Uploader)
[03:18:39] <Elsie>	 [[mw:User:Matma Rex]]<gerritpatchuploader@gmail.com>
[03:18:44] <Elsie>	 I'm a little baffled.
[03:28:36] <grrrit-wm>	 (03CR) 10Dereckson: "Indeed:" [core] - 10https://gerrit.wikimedia.org/r/90067 (owner: 10Dereckson)
[04:10:15] <grrrit-wm>	 (03PS4) 10Arlolra: Rename sections in parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/89141 
[04:44:55] <grrrit-wm>	 (03PS1) 10Legoktm: Show error messages in content language to avoid cache issues [extensions/Cite] - 10https://gerrit.wikimedia.org/r/90084 
[04:52:23] <ruwanego___>	 hi devs, where can I find the wiktionary source code?
[04:52:44] <ruwanego___>	 is wiktionary available as an opensource project?
[04:55:56] <legoktm>	 Wiktionary uses MediaWiki, and the source for that is on git.wikimedia.org
[04:56:17] <legoktm>	 And you can see any custom extensions that Wiktionary is using at https://en.wiktionary.org/wiki/Special:Version
[04:57:07] <ruwanego___>	 thanks a lot legoktm 
[04:57:18] <legoktm>	 np
[06:36:06] <grrrit-wm>	 (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána)
[06:47:01] <grrrit-wm>	 (03CR) 10Nemo bis: "I'm not sure you really have to split the URL per commit guidelines. It looks a bit excessive. :)" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/82208 (owner: 10AndyRussG)
[07:33:30] <grrrit-wm>	 (03PS1) 10Mattflaschen: Keep returnto, returntoquery on Special:CreateAccount redirect [core] - 10https://gerrit.wikimedia.org/r/90088 
[07:39:54] <grrrit-wm>	 (03Abandoned) 10Mattflaschen: Hide thank link when there is no JavaScript [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/80336 (owner: 10Mattflaschen)
[08:03:38] <grrrit-wm>	 (03CR) 10Nikerabbit: "Unconditionally unlocalised?" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger)
[09:09:47] <YuviPanda>	 zeljkof: https://bugzilla.wikimedia.org/show_bug.cgi?id=53864 is the only big tests related thing I see (other than windows issues)
[09:09:58] <YuviPanda>	 zeljkof: not sure if there's a way we can specify vagrant params from puppet
[09:10:17] <YuviPanda>	 zeljkof: and I don't think raising it to 1G by default is a good idea either
[09:10:18] <YuviPanda>	 zeljkof: perhaps add prominent documentation about raising it
[09:11:00] <zeljkof>	 YuviPanda: thanks
[09:11:23] <zeljkof>	 my question is, how it used to work before, but fails now? :)
[09:11:50] <zeljkof>	 but if there is nothing to do there, just close it, and/or document that some roles require more RAM
[09:11:57] <YuviPanda>	 zeljkof: i'll blame ruby :P
[09:12:07] <zeljkof>	 YuviPanda: my guess too
[09:12:31] <zeljkof>	 maybe not ruby itself, but one of the ruby tools, rubygems, bundler, one of those
[09:12:33] <YuviPanda>	 <insert-ruby-is-terrible-at-integrating-with-rest-of-linux-rant>
[09:12:39] <YuviPanda>	 yeah
[09:13:57] <grrrit-wm>	 (03CR) 10Yuvipanda: "the $wgServer issue has been fixed. Now need to test for a working PURGE, and then verify that all other services work as advertised too (" [vagrant] - 10https://gerrit.wikimedia.org/r/87623 (owner: 10Yuvipanda)
[09:16:43] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Looks harmless" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/90084 (owner: 10Legoktm)
[09:16:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Show error messages in content language to avoid cache issues [extensions/Cite] - 10https://gerrit.wikimedia.org/r/90084 (owner: 10Legoktm)
[09:29:27] <grrrit-wm>	 (03PS6) 10Physikerwelt: Mark Math-specific functions in core as deprecated [core] - 10https://gerrit.wikimedia.org/r/87479 
[09:31:51] <grrrit-wm>	 (03CR) 10Physikerwelt: "I added a short description on how the math extension is going to use the extra cache keys to" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt)
[09:38:30] <grrrit-wm>	 (03CR) 10Nikerabbit: "The line is too long." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/90084 (owner: 10Legoktm)
[09:42:20] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Yes." [core] - 10https://gerrit.wikimedia.org/r/89514 (owner: 10Gerrit Patch Uploader)
[09:45:15] <grrrit-wm>	 (03CR) 10Amire80: "This commit also caused https://bugzilla.wikimedia.org/show_bug.cgi?id=55779 , which breaks RTL pretty badly." [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson)
[09:48:15] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Ah, I see. It's now reported as bug 55779 by Amir." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu)
[09:49:10] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Revert "Notification overlay is partially hidden in RTL language" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90099 
[10:00:26] <grrrit-wm>	 (03PS6) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 
[10:04:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger)
[10:36:57] <grrrit-wm>	 (03CR) 10Esanders: "(5 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders)
[10:37:13] <grrrit-wm>	 (03PS4) 10Esanders: Compatibility filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 
[10:41:54] <grrrit-wm>	 (03PS1) 10Hashar: extension sqlite installer now use a shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90104 
[10:45:43] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Add support for sqlite [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/90105 
[10:59:20] <grrrit-wm>	 (03CR) 10Krinkle: "FIXME: This broke the main font-size relationship of the Vector skin. Fix ASAP." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson)
[11:00:07] <grrrit-wm>	 (03CR) 10Krinkle: "Screenshots before/after:" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson)
[11:01:14] <grrrit-wm>	 (03CR) 10Krinkle: "Screenshots before:" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson)
[11:01:33] <Krinkle>	 Reedy: regression ^ blocks wmf branch FYI
[11:02:34] <MatmaRex>	 Krinkle: there's already one vector/less one
[11:02:44] <MatmaRex>	 Krinkle: with rtl flipping being all messed up
[11:02:48] <MatmaRex>	 https://bugzilla.wikimedia.org/55779
[11:03:22] <MatmaRex>	 root cause is that bizarre html flipping i complained about a few months ago where you discarded my proposed solution
[11:05:14] <RoanKattouw>	 You mean the HTML flipping of the tabs in Vector?
[11:05:52] <RoanKattouw>	 IIRC that's necessary for supporting some version of IE or other
[11:06:53] <MatmaRex>	 it's probably not, we just didn't try hard enough
[11:07:10] <MatmaRex>	 i only played with it briefly, though
[11:07:12] <RoanKattouw>	 OK
[11:07:15] <MatmaRex>	 i did fix the search box flipping
[11:07:18] <MatmaRex>	 (patch pending)
[11:07:23] <RoanKattouw>	 Oh awesome
[11:07:25] <MatmaRex>	 (and now not merging because of the less madness)
[11:07:27] <MatmaRex>	 so yeah
[11:07:39] <MatmaRex>	 feel free to, etc
[11:07:49] <Krinkle>	 MatmaRex: OK, but that's something we've had since the first version of vector. I dont' recall at the moment what you proposed that I disarded, but exactly what is the recent regression?
[11:08:12] <MatmaRex>	 Krinkle: see the screenshots
[11:08:16] <Krinkle>	 got it
[11:08:21] <MatmaRex>	 i guess flipping annotations are broken
[11:08:34] <MatmaRex>	 or something else  with css flipping
[11:08:38] <MatmaRex>	 dunno
[11:08:48] <Krinkle>	 MatmaRex:  https://bugzilla.wikimedia.org/55779
[11:08:51] <Krinkle>	 RoanKattouw: ^
[11:08:58] <MatmaRex>	 Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=46956#c2
[11:12:12] <Krinkle>	 MatmaRex: okay, I'm not sure how that would've helped the rtl issue when converting from less to css? The html should be unchanged, and the css as well.
[11:13:27] <MatmaRex>	 Krinkle: vector's css relied on @noflip annotations for that to work
[11:13:36] <MatmaRex>	 i guess they no longer work now (or were removed)
[11:13:36] <RoanKattouw>	 Krinkle: https://gerrit.wikimedia.org/r/#/c/82100
[11:19:37] <RoanKattouw>	 MatmaRex: Thanks for 82100. I'm the least CSS-proficient person on the team so I can't judge it as well as Krinkle or Trevor could, but I'm very happy that someone's getting all those simpleSearch problems fixed
[11:20:56] <MatmaRex>	 it needs rebasing on the less stuff now, eh
[11:21:52] <RoanKattouw>	 :(
[11:21:53] <RoanKattouw>	 Yeah
[11:22:22] <RoanKattouw>	 I spent the last couple days poking at a huge commit that Trevor had submitted, splitting most ve.ui.* files out into a standalone UI library
[11:22:50] <RoanKattouw>	 It's now at PS22 because I split like 11 commits doing other things out of it and I had to keep rebasing it
[11:23:02] <RoanKattouw>	 I'm gonna have to rebase it again because I'm merging things it'll conflict with
[11:23:18] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[11:23:25] <RoanKattouw>	 Git is fun. But also a lot of work :)
[11:24:05] <MatmaRex>	 Krinkle: when i did what you suggested, i've been shouted at by other reviewers
[11:24:09] <MatmaRex>	 (see previous patchsets)
[11:24:26] <MatmaRex>	 using .client-js .simpleSearch will break selector specificity compatibility
[11:24:59] <MatmaRex>	 i can move that script below #simpleSearchOff's subtree easily, though.
[11:25:25] <MatmaRex>	 (but i'm positive that it doesn't cause any issues, i tested on some ancient browsers and it worked)
[11:25:30] <Krinkle>	 MatmaRex: Sure, but we don't have to put everything in there
[11:25:42] <Krinkle>	 Do all of those styles only make sense in js?
[11:25:48] <Krinkle>	 it wasn't js conditional before either it seems.
[11:25:58] <MatmaRex>	 yeah, it was messed up before
[11:26:18] <MatmaRex>	 and yes, i believe they only make sense in js
[11:26:28] <MatmaRex>	 since otherwise you lose the fulltext search functionality entirely
[11:26:38] <MatmaRex>	 (unless you want to redesign that)
[11:26:41] <MatmaRex>	 (i don't)
[11:28:15] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[11:46:11] <grrrit-wm>	 (03CR) 10Aklapper: "Sorry, I should have been more clear. This is intended, it's just some CSS additions for admin.cgi which I tested (plus there would be onl" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89795 (owner: 10Aklapper)
[12:02:58] <grrrit-wm>	 (03CR) 10Hashar: "This change has been confirmed to cause bug 55779 see comments #7 and #8 there." [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson)
[12:15:33] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90104 (owner: 10Hashar)
[12:15:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: extension sqlite installer now use a shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90104 (owner: 10Hashar)
[12:16:20] <Krinkle>	 hashar: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/5106/console
[12:16:26] <Krinkle>	 unrelated regression
[12:16:32] <Krinkle>	 Database error, log exception
[12:16:36] <hashar>	 arffff
[12:16:38] <Krinkle>	 Any ideas?
[12:16:45] <hashar>	 12:12:07 + /srv/slave-scripts/bin/mw-install-sqlite.sh
[12:16:52] <hashar>	 I migrated jobs to use a shell script
[12:16:59] <hashar>	 the doc test one works
[12:17:17] <hashar>	 will look
[12:17:18] <hashar>	 well
[12:17:20] <hashar>	 looking sorry
[12:18:27] <hashar>	 https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/jobConfigHistory/showDiffFiles?timestamp1=2013-10-15_10-53-56&timestamp2=2013-10-16_12-13-48
[12:18:31] <Krinkle>	 hashar: just to confirm, it's not a race condition during deployment or something, I can reproduce it when retriggering that job
[12:18:52] <hashar>	 I am wondering if it is an issue with mediawiki / the VE patch  or the change I made to job config
[12:18:52] <hashar>	 :(
[12:20:09] <hashar>	 rebuilding the last gate-and-submit job
[12:20:15] <hashar>	 https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/5108/console
[12:20:28] <hashar>	 dambn
[12:20:31] <hashar>	 same warning
[12:22:15] <hashar>	 12:20:14 <p>A database query error has occurred.
[12:22:18] <hashar>	 :-(
[12:25:06] <grrrit-wm>	 (03PS1) 10Aude: Update Wikibase (fixes broken page move autosummary) [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90108 
[12:25:29] <hashar>	 Krinkle: the db error http://paste.openstack.org/show/48550/
[12:25:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase (fixes broken page move autosummary) [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90108 (owner: 10Aude)
[12:25:45] <hashar>	 Krinkle: I got a patch floating around that would enable wgDebugLogFile and archive it so people can review the outut
[12:25:54] <Krinkle>	  unable to open database file
[12:25:54] <hashar>	 Error: 14 unable to open database file
[12:25:56] <hashar>	 sniff
[12:26:02] <Krinkle>	 chmod
[12:26:06] <Krinkle>	 apache vs. cli
[12:26:09] <Krinkle>	 I think
[12:26:15] <hashar>	 OH TRUE
[12:26:22] <hashar>	 stupid sqlite need write access on directory holding the d
[12:26:23] <hashar>	 b
[12:26:44] <hashar>	 the $wgSQLiteDataDir is set to /var/lib/jenkins-slave/tmpfs/mwext-VisualEditor-qunit/
[12:26:53] <hashar>	 which is not writable by apache
[12:26:54] <hashar>	 grr
[12:29:23] <grrrit-wm>	 (03PS1) 10Hashar: dir holding sqlite db need to be writable by Apache [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90109 
[12:29:34] <hashar>	 Krinkle: the good thing with using shell script is that we no more have to update all jobs \O/
[12:29:41] <Krinkle>	 yeah, :)
[12:29:47] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] dir holding sqlite db need to be writable by Apache [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90109 (owner: 10Hashar)
[12:29:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: dir holding sqlite db need to be writable by Apache [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90109 (owner: 10Hashar)
[12:29:57] <Krinkle>	 it also makes it easy to break all the jobs, though.
[12:29:57] <hashar>	 the repo is cloned by puppet
[12:30:03] <hashar>	 so it is only refreshed once per hour :(
[12:30:11] <Krinkle>	 but testing in production means we will find the bugs soon :P
[12:30:48] <hashar>	 rebuilding
[12:30:57] <Krinkle>	 hashar: since when is it cloned by puppet? I always do git remote update/log/rebase after I merge in ./jenkins on gallium.
[12:31:04] <hashar>	 since monday iirc
[12:31:07] <Krinkle>	 Seems nice, just curious
[12:31:11] <hashar>	 but that is cloned under /srv/slave-scripts
[12:31:13] <RoanKattouw>	 hashar: Once that fix is deployed, do I have to re-+2 changes to get them to be merged?
[12:31:19] <hashar>	 so on gallium it is actually cloned in two places
[12:31:21] <Krinkle>	 Ah, slave-scripts. Right.
[12:31:30] <hashar>	 I will probably phase out the git repository from /var/lib/jenkins
[12:31:31] <Krinkle>	 not just /var/lib/jenkins
[12:31:34] <Krinkle>	 cool
[12:31:39] <hashar>	 and migrate any job there to JJB
[12:31:48] <hashar>	 Krinkle: SUCCESS https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/5112/console
[12:31:51] <hashar>	 sorry for the trouble :(((
[12:31:56] <hashar>	 RoanKattouw: yes
[12:31:59] <RoanKattouw>	 OK
[12:32:02] <RoanKattouw>	 Doing so now
[12:32:02] <hashar>	 RoanKattouw: you need to send a comment with CR+2
[12:32:14] <hashar>	 RoanKattouw: that will trigger the change to enter the gate-and-submit pipeline
[12:32:33] <hashar>	 RoanKattouw: also you should be sleeping.  Sleep deprivation doesn't go well with university!
[12:32:49] * RoanKattouw  is in Europe, sitting across from Krinkle

[12:33:04] * hashar  books a flight

[12:33:37] * RoanKattouw  dares hashar to fly into the Leeuwarden airport

[12:33:44] <RoanKattouw>	 (hint: it's an air force base)
[12:34:46] <hashar>	 that city looks a lot like amsterdam
[12:35:25] <hashar>	 we got find my wife a job in NL so we can relocate there
[12:35:40] <Krinkle>	 Thx hashar
[12:35:58] <RoanKattouw>	 Oh you mean with canals and stuff?
[12:36:06] <RoanKattouw>	 That's probably like every old Dutch city ever
[12:36:13] <hashar>	 Krinkle: I managed to add qunit for some extension all by myself :-]  Was surprisingly easy to do
[12:36:17] <hashar>	 Krinkle: kudos!
[12:36:19] <Krinkle>	 hashar: May look a like but significantly less percentage free weed in the atmosphere 
[12:36:26] <hashar>	 RoanKattouw: i guess so, and I find your cities lovely
[12:36:34] <hashar>	 RoanKattouw: + they are bicycles friendly.
[12:36:40] <Krinkle>	 and presumably cheaper, though down town near the canels it'll be expensive in Leeuwarden as well 
[12:37:05] <Krinkle>	 s/weed/cannabis
[12:37:14] <hashar>	 what would be the rent price for a 2 bedroom  70-80 square meter apartment? 
[12:37:19] <RoanKattouw>	 Yeah I was very happy with the bike-friendliness this morning when I had to bike to the train station with a flat tire
[12:37:39] <hashar>	 my city it is 800€ - 900€ per month depending on the neighborhood
[12:38:11] <hashar>	 (Paris that would be 2 000 + €/month)
[12:38:12] <hashar>	 :(
[12:38:12] * RoanKattouw  has a 46 m^2 studio apartment in downtown SF for $1275/mo

[12:38:51] <RoanKattouw>	 I don't know anything about the urban rental market in NL, I'm from the country :S
[12:39:16] <RoanKattouw>	 I know what buying a house in a pop 10k city should cost you, but other than that...
[12:39:49] <hashar>	 given the real-estate bubble in most European countries, buying is not an option :-]
[12:40:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Is it possible to add tests for this functionality?" [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem)
[12:40:45] <hashar>	 moaar tests
[12:42:48] <hashar>	 Krinkle: my crazy mediawiki/conf.d/ change https://gerrit.wikimedia.org/r/#/c/89837/ :D
[12:42:59] <hashar>	 Krinkle: let us injects PHP snippets at the bottom of LocalSettings.php
[12:43:36] <hashar>	 but first I need to migrate mediawiki jobs to use the shell installer
[12:46:45] <grrrit-wm>	 (03PS4) 10Bartosz Dziewoński: Backport information boxes' styles from vforms to shared CSS [core] - 10https://gerrit.wikimedia.org/r/82828 
[12:47:11] <grrrit-wm>	 (03PS1) 10Hashar: mediawiki-core-qunit now uses shell installer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90110 
[12:47:14] <hashar>	 !jenkins mediawiki-core-qunit
[12:47:15] <wm-bot>	 https://integration.wikimedia.org/ci/job/mediawiki-core-qunit
[12:49:31] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Rebased again. Could somebody merge this at last? I was promised that this will have been done by the E2 team in the week after I submitte" [core] - 10https://gerrit.wikimedia.org/r/82828 (owner: 10Bartosz Dziewoński)
[12:51:58] <grrrit-wm>	 (03PS1) 10Hashar: whitelist Matanya Moses [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/90111 
[12:52:09] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] whitelist Matanya Moses [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/90111 (owner: 10Hashar)
[12:52:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "It was probably done that way because of how much separated Vector ws from the rest of the codebase (see the awfulness in Vector.php and t" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson)
[12:52:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: whitelist Matanya Moses [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/90111 (owner: 10Hashar)
[12:53:31] <Krinkle>	 hashar: What's the purpose of the cp to log?
[12:53:35] <Krinkle>	 they're both in the same workspace?
[12:53:49] <hashar>	 Krinkle: the idea is to archive whatever is under /log/
[12:54:02] <hashar>	 aka debug log , local settings , junit results
[12:54:07] <Krinkle>	 build artifacts
[12:54:11] <Krinkle>	 k
[12:54:12] <hashar>	 this way they will be made available on the build page
[12:54:14] <hashar>	 yeah build artifacts
[12:54:20] <hashar>	 that has been a regular complaint
[12:55:35] <hashar>	 any idea where I could document all of that ?
[12:55:45] <hashar>	 I am not sure on which mw.org CI/ page I should write the doc 
[12:56:15] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "On second thought, the CSS will require either per-skin fixes or just simplifying and keeping some styles Vector-only – there are various " [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson)
[12:56:36] <grrrit-wm>	 (03CR) 10Daniel Friesen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[12:57:35] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(Monobook has some preferences styling as well which partially conflicts with this.)" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson)
[12:57:59] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90110 (owner: 10Hashar)
[12:58:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki-core-qunit now uses shell installer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90110 (owner: 10Hashar)
[12:58:52] <Krinkle>	 hashar: Hm.. Isn't it problematic to include the <?php?
[12:59:04] <Krinkle>	 LocalSettings shouldn't end with ?> so how can you append <?php to that?
[12:59:26] <hashar>	 I wanted to keep the <?php in the conf.d files
[12:59:31] <hashar>	 so I am doing something like: 
[12:59:44] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "That sounds silly and needlessly inconsistent :/" [core] - 10https://gerrit.wikimedia.org/r/82814 (owner: 10Bartosz Dziewoński)
[12:59:59] <hashar>	 err
[13:00:05] <hashar>	 so I am explicitly closing the ?>
[13:00:11] <hashar>	 then append the file which are having a <?php
[13:00:17] <hashar>	 got to test it out a bit more
[13:00:53] <hashar>	 hexmode: there ?
[13:01:00] <hashar>	 hexmode: I am missing a google hangout video link
[13:01:17] <Krinkle>	 hashar: Yes, I see that. So it ends up like <?php 001 ?><?php 002 ?><?php 003 ?>
[13:01:20] <Krinkle>	 that's fine
[13:01:22] <matanya>	 Thanks hashar !
[13:01:33] <hashar>	 Krinkle: yup, with a comment showing the filename
[13:01:35] <Krinkle>	 hashar: However LocalSettings.php is <?php settings;
[13:01:44] <Krinkle>	 so how can you append <?php to that without it breaking
[13:01:54] <Krinkle>	 it would have to close first, right?
[13:01:55] <hashar>	 Krinkle: I really need to add an integration tests that ensure it is working properly
[13:02:04] <hashar>	 yeah should be closing first
[13:02:06] <hashar>	 hopefully
[13:02:16] <hashar>	 I haven't fully tested it yet :(
[13:02:35] <hashar>	 matanya: yup. I whitelisted you in Zuul, so you will get unit test to run on your patchset send in Gerrit :-]
[13:02:54] <Krinkle>	 hashar: k, I haven't looked into it, but at first glance I'd go with letting php handling it natively through require or include. e.g. append require(_join.php) and let that require the others
[13:03:16] <hashar>	 Krinkle: but I wanted to archive the full LocalSettings.php
[13:03:27] <Krinkle>	 instead of string concat, mimicking a php stream and effectively evalling it. Should be fine, but close tags like ?> usually seem suspicious as it coudl get whitespace in between. Shoud be safe though, so I'll let you handl eit.
[13:03:28] <hashar>	 hence why I append the conf snippets
[13:03:33] <Krinkle>	 Right
[13:03:43] <hashar>	 that is not very nice though :-(
[13:03:56] <hashar>	 instead I could copy the snippets under  $WORKSPACE/conf.d/
[13:03:58] <hashar>	 archive conf.d
[13:04:06] <hashar>	 and have LocalSettings.php load any files in conf.d
[13:04:10] <hashar>	 that would work as well
[13:06:29] <grrrit-wm>	 (03CR) 10Krinkle: "(4 comments)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 (owner: 10Hashar)
[13:24:00] <grrrit-wm>	 (03PS1) 10Shirayuki: Fix double-space in messages [core] - 10https://gerrit.wikimedia.org/r/90112 
[13:24:36] <hashar>	 Krinkle: I should really have asked you for a review : / sorry
[13:27:28] <grrrit-wm>	 (03CR) 10Hashar: "(4 comments)" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 (owner: 10Hashar)
[13:27:57] <grrrit-wm>	 (03PS1) 10Hashar: mediawiki/conf.d/_join.php minor fix + comment update [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90114 
[13:28:09] <grrrit-wm>	 (03CR) 10Hashar: "Follow up in https://gerrit.wikimedia.org/r/90114" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 (owner: 10Hashar)
[13:30:06] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Fix double-space in messages [core] - 10https://gerrit.wikimedia.org/r/90112 (owner: 10Shirayuki)
[13:32:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix double-space in messages [core] - 10https://gerrit.wikimedia.org/r/90112 (owner: 10Shirayuki)
[13:33:20] <brion>	 morning all
[13:34:17] <grrrit-wm>	 (03PS1) 10Hashar: placeholders for mysql/postgre installers [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90115 
[13:34:20] <hashar>	 good mornin
[13:34:20] <hashar>	 g
[13:34:22] <MatmaRex>	 hi brion. i cc'd you on things.
[13:34:28] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] placeholders for mysql/postgre installers [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90115 (owner: 10Hashar)
[13:34:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: placeholders for mysql/postgre installers [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90115 (owner: 10Hashar)
[13:34:43] <brion>	 yay :D
[13:36:16] * hashar  screams

[13:37:55] <brion>	 !
[13:37:55] <wm-bot>	 an exclamation point
[13:38:01] <brion>	 thanks wm-bot
[13:38:01] <wm-bot>	 Hey brion, you are welcome!
[13:38:09] <hashar>	 for god sake
[13:38:13] <hashar>	 !! del
[13:38:13] <wm-bot>	 Unable to find the specified key in db
[13:38:15] <hashar>	 ! del
[13:38:15] <wm-bot>	 Successfully removed 
[13:38:19] <hashar>	 !
[13:38:19] <wm-bot>	 There is no such key, you probably want to try: !?>, !@, !@param, !1.17, !1.18, !2.0, !3x, !42, !a, !abusefilter, !access, !ack, !actionpaths, !actions, !adminsettings, !allmessages, !allowoverride, !amend, !ampersand, !analytics, !ancient, !anglebrackets, !announce, !annoyinglittlebug, !anonnotice, !answer, !api, !around, !audit, !auth, !authentication, !autoblock, !autoconfirmed, !autoload, !autothumb, !backup, !bellthecat, !bestcase, !blacklist, !blame, !blank, !bleedingedge, !blocking, !boilerplate, !bom, !bot, !botbrain2, !botnoob, !branch, !branchpoints, !browser, !bugsearch, !bugzilla, !bunching, !bureaucracy, !bzapi, !bzsource, !cache, !captcha, !cat, !categories, !centralauth, !chansearch, !chanspam, !charinsert, !cheatsheet, !checkuser, !ci, !cia, !cite, !class, !cloak, !cms, !code, !codereview, !collapse, !colon, !commit, !commons, !compare, !compression, !config, !console, !cookies, !cooluris, !copyhelp, !copying, !copyinghelp, !copytemplates, !core, !corehack, !corn, !createandpromote, !createpage, !credit, !cron, !css, !csshideheader, !csv2wp, !damneditcount, !db, !dbtable, !debbug, !debianubuntu, !debug, !defaultsettings, !defenestrate, !deleteuser, !deploymentqueue, !deployments, !details, !developer, !developers, !devsecurity, !diff3, !dismissablesitenotice, !displaytitle, !documentation, !doesntwork, !domdocument, !downgrade, !download, !doxygen, !dpl, !draft, !dump, !dumphtml, !easy, !echo, !editbuttons, !editing, !edittoken, !email, !emailconfirmed, !enableapi, !enotif, !enwp, !errors, !es, !etherpad, !events, !evilglobals, !exclamation, !export, !exporttemplate, !extensiondistributor, !extensionmatrix, !extensions, !externalauth, !externaleditor, !externalimages, !extranamespace, !f5, !fail, !false, !faq, !feature, !feeds, !file, !filecache, !filepermissions, !filesize, !filetype, !fileurl, !firebug, !flaggedrevs, !flash, !footer, !foreignfilerepos, !fu, !gadget, !gadgets, !gallery, !gerritapi, !gerritdocs, !gerriterror, !gerrithelp, !gerritkeys, !gerritsearch, !gethelp, !gfi, !git, !git-access, !gitaccount, !gitauthor, !gitcheat, !gitemail, !gitrepo, !git-review, !giturl, !gnu, !google, !googleanalytics, !googleit, !grep, !gsocapp, !gsod, !hacker, !HAL, !hdss, !hello, !help, !helpfor, !hetdeploy, !hiddencategories, !hidetabs, !hidetoc, !highlight, !hooks, !hosting, !howto, !html, !html9, !humor, !i18n, !iamabot, !icon, !ie6, !iframe, !iis, !iis404, !imabot, !imageauth, !imagelink, !imagemagic, !imagemap, !images, !img_auth, !import, !important, !importhelp, !importimages, !importsources, !info, !infobox, !inputbox, !install, !installlinux, !installmacosx, !instantcommons, !interface, !internalapi, !interwiki, !invalidupload, !is, !itsalwaysbugzilla, !javascript, !jobqueue, !jquery, !labs, !langlinks, !lazy, !ldap, !ldapdebug, !ldapsupport, !line, !links, !list, !listinfo, !lists, !lmgtfy, !localhost, !lockdown, !logo, !lowercase, !lsb, !lua, !lucene, !magicwords, !mailarchive, !mainpage, !mainpagetitle, !man, !manapi, !maps, !math, !maxlag, !mediawiki, !meetings, !memcached, !memory, !migrate, !mime, !moderation, !moin, !monday, !moo, !morbo, !move, !mssql, !multiplecommits, !multiplewiki, !mwbot, !mw-config, !mwdumper, !mwhelp, !mysql, !namespaces, !networkauth, !newgit, !newusergroup, !newwindow, !next, !nightly, !nofollow, !noob, !noshell, !nosql, !not, !notes, !nowiki, !nuke, !nullpath, !numberedparams, !ogg, !omgevilbug, !openid, !opw, !oracle, !oversight, !packagefix, !padindex, !pagecss, !paranoid, !parser, !parserconf, !parserfunctions, !passthru, !passwordsql, !patch, !pdhelp, !performance, !petan, !phase3, !php, !php4, !php531, !phpinfo, !phpmyadmin, !phpshell, !phpsucks, !ping, !pipetrick, !plainlinks, !player, !poem, !ppp, !prefsrant, !preventaccess, !profiling, !protect, !protocols, !punehackathon, !purge, !putty, !pywikipediabot, !query, !queue, !rangeblocking, !rawr, !rcbot, !readonly, !rebase, !recaptcha, !redirect, !redlinks, !refresh, !releasedate, !renameuser, !repeat, !reportbug, !reports, !requestcontext, !research, !resetpass, !resetpassword, !resourceloader, !rest, !revdelete, !revert, !reviewqueue, !rfc, !rights, !rightssql, !robots, !rollback, !rt, !rtam, !rtfm, !ruby, !safemode, !sal, !sandbox, !sarcasm, !sb, !scap, !scarytranscluding, !schema, !search, !secrets, !security, !selfmerge, !selinux, !semantichelp, !semanticmediawiki, !sequel, !serversuperglobal, !session, !sharedlogins, !shell, !shellrequest, !shorturls, !sitemap, !sitenotice, !siwae, !sm, !smtp, !smw, !sofixit, !songs, !sop, !sortkey, !sorttable, !sourceforge, !spam, !specialpages, !sqlite, !sqllog, !sqlsearch, !srv193, !start, !stfu, !stringfunctions, !stroopwafels, !subpages, !subst, !suggest, !sul, !sumanah, !support, !supported, !svg, !svnauthor, !svnprops, !svn-rev, !svnsearch, !syntax, !syntaxhighlight, !sysadmin, !t_paamayim_nekudotayim, !tabcompletion, !table, !tables.sql, !tabs, !tag, !tautology, !telepathy, !temp, !templates, !test, !test2, !testing, !tests, !testswarm, !testwiki, !thankyou, !the_mask, !thisbotisnotstupid, !thisisalongkey, !threads, !thumb, !tias, !tidy, !tidyforidiots, !timezone, !toc, !toolserver, !tooquiet, !transclusion, !translatewiki, !true, !ts, !tso, !tss, !tunemysql, !twn, !ui, !umask, !undo, !unicode_test, !uninstall, !unreviewedcode, !update.php, !upgrade, !upload, !uploadbyurl, !useful, !useragent, !userapproval, !variables, !vector, !version, !versionlifecycle, !viewvc, !votes, !vulnerability, !wallofshame, !webinspector, !webrequest, !webscale, !welcome, !wf, !wiki, !wiki2pdf, !wiki2xml, !wikia, !wikiacode, !wikibugs, !wikidata, !wikieditor, !wikimania, !wikimedia, !wikipmediawiki, !wip, !wmf, !wmf-deployment, !wmo, !worstcase, !wptemplates, !wtf, !wysiwyg, !xampp, !xkcd, !xml, !yoda, !sanitizer, !index.php, !wikipedia, !pastelocalsettings, !flow, !opsschool, !vagrant, !packages, !subversion, !1.21, !1.20, !1.22, !patrol, !wm-bot, !wp, !memoserv, !submodules, !cs, !5.4, !$wgServer, !visualeditor, !master, !unicorn, !rewriteproblems, !parsoid, !pong, !adsense, !github, !sourcecode, !technews, !reboot, !hook, !seen, !tryflow, !sidebar, !htmlform, !bzqs, !roadmap, !apiinternal, !apiclient, !pastebin, !dirtydiffs, !parsoid-web, !parsoid-test, !link, !smart, !autopromote, !vebug, !VE-table, !veq, !maintenance, !bugsong, !ext, !tea, !ask, !jobs, !farm, !newbug, !templateproblems, !mw, !blink, !htmllogs, !logs, !hss, !jsduck, !packagessimple, !skins, !skinning, !job, !codesearch, !ie, !bribe, !gitblit, !ajax, !wg, !stash, !csv2wiki, !repos, !sleep, !jjb, !card, !ping2, !wm-bot-ping, !IE10, !jenkins, !log, 
[13:38:19] <hashar>	 ahh
[13:38:20] <hashar>	 !!
[13:38:20] <wm-bot>	 There is no such key, you probably want to try: !?>, !anonnotice, !bom, !cms, !console, !cooluris, !credit, !css, !exclamation, !export, !fail, !firebug, !footer, !fu, !hello, !help, !hidetabs, !iamabot, !iframe, !images, !import, !important, !install, !lockdown, !lucene, !mainpagetitle, !maps, !math, !maxlag, !moin, !mwdumper, !namespaces, !next, !nosql, !omgevilbug, !oracle, !parserfunctions, !pipetrick, !ppp, !queue, !readonly, !releasedate, !resetpass, !secrets, !shorturls, !sitenotice, !sm, !tabcompletion, !templates, !tooquiet, !ts, !tss, !vector, !welcome, !wikibugs, !wikimedia, !pastelocalsettings, !unicorn, !rewriteproblems, !parsoid, !jobs, !hss, !skins, !skinning, !bribe, 
[13:38:24] <hashar>	 ;(-
[13:38:31] <hashar>	 ! is  
[13:38:31] <wm-bot>	 Key was added
[13:38:34] <hashar>	 !! is  
[13:38:35] <wm-bot>	 Key was added
[13:38:35] <hashar>	 !
[13:38:36] <wm-bot>	  
[13:38:36] <hashar>	 !!
[13:38:37] <wm-bot>	  
[13:38:41] <hashar>	 lovely
[13:38:50] <hashar>	 should look at injecting a RTL to LTR character
[13:38:57] <hashar>	 wondering how it would confuse some IRC clients
[13:40:13] <hashar>	 I am going to break mediawiki-core-install-sqlite
[13:40:44] <hashar>	 !jenkins mediawiki-core-install-sqlite
[13:40:44] <wm-bot>	 https://integration.wikimedia.org/ci/job/mediawiki-core-install-sqlite
[13:47:36] <grrrit-wm>	 (03PS2) 10Aude: Update Wikibase (fixes broken page move autosummary) [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90108 
[13:52:38] <brion>	 grumble grumble.... fedora 20 won't install the parallels guest tools because the kernel changed internal structured or some shit.
[13:52:47] <brion>	 yay open source API compatibility :)
[13:54:08] <hashar>	 kernel ABI ?
[13:54:57] <brion>	 API.... it compiles a module from source
[13:55:03] <brion>	 there's no ABI compatibility in the linux kernel :)
[13:55:15] <brion>	 and even source breaks half the time
[13:55:20] <hashar>	 :-(
[13:55:29] <brion>	 i guess that's a "feature" to keep us from having to use proprietary nvidia drivers ;)
[13:56:05] <grrrit-wm>	 (03PS1) 10Hashar: mediawiki-core-install-sqlite now uses shell installer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90119 
[13:56:18] <brion>	 now i gotta go waste my disk space by installing Xcode in a VM to play with horrible proprietary apple code signing \o/
[13:56:25] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90119 (owner: 10Hashar)
[13:56:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki-core-install-sqlite now uses shell installer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90119 (owner: 10Hashar)
[13:59:08] <grrrit-wm>	 (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger)
[14:00:01] <grrrit-wm>	 (03PS1) 10Hashar: rename mw-install-sqlite-2 to mw-install-sqlite [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90121 
[14:00:13] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] rename mw-install-sqlite-2 to mw-install-sqlite [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90121 (owner: 10Hashar)
[14:00:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: rename mw-install-sqlite-2 to mw-install-sqlite [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90121 (owner: 10Hashar)
[14:01:52] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87646 (owner: 10Legoktm)
[14:03:24] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87646 (owner: 10Legoktm)
[14:04:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add EditPage::getCopyrightWarning before "Send" button [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87646 (owner: 10Legoktm)
[14:15:34] <grrrit-wm>	 (03PS1) 10Hashar: mediawiki-core-code-coverage is now niced (19) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90123 
[14:17:45] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] mediawiki-core-code-coverage is now niced (19) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90123 (owner: 10Hashar)
[14:18:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: mediawiki-core-code-coverage is now niced (19) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90123 (owner: 10Hashar)
[14:19:18] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "See also bug 6411. (This might fix it with one or two lines of code more.)" [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem)
[14:24:39] <grrrit-wm>	 (03PS6) 10Matthias Mullie: Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 
[14:30:43] <grrrit-wm>	 (03PS7) 10Matthias Mullie: Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 
[14:34:02] <grrrit-wm>	 (03PS1) 10Anomie: Include miscellaneous query parameters in $wgSecureLogin redirect [core] - 10https://gerrit.wikimedia.org/r/90125 
[14:35:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Include miscellaneous query parameters in $wgSecureLogin redirect [core] - 10https://gerrit.wikimedia.org/r/90125 (owner: 10Anomie)
[14:39:24] <grrrit-wm>	 (03CR) 10Aude: "i might have another bug fix coming, so this can wait a bit" [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90108 (owner: 10Aude)
[14:40:01] <Krinkle>	 hashar: https://integration.wikimedia.org/ci/job/mwext-TemplateData-testextensions-master/209/console
[14:40:01] <Krinkle>	 Error: 13 database or disk is full
[14:40:04] <anomie>	 hashar: Hmm. It looks like Jenkins ran out of disk space running the tests for change 90125?
[14:40:14] <Krinkle>	 this time from cli, not apache
[14:40:33] <grrrit-wm>	 (03CR) 10Anomie: "The failure logged doesn't seem to have anything to do with this change. It looks like Jenkins ran out of disk space running the unit test" [core] - 10https://gerrit.wikimedia.org/r/90125 (owner: 10Anomie)
[14:43:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh)
[14:44:38] <hashar>	 damn
[14:45:23] <hashar>	 sad is not full
[14:45:27] <hashar>	 but the tmpfs is :(
[14:46:31] <hashar>	 it is not cleaning them out :(
[14:49:16] <Krinkle>	 hashar: Weren't we using tmpfs already? How come it is only failing now? Coincedence? Or did we fix something that makes it actually use tmpfs, or broke the clean up process
[14:49:27] <hashar>	 yeah we did
[14:49:38] <hashar>	 but now the sqlite dabtaase is named  build#####.sqlite
[14:50:08] <hashar>	 rm -f '/var/lib/jenkins-slave/tmpfs/mwext-TemplateData-testextensions-master//*.sqlite'
[14:51:10] <hashar>	 yeah one more bug
[14:52:53] <grrrit-wm>	 (03CR) 10Anomie: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89621 (owner: 10Krinkle)
[14:53:53] <grrrit-wm>	 (03PS1) 10Hashar: mw-install-sqlite: properly delete sqlite files [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90129 
[14:54:04] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] mw-install-sqlite: properly delete sqlite files [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90129 (owner: 10Hashar)
[14:54:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: mw-install-sqlite: properly delete sqlite files [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90129 (owner: 10Hashar)
[14:56:12] <hashar>	 Krinkle: will bump disk size from 128M to 512M
[14:59:13] <hashar>	 https://gerrit.wikimedia.org/r/90131 merged by mark
[14:59:17] <grrrit-wm>	 (03CR) 10Brion VIBBER: "We should hash out an updated look and tweak iOS to match as well!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/89846 (owner: 10Brion VIBBER)
[14:59:26] <hashar>	 probably need a post build step to clean out the temp files
[15:08:01] <grrrit-wm>	 (03PS1) 10Manybubbles: Optionally pull suggestions from text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90132 
[15:12:02] <Krinkle>	 RoanKattouw: https://twitter.com/search?q=indianvisaonline
[15:13:23] <grrrit-wm>	 (03PS1) 10Jdlrobson: Move noflip annotations into rules themselves [core] - 10https://gerrit.wikimedia.org/r/90133 
[15:16:13] <hashar>	 annnd
[15:16:17] <hashar>	 I think I can get rid of /var/lib/jenkins/tmpfs
[15:16:24] <grrrit-wm>	 (03CR) 10Amire80: [C: 031] "This seems to fix the display. Somebody who knows LESS and RL well should take another look at the code." [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[15:18:11] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[15:19:58] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(This fixes the issue for me, apart from the one rule you missed causing slightly misplaced background.)" [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[15:20:27] <grrrit-wm>	 (03PS1) 10Jdlrobson: Regression: Fix font size [core] - 10https://gerrit.wikimedia.org/r/90134 
[15:21:19] <grrrit-wm>	 (03CR) 10Jdlrobson: "Thanks for finding that. See I3a5a159cbb04a1a24277596ca304805a84d3b77f for fix!" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson)
[15:25:09] <grrrit-wm>	 (03CR) 10Jdlrobson: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[15:25:11] <grrrit-wm>	 (03PS2) 10Jdlrobson: Move noflip annotations into rules themselves [core] - 10https://gerrit.wikimedia.org/r/90133 
[15:26:30] <grrrit-wm>	 (03PS2) 10Anomie: Include miscellaneous query parameters in $wgSecureLogin redirect [core] - 10https://gerrit.wikimedia.org/r/90125 
[15:29:17] <grrrit-wm>	 (03CR) 10Jdlrobson: "No pain no gain :)" [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson)
[15:29:37] <grrrit-wm>	 (03CR) 10Jdlrobson: "*interesting problems (with code) in MediaWiki" [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson)
[15:35:22] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] update template config docs [qa/browsertests] - 10https://gerrit.wikimedia.org/r/89872 (owner: 10Cmcmahon)
[15:38:18] <grrrit-wm>	 (03CR) 10PleaseStand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[15:42:38] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Add a line of explanation to Html::expandAttributes [core] - 10https://gerrit.wikimedia.org/r/90137 
[15:43:07] <grrrit-wm>	 (03PS1) 10Zfilipin: Fixed mailing list address [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90138 
[15:48:01] <grrrit-wm>	 (03PS2) 10Krinkle: Regression: Fix font size [core] - 10https://gerrit.wikimedia.org/r/90134 (owner: 10Jdlrobson)
[15:48:05] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Vector: Fix font size regression [core] - 10https://gerrit.wikimedia.org/r/90134 (owner: 10Jdlrobson)
[15:50:59] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Scroll elements to middle of the screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90077 (owner: 10EBernhardson)
[15:51:03] <grrrit-wm>	 (03CR) 10Matthias Mullie: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90077 (owner: 10EBernhardson)
[15:51:10] <grrrit-wm>	 (03PS1) 10Pigpen: Latest state of development [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/90139 
[15:51:11] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Scroll elements to middle of the screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90077 (owner: 10EBernhardson)
[15:51:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Scroll elements to middle of the screen [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90077 (owner: 10EBernhardson)
[15:52:09] <grrrit-wm>	 (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/90140 
[15:53:02] <grrrit-wm>	 (03PS1) 10Pigpen: Latest state of development [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/90141 
[15:56:14] <grrrit-wm>	 (03CR) 10Pigpen: [C: 032 V: 032] "Updated to Beta" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/90141 (owner: 10Pigpen)
[15:56:39] <grrrit-wm>	 (03CR) 10Pigpen: [C: 032 V: 032] "Updated to Beta" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/90140 (owner: 10Pigpen)
[15:57:18] <grrrit-wm>	 (03CR) 10Pigpen: [C: 032 V: 032] "Updated to Beta" [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/90139 (owner: 10Pigpen)
[15:58:43] <grrrit-wm>	 (03PS1) 10MarkAHershberger: Removed Vector from 1.22. [tools/release] - 10https://gerrit.wikimedia.org/r/90144 
[16:02:40] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Expose changed links in LinksUpdate [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89996 (owner: 10Chad)
[16:02:50] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Expose changed links in LinksUpdate [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89997 (owner: 10Chad)
[16:03:03] <grrrit-wm>	 (03PS3) 10MarkAHershberger: Update make-release.py. [tools/release] - 10https://gerrit.wikimedia.org/r/89413 
[16:05:08] <grrrit-wm>	 (03CR) 10MarkAHershberger: "(2 comments)" [tools/release] - 10https://gerrit.wikimedia.org/r/89413 (owner: 10MarkAHershberger)
[16:06:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Expose changed links in LinksUpdate [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89996 (owner: 10Chad)
[16:08:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Expose changed links in LinksUpdate [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89997 (owner: 10Chad)
[16:12:46] <grrrit-wm>	 (03PS1) 10Hashar: wrapper around MediaWiki core phpunit [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90146 
[16:13:37] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Use batch inserting of jobs [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89382 (owner: 10Legoktm)
[16:14:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use batch inserting of jobs [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89382 (owner: 10Legoktm)
[16:20:16] <hashar>	 I am off
[16:20:20] <hashar>	 see you tomorrow
[16:22:51] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Link to specific revision of spamlist that was used [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87512 (owner: 10Legoktm)
[16:22:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Link to specific revision of spamlist that was used [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87512 (owner: 10Legoktm)
[16:23:34] <grrrit-wm>	 (03PS1) 10Dan-nl: corrected issue where batch upload stops after 9th image uploaded [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90147 
[16:25:50] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Reindent UsercreateTemplate and UserloginTemplate [core] - 10https://gerrit.wikimedia.org/r/90148 
[16:28:38] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Reindent UsercreateTemplate and UserloginTemplate [core] - 10https://gerrit.wikimedia.org/r/90148 
[16:32:03] <grrrit-wm>	 (03PS1) 10Dan-nl: corrected issue where batch upload breaks off early [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90149 
[16:34:20] <grrrit-wm>	 (03PS1) 10Manybubbles: Optionally enable sloppy prefix matching [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90150 
[16:34:23] <grrrit-wm>	 (03PS2) 10Hashar: wrapper around MediaWiki core phpunit [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90146 
[16:34:44] <grrrit-wm>	 (03CR) 10Manybubbles: [C: 04-1] "Waiting for some clarification on the bug." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90150 (owner: 10Manybubbles)
[16:38:08] <grrrit-wm>	 (03PS1) 10Hashar: jenkins test .. should fail. [core] - 10https://gerrit.wikimedia.org/r/90151 
[16:38:15] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90149 (owner: 10Dan-nl)
[16:38:33] <Reedy>	 Warning:  Search backend error during full text search for 'rtmdexnyftyyyyyyyyyyyyyyyyyyyyyyyyyyyybawedffkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkddddddddddddddddddd
[16:38:33] <Reedy>	 ddddddddddddddddddddmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmxxxxxxxxxxxxxxxxxxxxxxxxxxxxxiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiffffffffffffffffffffffffffffffffffffffffffffjjjjjjj
[16:38:33] <Reedy>	 jjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhooooooooooooooooooooooooooooooooooopppppppppppppppppppppppppppppppp
[16:38:33] <Reedy>	 ppppppppppppeeeeeeeeeeeeeeeeeeeeeeeeeeeeaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaazzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz'
[16:38:39] <Reedy>	 manybubbles: ^ :D
[16:39:00] <manybubbles>	 my kids like to roll their face on the keyboard too
[16:39:06] <manybubbles>	 Reedy: where do you get that log?
[16:39:20] <Reedy>	 apache syslogs
[16:39:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] jenkins test .. should fail. [core] - 10https://gerrit.wikimedia.org/r/90151 (owner: 10Hashar)
[16:39:28] <manybubbles>	 ah
[16:39:41] <manybubbles>	 I wonder what it says.
[16:40:31] <grrrit-wm>	 (03PS1) 10Siebrand: Add gitignore nad jshint related files [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/90152 
[16:41:05] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Remove unnecessary defined( 'MEDIAWIKI' ) check [core] - 10https://gerrit.wikimedia.org/r/90153 
[16:41:24] <ebernhardson>	 aude: working up another patch related to recentchanges, wouldn't mind your opinion on if this is a reasonable way forward: https://gerrit.wikimedia.org/r/#/c/90051/
[16:41:37] <manybubbles>	 Reedy: is fenari fenari.pmtpa.wmnet?
[16:41:42] <Reedy>	 yeah
[16:41:48] <Reedy>	 you can ssh directly into fenari
[16:41:57] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Add a line of explanation to Html::expandAttributes [core] - 10https://gerrit.wikimedia.org/r/90137 (owner: 10Bartosz Dziewoński)
[16:42:05] <aude>	 ebernhardson: not able to look right now, but maybe tomorrow
[16:42:10] <grrrit-wm>	 (03CR) 10EBernhardson: "will do, i grepped around for other hooks used in SpecialWatchlist and didn't see any" [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson)
[16:42:13] <aude>	 or later
[16:42:39] <grrrit-wm>	 (03CR) 10EBernhardson: "(early submit, oops. continuing prev comment) didn't see anything, wasn't sure what it needed in particular. Will get this documentation" [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson)
[16:42:42] <manybubbles>	 Reedy: got it
[16:42:43] <ebernhardson>	 aude: sure
[16:44:07] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Reindent UsercreateTemplate and UserloginTemplate [core] - 10https://gerrit.wikimedia.org/r/90148 (owner: 10Bartosz Dziewoński)
[16:44:58] <Reedy>	 Ooh, that one is quite scary manybubbles
[16:45:07] <Reedy>	 well, connection fail
[16:45:12] <manybubbles>	 sorry?
[16:45:35] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix hover hit regions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90154 
[16:45:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a line of explanation to Html::expandAttributes [core] - 10https://gerrit.wikimedia.org/r/90137 (owner: 10Bartosz Dziewoński)
[16:45:50] <Reedy>	 Error message is:  SearchPhaseExecutionException[Failed to execute phase [dfs], all shards failed; shardFailures {[zP0XxWlmQQ2fSJAV9qkISQ][cawiki_content_1379967682][3]: RemoteTransportException[[testsearch1003][inet[/10.64.32.136:9300]][search/phase/dfs]]; nested: SearchParseException[[cawiki_content_1379967682][3]: from[-1],size[-1]: Parse Failure [Failed to parse source [{"fields":["id","title","na in /usr/local/apache/common-local/php
[16:45:50] <Reedy>	 -1.22wmf20/includes/debug/Debug.php on line 296
[16:46:12] <manybubbles>	 Reedy: yeah, that is just ES saying: "I can't parse this request"
[16:46:19] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] Remove unnecessary defined( 'MEDIAWIKI' ) check [core] - 10https://gerrit.wikimedia.org/r/90153 (owner: 10Bartosz Dziewoński)
[16:46:23] <manybubbles>	 which is odd because I don't see the error locally
[16:46:41] <manybubbles>	 but I see it all over prod
[16:46:44] <manybubbles>	 I wonder what I did
[16:47:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reindent UsercreateTemplate and UserloginTemplate [core] - 10https://gerrit.wikimedia.org/r/90148 (owner: 10Bartosz Dziewoński)
[16:48:26] <manybubbles>	 Reedy: wild guess: lvs is chopping the requests at some size
[16:50:36] <grrrit-wm>	 (03PS13) 10Gergő Tisza: Add "extended" file metadata to API [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[16:51:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unnecessary defined( 'MEDIAWIKI' ) check [core] - 10https://gerrit.wikimedia.org/r/90153 (owner: 10Bartosz Dziewoński)
[16:51:49] <manybubbles>	 no, that isn't it
[16:54:52] <grrrit-wm>	 (03PS3) 10Jdlrobson: Move noflip annotations into rules themselves [core] - 10https://gerrit.wikimedia.org/r/90133 
[16:56:08] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Fix hover hit regions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90154 
[16:57:36] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Simplify boolean attribute handling for Html::input in templates [core] - 10https://gerrit.wikimedia.org/r/90155 
[16:57:48] <grrrit-wm>	 (03PS4) 10Jdlrobson: Move noflip annotations into rules themselves [core] - 10https://gerrit.wikimedia.org/r/90133 
[16:58:49] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(untested)" [core] - 10https://gerrit.wikimedia.org/r/90155 (owner: 10Bartosz Dziewoński)
[17:00:17] <grrrit-wm>	 (03PS14) 10MarkTraceur: Add "extended" file metadata to API [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff)
[17:00:24] <grrrit-wm>	 (03PS4) 10MarkTraceur: Add extmetadata to the ForeignAPIFile iiprops [core] - 10https://gerrit.wikimedia.org/r/88889 
[17:01:07] <grrrit-wm>	 (03CR) 10CSteipp: [C: 032] "Looks like it fixes the issue in my dev" [core] - 10https://gerrit.wikimedia.org/r/90125 (owner: 10Anomie)
[17:07:46] <grrrit-wm>	 (03PS3) 10Matthias Mullie: Fix hover hit regions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90154 
[17:08:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Include miscellaneous query parameters in $wgSecureLogin redirect [core] - 10https://gerrit.wikimedia.org/r/90125 (owner: 10Anomie)
[17:11:57] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Fix default value of domain select box in templates [core] - 10https://gerrit.wikimedia.org/r/90156 
[17:12:08] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(untested)" [core] - 10https://gerrit.wikimedia.org/r/90156 (owner: 10Bartosz Dziewoński)
[17:13:24] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Update links only when added or removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89986 (owner: 10Manybubbles)
[17:13:50] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Enable tests for removing links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89988 (owner: 10Manybubbles)
[17:13:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update links only when added or removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89986 (owner: 10Manybubbles)
[17:13:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Enable tests for removing links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89988 (owner: 10Manybubbles)
[17:16:18] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Optionally pull suggestions from text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90132 (owner: 10Manybubbles)
[17:16:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Optionally pull suggestions from text [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90132 (owner: 10Manybubbles)
[17:18:12] <grrrit-wm>	 (03CR) 10Bsitu: "Thanks for catching this, I did not realize that's a RTL bug in core" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90099 (owner: 10Bartosz Dziewoński)
[17:20:29] <grrrit-wm>	 (03CR) 10EBernhardson: "The recursion code looks good, there is a bug with clicking the number of comments and scrolling down. In my javascript console i get:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie)
[17:23:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[17:24:04] <grrrit-wm>	 (03PS5) 10Bartosz Dziewoński: Move noflip annotations into rules themselves [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[17:24:07] <Aaron|home>	 ^d: https://gerrit.wikimedia.org/r/#/c/86007/
[17:24:08] <grrrit-wm>	 (03CR) 10Hashar: "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/90144 (owner: 10MarkAHershberger)
[17:24:13] <grrrit-wm>	 (03CR) 10Hashar: [C: 04-1] Removed Vector from 1.22. [tools/release] - 10https://gerrit.wikimedia.org/r/90144 (owner: 10MarkAHershberger)
[17:25:24] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Fixed whitespace things. Let's do this." [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[17:25:33] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Support rate-limiting thumbnail generation [core] - 10https://gerrit.wikimedia.org/r/86007 (owner: 10Aaron Schulz)
[17:26:54] <jdlrobson>	 thanks MatmaRex :)
[17:27:07] <MatmaRex>	 my pleasure
[17:27:15] <jdlrobson>	 MatmaRex: i'm just happy lots of vector code is being worked on now :-)
[17:27:20] <Aaron|home>	 \o/
[17:27:27] <jdlrobson>	 even if it is due to regressions :)
[17:27:29] <MatmaRex>	 heh
[17:27:34] <jdlrobson>	 that code has been stale for far too long
[17:27:50] <MatmaRex>	 jdlrobson: hmm, you wanna work on vector code?
[17:28:05] <MatmaRex>	 jdlrobson: https://gerrit.wikimedia.org/r/#/c/82100/
[17:28:27] <jdlrobson>	 MatmaRex: https://gerrit.wikimedia.org/r/#/c/90134/ care to get this one merged too? another regression :)
[17:28:46] <jdlrobson>	 MatmaRex: that's gonna need a rebase now screen.css is a less file..
[17:29:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move noflip annotations into rules themselves [core] - 10https://gerrit.wikimedia.org/r/90133 (owner: 10Jdlrobson)
[17:29:20] <MatmaRex>	 jdlrobson: yeah. :/
[17:30:18] <MatmaRex>	 jdlrobson: i might do that in a while
[17:30:29] <MatmaRex>	 jdlrobson: but the logic is going to stay the same, so it's reviewable ;)
[17:31:04] <jdlrobson>	 MatmaRex: i was gonna do some more less rewriting that would clean up the css file
[17:31:15] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Self-merging a revert. Core bug 55779 has been fixed in I412575f37dd647d018d46b96f5642f5d68ebeb74." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90099 (owner: 10Bartosz Dziewoński)
[17:31:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support rate-limiting thumbnail generation [core] - 10https://gerrit.wikimedia.org/r/86007 (owner: 10Aaron Schulz)
[17:33:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Notification overlay is partially hidden in RTL language" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90099 (owner: 10Bartosz Dziewoński)
[17:34:44] <MatmaRex>	 jdlrobson: i have a bunch of pending patches we'd both probably prefer getting merged before that ;)
[17:35:52] <grrrit-wm>	 (03PS1) 10Bartosz Dziewoński: Move noflip annotations into rules themselves [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90169 
[17:36:15] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Move noflip annotations into rules themselves [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90169 (owner: 10Bartosz Dziewoński)
[17:37:44] <grrrit-wm>	 (03CR) 10MarkAHershberger: "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/90144 (owner: 10MarkAHershberger)
[17:37:46] <grrrit-wm>	 (03PS3) 10Aude: Update Wikibase [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90108 
[17:38:21] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update README to touch repository & test git-deploy [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/90170 
[17:41:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move noflip annotations into rules themselves [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90169 (owner: 10Bartosz Dziewoński)
[17:42:35] <grrrit-wm>	 (03PS1) 10Jdlrobson: Rewrite vectorTabs and #p-personal with nesting [core] - 10https://gerrit.wikimedia.org/r/90171 
[17:45:07] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update Wikibase [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90108 (owner: 10Aude)
[17:45:49] <grrrit-wm>	 (03CR) 10Dzahn: [C: 032 V: 032] Remove custom CSS files identical to upstream standard CSS files. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89795 (owner: 10Aklapper)
[17:47:15] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "Self-merging trivial commit (adds punctuation to README)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/90170 (owner: 10Ori.livneh)
[17:47:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update README to touch repository & test git-deploy [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/90170 (owner: 10Ori.livneh)
[17:47:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Wikibase [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90108 (owner: 10Aude)
[17:48:19] <MatmaRex>	 jdlrobson: still around?
[17:48:23] <jdlrobson>	 yup
[17:48:29] <grrrit-wm>	 (03CR) 10Reedy: [C: 032] Remove deleted wikis entries from CentralAuth tables [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/89484 (owner: 10Reedy)
[17:48:33] <jdlrobson>	 MatmaRex: what's up?
[17:48:38] <MatmaRex>	 jdlrobson: i'd start cleaning up vector with those stupid capslock comments
[17:48:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove deleted wikis entries from CentralAuth tables [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/89484 (owner: 10Reedy)
[17:48:56] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-1] "$ php maintenance/rebuildrecentchanges.php" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson)
[17:48:57] <jdlrobson>	 MatmaRex: you mean OVERRIDDEN BY COMPLIANT BROWSERS ?
[17:48:58] <MatmaRex>	 and use a star hack for each one instead, i guess
[17:49:05] <MatmaRex>	 jdlrobson: and IGNORED BY IE6
[17:49:11] <jdlrobson>	 i'm not sure why they are even there - they seem useless
[17:49:38] <MatmaRex>	 the hack that entire file is using is also quite annoying, isn't it?
[17:49:57] <MatmaRex>	 and it's only going to be more annoying when rewritten in less with nesting etc
[17:50:09] <MatmaRex>	 does less work with the "star hack"?
[17:51:27] <ori-l>	 jdlrobson: thank you for fixing that
[17:51:35] <ori-l>	 and MatmaRex, thanks for the review / deployment nudge
[17:51:37] <jdlrobson>	 MatmaRex: you mean *display: block star hack?
[17:51:52] <grrrit-wm>	 (03CR) 10KartikMistry: [C: 032] "LGTM." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/90152 (owner: 10Siebrand)
[17:51:56] <MatmaRex>	 jdlrobson: yeah, it's already used in a few places in core
[17:52:09] <MatmaRex>	 ori-l: my pleasure
[17:52:10] <jdlrobson>	 LESS shouldn't stop it from working
[17:52:35] <jdlrobson>	 i'm keen to start making use of nesting in our vector less files asap as I think it will surface messiness and redundancy
[17:54:14] <MatmaRex>	 they're visible enough already :P
[17:54:38] <MatmaRex>	 jdlrobson: if we kill some of it first, there'll be less stuff to rewrite
[17:55:08] <jdlrobson>	 MatmaRex: I find huge files very difficult to grep
[17:55:20] <jdlrobson>	 so from my perspective the nesting makes it more noticeable
[17:56:14] <MatmaRex>	 jdlrobson: hm, yeah
[17:56:41] <MatmaRex>	 jdlrobson: still i'd prefer merging, say, https://gerrit.wikimedia.org/r/#/c/82100/ before we completely rewrite that part of the code :)
[17:56:57] <MatmaRex>	 (unrelated – https://gerrit.wikimedia.org/r/#/c/89174/ – trivial css patch, review please?)
[17:58:23] <jdlrobson>	 errggg times new roman
[17:58:25] <jdlrobson>	 wtf
[17:58:33] <Aaron|home>	 best font EVER
[17:58:40] <MatmaRex>	 2003 called, they want their times new roman back. ;)
[17:59:03] <mutante>	 Comic Sans?
[17:59:24] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Code looks fine but I'll have to boot up a VM and check it in IE6. If someone else can verify in meantime please +2 :)" [core] - 10https://gerrit.wikimedia.org/r/89174 (owner: 10Bartosz Dziewoński)
[17:59:30] <MatmaRex>	 (times is IMO not that bad in itself, but this is definitely very silly)
[18:01:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "This doesn't merge anymore due to https://gerrit.wikimedia.org/r/#/c/90148/, sorry about that (I was hoping to merge this before doing cle" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis)
[18:02:05] <MatmaRex>	 jdlrobson: i'm going to try rebasing "Rewrite rendering of Vector simple search" in a while, btw.
[18:04:07] <grrrit-wm>	 (03CR) 10Bsitu: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 (owner: 10Legoktm)
[18:05:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[18:05:57] <jdlrobson>	 MatmaRex: some comments for you^
[18:06:55] <grrrit-wm>	 (03PS1) 10Netbrain: Tagged v0.1, did various cleanup and started on v 0.2 [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90174 
[18:09:16] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] Use max() for job count for sanity [core] - 10https://gerrit.wikimedia.org/r/89123 (owner: 10Aaron Schulz)
[18:12:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use max() for job count for sanity [core] - 10https://gerrit.wikimedia.org/r/89123 (owner: 10Aaron Schulz)
[18:13:03] <Aaron|home>	 bd808|LUNCH: any chance messing with https://gerrit.wikimedia.org/r/#/c/78969/ ?
[18:14:40] <MatmaRex>	 jdlrobson: looking (i was afk for a while)
[18:16:57] <MatmaRex>	 jdlrobson: i'd like to avoid an inline script, but i see no better solutions. do you?
[18:17:08] <WikiJunkie>	 is there any way of knowing when Bug 55501 (https://bugzilla.wikimedia.org/show_bug.cgi?id=55501) is going to be taken care of? (the only action needed to do to fix it is to revert a change made).
[18:17:32] <jdlrobson>	 MatmaRex: i need to look closer to the code and understand the problem better
[18:17:43] <MatmaRex>	 jdlrobson: (and we use inline scripts in OutputPage, for example, so this is not unheard of)
[18:20:09] <MatmaRex>	 WikiJunkie: have you tried asking the people who made the previous change directly?
[18:20:47] <MatmaRex>	 WikiJunkie: if this comment: https://bugzilla.wikimedia.org/show_bug.cgi?id=55501#c3 is right, then you need a person who can deploy code on the servers
[18:21:15] <WikiJunkie>	 whom would that be ?
[18:21:27] <WikiJunkie>	 jenkins was the one whom made the change last time
[18:21:45] <MatmaRex>	 WikiJunkie: the simplest way to get one would be to file a bug in the Wikimedia -> Site requests component
[18:22:12] <MatmaRex>	 WikiJunkie: jenkins is a tool used to perform automatic tests (the comments in bugzilla are misleading :? )
[18:22:14] <MatmaRex>	 :/
[18:22:27] <MatmaRex>	 WikiJunkie: (or to move that bug to that component)
[18:22:34] <WikiJunkie>	 file the same bug under  Wikimedia -> Site requests component ?
[18:22:44] <MatmaRex>	 or just move the current one
[18:22:45] <James_F>	 MatmaRex: Does https://gerrit.wikimedia.org/r/#/c/90133/ need to get back-ported for production?
[18:22:45] <MatmaRex>	 let me do that for you
[18:22:46] <MatmaRex>	 okay?
[18:22:53] <MatmaRex>	 James_F: it was already
[18:22:54] <WikiJunkie>	 ok
[18:22:56] <WikiJunkie>	 thanks
[18:23:00] <MatmaRex>	 James_F: ori was deploying it
[18:23:04] <James_F>	 Oh, I see.
[18:23:07] <WikiJunkie>	 when do you think it would be fixed? 
[18:23:22] * James_F  grumbles at gerrit's e-mails being indestinguishable.

[18:23:41] <MatmaRex>	 WikiJunkie: sorry, no idea :( try asking someone by e-mail?
[18:23:48] <MatmaRex>	 WikiJunkie: i moved the bug
[18:23:55] <WikiJunkie>	 thanks
[18:24:03] <James_F>	 greg-g: ^^^^ Do you have this hot fix for wmf21 RTL scheduled to go out?
[18:24:19] <Reedy>	 It's alredy gone out...
[18:24:45] <James_F>	 Oh, yes, now I see it in the SAL.
[18:24:51] <James_F>	 I'm having a good day, clearly. :-)
[18:25:01] <Reedy>	 Bed time!
[18:25:16] <James_F>	 Reedy: It's 11:25… ;-)
[18:25:22] <ori-l>	 Reedy: I'm glad we're not talking! Don't reply to me, ever!
[18:25:32] <grrrit-wm>	 (03PS4) 10Nemo bis: Link to existing login help page by default from helplogin-url [core] - 10https://gerrit.wikimedia.org/r/83220 
[18:25:35] * Reedy  glares at ori-l

[18:25:45] <ori-l>	 My questions suck anyway!
[18:25:52] <ori-l>	 also, good night.
[18:26:09] <Reedy>	 You're going to bed?
[18:26:20] <ori-l>	 oh, I thought you were.
[18:26:29] <grrrit-wm>	 (03CR) 10Nemo bis: "MatmaRex, hopefully I rebased it. It wasn't your fault mainly, it seems people are all changing and adding messages around mine." [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis)
[18:26:34] <James_F>	 This is feeling like the old people's home.
[18:28:22] <grrrit-wm>	 (03CR) 10Bsitu: "(5 comments)" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/74166 (owner: 10Matthias Mullie)
[18:29:03] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 04-1] "Still -1" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders)
[18:29:17] <grrrit-wm>	 (03CR) 10MarkTraceur: "(2 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders)
[18:29:37] <grrrit-wm>	 (03CR) 10MarkTraceur: "See the comments on PS3 for why (Gerrit's being a little unintuitive right now)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders)
[18:31:17] <greg-g>	 James_F: "yep" :)
[18:34:02] * James_F  grins.

[18:34:06] <grrrit-wm>	 (03CR) 10EBernhardson: "doh, sorry to keep leaving these silly l" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson)
[18:35:07] <MatmaRex>	 jdlrobson: huuuuh. git claims to have automatically rebased 82100 all by itself
[18:35:26] * MatmaRex  does the three-way merge dance

[18:35:31] <grrrit-wm>	 (03CR) 10EBernhardson: "doh, sorry to keep leaving these silly little mistakes in, went back through the whole patch again to try and find anything lingering, bu" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson)
[18:35:33] <grrrit-wm>	 (03PS8) 10EBernhardson: Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 
[18:36:20] <grrrit-wm>	 (03CR) 10Parent5446: [C: 032] Keep returnto, returntoquery on Special:CreateAccount redirect [core] - 10https://gerrit.wikimedia.org/r/90088 (owner: 10Mattflaschen)
[18:40:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Keep returnto, returntoquery on Special:CreateAccount redirect [core] - 10https://gerrit.wikimedia.org/r/90088 (owner: 10Mattflaschen)
[18:41:26] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "L10n reviewed. Thanks for documenting the keys." [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90174 (owner: 10Netbrain)
[18:41:33] <grrrit-wm>	 (03PS7) 10Bartosz Dziewoński: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 
[18:42:40] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "Just a rebase, will address comments from PS6 in next patchset. (git managed to do it all by itself! Magic.)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[18:44:54] <jdlrobson>	 MatmaRex: in your patch you may want to consider separating simple search from screen.less as well …
[18:45:01] <jdlrobson>	 (or maybe as a follow up)
[18:45:39] <grrrit-wm>	 (03PS4) 10Jdlrobson: Rewrite Vector's special.preferences.less with nesting [core] - 10https://gerrit.wikimedia.org/r/87171 
[18:45:40] <grrrit-wm>	 (03PS4) 10Jdlrobson: Move Vector's preferences css out of screen.less [core] - 10https://gerrit.wikimedia.org/r/87170 
[18:46:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(6 comments)" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[18:46:36] <MatmaRex>	 jdlrobson: ^
[18:48:23] <grrrit-wm>	 (03PS8) 10Bartosz Dziewoński: Rewrite rendering of Vector simple search [core] - 10https://gerrit.wikimedia.org/r/82100 
[18:48:45] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "TODO:" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[18:50:03] <MatmaRex>	 jdlrobson: can we do these todo things *after* merging that and dependent https://gerrit.wikimedia.org/r/#/c/82102/ ? i don't want to fuck up wit hthe caching, and there's a lot of interdependencies to consider with this, i'm having trouble keeping them all together already, and it's only going to get worse if we introduce more abstraction
[18:50:57] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 (owner: 10Legoktm)
[18:51:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87172 (owner: 10Legoktm)
[18:53:22] <grrrit-wm>	 (03PS3) 10Bartosz Dziewoński: Remove HTML back-compat styles from I5fe0543e [core] - 10https://gerrit.wikimedia.org/r/82102 
[18:53:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Can we do these todo things *after* merging this and dependent https://gerrit.wikimedia.org/r/#/c/82102/ ? I don't want to mess up somethi" [core] - 10https://gerrit.wikimedia.org/r/82100 (owner: 10Bartosz Dziewoński)
[18:53:53] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "Rebased." [core] - 10https://gerrit.wikimedia.org/r/82102 (owner: 10Bartosz Dziewoński)
[18:56:56] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson)
[18:58:37] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 032] Fix hover hit regions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90154 (owner: 10Matthias Mullie)
[18:58:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix hover hit regions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90154 (owner: 10Matthias Mullie)
[19:09:49] <grrrit-wm>	 (03CR) 10EBernhardson: "Just noticed this patch puts replies in the right place when inserted by javascript, but when reloading the page the replies are indented." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90154 (owner: 10Matthias Mullie)
[19:11:59] <grrrit-wm>	 (03PS4) 10Nemo bis: New mediawiki-visualeditor.log (filtering VisualEditor product) [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/54984 (owner: 10Krinkle)
[19:12:44] <grrrit-wm>	 (03CR) 10Nemo bis: "I added relevant information from last comment to the commit. There's however an unanswered question in the followup Id7405c8ee and I've b" [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/54984 (owner: 10Krinkle)
[19:12:57] <grrrit-wm>	 (03PS1) 10EBernhardson: Only use a single indentation level for tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90178 
[19:13:17] <grrrit-wm>	 (03CR) 10EBernhardson: "related fix at I1b0cb2e020cfa69f7ec792cb55c93d4c3a5f0b7e" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90154 (owner: 10Matthias Mullie)
[19:15:08] <grrrit-wm>	 (03CR) 10CSteipp: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89107 (owner: 10Aaron Schulz)
[19:23:22] <grrrit-wm>	 (03PS5) 10Jforrester: New mediawiki-visualeditor.log (filtering VisualEditor product) [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/54984 (owner: 10Krinkle)
[19:23:33] <grrrit-wm>	 (03CR) 10Jforrester: "Clarified per request on the other PS." [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/54984 (owner: 10Krinkle)
[19:26:18] * James_F  worries that his new commit summary is sarcastically-long. :-)

[19:26:48] <bd808>	 Aaron|home: I haven't had a chance yet and my turn in the deploy line is coming up soon. Urgent?
[19:28:04] <Aaron|home>	 just really old
[19:30:19] <grrrit-wm>	 (03PS1) 10Ori.livneh: Log performance.parsoid.* events broadcast by VE [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90182 
[19:32:08] <grrrit-wm>	 (03PS2) 10Ori.livneh: Log performance.parsoid.* events broadcast by VE [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90182 
[19:32:09] <grrrit-wm>	 (03PS1) 10Ori.livneh: Add .jshintrc [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90183 
[19:33:07] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Add .jshintrc [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90183 (owner: 10Ori.livneh)
[19:33:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add .jshintrc [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90183 (owner: 10Ori.livneh)
[19:33:30] <grrrit-wm>	 (03PS3) 10Ori.livneh: Log performance.parsoid.* events broadcast by VE [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90182 
[19:39:26] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Log performance.parsoid.* events broadcast by VE [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90182 (owner: 10Ori.livneh)
[19:39:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Log performance.parsoid.* events broadcast by VE [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90182 (owner: 10Ori.livneh)
[19:39:37] <bd808>	 Aaron|home: I'll try to get to it soon.
[19:39:50] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Only use a single indentation level for tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90178 (owner: 10EBernhardson)
[19:39:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only use a single indentation level for tangents [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90178 (owner: 10EBernhardson)
[19:40:00] <bd808>	 Aaron|home: Thanks for the notes on how to test too
[19:41:23] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/90185 
[19:41:44] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update WikimediaEvents to master [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90186 
[19:43:50] <legoktm>	 MatmaRex: ty for the +2 :D
[19:44:26] <MatmaRex>	 legoktm: my pleasure
[19:45:05] <MatmaRex>	 i've fallen behind in CR, eh.
[19:45:43] <MatmaRex>	 hmm.
[19:45:58] <MatmaRex>	 Nemo_bis: your https://toolserver.org/~nemobis/crstats/core.txt should somehow de-dupe people based on their e-mail.
[19:47:14] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/90185 (owner: 10Ori.livneh)
[19:47:23] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update WikimediaEvents to master [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90186 (owner: 10Ori.livneh)
[19:49:35] <grrrit-wm>	 (03CR) 10Nemo bis: "Thanks for the clarifications. I consider this behaviour a bug, filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=55807" [wikimedia/bugzilla/wikibugs] - 10https://gerrit.wikimedia.org/r/54984 (owner: 10Krinkle)
[19:50:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/90185 (owner: 10Ori.livneh)
[19:50:48] <mwalker>	 chrismcmalunch: I know this is some kafuffle about SSL and beta -- where can I jump in on that discussion -- because I was going to test something on beta but I cannot because it required that I be logged in; which causes issues
[19:52:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update WikimediaEvents to master [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90186 (owner: 10Ori.livneh)
[19:53:08] <Nemo_bis>	 MatmaRex: I don't understand your question
[19:53:45] <grrrit-wm>	 (03PS1) 10Daniel Werner: Rename some files [extensions/Variables] - 10https://gerrit.wikimedia.org/r/90190 
[19:53:59] <Nemo_bis>	 though I can guess you mean CR of same value from same person, with same email but changed username
[19:54:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rename some files [extensions/Variables] - 10https://gerrit.wikimedia.org/r/90190 (owner: 10Daniel Werner)
[19:54:07] <YuviPanda>	 mwalker: https://bugzilla.wikimedia.org/show_bug.cgi?id=48501
[19:54:13] <Nemo_bis>	 we also have people who changed email but kept same name
[19:54:14] <YuviPanda>	 (for beta / ssl)
[19:54:31] <Nemo_bis>	 and we have people who legitimately appear multiple times for +2, +1, -1
[19:55:10] <grrrit-wm>	 (03PS2) 10Daniel Werner: Rename some files [extensions/Variables] - 10https://gerrit.wikimedia.org/r/90190 
[19:55:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rename some files [extensions/Variables] - 10https://gerrit.wikimedia.org/r/90190 (owner: 10Daniel Werner)
[19:55:42] <MatmaRex>	 Nemo_bis: i am there as Bartosz Dziewoński <matma.rex@gmail.com> and as Matmarex <matma.rex@gmail.com>
[19:56:13] <MatmaRex>	 gerrit uses e-mails only to identify people, it basically ignores the names
[19:58:15] <grrrit-wm>	 (03PS8) 10EBernhardson: Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie)
[19:59:23] <Nemo_bis>	 MatmaRex: I don't see a value in merging those lines without merging the lines from users who just changed email
[19:59:41] <Nemo_bis>	 anyway I call it impossible with the current script and I declare it your fault
[20:01:11] <grrrit-wm>	 (03CR) 10EBernhardson: "fixed bug related to scrollTop and rebased against master in PS8." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie)
[20:01:12] <MatmaRex>	 heh
[20:01:18] <MatmaRex>	 okay.
[20:01:21] <grrrit-wm>	 (03CR) 10EBernhardson: [C: 04-1] "last comment needed a -1" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie)
[20:04:39] <grrrit-wm>	 (03CR) 10Aaron Schulz: "What is this supposed to change?" [core] - 10https://gerrit.wikimedia.org/r/89512 (owner: 10PleaseStand)
[20:06:23] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] "Good enough for now :-] Still have to clean up the script but that change is fine." [tools/release] - 10https://gerrit.wikimedia.org/r/89413 (owner: 10MarkAHershberger)
[20:06:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update make-release.py. [tools/release] - 10https://gerrit.wikimedia.org/r/89413 (owner: 10MarkAHershberger)
[20:07:19] <chrismcmahon>	 hi mwalker https://bugzilla.wikimedia.org/show_bug.cgi?id=55804 maybe?  what do you want to do on beta that you can't do?
[20:08:07] <mwalker>	 oh - I was just running into the certificate thing where the bits certificate wasn't being allowed
[20:08:21] <mwalker>	 so; I went and manually accepted that certificate
[20:08:32] <mwalker>	 but; that is incredibly annoying
[20:08:47] <mwalker>	 and totally non intuitive for those of us who hadn't been playing along at home
[20:08:55] <grrrit-wm>	 (03PS1) 10Ori.livneh: Update VisualEditor for cherry-picks I54602394e & I3b58ce0f4 [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90192 
[20:09:34] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Update VisualEditor for cherry-picks I54602394e & I3b58ce0f4 [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90192 (owner: 10Ori.livneh)
[20:11:50] <grrrit-wm>	 (03CR) 10Hashar: "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/90144 (owner: 10MarkAHershberger)
[20:11:54] <grrrit-wm>	 (03PS2) 10Hashar: Removed Vector from 1.22. [tools/release] - 10https://gerrit.wikimedia.org/r/90144 (owner: 10MarkAHershberger)
[20:11:59] <grrrit-wm>	 (03CR) 10Hashar: [C: 032] Removed Vector from 1.22. [tools/release] - 10https://gerrit.wikimedia.org/r/90144 (owner: 10MarkAHershberger)
[20:12:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Removed Vector from 1.22. [tools/release] - 10https://gerrit.wikimedia.org/r/90144 (owner: 10MarkAHershberger)
[20:13:22] <grrrit-wm>	 (03PS3) 10Hashar: make-release: initial tarball test script [tools/release] - 10https://gerrit.wikimedia.org/r/89158 
[20:13:25] <ebernhardson>	 before i go off writing something ... does there already exist a convention for accessing a process level cache of retrieved user objects?  Essentially we have a new patch thats doing way to many User::newFromId calls, i could figure out a proper solution but if something already exists will just use it
[20:13:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VisualEditor for cherry-picks I54602394e & I3b58ce0f4 [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90192 (owner: 10Ori.livneh)
[20:15:08] <grrrit-wm>	 (03CR) 10PleaseStand: "In some places, a Database subclass throws a DBUnexpectedError, not a DBConnectionError or DBQueryError, though third-party users may stil" [core] - 10https://gerrit.wikimedia.org/r/89512 (owner: 10PleaseStand)
[20:20:53] <grrrit-wm>	 (03PS3) 10Daniel Werner: Rename some files [extensions/Variables] - 10https://gerrit.wikimedia.org/r/90190 
[20:21:08] <grrrit-wm>	 (03CR) 10Daniel Werner: [C: 032 V: 032] Rename some files [extensions/Variables] - 10https://gerrit.wikimedia.org/r/90190 (owner: 10Daniel Werner)
[20:21:57] <grrrit-wm>	 (03CR) 10Aaron Schulz: "What if someone had $wgShowDBErrorBacktrace = false but $wgShowExceptionDetails = true?" [core] - 10https://gerrit.wikimedia.org/r/89512 (owner: 10PleaseStand)
[20:23:29] <chrismcmahon>	 mwalker: it is very annoying indeed
[20:28:41] <grrrit-wm>	 (03CR) 10PleaseStand: "I'm not completely sure what the best way to deal with that would be, though I might have a good idea." [core] - 10https://gerrit.wikimedia.org/r/89512 (owner: 10PleaseStand)
[20:40:41] <grrrit-wm>	 (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie)
[20:41:42] <grrrit-wm>	 (03PS1) 10Manybubbles: Improvements when searching long strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90200 
[20:43:00] <grrrit-wm>	 (03PS1) 10Manybubbles: Tests for unbalanced quotes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90202 
[20:44:47] <MatmaRex>	 hm guys, what is ulsfo? and where is it geographically?
[20:45:42] <Reedy>	 MatmaRex: united layer SFO
[20:45:44] <mutante>	 MatmaRex: datacenter, San Francisco. United Layer SF
[20:45:52] <Reedy>	 SFO being San Francisco International Airport
[20:45:58] <Reedy>	 IATA code
[20:46:14] <Nemo_bis>	 again this conversation
[20:46:19] <MatmaRex>	 thanks. what does it do?
[20:46:30] <legoktm>	 !ulsfo is United Layer, San Franciso
[20:46:30] <wm-bot>	 Key was added
[20:46:41] <mutante>	 MatmaRex: cache things
[20:46:48] <MatmaRex>	 right. okay. thanks :D
[20:47:07] <mutante>	 it's a caching-only center vs. a full one with appservers 
[20:47:17] <Reedy>	 MatmaRex: For Asia/Oceana etc
[20:47:35] <Reedy>	 like ESAMS is for Europe
[20:48:16] <Ryan_Lane>	 for things that route closer to the west coast, rather than the east coast
[20:48:32] <brion>	 but... Oceania has *always* been at war with Eastasia
[20:48:37] <mutante>	 MatmaRex: https://commons.wikimedia.org/wiki/Category:Wikimedia_servers_in_San_Francisco
[20:48:49] <Nemo_bis>	 https://meta.wikimedia.org/w/index.php?title=Wikimedia_servers&action=historysubmit&diff=6064631&oldid=5928809
[20:48:59] <MatmaRex>	 and it's in san francisco? heh, okay
[20:49:06] <^demon|away>	 brion: Eurasia!
[20:49:09] <^demon|away>	 Thought criminal!
[20:49:58] <brion>	 :D
[20:50:43] <gwicke>	 ori-l: ping
[20:51:28] <grrrit-wm>	 (03PS2) 10Netbrain: Tagged v0.1, did various cleanup and started on v 0.2 [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90174 
[20:51:55] <Krenair>	 MatmaRex: https://meta.wikimedia.org/wiki/Wikimedia_servers#Hosting is a useful reference for that info
[20:52:28] <Krenair>	 ... or would be if ulsfo was on the list. huh.
[20:54:04] <mutante>	 added 
[20:54:07] <mutante>	 Edit conflict
[20:54:18] <Krenair>	 by me :P
[20:54:21] <mutante>	 protected page in 2006 :p
[20:54:37] <Krenair>	 [edit=autoconfirmed:move=autoconfirmed]
[20:54:39] <mutante>	 thx
[20:54:41] <Krenair>	 ugh, old style protection logs
[20:56:19] <mutante>	 more info about location http://www.unitedlayer.com/san-francisco.htm
[20:57:33] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Improvements when searching long strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90200 (owner: 10Manybubbles)
[20:57:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improvements when searching long strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90200 (owner: 10Manybubbles)
[20:57:40] <grrrit-wm>	 (03CR) 10GWicke: "The naming here seems to be similarly misleading as in https://gerrit.wikimedia.org/r/#/c/89347/" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/90182 (owner: 10Ori.livneh)
[20:57:49] <grrrit-wm>	 (03CR) 10Chad: [C: 032] Tests for unbalanced quotes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90202 (owner: 10Manybubbles)
[20:57:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tests for unbalanced quotes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/90202 (owner: 10Manybubbles)
[21:03:13] <MatmaRex>	 jdlrobson: i'd appreciate a reply today on https://gerrit.wikimedia.org/r/#/c/82100/ :) i'm off in a few minutes
[21:06:47] <marktraceur>	 Oh hey, who needs i18n on CC licenses, that seems WAY unnecessary
[21:06:48] * marktraceur  sighs

[21:15:42] <grrrit-wm>	 (03PS10) 10SuchetaG: mediawiki.api: add postWithToken and getToken [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit)
[21:16:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: add postWithToken and getToken [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit)
[21:25:13] <grrrit-wm>	 (03PS1) 10MarkTraceur: Return categories and license [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90213 
[21:25:17] <marktraceur>	 Bam
[21:26:16] <grrrit-wm>	 (03PS2) 10Legoktm: Only allow Thanks for public revisions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 
[21:27:54] <grrrit-wm>	 (03PS3) 10Netbrain: Tagged v0.1, did various cleanup and started on v 0.2 [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90174 
[21:29:38] <grrrit-wm>	 (03PS4) 10Spage: Update browsertests for string change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89389 
[21:30:11] <grrrit-wm>	 (03CR) 10Spage: "Chris thanks for the thoughtful comments, I reduced the TODOs (and rebased again)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89389 (owner: 10Spage)
[21:33:21] <grrrit-wm>	 (03PS4) 10Netbrain: Tagged v0.1, did various cleanup and started on v 0.2 [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/90174 
[21:41:11] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/87279 (owner: 10MarkTraceur)
[21:48:37] <mwalker>	 jdlrobson: can you talk to me about https://gerrit.wikimedia.org/r/#/c/79948/
[21:48:44] <mwalker>	 it's made things look very odd
[21:49:01] <jdlrobson>	 mwalker: sorry not quite now - i'm trying to get stuff ready for the deployment train
[21:49:48] <jdlrobson>	 mwalker: do you want to send me a mail and we can discuss it when i have a free moment?
[21:50:19] <mwalker>	 sure
[21:55:02] <grrrit-wm>	 (03CR) 10Raimond Spekking: "(3 comments)" [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/89361 (owner: 10Luis Felipe Schenone)
[21:55:24] <gwicke>	 ori-l: ping
[21:55:34] <ori-l>	 hi
[21:56:25] <gwicke>	 hey, maybe renaming the internal variables would still be a good idea to avoid confusion
[21:57:17] <gwicke>	 performance.parsoid.domLoad sounds very much like it is measuring parsoid to me
[21:58:03] <gwicke>	 since this is in VE implicitly, wouldn't calling it simply performance.domLoad work?
[21:59:35] <ori-l>	 I don't mind, but since I am not personally motivated to change it, nor am I in a position to approve the change, please persuade the VE team and get a patch merged. I can offer to update things on my end.
[22:00:26] <legoktm>	 I just updated core to master and am seeing "Uncaught Error: Unknown dependency: mediaWiki.config "
[22:00:31] <gwicke>	 alright, am just trying to avoid confusion
[22:01:40] <ori-l>	 'performance.domLoad' is fine by me.
[22:02:44] <mwalker>	 legoktm: I would recommend using git bisect
[22:02:55] <mwalker>	 to figure out what patch caused it
[22:03:14] <mwalker>	 *if you have time to debug
[22:03:42] <legoktm>	 i'm disabling all my extensions first
[22:03:54] <mwalker>	 *nods* I don't get it with my install of core
[22:04:07] <gwicke>	 ori-l: https://gerrit.wikimedia.org/r/#/c/90258/
[22:05:36] <grrrit-wm>	 (03PS11) 10SuchetaG: mediawiki.api: add postWithToken and getToken [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit)
[22:05:50] <legoktm>	 gone now, time to figure out what extension it is...
[22:07:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: add postWithToken and getToken [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit)
[22:11:02] <legoktm>	 found it >.>
[22:11:05] <legoktm>	 it was my code
[22:11:47] <mwalker>	 *high five*
[22:11:47] <grrrit-wm>	 (03PS1) 10Legoktm: Remove invalid dependency upon 'mediawiki.config' [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/90259 
[22:11:57] <legoktm>	 mwalker: ^
[22:12:11] <grrrit-wm>	 (03CR) 10Mwalker: [C: 032] Remove invalid dependency upon 'mediawiki.config' [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/90259 (owner: 10Legoktm)
[22:12:14] <legoktm>	 ty :)
[22:17:56] <grrrit-wm>	 (03PS12) 10SuchetaG: mediawiki.api: add postWithToken and getToken [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit)
[22:22:17] * werdna  waves

[22:22:56] <grrrit-wm>	 (03PS1) 10Werdna: WIP: Moderation confirmation dialogues [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90260 
[22:23:04] <werdna>	 there ya go ebernhardson / spagewmf 
[22:23:08] <werdna>	 I just used jQuery.ui.dialog
[22:23:14] <werdna>	 isn't that the easiest way to do it?
[22:31:27] <Krenair>	 I've been getting more legitimate mailing list emails going to spam again...
[22:32:25] <Krenair>	 Eloquence, I've been getting more legitimate mailing list emails going to spam again...
[22:32:46] <werdna>	 weird, where is my team?
[22:32:55] <werdna>	 it's only 4:30pm in SF, right?
[22:33:00] <ori-l>	 3:30pm
[22:33:12] <werdna>	 oh yeah
[22:33:16] <werdna>	 even earlier
[22:34:25] <Krenair>	 "[Wikitech-l] Individual Engagement Grants: deadline approaching" and "[Wikitech-l] MediaWiki 1.22 Release Plan talk on 9 Oct" by Quim, "[Wikimedia-l] Join the community review of 4 FDC annual plan grant requests!"  by katy love
[22:35:33] <grrrit-wm>	 (03PS1) 10Legoktm: Merge AssertEdit extension into core [core] - 10https://gerrit.wikimedia.org/r/90263 
[22:35:44] <Reedy>	 o_0
[22:36:35] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] Replace deprecated methods [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89744 (owner: 10Siebrand)
[22:36:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Replace deprecated methods [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89744 (owner: 10Siebrand)
[22:39:40] <grrrit-wm>	 (03PS2) 10MarkTraceur: Return categories and license [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/90213 
[22:40:44] <grrrit-wm>	 (03CR) 10Legoktm: "This needs release notes, I'll add those in later to avoid rebase hell." [core] - 10https://gerrit.wikimedia.org/r/90263 (owner: 10Legoktm)
[22:41:23] <sucheta>	 superm401, Ping. 
[22:41:42] <superm401>	 sucheta, hey.
[22:42:30] <sucheta>	 superm401, Hi. I looked at the review you made last time. And, I have mediawiki.api.edit.js edited as you had mentioned. 
[22:42:40] <sucheta>	 Could you look at the patch once?
[22:42:57] <sucheta>	 https://gerrit.wikimedia.org/r/#/c/64582/10
[22:43:55] <superm401>	 sucheta, I have a few things to review already, so I'll do a real review when I can (unless someone beats me to it :) ).
[22:44:00] <superm401>	 However, I will post a quick comment now.
[22:44:55] <sucheta>	 Alright :)
[22:53:16] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "(9 comments)" [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit)
[22:53:34] <RoanKattouw>	 sucheta: I don't know that code very well but I noticed some minor nitpicky things so I commented on those
[22:55:00] <marktraceur>	 Is there not a function in MediaWiki for checking category membership?
[22:55:41] <marktraceur>	 i.e. even with nested categories e.g. isCategoryMember( $title, 'Category:CC-BY-SA-3.0' ); // Returns true even if page is in Category:CC-BY-SA-3.0-NL
[22:55:43] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit)
[22:55:54] <legoktm>	 marktraceur: not for recursive ones
[22:55:58] <marktraceur>	 Crap.
[22:55:59] <legoktm>	 for non-recursive there is
[22:56:13] <superm401>	 sucheta, yeah, RoanKattouw pretty much beat me to all my draft comments. :)
[22:56:16] <legoktm>	 category recursion is bad
[22:56:31] <superm401>	 I wouldn't say bad, I would say technically challenging. :)
[22:56:32] <legoktm>	 because some idiot user will create a loop somehow
[22:56:45] <marktraceur>	 legoktm: I just want bloody wikibase on bloody Commons so I can stop hacking around all of this bullshit
[22:56:51] <legoktm>	 :D
[22:57:01] <superm401>	 sucheta, only difference is I think you should maintain compatibility with the prior API (including deprecated parameters).
[22:57:09] <legoktm>	 marktraceur: i wrote https://gerrit.wikimedia.org/r/#/c/78343/ for use in massmessage a while back
[22:57:12] <marktraceur>	 It seems like every day I find something absolutely painful to even think about in this codebase
[22:57:35] <legoktm>	 :)
[22:57:36] <legoktm>	 brb
[22:57:52] <marktraceur>	 legoktm: Looks a lot like Title::getParentCategories
[22:58:24] <superm401>	 marktraceur, all of the subcategories of https://commons.wikimedia.org/wiki/Category:CC-BY-SA-2.0 are actually different licenses.
[23:00:00] <superm401>	 For the gory details, see http://wiki.creativecommons.org/Frequently_Asked_Questions#What_are_the_international_.28.E2.80.9Cunported.E2.80.9D.29_Creative_Commons_licenses.2C_and_why_does_CC_offer_.E2.80.9Cported.E2.80.9D_licenses.3F
[23:00:14] <marktraceur>	 superm401: That's sort of what I was afraid of
[23:00:15] <superm401>	 marktraceur, short answer, they are not translations, but "jurisdiction ports".
[23:00:43] <marktraceur>	 superm401: In that case I either need to implement badly or implement more badly
[23:00:47] <marktraceur>	 But I'm not sure which is which yet
[23:00:48] <marktraceur>	 v.v
[23:00:57] <quiddity>	 help pls:  I'm not experienced with <translate>,  so am delegating this problem:  "Fatal exception of type MWException" if I try to edit the first section at https://meta.wikimedia.org/wiki/Wikidata/Development/Storyboard_for_linking_Wikipedia_articles_v0.2  I assume because of <translate> problems in https://meta.wikimedia.org/wiki/Template:Draft
[23:01:07] <RoanKattouw>	 See and things like what superm401 said are why I said I didn't know this code well enough :)
[23:01:15] <RoanKattouw>	 Keeping back compat seems very reasonable
[23:01:22] <superm401>	 I think you can get away with just treating e.g. {{Cc-by-sa-2.0-at}} and {{Cc-by-sa-2.0}} as different licenses.
[23:01:29] <marktraceur>	 "just"
[23:01:35] <superm401>	 ?
[23:01:46] <superm401>	 Well, there's probably hundreds of licenses on Commons.
[23:01:59] <superm401>	 So you can't avoid having a long list somewhere if you're making a pretty way to render them.
[23:02:03] <marktraceur>	 superm401: The problem is I need to somehow translate {{Cc-by-sa-2.0-at}} into a link to creativecommons.org *or* somehow figure out whether it's OK for me to violate their trademark policy
[23:02:04] <superm401>	 I assume this about the image viewer, etc.?
[23:02:10] <marktraceur>	 Yeah it is
[23:02:31] <marktraceur>	 I'm just *full* of attempted violations of CC trademark policy today.
[23:02:34] <marktraceur>	 Hi mindspillage
[23:03:17] <superm401>	 marktraceur, UploadWizard.config.php has a long list of them (though not 2.0-at).
[23:03:19] * mindspillage  waves a weary wave at marktraceur: another day, another trademark issue!

[23:03:22] <marktraceur>	 Heh
[23:03:28] <superm401>	 It should be probably be moved somewhere else and the missing ones added.
[23:03:35] <marktraceur>	 superm401: The Solution will be Wikibase on Commons
[23:03:49] <marktraceur>	 Including licensing stuff
[23:03:52] <marktraceur>	 And so on
[23:04:08] <marktraceur>	 Then I can stop writing hacks and instead make cool software
[23:04:23] <superm401>	 Yep, that will help a lot.
[23:04:44] <superm401>	 We need to make sure people's bylines don't get messed up in the transition though.
[23:04:48] <marktraceur>	 mindspillage: I won't ask you to comment, I was just noting the hilarity of talking about violating your employer's trademark policy.
[23:04:55] <superm401>	 People are particular about that (understandably).
[23:05:18] <marktraceur>	 superm401: I'm not mangling any, but I do strip out formatting when displaying in the viewer
[23:05:26] <marktraceur>	 Which is maybe more mangling than they'd like but meh
[23:05:47] <superm401>	 As long as you can still go to the image page, it should be alright.
[23:06:21] <marktraceur>	 Yup
[23:06:26] <marktraceur>	 That's what lvillaWMF said too. :)
[23:07:17] <mindspillage>	 marktraceur: I saw nothing, what are you talking about? 
[23:07:41] <marktraceur>	 mindspillage: Do you actually want to know? We're going to ask lvilla anyway, so it's probably not important.
[23:08:25] <mindspillage>	 marktraceur: it may be similar to something I have already talked to him about, but no--talk to Luis and if he can't give you a good answer I'm sure I will hear about it!
[23:08:40] <marktraceur>	 Cool cool
[23:08:51] <marktraceur>	 mindspillage: We always bring you the juicy legal questions!
[23:09:32] <mindspillage>	 marktraceur: I would be disappointed if you didn't... (speaking of which, back to work)
[23:09:38] <marktraceur>	 Heh
[23:10:24] <superm401>	 Wow, the jurisdiction ports are translated too.
[23:10:47] <superm401>	 CC-BY-SA 2.0 Belgium in Croatian: https://creativecommons.org/licenses/by-sa/2.0/be/deed.hr
[23:11:27] <marktraceur>	 superm401: I often find that I'm in Croatia and want to use a photo taken in and primarily distributed in Belgium, yes. :)
[23:18:00] <grrrit-wm>	 (03PS14) 10Tim Starling: Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána)
[23:18:07] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 032] Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána)
[23:20:03] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 032] Wikipedia archive import script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/87503 (owner: 10Tim Starling)
[23:21:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Wikipedia archive import script [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/87503 (owner: 10Tim Starling)
[23:23:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána)
[23:26:46] <legoktm>	 quiddity: use {{TNT|draft}}
[23:27:10] <grrrit-wm>	 (03PS3) 10BryanDavis: Added a "syncviadelete" param to copyFileBackend script [core] - 10https://gerrit.wikimedia.org/r/78969 (owner: 10Aaron Schulz)
[23:28:25] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson)
[23:29:25] <quiddity>	 legoktm, I can't edit the page, and I don't want to mess with the template.
[23:29:33] <legoktm>	 quiddity: I already fixed it
[23:29:36] <quiddity>	 <3
[23:29:37] <legoktm>	 quiddity: why can't you edit the page?
[23:29:43] <grrrit-wm>	 (03CR) 10BryanDavis: [C: 032] "Tested locally using the default local-backend and a FSFileBackend named 'local-testing' as suggested by Aaron. Replication, purge of orph" [core] - 10https://gerrit.wikimedia.org/r/78969 (owner: 10Aaron Schulz)
[23:29:57] <legoktm>	 quiddity: https://meta.wikimedia.org/w/index.php?title=Wikidata/Development/Storyboard_for_linking_Wikipedia_articles_v0.2&diff=prev&oldid=6065564
[23:31:35] <quiddity>	 legoktm, if I go to Tony's prior version: https://meta.wikimedia.org/w/index.php?title=Wikidata/Development/Storyboard_for_linking_Wikipedia_articles_v0.2&oldid=3849359
[23:31:39] <quiddity>	 it says: "[ae85a216] 2013-10-16 23:31:02: Fatal exception of type MWException"
[23:31:54] <legoktm>	 quiddity: yeah, Reedy filed the bug for that earlier today
[23:31:59] <quiddity>	 kk
[23:32:07] <legoktm>	 you can always just add ?action=edit to the url
[23:32:18] <legoktm>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=55808
[23:33:10] <quiddity>	 the error was appearing when I clicked [edit], but I didn't check what URL it was presenting.
[23:33:21] <legoktm>	 o.O
[23:33:30] <legoktm>	 if the error shows up on the edit page, it's a different bug
[23:33:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson)
[23:33:49] <legoktm>	 https://meta.wikimedia.org/w/index.php?title=Wikidata/Development/Storyboard_for_linking_Wikipedia_articles_v0.2&oldid=3849359&action=edit <-- I can't reproduce
[23:34:32] <quiddity>	 Hmm. I had tested it at 2 pages (also https://meta.wikimedia.org/wiki/Statement_of_Principles  ) and definitely could not edit.  Seems to work now.
[23:34:53] <legoktm>	 weird.
[23:34:55] <grrrit-wm>	 (03CR) 10Mwalker: [C: 031] Vector: Fix font size regression [core] - 10https://gerrit.wikimedia.org/r/90134 (owner: 10Jdlrobson)
[23:34:57] <legoktm>	 well using TNT will fix it
[23:35:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Added a "syncviadelete" param to copyFileBackend script [core] - 10https://gerrit.wikimedia.org/r/78969 (owner: 10Aaron Schulz)
[23:45:23] <grrrit-wm>	 (03CR) 10Bsitu: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 (owner: 10Legoktm)
[23:49:25] <grrrit-wm>	 (03PS1) 10Tim Starling: Revert "Add support for mysqli extension" [core] - 10https://gerrit.wikimedia.org/r/90266 
[23:49:45] <grrrit-wm>	 (03CR) 10Tim Starling: [C: 032] Revert "Add support for mysqli extension" [core] - 10https://gerrit.wikimedia.org/r/90266 (owner: 10Tim Starling)
[23:51:26] <grrrit-wm>	 (03PS1) 10MarkTraceur: Add license to the header [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90267 
[23:54:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Add support for mysqli extension" [core] - 10https://gerrit.wikimedia.org/r/90266 (owner: 10Tim Starling)