[00:00:13] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/89644 (owner: 10L10n-bot) [00:00:31] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/89645 (owner: 10L10n-bot) [00:00:44] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/89645 (owner: 10L10n-bot) [00:00:50] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/89646 (owner: 10L10n-bot) [00:01:02] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/89646 (owner: 10L10n-bot) [00:01:28] (03CR) 10Aklapper: [C: 031] "Incorporates feedback by design team (see https://bugzilla.wikimedia.org/show_bug.cgi?id=36762#c12 ) and can be tested on http://boogs.wmf" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/74360 (owner: 10Aklapper) [00:01:37] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/89649 (owner: 10L10n-bot) [00:01:45] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/89649 (owner: 10L10n-bot) [00:01:57] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89650 (owner: 10L10n-bot) [00:02:07] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89650 (owner: 10L10n-bot) [00:02:21] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/89647 (owner: 10L10n-bot) [00:02:25] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/89647 (owner: 10L10n-bot) [00:02:32] (03CR) 10Reedy: [C: 032] Localisation updates from http://translatewiki.net. [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/89648 (owner: 10L10n-bot) [00:03:26] (03CR) 10Reedy: [V: 032] Localisation updates from http://translatewiki.net. [extensions/AccountAudit] - 10https://gerrit.wikimedia.org/r/89644 (owner: 10L10n-bot) [00:03:40] (03CR) 10Reedy: [V: 032] Localisation updates from http://translatewiki.net. [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/89648 (owner: 10L10n-bot) [00:43:33] Reedy: https://gerrit.wikimedia.org/r/#/q/owner:L10n-bot+status:open,n,z is empty now. [00:43:41] I now [00:43:43] See above [00:43:49] It just missed A and C? [00:43:53] *Know [00:44:19] Nope [00:44:22] APC was done [00:44:34] I wonder if it was just gerrit fail [00:44:38] Odd. [00:44:45] like you get on clones/updates/whatever [00:44:49] Then try it again and it works [00:45:03] I don't clone enough to hit failures, thankfully. [00:45:09] Does it fail sometimes? [00:45:11] It shouldn't. [00:45:59] I have one or 2 a day when I'm updating over 600 repos [00:46:32] just doing fetch/pull etc [00:46:57] Hrm. [00:48:59] It wouldn't surprised if the script didn't account for failures [00:52:16] Right. [00:52:35] The sentence is vaguely understandable. [00:52:38] That * [00:52:41] Now you've infected me. [01:24:54] ori-l or legoktm: Do you have a good way of easily inspecting the contents of a RL module? [01:25:07] For example, "mediawiki.api.watch". [01:25:44] resources/mediawiki.api/mediaiwki.api.watch.js ? [01:26:12] Maybe. [01:26:48] Resouces.php tells you this stuff [01:26:49] 'mediawiki.api.watch' => array( [01:26:49] 'scripts' => 'resources/mediawiki.api/mediawiki.api.watch.js', [01:27:12] I was kind of hoping of some way to pretty-print the contents of the module into the console. [01:27:39] pretty-print --> no minification or other nonsensen. [01:27:41] Nonsense. [01:28:09] You can of course make calls to bits with debug=true [01:29:50] There must be a one liner to do something like that [01:30:53] Dunno. [01:31:11] Is there an easy way to export Chrome's console? [01:31:18] I guess copy and paste support is too much to ask for. [01:43:02] Yeah, I just look at the source code directly [01:49:55] you can [01:50:13] mw.loader.moduleRegistry['mediawiki.api.watch'].script [01:50:43] Can I wrap that in a function name I might remember? [01:50:48] Like print()? [01:51:42] well, the rdepends-like function was called 'why', so this one should be 'what', no? [01:51:48] or 'wat' [01:52:15] I'm fine with that. [01:52:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=4716 Old bug. [01:53:17] https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Typography Interesting. [01:53:26] !log rebooting mw1035 for init testing [01:53:26] There is no such key, you probably want to try: !anonnotice, !api, !chansearch, !cms, !debug, !errors, !gitaccount, !logo, !revdelete, !sal, !sharedlogins, !sqllog, !sul, !tautology, !htmllogs, !logs, !skinning, [01:53:41] Heh. [01:53:43] function what( moduleName ) { console.dir( mw.loader.moduleRegistry[moduleName] ); } [01:54:25] what is "init testing"? [01:54:46] init.d scripts? [01:55:15] I think he's still working on the cgroups thing. [01:55:30] ...what are cgroups? [01:55:45] https://en.wikipedia.org/wiki/Cgroups [01:55:56] I know what C-beams are [01:56:01] they're those things that glitter in the darkness [01:56:01] https://wikitech.wikimedia.org/wiki/Server_Admin_Log#October_15 [01:57:02] ah, thanks. [01:57:43] Oh. [01:57:50] Can I add .script? [01:58:00] It's outputting the object. [01:58:15] https://en.wikipedia.org/wiki/User:MZMcBride/what.js [01:58:23] well, modules comprise CSS, JS, and messages [01:58:25] [moduleName].script [01:58:33] script is just the javascript, but if that's all you care about, sure [01:58:43] Hmm. [01:59:01] It's all minified inside the object. [02:00:01] you can beautify it using a beautification script, or you can do what reedy suggested and get the unminified version [02:00:07] which would be, um, [02:00:36] This inspect thing is neat, but working in the console is hurting my head. [02:00:43] (you should document this, by the way, so you're not the only person with this know-how) [02:00:43] Because it's not really a table, it's basically an image of a table. [02:00:47] Where there are no links and I can't copy and paste. [02:00:51] I can half-assed sort. [02:01:44] yeah, I think we'll separate the computation of the payload data from its presentation [02:01:52] +++ [02:01:54] Yes. [02:01:55] this should make it easier to write helper scripts for poking at it [02:02:20] The data is nice, but working in the console is hurting my head. [02:22:55] Elsie: https://dpaste.de/pRWW/raw/ [02:23:22] I've wanted to write script for a while, actually [02:23:26] *that [02:23:43] don't think i'm being nice [02:30:34] :-) [02:36:10] ori-l: Are you going to make a user script? [02:43:42] Hrm. [02:50:27] (03PS1) 10Legoktm: Only load RL modules on the edit form and if the user can edit [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89766 [02:53:51] Yes, I found that with mw.loader.inspect(). [02:57:28] (03PS2) 10leucosticte: Add PerPageLicense extension. [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 [03:12:18] legoktm: gj [03:16:58] YuviPanda|away: LIKE HELL YOU ARE [03:17:39] * marktraceur whacks YuviPanda|away around with the "Open a Bloody RfC Before Making Crazy Architectural Decisions" bat [03:18:27] What are you referring to? [03:19:34] * werdna blinks [03:22:44] * werdna is trying very hard to make the line lengths in this commit message line up. A little too hard, perhaps. [03:25:51] (03PS1) 10Werdna: Reply adjustments, especially for tangents. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89768 [03:26:08] success! [03:26:53] (03PS2) 10Legoktm: Modify Drafts::display to return HTML instead of a count [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 [03:26:57] (03CR) 10jenkins-bot: [V: 04-1] Modify Drafts::display to return HTML instead of a count [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 (owner: 10Legoktm) [03:27:16] :| [03:28:41] (03PS2) 10Legoktm: Move Special:Drafts specific code into SpecialDrafts.php [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88893 [03:28:42] (03PS3) 10Legoktm: Modify Drafts::display to return HTML instead of a count [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 [03:40:11] (03PS1) 10Legoktm: Add a script to remove expired drafts from the database [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89769 [03:51:25] legoktm: I hope you know what you're getting into with the drafts extension; when I last looked at it it was a bit of a hack and I imagine the work needed for making it production-ready is considerable [03:51:45] Yeah, it currently doesn't work [03:53:37] (03PS5) 10Legoktm: [WIP] Convert to use jQuery [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88405 [03:53:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert to use jQuery [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88405 (owner: 10Legoktm) [03:53:49] ^ that's the patchset currently giving me trouble [03:54:08] None of the .on(thing, function) calls are working [03:54:16] (03PS6) 10Legoktm: [WIP] Convert to use jQuery [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88405 [04:06:18] (03CR) 10Aaron Schulz: [C: 032] Update comments and satisfy analyzer [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89737 (owner: 10Siebrand) [04:25:56] (03PS1) 10Legoktm: Remove unused configuration variable [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89770 [04:41:00] is there any documentation for MediaWiki's LESS setup? [04:46:39] there's https://www.mediawiki.org/wiki/Requests_for_comment/LESS [04:57:05] werdna: There's a changeset somewhere converting screen.css to screen.less. [04:57:27] I found https://www.mediawiki.org/wiki/Manual:Coding_conventions/LESS [04:57:35] And that. [04:57:37] CC/LESS [05:13:14] werdna: there's LESS of it than there ought to be [05:13:24] (sorry, sorry, I'll be leaving now) [05:14:48] thanks ori-l [05:15:08] I gotta go for a bit, but if you have specific questions ask here and I'll answer them in an hour [05:15:37] nah I got it sorted [05:45:17] (03CR) 10Legoktm: "(3 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 (owner: 10Legoktm) [06:11:15] Is there any way to add css and javascript to the tag of the page from an extension? [06:12:46] now it is loaded from javascript, which means that for a split second all my elements looks ugly in a split second before css/js is loaded [06:17:18] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [06:40:17] (03CR) 10Nikerabbit: [C: 031] Modify Drafts::display to return HTML instead of a count [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 (owner: 10Legoktm) [06:45:23] (03CR) 10Nikerabbit: "I'm convinced that getMath should be deprecated, but it must be replaced with one of the alternative ways to fragment the cache." [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [07:12:06] (03CR) 10Nikerabbit: [C: 032] Expose number of queued messages in the API [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 (owner: 10Legoktm) [07:12:17] (03Merged) 10jenkins-bot: Expose number of queued messages in the API [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 (owner: 10Legoktm) [07:16:26] (03CR) 10Nikerabbit: "Can someone summarize the current status of this patch?" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [07:32:05] (03CR) 10Nikerabbit: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88998 (owner: 10Zfilipin) [07:36:07] (03CR) 10Nikerabbit: "Can you give examples of search terms where the behavior changes?" [core] - 10https://gerrit.wikimedia.org/r/84475 (owner: 10Ejegg) [07:38:45] (03CR) 10Nikerabbit: [C: 031] LinkSearch: use default protocol if unsupported [core] - 10https://gerrit.wikimedia.org/r/84475 (owner: 10Ejegg) [07:55:54] is it just me or is bugzilla down? [07:56:19] isup.me said it is just me :( [07:58:15] it is back up, looks like my machine was the problem [08:32:26] (03PS35) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:32:45] (03CR) 10Addshore: "Reading SQL into an object, modifying an object, writing it back. ie. schema modification." [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [08:35:14] (03CR) 10Physikerwelt: "(1 comment)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/89753 (owner: 10Ori.livneh) [08:41:51] (03CR) 10Ori.livneh: "(1 comment)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/89753 (owner: 10Ori.livneh) [08:42:54] (03PS4) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [08:44:18] (03CR) 10jenkins-bot: [V: 04-1] add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [08:44:24] (03CR) 10Physikerwelt: "ok. I'll use addExtraKey for that." [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [08:46:12] (03PS5) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [08:47:11] (03CR) 10jenkins-bot: [V: 04-1] add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [08:49:17] (03PS1) 10Pigpen: Merged from develop [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/89779 [08:50:43] (03CR) 10Pigpen: [C: 032 V: 032] "Latest state of development" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/89779 (owner: 10Pigpen) [08:52:55] (03PS36) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [08:53:22] andre__: do you have a minute? [08:54:40] andre__: I was wondering where to report problems with git-review but looks like the place is bugzilla>wikimedia>git/gerrit [08:56:14] zeljkof, alright, now I have time [08:56:17] and yes, you are right :P [08:56:55] andre__: by the way, are you aware of any problems with git review on linux or specifically ubuntu? [08:57:50] or could the problem be that the machine is chrome book with ARM processor? [08:58:01] "any problems" is a bit vague. :D I haven't tried it on Ubuntu, it works fine for me on Fedora [08:58:09] but python should not care about that, right? [08:58:48] andre__: well, I was able to install git-review, but when I try to run it (with -s or -d) then it outputs error messages [08:58:57] anyway, will report the problem, so we can take it from there [08:58:59] Let me see your bug report with the error messages :) [08:59:12] andre__: will do [08:59:12] Idiot that I am, I normally just follow https://www.mediawiki.org/wiki/Git/Tutorial [09:00:37] I did the same [09:00:47] and it worked fine until git review -s [09:02:01] andre__: while I have you here, where is the setting to make a bugzilla search public? [09:02:14] I remember seeing it somewhere, but can not find now... [09:02:24] zeljkof, you means saving it and then sharing it? [09:02:26] http://blogs.gnome.org/aklapper/2013/07/12/bugzillatips-saved-searches/ [09:03:01] zeljkof, or if you have already stored the search, go to https://bugzilla.wikimedia.org/userprefs.cgi?tab=saved-searches and set the group to "bz_canusewhines" [09:03:03] andre__: exactly what I was looking for! :) [09:03:29] andre__: bz_canuswhines? :) [09:03:40] hmm, yeah [09:04:21] (03PS1) 10Pigpen: Merged from develop [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/89780 [09:04:53] andre__: is there a reason for such cryptic name? isn't "public" a better name? [09:05:33] hmm, yeah, good point, from a saved search point of view. [09:05:40] and also, is there a way to get a shorter url for a search? [09:05:52] the groups don't refer to saved searches only. bz_canusewhines is a default group in Bugzilla, and a group that every user is a member of [09:06:02] I see [09:06:10] but I would never figure that out myself [09:06:34] zeljkof, shorter URL? I don't think so :-/ [09:06:40] hmm. good point. [09:06:44] need to think about that. [09:07:09] andre__: I know how to shorten the url with a url shortener, but bugzilla by default creates really long urls [09:07:25] (03PS6) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [09:07:27] yes, Bugzilla loves long URIs [09:08:25] and I had problems embedding them in wiki pages [09:08:40] meaning broken links [09:08:52] and mediawiki does not like url shorteners [09:11:01] andre__: hm, but if I make a search shared, it is still not public, right? [09:11:06] (03CR) 10Pigpen: [C: 032 V: 032] "Latest state of development" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/89780 (owner: 10Pigpen) [09:11:09] meaning, you have to log in to see the search [09:11:50] andre__: is there a way to make a search public, so people could see a list of bugs _before_ they create bugzilla account? [09:13:25] (03PS1) 10Pigpen: Added WMF git ignores [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/89782 [09:13:55] (03CR) 10Pigpen: [C: 032 V: 032] "Added WMF git ignores" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/89782 (owner: 10Pigpen) [09:16:06] (03CR) 10Addshore: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [09:16:33] zeljkof, I just tried. No, looks like you need to create an account first. Meh. [09:16:54] andre__: yes, I have tried it myself too [09:17:07] that would be a nice feature to have, one day [09:17:12] I'll ask upstream [09:17:20] thanks [09:18:07] (03PS1) 10Pigpen: Added WMF git ignores; latest updates [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/89783 [09:18:34] (03CR) 10Pigpen: [C: 032 V: 032] "Added WMF git ignores; latest updates" [extensions/BlueSpiceExtensions] - 10https://gerrit.wikimedia.org/r/89783 (owner: 10Pigpen) [09:18:51] (03CR) 10Hashar: """Reading SQL into an object, modifying an object, writing it back. ie. schema modification.""" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [09:21:17] hello [09:22:40] zeljkof, hah, upstreamed already: https://bugzilla.mozilla.org/show_bug.cgi?id=400063 [09:23:20] (03PS1) 10Pigpen: Added WMF git ignores; latest updates [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/89784 [09:23:49] (03CR) 10Pigpen: [C: 032 V: 032] "Added WMF git ignores; latest updates" [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/89784 (owner: 10Pigpen) [09:23:50] andre__: great, I was sure we are not the only one that could use the feature :) [09:25:03] (03CR) 10Addshore: "There is no need to specifically save some representation of the object to the database and the dbms itself has ways to read the exact def" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [09:25:26] morning hashar :) [09:29:20] :-) [09:29:24] I should stop doing review [09:37:31] (03PS1) 10Hashar: jobs for mediawiki/extensions/CategoryTagSorter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89786 [09:39:11] (03PS1) 10Hashar: triggers for mediawiki/extensions/CategoryTagSorter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89787 [09:39:28] (03CR) 10Hashar: [C: 032] triggers for mediawiki/extensions/CategoryTagSorter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89787 (owner: 10Hashar) [09:39:57] (03PS2) 10Hashar: triggers for mediawiki/extensions/CategoryTagSorter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89787 [09:40:06] (03CR) 10Hashar: [C: 032] triggers for mediawiki/extensions/CategoryTagSorter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89787 (owner: 10Hashar) [09:40:22] (03Merged) 10jenkins-bot: triggers for mediawiki/extensions/CategoryTagSorter [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89787 (owner: 10Hashar) [09:40:39] (03CR) 10Hashar: [C: 032] jobs for mediawiki/extensions/CategoryTagSorter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89786 (owner: 10Hashar) [09:40:57] (03Merged) 10jenkins-bot: jobs for mediawiki/extensions/CategoryTagSorter [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89786 (owner: 10Hashar) [09:42:37] andre__: reported the bug https://bugzilla.wikimedia.org/55732 [09:42:46] (03CR) 10Physikerwelt: "whenever I got this error message it was related to" [extensions/Math] - 10https://gerrit.wikimedia.org/r/89753 (owner: 10Ori.livneh) [09:51:25] zeljkof: would love to also see "git review --version" and "git review -vs" output in your ticket [09:51:38] (03PS1) 10Hashar: whitelist Daniel Renfro from VistaPrint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89789 [09:51:40] andre__: will do [09:51:48] (03CR) 10Hashar: [C: 032] whitelist Daniel Renfro from VistaPrint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89789 (owner: 10Hashar) [09:52:00] (03Merged) 10jenkins-bot: whitelist Daniel Renfro from VistaPrint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89789 (owner: 10Hashar) [09:53:43] -vs is not a valid argument [09:53:52] andre__: ^ [09:54:04] zeljkof: uh. it worked here. [09:54:21] impressive. basically -s with verbose output [09:54:24] does not work on ubuntu or mac for me [09:54:29] but I'm running version 1.22 [09:54:34] let me try again [09:54:58] my mistake [09:55:03] I was running --vs [09:55:06] it should be -vs [09:56:42] done, added the info to the ticket [10:21:24] (03PS2) 10Tim Landscheidt: Disallow top level domains in Cookie::validateCookieDomain(). [core] - 10https://gerrit.wikimedia.org/r/24636 [10:25:21] (03PS3) 10Hashar: Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [10:25:21] (03CR) 10jenkins-bot: [V: 04-1] Show error for empty username for providers. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/50593 (owner: 10Parent5446) [10:38:58] (03PS2) 10Hashar: mw-run-phpunit.sh replace mw-phpunit-allexts macro [integration/jenkins] - 10https://gerrit.wikimedia.org/r/87324 [10:39:23] (03CR) 10Addshore: [C: 031] Set relevant User on Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/88785 (owner: 10Umherirrender) [10:41:47] Cool SSL error dude! http://www.indianvisaonline.gov.in/visa/ [10:41:53] https://indianvisaonline.gov.in/visa/indianVisaReg.jsp [10:41:59] (first link) [10:42:16] (03PS2) 10Hashar: extension: set MW_INSTALL_PATH to WORKSPACE when unset [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89168 [10:44:55] (03CR) 10Hashar: [C: 032] "deploying" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89168 (owner: 10Hashar) [10:45:15] (03Merged) 10jenkins-bot: extension: set MW_INSTALL_PATH to WORKSPACE when unset [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89168 (owner: 10Hashar) [10:46:31] (03CR) 10Addshore: [C: 031] Add timeout and options to MediaWikiSite::normalizePageName [core] - 10https://gerrit.wikimedia.org/r/55056 (owner: 10John Erling Blad) [10:47:25] Krinkle: the india government CA is pending review of all sub-CAs http://www.mozilla.org/projects/security/certs/pending/ :D [10:49:46] (03PS5) 10Siebrand: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 [10:50:21] (03CR) 10Siebrand: "PS5 fixes merge conflict in Exception.php to prevent patch rot." [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [10:51:18] (03PS3) 10Hashar: mw-run-phpunit-allexts.sh replaces mw-phpunit-allexts macro [integration/jenkins] - 10https://gerrit.wikimedia.org/r/87324 [10:52:16] hashar: their site doesn't advocate HTTPS though, that same form is linked to from other pages as non-https. Just that one link did it. [10:52:24] the button on the bottom of that same page goes to the right url [10:53:38] (03PS4) 10Hashar: mw-run-phpunit-allexts.sh replaces mw-phpunit-allexts macro [integration/jenkins] - 10https://gerrit.wikimedia.org/r/87324 [10:54:42] (03CR) 10Hashar: [C: 032] mw-run-phpunit-allexts.sh replaces mw-phpunit-allexts macro [integration/jenkins] - 10https://gerrit.wikimedia.org/r/87324 (owner: 10Hashar) [10:55:17] (03Merged) 10jenkins-bot: mw-run-phpunit-allexts.sh replaces mw-phpunit-allexts macro [integration/jenkins] - 10https://gerrit.wikimedia.org/r/87324 (owner: 10Hashar) [11:00:26] (03PS1) 10Hashar: mw-run-*.sh should be executable [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89793 [11:01:17] (03CR) 10Hashar: [C: 032] mw-run-*.sh should be executable [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89793 (owner: 10Hashar) [11:02:08] (03PS1) 10Aklapper: Remove custom CSS files identical to upstream standard CSS files. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89795 [11:03:10] (03CR) 10Hashar: [V: 032] mw-run-*.sh should be executable [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89793 (owner: 10Hashar) [11:04:06] (03CR) 10Aklapper: [C: 031] "+1: tested locally by disabling specific CSS files in Firefox's "Developer Tools > Style Editor", and on boogs.wmflabs.org by removing the" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89795 (owner: 10Aklapper) [11:06:54] Krinkle: if you are still around, I am slowly starting to migrate the JJB inline shell scripts to shells scripts files hosted in integration/jenkins [11:07:08] Krinkle: will document that on the wiki somewhere [11:08:10] (03CR) 10Parent5446: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [11:10:21] (03PS1) 10Hashar: migrate phpunit macro for extension to shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89796 [11:10:35] (03CR) 10Hashar: [C: 032] migrate phpunit macro for extension to shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89796 (owner: 10Hashar) [11:10:59] (03Merged) 10jenkins-bot: migrate phpunit macro for extension to shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89796 (owner: 10Hashar) [11:12:17] (03PS1) 10Hashar: mw-run-phpunit-allexts: junit output under /logs/ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89798 [11:13:38] (03PS1) 10Hashar: mw-run-phpunit-allexts: junit output under /logs/ [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89799 [11:13:50] (03CR) 10Hashar: [C: 032] mw-run-phpunit-allexts: junit output under /logs/ [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89799 (owner: 10Hashar) [11:14:22] (03Merged) 10jenkins-bot: mw-run-phpunit-allexts: junit output under /logs/ [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89799 (owner: 10Hashar) [11:14:26] (03CR) 10Hashar: [C: 032] mw-run-phpunit-allexts: junit output under /logs/ [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89798 (owner: 10Hashar) [11:16:05] (03PS7) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [11:17:09] (03Restored) 10Hashar: JENKINS validation (do not submit) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/44102 (owner: 10Hashar) [11:17:16] (03PS8) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [11:17:29] (03PS9) 10Hashar: JENKINS validation (do not submit) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/44102 [11:19:13] (03PS1) 10Aklapper: Remove unused release-notes.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89800 [11:19:48] (03CR) 10Aklapper: [C: 031] Remove unused release-notes.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89800 (owner: 10Aklapper) [11:22:19] (03PS2) 10Zfilipin: Updated Jobs and documentation who gets e-mail notification when a Jenkins job fails [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88998 [11:23:00] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT). [extensions/Cite] - 10https://gerrit.wikimedia.org/r/69653 (owner: 10Hashar) [11:23:29] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT). [extensions/Cite] - 10https://gerrit.wikimedia.org/r/69653 [11:23:46] (03Abandoned) 10Hashar: JENKINS validation (do not submit) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/44102 (owner: 10Hashar) [11:24:22] (03PS3) 10Zfilipin: Updated Jobs and documentation who gets e-mail notification when a Jenkins job fails [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88998 [11:25:00] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT). [extensions/Cite] - 10https://gerrit.wikimedia.org/r/69653 (owner: 10Hashar) [11:25:11] (03CR) 10Zfilipin: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88998 (owner: 10Zfilipin) [11:33:24] andre__: can you access my saved searches from this e-mail? http://lists.wikimedia.org/pipermail/qa/2013-October/000555.html [11:33:58] andre__: siebrand says the links do not work for him http://lists.wikimedia.org/pipermail/qa/2013-October/000556.html [11:34:31] (03PS1) 10Hashar: publisher macro 'archive-logs-dir' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89801 [11:34:33] (03PS1) 10Hashar: mw ext test jobs now archives logs dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89802 [11:34:47] (03CR) 10Hashar: [C: 032] publisher macro 'archive-logs-dir' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89801 (owner: 10Hashar) [11:34:52] I deny any an all involvement. They are impersonators out to get me! [11:34:52] (03CR) 10Hashar: [C: 032] mw ext test jobs now archives logs dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89802 (owner: 10Hashar) [11:35:23] (03Merged) 10jenkins-bot: publisher macro 'archive-logs-dir' [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89801 (owner: 10Hashar) [11:35:39] (03Merged) 10jenkins-bot: mw ext test jobs now archives logs dir [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89802 (owner: 10Hashar) [11:40:45] (03CR) 10Hashar: "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89168 (owner: 10Hashar) [11:47:54] (03PS1) 10Hashar: rename log dir: logs -> log [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89804 [11:47:54] zeljkof, I cannot: "The search named zfilipin does not exist." [11:47:58] (03PS1) 10Hashar: rename log dir: logs -> log [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89805 [11:48:13] (03CR) 10Hashar: [C: 032] rename log dir: logs -> log [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89804 (owner: 10Hashar) [11:48:19] andre__: well, it works for me :) [11:48:21] (03CR) 10Hashar: [V: 032] rename log dir: logs -> log [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89804 (owner: 10Hashar) [11:48:34] andre__: can you take a look in my preferences, if I did something wrong? [11:49:48] (03CR) 10Hashar: [C: 032] rename log dir: logs -> log [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89805 (owner: 10Hashar) [11:50:07] (03Merged) 10jenkins-bot: rename log dir: logs -> log [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89805 (owner: 10Hashar) [11:53:24] (03CR) 10Alex Monk: [C: 032] Remove unused local variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89736 (owner: 10Siebrand) [11:53:32] (03Merged) 10jenkins-bot: Update comments and satisfy analyzer [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89737 (owner: 10Siebrand) [11:53:33] (03Merged) 10jenkins-bot: Remove unused local variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89736 (owner: 10Siebrand) [11:53:55] zeljkof, looks all correct. sigh. And I can see these queries also listed as shared and available on https://bugzilla.wikimedia.org/userprefs.cgi?tab=saved-searches for my own Bugzilla account. But: [11:54:01] * siebrand thanks Krenair  [11:54:18] oh, had to thank hashar there :) [11:54:50] zeljkof, If I log in with my second account, and try to run a saved search shared by my first account, a URL in the style of https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=$InsertNameHere&sharer_id=$YourBugzillaUserID works for me [11:54:51] only 11 mergeble patch sets to go... [11:57:36] andre__: do you know what could be the problem with my saved searches? [11:59:04] zeljkof, they need a format like https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=qa&sharer_id=16205 [11:59:10] then they work for me when being logged in [11:59:19] I see [11:59:22] let me try [12:01:30] siebrand: You're welcome. There's more? [12:01:44] ah, in different projects [12:01:56] Krenair: *nod* [12:01:58] (03PS1) 10Matthias Mullie: Method was not static but was called as if it were [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/89807 [12:03:50] zeljkof: (note that the sharer_id parameter is your own Bugzilla user ID) [12:04:07] andre__: thanks [12:04:10] sure [12:04:14] I also learned something :) [12:04:37] (03PS5) 10Matthias Mullie: Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 [12:08:44] (03CR) 10Alex Monk: [C: 032] Method was not static but was called as if it were [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/89807 (owner: 10Matthias Mullie) [12:08:47] (03Merged) 10jenkins-bot: Method was not static but was called as if it were [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/89807 (owner: 10Matthias Mullie) [12:09:49] (03PS2) 10Alex Monk: (bug 54520) Remove message 'articlefeedbackv5-error-email' from ArticleFeedbackv5.php [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/86092 (owner: 10Matthias Mullie) [12:14:32] zeljkof: those email links don't have your sharer id on them by the looks [12:14:58] grab the links from Prefs -> Shared Searches -> Run compared to your sidebar [12:15:37] p858snake|l: thanks, andre__ already pointed me there [12:15:44] p858snake|l: these links should work http://lists.wikimedia.org/pipermail/qa/2013-October/000559.html [12:27:12] (03CR) 10Alex Monk: "Should probably get rid of articlefeedbackv5-bucket5-wellwritten-label as well, which also became unused in Ic99ba850" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/86092 (owner: 10Matthias Mullie) [12:27:50] (03CR) 10Alex Monk: "Looks like you should've removed a couple of messages with this, this has been done in Idd0e93e1" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/3917 (owner: 10Reha Sterbin) [12:35:59] (03CR) 10Nikerabbit: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88998 (owner: 10Zfilipin) [12:52:05] (03CR) 10Zfilipin: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88998 (owner: 10Zfilipin) [13:05:06] (03CR) 10Matthias Mullie: [C: 032] Reply adjustments, especially for tangents. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89768 (owner: 10Werdna) [13:05:23] (03Merged) 10jenkins-bot: Reply adjustments, especially for tangents. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89768 (owner: 10Werdna) [13:07:14] (03Abandoned) 10coren: Changed FOR UPDATE handling in Postgresql [core] - 10https://gerrit.wikimedia.org/r/69767 (owner: 10Parent5446) [13:08:50] (03CR) 10Matthias Mullie: "Added Siebrand to the patch." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/86092 (owner: 10Matthias Mullie) [13:14:06] (03CR) 10Siebrand: [C: 031] "Looks like the message is no longer in the i18n.php file, so the removal of this key was apparently accidentally omitted when the entry wa" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/86092 (owner: 10Matthias Mullie) [13:22:29] (03PS1) 10Siebrand: Create consistent return point [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89818 [13:22:30] (03PS1) 10Siebrand: Ensure variables are defined [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89819 [13:22:31] (03PS1) 10Siebrand: Declare visibility on class properties [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89820 [13:22:32] (03PS1) 10Siebrand: Declare class properties, update docs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89821 [13:22:45] Krenair: Have a few more. [13:29:06] (03CR) 10Alex Monk: [C: 032] Create consistent return point [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89818 (owner: 10Siebrand) [13:29:19] (03Merged) 10jenkins-bot: Create consistent return point [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89818 (owner: 10Siebrand) [13:30:58] * siebrand greets jorm. [13:31:15] up early; 6:30. [13:36:34] php > require( '*.php' ); [13:36:35] Warning: require(*.php): failed to open stream: No such file or directory in php shell code on line 1 [13:36:35] :-((( [13:52:41] (03CR) 10Cmcmahon: [C: 04-1] "on reflection I'm going to suggest that the TODOs here have some issues." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89389 (owner: 10Spage) [14:14:04] (03CR) 10Zfilipin: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [14:21:43] (03CR) 10Cmcmahon: [C: 032] "documentation" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88998 (owner: 10Zfilipin) [14:22:39] (03PS2) 10Cmcmahon: Documented Jenkins jobs for Flow [qa/browsertests] - 10https://gerrit.wikimedia.org/r/89228 (owner: 10Zfilipin) [14:23:14] (03CR) 10Cmcmahon: [C: 032] "documentation" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/89228 (owner: 10Zfilipin) [14:33:21] (03CR) 10Alex Monk: [C: 032] Remove message 'articlefeedbackv5-error-email' from ArticleFeedbackv5.php [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/86092 (owner: 10Matthias Mullie) [14:33:48] (03Merged) 10jenkins-bot: Remove message 'articlefeedbackv5-error-email' from ArticleFeedbackv5.php [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/86092 (owner: 10Matthias Mullie) [14:37:03] (03PS7) 10Zfilipin: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [14:37:09] (03PS3) 10Cmcmahon: Update browsertests for string change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89389 (owner: 10Spage) [14:39:51] (03CR) 10Alex Monk: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [14:42:47] (03CR) 10Alex Monk: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [14:47:05] (03PS1) 10Manybubbles: Include wordCount and byteSize in result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89832 [14:51:39] (03PS1) 10Manybubbles: Update README for --forceUpdate [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89833 [14:56:10] (03CR) 10Zfilipin: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [14:58:09] [14:58:40] has anybody been maintaining mwdumper? i kinda dropped it years ago :) [14:58:58] Last I heard, no. That's why I was just sorta hopin'... [14:59:00] occcasionally someone pokes at it [14:59:03] :( [14:59:13] I have some c tools ... not cross platform though [14:59:34] I'd have to learn java, newfangled stuff :-P [14:59:40] *shudder* [14:59:46] might be easier to make the c build cross platform ;) [14:59:59] [15:00:50] (03CR) 10Zfilipin: [C: 04-1] "(3 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [15:01:14] Well, apparently MWDumper worked for a gentlecritter mirroring the de.WT. [15:02:44] (03CR) 10Matthias Mullie: [C: 031] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89611 (owner: 10Werdna) [15:02:48] (03PS3) 10Matthias Mullie: Reduce edit form latency and work around bug 55682 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89611 (owner: 10Werdna) [15:03:00] (03CR) 10Matthias Mullie: [C: 032] Reduce edit form latency and work around bug 55682 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89611 (owner: 10Werdna) [15:03:09] (03Merged) 10jenkins-bot: Reduce edit form latency and work around bug 55682 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89611 (owner: 10Werdna) [15:03:39] (03CR) 10Reedy: [C: 032] Update Wikibase with fix for site link editing [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89715 (owner: 10Aude) [15:03:54] (03CR) 10Reedy: [V: 032] Update Wikibase with fix for site link editing [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89715 (owner: 10Aude) [15:04:10] Apergos: any advice I should be giving to people who want to import/process wiktionary dumps? it's about the most common one I run into. [15:04:56] what platform are they on? [15:05:07] are they importing the whole dump into a new wiki? [15:05:20] cause I have tons of advice, some of it maybe even good :-P [15:05:21] Usually linux, and usually yes. [15:05:34] ok well I think my c tools are good enough [15:05:41] but no warranty etc... [15:05:42] see [15:05:55] http://meta.wikimedia.org/wiki/Data_dumps/Import_examples [15:06:04] [15:06:55] there's a perl script around listed under import tools (if you go back to the main dumps page on meta) [15:07:13] which is another option, it was good with 1.19, not sure if it's been updated for mw1.20 [15:07:34] mwdumper was good for 1.19 too I think, the only thing is non utf8 in old revisions sometimes [15:08:57] The person was importing de.WT, which almost certainly has some issues in old revisions. [15:09:38] (03CR) 10Siebrand: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [15:17:27] (03PS1) 10Hashar: settings injected for MediaWiki [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 [15:18:39] (03PS2) 10Hashar: settings injected for MediaWiki [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 [15:20:14] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [15:26:28] Apergos: the mwdump import succeeded with 1.21, as an aside note. [15:27:06] great [15:27:21] hey maybe you want to note that on the page for that tool?? [15:27:22] :-) [15:30:03] Heh. They're currently complaining that there are content issues. [15:30:13] So I am introducing them to your method. [15:30:30] (03PS1) 10Hashar: extension: set MW_INSTALL_PATH to WORKSPACE when unset [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89838 [15:30:32] (03PS1) 10Hashar: inject $wgWikimediaJenkinsCI = true [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89839 [15:31:24] (03CR) 10Hashar: "Ported to integration/jenkins.git with https://gerrit.wikimedia.org/r/#/c/89838/ . Same change-id I5ad86e694963098f2a98cbca0abec9eed29bc9c" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89168 (owner: 10Hashar) [15:31:52] (03CR) 10Hashar: "Ported to integration/jenkins.git with https://gerrit.wikimedia.org/r/#/c/89839/ . Same change-id Ice52170ee507a34d15316580ad6be3ba83f01a0" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89710 (owner: 10Hashar) [15:32:11] (03CR) 10Hashar: [C: 032] inject $wgWikimediaJenkinsCI = true [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89839 (owner: 10Hashar) [15:32:16] (03CR) 10Hashar: [C: 032] extension: set MW_INSTALL_PATH to WORKSPACE when unset [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89838 (owner: 10Hashar) [15:32:39] (03PS3) 10Hashar: settings injected for MediaWiki [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 [15:32:53] (03CR) 10Hashar: [C: 032] settings injection for MediaWiki [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 (owner: 10Hashar) [15:33:09] (03CR) 10Hashar: [V: 032] settings injection for MediaWiki [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89837 (owner: 10Hashar) [15:33:15] (03PS2) 10Hashar: extension: set MW_INSTALL_PATH to WORKSPACE when unset [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89838 [15:33:25] (03CR) 10Hashar: [C: 032 V: 032] extension: set MW_INSTALL_PATH to WORKSPACE when unset [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89838 (owner: 10Hashar) [15:33:29] (03PS2) 10Hashar: inject $wgWikimediaJenkinsCI = true [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89839 [15:33:35] (03CR) 10Hashar: [C: 032 V: 032] inject $wgWikimediaJenkinsCI = true [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89839 (owner: 10Hashar) [15:34:35] (03PS2) 10Manybubbles: Expose changed links in LinksUpdate [core] - 10https://gerrit.wikimedia.org/r/88789 [15:34:50] (03CR) 10Siebrand: [C: 04-1] Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [15:35:25] (03CR) 10Manybubbles: "Removed dumb updates as requested. Makes my life easier." [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [15:36:39] (03CR) 10BryanDavis: "Ping. Getting this approved & merged is a blocker to my HTCP purge activity scheduled for 2013-10-16T20:00Z (tomorrow)." [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [15:37:54] is there any extension that i can install to generate reports on traffic and wanted pages? [15:38:13] (03CR) 10Siebrand: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87556 (owner: 10Siebrand) [15:38:41] (03CR) 10Ori.livneh: [C: 032] "Looks good to me." [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [15:38:42] (03PS6) 10Siebrand: Update docs and declare visibility on class props [core] - 10https://gerrit.wikimedia.org/r/87556 [15:38:53] (03PS4) 10Ori.livneh: Add configurable delay between purgeChangedPages batches [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [15:38:58] (03CR) 10Ori.livneh: [C: 032] Add configurable delay between purgeChangedPages batches [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [15:39:10] ori-l: thanks [15:39:59] thanks. the double-review is because I forgot to rebase first [15:40:11] er, I mean, np :D [15:40:14] it's early. [15:40:30] (03PS1) 10Hashar: integration-jenkins-phplint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89840 [15:40:32] (03PS1) 10Hashar: pep8+pyflakes -> python-jobs job group [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89841 [15:40:40] (03CR) 10Hashar: [C: 032] integration-jenkins-phplint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89840 (owner: 10Hashar) [15:40:44] (03CR) 10Hashar: [C: 032] pep8+pyflakes -> python-jobs job group [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89841 (owner: 10Hashar) [15:41:00] (03CR) 10GWicke: "The SVG in http://math-test2.instance-proxy.wmflabs.org/wiki/Fourier_series is still broken, probably needs to be re-generated after the d" [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [15:41:33] !jenkins integration-jenkins-phplint [15:41:38] !jenkins [15:41:39] (03PS1) 10BryanDavis: Add configurable delay between purgeChangedPages batches [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89842 [15:41:53] !jenkins is https://integration.wikimedia.org/ci/job/$1 [15:41:54] Key was added [15:41:59] !jenkins integration-jenkins-phplint [15:41:59] https://integration.wikimedia.org/ci/job/integration-jenkins-phplint [15:42:44] (03PS1) 10Hashar: trigger integration-jenkins-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89843 [15:42:57] ori-l: Is it reasonable for me to self-approve the backports of that patch to wmf20 and wmf21? [15:43:57] (03PS1) 10BryanDavis: Add configurable delay between purgeChangedPages batches [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89844 [15:43:57] highly unreasonable [15:44:02] and, frankly, offensive [15:44:10] you should be ashamed of yourself [15:44:15] * bd808 hides under desk [15:44:21] no, just kidding, i think it's reasonable [15:44:35] ori-l: I figured. [15:45:07] ori-l: Ha. I don't have +2 on backports [15:45:31] (03CR) 10BryanDavis: [C: 031] "Minor backport needed for https://www.mediawiki.org/wiki/User:BDavis_(WMF)/Notes/Finding_Files_To_Purge#Production_purge" [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89842 (owner: 10BryanDavis) [15:45:34] hrm, probably someone forgot to add you to the deployment group [15:45:38] i might be able to fix that, hang on [15:45:41] (03CR) 10BryanDavis: [C: 031] "Minor backport needed for https://www.mediawiki.org/wiki/User:BDavis_(WMF)/Notes/Finding_Files_To_Purge#Production_purge" [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89844 (owner: 10BryanDavis) [15:46:57] (03Merged) 10jenkins-bot: integration-jenkins-phplint [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89840 (owner: 10Hashar) [15:46:57] (03Merged) 10jenkins-bot: pep8+pyflakes -> python-jobs job group [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89841 (owner: 10Hashar) [15:46:57] (03Merged) 10jenkins-bot: Add configurable delay between purgeChangedPages batches [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [15:49:03] bd808: yeah, you were not in the 'wmf-deployment' group; i added you [15:49:10] you should start receiving a paycheck now too [15:49:25] (just kidding about the second part) [15:49:26] Don't be silly [15:49:35] yeah, no paycheck [15:49:36] ori-l: Excellent. I had been hoping for pay soon [15:49:57] but +2 for backports [15:49:57] in lieu of a salary [15:49:57] ok I'll just move my desk back to make more room for the boxes [15:50:06] but I was told I could keep the stapler [15:50:31] (03CR) 10Hashar: [C: 032] trigger integration-jenkins-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89843 (owner: 10Hashar) [15:51:02] (03CR) 10BryanDavis: [C: 032] "Self-approving backport" [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89842 (owner: 10BryanDavis) [15:51:20] (03CR) 10BryanDavis: [C: 032] "Self-approving backport" [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89844 (owner: 10BryanDavis) [15:51:57] (03Merged) 10jenkins-bot: trigger integration-jenkins-phplint [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89843 (owner: 10Hashar) [15:54:19] (03CR) 10Matthias Mullie: [C: 032] position 'top' for ext.flow.discussion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 (owner: 10Spage) [15:54:55] (03Merged) 10jenkins-bot: Add configurable delay between purgeChangedPages batches [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89842 (owner: 10BryanDavis) [15:55:05] ori-l, Reedy: got a conf call in a few minutes, but my next task on this track will be to have somebody teach me how to push those backported patches out to tin and/or terbium [15:55:25] mash your keyboard [15:55:28] hope for the best [15:55:30] that's not how we roll, bd808 [15:55:32] works well for me [15:56:40] we set you up to fail [15:56:40] then we snicker when you do [15:56:40] good luck! [15:56:40] So mash & fail. Got it [15:56:40] yep. [15:56:40] Hmm [15:56:40] (03PS1) 10Brion VIBBER: bug 55742: fix types in JSON videoinfo output [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/89846 [15:56:40] Aren't I supposed to be in said conf call too? [15:56:40] (03Merged) 10jenkins-bot: position 'top' for ext.flow.discussion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 (owner: 10Spage) [15:56:42] Reedy: My next one is Multimedia [15:56:52] That's a no then :D [15:57:34] Reedy: Core isn't for several hours [15:57:52] I thought there is usually a release/qa meeting [15:58:03] (03CR) 10Matthias Mullie: [C: 032] Notification overlay is partially hidden in RTL language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [15:58:59] Ah. I'm not cool enough to be on calls with greg-g [15:58:59] (03Merged) 10jenkins-bot: Add configurable delay between purgeChangedPages batches [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89844 (owner: 10BryanDavis) [15:59:52] (03Merged) 10jenkins-bot: Notification overlay is partially hidden in RTL language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [15:59:54] (03PS12) 10Gergő Tisza: Add "extended" file metadata to API [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [16:00:31] Either I can't tell time or my meeting just magically moved itself. :) [16:01:27] Always go for the magic answer. It's usually more right. [16:01:28] Years of debugging has taught me the same thing csteipp [16:02:23] Reedy: the syntax is "mash-deploy lkajhsdflkjahdf", right? [16:02:55] So who want's to explain like I'm old how to push/pull changes? [16:03:35] bd808: https://wikitech.wikimedia.org/wiki/How_to_deploy_code is reasonably thorough [16:03:46] (03Draft3) 10PleaseStand: Parser::replaceInternalLinks: fix batching [core] - 10https://gerrit.wikimedia.org/r/89835 [16:03:47] ori-l: Thanks. I'll start reading [16:04:43] bd808: you can start at step 2 [16:04:52] are there any tools for firefox/chrome/some browser that can tell me the subset of css rules that are currently visible in the viewport? Basically i want to set my browser's height to say 1000px and see only the css rules that are used in that first 1000px of the page [16:05:18] so can make better decisions about what does/doesn't need to be loaded 'top' [16:05:21] (03PS4) 10PleaseStand: Parser::replaceInternalLinks: fix batching [core] - 10https://gerrit.wikimedia.org/r/89835 [16:06:52] (03CR) 10Alex Monk: [C: 032] Add GENDER support for 'thanks-error-ratelimited' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88119 (owner: 10Siebrand) [16:06:53] (03Merged) 10jenkins-bot: Add GENDER support for 'thanks-error-ratelimited' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88119 (owner: 10Siebrand) [16:12:03] ori-l: so far so good. fetch & log steps showing what I expect. [16:12:17] * bd808 pauses before rebase…. [16:13:02] Reedy: next week :) [16:15:52] ebernhardson: var selectors = {}; $('*').filter(function () { return $( this ).offset().top <= 1000; }).each(function () { if (this.id) selectors['#' + this.id] = 1; $.makeArray(this.classList).forEach(function (cls) { selectors['.'+cls] = 1; }); }); console.log(JSON.stringify(Object.keys(selectors))); [16:15:59] * bd808 hears no objections so *boldly* rebases [16:16:25] ori-l: excellent, thanks! [16:16:54] there might be better ways to do this, that's just an idea i had :P [16:17:29] ori-l: it had occured to me a bit of js would probably do the trick, i suppose i was just being lazy to see if someone else already wrote it :) [16:19:55] Reedy, ori-l: I only need this change on terbium. Seems like `sync-file` os overkill, no? [16:20:04] s/os/is/ [16:21:12] It is, sort of [16:21:28] You could just run sync-common on terbiu [16:21:29] m [16:21:43] I wouldn't worry about it though [16:22:23] Reedy: So sync-file for practice? [16:22:30] Yeah [16:24:57] (03CR) 10CSteipp: [C: 04-1] "Code looks ok, but can we rename the function to make sure someone doesn't accidentally base their access control decision on this?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89107 (owner: 10Aaron Schulz) [16:31:56] (03CR) 10Trevor Parscal: [C: 032] Vector: New beta module with new typography styles [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [16:33:28] gwicke: would like to talk to you about flow and parsoid usage, perhaps we could grab lunch later to figure out how integration can work best? [16:33:32] (03CR) 10Trevor Parscal: "Disclaimer: The styling choices within this patch do not necessarily reflect the opinion if it's reviewer, and should not be misconstrued " [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [16:34:32] TrevorParscal: :-D [16:34:45] (03Merged) 10jenkins-bot: Vector: New beta module with new typography styles [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [16:38:42] brion, YuviPanda: I have heard rumours of twig! :D [16:41:57] mwalker: keep it quiet :P [16:42:57] mwalker: idea is to try it out in an extension or two then move it to core eventually [16:44:48] YuviPanda: don't know what y'all's plans are; but you might be able to adapt https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FFundraisingEmailUnsubscribe/73eabca5edb9f578ebf299ac222d3a3613784e53/includes [16:45:01] mwalker: yeah, I have an uncommited copy of that in one of my extension repos [16:45:16] shiney [16:45:21] (03CR) 10Matthias Mullie: [C: 031] Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [16:45:44] (03PS3) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [16:47:29] (03CR) 10MarkAHershberger: "Adapted the useDatabase=flag for a couple more spots so installer would work." [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [16:48:08] (03CR) 10jenkins-bot: [V: 04-1] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [16:48:49] (03CR) 10MarkAHershberger: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [16:50:19] (03CR) 10PleaseStand: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89835 (owner: 10PleaseStand) [16:50:27] (03PS1) 10Aaron Schulz: Removed excess subpage parameter from links [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89851 [16:53:01] (03PS1) 10Yuvipanda: Add special page to list all running campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89853 [16:53:08] brion: ^ [16:53:58] @seen moogsi [16:53:58] !seen moogsi [16:53:58] YuviPanda: Last time I saw moogsi they were quitting the network with reason: Ping timeout: 256 seconds N/A at 9/13/2013 10:33:36 PM (31d18h20m22s ago) [16:53:59] Did you mean @seen moogsi? [16:54:08] heh [16:54:42] hey #-dev - does anyone remember off the top of there head where wfLogWarning goes on the cluster? [16:56:28] manybubbles: ori-l would know, i think [16:56:43] i'm planning on adding a manual page for UploadStash, which page title would be better, Manual:UploadStash or Manual:UploadStash.php? [16:57:05] fluorine [16:57:05] manybubbles: ^ [16:57:17] ori-l: but which file? [16:59:33] dan-nl: former, i guess [16:59:50] manybubbles: hmm, might not be enabled [16:59:56] it goes to $wgDebugLogFile [17:00:11] which is only enabled for test & test2, it seems [17:00:15] grr [17:00:27] it looked to me like that is how you are supposed to log warnings [17:00:39] I'd love to see the warnings I log [17:01:51] YuviPanda: thanks, i prefer that one as well [17:03:18] (03CR) 10Chad: [C: 032] Update README for --forceUpdate [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89833 (owner: 10Manybubbles) [17:03:30] (03Merged) 10jenkins-bot: Update README for --forceUpdate [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89833 (owner: 10Manybubbles) [17:04:43] (03PS1) 10Aaron Schulz: Fixed use of message that does not exist [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89855 [17:04:58] spagewmf: alright S -- I'm going to be bold and merge your vform patch [17:05:00] (03PS4) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [17:05:26] dan-nl: :) [17:05:36] wooo mwalker! [17:05:49] :D [17:05:51] manybubbles: as a stop-gap you can push a wmf-config change that adds $wgHooks['Debug'] = function ( $text ) { if ( preg_match( '/search/i', text ) wfDebugLog('search-debug', $text ); }; [17:06:02] (03CR) 10MarkAHershberger: "hrm... now Special:Gadgets is redlinked, but -- w00! -- parsing without DB access works!" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [17:06:15] ori-l: I'll give it a shot [17:07:45] ori-l: I just need it for one wiki - any objections to me just turning on debug logging for that wiki entirely? [17:07:48] (03CR) 10Siebrand: "The links are red because the extensions are not yet installed, and so the special pages are not registered. Don't know if you can get aro" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [17:07:54] (03CR) 10jenkins-bot: [V: 04-1] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [17:08:28] manybubbles: i'd ask Reedy [17:09:01] might depend on the size of the wiki [17:09:13] Reedy: ^^ enwikisource in this case [17:09:24] oh, that's probably fine [17:10:34] brion dearest, think you'll have time for MultimediaViewer review soon? [17:13:07] is there any way to force the mediawiki installer when it is already installed? (Bug: 55589) [17:13:55] (03CR) 10Chad: [C: 04-1] "(2 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89832 (owner: 10Manybubbles) [17:14:53] jdlrobson: mv LocalSettings.php /tmp [17:15:07] YuviPanda: that easy huh? :) thanks [17:15:17] jdlrobson: :) [17:16:30] Reedy: do you have time to review some massmessage patches? [17:16:49] (03PS5) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [17:16:57] brion: I've set myself an alarm at 2AM, and going to force myself to sleep there [17:16:58] *then [17:17:28] (03CR) 10MarkAHershberger: "Might break for languages with variants" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [17:19:49] (03CR) 10jenkins-bot: [V: 04-1] Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [17:19:51] (03PS3) 10Legoktm: Add $wgAllowGlobalMessaging to allow global messaging [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 [17:20:24] (03CR) 10Bsitu: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89332 (owner: 10Bsitu) [17:20:48] (03CR) 10Legoktm: "PS3: Rebase" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [17:21:29] (03PS6) 10Mwalker: Add vform format to HTMLForm, use in PasswordReset [core] - 10https://gerrit.wikimedia.org/r/65346 (owner: 10Spage) [17:23:07] (03CR) 10Mwalker: [C: 032 V: 032] "PS6 was a rebase -- All that was required was to regenerate the CSS." [core] - 10https://gerrit.wikimedia.org/r/65346 (owner: 10Spage) [17:23:18] (03CR) 10Chad: "I hate when we check in serialized files like this. They're impossible to review. :\" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [17:23:36] ah crap -- hope I didn't just break the build -- didn't mean to V+2 that [17:26:08] ebernhardson: yes, lets grab lunch today [17:26:50] (03CR) 10MarkTraceur: [C: 04-1] "Use iiextmetadatalang=de e.g." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 (owner: 10MarkTraceur) [17:27:05] gwicke: sounds good, i'll drop by your desk around noon [17:27:22] (03CR) 10Jdlrobson: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [17:28:29] (03CR) 10Chad: [C: 04-2] "I think we should nuke all of these files in serialized/ and store them as json. Not only is it easier to read and review by humans (and s" [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [17:30:12] (03CR) 10Aaron Schulz: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [17:31:12] (03PS1) 10Kipcool: Special:ExportTSV accessible to anyone [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/89861 [17:31:54] (03CR) 10Kipcool: [C: 032 V: 032] Special:ExportTSV accessible to anyone [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/89861 (owner: 10Kipcool) [17:33:12] (03PS3) 10Manybubbles: Expose changed links in LinksUpdate [core] - 10https://gerrit.wikimedia.org/r/88789 [17:33:31] (03CR) 10Manybubbles: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [17:34:01] (03CR) 10PleaseStand: "Chad: As I noted in Ifb885902, some Linux distributions package the JSON extension separately, and at least the environmental checks have " [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [17:36:18] manybubbles: wow, what happened? [17:36:29] git add . [17:36:31] ...... [17:36:35] nuking stuff now [17:36:40] * YuviPanda sings praise of git commit -p [17:37:32] it happens when you "just fix something small".... [17:41:35] who has tests/multiversion/MWMultiVersionTest.php with uncommitted change on tin?? [17:43:31] (03PS1) 10Anomie: Fix onUserLoadFromSession and pending consumers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89865 [17:44:14] (03PS4) 10Manybubbles: Expose changed links in LinksUpdate [core] - 10https://gerrit.wikimedia.org/r/88789 [17:44:50] Aaron|home and ^d: removed the crazy crap. [17:44:52] (03CR) 10Chad: "I'd take an unlocalized installer over serialized php." [core] - 10https://gerrit.wikimedia.org/r/76663 (owner: 10MarkAHershberger) [17:47:07] (03CR) 10EBernhardson: "This does rework the recursion code, but it still appears that we do separate recursions for each type of thing?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [17:49:58] (03CR) 10Aaron Schulz: [C: 032] Expose changed links in LinksUpdate [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [17:52:01] (03CR) 10Aaron Schulz: [C: 032 V: 032] Fix onUserLoadFromSession and pending consumers [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89865 (owner: 10Anomie) [17:52:59] (03CR) 10Bartosz Dziewoński: "I can't reproduce the issue. What is this patch even supposed to fix?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [17:53:13] (03Merged) 10jenkins-bot: Expose changed links in LinksUpdate [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [17:58:27] MatmaRex, in RTL languages opening the notification overlay would show half of it with the other half off the screen [18:00:00] MatmaRex, it might not occur on all screen resolutions... [18:02:58] Krenair: the screenshot looks broken to me [18:03:06] Krenair: the personal bar is not flipped on it [18:05:29] andre__, "The attachment is not viewable in your browser due to security restrictions enabled by your Bugzilla administrator." why can we not view png files? [18:05:56] Krenair: there's a bug for that [18:06:09] two, in fact, one security, one not [18:06:49] i don't have access to the security one, but i think it's basically well-intentioned paranoia :) [18:07:08] link? [18:07:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 [18:12:02] jdlrobson: Yo dawg I herd you wanted to deploy something https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment [18:13:22] WAS IT APPROVED BY FEATURES? [18:13:24] (just kidding) [18:13:50] :D [18:14:06] YuviPanda: We're not telling product [18:14:08] Ssshhhhh [18:14:15] gj marktraceur [18:14:29] <^d> I don't tell anyone. I just sync the code with vague log messages ;-) [18:14:29] * marktraceur collapses in giggles, is surely giving our plan away [18:14:43] !log updating stuff [18:14:44] There is no such key, you probably want to try: !anonnotice, !api, !chansearch, !cms, !debug, !errors, !gitaccount, !logo, !revdelete, !sal, !sharedlogins, !sqllog, !sul, !tautology, !htmllogs, !logs, !skinning, [18:14:54] !log is 'Logged the message, master' [18:14:55] Key was added [18:14:57] :D [18:15:06] scap "Breaking the cluster" [18:15:09] <^d> !log del [18:15:09] Successfully removed log [18:15:15] fine fine, it'll cause confusion [18:15:16] <^d> !log is Wrong channel, try again. [18:15:16] Key was added [18:15:45] ^d: hmpf, look at you, adding useful messages [18:15:54] gone mellow in your old age! [18:16:01] plop YuviPanda [18:16:11] scap "Reverting to MediaWiki 1.6" [18:16:14] Nikerabbit: bleep [18:16:48] marktraceur: 1.3 was the bug [18:17:24] Nemo_bis: NO U [18:17:31] scap "Migrating to Drupal" [18:17:50] scap "Switching to IIS5.1" [18:18:05] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89610 (owner: 10PleaseStand) [18:18:28] scap "Surely our PostGres support is good enough by now..." [18:18:49] scap "Switching to sqlite" [18:19:03] FOR PERFORMANCE [18:19:09] (justify any change) [18:19:21] "Deleting includes/ for performance" [18:19:43] <^d> Maybe we should delete all the css files. [18:19:47] <^d> Surely plain pages will be faster. [18:19:49] Yeeeesss [18:20:01] <^d> It works for Craigslist ;-) [18:20:04] ^d: let's delete all the PHP files [18:20:14] Those are the ones that take longest to run! [18:20:18] indeed [18:20:24] <^d> So if we're deleting the PHP and the CSS, we're left with JS. [18:20:26] CSS and JS have shortest execution times on apaches [18:20:29] <^d> That is now calling dead APIs. [18:20:36] well, Parsoid won't be dead [18:20:41] Yeah [18:20:44] enwiki can still revolt [18:20:57] the new android / iOS apps won't be deaed either, since they'll call parsoid [18:21:00] <^d> Contrary to popular belief, we can't run MediaWiki on parsoid alone. [18:21:01] We'll just finish the mock API in Parsoid's test directory, and it will be the not-mock API going forward [18:21:01] Let's delete all the DBs and media uploads. They take up lots of space and most of it isn't used much anyway [18:21:02] we it can still work [18:21:16] let's delete all the developers. [18:21:18] we just don't let the opcode cache go to disk [18:21:22] boom, magic execution [18:21:54] <^d> Platonides: We could implement all of MediaWiki as a PHP extension. [18:21:55] volunteer servers. they parse wikitext in their head [18:22:05] <^d> Then the whole site would just be mediawiki_run(); [18:22:06] <^d> :) [18:22:18] all of mediawiki in wikitext [18:22:19] SELF HOSTING, YO! [18:22:21] even better, the extension could hook php loading [18:22:51] ^d: Extension? Let's just get it merged into PHP itself. [18:23:02] <^d> Let's do it with hhvm instead. [18:23:09] <^d> :) [18:23:12] Yeeees [18:23:17] ^d: vagrant hhvm role? :D [18:23:21] Then you can have FaceWiki [18:23:31] <^d> YuviPanda: That'd be nice ;-) [18:23:35] implement it as a the microprocessor instruction! [18:23:37] marktraceur: didn't we already have facewiki when we made the color of the login button blue? [18:24:02] YuviPanda: I'm sure the designers weren't trying to look like Facebook. [18:24:05] :pokerface: [18:24:32] (now to see if any designers pay attention to this channel or get pinged on "designer") [18:24:42] Apart from like [18:24:44] Isarra [18:24:54] But she doesn't count really [18:25:01] marktraceur: woo, new team member [18:25:03] <^d> designers designers designers. [18:25:03] She's too developer-y [18:25:15] (03PS1) 10Cmcmahon: workaround for URL redirect causes flaky failures [qa/browsertests] - 10https://gerrit.wikimedia.org/r/89870 [18:25:17] marktraceur: well, she hates gerrit [18:25:17] so [18:26:14] (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/89870 (owner: 10Cmcmahon) [18:26:40] YuviPanda: Right, there are levels [18:27:14] marktraceur: no, that's a positive for being too developer-y [18:27:20] Truuuue [18:27:41] YuviPanda: Though she also hates Bugzilla - she plans to overthrow them both [18:27:47] (03CR) 10Aaron Schulz: "Rename to what?" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89107 (owner: 10Aaron Schulz) [18:28:37] (03PS1) 10Cmcmahon: update template config docs [qa/browsertests] - 10https://gerrit.wikimedia.org/r/89872 [18:31:25] (03PS1) 10Jeroen De Dauw: Remove comment which is plainly wrong [core] - 10https://gerrit.wikimedia.org/r/89873 [18:31:38] (03PS5) 10PleaseStand: Parser::replaceInternalLinks: fix batching [core] - 10https://gerrit.wikimedia.org/r/89835 [18:32:33] (03CR) 10Bartosz Dziewoński: [C: 032] Remove comment which is plainly wrong [core] - 10https://gerrit.wikimedia.org/r/89873 (owner: 10Jeroen De Dauw) [18:32:50] THE FASTEST MERGE. [18:33:14] MatmaRex: I'm almost certain I've got you beat on some of the older orgcharts patches [18:33:23] Though, selfmerge. Maybe it doesn't count. [18:33:23] oh, no doubt [18:33:33] it took me like a whole minute, somebody must have been faster sometime :) [18:33:43] Oh, I thought it was 8 seconds [18:33:48] Yeah definitely have you there [18:38:44] marktraceur: I don't count because I'm a volunteer. That's basically all there is to it. [18:39:10] (03Merged) 10jenkins-bot: Remove comment which is plainly wrong [core] - 10https://gerrit.wikimedia.org/r/89873 (owner: 10Jeroen De Dauw) [18:39:18] Isarra: I think we're referring to different counts, because you totally *do* count as a volunteer [18:39:37] I mean I don't count as a designer because I'm a volunteer. [18:40:35] Isarra: No, you don't count as a designer because you're tied into all of the cool developer channels [18:40:41] <^d> I've decided I don't count as a developer anymore. Developers create things. I destroy them :p [18:40:51] So it's not a challenge for you to be paying attention here [18:41:05] Is that why 'real' designers ignore everything I say? [18:41:43] ^d: To create things you must destroy them. Therefore what you do is an integral part of development. [18:41:57] Isarra: No, they're too busy, most of them are primaries on like 3-5 projects right now [18:42:30] That's a problem. [18:42:34] Yuuuup [18:43:08] <^d> Solution: let's not design anything. [18:43:15] <^d> We'll just barf out code and see what happens :) [18:43:31] Be part of the solution :) http://hire.jobvite.com/Jobvite/Job.aspx?j=oO8OXfwr&c=qSa9VfwQ [18:43:34] That actually doesn't work as badly as you might expet. [18:44:05] marktraceur: I'm not hireable. I wish I were, but I don't have anything that... [18:44:10] Well, it doesn't work. [18:44:17] Gods bloody dammit. [18:44:59] I don't understand, but I do know it can't hurt to try [18:45:17] You need a resume and a portfolio. Those are two things I simply cannot do. [18:45:21] Believe me, I've tried. [18:45:32] I've tried and I've tried and I've lost my mind, but... [18:45:45] Isarra: I dunno about portfolios, but I can halp with a resume! [18:46:07] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=54181 [18:46:16] ah. answered already. sigh. [18:47:06] marktraceur: Thank you, but it's hopeless. [18:47:36] :( [18:47:50] * marktraceur hugs Isarra [18:47:56] Wellp, open offer [18:53:56] labs down again I suppose? [18:54:47] Nemo_bis: nfs restart [18:55:26] hmm [18:55:27] well [19:00:16] * Isarra sticks a form in grrrit-wm. [19:00:22] fork* [19:00:44] okay it'll stop floodig now [19:00:59] Isarra, to hold it down? or to test if it's properly cooked? [19:01:47] I don't know. It just seemed the thing to do. [19:02:22] ok [19:02:26] (03CR) 10Physikerwelt: [C: 04-1] "Yes I didn't update the caches." [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 (owner: 10Physikerwelt) [19:02:32] okay [19:02:32] that works [19:08:37] (03CR) 10EBernhardson: "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [19:13:15] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [19:16:26] (03PS2) 10Manybubbles: Include wordCount and byteSize in result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89832 [19:21:25] (03PS1) 10AndyRussG: Fix combobox options bug [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/89881 [19:26:22] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89915 (owner: 10L10n-bot) [19:37:23] (03CR) 10Chad: [C: 032] Include wordCount and byteSize in result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89832 (owner: 10Manybubbles) [19:37:26] (03Merged) 10jenkins-bot: Include wordCount and byteSize in result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89832 (owner: 10Manybubbles) [19:40:21] (03Abandoned) 10Raimond Spekking: Localisation updates from http://translatewiki.net. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/89970 (owner: 10L10n-bot) [19:44:48] (03PS1) 10Manybubbles: Update links only when added or removed [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89986 [19:45:58] (03CR) 10Jeroen De Dauw: [C: 032] Fix combobox options bug [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/89881 (owner: 10AndyRussG) [19:45:59] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89915 (owner: 10L10n-bot) [19:46:06] Ooh, 14 changes until 90k [19:47:47] (03PS4) 10Dereckson: Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 [19:47:53] (03CR) 10Manybubbles: [C: 04-1] "Probably should wait to merge this until its required core change is deployed....." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89986 (owner: 10Manybubbles) [19:49:18] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89915 (owner: 10L10n-bot) [19:49:52] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/89928 (owner: 10L10n-bot) [19:50:29] (03Merged) 10jenkins-bot: Fix combobox options bug [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/89881 (owner: 10AndyRussG) [19:54:34] (03PS1) 10Manybubbles: Enable tests for removing links [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89988 [19:55:35] (03CR) 10Manybubbles: [C: 04-1] "Should wait to merge this until we are ready to merge I91396cc3e1120b207c334c47d2e8fd94819de7ff which is after I115f8cf9d3b0a1dba979ceb58b" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89988 (owner: 10Manybubbles) [19:55:51] (03CR) 10jenkins-bot: [V: 04-1] Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 (owner: 10Dereckson) [19:56:19] ori-l: hasher: I'm puzzled by https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/ [19:56:25] https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/2686/console [19:56:28] the warning is still there [19:56:32] but now it passed !? [19:56:54] I was hoping the warning was triggered by some race condition (that at least would've made sense) [19:57:11] but it is consistent, but the failure is ... what? [19:57:13] I just assumed that Jenkins only voted -1 if the lint error referenced a file that the changeset touched [19:57:34] but I don't know that that's actually the case [19:58:13] you know what would be awesome? being able to put "wiki/User:Foo" as reviewer into a gerrit change and having a bot message pasted on their talk page on meta [19:59:08] manybubbles: re: warnings, can't you just use a dedicated log group, like wfDebugLog( 'cirrus-warning', 'something looks funny' ) ? [19:59:52] manybubbles: if you want a dedicated log file and the standard wfLogWarning behavior, you could have a CirrusSearch::warn that calls both [20:00:00] ori-l: I suppose the problem is more that the function is documented as being the way to log warnings in production. if it isn't the way to do that then it shouldn't be documented that way. [20:00:44] ori-l: I can switch to CirrusSearch-warning or something if it is the right thing to do [20:00:44] manybubbles: right [20:00:55] yes [20:05:50] (03PS2) 10BryanDavis: Added a "syncviadelete" param to copyFileBackend script [core] - 10https://gerrit.wikimedia.org/r/78969 (owner: 10Aaron Schulz) [20:08:04] (03CR) 10Brion VIBBER: [C: 032] "Seems to work. This'd be prettier with a Pager instance to manage the pagination links, but that can be added later. :)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89853 (owner: 10Yuvipanda) [20:08:27] (03PS5) 10Dereckson: Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 [20:08:30] (03CR) 10BryanDavis: [C: 031] "I read through the code and didn't see any obvious mistakes, but I don't know how to test it." [core] - 10https://gerrit.wikimedia.org/r/78969 (owner: 10Aaron Schulz) [20:09:04] (03CR) 10jenkins-bot: [V: 04-1] Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 (owner: 10Dereckson) [20:09:20] (03Merged) 10jenkins-bot: Add special page to list all running campaigns [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89853 (owner: 10Yuvipanda) [20:09:24] ori-l: nope, that's not the case. [20:10:20] (03PS1) 10Krinkle: mediawiki.Title: Fix doc reference error [core] - 10https://gerrit.wikimedia.org/r/89991 [20:12:10] (03PS6) 10Dereckson: Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 [20:18:19] (03PS3) 10MarkTraceur: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 [20:19:13] (03PS1) 10Gerrit Patch Uploader: In maintenance/postgres/tables.sql, the profiling table should be defined like this: [core] - 10https://gerrit.wikimedia.org/r/89995 [20:19:55] (03CR) 10jenkins-bot: [V: 04-1] Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 (owner: 10Dereckson) [20:19:58] (03PS3) 10MarkTraceur: Add extmetadata to the ForeignAPIFile iiprops [core] - 10https://gerrit.wikimedia.org/r/88889 [20:21:45] (03CR) 10Siebrand: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89853 (owner: 10Yuvipanda) [20:21:47] (03PS1) 10Chad: Expose changed links in LinksUpdate [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89996 [20:22:33] (03PS2) 10Aaron Schulz: Removed excess subpage parameter from links [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89851 [20:22:38] (03PS1) 10Chad: Expose changed links in LinksUpdate [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89997 [20:22:58] siebrand: sorry, missed commiting. I swear i added them. [20:23:04] putting up now [20:23:33] (03CR) 10Manybubbles: [C: 04-1] "I think we just merged this" [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89996 (owner: 10Chad) [20:24:06] ori-l: for example, https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck/2650/console also passed, the very commit changing mw.Title. [20:24:35] I wonder if we've been missing errors elsewhere. Strange [20:24:54] it doesn't always pass on errors, it did fail here and there . really strange [20:24:55] ^demon|lunch: I think something isn't working with your changes [20:25:15] <^demon|lunch> Hm? [20:25:27] <^demon|lunch> Which changes are these? [20:27:11] (03CR) 10Chad: "We did to master..." [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89996 (owner: 10Chad) [20:27:19] (03PS1) 10Yuvipanda: Add missing qqq for messages added in I5e05c53acb04deb93f4eaad2604a75d2ec3d1e3d [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89999 [20:27:22] siebrand: brion ^ [20:27:45] yay qqq [20:27:47] <^demon|lunch> hashar: Quick question. Does jenkins-bot ever vote in the code review category? [20:28:02] (03CR) 10Brion VIBBER: [C: 032] Add missing qqq for messages added in I5e05c53acb04deb93f4eaad2604a75d2ec3d1e3d [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89999 (owner: 10Yuvipanda) [20:28:06] (03Merged) 10jenkins-bot: Add missing qqq for messages added in I5e05c53acb04deb93f4eaad2604a75d2ec3d1e3d [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89999 (owner: 10Yuvipanda) [20:28:08] ^demon|lunch: let me check [20:28:17] bots don't get a vote [20:28:20] this is a human's world [20:28:27] yeah hmm [20:28:29] <^demon|lunch> He votes verified :) [20:28:36] we eventually got tired of voting so we automatized the process :D [20:28:36] (03CR) 10Manybubbles: [C: 031] Expose changed links in LinksUpdate [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/89996 (owner: 10Chad) [20:29:11] ^demon|lunch: so it does vote code-review 0 on success/failure [20:29:20] ooh, google maps on iOS now supports hebrew and arabic [20:29:29] random update notification of the day \o/ [20:29:30] <^demon|lunch> hashar: Why bother with 0? [20:29:40] * brion crawls back to -mobile [20:29:54] ^demon|lunch: I think it was to reset its CR score. Some pipelines used to vote CR+1 at some point (I think for linting) [20:30:12] (03CR) 10Aaron Schulz: "You can add filebackends to localsettings.php, like:" [core] - 10https://gerrit.wikimedia.org/r/78969 (owner: 10Aaron Schulz) [20:30:23] ^demon|lunch: we could try removing it [20:30:46] ^demon|lunch: ahh I think it was voting CR-2 to prevent changes from being merged, but nowadays votes Verified-1. [20:30:59] I DOSed chad :( [20:31:11] (03CR) 10Manybubbles: [C: 031] Expose changed links in LinksUpdate [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89997 (owner: 10Chad) [20:31:59] hashar: don't make him swap :( [20:32:14] (03CR) 10Anomie: [C: 032] Removed excess subpage parameter from links [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89851 (owner: 10Aaron Schulz) [20:32:20] (03Merged) 10jenkins-bot: Removed excess subpage parameter from links [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89851 (owner: 10Aaron Schulz) [20:32:49] (03PS7) 10Dereckson: Add DROP INDEX support to DatabaseSqlite::replaceVars method [core] - 10https://gerrit.wikimedia.org/r/40281 [20:35:05] <^demon|lunch> hashar: Would kinda be nice. If it doesn't have permission to vote in the category it'll get greyed out. [20:35:15] <^demon|lunch> Which would be a little more intuitive imho [20:35:20] <^demon|lunch> Not urgent tho. [20:35:35] (03PS1) 10Gerrit Patch Uploader: Patch to add e-mail notification reference to the Watchlist preference tab [core] - 10https://gerrit.wikimedia.org/r/90002 [20:35:57] ^demon|lunch: will do tomorrow [20:36:06] <^demon|lunch> Yeah ping me and we'll have a look [20:36:28] woot [20:36:34] why does https://git.wikimedia.org/commit/mediawiki%2Fcore/3731c226018015c64edf9f143b9e5a9045bf79ea go to the main page [20:36:37] it's from https://gerrit.wikimedia.org/r/#/c/90002/ [20:38:36] (works now. yay slow replication, i guess) [20:40:00] (03CR) 10Bartosz Dziewoński: [C: 04-1] "You should link to the appropriate tab, not to the special page (that's just a quick look)." [core] - 10https://gerrit.wikimedia.org/r/90002 (owner: 10Gerrit Patch Uploader) [20:40:25] ^demon|lunch: logged as https://bugzilla.wikimedia.org/show_bug.cgi?id=55757 will do it tomorrow [20:47:35] (03CR) 10Dereckson: "PS7: rebased. Test fixed." [core] - 10https://gerrit.wikimedia.org/r/40281 (owner: 10Dereckson) [20:53:45] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/90016 (owner: 10L10n-bot) [20:54:22] (03PS37) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [20:55:06] (03PS38) 10Physikerwelt: Math 2.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/85801 [20:55:39] (03PS1) 10Kaldari: Add support for user gender to revision API [core] - 10https://gerrit.wikimedia.org/r/90024 [20:56:07] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/90016 (owner: 10L10n-bot) [20:56:30] (03Draft2) 10Dereckson: SQLite compatibility for Echo database patches [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87022 [20:57:51] (03PS2) 10Kaldari: Add support for user gender to revision API [core] - 10https://gerrit.wikimedia.org/r/90024 [20:59:27] (03PS3) 10Kaldari: Add support for user gender to revision API [core] - 10https://gerrit.wikimedia.org/r/90024 [21:00:04] (03CR) 10Dereckson: "According the level of feedback in 8 months, this semantic detail doesn't matter." [tools/release] - 10https://gerrit.wikimedia.org/r/40080 (owner: 10Dereckson) [21:02:36] (03Abandoned) 10Dereckson: Update Javanese keymap [extensions/Narayam] - 10https://gerrit.wikimedia.org/r/43483 (owner: 10Dereckson) [21:15:07] (03CR) 10Anomie: "Haven't looked at the code yet. But from the description I really feel like this is kludging something in where it doesn't really fit: the" [core] - 10https://gerrit.wikimedia.org/r/90024 (owner: 10Kaldari) [21:16:34] (03CR) 10MarkTraceur: [C: 04-1] "Crashes when value is an array - ComponentsConfiguration e.g." [core] - 10https://gerrit.wikimedia.org/r/78926 (owner: 10Brian Wolff) [21:21:31] (03PS1) 10EBernhardson: Moderation button styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90027 [21:30:42] (03PS12) 10Hashar: debian-glue macros and jobs [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/71245 (owner: 10AzaToth) [21:30:55] RoanKattouw: I like how Mac's address book applies rather interesting formatting [21:31:18] +31 6 00 00 00 00. but ..also.. +1 (415) 123-4567 [21:31:50] jdlrobson: Fair warning, I may bug you about i18n with lat/long systems sometime in the future [21:32:14] presumably one's formatted for US and the other a generic fallback [21:32:45] I *think* you're the person to ask [21:33:29] (03CR) 10Alex Monk: "See the screenshot on the bug..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [21:35:10] Krinkle: No, that looks like it has country-specific knowledge [21:35:14] Because it knows that '6' is an area code [21:35:17] (03CR) 10Bartosz Dziewoński: "That screenshot is broken, the personal bar is not flipped. Something else must have caused that." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [21:35:39] Presumably if I gave you my landline it would format it as +31 517 NN NN NN or something [21:39:02] RoanKattouw: Indeed, though without +31 and "0" instead, it just becomes a continued sequence without spaces (not "0519" or "(0519")) [21:39:52] so only if you give it a country code, it doesn't seem to default to any formatting. Hm.. actually it does. It formats some US numbers I imported from office wiki without +1 [21:40:09] (03CR) 10Dzahn: [C: 032] Starting a bug summary with ">" would make it purple [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89606 (owner: 10Aklapper) [21:40:41] probably has to do with my OS being set to English, I hope it'll format Dutch numbers without requiring +31 for Dutch people. [21:40:50] .. having set their OS to Dutch. [21:40:51] (03CR) 10Dzahn: [V: 032] Starting a bug summary with ">" would make it purple [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89606 (owner: 10Aklapper) [21:42:27] (03CR) 10Matthias Mullie: "While I did't have it on enwiki (the username & notifications icon are on the right hand side of #p-personal), I did have it in my local s" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [21:44:30] (03CR) 10Dzahn: [C: 032 V: 032] Italicize bug numbers of unconfirmed tickets in "Blocks/Depends on" field. [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/87053 (owner: 10Aklapper) [21:47:03] (03CR) 10Ori.livneh: [C: 032] mediawiki.Title: Fix doc reference error [core] - 10https://gerrit.wikimedia.org/r/89991 (owner: 10Krinkle) [21:49:28] mutante: is the bugzilla logo on http://boogs.wmflabs.org/ real or pun? [21:49:31] (03CR) 10Bartosz Dziewoński: "The personal bar is not supposed to flip that way. If it does, it's a bug in core. Please revert this and fix the real bug." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [21:49:59] (03CR) 10Bartosz Dziewoński: "(Hell, I'll be happy to fix it for you if you tell me how to reproduce it.)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [21:50:01] (03Merged) 10jenkins-bot: mediawiki.Title: Fix doc reference error [core] - 10https://gerrit.wikimedia.org/r/89991 (owner: 10Krinkle) [21:50:08] it's cute [21:50:32] Krinkle: it's real [21:50:37] liked it too [21:51:09] ask andre__ for details [21:53:12] mutante: k. do you know who created it? It should at least say Bugzilla somewhere on a regular (preferably in the logo area, as we do on other projects), and favicon isn't updated yet. [21:53:50] (03CR) 10Dzahn: "i see a diff between contrib/Wikimedia/admin.css and standard/admin.css:" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89795 (owner: 10Aklapper) [21:55:43] Krinkle: afaik andre's girl friend [21:58:33] greg-g: Is it OK for VE to grab an LD window (behind Growth)? [21:59:59] (03CR) 10Dzahn: [C: 031] "all the others are identical though, ack." [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89795 (owner: 10Aklapper) [22:01:23] (03CR) 10Dzahn: [C: 032 V: 032] Remove unused release-notes.css [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/89800 (owner: 10Aklapper) [22:03:14] (03CR) 10Bsitu: "This could be reproduced on master when I update my language setting from en to fa. The top navigation is exactly like the screenshot in " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 (owner: 10Bsitu) [22:07:02] Reedy: what was up with those arbcom vhosts? ServerName arbcom.de.wikimedia.org is twice (where it should be nl) anyways :) [22:07:51] those are wikimedia ones. don't resolve and are dead [22:08:08] as well as being wrong [22:09:23] Reedy: ack, existing arbcom DNS all in wikipedia.org [22:09:48] :D [22:09:54] diediedie [22:10:37] * ebernhardson screams in pain after seeing hooks to SpecialWatchlistQuery look for specific string pieces of the query and then replace them [22:10:58] there is no clean way to work with something like that if multiple extensions are using the same hook :P [22:11:03] That sounds familiar [22:11:20] I had a lot of fun with similar cases when I did the QueryPage refactor [22:11:45] count( $wgHooks['MyHook'] ) [22:12:37] (03CR) 10Aaron Schulz: [C: 032] In maintenance/postgres/tables.sql, the profiling table should be defined like this: [core] - 10https://gerrit.wikimedia.org/r/89995 (owner: 10Gerrit Patch Uploader) [22:12:40] Reedy: Ow [22:13:18] ori-l: Hey so about that minifier cache thing. I figure that the benefit is negligible because these requests very frequently hit Varnish, actual backend requests served from the minifier cache are rare. We also shouldn't be hard-coding thresholds into MW that are based on performance data from WMF's production environment IMO [22:13:20] or has the hooks class got a wrapper? [22:13:25] * Reedy grins [22:13:48] Hooks::isRegistered( 'MyHook' ) will tell you whether it's greater than zero [22:13:53] RoanKattouw: right, that was my point too [22:14:03] So I think that argues for keeping things simple and consistent [22:14:11] Great; just running it by you before I comment on the change [22:14:11] Yeah. [22:14:24] James_F: oh, forgot to add mobile's in there, there's already two [22:14:25] I guess count( Hooks::getHandlers( 'MyHook' ) ) is miiiildly less shitty [22:14:35] RoanKattouw: It's very kind of you to pretend like I know this as well as you do :P [22:14:59] greg-g: Ah, OK. Not really an issue, 'cept that RoanKattouw needs to go to bed at some point (he's Europe-based right now). [22:15:14] sleep? bah [22:15:16] k, one sec [22:15:26] * James_F grins. [22:15:29] James_F: Please, it's RoanKattouw [22:15:31] I'm sure it'll be fine. [22:15:40] marktraceur: … who needs 23 hours a night? [22:15:42] 1am is not that late [22:15:46] ^^ [22:15:51] neither is 3am [22:15:58] Neither is 6am really [22:15:58] I am meeting Timo tomorrow at like 11:15 in a different city, but that should be fine [22:16:01] RoanKattouw: OK, as long as you're OK with it. Don't want to be more of a burden. :-) [22:16:05] I have until like 10:30 to get out of the house [22:16:13] James_F: No it's totally fine [22:16:27] Welcome to another episode of "RoanKattouw plans his day", with your host James_F [22:16:28] I have been getting more than enough sleep recently [22:16:37] RoanKattouw: You're already slipping into Valley-girl ("like…like…like"), which speaks poorly for your level of wakefulness. :-P [22:16:49] (03Merged) 10jenkins-bot: In maintenance/postgres/tables.sql, the profiling table should be defined like this: [core] - 10https://gerrit.wikimedia.org/r/89995 (owner: 10Gerrit Patch Uploader) [22:16:51] I like, like "like" [22:17:02] Like, yuh, like? [22:17:03] * AaronSchulz likes valleygirl [22:17:11] I'm in the middle of nowhere, I sit on my ass all day and there's no noise to distract me or wake me up. Major sleep debt eraser [22:17:20] (in occasional doses only) [22:17:32] RoanKattouw: Are you asking for us to send you to work from the Moon? [22:17:35] haha [22:17:46] No, I was just about to say [22:18:20] I'm ready to be back in the city and not sit in the same house all day with no signs of life outside [22:18:25] :-D [22:18:28] (Yay.) [22:23:14] FFS, Chromium [22:23:30] Refresh when I go to the image directly, but not when I load it in a page [22:24:02] (03PS1) 10Bsitu: Remove redundant

tag from notification & escape topic title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90035 [22:25:11] Reedy: lol, yeah, neither is 9 am. [22:26:08] I've shifted back to 5-ish am though. [22:26:23] ever since I returned from SF last month. [22:26:26] Krinkle: Yeah, you're working the /wrong/ 9-5. ;-) [22:26:45] haha [22:27:24] Krinkle: But remember being somewhere tomorrow at 11:15 lest Roan is unhappy. :-) [22:27:32] that's quite precise actually I hadn't noticed it was 9-5. more like 5-5, but that's incl. dinner and lunch (in that order) [22:27:54] * James_F nods. [22:28:43] it's like our rhythm when in SF. Except with dinner earlier and consistently coming back in the office afterwards until 8pm. [22:28:50] and starting 2 hours later. [22:29:13] (03PS1) 10Hashar: mw-install-sqlite-2 macro using the shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90037 [22:29:15] (03PS1) 10Hashar: mediawiki-core-code-coverage now uses shell installer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90038 [22:29:18] well, no, at the same time actually. like phsically at the same time. [22:29:23] (03CR) 10Hashar: [C: 032] mw-install-sqlite-2 macro using the shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90037 (owner: 10Hashar) [22:29:29] (03CR) 10Hashar: [C: 032] mediawiki-core-code-coverage now uses shell installer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90038 (owner: 10Hashar) [22:30:08] (03Merged) 10jenkins-bot: mw-install-sqlite-2 macro using the shell script [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90037 (owner: 10Hashar) [22:30:24] (03Merged) 10jenkins-bot: mediawiki-core-code-coverage now uses shell installer [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/90038 (owner: 10Hashar) [22:32:56] (03Abandoned) 10Kaldari: Add support for user gender to revision API [core] - 10https://gerrit.wikimedia.org/r/90024 (owner: 10Kaldari) [22:34:52] csteipp: any suggestions for https://gerrit.wikimedia.org/r/#/c/89107/ ? [22:35:07] maybe it could be merged and renamed later, I don't want to bikeshed on that one [22:35:15] (03PS1) 10MarkTraceur: Add creation time to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/90040 [22:35:36] Yeah, we could do that. I haven't come up with a good name yet [22:36:29] (03PS1) 10Dan-nl: assembla/169 ------------ re: #169/assembla - Second source field mapping dissapears [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/90041 [22:41:45] (03PS1) 10Bsitu: Add new method to process a param in escaped format [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90046 [22:43:29] (03PS2) 10Bsitu: Remove redundant

tag from notification & escape topic title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90035 [22:48:43] (03PS1) 10Hashar: mw-install-sqlite: avoid race condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90047 [22:49:00] (03CR) 10Hashar: [C: 032] mw-install-sqlite: avoid race condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90047 (owner: 10Hashar) [22:49:03] (03Merged) 10jenkins-bot: mw-install-sqlite: avoid race condition [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90047 (owner: 10Hashar) [22:49:45] (03PS1) 10MaxSem: Update MobileFrontend to 1.22wmf20 tip [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/90048 [22:50:48] (03PS1) 10MaxSem: Update MobileFrontend to 1.22wmf21 tip [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90050 [22:51:01] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to 1.22wmf21 tip [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90050 (owner: 10MaxSem) [22:52:01] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to 1.22wmf20 tip [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/90048 (owner: 10MaxSem) [22:52:03] (03CR) 10Hashar: "Validated using https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/ as a playground (build 234 and 235)." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/90047 (owner: 10Hashar) [22:52:14] (03PS1) 10EBernhardson: New hook accomidates non-revision rc querys [core] - 10https://gerrit.wikimedia.org/r/90051 [22:53:09] (03PS2) 10EBernhardson: New hook accomidates non-revision rc querys [core] - 10https://gerrit.wikimedia.org/r/90051 [22:53:28] (03CR) 10saper: "I think MySQL's FLOAT is single precision but PostgreSQL is DOUBLE (if precision is not given to FLOAT), but that does not matter much I t" [core] - 10https://gerrit.wikimedia.org/r/89995 (owner: 10Gerrit Patch Uploader) [22:58:57] superm401: LD time, you can go first if you like [22:59:29] RoanKattouw, you can go, we're not quite ready. [23:02:03] OK, I'll get ready and let you know when I'm going [23:08:01] (03CR) 10Bsitu: [C: 032] Moderation button styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90027 (owner: 10EBernhardson) [23:08:13] RoanKattouw & superm401, I actually managed to not deploy the most important fix, so please let me know when you're done:P [23:08:25] OK [23:08:25] (03Merged) 10jenkins-bot: Moderation button styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/90027 (owner: 10EBernhardson) [23:08:27] MaxSem, we're not going today after all. [23:09:20] (03PS1) 10Catrope: Update VisualEditor for cherry-pick of I8cf8418ded [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90055 [23:09:33] (03CR) 10Catrope: [C: 032 V: 032] Update VisualEditor for cherry-pick of I8cf8418ded [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90055 (owner: 10Catrope) [23:10:57] (03PS1) 10MaxSem: Update MobileFrontend to 1.22wmf21 tip [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90056 [23:11:27] (03PS6) 10EBernhardson: Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 [23:12:17] (03PS1) 10saper: Escape backslashes in image metadata [core] - 10https://gerrit.wikimedia.org/r/90057 [23:12:40] (03CR) 10EBernhardson: "Updated per aaron's comments. Wasn't entirely sure what to put in the release notes, this new field will need to be populated on wmf wiki" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [23:12:59] (03PS1) 10MaxSem: Update MobileFrontend to 1.22wmf20 tip [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/90058 [23:13:00] MaxSem: I'm done, and superm401 isn't going, so you're up [23:14:37] (03CR) 10MZMcBride: "Who's responsible for this changeset?" [core] - 10https://gerrit.wikimedia.org/r/90002 (owner: 10Gerrit Patch Uploader) [23:16:19] RoanKattouw, thanks:) [23:16:33] hashar: I see you've done some work on the debian packaging ツ [23:16:37] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to 1.22wmf20 tip [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/90058 (owner: 10MaxSem) [23:16:47] AzaToth: yeah one job managed to build a package [23:16:50] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to 1.22wmf21 tip [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/90056 (owner: 10MaxSem) [23:16:52] AzaToth: got to generalize it :-] [23:16:53] heh [23:17:09] AzaToth: I can't remember what is preventing the completion though :/ [23:17:37] ah yeah [23:17:42] well, take your time, I don't have the energy yet to push you ツ [23:17:44] Zuul triggers the job one after the other [23:18:41] AzaToth: I posted a reply on patchset 11 of https://gerrit.wikimedia.org/r/#/c/71245/ [23:18:49] (03CR) 10jenkins-bot: [V: 04-1] Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [23:18:52] AzaToth: and also updated the commit summary with the issue [23:19:26] "Unable to find a build for artifact copy from: operations-debs-pybal-binaries" [23:20:36] ah that one got fixed [23:20:46] my test ground : https://gerrit.wikimedia.org/r/#/c/84932/ [23:21:12] ah, ok [23:21:32] the artifact search was wrong for the piuparts template [23:21:59] I see4 [23:22:34] so the issue is that Zuul triggers jobs independently [23:22:40] you haven't uploaded that fix? [23:22:55] but the copy artifact would take the last successful build [23:22:58] what do you mean by that? [23:23:40] I set "fallback-to-last-successful: true" as I thought that was the most logical [23:23:49] so if I send 3 changes A,B,C , by the time the 'binaries' job for A is completed, the 'source' job would have an artifact of the change C [23:24:07] and when 'binaries' job for B runs, it will end up fetching the artifact of C [23:24:12] ah [23:24:18] described on https://gerrit.wikimedia.org/r/#/c/71245/ [23:24:36] in commit message [23:25:02] I see [23:25:56] all jobs are sharing the same build parameter ZUUL_COMMIT [23:26:12] that is a merge commit of the patchset against the tip of the branch [23:26:24] (03CR) 10Catrope: [C: 04-2] "Ori, I think you're right. Especially given that the benefit of this change is very small (these requests hit Varnish most of the time), I" [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [23:26:48] so potentially the copy artifact plugin could look up in the other job for the last successful build that had the same ZUUL_COMMIT value [23:27:04] (03Abandoned) 10MaxSem: Don't cache very small minified resources [core] - 10https://gerrit.wikimedia.org/r/86739 (owner: 10MaxSem) [23:28:28] well, I asssume we shouldn't use last successful build then [23:28:56] (03Merged) 10jenkins-bot: Escape backslashes in image metadata [core] - 10https://gerrit.wikimedia.org/r/90057 (owner: 10saper) [23:30:05] AzaToth: ahh the first ever run result https://bugzilla.wikimedia.org/show_bug.cgi?id=36443#c15 :-] [23:30:15] hashar: I assume upstream-build (TriggeredBuildSelector) will point to correct one [23:30:17] comment 16th is a copy paste of above mumbling [23:30:35] AzaToth: except there is no upstream-build anymore [23:30:50] uh? [23:31:02] it is Zuul containg the parent-child dependencies [23:31:06] ah [23:31:09] DarTar: https://meta.wikimedia.org/wiki/Schema:MediaViewer has some changes, d'you think it's looking all right? I could probably start working on the implementation if so. [23:31:12] Jenkins no more has that knowledge [23:31:34] maybe could revert back to have only the source job to be triggered [23:31:36] marktraceur: looking [23:31:37] does zulu know about build number? [23:31:43] (03PS1) 10Cmcmahon: need to log in to have correct link to edit [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90063 [23:31:45] which-build: specific-build [23:31:45] build-number: 123 [23:31:47] then have that job be blocking until all child are complete. [23:32:01] (03PS3) 10Aaron Schulz: New hook accommodates non-revision rc querys [core] - 10https://gerrit.wikimedia.org/r/90051 (owner: 10EBernhardson) [23:32:04] (03CR) 10Cmcmahon: [C: 032] "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90063 (owner: 10Cmcmahon) [23:32:14] (03CR) 10Cmcmahon: "maintenance" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/90063 (owner: 10Cmcmahon) [23:32:19] 'kay [23:32:36] (03CR) 10Aude: "I think it's good to have this in before the 1.22 release cutoff." [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [23:32:51] AzaToth: I don't think Zuul pass the parent job name / build number [23:33:28] marktraceur: lgtm, I'm making some small cosmetic change to make the action field more readable but other than that I think we're good to go. You guys are not interested in filtering by namespace or article, right? If you do, you may want to add pageId and pageNamespace [23:33:33] (03CR) 10Aude: "obviously the issues with test failures needs to be addressed first" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson) [23:33:36] 'kay [23:34:13] DarTar: I don't think so - we might want to separate between thumbnails, galleries, category listings, etc., but right now we don't support anything but thumbnails, so probably not useful [23:39:33] AzaToth: yeah there is a build parameter selector apparently [23:39:54] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Initial commit of the extension [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/89361 (owner: 10Luis Felipe Schenone) [23:41:27] (03CR) 10Aaron Schulz: [C: 032] Add $wgAllowGlobalMessaging to allow global messaging [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [23:41:36] (03Abandoned) 10Dereckson: Fixes stacktrace output when no file context is available. [core] - 10https://gerrit.wikimedia.org/r/88628 (owner: 10Dereckson) [23:41:40] (03Merged) 10jenkins-bot: Add $wgAllowGlobalMessaging to allow global messaging [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [23:42:23] (03PS4) 10Aaron Schulz: Avoid cache issues by showing error messages in content language [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88791 (owner: 10Legoktm) [23:42:28] (03CR) 10Aaron Schulz: [C: 032] Avoid cache issues by showing error messages in content language [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88791 (owner: 10Legoktm) [23:42:37] (03Merged) 10jenkins-bot: Avoid cache issues by showing error messages in content language [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88791 (owner: 10Legoktm) [23:43:36] hashar: how would that help? [23:43:54] (03CR) 10Aaron Schulz: [C: 032] Add type hinting [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89383 (owner: 10Legoktm) [23:43:56] (03CR) 10jenkins-bot: [V: 04-1] Add type hinting [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89383 (owner: 10Legoktm) [23:44:09] - copy-artifact: [23:44:10] which-build: build-param [23:44:11] param: ZUUL_COMMIT [23:44:24] ah [23:44:51] trying [23:45:05] smells a bit magical, but ok [23:46:05] yeah sorry :( [23:47:52] no probs; I can't focus correctly yet, so it's probable I fail to grasp trivial stuff ツ [23:48:42] it is not that trivial :] [23:49:09] apparently the copy artifact plugin let you retrieve artifacts from a job by searching builds matching a specific parameter [23:49:32] since Zuul triggers all the jobs using the same ZUUL_COMMIT, we can use that as a lookup value [23:49:39] ah, ok [23:49:44] this way the binaries job will end up fetching the proper source [23:49:46] hopefully [23:50:10] (03PS2) 10CSteipp: Fixed use of message that does not exist [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89855 (owner: 10Aaron Schulz) [23:50:12] but does all three jobs have the same build-param? [23:50:20] (03CR) 10CSteipp: [C: 032] Fixed use of message that does not exist [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89855 (owner: 10Aaron Schulz) [23:50:42] (03Merged) 10jenkins-bot: Fixed use of message that does not exist [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89855 (owner: 10Aaron Schulz) [23:51:15] (03CR) 10Krinkle: [C: 04-1] "The OOP interface is nice, but as I said Max already:" [core] - 10https://gerrit.wikimedia.org/r/74293 (owner: 10MaxSem) [23:51:16] ehm, forgot project is specified [23:52:54] (03PS3) 10Legoktm: Re-implement parser function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89357 [23:52:55] (03PS2) 10Legoktm: Add type hinting [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89383 [23:54:13] AzaToth: bahh https://integration.wikimedia.org/ci/job/operations-debs-pybal-binaries/13/console [23:54:23] lol [23:54:53] (well, no, because I can't laught out loud atm) [23:55:06] hurts way too much [23:55:14] BUILD_SELECTOR=$BUILD_NUMBER [23:55:15] seriously [23:56:21] where? [23:56:33] that is apparently what I got to pass [23:56:37] hmm [23:56:56] hmm [23:58:39] missing the context I feel [23:59:31] (03PS1) 10Dereckson: Fixes stacktrace output when an internal function is called. [core] - 10https://gerrit.wikimedia.org/r/90067 [23:59:56] (03CR) 10Legoktm: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/86055 (owner: 10MarkTraceur)