[00:00:51] legoktm: you'd probably have to copy/paste the code in mediawiki.inspect.js and modify it [00:01:11] paste it into a user js page, I mean [00:01:28] Yeah, for what Elsie wants [00:01:41] Ugh, that sounds gross. [00:01:46] I can't use a hook or something? [00:01:57] I don't want to duplicate all the logic. [00:02:13] mw.hook('OnResourceLoaderLoadInspectCheckIfElsieNeedsToModifySomething').fire(); [00:02:28] I'll start the RFC [00:02:58] Anyone know what mw.MwEmbedSupport is? [00:03:05] legoktm: the code to generate the inspect data and the call to console.log/console.table should probably be separated [00:03:12] that way you could just get the data and filter it somehow [00:03:23] if you want to file a bug i'll do that [00:03:36] Well, don't you just really need to modify getLoadedModules? [00:04:18] yes [00:04:22] want to submit a patch? :) [00:04:55] gotta go. [00:05:02] Bye. [00:05:15] I do too, I'll work on it when I get back [00:14:08] (03PS5) 10Plavi: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 [01:32:03] (03CR) 10Krinkle: "Note, method name 'addModules' might be a bit confusing since OutputPage and ParserOutput have the same method but work different (those t" [core] - 10https://gerrit.wikimedia.org/r/89475 (owner: 10Bartosz Dziewoński) [01:33:30] (03CR) 10Krinkle: "If you intend to override this from a subclass, perhaps restructure it as getModules() so that you don't repeat the getOutput()->addModule" [core] - 10https://gerrit.wikimedia.org/r/89475 (owner: 10Bartosz Dziewoński) [01:38:48] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88266 (owner: 10Krinkle) [01:38:53] (03PS6) 10Krinkle: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 [01:39:04] (03PS7) 10Krinkle: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 [01:41:45] (03PS1) 10PleaseStand: Installer: Run the LESS compiler for screen.less [core] - 10https://gerrit.wikimedia.org/r/89610 [01:43:40] (03CR) 10Mattflaschen: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [01:47:57] (03CR) 10Mattflaschen: [C: 031] "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [01:56:37] (03PS1) 10Werdna: Reduce edit form latency and work around bug 55682 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89611 [01:56:48] (03CR) 10jenkins-bot: [V: 04-1] Reduce edit form latency and work around bug 55682 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89611 (owner: 10Werdna) [01:58:57] (03CR) 10Mattflaschen: "Also, ProveIt only works in source/wiktext mode, not with VisualEditor." [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [02:01:34] (03PS2) 10Werdna: Reduce edit form latency and work around bug 55682 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89611 [02:33:38] (03PS1) 10Werdna: Fix bug 54936: Redirect most references to Special:Flow through UrlGenerator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89612 [02:34:32] (03PS2) 10Werdna: Fix bug 54936: Redirect most references to Special:Flow through UrlGenerator. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89612 [02:47:19] Anyone here using MediaWiki-vagrant? [02:47:31] I'm having a permissions issue, and want to know if it's specific to my setup. [03:06:29] (03PS10) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [03:11:47] (03CR) 10Ori.livneh: "Should this vary by user ID?" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [03:15:13] (03CR) 10Mattflaschen: "For any of the modules with user= in the URL, I think it needs to. That may just be the user module, but I'm not sure off the top of my h" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [03:15:52] superm401: ori-l uses it. [03:16:24] Yeah, think he might be working on something, though. [03:17:09] Aren't we all. [03:45:18] superm401: permissions issue with what? [03:45:37] legoktm, writing to logs [03:46:22] legoktm, I think I almost have it tracked down. [03:46:29] which logs? [03:47:18] One is /vagrant/logs/mediawiki-debug.log [03:47:34] If you don't mind, I'd appreciate if you run a test script. [03:47:45] It just dumps a bunch of permission data. [03:48:41] http://pastebin.com/7XuduxFu [03:48:49] ok [03:48:54] You can just put it next to index.php in the main directory. [03:49:06] You're running Vagrant, right? [03:49:39] yes [03:49:41] ok [03:50:13] Doh, get_current_user is the owner of the script. [03:50:38] superm401: https://dpaste.de/nKO0/raw/ [03:51:10] Does OAuth require JavaScript? [03:51:32] Elsie, no, it can be implemented in other environments (e.g. Android) [03:52:20] It seems to use a jQuery dialog pop up thing. [03:52:24] I'm not sure why. [03:52:24] I think you can implement it just in HTML and server-side code, though it might be a little kludgy on the front-end. [03:52:35] You're probably thinking of a particular OAuth client library. [03:52:42] I'm using OAuth on MediaWiki.org. [03:52:52] [[mw:Extension:OAuth]], I think. [03:53:19] legoktm, mine is https://dpaste.de/iuk1 , very similar. [03:53:47] Hmm, it has a fallback. [03:53:48] Weird. [03:54:11] So it looks like the scripts are running as www-data which doesn't have write access to the file. [03:54:17] superm401: were you having an MWV issue earlier? [03:54:28] MWV, heh. [03:54:30] ori-l, yeah, I think I've tracked it down though. [03:54:41] Apache doesn't have write access to the log files for me. [03:54:54] It seems to run as www-data:www-data, but the file perms are: [03:55:22] drwxr-xr-x 1 vagrant www-data 4096 Oct 9 09:12 /vagrant/logs/ [03:55:23] -rw-r--r-- 1 vagrant www-data 69275 Oct 14 02:26 /vagrant/logs/mediawiki-debug.log [03:55:33] I think I can fix it by adding group write. [03:55:34] superm401: https://gerrit.wikimedia.org/r/#/c/87445/ [03:56:14] ori-l, I'm at master, which contains that. [03:56:31] oh, that's the mw debug log you're talking about [03:56:34] Are you able to write to /vagrant/logs/mediawiki-debug.log from PHP (running through the web server normally). [03:56:37] not the apache error log [03:57:01] I don't think so, I think I noticed the permission issue at one point but forgot to look into it [03:57:24] what you describe sounds right; let me verify. [03:58:18] ori-l, alright, found an example (http://stackoverflow.com/questions/13169154/cannot-change-permissions-of-folders-within-vagrant-home-folder), so I should have a patch shortly [03:59:00] Vagrant is surely the most annoying fucking upstream ever [03:59:48] I can be fast and loose with patches sometimes, but the Vagrant guy just responds to people pointing out major issues with releases by just hastily making another release [04:00:16] Where does OAuth hide per-app preferences.... [04:02:08] Oh, I see it. [04:04:08] (03CR) 10Krinkle: "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/89413 (owner: 10MarkAHershberger) [04:10:26] (03PS1) 10Gnosygnu: v0.10.1.0 [xowa] - 10https://gerrit.wikimedia.org/r/89614 [04:16:21] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving my own commit" [xowa] - 10https://gerrit.wikimedia.org/r/89614 (owner: 10Gnosygnu) [04:16:59] (03CR) 10Gnosygnu: "approving my own commit" [xowa] - 10https://gerrit.wikimedia.org/r/87994 (owner: 10Gnosygnu) [04:18:08] superm401: anyways, patch would be appreciated [04:18:18] ori-l, yep, it's working, doing final verification. [04:18:31] Basically, I made a separate synced folder for logs, with www-data owning it all. [04:29:10] (03CR) 10Ori.livneh: [C: 032] vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 (owner: 10Krinkle) [04:31:54] (03Merged) 10jenkins-bot: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 (owner: 10Krinkle) [04:32:43] (03PS1) 10Legoktm: Only load RL modules when a tag is being used [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 [04:37:31] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/89608 (owner: 10Ori.livneh) [04:39:25] (03PS1) 10Mattflaschen: Fix logging with a separate dir and www-data as user and group [vagrant] - 10https://gerrit.wikimedia.org/r/89619 [04:40:05] Next up, figuring out why my Redis isn't working. [04:40:15] Should be smoother with full debugging and logging. :) [04:41:58] Krinkle: why avoid '_'? I thought about it and I think it's more idiomatic than 'i', which suggests you care about the index [04:42:43] '_' is often used to discard items you don't care about when unpacking collections, it's common in lisp and python as well, and jquery's use of it suggests it's not unidiomatic in JS either [04:43:55] (03CR) 10Krinkle: [C: 031] "Code looks right, untested though." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89617 (owner: 10Legoktm) [04:44:25] e.g.: name, _, phone = ( 'k. rinkle', '123 foo st.', '+1 123 456') [04:44:31] in python [04:45:30] i think there's reason to prefer it especially for nested calls like this one [04:45:49] you can either use 'i' for the outer loop and 'j' for the inner, which really looks a bit silly since you're using neither [04:46:10] or you can use 'i' twice, which looks like a bug at a glance, since the inner i is shadowing the outer one [04:46:23] with '_' you still get the shadowing but it doesn't look like a bug [04:46:31] since '_' is obviously 'throwaway' [04:49:05] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89608 (owner: 10Ori.livneh) [04:52:00] ori-l: https://code.google.com/p/chromium/issues/detail?id=306915 [04:52:32] did you hear about MatmaRex's issue with console.table in Opera? [04:52:41] ori-l: I don't believe in throwaway variables. Names should be descriptive or at least consistent. I think we talked about last week and you went with 'i'. [04:52:47] (nice report, by the way) [04:54:09] The shadowing is an issue indeed, though not as much as with a for loop since they are both properly scoped. [04:54:27] well, I suppose in case of a for it isn't shadowing but just plain dangerous [04:54:51] anyhow, I don't mind. Just thought I'd mention it and see what you think considering we don't use it elsewhere and you seemed to agree last week. [04:55:07] ori-l: What's in Opera. [04:56:15] window.table is set but just... doesn't do anything. https://bitbucket.org/dstorey/opera-dragonfly-manual/src/12df470b7ce1/console.md#markdown-header-consoletable [04:56:24] er, console.table, rather. [04:56:32] console.table(): doesn't work? :/ [04:56:49] and then below: console.table() broken? awaiting feedback. [04:56:58] ori-l: What version are we talking? [04:57:01] 12 [04:57:49] Right, that's like IE8 from a dev perspective. Supported but not only graceful, especially for developers stuff. [04:58:02] I tweeted @browsehappy that 17 went stable a few days back [04:58:20] well, granted, 13 and 14 don't exist. [04:58:27] 15+ is chromium [04:58:35] (03PS6) 10Ori.livneh: exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [04:59:02] ^ i changed a stray '$exception' into an '$e', since that's the usage elsewhere in the file [04:59:11] OK to merge otherwise, looks good & tested [04:59:21] if you +1 to indicate approval of my amend i'll +2 [04:59:25] yeah, I noticed that as well since my fnr didn't catch it (find n replace) [04:59:35] was going to do a core wide sweep, but this is ok [05:00:25] +1 [05:00:30] (03CR) 10Krinkle: [C: 031] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [05:00:42] (03PS7) 10Ori.livneh: exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [05:00:52] (03CR) 10Ori.livneh: [C: 032] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [05:01:21] what happened to my previous topic? [05:01:25] ori-l: (detached [05:01:41] No idea. Where the hell did that come from? [05:02:01] what was it previously? [05:02:05] ori-l: presumably from you checking it locally in a detached head and git-review using it as branch name (without quoting) [05:02:08] I see it all the time [05:02:25] (03CR) 10Ori.livneh: [C: 04-2] "Blocking Jenkins so that the topic can be fixed." [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [05:02:34] when changed implicitly through a push, gerrit ui doesn't show the history [05:03:11] It had "rl-logException" (just fixed it a sec ago) [05:03:22] same branch as the other commit, I should push the other one as well :) [05:03:28] (03CR) 10Ori.livneh: [C: 032] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [05:05:16] (03Merged) 10jenkins-bot: exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [05:07:37] (03PS1) 10Krinkle: [WIP] exception: Use new MWExceptionHandler::logException in more places [core] - 10https://gerrit.wikimedia.org/r/89621 [05:07:58] (03PS5) 10Krinkle: resourceloader: Rethrow LESS error and let makeModuleResponse handle it [core] - 10https://gerrit.wikimedia.org/r/88645 [05:09:52] (03PS6) 10Krinkle: resourceloader: Rethrow LESS error and let makeModuleResponse handle it [core] - 10https://gerrit.wikimedia.org/r/88645 [05:10:38] (03CR) 10Krinkle: "Changed to not re-throw less' Exception as MException, instead relying on RL now handling it properly per f0386d31835b8f65." [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [05:11:13] (03PS2) 10Ori.livneh: List dependency relationships in mw.loader.inspect() [core] - 10https://gerrit.wikimedia.org/r/89608 [05:11:27] (03CR) 10Krinkle: "Fixed bug 55442." [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [05:12:53] (03PS7) 10Krinkle: resourceloader: Rethrow LESS error and let makeModuleResponse handle it [core] - 10https://gerrit.wikimedia.org/r/88645 [05:13:37] ori-l: at this point the plain text log seems much nicer, especially because of the "" everywhere [05:14:05] should we just drop the use of console.table, then? [05:14:44] Does Firefox have a decent console.table? [05:14:56] Firebug does, but plain FF does not [05:16:42] you know what would be a fun & useful hack? a mediawiki panel in chrome's dev tools, implemented via http://developer.chrome.com/extensions/devtools_panels.html [05:16:55] Yep [05:17:06] ori-l: mediawiki.debug contains a lot of the data [05:17:14] could be exposed from there [05:17:26] though I rarely use mediawiki.debug, when I do, it's great. [05:17:46] $wgDebugToolbar [05:19:28] I wonder if extensions can pass the devtools interface to the page scope [05:20:28] meh, we'd probably want to keep it all inside the plugin so we can update it independently [05:20:31] http://i.imgur.com/4pbYyLo.png [05:20:55] :) [05:21:00] heheh [05:21:15] * James_F grins. [05:21:22] And we have a James! [05:21:32] * James_F reminds the both of you that tomorrow (Krinkle: today) is a holiday. :-P [05:21:46] I'm leaving in 3 hours for amsterdam. [05:22:01] where are you right now? [05:22:13] Lol, that came out slightly too ambiguous. [05:22:26] I'm going to a concert and to the Pixar Expo [05:22:33] ahh [05:22:39] ori-l: Enschede, where I live. Opposite side of the country [05:22:48] 2-3 hour drive [05:23:03] literal from border to the dock. [05:23:08] Krinkle: Have fun. :-) [05:23:35] give or take 10 km, I'll be driving from the near German border (Enschede) to sea [05:23:50] don't drive into the sea :P [05:24:04] I'll be sure to remind the driver hehe [05:24:44] ori-l: yeah, if there's no decent console.table implementation (drunk in chrome, even more broken in Opera 12), we coudl drop that path for now. [05:25:26] ori-l: btw, random thing I found out earlier. document.all (the old old thing) is both an array and a function. [05:25:30] It's quite an interesting little thing [05:25:34] it's also boolean false [05:25:42] what is it? [05:25:44] document.all[1] [05:25:47] document.all(1) [05:25:57] I don't think I've ever encountered it before [05:26:02] if ( document.all ) { 1 } else { 0 } [05:26:08] ori-l: It's from the 90s, IE4 ism [05:26:12] document.images [05:26:13] etc. [05:26:24] to iterate through lacking a better interface at the time. [05:26:53] it's boolean false, NodeList and an accessor function eq() like at the same time [05:27:09] the boolean false is to make sure it doesn't trigger reverse feature tests. [05:27:32] accessor is for old IE code, array is for Netscape/Mozilla code. [05:27:49] what a strange thing [05:28:01] I can imagine creating the function/array hybrid in ecmascript 5 using a getter on a function object. [05:28:28] but the boolean false must be some kind of black hack they invented. [05:30:09] typeof document.all === 'undefined', wat [05:30:14] yeah, that too [05:30:41] it's falsey (undefind) for feature tests, and array/function for code that didn't bother to test first. [05:30:47] amazing what they do for compatibility [05:31:47] https://github.com/dstockwell/blink/blob/52d946ab6ed939fd9912d50e8097b27cecb14699/LayoutTests/fast/dom/collection-null-like-arguments-expected.txt [05:31:54] .item() [05:31:57] even more [05:32:35] document.all.tags() [05:32:45] https://github.com/dstockwell/blink/blob/master/LayoutTests/fast/dom/document-all-tags.html [05:32:47] wow [05:33:26] could be a nice riddle [05:33:38] make this true: x.length && typeof x === 'undefined' [05:33:40] document.all.tags('body').length === 1 [05:34:05] https://github.com/dstockwell/blink/blob/master/Source/core/html/HTMLAllCollection.cpp [05:34:14] wait, that's in the spec? [05:34:24] http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection [05:34:35] well, most of it [05:35:19] spec says arr[index], arr[name], and func(name). not func(index), or being undefined-like [05:35:30] that's still pretty crazy [05:39:26] At least they're standardising which I suppose it nice. just like the craziness in window.navigator [05:39:26] http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#client-identification [05:39:37] it is required by spec to return Mozilla and Gecko there [05:39:50] and taintEnabled/false [05:40:16] they have no definition or meaning :-). Just legacy detection foolers towards the "modern" version. [06:00:09] (03PS1) 10leucosticte: Add PerPageLicense extension. [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 [06:46:55] (03CR) 10MathiasLidal: [C: 031] "(2 comments)" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 (owner: 10Netbrain) [07:12:12] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/PerPageLicense] - 10https://gerrit.wikimedia.org/r/89625 (owner: 10leucosticte) [07:25:11] (03CR) 10Werdna: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [07:26:06] (03PS3) 10Werdna: Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [07:26:08] (03CR) 10jenkins-bot: [V: 04-1] Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [07:27:28] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/89609 (owner: 10Legoktm) [07:28:14] (03PS4) 10Werdna: Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [07:39:20] (03CR) 10Werdna: "I rewrote the recursion code, renamed some functions, messed around with the PostRevision getCreator() thing, moved some formatting code f" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [08:00:40] (03CR) 10Ebrahim: "But arrow messages you've added got deleted on https://gerrit.wikimedia.org/r/#/c/86464/1/CategoryTree.i18n.php and all arrow on Persian w" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO) [08:13:06] (03CR) 10Smuggli: "Thanks for reverting it." [core] - 10https://gerrit.wikimedia.org/r/89391 (owner: 10Spage) [08:14:51] (03CR) 10Ebrahim: "And Hebrew Wikipedia http://he.wikipedia.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Categorytree-expand-bullet" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO) [08:17:26] (03CR) 10Ebrahim: "Is there anyway to command translator bot to don't remove categorytree-expand-bullet and categorytree-empty-bullet from the translations? " [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/86464 (owner: 10L10n-bot) [08:28:11] (03PS1) 10TTO: Revert "Localisation updates from http://translatewiki.net." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/89633 [08:29:36] (03CR) 10TTO: "That bot change needs to be reverted: see my pending revert I810790536fa35c2f9af736c682221fc0d03b4818." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO) [08:33:49] (03PS1) 10Nehagani: test changes, ChangeId: FTH-01 [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89634 [08:41:46] (03PS2) 10Nehagani: test changes, again ChangeId: FTH-01 [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89634 [08:48:00] (03CR) 10TTO: "Fixed in https://gerrit.wikimedia.org/r/#/c/89636/, thanks to Siebrand." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO) [08:48:08] (03PS1) 10Siebrand: Re-add erroneously removed translations [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/89637 [08:48:26] (03CR) 10TTO: "A real link that works: I49e9e4260cf163e4b44e10388c477dd534b4beb2" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/85655 (owner: 10TTO) [08:48:53] (03CR) 10Siebrand: [C: 032] Re-add erroneously removed translations [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/89637 (owner: 10Siebrand) [08:48:55] (03Merged) 10jenkins-bot: Re-add erroneously removed translations [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/89637 (owner: 10Siebrand) [08:49:59] (03Abandoned) 10TTO: Revert "Localisation updates from http://translatewiki.net." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/89633 (owner: 10TTO) [08:50:51] (03CR) 10Nehagani: [C: 04-1] "(1 comment)" [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89634 (owner: 10Nehagani) [08:51:25] (03Abandoned) 10Nehagani: test changes, again ChangeId: FTH-01 [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89634 (owner: 10Nehagani) [10:07:58] (03CR) 10TTO: [C: 031] "Seems legit." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/77491 (owner: 10Rillke) [10:54:35] (03PS1) 10TTO: Refresh Deletereason-dropdown [core] - 10https://gerrit.wikimedia.org/r/89692 [11:00:06] (03CR) 10Nemo bis: [C: 031] ""Broken redirect" is probably not that frequent, but it's valid for any wiki even if they had $wgFixDoubleRedirects set to true, so no har" [core] - 10https://gerrit.wikimedia.org/r/89692 (owner: 10TTO) [11:04:13] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/89693 [11:04:24] (03CR) 10Siebrand: [C: 032 V: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/89693 (owner: 10Siebrand) [11:23:13] (03PS1) 10Siebrand: Use substitution instead of hard-coded terminology [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89695 [11:33:36] (03CR) 10Raimond Spekking: [C: 032] Use substitution instead of hard-coded terminology [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89695 (owner: 10Siebrand) [12:03:15] (03CR) 10Raimond Spekking: [C: 032] Update capitalisation [extensions/Math] - 10https://gerrit.wikimedia.org/r/89699 (owner: 10Siebrand) [12:03:23] (03Merged) 10jenkins-bot: Update capitalisation [extensions/Math] - 10https://gerrit.wikimedia.org/r/89699 (owner: 10Siebrand) [12:36:35] (03PS3) 10Hashar: Document class property and break long lines [core] - 10https://gerrit.wikimedia.org/r/88024 (owner: 10Siebrand) [12:36:41] (03CR) 10Hashar: [C: 032] Document class property and break long lines [core] - 10https://gerrit.wikimedia.org/r/88024 (owner: 10Siebrand) [12:37:44] (03CR) 10jenkins-bot: [V: 04-1] Document class property and break long lines [core] - 10https://gerrit.wikimedia.org/r/88024 (owner: 10Siebrand) [12:40:46] (03Merged) 10jenkins-bot: Document class property and break long lines [core] - 10https://gerrit.wikimedia.org/r/88024 (owner: 10Siebrand) [12:42:47] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [tools/release] - 10https://gerrit.wikimedia.org/r/89413 (owner: 10MarkAHershberger) [12:56:13] (03CR) 10Matthias Mullie: [C: 031] Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [12:59:57] (03CR) 10Alex Monk: [C: 04-1] "Please fix ApiStabilize as well" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/76460 (owner: 10TTO) [13:02:08] (03CR) 10Alex Monk: [V: 032] "You need to Verified+1 and submit in FlaggedRevs, Raimond. Code-Review+2 isn't enough" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89695 (owner: 10Siebrand) [13:02:29] (03CR) 10Alex Monk: "Uh... I mean Verified+2, not +1" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89695 (owner: 10Siebrand) [13:04:37] (03PS1) 10Hashar: mwext-Wikibase-qunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89706 [13:04:49] (03CR) 10Hashar: [C: 032] mwext-Wikibase-qunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89706 (owner: 10Hashar) [13:05:18] (03Merged) 10jenkins-bot: mwext-Wikibase-qunit [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89706 (owner: 10Hashar) [13:06:05] (03CR) 10Matthias Mullie: [C: 032] Fix bug 54936: Redirect most references to Special:Flow through UrlGenerator. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89612 (owner: 10Werdna) [13:06:11] (03Merged) 10jenkins-bot: Fix bug 54936: Redirect most references to Special:Flow through UrlGenerator. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89612 (owner: 10Werdna) [13:09:38] (03CR) 10Bartosz Dziewoński: "Subclasses might want to call addModuleStyles() as well." [core] - 10https://gerrit.wikimedia.org/r/89475 (owner: 10Bartosz Dziewoński) [13:10:41] (03Restored) 10Nehagani: test changes, again ChangeId: FTH-01 [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89634 (owner: 10Nehagani) [13:10:49] (03PS4) 10Nehagani: test changes, again ChangeId: FTH-01 [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89634 [13:11:10] (03CR) 10Anomie: [C: 032] Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [13:11:41] (03PS1) 10Hashar: trigger mwext-Wikibase-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89708 [13:13:10] (03CR) 10Hashar: [C: 032] trigger mwext-Wikibase-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89708 (owner: 10Hashar) [13:13:12] (03CR) 10Bartosz Dziewoński: [C: 032] Refresh Deletereason-dropdown [core] - 10https://gerrit.wikimedia.org/r/89692 (owner: 10TTO) [13:13:16] (03CR) 10Addshore: [C: 031] trigger mwext-Wikibase-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89708 (owner: 10Hashar) [13:13:22] (03Merged) 10jenkins-bot: trigger mwext-Wikibase-qunit (non voting) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89708 (owner: 10Hashar) [13:14:36] (03Merged) 10jenkins-bot: Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [13:16:34] (03Merged) 10jenkins-bot: Refresh Deletereason-dropdown [core] - 10https://gerrit.wikimedia.org/r/89692 (owner: 10TTO) [13:24:20] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88266 (owner: 10Krinkle) [13:36:35] (03PS1) 10Hashar: inject $wgWikimediaJenkinsCI = true [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89710 [13:39:28] (03PS2) 10Hashar: inject $wgWikimediaJenkinsCI = true [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89710 [13:44:49] (03CR) 10Hashar: [C: 032] "That is really horrible, but really a quick workaround to have qunit test job running for Wikibase. Will eventually refactor that later o" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89710 (owner: 10Hashar) [13:45:08] (03Merged) 10jenkins-bot: inject $wgWikimediaJenkinsCI = true [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89710 (owner: 10Hashar) [14:30:36] (03CR) 10Hashar: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88628 (owner: 10Dereckson) [14:38:42] (03CR) 10Hashar: "Illustration:" [core] - 10https://gerrit.wikimedia.org/r/88628 (owner: 10Dereckson) [14:43:21] (03PS6) 10Hashar: Cleanup jobs for LangEng extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88718 (owner: 10Siebrand) [14:44:30] (03CR) 10Hashar: [C: 032] Cleanup jobs for LangEng extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88718 (owner: 10Siebrand) [14:44:48] (03Merged) 10jenkins-bot: Cleanup jobs for LangEng extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88718 (owner: 10Siebrand) [14:46:30] (03PS18) 10Hashar: Update jobs for LangEng extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88722 (owner: 10Siebrand) [14:47:47] * siebrand thanks hashar  [14:53:07] (03PS1) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [14:53:43] addshore: ping! [14:56:25] (03PS1) 10Aude: Update Wikibase with fix for site link editing [core] (wmf/1.22wmf21) - 10https://gerrit.wikimedia.org/r/89715 [14:56:49] (03PS2) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [15:00:37] (03PS19) 10Hashar: Update jobs for LangEng extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88722 (owner: 10Siebrand) [15:01:20] (03CR) 10Hashar: "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88722 (owner: 10Siebrand) [15:01:28] (03CR) 10Hashar: [C: 032] Update jobs for LangEng extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88722 (owner: 10Siebrand) [15:01:41] (03Merged) 10jenkins-bot: Update jobs for LangEng extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88722 (owner: 10Siebrand) [15:04:54] (03PS1) 10Siebrand: Update sorting [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89716 [15:05:37] hashar: Nice. Thanks. https://gerrit.wikimedia.org/r/89716 should organise mediawiki-extensions.yaml a little more. [15:05:52] (03PS2) 10BryanDavis: Fix logging with a separate dir and www-data as user and group [vagrant] - 10https://gerrit.wikimedia.org/r/89619 (owner: 10Mattflaschen) [15:06:46] siebrand: thanks for the maintenance :) [15:07:12] hashar: Going to to a similar check on layout.yaml now. [15:08:35] (03CR) 10Hashar: [C: 032] "No jobs changed, excellent!" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89716 (owner: 10Siebrand) [15:08:40] easy :-] [15:08:53] (03Merged) 10jenkins-bot: Update sorting [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89716 (owner: 10Siebrand) [15:08:53] * siebrand nods at hashar  [15:11:23] (03CR) 10Hashar: "Added Aaron Schulz and Bryan Davis who reviewed ""Escape backticks when quoting MySQL identifiers"" https://gerrit.wikimedia.org/r/#/c/885" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [15:13:28] (03PS1) 10Siebrand: Add Kartik Mistry as trusted user [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89718 [15:14:57] (03PS1) 10Siebrand: Move Moriel to staff & contractors [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89720 [15:15:27] (03CR) 10BryanDavis: [C: 031] "This is working for me in local vm and seems to fix a long standing problem I've had with file permissions in the logging directory." [vagrant] - 10https://gerrit.wikimedia.org/r/89619 (owner: 10Mattflaschen) [15:19:24] (03PS1) 10Siebrand: Move some current contractors to the correct group [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89721 [15:32:28] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89718 (owner: 10Siebrand) [15:33:18] (03CR) 10Hashar: [C: 032] Move Moriel to staff & contractors [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89720 (owner: 10Siebrand) [15:33:45] (03CR) 10Hashar: [C: 032] Move some current contractors to the correct group [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89721 (owner: 10Siebrand) [15:36:40] siebrand: Kartik needs to be blacklisted in check pipeline :/ https://gerrit.wikimedia.org/r/89718 [15:36:53] siebrand: or Zuul will trigger two sets of jobs (one from `check` the other set from `test`) [15:43:19] (03CR) 10BryanDavis: [C: 04-1] "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [15:52:13] bd808: thanks for that review: -] [15:52:39] nowI am reallyoff [15:53:42] (03PS3) 10Addshore: add Mysql RemoveIdentifierQuotes method and tests [core] - 10https://gerrit.wikimedia.org/r/89713 [15:56:31] bd808: thanks indeed :) [16:17:20] <^d> ! [16:17:21] an exclamation point [16:17:24] <^d> !! [16:17:24] an exclamation point [16:17:32] <^d> Shut up bot. [16:17:44] <^d> !!!!!! [16:17:58] <^d> Today is a happy day :) [16:30:56] (03CR) 10BryanDavis: [C: 032] "Merging as suggested by Siebrand so Dan can work on additional updates in smaller chunks." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [16:31:06] (03Merged) 10jenkins-bot: addressing mark traceur’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [16:32:36] thanks bd808! [16:33:20] dan-nl: I'm going to touch the next one to get rid of the -1 from jenkins and then merge it too [16:34:14] bd808: sounds good, hopefully it merges properly [16:35:26] (03PS15) 10BryanDavis: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [16:35:27] (03CR) 10jenkins-bot: [V: 04-1] addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [16:37:29] *grumble* rebase *grumble* [16:37:53] bd808: yes, what does that mean anyway? [16:38:27] ori-l: > Nope. The page as is is useless IMHO, can't contribute to it. --Nemo 19:22, 13 October 2013 (UTC) [16:38:35] ori-l: My new tech debt page has been well received. ;-) [16:39:03] dan-nl: There are conflicts in a couple of the files when rebasing the second patch set on the first. I'll see if I can fix it maunally [16:39:36] bd808: ja, that what i was concerned about. if it's not clear let me know and i'll see if i can sort it out [16:41:59] <^d> Well there goes my day off :P [16:44:10] dan-nl: There's more mess there than I can probably fix. includes/Config.php is the tricky one. [16:44:48] bd808: on that one anything that is in the php branch can replace whatever is in HEAD [16:46:07] ^d: HHVM fun for you today? [16:47:15] dan-nl: Ok. That should make it easier. [16:52:47] <^d> bd808: Indeed. https://github.com/facebook/hiphop-php/commit/bad8a99b4ab6bd606481aea320de902878e7378e landed friday [16:53:00] <^d> I can't help spend this lovely day hacking with it. [16:54:11] (03PS1) 10MarkAHershberger: Fix up cite-desc message so it can be displayed without the parser. [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89727 [16:55:10] ^d: shiny. That essentially creates a hook to add our own extensions without getting them into mainline? [16:55:43] <^d> Right, means we should be able to drop our stuff in at runtime. [16:55:52] <^d> And also hopefully not have to change much :) [16:59:41] (03PS16) 10BryanDavis: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [17:00:40] dan-nl: I'd like you to look at https://gerrit.wikimedia.org/r/#/c/83657 and make sure I didn't screw it up when fixing the conflicts. [17:01:05] bd808: okay, thanks [17:01:26] dan-nl: If it looks right to you, +1 it and I'll follow up with the +2. [17:08:34] (03CR) 10BryanDavis: "Manually rebased onto Ib7c74caf7a0fbfa80136b263653610fc3e2fd225" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [17:15:26] (03CR) 10Legoktm: "Perfect is the enemy of the good. Yes, that would be better, but I don't see why this would be bad." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88668 (owner: 10Legoktm) [17:20:31] (03CR) 10Dan-nl: [C: 031] addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [17:20:57] bd808: the merge looks good [17:21:21] * bd808 is bold [17:22:16] (03CR) 10BryanDavis: [C: 032] "Approving for merge so that Dan can keep moving forward and hopefully create smaller change sets for review in the future." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [17:22:22] (03Merged) 10jenkins-bot: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [17:24:29] (03PS1) 10MarkAHershberger: Fix up gadgets-desc message so it can be displayed without the parser. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/89728 [17:24:58] bd808: thanks, hopefully i can now sort out a way to keep these change sets smaller. do you think creating a change set per comment topic is okay or would that create too many change sets? [17:25:41] dan-nl: I think lots of small changes will be easier to get approved than a few big ones. [17:26:32] hello, anybody here? [17:26:53] NewbieAdmin: yep. What's up? [17:27:27] (03PS1) 10MarkAHershberger: Fix up interwiki-desc message so it can be displayed without the parser. [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/89729 [17:27:27] fine [17:27:50] (03CR) 10BryanDavis: [C: 04-1] "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [17:27:53] (03CR) 10Siebrand: [C: 04-1] "Functionality degradation. Shouldn't do this." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/89728 (owner: 10MarkAHershberger) [17:28:01] hi, i'm struggling with the visualeditor installation, and its connection with Parsoid [17:28:10] bd808: k, so i guess creating a new change set based on comments in the initial change set might be the best way to go about it. what about having the commenter create a bug for each of their comment topics? [17:28:31] i read all documents on mediawiki, but i didn't find a proper answer :( [17:29:06] (03CR) 10Siebrand: "Can't you strip( wfMessage()->parse() )?" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [17:29:16] NewbieAdmin: Are you having specific issues or just generally not getting it to work for you? [17:29:24] (03PS1) 10MarkAHershberger: Fix up nuke-desc message so it can be displayed without the parser. [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/89730 [17:29:36] i am getting errors when linking parsoid to my wiki [17:29:47] dan-nl: Getting reviewed to open a bunch of bugs isn't likely. :) [17:29:49] the website repsonds: bad badrequest [17:29:51] (03CR) 10Siebrand: [C: 04-1] "strip_tags() that is." [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [17:30:16] dan-nl: *reviewers [17:30:57] * bd808 looks around for a parsoid expert [17:31:08] bd808: ok :), i guess i could do it and relate them to the topics of their comments … ? [17:32:21] dan-nl: Sure, if that helps your workflow go for it. Or hope that by adding functionality in small slices the reviews aren't so hard to keep up with. [17:33:43] dan-nl: You can make patch sets that depend on each other in a chain too. I've seen marktraceur do that as he was building the BetaFeatures extension. [17:34:34] (03PS2) 10Siebrand: Add Kartik Mistry as trusted user [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89718 [17:34:34] dan-nl: That can help keep the size of each review being submitted smaller and still let you keep moving while reviews are in progress. [17:35:01] (03PS1) 10MarkAHershberger: Fix up renameuser-desc message so it can be displayed without the parser. [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/89731 [17:35:25] (03CR) 10Ori.livneh: [C: 032] "Thanks for the patch and the review." [vagrant] - 10https://gerrit.wikimedia.org/r/89619 (owner: 10Mattflaschen) [17:35:29] (03Merged) 10jenkins-bot: Fix logging with a separate dir and www-data as user and group [vagrant] - 10https://gerrit.wikimedia.org/r/89619 (owner: 10Mattflaschen) [17:35:57] (03CR) 10Siebrand: [C: 04-1] "Removing functionality to let the installer work isn't a good idea. Fix the installer instead." [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/89731 (owner: 10MarkAHershberger) [17:36:22] bd808: hmm. i'll take a look at it and see if i can also figure out how to do it. were they change sets that depended on each other or a single change set? [17:36:30] (03CR) 10Siebrand: [C: 04-2] "Removing functionality to let the installer work isn't a good idea. Fix the installer instead." [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/89730 (owner: 10MarkAHershberger) [17:36:35] (03CR) 10Siebrand: [C: 04-2] "Removing functionality to let the installer work isn't a good idea. Fix the installer instead." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/89729 (owner: 10MarkAHershberger) [17:36:41] (03CR) 10Siebrand: [C: 04-2] "Removing functionality to let the installer work isn't a good idea. Fix the installer instead." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/89727 (owner: 10MarkAHershberger) [17:37:16] dan-nl: They were change sets that depended on each other. Like a feature branch would look with each one building on the ones before. [17:37:45] (03CR) 10Siebrand: "Thanks, Bryan." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/82619 (owner: 10Dan-nl) [17:38:34] NewbieAdmin: I don't have much experience with parsoid myself. [17:38:39] bd808: ah, ok, that makes more sense. will see if i can sort that out as well. i think i saw something like that in the advanced workflow. thanks again for your help with the merges into master! [17:39:23] NewbieAdmin: I've only set it up using MediaWiki-Vagrant and the role::visualeditor role it uses. [17:40:17] dan-nl: Glad to be of help. Hopefully nobody will chew me out for it later. :) [17:40:52] bd808: well, you have me, siebrand and david behind you [17:41:16] bd808: Run Forest, run! [17:41:28] * bd808 takes off cross-country [17:41:48] bd808: and we can always make further changes if anyone wishes … just need them to let us know what they'd like changed [17:42:10] Does it have a bugzilla component? [17:42:22] (or some tracker somewhere?) [17:42:36] bd808: have fun [17:43:22] siebrand: you mean like this https://bugzilla.wikimedia.org/buglist.cgi?component=GWToolset? [17:43:48] dan-nl: Yes. [17:44:23] HI ori-l. SHoulnd't you be "not working"? [17:44:30] (03CR) 10MarkAHershberger: "Agreed that this solution isn't ideal, but "fixing the installer" in this case would mean re-implementing the parser without DB dependenci" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/89731 (owner: 10MarkAHershberger) [17:45:05] bd808: i'm not working, i'm reading some stupid websites and futzing around IRC [17:45:16] ori-l: Excellent [17:45:33] * bd808 plans to "not work" after lunch [17:46:09] siebrand: i don't see it in the component list here, https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki%20extensions, how do i add it there? [17:46:10] dan-nl: What's your bugzilla email address? (can't find you) [17:46:21] dan-nl: I'm adding it right now. [17:46:35] dan-nl: Who else need to be on CC? [17:47:02] dan-nl: Okay, I have your email address in the private chat. [17:48:10] (03CR) 10Ori.livneh: [C: 032] "Yep. Smart." [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [17:48:23] dan-nl: So I created the component with only you in CC. [17:48:50] bd808: i'm not working either! [17:49:04] siebrand: cool, thanks! [17:49:23] (03PS8) 10Ori.livneh: resourceloader: Don't catch LESS error in ResourceLoaderFileModule [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [17:49:29] (03CR) 10Ori.livneh: [C: 032] resourceloader: Don't catch LESS error in ResourceLoaderFileModule [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [17:49:34] dan-nl: https://bugzilla.wikimedia.org/enter_bug.cgi?product=MediaWiki%20extensions&component=GWToolset [17:49:56] siebrand: excellent [17:50:19] works from the extension page as well now [17:51:32] siebrand: how can i add someone else to the notification list at a later date? [17:52:18] YuviPanda: Are you typing? [17:52:34] bd808: a little. mostly watching videos and reading [17:52:56] YuviPanda: Good. Rest those wrists. [17:53:55] (03Merged) 10jenkins-bot: resourceloader: Don't catch LESS error in ResourceLoaderFileModule [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [17:54:08] siebrand: got your private chat. thanks for setting up the component in bugzilla! [17:55:44] (03CR) 10Siebrand: "Have you tried wfMessage()->useDatabase( false )->parser()?" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/89731 (owner: 10MarkAHershberger) [17:56:09] (03CR) 10Siebrand: "Damn typos: Have you tried wfMessage( key )->useDatabase( false )->parse()?" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/89731 (owner: 10MarkAHershberger) [17:58:15] legoktm, global notifications rfc: your schema doesn't deal with notifications [17:58:46] events might not even need to be stored centrally. not sure about that. notifications should be stored centrally though [17:59:16] (see echo_notifications table) [18:00:59] (03CR) 10Alex Monk: "It's not bad, it's just not what I believe (feel free to correct me Benny) we want to do." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88668 (owner: 10Legoktm) [18:12:52] (03CR) 10Mdale: [C: 032 V: 032] "Tested locally. Looks good." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/87284 (owner: 10Rillke) [19:02:40] (03PS3) 10BryanDavis: Simplified IPv6 regex per comment [core] - 10https://gerrit.wikimedia.org/r/66304 (owner: 10Aaron Schulz) [19:13:45] (03CR) 10Brion VIBBER: "Couple of notes from a quick skim:" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [19:15:40] (03PS5) 10BryanDavis: [HEAVY WIP] Add varnish role [vagrant] - 10https://gerrit.wikimedia.org/r/87623 (owner: 10Yuvipanda) [19:16:13] (03CR) 10BryanDavis: [C: 032] Simplified IPv6 regex per comment [core] - 10https://gerrit.wikimedia.org/r/66304 (owner: 10Aaron Schulz) [19:18:56] (03Merged) 10jenkins-bot: Simplified IPv6 regex per comment [core] - 10https://gerrit.wikimedia.org/r/66304 (owner: 10Aaron Schulz) [19:28:19] (03CR) 10Parent5446: "What's the purpose of this function? Why would you ever need or want to remove quotes from something you already quoted?" [core] - 10https://gerrit.wikimedia.org/r/89713 (owner: 10Addshore) [19:41:09] (03CR) 10Siebrand: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/71572 (owner: 10Hoo man) [19:45:29] (03PS1) 10Siebrand: Pass correct variable to closure [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89735 [19:45:30] (03PS1) 10Siebrand: Remove unused local variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89736 [19:45:31] (03PS1) 10Siebrand: Update comments and satisfy analyzer [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/89737 [19:59:56] (03PS1) 10Siebrand: Update formatting [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89738 [20:01:55] (03PS1) 10Hashar: jobs for mw/ext/Drafts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89739 [20:02:27] (03CR) 10Hashar: [C: 032] jobs for mw/ext/Drafts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89739 (owner: 10Hashar) [20:02:45] (03Merged) 10jenkins-bot: jobs for mw/ext/Drafts [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89739 (owner: 10Hashar) [20:03:01] (03CR) 10Ori.livneh: "> It looks like the entire cached module set is stored in one giant JSON blob; this'll force synchronous disk i/o, memory usage, and JSON " [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:04:49] (03CR) 10Ori.livneh: "> that writing data in a single setItem() is much more expensive than splitting that data into 80-90 setItem()s." [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:04:56] (03PS1) 10Hashar: triggers for mw/ext/Drafts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89740 [20:05:04] brion: replied [20:06:09] (03CR) 10Hashar: [C: 032] triggers for mw/ext/Drafts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89740 (owner: 10Hashar) [20:06:17] (03Merged) 10jenkins-bot: triggers for mw/ext/Drafts [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89740 (owner: 10Hashar) [20:07:20] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89741 [20:07:25] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89741 (owner: 10Hashar) [20:09:20] (03PS1) 10Hashar: Drafts was using DynamicSidebar :/ [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89742 [20:09:31] (03CR) 10Hashar: [C: 032] Drafts was using DynamicSidebar :/ [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89742 (owner: 10Hashar) [20:09:38] (03Merged) 10jenkins-bot: Drafts was using DynamicSidebar :/ [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/89742 (owner: 10Hashar) [20:10:03] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89741 [20:12:52] Krenair: Right. I think we'd still need to store events centrally for context though. I'll look at the code again in a bit [20:12:55] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/89741 (owner: 10Hashar) [20:13:15] hashar: thank you :D [20:13:28] legoktm: it took a while sorry :/ [20:13:44] legoktm: jshint should not be too hard, there is only a few issues [20:14:04] well, i'm planning on rewriting all of the JS [20:14:13] https://gerrit.wikimedia.org/r/#/c/88405/ [20:15:51] ahhh [20:16:06] legoktm: note the jshint defaults comes from the repository integration/docroot [20:16:11] legoktm: that is a bug [20:16:25] that's because drafts doesn't have a .jshintrc [20:16:29] yup [20:16:45] i'll add that…eventually :P [20:16:48] and integration/docroot is fetched on gallium as /srv which is also the root of workspaces for jobs [20:16:53] got to fix it someway [20:17:07] (03PS1) 10Siebrand: Declare variables at top of function [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89743 [20:17:08] (03PS1) 10Siebrand: Replace deprecated methods [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89744 [20:17:08] but .jshintrc  with {} will surely reset to the default ] [20:17:09] (03PS1) 10Siebrand: Reduce maximum line length to 100 characters or less [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89745 [20:18:07] (03CR) 10Hashar: [C: 032] Update formatting [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89738 (owner: 10Siebrand) [20:18:12] (03Merged) 10jenkins-bot: Update formatting [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89738 (owner: 10Siebrand) [20:19:21] (03CR) 10Hashar: [C: 032] Declare variables at top of function [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89743 (owner: 10Siebrand) [20:19:25] (03Merged) 10jenkins-bot: Declare variables at top of function [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89743 (owner: 10Siebrand) [20:20:56] (03PS2) 10Siebrand: Reduce maximum line length to 100 characters or less [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89745 [20:21:03] (03CR) 10Hashar: [C: 032] Reduce maximum line length to 100 characters or less [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89745 (owner: 10Siebrand) [20:21:05] (03Merged) 10jenkins-bot: Reduce maximum line length to 100 characters or less [extensions/ApiSandbox] - 10https://gerrit.wikimedia.org/r/89745 (owner: 10Siebrand) [20:21:23] siebrand: merged most of them [20:22:17] hashar: What did you do with https://gerrit.wikimedia.org/r/#/c/89745/2 ? [20:22:33] skills [20:22:54] hashar: that's why I'm asking. [20:23:01] https://tinyurl.com/c7z4728 [20:23:03] :D [20:23:05] siebrand: i assume he cherry-picked the change on master [20:23:25] siebrand: more seriously, in Gerrit you can now use the [Cherry pick to] button [20:23:29] which is basically equivalent to rebasing it off master, dropping any unmerged dependencies [20:23:34] which let you pick the change on a branch, for example refs/head/master [20:23:36] except that you can do it from the web ui [20:23:37] :D [20:23:45] ah [20:23:49] (you can't cherry-pick on random sha1s, though, which sucks) [20:23:50] that let you get a change out of a dependency chain [20:24:07] oh, cool. [20:24:11] MatmaRex: must be a branch / tag ? [20:24:22] ah yeah a branch ... [20:29:41] (03CR) 10Plavi: "(12 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [20:33:43] (03CR) 10Plavi: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [20:34:23] siebrand: what was that supposed to be? [20:34:45] SurprisedPanda: I think you wrote "cat" and Google tells me I replied with "cute". [20:34:58] siebrand: google is wrong [20:35:11] siebrand: that circle in the second word indicates it's not a real character [20:35:46] siebrand: no idea what that means :) [20:35:56] siebrand: but yeah, was just hijacking random comment threads [20:36:51] (03PS6) 10Plavi: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 [20:37:48] (03CR) 10Brion VIBBER: "*nod* the main win here should be in avoiding network round-trips for modules we don't need to update, so the sync/async & CPU/RAM usage d" [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [20:39:43] (03PS1) 10Hashar: CodeSniffer job has been deleted [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89747 [20:39:45] (03PS1) 10Hashar: snapshot manually maintained jobs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89748 [20:40:04] (03CR) 10Hashar: [C: 032 V: 032] CodeSniffer job has been deleted [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89747 (owner: 10Hashar) [20:40:10] death to CodeSniffer! [20:40:12] (03CR) 10Hashar: [C: 032 V: 032] snapshot manually maintained jobs [integration/jenkins] - 10https://gerrit.wikimedia.org/r/89748 (owner: 10Hashar) [20:41:00] brion: that is the olddd job :-] [20:41:11] brion: how is your javascript video decoder going on ? [20:41:23] brion: it works smoothly on my laptop! [20:41:23] hashar: surprisingly well :) [20:41:27] awesome [20:41:34] still too slow on mobile, but that's what native apps are for [20:41:42] I am just not sure what is the advantage over