[00:12:00] (03CR) 10Bsitu: "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [00:13:59] (03CR) 10Alex Monk: [C: 032] Fix scope error in mw.UploadWizardUploadInterface.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89173 (owner: 10Mattflaschen) [00:14:30] (03Merged) 10jenkins-bot: Fix scope error in mw.UploadWizardUploadInterface.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/89173 (owner: 10Mattflaschen) [00:20:00] (03PS1) 10Shirayuki: Remove full-stop from desc [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/89371 [00:21:45] (03CR) 10Alex Monk: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 (owner: 10MarkTraceur) [00:22:33] (03CR) 10Spage: [C: 04-1] "This fails with" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 (owner: 10Spage) [00:22:43] (03PS1) 10Mwalker: Revert "Updating DonationInterface to master" [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89372 [00:22:52] (03CR) 10Mwalker: [C: 032 V: 032] Revert "Updating DonationInterface to master" [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89372 (owner: 10Mwalker) [00:23:11] (03CR) 10MarkAHershberger: [C: 04-1] "Links aren't handled correctly. This is one of the problems of this that needs work. Cite's description shows as "Adds (03PS1) 10Mwalker: Revert "Adding RapidError Pages! woo." [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89373 [00:27:46] (03PS1) 10Ori.livneh: WebWorker ResourceLoader Eliza wat [core] - 10https://gerrit.wikimedia.org/r/89375 [00:27:49] (03CR) 10Katie Horn: [C: 032 V: 032] "Bah. Unrevert when we're actually ready for this." [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89373 (owner: 10Mwalker) [00:28:25] (03PS1) 10Shirayuki: Replace "id" by "ID" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89376 [00:30:51] (03PS1) 10Mwalker: Updating DI to master again [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89377 [00:31:21] (03CR) 10Mwalker: [C: 032 V: 032] Updating DI to master again [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89377 (owner: 10Mwalker) [00:35:38] (03CR) 10jenkins-bot: [V: 04-1] WebWorker ResourceLoader Eliza wat [core] - 10https://gerrit.wikimedia.org/r/89375 (owner: 10Ori.livneh) [00:44:07] (03PS1) 10Bartosz Dziewoński: SpecialRecentChanges: Don't call getUser() repeatedly in getDefaultOptions() [core] - 10https://gerrit.wikimedia.org/r/89378 [00:51:29] (03PS2) 10Spage: position 'top' for ext.flow.discussion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 [00:56:55] (03CR) 10Krinkle: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 (owner: 10Spage) [01:05:00] (03CR) 10Krinkle: [C: 031] SpecialRecentChanges: Don't call getUser() repeatedly in getDefaultOptions() [core] - 10https://gerrit.wikimedia.org/r/89378 (owner: 10Bartosz Dziewoński) [01:10:25] (03PS3) 10Spage: position 'top' for ext.flow.discussion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 [01:11:54] (03CR) 10Spage: "PS3 improves commit message, thanks Krinkle." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 (owner: 10Spage) [01:13:06] spagewmf: I'd move the entire object definnition out of the closure [01:13:24] parsing an object is cheap, and having the property magically appear later is probably not very useful ;-) [01:15:32] spagewmf: Hm.. there doesn't seem to be anything dom related in that closure. Why is there a $() there at all? [01:20:41] Krinkle: I don't see any reason either, I'll try removing it. Does loading code later in $() reduce time to first page render? [01:21:09] spagewmf: I'd argue it has more cost than win, if any win at all. [01:22:06] it'l save a few function calls that return more straight up functions, but that's still very minor execution. [01:22:56] spagewmf: but mostly, I'd say having those methods there when the module is 'ready' satisfies the expectation when the module is loaded. It is a public method after all, so it should be there when it is loaded. [01:23:47] saving 1 css paint or DOM operation is probably a tenfold stronger gain (if it gains). [01:26:48] (03PS1) 10Legoktm: Use batch inserting of jobs [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89382 [01:29:36] (03CR) 10Krinkle: "FIXME Incorrect release notes. "Wikipedia feed items" ? Do you mean MediaWiki, RecentChanges or API? Something else?" [core] - 10https://gerrit.wikimedia.org/r/61286 (owner: 10Kaligula) [01:31:39] Krinkle: thanks! I'll review other modules for DOM-independent definition in a document ready. (Flow has a mix, which is how I stumbled into this making a small change :o) ). [01:31:56] cool [01:33:17] spagewmf: btw, if you're interested in learing more about tracking and addressing rendering performance. I tend to do a somewhat unorganised sprint over the coming weeks focussing on this topic. There's a few links I could send you to research and then apply on your own in various projects where you see fit. [01:35:24] Krinkle: sure, I'll probably at least write something on the wiki [01:44:29] (03PS1) 10Legoktm: Add type hinting [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89383 [01:49:22] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87512 (owner: 10Legoktm) [01:49:38] (03PS2) 10Legoktm: Link to specific revision of spamlist that was used [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87512 [01:49:39] (03CR) 10jenkins-bot: [V: 04-1] Link to specific revision of spamlist that was used [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87512 (owner: 10Legoktm) [01:49:45] i know >.> [01:50:50] (03PS3) 10Legoktm: Link to specific revision of spamlist that was used [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87512 [01:59:18] (03PS3) 10Legoktm: Expose number of queued messages in the API [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 [01:59:40] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 (owner: 10Legoktm) [02:03:04] (03PS4) 10Spage: position 'top' for ext.flow.discussion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370 [02:03:11] (03PS2) 10Legoktm: Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 [02:08:47] (03PS3) 10Legoktm: Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 [02:09:17] (03CR) 10jenkins-bot: [V: 04-1] Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [02:09:29] stupid release notes. [02:12:43] (03PS4) 10Legoktm: Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 [02:13:27] (03CR) 10Legoktm: "PS2: Removed $this" [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [02:17:40] (03PS4) 10Legoktm: Expose number of queued messages in the API [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87695 [02:19:45] (03PS4) 10Legoktm: Check for a message with no timestamp [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87183 [02:22:59] (03PS6) 10Legoktm: Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 [02:23:05] (03CR) 10jenkins-bot: [V: 04-1] Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [02:38:03] (03CR) 10Legoktm: "Good (not really) news: I can reproduce the failure on my testwiki. Bad news: I think LQT posting is broken >.>" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [02:42:10] (03CR) 10Legoktm: "It's not broken, but now I can't reproduce the failure... >.>" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [02:46:22] (03PS1) 10PleaseStand: Put the HTML attribute whitelist closer to HTML5 [core] - 10https://gerrit.wikimedia.org/r/89384 [02:47:33] (03CR) 10jenkins-bot: [V: 04-1] Put the HTML attribute whitelist closer to HTML5 [core] - 10https://gerrit.wikimedia.org/r/89384 (owner: 10PleaseStand) [02:49:43] (03PS7) 10Legoktm: Add tests for LiquidThreads functionality [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 [02:51:30] (03CR) 10PleaseStand: "The patch is not mine; it was originally uploaded as a Bugzilla attachment. I have simply reuploaded it here for easier review." [core] - 10https://gerrit.wikimedia.org/r/89384 (owner: 10PleaseStand) [02:54:15] (03CR) 10Legoktm: [C: 031] "After a bit of debugging, it seems that LqtDispatch::isLqtPage doesn't work correctly when @group Database is set (it modifies the $wgDBpr" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/81468 (owner: 10Legoktm) [04:19:15] (03PS7) 10thibaultmarin: (extension/TimelineTable) Refactoring and cleanup [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 [04:21:26] (03CR) 10thibaultmarin: "(2 comments)" [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/38485 (owner: 10thibaultmarin) [05:23:27] (03PS1) 10Hiong3-eng5: added API owAddToCollection [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/89388 [05:26:11] (03PS1) 10Spage: Update browsertests for string change [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89389 [05:34:36] * Dantman isn't very impressed looking over the state of the 3rd party libraries in resources/jquery/ [06:25:17] (03CR) 10Spage: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 (owner: 10Matthias Mullie) [07:16:40] (03PS2) 10Ebrahim: Reversed question mark for RTL languages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87654 [07:17:44] (03PS1) 10Pastakhov: Refactoring $stack [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/89390 [07:19:20] (03Abandoned) 10Ebrahim: Reversed question mark for RTL languages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/87654 (owner: 10Ebrahim) [07:20:27] (03CR) 10Pastakhov: [C: 032] Refactoring $stack [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/89390 (owner: 10Pastakhov) [07:20:32] (03Merged) 10jenkins-bot: Refactoring $stack [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/89390 (owner: 10Pastakhov) [07:51:48] (03CR) 10Rtdwivedi: [C: 031] Add icons for pref, next and index navigation links to the Vector skin [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/89170 (owner: 10Tpt) [07:52:05] (03CR) 10Tpt: [C: 032] Add icons for pref, next and index navigation links to the Vector skin [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/89170 (owner: 10Tpt) [07:52:19] (03Merged) 10jenkins-bot: Add icons for pref, next and index navigation links to the Vector skin [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/89170 (owner: 10Tpt) [08:16:55] (03PS1) 10Spage: Revert visibility change to HTMLForm $typeMappings [core] - 10https://gerrit.wikimedia.org/r/89391 [08:19:53] (03CR) 10Spage: "Nikerabbit's instinct was right in https://gerrit.wikimedia.org/r/#/c/56078/ comments. I think declaring it public static is effectively " [core] - 10https://gerrit.wikimedia.org/r/89391 (owner: 10Spage) [08:31:10] (03CR) 10Nemo bis: "Followup at https://gerrit.wikimedia.org/r/#/c/89391/" [core] - 10https://gerrit.wikimedia.org/r/56078 (owner: 10Spage) [09:40:47] (03PS1) 10Pastakhov: small cleaning up [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/89392 [09:43:44] (03CR) 10Pastakhov: [C: 032] small cleaning up [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/89392 (owner: 10Pastakhov) [09:43:51] (03Merged) 10jenkins-bot: small cleaning up [extensions/Foxway] (develop) - 10https://gerrit.wikimedia.org/r/89392 (owner: 10Pastakhov) [10:24:05] (03CR) 10Siebrand: [C: 032] Native digits on 'mw-fr-revisiontag-edit' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/88008 (owner: 10Ebrahim) [11:28:33] (03CR) 10Kipcool: [C: 032 V: 032] "I have no comments to make on your codes lately," [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/89388 (owner: 10Hiong3-eng5) [11:29:28] (03CR) 10Siebrand: [C: 032 V: 032] Replace "id" by "ID" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89376 (owner: 10Shirayuki) [11:29:55] (03CR) 10Siebrand: [C: 032 V: 032] Remove full-stop from desc [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/89371 (owner: 10Shirayuki) [11:33:07] (03PS2) 10Bartosz Dziewoński: Put the HTML attribute whitelist closer to HTML5 [core] - 10https://gerrit.wikimedia.org/r/89384 (owner: 10PleaseStand) [11:36:42] (03CR) 10Bartosz Dziewoński: "Fixed a test which was testing behavior of ." [core] - 10https://gerrit.wikimedia.org/r/89384 (owner: 10PleaseStand) [11:38:28] (03CR) 10Bartosz Dziewoński: [C: 031] "The changes look good to me, I added some more reviewers." [core] - 10https://gerrit.wikimedia.org/r/89384 (owner: 10PleaseStand) [13:14:52] (03CR) 10Dereckson: "I'm not currently planning to add tests to this patch." [core] - 10https://gerrit.wikimedia.org/r/88628 (owner: 10Dereckson) [13:39:30] (03CR) 10MarkAHershberger: "Note that using ->text() instead of ->escaped() doesn't shows "Adds and tags, for citations" (or something similar), so maybe I should j" [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [13:41:28] siebrand: needs also V+2 https://gerrit.wikimedia.org/r/88008 [14:02:58] !class FormOptions [14:02:59] See https://doc.wikimedia.org/mediawiki-core/master/php/html/classFormOptions.html [14:08:10] (03CR) 10Nikerabbit: [C: 031] Add APIQuerySiteInfoStatisticsInfo hook [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [14:59:55] (03PS1) 10Bartosz Dziewoński: FormOptions: More documentation! [core] - 10https://gerrit.wikimedia.org/r/89403 [15:17:08] (03CR) 10Kaligula: "I assume "(bug 47219) Allow to specify the type of changes in Wikipedia API watchlist feed" would be a good description?" [core] - 10https://gerrit.wikimedia.org/r/61286 (owner: 10Kaligula) [15:31:58] hmm [15:32:12] is there a way to pass empty string to param in api sandbox? [15:34:06] (03PS2) 10Siebrand: FormOptions: More documentation! [core] - 10https://gerrit.wikimedia.org/r/89403 (owner: 10Bartosz Dziewoński) [15:34:59] (03CR) 10Siebrand: [C: 032] "Nice work. Added some consistency fixes in PS2." [core] - 10https://gerrit.wikimedia.org/r/89403 (owner: 10Bartosz Dziewoński) [15:35:59] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/89405 [15:38:53] (03Merged) 10jenkins-bot: FormOptions: More documentation! [core] - 10https://gerrit.wikimedia.org/r/89403 (owner: 10Bartosz Dziewoński) [15:40:54] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/89361 (owner: 10Luis Felipe Schenone) [15:41:52] (03CR) 10Bartosz Dziewoński: [C: 032] Update formatting [core] - 10https://gerrit.wikimedia.org/r/89405 (owner: 10Siebrand) [15:44:45] (03Merged) 10jenkins-bot: Update formatting [core] - 10https://gerrit.wikimedia.org/r/89405 (owner: 10Siebrand) [15:49:58] (03CR) 10Siebrand: "You can combine two commits into one. It's called squashing. Have a look at what happens when you type this into your commandline: "git re" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89132 (owner: 10Luis Felipe Schenone) [16:22:20] (03PS1) 10Merlijn van Deen: Another test commit, now in an integrated setting. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89408 [16:27:54] (03PS1) 10Merlijn van Deen: Another test commit, now in an integrated setting. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89409 [16:28:30] (03PS1) 10Merlijn van Deen: Another test commit, now in an integrated setting. [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89410 [16:44:02] (03PS1) 10Umherirrender: Add column with link to UnreviewedPages on ValidationStatistics [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89412 [16:46:28] (03CR) 10Umherirrender: "Link to dewiki https://de.wikipedia.org/wiki/Spezial:Sichtungsstatistik?uselang=de" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89412 (owner: 10Umherirrender) [16:58:44] (03PS1) 10MarkAHershberger: merge [tools/release] - 10https://gerrit.wikimedia.org/r/89413 [17:00:50] (03PS2) 10MarkAHershberger: Update make-release.py. [tools/release] - 10https://gerrit.wikimedia.org/r/89413 [17:02:39] (03PS1) 10Gerrit Patch Uploader: Something Something Patchy [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89414 [17:07:26] * ori-l blinks [17:15:32] * Nemo_bis covers eyes [17:17:51] (03CR) 10Alex Monk: [C: 032] Revert visibility change to HTMLForm $typeMappings [core] - 10https://gerrit.wikimedia.org/r/89391 (owner: 10Spage) [17:20:39] (03Merged) 10jenkins-bot: Revert visibility change to HTMLForm $typeMappings [core] - 10https://gerrit.wikimedia.org/r/89391 (owner: 10Spage) [17:38:51] (03CR) 10Ebrahim: "Hmm, seems someone must verify the patch in order to merge and jenkins-bot is not doing it automatically." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/88008 (owner: 10Ebrahim) [17:40:19] hi ori-l [17:40:33] hey Nikerabbit, how are you? [17:41:14] ori-l: quite swamped about all the things I want to do but enjoying my weekend nevertheless [17:41:38] :) [17:44:03] awesome autumn weather here [17:44:28] ruska, if you know [17:45:04] autumn leaf color? [17:45:30] here still all green [17:46:02] yep [17:46:26] I'm surprised English doesn't have word for this [17:46:48] * YuviPanda is staying away from the Keyboard [17:46:51] with little success [17:47:55] foliage [17:47:58] sorta [17:48:03] sorta ruska [17:50:13] not to be confused with tuska [17:55:45] (03CR) 10Bartosz Dziewoński: [C: 032 V: 032] Native digits on 'mw-fr-revisiontag-edit' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/88008 (owner: 10Ebrahim) [17:59:05] heh, at least tuska is on my dictionary [18:16:51] hey Nikerabbit [18:19:24] hi [18:20:46] so, i've been thinking -- we use a separate hostname (bits) to have better parallelism, btu that doesn't really apply in the case of fonts [18:20:52] so you could just use, e.g., https://en.wikipedia.org/w/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-regular.woff [18:21:29] doesn't really apply == doesn't really matter in the case of static assets that should ideally be cached for a long time [18:22:53] ori-l: wouldn't that be bad for people using multiple projects? [18:25:01] hmmmm, yes. [18:25:43] there's also bits/w/ but when I asked him about it, Tim mysteriously said "it's not recommended" and then disappeared [18:25:47] (03PS1) 10Bartosz Dziewoński: Simplify watchlist edit mode handling [core] - 10https://gerrit.wikimedia.org/r/89423 [18:25:56] but it meets all the requirements AFAICT [18:26:10] ^ trivial [18:26:21] this would be https://bits.wikimedia.org/w/extensions/UniversalLanguageSelector/data/fontrepo/fonts/amiri/amiri-regular.woff [18:28:33] it's just amazing how that stuff survived for so long [18:28:56] same with other things here: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:watchlist,n,z [18:29:10] i'm uncovering the lost world of 2005 [18:29:57] I uncover the lost world of 5000 everytime I've to write Html::element [18:47:52] (03PS1) 10Bartosz Dziewoński: Rename SpecialRecentChanges::addRecentChangesJS() to addModules() [core] - 10https://gerrit.wikimedia.org/r/89475 [19:23:45] (03CR) 10Bartosz Dziewoński: [C: 032] "This works and I see no reason not to do it." [core] - 10https://gerrit.wikimedia.org/r/65872 (owner: 10Hazard-SJ) [19:26:47] (03Merged) 10jenkins-bot: Add bot to createAndPromote.php groups [core] - 10https://gerrit.wikimedia.org/r/65872 (owner: 10Hazard-SJ) [19:39:25] (03PS1) 10CryoKey: Support CryoKey Android client [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/89477 [19:43:55] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Doesn't merge." [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [19:46:47] (03CR) 10CryoKey: [C: 032 V: 032] Support CryoKey Android client [extensions/CryoKey] - 10https://gerrit.wikimedia.org/r/89477 (owner: 10CryoKey) [19:46:50] (03PS1) 10Kipcool: Added filtering by classes and topics [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/89478 [19:47:12] (03CR) 10Kipcool: [C: 032 V: 032] Added filtering by classes and topics [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/89478 (owner: 10Kipcool) [19:52:57] (03CR) 10Bartosz Dziewoński: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/65299 (owner: 10Mwalker) [19:56:31] (03CR) 10Bartosz Dziewoński: "Niklas?" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [19:58:18] MatmaRex: you could as well just merge it ;) nobody's going to die for some more _blank which is already around in a dozen special pages [19:58:31] (03CR) 10Siebrand: "This has nothing to do with trumping PHPCS warnings. There was no visibility declared, and you chose to fix the issue by declaring the mos" [core] - 10https://gerrit.wikimedia.org/r/89391 (owner: 10Spage) [20:01:13] Nemo_bis: you could just as well kill that _blank, it's actually hardly used and a bad practice [20:01:27] usually a bad practice* [20:02:00] and i see no reason to use it in that particular spot, especially since we have other links in the same form that are not target=_blank [20:02:18] and there is not data to be lost on leaving the page [20:02:22] no data* [20:08:10] Sure, yours is a legitimate opinion. I don't see compelling arguments to choose though. [20:15:16] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89412 (owner: 10Umherirrender) [20:19:39] (03CR) 10Bartosz Dziewoński: "Issue in previous PS filed as bug 55442." [core] - 10https://gerrit.wikimedia.org/r/88266 (owner: 10Krinkle) [20:23:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88266 (owner: 10Krinkle) [20:41:40] (03CR) 10Alex Monk: [C: 032 V: 032] Add column with link to UnreviewedPages on ValidationStatistics [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/89412 (owner: 10Umherirrender) [20:47:34] (03PS1) 10Foxtrott: Reworking the extension [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/89480 [20:49:31] (03PS1) 10Umherirrender: Pass Context to User::resetOptions [core] - 10https://gerrit.wikimedia.org/r/89481 [20:50:02] (03CR) 10Alex Monk: "(1 comment)" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 (owner: 10Legoktm) [20:55:24] (03PS2) 10Foxtrott: Reworking the extension [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/89480 [20:55:57] (03PS3) 10Foxtrott: Reworking the extension [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/89480 [21:00:47] (03CR) 10Alex Monk: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86777 (owner: 10MarkTraceur) [21:24:00] (03CR) 10Bartosz Dziewoński: [C: 032] Pass Context to User::resetOptions [core] - 10https://gerrit.wikimedia.org/r/89481 (owner: 10Umherirrender) [21:26:45] (03Merged) 10jenkins-bot: Pass Context to User::resetOptions [core] - 10https://gerrit.wikimedia.org/r/89481 (owner: 10Umherirrender) [22:04:29] (03PS1) 10Reedy: Remove deleted wikis entries from CentralAuth tables [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/89484 [22:08:03] (03PS1) 10GWicke: Insert defs into svg element, not before it [extensions/Math] - 10https://gerrit.wikimedia.org/r/89485 [22:08:28] (03PS2) 10GWicke: Insert defs into svg element, not before it [extensions/Math] - 10https://gerrit.wikimedia.org/r/89485 [22:29:25] (03PS1) 10Bartosz Dziewoński: IcuCollation: Sort digits under localised digits' headings [core] - 10https://gerrit.wikimedia.org/r/89488 [22:30:17] (03CR) 10jenkins-bot: [V: 04-1] IcuCollation: Sort digits under localised digits' headings [core] - 10https://gerrit.wikimedia.org/r/89488 (owner: 10Bartosz Dziewoński) [22:30:54] (03PS2) 10Luis Felipe Schenone: Initial commit of the extension [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/89361 [22:32:52] what [22:33:04] are we still using ancient php where you can't do func()[]? D: [22:34:07] (03PS2) 10Bartosz Dziewoński: IcuCollation: Sort digits under localised digits' headings [core] - 10https://gerrit.wikimedia.org/r/89488 [22:35:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "https://bugzilla.wikimedia.org/show_bug.cgi?id=55630#c7" [core] - 10https://gerrit.wikimedia.org/r/89488 (owner: 10Bartosz Dziewoński) [22:36:58] (03PS1) 10Foxtrott: Mostly code styling [skins/chameleon] - 10https://gerrit.wikimedia.org/r/89489 [22:41:35] (03PS2) 10Foxtrott: Mostly code styling [skins/chameleon] - 10https://gerrit.wikimedia.org/r/89489 [22:41:51] (03CR) 10Foxtrott: [C: 032 V: 032] Code styling; adapting to extension Bootstrap changes [skins/chameleon] - 10https://gerrit.wikimedia.org/r/89489 (owner: 10Foxtrott) [22:42:05] (03CR) 10Foxtrott: [C: 032 V: 032] Reworking the extension [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/89480 (owner: 10Foxtrott) [22:46:55] (03PS2) 10Reedy: Remove deleted wikis entries from CentralAuth tables [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/89484 [23:17:31] (03PS2) 10Ori.livneh: Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 [23:20:41] (03CR) 10jenkins-bot: [V: 04-1] Cache ResourceLoader modules in localStorage [core] - 10https://gerrit.wikimedia.org/r/86867 (owner: 10Ori.livneh) [23:20:45] (03Abandoned) 10Ori.livneh: WebWorker ResourceLoader Eliza wat [core] - 10https://gerrit.wikimedia.org/r/89375 (owner: 10Ori.livneh)