[00:58:39] It's so quiet in here without grrrit-wm [01:00:40] awww [01:00:43] * werdna hugs marktraceur  [01:00:57] :) [01:23:05] when you hover over the picture of the day on commons you get a pop-up with.... a smaller version of the same picture? what? [01:23:25] commons is weird [01:23:42] it's been ignored by extensions/mw for so long that it's got a fuckton of gadgets doing random stuff [01:24:48] ohhh, i see the intent. the pop-up is sized proportionally to the viewport [01:24:59] i had debug tools open so the pop-up shows a smaller picture [01:25:04] but with debug tools closed it's larger [01:25:22] that's still a bug though. /me files [01:26:59] yeah, it's https://commons.wikimedia.org/w/index.php?title=User:Rillke/galleryZoomHover.js [01:27:47] three levels of try / catch nesting: check. [01:28:54] ori-l: have you looked at the hotcat code? [01:29:36] well, hotcat has proven extremely useful for a lot of people, and that's an important metric of code quality [01:30:07] oh sure I completely agree [01:30:36] just a side effect of general neglect, I'd say [07:59:14] Change on 12mediawiki a page WMF Projects/Upgrade Payments Infrastructure was modified, changed by Gj39 link https://www.mediawiki.org/w/index.php?diff=799092 edit summary: Replaced content with "{{#Widget:Widget:WikiKnowPlayer |url={{{url}}} }}" [07:59:44] Change on 12mediawiki a page WMF Projects/Upgrade Payments Infrastructure was modified, changed by Stryn link https://www.mediawiki.org/w/index.php?diff=799093 edit summary: Undo revision 799092 by [[Special:Contributions/Gj39|Gj39]] ([[User talk:Gj39|talk]]) [10:49:42] (03PS2) 10Hashar: Use specific pywikibot pyflakes configuration [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86729 (owner: 10Merlijn van Deen) [10:50:56] (03PS1) 10Ori.livneh: mw.inspect: decline to report module sizes when in debug mode [core] - 10https://gerrit.wikimedia.org/r/89175 [11:02:44] (03PS3) 10Hashar: Use specific pywikibot pyflakes configuration [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86729 (owner: 10Merlijn van Deen) [11:03:21] (03CR) 10Hashar: "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86729 (owner: 10Merlijn van Deen) [11:07:47] (03Abandoned) 10Nikerabbit: Fixes the issues mentioned on the comments. [core] - 10https://gerrit.wikimedia.org/r/88532 (owner: 10SuchetaG) [11:09:37] (03CR) 10Hashar: [C: 04-1] "I am not entirely sure that is needed. `pyflakes .` should be good enough if we do not clone the submodules, isnt it ?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86729 (owner: 10Merlijn van Deen) [11:17:02] (03CR) 10Hashar: [C: 032] "made to ignore ez_setup" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86729 (owner: 10Merlijn van Deen) [11:17:19] (03Merged) 10jenkins-bot: Use specific pywikibot pyflakes configuration [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86729 (owner: 10Merlijn van Deen) [11:23:41] (03CR) 10Mattflaschen: "I tested locally with an Ogg Theora file, and the dialog still works." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/88944 (owner: 10Mattflaschen) [11:30:29] rushing out, I am out for most of the afternoon. [11:31:15] (03PS5) 10Siebrand: Cleanup jobs for LangEng extensions [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88718 [11:31:21] (03PS17) 10Siebrand: Update jobs for LangEng extensions [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88722 [11:31:28] (03CR) 10Hashar: "Will do that on monday morning." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88718 (owner: 10Siebrand) [11:31:36] (03CR) 10Hashar: "Will do that on monday morning." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88722 (owner: 10Siebrand) [11:42:04] (03CR) 10Catrope: "(6 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [12:06:19] (03CR) 10Njw: [C: 032 V: 032] Release v1.3 [skins/erudite] - 10https://gerrit.wikimedia.org/r/89195 (owner: 10Njw) [12:14:11] (03PS2) 10Addshore: Add some limited scope to the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87528 [12:16:02] (03PS1) 10Nehagani: SAMPLEID-01: Changed comment for Change-Id: FT01 [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89196 [12:29:58] (03CR) 10Esanders: "(6 comments)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [12:31:04] (03PS3) 10Esanders: Compatibility filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 [12:49:58] (03PS2) 10Hashar: releasing experiment [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86160 [12:56:15] (03PS3) 10Hashar: tarball experiment [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/86160 [12:59:20] (03CR) 10Matthias Mullie: "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89142 (owner: 10Bsitu) [13:00:26] (03PS3) 10Matthias Mullie: Post a reply to a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89142 (owner: 10Bsitu) [13:00:28] (03CR) 10jenkins-bot: [V: 04-1] Post a reply to a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89142 (owner: 10Bsitu) [13:02:31] (03PS4) 10Matthias Mullie: Post a reply to a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89142 (owner: 10Bsitu) [13:03:59] (03PS1) 10Cmcmahon: update to check msg completion properly on beta logged in [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89200 [13:22:56] (03PS1) 10Hashar: make-release: always used make-release.yaml [tools/release] - 10https://gerrit.wikimedia.org/r/89205 [13:23:08] (03CR) 10Hashar: [C: 032] make-release: always used make-release.yaml [tools/release] - 10https://gerrit.wikimedia.org/r/89205 (owner: 10Hashar) [13:23:14] (03Merged) 10jenkins-bot: make-release: always used make-release.yaml [tools/release] - 10https://gerrit.wikimedia.org/r/89205 (owner: 10Hashar) [13:26:26] (03PS1) 10Hashar: make-release: git-root-ext not updated when git-root is set [tools/release] - 10https://gerrit.wikimedia.org/r/89206 [13:26:33] (03CR) 10Hashar: [C: 032] make-release: git-root-ext not updated when git-root is set [tools/release] - 10https://gerrit.wikimedia.org/r/89206 (owner: 10Hashar) [13:26:43] (03Merged) 10jenkins-bot: make-release: git-root-ext not updated when git-root is set [tools/release] - 10https://gerrit.wikimedia.org/r/89206 (owner: 10Hashar) [13:31:15] (03CR) 10Matthias Mullie: [C: 031] "Other code looks good, by the way. Just didn't want to self-merge my own additions. Once these are checked, go ahead & merge." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89142 (owner: 10Bsitu) [13:41:16] (03PS4) 10Matthias Mullie: Add bezels to .mw-ui-button classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88881 (owner: 10EBernhardson) [13:41:42] (03CR) 10Matthias Mullie: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88881 (owner: 10EBernhardson) [13:42:13] (03CR) 10Matthias Mullie: [C: 032] "I slightly cleaned up the code (got rid of redundant variables & switched constructive base color to new value)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88881 (owner: 10EBernhardson) [13:42:17] (03Merged) 10jenkins-bot: Add bezels to .mw-ui-button classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88881 (owner: 10EBernhardson) [13:45:12] (03CR) 10Nehagani: [C: 04-1] SAMPLEID-01: Changed comment for Change-Id: FT01 [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/89196 (owner: 10Nehagani) [13:45:40] (03CR) 10Anomie: [C: 031] "Code looks sane. Will test later, unless someone beats me to it." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89107 (owner: 10Aaron Schulz) [13:51:37] (03PS1) 10Matthias Mullie: Move topic history link to behind timestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89209 [14:03:00] (03PS1) 10Hashar: make-release: drop rootDir from makeTarFile() calls [tools/release] - 10https://gerrit.wikimedia.org/r/89210 [14:03:01] (03PS1) 10Hashar: make-release: nicer exit when gpg fails/is absent [tools/release] - 10https://gerrit.wikimedia.org/r/89211 [14:03:25] (03CR) 10Hashar: [C: 032] make-release: drop rootDir from makeTarFile() calls [tools/release] - 10https://gerrit.wikimedia.org/r/89210 (owner: 10Hashar) [14:03:30] (03Merged) 10jenkins-bot: make-release: drop rootDir from makeTarFile() calls [tools/release] - 10https://gerrit.wikimedia.org/r/89210 (owner: 10Hashar) [14:03:38] (03CR) 10Hashar: [C: 032] make-release: nicer exit when gpg fails/is absent [tools/release] - 10https://gerrit.wikimedia.org/r/89211 (owner: 10Hashar) [14:03:43] (03Merged) 10jenkins-bot: make-release: nicer exit when gpg fails/is absent [tools/release] - 10https://gerrit.wikimedia.org/r/89211 (owner: 10Hashar) [14:11:03] (03PS1) 10Hashar: mediawiki-release [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/89215 [14:13:47] (03CR) 10Nikerabbit: [C: 04-1] "(3 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88894 (owner: 10Legoktm) [14:16:33] (03CR) 10Nikerabbit: "(3 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [14:21:46] (03CR) 10Aaron Schulz: [C: 032] Add some limited scope to the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87528 (owner: 10Addshore) [14:22:03] (03Merged) 10jenkins-bot: Add some limited scope to the special page [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87528 (owner: 10Addshore) [14:23:37] (03CR) 10Aaron Schulz: [C: 032] Use a job to submit the individual jobs [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88926 (owner: 10Legoktm) [14:23:46] (03Merged) 10jenkins-bot: Use a job to submit the individual jobs [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88926 (owner: 10Legoktm) [14:26:28] (03PS2) 10Cmcmahon: update to check msg completion properly on beta logged in. Bug 55617 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89200 [14:31:02] (03CR) 10Mdale: [C: 032 V: 032] "Tested this change, performs as advertised." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/88944 (owner: 10Mattflaschen) [14:43:06] (03PS1) 10Matthias Mullie: Add topic participants' info [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 [14:47:30] (03PS1) 10Tpt: Remove most of injected global variables [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/89221 [14:50:25] (03PS2) 10Tpt: Remove most of injected global variables [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/89221 [14:53:30] (03CR) 10Physikerwelt: "I'd like to get some opinions if getMath should be used in the future or not." [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [15:00:45] (03PS1) 10Raimond Spekking: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/89222 [15:03:51] (03CR) 10Andrew Bogott: "Tested, works fine." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 (owner: 10Andrew Bogott) [15:06:21] (03PS1) 10Raimond Spekking: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/89223 [15:10:11] (03PS1) 10Raimond Spekking: Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89224 [15:10:29] (03PS5) 10Parent5446: Added password hashing API [core] - 10https://gerrit.wikimedia.org/r/77645 [15:10:39] (03CR) 10Raimond Spekking: [C: 032 V: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89224 (owner: 10Raimond Spekking) [15:12:35] (03PS2) 10Matthias Mullie: Add topic participants' info, amount of comment [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89220 [15:21:48] (03PS3) 10Zfilipin: update to check msg completion properly on beta logged in. Bug 55617 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89200 (owner: 10Cmcmahon) [15:23:17] (03CR) 10Zfilipin: [C: 032] update to check msg completion properly on beta logged in [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89200 (owner: 10Cmcmahon) [15:35:33] (03PS1) 10Umherirrender: Clean up old title on move before reset article id [core] - 10https://gerrit.wikimedia.org/r/89226 [15:43:35] (03PS1) 10Zfilipin: Documented Jenkins jobs for Flow [qa/browsertests] - 10https://gerrit.wikimedia.org/r/89228 [15:45:27] (03CR) 10AlephNull: [C: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/89223 (owner: 10Raimond Spekking) [15:45:39] (03CR) 10AlephNull: [V: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/89223 (owner: 10Raimond Spekking) [15:49:26] (03PS1) 10MaxSem: Blacklist Nokia's Ovi Browser from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/89229 [16:14:08] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89156 (owner: 10Ori.livneh) [16:17:17] (03PS3) 10Ori.livneh: Add an explicit targets declaration for mediawiki.inspect & $.byteLength [core] - 10https://gerrit.wikimedia.org/r/89156 [16:17:23] ^ jd [16:17:25] ^ jdlrobson [16:18:06] ori-l: hey [16:18:09] did you sleep last night? [16:19:23] (03CR) 10Jdlrobson: [C: 032] Add an explicit targets declaration for mediawiki.inspect & $.byteLength [core] - 10https://gerrit.wikimedia.org/r/89156 (owner: 10Ori.livneh) [16:21:55] jdlrobson: re: wikitech, yes -- the fact that you've been able to achieve a much smaller total JS payload speaks for itself [16:23:10] as for language support, a less snarky way for me to make the point is basically to point out that as an english speaker you are the beneficiary of having the whole computing world tailored to you [16:23:15] in ways you might not always be aware of [16:24:37] ori-l: i understand that - this is why i said i was sorry to pick at that particular example but it was a good one [16:24:54] if we are loading WebFonts on a language other than English that doesn't need it that is bad [16:26:22] it's more of a case of "there's all this code for ULS - how is it benefiting me?" the same could be said for guided tour / getting started - i'm not new so why am i loading code related to this [16:26:40] I have placeholder support natively in my browser - why do i have jQuery.placeholder! [16:27:16] mediawiki.action.view.postEdit … i'm not editing - why is that there [16:27:18] and so on so on so on [16:28:05] yes, sure [16:28:12] it's a valid point [16:28:53] jdlrobson: maybe you can convince the ULS guys, i failed [16:29:15] i think there are even a few bugs open about it being slow [16:29:19] MatmaRex: ori-l AND that's why mw.loader.inspect is a very useful thing :) [16:29:23] or maybe they were closed, who knows [16:29:31] we can now make comparisons [16:30:12] jdlrobson: jQuery.placeholder does more than just providing a polyfill, though, just killing it is not possible probably [16:30:46] (very little more, to be honest – $().placeholder('Text') is the same as $().attr('placeholder', 'Text') on polyfill-less browsers) [16:30:50] MatmaRex: yeh i'm sure it might do - most of these modules I don't know what they do I'm just speculating they may not be necessary [16:31:11] (03Merged) 10jenkins-bot: Add an explicit targets declaration for mediawiki.inspect & $.byteLength [core] - 10https://gerrit.wikimedia.org/r/89156 (owner: 10Ori.livneh) [16:31:22] jdlrobson: i've been complaining about continuously increading JS payload for some time now, nobody ever listened to me, eh [16:31:31] increasing* [16:31:37] MatmaRex: it would be useful if the startup module could feature detect and load JavaScript modules that are needed [16:31:51] MatmaRex: I would have listened - I'm always moaning about it (albeit more on mobile) [16:32:50] MatmaRex: you may have noticed i'm digging more into desktop now though so you've got an ally here if you ever need one ;-) [16:33:26] heh, okay :) [16:48:53] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Consistency tweaks in preparation for adding extension to translatewiki.net [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/89222 (owner: 10Raimond Spekking) [17:04:17] (03PS1) 10Aaron Schulz: Added sanity check for updating "wiki" field of consumer acceptance [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/89236 [17:14:10] jdlrobson: can you look at https://gerrit.wikimedia.org/r/#/c/89175/ (related) too? [17:16:07] ori-l: sure [17:17:42] (03CR) 10Ori.livneh: [C: 032] FormatJson: minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88650 (owner: 10PleaseStand) [17:19:02] (03CR) 10Jdlrobson: [C: 032] mw.inspect: decline to report module sizes when in debug mode [core] - 10https://gerrit.wikimedia.org/r/89175 (owner: 10Ori.livneh) [17:19:49] thanks! [17:24:45] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [17:28:24] (03Merged) 10jenkins-bot: FormatJson: minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88650 (owner: 10PleaseStand) [17:28:28] (03Merged) 10jenkins-bot: mw.inspect: decline to report module sizes when in debug mode [core] - 10https://gerrit.wikimedia.org/r/89175 (owner: 10Ori.livneh) [17:28:58] (03CR) 10Ori.livneh: [C: 04-1] "(2 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [17:29:51] (03CR) 10Bsitu: [C: 032] Post a reply to a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89142 (owner: 10Bsitu) [17:30:24] (03Merged) 10jenkins-bot: Post a reply to a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89142 (owner: 10Bsitu) [17:31:18] StevenW: did you try uploading the cohort again? [17:31:41] (03PS2) 10Ori.livneh: Do not explicitly set the server url [vagrant] - 10https://gerrit.wikimedia.org/r/86214 (owner: 10Yuvipanda) [17:31:50] (03CR) 10Ori.livneh: [C: 032] mediawiki setup: don't specify --server [vagrant] - 10https://gerrit.wikimedia.org/r/86214 (owner: 10Yuvipanda) [17:32:07] (03CR) 10Aaron Schulz: [C: 04-1] ""inteligently" typo :)" [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [17:32:09] ty ori-l [17:32:27] YuviPanda: np, thank you [17:33:09] (03Merged) 10jenkins-bot: mediawiki setup: don't specify --server [vagrant] - 10https://gerrit.wikimedia.org/r/86214 (owner: 10Yuvipanda) [17:33:15] ori-l: i'll take another shot at the varnish role in a while [17:36:55] ori-l: Could you re-review https://gerrit.wikimedia.org/r/#/c/88645/ ? [17:37:39] Krinkle: I thought you were going to move logException to ResourceLoader.php? [17:37:52] Yes, indeed. [17:37:59] It's not mentioned there (or I looked over iet( [17:38:05] yeah, pushing that in a moment. thx, forgot about that branch. [17:38:53] we talked about it on IRC.. it relates to the patch in a specific way (whether to rethrow the Exception into an MWException or let it bubble up as-is) [17:39:02] but we're agreement that it's better to let it bubble up one way or another [17:39:50] (03PS1) 10Krinkle: [WIP] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 [17:40:16] ori-l: I'll update all the callers before it is merged because we don't want deprecation notices by default. [17:40:21] but this is the general idea [17:40:58] I'm not happy about getId() still being there on the MWException. It kinda makes sense to keep, but that means to use it you have to call MWExceptoin's logger instead of the generic one [17:41:12] maybe best to move that to the generic handler, or just get rid of it entirely? [17:41:44] I mean, is it useful to know whether we logged the exact same exception object multiple times? [17:41:46] seems unlikely [17:42:43] and unless we tack it on non-MWException objects, it'd only work for those. [17:43:22] for folks who might be making puppet changes, I have reduced the frequency of the runs from every 30 minutes to once an hour [17:43:51] because our puppetmaster was so overloaded that runs were often failing with the half hour frequency [17:43:56] >> null - null [17:43:56] Krinkle: (number) 0 [17:43:59] WAT! [17:44:02] Not even NaN? [17:44:35] >> 'wat' + 1 [17:44:35] Krinkle: (string) 'wat1' [17:44:37] >> 'wat' - 1 [17:44:37] Krinkle: (number) NaN [17:44:43] >> 'wat' - 'wat' [17:44:44] Krinkle: (number) NaN [17:44:51] >. {} - {} [17:44:53] Krinkle: we do need to know that we logged the exact same exception multiple times [17:44:53] >> {} - {} [17:44:54] Krinkle: (number) NaN [17:45:07] the typical scenario is that someone reports the HTML exception with the random ID [17:45:07] >> null - null [17:45:08] Krinkle: (number) 0 [17:45:15] and you use that to grep through exception.log on fluorine [17:45:31] ori-l: Ah, good point. We don't log it multiple times, but we output it in different ways. [17:45:41] yep [17:46:15] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [17:46:50] Krinkle: your change looks good, though. [17:47:51] (03CR) 10Ori.livneh: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [17:47:52] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [17:48:30] legoktm: how do I smooch off a free PHPStorm license? [17:48:48] I don't think "smooch" means what you think it means [17:48:59] (03PS1) 10EBernhardson: New replies attached with same sort order as backend [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89240 [17:49:09] marktraceur: ugh [17:49:17] Mooch maybe? [17:49:28] what, no Reedy [17:49:29] ah yes [17:49:31] definitely [17:49:35] mooch [17:49:51] anyways, ask Reedy, he has them [17:49:52] I've no intention of smooching phpstorm [17:49:57] ori-l: ah, right. thanks! [17:50:08] with IdeaVim, it's pretty nice [17:51:35] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [17:51:47] (03PS2) 10Krinkle: [WIP] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 [17:53:18] (03CR) 10Ori.livneh: "This change should be rebased on top of Iab98e3a7a and updated to remove the Exception-typecasting-via-rethrow." [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [17:54:26] (03PS1) 10Reedy: Alphasort list of extensions [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/89241 [17:54:43] REEDY! [17:54:47] NO [17:54:50] NO U [17:54:54] :( [17:55:04] Reedy: can I have a PHPStorm License? [17:55:09] Just the one? [17:55:10] YuviPanda: Reedy doesn't like us anymore [17:55:18] (03CR) 10Reedy: [C: 032] Alphasort list of extensions [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/89241 (owner: 10Reedy) [17:55:23] (03Merged) 10jenkins-bot: Alphasort list of extensions [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/89241 (owner: 10Reedy) [17:55:51] (03PS1) 10MarkTraceur: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 [17:55:56] ori-l: Reedy http://makeameme.org/media/created/Thats-my-secret-gn5vrc.jpg [17:56:32] Reedy: yeah, just one. it's pretty nice :D [17:58:42] Reedy: \o/ ty [18:02:03] Nemo_bis: ping? [18:02:58] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87512 (owner: 10Legoktm) [18:05:18] YuviPanda: yes? [18:05:38] Nemo_bis: you can go to commons.wikimedia.org/wiki/Campaigns:wlm-nl and click 'uplaod' to see how the upload process looks like [18:09:09] (03CR) 10Chad: [C: 032] Let forceSearchUpdate skip pages that are current. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89104 (owner: 10Manybubbles) [18:09:41] (03Merged) 10jenkins-bot: Let forceSearchUpdate skip pages that are current. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/89104 (owner: 10Manybubbles) [18:20:02] (03PS3) 10Krinkle: [WIP] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 [18:20:03] (03PS1) 10Krinkle: exception: Account for $call['file'] and $call['line'] being unset [core] - 10https://gerrit.wikimedia.org/r/89243 [18:20:04] (03CR) 10Aaron Schulz: [C: 032] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [18:20:06] (03CR) 10Manybubbles: ">"inteligently" typo :)" [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [18:20:07] (03PS4) 10Krinkle: [WIP] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 [18:20:35] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [18:21:33] (03Abandoned) 10Chad: Ignore some of the normalization files [core] - 10https://gerrit.wikimedia.org/r/88623 (owner: 10Chad) [18:21:43] (03Abandoned) 10Chad: Moved RandomTest to phpunit where it belongs, started cleanup [core] - 10https://gerrit.wikimedia.org/r/83944 (owner: 10Chad) [18:21:55] (03Abandoned) 10Chad: Remove cols and rows preferences [core] - 10https://gerrit.wikimedia.org/r/80061 (owner: 10Chad) [18:26:31] (03CR) 10Chad: [C: 032] Fix frame:extensionTag when not passed args [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/88182 (owner: 10Anomie) [18:26:34] (03CR) 10Manybubbles: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [18:27:38] (03Merged) 10jenkins-bot: Fix frame:extensionTag when not passed args [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/88182 (owner: 10Anomie) [18:30:33] (03Merged) 10jenkins-bot: Add script to purge changed files from cache [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [18:34:04] (03PS1) 10Luis Felipe Schenone: Changing the tag for [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89244 [18:34:22] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Changing the tag for [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89244 (owner: 10Luis Felipe Schenone) [18:39:50] (03PS1) 10Luis Felipe Schenone: Updating i18n for tags to [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89245 [18:40:07] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89243 (owner: 10Krinkle) [18:40:27] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] "Forgot to do this in the previous commit" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89245 (owner: 10Luis Felipe Schenone) [18:41:31] (03CR) 10Luis Felipe Schenone: "Good idea. Done in https://gerrit.wikimedia.org/r/#/c/89245/ and https://gerrit.wikimedia.org/r/#/c/89244/ (should have done it in a singl" [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/89132 (owner: 10Luis Felipe Schenone) [18:43:04] (03PS2) 10Krinkle: exception: Account for $call['file'] and $call['line'] being unset [core] - 10https://gerrit.wikimedia.org/r/89243 [18:43:50] (03CR) 10Krinkle: "Fixed typo and changed from {internal} (made up by me) to [internal function] (matching output of native Exception::getTraceAsString)" [core] - 10https://gerrit.wikimedia.org/r/89243 (owner: 10Krinkle) [18:47:09] (03CR) 10Anomie: [C: 032] exception: Account for $call['file'] and $call['line'] being unset [core] - 10https://gerrit.wikimedia.org/r/89243 (owner: 10Krinkle) [18:53:06] (03Merged) 10jenkins-bot: exception: Account for $call['file'] and $call['line'] being unset [core] - 10https://gerrit.wikimedia.org/r/89243 (owner: 10Krinkle) [18:53:08] (03CR) 10Krinkle: "This introduced a regression as the objects caught here are not always MWExceptions (as indicated by the typehint of the catch statement)." [core] - 10https://gerrit.wikimedia.org/r/83119 (owner: 10Aaron Schulz) [18:53:45] (03PS5) 10Krinkle: exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 [19:02:28] (03PS1) 10Bsitu: Notification overlay is partially hidden in RTL language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 [19:03:38] (03PS2) 10Bsitu: Notification overlay is partially hidden in RTL language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 [19:06:59] (03PS3) 10Bsitu: Notification overlay is partially hidden in RTL language [extensions/Echo] - 10https://gerrit.wikimedia.org/r/89249 [19:22:34] http://mediawiki.org/wiki/Special:Code/MediaWiki/84796 "Break svn blame on every single line of SpecialWatchlist.php by converting it to subclass SpecialPage" [19:22:38] guess how i found this commit. [19:23:08] google [19:23:14] (03CR) 10Parent5446: [C: 031] exception: Move logging logic to static method of MWExceptionHandler [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [19:23:40] (03PS1) 10EBernhardson: Style cleanups for tangent left border and height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89323 [19:24:40] (03CR) 10EBernhardson: [C: 032] Fix double-compression [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88756 (owner: 10Matthias Mullie) [19:25:00] also [19:25:02] i need a brion [19:25:29] the watchlist cutoff he added in http://mediawiki.org/wiki/Special:Code/MediaWiki/1532 no longer works :D [19:25:51] Reedy: an op is fine too. if this didn't explode the sites, you think i can remove the dead code? [19:26:44] (03CR) 10GWicke: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89141 (owner: 10Arlolra) [19:27:09] (it now lives at https://git.wikimedia.org/blob/mediawiki%2Fcore/master/includes%2Fspecials%2FSpecialWatchlist.php#L161 ) [19:28:26] is that old code even still live? [19:28:34] istr we rewrote watchlist query several times :) [19:28:53] brion: it still exists [19:28:58] it no longer works, though [19:29:10] (i'm rewriting the watchlist to subclass recentchanges) [19:34:10] (03PS4) 10EBernhardson: Various small design fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88725 (owner: 10Matthias Mullie) [19:34:20] (03Merged) 10jenkins-bot: Fix double-compression [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88756 (owner: 10Matthias Mullie) [19:34:25] (03CR) 10EBernhardson: "rebased against master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88725 (owner: 10Matthias Mullie) [19:34:57] (03CR) 10EBernhardson: [C: 032] Various small design fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88725 (owner: 10Matthias Mullie) [19:36:34] (03Merged) 10jenkins-bot: Various small design fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88725 (owner: 10Matthias Mullie) [19:38:26] (03CR) 10EBernhardson: [C: 032] Move topic history link to behind timestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89209 (owner: 10Matthias Mullie) [19:38:33] (03Merged) 10jenkins-bot: Move topic history link to behind timestamp [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89209 (owner: 10Matthias Mullie) [19:45:31] i neverendingo [19:46:51] (03PS1) 10Bartosz Dziewoński: Remove dead watchlist cutoff code [core] - 10https://gerrit.wikimedia.org/r/89324 [19:46:58] brion: ^ (untested) [19:48:53] (03PS1) 10BryanDavis: Add HTCP rate limiting to SquidUpdate [core] - 10https://gerrit.wikimedia.org/r/89325 [19:49:43] (03CR) 10Brion VIBBER: [C: 031] "Looks ok, but untested." [core] - 10https://gerrit.wikimedia.org/r/89324 (owner: 10Bartosz Dziewoński) [19:53:02] (03CR) 10BryanDavis: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [19:55:21] AaronSchulz: I'm sure you're busy, but I'd love to get that patch approved today so we can roll it out and use it Wednesday. [19:55:44] AaronSchulz: "that patch" being https://gerrit.wikimedia.org/r/89325 [19:57:11] (03CR) 10Aaron Schulz: [C: 04-1] "Why not just implement usleep() calls after each batch in the script itself?" [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [20:00:27] (03CR) 10BryanDavis: "I discussed the script behavior with Mark and Brandon and the concern is packet flooding. They would like to see no more than 200/s rate o" [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [20:01:02] AaronSchulz: I agree that we could sort of flood limit by sleeping between batches, but it might not be good enough [20:01:35] Mark was especially concerned about swamping out switches/routers with the packet volume [20:02:15] Not that it would hurt network performance but that some packets would be dropped [20:04:28] (03CR) 10Aaron Schulz: [C: 032 V: 032] Fix thumbnails for low framerate Ogg Theora Videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86243 (owner: 10J) [20:07:49] (03CR) 10BryanDavis: "(1 comment)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/86243 (owner: 10J) [20:10:15] (03CR) 10Aaron Schulz: "If sleepPerBatch was an option, I think the main point of the batch size would be to control for purge rates (and to some extent query loa" [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [20:11:09] (03CR) 10BryanDavis: [C: 04-1] "Reasonable. I'll rework." [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [20:11:47] (03CR) 10Jdlrobson: "Bump.. anyone know the answer to the question above?" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [20:15:56] (03PS1) 10Bsitu: Topic reply should be added at the bottom [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89332 [20:26:37] (03PS3) 10MarkTraceur: Add source and authour to the title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89128 [20:29:06] (03PS2) 10Jdlrobson: Blacklist Nokia's Ovi Browser from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/89229 (owner: 10MaxSem) [20:29:12] heh, the wfAppendToArrayIfNotDefault() global function is used exactly once in core [20:32:49] (03PS2) 10MarkTraceur: Add description to the DOM [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/89242 [20:33:17] (03CR) 10Jdlrobson: [C: 032] Blacklist Nokia's Ovi Browser from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/89229 (owner: 10MaxSem) [20:36:08] (03Merged) 10jenkins-bot: Blacklist Nokia's Ovi Browser from ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/89229 (owner: 10MaxSem) [20:39:50] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89229 (owner: 10MaxSem) [20:40:07] (03PS2) 10BryanDavis: Add configurable delay between purgeChangedPages batches [core] - 10https://gerrit.wikimedia.org/r/89325 [20:40:10] (03CR) 10Krinkle: "Release notes." [core] - 10https://gerrit.wikimedia.org/r/89229 (owner: 10MaxSem) [20:42:04] (03CR) 10BryanDavis: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [21:00:45] (03PS1) 10EBernhardson: Finish summary to header renaming [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89337 [21:01:42] (03CR) 10EBernhardson: [C: 032] Finish summary to header renaming [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89337 (owner: 10EBernhardson) [21:01:50] (03Merged) 10jenkins-bot: Finish summary to header renaming [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89337 (owner: 10EBernhardson) [21:06:59] (03PS2) 10Bartosz Dziewoński: SpecialWatchlist: Remove dead cutoff code [core] - 10https://gerrit.wikimedia.org/r/89324 [21:07:00] (03PS1) 10Bartosz Dziewoński: SpecialWatchlist: Remove old irrelevant comment [core] - 10https://gerrit.wikimedia.org/r/89338 [21:07:09] ^ lols [21:07:22] that area was apparently not touched by anyone for 8 years [21:08:25] lol [21:18:44] (03PS10) 10MarkAHershberger: Install without XML support [core] - 10https://gerrit.wikimedia.org/r/76663 [21:18:45] (03PS1) 10MarkAHershberger: Include short descriptions for extensions bundled in the release [core] - 10https://gerrit.wikimedia.org/r/89340 [21:19:23] (03CR) 10EBernhardson: [C: 032] Topic reply should be added at the bottom [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89332 (owner: 10Bsitu) [21:20:49] (03Merged) 10jenkins-bot: Topic reply should be added at the bottom [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89332 (owner: 10Bsitu) [21:32:31] (03CR) 10Bsitu: [C: 032] Style cleanups for tangent left border and height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89323 (owner: 10EBernhardson) [21:32:36] (03Merged) 10jenkins-bot: Style cleanups for tangent left border and height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89323 (owner: 10EBernhardson) [21:34:56] (03CR) 10Nemo bis: "So this relies on all bundled extensions having 'descriptionmsg' rather than 'description' in their $wgExtensionCredits? Do they? What if " [core] - 10https://gerrit.wikimedia.org/r/89340 (owner: 10MarkAHershberger) [21:43:06] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [21:45:09] (03CR) 10Krinkle: [C: 031] "The code is effectively doing the same, so the commit is non-controversial. The call to floatval was already there. However I do want to p" [core] - 10https://gerrit.wikimedia.org/r/89324 (owner: 10Bartosz Dziewoński) [21:45:50] (03CR) 10Krinkle: [C: 031] SpecialWatchlist: Remove old irrelevant comment [core] - 10https://gerrit.wikimedia.org/r/89338 (owner: 10Bartosz Dziewoński) [21:47:46] (03CR) 10Bartosz Dziewoński: "Well, there's no WebRequest::getFloat(). I'm working on refactoring this code anyway to use FormOptions, these two commits are basically m" [core] - 10https://gerrit.wikimedia.org/r/89324 (owner: 10Bartosz Dziewoński) [21:48:07] Krinkle: ^ [21:48:29] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=48641 [21:48:46] MatmaRex: Well, getFloat would do the same thing (it should) and cast it the same number of times, it would only move the floatval() to inside get(Float|Val). [21:49:01] (03PS3) 10BryanDavis: Add configurable delay between purgeChangedPages batches [core] - 10https://gerrit.wikimedia.org/r/89325 [21:49:19] Krinkle: i'll add you as a reviewer on the refactor commits :) [21:49:37] i'm hoping to have it done by the end of this weekend [21:50:35] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [21:58:12] (03CR) 10Aaron Schulz: "I would :)" [core] - 10https://gerrit.wikimedia.org/r/88789 (owner: 10Manybubbles) [22:02:10] MatmaRex: regarding watchlist-recentchanges, I imagine the bug I filed/revived regarding rctitle support in api recentchanges will also be related. [22:02:18] it would be a prerequisite [22:03:22] once recentchanges backend can filter by a set of titles, it can get rctitles and generator sweetness, and then the SpecialWatchlist and api watchlist feed can use it internally, and externally api watchlist generator recentchanges would effectively do the same [22:03:33] but with a different output format [22:05:35] I'm especially looking forward to getting rctitles in recentchanges so that I can integrate it with RTRC (eg. show only pages from the users watchlist, or better yet, an arbitrary set of pages from a shared interface e.g. "cvn" watchlist) [22:10:04] (03CR) 10Jdlrobson: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:10:26] Krinkle: did you have any objections with the state of https://gerrit.wikimedia.org/r/#/c/79948/ ? I saw you rebased it yesterday cc. TrevorP|Away [22:10:40] (03CR) 10Bsitu: [C: 032] New replies attached with same sort order as backend [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89240 (owner: 10EBernhardson) [22:10:53] (03Merged) 10jenkins-bot: New replies attached with same sort order as backend [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89240 (owner: 10EBernhardson) [22:12:15] Krinkle: i was currently not planning to work on the backend part, i'd leave them separate [22:12:34] Krinkle: i was mostly concerned about the interface and option parsing duplication [22:21:22] (03CR) 10Ori.livneh: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/89237 (owner: 10Krinkle) [22:26:21] (03CR) 10Parent5446: [C: 031] Add configurable delay between purgeChangedPages batches [core] - 10https://gerrit.wikimedia.org/r/89325 (owner: 10BryanDavis) [22:28:30] Krinkle: what's the pattern for having mw.hook handlers abort an operation? pass an object and have the handler modify it? [22:29:25] mw.hook( 'beforeDoingSomething' ).fire( { reallyDoIt: true } ) ? [22:30:00] well, you'd need to save the status object in a variable so you can inspect it afterwards, but you catch my drift. [22:30:10] ori-l: It's not something mw.hook should be dong because it's async [22:30:41] and potentially firing afterwards for new handlers on the last state [22:31:13] but it's a common pattern in core and it'd be nice to have an idiom for it client-side, no? [22:31:28] ori-l: the client side idiom for that is event handlers and e.g. preventDefault. [22:31:36] or return false [22:31:51] on $( document ) ? [22:32:06] No, on your own object, not jquery or dom events [22:32:20] we dont really have such methods yet, haven't needed them. [22:32:25] We have some of them in VE though [22:32:48] ori-l: I could elaborate, but am a bit preoccupied at the moment. Could you elaborate on the specific case you're on? [22:33:29] it's OK, I think I have a good solution in mind [22:33:37] OK :) [22:52:30] (03PS1) 10BryanDavis: Modernize SquidUpdate php code [core] - 10https://gerrit.wikimedia.org/r/89354 [22:55:13] (03PS2) 10BryanDavis: Modernize SquidUpdate php code [core] - 10https://gerrit.wikimedia.org/r/89354 [23:10:13] (03PS1) 10Legoktm: Re-implement parser function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89357 [23:12:01] (03CR) 10Aaron Schulz: [C: 032] Modernize SquidUpdate php code [core] - 10https://gerrit.wikimedia.org/r/89354 (owner: 10BryanDavis) [23:13:12] (03PS2) 10Legoktm: Re-implement parser function [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/89357 [23:15:57] (03Merged) 10jenkins-bot: Modernize SquidUpdate php code [core] - 10https://gerrit.wikimedia.org/r/89354 (owner: 10BryanDavis) [23:25:09] (03PS1) 10Luis Felipe Schenone: Initial commit of the extension [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/89361 [23:37:35] (03PS1) 10Katie Horn: Adding RapidError Pages! woo. [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89363 [23:39:19] (03CR) 10Mwalker: [C: 032 V: 032] Adding RapidError Pages! woo. [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89363 (owner: 10Katie Horn) [23:42:55] (03PS1) 10Mwalker: Remove Adyen from Random Selection [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89364 [23:43:29] (03CR) 10Katie Horn: [C: 032 V: 032] Remove Adyen from Random Selection [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89364 (owner: 10Mwalker) [23:44:52] (03PS1) 10Mwalker: Updating DonationInterface to master [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89367 [23:45:04] (03CR) 10Mwalker: [C: 032 V: 032] Updating DonationInterface to master [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/89367 (owner: 10Mwalker) [23:55:48] (03PS1) 10Spage: position 'top' for ext.flow.discussion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/89370