[00:09:36] (03CR) 10EBernhardson: "something about this just feels hacky ... i dunno. Suggestions prefered." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88881 (owner: 10EBernhardson) [00:14:28] ori-l, I heard there was a data issue with EL. [00:14:35] Can you send info to eventlogging-alerts? [00:15:12] (03CR) 10Catrope: [C: 04-1] "(1 comment)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88244 (owner: 10Ori.livneh) [00:22:05] Wow, I think I've totally nuked my local wiki by importing the information template [00:23:09] marktraceur, yeah, it has a lot of dependencies. [00:23:11] I have a fake one. [00:23:26] That sounds way smarter [00:23:36] Sadly I need the HTML it outputs [00:24:19] You'll need Scribunto for a start, if you don't already have it. [00:24:31] It's enabled [00:24:46] My requests are all coming back with "request took more than 30 seconds, lol" [00:25:01] $wgTrollfaceErrorMessages = true; [00:25:49] moar time! [00:26:17] Reedy: If a request for a file page is taking 30 seconds there's a bigger problem [00:26:55] if you're including a tonne of templates... [00:27:02] and a slow machine [00:27:02] and [00:27:03] and [00:27:17] Reedy: I'm not, the file page is empty right now...er, maybe not, never mind [00:27:20] IGNORE ME [00:27:27] /ignore marktraceur [00:27:58] http://www.youtube.com/watch?v=6y2gdLDzjt0 [00:29:07] Or rather http://www.youtube.com/watch?v=6y2gdLDzjt0 [00:29:59] (03PS2) 10Ori.livneh: Log VisualEditorDOMRetrieved latency data via EventLogging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88244 [00:30:02] (03CR) 10Mattflaschen: "Yeah, I logged out each time." [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [00:31:26] 300 seconds [00:31:28] HERE WE GO [00:31:38] gl;hf [00:31:55] My computer might melt though [00:33:46] (03CR) 10Ori.livneh: "Since this requires a bit of work to test (you need to set up EventLogging and WikimediaEvents) here's a screenshot as proof :) http://i.i" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88244 (owner: 10Ori.livneh) [00:37:19] (03PS1) 10Luis Felipe Schenone: Minor fix with the message keys [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/88907 [00:42:14] The wonders in fact do cease to raddle your noodle, none of them like the buns for it is not your average tomato. [00:42:29] Consider that when gerrit tries to eat your foot. [00:42:43] Isarra: Wise words [00:43:03] * Isarra hugs marktraceur. [00:43:10] Aw. [00:43:14] * marktraceur hugs back [00:43:47] Isarra: Is gerrit eating your foot, or were you offering advice without provocation? [00:44:33] It already ate it. [00:44:40] <^d> wheee \o/ https://github.com/facebook/hiphop-php/pull/1144 [00:45:12] Sadness, Isarra [00:45:23] ^d: nice! [00:45:35] this helps a bunch of additional tests pass, right? [00:45:39] uzzah ^d [00:45:43] Huzzah even [00:45:54] <^d> No, I'm just kinda excited because it's my first pull request merged :) [00:46:11] ah. well, yes, that is pretty cool regardless :) [00:46:13] <^d> If my other one gets merged it'll shut up a ton of notices though. [00:47:41] (03PS2) 10Luis Felipe Schenone: Fixes to the message keys [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/88907 [00:48:47] (03CR) 10Luis Felipe Schenone: "Thanks Siebrand, see https://gerrit.wikimedia.org/r/#/c/88907/" [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/87919 (owner: 10Luis Felipe Schenone) [00:49:45] Argh [00:49:50] Perform import on one wiki [00:49:53] Success [00:49:58] Perform it on nearly identical wiki [00:50:29] Crash everything [00:50:58] How not identical is it? [00:53:18] <^d> This is some weird code. [00:54:08] Isarra: Not that much not identical [00:54:25] I'm in the process of fucking information and writing my own implementation that won't, you know, crash my wiki [00:55:24] Generally not crashing is good. [00:55:42] I'm a fan [00:59:23] marktraceur: I hear if you put try catches everywhere, and then just carry on, that increases reliability [01:00:55] Reedy: Cool, I'll try that [01:01:03] Pun not intentional at first but I left it in [01:04:28] :D [01:05:55] (03CR) 10Chad: "This introduced a broken test for me on zend & hhvm: http://p.defau.lt/?y5QqdLlRUZvM0i_Yyl5nyg" [core] - 10https://gerrit.wikimedia.org/r/88533 (owner: 10BryanDavis) [01:06:04] <^d> bd808 ^ [01:11:42] Woohoo [01:11:46] Enough that I can test woohoo [01:12:10] <^d> Huh? [01:12:10] ^d: patch to get rid of that test case. It's not very useful anyway. [01:14:04] <^d> Why on earth would someone give a non-string to addIdentifierQuotes() anyway? ;-) [01:15:35] (03PS1) 10Chad: Remove silly test cases that are likely to fail [core] - 10https://gerrit.wikimedia.org/r/88915 [01:16:55] (03CR) 10Chad: [C: 032] Remove silly test cases that are likely to fail [core] - 10https://gerrit.wikimedia.org/r/88915 (owner: 10Chad) [01:21:05] (03Merged) 10jenkins-bot: Remove silly test cases that are likely to fail [core] - 10https://gerrit.wikimedia.org/r/88915 (owner: 10Chad) [01:25:10] (03PS1) 10Legoktm: Move all JS and CSS into modules/ [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88916 [01:38:58] (03PS1) 10Legoktm: Don't create a duplicate WikiPage object in getParserFunctionTargets [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88917 [01:41:43] Hi anomie. Is OAuth ready for bugs? [01:42:06] anomie: I'm not sure what stage it's in and I don't want to be annoying. [01:42:11] But I have a few I could file. [01:42:19] Elsie: Yes, please file any bugs you see. [01:42:32] Are all current bugs under the OAuth extension in Bugzilla? [01:43:10] https://bugzilla.wikimedia.org/buglist.cgi?component=OAuth&resolution=---&list_id=240270 [01:43:13] Short list. [01:43:19] I have mostly stupid cosmetic bugs. [01:43:27] I assume the hard part is implemented well. ;-) [01:46:26] Elsie: Yes, the hard part seems to be reasonably functional. [01:47:13] I hope your cosmetic issues don't conflict with what the UX team had us do. ;) [01:47:28] I commented on the buttons bug. [01:47:37] Those two grey buttons are a bit blah. [01:47:46] The other bugs I was about to file are... [01:47:57] privacy policy link is broken (goes to Project:privacy policy) [01:48:11] application description hyperlinks don't seem to work [01:48:21] author and app name should be hyper-linkable [01:48:25] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88915 (owner: 10Chad) [01:48:33] "wiki project ID" means nothing to me [01:48:44] "allowed on wiki" field needs autocomplete or something else to make it easier [01:48:55] ** perhaps some helper JS to know how to enter multiple wikis [01:49:07] "projects on this site" is super-confusing [01:49:56] That was pretty much it. [01:50:08] And some of the text is super-confusing to read. [01:50:23] "Use the form below to revoke ..." text, I mean. [01:51:27] anomie: Is it possible to specify multiple wiki project IDs? [01:51:34] Or is it all or none? [01:51:47] Err, all, one, or none. [01:52:01] Elsie: I believe it's all or one ("none" wouldn't make sense), but I'm not 100% sure. [01:53:20] I think it should rely on domain names. I'm not sure what a wiki project ID is. [01:53:33] And I doubt anyone else will know. Copying and pasting the domain is easy enough, though. [01:54:10] I don't even know, and I should. [01:54:49] I think it's equivalent to DB name. [01:54:55] A "wiki project ID" is like enwiki or dewiktionary. [01:54:58] I wonder if it has input validation. [01:55:01] Right, so DB name. [01:55:16] Which are historical and quirky. [01:55:27] wiki is short of wikipedia, except when it's not. [01:55:31] s/of/for/ [01:55:42] lol [01:55:53] And it's mediawikiwiki, not mediawiki. [01:56:21] I'l file some bugs. [01:56:25] Though maybe not tonight. [01:56:53] Lazy fuck. [01:57:09] The ice cream isn't going to eat itself. [01:57:28] Multitask boy! [01:59:08] Isn't there this horrible variable class thingy thing that maps all the ids to the sane names and stuff? [01:59:25] A really horrible awful thing. [01:59:34] The sort of thing you send after bad children to eat them. [01:59:43] It tired to eat my other foot. [02:01:59] <^d> Elsie: I'm eating ice cream too. Much more fun than filing bugs :) [02:02:23] <^d> Isarra: Huh? [02:02:23] Just don't get confused, or you might end up eating bugs and filing ice cream [02:02:43] ^d: It was horrible. [02:02:47] HORRIBLE. [02:02:55] This ice cream thing sounds like a much better idea. [02:04:39] I'll * [02:06:22] Isarra: $wgConf? [02:07:42] Maybe. [03:13:03] (03PS1) 10Legoktm: Remove outdated 'wp' prefix from form [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88918 [03:35:16] (03CR) 10Bsitu: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84880 (owner: 10Aaron Schulz) [03:51:04] (03PS1) 10Legoktm: Store entire db to url mapping in memcache [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88919 [03:56:47] (03Abandoned) 10Ebrahim: Native digits on pref [core] - 10https://gerrit.wikimedia.org/r/88767 (owner: 10Ebrahim) [04:04:05] (03PS1) 10Legoktm: Replace all usage of $wgDBname with wfWikiId() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88920 [04:04:12] (03CR) 10jenkins-bot: [V: 04-1] Replace all usage of $wgDBname with wfWikiId() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88920 (owner: 10Legoktm) [04:04:17] :< [04:09:40] (03CR) 10Parent5446: ":/ why the hell do we have a test passing array() has a MySQL identifier?" [core] - 10https://gerrit.wikimedia.org/r/88533 (owner: 10BryanDavis) [04:14:40] (03PS2) 10Legoktm: Replace all usage of $wgDBname with wfWikiId() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88920 [04:20:09] (03CR) 10BryanDavis: "Chad removed the array() input test in Ibebf5d32196ac5b80cd477aedfef982fd2c9a0e6." [core] - 10https://gerrit.wikimedia.org/r/88533 (owner: 10BryanDavis) [04:24:47] (03CR) 10Physikerwelt: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [04:31:10] (03CR) 10Chad: "Not just hhvm, Zend too. See my pastebin." [core] - 10https://gerrit.wikimedia.org/r/88533 (owner: 10BryanDavis) [04:31:27] (03CR) 10Physikerwelt: "That's the way the node-script died:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/88678 (owner: 10GWicke) [04:37:34] (03CR) 10Daniel Friesen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [04:44:19] (03PS1) 10Spage: Minimal supporting for Selenium browser tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88923 [04:44:20] (03PS1) 10Spage: "Given I am Logged in" support files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88924 [04:44:22] (03PS1) 10Spage: Actual Flow browsertests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88925 [04:49:08] (03CR) 10Physikerwelt: "You can inspect the error in the following way." [extensions/Math] - 10https://gerrit.wikimedia.org/r/88678 (owner: 10GWicke) [05:01:53] (03PS1) 10Legoktm: Use a job to submit the individual jobs [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88926 [05:04:42] ~36 degrees C in Sydney today [05:04:52] (97F) [05:04:57] in mid to early spring [05:05:04] * werdna drinks a few liters of water [05:13:51] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [05:15:05] (03CR) 10Physikerwelt: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [05:32:46] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [05:33:41] (03CR) 10Mattflaschen: [C: 04-1] "As I said in patch set 4, change mediawiki.api.edit to use the general functionality. Otherwise, this introduces code duplication." [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit) [05:45:35] (03PS4) 10GWicke: Fix SVG glyphs and make the service more robust [extensions/Math] - 10https://gerrit.wikimedia.org/r/88678 [05:45:48] (03CR) 10jenkins-bot: [V: 04-1] Fix SVG glyphs and make the service more robust [extensions/Math] - 10https://gerrit.wikimedia.org/r/88678 (owner: 10GWicke) [05:47:01] (03PS5) 10GWicke: Fix SVG glyphs and make the service more robust [extensions/Math] - 10https://gerrit.wikimedia.org/r/88678 [05:57:14] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [05:58:02] (03CR) 10Nikerabbit: [C: 032] "Wow jslint seems to have this file." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/88897 (owner: 10Krinkle) [05:58:07] (03Merged) 10jenkins-bot: Minor clean up of css/js [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/88897 (owner: 10Krinkle) [06:09:36] (03CR) 10Physikerwelt: "ok this is much better." [extensions/Math] - 10https://gerrit.wikimedia.org/r/88678 (owner: 10GWicke) [06:15:32] @_@ PHP's copying of array() looks even more messed up now. [06:20:49] (03Abandoned) 10Physikerwelt: Fix: Glyphs are not copied [extensions/Math] - 10https://gerrit.wikimedia.org/r/87647 (owner: 10Physikerwelt) [06:21:00] (03Abandoned) 10Physikerwelt: WIP: Ideas to make the node worker more robust [extensions/Math] - 10https://gerrit.wikimedia.org/r/87699 (owner: 10Physikerwelt) [06:33:22] (03CR) 10Raimond Spekking: [C: 04-1] "(1 comment)" [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/88907 (owner: 10Luis Felipe Schenone) [06:39:08] (03CR) 10Nikerabbit: [C: 032] Avoid cache issues by showing error messages in content language [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/88791 (owner: 10Legoktm) [06:40:26] (03CR) 10Physikerwelt: [C: 04-1] "Content length wrong" [extensions/Math] - 10https://gerrit.wikimedia.org/r/88678 (owner: 10GWicke) [06:46:25] (03PS1) 10Rfaulk: mod - allow git config to be overriden. [sartoris] - 10https://gerrit.wikimedia.org/r/88930 [06:46:25] (03PS1) 10Rfaulk: fix - initializtion of the test repo, preventing override of class method names in decorator. [sartoris] - 10https://gerrit.wikimedia.org/r/88931 [06:46:43] (03CR) 10Rfaulk: [C: 032 V: 032] mod - allow git config to be overriden. [sartoris] - 10https://gerrit.wikimedia.org/r/88930 (owner: 10Rfaulk) [06:46:54] (03CR) 10Rfaulk: [C: 032 V: 032] fix - initializtion of the test repo, preventing override of class method names in decorator. [sartoris] - 10https://gerrit.wikimedia.org/r/88931 (owner: 10Rfaulk) [07:00:09] ori-l, et al, added instructions for debugging MW PHP in Emacs (https://www.mediawiki.org/wiki/MediaWiki-Vagrant/Advanced_usage#Emacs_with_geben) [07:00:41] Thanks to Ori, Yurik, and everyone who helped with the already existing XDebug docs and Vagrant role. [07:04:31] did it work? [07:04:46] ori-l, yeah. :) [07:05:14] It's still downloading the files with TRAMP (emacs SSH stuff) rather than understanding the local files are the same ones. [07:05:17] that is pretty leet, i have to say [07:05:22] But that's not really a big deal. [07:05:37] Since when you edit the local file it reflects anyway thanks to Vagrant. [07:05:39] Thanks. :) [07:05:46] Wasn't really bad at all. [07:06:01] Now I'm changing the keybindings to match Firebug (it uses weird ones by default). [07:06:13] emacs? i'm shocked [07:06:21] Well, some random emacs mode. [07:06:29] And they're one character, just weird characters. [07:06:37] Like 'g' for run. [07:08:22] what sort of things is it useful for? [07:09:02] Is what? [07:12:16] Emacs in general? [07:13:52] ^ ori-l [07:14:14] no, stepping through code with Xdebug [07:15:00] ori-l, oh, I'm hoping it will result in less squinting through the log files and make it easier to debug https://gerrit.wikimedia.org/r/#/c/65867/ to start. [07:15:08] And tomorrow the world. :) [07:15:19] No more wfDebugDieBacktrace. [07:15:42] i started setting it up when i was dealing with the comment-handling in lessphp [07:16:16] i ended up doing it the way i've always done it, which is to add printfs (well, echo / var_dump) _everywhere_ [07:16:49] I have a history of first doing it that way with a new language/environment, then eventually accepting the debugger. [07:17:27] It's a combination of the debugging tools improving and me doing enough research to use them properly. [07:18:53] <^d> https://github.com/facebook/hiphop-php/pulls/demon wheee [07:18:55] <^d> I've been busy [07:20:18] ^d, cool. :) [07:32:22] ori-l, do you think it would be useful for me to put the code for having it use Firebug's key bindings (which are more similar to other debuggers too I think) on MW.org? [07:32:53] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/88907 (owner: 10Luis Felipe Schenone) [07:32:55] sure, why not? [07:33:22] g'day [07:33:30] Alright, will do. [07:33:31] Hey, siebrand [07:33:37] How is life if the wikiverse today? [07:33:47] <^demon|zzz> It's time for bed :) [07:34:05] ^demon|zzz: No it's not. I woke up a little over an hour ago. [07:34:17] <^demon|zzz> I should've gone to bed an hour ago ;-) [07:34:23] * siebrand smiles. [07:34:45] hey siebrand [07:35:15] hey ori-l. Congrats on the public clarity. [07:35:24] (03CR) 10Zfilipin: "(1 comment)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88249 (owner: 10Plavi) [07:35:48] ah, thanks! [07:35:57] I try not to participate in "reply to all" threads about people's new roles, so no email congrats from me :) [07:37:30] yeah, me too. or i do, but inconsistetly [07:39:07] I try to participate inconsistently. ;) [07:39:42] But yeah, it's pretty cool, and I really do hope we can work together on perf stuff. It certainly impacts the Growth team's work a lot. [07:40:29] oh did you see mw.loader.inspect? it's a small thing but kinda nifty; i'm pretty pleased with that [07:40:43] if you're running master do mw.loader.inspect() in your debug console [07:41:00] works better in chrom* than ff due to the availability of console.table [07:42:42] ori-l: When did that land? [07:42:59] 10 hours ago or so, timo merged it [07:43:09] Ah, I still need to update then. [07:43:17] Hmm, "Unknown dependency: mediawiki.inspect" [07:43:17] Lemme put it on twn now... [07:43:51] superm401: browser cache? [07:44:01] Yeah, let me hard-refresh. [07:44:56] (03PS2) 10Zfilipin: Fixed Hotcat test - plural/singular for Categories link [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88249 (owner: 10Plavi) [07:45:05] ori-l, very cool! [07:45:40] yay, it worked [07:45:46] That measure should track best with parse time (as well as runtime with a weaker correlation). [07:45:55] ori-l: In firebug, I just get "function()" as return value? [07:46:00] Although bandwidth is a real issue, gzip will throw the correlation out of whack. [07:46:13] Also, caching obviously. [07:46:34] yeah, these are all valid limitations [07:46:55] But it's still an awesome gut check. [07:46:58] are you invoking it? don't forget the parens: mw.loader.inspect() [07:47:03] (03PS1) 10Hiong3-eng5: added classes and collections to owd csv [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/88936 [07:47:19] (03PS3) 10Zfilipin: Fixed Hotcat test - plural/singular for Categories link [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88249 (owner: 10Plavi) [07:47:39] siebrand: works for me on twn [07:47:51] It's mw.loader.inspect() [07:47:59] It also raises the question, why is jquery.ui loaded on the home page? [07:48:21] (03CR) 10Zfilipin: [C: 031] "I have implemented the change I have suggested in patch set 1. As far as I am concerned this can be merged into master. Since I made the l" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88249 (owner: 10Plavi) [07:49:00] superm401: on your dev instance or twn? [07:49:06] siebrand: so did it work or not? [07:49:08] Mine, I'll check there. [07:49:17] ori-l: It worked. Using mw.loader.inspect() not mw.loader.inspect [07:49:29] ah, yep [07:49:39] Not on TWN [07:49:53] not on my dev instance either, so maybe an extension? [07:49:56] ori-l, next can you implement rdepends? :) [07:50:19] hrm, might be possible actually [07:51:18] that's a pretty good idea [07:51:18] It would be useful; grepping for now [07:53:49] Looks like jquery.mwEmbedUtil [07:55:41] I think Munaf brought this up a couple times (not specifically flagging MwEmbed, but the fact that we were pulling in so much jquery.ui) [08:01:11] Going to file a bug, then submit a patch. [08:01:40] for jquery.mwEmbedUtil or dependency resolution? [08:02:06] jquery.mwEmbedUtil [08:02:28] rdependswould be great, and it's all yours if you want to work on it. [08:12:03] Hmm, MwEmbedSupport doesn't even have a Bugzilla component. [08:14:44] (03PS1) 10Hashar: whitelist Santhosh Thottingal [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88938 [08:15:47] (03CR) 10Hashar: [C: 032] "Added Siebrand / Niklas as reviewer for information. This change will cause Zuul to trigger unit tests whenever Santhosh send a patch in " [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88938 (owner: 10Hashar) [08:15:55] (03Merged) 10jenkins-bot: whitelist Santhosh Thottingal [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88938 (owner: 10Hashar) [08:28:44] (03PS6) 10Yuvipanda: Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 [08:28:49] ori-l: definitely cleaner now ^ [08:29:05] thanks for the comments! [08:29:16] (03CR) 10jenkins-bot: [V: 04-1] Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [08:29:20] now what [08:31:43] (03PS7) 10Yuvipanda: Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 [08:33:09] AaronSchulz: what excatly do you mean by 'functional' in https://gerrit.wikimedia.org/r/#/c/87887/? it doesn't work for you? or is it the other type of 'functional'? [08:34:44] heh, I'm in the 'dead' zone, I guess. Should come back later [08:38:27] (03CR) 10VitaliyFilippov: ")) can you just merge it and then think of a better solution? )) because the MW master is broken until this fix is merged..." [core] - 10https://gerrit.wikimedia.org/r/88443 (owner: 10VitaliyFilippov) [08:40:46] (03PD1) 10Addshore: Add tests for Wikidata repo [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88734 [08:55:03] (03CR) 10Hashar: "Something went wrong when I did the deploy, the jobs did not get updated as spotted by Timo https://bugzilla.wikimedia.org/show_bug.cgi?id" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88743 (owner: 10Siebrand) [09:08:19] ori-l, found an issue with inspect in debug mode: https://bugzilla.wikimedia.org/show_bug.cgi?id=55553 [09:08:34] Shouldn't be overly hard to fix. [09:08:36] superm401: I sent ori to sleep :) [09:08:53] I should go too; he's 3 hours earlier... [09:09:07] * hashar send superm401 to bed. [09:09:08] :-] [09:09:24] Fails to parse, grammar error. [09:09:30] ah yeah [09:09:38] Must get jquery.ui.dialog to stop loading on main page for no reason. [09:13:12] (03CR) 10Nikerabbit: "That will take a while..." [core] - 10https://gerrit.wikimedia.org/r/84475 (owner: 10Ejegg) [09:19:16] (03CR) 10Hashar: "(1 comment)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88734 (owner: 10Addshore) [09:21:05] (03PS2) 10Hashar: jobs for Wikidata extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88734 (owner: 10Addshore) [09:21:27] (03CR) 10Hashar: [C: 032] "mwext-Wikidata-jslint" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88734 (owner: 10Addshore) [09:21:47] (03Merged) 10jenkins-bot: jobs for Wikidata extension [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88734 (owner: 10Addshore) [09:25:17] (03PS1) 10Hashar: triggers for mediawiki/extensions/Wikidata [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88942 [09:26:04] (03CR) 10Hashar: [C: 032] triggers for mediawiki/extensions/Wikidata [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88942 (owner: 10Hashar) [09:26:28] (03Merged) 10jenkins-bot: triggers for mediawiki/extensions/Wikidata [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88942 (owner: 10Hashar) [09:29:44] (03PS1) 10Mattflaschen: Remove dialogFitWindow and jquery.ui.dialog from mwEmbedUtil [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/88943 [09:34:13] (03PS1) 10Mattflaschen: Correct mw.PopUpMediaTransform dependency [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/88944 [09:36:01] (03CR) 10Mattflaschen: [C: 04-1] "Someone needs to test this to make the dialog still shows when it should. I only verified that it doesn't load jquery.ui.dialog when it d" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/88944 (owner: 10Mattflaschen) [09:37:17] (03CR) 10Mattflaschen: "dialogFitWindow is used nowhere on the cluster, at least according to my grep of wmf/1.22wmf20. However, if someone knows somewhere else " [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/88943 (owner: 10Mattflaschen) [09:53:29] (03PS1) 10Nehagani: local commit in comment [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/88948 [10:04:18] (03CR) 10Hashar: "Refreshed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88743 (owner: 10Siebrand) [10:05:07] @rss+ enplanet http://en.planet.wikimedia.org/atom.xml [10:05:08] Item was inserted to feed [10:24:46] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88895 (owner: 10Legoktm) [11:11:57] (03CR) 10Diptimoh: [C: 031] "Test Approving" [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/88948 (owner: 10Nehagani) [11:12:29] (03CR) 10Diptimoh: "Someone else please review too!" [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/88948 (owner: 10Nehagani) [11:34:44] (03CR) 10Matthias Mullie: "(4 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88881 (owner: 10EBernhardson) [12:44:40] (03PS3) 10Luis Felipe Schenone: Fixes to the message keys [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/88907 [12:46:47] (03PS4) 10Luis Felipe Schenone: Fixes to the message keys [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/88907 [12:47:56] (03PS2) 10Addshore: Add another job for wikibase-repoapi [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88488 [12:54:30] (03PS1) 10Addshore: Fix which tests we run when [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 [12:55:24] (03PS2) 10Addshore: Fix wikibase tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 [13:01:19] (03CR) 10Jeroen De Dauw: [C: 031] Add another job for wikibase-repoapi [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88488 (owner: 10Addshore) [13:02:01] (03CR) 10Zfilipin: [C: 04-1] "(11 comments)" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [13:02:57] (03CR) 10Jeroen De Dauw: [C: 031] Fix wikibase tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:03:21] (03CR) 10Hashar: [C: 032] "good, deployed." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88488 (owner: 10Addshore) [13:03:41] (03Merged) 10jenkins-bot: Add another job for wikibase-repoapi [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88488 (owner: 10Addshore) [13:09:48] (03CR) 10Hashar: [C: 04-1] "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:16:04] (03CR) 10Jeroen De Dauw: "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:19:58] (03CR) 10Hashar: "So mwext-Wikibase-testextensions-master turns out to be relatively slow, so it is skip on test to speed up feedback. But the team do care" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:20:39] (03CR) 10Addshore: "(1 comment)" [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:22:08] (03PS3) 10Hashar: Fix wikibase tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:22:46] (03CR) 10Hashar: [C: 032] Fix wikibase tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:22:54] (03Merged) 10jenkins-bot: Fix wikibase tests [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88974 (owner: 10Addshore) [13:54:59] (03CR) 10Zfilipin: [C: 032] Minimal supporting for Selenium browser tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88923 (owner: 10Spage) [13:56:23] (03PS1) 10Jeroen De Dauw: Do not use colors by default for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/88984 [13:57:58] (03CR) 10Zfilipin: "Yes, we will move more code into selenium-mediawiki gem, but we are not there yet." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88924 (owner: 10Spage) [14:00:10] (03PS2) 10Zfilipin: "Given I am Logged in" support files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88924 (owner: 10Spage) [14:00:23] (03CR) 10Zfilipin: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88924 (owner: 10Spage) [14:01:32] (03PS1) 10Hashar: Hooks::displayTabs() missed wfProfileOut() [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/88986 [14:01:39] (03CR) 10Zfilipin: [C: 031] "I have implemented the change that I have suggested in patch set 1:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88924 (owner: 10Spage) [14:01:54] (03CR) 10Hashar: "caused profiling error in displayTabs, it exit with wfProfileIn() instead of wfProfileOut()." [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/8005 (owner: 10Reedy) [14:03:40] I'm trying to convert a maintenance script to use the maintenance class. [14:03:46] (03CR) 10Jeroen De Dauw: [C: 032] "Stupid profiling code is stupid :)" [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/88986 (owner: 10Hashar) [14:03:58] The old script uses a helper object, that echos output. [14:04:42] is there a way to route that output the proper way (I assume through Maintenance::output(), but that helper object doesn't know about that, or does it?) [14:06:02] https://gerrit.wikimedia.org/r/#/c/88985/1/scripts/sync-group.php line 149 and line 286. [14:06:43] siebrand: which script ? [14:07:26] hashar: https://gerrit.wikimedia.org/r/#/c/88985/1/scripts/sync-group.php line 149 and line 286. [14:07:48] (gotta go get my son from judo - back in 25) [14:07:56] happy judo :-] [14:08:11] ippon [14:08:35] I can just static the heck out of things, but having it contained to a class is nice... [14:08:35] (03PS3) 10MarkAHershberger: let us point extension root to some other place [tools/release] - 10https://gerrit.wikimedia.org/r/86269 (owner: 10Hashar) [14:09:55] (03CR) 10MarkAHershberger: [C: 032] let us point extension root to some other place [tools/release] - 10https://gerrit.wikimedia.org/r/86269 (owner: 10Hashar) [14:10:57] (03PS1) 10Esanders: Compatability filters for BetaFeatures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 [14:30:11] @trustadd .*@wikimedia/qchris trusted [14:30:11] Successfuly added .*@wikimedia/qchris [14:30:29] qchris: ^^^ [14:30:43] might want admin instead [14:30:56] @trustadd .*@wikimedia/qchris admin [14:30:56] Permission denied [14:31:00] ah cant [14:31:19] It's ok. Thanks :-) [14:32:09] (03CR) 10Akosiaris: "Any reason we have not merged this ?" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/73928 (owner: 10Hashar) [14:34:37] (03CR) 10Zfilipin: [C: 04-1] "(3 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88925 (owner: 10Spage) [14:37:08] (03PS1) 10Hashar: profiling: add newlines to profile errors [core] - 10https://gerrit.wikimedia.org/r/88990 [14:37:33] (03CR) 10Zfilipin: "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88925 (owner: 10Spage) [14:37:39] Need help with wm-bot? [14:37:43] (03CR) 10Hashar: "lack of time mainly. Lets add them." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/73928 (owner: 10Hashar) [14:37:48] (03PS2) 10Hashar: operations-puppet-spec [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/73928 [14:37:50] hashar: qchris ^^ [14:38:07] I am getting too popular [14:38:10] I need a new nickname :D [14:38:26] T13: wanted to add qchris to some group [14:38:27] @whoami [14:38:27] You are root identified by name .*@wikimedia/Technical-13 [14:38:35] T13: seems trusted is good enough for him right now :-] [14:38:37] @whoami [14:38:37] You are trusted identified by name .*@mediawiki/..* [14:38:41] Which group [14:38:44] trusted [14:38:47] it is done already [14:38:59] Okay, do you need admin? [14:39:02] I am not sure what the 'admin' group grants, probably not needed. [14:39:19] Everything except root stuff [14:39:48] I think trusted is good enough, that was on qchris request [14:39:56] hashar: Yes, but when I tried to set a key, wm-bot2 told me that I am not allowed :-/ [14:40:15] Okay. Feel free to ping me [14:40:26] qchris_wmf: if that needs admin, feel free to ask T13 :-] [14:40:29] (03CR) 10Akosiaris: [C: 032] operations-puppet-spec [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/73928 (owner: 10Hashar) [14:40:41] Ok. Thanks. [14:41:00] !card is https://mingle.corp.wikimedia.org/projects/analytics/cards/$1 [14:41:00] Key was added [14:41:11] hashar: the trust is per channel [14:41:23] ^^^ [14:41:27] Oh! [14:41:30] hashar: @trusted in the analytics channel shows that just JeremyB can do it [14:41:31] That explains things. [14:41:53] I can do it in analytics too. [14:41:56] ;) [14:42:03] :) [14:42:35] Just invite me whereever you need me. :) [14:42:57] T13 Could you please trust me in #wikimedia-analytics? [14:43:07] thanks, good to know [14:45:55] (03PS1) 10Zfilipin: Flow tests are moved to Flow repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88992 [14:45:57] (03CR) 10jenkins-bot: [V: 04-1] Flow tests are moved to Flow repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88992 (owner: 10Zfilipin) [14:47:47] (03PS2) 10Zfilipin: Flow tests are moved to Flow repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88992 [14:48:25] (03PS3) 10Zfilipin: Flow tests are moved to Flow repository [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88992 [14:49:06] (03PS3) 10MarkAHershberger: let us override the tar command [tools/release] - 10https://gerrit.wikimedia.org/r/86270 (owner: 10Hashar) [14:49:12] (03PS1) 10Hashar: point operations-puppet-rspec to git:// url [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88993 [14:49:39] (03CR) 10MarkAHershberger: [C: 032] let us override the tar command [tools/release] - 10https://gerrit.wikimedia.org/r/86270 (owner: 10Hashar) [14:49:47] (03CR) 10Hashar: [C: 032] "deployed" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88993 (owner: 10Hashar) [14:50:09] (03Merged) 10jenkins-bot: point operations-puppet-rspec to git:// url [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88993 (owner: 10Hashar) [14:52:20] (03PS2) 10MarkAHershberger: option to skip gpg signature (--dont-sign) [tools/release] - 10https://gerrit.wikimedia.org/r/86275 (owner: 10Hashar) [14:53:20] (03CR) 10MarkAHershberger: [C: 032] option to skip gpg signature (--dont-sign) [tools/release] - 10https://gerrit.wikimedia.org/r/86275 (owner: 10Hashar) [14:56:25] (03PS1) 10Anomie: API: Handle "special" options in action=options [core] - 10https://gerrit.wikimedia.org/r/88995 [14:59:05] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/88987 (owner: 10Esanders) [15:02:23]