[00:00:00] Krinkle: do you want to fix up yours and i'll +2 ? [00:00:05] fixing [00:01:02] (03PS3) 10Krinkle: Make .transition mixin take only 1 value and fix usage [core] - 10https://gerrit.wikimedia.org/r/88254 [00:01:35] suddenly I have to learn less [00:01:36] Krinkle: quickly testing locally and then +2ing [00:01:37] eep :p [00:01:45] werdna: it's the same as css pretty much you'll be okay ;-) [00:02:16] (03CR) 10Jdlrobson: [C: 032] Make .transition mixin take only 1 value and fix usage [core] - 10https://gerrit.wikimedia.org/r/88254 (owner: 10Krinkle) [00:02:41] jdlrobson: :) [00:03:05] Krinkle: so how come the save page button is disabled for me on mediawiki.org? [00:03:32] jdlrobson: console errors? have you made a change to the document yet? [00:03:45] Krinkle: Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist. [00:03:46] :( [00:03:58] that's new, please file a bug :) [00:04:13] Krinkle: doing so now [00:04:34] I think I've never had the pleasure of catching a NotFoundError. Wasn't aware that Error subclass existed. [00:04:58] "Pleasure" may be an exaggeration :p [00:05:50] i can't edit the page at all [00:06:00] if you want to debug it i can replicate it now [00:06:21] (03Merged) 10jenkins-bot: Make .transition mixin take only 1 value and fix usage [core] - 10https://gerrit.wikimedia.org/r/88254 (owner: 10Krinkle) [00:08:10] when is the next VE deployment? [00:08:15] Krinkle: did you want to live debug it at all whilst i can replicate it? [00:08:30] seems to be ve.dm.Converter.js:1401 [00:09:14] AaronSchulz: from reading the code in JobQueue it seems that deduplication only works with memcached, is that correct? [00:10:00] jdlrobson: I'm working on something else a.t.m. [00:10:12] Krinkle: ok luckily james can replicate too [00:10:24] (03PS1) 10Bsitu: Update style for editing a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88262 [00:11:23] gwicke: whatever cache is configured or it can use redis if you use redis for the queue as we do [00:11:57] AaronSchulz: ah, so it should work with a vanilla MW install as well? [00:12:29] not sure if there is db caching by default [00:13:18] DB is the default $wgMemc [00:14:35] AaronSchulz: k, thanks [00:15:00] (03CR) 10Aaron Schulz: [C: 032] Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [00:15:08] <^d> AaronSchulz: It is? I thought $wgMemc defaulted to CACHE_NONE. [00:15:22] for some reason dedup does not work locally [00:15:32] vanilla install without memcached [00:15:42] ^d: Except for pcache [00:15:53] <^d> werdna: Yeah pcache, language cache, etc. [00:15:59] <^d> But the main cache is none I thought. [00:17:02] DefaultSettings.php concurs [00:17:07] $wgMainCacheType = CACHE_NONE; [00:17:09] huh [00:17:14] gwicke: thought it was DB by default [00:17:18] guess not [00:17:29] <^d> $wgMainCacheType = CACHE_NONE; [00:17:29] <^d> $wgMessageCacheType = CACHE_ANYTHING; [00:17:29] <^d> $wgParserCacheType = CACHE_ANYTHING; [00:17:31] <^d> $wgSessionCacheType = CACHE_ANYTHING; [00:17:32] <^d> $wgLanguageConverterCacheType = CACHE_ANYTHING; [00:17:47] There's a rhythm to it [00:17:55] (03Merged) 10jenkins-bot: Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [00:18:08] <^d> We also need a $wgResourceLoaderCacheType. [00:18:20] <^d> Because it's cached in $wgMemc and is thus none by default. [00:18:29] <^d> Which has made MW slower since we added RL :) [00:18:53] * bd808 claps hands loudly for merge of Id0e95290e83333545e6bb0378cc620c35c653bf9 [00:19:17] jdlrobson: ori-l: Updated https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#Less. Feedback welcome. [00:19:24] jgonera: ^ [00:19:31] bd808: congrats! [00:20:33] (03CR) 10Ori.livneh: [C: 032] mediawiki.action.edit.preview: Clean up and optimisation [core] - 10https://gerrit.wikimedia.org/r/87917 (owner: 10Krinkle) [00:20:51] ^d: Does it not default to wgMainCacheType? [00:20:59] ah, I suppose it does but wgMainCacheType is none by default :) [00:21:06] <^d> My point :) [00:21:13] (03PS2) 10Aaron Schulz: Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 [00:21:14] <^d> We shouldn't put it in the main cache. [00:21:21] indeed [00:21:37] ^d: alternatively, why is main=none by default? [00:21:45] <^d> Been that way forever. [00:21:47] cause MW is so fast [00:21:48] or is main alias for "supposed to be relatively cheap" [00:21:52] :) [00:22:08] <^d> AaronSchulz: Remember when it was? ;-) [00:22:27] ^d: CACHE_ANYTHING is DB by default, yes? [00:23:13] Krinkle, looks, good, will have a closer look later [00:23:22] <^d> Krinkle: Out of the box? Yeah [00:23:39] (03Merged) 10jenkins-bot: mediawiki.action.edit.preview: Clean up and optimisation [core] - 10https://gerrit.wikimedia.org/r/87917 (owner: 10Krinkle) [00:23:42] ^d: for what its worth though, rl does have db caching by default (module_deps tables etc.) [00:23:48] so it's not completely uncached [00:23:56] <^d> Yeah I know. [00:24:21] but that is fairly cheap, and has caused more problems that it solves for simple installs [00:24:32] (e.g. hardcoded paths when upgrading or moving wikis) [00:24:46] seen a fair share of bugs for that [00:26:16] <^d> I think RL causes more problems than it solves for basically most installs but us :) [00:27:16] (03CR) 10Krinkle: "plop" [core] - 10https://gerrit.wikimedia.org/r/4055 (owner: 10Daniel Friesen) [00:27:50] (03CR) 10Krinkle: "plop plop" [core] - 10https://gerrit.wikimedia.org/r/4051 (owner: 10Daniel Friesen) [00:29:44] Krinkle|detached: looks good [00:33:15] (03PS3) 10Jdlrobson: Move preferences css out of screen.less [core] - 10https://gerrit.wikimedia.org/r/87170 [00:33:21] ^d: yeah, certainly from an operations point of view. [00:33:25] ^d: from a developers point of view (e.g. extension author) it is beneficial even on a small scale I'd say. [00:33:29] (03PS3) 10Jdlrobson: Rewrite mediawiki.special.preferences.less with nesting [core] - 10https://gerrit.wikimedia.org/r/87171 [00:34:11] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87171 (owner: 10Jdlrobson) [00:34:17] <^d> Meh, I can go either way :) [00:34:39] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [00:34:42] (03CR) 10Krinkle: [C: 04-1] Move preferences css out of screen.less [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [00:37:40] (03PS3) 10MarkTraceur: Put username into title div [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [00:40:32] (03PS1) 10Krinkle: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 [00:40:37] (03PS2) 10Springle: Removed RC query UNION [core] - 10https://gerrit.wikimedia.org/r/88135 (owner: 10Aaron Schulz) [00:41:32] (03PS2) 10Krinkle: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 [00:42:33] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [00:43:39] (03PS1) 10Legoktm: Use MWTimestamp::getHumanTimestamp [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88267 [00:46:03] (03CR) 10Springle: [C: 032] Removed RC query UNION [core] - 10https://gerrit.wikimedia.org/r/88135 (owner: 10Aaron Schulz) [00:47:02] Krinkle, what does plop mean...? [00:47:14] ping [00:47:21] uga [00:47:42] legoktm: can we abandon this https://gerrit.wikimedia.org/r/#/c/88005/? [00:48:01] (03Abandoned) 10Legoktm: Add puppet-cron submodule [vagrant] - 10https://gerrit.wikimedia.org/r/88005 (owner: 10Legoktm) [00:48:13] thanks [00:48:30] (03CR) 10Jdlrobson: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87170 (owner: 10Jdlrobson) [00:48:46] for https://gerrit.wikimedia.org/r/#/c/88006/, is there an easier way to write the config as an array rather than one lining it? [00:49:00] ori-l: if i want to register a LESS variable conditionally where's the best place to do that? [00:49:13] use case: a skin registering its own globals [00:50:25] add them to $wgLESSvars; but be sure that this is really what you want to do [00:50:47] legoktm: have you tried just using native puppet syntax? [00:50:59] ori-l: I don't know puppet :P [00:51:04] i.e., [ 'one', 'two' ] for array( 'one', 'two' ) [00:51:17] { foo => 'bar' } for array ( 'foo' => 'bar' ) [00:51:34] ah [00:51:36] ill try that [00:51:58] (03CR) 10Ori.livneh: [C: 04-1] "(2 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [00:52:52] ori-l: ${role::mediawiki::dir}} <-- should it just be one bracket or two? or is that intentional? [00:54:50] <3 more stuff [00:55:00] (03PS1) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [00:55:03] There it is [00:56:56] jdlrobson, do the variables need to be dynamic? [00:57:09] Or is it just mySkinToolbarColor = 'the perfect shade of blue'? [00:58:53] legoktm: just one bracket [00:58:58] ok [00:58:59] superm401: i basically want to choose a set of variables based on a beta feature.. [00:59:02] my bad [00:59:31] essentially superm401 if ( $beta ) { $wgResourceLoaderLESSVars['vectorVariablesFile'] = "variablesBeta.less"; else { $wgResourceLoaderLESSVars['vectorVariablesFile'] = "variables.less";} [01:01:27] jdlrobson, you'll need to vary RL links on this [01:01:52] MaxSem: if i'm not mistaken its already varied as it's user specific? [01:02:04] jdlrobson, in general RL is not user-specific. [01:02:17] only user-specific modules [01:02:25] most links aren't [01:02:46] (03CR) 10Ori.livneh: [C: 04-1] "(2 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/88003 (owner: 10Legoktm) [01:03:20] if you're modifying PHP globals you should expect that this can affect all modules [01:03:41] jdlrobson, I think I know a way to do it: [01:03:50] superm401: i would love to hear it :) [01:03:56] Make a giant mixin function that takes the colors that vary as parameters: [01:04:21] Can mixins declare rules or just properties? [01:04:52] both but that could get very messy superm401 [01:05:38] Well, the advantage is you don't have to duplicate any code. Just have one mixin files shared by two modules. [01:05:44] (03CR) 10Werdna: [C: 04-1] "(10 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [01:05:59] Then have each module import a different variable file (exporting variables with the same names), then call the same function. [01:06:13] Then your if can addModules/addModuleStyles the right modules. [01:07:11] Is there a way to see all comments on a patchset? [01:07:16] in gerrit* [01:07:21] werdna, expand all [01:07:22] ^d perhaps knows [01:07:39] nono the inline comments [01:08:35] Only way I know is click into each file with something in the Comments column (5 comments, 1 comment, etc.) [01:11:38] ahh annoying [01:12:59] werdna, there is a way to open all the files in the patch set (one window each). [01:13:04] But that is *all*, not just the ones with comments. [01:13:07] even worse :p [01:13:15] You can also go from file to file, but again, not just for ones with comments. [01:13:44] even worse :p [01:13:57] ah well [01:13:59] I'll just click through [01:15:03] (03CR) 10Daniel Friesen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [01:17:44] (03Abandoned) 10Mattflaschen: Break out CLDR so it can be used separately. [vagrant] - 10https://gerrit.wikimedia.org/r/85511 (owner: 10Mattflaschen) [01:24:27] <^d> werdna: I know notttthiinnnggg about gerrit :p [01:24:32] <^d> At least I pretend to [01:24:37] :D [01:27:25] (03PS2) 10Legoktm: Add MassMessage role [vagrant] - 10https://gerrit.wikimedia.org/r/88003 [01:27:27] (03CR) 10jenkins-bot: [V: 04-1] Add MassMessage role [vagrant] - 10https://gerrit.wikimedia.org/r/88003 (owner: 10Legoktm) [01:27:40] ill rebase that later [01:29:38] rebase schmebase [01:37:44] (03CR) 10MZMcBride: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88124 (owner: 10MarkTraceur) [01:37:52] hmmm, trying to find the code for DB updates [01:39:12] You mean applying .sql patches? [01:39:18] It's the maintenance directory. [01:39:20] in the [01:40:06] aha, includes/installer [01:43:29] (03PS3) 10Ori.livneh: Add role for MassMessage extension. [vagrant] - 10https://gerrit.wikimedia.org/r/88003 (owner: 10Legoktm) [01:43:32] (03CR) 10jenkins-bot: [V: 04-1] Add role for MassMessage extension. [vagrant] - 10https://gerrit.wikimedia.org/r/88003 (owner: 10Legoktm) [01:43:49] oh my [01:44:23] (03PS4) 10Ori.livneh: Add role for MassMessage extension. [vagrant] - 10https://gerrit.wikimedia.org/r/88003 (owner: 10Legoktm) [01:44:51] (03CR) 10Ori.livneh: [C: 032] Add role for MassMessage extension. [vagrant] - 10https://gerrit.wikimedia.org/r/88003 (owner: 10Legoktm) [01:44:54] (03Merged) 10jenkins-bot: Add role for MassMessage extension. [vagrant] - 10https://gerrit.wikimedia.org/r/88003 (owner: 10Legoktm) [01:45:51] woot, thanks ori-l [01:46:02] np, makes my life easier [01:47:22] (03CR) 10Ori.livneh: "(3 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [01:50:01] (03PS1) 10Spage: Change @does_not_exist_page_name to @random_string [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88397 [01:52:59] (03PS2) 10Spage: Change @does_not_exist_page_name to @random_string [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88397 [01:58:26] (03CR) 10Parent5446: "Before this is merged, have we already tried filing this upstream and asking HHVM to fix this? Because wfSuppressWarnings() is usually pre" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [01:59:16] (03CR) 10Parent5446: [C: 032 V: 032] "Yep, looks good." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/87704 (owner: 10Mattflaschen) [01:59:20] (03Merged) 10jenkins-bot: Fix ordering of db updates and syntax errors. [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/87704 (owner: 10Mattflaschen) [02:12:23] (03PS3) 10Legoktm: Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 [02:12:27] (03CR) 10jenkins-bot: [V: 04-1] Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [02:12:47] (03CR) 10Legoktm: [C: 04-1] "Needs to increment the version number..." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88257 (owner: 10Legoktm) [02:13:37] (03PS4) 10Legoktm: Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 [02:13:40] (03CR) 10jenkins-bot: [V: 04-1] Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [02:14:02] :/ [02:14:16] ori-l: ^ do you know what that should be? [02:30:22] (03PS1) 10Werdna: Change rev_comment to rev_change_type and adjust references to "comments" to instead refer to "change types". [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88398 [02:31:25] (03PS1) 10Aaron Schulz: Made root job de-duplication work without cache setup [core] - 10https://gerrit.wikimedia.org/r/88399 [02:31:44] (03PS2) 10Aaron Schulz: Made root job de-duplication work without cache setup [core] - 10https://gerrit.wikimedia.org/r/88399 [03:21:17] (03PS2) 10Legoktm: Show drafts after deletion and undeletion [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88257 [03:25:52] (03PS4) 10thibaultmarin: (extension/PGFTikZ) PGFTikZ extension: initial import [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 [03:34:02] (03CR) 10thibaultmarin: "(1 comment)" [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [03:37:11] legoktm: Puppet hashes use =>, not : [03:37:20] ah. [03:38:29] (03PS5) 10Legoktm: Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 [03:38:51] now let me test that [03:39:45] i guess i could do that [03:42:32] hm [03:42:40] jobs arent being submitted properly [03:45:05] what does the generated PHP loader code look like? [03:45:19] it should be in settings.d/puppet-managed [03:45:42] $wgJobTypeConf = array( "default" => array( "class" => "JobQueueRedis", "redisConfig" => array( "compression" => "gzip", "connectTimeout" => 2 ), "redisServer" => "localhost" ) ); [03:46:25] is that correct? it looks OK at a glance [03:47:00] i think so [03:47:04] i copied it out of the wmf config :P [03:47:20] Heh. [03:47:20] https://noc.wikimedia.org/conf/highlight.php?file=jobqueue-eqiad.php [03:47:25] I hit that problem at work someitmes. [03:47:26] sometimes [03:47:32] (and i got it to work on my testwiki) [03:47:35] "Surely this code isn't terrible, it's deployed..." [03:47:40] And everyone else recoils. [03:47:53] unless redis has a password? [03:47:54] is redis up? [03:47:59] no, it doesn't [03:48:07] you can run 'redis-cli' [03:48:24] vagrant@mediawiki-vagrant:~$ redis-cli [03:48:24] redis 127.0.0.1:6379> [03:48:54] you can type 'monitor' and hit enter [03:49:03] and then go to your wiki and do something job-queue-y [03:49:47] hoooly crap [03:50:01] you saw the matrix? [03:50:41] well i submitted about 1k jobs [03:50:44] and they showed up [03:50:51] but when i run showJobs.php --group [03:50:56] or even runJobs.php, there are no jobs [03:51:04] 1381204179.500971 [0 127.0.0.1:46658] "EVALSHA" "c32f04b2b3a9aed1bc08592766353ca2500dde15" "5" "wiki:jobqueue:massmessageJob:l-unclaimed" "wiki:jobqueue:massmessageJob:h-sha1ById" "wiki:jobqueue:massmessageJob:h-idBySha1" "wiki:jobqueue:massmessageJob:z-delayed" "wiki:jobqueue:massmessageJob:h-data" "40da4037dcd7436aab5620cfa348d25d" "" "0" "a:8:{s:4:\"type\";s:14:\"massmessageJob\";s:9:\"namespace\";i:4;s:5:\"title\";s:7:\"MM/1065\";s:6:\"params [03:51:05] \";a:4:{s:8:\"spamlist\";s:4:\"MM/2\";s:7:\"subject\";s:4:\"haha\";s:7:\"message\";s:3:\"asd\";s:7:\"comment\";a:3:{i:0;s:5:\"Admin\";i:1;s:4:\"wiki\";i:2;s:46:\"http://127.0.0.1:8080/w/index.php?title=MM/2&1\";}}s:10:\"rtimestamp\";i:0;s:4:\"uuid\";s:32:\"40da4037dcd7436aab5620cfa348d25d\";s:4:\"sha1\";s:0:\"\";s:9:\"timestamp\";i:1381204179;}" [03:55:32] does showJobs.php get the right job queue? [03:55:49] it should automatically pick up 'default' [03:58:10] hmm, dunno. in phpsh do var_dump( JobQueueGroup::singleton() ); [03:58:29] this is the first time I'm looking at some of this code [03:58:49] https://dpaste.de/cLry/raw/ [04:00:57] (03CR) 10Chad: "So, what do you think the ideal upstream behavior is? Zend doesn't display errors here unless mysql.trace_mode is on (and it's off by defa" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [04:02:21] legoktm: what's $jq = JobQueueGroup::singleton(); echo gettype( $jq ); [04:02:39] object [04:03:35] thank you, php [04:03:38] :D [04:03:50] sorry, my brain is cheese at the moment [04:04:01] and i know astonishingly little about the job queue [04:04:14] maybe this aaron guy knows something [04:08:38] (03PS1) 10Legoktm: Stick globals in mw.config instead of edit form [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88402 [04:17:13] (03PS1) 10Legoktm: Use ResourceLoader for localized messages [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88403 [04:17:40] (03PS1) 10Spage: Fix help string to avoid PHP notice [core] - 10https://gerrit.wikimedia.org/r/88404 [04:18:01] (03PS2) 10Legoktm: Use ResourceLoader for localized messages [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88403 [04:19:57] legoktm: I'm sorry for getting you hooked on Drafts. :-( [04:21:00] :P [04:21:17] The concept is pretty cool [04:21:29] And most of the framework is there, just super outdated. [04:22:13] legoktm: If you're having trouble installing VE, that's also something you can e-mail wikitech-l about. [04:22:24] it was parsoid [04:22:26] and it was like 3 am [04:22:35] so I wasn't sure if it was me or parsoid :P [04:22:55] either way, the extension needs a lot of work before anyone even tries to get it to work with VE [04:23:48] right now I'm fixing up the JS so I can get it to actually work [04:23:51] (03PS11) 10Werdna: Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [04:23:54] then i'll get to the PHP stuff [04:24:29] (03CR) 10Werdna: "New patchset:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [04:31:52] (03PS1) 10Legoktm: [WIP] Convert to use jQuery [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88405 [04:34:06] legoktm: man, I remember that extension :P [04:34:14] :D [04:34:19] werdna: wanna review some patches? [04:34:24] * werdna eeeps [04:34:45] some of them are pretty trivial https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Drafts+status:open,n,z [04:34:53] like https://gerrit.wikimedia.org/r/#/c/88243/ [04:34:53] I might take a look in a bit :) [04:34:58] * werdna is working on renaming some things. [04:35:05] or https://gerrit.wikimedia.org/r/#/c/88245/ [04:35:07] ok [04:59:46] (03CR) 10Aaron Schulz: [C: 032] Fix help string to avoid PHP notice [core] - 10https://gerrit.wikimedia.org/r/88404 (owner: 10Spage) [05:02:30] (03Merged) 10jenkins-bot: Fix help string to avoid PHP notice [core] - 10https://gerrit.wikimedia.org/r/88404 (owner: 10Spage) [05:08:53] (03PS3) 10Legoktm: Show drafts after deletion and undeletion [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88257 [05:09:57] (03PS4) 10Legoktm: Update page id whenever it changes [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88257 [05:21:26] (03PS1) 10Aaron Schulz: Deal with PHP bug 63411 and tweaked sleep waits [extensions/SwiftCloudFiles] - 10https://gerrit.wikimedia.org/r/88406 [05:23:11] (03CR) 10Chad: "Hmm, mysql.trace_mode only affects mysql, not mysqli. Since the functionality basically doesn't exist at all in Zend anymore, I think we c" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [05:31:29] (03PS2) 10Legoktm: Use PageContentSaveComplete hook [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87995 [05:31:56] (03Abandoned) 10Chad: Wrap MySQL queries in wfSuppressWarnings()/wfRestoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [05:32:32] (03PS3) 10Legoktm: Use PageContentSaveComplete hook [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87995 [05:33:53] (03PS4) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [05:37:10] (03CR) 10Chad: [C: 032] "Much more likely to work out of the box for people." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88247 (owner: 10Chad) [05:37:14] (03Merged) 10jenkins-bot: Make default host localhost [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88247 (owner: 10Chad) [05:45:20] (03CR) 10Nikerabbit: "(3 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87995 (owner: 10Legoktm) [05:56:32] (03PS3) 10Netbrain: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 [05:57:35] (03CR) 10Legoktm: "(3 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87995 (owner: 10Legoktm) [05:57:47] (03PS4) 10Legoktm: Use PageContentSaveComplete hook [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87995 [06:00:00] (03CR) 10Nikerabbit: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88209 (owner: 10Manybubbles) [06:03:57] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88209 (owner: 10Manybubbles) [06:03:59] (03PS4) 10Netbrain: Added "search and replace within selection" functionality [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/87322 [06:12:35] (03PS1) 10Werdna: Rename summaries to headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88407 [06:15:38] (03PS1) 10Ori.livneh: Add mediawiki.inspect module [core] - 10https://gerrit.wikimedia.org/r/88408 [06:18:55] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.inspect module [core] - 10https://gerrit.wikimedia.org/r/88408 (owner: 10Ori.livneh) [06:23:48] the JS duck thing is a bit absurd sometimes [06:25:59] (03CR) 10Spage: "(11 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [06:29:03] (03PS2) 10Ori.livneh: Add mediawiki.inspect module [core] - 10https://gerrit.wikimedia.org/r/88408 [06:32:09] (03CR) 10jenkins-bot: [V: 04-1] Add mediawiki.inspect module [core] - 10https://gerrit.wikimedia.org/r/88408 (owner: 10Ori.livneh) [06:33:27] (03PS3) 10Ori.livneh: Add mediawiki.inspect module [core] - 10https://gerrit.wikimedia.org/r/88408 [06:33:37] (03CR) 10Spage: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [06:33:52] your move, jenkins [06:33:54] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [06:45:37] (03CR) 10Nikerabbit: "(1 comment)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88151 (owner: 10Legoktm) [06:46:17] (03PS28) 10Jdlrobson: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 [07:03:12] (03PS1) 10MarkTraceur: Add articlepath to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 [07:12:22] * marktraceur swears about the api patch he just submitted [07:15:04] (03PS2) 10MarkTraceur: Add some siteinfo to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 [07:19:54] (03PS2) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [07:20:01] * marktraceur is so happy about that [07:21:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Trivial." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [07:33:27] (03PS1) 10Werdna: Add AJAX header modification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 [07:35:44] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88407 (owner: 10Werdna) [07:37:07] (03PS2) 10Werdna: Add AJAX header modification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 [07:37:41] ori-l: why -2 for adding the cron module? [07:37:51] ori-l: it has absolutely no cross distribution stuff, for example [07:37:59] did you read my comment? [07:38:03] ori-l: we shouldn't be re-inventing the wheel everytime [07:38:07] ..did you read my comment? [07:38:09] there was one from bd808 [07:38:11] looking [07:38:41] ori-l: nevermind. [07:38:46] thanks. [07:39:05] * YuviPanda sheepishly slowly walks away [07:39:14] :P [07:39:17] that was slightly embarassing :P [07:39:27] i should read gerrit comments on gerrit, than on my phone's email when slightly asleep [07:39:42] yes, it's a very good alternative for raging :P [07:39:48] true [07:40:15] * YuviPanda finds something else to rage about [07:40:47] there's always the API [07:41:12] I need to dig into the null / "" thing on the CLI patch [07:43:27] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [07:47:09] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [07:47:34] ori-l: thoughts on an Extensions.yaml? Not checked into git, people can just add extensions + settings, and puppet will pick them up [07:48:15] i can write up notes on it if you want [07:48:54] there was a Roles.yaml before [07:48:59] indeed [07:49:08] I remember :) [07:49:24] what would this do differently? [07:49:43] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 (owner: 10Werdna) [07:49:52] this won't need roles to be defined in roles.pp? [07:50:50] (03CR) 10Werdna: "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 (owner: 10Werdna) [07:50:59] interesting, maybe [07:51:28] I thought about having 'enable-role' offer to guess if no matching role is defined [07:52:19] I thought about an enable-extension, but that'll perhaps require a list-extensions, and also need a way to setup settings [07:52:36] an Extensions.yaml doesn't mean we can't have enable-extension [07:52:56] i don't think it makes sense to have enable-role and enable-extension [07:53:05] i think i should get over myself and allow roles to be one-offs [07:53:05] right [07:53:13] it causes problems! [07:53:21] what does? [07:53:32] well, CodeEditor being required by both UW and Scribunto [07:53:33] or are you making fun of me ? :P [07:53:35] (03PS3) 10Werdna: Add AJAX header modification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 [07:53:47] well, that'll go away if we allow a CodeEditor role [07:53:51] right [07:54:12] it still requires that people make a patch for every extension [07:54:18] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 (owner: 10Werdna) [07:54:29] siebrand: there we go :p [07:54:51] werdna: That looked like a bad merge when I first looked at it. [07:54:59] nah, just a bad search/replace :p [07:56:35] YuviPanda: fortunately there are only 1,000,000,000,000 or so extensions [07:57:15] heh :D [07:57:18] but seriously, if you're going to take the minute or so it takes to set up an extension, just make it a role and submit a patch [07:57:31] there aren't *that* many that people plausibly want to use [07:57:40] ori-l: so does this mean it's okay to have one off roles? [07:57:55] yeah, i said as much before, no? [07:58:18] well, "13:23 ori-l: i think i should get over myself and allow roles to be one-offs " [07:58:21] only 'i think' :) [07:58:24] but yeah, okay [07:58:32] i thought about it and my reservation amounts to moaning about not getting the design exactly right from the beginning [07:58:32] I'll make CodeEditor work then, now. [07:58:54] i can think of alternative schemes but they'd be annoying to migrate to [07:59:21] such as? [08:01:14] well, you could generate some catalog of extensions and their configuration values [08:01:21] and have puppet query that [08:02:08] hmmm [08:02:10] that's a far bit off [08:02:12] anyways, I'm ok with the current scheme [08:02:16] yeah, okay [08:02:31] since it turned out in the end that extension bundles are the exception rather than the norm of roles [08:03:00] we could make them stand out by calling them role::bundle::foo instead of role::foo [08:03:27] and rig vagrant list-roles to list them separate [08:03:35] *separately [08:04:10] right [08:04:15] even have them in separate files [08:04:24] roles/bundles.pp roles/extensions.pp [08:04:34] but in general, maybe it's just me, but i think the project is more or less at its sweet spot [08:04:44] i periodically get fancy ideas, half implement them, and realize that it wouldn't be worth it [08:05:11] heh [08:05:16] i wanted something less painful than having a gigantic localsettings.php (have you ever seen arthur's?) [08:05:21] and this works pretty well for that [08:05:43] and the fact that puppet is so extensible made it possible to have a DSL for describing mediawiki configs, that's pretty nice [08:05:56] but i think that's as far as i need mediawiki configuration to go [08:06:20] hmm, okay [08:06:35] so from now it pretty much just grows organically, with extensions and roles as such. [08:07:08] it's not "my" project any more so if something compelling comes along and people want to run with it, sure, whatever [08:08:03] (03PS1) 10Yuvipanda: Separate CodeEditor into its own Role [vagrant] - 10https://gerrit.wikimedia.org/r/88415 [08:08:12] but my enthusiasm for bold new vagrant frontiers is waning a little [08:09:19] ori-l: alright! [08:09:23] the UploadWizard role is especially nice [08:09:23] ori-l: and yeah, it is at a sweet spot. [08:09:49] ori-l: why so? [08:09:55] because of the includes? [08:10:01] which pack in quite a punch [08:10:16] yeah, and the settings are nontrivial but they map pretty nicely to php [08:10:27] no big ugly string literals [08:10:50] and they nest too [08:10:54] yep [08:11:04] ok, i'm rambling, i'm off to bed. /wave [08:11:10] heh [08:11:11] ori-l: night! [08:11:17] * YuviPanda self merges [08:11:21] wait [08:11:30] Wow, if ori-l is sleeping, it's clearly time for me to sleep too [08:11:30] (03CR) 10Yuvipanda: [C: 032] Separate CodeEditor into its own Role [vagrant] - 10https://gerrit.wikimedia.org/r/88415 (owner: 10Yuvipanda) [08:11:32] (03Merged) 10jenkins-bot: Separate CodeEditor into its own Role [vagrant] - 10https://gerrit.wikimedia.org/r/88415 (owner: 10Yuvipanda) [08:11:35] ori-l: ow [08:11:56] did I typo again? [08:17:02] (03PS1) 10Ori.livneh: Drop spurious trailing '#' from comment block [vagrant] - 10https://gerrit.wikimedia.org/r/88416 [08:17:24] (03CR) 10Ori.livneh: [C: 032] Drop spurious trailing '#' from comment block [vagrant] - 10https://gerrit.wikimedia.org/r/88416 (owner: 10Ori.livneh) [08:17:27] (03Merged) 10jenkins-bot: Drop spurious trailing '#' from comment block [vagrant] - 10https://gerrit.wikimedia.org/r/88416 (owner: 10Ori.livneh) [08:17:31] fine now :P [08:17:34] cya [08:18:06] ori-l: night [08:33:39] * werdna ponders submitting a FOSDEM talk [08:56:03] (03CR) 10Werdna: [C: 032] Convert wikitext to html, depending on editor needs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87335 (owner: 10Matthias Mullie) [08:56:13] (03Merged) 10jenkins-bot: Convert wikitext to html, depending on editor needs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87335 (owner: 10Matthias Mullie) [09:47:05] (03PS1) 10Raimond Spekking: Add message documentation [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88427 [09:47:16] (03PS1) 10Reedy: Fix .gitreview in extension branches when we branch for WMF version [tools/release] - 10https://gerrit.wikimedia.org/r/88428 [09:49:06] (03CR) 10Catrope: [C: 032 V: 032] Fix .gitreview in extension branches when we branch for WMF version [tools/release] - 10https://gerrit.wikimedia.org/r/88428 (owner: 10Reedy) [09:50:30] * werdna waves RoanKattouw  [09:50:36] Heya werdna [09:50:43] You back in Oz these days? [09:50:55] yeah, all done with travelling [09:51:08] may be currently shopping for hypothetical fosdem flights [09:51:14] Nice [09:51:21] Yeah I've decided I shouldn't go to FOSDEM [09:51:28] It'll be during term time and I'm already spending the first week of term in Perth [09:51:37] wtf are you doing in perth [09:51:42] linux.conf.au [09:51:47] But indeed, what the hell are they doing in Perth [09:52:09] FOSDEM is tempting, but probably I won't end up doing it [09:52:24] And what the hell are they doing starting their conference on the 6th of January so us poor US residents have to leave right after New Year's [09:52:27] fares are ~$2800 for SYD-SFO-BRU [09:52:42] That's fairly high [09:53:01] But that's about what my January 2012 trip (AMS-MEL-SFO-AMS) cost [09:53:04] that's for RTW remember [09:53:15] Yeah [09:53:15] $1476 for a straight return to bru [09:53:21] :O [09:53:27] Yeah transpacific is crazy expensive [09:53:36] To AU at least, transpacific to Asia isn't that bad [09:53:46] Take a cargo ferry [09:53:53] well, not ferry [09:53:56] ocean liner [09:53:57] whatever [09:54:00] :p [09:54:01] Heck, you could nest a BRU-SFO-BRU ticket inside that SYD-BRU-SYD ticket and just about come out ahead [09:54:13] yeah [09:54:16] Or Eurostar to LHR and you can get a round-trip ticket to SFO for <$1k [09:54:45] mmm I avoid London because of the passenger movement cost [09:54:51] * RoanKattouw envies Londoners for this [09:55:14] Is BRU even cheaper to fly out of? [09:55:30] not sure [09:55:31] Even with the high UK taxes, SFO-LHR fares are usually ~$200 lower than SFO-AMS fares [09:55:44] hm, but you could pick up a cheap flight to tag on to avoid it? [09:56:30] Last weekend I flew SFO-LHR on United, then went all the way out through customs and all the way back in again to take an award flight on BA to AMS [09:56:45] So I incurred the passenger charge thing but I still came out ~$150 ahead [09:56:58] (Part of this was because I had enough BA miles to be able to get an award flight for like $27) [09:57:03] nod [09:57:26] typical bru-syd prices are $1k [09:57:28] But I think that trick might stop working soon [09:57:42] actually basically each leg, by itself is ~$1k [09:57:43] UA is switching from 747s to 777s on SFO-LHR so I expect fares to go up [09:57:48] SYD-SFO-BRU-SYD [09:57:55] Right [09:57:59] and I can get the lot for $2800 [09:58:10] on QF (that was SYD-SFO-BRU/AMS-SYD) [09:58:26] well obviously not qf the whole way [09:58:35] presumably some emirates and BA and hopefully not AA [09:58:40] How does QF sell you an SFO-BRU ticket? AA/BA? [09:59:25] hopefully BA/BA [09:59:32] (03CR) 10Siebrand: [C: 032 V: 032] Add message documentation [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88427 (owner: 10Raimond Spekking) [10:00:22] I guess if you do a nested ticket you spend a lot of time flying back from SFO to SYD via Europe [10:03:53] (03PS1) 10MaxSem: MobileFrontend to the train [tools/release] - 10https://gerrit.wikimedia.org/r/88432 [10:04:26] (03CR) 10MaxSem: [C: 032] MobileFrontend to the train [tools/release] - 10https://gerrit.wikimedia.org/r/88432 (owner: 10MaxSem) [10:04:29] (03Merged) 10jenkins-bot: MobileFrontend to the train [tools/release] - 10https://gerrit.wikimedia.org/r/88432 (owner: 10MaxSem) [10:04:45] Reedy, ^^ :) [10:32:29] (03CR) 10Helder.wiki: "Causes bug 55463." [core] - 10https://gerrit.wikimedia.org/r/87917 (owner: 10Krinkle) [11:08:34] (03CR) 10VitaliyFilippov: "?!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!" [core] - 10https://gerrit.wikimedia.org/r/27919 (owner: 10MarkTraceur) [11:11:18] Taken a year to notice? [11:16:56] (03PS1) 10Raimond Spekking: Add i18n file [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/88442 [11:17:05] (03PS1) 10VitaliyFilippov: (bug 40889) Follow-up 6f1d4db3: Fix the upload form when radio buttons are shown. [core] - 10https://gerrit.wikimedia.org/r/88443 [11:18:58] (03CR) 10VitaliyFilippov: "OK, I've just posted a fix for this problem: I7c15fd4250b6a2d26af2cc0373da5ac6c884d690" [core] - 10https://gerrit.wikimedia.org/r/27919 (owner: 10MarkTraceur) [11:19:17] lol [11:25:05] (03PS2) 10VitaliyFilippov: (bug 40889) Follow-up 6f1d4db3: Fix the upload form when radio buttons are shown. [core] - 10https://gerrit.wikimedia.org/r/88443 [11:25:36] (03CR) 10VitaliyFilippov: "Oops sorry in the rage of fixing I've messed with the first patch :) now it works OK." [core] - 10https://gerrit.wikimedia.org/r/88443 (owner: 10VitaliyFilippov) [11:46:01] (03PS11) 10Hashar: tests to compare En, Qqq and messages.inc [core] - 10https://gerrit.wikimedia.org/r/5550 [11:48:00] (03CR) 10jenkins-bot: [V: 04-1] tests to compare En, Qqq and messages.inc [core] - 10https://gerrit.wikimedia.org/r/5550 (owner: 10Hashar) [12:02:55] (03CR) 10Hashar: "The jobs need to be updated with Jenkins job builder :-] I did so." [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88205 (owner: 10Ori.livneh) [12:08:05] !g Ie53c620c29e13c2fa3629865771d447c49332f0f [12:08:05] https://gerrit.wikimedia.org/r/#q,Ie53c620c29e13c2fa3629865771d447c49332f0f,n,z [12:08:33] (03CR) 10Hashar: "I have pulled the change on gallium and reloaded Zuul." [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88204 (owner: 10Ori.livneh) [12:09:22] (03PS1) 10Hashar: HelpPages TimeMachine WikimediaEvents [extensions] - 10https://gerrit.wikimedia.org/r/88449 [12:09:41] (03CR) 10Hashar: [C: 032] HelpPages TimeMachine WikimediaEvents [extensions] - 10https://gerrit.wikimedia.org/r/88449 (owner: 10Hashar) [12:10:05] (03CR) 10Hashar: [V: 032] HelpPages TimeMachine WikimediaEvents [extensions] - 10https://gerrit.wikimedia.org/r/88449 (owner: 10Hashar) [12:15:09] TimStarling: Thank you. [12:32:24] (03PS4) 10Yuvipanda: Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 [12:38:37] (03CR) 10Yuvipanda: "Patch fixed to not use empty" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [12:41:10] sorry Jenkins restarting … killed it by mistake [12:44:21] (03PS14) 10Dan-nl: addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 [12:45:28] (03CR) 10jenkins-bot: [V: 04-1] addressing brian wolff’s comments [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/83657 (owner: 10Dan-nl) [13:02:29] (03CR) 10Matthias Mullie: "(10 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [13:05:14] hashar: Hey what's going on with Jenkins [13:05:18] I'm getting LOST jobs [13:05:21] https://gerrit.wikimedia.org/r/#/c/86802/ [13:14:02] (03PS1) 10Odder: (bug 48480) Clean-up EmailCapture extension config [tools/release] - 10https://gerrit.wikimedia.org/r/88457 [13:16:33] (03PS2) 10Odder: (bug 48480) Clean-up EmailCapture extension config [tools/release] - 10https://gerrit.wikimedia.org/r/88457 [13:17:11] (03CR) 10Odder: "This is a follow-up to Idbcf67cf1b3ebca840bd35fb70266e678750c442." [tools/release] - 10https://gerrit.wikimedia.org/r/88457 (owner: 10Odder) [13:54:49] (03CR) 10Alex Monk: [C: 04-1] jshint fixes for mw.UploadWizardLicenseInput.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (owner: 10MarkTraceur) [13:55:57] (03CR) 10Alex Monk: [C: 04-1] "-1 for comment visibility" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (owner: 10MarkTraceur) [13:59:11] (03CR) 10Alex Monk: [C: 04-1] "-1 for comment visibility" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86814 (owner: 10MarkTraceur) [14:00:38] (03PS1) 10SuchetaG: mediawiki.api: add postWithToken and getToken Similar to postWithEditToken in mw.api.edit, but more generic. [core] - 10https://gerrit.wikimedia.org/r/88463 [14:00:39] (03PS1) 10SuchetaG: mediawiki.api: add postWithToken and getToken Similar to postWithEditToken in mw.api.edit, but more generic. [core] - 10https://gerrit.wikimedia.org/r/88464 [14:01:30] (03PS1) 10Siebrand: Update formatting [core] - 10https://gerrit.wikimedia.org/r/88465 [14:01:31] (03PS1) 10Siebrand: Address PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88466 [14:02:01] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: add postWithToken and getToken Similar to postWithEditToken in mw.api.edit, but more generic. [core] - 10https://gerrit.wikimedia.org/r/88463 (owner: 10SuchetaG) [14:02:56] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: add postWithToken and getToken Similar to postWithEditToken in mw.api.edit, but more generic. [core] - 10https://gerrit.wikimedia.org/r/88464 (owner: 10SuchetaG) [14:16:29] (03PS5) 10MaxSem: Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 [14:21:34] (03CR) 10Siebrand: [C: 032 V: 032] Add i18n file [extensions/NumerAlpha] - 10https://gerrit.wikimedia.org/r/88442 (owner: 10Raimond Spekking) [14:35:22] (03CR) 10Cmcmahon: [C: 032] Change @does_not_exist_page_name to @random_string [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88397 (owner: 10Spage) [14:40:07] (03CR) 10Alex Monk: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88124 (owner: 10MarkTraceur) [14:44:14] chrismcmahon, morning! Andre can't make it to the ECT meeting and guillom is on holidays so I decided to cancel. [14:49:01] (03PS1) 10Alex Monk: Fix a few remaining things in mw.LanguageUpWiz.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88476 [14:54:29] <^d> qgil: Any time I see you type ECT I think electroconvulsive therapy :p [14:54:54] ^d: Isn't it great how we have ECT and EEG now :) [14:56:51] ^d I'm sure whoever came with the acronym was aware of the connection... :) [14:56:56] <^d> :) [14:58:02] (03PS1) 10Tpt: Use as wgPageContentLanguage the language of the displayed page content ...and not the language of the page as stored in the database [core] - 10https://gerrit.wikimedia.org/r/88478 [14:59:25] (03PS2) 10Tpt: Use as wgPageContentLanguage the language of the displayed page content ...and not the language of the page as stored in the database [core] - 10https://gerrit.wikimedia.org/r/88478 [15:00:23] qgil: saw that, np [15:01:42] ^d I actually dislike the overuse of the term "Engineering" but "Technical Community Team" won't make a nice acronym either... https://en.wikipedia.org/wiki/TCT [15:02:10] (03CR) 10Anomie: [C: 031] "Probably a good idea. Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/88203 (owner: 10CSteipp) [15:02:14] (03CR) 10Tpt: "The main goal of this change is to be able to access to variables like wgMonthNames in the displayed page content language." [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [15:02:32] <^d> Naming things is...you know [15:03:31] I guess it was funnier 3000 years ago, on new ground [15:05:30] (03CR) 10Alex Monk: [C: 04-1] "(2 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86779 (owner: 10MarkTraceur) [15:07:56] (03PS1) 10Manybubbles: Fix updateSearchIndexConfig for non-existant alias [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88479 [15:11:30] (03CR) 10Chad: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88479 (owner: 10Manybubbles) [15:13:08] (03PS1) 10Legoktm: Fix qqq message [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/88480 [15:13:31] (03CR) 10Legoktm: [C: 032 V: 032] Fix qqq message [extensions/HelpPages] - 10https://gerrit.wikimedia.org/r/88480 (owner: 10Legoktm) [15:14:31] (03CR) 10Anomie: "Code seems to work." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 (owner: 10Aaron Schulz) [15:17:57] (03CR) 10Manybubbles: "(1 comment)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88479 (owner: 10Manybubbles) [15:18:46] (03PS2) 10Manybubbles: Fix updateSearchIndexConfig for non-existant alias [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88479 [15:24:17] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [15:29:39] (03PS1) 10Legoktm: Kill uneeded global variable [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/88482 [15:30:41] (03PS1) 10Nemo bis: Bundle SimpleAntiSpam [tools/release] - 10https://gerrit.wikimedia.org/r/88483 [15:32:06] (03PS15) 10Anomie: Add list=allfileusages [core] - 10https://gerrit.wikimedia.org/r/61817 (owner: 10Umherirrender) [15:32:13] (03CR) 10Anomie: [C: 032] Add list=allfileusages [core] - 10https://gerrit.wikimedia.org/r/61817 (owner: 10Umherirrender) [15:34:40] (03PS1) 10Nemo bis: Remove EditPageTracking extension [tools/release] - 10https://gerrit.wikimedia.org/r/88484 [15:37:24] (03Merged) 10jenkins-bot: Add list=allfileusages [core] - 10https://gerrit.wikimedia.org/r/61817 (owner: 10Umherirrender) [15:44:00] (03CR) 10MarkAHershberger: "Serendipity! Markus and I just had a meeting about which anti-spam bits to include." [tools/release] - 10https://gerrit.wikimedia.org/r/88483 (owner: 10Nemo bis) [15:45:11] (03CR) 10Nemo bis: "Good to hear! Some things will need to get into core eventually, IMHO, after they've settled down as bundles." [tools/release] - 10https://gerrit.wikimedia.org/r/88483 (owner: 10Nemo bis) [15:46:21] (03CR) 10Mglaser: [C: 031] "Totally in favour of this." [tools/release] - 10https://gerrit.wikimedia.org/r/88483 (owner: 10Nemo bis) [15:49:43] (03CR) 10MarkAHershberger: [C: 032] Bundle SimpleAntiSpam [tools/release] - 10https://gerrit.wikimedia.org/r/88483 (owner: 10Nemo bis) [15:52:22] (03PS2) 10Aaron Schulz: Avoid master queries in Revision::newFromTitle(..., Revision::READ_NORMAL) [core] - 10https://gerrit.wikimedia.org/r/67387 (owner: 10Tim Starling) [15:53:44] (03CR) 10Chad: [C: 032] Fix updateSearchIndexConfig for non-existant alias [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88479 (owner: 10Manybubbles) [15:53:52] (03Merged) 10jenkins-bot: Fix updateSearchIndexConfig for non-existant alias [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88479 (owner: 10Manybubbles) [15:55:00] (03PS2) 10BryanDavis: Add script to purge changed files from cache [core] - 10https://gerrit.wikimedia.org/r/87635 [15:55:32] (03PD1) 10Addshore: Add another job for wikibase [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88488 [15:58:21] (03PS1) 10Hashar: zuul: changes processed [integration/docroot] - 10https://gerrit.wikimedia.org/r/88489 [15:58:38] (03CR) 10Hashar: [C: 032] zuul: changes processed [integration/docroot] - 10https://gerrit.wikimedia.org/r/88489 (owner: 10Hashar) [15:58:40] (03Merged) 10jenkins-bot: zuul: changes processed [integration/docroot] - 10https://gerrit.wikimedia.org/r/88489 (owner: 10Hashar) [16:00:23] (03PS1) 10Hashar: zuul: fix spaces in url for graphite [integration/docroot] - 10https://gerrit.wikimedia.org/r/88491 [16:00:40] (03CR) 10Hashar: [C: 032] zuul: fix spaces in url for graphite [integration/docroot] - 10https://gerrit.wikimedia.org/r/88491 (owner: 10Hashar) [16:00:42] (03Merged) 10jenkins-bot: zuul: fix spaces in url for graphite [integration/docroot] - 10https://gerrit.wikimedia.org/r/88491 (owner: 10Hashar) [16:01:29] (03PS1) 10EBernhardson (WMF): New SVG's from design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88492 [16:01:49] (03PS3) 10BryanDavis: Add script to purge changed files from cache [core] - 10https://gerrit.wikimedia.org/r/87635 [16:05:35] (03CR) 10BryanDavis: "Removing my -2 block. This is ready for review." [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [16:06:34] random idea I havn't fully considered yet, when using svg icon's we also need to include png's for backwards compatability. It would potentially be reasonable to use less to auto-generate both sets of rules so everywhere uses the same method of overloading. The random idea that may or may not be reasonable though, is what if less(or perhaps a different post-processor instead) could also run the svg->png conversion before @embed'ing the icons? [16:08:05] (03CR) 10CSteipp: [C: 032] Avoid using stilly "wp" prefix in form [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88252 (owner: 10Aaron Schulz) [16:08:38] (03Merged) 10jenkins-bot: Avoid using stilly "wp" prefix in form [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88252 (owner: 10Aaron Schulz) [16:09:29] (03PS11) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [16:09:31] (03PS1) 10Matthias Mullie: Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 [16:10:50] (03CR) 10Matthias Mullie: [C: 032] New SVG's from design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88492 (owner: 10EBernhardson (WMF)) [16:10:54] (03Merged) 10jenkins-bot: New SVG's from design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88492 (owner: 10EBernhardson (WMF)) [16:13:45] (03CR) 10BryanDavis: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [16:14:02] (03PS2) 10Legoktm: [WIP] Convert to use jQuery [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88405 [16:17:09] (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88443 (owner: 10VitaliyFilippov) [16:17:50] (03CR) 10Reedy: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [16:19:14] (03PS7) 10Reedy: Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 [16:19:43] (03CR) 10jenkins-bot: [V: 04-1] Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [16:20:41] (03PS1) 10Siebrand: Remove unused local variable [core] - 10https://gerrit.wikimedia.org/r/88496 [16:20:42] (03PS1) 10Siebrand: Update documentation [core] - 10https://gerrit.wikimedia.org/r/88497 [16:21:26] (03PS8) 10Reedy: Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 [16:22:08] (03PS9) 10Reedy: Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 [16:22:41] (03PS1) 10Chad: Add curl support to php [vagrant] - 10https://gerrit.wikimedia.org/r/88498 [16:22:48] (03CR) 10Reedy: [C: 031] Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [16:24:38] (03CR) 10Aaron Schulz: [C: 032] Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [16:25:41] (03CR) 10BryanDavis: [C: 032] Add curl support to php [vagrant] - 10https://gerrit.wikimedia.org/r/88498 (owner: 10Chad) [16:28:22] (03Merged) 10jenkins-bot: Add curl support to php [vagrant] - 10https://gerrit.wikimedia.org/r/88498 (owner: 10Chad) [16:30:41] (03CR) 10Aaron Schulz: [C: 032] Move forceHTTPS check until after wgTitle is setup [core] - 10https://gerrit.wikimedia.org/r/88203 (owner: 10CSteipp) [16:31:02] csteipp: https://gerrit.wikimedia.org/r/#/c/88203/ isn't quite as fragile as it sounded, heh [16:31:08] (03Merged) 10jenkins-bot: Added $wgExtensionEntryPointListFiles for use with mergeMessageFileList.php [core] - 10https://gerrit.wikimedia.org/r/84897 (owner: 10Reedy) [16:33:38] (03PS4) 10Tpt: Implement ContentHandler for page pages [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85418 [16:33:40] (03PS1) 10Siebrand: Add close elements through code [core] - 10https://gerrit.wikimedia.org/r/88500 [16:34:15] (03Merged) 10jenkins-bot: Move forceHTTPS check until after wgTitle is setup [core] - 10https://gerrit.wikimedia.org/r/88203 (owner: 10CSteipp) [16:36:00] (03PS1) 10Siebrand: Remove deprecated HTML tag [core] - 10https://gerrit.wikimedia.org/r/88501 [16:37:11] (03PS1) 10Chad: Default to 1 replicate per shard [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88502 [16:37:14] (03PS5) 10Tpt: Implement ContentHandler facility for page pages [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85418 [16:37:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove deprecated HTML tag [core] - 10https://gerrit.wikimedia.org/r/88501 (owner: 10Siebrand) [16:37:54] hm i shouldn't poke V on that should i [16:37:55] whoops [16:38:30] (03CR) 10Tpt: "PS 4 and 5: improve output for redirections + follow the signature change in ContentHandler::makeRedirect" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85418 (owner: 10Tpt) [16:38:32] https://gerrit.wikimedia.org/r/#/c/84898/5 [16:38:38] Reedy: why is echo special? [16:38:51] * Aaron|home thought it was Flow or something [16:38:59] for jobqueue you mean? [16:39:15] (03CR) 10Tpt: [C: 032] "Already reviewed in PS 3" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85418 (owner: 10Tpt) [16:40:25] Aaron|home: God knows why I put Echo [16:41:12] (03PS2) 10Chad: Default to 1 replicate per shard [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88502 [16:41:13] (03PS1) 10Chad: Remove outdated instructions, Elastica is in another extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88505 [16:42:06] (03CR) 10Tpt: [C: 032] "Minor change in the working branch." [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/88216 (owner: 10Tpt) [16:42:09] (03Merged) 10jenkins-bot: Implement ContentHandler facility for page pages [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/85418 (owner: 10Tpt) [16:42:28] Aaron|home: i think thats the patch about i18n messages on beta cluster? chrismcmahon had been pushing for that patch i believe, the problem was that because Flow is not on the production deployment list its i18n messages wern't being deployed to beta cluster (i havn't looked into it, thats just my understanding from what i've seen chrismcmahon say) [16:42:40] ebernhardson: He knows [16:42:53] ebernhardson: He was questioning why I set it for an extension already deployed on the cluster [16:42:55] ie Echo not Flow [16:42:58] oh :) [16:43:32] (03Merged) 10jenkins-bot: Improve image transformation parameter normalisation [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/88216 (owner: 10Tpt) [16:44:08] (03CR) 10Manybubbles: "(2 comments)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88502 (owner: 10Chad) [16:46:04] (03CR) 10EBernhardson (WMF): [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [16:47:31] (03PS1) 10Siebrand: Remove incorrect span in translation [core] - 10https://gerrit.wikimedia.org/r/88506 [16:49:10] (03PS2) 10Tpt: Major refactoring of the JS part of the page edition system [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87527 [16:50:01] (03CR) 10Tpt: "Rebase" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87527 (owner: 10Tpt) [16:50:06] Reedy: now to actually get the Flow messages over to beta, I'm not sure that's going to happen automatically [16:50:37] Is that not part of the autodeploy? [16:50:53] Thanks aaron. Reedy, we have at least a partial fix for bug 55435. Looks like we're getting ~300 fatals/day from that. Should we backport https://gerrit.wikimedia.org/r/#/c/88203/ ? [16:51:29] Seems sensible to [16:51:31] Reedy: guess we'll find out. [16:51:35] (03PS1) 10Reedy: Move forceHTTPS check until after wgTitle is setup [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88508 [16:51:52] We could almost have a bot for that [16:52:03] !cherry-pick 12345 wmf/1.22wmf20 [16:52:25] don't even have to alt tab out of my irc client then! [16:53:26] I'm AFK for an hour or so, need to go home [16:53:53] F7U12 [16:54:00] Can deploy that later... [16:54:14] ^d: I'm still getting TypeError messages on Gerrit main page [16:54:25] <^d> Huh? [16:54:59] I pinged you about an error in the JS console, maybe a week ago [16:55:51] ^d: http://paste.marktraceur.info/243/raw/phork0.txt [16:56:35] <^d> :\ [16:57:05] (03PS12) 10Matthias Mullie: New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [16:57:06] ^d: Only on the main page though, other pages are fine [16:57:11] (03PS1) 10Ori.livneh: Register WikimediaEvents submodule [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88511 [16:57:12] I'll use dashboards for now [16:57:22] (03CR) 10Raimond Spekking: [C: 032] Remove incorrect span in translation [core] - 10https://gerrit.wikimedia.org/r/88506 (owner: 10Siebrand) [16:57:38] (03PS3) 10Tpt: Major refactoring of the JS part of the page edition system [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87527 [16:57:57] (03CR) 10Tpt: "PS3: Fix an issue introduced by PS 2 rebase" [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87527 (owner: 10Tpt) [17:00:11] greg-g: can I LD an extension rename today? [17:00:16] (03CR) 10Siebrand: "binasher has gone to pursue other interests, so commit summary may need updating." [core] - 10https://gerrit.wikimedia.org/r/51675 (owner: 10Reedy) [17:01:19] ori-l: WikimediaEvents to EveryonesEvents? [17:01:23] :P [17:01:29] <^d> MyEvents! [17:01:38] UrEvents [17:01:53] go on, I can wait [17:02:11] greg-g: yes, CoreEvents -> WikimediaEvents [17:02:48] ori-l: so, on the surface, that seems trivial, but is that risky at all re i10n translations/etc? [17:03:09] no [17:03:15] cool, then yeah [17:03:18] the only message is the extension description in Special:Version [17:03:23] ah, who cares then [17:03:25] :) [17:03:31] versionists [17:03:32] (03CR) 10Alex Monk: [C: 04-1] "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 (owner: 10MarkTraceur) [17:04:01] greg-g: should I do it now or at 4? [17:04:10] (03CR) 10Siebrand: [C: 032] Add method parameter type documentation [core] - 10https://gerrit.wikimedia.org/r/82255 (owner: 10Reedy) [17:04:46] ori-l: if truly unrisky, now, before Echo [17:04:58] (which is in 30 minutes) [17:05:02] well, 25 [17:05:22] (03CR) 10Ori.livneh: [C: 032] Register WikimediaEvents submodule [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88511 (owner: 10Ori.livneh) [17:05:25] sounds like a plan [17:05:32] 24 minutes for jenkins, 1 minute to deploy [17:05:35] deployment window coming up h? [17:05:38] *eh [17:06:05] (03CR) 10MarkTraceur: "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 (owner: 10MarkTraceur) [17:06:09] apergos: yah, Echo at 10:30 pacific [17:06:34] apergos: heya, btw, how's the sync articles from production to beta thing going? [17:06:36] guess there should be plenty of folks around in a good timezone (i.e. during their workday) [17:07:00] yeah, some of SF Opsen are awake at 10am ;) [17:07:08] well I"m thinking that I'm going to shovel the first batch of crud in their mannually [17:07:16] if we trry to automate it, it's never going to get done [17:07:21] heh, true [17:07:38] perfect, good, enemy, etc [17:07:43] (03PS1) 10Ori.livneh: Register WikimediaEvents submodule [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88512 [17:07:46] labs has been having some nfs issues (and I guess there is an update scheduled.. today? tomorrow?) [17:08:00] (03CR) 10Ori.livneh: [C: 032] Register WikimediaEvents submodule [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88512 (owner: 10Ori.livneh) [17:08:17] (03Merged) 10jenkins-bot: Add method parameter type documentation [core] - 10https://gerrit.wikimedia.org/r/82255 (owner: 10Reedy) [17:08:26] apergos: Thur at 18 UTC [17:08:36] which is jusst as well cause I have been busy with other crap, but when it looks like it's back I'll look at one of the smaller set of pages [17:08:47] ok [17:09:23] need to figure out which set of tools is going to be quickest, that's the bulk of the work, after that it's jut grunge (run... curse... rerun.. curse more...) [17:09:54] (03Merged) 10jenkins-bot: Register WikimediaEvents submodule [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88511 (owner: 10Ori.livneh) [17:10:35] I could tell you on my laptop with 0 users what I'd do but on a vm with other users and less memory than I have irl, meh [17:10:47] * greg-g nods [17:11:11] apergos: when you have some thoughts, could you update https://bugzilla.wikimedia.org/show_bug.cgi?id=49779 ? just for the sake of others [17:11:15] sure [17:11:37] basically after I get a first set of pages in there I'll note what choice was made and why [17:11:45] * greg-g nods [17:11:47] thanks apergos [17:12:11] sure [17:12:45] * apergos wanders off to do dishes before deployment [17:13:15] (03PS1) 10Siebrand: Fix PHP CodeSniffer warnings and errors [core] - 10https://gerrit.wikimedia.org/r/88513 [17:13:48] (03CR) 10jenkins-bot: [V: 04-1] Fix PHP CodeSniffer warnings and errors [core] - 10https://gerrit.wikimedia.org/r/88513 (owner: 10Siebrand) [17:16:49] (03Abandoned) 10SuchetaG: mediawiki.api: add postWithToken and getToken Similar to postWithEditToken in mw.api.edit, but more generic. [core] - 10https://gerrit.wikimedia.org/r/88463 (owner: 10SuchetaG) [17:18:25] (03CR) 10Umherirrender: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85517 (owner: 10Umherirrender) [17:19:20] (03PS2) 10Matthias Mullie: Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 [17:23:22] (03PS1) 10EBernhardson (WMF): Workaround for php+apc lambda issues [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88517 [17:23:35] (03PS2) 10Siebrand: Fix PHP CodeSniffer warnings and errors [core] - 10https://gerrit.wikimedia.org/r/88513 [17:24:09] greg-g: done; thank you! [17:24:17] ori-l: thank you [17:24:27] ... for not breaking the site (yet) [17:25:34] (03CR) 10Siebrand: [C: 032] Add myself to authors (maintenance done etc) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84938 (owner: 10Reedy) [17:26:04] (03Merged) 10jenkins-bot: Add myself to authors (maintenance done etc) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/84938 (owner: 10Reedy) [17:28:30] (03CR) 10Siebrand: [C: 032] Fixup parameter type hints [core] - 10https://gerrit.wikimedia.org/r/84480 (owner: 10Reedy) [17:30:37] (03PS1) 10Bsitu: Update Echo and Thanks to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88518 [17:31:25] (03Merged) 10jenkins-bot: Fixup parameter type hints [core] - 10https://gerrit.wikimedia.org/r/84480 (owner: 10Reedy) [17:31:57] (03Abandoned) 10MarkTraceur: Add the userpage link to the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/87169 (owner: 10MarkTraceur) [17:32:28] (03PS1) 10Siebrand: Fix PHP CodeSniffer errors and warnings [core] - 10https://gerrit.wikimedia.org/r/88519 [17:32:53] (03PS6) 10Matthias Mullie: Add style to new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [17:33:39] (03CR) 10Matthias Mullie: [C: 031] "I rebased against updated parent patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [17:33:41] (03PS5) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [17:34:22] (03PS1) 10Bsitu: Update Echo and Thanks to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88520 [17:35:20] (03PS3) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [17:35:36] (03CR) 10BryanDavis: [C: 031] "Worked for me as part of a vagrant destroy/up cycle." [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [17:36:35] brion: If you're up for more review on MultimediaViewer, https://gerrit.wikimedia.org/r/86063 is working nicely now [17:36:46] excellent, will look shortly marktraceur [17:36:50] Huzzah [17:38:07] (03PS2) 10Matthias Mullie: Update style for editing a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88262 (owner: 10Bsitu) [17:38:25] (03CR) 10Matthias Mullie: [C: 031] "Rebased against updated parent patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88262 (owner: 10Bsitu) [17:38:36] Krinkle: Is newFromImgSrc a non-starter or do you think we could get it going soon? You seem concerned about the concept generally, but it seems like the conversation on the patch died down. [17:39:09] marktraceur: I think in general we should not be using thumbnail urls as a public API to get a Title object. [17:39:20] (03CR) 10Bsitu: [C: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88518 (owner: 10Bsitu) [17:39:27] marktraceur: If there is no feasible alternative, then it might be required, but even then I'm not sure it belongs in core mw.Title [17:39:34] Heh. [17:39:36] marktraceur: In which specific case do you want to use this? [17:39:48] And does that scenario not have the title somewhere already? [17:39:52] Krinkle: MultimediaViewer, which is getting information about the files based on thumbnails [17:40:08] marktraceur: based on thumbnails inside a wiki page [17:40:12] Yup [17:40:27] so it has the general [[File:]] html rendering [17:40:34] Krinkle: Yeah [17:41:01] marktraceur: does it need to tie it to a specific thumbnail or any image used on the page in general (possibly the API could be used) [17:41:14] though that'll include non-thumbs like icons used in templates. [17:42:11] (03Merged) 10jenkins-bot: Update Echo and Thanks to master [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88518 (owner: 10Bsitu) [17:42:11] Krinkle: I only tie it to '.thumb a.image' right now, I think [17:42:16] So only thumbnails [17:42:47] marktraceur: I mean, the information you get via the Title, does that feed back to the thumbnail on the page? e.g. if you could make an API call that gives you the titles of images used on this page, woudl that be useful? [17:43:01] Hmmm [17:43:09] or do you need the title bound to the html element (e.g. for a button or something) [17:43:13] Krinkle: Only if I can tie it back to the elements, yeah [17:43:17] k [17:43:26] Krinkle: Because I bring up the lightbox based on clicking on the image [17:43:34] (03PS13) 10Matthias Mullie: New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [17:44:20] Krinkle: But maybe it could still work with id attributes, as long as we could make sure both the API response cache and the parser cache were invalidated when an edit happened [17:44:53] (03PS2) 10Chad: Remove outdated instructions, Elastica is in another extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88505 [17:44:54] (03PS3) 10Chad: Default to 1 replicate per shard [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88502 [17:45:09] Krinkle: The better solution is to have an HTML attribute with the title, but I'm torn between getting it in without trouble (using data-mw-title or so) or following the Parsoid spec, which seems like the "right" way to go [17:45:15] marktraceur: Just to clarify, by id attribute you mean data attribute? And which API request is this? [17:45:54] (03CR) 10Brion VIBBER: "I would recommend having this function accept an img element rather than a URL -- this would allow it to transition naturally to a more ma" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [17:46:34] brion: I was just thinking that, thanks [17:46:42] main thing i don't like about the parsoid spec is the use of page-relative URLs like "./././././Something/foo/bar/what' :D [17:46:53] Krinkle: No, I mean, the parser could put id="thumbnailimage1" or so into the img element and then the API call could return results indexed by the ID [17:47:03] which means among other things that the markup depends on the page title of the *current* page which sounds awful [17:47:09] greg-g: just realized I don't know the answer to this: they only need the current revision right? we're not talking full history of anything [17:47:09] marktraceur: btw, for the unit tests we can ducktype it with an object literal like { src: .. } (so don't use jQuery inside the method but acces it like element.src) [17:47:29] marktraceur: Hm.. that doesn't seem very attractive to me. [17:47:35] or will ther ebe some attribution issues if we do that? [17:48:24] brion: Indeed, we already have a url in most cases (href, src, even on images most of the time the parent has a href to the file page) (url relative or not I couldn' care less) [17:48:26] Krinkle: Should we pass in an element or a jQuery object? [17:48:32] the value would be in having the plain title [17:48:36] marktraceur: element [17:49:00] apergos: I believe that to be true, yes [17:49:06] Krinkle: 'kay [17:49:06] meh, I suppose you could support both. [17:49:18] el = el.jquery ? el[0] : el; [17:49:20] Krinkle: we can't rely on href on the link though since it can be overridden to point to a different page than the file... same with the title/alt attribute :) [17:49:40] all right I'll proceed as I was gonig to then, thanks [17:49:44] brion: I know, I'm just pointing out that having yet another (relative) url isn't very valuable. [17:50:00] we could make that url to the file page mandatory in the html output if we really want to have a url. [17:50:16] (in a different attribute if neccecary) [17:51:50] (03CR) 10Manybubbles: [C: 032] Default to 1 replicate per shard [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88502 (owner: 10Chad) [17:51:53] (03Merged) 10jenkins-bot: Default to 1 replicate per shard [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88502 (owner: 10Chad) [17:52:15] (03CR) 10Manybubbles: [C: 032] Remove outdated instructions, Elastica is in another extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88505 (owner: 10Chad) [17:52:18] (03Merged) 10jenkins-bot: Remove outdated instructions, Elastica is in another extension [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88505 (owner: 10Chad) [17:53:05] *nod* [17:53:16] Krinkle: So, should I bother addressing thoughts on this iteration of the patch, or just rewrite it after adding data-mw-title or so to the HTML output? [17:53:21] that's one reason i prefer a title over a url here; it's actually slightly different information :) [17:53:27] (third bloody solution I've had to write) [17:53:39] (03CR) 10Brion VIBBER: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [17:53:54] marktraceur: I'd recommend going with this, just with slight tweaks ;) [17:54:05] if in doubt, toss it in the extension instead of mw.Title and it'll get through review easier :P [17:54:08] Heh [17:54:23] brion: Cheap solution wasn't my intent, but it seems to be a theme recently [17:54:28] hehe [17:54:31] "git er done" [17:54:39] git-er --done [17:54:39] or "do the needful"? [17:54:52] (03PS1) 10BryanDavis: Add doc comment to Status explaining use [core] - 10https://gerrit.wikimedia.org/r/88522 [17:55:36] brion: All right, if you're happy enough (nearly) to merge it, I'll stop listening to Krinkle whine for the time being :) [17:55:47] :) [17:56:22] marktraceur: Did you read my comments from yesterday? (e.g. move it up to below newFromtext and return null instea of undefined) [17:56:25] (03CR) 10Aaron Schulz: [C: 032] Add doc comment to Status explaining use [core] - 10https://gerrit.wikimedia.org/r/88522 (owner: 10BryanDavis) [17:56:33] Yeah, I fixed them [17:56:48] Krinkle: I do need to fix the tests, but otherwise it's better now [17:57:01] I more meant your whining about this not belonging in core, etc. [17:57:18] marktraceur: it still says @returns {. | undefined } [17:57:25] (03CR) 10Manybubbles: [C: 031] "Aaron beat me to the +2" [core] - 10https://gerrit.wikimedia.org/r/88522 (owner: 10BryanDavis) [17:57:28] ah, you forgot to update the comment, the code is updated. [17:57:42] Oh? [17:57:50] Hm, thought I did both. Weird. [17:57:54] AaronSchulz, Aaron|home: \o/ [17:59:01] brion: I think I dealt with all two possible values of $wgHashedUploadDirectory, what's your comment about? [17:59:47] ah nvmind [18:00:00] marktraceur: that's what i get for skimming sometimes :D [18:00:21] Indeed [18:00:28] And...hm [18:00:42] I guess it's true that file extensions are sometimes longer, but for images I'd guess not [18:00:46] (03Merged) 10jenkins-bot: Add doc comment to Status explaining use [core] - 10https://gerrit.wikimedia.org/r/88522 (owner: 10BryanDavis) [18:00:56] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [18:01:14] Well fine guys [18:01:23] marktraceur: images could be thumbnails of funky formats though [18:01:36] i'd just drop the length check [18:02:04] 'kay [18:02:08] Done now [18:02:31] (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [18:02:40] just writing down my 'never mind' there :) [18:04:04] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [18:04:27] marktraceur: if not already, also add a test for .svg.png thumbnails [18:04:42] where the thumbnail not only adds 123px- but also the .png suffix [18:04:45] good times B) [18:05:20] 'kay [18:05:23] the regex is checking for the intermediate directory so that should work, but yes test it :D [18:05:23] I think it already has one [18:05:35] Krinkle: Yeah, the wikipedia logo one [18:05:49] brion: ah, good one. So it works already, that's nice. still test it though. [18:05:58] (as it does ) [18:08:54] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [18:10:01] Argh. [18:10:19] Removing the file extension check makes it too broad a regex [18:10:55] Krinkle, brion, d'you think adding a check for at least one full stop would be enough? I don't think we have any files without extensions. [18:11:00] (03CR) 10Bsitu: [C: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88520 (owner: 10Bsitu) [18:11:15] (03PS2) 10Reedy: Move forceHTTPS check until after wgTitle is setup [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88508 [18:11:20] (03CR) 10Reedy: [C: 032] Move forceHTTPS check until after wgTitle is setup [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88508 (owner: 10Reedy) [18:11:22] marktraceur: Indeed, but why would we hardcode that here? [18:11:42] marktraceur: either check for a dot but not the length, or just skip the check [18:11:48] not sure it's really needed [18:12:04] Krinkle: Because if I try to parse /wikipedia/commons/thumb/Wikipedia-logo-v2.svg/150px-Wikipedia-logo-v2.svg.png with the non-dot, non-length version, I get "wikipedia" [18:12:20] marktraceur: it should match against the end [18:12:25] all regexes shuld have a $ [18:12:28] Actually [18:12:42] Hrm, 'kay [18:12:44] I'll do that then [18:12:47] and for the thumbnail, ignore the last part, but include it in the regex [18:13:34] Sure sure [18:13:47] Wait - can files include slashes in their names? I suspect no. [18:13:53] Since it would cause storage issues. [18:14:03] Indeed, I hope so. [18:14:22] We'll go with that [18:14:35] (03CR) 10Aaron Schulz: [C: 032] Allow $context->setTitle( null ) [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [18:14:57] lol, lovely train of thought this whole AM; "Hey look Google App Engine Supports PHP" -> -> "Lets see what it would theoretically take to run MW on GAE" -> -> "Cool, the Cloud SQL instances can completely turn off saving money when no-one is using them" -> "Wait isn't that kind of 0-∞ scaling generally the intended purpose of real cloud environments. I wonder what can be done with Load Balancing and scaling on AWS." -> (03CR) 10jenkins-bot: [V: 04-1] Update Echo and Thanks to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88520 (owner: 10Bsitu) [18:16:55] * -> -> "*drool* Now I want to setup a wiki host with common load balancing, etc... where various MW site code filesystems are stored in object storage somewhere and instances are auto-scaled to fit traffic sourcing their code from the object storage" [18:18:01] (03CR) 10EBernhardson (WMF): [C: 04-1] "I think there is one piece missing, based on the design iteration 5: https://upload.wikimedia.org/wikipedia/commons/1/1e/Flagged.png" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [18:18:16] marktraceur: Hm.. digging into the code (starting up at SpecialUpload, down to File.php) I don't see anything in Title.php, LocalRepo, FileRepo, File that would invalidate the slash [18:18:51] (03CR) 10Bartosz Dziewoński: "Any chance to get this in 1.22, please?" [core] - 10https://gerrit.wikimedia.org/r/84315 (owner: 10Bartosz Dziewoński) [18:19:05] marktraceur: when I submit one with a slash (Foo/bar.png) it brings be back to the upload form sauing the nae was changed to "bar.png" [18:19:07] interesting [18:19:11] Hrmmm. [18:19:49] UploadBase; $warnings['badfilename'] = $filename; [18:19:51] :) [18:20:37] (03CR) 10Brion VIBBER: [C: 04-1] "'Unrecognized value for parameter 'meta': repoinfo' ..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 (owner: 10MarkTraceur) [18:21:35] brion: Bollocks, I thought I'd fixed that [18:21:41] * marktraceur scrambles [18:21:49] lightbox pops up, but i don't seem to have any metadata displayed [18:22:13] Yeah, because the repo request failed [18:22:21] that makes sense :D [18:23:18] (03CR) 10Ori.livneh: "recheck" [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88520 (owner: 10Bsitu) [18:23:35] * brion stabs apple -- https://github.com/mxcl/homebrew/wiki/C++-Standard-Libraries [18:23:57] apparently they switched standard C++ libraries under the hood in 10.9 [18:24:05] * brion stabs C++ [18:24:19] marktraceur: found it, UploadBase::getTitle, uses $this->mFilteredName = wfStripIllegalFilenameChars( $this->mFilteredName ); [18:24:28] <^d> brion: Are they shipping a semi-modern gcc finally? [18:24:30] Woot [18:24:37] ^d: they're killing gcc in favor of clang [18:24:42] so probably not :) [18:25:09] admittedly, clang/llvm is awesome [18:25:16] * brion points to his crazy javascript video decoder :) [18:25:49] (03CR) 10Bsitu: [V: 032] Update Echo and Thanks to master [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88520 (owner: 10Bsitu) [18:28:27] (03Merged) 10jenkins-bot: Move forceHTTPS check until after wgTitle is setup [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88508 (owner: 10Reedy) [18:28:41] (03CR) 10CSteipp: [C: 031] "I'll let you guys figure out the best place to put the code, but the list looks correct to me. Thanks!" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87617 (owner: 10Anomie) [18:28:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [18:30:04] (03Merged) 10jenkins-bot: Allow $context->setTitle( null ) [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [18:32:25] (03CR) 10Jdlrobson: [C: 04-1] "I'm not entirely sure why but this causes a parse error:" [core] - 10https://gerrit.wikimedia.org/r/88266 (owner: 10Krinkle) [18:33:17] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88464 (owner: 10SuchetaG) [18:33:59] (03CR) 10Krinkle: "plop" [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit) [18:36:35] (03PS8) 10MarkTraceur: Add file-link "parser" to mw.Title from commons [core] - 10https://gerrit.wikimedia.org/r/87487 [18:37:30] (03CR) 10EBernhardson (WMF): "Checked with may, the "Talk to JearBear" button should link to the person who hid the comments talk page." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [18:38:19] (03CR) 10Anomie: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88410 (owner: 10MarkTraceur) [18:39:10] (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88410 (owner: 10MarkTraceur) [18:40:32] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88410 (owner: 10MarkTraceur) [18:40:33] (03CR) 10Legoktm: "Bump?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/78491 (owner: 10Legoktm) [18:40:51] (03CR) 10Aaron Schulz: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson (WMF)) [18:41:09] (03PS1) 10SuchetaG: Fixes the issues mentioned on the comments. [core] - 10https://gerrit.wikimedia.org/r/88532 [18:41:26] (03PS1) 10BryanDavis: Escape backticks when quoting MySQL identifiers [core] - 10https://gerrit.wikimedia.org/r/88533 [18:42:15] (03CR) 10jenkins-bot: [V: 04-1] Fixes the issues mentioned on the comments. [core] - 10https://gerrit.wikimedia.org/r/88532 (owner: 10SuchetaG) [18:43:18] (03PS8) 10MarkTraceur: Pull data from API, load title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 [18:45:01] Ironholds: for hidden comments that are expanded, do we need to show the username that created the post? It wasn't in https://mingle.corp.wikimedia.org/projects/flow/cards/269 so its not currently in the design. [18:45:20] doh wrong room again :P [18:47:38] https://code.google.com/p/gerrit/issues/detail?id=2172 [18:48:40] (03PS5) 10SuchetaG: mediawiki.api: add postWithToken and getToken [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit) [18:49:35] (03CR) 10jenkins-bot: [V: 04-1] mediawiki.api: add postWithToken and getToken [core] - 10https://gerrit.wikimedia.org/r/64582 (owner: 10Nikerabbit) [18:49:38] (03PS3) 10Legoktm: [WIP] Convert to use jQuery [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88405 [18:49:50] (03PS4) 10Legoktm: Replace sajax with an API module [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88250 [18:53:30] Nikerabbit: sucheta: Hm.. what's going on wit the postWithToken change? https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+branch:master+topic:2013/api,n,z [18:53:59] Nikerabbit: sucheta: There are 3 changes all with the same commit message that depend on each other. and the middle one is actually abandoned, and the third one depends on the abanandoned one [18:54:04] abandoned* [18:54:11] (03CR) 10Brion VIBBER: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [18:54:25] Ohhh nooooo [18:54:47] Craaay [18:54:55] Craaap* [18:55:17] (03PS9) 10MarkTraceur: Add file-link "parser" to mw.Title from commons [core] - 10https://gerrit.wikimedia.org/r/87487 [18:55:21] * marktraceur grumbles [18:55:30] Krinkle: if you have no strong objection i'm happy to land the mw.Title.newFromImg with that fix [18:55:32] (03CR) 10Spage: "(7 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [18:55:33] Picky picky picky [18:55:38] marktraceur: ? [18:55:40] if you'd prefer, i can recommend that poor marktraceur move it to his extension for now :) [18:56:09] Krenair: I'm pulling brion's leg because he caught the _only_ rename that I missed [18:56:15] :) [18:56:21] brion: I think the implementation is fine (I'd save one statement by merging img = img; and src = img.src) [18:56:23] always double-check the comments ;) [18:56:45] brion: but those data attributes do seem appealing, and alternatively, having this iterate inside that extension before having to support it in core, seems appealing too [18:56:48] sucheta, It was me messing up the patchsets. Gerrit was being unbelievably evil to me since last night. Sorry. [18:56:54] Gah. [18:56:57] that way we can see how it goes and move it in core if it goes well. [18:57:06] sucheta: Talkin' to yourself? Not surprising. [18:57:17] marktraceur, Its fun. [18:57:46] sucheta: no worries, Gerrit can be very... shall we say... playful. [18:58:10] Krinkle: It's also used in gadgets on Commons, and I suspect more Multimedia tools will have need of it [18:58:26] So having it maintained in core, rather than splitting it up, seems sane [18:58:30] marktraceur: It can't be used on Commons yet, it isnt in core yet. [18:58:31] it does seem like a common thing of usefulness [18:58:46] Krinkle: I mean, the idea *comes* from a gadget on Commons [18:58:51] yeah [18:59:07] And they can delete the old untested version and start using a new moretested one [18:59:09] Krinkle, RoanKattouw, TrevorParscal, jdlrobson: Use here for your Vector font bugs sprint? [18:59:21] I'm here [19:00:01] Maybe use -meetbot :P [19:00:12] marktraceur: brion: k. btw, what do you think of the data attribute approach? This can be changed later to use that (seems useful to abstract it and not require code to hardcode that data attribtue either, I like this method more now that it uses the img element) [19:00:18] marktraceur: It's not a meeting, it's work. I don't think a log makes sense. [19:00:35] lets keep this in core, and then look into getting that data attribute in there (or not if there are good reasons not to) [19:00:39] Krinkle: i think the data attribute is the way to go in future yes [19:00:40] lol [19:00:48] and taking the img element future-proofs us for that [19:00:49] Krinkle: I like the data attribute idea, yeah, it's just not going to be as trivial as this [19:00:52] Ed's "disable insert reference button when document is empty" fix broke [19:01:02] (03PS11) 10Wikinaut: Bug 46617: Allow account creation through OpenID when the wiki disallows for anons [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/81629 [19:01:12] Turns out [

,

, , ].length >= 2 [19:01:12] James_F: I'm about to have dinner. I'll catch up. [19:01:18] I could probably scheme to get cscott to write the data-attribute patch if I play my cards right :P [19:01:25] Krinkle: Tell TrevorParscal, not me. :-) [19:01:29] (03CR) 10Parent5446: [C: 031] Escape backticks when quoting MySQL identifiers [core] - 10https://gerrit.wikimedia.org/r/88533 (owner: 10BryanDavis) [19:02:07] (03CR) 10Brion VIBBER: [C: 031] "So I'm inclined to go ahead and land this now, knowing we can enhance it to use a data attribute in future once we've synced up what we wa" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [19:02:17] brion: That sounded like assent to me [19:03:06] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/APC] - 10https://gerrit.wikimedia.org/r/88539 (owner: 10L10n-bot) [19:03:42] hmm [19:04:01] pushing +2 in 10 seconds.... :D [19:04:29] (03CR) 10Brion VIBBER: [C: 032] "Heck, let's land it. :D" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [19:05:06] Muahaha. [19:05:16] Getting brion to review patches is the most productive thing ever [19:05:24] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/79948/ [19:05:30] And it always ends with the most entertaining patch comments. [19:05:37] heh [19:06:15] * marktraceur shifts to *other* core dependency [19:07:12] jdlrobson: That's only 300 lines of code :) [19:07:24] (03PS5) 10EBernhardson (WMF): Add new recentchanges field rc_source to replace rc_type [core] - 10https://gerrit.wikimedia.org/r/85787 [19:07:45] RoanKattouw: hurray for less :) [19:08:10] (03CR) 10EBernhardson (WMF): "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/85787 (owner: 10EBernhardson (WMF)) [19:09:17] (03Merged) 10jenkins-bot: Add file-link "parser" to mw.Title from commons [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [19:10:08] (03CR) 10Catrope: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:10:56] Krinkle|detached , jdlrobson : if an extension wants to use .background-image-svg() in its LESS, does it need to @import '../../../../../resources/mediawiki.less/mediawiki.mixins.less'@import '../../../../../resources/mediawiki.less/mediawiki.mixins.less' ? [19:12:31] lol, combining the job queue (though it might have to be implemented with SQS) with auto-scaling and spot instances sounds awesome. [19:14:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Now runs on core master. :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 (owner: 10MarkTraceur) [19:14:28] Krinkle|detached: we're learning to use git review [19:14:55] spagewmf: no just @import 'mediawiki.mixins.less' [19:14:58] it's in the include path :) [19:15:33] AaronSchulz: are errors in jobs handled in the job runner? [19:15:38] (03CR) 10EBernhardson (WMF): "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88398 (owner: 10Werdna) [19:15:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/87527 (owner: 10Tpt) [19:15:54] Wait till AWS has a pile of spare compute time really low prices, then automatically start handling jobs at a lower cost than usual . [19:16:10] gwicke: warnings don't do much and exceptions are caught [19:16:31] (03PS14) 10Matthias Mullie: New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [19:16:39] (03CR) 10Matthias Mullie: "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [19:16:44] (03PS2) 10Cmcmahon: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [19:17:08] Aaron|home: yeah, but something like accessing an undefined array key will simply crash the PHP process afaik [19:17:23] is that handled by monitoring the subprocess or the like? [19:17:41] (03PS29) 10Trevor Parscal: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:17:49] fatals will end the process and in a second or so one will take its place [19:18:15] will that retry the job then? [19:18:18] well, with jobs-loop [19:18:54] it will retry the job 2 more times [19:18:55] to me it sounds like jobs cannot really fail [19:19:01] or rather, should not [19:19:27] better to silently hide bugs than fail [19:20:22] (03CR) 10Catrope: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:20:57] TrevorParscal: Did you rebase? [19:21:31] brion: spagewmf: also, without ".less" [19:21:33] nodejs style [19:23:13] jdlrobson: I left a couple of comments on PS28, that's about all the CR I can do. The rest is all LESS which I don't speak very well [19:23:34] TrevorParscal, Krinkle: You guys are on your own reviewing his CSS/LESS [19:26:04] (03CR) 10Krinkle: [C: 04-1] "* Use a less generic class name than "Beta". The class may not be needed though, that'd be even better." [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:26:32] (03PS2) 10Chad: Moved RandomTest to phpunit where it belongs, started cleanup [core] - 10https://gerrit.wikimedia.org/r/83944 [19:26:40] <^d> Unit tests, hell yeah :) [19:26:45] I'm going through what's been done in this patch with Jon right now [19:26:58] we can use google hangout if you want so we can all talk together [19:27:42] <^d> brion: Do you happen to have mediawiki/extensions/normal compiled on your system? [19:27:46] <^d> I can't get it to build :\ [19:28:30] TrevorParscal: I think I'm gonna call it a night soon [19:28:39] really? [19:28:39] Just getting my commits in order to push them to Gerrit now [19:28:41] ok [19:28:49] I need you for something [19:28:52] I went to sleep at 1:30 last night and got up at 8 :S [19:28:54] https://gerrit.wikimedia.org/r/#/c/79948/28/skins/Vector.php,unified [19:28:56] (03Merged) 10jenkins-bot: Pull data from API, load title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 (owner: 10MarkTraceur) [19:29:09] this is an excellent observation, but do you have any ideas about solving this? [19:29:29] Well, I suppose there could be a hook that allowed you to modify an array of modules to load [19:29:32] <^d> Ah, it's somewhere else. [19:29:34] <^d> Silly swig. [19:29:57] yup, that's what I was thinking [19:30:01] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:30:05] seems reasonable [19:30:07] BTW there's also no reason that I can see why $this->isBeta should be set in the init function and referenced later, it's only referenced once [19:30:13] idea for hook name? [19:30:15] The check can just live there [19:30:22] And at that point it's easier to imagine the hook situation [19:30:37] SkinVectorStyleModules ? [19:30:39] (03PS3) 10Matthias Mullie: Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 [19:30:41] Something like: [19:31:21] the problem is, at least now, he's choosing which thing to add, not just adding an extra style [19:31:29] $modules = array( 'skins.vector', 'skins.vector.styles' ); wfRunHooks( 'SkinVectorStyleModules', array( $this, $out, &$modules ); $out->addModuleStyles( $modules ); [19:31:38] That's OK, you pass $modules by reference [19:31:42] right [19:31:46] So the hook can remove things from the array as well as add [19:32:07] yeah [19:32:46] (03CR) 10Aaron Schulz: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [19:32:49] (03CR) 10Krinkle: "* Change the resource definition dynamically instead of registering 2 modules. Modules should be canonical names for functionality and log" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:33:21] * Krinkle catches up in this channel [19:34:19] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [19:34:34] gwicke: anyway, the error would have just been a notice not a fatal [19:34:59] RoanKattouw: Afaik we can change the module definition (or actually, it should only have to add something to it, not change it, right now it duplicates the variable file but that doesn't ahve to be that way) [19:35:23] No, that's a terrible iea [19:35:27] I'm going to refute that on the bug [19:35:36] RoanKattouw: OK, Why? [19:35:45] You can't dynamically change the definition of a module, which is global, based on a *user* preference [19:36:03] Ah, it's a user preference. Ugh. [19:36:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Not sure how fond I am of "Talk to [user]"." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [19:36:30] RoanKattouw: ok, but then at least we don't need skins.vector *and* skins.vector.variation [19:36:36] we need 2, not 3 [19:36:47] they'll be in the same request anyway. [19:37:29] * cscott wakes up, reads backlog, is confused [19:37:32] * cscott blames marktraceur [19:37:42] (03CR) 10Catrope: "Ignore what Krinkle says about dynamically registering the module, that's a terrible idea. You cannot define an RL module (which is a glob" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:37:53] ok :-) [19:37:58] Sure, fine [19:38:27] cscott: You just woke up? [19:39:27] jdlrobson: TrevorParscal: RoanKattouw: Is anyone amending the patch set? [19:39:43] I'm not doing anythin [19:39:50] (03PS4) 10BryanDavis: Add script to purge changed files from cache [core] - 10https://gerrit.wikimedia.org/r/87635 [19:39:53] Im going to hook-ify the module thing [19:39:56] I'm going to gather up my VE Gerrit changes and call it a night [19:39:57] you? [19:40:00] RoanKattouw: Krinkle so essentially in an ideal scenario i would have an extension which takes skins.vector.styles and swaps out the variables.less file in the array to be the beta one. and append the additional styles [19:40:21] I suppose so [19:40:21] thus this would need 1) a core change 2) a change to BetaFeatures to package it in there or creating a new extension just for this purpose [19:40:29] jdlrobson: Is there no way you can make it entirely override-based? [19:40:30] (03PS1) 10Krinkle: mediawiki.action.edit.preview: Fix for LiquidThreads hack [core] - 10https://gerrit.wikimedia.org/r/88619 [19:40:45] Surely at least for the less vars you can load the beta one after the core one and the values will just be overwritten? [19:40:49] (03PS2) 10Krinkle: mediawiki.action.edit.preview: Fix for LiquidThreads hack [core] - 10https://gerrit.wikimedia.org/r/88619 [19:41:00] RoanKattouw: yes [19:41:15] And yeah otherwise you can grab $modules, remove a module from it, and add a module to it [19:41:21] jdlrobson: That would require duplicating the styles and having them overwrite on the client side, that's not ideal. [19:41:25] That's equivalent to what you're already doing (adding either one module or the other depending on whether beta is enabled) [19:41:26] and might mess with cascading order in general [19:42:57] (03CR) 10Spage: "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [19:43:16] (03PS4) 10Matthias Mullie: Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 [19:43:43] <^d> The helllllll [19:43:44] <^d> http://p.defau.lt/?pjxD_YJBskR1x8Z1Y8xHcQ [19:43:49] Krinkle: I don't see how it would require anything clients-ide [19:43:53] (03CR) 10Parent5446: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [19:44:01] (03CR) 10Parent5446: [C: 04-1] "See PS3 comments." [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [19:44:21] Krinkle: RoanKattouw Trevor and I are breaking out stuff into a separate extension called VectorBeta [19:45:26] (03PS3) 10Cmcmahon: Created a test for ProveIt gadget [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [19:46:28] <^d> How on earth does this blasted thing compile. [19:46:29] (03CR) 10Cmcmahon: [C: 031] "by using title: to address the Edit link we can run the test for users who have VisualEdit enabled" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/87436 (owner: 10Plavi) [19:46:39] Awesome [19:48:17] (03CR) 10Krinkle: "* As is this will cause a regression on all cached pages for ~ 30 days because module skins.vector is now incomplete (which his referenced" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [19:48:50] jdlrobson: wait, what? So this patch is obsolete? I'll wait for you to finish then. I'm amending the patch to address the mentioned issues. [19:49:12] Krinkle: it's not obsolete - we're just breaking out the unnecessary non-core changes [19:49:24] any ideas you have are still valuable [19:49:32] RoanKattouw: If you register the module in the extension, it can't override the less variables. the beta module doens't only add styles (screenBeta.less) it also changes variables used in the main screen.less [19:49:42] is there any way we can make the styles vary on the user in this case? [19:49:51] since the preference is per user [19:50:00] Krinkle: Right, I see [19:50:13] jdlrobson: What do you mean "make styles vary on the user"? You're already doing that AFAICT [19:50:32] (03CR) 10Nemo bis: "Ok, I've asked Nikerabbit to comment as that's his approach. I'll see what to do." [core] - 10https://gerrit.wikimedia.org/r/83220 (owner: 10Nemo bis) [19:50:36] RoanKattouw: just responding to "cause a regression on all cached pages for ~ 30 days" [19:50:41] Do you mean have one module output different styles for different users? That's possible but a bit hairy, see ResourceLoaderUserCSSPrefsModule.php [19:50:48] That's only for anons [19:50:59] will in this situation skins.vector.styles will have 2 flavours [19:51:00] And only if you rip stuff out of the main module [19:51:14] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88619 (owner: 10Krinkle) [19:52:02] Krinkle is right that you can't add a new module that then needs to be in the head of all page views, that will fail due to caching [19:52:39] I hadn't considered that, that's a good point [19:52:49] jdlrobson: the problem is that skins.vector is now incomplete withotu that second module. That will break pages for ~ 30 days, which makes sense because you're changing the meaning of module 'skins.vector'. We should keep skins.vector as-is and replace that one with skins.vector.beta instead of replacing only the skins.vector.styles module [19:52:49] (That's something we should fix in RL BTW) [19:53:32] Krinkle: roger. i understand what you mean [19:54:01] RoanKattouw: arguably no, this expected imho. Even if we'd somehow replace that site-wide in all caches (e.g. ESI though that's tricky as it can vary by page), I think it is sensible to keep module names semantic/canonical. [19:54:28] but yeah, we might be able to make that possible in RL, but I don't think we need it. [19:54:35] Krinkle: so i suppose the trick would be to create a clone 'skins.vector' and then substitute the variables.less file [19:55:03] (called skins.vector.beta) [19:55:05] jdlrobson: that's what I was doing in my working copy before I heard you're doing it in an extension. [19:55:22] Essentially I moved the files from skins.vector to be imports in screen.less [19:55:27] Krinkle: but how would you ensure localBasePath was valid (as now the variables file would be in a different folder)? [19:56:02] Krinkle: can you post this patch to a sandbox? [19:56:32] It's a trivial move of 4 lines of code. and actually, I don't have that patch yet :) [19:56:38] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88621 [19:56:56] Krinkle: ok :) [19:57:55] (03PS15) 10Matthias Mullie: New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [19:59:06] TrevorParscal: I'll continue on something else for now. Let me know if there's a patch you want me to look at. See last comment on https://gerrit.wikimedia.org/r/#/c/79948/ for what I was going to change. [19:59:26] (seems easier for you two to handle it in physical proximity, I can't see what you're doing) [19:59:42] (03CR) 10Matthias Mullie: "(5 comments)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [20:01:05] TrevorParscal: jdlrobson: What I had locally: https://gist.github.com/Krinkle/e5aff1bc722218579dab [20:01:30] (variables were in a different order, and one of the variables was missing from variables.less, presumably not used by non-beta, but should be defined in both) [20:01:35] (03PS1) 10MaxSem: Update MobileFrontend to production tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88622 [20:01:52] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88622 (owner: 10MaxSem) [20:01:56] ^d: I can now no longer access dashboards [20:02:10] <^d> I haven't done anything :\ [20:02:44] Well, something's weird [20:02:59] Individual patch pages still work [20:03:17] (03PS5) 10Matthias Mullie: Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 [20:03:19] Oh, the UW dashboard works OK. I guess custom ones don't, though. [20:04:10] * marktraceur doesn't understand this [20:04:16] (03PS3) 10Krinkle: mediawiki.action.edit.preview: Fix for LiquidThreads hack [core] - 10https://gerrit.wikimedia.org/r/88619 [20:04:38] James_F: are you updating VE to HEAD during your window today or just cherry-picking a fix? [20:04:58] ori-l: Cherry-picking, sorry. [20:05:14] Ok, no problem. I was just curious. [20:05:25] ori-l: Also, I checked with gwicke; he said Parsoid was going to push new master to production some time this week once they fixed a few more things. [20:05:45] cool. [20:08:47] (03PS1) 10Chad: Ignore some of the normalization files [core] - 10https://gerrit.wikimedia.org/r/88623 [20:12:57] (03PS1) 10MarkTraceur: Quick refactor of the http logic in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/88625 [20:14:39] anomie: ^^ [20:15:16] (03PS1) 10Hashar: Translate no more need phpcs lenient jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88626 [20:16:38] (03PS3) 10MarkTraceur: Add some siteinfo to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 [20:16:38] Muuuuch shorter patch. [20:16:42] (03CR) 10Hashar: [C: 032] Translate no more need phpcs lenient jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88626 (owner: 10Hashar) [20:17:23] (03Merged) 10jenkins-bot: Translate no more need phpcs lenient jobs [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88626 (owner: 10Hashar) [20:17:37] (03PS5) 10BryanDavis: Add script to purge changed files from cache [core] - 10https://gerrit.wikimedia.org/r/87635 [20:18:30] (03CR) 10EBernhardson (WMF): [C: 032] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [20:18:45] (03PS1) 10Dereckson: Cleaning code in includes/Exception.php [core] - 10https://gerrit.wikimedia.org/r/88627 [20:18:48] (03CR) 10BryanDavis: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [20:19:18] (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.action.edit.preview: Fix for LiquidThreads hack [core] - 10https://gerrit.wikimedia.org/r/88619 (owner: 10Krinkle) [20:19:25] (03CR) 10BryanDavis: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/87635 (owner: 10BryanDavis) [20:21:51] (03Merged) 10jenkins-bot: New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [20:25:02] (03CR) 10EBernhardson (WMF): [C: 04-1] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [20:25:09] (03CR) 10MaxSem: [C: 032 V: 032] Update MobileFrontend to production tip [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88621 (owner: 10MaxSem) [20:26:17] (03CR) 10Helder.wiki: [C: 031] mediawiki.action.edit.preview: Fix for LiquidThreads hack [core] - 10https://gerrit.wikimedia.org/r/88619 (owner: 10Krinkle) [20:27:00] (03Merged) 10jenkins-bot: mediawiki.action.edit.preview: Fix for LiquidThreads hack [core] - 10https://gerrit.wikimedia.org/r/88619 (owner: 10Krinkle) [20:27:08] (03PS5) 10Ori.livneh: Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [20:28:54] (03PS6) 10EBernhardson (WMF): Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [20:28:56] (03CR) 10Parent5446: [C: 04-1] "Tabs are the standard. Why is this file different?" [core] - 10https://gerrit.wikimedia.org/r/88627 (owner: 10Dereckson) [20:29:00] ori-l: the dot '.' causing a parse error when in a literal mixin call parameter, would you say that is a (fixable) bug? [20:29:09] I can reproduce it in less.js as wlel [20:29:32] less>> .backgrond-image(@src) { background-image: url(@src); } .foo { .backgrond-image(images/foo.png); } [20:29:34] (03CR) 10EBernhardson (WMF): "Patch Set 6:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [20:29:40] (03CR) 10EBernhardson (WMF): [C: 032] Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [20:29:42] Syntax error: expected ')' got '.' [20:29:43] Krinkle: I'm not caught up with this particular issue, let me stare at it for a moment. [20:30:28] (03Merged) 10jenkins-bot: Hide hidden posts, revealing them only after clicking [Show] [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88494 (owner: 10Matthias Mullie) [20:30:49] ori-l: jdlrobson: https://github.com/less/less.js/issues/1588 [20:31:38] (03PS1) 10Dereckson: Fixes stacktrace output when no file context is available. [core] - 10https://gerrit.wikimedia.org/r/88628 [20:32:09] Krinkle: the argument should be quoted [20:32:40] (03CR) 10Aaron Schulz: [C: 032] Fix revision table cleanup on delete [core] - 10https://gerrit.wikimedia.org/r/87505 (owner: 10Tim Starling) [20:33:15] hrm, though I see your point; it's fine that there's a workaround, but it's still annoying that it chokes on this [20:33:30] yeah, I'll quote them for now, but I was hoping not to have to. [20:34:25] Krinkle: suppose this was easy to fix in lessphp; do you think it'd be appropriate for upstream to merge it? [20:34:31] given that lessjs is the reference implementation [20:34:49] I think so yes [20:35:00] ori-l: upstream lessphp or lessjs? [20:35:02] (03PS2) 10MarkTraceur: Quick refactor of the http logic in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/88625 [20:35:08] (03CR) 10Helder.wiki: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [20:35:09] (03Abandoned) 10Dereckson: Cleaning code in includes/Exception.php [core] - 10https://gerrit.wikimedia.org/r/88627 (owner: 10Dereckson) [20:35:10] (03CR) 10Aaron Schulz: [C: 032] "unblocking" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87617 (owner: 10Anomie) [20:35:13] Woops [20:35:59] (03CR) 10MarkTraceur: [C: 04-1] "Failed rebase, sec." [core] - 10https://gerrit.wikimedia.org/r/88625 (owner: 10MarkTraceur) [20:36:09] (03CR) 10BryanDavis: [C: 031] Do not set $wgServer in CLI install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [20:36:23] (03Merged) 10jenkins-bot: Add necessary functions to $wgRedactedFunctionArguments [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87617 (owner: 10Anomie) [20:36:38] marktraceur: Can get get API urls for non-API repos (e.g. DB repo)? Through wiki-id/site-id or something. otherwise we probably can't use this API for much in production since we don't use commons over API (and in the VisualEditor media insertion dialog we'd want to use this API) [20:36:46] (03Merged) 10jenkins-bot: Fix revision table cleanup on delete [core] - 10https://gerrit.wikimedia.org/r/87505 (owner: 10Tim Starling) [20:36:47] (03PS3) 10MarkTraceur: Quick refactor of the http logic in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/88625 [20:37:40] (03CR) 10EBernhardson (WMF): [C: 032] "(1 comment)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 (owner: 10Werdna) [20:37:54] marktraceur: afaik it already has a way of getting a url, since it outputs links like "From a [link to commons shared repository]" on the File page. [20:38:01] but probably not yet nicely exposed [20:38:23] ori-l: are you asking whether we should fix it in mw and then ask upstream lessphp to merge it? [20:38:36] Krinkle: I actually don't think this patch will wind up being particularly useful for getting the API URL [20:38:55] (03PS7) 10Bsitu: Add style to new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 [20:38:57] (03CR) 10jenkins-bot: [V: 04-1] Add AJAX header modification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88412 (owner: 10Werdna) [20:38:59] I'm adding siteinfo to the return value in a separate patch, and I think everything else is covered by other parts of the API [20:39:00] ori-l: or to fix it in lessphp (here and upstream) and then ask upstream lessjs to merge it. I think lessphp will reject that and will want to have it be in lessjs first. [20:39:19] marktraceur: Oh, I didn't even look at your patches yet. Just a thought in general. [20:40:01] marktraceur: the recently landed api to get foreign file repo data, from what I saw originally the apiUrl (or any url for that matter) was added to the info array from the api repo subclass only. [20:40:07] Krinkle: so, I'm to the point where I need you now [20:40:32] TrevorParscal: k. where do I look / ask away. [20:40:55] (03PS2) 10Dereckson: Fixes stacktrace output when no file context is available. [core] - 10https://gerrit.wikimedia.org/r/88628 [20:40:56] let's video chat [20:40:57] (03PS1) 10EBernhardson (WMF): Merge "New design" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88629 [20:41:36] (03PS2) 10MarkTraceur: Recursive filerepoinfo [core] - 10https://gerrit.wikimedia.org/r/86393 [20:42:04] Krinkle: It was, but actually the API url is only slightly useful [20:42:16] (03Abandoned) 10EBernhardson (WMF): Merge "New design" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88629 (owner: 10EBernhardson (WMF)) [20:42:21] So I'm turning to other solutions. [20:45:32] Krinkle: the problem is not just the '.'; '/' is interpreted as a division operator unless quoted [20:45:41] (03PS2) 10EBernhardson (WMF): Workaround for php+apc lambda issues [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88517 [20:49:51] (03PS1) 10Legoktm: Fix phpdoc comment [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88631 [20:51:05] (03CR) 10Aaron Schulz: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [20:51:35] (03PS1) 10Aaron Schulz: Fix revision table cleanup on delete [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88632 [20:54:37] (03PS2) 10Legoktm: Fix phpdoc comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88631 [20:55:24] (03CR) 10EBernhardson (WMF): [C: 032] Add style to new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [20:55:34] (03Merged) 10jenkins-bot: Add style to new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [20:56:38] (03PS3) 10Legoktm: Fix phpdoc comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88631 [20:57:18] (03PS1) 10Merlijn van Deen: DO NOT SUBMIT test commit [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/88633 [20:57:27] (03CR) 10EBernhardson (WMF): [C: 032] Fix phpdoc comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88631 (owner: 10Legoktm) [20:57:33] (03Merged) 10jenkins-bot: Fix phpdoc comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88631 (owner: 10Legoktm) [20:58:14] (03CR) 10Ori.livneh: [C: 04-1] "The approach you take with $wgServer in LocalSettingsGenerator.php should be the same that we take with other conditionally-included setti" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [20:58:39] (03PS1) 10Merlijn van Deen: DO NOT SUBMIT test commit [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/88634 [20:58:40] (03Abandoned) 10Merlijn van Deen: DO NOT SUBMIT test commit [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/88633 (owner: 10Merlijn van Deen) [20:59:30] (03PS1) 10Hashar: mwext-Translate-phpcs-strict{,-HEAD} are now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88635 [21:00:27] (03CR) 10Hashar: [C: 032] mwext-Translate-phpcs-strict{,-HEAD} are now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88635 (owner: 10Hashar) [21:00:35] (03Merged) 10jenkins-bot: mwext-Translate-phpcs-strict{,-HEAD} are now voting [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88635 (owner: 10Hashar) [21:00:40] (03CR) 10EBernhardson (WMF): [C: 032] Workaround for php+apc lambda issues [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88517 (owner: 10EBernhardson (WMF)) [21:00:45] (03Merged) 10jenkins-bot: Workaround for php+apc lambda issues [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88517 (owner: 10EBernhardson (WMF)) [21:00:48] (03PS1) 10Marco: Adding heading id for TranscodeStatusTable [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/88636 [21:04:09] Krinkle: $wgResourceLoaderLESSImportPaths [21:04:24] (03CR) 10Aaron Schulz: "It would be nice if the final file content generation could stay functional...but that's just me" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [21:05:38] AaronSchulz: what do you mean by 'functional'? [21:07:18] return "blah {$var} blah" vs $s = "stuff"; ... do stuff to $s ... return $s [21:07:44] of course it doesn't effect the result of anything [21:08:15] ah, so you mean you'd prefer the templates to remain logicless? [21:09:40] there are a few other conditional blocks that are handled in the same method [21:10:14] but they're handled at the top of the function and interpolated unconditionally [21:12:31] (03PS6) 10MarkTraceur: Put the username into the info list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 [21:12:53] (03PS3) 10Bsitu: Update style for editing a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88262 [21:13:30] (03CR) 10Matthias Mullie: [C: 032] Update style for editing a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88262 (owner: 10Bsitu) [21:13:39] (03Merged) 10jenkins-bot: Update style for editing a topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88262 (owner: 10Bsitu) [21:14:10] ori-l: well I wouldn't mind ternaries in there either ;) [21:14:28] (03PS1) 10EBernhardson (WMF): Use standard humanized timestamps for moderation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88637 [21:14:40] (03PS4) 10MarkTraceur: Add some siteinfo to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 [21:14:54] (03Abandoned) 10Merlijn van Deen: DO NOT SUBMIT test commit [test/mediawiki/extensions/examples] - 10https://gerrit.wikimedia.org/r/88634 (owner: 10Merlijn van Deen) [21:15:31] (03PS4) 10MarkTraceur: Quick refactor of the http logic in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/88625 [21:15:44] (03PS5) 10MarkTraceur: Add some siteinfo to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 [21:15:45] (03CR) 10Aaron Schulz: [C: 032] Quick refactor of the http logic in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/88625 (owner: 10MarkTraceur) [21:15:50] (03PS3) 10MarkTraceur: Recursive filerepoinfo [core] - 10https://gerrit.wikimedia.org/r/86393 [21:15:52] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88625 (owner: 10MarkTraceur) [21:16:03] Rebase aaalllll the things [21:16:10] Oh, sorry Aaron [21:16:16] AaronSchulz: I rebased it [21:16:21] Bad timing [21:16:23] Aaron|home: btw, remember when I proposed a using redis sets for membership tests for Bug54847.php? I thought about it later; it's not the right redis data type to have used. a single string key with SETBIT/GETBIT used to set/get membership status, with the bit offset being equal to the user id [21:17:02] (03PS4) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [21:18:54] <^d> brioonnnnnnnn [21:20:13] (03CR) 10Aaron Schulz: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88410 (owner: 10MarkTraceur) [21:20:20] come to candy mountain brioonnnnnnn [21:20:42] * Aaron|home wants to make a snowman [21:21:57] (03CR) 10Chad: "Man this is some olddddddd code. Thanks for cleaning it up :)" [core] - 10https://gerrit.wikimedia.org/r/88625 (owner: 10MarkTraceur) [21:22:38] (03Merged) 10jenkins-bot: Quick refactor of the http logic in ForeignAPIRepo [core] - 10https://gerrit.wikimedia.org/r/88625 (owner: 10MarkTraceur) [21:23:00] <3 ^d [21:23:16] ori-l: ganglia question for you (this is not currently on the cluster but hopefully will be soon) -- I'm feeding metrics to gmond and it seems to be picking them up -- if I want to plot the metrics in the web interface -- do I absolutely have to create a custom plot type? or is there something nicely generic I can use? [21:23:38] (and I'm asking you because you've clearly added eventlogging metrics somehow!) [21:23:48] (03PS6) 10MarkTraceur: Add some siteinfo to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 [21:23:56] AaronSchulz: {{done}} [21:25:16] (03CR) 10Aaron Schulz: [C: 032] Add some siteinfo to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 (owner: 10MarkTraceur) [21:25:18] $uri = ( $_SERVER['HTTPS'] ? 'https://' : 'http://' ) . [21:25:18] $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']; [21:25:22] (03CR) 10Mdale: [C: 032 V: 032] "Looks like a pretty safe change." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/88636 (owner: 10Marco) [21:25:25] It's always going to be HTTP when it hits apache, right? [21:25:44] (03PS1) 10EBernhardson (WMF): Hide who edited a post. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88640 [21:25:46] (03PS30) 10Trevor Parscal: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [21:26:27] (03CR) 10Aaron Schulz: [C: 032] Fix revision table cleanup on delete [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88632 (owner: 10Aaron Schulz) [21:27:45] Krinkle: I need to make a new extension repo in gerrit called VectorBeta [21:27:49] what should I do? [21:27:53] Panic. [21:27:55] ^d: ^^ [21:27:59] Bother Chad [21:28:01] Always the solution [21:28:02] Reedy: done [21:28:02] <^d> TrevorParscal: Put a request on mw.org, Christian or I will get on it. [21:28:06] keep calm and carry on [21:28:32] * TrevorParscal decides to just give up and push to github [21:28:38] lol [21:28:39] <^d> TrevorParscal: I can do it now :) [21:28:40] Keep calm and Gerrit on [21:28:45] <^d> I just want it on mw.org so there's a record. [21:28:52] (03CR) 10Matthias Mullie: [C: 032] Hide who edited a post. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88640 (owner: 10EBernhardson (WMF)) [21:29:01] https://www.mediawiki.org/wiki/Extension_requests? [21:29:15] <^d> Na, https://www.mediawiki.org/wiki/Gerrit/New_repositories#Step_3:_Request_space_for_your_extension [21:29:37] Jenkins y u no merge [21:30:27] (03Merged) 10jenkins-bot: Add some siteinfo to the repo info array [core] - 10https://gerrit.wikimedia.org/r/88410 (owner: 10MarkTraceur) [21:30:52] <^d> TrevorParscal: New empty repo "mediawiki/extensions/VectorBeta" created. [21:31:17] <^d> I imagine Reedy will add you a default .gitreview and .gitignore since I never do :p [21:31:31] I wonder if many repos are missing them... [21:31:37] (03CR) 10MarkTraceur: "Jenkins is drunk, forgot to submit it." [core] - 10https://gerrit.wikimedia.org/r/88410 (owner: 10MarkTraceur) [21:31:38] to the shells! [21:31:41] Oh [21:31:43] (03Merged) 10jenkins-bot: Hide who edited a post. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88640 (owner: 10EBernhardson (WMF)) [21:31:45] My comment was late! [21:32:24] ^d: I'm at the very end of an insanely long list https://www.mediawiki.org/wiki/Git/New_repositories/Requests [21:32:38] oh, you are ahead of me [21:33:15] Aw man, it's so cool to be able to run this extension on mediawiki/core/master [21:33:22] (03Merged) 10jenkins-bot: Fix revision table cleanup on delete [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88632 (owner: 10Aaron Schulz) [21:33:36] <^d> TrevorParscal: Yeah that big list format sucks. Ryan and I have wanted to come up with an app to automate this. [21:33:55] Extension:GerritRepoCreator [21:34:07] <^d> I started writing Extension:GerritTools but I abandoned it. [21:34:57] brion: There exist two more smallish JS reviews in MultimediaViewer, the second of which has some outstanding i18n feedback, but the first of which is baaasically ready to go [21:37:54] ok, trying to push a branch of my new repo into gerrit, it's saying something about needing a remote called gerrit [21:38:04] do I need to initialize the repo for use with gerrit? [21:38:44] copy in a .gitreview file [21:38:45] modify it [21:38:48] git review -s [21:38:51] git review [21:39:18] I was going to add one, but waiting for numerous repos to update takes a while [21:41:21] (03PS1) 10Trevor Parscal: Setup gerrit [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88642 [21:41:22] (03PS1) 10Trevor Parscal: Initial commit [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88643 [21:42:08] (03CR) 10Jdlrobson: [C: 032] Initial commit [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88643 (owner: 10Trevor Parscal) [21:42:21] (03PS1) 10Matthias Mullie: Improve button display in flyouts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88644 [21:42:24] (03CR) 10Jdlrobson: [C: 032] Setup gerrit [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88642 (owner: 10Trevor Parscal) [21:46:26] (03CR) 10Reedy: [C: 032 V: 032] "Jenkins won't merge this repo yet..." [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88642 (owner: 10Trevor Parscal) [21:46:50] (03CR) 10Jdlrobson: [V: 032] Initial commit [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88643 (owner: 10Trevor Parscal) [21:47:01] another vector extension? [21:47:24] Now with more radiation [21:48:04] <^d> Aaron|home: You know better, we don't do anything in core anymore ;-) [21:48:24] Krinkle: so, both the extension and the latest version of the patch are in [21:48:28] This is of course only the 2nd Vector extension [21:48:31] There will be a few more to come [21:48:40] <^d> VectorBase? [21:48:42] <^d> VectorLib? [21:48:44] <^d> :) [21:48:47] (03PS1) 10Krinkle: resourceloader: Rethrow LESS error and let makeModuleResponse handle it [core] - 10https://gerrit.wikimedia.org/r/88645 [21:48:57] Reedy: it's not a vector extension, it is simply a preference that swaps which vector skin module is used [21:49:03] the CSS is entirely in core [21:49:14] (03PS2) 10Krinkle: resourceloader: Rethrow LESS error and let makeModuleResponse handle it [core] - 10https://gerrit.wikimedia.org/r/88645 [21:49:23] ^d: Should've called it NotVectorBeta [21:49:31] and the preference depends on the BetaFeatures extension - did you want something in core depending on that extension? [21:50:01] <^d> Let's put everything in core :) [21:50:09] git status [21:50:12] I'm waiting for the one that includes a squid launcher. *oh yeah!* [21:50:40] ^d: sadly, there are some people who would say that without a :) at the end, but rather 3x ! [21:51:12] TrevorParscal: Checking [21:51:21] TrevorParscal: I guess this image should be in the extension then? Hot linking it from core seems fragile. [21:51:27] TrevorParscal: resources/mediawiki/images/typography-beta.svg [21:51:45] <^d> Ohhhhh, shameless self promotion. Raise your hand if you use vagrant. [21:54:33] (03CR) 10Krinkle: "(4 comments)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [21:54:47] (03PS1) 10Matthias Mullie: Get rid of images-NEXT; fix path to Echo icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88647 [21:54:50] (03PS31) 10Krinkle: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [21:56:06] (03PS32) 10Krinkle: Beta: Apply mobile typography lessons to Vector on desktop [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [21:56:40] (03CR) 10Bsitu: [C: 032] Get rid of images-NEXT; fix path to Echo icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88647 (owner: 10Matthias Mullie) [21:56:42] (03CR) 10Krinkle: [C: 04-1] Vector: New beta module with new typography styles [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [21:56:56] Krinkle: yes, that was an oversight - I will move that in a min (unless you want to :) ) [21:57:13] TrevorParscal: Easier for you as the VectorBeta change was already merged.. [21:57:13] (03Merged) 10jenkins-bot: Get rid of images-NEXT; fix path to Echo icon [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88647 (owner: 10Matthias Mullie) [21:58:14] (03Abandoned) 10Chad: Allow selection of MySQLi database type during installation [core] - 10https://gerrit.wikimedia.org/r/62174 (owner: 10Jakub Vrána) [22:00:58] (03PS3) 10Krinkle: resourceloader: Rethrow LESS error and let makeModuleResponse handle it [core] - 10https://gerrit.wikimedia.org/r/88645 [22:02:53] (03PS33) 10Jdlrobson: Vector: New beta module with new typography styles [core] - 10https://gerrit.wikimedia.org/r/79948 [22:03:00] ^ Krinkle TrevorParscal [22:03:06] (03PS4) 10Krinkle: resourceloader: Rethrow LESS error and let makeModuleResponse handle it [core] - 10https://gerrit.wikimedia.org/r/88645 [22:03:14] happy to rename to skins.vector.beta if preferred [22:03:31] jdlrobson: https://gerrit.wikimedia.org/r/#/c/79948/32..33//COMMIT_MSG [22:03:34] intentional? [22:03:47] nope :) [22:04:03] (03CR) 10Trevor Parscal: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:04:05] Krinkle: saw you changed commit after i altered patch set was so trying to honor your change :) [22:04:22] ok :) [22:04:36] (03CR) 10Bsitu: [C: 032] Improve button display in flyouts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88644 (owner: 10Matthias Mullie) [22:05:57] (03Merged) 10jenkins-bot: Improve button display in flyouts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88644 (owner: 10Matthias Mullie) [22:15:32] (03PS34) 10Jdlrobson: Vector: New beta module with new typography styles [core] - 10https://gerrit.wikimedia.org/r/79948 [22:15:38] ^ Krinkle fixed [22:16:29] (03PS1) 10Bsitu: Reply button is not parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88649 [22:16:37] (/ns id PASSWORD) [22:16:53] nevermind that. i am trying to do something I've never done before :) [22:17:43] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:18:16] (03CR) 10Krinkle: [C: 04-1] "(re-CR, svg file)" [core] - 10https://gerrit.wikimedia.org/r/79948 (owner: 10Jdlrobson) [22:18:58] Krinkle: what's up with the svg? [22:19:03] ask Trevor [22:19:33] (03PS5) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [22:19:38] got it [22:20:11] (03PS35) 10Jdlrobson: Vector: New beta module with new typography styles [core] - 10https://gerrit.wikimedia.org/r/79948 [22:20:50] Who needs designers [22:20:56] I can write my own bloody SVGs [22:22:25] Krinkle: i just need to grab a coffee. If you let me know what fix ups you want me to make to the core change if i do those can we look to merge this by tomorrow? [22:23:11] jdlrobson: relax! [22:23:24] no pointing guns at reviewers :P [22:24:24] (03PS2) 10EBernhardson (WMF): Change rev_comment to rev_change_type and adjust references to "comments" to instead refer to "change types". [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88398 (owner: 10Werdna) [22:24:27] (03CR) 10jenkins-bot: [V: 04-1] Change rev_comment to rev_change_type and adjust references to "comments" to instead refer to "change types". [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88398 (owner: 10Werdna) [22:24:40] jdlrobson: tomorrow, or today, sure :) [22:25:58] (03PS3) 10Krinkle: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 [22:26:14] (03PS4) 10Krinkle: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 [22:26:32] (03PS5) 10Krinkle: vector: Apply coding conventions to screen.less and minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88266 [22:28:17] (03PS1) 10PleaseStand: FormatJson: minor cleanup [core] - 10https://gerrit.wikimedia.org/r/88650 [22:28:18] (03PS1) 10PleaseStand: FormatJson: remove whitespace from empty arrays and objects [core] - 10https://gerrit.wikimedia.org/r/88651 [22:29:50] (03Abandoned) 10GWicke: Revert "(bug 41716) Add variant config to siprop=general" [core] - 10https://gerrit.wikimedia.org/r/50767 (owner: 10GWicke) [22:31:22] (03CR) 10Ori.livneh: "I need to review this carefully but I agree with the overall thrust of the patch. I wonder, though: you reference bug 55442 -- do we know " [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [22:31:57] (03CR) 10GWicke: "It is certainly more efficient to fix up our URL scheme than to patch up hrefs everywhere depending on the use case. The resource attribut" [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [22:36:33] ori-l: https://bugzilla.wikimedia.org/show_bug.cgi?id=48480 [22:36:40] ori-l: Slow progress. :-) [22:37:12] (03PS12) 10EBernhardson (WMF): Generate recentchanges rows from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 [22:37:35] Elsie: cool, thanks. Good to CC DarTar on these bugs [22:37:43] (03CR) 10EBernhardson (WMF): "PS12: rebase against master" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/81017 (owner: 10EBernhardson (WMF)) [22:37:50] (03CR) 10Krinkle: "This doesn't solve bug 55442 entirely, it addresses some part of it. Bug 55442 is solved when we change the typehint in the catch() of Res" [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [22:38:56] ori-l: That bug is actually moving forward without my consent... [22:39:07] I wrote it to investigate, but Nemo is apparently convinced the investigation is complete. [22:39:10] * Elsie shrugs. [22:39:20] I won't object to killing code. [22:43:56] yeah, it looks like it's fine [22:44:05] Nemo is right, I think [22:44:14] thanks for flagging it, Elsie [22:45:05] (03PS1) 10Mattflaschen: Improvements and fixes to OB6 test [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/88653 [22:45:06] (03CR) 10jenkins-bot: [V: 04-1] Improvements and fixes to OB6 test [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/88653 (owner: 10Mattflaschen) [22:46:41] Reedy: prod maintenance script questions for you; 1) better to run on terbium or tin [22:47:15] Reedy: 2) if patch was merged yesterday when will it be in the right place to run it? [22:47:33] I asked greg-g #2 and he punted to you [22:47:38] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/51675 (owner: 10Reedy) [22:48:21] Is the Jenkins "unable to be automatically merged" job broken again? [22:48:35] (03CR) 10PleaseStand: "Note that a faster alternative (by roughly 10-20% for typical input) would be to pretty-print the array/object the HHVM way, removing the " [core] - 10https://gerrit.wikimedia.org/r/88651 (owner: 10PleaseStand) [22:54:39] (03PS8) 10Chad: Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [22:55:10] (03CR) 10jenkins-bot: [V: 04-1] Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [22:55:16] (03CR) 10Mattflaschen: "recheck" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/88653 (owner: 10Mattflaschen) [22:55:32] (03CR) 10Chad: "(3 comments)" [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [22:56:34] (03CR) 10Swalling: [C: 031] "Control and test cases tried out on piramido in a variety of circumstances. Fixes such as the modal background dimming, vertical offset, a" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/88653 (owner: 10Mattflaschen) [23:05:24] ori-l: guns get +2s! ;-) [23:05:26] (03CR) 10Daniel Friesen: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [23:05:29] Hi helderwiki. [23:05:52] ori-l: I started a page: https://meta.wikimedia.org/wiki/Technical_debt [23:07:37] I think we still have less debt than the US government! [23:08:32] :-) [23:09:59] Elsie: that page is going to get big ;-) [23:11:10] I hope so! [23:11:17] I think it's mostly going to be an index of bugs. [23:14:06] (03PS6) 10MarkTraceur: Add remote image repository information to list [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/88318 [23:16:02] (03PS1) 10Jdlrobson: Add logo to Beta Features page [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88657 [23:16:04] (03CR) 10Matthias Mullie: [C: 032] Reply button is not parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88649 (owner: 10Bsitu) [23:16:08] (03Merged) 10jenkins-bot: Reply button is not parsed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88649 (owner: 10Bsitu) [23:16:18] (03PS1) 10Reedy: Add .gitreview and .gitignore [extensions/DataValueImplementations] - 10https://gerrit.wikimedia.org/r/88658 [23:16:39] (03CR) 10Mattflaschen: [C: 032] "Self-merging: CSS fixes and minor JS flow changes for the overlay" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/88653 (owner: 10Mattflaschen) [23:16:45] (03Merged) 10jenkins-bot: Improvements and fixes to OB6 test [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/88653 (owner: 10Mattflaschen) [23:19:08] (03PS1) 10Jdlrobson: Rename vector module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88661 [23:19:23] (03CR) 10Jdlrobson: [C: 032] Rename vector module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88661 (owner: 10Jdlrobson) [23:19:31] (03CR) 10Jdlrobson: [V: 032] Rename vector module [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88661 (owner: 10Jdlrobson) [23:20:24] (03CR) 10Jdlrobson: [C: 032 V: 032] Add logo to Beta Features page [extensions/VectorBeta] - 10https://gerrit.wikimedia.org/r/88657 (owner: 10Jdlrobson) [23:20:58] (03CR) 10Ori.livneh: [C: 04-1] "If the catch in makeModuleResponse should catch any error whatever, then it should not have its type hint changed. Instead it should call " [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [23:22:03] (03PS36) 10Jdlrobson: Vector: New beta module with new typography styles [core] - 10https://gerrit.wikimedia.org/r/79948 [23:23:18] Elsie: I'm skeptical that technical debt could be represented in summary form like that. It's easy enough to itemize things like 'drop this table which we are no longer using', but that's just one form of technical debt, and a fairly mild one at that. Other ones are much fuzzier. [23:23:59] (03PS1) 10EBernhardson (WMF): Icon hovers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88663 [23:24:47] (03PS1) 10Mattflaschen: Bump GettingStarted for A/B test fixes [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88664 [23:24:58] (03PS1) 10Mattflaschen: Bump GettingStarted for A/B test fixes [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88665 [23:25:35] (03CR) 10Mattflaschen: [C: 032 V: 032] "A/B test bump" [core] (wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88664 (owner: 10Mattflaschen) [23:25:45] (03CR) 10Mattflaschen: "A/B test bump" [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88665 (owner: 10Mattflaschen) [23:25:48] (03CR) 10Spage: "(3 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/88653 (owner: 10Mattflaschen) [23:25:58] (03CR) 10Mattflaschen: [C: 032 V: 032] Bump GettingStarted for A/B test fixes [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88665 (owner: 10Mattflaschen) [23:26:42] (03CR) 10Ori.livneh: "> I actually wonder whether the creator of that bug hit a Less exception, because those are caught and not rethrown (both before and after" [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [23:27:58] (03PS9) 10Chad: Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [23:29:30] (03PS1) 10Aaron Schulz: Fix revision table cleanup on delete [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88667 [23:29:42] (03CR) 10Aaron Schulz: [C: 032] Fix revision table cleanup on delete [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88667 (owner: 10Aaron Schulz) [23:30:07] (03CR) 10Krinkle: "I'm re-throwing it as MWException because makeModuleResponse breaks right now if you give it any other. And though the bug suggests otherw" [core] - 10https://gerrit.wikimedia.org/r/88645 (owner: 10Krinkle) [23:30:35] (03PS2) 10EBernhardson (WMF): Rename summaries to headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88407 (owner: 10Werdna) [23:30:49] (03PS10) 10Chad: Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [23:31:20] (03CR) 10EBernhardson (WMF): [C: 032] Rename summaries to headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88407 (owner: 10Werdna) [23:31:22] (03CR) 10jenkins-bot: [V: 04-1] Add support for mysqli extension [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [23:32:41] Krinkle: to clarify, re: https://gerrit.wikimedia.org/r/#/c/88645/ , I think you are correct that compileLESSFile should allow exceptions to bubble up to makeModuleResponse; that is a good insight and I am in favor of merging that. I disagree that it should be rethrowing the exception as an MWException; you should simply update the patch to include a change to makeModuleResponse to make it check method_exists before calling logExcept [23:32:41] ion. [23:32:46] (03PS1) 10Legoktm: [WIP] Enable backend support for sending cross-wiki notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88668 [23:32:51] (03CR) 10Chad: "So, I redid this based on Tim's suggestions to change the behavior of factory() (rather than adding a new $wgDBtype)." [core] - 10https://gerrit.wikimedia.org/r/62173 (owner: 10Jakub Vrána) [23:34:23] (03CR) 10jenkins-bot: [V: 04-1] Fix revision table cleanup on delete [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88667 (owner: 10Aaron Schulz) [23:34:26] Krinkle: I don't support changing the type hint in makeModuleResponse to MWException because I don't see a reason why it should catch errors from database code unrelated to RL but not from lessphp [23:34:30] (03CR) 10jenkins-bot: [V: 04-1] Rename summaries to headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88407 (owner: 10Werdna) [23:34:39] ori-l: yeah, I agree it should handle all exceptions. [23:34:51] we can't realistically catch everything at a lower level. [23:35:14] this is the lower lowel, low enough anyway [23:35:21] (03CR) 10jenkins-bot: [V: 04-1] Rename summaries to headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/88407 (owner: 10Werdna) [23:35:23] level* [23:35:35] yep. [23:35:50] (03Abandoned) 10Aaron Schulz: Update thumb.php to handle "langXX"-type thumbnail names [core] - 10https://gerrit.wikimedia.org/r/69019 (owner: 10Jarry1250) [23:36:49] ori-l: though, there's quite a lot of usage of logException in rl.php. And there is no clear sign that this one is any more stable than the others. [23:36:55] (03CR) 10Aaron Schulz: [V: 032] Fix revision table cleanup on delete [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88667 (owner: 10Aaron Schulz) [23:40:23] (03PS1) 10Huji: (bug 55486) Add .gitignore to the /skins directory to make it easier to work on extensions [core] - 10https://gerrit.wikimedia.org/r/88669 [23:42:55] Krinkle: strangely enough although there is a lot of usage of logException in ResourceLoader.php, it looks it's the *only place in all of MediaWiki* where MWException::logException is used [23:43:17] it should be made a method of ResourceLoader.php, perhaps, or a standalone function [23:43:36] ori-l: I'm ahead :) [23:43:52] I'm moving it into a static method of ResourceLoader, though considering to move it to a static method of MWException [23:43:54] what do you think ? [23:43:58] (03PS1) 10Huji: (bug 55486) Add .gitignore to the /skins directory to make it easier to work on extensions [core] - 10https://gerrit.wikimedia.org/r/88670 [23:44:24] hmmmmmmmm. [23:48:15] (03PS1) 10Aaron Schulz: Fix revision table cleanup on delete [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88671 [23:48:42] Krinkle: I have an idea I want to check, hang on [23:49:07] (03PS2) 10Aaron Schulz: Fix revision table cleanup on delete [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88671 [23:49:58] (03CR) 10CSteipp: [C: 031] "I think this should be merged, unless anyone has a good reason for it not to be," [core] - 10https://gerrit.wikimedia.org/r/88533 (owner: 10BryanDavis) [23:50:44] (03Abandoned) 10Aaron Schulz: Fix revision table cleanup on delete [core] (refs/wmf/1.22wmf19) - 10https://gerrit.wikimedia.org/r/88671 (owner: 10Aaron Schulz) [23:51:29] csteipp: \o/ my first security review passed with flying colors [23:53:12] Krinkle: I think static method of ResourceLoader is right [23:53:59] ori-l: logException also uses MWException#getLogMessage [23:54:16] I was hoping to make it work for non MWException (instead of the method not logging those) [23:54:30] AaronSchulz: have you had any thoughts on how WikiPage::getContent() might have returned null? [23:54:52] ori-l: looks like getLogId is then called from there, which is also custom. [23:55:18] <^d> You know, the more I think about this mysql/mysqli thing I'm thinking we should just drop mysql support. [23:55:26] <^d> mysqli's been enabled by default since 5.3.0 [23:55:27] TimStarling: not really, though there was some exception in flaggedrevs where revision->getContent() is null (and the revision did not look deleted) [23:56:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=55471 [23:56:28] may not be related, but it's annoying [23:56:31] <^d> And it works in hhvm [23:56:42] TimStarling: more annoying is that cherry-pick to wmf19 does not work [23:58:31] dewiki seems to be the most severely affected wiki [23:58:34] <^d> Or not, dangit. [23:59:42] getSha1() is empty