[00:01:26] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87929 (owner: 10L10n-bot) [00:03:06] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87932 (owner: 10L10n-bot) [00:03:27] (03PS5) 10Krinkle: Exception: Clean up html document for error pages [core] - 10https://gerrit.wikimedia.org/r/84991 [00:05:56] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87938 (owner: 10L10n-bot) [00:06:43] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/87939 (owner: 10L10n-bot) [00:06:58] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/ReaderFeedback] - 10https://gerrit.wikimedia.org/r/87941 (owner: 10L10n-bot) [00:07:08] (03CR) 10Legoktm: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [00:07:31] (03Abandoned) 10Siebrand: Localisation updates from http://translatewiki.net. [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/87942 (owner: 10L10n-bot) [00:10:47] siebrand: What's up? [00:11:29] (03CR) 10jenkins-bot: [V: 04-1] Localisation updates from http://translatewiki.net. [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/87950 (owner: 10L10n-bot) [00:12:14] Elsie: the sky? [00:12:47] p858snake|l_: I was asking about the abandonments. [00:13:29] (03Merged) 10jenkins-bot: Localisation updates from http://translatewiki.net. [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/87950 (owner: 10L10n-bot) [00:13:51] (03PS1) 10Siebrand: Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87953 [00:13:57] (03CR) 10Siebrand: [C: 032] Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87953 (owner: 10Siebrand) [00:14:00] (03Merged) 10jenkins-bot: Revert "Localisation updates from http://translatewiki.net." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/87953 (owner: 10Siebrand) [00:47:22] (03CR) 10Brian Wolff: "If this was such an asap issue, it would have been nice if it was mentioned three months ago when this change was made..." [core] - 10https://gerrit.wikimedia.org/r/67885 (owner: 10Brian Wolff) [01:00:07] (03CR) 10Siebrand: [C: 031] "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87613 (owner: 10Legoktm) [02:04:45] (03PS1) 10Luis Felipe Schenone: Uploading updated and improved version of the GoogleDocViewer extension [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/87985 [02:05:56] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Uploading updated and improved files [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/87914 (owner: 10Luis Felipe Schenone) [02:09:21] (03CR) 10Isarra: "LESS shouldn't be a problem if there's some affirmation that it'd be likely to get merged at all." [core] - 10https://gerrit.wikimedia.org/r/50594 (owner: 10Isarra) [02:11:27] (03PS1) 10Rfaulk: add - logging for revert. [sartoris] - 10https://gerrit.wikimedia.org/r/87986 [02:11:28] (03PS1) 10Rfaulk: add/mod - _dulwich_get_tags method / utilize get tags in revert, add syncing. [sartoris] - 10https://gerrit.wikimedia.org/r/87987 [02:11:29] (03PS1) 10Rfaulk: add - allow auto-syncing on revert. [sartoris] - 10https://gerrit.wikimedia.org/r/87988 [02:11:52] (03CR) 10Rfaulk: [C: 032 V: 032] add - logging for revert. [sartoris] - 10https://gerrit.wikimedia.org/r/87986 (owner: 10Rfaulk) [02:12:04] (03CR) 10Rfaulk: [C: 032 V: 032] add/mod - _dulwich_get_tags method / utilize get tags in revert, add syncing. [sartoris] - 10https://gerrit.wikimedia.org/r/87987 (owner: 10Rfaulk) [02:12:18] (03CR) 10Rfaulk: [C: 032 V: 032] add - allow auto-syncing on revert. [sartoris] - 10https://gerrit.wikimedia.org/r/87988 (owner: 10Rfaulk) [02:24:03] (03CR) 10Luis Felipe Schenone: [C: 032 V: 032] Uploading updated and improved version of the MpDisqus extension [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/87919 (owner: 10Luis Felipe Schenone) [02:36:20] (03CR) 10Parent5446: [C: 031] Fix ordering of db updates and syntax errors. [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/87704 (owner: 10Mattflaschen) [02:37:11] (03PS1) 10Rfaulk: fix - show_tag. [sartoris] - 10https://gerrit.wikimedia.org/r/87989 [02:37:12] (03PS1) 10Rfaulk: mod - log_deploys, use _dulwich_get_tags, rework logic. [sartoris] - 10https://gerrit.wikimedia.org/r/87990 [02:37:13] (03PS1) 10Rfaulk: mod - mask unused 'args'. [sartoris] - 10https://gerrit.wikimedia.org/r/87991 [02:37:26] (03CR) 10Rfaulk: [C: 032 V: 032] fix - show_tag. [sartoris] - 10https://gerrit.wikimedia.org/r/87989 (owner: 10Rfaulk) [02:37:40] (03CR) 10Rfaulk: [C: 032 V: 032] mod - log_deploys, use _dulwich_get_tags, rework logic. [sartoris] - 10https://gerrit.wikimedia.org/r/87990 (owner: 10Rfaulk) [02:37:50] (03CR) 10Rfaulk: [C: 032 V: 032] mod - mask unused 'args'. [sartoris] - 10https://gerrit.wikimedia.org/r/87991 (owner: 10Rfaulk) [02:38:24] Whoa [02:44:29] (03PS1) 10Legoktm: Script to audit page table [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87992 [02:44:40] Isarra: ^ [02:45:40] What'd you commit that for? >.> [02:45:45] Although... [02:45:53] Dammit, why must you be so smart? [02:45:57] Does it actually work? [02:46:20] Can you run it? [02:46:25] legoktm: ^ [02:46:31] yeah [02:46:39] just look at it first to make sure nothing looks horribly wrong? [02:46:59] Gerrit looks horribly wrong. Sometimes it's hard to tell after that. [02:47:03] :) [02:47:23] https://dpaste.de/gmtf/raw/ if you dont want to use gerrit [02:47:42] $this->insertRows( $stuff ); [02:47:44] > $this->output( "Processed $pageCount users.\n" ); <-- lol [02:47:45] Whassat? [02:47:46] yeah [02:47:49] i just copied an existing one [02:47:51] oops [02:48:27] (03PS2) 10Legoktm: Script to audit page table [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87992 [02:50:00] legoktm: Doesn't look like it'll explode, at least. Need to run it to see what actually does happen. [02:50:05] $this->output( "Processed $pageCount users.\n" ); [02:50:07] Also what? [02:50:10] yeah, just fixed that [02:50:19] i copied the user_groups one and started modifying stuff [02:51:05] Ah. [03:04:16] (03PS3) 10Legoktm: Script to audit page table [tools/grabbers] - 10https://gerrit.wikimedia.org/r/87992 [03:04:53] (03PS1) 10Gnosygnu: v0.10.0.0 [xowa] - 10https://gerrit.wikimedia.org/r/87994 [03:06:11] (03CR) 10Gnosygnu: [C: 032 V: 032] "approving own commit" [xowa] - 10https://gerrit.wikimedia.org/r/87994 (owner: 10Gnosygnu) [03:27:46] (03PS1) 10Legoktm: Use PageContentSaveComplete hook [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87995 [03:29:10] Elsie: ^ [03:31:46] $wgAutoloadClasses['Drafts'] = $dir . 'Drafts.classes.php'; [03:31:46] $wgAutoloadClasses['Draft'] = $dir . 'Drafts.classes.php'; [03:31:52] whaa >.> [03:32:17] oh [03:32:22] two classes in one file :/ [03:32:57] im not sure why that class is abstract [03:38:01] (03PS1) 10Legoktm: Fix wfMsg* calls to use wfMessage [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87996 [03:40:55] legoktm: Nice. [03:50:31] Elsie: Umm, when was the last time anyone tested this extension? [03:50:34] I'm not sure it even works. [03:51:08] legoktm: It's possible it's broken. [03:51:54] so when i hit "Save draft" it just saves the page [03:52:26] It may not be aware of ContentHandler or something like that. [03:52:59] I'll do some more debugging in a bit, filing a bug right now [03:55:05] legoktm: Cool, feel free to cc me on any Drafts bugs or Gerrit changes. [03:57:18] Hm [03:57:23] Was action=ajax killed yet? [03:57:39] (03PS1) 10Rfaulk: fix - _dulwich_get_tags returns OrderedDict, log_deploys logic. [sartoris] - 10https://gerrit.wikimedia.org/r/87997 [03:58:06] (03CR) 10Rfaulk: [C: 032 V: 032] fix - _dulwich_get_tags returns OrderedDict, log_deploys logic. [sartoris] - 10https://gerrit.wikimedia.org/r/87997 (owner: 10Rfaulk) [03:58:39] nope [03:58:42] https://bugzilla.wikimedia.org/show_bug.cgi?id=53119 [04:09:18] (03PS1) 10Legoktm: Fix some phpdoc comments [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87998 [04:15:50] (03CR) 10Legoktm: "Would you be willing to restore this? I started work at https://gerrit.wikimedia.org/r/#/c/87996/ and https://gerrit.wikimedia.org/r/#/c/8" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [04:27:21] (03PS1) 10Hiong3-eng5: found \r bug in formatting [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/87999 [05:05:12] (03CR) 10Legoktm: "(1 comment)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [05:52:24] (03PS1) 10Legoktm: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 [05:52:27] (03CR) 10jenkins-bot: [V: 04-1] Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [05:52:36] YuviPanda: ^ [05:52:49] mmm! [05:53:15] legoktm: nested quotes fail [05:53:23] yeah, just realized [05:54:05] (03PS2) 10Legoktm: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 [05:54:07] (03CR) 10jenkins-bot: [V: 04-1] Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [05:54:53] heh [05:54:55] (03PS3) 10Legoktm: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 [05:55:06] woot. [05:56:59] (03CR) 10Yuvipanda: "(2 comments)" [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [05:57:10] legoktm: fix thsoe, and I'll test and merge [05:58:46] YuviPanda: what's dictionary syntax? [05:58:56] (03CR) 10Legoktm: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [05:59:13] oh i see [05:59:14] legoktm: look at role::multimedia [05:59:18] yeah just found it [05:59:51] switching networks brb [06:00:47] (03PS4) 10Legoktm: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 [06:01:43] ok,testing [06:02:44] (03CR) 10Nikerabbit: "(2 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87996 (owner: 10Legoktm) [06:03:41] legoktm: you're making antispoof depend on itself [06:03:58] Nikerabbit: would you mind un-abandoning https://gerrit.wikimedia.org/r/#/c/29749/ ? it would be easier to just work off of everything siebrand has already done [06:04:02] YuviPanda: Oh. [06:04:04] YuviPanda: heh. [06:04:09] legoktm: that was my comment about not needed :P [06:04:12] lol [06:04:37] legoktm: doesn't even run, because of cycle :) [06:04:50] (03PS5) 10Legoktm: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 [06:04:56] is that better^ ? [06:04:59] cecking [06:05:32] legoktm: no, you're 'require'ing it without declaring it :) [06:05:39] blegh [06:05:43] can you just fix it? :P [06:05:54] pfft [06:05:56] kk [06:06:08] ohhhh [06:06:09] wait [06:06:10] i see [06:06:13] i know what to do [06:06:18] i got this [06:06:38] ok! :D [06:06:58] (03PS6) 10Legoktm: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 [06:07:00] (03CR) 10jenkins-bot: [V: 04-1] Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [06:07:03] aksdjhfskdjfh [06:07:52] (03PS7) 10Legoktm: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 [06:08:09] YuviPanda: ^ [06:08:14] checking [06:08:32] legoktm: testing them with vagrant provision locally will help catch those -1's, y'know :P [06:08:36] okay [06:08:37] :P [06:08:59] (03PS1) 10Yuvipanda: Remove CodeEditor from UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/88002 [06:09:38] YuviPanda: wfm locally [06:09:42] yeah, testing now [06:12:34] (03CR) 10Yuvipanda: [C: 032] "WFM!" [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [06:12:37] :D [06:12:37] (03Merged) 10jenkins-bot: Add AntiSpam role [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [06:12:56] for the redis job queue, how would i add a crontab entry? [06:13:08] (03PS2) 10Yuvipanda: Remove CodeEditor from UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/88002 [06:13:20] legoktm: good question. [06:13:33] legoktm: I think you should add a 'cron' module [06:13:38] that lets roles define crontab entries [06:13:47] how would that work? [06:13:54] moment [06:14:09] legoktm: look at modules/apache [06:14:13] okay [06:14:17] adding a massmessage role first [06:14:23] hah, ok [06:21:02] (03PS1) 10Legoktm: Add MassMessage role [vagrant] - 10https://gerrit.wikimedia.org/r/88003 [06:21:24] YuviPanda: ^ [06:21:44] (03PS3) 10Yuvipanda: Remove CodeEditor from UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/88002 [06:22:33] YuviPanda: for that, why don't you define a CodeEditor role, and then include that in scribunto/uploadwizard? [06:22:56] legoktm: so that's this big thing that's been going around. ori-l doesn't want a proliferation of roles coming through everywhere... [06:23:23] it's a fix just for now [06:23:40] oh :/ [06:23:42] hm [06:27:09] fucking powercuts [06:27:12] 3rd this morning [06:27:14] * YuviPanda stabs everyone [06:28:23] ow [06:29:47] YuviNoPower: can we just use something like https://github.com/torrancew/puppet-cron ? [06:30:25] legoktm: go for it. use a submodule. [06:30:44] you seem to keep forgetting i don't know how puppet works! [06:30:46] legoktm: there have been no resusing other puppet modules yet, but I think that's a bad thing. [06:30:49] hah [06:31:12] legoktm: have you used git submodules before? [06:31:20] yes :P [06:31:37] legoktm: so just addhttps://github.com/torrancew/puppet-cron.git as a submodule into puppet/modules in the vagrant repo [06:31:42] so you'll get puppet/modules/cron [06:31:45] right [06:31:46] once you do that [06:31:48] just figured that out [06:31:51] :) [06:31:55] can i just do include cron after that? [06:32:04] legoktm: you are not able to restore it? [06:32:12] Nikerabbit: no, I don't have +2 [06:32:21] (03Restored) 10Nikerabbit: Maintenance for Drafts extension [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [06:32:28] thanks [06:32:46] i'm going to have fun rebasing that >.> [06:32:59] legoktm: yeah, you can just do cron:: after that [06:33:08] legoktm: the readme has examples [06:35:22] YuviNoPower: ok, so how do i set a $wg global? [06:35:33] did I miss anything? [06:35:37] [11:35:22 PM] YuviNoPower: ok, so how do i set a $wg global? [06:35:44] all of the role examples depend on an extension [06:36:01] legoktm: see role::multimedia, 'thumb.php on 404' [06:36:15] mediawiki::settings [06:36:19] ah [06:36:21] thanks [06:37:59] YuviPanda: so is there an elegant way to write https://dpaste.de/PXuy/raw/ ? or do i have to oneliner it? [06:38:10] looking [06:38:22] legoktm: try it out? :D [06:38:41] I remember vaguely sending a patch to make these things possible... a long time ago. [06:38:46] heh [06:39:25] can I assume redis is already set up and running? [06:39:33] legoktm: yah [06:39:34] you can [06:44:53] YuviPanda: ok, so i'm still not sure how i would add the nested arrays as settings. [06:45:08] legoktm: meh, one liner it for now then. [06:46:09] (03PS1) 10Rfaulk: add - method _get_deploy_tags, utilize in diff & log_deploys. [sartoris] - 10https://gerrit.wikimedia.org/r/88004 [06:46:29] (03CR) 10Rfaulk: [C: 032 V: 032] add - method _get_deploy_tags, utilize in diff & log_deploys. [sartoris] - 10https://gerrit.wikimedia.org/r/88004 (owner: 10Rfaulk) [06:48:03] (03PS1) 10Legoktm: Add puppet-cron submodule [vagrant] - 10https://gerrit.wikimedia.org/r/88005 [06:48:04] (03PS1) 10Legoktm: Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 [06:48:08] (03CR) 10jenkins-bot: [V: 04-1] Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [06:49:00] legoktm: test locally to avoid jenkins-bot :P [06:49:18] meh [06:49:22] i use it as my linter :P [06:49:29] booorrring :P [06:49:37] (03PS2) 10Legoktm: Add redisjobqueue role [vagrant] - 10https://gerrit.wikimedia.org/r/88006 [06:49:44] woot. [06:49:50] now lets find out if that actually works. [06:50:28] heh :D [06:51:07] legoktm: heh, I guess that feels weird to me since it takes about 15s for me to push to gerrit. Guess it's faster for you :D [06:51:52] oh, it takes like 2 seconds for me [06:52:07] root@mediawiki-vagrant:/home/vagrant# crontab -l [06:52:07] no crontab for root [06:52:08] hm [06:52:22] root@mediawiki-vagrant:/etc/cron.d# ls [06:52:22] php5 runJobs [06:52:24] oh sweet [06:52:50] let me just spam the job queue [06:58:06] (03CR) 10Legoktm: [C: 04-1] "Fatal error: Unsupported operand types in /vagrant/mediawiki/includes/job/JobQueueGroup.php on line 92" [vagrant] - 10https://gerrit.wikimedia.org/r/88006 (owner: 10Legoktm) [07:14:24] (03PS2) 10Legoktm: Maintenance for Drafts extension [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [07:14:45] (03CR) 10Legoktm: "PS2 is a manual rebase" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [07:15:35] (03PS3) 10Legoktm: Maintenance for Drafts extension [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [07:16:11] (03Abandoned) 10Legoktm: Fix wfMsg* calls to use wfMessage [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87996 (owner: 10Legoktm) [07:16:20] (03Abandoned) 10Legoktm: Fix some phpdoc comments [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/87998 (owner: 10Legoktm) [07:18:30] (03PS4) 10Legoktm: Maintenance for Drafts extension [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [07:40:25] hello [07:40:57] morning hashar [07:43:28] ori-l: hey :-D [07:43:40] ori-l: can you confirm whether statsd is enabled on tungsten ? [07:43:47] I think I noticed a merge by Faidon on friday [07:44:06] yes, it's enabled [07:44:40] \O/ [07:44:44] thankkkk youuu [07:46:00] np! faidon and rob did most of the work [07:46:05] (03CR) 10Yuvipanda: [C: 032] Remove CodeEditor from UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/88002 (owner: 10Yuvipanda) [07:46:09] self merging still feels weird [07:46:10] (03Merged) 10jenkins-bot: Remove CodeEditor from UploadWizard [vagrant] - 10https://gerrit.wikimedia.org/r/88002 (owner: 10Yuvipanda) [07:50:15] (03PS1) 10Ebrahim: Native digits on 'mw-fr-revisiontag-edit' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/88008 [07:56:52] ori-l: hmm, is there a proper way to make puppet run 'only once!' tasks? [07:57:03] ori-l: specifically, I want to run 'labs-vagrant provision' the first time that role is added [07:57:19] hmm, I could do an 'unless' check for /vagrant/mediawiki, I suppose [07:58:27] YuviPanda: there is "refreshonly" http://docs.puppetlabs.com/guides/techniques.html#how-do-i-run-a-command-whenever-a-file-changes [07:58:35] not sure whether it applies to your use case though [07:58:39] * YuviPanda looks [08:03:20] (03CR) 10Rjain: [V: 031] "Fixes the issue." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/87704 (owner: 10Mattflaschen) [08:10:50] anyone know how i can get specific ci jobs to run on an extension i'm working on? [08:22:24] dan-nl: hashar is the one you're looking for [08:22:37] dan-nl: yeah that is mostly me [08:23:03] YuviPanda: hashar: cool, thanks [08:30:26] Krinkle|detached: thanks a lot for your help with debugging why git-review is broken on my machine, uninstalling it and then installing it again fixed the problem [08:35:13] hashar: also, is there a way i can get those ci jobs into a local version of jenkins i have? [08:36:20] dan-nl: Merjin from pywikibot has a vagrant machine that let one clone our installation (Jenkins + Gerrit + Zuul) [08:36:49] dan-nl: what we do is that the jobs are defined in a YAML file which is proceeded by a python script named Jenkins Job Builder [08:37:03] dan-nl: you can install that script on your local machine and configure it to update your local Jenkins installation [08:37:20] !jjb [08:37:25] !jjb is https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder [08:37:25] Key was added [08:37:29] !jjb | dan-nl [08:37:29] dan-nl: https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder [08:37:37] hashar: thanks [08:38:07] dan-nl: the configuration is really meant to be used on the WMF Jenkins server though [08:38:17] dan-nl: it references hard paths which only exists on our servers. [08:38:36] dan-nl: what job do you want added? [08:39:03] hashar: looking [08:43:19] i'm looking at this gerrit change https://gerrit.wikimedia.org/r/#/c/87607/ and all of the ci jobs in there [08:53:05] (03Abandoned) 10Hoo man: Accessibility: Make the collapsible sidebar screen reader friendly [extensions/Vector] - 10https://gerrit.wikimedia.org/r/80927 (owner: 10Hoo man) [08:54:00] thedj: https://gerrit.wikimedia.org/r/82122 Do you have any opinion regarding my comment there? [08:54:30] dan-nl: sorry was reviewing some stuff [08:54:48] dan-nl: want me to explain each of the jobs being shown at https://gerrit.wikimedia.org/r/#/c/87607/ ? [08:55:42] hashar: np, no, need to describe them all and i see that some i actually don't need, such as sqlite [08:56:33] hashar: what i'd like to know is if the phpcs-lenient and phpcs-strict will be added at some point to https://gerrit.wikimedia.org/r/#/c/83657/ [08:57:57] hashar: one thing i don't understand is how or when these ci jobs are added to a gerrit change set. in the two i've shown only two ci jobs were added to 83657, while several were added to 87607, how is that determined or setup? [08:58:25] dan-nl: the phpcs lenient/strict checks are merely experimental. They are only enabled on mediawiki/core and mediawiki/extensions/Translate [08:58:30] I need to eventually generalize them [08:58:51] dan-nl: we also have a concept of whitelist [08:59:05] dan-nl: the tests executes whatever code is submitted by the author [08:59:26] dan-nl: whenever someone is untrusted, we only run the linting jobs which are safe [08:59:45] dan-nl: also, the jobs have to be configured for each repository. GWToolset most probably does not have unit testing enabled. [09:00:09] hashar: not yet in the extension, i'm about to add it [09:00:10] (03PS1) 10Siebrand: Set 'tooltip-iwiki' as optional [core] - 10https://gerrit.wikimedia.org/r/88011 [09:00:18] ah it is enabled [09:00:23] I guess you are not allowed :D [09:00:43] hashar: :) [09:01:08] (03PS2) 10Siebrand: Set 'tooltip-iwiki' as optional [core] - 10https://gerrit.wikimedia.org/r/88011 [09:01:21] hashar: so the ci jobs get added automatically depending on the code submitted and the whitelist which helps determine which ci jobs are added? [09:02:02] (03PS1) 10Hashar: whitelist dan-nl [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88012 [09:02:04] dan-nl: exactly [09:02:10] and this change 88012 will enable tests for you [09:02:22] hashar: thanks :) [09:02:54] eventually we will run tests for anyone [09:03:06] whenever I manage to get the tests to run in disposable virtual instances [09:03:23] (03CR) 10Hashar: [C: 032] whitelist dan-nl [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88012 (owner: 10Hashar) [09:03:32] (03Merged) 10jenkins-bot: whitelist dan-nl [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88012 (owner: 10Hashar) [09:05:26] hashar: thanks again [09:05:32] dan-nl: Zuul is reloading still [09:05:44] whenever that is done, you will get test running whenever you amend/submit a patchset [09:08:06] (03PS1) 10Siebrand: Add GENDER support for 'thanks-button-thank' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88013 [09:11:22] dan-nl: zuul reloaded :-] [09:22:57] (03PS3) 10Santhosh: Set 'tooltip-iwiki' as optional [core] - 10https://gerrit.wikimedia.org/r/88011 (owner: 10Siebrand) [09:23:28] (03CR) 10Santhosh: [C: 032] Set 'tooltip-iwiki' as optional [core] - 10https://gerrit.wikimedia.org/r/88011 (owner: 10Siebrand) [09:26:08] (03PS2) 10Santhosh: Add GENDER support for 'thanks-button-thank' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88013 (owner: 10Siebrand) [09:28:29] (03Merged) 10jenkins-bot: Set 'tooltip-iwiki' as optional [core] - 10https://gerrit.wikimedia.org/r/88011 (owner: 10Siebrand) [09:29:25] (03CR) 10Santhosh: [C: 032] Add GENDER support for 'thanks-button-thank' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88013 (owner: 10Siebrand) [09:29:35] (03Merged) 10jenkins-bot: Add GENDER support for 'thanks-button-thank' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88013 (owner: 10Siebrand) [09:33:33] (03PS1) 10Siebrand: Document class property and break long lines [core] - 10https://gerrit.wikimedia.org/r/88024 [09:35:18] (03PS2) 10Siebrand: Document class property and break long lines [core] - 10https://gerrit.wikimedia.org/r/88024 [09:59:01] (03PS1) 10Nemo bis: Make thanks-confirmation more neutral dropping "Are you sure" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88032 [10:02:19] (03PS1) 10Hoo man: Accessibility: Make the collapsible sidebar screen reader friendly [core] - 10https://gerrit.wikimedia.org/r/88033 [10:04:26] (03CR) 10Hoo man: "Moved to core from https://gerrit.wikimedia.org/r/80927 after the collapsible sidebar has been moved to core." [core] - 10https://gerrit.wikimedia.org/r/88033 (owner: 10Hoo man) [10:45:26] (03PS10) 10Nemo bis: Add GENDER support to pagetriage-byline and friend [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/77898 [10:46:22] (03PS1) 10Ebrahim: Native digits on 'mw-echo-overlay-title-text' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88045 [10:58:56] (03CR) 10Dzahn: [C: 032 V: 032] Misc. CSS typo fixes; Firefox compatibility fixes [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86884 (owner: 10Aklapper) [10:59:31] mutante: :) [10:59:36] (03CR) 10Dzahn: [C: 032 V: 032] Remove custom CSS for duplicates.cgi [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/87057 (owner: 10Aklapper) [11:04:15] (03CR) 10Physikerwelt: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [11:04:18] (03CR) 10Dzahn: "W3C CSS Validator says: " This document validates as CSS level 3 ! ":) 6 warnings left, half of them related to -moz-border-. http://jigsa" [wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/86884 (owner: 10Aklapper) [11:06:55] (03PS3) 10Hoo man: Accessibility: Don't remove checkbox outline on focus [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [11:07:55] (03CR) 10Siebrand: [C: 04-1] "(2 comments)" [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/38487 (owner: 10thibaultmarin) [11:08:01] thedj: there? [11:08:16] (03PS2) 10Ebrahim: Native digits on 'mw-echo-overlay-title-text' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88045 [11:12:54] (03PS1) 10Dzahn: fix the last CSS validator warning in vector.css. "Same color for background-color and color" for
[wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/88049 [11:13:37] (03CR) 10Dzahn: [C: 032 V: 032] fix the last CSS validator warning in vector.css. "Same color for background-color and color" for
[wikimedia/bugzilla/modifications] - 10https://gerrit.wikimedia.org/r/88049 (owner: 10Dzahn) [11:16:18] (03CR) 10Siebrand: "(1 comment)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88032 (owner: 10Nemo bis) [11:18:05] (03CR) 10Nemo bis: "Siebrand, do you want that change in this or another commit?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88032 (owner: 10Nemo bis) [11:18:36] Nemo_bis: If you know how to amend, might as well be in the asme. [11:19:13] oki [11:20:40] (03CR) 10Siebrand: "(1 comment)" [extensions/PageDisqus] - 10https://gerrit.wikimedia.org/r/87919 (owner: 10Luis Felipe Schenone) [11:23:50] (03PS2) 10Nemo bis: Reword thanks-confirmation and thanks-thanked-notice [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88032 [11:26:01] (03CR) 10Siebrand: [C: 032] Reword thanks-confirmation and thanks-thanked-notice [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88032 (owner: 10Nemo bis) [11:26:04] (03Merged) 10jenkins-bot: Reword thanks-confirmation and thanks-thanked-notice [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88032 (owner: 10Nemo bis) [11:38:45] (03CR) 10Hashar: "spamming as well for zuul test." [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/70821 (owner: 10QChris) [11:40:06] (03CR) 10Hoo man: "Fixed the style issues brought up by MarkTraceur" [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [11:40:30] marktraceur: ^ Could you have another look so that we can maybe merge this anytime soon? [12:18:01] (03PS3) 10Stwalkerster: Add links to abusefilter-edit-done [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 [12:21:07] (03PS1) 10Siebrand: Remove language that has fallback. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88059 [12:22:13] (03PS2) 10Siebrand: Remove language that has fallback. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88059 [12:22:25] (03CR) 10Siebrand: [C: 032] Remove language that has fallback [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88059 (owner: 10Siebrand) [12:22:28] (03Merged) 10jenkins-bot: Remove language that has fallback [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88059 (owner: 10Siebrand) [12:34:56] (03PS1) 10Hashar: Add a graphite key for all jobs in a pipeline [integration/zuul] - 10https://gerrit.wikimedia.org/r/88063 [12:35:39] (03CR) 10Hashar: [C: 032 V: 032] Add a graphite key for all jobs in a pipeline [integration/zuul] - 10https://gerrit.wikimedia.org/r/88063 (owner: 10Hashar) [12:44:40] (03CR) 10Alex Monk: [C: 032] Add links to abusefilter-edit-done [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 (owner: 10Stwalkerster) [12:44:50] (03Merged) 10jenkins-bot: Add links to abusefilter-edit-done [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 (owner: 10Stwalkerster) [12:52:30] (03PS1) 10Hashar: Revert "Add a graphite key for all jobs in a pipeline" [integration/zuul] - 10https://gerrit.wikimedia.org/r/88065 [12:52:36] (03CR) 10Hashar: [C: 032 V: 032] Revert "Add a graphite key for all jobs in a pipeline" [integration/zuul] - 10https://gerrit.wikimedia.org/r/88065 (owner: 10Hashar) [13:11:19] (03CR) 10Siebrand: "(1 comment)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/87701 (owner: 10Stwalkerster) [13:16:21] (03CR) 10Ebrahim: [C: 031] Set up local date formats for Sorani Kurdish (ckb) [core] - 10https://gerrit.wikimedia.org/r/76232 (owner: 10TTO) [13:32:26] (03PS1) 10Hashar: graph showing Gerrit events [integration/docroot] - 10https://gerrit.wikimedia.org/r/88075 [13:32:36] (03CR) 10Hashar: [C: 032] graph showing Gerrit events [integration/docroot] - 10https://gerrit.wikimedia.org/r/88075 (owner: 10Hashar) [13:32:38] (03Merged) 10jenkins-bot: graph showing Gerrit events [integration/docroot] - 10https://gerrit.wikimedia.org/r/88075 (owner: 10Hashar) [13:40:15] (03CR) 10Alex Monk: [C: 032] Remove unused or incognito mwe-upwiz-campaigns-editing [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87628 (owner: 10Nemo bis) [13:40:23] (03Merged) 10jenkins-bot: Remove unused or incognito mwe-upwiz-campaigns-editing [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87628 (owner: 10Nemo bis) [13:41:26] (03CR) 10Anomie: "Good catch. Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/87655 (owner: 10Umherirrender) [13:44:49] (03CR) 10Alex Monk: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86814 (owner: 10MarkTraceur) [14:15:43] (03CR) 10Anomie: [C: 031] "Straightforward and works as advertised. Probably should be mentioned in RELEASE_NOTES though?" [core] - 10https://gerrit.wikimedia.org/r/87692 (owner: 10Legoktm) [14:27:49] (03CR) 10Alex Monk: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86787 (owner: 10MarkTraceur) [14:30:58] (03CR) 10Brion VIBBER: [C: 031] "Provisional +1, comment makes me happy :)" [core] - 10https://gerrit.wikimedia.org/r/86007 (owner: 10Aaron Schulz) [14:33:38] hey brion [14:33:43] trivial patches: https://gerrit.wikimedia.org/r/#/c/85654/ and https://gerrit.wikimedia.org/r/#/c/87513/ [14:34:18] howdy [14:37:05] oh yay, os x 10.9 upgrade broke my web config [14:37:12] do i fix it or switch to vagrant? :D [14:37:41] will have to work on vagrant-parallels some time... or else start running it under linux in parallels ;) [14:37:42] (03CR) 10Alex Monk: "(3 comments)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86789 (owner: 10MarkTraceur) [14:40:20] YuviPanda: did you see my crazy weekend project? :D https://brionv.com/log/2013/10/06/ogv-js-proof-of-concept/ [14:41:35] (03CR) 10Brion VIBBER: [C: 04-2] "There's already a "Campaign" class in CentralAuth, so..... probably not a good idea to conflict here." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87513 (owner: 10Yuvipanda) [14:41:45] (03CR) 10Brion VIBBER: "CentralNotice rather, not CentralAuth." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87513 (owner: 10Yuvipanda) [14:48:19] (03CR) 10BryanDavis: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87650 (owner: 10Aaron Schulz) [14:49:01] brion: why would CentralNotice have a 'Campaign' class?! [14:49:02] oh [14:49:03] well [14:49:18] brion: vagrant! :D [14:49:23] because there are notice campaigns. [14:49:31] (03Abandoned) 10Yuvipanda: Rename UploadWizardCampaign class to Campaign [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/87513 (owner: 10Yuvipanda) [14:49:35] hurr durr PHP [14:49:42] namespaces :D [14:50:01] +1 for at least fake namespaces [14:50:06] brion: there's also https://gerrit.wikimedia.org/r/#/c/87887/ [14:50:15] bd808: ^ that's the wgServer fix [14:50:17] in cor [14:50:18] e [14:51:20] * brion looks [14:53:35] (03CR) 10Brion VIBBER: [C: 031] "Probably the right thing to do, though I'm slightly concerned the installer might try to do something with a URL -- could be an issue when" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [14:54:30] (03CR) 10Reza: [C: 031] "looks ok" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88045 (owner: 10Ebrahim) [14:57:04] Krinkle|detached: nature's call [15:00:56] hashar: where did you go [15:02:02] (03PS1) 10Aude: Update Wikibase with fix for diff viewing [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88114 [15:02:45] Reedy: ^ for whenever we put wikidata on 1.22wmf20 [15:02:59] Uhh [15:03:00] it involves a new i18n message, so needs cache update [15:03:09] is that what we are on ? [15:03:26] it can wait a few hours [15:05:19] (03CR) 10BryanDavis: [C: 031] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [15:08:50] (03CR) 10Anomie: "Seems to generally work, at the expense of making '"' be incorrectly highlighted." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/86395 (owner: 10Ori.livneh) [15:08:57] (03CR) 10BryanDavis: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/87623 (owner: 10Yuvipanda) [15:10:14] (03PS1) 10Siebrand: Explicit plural support for 'echo-overlay-title-overflow' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88115 [15:16:48] (03PS1) 10Krinkle: zuul: Fix insecure content warnings, amp, img[title] [integration/docroot] - 10https://gerrit.wikimedia.org/r/88118 [15:17:02] (03CR) 10Krinkle: [C: 032] zuul: Fix insecure content warnings, amp, img[title] [integration/docroot] - 10https://gerrit.wikimedia.org/r/88118 (owner: 10Krinkle) [15:17:06] (03CR) 10BryanDavis: "So far Ori has preferred to create very slim and targeted local modules rather than pull in common puppet modules like this. See the apach" [vagrant] - 10https://gerrit.wikimedia.org/r/88005 (owner: 10Legoktm) [15:17:42] (03CR) 10Raimond Spekking: [C: 032] Explicit plural support for 'echo-overlay-title-overflow' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88115 (owner: 10Siebrand) [15:17:55] (03Merged) 10jenkins-bot: Explicit plural support for 'echo-overlay-title-overflow' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88115 (owner: 10Siebrand) [15:18:22] (03CR) 10Yuvipanda: "Personally, creating a new module for everything feels very much NIH-y to me. We should re-use libraries wherever we can." [vagrant] - 10https://gerrit.wikimedia.org/r/88005 (owner: 10Legoktm) [15:18:23] (03PS1) 10Siebrand: Add GENDER support for 'thanks-error-ratelimited' [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88119 [15:18:32] (03CR) 10Hashar: "you are the best :)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/88118 (owner: 10Krinkle) [15:23:51] (03CR) 10Anomie: "(1 comment)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [15:25:06] (03CR) 10Anomie: [C: 031] "Code looks ok. Haven't tested." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/87311 (owner: 10Legoktm) [15:29:23] (03PS13) 10BryanDavis: Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [15:31:28] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [15:35:15] (03CR) 10Daniel Kinzler: [C: 031] "Looks sane, didn't test." [core] - 10https://gerrit.wikimedia.org/r/80367 (owner: 10Addshore) [15:37:22] (03CR) 10Krinkle: "Need tests." [core] - 10https://gerrit.wikimedia.org/r/87482 (owner: 10saper) [15:37:36] (03CR) 10Legoktm: "What Yuvi said. I don't think its worth the effort to write another cron module when one that works already exists." [vagrant] - 10https://gerrit.wikimedia.org/r/88005 (owner: 10Legoktm) [15:39:26] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87482 (owner: 10saper) [15:43:16] (03CR) 10BryanDavis: "I don't have really strong feelings one way or the other, but I think Ori does. :)" [vagrant] - 10https://gerrit.wikimedia.org/r/88005 (owner: 10Legoktm) [15:47:03] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87479 (owner: 10Physikerwelt) [15:48:07] (03PS8) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [15:55:52] (03CR) 10Daniel Kinzler: [C: 031] "Looks like the right thing, but my jquery foo is weak." [core] - 10https://gerrit.wikimedia.org/r/88033 (owner: 10Hoo man) [16:02:10] (03PS1) 10MarkTraceur: jquery audit for mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88124 [16:17:06] (03PS9) 10Matthias Mullie: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 [16:21:39] (03PS1) 10Chad: Moved scripts but didn't update paths [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88127 [16:22:04] (03CR) 10Nikerabbit: [C: 031] Native digits on 'mw-fr-revisiontag-edit' [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/88008 (owner: 10Ebrahim) [16:26:46] (03PS1) 10Aaron Schulz: Made JobQueueDB use getConnectionRef [core] - 10https://gerrit.wikimedia.org/r/88128 [16:27:10] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [16:27:18] (03CR) 10Parent5446: [C: 031] "Haven't tested." [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [16:29:14] (03PS1) 10Manybubbles: Optimize in place reindexing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 [16:30:49] (03CR) 10Ori.livneh: [C: 04-2] "The cron resource type is built-in: http://docs.puppetlabs.com/references/2.7.stable/type.html#cron" [vagrant] - 10https://gerrit.wikimedia.org/r/88005 (owner: 10Legoktm) [16:31:24] (03CR) 10jenkins-bot: [V: 04-1] Made JobQueueDB use getConnectionRef [core] - 10https://gerrit.wikimedia.org/r/88128 (owner: 10Aaron Schulz) [16:33:01] (03CR) 10Nikerabbit: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88033 (owner: 10Hoo man) [16:34:11] (03PS2) 10Aaron Schulz: Made JobQueueDB use getConnectionRef [core] - 10https://gerrit.wikimedia.org/r/88128 [16:34:23] (03CR) 10Aaron Schulz: "Some local changes weren't pushed...grr" [core] - 10https://gerrit.wikimedia.org/r/88128 (owner: 10Aaron Schulz) [16:35:08] (03CR) 10Manybubbles: [C: 032] Moved scripts but didn't update paths [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88127 (owner: 10Chad) [16:35:28] (03Merged) 10jenkins-bot: Moved scripts but didn't update paths [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88127 (owner: 10Chad) [16:39:14] (03PS1) 10Aaron Schulz: Removed RC query UNION [core] - 10https://gerrit.wikimedia.org/r/88135 [16:40:23] (03CR) 10Chad: "Haven't tested yet, but looks promising on the tin." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 (owner: 10Manybubbles) [16:40:35] my team is interested in pulling in a simple library ( https://github.com/schmittjoh/php-option/tree/master/src/PhpOption ) and was curious, is there some procedure perhaps for security code review before pulling in vendor code? I've looked over the code already, but perhaps theres something more official [16:41:08] (03PS3) 10Aaron Schulz: Added an expiry field to upload stash table [core] - 10https://gerrit.wikimedia.org/r/87607 [16:41:38] <^d> ebernhardson: I wouldn't worry about that library too much. Doesn't appear to *do* much of anything. [16:41:41] ebernhardson: For deployment on the wmf cluster? Yeah, you would need a security review of it [16:41:56] ^d: correct it doesn't do much, its justa Maybe monad in php [16:42:17] csteipp: is there some mailing list i should ping perhaps? or just email you? :) [16:42:30] (03CR) 10Manybubbles: ">At the very least we should note in the README that we've now require pcntl (and thus don't support Windows)" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 (owner: 10Manybubbles) [16:43:07] (03CR) 10Manybubbles: [C: 04-1] "-1 my own commit until I fix it up to not crash on windows." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 (owner: 10Manybubbles) [16:43:09] (03PS1) 10Ebrahim: Native digits on 'onGetHumanTimestamp' [extensions/cldr] - 10https://gerrit.wikimedia.org/r/88136 [16:44:06] <^d> ebernhardson: Do note you'll have to import that code into a gerrit repo (either copying into your extension or creating a new gerrit repo). We can't deploy from external github repos. [16:44:10] ebernhardson: Send me and Robla an email saying how your planning to use it, and what your timeline is, and we'll prioritize it in the queue [16:44:48] ^d: thats reasonable, can have a /vendor directory in our extension. [16:44:54] csteipp: ok thanks, will do [16:48:53] (03CR) 10Reza: [C: 031] "seems ok" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/88136 (owner: 10Ebrahim) [16:49:16] greg-g: with more things riding the train nowadays, would it make sense to make the LD window longer? [16:49:23] or would you view that as regressive? [16:53:46] (03Abandoned) 10Ebrahim: Native digits for human timestamp [core] - 10https://gerrit.wikimedia.org/r/85711 (owner: 10Ebrahim) [16:53:48] ori-l: mostly regressive [16:54:06] ori-l: for config changes and high priority stuff, maybe. [16:54:22] but hopefully we just get better about developing an targeting the train [16:54:28] and* [16:54:45] how come? [16:55:06] (03PS1) 10Manybubbles: Wrap updateOneSearchIndexConfig in top level catch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88138 [16:55:23] (03PS1) 10Mwalker: Updating DI to master and adding CLDR [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/88139 [16:55:37] (03CR) 10Ebrahim: "This could fix the bug if applied but https://gerrit.wikimedia.org/r/#/c/88136/ is the right way to fix it." [core] - 10https://gerrit.wikimedia.org/r/85711 (owner: 10Ebrahim) [16:55:56] <^d> AaronSchulz: https://gerrit.wikimedia.org/r/#/c/87612/ [16:56:45] (03CR) 10Aaron Schulz: [C: 032] Remove placeholder tests [core] - 10https://gerrit.wikimedia.org/r/87612 (owner: 10Chad) [16:57:01] (03PS2) 10Mwalker: Updating DI to master and adding CLDR [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/88139 [16:58:06] (03CR) 10Mwalker: [C: 032 V: 032] Updating DI to master and adding CLDR [core] (fundraising/1.22) - 10https://gerrit.wikimedia.org/r/88139 (owner: 10Mwalker) [17:01:41] (03Merged) 10jenkins-bot: Remove placeholder tests [core] - 10https://gerrit.wikimedia.org/r/87612 (owner: 10Chad) [17:08:04] (03CR) 10Aaron Schulz: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87617 (owner: 10Anomie) [17:08:25] (03PS1) 10Stwalkerster: Remove trailing whitespace [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/88142 [17:09:05] (03CR) 10Siebrand: [C: 032] Remove trailing whitespace [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/88142 (owner: 10Stwalkerster) [17:09:11] (03Merged) 10jenkins-bot: Remove trailing whitespace [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/88142 (owner: 10Stwalkerster) [17:09:14] ^d: https://gerrit.wikimedia.org/r/#/c/87703/ [17:10:18] (03CR) 10Chad: [C: 032] Avoid section edit links when needed [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/87703 (owner: 10Aaron Schulz) [17:25:39] (03PS2) 10Manybubbles: Optimize in place reindexing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 [17:26:03] (03CR) 10Manybubbles: "Now it'll degrade to a single process on Windows." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 (owner: 10Manybubbles) [17:34:52] (03CR) 10Chad: [V: 032] Avoid section edit links when needed [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/87703 (owner: 10Aaron Schulz) [17:44:26] (03PS3) 10Krinkle: mediawiki.action.edit.preview: Clean up and optimisation [core] - 10https://gerrit.wikimedia.org/r/87917 [17:48:15] Krinkle: Think I can trouble you for more review on the core patch for mw.Title? [17:48:19] It's rebased and ready to go [17:48:35] marktraceur: fromImgSrc? [17:48:50] That's the one [17:49:11] I'm hoping to push it through and start using it in MultimediaViewer [17:52:40] (03CR) 10Krinkle: "(5 comments)" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [17:53:14] Arigatou, Krinkle-san [17:54:33] (03CR) 10Anomie: "(1 comment)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/87617 (owner: 10Anomie) [17:54:53] marktraceur, what extension special-cases TOR users? [17:54:57] (03CR) 10Krinkle: "I'd be for adding a data attribute containing the full (plain) page name to internal wiki links and file embeds . But it doesn't " [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [17:55:11] marktraceur, because it sounds like another plugin is involved in https://bugzilla.wikimedia.org/show_bug.cgi?id=55426 [17:55:16] extension* even, not plugin [17:55:33] Krenair: I, um, haven't the slightest involvement in the Tor stuff [17:55:49] Wrong mark. Oops, sorry. [17:55:52] hexmode, ^ [17:56:02] I can see why you might be confused [17:56:10] Us both being Mark Andrew H. and all. [17:56:12] I just typed mark and it autocompleted, so... :p [17:56:31] Source of endless fun [17:58:24] (03PS1) 10Legoktm: Use the API to fetch the email if possible [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/88150 [18:01:02] (03CR) 10Isarra: "(1 comment)" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/88150 (owner: 10Legoktm) [18:02:50] (03PS2) 10Umherirrender: Move release note for meta=filerepoinfo into api section [core] - 10https://gerrit.wikimedia.org/r/87655 [18:03:43] (03CR) 10Umherirrender: "Patch Set 2: Rebased" [core] - 10https://gerrit.wikimedia.org/r/87655 (owner: 10Umherirrender) [18:06:26] (03PS2) 10Legoktm: Use the API to fetch the email if possible [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/88150 [18:06:31] Isarra: ^ [18:07:43] duh: Interesting new nick there [18:07:56] i've had this one for a while :P [18:07:57] marktraceur: he's had that for a while :P [18:08:05] SOCK [18:08:05] SOCK [18:08:06] SOCK [18:08:16] Reedy_: You are not the real Reedy! [18:08:29] Reedy_: Damn it, came out with an odd number of socks in the wash again [18:08:54] The washer monsters ate it. [18:09:07] Won't the real Slim Reedy please stand up, please stand up [18:09:20] heh [18:10:38] (03CR) 10Reedy: [C: 032 V: 032] Update Wikibase with fix for diff viewing [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88114 (owner: 10Aude) [18:11:00] duh: Scratch that, isn't all that stuff in the api now? [18:11:10] brion: poke [18:11:14] Isarra: it should be, but we don't have to remove the fallback [18:11:19] YuviPanda: peek [18:11:25] brion: special pages don't get cached at all, right? [18:11:41] YuviPanda: not unless they explicitly opt in to http caching no [18:11:48] (03CR) 10Anomie: [C: 032] Move release note for meta=filerepoinfo into api section [core] - 10https://gerrit.wikimedia.org/r/87655 (owner: 10Umherirrender) [18:11:49] brion: are there any that do? [18:11:55] duh: Well, currently the fallback is running either way; if it's in the api we can have it skip the entire screenscraping mess entirely. [18:12:09] not sure... might be a couple that do a quick last-modified check [18:12:16] hmm [18:12:35] Like all that stuff, real name, email, er... actually, that may be it. [18:12:44] Isarra: yeah. i'm going to have to go afk in a bit, ill work on the patch when i get back [18:12:51] duh: Aiight, thanks. [18:13:09] duh: If I take the entire wiki pile down on accident, though, can you clean that up when you get back instead? [18:13:15] (03CR) 10MarkTraceur: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [18:13:17] brion: hmm, okay. I'm going to repeat the same thing I did with campaign pages - just not cache it to start with, and then see if I need to :) [18:13:30] heh [18:13:32] hoo: Sorry, I have one more nitpick on that patch and then we can merge 'er [18:13:36] worked out ok [18:13:49] (03PS1) 10Legoktm: ReferenceError: wgDraft is not defined [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88151 [18:14:06] marktraceur: Ah damn, missed that... thanks for pointing it out ;) [18:14:11] No problemo [18:14:11] Bloody centralnotice... [18:14:16] And it's the damn cooperative one. [18:14:31] hoo: I'm glad my OCD can be useful to you [18:14:40] fatal: failed to read object c9768a7a1b00b876bd53082b660be40f6c8fb5fe: Operation not permitted [18:14:45] (03Abandoned) 10MaxSem: Disable slow list=allusers&auactiveusers query in miser mode [core] - 10https://gerrit.wikimedia.org/r/79761 (owner: 10MaxSem) [18:16:14] MaxSem: domas would be upset [18:16:21] (03Merged) 10jenkins-bot: Move release note for meta=filerepoinfo into api section [core] - 10https://gerrit.wikimedia.org/r/87655 (owner: 10Umherirrender) [18:16:29] (03PS4) 10Hoo man: Accessibility: Don't remove checkbox outline on focus [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [18:16:47] Reedy, just trolling teh trollz [18:17:17] (03CR) 10Hoo man: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [18:17:19] God damn it all [18:17:28] git review without a key manager is hell [18:17:36] (03CR) 10Hoo man: "Fixed indentation, per MarkTraceur" [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [18:17:47] It makes like five fetches in a row [18:18:02] git push gerrit HEAD:refs/for/master [18:18:02] ftw [18:18:30] Mrr [18:18:45] bd808|LUNCH: poke at https://gerrit.wikimedia.org/r/#/c/87887/ when you can :) [18:18:48] YuviPanda: I like the git-review interface, I just don't like it on this shitty ass-computer [18:19:14] marktraceur: ah, right [18:19:14] marktraceur, GET A MAC [18:19:31] marktraceur: an ssh roundtrip for me to gerrit is like, ~10s, so anything to minimize that :) [18:20:17] (03CR) 10MarkTraceur: [C: 032] "Arrrrrrrighty then, let's do this thing." [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [18:20:49] MaxSem: I'm getting another T420s tomorrow, I just failed to bring in the old one today so I can't switch yet [18:21:02] hoo: There ya go [18:21:09] :)) [18:21:09] WHY NOT MAC [18:21:09] (03CR) 10Legoktm: [C: 031] "(1 comment)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [18:21:16] * YuviPanda waits for the X240 reviews [18:21:17] So for now, HP mini like a bowss. [18:23:55] (03Merged) 10jenkins-bot: Accessibility: Don't remove checkbox outline on focus [core] - 10https://gerrit.wikimedia.org/r/80813 (owner: 10TheDJ) [18:24:28] (03CR) 10saper: "Thanks, strange; somehow I did sucessfully test the change..." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/87293 (owner: 10Bpetty) [18:26:33] i might be about to spam the channel with apps-ios-commons updates. if so, sorry [18:27:51] (03PS7) 10MarkTraceur: Add file-link "parser" to mw.Title from commons [core] - 10https://gerrit.wikimedia.org/r/87487 [18:29:00] 2 PHP Catchable fatal error: Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.22wmf20/extensions/AbuseFilter/AbuseFilter.class.php on line 901 and defined in /usr/local/apache/common-local/php-1.22wmf20/includes/context/RequestContext.php on line 93 [18:29:40] (03CR) 10MarkTraceur: "There isn't currently a more direct data source, and I don't want to dredge through an RfC process before beginning work on MultimediaView" [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [18:30:02] (03PS9) 10Umherirrender: Add expensive parser functions {{REVISION*:}} [core] - 10https://gerrit.wikimedia.org/r/76534 [18:30:28] (03CR) 10Umherirrender: "Patch Set 9: Rebased" [core] - 10https://gerrit.wikimedia.org/r/76534 (owner: 10Umherirrender) [18:31:00] (03CR) 10jenkins-bot: [V: 04-1] Add file-link "parser" to mw.Title from commons [core] - 10https://gerrit.wikimedia.org/r/87487 (owner: 10MarkTraceur) [18:32:16] (03CR) 10Jdlrobson: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/50594 (owner: 10Isarra) [18:34:56] (03PS1) 10Brion VIBBER: Initial pass at removal of details table view. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88154 [18:34:57] (03PS1) 10Brion VIBBER: Made title use a label instead of textbox if already uploaded. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88155 [18:34:58] (03PS1) 10Brion VIBBER: Made description use a label instead of textbox if already uploaded. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88156 [18:34:59] (03PS1) 10Brion VIBBER: Made title text field padding better match description box's. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88157 [18:34:59] wheeeee [18:35:00] (03PS1) 10Brion VIBBER: Hooked up the add category button. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88158 [18:35:01] (03PS1) 10Brion VIBBER: Implemented category swipe to delete. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88159 [18:35:02] (03PS1) 10Brion VIBBER: Made details scroll down if gap beneath slider after category delete. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88160 [18:35:02] here comes the flood [18:35:03] (03PS1) 10Brion VIBBER: Added hamburger to category labels for swipe to delete discovery. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88161 [18:35:04] (03PS1) 10Brion VIBBER: No description found message wasn't displaying. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88162 [18:35:05] (03PS1) 10Brion VIBBER: Category "loading..." message behavior and appearance. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88163 [18:35:06] (03PS1) 10Brion VIBBER: Added license info to details page for already uploaded images. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88164 [18:35:07] (03PS1) 10Brion VIBBER: Made details page license selectable for new images. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88165 [18:35:08] (03PS1) 10Brion VIBBER: Diplay license name (instead of abbreviation) for uploaded images. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88166 [18:35:09] (03PS1) 10Brion VIBBER: Scrolling details up no longer hides nav bar. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88167 [18:35:10] (03PS1) 10Brion VIBBER: Made My Uploads page use back arrow for consistency. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88168 [18:35:11] (03PS1) 10Brion VIBBER: Made text box not underlap nav bar when keyboard appears. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88169 [18:35:12] (03PS1) 10Brion VIBBER: Made nav back buttons more consistent between iOS 6 and 7. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88170 [18:35:13] (03PS1) 10Brion VIBBER: Fix gallery top spacing for iOS 7. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88171 [18:35:14] (03PS1) 10Brion VIBBER: Made category hamburger a bit lighter and taller for better contrast. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88172 [18:35:15] (03PS1) 10Brion VIBBER: Moved delete button to bottom of details slider. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88173 [18:35:16] (03PS1) 10Brion VIBBER: Made category search dark grey. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88174 [18:35:17] (03PS1) 10Brion VIBBER: Removed the "Deletion" heading above the slider delete button. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88175 [18:35:18] (03PS1) 10Brion VIBBER: Reduced height of details description text box. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88176 [18:35:19] (03PS1) 10Brion VIBBER: Cleared out some table view cruft. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88177 [18:35:19] :S [18:35:20] (03PS1) 10Brion VIBBER: Fix for improper call to super method. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88178 [18:35:21] (03PS1) 10Brion VIBBER: Fixed visual artifact with swipe to delete. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88179 [18:35:22] (03PS1) 10Brion VIBBER: iOS 7 fixes for text field cursor consistency. [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88180 [18:35:27] ok that should be it [18:35:31] :) [18:36:18] Did someone put brion in a dark room with no internet? [18:36:36] brion: are you going to hand merge them all?! [18:36:40] i'm migrating monte's changes over from github :D [18:36:57] YuviPanda: i figured i'd read them in gerrit rather than in github and then squash them [18:36:59] it won't take me too long :) [18:37:07] heh [18:37:08] true [18:38:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Tested along with subsequent commits; merging to gerrit." [apps/ios/commons] - 10https://gerrit.wikimedia.org/r/88154 (owner: 10Brion VIBBER) [18:40:43] brion: deployed patch to move apps/.* to -mobile [18:40:49] so won't be spamming here anymore! [18:41:14] yay [18:42:43] (03PS3) 10Chad: Wrap MySQL queries in wfSuppressWarnings()/wfRestoreWarnings() [core] - 10https://gerrit.wikimedia.org/r/87281 [18:43:38] (03PS1) 10Anomie: Fix frame:extensionTag when not passed args [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/88182 [18:43:53] (03CR) 10Reedy: "Caused https://bugzilla.wikimedia.org/show_bug.cgi?id=55437" [core] - 10https://gerrit.wikimedia.org/r/69027 (owner: 10Brian Wolff) [18:43:59] YuviPanda: I looked at you installer patch. Seems like good stuff, but I'm not BOLD enough to +2 [18:44:36] bd808: hmm, that leaves us with ori -l [18:45:22] YuviPanda: Replacing `empty()` with something else might be good too. [18:45:33] bd808: well, in this case empty is what I want... [18:45:43] like, literally, if it isn't set wgServer ends up being "" [18:45:44] Hi marktraceur, Krin-kle and Daniel suggested adding a data attribute to s and s. What's the issue with that? [18:46:33] YuviPanda: ah, but although empty("") === true so many other things do as well [18:46:35] rillke: You mean Krinkle? [18:46:49] bd808: right, and considered dangerous for that reason [18:47:13] rillke: I think the issue is that there's a patch in already, that it's controversial because of the technical implications, and that it would take time to shepherd it through [18:47:21] bd808: the *actual* fix there is probably for me to track down where it gets set to "" and make sure that it is set to something else saner. like null. [18:47:25] empty("") == true is ok, empty("0") == true is insane :D [18:47:26] bd808: or better yet - not set at all! [18:47:37] I think the parser is a faster path to the solution for now, and we can delete it later if we get titles in attributes [18:47:48] (03PS1) 10Reedy: Fix "Unsupported operand types at thumb.php on line 429" [core] - 10https://gerrit.wikimedia.org/r/88183 [18:47:57] bd808: ori-l but in the meantime, I can change that to a !== "" [18:48:02] Reedy: https://gerrit.wikimedia.org/r/#/c/88009/ could use your input (not urgent, just flagging) [18:48:23] (03PS1) 10Reedy: Fix "Unsupported operand types at thumb.php on line 429" [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88184 [18:48:40] (03CR) 10MaxSem: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [18:48:41] (03CR) 10Reedy: [C: 032] Fix "Unsupported operand types at thumb.php on line 429" [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88184 (owner: 10Reedy) [18:49:17] brion: Note though that unfortunately, most of empty()'s evilness is in PHP's boolean cast, not the function itself. empty() is effectively `!isset($var) || !$var` [18:49:23] marktraceur: So it is mainly an implementation-and-testing issue but nothing against a data-attribute. [18:49:40] oh booleans [18:49:48] no more empty [18:49:49] could be worse, could be ruby [18:49:51] where 0 means true [18:49:59] !array(), !"0", !"", all false [18:49:59] (03PS3) 10Yuvipanda: Do not set wgServer in cli install unless explicitly passed [core] - 10https://gerrit.wikimedia.org/r/87887 [18:50:06] true* [18:50:15] rillke: I'm not sure what you mean [18:50:26] * YuviPanda has been writing scala and SML lately [18:50:29] https://gerrit.wikimedia.org/r/#/c/85926/ [18:50:57] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [18:51:03] "I'd be for adding a data attribute containing the full (plain) page name to internal wiki links", marktraceur [18:51:05] * bd808 was reading/writing objc for most of the weekend [18:51:36] * rillke thinks that Gerrit could be improved so one can link directly to Comments [18:51:45] rillke: I'm intrigued, but I think we should follow the Parsoid spec, or if the Parsoid spec doesn't make sense, we should change it [18:51:49] Let's do this "right" [18:52:55] marktraceur: i've only been half-following that above, but "do you need an rfc for that?" cause having machine-readable link/media target name would be *really useful* for mobile apps [18:52:58] so i'd like to push forward on that [18:54:11] brion: It would be useful, but I think my naive solution there isn't enough [18:54:22] brion: If you'd like to help out on the review of that patch it'd be awesome [18:54:35] ok add me on there and i'll look & comment later [18:54:41] (03Merged) 10jenkins-bot: Fix "Unsupported operand types at thumb.php on line 429" [core] (wmf/1.22wmf20) - 10https://gerrit.wikimedia.org/r/88184 (owner: 10Reedy) [18:54:42] Saweet. [18:55:52] Done [18:56:15] brion: I guess a good temporary solution would be adding data-mw-title and data-mw-interwiki where applicable [18:56:31] Or "just" adding a data-mw attribute with JSON values (like Parsoid does already) [18:56:54] But that'd mean writing a library for accessing the data-mw stuff on the frontend... [18:57:01] Krinkle: Does VE already do ^ that? [18:57:22] you dawg i heard you liked data structures [18:57:28] so i put json in your xml [18:57:35] and put the xm in json! [18:57:44] json in xml in json! [18:57:53] hah [18:58:03] yeah that'd be funny if it weren't true [18:58:12] * brion looks pointedly at action=mobileview [18:58:32] bd808: hopefully gwicke's Content API stuff will be ready for us when we start the app :) [18:58:40] marktraceur: do what exactly? [18:58:56] Krinkle: Load data-mw [18:59:06] Into a sane-looking structure that isn't painful [18:59:17] (03PS1) 10Andrew Bogott: Fix one error message, remove another bogus one. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88186 [18:59:18] (03PS1) 10Andrew Bogott: DRAFT -- add a gui for invisible unicorn [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 [18:59:28] Well, in our data structure they are accessible as native objects. We access them if we need to, yes. [18:59:42] hmmm, OpenStackManager reports here [18:59:43] but commonly the target property of a link [18:59:53] Hm [18:59:58] which we then strip the prefix ./ and the like from to get the real title [19:00:00] most annoying imho. [19:00:49] Krinkle: So it's not like it's a library we could use to access it from other scripts [19:01:58] (03PS1) 10Anomie: Allow $context->setTitle( null ) [core] - 10https://gerrit.wikimedia.org/r/88189 [19:04:07] marktraceur: indeed, but also, there is not much do it.. [19:04:08] target = $.data('mw').target; title = mw.Title.newFromText(target); [19:04:47] * Isarra shakes her fist at mwalker. [19:04:59] What you need to go making the damn stuff better for? [19:05:01] Krinkle: $.data parses JSON automatically? [19:05:15] Isarra: what did I do? [19:05:40] * YuviPanda guesses CN [19:05:50] ah; ya; that would make sense [19:05:53] mwalker: Well, maybe it wasn't you, but I installed the wrong (1.22) version of centralnotice on accident and it had a much nicer interface than the 1.21 branch. [19:06:02] But it was probably you. [19:06:11] probably -- I'll poke you when I get back [19:06:14] mark calls for curry [19:06:22] Eat well, you nutters. [19:06:45] marktraceur: it might, but even if not, so you parse it. [19:06:54] $.parseJSON() [19:06:58] part of jquery core [19:07:13] though I don't think we should use json here [19:07:15] a simple data attribute directly. [19:07:51] does it automatically parse as JSON strings that happen to look like JSON but weren't meant to be? [19:08:17] brion: The trick there is that everything is valid json. [19:08:25] \o/ [19:08:27] data-foo="4" comes out as number 4 [19:08:32] not string [19:08:39] (03CR) 10CSteipp: [C: 031] "That fixes our issue, although I'm not sure about any side effects." [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [19:08:47] with implied quoting if it isn't an object [19:08:49] I think [19:08:50] not sure [19:08:51] so as long as you store data-foo=""blah"" instead of data-foo="blah" ... [19:09:12] anyway, not a feature we should use. jQuery specific and adds bloat [19:09:24] * brion avoids the bloat boat [19:09:52] I suppose it made sense for Parsoid as a concept of authority. e.g. every attribute is public. So everything inside data-parsoid is private. [19:10:19] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87887 (owner: 10Yuvipanda) [19:14:44] (03PS1) 10Ori.livneh: Rename CoreEvents to WikimediaEvents [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88190 [19:18:03] (03PS1) 10Ori.livneh: Remove HTTPS support detection [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88191 [19:19:04] (03PS14) 10Umherirrender: Add list=allfileusages [core] - 10https://gerrit.wikimedia.org/r/61817 [19:20:15] (03CR) 10Umherirrender: "Patch Set 14: Rebased on the top of Patch Set 6" [core] - 10https://gerrit.wikimedia.org/r/61817 (owner: 10Umherirrender) [19:23:09] ori-l: I praised you all day long for statsd :-] Zuul is spamming some metrics there now \O/ [19:23:20] (03CR) 10Aaron Schulz: [C: 032] Fix "Unsupported operand types at thumb.php on line 429" [core] - 10https://gerrit.wikimedia.org/r/88183 (owner: 10Reedy) [19:23:21] (03PS2) 10Andrew Bogott: DRAFT -- add a gui for invisible unicorn [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 [19:23:39] how do you know the invisible unicorn is there? [19:23:50] AaronSchulz: radar. [19:23:54] you need to have faith [19:23:57] I was going to say sonar [19:24:35] (03CR) 10Andrew Bogott: [C: 032] Fix one error message, remove another bogus one. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88186 (owner: 10Andrew Bogott) [19:24:41] (03CR) 10Andrew Bogott: [V: 032] Fix one error message, remove another bogus one. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88186 (owner: 10Andrew Bogott) [19:25:44] hashar: cool; i'm glad it's useful [19:26:11] (03Merged) 10jenkins-bot: Fix "Unsupported operand types at thumb.php on line 429" [core] - 10https://gerrit.wikimedia.org/r/88183 (owner: 10Reedy) [19:26:13] ori-l: I got some more crazy ideas but no time to actually get thelm implemented. Maybe next quarter :-] [19:26:43] (03CR) 10Mattflaschen: "(2 comments)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88190 (owner: 10Ori.livneh) [19:27:16] (03CR) 10Ori.livneh: "(2 comments)" [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88190 (owner: 10Ori.livneh) [19:31:01] jgonera: are you coming to office today? DarTar wants to know [19:31:23] jdlrobson, I am, I wrote him on IRC but he didn't reply [19:31:25] (03CR) 10Parent5446: "...this patch just completely changed its purpose. In the future it'd be better to submit a new patchset. Rewriting tableExists() is not e" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [19:31:34] ok he just came over to me and asked :) [19:31:36] Kenan and I had the meeting without him [19:31:45] jgonera: sorry guys [19:32:06] I was talking to ori and bsitu on a related issue and missed our call [19:32:19] DarTar, that's OK, I guess we changed the invite a bit late [19:32:51] (03CR) 10Swalling: [C: 031] "Control and test versions checked on piramido and in the log db. Looks correct to me, including data for source, action, funnel, bucket an" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 (owner: 10Mattflaschen) [19:32:51] jgonera: I think we have a good action plan (basically what we discuss on Friday), shall I just send a note to the two of you or is there other stuff that we need to discuss? [19:32:59] s/discuss/discussed [19:33:13] DarTar, to sum up, we think we'll do the graph that is causing problems only for enwiki now and possibly expand later. Kenan was interested what projects use the Edit schema [19:33:29] DarTar, I think Kenan will send an email [19:33:42] ok cool, I'll wait for that then [19:33:50] and I don't know why we're talking on -dev instead of -mobile ;) [19:34:38] (03CR) 10Parent5446: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [19:37:09] (03PS2) 10Ori.livneh: Rename CoreEvents to WikimediaEvents [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88190 [19:38:40] (03PS1) 10Krinkle: mediawiki.Title: Fix weird

in constructor description [core] - 10https://gerrit.wikimedia.org/r/88197 [19:39:04] (03CR) 10Krinkle: "see https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title" [core] - 10https://gerrit.wikimedia.org/r/88197 (owner: 10Krinkle) [19:39:45] (03PS3) 10Andrew Bogott: Add a gui for creation/deletion of labs proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 [19:41:32] (03CR) 10Mattflaschen: [C: 032] "Wording looks good, thanks." [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88190 (owner: 10Ori.livneh) [19:42:51] (03CR) 10Aaron Schulz: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [19:43:09] (03CR) 10Mattflaschen: [V: 032] Rename CoreEvents to WikimediaEvents [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88190 (owner: 10Ori.livneh) [19:44:35] (03PS4) 10Andrew Bogott: Add a gui for creation/deletion of labs proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 [19:47:27] Isarra: you should be able to use master of CentralNotice [19:47:32] if you're on 1.21 you have content handler [19:47:42] which is the only dependency I introduced [19:48:07] (03PS5) 10Andrew Bogott: Add a gui for creation/deletion of labs proxies. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 [19:48:53] (03CR) 10Andrew Bogott: [C: 04-1] "I'm pretty happy with this, but it should not be merged until Yuvi's code has a proper deployment path." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/88187 (owner: 10Andrew Bogott) [19:51:47] mwalker: It exploded on some html button thing. [19:51:58] Isarra: ah ya [19:52:05] you could patch it in [19:52:07] but... [19:52:14] (03PS1) 10Odder: Modify vocative case for Ukrainian Wikinews [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88202 [19:52:16] The 1.21 branch doesn't work either. [19:52:16] *sadness* [19:52:20] what? [19:52:21] (03PS1) 10CSteipp: Move forceHTTPS check until after wgTitle is setup [core] - 10https://gerrit.wikimedia.org/r/88203 [19:52:22] (03PS1) 10Ori.livneh: Update layout.yaml to reflect extension rename (CoreEvents -> WikimediaEvents) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88204 [19:52:27] what error are you getting?!? [19:52:34] The interface is unusable. [19:52:40] oh; ya [19:52:52] I also broke something somewhere and now the updater won't run. [19:53:49] (03CR) 10Anomie: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/88189 (owner: 10Anomie) [19:54:11] (03PS1) 10Ori.livneh: Update mediawiki-extensions.yaml to reflect extension rename (CoreEvents -> WikimediaEvents) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88205 [19:55:26] * brion hmms [19:55:59] mwalker: CentralNotice broke update.php. [19:56:02] lies! [19:56:03] ^d: https://gerrit.wikimedia.org/r/#/q/project:apps/ios/commons,p,002845610001585b <- so i just reviewed a bunch of commits i imported from github to gerrit on apps/ios/commons, but only the first one (on second page) has merged so far [19:56:06] any idea what i need to push? [19:56:10] The 1.21 branch. [19:56:16] * mwalker looks [19:56:17] The 1.22 branch didn't. [19:56:30] Meh. [19:56:35] ^d: ah never mind the 'submit' button is available again [19:56:38] i'll push that :D [19:56:39] I can just kill the entire thing and come back later. [19:56:43] (03PS1) 10Ori.livneh: Update make-wmf-branch to reflect extension rename (CoreEvents -> WikimediaEvents) [tools/release] - 10https://gerrit.wikimedia.org/r/88206 [19:56:48] Like when we're on 1.22. [19:57:30] (03PS1) 10Foxtrott: Remove dependency on Less extension; work around lessphp bug [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/88207 [19:58:13] (03PS2) 10Foxtrott: Remove dependency on Less extension; work around lessphp bug [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/88207 [19:58:30] (03CR) 10Foxtrott: [C: 032 V: 032] Remove dependency on Less extension; work around lessphp bug [extensions/Bootstrap] - 10https://gerrit.wikimedia.org/r/88207 (owner: 10Foxtrott) [19:58:49] Isarra: what point release of 1.21? [19:58:58] ... are you running [19:59:05] (03CR) 10Base: [C: 031] Modify vocative case for Ukrainian Wikinews [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/88202 (owner: 10Odder) [19:59:06] 1.21.[0-2] [20:00:03] .1 [20:03:45] Isarra: damn... this bug [20:03:50] I'll fix it [20:05:21] Thanks. [20:05:27] * Isarra collapses on mwalker. [20:05:47] (03CR) 10MarkAHershberger: "It looks like this might need to be backported to 1.21. See https://www.mediawiki.org/wiki/Thread:Project:Support_desk/PHP_Catchable_fata" [core] - 10https://gerrit.wikimedia.org/r/53923 (owner: 10Parent5446) [20:05:48] (03CR) 10Alex Monk: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88124 (owner: 10MarkTraceur) [20:06:04] (03PS1) 10Manybubbles: Replace prefix: implementation. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88209 [20:06:17] (03PS1) 10Manybubbles: Tests for proper prefix: implementation. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88210 [20:09:08] (03CR) 10MarkTraceur: "(1 comment)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88124 (owner: 10MarkTraceur) [20:09:14] Isarra: find more and make him fix them! [20:10:24] (03CR) 10Chad: [C: 032] Wrap updateOneSearchIndexConfig in top level catch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88138 (owner: 10Manybubbles) [20:10:36] Reedy: She can't, she's just passed out [20:10:52] (03Merged) 10jenkins-bot: Wrap updateOneSearchIndexConfig in top level catch [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88138 (owner: 10Manybubbles) [20:10:52] * Reedy kicks Isarra [20:10:57] Welcome to the wonderful world of Isarra randomness [20:11:11] * Isarra throws centralauth at Reedy [20:11:13] . [20:11:51] Seriously, though, I think I've kind of had it with wikis for the time being. How they can be this difficult, annoying, bothersome, explosive, and downright contrary is beyond me, but... [20:12:23] But maybe legoktm can finish this last little bit for me while I go kill myself with a shovel. [20:12:29] nooo [20:12:30] :| [20:12:39] there would be sadness [20:13:51] (03CR) 10Chad: [C: 032] Tests for proper prefix: implementation. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88210 (owner: 10Manybubbles) [20:13:53] (03Merged) 10jenkins-bot: Tests for proper prefix: implementation. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88210 (owner: 10Manybubbles) [20:15:23] Vodka, then. I'll use vodka. [20:15:51] Actually maybe I should stick to mediawiki. It at least doesn't stick really pointy needles in my thumb. [20:16:04] vodka does? [20:17:19] No, that plant over there did. Getting up is dangerous. Staying right here with the vodka and the mediawiki is safe. [20:17:53] (03PS1) 10Tpt: Improve image transformation parameter normalisation [extensions/ProofreadPage] (pagePagesRefactoring) - 10https://gerrit.wikimedia.org/r/88216 [20:18:12] Isarra: Vodka and MediaWiki could be a cool name for a drink [20:21:20] Let's do it. [20:21:40] Or something. [20:23:27] (03PS1) 10Tpt: (bug 55439) Fix an error when an image has an unknown media type [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/88217 [20:23:53] (03PS1) 10Foxtrott: Rearrange header elements; align with changes to Bootstrap extension [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88218 [20:24:36] (03CR) 10Foxtrott: [C: 032 V: 032] Rearrange header elements; align with changes to Bootstrap extension [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88218 (owner: 10Foxtrott) [20:25:32] Isarra: ignoring the fact that zuul cant handle release branches apparently -- apply https://gerrit.wikimedia.org/r/#/c/88219/ [20:25:35] (03CR) 10Chad: [C: 032] Replace prefix: implementation. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88209 (owner: 10Manybubbles) [20:25:38] (03Merged) 10jenkins-bot: Replace prefix: implementation. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88209 (owner: 10Manybubbles) [20:26:11] not sure what the procedure is on if I can +2 them myself [20:26:26] actually; Reedy, want to do some CR? :D [20:30:52] (03PS2) 10Ori.livneh: Remove HTTPS support detection [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88191 [20:31:23] greg-g: I don't really have anyone to review that ^. could you? It just deletes code. [20:31:39] I like deleting [20:31:46] heh [20:33:05] ori-l: I don't feel comfortable giving +2, but I can +1 [20:33:15] I mean... lemme see one sec [20:34:50] <^d> ori-l: Less code is more code. [20:35:21] what about LESS code? [20:35:43] <^d> I wouldn't know, LESS is freaky CSS stuff. [20:35:45] (03CR) 10Yuvipanda: [C: 032] Remove HTTPS support detection [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88191 (owner: 10Ori.livneh) [20:35:49] <^d> :) [20:35:56] ori-l: why can't I find MediaWikiEvents in git.wikimeida? [20:35:57] ori-l: no jenkins? [20:36:00] spell correctly [20:36:04] greg-g: because it's WikimediaEvents [20:36:06] greg-g: WikimediaEvents :P [20:36:15] also, because we just renamed it from 'CoreEvents' [20:36:43] (03CR) 10Yuvipanda: [V: 032] Remove HTTPS support detection [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88191 (owner: 10Ori.livneh) [20:36:46] ahhhhhhhhhhhhh [20:36:47] x2 [20:37:01] ahhhhhhhhhhhhh ahhhhhhhhhhhhh ? [20:37:29] or... ahhhhhhhhhhhhhhhhhhhhhhhhhh? [20:37:39] one: right name [20:37:44] <^d> ori-l: WHAT IF I WANT EVENTS ON MY WIKI? [20:37:48] two: actual still in use on git.wikimedia name [20:37:56] ^d: no events for you [20:37:58] <^d> :( [20:38:10] git clone wmf:mediawiki/extensions/WikimediaEvents ftw! [20:38:19] ^d: superm401 suggested adding a note to the README encourage reuse for exactly that reason [20:38:27] which I did [20:38:53] effing yuvi reviewed before I could [20:38:55] <^d> I know I'm crazy and you guys are gonna tell me to lay off the crack.... [20:38:59] but... [20:39:07] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [20:39:08] <^d> How about we not call it WikimediaFoo if we're actually encouraging reuse? [20:39:08] (03PS1) 10Legoktm: Fix phpdoc comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88222 [20:39:10] (03PS7) 10Krinkle: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 [20:39:19] (03CR) 10Krinkle: "Rebased to resolve conflict." [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [20:39:28] (03CR) 10Krinkle: "Rephrased release note." [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [20:39:36] RoanKattouw: any time :) https://gerrit.wikimedia.org/r/#/c/81884/ [20:39:37] ^d: reuse? i think your in the wrong channel :P (i kid) [20:39:47] ^d: well, it had upload.wikimedia.org hardcoded and stuff :) [20:40:03] <^d> ebernhardson: Yeah. We should all /part and go back to #mediawiki like the old days before this lame channel existed. [20:40:05] <^d> :) [20:40:09] (03PS2) 10Legoktm: Fix phpdoc comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88222 [20:40:17] (03CR) 10jenkins-bot: [V: 04-1] Fix phpdoc comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88222 (owner: 10Legoktm) [20:40:23] wat [20:40:41] wtf??? [20:40:55] oh [20:41:34] ^d, well most stuff is still supposed to be in the extensions (e.g. GuidedTour, Thanks, etc.) [20:41:53] This is only for stuff that doesn't make sense there for some reason, e.g. because it's in core. [20:41:57] As far the name: [20:42:02] 1. I couldn't think of a better one. [20:42:25] 2. It is somewhat Wikimedia-specific (e.g. who else is doing a huge transition to SSL and needs analytics for that). [20:42:29] greg-g: so -- I'm somewhat in the same position as ori-l is in -- I don't have a reviewer this week for centralnotice (adam is on vacation) -- want to review two backports for me? [20:42:35] <^d> Naming is hard yo. [20:42:41] However, it *is* fully FOSS, and anyone can use it. [20:42:42] (03PS3) 10Legoktm: Fix phpdoc comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88222 [20:42:46] Which is why I bugged ori-l about that. [20:42:58] superm401: I think you were right to; just giving credit [20:43:10] ^d: "There are only two hard things in Computer Science: cache invalidation andnaming things." Phil Karlton [20:43:28] mwalker: I can review your stuff; add me [20:43:59] thanks ori-l! [20:44:00] mwalker: I thought the only two hard things were 'cache invalidation, naming things and off by one errors' [20:44:02] in your queue [20:44:08] (03CR) 10GWicke: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [20:44:12] <^d> I should rename CirrusSearch to MWSearchv5. [20:44:15] mwalker: linkies, but getting real live developers would be good, too :) [20:44:19] YuviPanda: I had a cacheinvalidation error there :) [20:44:37] mwalker: you're missing the off by one joke :P [20:44:51] ori-l, greg-g: there's two; the first one https://gerrit.wikimedia.org/r/#/c/88215/1 and the second one follows [20:45:25] mwalker: you have a knack for writing confidence inspiring commit messages [20:45:33] YuviPanda: I spose the better response would have been; my implementation of string retrieval does bounds checking? [20:45:49] greg-g: the problem with the first patch is that we moved the hook definitions around a lot [20:45:53] into different files [20:46:01] I did test it though [20:46:01] mwalker: What about the thing where it was causing update.php to fail? [20:46:28] mwalker: well, that's not string retreival. Array bounds checking might help, however... [20:46:29] Is that because I ran it already on the later version? >.> [20:46:50] no no; it's fixed by making the hook definition actually work [20:46:50] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [20:47:06] (03PS1) 10Legoktm: Only show Thanks links for public revisions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88223 [20:47:48] greg-g: I can also point you to where it's currently defined and you can see that the fix is the same; just in a different file [20:50:53] ori-l: it doesn't actually [20:51:01] there's a bug in zuul that prevents from creating the repo [20:51:16] oh [20:51:20] actually maybe it's correct in this case [20:51:50] ah crap [20:51:59] ori-l: do you know how to make it review into REL1_21? [20:52:13] it's currently trying to review into master [20:52:26] git push gerrit HEAD:refs/for/REL1_21 [20:52:31] instead of 'git review' [20:52:41] assuming the remote name is 'gerrit'; ymmv. [20:52:55] gotcha [20:53:50] (03PS3) 10Chad: Optimize in place reindexing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 (owner: 10Manybubbles) [20:53:59] mwalker: Also, 'git review REL1_21' works for that [20:54:01] And *really* [20:54:13] If your .gitreview doesn't already say defaultbranch=REL1_21, you should be concerned [20:54:29] <^d> And *really*, git review sucks :| [20:54:55] marktraceur: What kind of drink would a Vodka and MediaWiki be? [20:55:12] RoanKattouw: when we branch the REL branches; it apparently does not update the defaultbranch [20:55:12] * Isarra hugs ^d. [20:55:17] Isarra: Something fruitiful [20:55:25] <^d> Isarra: Vodka and MediaWiki? [20:55:27] Because there aren't enough fruity drinks in this world [20:55:27] <^d> That's called a Chad. [20:55:38] Isarra: something that makes your head hurt really bad the next morning [20:55:40] But mediawiki isn't very fruity. Or is that the point? [20:55:51] <^d> You underestimate how much of MediaWiki is vodka-induced. [20:55:56] mwalker: Those should have been updated; if they haven't, that's a bug [20:56:04] MatmaRex: How would it do that? [20:56:07] But it also means that you should check very carefully that you are indeed based on REL1_21 [20:56:24] Last time someone said that .gitreview had defaultbranch=master that was because they had based their commit on master [20:56:26] Isarra: i dunno. have you seen the surgeon general's warning on EditPage? [20:56:27] Isarra: I'm thinking it could basically be a vodka gimlet with sunflower petals [20:56:34] I just double checked -- git checkout gerrit/REL1_21 [20:56:48] hah [20:56:52] (03PS4) 10Legoktm: Fix phpdoc comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88222 [20:56:52] MatmaRex: There's... a warning? [20:56:53] and it points to the wrong place; unless headless checkouts dont update the dot files [20:57:01] Isarra: surgeon general's, yes. [20:57:04] marktraceur: heh. [20:57:15] * Isarra looks up gimlet. [20:57:26] RoanKattouw: that was the command I ran -- .gitreview points to the wrong place -- where should I file the bug [20:57:39] Hmm. [20:58:04] (03CR) 10Chad: [C: 032] "Works for me well locally. Let's get this in master and try it out on labs." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 (owner: 10Manybubbles) [20:58:05] (03Merged) 10jenkins-bot: Optimize in place reindexing. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88131 (owner: 10Manybubbles) [20:58:31] mwalker: Complain to Reedy? [20:58:35] <^d> Yeah complain to him. [20:58:48] <^d> It's not a bug except by the person who made the branch :) [20:59:26] I'm guessing we create REL branches by script? [20:59:30] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/b26cbfd830060e14f51294499d4d332c75bc37f0/.gitreview [20:59:34] Wonder when that broke [20:59:46] (03CR) 10Catrope: [C: 04-1] "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [21:00:16] before wmf18 [21:00:21] How come no one has noticed? [21:00:48] How did it break? [21:00:50] (03PS8) 10Krinkle: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 [21:00:52] no one does backports? [21:01:02] In what way? [21:01:06] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [21:01:08] What are the symptoms? [21:01:34] (03CR) 10Catrope: [C: 032] resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [21:01:35] when you try to use git-review on backports; by default it commits to master instead of the REL branch [21:01:46] Looks more like someone reverted it [21:01:52] unintentionally or otherwise [21:01:55] Still done in https://git.wikimedia.org/commit/mediawiki%2Fcore.git/8a44ff51a7e039d344057267f01e96f2966440f9 [21:01:59] Isarra: symptom is on the REL branch; your .gitreview file will point to master [21:02:09] mwalker: DYK you can now backport from within the Gerrit web UI if there are no conflicts? [21:02:16] >>< [21:02:16] Isarra: SyntaxError: Unexpected token < [21:02:18] oh really!? [21:02:18] >.< [21:02:22] RoanKattouw: how? [21:02:26] mwalker: Cherry Pick To button [21:02:30] 0.0 [21:02:36] You make that sound like it's a new feature ;) [21:02:43] It's somewhat recent [21:02:52] https://git.wikimedia.org/blobdiff/mediawiki%2Fcore.git/8a44ff51a7e039d344057267f01e96f2966440f9/.gitreview [21:02:54] <^demon> Like...5 upgrades ago. [21:02:54] I've been using it a lot ever since it was introduced [21:02:57] The change is visibly comitted there [21:03:05] <^demon> RoanKattouw: You're late to the party [21:03:25] His invitation was stolen by a magpie. [21:03:40] magic! [21:03:42] I love it [21:05:02] * wmf/1.22wmf20 [21:05:02] reedy@ubuntu64-web-esxi:~/git/mediawiki/core$ cat .gitreview [21:05:02] [gerrit] [21:05:02] host=gerrit.wikimedia.org [21:05:02] port=29418 [21:05:04] project=mediawiki/core.git [21:05:07] defaultbranch=wmf/1.22wmf20 [21:05:09] defaultrebase=0 [21:05:11] RESOLVED WORKSFORME [21:05:30] And also https://git.wikimedia.org/blob/mediawiki%2Fcore.git/f21247fa34a0333c3b11d7e8c2785d8b05ad2657/.gitreview [21:05:36] (03Merged) 10jenkins-bot: resourceloader: Support hashes as cache invalidation trigger [core] - 10https://gerrit.wikimedia.org/r/81884 (owner: 10Krinkle) [21:05:55] Reedy: is that doing the same thing for extensions? [21:06:01] is what? [21:06:12] doing what? [21:06:27] Reedy: REL1_21 [21:06:29] updating the .gitreview file to the REL branch for extensions? [21:06:30] Why is it so easy, after having all these ideas and brilliant plans, to wind up lost up parser.php without a paddle and vodka is the only way out? [21:06:42] No [21:06:46] That's nothing to do with me [21:07:08] do you know what/who creates REL branches for extensions then? [21:07:10] (03PS3) 10Bsitu: Add style to new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 [21:07:12] (03PS10) 10Bsitu: [WIP] New design [extensions/Flow] - 10https://gerrit.wikimedia.org/r/86856 (owner: 10Matthias Mullie) [21:07:32] https://git.wikimedia.org/history/mediawiki%2Ftools%2Frelease.git/de1ea6237b8b8bca0cfd28b8b84ce866e99d86bc/make-extension-branches [21:07:35] Blame Krinkle [21:08:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Trivial." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 (owner: 10Bsitu) [21:08:13] The code doesn't even attempt to fix it [21:08:18] * mwalker blames Krinkle! :) [21:08:32] I can attempt to patch it; unless you want to do it reedy [21:09:03] Should be trivially done I think.. [21:09:28] before the push, something like I've got in make-wmf-branch [21:09:28] <^demon> That should be the responsibility of whoever cuts the REL1_nn branches. [21:09:38] <^demon> :) [21:09:39] https://git.wikimedia.org/blob/mediawiki%2Ftools%2Frelease.git/de1ea6237b8b8bca0cfd28b8b84ce866e99d86bc/make-extension-branches%2Fmake-extension-branches [21:10:08] Haha [21:10:17] (03PS1) 10Yaron Koren: Version 0.4 [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/88229 [21:10:18] mwalker: You can almost just copy paste all the code from make-wmf-branch [21:10:46] <^demon> Maybe we should write this as a library. [21:10:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Heh, this is silly." [core] - 10https://gerrit.wikimedia.org/r/88197 (owner: 10Krinkle) [21:10:53] <^demon> WikiBranchCreatorLibBase [21:11:30] 10 lines maybe [21:11:36] ^demon: Might need 2 extensions [21:12:19] ori-l: ok; second attempt: https://gerrit.wikimedia.org/r/#/c/88227/ and https://gerrit.wikimedia.org/r/#/c/88228/1 [21:12:43] (03CR) 10Brion VIBBER: "What's the the prepending of "./" to a relative URL? That sounds.... nasty." [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [21:12:47] mwalker: And of course, a cleanup script would also be nice (though, not necesserily) [21:12:51] the reason the unit tests are failing on the updater is because we did not yet, at this point, have a test compatible DB [21:12:52] mwalker: it still doesn't need to be an array :P [21:13:03] true; but that's how the code currently is [21:13:16] oh no [21:13:19] I'm smoking crack [21:13:22] hang on [21:13:35] CC-CRACK-SA [21:13:38] Time consuming hobby, mwalker [21:13:40] (03Merged) 10jenkins-bot: mediawiki.Title: Fix weird

in constructor description [core] - 10https://gerrit.wikimedia.org/r/88197 (owner: 10Krinkle) [21:15:01] ori-l: ok! moar correctness [21:15:09] (03PS4) 10Bsitu: Add style to new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 [21:15:26] (03PS4) 10MaxSem: Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 [21:15:28] Krinkle, would you happen to know how "element == this" can ever possibly equate to false in a $.each callback? [21:15:38] evaluate to* [21:16:42] (03CR) 10Brion VIBBER: [C: 04-1] "Reviewing -1 per existing inline discussion: the paths relative to "./" are going to be wrong and need to be either replaced with a full U" [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [21:16:47] (03PS1) 10Manybubbles: Add cleanup to be used around forking. [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/88230 [21:17:29] (03CR) 10Manybubbles: "This is required for one of the commits we've merged to master. I forgot to submit it earlier!" [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/88230 (owner: 10Manybubbles) [21:18:42] (03CR) 10jenkins-bot: [V: 04-1] Make TOC hideable [core] - 10https://gerrit.wikimedia.org/r/80578 (owner: 10MaxSem) [21:18:50] (03CR) 10Chad: [C: 032] Add cleanup to be used around forking. [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/88230 (owner: 10Manybubbles) [21:19:33] (03PS1) 10Foxtrott: Some more tweaks to the page header elements to resize (more) graceful [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88232 [21:19:38] (03CR) 10MaxSem: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [21:20:54] Reedy: possibly a related bug -- when we branch WMF branches -- we do not copy over any local security patches in extensions [21:21:01] (03PS2) 10Foxtrott: Some more tweaks to the page header elements to resize (more) graceful [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88232 [21:21:02] where would that happen? [21:21:55] (03PS5) 10Bsitu: Add style to new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/87637 [21:22:16] (03CR) 10Foxtrott: [C: 032 V: 032] Some more tweaks to the page header elements to resize (more) graceful [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88232 (owner: 10Foxtrott) [21:22:17] (03CR) 10Brion VIBBER: "A more general issue with using URLs here is that additional information (knowledge of the local wiki's $wgArticlePath setting) is require" [core] - 10https://gerrit.wikimedia.org/r/85926 (owner: 10MarkTraceur) [21:22:18] mwalker: That's an ongoing issue [21:23:00] (03CR) 10Chad: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/87281 (owner: 10Chad) [21:23:49] (03PS1) 10Legoktm: Remove deprecated call to Job::insert [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88233 [21:23:59] (03CR) 10Chad: [V: 032] Add cleanup to be used around forking. [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/88230 (owner: 10Manybubbles) [21:26:09] (03CR) 10Yaron Koren: [C: 032 V: 032] Version 0.4 [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/88229 (owner: 10Yaron Koren) [21:27:48] ^d: just to confirm, action=opensearch hits the search backend, right? current one or cirrus (when it turns up) [21:28:17] <^d> action=opensearch hits the primary. [21:28:31] ^d: the primary search backend, right? [21:28:32] ok [21:28:34] <^d> Yeah [21:28:54] <^d> The hook for prefix searching kind of sucks, otherwise I would've added srbackend support to it. [21:29:20] hmm, that's okay. it'll eventually switch anyway [21:35:05] [21:36:02] (03CR) 10Yuvipanda: [C: 032] Fix phpdoc comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88222 (owner: 10Legoktm) [21:36:04] (03Merged) 10jenkins-bot: Fix phpdoc comment [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/88222 (owner: 10Legoktm) [21:36:46] http://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg71730.html mw.Title reborn [21:36:50] superm401: [21:37:10] Krinkle: IT'S ALIIIIIIVE [21:37:11] (03CR) 10Yuvipanda: [C: 032] Remove deprecated call to Job::insert [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88233 (owner: 10Legoktm) [21:37:16] (03Merged) 10jenkins-bot: Remove deprecated call to Job::insert [extensions/Echo] - 10https://gerrit.wikimedia.org/r/88233 (owner: 10Legoktm) [21:37:18] legoktm: done [21:37:22] ty :D [21:37:32] Krinkle, thanks for the write-up. [21:43:42] (03PS1) 10Mwalker: Update .gitreview When Branching [tools/release] - 10https://gerrit.wikimedia.org/r/88236 [21:44:01] (03CR) 10Mwalker: [C: 04-2] "this is obviously not going to wrok" [tools/release] - 10https://gerrit.wikimedia.org/r/88236 (owner: 10Mwalker) [21:44:05] ori-l: ping [21:44:18] Krinkle: in a meeting; will ping you in a bit [21:44:23] ori-l: k [21:44:53] ori-l: i'm looking for the script running periodically that measures differnet wikis performance and module load size via phantomjs [21:45:39] ori-l: looking to perhaps re-use or extend that to also look for 1) uncaught exceptions thrown by some js, 2) monitor mw.log.deprecate things, 3) extend to more or all wikis [21:45:58] (03CR) 10Yuvipanda: [C: 031] "(2 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [21:46:01] though these 3 things are probably more towards continuous integration than monitoring. so probably re-use not extend, and run from jenkins perhaps. [21:46:06] legoktm: will merge after those [21:46:18] * legoktm looks [21:46:46] basically I want to know about wikis that have broken site scripts and/or on which wikis we deployed something that is broken on every page. [21:47:01] as well as 404 and other HTTP errors in the network stack [21:47:34] fucking powercuts [21:47:36] grrrrrrr [21:47:48] 03:16 YuviPanda: legoktm: I think the comment about 'newline' might just be a CSS issue on my browser :| [21:47:57] heh [21:48:09] i just put a draft comment that says "No, thats just gerrit being fucked up" [21:48:28] (03PS5) 10Legoktm: Maintenance for Drafts extension [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [21:48:32] heh, right [21:48:39] (03CR) 10Legoktm: "(2 comments)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [21:49:11] * siebrand mumbles something about many months old and abandoned patch sets being revived. [21:49:28] (03CR) 10Yuvipanda: [C: 032] "Could be worse." [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [21:49:49] (03CR) 10Yuvipanda: [V: 032] Maintenance for Drafts extension [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/29749 (owner: 10Siebrand) [21:49:54] legoktm: merged! [21:50:01] woot :D [21:50:07] now i want to re-arrange some stuff [21:50:11] heh [21:50:21] Special:Drafts is called Drafts.pages.php [21:50:26] That makes no sense >.> [21:50:35] there's Drafts.classes.php too [21:50:38] which also is ugh [21:50:42] oh yeah [21:50:49] there's a Draft class, and a Drafts class [21:51:15] should probably be their own files [21:51:23] they should be merged into one class [21:51:34] does lack of electricity make you want to punch people? [21:51:46] seems to do to me. [21:51:47] sometimes [21:51:52] https://gerrit.wikimedia.org/r/#/c/88151/ <-- what do you think about that? [21:51:57] i'm not sure that's the correct solution [21:52:10] there seems to be some kind of race condition where wgDraft isnt initialized properly or something. [21:52:14] hacky [21:52:17] very hacky [21:52:22] fix the actual problem :P [21:52:33] (03CR) 10Yuvipanda: [C: 04-1] "hacky. very hacky!" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88151 (owner: 10Legoktm) [21:52:35] :D [21:52:46] well, the whole thing needs to be re-written anyways [21:52:54] to not use sajax [21:52:57] lol [21:53:42] hearing a clock tick actually makes the 'lack of electricity' rage worse. [21:53:46] * YuviNoPower goes to make the clock stop [21:54:04] (03CR) 10Spage: [C: 04-1] "(4 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 (owner: 10Mattflaschen) [21:54:17] (03PS2) 10Mwalker: Update .gitreview When Branching [tools/release] - 10https://gerrit.wikimedia.org/r/88236 [21:54:46] that [21:54:48] 's better [21:55:14] (03PS1) 10Huji: (bug 55446) Commented out section of the CSS in Chameleon skin is removed [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88237 [21:55:49] (03PS3) 10Mwalker: Update .gitreview When Branching [tools/release] - 10https://gerrit.wikimedia.org/r/88236 [21:56:35] (03CR) 10Krinkle: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson) [21:56:51] (03PS4) 10Mwalker: Update .gitreview When Branching [tools/release] - 10https://gerrit.wikimedia.org/r/88236 [21:57:22] Reedy_, Krinkle; apologies for the gerrit spam from 88236 -- it had WS errors that I didn't notice until after I added y'all [21:58:59] (03PS1) 10Legoktm: Rename functions to standard names [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88238 [21:59:00] * legoktm calms the RagePanda  [21:59:02] ^ [21:59:03] (03PS1) 10Huji: (bug 55445) Edit box is too narrow in Chameleon skin [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88239 [21:59:29] my grep showed that nothing should have broken [21:59:47] (03PS5) 10MarkTraceur: Pull data from API, load title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 [22:00:06] (03CR) 10Yuvipanda: [C: 032 V: 032] Rename functions to standard names [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88238 (owner: 10Legoktm) [22:00:24] legoktm: well, the extension itself is fairly broken :) [22:00:26] so [22:00:28] :D [22:00:54] hasharCall: once you're no longer busy, could you enable php lint and jslint tests (nonvoting) for the Drafts extension? [22:01:27] legoktm: getting to bed. Can you fill in a bug against Wikimedia > Continuous integration please? [22:01:32] (03PS6) 10MarkTraceur: Pull data from API, load title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 [22:01:33] sure [22:01:35] legoktm: will do tomorrow morning [22:01:42] thanks :) [22:01:50] (03PS7) 10MarkTraceur: Pull data from API, load title [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86063 [22:02:02] legoktm: you can even attempt to add them by reading https://www.mediawiki.org/wiki/Continuous_integration/Tutorial/Adding_basic_checks :-) [22:02:33] legoktm: err sorry https://www.mediawiki.org/wiki/Continuous_integration/Tutorial/Adding_a_MediaWiki_extension [22:02:56] (03PS1) 10Huji: (bug 54930) Labels for checkboxes/radiobuttons should appear inline [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88240 [22:03:00] i'll just let you do it :P [22:03:04] (03PS2) 10Foxtrott: (bug 55445) Edit box is too narrow in Chameleon skin [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88239 (owner: 10Huji) [22:03:09] legoktm: sure :-) [22:03:29] (03CR) 10Foxtrott: [C: 032 V: 032] (bug 55445) Edit box is too narrow in Chameleon skin [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88239 (owner: 10Huji) [22:05:32] (03PS2) 10Foxtrott: (bug 55446) Commented out section of the CSS in Chameleon skin is removed [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88237 (owner: 10Huji) [22:06:00] (03CR) 10Foxtrott: [C: 032 V: 032] (bug 55446) Commented out section of the CSS in Chameleon skin is removed [skins/chameleon] - 10https://gerrit.wikimedia.org/r/88237 (owner: 10Huji) [22:06:24] ^d: i'll brt [22:07:43] <^d> ori-l: Okie dokie [22:08:26] (03CR) 10Reedy: [C: 032] "Probably should create a script to fix this up on extension branches that already exist, but that's a different issue!" [tools/release] - 10https://gerrit.wikimedia.org/r/88236 (owner: 10Mwalker) [22:08:28] (03Merged) 10jenkins-bot: Update .gitreview When Branching [tools/release] - 10https://gerrit.wikimedia.org/r/88236 (owner: 10Mwalker) [22:08:33] (03PS1) 10Legoktm: Use User::matchEditToken [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88243 [22:10:29] (03CR) 10Spage: [C: 032] "Works for me, thanks for the regular/VE split. VE in Flow was a development spike, it's very likely to be turned off for initial roll-out" [qa/browsertests] - 10https://gerrit.wikimedia.org/r/84772 (owner: 10Cmcmahon) [22:11:30] (03PS1) 10Ori.livneh: Log VisualEditorDOMRetrieved latency data via EventLogging [extensions/WikimediaEvents] - 10https://gerrit.wikimedia.org/r/88244 [22:13:32] (03PS1) 10Legoktm: Use more specific Title in phpdoc [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88245 [22:14:45] (03CR) 10MarkTraceur: "Deprecated?" [core] - 10https://gerrit.wikimedia.org/r/86319 (owner: 10Bartosz Dziewoński) [22:15:25] MatmaRex: I'd suggest porting them to FormSpecialPage rather than continuing the haxx [22:15:42] (03CR) 10Bartosz Dziewoński: "Deprecated, as of the unmerged dependency ;) Soft-deprecated since 1.18." [core] - 10https://gerrit.wikimedia.org/r/86319 (owner: 10Bartosz Dziewoński) [22:15:58] marktraceur: the haxx are not that bad [22:16:16] and formspecialpage is probably not versatile enough [22:16:18] (and htmlform too) [22:16:25] doesn't mean it can't be fixed, of course [22:16:38] but that's not something i want to struggle to get merged before 1.22 [22:16:44] (not, in fact, struggle to write) [22:17:23] (03PS1) 10Chad: Make default host localhost [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/88247 [22:20:11] i'm off to sleep. nothing like a uni schedule that stretches five lectures over 13 hours, eh [22:20:50] MatmaRex: Is there discussion about the deprecation somewhere? [22:23:03] (03PS1) 10Plavi: Fixed Hotcat test - plural/singular for Categories link [qa/browsertests] - 10https://gerrit.wikimedia.org/r/88249 [22:23:54] marktraceur: none i know of, to be honest [22:24:13] marktraceur: i discussed this briefly on irc when i discovered the comment that says "IContextSource available since 1.18, will become compulsory in 1.18." (sic) [22:24:20] Ahhh. [22:24:33] I remember that conversation [22:24:47] then went ahead and submitted patches [22:24:51] AaronSchulz: Ping on https://gerrit.wikimedia.org/r/#/c/86883/. I got a +1 from Parent5446 with patch set #13. [22:25:00] anyway i'm off. mail me if i'm needed or something [22:25:09] good night [22:25:20] AaronSchulz: Hoping what I did there (adding explicit join) didn't hurt the performance [22:26:16] I don't see the point of it (it's slightly more code), but it shouldn't hurt [22:27:52] What's the path to +2? [22:28:00] (03PS1) 10Legoktm: Replace sajax with an API module [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88250 [22:28:44] AaronSchulz: in local testing I ran into https://bugs.php.net/bug.php?id=65704 [22:29:32] ^d: I +2d https://gerrit.wikimedia.org/r/#/c/84772/ and it didn't merge. Is that because https://gerrit.wikimedia.org/r/#/admin/projects/qa,access doesn't have a "Push Merge Commit" setting? [22:30:03] <^d> No. [22:30:09] <^d> It probably doesn't have auto submit. [22:30:32] bd808: I'll get to that next [22:30:40] * AaronSchulz is about to commit [22:31:54] AaronSchulz: thx. Then I'll have to figure out how to actually run it in beta I guess :) [22:35:27] ^d: aha it has a [Submit Patch Set #7] button. I've got used to only clicking the gerrit [Review] button. [22:35:32] (03PS1) 10Aaron Schulz: Added Special:MWOAuthListConsumers page [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88251 [22:36:27] bd808: so is the $wgHTCPRouting stuff actually helpful? What did Leslie say? [22:38:27] AaronSchulz: As I recall she though it may be possible to address packets directly at hooft [22:38:36] (03PS2) 10Legoktm: Replace sajax with an API module [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88250 [22:38:36] I don't think it's been tried yet [22:38:37] ori-l: may I poke you to point out my foolishness again in https://gerrit.wikimedia.org/r/#/c/88227/ and https://gerrit.wikimedia.org/r/#/c/88228/ ? :D [22:41:19] bd808: I just realized adding page_latest=rev_id to the WHERE would make SEEN cache unnecessary [22:41:26] * AaronSchulz feels silly [22:42:05] Yea, that was the point of page_latest=rev_id in the first query [22:42:27] Can that go back in the query and not kill the performance? [22:42:32] did the old query also have rev_page=page_id [22:42:53] No, it was joining on page_latest [22:43:01] yeah, that would be slow :) [22:43:02] I think... [22:43:06] but having both is fine [22:43:50] huh, it had 'page_id = rev_page' to [22:45:08] *too [22:45:10] AaronSchulz: It looks like I took that out in patch set #2 for some reason [22:46:49] bd808: I'll just merge after that and have this done with [22:47:51] AaronSchulz: "after that"? What should I be fixing? [22:48:24] not really a fix, just a bit cleaner, using page_latest [22:49:21] OK. So roll the sql back to basically what was in patch set #1 and take out the dup counter stuff? [22:49:58] bd808: no, just add that to the WHERE and remove the LRU stuff [22:50:24] AaronSchulz: okey doke. [22:50:25] all the page loop stuff and all is fine [22:54:55] (03CR) 10Krinkle: "Caused by I2be09a7a8e7ee actually." [core] - 10https://gerrit.wikimedia.org/r/85920 (owner: 10Jdlrobson) [22:55:10] bd808: hopefully the file purge script CR will go more expediently [22:55:39] (03CR) 10Krinkle: "(2 comments)" [core] - 10https://gerrit.wikimedia.org/r/87165 (owner: 10Jdlrobson) [22:58:52] (03PS1) 10Aaron Schulz: Avoid using stilly "wp" prefix in form [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/88252 [23:01:45] (03PS2) 10Mattflaschen: Fixes of current logging, and cleanup of out of date code [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 [23:01:53] (03PS1) 10Krinkle: Follow-up 99c92a87fc: Fix vector-animateLayout breakage [core] - 10https://gerrit.wikimedia.org/r/88254 [23:02:13] gwicke: it hangs? Does curl_multi_select() have a timeout given? [23:02:29] (03PS3) 10Legoktm: Replace sajax with an API module [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88250 [23:02:40] (03CR) 10Mattflaschen: "(4 comments)" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 (owner: 10Mattflaschen) [23:03:54] AaronSchulz: it hangs, and no timeout helps [23:04:01] AaronSchulz: only downgrading libcurl helped [23:04:10] (03PS14) 10BryanDavis: Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [23:04:27] Krinkle: want me to fix that patch set now? [23:04:34] AaronSchulz: hang means an infinite loop in this case [23:04:50] (Krinkle since i broke it) [23:05:08] AaronSchulz: curl_multi_select never blocks or returns -1 (normally signals a timeout) [23:05:25] jdlrobson: yes, since I didn't know how to fix it with less (the quotation of arguments is tricky) [23:05:33] but then I figured it out and wrote a patch [23:05:35] Krinkle: on it now - not sure went wrong there sorry [23:05:43] https://gerrit.wikimedia.org/r/#/c/88254/ [23:05:50] i've been trying to work on too many patch sets at the same time [23:05:57] ori-l, are you going to remove https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FCoreEvents.git ? [23:07:02] (03CR) 10BryanDavis: "Aaron realized that the duplicate detection code was not needed if we put the `page_latest = rev_page` condition back into the query. This" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [23:07:33] * bd808 crosses fingers that patch set #14 is the lucky charm [23:11:28] superm401: yes, on my todo [23:11:43] (03PS1) 10Chad: Adding CirrusSearch role [vagrant] - 10https://gerrit.wikimedia.org/r/88255 [23:11:45] Okay, sounds good [23:12:43] (03CR) 10Mattflaschen: "Parent5446, you have +2 here, right? I tested, so you can +2 if the code looks solid." [extensions/Annotator] - 10https://gerrit.wikimedia.org/r/87704 (owner: 10Mattflaschen) [23:13:47] (03CR) 10Ori.livneh: [C: 032] "\o/" [vagrant] - 10https://gerrit.wikimedia.org/r/88255 (owner: 10Chad) [23:13:50] (03Merged) 10jenkins-bot: Adding CirrusSearch role [vagrant] - 10https://gerrit.wikimedia.org/r/88255 (owner: 10Chad) [23:17:10] (03CR) 10Mattflaschen: "Okay, let me re-review and test (I don't think I tested the version I +1'ed either, which another reason I didn't +2)." [core] - 10https://gerrit.wikimedia.org/r/65867 (owner: 10Parent5446) [23:19:59] (03CR) 10Ori.livneh: "(1 comment)" [vagrant] - 10https://gerrit.wikimedia.org/r/88000 (owner: 10Legoktm) [23:20:43] ori-l: lemme fix that [23:20:49] how come it didnt throw an error? [23:21:24] (03PS1) 10Jdlrobson: Regression: Fix transition mixin arguments [core] - 10https://gerrit.wikimedia.org/r/88256 [23:21:35] (03PS1) 10Legoktm: Show drafts after deletion and undeletion [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/88257 [23:21:49] ^ Krinkle [23:22:20] jdlrobson: you did see my patch set 20 minutes ago? I linked it and added you as reviewer [23:22:38] Krinkle: jdlrobson: yes, since I didn't know how to fix it with less (the quotation of arguments is tricky) [23:22:38] 01:05 Krinkle: but then I figured it out and wrote a patch [23:22:39] 01:05 Krinkle: https://gerrit.wikimedia.org/r/#/c/88254/ [23:22:47] Krinkle: nope sorry missed all that [23:22:58] (03PS1) 10Ori.livneh: Fix syntax error introduced in Id6c2d79d62 [vagrant] - 10https://gerrit.wikimedia.org/r/88258 [23:23:06] jdlrobson: Hm... ';' ? [23:23:09] Krinkle: as you can see in my patch the solution slightly cleaner :) [23:23:19] ^ legoktm, fyi [23:23:20] The ';' is that a feature? [23:23:22] Krinkle: yeh if a mixin has a ; present it assumes that as the delimiter [23:23:24] (03PS1) 10Legoktm: Syntax error: MediaWiki --> Mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/88259 [23:23:26] http://leafo.net/lessphp/docs/#mixin_arguments [23:23:29] ori-l: heh ^ [23:23:53] legoktm: I'll merge yours; don't abandon it. [23:24:02] Krinkle: specifically "If a ; appears anywhere in the argument list, then it will be used as the argument delimiter, and all commas we be used as part of the argument values." [23:24:03] yours had a better commit summary though [23:24:51] jdlrobson: this function will only ever take 1 argument, so the @arguments with ; seems sementically incorrect [23:25:02] and misleading, what will it do if you really do pass multiple arguments? [23:25:11] it would join them by space still, whcih is undesireable [23:25:17] I think neither is ideal though [23:25:28] I'll let ori-l decide what is more less-like. [23:25:57] Krinkle: i'm not sure i follow [23:25:59] (03PS2) 10Ori.livneh: Syntax error: MediaWiki --> Mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/88259 (owner: 10Legoktm) [23:26:07] this is valid less :) [23:26:15] (03CR) 10Ori.livneh: [C: 032] Syntax error: MediaWiki -> Mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/88259 (owner: 10Legoktm) [23:26:18] (03Merged) 10jenkins-bot: Syntax error: MediaWiki -> Mediawiki [vagrant] - 10https://gerrit.wikimedia.org/r/88259 (owner: 10Legoktm) [23:26:26] :) [23:26:31] jdlrobson: The .transition is defined as (...) and using @arguments [23:26:41] Krinkle: sure and i'm not touching that [23:26:46] jdlrobson: But you shouldn't pass it more than one argument, right [23:26:57] jdlrobson: if one does, then that is an error, as shown by the problem at hand [23:27:01] but in the usage if you put a ; it doesn't treat the ',' as an argument divider [23:27:26] (03CR) 10Spage: [C: 032] "Looks good. I didn't check everything but a page with ?gettingStartedReturn=true and a control (sees Special:GS) both logged without compl" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 (owner: 10Mattflaschen) [23:27:30] (03Merged) 10jenkins-bot: Fixes of current logging, and cleanup of out of date code [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/87665 (owner: 10Mattflaschen) [23:27:37] jdlrobson: so if you keep that and then require us all to use ;, we're working around it and still keeping the multiple-arguments signature . Which means yiu're now opening it up to .transition(foo, bar; baz, quux) [23:28:01] jdlrobson: yes, so then waht it the point of supporting multiple arguments? there should only ever be one, a second one woudl be a typo [23:28:10] ori-l: if you have some time, could you review https://gerrit.wikimedia.org/r/#/c/87646/ for massmessage? [23:28:10] (03PS2) 10Jdlrobson: Regression: Fix transition mixin arguments [core] - 10https://gerrit.wikimedia.org/r/88256 [23:28:22] I'd rather have less throw an error for passing a second arguemnt that shouldn't exist then silently having ... and @arguments join it by space. [23:28:25] Krinkle: I don't have any pretensions of being the Lord of LESS; you have more experience than me in enforcing code conventions, so you should feel free to call it one way or another. [23:28:34] (03CR) 10Jdlrobson: "Also see I18e8c86824bca2fd3c3197c1c471cd6acbd8e703 which I personally think is the cleaner way to do this." [core] - 10https://gerrit.wikimedia.org/r/88254 (owner: 10Krinkle) [23:28:39] I don't know the details of this particular case; haven't been following the conversation. [23:28:43] k [23:28:49] Krinkle: but why reinvent the wheel [23:28:53] LESS supports this so why not use it? [23:29:25] (03CR) 10Mattflaschen: [C: 032] Update layout.yaml to reflect extension rename (CoreEvents -> WikimediaEvents) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88204 (owner: 10Ori.livneh) [23:29:33] jdlrobson: To be clear, we're doing 2 different things here, I don't think it makes sense to do both the things you do, one of them (the ; operator) seems possibly useful, but not the @arguments [23:29:41] (03Merged) 10jenkins-bot: Update layout.yaml to reflect extension rename (CoreEvents -> WikimediaEvents) [integration/zuul-config] - 10https://gerrit.wikimedia.org/r/88204 (owner: 10Ori.livneh) [23:30:00] jdlrobson: Know what I mean? There is no point in having .. in the definition there, it can only cause errors. [23:30:02] Krinkle: jgonera may have a view on all this [23:30:17] jdlrobson: massage time [23:30:42] jdlrobson: I'm not debating the style of ~'' vs. ;, That's a style choice that has no rational side, it's a matter of taste and we'll pick one and stick to it. [23:30:53] I'm debating the technical problems and error surpression of using @arguments. [23:31:43] .transition ( ... ) { transition: @arguments; } vs. .transition ( @val ) { transition: @val; } [23:31:59] they both do the same regardless of whether we use ; or ~''. Do you understand? [23:34:18] The difference is that the former mean that if somebody forgets to use the ';' or ~'' (like you did in the original commit), it will not throw an error but join it by space. [23:34:57] (03CR) 10Mattflaschen: [C: 032] Update make-wmf-branch to reflect extension rename (CoreEvents -> WikimediaEvents) [tools/release] - 10https://gerrit.wikimedia.org/r/88206 (owner: 10Ori.livneh) [23:35:01] (03Merged) 10jenkins-bot: Update make-wmf-branch to reflect extension rename (CoreEvents -> WikimediaEvents) [tools/release] - 10https://gerrit.wikimedia.org/r/88206 (owner: 10Ori.livneh) [23:35:11] (03Abandoned) 10Ori.livneh: Fix syntax error introduced in Id6c2d79d62 [vagrant] - 10https://gerrit.wikimedia.org/r/88258 (owner: 10Ori.livneh) [23:38:38] (03CR) 10Mattflaschen: [C: 04-1] "(1 comment)" [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88205 (owner: 10Ori.livneh) [23:40:07] bd808: you mean page_latest = rev_id :) [23:41:14] AaronSchulz: OMG. Fixing... [23:41:37] lol [23:42:04] (03CR) 10MarkTraceur: [C: 04-1] "(1 comment)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/86172 (owner: 10MarkTraceur) [23:42:44] bd808: seeing that always reminds me of https://en.wikipedia.org/wiki/Valley_girl [23:43:34] (03PS2) 10Ori.livneh: Update mediawiki-extensions.yaml to reflect extension rename (CoreEvents -> WikimediaEvents) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88205 [23:46:49] (03PS2) 10Krinkle: Make .transition mixin take only 1 value and fix usage [core] - 10https://gerrit.wikimedia.org/r/88254 [23:47:29] (03CR) 10Mattflaschen: [C: 032] Update mediawiki-extensions.yaml to reflect extension rename (CoreEvents -> WikimediaEvents) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88205 (owner: 10Ori.livneh) [23:47:59] (03Merged) 10jenkins-bot: Update mediawiki-extensions.yaml to reflect extension rename (CoreEvents -> WikimediaEvents) [integration/jenkins-job-builder-config] - 10https://gerrit.wikimedia.org/r/88205 (owner: 10Ori.livneh) [23:48:01] (03CR) 10Krinkle: "@Jdlrobson: I don't know if you're referring to the ~ style or the mixin argument. I could care less about the style of ~ or ;. My main pu" [core] - 10https://gerrit.wikimedia.org/r/88254 (owner: 10Krinkle) [23:48:51] (03Abandoned) 10Krinkle: Regression: Fix transition mixin arguments [core] - 10https://gerrit.wikimedia.org/r/88256 (owner: 10Jdlrobson) [23:50:07] jdlrobson: as for the ; style, we can do that still. [23:50:13] they're not mutually exclusive. [23:50:14] :) [23:50:22] Krinkle: so it sounds like we want a combination of the two? [23:50:37] (03PS15) 10BryanDavis: Add script to purge changed pages from cache [core] - 10https://gerrit.wikimedia.org/r/86883 [23:50:38] I've updated the commit summary [23:52:52] (03CR) 10BryanDavis: "(1 comment)" [core] - 10https://gerrit.wikimedia.org/r/86883 (owner: 10BryanDavis) [23:52:54] Krinkle: so i still have a preference for not using ~'..' e.g. .transition( margin-left 250ms, padding 250ms; ); but i think fixing the bug is more important. I think ~'..' is less user friendly to a less newbie [23:53:14] jgonera: do you have any preferences for either or? [23:53:19] or anyone else in the room? [23:53:46] Interesting, I was going to use ~'' as being more intuitive to a less newby (e.g. myself) [23:53:59] jdlrobson, I prefer your variant [23:54:07] well to me a semicolon always means end [23:54:08] since ; is a very small detail and looks like an error and if not an error, not obvious as being an argument separator. it is jus something at the end of the value [23:54:14] so it's different from foo(bar, ); [23:54:28] jdlrobson: maybe start a topic on the talk page of https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#Less ? [23:54:32] a comma intuitively means more (just referring to your commit message) [23:54:49] I suppose we have different intuitions, then. [23:54:52] hard to argue with [23:54:54] .transition( ~'margin-left 250ms, padding 250ms' ); could be confusing since ~ can mean sibling [23:55:39] jdlrobson: just to be clear, anything about ~ or ; with arguments related to general perception is going to be moot because we can and are going to use both [23:55:48] because they are for different situations and both will be inevitable [23:55:50] I think [23:56:04] but in the case of 1 argument, both are usable [23:56:22] in case of multiple, you'd always use ; [23:56:45] meh, no. that doens't make sense. you could also foo foo( ~'foo, x', ~'bar, y' ) [23:56:47] which is ugly [23:56:52] okay, let's use ; then [23:58:43] ok we should record this on coding conventions page [23:58:58] we can always change our minds later.. [23:59:05] one of the nice things about LESS making css cleaner :)